Timeline



Jan 27, 2006:

7:26 PM Changeset in webkit [12424] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Geoff.

  • ForwardingHeaders/JSLock.h: added
  • page/Page.cpp: (Page::~Page): In debug mode, when destroying the last page, 0 out m_mainFrame to destroy the very last frame and then garbage collect, so a GC happens at a time when the stack won't have references into the JS heap for the conservative GC to catch.
7:07 PM Changeset in webkit [12423] by mjs
  • 9 edits
    1 add in trunk/WebCore

Reviewed by Eric.

  • ForwardingHeaders/kjs/JSLock.h: Added.
  • bridge/mac/MacFrame.mm: (Plugin::Plugin): renamed from KWQPluginPart, make it able to store a view. (Plugin::view): And return the QWidget* view. (MacFrame::createPart): Use Plugin instead of KWQPluginPart, avoid setWidget. (MacFrame::setView): Don't use m_url directly so much, and use through d-> if needed. (MacFrame::userAgent): ditto (MacFrame::openURLFromPageCache): ditto
  • kwq/KWQObject.cpp: (QObject::inherits): Removed case for ObjectContents, which is not long for this world.
  • kwq/KWQObject.h:
  • page/Frame.cpp: (Frame::init): Don't pass parent() to FramePrivate, we can't possibly have one yet. (Frame::restoreURL): d->m_url, not m_url (Frame::didOpenURL): ditto (Frame::executeScript): ditto (Frame::receivedFirstData): ditto (Frame::begin): ditto (Frame::gotoAnchor): ditto (Frame::requestObject): ditto, plus only use Frame methods when we really have a Frame. (Frame::processObjectRequest): ditto, also get view() not widget(). (Frame::childFrame): remove excess spaces and pointless assert. (Frame::parentFrame): just call parent() (could probably remove this). (Frame::reparseConfiguration): d->m_url not m_url (Frame::canCachePage): ditto (Frame::updatePolicyBaseURL): ditto (Frame::scrollToAnchor): ditto (Frame::setName): set in FramePrivate (Frame::name): get from FramePrivate (Frame::setParent): similarly (Frame::parent): similarly (Frame::url): similarly
  • page/Frame.h:
  • page/FramePrivate.h: (FramePrivate::FramePrivate): Added m_parent, m_name and m_url.
  • page/FrameView.cpp: (FrameView::viewportMousePressEvent): Call frame directly instead of sending through QApplication. (FrameView::viewportMouseDoubleClickEvent): ditto (FrameView::viewportMouseMoveEvent): ditto (FrameView::viewportMouseReleaseEvent): ditto
  • page/ObjectContents.h: (ObjectContents::ObjectContents): Removed url, setParent, parent, name, setName, openURL, closeURL, widget, setWidget, event and customEvent methods, and corresponding fields. Add pure virtual view() method.
5:19 PM Changeset in webkit [12422] by darin
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Adele.

  • fast/events/related-target-expected.txt: Added.
  • fast/events/related-target.html: Added.
5:18 PM Changeset in webkit [12421] by darin
  • 4 edits in trunk/WebCore

Reviewed by Adele.

Test: fast/events/related-target.html

  • khtml/xml/NodeImpl.h:
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchMouseEvent): Added a relatedTarget parameter to a couple overloads.
  • page/FrameView.cpp: (FrameView::viewportMouseMoveEvent): Moved code to set prevMouseX/Y out of here and into dispatchMouseEvent, because it now handles mouseout and mouseover events, and that's what these globals are used for. This fixes DumpRenderTree to work properly with mouseout and mouseover (because it delivers only mouse down and up, no mouse move events). (FrameView::dispatchMouseEvent): Passed in the "other" node as the related target for mouseout and mouseover events. Also set prevMouseX/Y.
5:05 PM Changeset in webkit [12420] by eseidel
  • 2 edits in trunk/WebKitTools

2006-01-27 Eric Seidel <​eseidel@apple.com>

Reviewed by adele.

  • Scripts/run-webkit-tests: make new tests use absolute urls
3:41 PM Changeset in webkit [12419] by adele
  • 2 edits
    4 adds in trunk

LayoutTests:

Adding test for
<rdar://problem/4422624> REGRESSION: crash loading webmail.mac.com

  • fast/forms/input-no-renderer-expected.checksum: Added.
  • fast/forms/input-no-renderer-expected.png: Added.
  • fast/forms/input-no-renderer-expected.txt: Added.
  • fast/forms/input-no-renderer.html: Added.

WebCore:

Adding comment for added layout test.

3:06 PM Changeset in webkit [12418] by eseidel
  • 1 edit in trunk/WebCore/ChangeLog

Updated ChangeLog to mention layout tests landed with previous commits.

2:39 PM Changeset in webkit [12417] by adele
  • 1 edit in trunk/WebCore/ChangeLog

Updating ChangeLog with explanation of missing test case.

1:18 PM Changeset in webkit [12416] by tomernic
  • 1 edit in trunk/WebCore/ChangeLog

Updated ChangeLog to explain why my last commit did not include a test case.

2:52 AM Changeset in webkit [12415] by eseidel
  • 2 edits in trunk/WebKitTools

2006-01-27 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

make run-webkit-tests output total leaks count

  • Scripts/run-webkit-tests:
2:22 AM Changeset in webkit [12414] by hyatt
  • 76 edits
    2 moves
    7 deletes in trunk/WebCore

Fix for 6867. Rename QPixmap to Image and move it to platform/.
Eliminate QPaintDevice and QPaintDeviceMetrics completely, since
they aren't necessary.

Reviewed by anders

  • ForwardingHeaders/q3paintdevicemetrics.h: Removed.
  • ForwardingHeaders/qpaintdevice.h: Removed.
  • ForwardingHeaders/qpaintdevicemetrics.h: Removed.
  • ForwardingHeaders/qpixmap.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.mm: (MacFrame::fileWrapperForElement):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge reapplyStylesForDeviceType:]): (nowPrinting): (-[WebCoreFrameBridge elementAtPoint:]):
  • css/css_valueimpl.cpp: (WebCore::CSSPrimitiveValueImpl::computeLength): (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
  • css/css_valueimpl.h:
  • css/csshelper.cpp:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::initForStyleResolve): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement): (WebCore::convertToLength): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundXPosition): (WebCore::CSSStyleSelector::mapBackgroundYPosition):
  • css/cssstyleselector.h:
  • kcanvas/KCanvasFilters.h: (KCanvasFEImage::image): (KCanvasFEImage::setImage):
  • kcanvas/KCanvasImage.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEImageQuartz::getCIFilter):
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h: (KCanvasImageQuartz::init):
  • khtml/ecma/kjs_events.cpp: (KJS::ClipboardProtoFunc::callAsFunction):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::callAsFunction): (KJS::drawPattern): (KJS::_rh): (KJS::ImagePattern::createPattern):
  • khtml/ecma/kjs_html.h: (KJS::ImagePattern::image):
  • khtml/ecma/kjs_window.cpp: (KJS::Screen::getValueProperty):
  • khtml/editing/SelectionController.h:
  • khtml/html/html_imageimpl.h: (WebCore::HTMLImageElementImpl::image):
  • khtml/misc/helper.h:
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::DocumentImpl): (WebCore::DocumentImpl::~DocumentImpl): (WebCore::DocumentImpl::recalcStyle): (WebCore::DocumentImpl::attach): (WebCore::DocumentImpl::detach):
  • khtml/xml/DocumentImpl.h: (WebCore::DocumentImpl::printing): (WebCore::DocumentImpl::setPrinting):
  • khtml/xml/dom2_eventsimpl.h:
  • ksvg2/css/SVGCSSStyleSelector.cpp:
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::cssPrimitiveToLength): (WebCore::KSVGPainterFactory::strokePainter):
  • ksvg2/svg/SVGCursorElementImpl.cpp: (SVGCursorElementImpl::notifyFinished):
  • ksvg2/svg/SVGCursorElementImpl.h: (KSVG::SVGCursorElementImpl::image):
  • ksvg2/svg/SVGDocumentImpl.cpp: (SVGDocumentImpl::SVGDocumentImpl):
  • ksvg2/svg/SVGFEImageElementImpl.cpp: (SVGFEImageElementImpl::notifyFinished):
  • ksvg2/svg/SVGMaskElementImpl.cpp: (KSVG::SVGMaskElementImpl::drawMaskerContent):
  • ksvg2/svg/SVGSVGElementImpl.cpp:
  • kwq/KWQApplication.h:
  • kwq/KWQApplication.mm: (QDesktopWidget::screenDepth):
  • kwq/KWQClipboard.h:
  • kwq/KWQClipboard.mm: (WebCore::KWQClipboard::dragImage): (WebCore::KWQClipboard::setDragImage): (WebCore::KWQClipboard::setDragImageElement):
  • kwq/KWQComboBox.mm:
  • kwq/KWQCursor.h:
  • kwq/KWQCursor.mm: (WebCore::createCustomCursor): (WebCore::QCursor::QCursor):
  • kwq/KWQKPartsEvent.h:
  • kwq/KWQObject.h:
  • kwq/KWQPaintDevice.h: Removed.
  • kwq/KWQPaintDeviceMetrics.h: Removed.
  • kwq/KWQPaintDeviceMetrics.mm: Removed.
  • kwq/KWQPainter.h: (WebCore::QPainter::printing):
  • kwq/KWQPainter.mm: (WebCore::QPainter::drawImage): (WebCore::QPainter::drawFloatImage): (WebCore::QPainter::drawTiledImage): (WebCore::QPainter::drawScaledAndTiledImage):
  • kwq/KWQPixmap.h: Removed.
  • kwq/KWQPixmap.mm: Removed.
  • kwq/KWQPrinter.h: (QPrinter::QPrinter):
  • kwq/KWQWidget.h:
  • loader/Cache.cpp: (khtml::Cache::init): (khtml::Cache::clear): (khtml::Cache::requestImage): (khtml::Cache::getStatistics):
  • loader/Cache.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::CachedImage::ref): (WebCore::CachedImage::tiled_image): (WebCore::CachedImage::image): (WebCore::CachedImage::image_size): (WebCore::CachedImage::do_notify): (WebCore::CachedImage::data): (WebCore::CachedImage::error):
  • loader/CachedImage.h:
  • loader/CachedImageCallback.cpp: (WebCore::CachedImageCallback::notifyUpdate): (WebCore::CachedImageCallback::notifyFinished): (WebCore::CachedImageCallback::handleError):
  • loader/CachedObject.h: (WebCore::CachedObject::):
  • loader/CachedObjectClient.h: (WebCore::CachedObjectClient::setImage):
  • loader/DocLoader.cpp: (khtml::DocLoader::setAutoloadImages): (khtml::DocLoader::setShowAnimations):
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests): (WebCore::Loader::slotFinished):
  • page/Frame.cpp: (Frame::paint):
  • page/Frame.h:
  • page/FrameView.cpp: (selectCursor):
  • page/FrameView.h:
  • platform/Image.h: Added.
  • platform/mac/Image.mm: Added. (WebCore::Image::loadResource): (WebCore::Image::Image): (WebCore::Image::~Image): (WebCore::Image::imageRef): (WebCore::Image::resetAnimation): (WebCore::Image::setAnimationRect): (-[WebImageCallback initWithCallback:WebCore::]): (WebCore::Image::shouldUseThreadedDecoding): (WebCore::Image::receivedData): (WebCore::Image::mask): (WebCore::Image::isNull): (WebCore::Image::size): (WebCore::Image::rect): (WebCore::Image::width): (WebCore::Image::height): (WebCore::Image::resize): (WebCore::Image::operator=): (WebCore::Image::increaseUseCount): (WebCore::Image::decreaseUseCount): (WebCore::Image::stopAnimations): (WebCore::Image::flushRasterCache):
  • rendering/InlineTextBox.cpp: (khtml::InlineTextBox::paint):
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::paintObject):
  • rendering/RenderText.h:
  • rendering/font.cpp: (khtml::Font::update):
  • rendering/font.h:
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/render_canvasimage.cpp: (WebCore::RenderCanvasImage::paint):
  • rendering/render_flow.cpp: (RenderFlow::paintLines):
  • rendering/render_image.cpp: (WebCore::RenderImage::RenderImage): (WebCore::RenderImage::~RenderImage): (WebCore::RenderImage::setContentObject): (WebCore::RenderImage::setImage): (WebCore::RenderImage::paint): (WebCore::RenderImage::layout): (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight):
  • rendering/render_image.h: (WebCore::RenderImage::image): (WebCore::RenderImage::getImage):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder):
  • rendering/render_list.cpp: (RenderListItem::getAbsoluteRepaintRect): (RenderListMarker::paint): (RenderListMarker::setImage): (RenderListMarker::calcMinMaxWidth):
  • rendering/render_list.h:
  • rendering/render_object.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::setImage):
  • rendering/render_object.h:
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::paint):
  • rendering/render_replaced.h:
  • rendering/render_theme_mac.mm: (khtml::RenderThemeMac::setFontFromControlSize):
2:20 AM Changeset in webkit [12413] by eseidel
  • 2 edits in trunk/WebKitTools

2006-01-27 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

run-webkit-test --leaks crashes (malloc logging runs out of memory)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6869

  • Scripts/run-webkit-tests: fix --leaks to not crash
1:39 AM Changeset in webkit [12412] by andersca
  • 2 edits in trunk

Somehow these ChangeLog entries weren't committed

1:35 AM Changeset in webkit [12411] by darin
  • 3 edits in trunk/LayoutTests
  • fast/forms/radio-button-no-change-event.html: Updated to add a second radio button.
  • fast/forms/radio-button-no-change-event-expected.txt: Updated.
1:29 AM Changeset in webkit [12410] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Revised test: fast/forms/radio-button-no-change-event.html

  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::setChecked): Don't send a change event for a radio button getting unchecked (matches Gecko at least).
12:10 AM Changeset in webkit [12409] by eseidel
  • 2 edits in trunk/WebKitTools

2006-01-26 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

run-webkit-tests should produce a self-contained results directory
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6864

  • Scripts/run-webkit-tests: copy failing items to results dir.

Jan 26, 2006:

10:55 PM Changeset in webkit [12408] by eseidel
  • 4 edits in trunk/WebCore

2006-01-26 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Leak fixes in SVG code.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6588

  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (teardownShadingWithStyle): delete image and context when through. (KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz): zero out cached mask (KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz): destroy cached mask image. (KRenderingPaintServerLinearGradientQuartz::setup): delete mask before making new (KRenderingPaintServerRadialGradientQuartz::setup): delete mask before making new
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::sharedSolidPaintServer): forgot "static" keyword
  • ksvg2/svg/SVGPolyElementImpl.cpp: (SVGPolyElementImpl::notifyAttributeChange): use RefPtr
10:05 PM Changeset in webkit [12407] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Eric.

  • various leaks on "fast" LayoutTests


​http://bugzilla.opendarwin.org/show_bug.cgi?id=6819
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6823
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6824


It turns out these all had the same cause.


  • page/Frame.cpp: (Frame::clear): If we have a document, make sure to cancel parsing, in case it has a tokenizer and parser that are keeping it alive. Use cancelParsing to avoid possibly accidentally firing the onload handler.
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::cancelParsing): Factored out of implicitOpen. (WebCore::DocumentImpl::implicitOpen): Call cancelParsing now.
  • khtml/xml/DocumentImpl.h:
9:42 PM Changeset in webkit [12406] by mjs
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Tim Omernick.


(This bug was fixed independently by Dave Harrison but I'm landing the test
case anyway.)

  • fast/lists/list-style-none-crash-expected.checksum: Added.
  • fast/lists/list-style-none-crash-expected.png: Added.
  • fast/lists/list-style-none-crash-expected.txt: Added.
  • fast/lists/list-style-none-crash.html: Added.
5:35 PM Changeset in webkit [12405] by bdakin
  • 1 edit
    4 adds in trunk/LayoutTests

Test case for <rdar://problem/4256504>
khtml::RenderBlock::skipWhitespace crashes upon interaction with
radio buttons

5:12 PM Changeset in webkit [12404] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/4256504> khtml::RenderBlock::skipWhitespace
crashes upon interaction with radio buttons.

The old code held an assumption that positioned elements would
always have line boxes. This is not necessarily the case, so this
patch makes sure that the lines are dirtied appropriately.

3:56 PM Changeset in webkit [12403] by andersca
  • 1 edit
    2 adds in trunk

2006-01-26 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Test: fast/dom/HTMLImageElement/image-without-renderer-width.html

Reviewed and landed by Anders.


  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLImageElementImpl::width): Return the image's dimensions only if it isn't null, but even if it hasn't finished loading. (WebCore::HTMLImageElementImpl::height): Ditto.
3:32 PM Changeset in webkit [12402] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4422365>

  • WebView.subproj/WebHTMLView.m: (-[NSArray addSuperviewObservers]): In addition to registering for frame/bounds change notifications, call -_frameOrBoundsChanged. It will check the current size/scroll against the previous layout's size/scroll. We need to do this here to catch the case where the WebView is laid out at one size, removed from its window, resized, and inserted into another window. Our frame/bounds changed notifications will not be sent in that situation, since we only watch for changes while in the view hierarchy.

I have verified that this does not cause unnecessary layouts while running the PLT.

2:45 PM Changeset in webkit [12401] by adele
  • 2 edits in trunk/WebCore

Reviewed by Hyatt and Vicki.

Fix for broken layout tests.

  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::focus):
2:00 PM Changeset in webkit [12400] by andersca
  • 10 edits
    3 adds
    2 deletes in trunk

2006-01-26 Anders Carlsson <​andersca@mac.com>

Reviewed by Eric.


This makes DocumentType and DOMImplementation autogenerated.


  • JSCore.cpp: Added.


  • WebCore.xcodeproj/project.pbxproj: Add JSCore.cpp


  • bindings/scripts/CodeGeneratorJS.pm: Add attributes for controlling how null values should be converted to and from DOMString objects.


  • bindings/scripts/IDLParser.pm:
  • bindings/scripts/IDLStructure.pm: Remove the extended attributes hash on attribute objects and use the one on the signature.
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeProtoFunc::callAsFunction): For isSupported, just convert the version argument to an empty string if null is passed in. The reason for this change is that the autogenerated binding for DOMImplementation::hasFeature does the same thing. This also makes us behave like Mozilla and Opera.


(KJS::toDocumentType):
(KJS::getDOMNode):
Use JSDocumentType.


(KJS::getDOMDOMImplementation):
Use JSDOMImplementation.


  • khtml/ecma/kjs_dom.h: Remove DOMDOMImplementation and DOMDocumentType


  • khtml/xml/DOMImplementation.idl: Added.
  • khtml/xml/DocumentType.idl: Added.
1:40 PM Changeset in webkit [12399] by eseidel
  • 3 edits
    4 adds in trunk

2006-01-26 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

<text> elements with a scale on a parent <g> breaks nodeAtPoint
Fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6843

  • kcanvas/RenderSVGText.cpp: (RenderSVGText::nodeAtPoint):
12:32 PM Changeset in webkit [12398] by mjs
  • 6 edits in trunk/WebCore

Reviewed by Geoff.

There were three basic problems here, any one of which was enough
to cause the leak.


1) If the filter function for a NodeFilter, NodeIterator or TreeWalker
had that object in scope, it would cause a GC reference cycle. I fixed
this by making these JS functions get marked by the corresponding JS object,
as for XMLHttpRequest.


2) The TraversalImpl class that's a base class for NodeIteratorImpl and
TreeWalkerImpl did not have a virtual destructor, leading the Shared
template to call the base class destructor on deref.


3) ref/deref on the document were mismatched, I fixed all that sort of nonsense
by using RefPtr instead of manual ref/deref.


  • khtml/dom/dom2_traversal.h: (DOM::NodeFilterCondition::mark): Add no-op virtual mark method, JS subclass will do something useful here.
  • khtml/ecma/kjs_traversal.cpp: (KJS::DOMNodeIterator::mark): Mark the DOM-level filter. (KJS::DOMNodeFilter::mark): ditto (KJS::DOMTreeWalker::mark): ditto (KJS::JSNodeFilterCondition::JSNodeFilterCondition): reformatted. (KJS::JSNodeFilterCondition::mark): Mark the filter function.
  • khtml/ecma/kjs_traversal.h:
  • khtml/xml/dom2_traversalimpl.cpp: (DOM::NodeFilterImpl::NodeFilterImpl): diligently applied RefPtr (DOM::TraversalImpl::TraversalImpl): ditto (DOM::TraversalImpl::~TraversalImpl): ditto (DOM::NodeIteratorImpl::NodeIteratorImpl): ditto (DOM::NodeIteratorImpl::~NodeIteratorImpl): ditto (DOM::NodeIteratorImpl::setReferenceNode): ditto (DOM::TreeWalkerImpl::TreeWalkerImpl): ditto (DOM::TreeWalkerImpl::setCurrentNode): ditto
  • khtml/xml/dom2_traversalimpl.h: (DOM::NodeFilterImpl::mark): call mark() on the codition (DOM::TraversalImpl::root): Use .get() (DOM::TraversalImpl::filter): ditto (DOM::NodeIteratorImpl::referenceNode): ditto (DOM::NodeIteratorImpl::document): ditto (DOM::TreeWalkerImpl::currentNode): ditto
12:18 PM Changeset in webkit [12397] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

  • kwq/KWQPageState.mm: (-[KWQPageState clear]): Garbage collect after deleting a bunch of stuff that holds onto JS objects. This should avoid false positive leaks and is good in any case since page state deallocation is already deferred.
10:46 AM Changeset in webkit [12396] by adele
  • 2 edits in trunk/WebCore

Reviewed by Vicki.

  • fix for <rdar://problem/4422624> REGRESSION: crash loading webmail.mac.com
  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::focus): Nil check for renderer.
8:59 AM Changeset in webkit [12395] by harrison
  • 1 edit
    4 adds in trunk/LayoutTests

Adding test case for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6835

  • editing/deleting/delete-listitem-001-expected.checksum: Added.
  • editing/deleting/delete-listitem-001-expected.png: Added.
  • editing/deleting/delete-listitem-001-expected.txt: Added.
  • editing/deleting/delete-listitem-001.html: Added.
8:58 AM Changeset in webkit [12394] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Timothy.

Test added:
editing/deleting/delete-listitem-001.html


  • rendering/render_list.cpp: (RenderListItem::setStyle): (RenderListItem::resetMarkerValue): (RenderListItem::getAbsoluteRepaintRect): (RenderListMarker::paint):
4:06 AM Changeset in webkit [12393] by ap
  • 3 edits
    1 add in trunk/WebCore

Fix by Mitz Pettel, reviewed by Darin, landed by ap.


  • manual-tests/bugzilla-6388.html: Added.
  • rendering/render_layer.cpp: (WebCore::RenderLayer::computeRepaintRects): Cache the object's absolute position before update. (WebCore::RenderLayer::updateLayerPositions): Use the cached position to determine if the object moved. If it did, do a full repaint.
  • rendering/render_layer.h:
3:32 AM Changeset in webkit [12392] by eseidel
  • 2 edits in trunk/WebCore

2006-01-26 Eric Seidel <​eseidel@apple.com>

Adding additional test case from:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6801

  • svg/custom/percentage-rect2-expected.checksum: Added.
  • svg/custom/percentage-rect2-expected.png: Added.
  • svg/custom/percentage-rect2-expected.txt: Added.
  • svg/custom/percentage-rect2.svg: Added.
3:11 AM Changeset in webkit [12391] by eseidel
  • 1 edit
    4 adds in trunk/LayoutTests

2006-01-26 Eric Seidel <​eseidel@apple.com>

Adding additional test case from:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6801

  • svg/custom/percentage-rect2-expected.checksum: Added.
  • svg/custom/percentage-rect2-expected.png: Added.
  • svg/custom/percentage-rect2-expected.txt: Added.
  • svg/custom/percentage-rect2.svg: Added.
2:57 AM Changeset in webkit [12390] by ap
  • 2 edits
    1 add in trunk/WebCore

Fix by Mitz Pettel, reviewed by Darin, committed by ap.


  • manual-tests/bugzilla-6278.html: Added.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::setCellWidths): If during layout a cell changes from not needing layout to needing layout, call repaintObjectsBeforeLayout on it.
2:53 AM Changeset in webkit [12389] by eseidel
  • 9 edits
    4 adds in trunk

2006-01-26 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

SVG shows up blank in WebKit+SVG
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6620

  • css/svg.css: default to width/height 100% for <svg>
1:53 AM Changeset in webkit [12388] by andersca
  • 1 edit in trunk/WebCore/khtml/xml/WheelEvent.idl

Force this to be re-generated

1:43 AM Changeset in webkit [12387] by andersca
  • 9 edits
    1 add in trunk/WebCore

2006-01-26 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6805
Support constants in IDL files

  • bindings/scripts/CodeGeneratorJS.pm: If an interface has constants, generate a constructor object and add the constants as properties. Also add a getConstructor method to the interface object.


  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/generate-bindings.pl: Add a --force-generation flag to force regeneration of files even though nothing has changed.


  • khtml/ecma/kjs_events.cpp:
  • khtml/ecma/kjs_events.h: Remove MutationEventConstructor and DOMMutationEvent, those are autogenerated now.


  • bindings/js/JSEvents.cpp: Include JSMutationEvent.cpp
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty):
  • khtml/ecma/kjs_window.h: (KJS::Window::): Add MutationEvent property.


  • khtml/xml/MutationEvent.idl: Added.
1:32 AM Changeset in webkit [12386] by eseidel
  • 34 edits
    4 adds in trunk

2006-01-25 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

Percentage values for width, height are not rendered correctly.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5331

Create items for even empty paths to prevent an empty render tree.
Calculate the viewport element on the fly rather than caching it,
unless there is no context from which to calculate it. Call
notifyAttributeChange() on layout to fix usage of viewport
percentages for lengths. Remove portion of code which appears to
do nothing but worsen the situation.

  • kcanvas/device/quartz/KCanvasItemQuartz.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::layout):
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::value):
  • ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::createRenderer):
1:23 AM Changeset in webkit [12385] by eseidel
  • 2 edits in trunk/WebCore

2006-01-26 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Disable <animateTransform> to stop layout test crashes.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6780

  • ksvg2/misc/KSVGTimeScheduler.cpp: hack out animateTransform.
12:37 AM Changeset in webkit [12384] by eseidel
  • 16 edits in trunk/WebCore

2006-01-26 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Deploy RefPtr throughout more of WebCore
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6754

  • bridge/mac/MacFrame.mm: (MacFrame::shouldClose): no need to call .get()
  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::createContextualFragment):
  • khtml/html/HTMLSelectElementImpl.cpp: (WebCore::HTMLSelectElementImpl::remove):
  • khtml/html/HTMLTextAreaElementImpl.cpp: (WebCore::HTMLTextAreaElementImpl::setDefaultValue):
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLBodyElementImpl::HTMLBodyElementImpl): (WebCore::HTMLBodyElementImpl::~HTMLBodyElementImpl): (WebCore::HTMLBodyElementImpl::createLinkDecl): (WebCore::HTMLBodyElementImpl::parseMappedAttribute):
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::HTMLLinkElementImpl): (WebCore::HTMLLinkElementImpl::~HTMLLinkElementImpl): (WebCore::HTMLLinkElementImpl::process): (WebCore::HTMLLinkElementImpl::setStyleSheet): (WebCore::HTMLLinkElementImpl::isLoading): (WebCore::HTMLStyleElementImpl::HTMLStyleElementImpl): (WebCore::HTMLStyleElementImpl::childrenChanged): (WebCore::HTMLStyleElementImpl::isLoading):
  • khtml/html/html_headimpl.h: (DOM::HTMLLinkElementImpl::sheet): (DOM::HTMLStyleElementImpl::sheet):
  • khtml/html/html_tableimpl.cpp: (WebCore::HTMLTableElementImpl::parseMappedAttribute): (WebCore::HTMLTableSectionElementImpl::insertRow): (WebCore::HTMLTableSectionElementImpl::deleteRow): (WebCore::HTMLTableRowElementImpl::deleteCell):
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchEvent): (WebCore::NodeImpl::dispatchGenericEvent): (WebCore::NodeImpl::dispatchWindowEvent): (WebCore::NodeImpl::dispatchMouseEvent): (WebCore::NodeImpl::dispatchKeyEvent): (WebCore::NodeImpl::createRendererIfNeeded):
  • khtml/xml/NodeImpl.h:
  • khtml/xml/dom_elementimpl.cpp: (WebCore::MappedAttributeImpl::clone): (WebCore::StyledElementImpl::StyledElementImpl): (WebCore::StyledElementImpl::createInlineStyleDecl): (WebCore::StyledElementImpl::destroyInlineStyleDecl): (WebCore::StyledElementImpl::getInlineStyleDecl):
  • khtml/xml/dom_elementimpl.h: (DOM::MappedAttributeImpl::MappedAttributeImpl): (DOM::MappedAttributeImpl::style): (DOM::MappedAttributeImpl::decl): (DOM::MappedAttributeImpl::setDecl): (DOM::StyledElementImpl::inlineStyleDecl):
  • khtml/xml/dom_position.cpp: (DOM::Position::Position): (DOM::Position::clear):
  • khtml/xml/dom_position.h: (DOM::Position::node):

Jan 25, 2006:

11:10 PM Changeset in webkit [12383] by mjs
  • 4 edits in trunk/WebCore

Reviewed by Dave Hyatt.


  • khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxyImpl::~KJSProxyImpl): Garbage collect after destroying the script interpreter.
  • page/Frame.cpp: (Frame::clear): Add a boolean parameter to indicate whether properties of the window object should also be cleared (defaults to true). (Frame::~Frame): Call clear(false) instead of clear()
  • page/Frame.h:
8:44 PM Changeset in webkit [12382] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImplCounter::~NodeImplCounter): Uncomment node counter now tit won't give a lot of false positives.
8:40 PM Changeset in webkit [12381] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.



This fixes 175 reproducible node leaks in the editing layout tests.


  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::detach): Clear hover, focus and active nodes. It doesn't make sense to have these without a view anyway, and if any of them is the document it can cause a leak of the whole DOM.
8:36 PM Changeset in webkit [12380] by adele
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6816
Crash in dispatchMouseEvent - Missing nil check

  • page/FrameView.cpp: (FrameView::dispatchMouseEvent):
6:39 PM Changeset in webkit [12379] by justing
  • 164 edits
    8 adds in trunk/LayoutTests

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6644>
TinyMCE: Undo operation crashes Safari
<rdar://problem/4343068>
Some shouldChangeSelection calls are nonsensical


Selections are blown away if their endpoints are removed from the document.
This changed the selections that editing delegates see during deletion/replacement.

  • editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
  • editing/deleting/delete-3608430-fix-expected.txt:
  • editing/deleting/delete-3608462-fix-expected.txt:
  • editing/deleting/delete-3775172-fix-expected.txt:
  • editing/deleting/delete-3800834-fix-expected.txt:
  • editing/deleting/delete-3857753-fix-expected.txt:
  • editing/deleting/delete-3865854-fix-expected.txt:
  • editing/deleting/delete-3928305-fix-expected.txt:
  • editing/deleting/delete-3959464-fix-expected.txt:
  • editing/deleting/delete-4038408-fix-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
  • editing/deleting/delete-block-contents-001-expected.txt:
  • editing/deleting/delete-block-contents-002-expected.txt:
  • editing/deleting/delete-block-contents-003-expected.txt:
  • editing/deleting/delete-block-merge-contents-001-expected.txt:
  • editing/deleting/delete-block-merge-contents-002-expected.txt:
  • editing/deleting/delete-block-merge-contents-003-expected.txt:
  • editing/deleting/delete-block-merge-contents-004-expected.txt:
  • editing/deleting/delete-block-merge-contents-005-expected.txt:
  • editing/deleting/delete-block-merge-contents-006-expected.txt:
  • editing/deleting/delete-block-merge-contents-007-expected.txt:
  • editing/deleting/delete-block-merge-contents-008-expected.txt:
  • editing/deleting/delete-block-merge-contents-009-expected.txt:
  • editing/deleting/delete-block-merge-contents-010-expected.txt:
  • editing/deleting/delete-block-merge-contents-012-expected.txt:
  • editing/deleting/delete-block-merge-contents-013-expected.txt:
  • editing/deleting/delete-block-merge-contents-014-expected.txt:
  • editing/deleting/delete-block-merge-contents-015-expected.txt:
  • editing/deleting/delete-block-merge-contents-016-expected.txt:
  • editing/deleting/delete-block-merge-contents-017-expected.txt:
  • editing/deleting/delete-block-merge-contents-018-expected.txt:
  • editing/deleting/delete-block-merge-contents-019-expected.txt:
  • editing/deleting/delete-block-merge-contents-020-expected.txt:
  • editing/deleting/delete-block-merge-contents-021-expected.txt:
  • editing/deleting/delete-br-008-expected.txt:
  • editing/deleting/delete-br-010-expected.txt:
  • editing/deleting/delete-image-001-expected.txt:
  • editing/deleting/delete-image-002-expected.txt:
  • editing/deleting/delete-image-003-expected.txt:
  • editing/deleting/delete-image-004-expected.txt:
  • editing/deleting/delete-line-001-expected.txt:
  • editing/deleting/delete-line-002-expected.txt:
  • editing/deleting/delete-line-003-expected.txt:
  • editing/deleting/delete-line-004-expected.txt:
  • editing/deleting/delete-line-005-expected.txt:
  • editing/deleting/delete-line-006-expected.txt:
  • editing/deleting/delete-line-007-expected.txt:
  • editing/deleting/delete-line-008-expected.txt:
  • editing/deleting/delete-line-009-expected.txt:
  • editing/deleting/delete-line-010-expected.txt:
  • editing/deleting/delete-line-011-expected.txt:
  • editing/deleting/delete-line-012-expected.txt:
  • editing/deleting/delete-line-013-expected.txt:
  • editing/deleting/delete-line-014-expected.txt:
  • editing/deleting/delete-line-015-expected.txt:
  • editing/deleting/delete-line-016-expected.txt:
  • editing/deleting/delete-line-017-expected.txt:
  • editing/deleting/delete-select-all-001-expected.txt:
  • editing/deleting/delete-select-all-002-expected.txt:
  • editing/deleting/delete-select-all-003-expected.txt:
  • editing/execCommand/boldSelection-expected.txt:
  • editing/execCommand/strikethroughSelection-expected.txt:
  • editing/input/attributed-substring-from-range-lines-expected.txt:
  • editing/input/text-input-controller-expected.txt:
  • editing/inserting/insert-3654864-fix-expected.txt:
  • editing/inserting/insert-3659587-fix-expected.txt:
  • editing/inserting/insert-3775316-fix-expected.txt:
  • editing/inserting/insert-3851164-fix-expected.txt:
  • editing/inserting/insert-3907422-fix-expected.txt:
  • editing/inserting/insert-after-delete-001-expected.txt:
  • editing/inserting/insert-div-001-expected.txt:
  • editing/inserting/insert-div-002-expected.txt:
  • editing/inserting/insert-div-003-expected.txt:
  • editing/inserting/insert-div-005-expected.txt:
  • editing/inserting/insert-div-007-expected.txt:
  • editing/inserting/insert-div-009-expected.txt:
  • editing/inserting/insert-div-010-expected.txt:
  • editing/inserting/insert-div-020-expected.txt:
  • editing/inserting/insert-div-023-expected.txt:
  • editing/inserting/insert-div-024-expected.txt:
  • editing/inserting/insert-div-025-expected.txt:
  • editing/inserting/insert-div-026-expected.txt:
  • editing/inserting/return-key-with-selection-001-expected.txt:
  • editing/inserting/return-key-with-selection-002-expected.txt:
  • editing/inserting/return-key-with-selection-003-expected.txt:
  • editing/pasteboard/3976872-expected.txt:
  • editing/pasteboard/4076267-3-expected.txt:
  • editing/pasteboard/4076267-expected.txt:
  • editing/pasteboard/block-wrappers-necessary-expected.txt:
  • editing/pasteboard/paste-4035648-fix-expected.txt:
  • editing/pasteboard/paste-4039777-fix-expected.txt:
  • editing/pasteboard/paste-line-endings-001-expected.txt:
  • editing/pasteboard/paste-line-endings-006-expected.txt:
  • editing/pasteboard/paste-line-endings-007-expected.txt:
  • editing/pasteboard/paste-line-endings-008-expected.txt:
  • editing/pasteboard/paste-line-endings-009-expected.txt:
  • editing/pasteboard/paste-line-endings-010-expected.txt:
  • editing/pasteboard/paste-match-style-001-expected.txt:
  • editing/pasteboard/paste-match-style-002-expected.txt:
  • editing/pasteboard/paste-pre-001-expected.txt:
  • editing/pasteboard/paste-pre-002-expected.txt:
  • editing/pasteboard/paste-text-002-expected.txt:
  • editing/pasteboard/paste-text-003-expected.txt:
  • editing/pasteboard/paste-text-006-expected.txt:
  • editing/pasteboard/paste-text-007-expected.txt:
  • editing/pasteboard/paste-text-008-expected.txt:
  • editing/pasteboard/paste-text-009-expected.txt:
  • editing/pasteboard/paste-text-011-expected.txt:
  • editing/pasteboard/paste-text-015-expected.txt:
  • editing/pasteboard/paste-text-016-expected.txt:
  • editing/pasteboard/paste-text-017-expected.txt:
  • editing/pasteboard/paste-text-018-expected.txt:
  • editing/pasteboard/smart-paste-006-expected.txt:
  • editing/pasteboard/smart-paste-007-expected.txt:
  • editing/selection/node-removal-1-expected.checksum: Added.
  • editing/selection/node-removal-1-expected.png: Added.
  • editing/selection/node-removal-1-expected.txt: Added.
  • editing/selection/node-removal-1.html: Added.
  • editing/selection/node-removal-2-expected.checksum: Added.
  • editing/selection/node-removal-2-expected.png: Added.
  • editing/selection/node-removal-2-expected.txt: Added.
  • editing/selection/node-removal-2.html: Added.
  • editing/style/block-style-004-expected.txt:
  • editing/style/block-style-005-expected.txt:
  • editing/style/block-style-006-expected.txt:
  • editing/style/create-block-for-style-001-expected.txt:
  • editing/style/create-block-for-style-002-expected.txt:
  • editing/style/create-block-for-style-003-expected.txt:
  • editing/style/create-block-for-style-004-expected.txt:
  • editing/style/create-block-for-style-007-expected.txt:
  • editing/style/create-block-for-style-009-expected.txt:
  • editing/style/create-block-for-style-010-expected.txt:
  • editing/style/create-block-for-style-011-expected.txt:
  • editing/style/create-block-for-style-012-expected.txt:
  • editing/style/create-block-for-style-013-expected.txt:
  • editing/style/relative-font-size-change-001-expected.txt:
  • editing/style/relative-font-size-change-002-expected.txt:
  • editing/style/remove-underline-across-paragraph-expected.txt:
  • editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
  • editing/style/remove-underline-after-paragraph-expected.txt:
  • editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
  • editing/style/remove-underline-from-stylesheet-expected.txt:
  • editing/style/smoosh-styles-001-expected.txt:
  • editing/style/smoosh-styles-002-expected.txt:
  • editing/style/smoosh-styles-003-expected.txt:
  • editing/style/style-3681552-fix-001-expected.txt:
  • editing/style/style-3681552-fix-002-expected.txt:
  • editing/style/style-3690704-fix-expected.txt:
  • editing/style/style-3998892-fix-expected.txt:
  • editing/style/style-boundary-001-expected.txt:
  • editing/style/style-boundary-003-expected.txt:
  • editing/style/style-boundary-004-expected.txt:
  • editing/style/typing-style-001-expected.txt:
  • editing/style/typing-style-003-expected.txt:
  • editing/unsupported-content/list-delete-001-expected.txt:
  • editing/unsupported-content/list-delete-002-expected.txt:
  • editing/unsupported-content/list-delete-003-expected.txt:
  • editing/unsupported-content/table-delete-001-expected.txt:
  • editing/unsupported-content/table-delete-002-expected.txt:
  • editing/unsupported-content/table-delete-003-expected.txt:
  • fast/events/updateLayoutForHitTest-expected.txt:
  • fast/forms/attributed-strings-expected.txt:
6:36 PM Changeset in webkit [12378] by justing
  • 5 edits in trunk/WebCore

Reviewed by mjs


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6644>
TinyMCE: Undo operation crashes Safari
<rdar://problem/4343068>
Some shouldChangeSelection calls are nonsensical

Notify the SelectionController of node removals,
and blow away the selection when end points are removed.

Tests added:

  • editing/selection/remove-node-1.html
  • editing/selection/remove-node-2.html


  • khtml/editing/SelectionController.cpp: (WebCore::MutationListener::handleEvent): (WebCore::SelectionController::SelectionController): (WebCore::SelectionController::~SelectionController): (WebCore::SelectionController::operator=): (WebCore::SelectionController::moveTo): (WebCore::SelectionController::setSelection): (WebCore::SelectionController::nodeWillBeRemoved): (WebCore::SelectionController::clear): (WebCore::SelectionController::setBase): (WebCore::SelectionController::setExtent):
  • khtml/editing/SelectionController.h: (WebCore::MutationListener::MutationListener): (WebCore::MutationListener::selectionController): (WebCore::MutationListener::setSelectionController):
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode):
  • rendering/render_flow.cpp: (RenderFlow::destroy):
6:30 PM Changeset in webkit [12377] by thatcher
  • 1 edit in trunk/WebCore/bridge/mac/MacFrame.mm

Build fix for i386.

6:09 PM Changeset in webkit [12376] by adele
  • 10 edits in trunk

LayoutTests:

Updating test results for aqua text fields.

  • fast/forms/input-appearance-focus-expected.checksum:
  • fast/forms/input-appearance-focus-expected.png:
  • fast/forms/input-appearance-focus-expected.txt:

WebCore:

Reviewed by Hyatt.

This change lets us display an aqua appearance for the new text fields.

Updated results for:

  • fast/forms/input-appearance-focus.html
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): remove styling of the div, since RenderTheme handles that now.
  • rendering/render_theme.cpp: (khtml::RenderTheme::adjustStyle): call adjustTextFieldStyle. (khtml::RenderTheme::paint): call paintTextField. (khtml::RenderTheme::adjustTextFieldStyle): added FIXME to turn off appearance later.
  • rendering/render_theme.h: added adjustTextFieldStyle, paintTextField
  • rendering/render_theme_mac.h: added paintTextField, setTextFieldState, and NSTextFieldCell.
  • rendering/render_theme_mac.mm: (khtml::): Added static textFieldMargins. (khtml::RenderThemeMac::adjustRepaintRect): update text field state and size. (khtml::RenderThemeMac::paintTextField): Added. Paints the NSTextFieldCell (khtml::RenderThemeMac::setTextFieldCellState): Initialize NSTextFieldCell, and update enabled state.
5:56 PM Changeset in webkit [12375] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Land project change so Brush is in the Win32 project.

5:53 PM Changeset in webkit [12374] by thatcher
  • 2 edits in branches/Safari-Leo-branch

Versioning.

5:52 PM Changeset in webkit [12373] by hyatt
  • 14 edits
    1 move
    3 deletes in trunk/WebCore

Rename QBrush to Brush and move it to platform/. Remove unused QPoint/Size/RectF forwarding
headers.

  • ForwardingHeaders/QPointF: Removed.
  • ForwardingHeaders/QRectF: Removed.
  • ForwardingHeaders/QSizeF: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • khtml/editing/SelectionController.cpp: (WebCore::SelectionController::paintCaret):
  • kwq/KWQBrush.h: Removed.
  • kwq/KWQNamespace.h:
  • kwq/KWQObject.h:
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::setBrush): (QPainter::brush): (QPainter::drawRect): (QPainter::drawEllipse): (QPainter::drawConvexPolygon): (QPainter::fillRect):
  • kwq/KWQPalette.h: (QColorGroup::brush):
  • platform/Brush.h: Added. (WebCore::Brush::): (WebCore::Brush::Brush::Brush): (WebCore::Brush::operator==): (WebCore::Brush::operator!=):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::fillHorizontalSelectionGap): (WebCore::RenderBlock::fillVerticalSelectionGap): (WebCore::RenderBlock::fillLeftSelectionGap): (WebCore::RenderBlock::fillRightSelectionGap):
  • rendering/render_box.cpp: (WebCore::RenderBox::outlineBox):
  • rendering/render_canvasimage.cpp: (WebCore::RenderCanvasImage::paint):
  • rendering/render_image.cpp: (WebCore::RenderImage::paint):
  • rendering/render_list.cpp: (RenderListMarker::paint):
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::paint):
5:50 PM Changeset in webkit [12372] by thatcher
  • 2 edits in branches/Safari-Leo-branch

Versioning.

5:14 PM Changeset in webkit [12371] by harrison
  • 9 edits in trunk/LayoutTests

Reviewed by Justin.


Updated pixel tests for my recent checkin.

  • editing/pasteboard/paste-list-001-expected.png:
  • editing/selection/3690703-2-expected.png:
  • editing/selection/3690703-expected.png:
  • editing/selection/3690719-expected.png:
  • editing/unsupported-content/list-type-after-expected.png:
  • editing/unsupported-content/list-type-before-expected.png:
  • editing/unsupported-content/table-type-after-expected.png:
  • editing/unsupported-content/table-type-before-expected.png:
5:13 PM Changeset in webkit [12370] by vicki
  • 3 edits in trunk/WebKit

Reviewed by Beth Dakin.

  • fix <rdar://problem/4351664> REGRESSION (420+): extra URL in b/f list - navigating back to previous page fails at apple.com/retail/)


  • WebView.subproj/WebFrame.m: (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): grab the redirect flag of the current load before calling _loadURL, which clears this flag, (-[WebFrame _transitionToCommitted:]): remove misleading comment
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem setURL:]): release resources in the page cache when setting the URL on a WebHistoryItem
4:54 PM Changeset in webkit [12369] by andersca
  • 2 edits in trunk/WebCore

2006-01-25 Anders Carlsson <​andersca@mac.com>

Reviewed by Timothy Hatcher.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6807
generate-bindings.pl should not use find command


  • bindings/scripts/generate-bindings.pl: Use opendir and readdir instead of find.
4:21 PM Changeset in webkit [12368] by hyatt
  • 4 edits in trunk/WebCore

Fix Win32 build bustage. Make the autogeneration from idl work on windows.

3:44 PM Changeset in webkit [12367] by hyatt
  • 14 edits
    2 moves
    1 delete in trunk/WebCore

Rename QPen to Pen and move it to the platform/ directory.

  • ForwardingHeaders/qpen.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • kwq/KWQNamespace.h: (Qt::):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::pen): (QPainter::setPen): (QPainter::drawRect): (QPainter::drawLine): (QPainter::drawEllipse): (QPainter::drawArc): (QPainter::drawConvexPolygon):
  • kwq/KWQPen.cpp: Removed.
  • kwq/KWQPen.h: Removed.
  • platform/Pen.cpp: Added. (WebCore::Pen::Pen): (WebCore::Pen::color): (WebCore::Pen::width): (WebCore::Pen::style): (WebCore::Pen::setColor): (WebCore::Pen::setWidth): (WebCore::Pen::setStyle): (WebCore::Pen::operator==): (WebCore::Pen::operator!=):
  • platform/Pen.h: Added. (WebCore::Pen::):
  • rendering/InlineTextBox.cpp: (khtml::InlineTextBox::paintMarkedTextUnderline):
  • rendering/RenderTableCell.cpp: (WebCore::outlineBox):
  • rendering/RenderText.cpp:
  • rendering/render_box.cpp: (WebCore::RenderBox::outlineBox):
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize):
  • rendering/render_image.cpp:
  • rendering/render_line.cpp:
  • rendering/render_list.cpp:
  • rendering/render_object.cpp: (WebCore::RenderObject::drawBorder):
3:04 PM Changeset in webkit [12366] by staikos
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

Merge fix cast fix from KDE (reinterpret_cast can't change size)

2:53 PM Changeset in webkit [12365] by thatcher
  • 2 edits in tags/Safari-521.6.2/WebCore

Build fix.

2:53 PM Changeset in webkit [12364] by thatcher
  • 1 edit in tags/Safari-521.6.2/WebKit/WebCoreSupport.subproj/WebFileButton.m

Build fix.

2:16 PM Changeset in webkit [12363] by thatcher
  • 5 edits in trunk

WebCore:

Move off of -[NSFont widthOfString:] since it is now deprecated.
Use the NSStringDrawing -[NSString sizeWithAttributes:] API.

  • bridge/mac/MacFrame.mm: (MacFrame::attributedString):
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView sizeWithColumns:rows:]):

WebKit:

Move off of -[NSFont widthOfString:] since it is now deprecated.
Use the NSStringDrawing -[NSString sizeWithAttributes:] API.

  • WebCoreSupport.subproj/WebFileButton.m: (-[WebFileChooserButton bestVisualFrameSizeForCharacterCount:]):
2:05 PM Changeset in webkit [12362] by tomernic
  • 3 edits in trunk/WebCore

Reviewed by Dave Harrison.

<rdar://problem/4339024>
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6785> "Fix for possible leak of applet, object, or embed
(and plugin view)"


  • khtml/html/html_objectimpl.cpp: (WebCore::HTMLAppletElementImpl::~HTMLAppletElementImpl): Assert that appletInstance has been deleted by detach(). (WebCore::HTMLAppletElementImpl::detach): Delete appletInstance, because it references the widget owned by the renderer we're about to destroy. It is assumed elsewhere (getRuntimeObject(), kjs_dom.cpp) that the instance is owned by the applet element. Therefore, it is required that the element destroy the instance in its tear-down phase. (WebCore::HTMLEmbedElementImpl::~HTMLEmbedElementImpl): Assert that embedInstance has been deleted by detach(). (WebCore::HTMLEmbedElementImpl::detach): Delete embedInstance, same reason. This is the one that fixes <rdar://problem/4339024>. (WebCore::HTMLObjectElementImpl::~HTMLObjectElementImpl): Assert that objectInstance has been deleted by detach(). (WebCore::HTMLObjectElementImpl::detach): Delete embedInstance, same reason.
  • khtml/html/html_objectimpl.h: Declared HTMLAppletElementImpl::detach() and HTMLEmbedElementImpl::detach().
2:04 PM Changeset in webkit [12361] by andersca
  • 1 add in trunk/WebCore/bindings/js/JSEvents.cpp

Forgot to add this

1:57 PM Changeset in webkit [12360] by andersca
  • 4 edits
    7 adds in trunk/WebCore

2006-01-24 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.


This is a first cut at an autogeneration framework based on
what KDOM uses, but with some changes to be able to move
gradually to using autogenerated files. Currently only Javascript
is supported, but ObjC support could be added by writing a new code
generator package.


  • WebCore.xcodeproj/project.pbxproj: Call generate-bindings.pl
  • bindings/js/JSEvents.cpp: Added. New file which #includes all generated files in the event module (Just JSWheelEvent.cpp for now)


  • khtml/xml/WheelEvent.idl: Added.


  • bindings/scripts: Added.
  • bindings/scripts/CodeGenerator.pm: Added.
  • bindings/scripts/CodeGeneratorJS.pm: Added.
  • bindings/scripts/IDLParser.pm: Added.
  • bindings/scripts/IDLStructure.pm: Added.
  • bindings/scripts/generate-bindings.pl: Added.


  • khtml/ecma/kjs_events.cpp: Remove DOMWheelEvent class.


(KJS::getDOMEvent):
Use JSWheelEvent here.


  • khtml/ecma/kjs_events.h: Remove DOMWheelEvent class.
1:11 PM Changeset in webkit [12359] by harrison
  • 30 edits in trunk/LayoutTests

Updated for fixes of:


<rdar://problem/3907635> copy/paste of list item text moves list item up one <LI>
<rdar://problem/3907647> Enhance list editing: return inserts <li></li>
<rdar://problem/4060158> deleting selection within table deletes more than intended
<rdar://problem/4061232> Deleting a list can delete unselected content
<rdar://problem/4062212> after pasting in contents of web.apple.com, typing before start adds to table instead of before table
<rdar://problem/4064437> After copy/paste from bugweb cannot go back to entering text at left side of page
<rdar://problem/4259845> Table editing in design mode is broken
<rdar://problem/4287667> Insertion point goes before table instead of inside first cell
<rdar://problem/4345749> Editing HTML - Enter at end of <LI> inserts uneditable blank <LI>
<rdar://problem/4345794> HTML editing: Enter at end of last <LI> does not add new <LI>
<rdar://problem/4345825> HTML Editing: editing first <LI> element removes first <LI> and more
<rdar://problem/4345835> HTML editing: editing last <LI> removes everything within <BODY>
<rdar://problem/4345879> HTML editing: editing first <TD> moves data out of table

  • editing/deleting/delete-4083333-fix-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
  • editing/deleting/delete-image-004-expected.txt:
  • editing/deleting/delete-line-015-expected.txt:
  • editing/deleting/delete-select-all-001-expected.txt:
  • editing/pasteboard/paste-list-001-expected.txt:
  • editing/pasteboard/paste-table-001-expected.txt:
  • editing/pasteboard/paste-table-001.html:
  • editing/selection/3690703-2-expected.txt:
  • editing/selection/3690703-2.html:
  • editing/selection/3690703-expected.txt:
  • editing/selection/3690719-expected.txt:
  • editing/selection/move-by-line-001-expected.txt:
  • editing/selection/move-by-line-001.html:
  • editing/selection/replaced-boundaries-3-expected.txt:
  • editing/unsupported-content/list-type-after-expected.txt:
  • editing/unsupported-content/list-type-after.html:
  • editing/unsupported-content/list-type-before-expected.txt:
  • editing/unsupported-content/list-type-before.html:
  • editing/unsupported-content/table-delete-001-expected.txt:
  • editing/unsupported-content/table-delete-001.html:
  • editing/unsupported-content/table-delete-002-expected.txt:
  • editing/unsupported-content/table-delete-002.html:
  • editing/unsupported-content/table-type-after-expected.txt:
  • editing/unsupported-content/table-type-after.html:
  • editing/unsupported-content/table-type-before-expected.txt:
  • editing/unsupported-content/table-type-before.html:
1:05 PM Changeset in webkit [12358] by harrison
  • 27 edits in trunk/WebCore

Reviewed by Justin.

<rdar://problem/3907635> copy/paste of list item text moves list item up one <LI>
<rdar://problem/3907647> Enhance list editing: return inserts <li></li>
<rdar://problem/4060158> deleting selection within table deletes more than intended
<rdar://problem/4061232> Deleting a list can delete unselected content
<rdar://problem/4062212> after pasting in contents of web.apple.com, typing before start adds to table instead of before table
<rdar://problem/4064437> After copy/paste from bugweb cannot go back to entering text at left side of page
<rdar://problem/4259845> Table editing in design mode is broken
<rdar://problem/4287667> Insertion point goes before table instead of inside first cell
<rdar://problem/4345749> Editing HTML - Enter at end of <LI> inserts uneditable blank <LI>
<rdar://problem/4345794> HTML editing: Enter at end of last <LI> does not add new <LI>
<rdar://problem/4345825> HTML Editing: editing first <LI> element removes first <LI> and more
<rdar://problem/4345835> HTML editing: editing last <LI> removes everything within <BODY>
<rdar://problem/4345879> HTML editing: editing first <TD> moves data out of table

...also added showTree() static functions because switch to gcc 4.0 makes calling instance methods unreliable

  • numerous small changes to handle empty list items
  • fix numeric list marker updating when adding/deleting list items
  • start to decompose "special element" handling, replacing it with appropriate handling of the different kinds of special elements in various situations, rather than giving a blanket treatment. I will do more of this in subsequent checkins.
  • numerous small editing/selection changes to handle VisiblePosition at table offset childNodeCount()
  • simplify and fix equivalentRangeCompliantPosition, rename it to rangeCompliantEquivalent and make it static
  • some minor reformatting to current standards
  • the comments in the list below are for changes not covered by the above comments


  • khtml/editing/Selection.cpp: (WebCore::Selection::toRange): (WebCore::Selection::validate):
  • khtml/editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingLeftBackward):
  • character selection backward from after table selects the table (WebCore::showTree):
  • khtml/editing/composite_edit_command.cpp: (WebCore::CompositeEditCommand::removeFullySelectedNode):
  • make sure empty cell has some height (WebCore::CompositeEditCommand::positionOutsideTabSpan):
  • check for !isTabSpanTextNode() to make calling this function easier (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
  • khtml/editing/delete_selection_command.cpp: (WebCore::positionBeforePossibleContainingSpecialElement): (WebCore::positionAfterPossibleContainingSpecialElement): (WebCore::DeleteSelectionCommand::initializeStartEnd):
  • new. more consistent handling of special element boundaries. (WebCore::DeleteSelectionCommand::initializePositionData): (WebCore::DeleteSelectionCommand::handleGeneralDelete):
  • handle childless block (e.g. empty table cell)
  • allow merging across list items (WebCore::DeleteSelectionCommand::moveNodesAfterNode):
  • use new isEmpty() method for renderers, to handle empty list items
  • khtml/editing/delete_selection_command.h:
  • khtml/editing/htmlediting.cpp: (WebCore::isAtomicNode): (WebCore::editingIgnoresContent):
  • new. smarter check than isReplaced() (WebCore::rangeCompliantEquivalent): (WebCore::maxDeepOffset): (WebCore::isFirstVisiblePositionInSpecialElement): (WebCore::positionBeforeContainingSpecialElement): (WebCore::isLastVisiblePositionInSpecialElement): (WebCore::positionAfterContainingSpecialElement): (WebCore::positionOutsideContainingSpecialElement): (WebCore::positionBeforeNode): (WebCore::positionAfterNode): (WebCore::isListElement): (WebCore::isTableElement): (WebCore::isFirstVisiblePositionAfterTableElement): (WebCore::positionBeforePrecedingTableElement): (WebCore::positionAvoidingSpecialElementBoundary):
  • khtml/editing/htmlediting.h:
  • khtml/editing/insert_line_break_command.cpp: (khtml::InsertLineBreakCommand::doApply):
  • khtml/editing/insert_paragraph_separator_command.cpp: (khtml::InsertParagraphSeparatorCommand::doApply):
  • khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::prepareForTextInsertion): (khtml::InsertTextCommand::input):
  • khtml/editing/replace_selection_command.cpp: (WebCore::isMailPasteAsQuotationNode): (WebCore::ReplacementFragment::countRenderedBlocks): (WebCore::ReplaceSelectionCommand::doApply):
  • allow for fact that fragments have no VisiblePositions
  • khtml/editing/visible_position.cpp: (khtml::VisiblePosition::isCandidate): (khtml::showTree): (khtml::makeRange): (khtml::setStart): (khtml::setEnd):
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_units.cpp: (khtml::previousBoundary): (khtml::nextBoundary): (khtml::startOfLine):
  • allow for fact that renderers for list markers and other generated content have no corresponding NodeImpl. (khtml::endOfLine):
  • ditto (khtml::nextLinePosition): (khtml::startOfParagraph): (khtml::endOfParagraph):
  • khtml/xml/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::getUpperLeftCorner): (WebCore::ContainerNodeImpl::childNode):
  • khtml/xml/ContainerNodeImpl.h:
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::childNode): (WebCore::NodeImpl::traversePreviousNode): (WebCore::NodeImpl::nextEditable): (WebCore::showTree):
  • khtml/xml/NodeImpl.h:
  • khtml/xml/dom_position.cpp: (DOM::Position::upstream): (DOM::Position::downstream): (DOM::Position::inRenderedContent): (DOM::showTree):
  • khtml/xml/dom_position.h:
  • rendering/render_canvas.cpp: (RenderCanvas::selectionRect):
  • rendering/render_list.cpp: (RenderListItem::calcListValue): (RenderListItem::isEmpty): (getParentOfFirstLineBox): (RenderListItem::resetMarkerValue): (RenderListItem::updateMarkerLocation):
  • rendering/render_list.h: (khtml::RenderListMarker::isListMarker):
  • rendering/render_object.cpp: (WebCore::RenderObject::nextRenderer): (WebCore::RenderObject::previousRenderer): (WebCore::showTree):
  • rendering/render_object.h: (WebCore::RenderObject::getBaselineOfLastLineBox): (WebCore::RenderObject::isEmpty):
12:14 PM Changeset in webkit [12357] by hyatt
  • 3 edits in trunk/WebCore

Make Color compile on Win32.

11:58 AM Changeset in webkit [12356] by hyatt
  • 3 edits
    1 add in trunk/WebCore

Make Win32 build again.

11:38 AM Changeset in webkit [12355] by thatcher
  • 1 edit in tags/Safari-521.6.2/WebCore/kwq/KWQLineEdit.mm

Build fix.

11:37 AM Changeset in webkit [12354] by thatcher
  • 2 edits in trunk/WebCore

Build fix, -[NSFont defaultLineHeightForFont] is deprecated.
We need to use -[NSLayoutManager defaultLineHeightForFont:] instead.

  • kwq/KWQLineEdit.mm: (QLineEdit::sizeForCharacterWidth): (QLineEdit::baselinePosition):
11:33 AM Changeset in webkit [12353] by darin
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/build-generated-files.sh

Quick update for Dave, who's working on getting this compiling again.

11:12 AM Changeset in webkit [12352] by hyatt
  • 1 edit in trunk/JavaScriptCore/kjs/internal.cpp

Fix JavaScriptCore Win32 bustage by #defining copysign to be _copysign.

11:09 AM Changeset in webkit [12351] by thatcher
  • 1 edit in tags/Safari-521.6.2/WebKit/WebCoreSupport.subproj/WebFrameBridge.h

Build fix.

11:07 AM Changeset in webkit [12350] by thatcher
  • 1 copy in tags/Safari-521.6.2

New Tag.

10:20 AM Changeset in webkit [12349] by darin
  • 2 edits
    1 delete in trunk/JavaScriptCore
  • removed an unused source file
  • kjs/pointer_hash.h: Removed.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Removed reference to pointer_hash.h.
4:36 AM Changeset in webkit [12348] by ap
  • 7 edits in trunk/LayoutTests

Reviewed by Darin.

Corrected a test case for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6385.

  • fast/frames/frame-element-name.html: Fix a reference to the left frame.
  • fast/frames/frame-element-name-expected.txt: Updated results.
  • fast/frames/frame-element-name-expected.png: Updated results.
  • fast/frames/frame-element-name-expected.checksum: Updated results.
  • fast/frames/resources/frame-element-name-left.html: Use escape() on the name.
  • fast/frames/resources/frame-element-name-right.html: Ditto.

Jan 24, 2006:

11:42 PM Changeset in webkit [12347] by darin
  • 1 edit
    2 adds in trunk/LayoutTests
  • fast/forms/radio-button-no-change-event.html: Added.
  • fast/forms/radio-button-no-change-event-expected.txt: Added.
11:41 PM Changeset in webkit [12346] by darin
  • 2 edits in trunk/WebCore

Reviewed by Adele.

Test: fast/forms/radio-button-no-change-event.html

  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::setChecked): One of many possible fixes: Don't send the event if the element is not yet in a document (as in when parsing the initial attributes).
11:35 PM Changeset in webkit [12345] by adele
  • 13 edits
    4 adds in trunk

LayoutTests:

Test for focus and blur for new text fields.

  • fast/forms/input-appearance-focus.html: Added.
  • fast/forms/input-appearance-focus-expected.txt: Added.
  • fast/forms/input-appearance-focus-expected.png: Added.
  • fast/forms/input-appearance-focus-expected.checksum: Added.

WebCore:

Reviewed by Hyatt.

This change will allow the new text field elements to get focus, and to respond to the focus and blur events.

Added: fast/forms/input-appearance-focus.html

  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::isFocusable): Removed recently added code that allowed editable elements with no parent to be focusable. We don't need to do this now that we try to focus the input element, instead of the inner div.
  • khtml/html/HTMLGenericFormElementImpl.cpp: (WebCore::HTMLGenericFormElementImpl::isMouseFocusable): Added case to for text fields.
  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::focus): Added. Selects contents of text field. (WebCore::HTMLInputElementImpl::setSelectionStart): Added break; in switch statement. (WebCore::HTMLInputElementImpl::setSelectionEnd): ditto. (WebCore::HTMLInputElementImpl::select): ditto. (WebCore::HTMLInputElementImpl::setSelectionRange): ditto.
  • khtml/html/HTMLInputElementImpl.h: Added focus()
  • khtml/xml/dom_elementimpl.h: Made focus() virtual.
  • page/Frame.cpp: (Frame::setFocusNodeIfNeeded): Walk up the Render Tree instead of the DOM tree when trying to find a node to focus. This will let us choose the input node instead of one of the nodes in the shadow tree.
  • page/FrameView.cpp: (FrameView::dispatchMouseEvent): ditto.
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::destroyLeftoverChildren): Corrected misspelling.
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::select): Implemented. Select contents of inner div.
  • rendering/RenderTextField.h: (WebCore::RenderTextField::renderName): Changed order. (WebCore::RenderTextField::removeLeftoverAnonymousBoxes): ditto.
10:08 PM Changeset in webkit [12344] by darin
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Eric.

  • fast/dom/replace-first-child.html: Added.
  • fast/dom/replace-first-child-expected.txt: Added
10:07 PM Changeset in webkit [12343] by darin
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • khtml/xml/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::insertBefore): Change one place that hands off ownership of as PassRefPtr that causes us to almost always return 0. Fix test that would screw up when both "prev" and "refChild->previousSibling()" were 0. (WebCore::ContainerNodeImpl::appendChild): Changed a nearly-identical place handing off ownership as above.
8:01 PM Changeset in webkit [12342] by mjs
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Dave Hyatt.


  • fast/parser/remove-block-in-residual-style-expected.checksum: Added.
  • fast/parser/remove-block-in-residual-style-expected.png: Added.
  • fast/parser/remove-block-in-residual-style-expected.txt: Added.

WebCore:

Reviewed by Dave Hyatt.


  • khtml/html/htmlparser.cpp: (HTMLParser::handleResidualStyleCloseTagAcrossBlocks): If the block has been removed from the document, then do not remove it from its parent or add it to its new location. This prevents the crash and matches Mozilla.
7:35 PM Changeset in webkit [12341] by darin
  • 17 edits
    4 adds
    3 deletes in trunk/WebCore

Reviewed by John Sullivan.

  • ForwardingHeaders/qdatetime.h: Removed.
  • kwq/KWQDateTime.cpp: Removed.
  • kwq/KWQDateTime.h: Removed.
  • platform/SystemTime.h: Added.
  • platform/mac/SystemTime.cpp: (WebCore::currentTime): Added.
  • platform/win: Added.
  • platform/win/SystemTime.cpp: (WebCore::currentTime): Added.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Added new files, removed old.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/css_base.h: Removed include of <qdatetime.h>.
  • css/cssstyleselector.cpp: Ditto.
  • khtml/html/htmltokenizer.h:
  • khtml/html/htmltokenizer.cpp: Convert tabs to spaces. (WebCore::HTMLTokenizer::continueProcessing): Change parameter from QTime to double. Use currentTime() instead of QTime::elapsed(). (WebCore::HTMLTokenizer::write): Use currentTime() instead of QTime::elapsed().
  • config.h: Added HAVE_FUNC_USLEEP for now, not sure this is really a good way to handle this.
  • khtml/xml/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::setActive): Use currentTime() instead of QTime::elapsed(). Use HAVE_FUNC_USLEEP for the if.
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::DocumentImpl): Use currentTime() instead of QTime::elapsed(). (WebCore::DocumentImpl::implicitClose): Ditto. (WebCore::DocumentImpl::minimumLayoutDelay): Ditto. (WebCore::DocumentImpl::elapsedTime): Ditto.
  • khtml/xml/dom2_eventsimpl.cpp: (WebCore::EventImpl::EventImpl): Use currentTime() instead of local function called currentTimeStamp().
  • khtml/xml/xml_tokenizer.h: Removed declaration of class QTime.
  • ksvg2/misc/KSVGTimeScheduler.h:
  • ksvg2/misc/KSVGTimeScheduler.cpp: (KSVG::TimeScheduler::TimeScheduler): Use currentTime instead of QTime::elapsed. (KSVG::TimeScheduler::startAnimations): Ditto. (KSVG::TimeScheduler::toggleAnimations): Ditto. (KSVG::TimeScheduler::elapsed): Ditto.
  • page/Frame.cpp: (Frame::clear): Removed unused m_parsetime.
  • page/FramePrivate.h: Ditto.
6:58 PM Changeset in webkit [12340] by hyatt
  • 83 edits
    3 moves
    1 add
    1 delete in trunk/WebCore

Fix for bug 6781, convert QColor to Color (and QRgb to RGBA32). r=maciej.

  • ForwardingHeaders/qcolor.h: Removed.
  • WebCore+SVG/KDOMSettings.h:
  • WebCore+SVG/RGBColorImpl.cpp: (RGBColorImpl::RGBColorImpl): (RGBColorImpl::red): (RGBColorImpl::green): (RGBColorImpl::blue):
  • WebCore+SVG/RGBColorImpl.h:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMCSS.mm: (getWrapperForRGB): (setWrapperForRGB): (removeWrapperForRGB): (-[DOMRGBColor dealloc]): (-[DOMRGBColor finalize]): (-[DOMRGBColor red]): (-[DOMRGBColor green]): (-[DOMRGBColor blue]): (-[DOMRGBColor _initWithRGB:]): (+[DOMRGBColor _RGBColorWithRGB:]): (-[DOMRGBColor alpha]): (-[DOMRGBColor _color]):
  • bridge/mac/MacFrame.mm: (MacFrame::attributedString): (MacFrame::fontAttributesForSelectionStart): (MacFrame::bodyBackgroundColor): (convertAttributesToUnderlines):
  • css/css_valueimpl.cpp: (WebCore::CSSPrimitiveValueImpl::CSSPrimitiveValueImpl): (WebCore::CSSPrimitiveValueImpl::cssText):
  • css/csshelper.h:
  • css/cssparser.cpp: (CSSParser::parseColor): (CSSParser::parseColorFromValue):
  • css/cssparser.h:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::): (WebCore::colorForCSSValue): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
  • css/cssstyleselector.h:
  • kcanvas/KCanvasFilters.h: (KCanvasFEDiffuseLighting::lightingColor): (KCanvasFEDiffuseLighting::setLightingColor): (KCanvasFEFlood::floodColor): (KCanvasFEFlood::setFloodColor): (KCanvasFESpecularLighting::lightingColor): (KCanvasFESpecularLighting::setLightingColor):
  • kcanvas/KCanvasTreeDebug.cpp: (operator<<):
  • kcanvas/KCanvasTreeDebug.h:
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/KRenderingPaintServerGradient.cpp: (KCSortedGradientStopList::addStop):
  • kcanvas/device/KRenderingPaintServerGradient.h:
  • kcanvas/device/KRenderingPaintServerSolid.cpp: (KRenderingPaintServerSolid::color): (KRenderingPaintServerSolid::setColor):
  • kcanvas/device/KRenderingPaintServerSolid.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (ciColor):
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (setupShadingWithStyle):
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (KRenderingPaintServerPatternQuartz::setup):
  • khtml/ecma/kjs_css.h:
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::callAsFunction): (KJS::colorRefFromValue): (KJS::colorFromValue): (KJS::Context2D::putValueProperty): (KJS::GradientFunction::callAsFunction):
  • khtml/ecma/kjs_html.h:
  • khtml/editing/apply_style_command.cpp: (WebCore::StyleChange::checkForLegacyHTMLStyleChange):
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLBodyElementImpl::parseMappedAttribute):
  • khtml/misc/helper.h:
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::DocumentImpl): (WebCore::DocumentImpl::resetLinkColor): (WebCore::DocumentImpl::resetVisitedLinkColor):
  • khtml/xml/DocumentImpl.h: (WebCore::DocumentImpl::setTextColor): (WebCore::DocumentImpl::textColor): (WebCore::DocumentImpl::linkColor): (WebCore::DocumentImpl::visitedLinkColor): (WebCore::DocumentImpl::activeLinkColor): (WebCore::DocumentImpl::setLinkColor): (WebCore::DocumentImpl::setVisitedLinkColor): (WebCore::DocumentImpl::setActiveLinkColor):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (KDOM::CSSStyleSelector::applySVGProperty):
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/css/SVGRenderStyleDefs.h:
  • ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::fillPaintServer):
  • ksvg2/misc/KSVGTimeScheduler.cpp: (KSVG::SVGTimer::notifyAll):
  • ksvg2/svg/SVGAnimateColorElementImpl.cpp: (SVGAnimateColorElementImpl::handleTimerEvent): (SVGAnimateColorElementImpl::clampColor): (SVGAnimateColorElementImpl::color): (SVGAnimateColorElementImpl::initialColor):
  • ksvg2/svg/SVGAnimateColorElementImpl.h:
  • ksvg2/svg/SVGAnimateElementImpl.cpp: (SVGAnimateElementImpl::handleTimerEvent):
  • ksvg2/svg/SVGColorImpl.cpp: (SVGColorImpl::setRGBColor): (SVGColorImpl::color):
  • ksvg2/svg/SVGColorImpl.h:
  • ksvg2/svg/SVGGradientElementImpl.cpp: (SVGGradientElementImpl::rebuildStops):
  • kwq/KWQAccObject.mm: (AXAttributeStringSetStyle):
  • kwq/KWQBrush.h: (QBrush::QBrush::QBrush): (QBrush::color): (QBrush::setColor):
  • kwq/KWQColor.h: Removed.
  • kwq/KWQColor.mm: Removed.
  • kwq/KWQColorData.gperf: Removed.
  • kwq/KWQKConfigBase.h:
  • kwq/KWQKConfigBase.mm: (KConfig::readColorEntry):
  • kwq/KWQLineEdit.mm: (QLineEdit::setPalette):
  • kwq/KWQNamespace.h: (Qt::):
  • kwq/KWQObject.h:
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (QPainter::setPen): (QPainter::setBrush): (QPainter::drawText): (QPainter::drawHighlightForText): (QPainter::selectedTextBackgroundColor): (_fillRectXX): (QPainter::setShadow): (QPainter::initFocusRing):
  • kwq/KWQPalette.h: (QColorGroup::QColorGroup): (QColorGroup::color): (QColorGroup::setColor): (QColorGroup::background): (QColorGroup::foreground): (QColorGroup::base): (QPalette::QPalette): (QPalette::background): (QPalette::foreground):
  • kwq/KWQPen.cpp: (QPen::QPen): (QPen::color): (QPen::setColor):
  • kwq/KWQPen.h:
  • kwq/KWQRenderTreeDebug.cpp: (operator<<):
  • kwq/KWQTextEdit.mm: (QTextEdit::setPalette):
  • loader/CachedImage.cpp: (WebCore::CachedImage::tiled_pixmap):
  • loader/CachedImage.h:
  • page/Frame.cpp: (Frame::paint):
  • page/Frame.h: (MarkedTextUnderline::MarkedTextUnderline):
  • platform/Color.cpp: Added. (WebCore::makeRGB): (WebCore::makeRGBA): (WebCore::parseHexColor): (WebCore::Color::Color): (WebCore::Color::name): (WebCore::Color::setNamedColor): (WebCore::Color::hsv): (WebCore::Color::setHsv): (WebCore::Color::light): (WebCore::Color::dark): (WebCore::Color::getRgbaF):
  • platform/Color.h: Added. (WebCore::Color::Color): (WebCore::Color::rgb): (WebCore::Color::setRgb): (WebCore::operator==): (WebCore::operator!=):
  • platform/ColorData.gperf: Added.
  • rendering/InlineTextBox.cpp: (khtml::simpleDifferenceBetweenColors): (khtml::correctedTextColor): (khtml::InlineTextBox::paint): (khtml::InlineTextBox::paintSelection): (khtml::InlineTextBox::paintMarkedTextBackground): (khtml::InlineTextBox::paintDecoration):
  • rendering/RenderTable.h: (WebCore::RenderTable::bgColor):
  • rendering/RenderTableCell.cpp: (WebCore::outlineBox): (WebCore::RenderTableCell::paintBoxDecorations):
  • rendering/font.cpp: (khtml::Font::drawHighlightForText): (khtml::Font::drawText):
  • rendering/font.h:
  • rendering/render_box.cpp: (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBackgrounds): (WebCore::RenderBox::paintBackground): (WebCore::RenderBox::paintBackgroundExtended): (WebCore::RenderBox::outlineBox):
  • rendering/render_box.h:
  • rendering/render_flow.cpp: (RenderFlow::paintFocusRing): (RenderFlow::paintOutlineForLine):
  • rendering/render_form.cpp: (RenderFieldset::paintBorderMinusLegend):
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize):
  • rendering/render_image.cpp: (WebCore::RenderImage::paint):
  • rendering/render_layer.h:
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintBackgrounds): (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder): (WebCore::InlineFlowBox::paintDecorations): (WebCore::EllipsisBox::paint):
  • rendering/render_line.h:
  • rendering/render_list.cpp: (RenderListMarker::paint):
  • rendering/render_object.cpp: (WebCore::RenderObject::drawBorder): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::paintOutline): (WebCore::RenderObject::selectionColor): (WebCore::RenderObject::getTextDecorationColors):
  • rendering/render_object.h: (WebCore::RenderObject::paintBackgroundExtended):
  • rendering/render_replaced.cpp: (WebCore::RenderReplaced::selectionColor):
  • rendering/render_replaced.h:
  • rendering/render_style.h: (khtml::BorderValue::isTransparent): (khtml::CollapsedBorderValue::color): (khtml::RenderStyle::hasBackground): (khtml::RenderStyle::borderLeftColor): (khtml::RenderStyle::borderRightColor): (khtml::RenderStyle::borderTopColor): (khtml::RenderStyle::borderBottomColor): (khtml::RenderStyle::outlineColor): (khtml::RenderStyle::color): (khtml::RenderStyle::backgroundColor): (khtml::RenderStyle::setBackgroundColor): (khtml::RenderStyle::setBorderLeftColor): (khtml::RenderStyle::setBorderRightColor): (khtml::RenderStyle::setBorderTopColor): (khtml::RenderStyle::setBorderBottomColor): (khtml::RenderStyle::setOutlineColor): (khtml::RenderStyle::setColor): (khtml::RenderStyle::initialColor):
  • rendering/render_theme.cpp: (khtml::RenderTheme::isControlStyled):
  • rendering/render_theme.h:
3:27 PM Changeset in webkit [12339] by darin
  • 5 edits in trunk/WebCore

Reviewed by John and Anders.

  • khtml/ecma/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::getValueProperty): Clean up a bit, using PassRefPtr where appropriate. (KJS::JSXMLHttpRequest::mark): Remove get calls now that getter functions don't return PassRefPtr. (KJS::JSXMLHttpRequest::JSXMLHttpRequest): Put the object into the DOM objects map. (KJS::JSXMLHttpRequest::~JSXMLHttpRequest): Remove the object from the DOM objects map. Also clear out both listeners so the implementation object isn't left with dangling pointers (since we won't be around to mark those objects any more). (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Tightened up the code a bit.
  • xml/xmlhttprequest.h:
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getResponseXML): Change to return just a plain old pointer. Remove the unnecessary typeIsXML boolean. (WebCore::XMLHttpRequest::onReadyStateChangeListener): Change to return just a plain old pointer. Update for name changes. (WebCore::XMLHttpRequest::setOnReadyStateChangeListener): Ditto. (WebCore::XMLHttpRequest::onLoadListener): Ditto. (WebCore::XMLHttpRequest::setOnLoadListener): Ditto. (WebCore::XMLHttpRequest::send): Protect the DOM wrapper if any as well as ourselves while the load is in progress. (WebCore::XMLHttpRequest::abort): Unprotect to balance out the above. (WebCore::XMLHttpRequest::slotFinished): Ditto.
  • khtml/ecma/JSXMLHttpRequest.h: Just formatting changes.
3:23 PM Changeset in webkit [12338] by darin
  • 3 edits in trunk/WebCore

Reviewed by Justin.

  • khtml/xml/ContainerNodeImpl.h: Remove some internals that don't need to be member functions.
  • khtml/xml/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::insertBefore): Improved algorithm to keep refs to more things so that we don't end up with a dangling pointer (fixes the crash) and so that we do not crash if someone modifies the tree inside a DOM mutation event handler (theoretical only at this point, needs test cases). (WebCore::ContainerNodeImpl::replaceChild): Ditto. (WebCore::willRemoveChild): Changed from member function to free function. (WebCore::ContainerNodeImpl::removeChild): Fix potential problem if the mutation event handler moves the node into a different parent. (WebCore::ContainerNodeImpl::appendChild): Made changes like those in insertBefore above. (WebCore::dispatchChildInsertionEvents): Changed from member function to free function. Tightened up handling of some edge cases. (WebCore::dispatchChildRemovalEvents): Ditto.
3:14 PM Changeset in webkit [12337] by darin
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

  • khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): Fix local variable "frame" that was shadowing another local variable named "frame" by naming the one for the new frame "newFrame".
10:25 AM Changeset in webkit [12336] by thatcher
  • 14 copies
    2 deletes in tags/Safari-521.6.1

new tag.

10:18 AM Changeset in webkit [12335] by thatcher
  • 4 edits in branches/Safari-Leo-branch

Versioning.

9:21 AM Changeset in webkit [12334] by andersca
  • 2 edits in trunk/JavaScriptCore

2006-01-23 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.


  • kjs/lookup.h:
Prefix all KJS types with KJS
in KJS_DEFINE_PROTOTYPE. (cacheGlobalObject): Move this out of the KJS namespace.
2:13 AM Changeset in webkit [12333] by darin
  • 1 edit in trunk/WebCore/WebCore+SVG/SVGElementFactoryWrapper.cpp

Touch the wrapper so it rebuilds. We need a better solution for this.

2:02 AM Changeset in webkit [12332] by mjs
  • 2 edits in trunk/WebCore
  • fix build
  • ksvg2/scripts/make_names.pl: Update script to generate code that works with the new HashMap.
1:04 AM Changeset in webkit [12331] by darin
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • fixed a storage leak found by running run-webkit-tests fast --leak
  • khtml/xml/dom_xmlimpl.cpp: (ProcessingInstructionImpl::checkStyleSheet): Removed bogus deref call, since the RefPtr handles it for us. Also deployed PassRefPtr in one place. (ProcessingInstructionImpl::setStyleSheet): Removed more bogus ref/deref calls.

Jan 23, 2006:

11:51 PM Changeset in webkit [12330] by mjs
  • 5 edits in trunk/WebCore

Rubber stamped by Eric.

  • Made some functions return const AtomicString& instead of AtomicString because they could.


Result of Darin's and Eric's comments on the last patch.

  • khtml/html/HTMLGenericFormElementImpl.cpp: (WebCore::HTMLGenericFormElementImpl::name):
  • khtml/html/HTMLGenericFormElementImpl.h:
  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::name):
  • khtml/html/HTMLInputElementImpl.h:
11:31 PM Changeset in webkit [12329] by mjs
  • 48 edits in trunk

JavaScriptCore:

Reviewed by Eric.

  • renamed PointerHash to PtrHash
  • made PtrHash the default hash function for int and pointer types that aren't further specialized
  • added an AtomicStringImpl class to make it easier and more typesafe to identity hash atomic strings
  • did appropriate consequent cleanup (very few places now need to declare a hash function) ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6752


  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): no need to mention PointerHash
  • kjs/collector.cpp: ditto
  • kjs/identifier.cpp: (KXMLCore::): declare DefaultHash the new way
  • kjs/internal.cpp: no need to mention PointerHash
  • kjs/ustring.h:
  • kxmlcore/HashCountedSet.h: change how we get the default hash to make it easier to specialize on PtrHash
  • kxmlcore/HashFunctions.h: (KXMLCore::): renamed PointerHash to PtrHash; changed DefaultHash so that it has a Hash typedef rather than being a hash function class itself; declared DefaultHash for int and partializy specialized for pointer types
  • kxmlcore/HashMapPtrSpec.h: (KXMLCore::PtrHashIteratorAdapter::PtrHashIteratorAdapter): Slight tweaks for new way of handling pointer hash (KXMLCore::PtrHashConstIteratorAdapter::PtrHashConstIteratorAdapter): ditto (KXMLCore::): ditto
  • kxmlcore/HashMap.h: ditto
  • kxmlcore/HashSet.h: ditto

WebCore:

Reviewed by Eric.

  • renamed PointerHash to PtrHash
  • made PtrHash the default hash function for int and pointer types that aren't further specialized
  • added an AtomicStringImpl class to make it easier and more typesafe to identity hash atomic strings
  • did appropriate consequent cleanup (very few places now need to declare a hash function) ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6752


  • bindings/objc/DOM.mm:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge elementWithName:inForm:]):
  • css/cssstyleselector.cpp: (WebCore::CSSRuleSet::getIDRules): (WebCore::CSSRuleSet::getClassRules): (WebCore::CSSRuleSet::getTagRules): (WebCore::CSSRuleSet::addToRuleSet):
  • khtml/dom/dom_string.h: (KXMLCore::):
  • khtml/ecma/kjs_binding.cpp: (KJS::UString::UString):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::mark):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLElement::classInfo): (KJS::HTMLElement::accessors): (KJS::HTMLElement::selectSetter): (KJS::HTMLElement::inputSetter): (KJS::HTMLElement::textAreaSetter): (KJS::HTMLElement::buttonSetter):
  • khtml/ecma/kjs_window.h:
  • khtml/editing/apply_style_command.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
  • khtml/html/HTMLCollectionImpl.h:
  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::isRecognizedTagName): (WebCore::inlineTagList): (WebCore::blockTagList):
  • khtml/html/HTMLFormCollectionImpl.cpp: (WebCore::HTMLFormCollectionImpl::updateNameCache):
  • khtml/html/HTMLGenericFormElementImpl.cpp: (WebCore::HTMLGenericFormElementImpl::name): (WebCore::HTMLGenericFormElementImpl::setName):
  • khtml/html/HTMLGenericFormElementImpl.h:
  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::name):
  • khtml/html/HTMLInputElementImpl.h:
  • khtml/html/htmlfactory.cpp: (DOM::HTMLElementFactory::createHTMLElement):
  • khtml/html/htmlparser.cpp: (HTMLParser::isHeaderTag): (HTMLParser::isResidualStyleTag): (HTMLParser::isAffectedByResidualStyle):
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::checkedRadioButtonForGroup): (WebCore::DocumentImpl::removeRadioButtonGroup):
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/NodeImpl.h:
  • khtml/xml/dom_atomicstring.h: (DOM::AtomicString::AtomicString): (DOM::AtomicString::impl): (KXMLCore::):
  • khtml/xml/dom_stringimpl.cpp: (DOM::equal):
  • khtml/xml/dom_stringimpl.h: (KXMLCore::):
  • khtml/xml/xml_tokenizer.h:
  • ksvg2/misc/KSVGTimeScheduler.cpp: (KSVG::SVGTimer::notifyAll):
  • kwq/KWQKJobClasses.h:
  • kwq/KWQObject.cpp:
  • loader/CachedObject.h:
  • loader/CachedObjectClientWalker.h:
  • loader/loader.h:
  • page/Frame.cpp: (Frame::endAllLifeSupport):
  • rendering/render_canvas.cpp: (RenderCanvas::selectionRect): (RenderCanvas::setSelection):
  • rendering/render_canvas.h:
  • rendering/render_object.h:
  • xml/xmlhttprequest.h:
10:24 PM Changeset in webkit [12328] by mjs
  • 8 edits in trunk/JavaScriptCore

Reviewed by Tim Omernick.


  • kjs/array_object.cpp:
  • kjs/identifier.cpp:
  • kjs/internal.cpp:
  • kxmlcore/HashMap.h: (KXMLCore::PairFirstExtractor::extract):
  • kxmlcore/HashMapPtrSpec.h: (KXMLCore::):
  • kxmlcore/HashSet.h: (KXMLCore::IdentityExtractor::extract):
  • kxmlcore/HashTable.h: (KXMLCore::addIterator): (KXMLCore::removeIterator): (KXMLCore::HashTable::add): (KXMLCore::HashTable::isEmptyBucket): (KXMLCore::HashTable::isDeletedBucket): (KXMLCore::HashTable::HashTable): (KXMLCore::HashTable::lookup): (KXMLCore::HashTable::add): (KXMLCore::HashTable::reinsert): (KXMLCore::HashTable::find): (KXMLCore::HashTable::contains): (KXMLCore::HashTable::remove): (KXMLCore::HashTable::allocateTable): (KXMLCore::HashTable::deallocateTable): (KXMLCore::HashTable::expand): (KXMLCore::HashTable::rehash): (KXMLCore::HashTable::clear): (KXMLCore::HashTable::swap): (KXMLCore::HashTable::operator): (KXMLCore::HashTable::checkTableConsistency): (KXMLCore::HashTable::checkTableConsistencyExceptSize): (KXMLCore::HashTable::invalidateIterators):
8:23 PM Changeset in webkit [12327] by darin
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • rendering/render_form.cpp: (RenderLineEdit::slotTextChanged): Made newText a DOMString. Assigning the empty DOMString to a QString and back to a DOMString resulted in a null string, which should be avoided here.
  • khtml/dom/dom_string.cpp: (DOM::DOMString::qstring): Don't turn an empty DOMString into a null QString; make an empty QString instead.
8:20 PM Changeset in webkit [12326] by darin
  • 1 edit
    1 add in trunk/WebKitTools
  • Scripts/update-webkit-localizable-strings: Added.
8:18 PM Changeset in webkit [12325] by darin
  • 4 edits in trunk/WebKit
  • fixed some small localizable strings issues
  • WebInspector.subproj/WebInspector.m: (-[DOMNode _nodeTypeName]): Changed so we don't have two localizable strings that are both "Document". I'm not sure we want to localize the DOM inspector UI at all, but this fixes things for now. (-[DOMNode _displayName]): Ditto.
  • English.lproj/Localizable.strings: Updated.
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
8:08 PM Changeset in webkit [12324] by darin
  • 1 edit
    6 adds in trunk/LayoutTests
  • fast/frames/frame-element-name.html: Added.
  • fast/frames/frame-element-name-expected.txt: Added.
  • fast/frames/frame-element-name-expected.png: Added.
  • fast/frames/frame-element-name-expected.checksum: Added.
8:08 PM Changeset in webkit [12323] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Test: fast/frames/frame-element-name.html

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getOwnPropertySlot): Remove the quirk where frame and iframe elements reflect all the properties of the window inside the frame. Testing indicates that no other browser does this -- not sure why we were doing it.
5:38 PM Changeset in webkit [12322] by thatcher
  • 1 edit in trunk/WebCore/bridge/mac/BrowserExtensionMac.mm

Build fix to workaround 4213314.

4:56 PM Changeset in webkit [12321] by mjs
  • 24 edits in trunk

JavaScriptCore:

Rubber stamped by Tim Hatcher.


  • renamed inert() operation on HashSet, HashCountedSet and HashTable to add() for consistency with HashMap
  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction):
  • kjs/collector.cpp: (KJS::Collector::protect):
  • kjs/identifier.cpp: (KJS::Identifier::add):
  • kxmlcore/HashCountedSet.h: (KXMLCore::::add):
  • kxmlcore/HashMap.h: (KXMLCore::::inlineAdd):
  • kxmlcore/HashSet.h: (KXMLCore::::add):
  • kxmlcore/HashTable.h: (KXMLCore::HashTable::add): (KXMLCore::::add): (KXMLCore::::HashTable):

WebCore:

Rubber stamped by Tim Hatcher.


  • renamed inert() operation on HashSet, HashCountedSet and HashTable to add() for consistency with HashMap
  • bridge/mac/MacFrame.mm: (MacFrame::didTellBridgeAboutLoad):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::mark):
  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::isRecognizedTagName): (WebCore::inlineTagList): (WebCore::blockTagList):
  • khtml/html/HTMLFormCollectionImpl.cpp: (WebCore::HTMLFormCollectionImpl::updateNameCache):
  • khtml/html/htmlparser.cpp: (HTMLParser::isHeaderTag): (HTMLParser::isResidualStyleTag): (HTMLParser::isAffectedByResidualStyle):
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::addElementById): (WebCore::DocumentImpl::registerDisconnectedNodeWithEventListeners):
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::registerNodeList):
  • khtml/xml/dom_atomicstring.cpp: (DOM::AtomicString::add):
  • khtml/xml/dom_qname.cpp: (DOM::QualifiedName::QualifiedName):
  • loader/CachedObject.cpp: (WebCore::CachedObject::ref):
  • page/Frame.cpp: (Frame::keepAlive):
  • rendering/render_canvas.cpp: (RenderCanvas::addWidget):
  • rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paint):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::addToRequestsByDocument):
4:25 PM Changeset in webkit [12320] by thatcher
  • 2 edits in trunk

Build fix.

4:23 PM Changeset in webkit [12319] by justing
  • 6 edits in trunk

Reviewed by thatcher
Turned on -O2 for Default and OptimizedWithSymbols.

3:38 PM Changeset in webkit [12318] by thatcher
  • 1 edit in trunk/WebCore/bridge/mac/WebCoreFrameBridge.h

Fix for when building in a clean sandbox and WebKit isn't built yet.

1:41 PM Changeset in webkit [12317] by mjs
  • 74 edits in trunk/JavaScriptCore

Reviewed by Tim Hatcher.


  • it's "Franklin Street", not "Franklin Steet"
  • kjs/array_instance.h:
  • kjs/array_object.cpp:
  • kjs/array_object.h:
  • kjs/bool_object.cpp:
  • kjs/bool_object.h:
  • kjs/collector.cpp:
  • kjs/collector.h:
  • kjs/completion.h:
  • kjs/context.h:
  • kjs/date_object.cpp:
  • kjs/date_object.h:
  • kjs/debugger.cpp:
  • kjs/debugger.h:
  • kjs/dtoa.h:
  • kjs/error_object.cpp:
  • kjs/error_object.h:
  • kjs/function.cpp:
  • kjs/function.h:
  • kjs/function_object.cpp:
  • kjs/function_object.h:
  • kjs/grammar.y:
  • kjs/identifier.cpp:
  • kjs/identifier.h:
  • kjs/internal.cpp:
  • kjs/internal.h:
  • kjs/interpreter.cpp:
  • kjs/interpreter.h:
  • kjs/lexer.cpp:
  • kjs/lexer.h:
  • kjs/list.cpp:
  • kjs/list.h:
  • kjs/lookup.cpp:
  • kjs/lookup.h:
  • kjs/math_object.cpp:
  • kjs/math_object.h:
  • kjs/nodes.cpp:
  • kjs/nodes.h:
  • kjs/nodes2string.cpp:
  • kjs/number_object.cpp:
  • kjs/number_object.h:
  • kjs/object.cpp:
  • kjs/object.h:
  • kjs/object_object.cpp:
  • kjs/object_object.h:
  • kjs/operations.cpp:
  • kjs/operations.h:
  • kjs/property_map.cpp:
  • kjs/property_map.h:
  • kjs/property_slot.cpp:
  • kjs/property_slot.h:
  • kjs/reference.cpp:
  • kjs/reference.h:
  • kjs/reference_list.cpp:
  • kjs/reference_list.h:
  • kjs/regexp.cpp:
  • kjs/regexp.h:
  • kjs/regexp_object.cpp:
  • kjs/regexp_object.h:
  • kjs/scope_chain.cpp:
  • kjs/scope_chain.h:
  • kjs/simple_number.h:
  • kjs/string_object.cpp:
  • kjs/string_object.h:
  • kjs/testkjs.cpp:
  • kjs/types.h:
  • kjs/ustring.cpp:
  • kjs/ustring.h:
  • kjs/value.cpp:
  • kjs/value.h:
  • kxmlcore/AlwaysInline.h:
  • kxmlcore/ListRefPtr.h:
  • kxmlcore/PassRefPtr.h:
  • kxmlcore/RefPtr.h:
9:13 AM Changeset in webkit [12316] by darin
  • 1 edit
    2 adds in trunk/WebKitTools
  • added a couple of scripts -- more about these two soon
  • Scripts/extract-localizable-strings: Added.
  • Scripts/merge-changelog: Added.
9:10 AM Changeset in webkit [12315] by darin
  • 5 edits in trunk/JavaScriptCore

Reviewed by John Sullivan.

  • kxmlcore/PassRefPtr.h: Fix assignment operator from RefPtr of a different type by calling get() instead of going directly at m_ptr.
  • kxmlcore/RefPtr.h: Ditto.
  • other changes
  • JavaScriptCore.xcodeproj/project.pbxproj: Xcode decided to change this file. It's just a resorted list of keys in a dictionary.
  • kjs/fpconst.cpp: Wrap this file in #if APPLE since the alternate version in internal.cpp is in #if __APPLE. This file is to give us the "no init routine" property we want to have on OS X.
9:10 AM Changeset in webkit [12314] by darin
  • 1 edit
    2 adds in trunk/LayoutTests

Suggested by Anders.

  • fast/dom/clone-node-form-elements-with-attr.html: Added.
  • fast/dom/clone-node-form-elements-with-attr-expected.txt: Added.
9:07 AM Changeset in webkit [12313] by darin
  • 40 edits in trunk/WebCore

Reviewed by John Sullivan.

Test: fast/dom/clone-node-form-elements-with-attr.html

Changed cloneNode and some other functions to return PassRefPtr.
Also made m_render private and changed its name to m_renderer.

  • bindings/objc/DOM.mm: (-[DOMNode cloneNode:]): Add call to get() needed now that cloneNode returns a PassRefPtr.
  • khtml/editing/break_blockquote_command.cpp: (WebCore::BreakBlockquoteCommand::doApply):
  • khtml/editing/insert_paragraph_separator_command.cpp: (khtml::InsertParagraphSeparatorCommand::doApply):
  • khtml/editing/split_element_command.cpp: (khtml::SplitElementCommand::doApply):
  • khtml/html/htmlparser.cpp: (HTMLParser::handleResidualStyleCloseTagAcrossBlocks): (HTMLParser::reopenResidualStyleTags):
  • khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::processContents):
  • ksvg2/svg/SVGUseElementImpl.cpp: (SVGUseElementImpl::closeRenderer): Use RefPtr and PassRefPtr as appropriate, since the result of cloneNode is now a referenced object in a PassRefPtr rather than a floating one and so needs to be kept referenced until used.
  • khtml/html/HTMLElementImpl.h:
  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::cloneNode): Changed to return a PassRefPtr. (WebCore::HTMLElementImpl::children): Ditto.
  • khtml/xml/DocumentFragmentImpl.h:
  • khtml/xml/DocumentFragmentImpl.cpp: (DOM::DocumentFragmentImpl::cloneNode): Changed to return a PassRefPtr.
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/DocumentTypeImpl.h:
  • khtml/xml/DocumentTypeImpl.cpp: (DOM::DocumentTypeImpl::cloneNode): Changed to return a PassRefPtr.
  • khtml/xml/NamedNodeMapImpl.h: (WebCore::NamedNodeMapImpl::getNamedItem): Changed to return PassRefPtr. (WebCore::NamedNodeMapImpl::removeNamedItem): Ditto. (WebCore::NamedNodeMapImpl::setNamedItemNS): Ditto.
  • khtml/html/HTMLGenericFormElementImpl.cpp: (WebCore::HTMLGenericFormElementImpl::attach): Use renderer() instead of getting at m_render directly. (WebCore::HTMLGenericFormElementImpl::recalcStyle): Ditto. (WebCore::HTMLGenericFormElementImpl::isFocusable): Ditto. (WebCore::HTMLGenericFormElementImpl::isKeyboardFocusable): Ditto. (WebCore::HTMLGenericFormElementImpl::isMouseFocusable): Ditto.
  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::selectionStart): Ditto. (WebCore::HTMLInputElementImpl::selectionEnd): Ditto. (WebCore::HTMLInputElementImpl::setSelectionStart): Ditto. (WebCore::HTMLInputElementImpl::setSelectionEnd): Ditto. (WebCore::HTMLInputElementImpl::select): Ditto. (WebCore::HTMLInputElementImpl::setSelectionRange): Ditto. (WebCore::HTMLInputElementImpl::parseMappedAttribute): Ditto. (WebCore::HTMLInputElementImpl::setValue): Ditto. (WebCore::HTMLInputElementImpl::defaultEventHandler): Ditto.
  • khtml/html/HTMLSelectElementImpl.cpp: (WebCore::HTMLSelectElementImpl::recalcStyle): Ditto. (WebCore::HTMLSelectElementImpl::setRecalcListItems): Ditto. (WebCore::HTMLSelectElementImpl::reset): Ditto. (WebCore::HTMLSelectElementImpl::notifyOptionSelected): Ditto. (WebCore::HTMLSelectElementImpl::defaultEventHandler): Ditto.
  • khtml/html/HTMLTextAreaElementImpl.cpp: (WebCore::HTMLTextAreaElementImpl::selectionStart): Ditto. (WebCore::HTMLTextAreaElementImpl::selectionEnd): Ditto. (WebCore::HTMLTextAreaElementImpl::setSelectionStart): Ditto. (WebCore::HTMLTextAreaElementImpl::setSelectionEnd): Ditto. (WebCore::HTMLTextAreaElementImpl::select): Ditto. (WebCore::HTMLTextAreaElementImpl::setSelectionRange): Ditto. (WebCore::HTMLTextAreaElementImpl::updateValue): Ditto. (WebCore::HTMLTextAreaElementImpl::setValue): Ditto.
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::updateForNewURL): Ditto. (WebCore::HTMLFrameElementImpl::openURL): Ditto. (WebCore::HTMLFrameElementImpl::attach): Ditto. (WebCore::HTMLFrameElementImpl::close): Ditto. (WebCore::HTMLFrameElementImpl::willRemove): Ditto. (WebCore::HTMLFrameElementImpl::isFocusable): Ditto. (WebCore::HTMLFrameElementImpl::setFocus): Ditto. (WebCore::HTMLFrameElementImpl::frameWidth): Ditto. (WebCore::HTMLFrameElementImpl::frameHeight): Ditto. (WebCore::HTMLFrameSetElementImpl::defaultEventHandler): Ditto. (WebCore::HTMLFrameSetElementImpl::recalcStyle): Ditto. (WebCore::HTMLIFrameElementImpl::attach): Ditto. (WebCore::HTMLIFrameElementImpl::recalcStyle): Ditto.
  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLImageElementImpl::parseMappedAttribute): Ditto. (WebCore::HTMLImageElementImpl::width): Ditto. (WebCore::HTMLImageElementImpl::height): Ditto.
  • khtml/html/html_inlineimpl.cpp: (WebCore::HTMLAnchorElementImpl::isFocusable): Ditto.
  • khtml/html/html_listimpl.cpp: (DOM::HTMLLIElementImpl::parseMappedAttribute): Ditto. (DOM::HTMLLIElementImpl::attach): Ditto.
  • khtml/html/html_objectimpl.cpp: (WebCore::HTMLAppletElementImpl::getAppletInstance): Ditto. (WebCore::HTMLAppletElementImpl::closeRenderer): Ditto. (WebCore::HTMLEmbedElementImpl::getEmbedInstance): Ditto. (WebCore::HTMLEmbedElementImpl::attach): Ditto. (WebCore::HTMLObjectElementImpl::getObjectInstance): Ditto. (WebCore::HTMLObjectElementImpl::parseMappedAttribute): Ditto. (WebCore::HTMLObjectElementImpl::attach): Ditto. (WebCore::HTMLObjectElementImpl::detach): Ditto. (WebCore::HTMLObjectElementImpl::recalcStyle): Ditto.
  • khtml/html/html_tableimpl.cpp: (WebCore::HTMLTableElementImpl::parseMappedAttribute): Ditto. (WebCore::HTMLTableElementImpl::attach): Ditto.
  • khtml/xml/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::getUpperLeftCorner): Ditto. (WebCore::ContainerNodeImpl::getLowerRightCorner): Ditto. (WebCore::ContainerNodeImpl::setActive): Ditto. (WebCore::ContainerNodeImpl::setHovered): Ditto.
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::~DocumentImpl): Ditto. (WebCore::DocumentImpl::elementFromPoint): Ditto. (WebCore::DocumentImpl::recalcStyle): Ditto. (WebCore::DocumentImpl::attach): Ditto. (WebCore::DocumentImpl::restoreRenderer): Ditto. (WebCore::DocumentImpl::detach): Ditto. (WebCore::DocumentImpl::setVisuallyOrdered): Ditto. (WebCore::DocumentImpl::updateSelection): Ditto. (WebCore::DocumentImpl::prepareMouseEvent): Ditto. (WebCore::DocumentImpl::cloneNode): Changed to return PassRefPtr. (WebCore::DocumentImpl::recalcStyleSelector): Use renderer() instead of getting at m_render directly. (WebCore::DocumentImpl::setInPageCache): Ditto.
  • khtml/xml/NodeImpl.h:
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::NodeImpl): Changed m_render to m_renderer. (WebCore::NodeImpl::~NodeImpl): Changed use of m_render to renderer(). (WebCore::NodeImpl::getRect): Ditto. (WebCore::NodeImpl::attach): Ditto. (WebCore::NodeImpl::detach): Ditto. (WebCore::NodeImpl::createRendererIfNeeded): Ditto. (WebCore::NodeImpl::getElementsByTagName): Changed to return PassRefPtr. (WebCore::NodeImpl::getElementsByTagNameNS): Ditto.
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_elementimpl.cpp: (WebCore::AttrImpl::cloneNode): Changed to return PassRefPtr. (WebCore::ElementImpl::cloneNode): Ditto. (WebCore::ElementImpl::scrollIntoView): Use renderer() instead of m_render. (WebCore::ElementImpl::scrollIntoViewIfNeeded): Ditto. (WebCore::ElementImpl::recalcStyle): Ditto. (WebCore::ElementImpl::setAttributeNode): Changed to return PassRefPtr. (WebCore::ElementImpl::removeAttributeNode): Ditto. (WebCore::NamedAttrMapImpl::removeNamedItemNS): Ditto. (WebCore::NamedAttrMapImpl::setNamedItem): Ditto. (WebCore::NamedAttrMapImpl::removeNamedItem): Ditto. (DOM::ElementImpl::setAttributeNodeNS): Ditto.
  • khtml/xml/dom_textimpl.h:
  • khtml/xml/dom_textimpl.cpp: (CharacterDataImpl::setData): Changed use of m_render to renderer(). (CharacterDataImpl::appendData): Ditto. (CharacterDataImpl::insertData): Ditto. (CharacterDataImpl::deleteData): Ditto. (CharacterDataImpl::replaceData): Ditto. (CommentImpl::cloneNode): Changed to return PassRefPtr. (TextImpl::splitText): Changed use of m_render to renderer(). (TextImpl::cloneNode): Changed to return PassRefPtr. (TextImpl::recalcStyle): Changed use of m_render to renderer(). (CDATASectionImpl::cloneNode): Changed to return PassRefPtr.
  • khtml/xml/dom_xmlimpl.h:
  • khtml/xml/dom_xmlimpl.cpp: (DOM::EntityImpl::cloneNode): Changed to return PassRefPtr. (DOM::EntityReferenceImpl::cloneNode): Ditto. (DOM::NotationImpl::cloneNode): Ditto. (DOM::ProcessingInstructionImpl::cloneNode): Ditto.
  • removed unused code
  • khtml/html/html_documentimpl.cpp: Removed unused slotHistoryChanged function.
  • khtml/html/html_documentimpl.h: Ditto.
  • kwq/KWQObject.cpp: (QObject::connect): Removed special case for slotHistoryChanged, no longer used.
  • fixed storage leak
  • bridge/mac/MacFrame.mm: (MacFrame::~MacFrame): Delete window widget.
7:30 AM Changeset in webkit [12312] by harrison
  • 1 edit
    4 adds in trunk/LayoutTests

<rdar://problem/4026906> Paste of HTML table content can break table structure

  • editing/pasteboard/paste-4039777-fix-expected.checksum: Added.
  • editing/pasteboard/paste-4039777-fix-expected.png: Added.
  • editing/pasteboard/paste-4039777-fix-expected.txt: Added.
  • editing/pasteboard/paste-4039777-fix.html: Added.
4:00 AM Changeset in webkit [12311] by andersca
  • 1 edit
    1 add in trunk/WebCore

2006-01-23 Anders Carlsson <​andersca@mac.com>

Forgot to add this as part of
​http://bugzilla.opendarwin.org/show_bug.cgi?id=3869


  • manual-tests/resources/webkit-background.png: Added.
2:14 AM Changeset in webkit [12310] by darin
  • 2 edits in trunk/WebCore
  • fix layout tests
  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Added missing code to set wrapInAnonymousSection false in the case where adding a footer.
12:47 AM Changeset in webkit [12309] by mjs
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Add missing reviewer.

12:44 AM Changeset in webkit [12308] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by NOBODY (OOPS!).

  • kjs/interpreter.h: make globalExec virtual so ScriptInterpreter can override it
12:36 AM Changeset in webkit [12307] by mjs
  • 17 edits
    4 adds in trunk/WebCore

Reviewed by Darin.


  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (MacFrame::MacFrame): Initialize _bridge (MacFrame::~MacFrame): Clear the bridge's frame pointer and release it. (Frame::frameDetached): Reverse order of removing from old-style frames array and calling frameDetached. (MacFrame::createPart): Don't ref the part when creating it, since the child bridge is no longer going to own a ref. (MacFrame::setBridge): KWQRetain / KWQRelease since we know own the bridge. (MacFrame::detachFromView): New method; clear out the view.
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (Bridge): Helper method to get a WebCoreFrameBridge from a Frame. (-[WebCoreFrameBridge firstChild]): Call through Frame. (-[WebCoreFrameBridge lastChild]): ditto (-[WebCoreFrameBridge childCount]): ditto (-[WebCoreFrameBridge previousSibling]): ditto (-[WebCoreFrameBridge nextSibling]): ditto (-[WebCoreFrameBridge isDescendantOfFrame:]): No need to cast parent pointer. (-[WebCoreFrameBridge appendChild:]): Call through Frame. (-[WebCoreFrameBridge _clearRenderPart]): New helper method to free the renderPart when removing a child. (-[WebCoreFrameBridge removeChild:]): Clear child's render part and call through to Frame. (-[WebCoreFrameBridge dealloc]): Remove unneeded m_frame-related code. (-[WebCoreFrameBridge finalize]): ditto (-[WebCoreFrameBridge clearFrame]): New helper method, needed now that bridge can outlive frame. (-[WebCoreFrameBridge handleFallbackContent]): Make safe against a null frame. (-[WebCoreFrameBridge removeFromFrame]): ditto
  • bridge/mac/WebCorePageBridge.h:
  • bridge/mac/WebCorePageBridge.mm: (-[WebCorePageBridge initWithMainFrame:]): Create a Page instance. (-[WebCorePageBridge dealloc]): Delete the Page. (-[WebCorePageBridge mainFrame]): Get the main frame from the Page.
  • khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::globalExec): Override; keep frame alive, then call superclass.
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_proxy.cpp: (KJSProxyImpl::clear): Don't pass exec to window. (KJSProxyImpl::interpreter): Don't do keepAlive.
  • khtml/ecma/kjs_window.cpp: (KJS::Window::isSafeScript): If the active part's document is gone, use the frame's URL for security check purposes. (KJS::Window::clear): Don't take an ExecState parameter any more - it wasn't used.
  • khtml/ecma/kjs_window.h:
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::implicitOpen): If we've got a tokenizer, delete it before closing - you don't ever want to fire an onload handler because of an open.
  • page/Frame.cpp: (Frame::init): Pass `this' to FramePrivate constructor. (FrameCounter::~FrameCounter): Added debug counting of leftover Frame objects on exit. (Frame::Frame): Moved out-of-line. Increment debug counter. (Frame::~Frame): Assert that there is no life support going, either at the start or end of this method. Decrement frame counter. (Frame::stopLoading): tweaked for the fact that ChildFrame::m_frame is now a RefPtr. (Frame::clear): ditto (Frame::stop): ditto (Frame::stopAnimations): ditto (Frame::checkEmitLoadEvent): ditto (Frame::processObjectRequest): ditto (Frame::childFrame): ditto (Frame::findFrame): ditto (Frame::setZoomFactor): ditto (Frame::frames): ditto (Frame::connectChild): ditto (Frame::disconnectChild): ditto (Frame::endAllLifeSupport): Method that, in debug mode, will clear all life suppor timers so the Frame exit counter works. (Frame::keepAlive): In debug mode, add proper support for endAllLifeSupport (Frame::slotEndLifeSupport): ditto (Frame::setPolicyBaseURL): Update for the fact that ChildFrame::m_frame is now a RefPtr. (Frame::treeNode): New helper method, get the FrameTreeNode class that implements frame tree traversal. (Frame::nextSibling): Simple wrapper that calls through to treeNode(). (Frame::previousSibling): ditto (Frame::firstChild): ditto (Frame::lastChild): ditto (Frame::childCount): ditto (Frame::appendChild): ditto (Frame::removeChild): ditto (Frame::detachFromView): no-op, just a virtual base for the MAcFrame method.
  • page/Frame.h:
  • page/FramePrivate.h: (FramePrivate::FramePrivate): Add FrameTreeNode member.
  • page/FrameTreeNode.cpp: Added. (FrameTreeNode::~FrameTreeNode): detach all children from their view (FrameTreeNode::appendChild): implemented (FrameTreeNode::removeChild): implemented - make sure to detach child from its view.
  • page/FrameTreeNode.h: Added. (FrameTreeNode::FrameTreeNode): New; initialize fields tht need it. (FrameTreeNode::nextSibling): Trivial inline. (FrameTreeNode::previousSibling): ditto (FrameTreeNode::firstChild): ditto (FrameTreeNode::lastChild): ditto (FrameTreeNode::childCount): ditto
  • page/Page.cpp: Added. (Page::Page): Initialize mainFrame and bump pageCount appropriately. (Page::~Page): Detach main frame from view, handle ending life support when last frame is destroyed.
  • page/Page.h: Added. (Page::mainFrame): Trivial inline.
  • WebCore.xcodeproj/project.pbxproj: Add new files.
Note: See TracTimeline for information about the timeline view.