Timeline



Feb 1, 2006:

11:42 PM Changeset in webkit [12521] by mjs
  • 16 edits in trunk/WebCore

Reviewed by Darin.

  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::generateFrameName): (WebCore::MacFrame::submitForm): (WebCore::Frame::frameDetached): (WebCore::MacFrame::nextKeyViewInFrameHierarchy): (WebCore::MacFrame::createEmptyDocument):
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setParent:]): (-[WebCoreFrameBridge parent]): (-[WebCoreFrameBridge setName:]): (-[WebCoreFrameBridge name]):
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::put): (KJS::Window::isSafeScript): (KJS::WindowFunc::callAsFunction):
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::isURLAllowed):
  • khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::process):
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::ownerElement): (WebCore::DocumentImpl::parentDocument):
  • page/Frame.cpp: (WebCore::Frame::checkCompleted): (WebCore::Frame::redirectionTimerFired): (WebCore::Frame::requestFrameName): (WebCore::Frame::slotChildCompleted): (WebCore::Frame::incrementFrameCount): (WebCore::Frame::decrementFrameCount): (WebCore::Frame::topLevelFrameCount): (WebCore::Frame::selectFrameElementInParentIfFullySelected): (WebCore::Frame::handleFallbackContent): (WebCore::Frame::userGestureHint): (WebCore::Frame::canCachePage): (WebCore::Frame::updatePolicyBaseURL):
  • page/Frame.h:
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
  • page/FrameTreeNode.cpp: (WebCore::FrameTreeNode::setName): (WebCore::FrameTreeNode::appendChild): (WebCore::FrameTreeNode::removeChild):
  • page/FrameTreeNode.h: (WebCore::FrameTreeNode::FrameTreeNode): (WebCore::FrameTreeNode::name): (WebCore::FrameTreeNode::parent): (WebCore::FrameTreeNode::setParent):
  • rendering/render_frames.cpp: (WebCore::isURLAllowed):
11:04 PM Changeset in webkit [12520] by hyatt
  • 1 edit in trunk/LayoutTests/fast/block/float/031.html

Back out the changes to 031.html's HTML because of the 4959 partial backout.

11:02 PM Changeset in webkit [12519] by hyatt
  • 4 deletes in trunk/LayoutTests/fast/parser

Remove residual style span form test case because of the backout.

10:45 PM Changeset in webkit [12518] by hyatt
  • 1 edit in trunk/WebCore/khtml/html/htmlparser.cpp

Back out half of the residual style fix for bug 4959, since treating <span> like residual style breaks fast/block/float/031.html (despite buildbot and people on the outside not seeing it... how weird is that).

9:16 PM Changeset in webkit [12517] by darin
  • 1 edit
    2 adds in trunk/LayoutTests
  • fast/dom/Window/clear-timeout.html: Added.
  • fast/dom/Window/clear-timeout-expected.txt: Added.
9:15 PM Changeset in webkit [12516] by darin
  • 2 edits in trunk/WebCore

Checking in without review because I *just* broke this with my last check-in.

Test: fast/dom/Window/clear-timeout.html

  • khtml/ecma/kjs_window.cpp: (WindowQObject::clearTimeout): Fixed a != that should have been a ==.
6:51 PM Changeset in webkit [12515] by darin
  • 30 edits
    3 adds
    3 deletes in trunk/WebCore

Reviewed by Hyatt.

  • use Timer for everything, kill timer features of QObject, QTimer, QTimerEvent
  • ForwardingHeaders/kxmlcore/Noncopyable.h: Added.
  • ForwardingHeaders/kxmlcore/OwnArrayPtr.h: Added.
  • ForwardingHeaders/kxmlcore/OwnPtr.h: Added.
  • ForwardingHeaders/qtimer.h: Removed.
  • kwq/KWQTimer.cpp: Removed.
  • kwq/KWQTimer.h: Removed.
  • kwq/KWQObject.h:
  • kwq/KWQObject.cpp: Remove timer-related features.
  • kwq/KWQEvent.h: Remove QTimerEvent.
  • WebCore.xcodeproj/project.pbxproj: Updated for file changes.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • platform/Timer.h: Change to use nextFireInterval rather than nextFireTime. More convenient and also no need to define what the epoch is. Change TimerBase to use a virtual function rather than a function pointer. Added setDeferringTimers function to ensure timers don't fire while handling an event.
  • platform/mac/Timer.cpp: (WebCore::timerFired): Added deferral support. (WebCore::fireDeferred): Added. (WebCore::TimerBase::TimerBase): Simplify to remove function pointer. (WebCore::TimerBase::~TimerBase): Put in here, no longer inline. (WebCore::TimerBase::start): Change to use interval. (WebCore::TimerBase::startRepeating): Change since we use interval now. (WebCore::TimerBase::startOneShot): Ditto. (WebCore::TimerBase::stop): Added deferral support. (WebCore::TimerBase::nextFireInterval): Added. (WebCore::TimerBase::fire): Added. (WebCore::isDeferringTimers): Added. (WebCore::setDeferringTimers): Added.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::startRedirectionTimer): Update for change to Timer class. (WebCore::MacFrame::passMouseDownEventToWidget): Update to use setDeferringTimers instead of QObject::setDefersTimers.
  • khtml/ecma/kjs_window.h:
  • khtml/ecma/kjs_window.cpp: (KJS::DOMWindowTimer): Added. Class for JavaScript "timeout". (KJS::WindowQObject::parentDestroyed): Update to use DOMWindowTimer. (KJS::WindowQObject::installTimeout): Ditto. (KJS::WindowQObject::pauseTimeouts): Ditto. (KJS::WindowQObject::resumeTimeouts): Ditto. (KJS::WindowQObject::clearTimeout): Ditto. (KJS::WindowQObject::timerFired): Ditto. (KJS::DOMWindowTimer::fired): Added.
  • khtml/html/htmltokenizer.h:
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::HTMLTokenizer): Use Timer instead of timer ID. (WebCore::HTMLTokenizer::reset): Ditto. (WebCore::HTMLTokenizer::continueProcessing): Ditto. (WebCore::HTMLTokenizer::write): Ditto. (WebCore::HTMLTokenizer::stopParsing): Ditto. (WebCore::HTMLTokenizer::processingData): Ditto. (WebCore::HTMLTokenizer::timerFired): Ditto. (WebCore::HTMLTokenizer::end): Ditto. (WebCore::HTMLTokenizer::finish): Ditto.
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::DocumentImpl): Updated for changes to use RefPtr more cases, and not use it for m_svgExtensions. (WebCore::DocumentImpl::~DocumentImpl): Delete m_svgExtensions instead of just deref'ing it since it's no longer shared. (WebCore::DocumentImpl::implementation): Update for RefPtr. (WebCore::DocumentImpl::elementSheet): Ditto. (WebCore::DocumentImpl::styleSheets): Ditto. (WebCore::DocumentImpl::recalcStyleSelector): Ditto. (WebCore::DocumentImpl::dispatchImageLoadEventSoon): Update to use new style timer. (WebCore::DocumentImpl::removeImage): Ditto. (WebCore::DocumentImpl::dispatchImageLoadEventsNow): Ditto. (WebCore::DocumentImpl::imageLoadEventTimerFired): Ditto. (WebCore::DocumentImpl::svgExtensions): Update for RefPtr. (WebCore::DocumentImpl::accessSVGExtensions): Ditto.
  • ksvg2/misc/KSVGTimeScheduler.h: (WebCore::TimeScheduler::document):
  • ksvg2/misc/KSVGTimeScheduler.cpp: (WebCore::SVGTimer::downcast): (WebCore::SVGTimer::SVGTimer): (WebCore::SVGTimer::start): (WebCore::SVGTimer::calculateTimePercentage): (WebCore::SVGTimer::notifyAll): (WebCore::SVGTimer::addNotify): (WebCore::SVGTimer::removeNotify): (WebCore::TimeScheduler::TimeScheduler): (WebCore::TimeScheduler::~TimeScheduler): (WebCore::TimeScheduler::addTimer): (WebCore::TimeScheduler::connectIntervalTimer): (WebCore::TimeScheduler::disconnectIntervalTimer): (WebCore::TimeScheduler::startAnimations): (WebCore::TimeScheduler::toggleAnimations): (WebCore::TimeScheduler::timerFired): Rework to use new timer.
  • ksvg2/misc/SVGDocumentExtensions.h:
  • ksvg2/misc/SVGDocumentExtensions.cpp: Make SVGDocumentExtensions no longer be shared, be solely owned by the document.
  • ksvg2/svg/SVGDocumentImpl.cpp: (WebCore::SVGDocumentImpl::createStyleSelector): Update for RefPtr use.
  • kwq/KWQSlot.cpp: Remove endLifeSupport and timerNotify slots.
  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::selectionLayoutChanged): Update to use new style timer. (WebCore::Frame::caretBlinkTimerFired): Ditto.
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Ditto.
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Update to use new style timer. (WebCore::FrameView::clear): Ditto. (WebCore::FrameView::layout): Ditto. (WebCore::FrameView::layoutTimerFired): Ditto. (WebCore::FrameView::scheduleRelayout): Ditto. (WebCore::FrameView::layoutPending): Ditto. (WebCore::FrameView::haveDelayedLayoutScheduled): Ditto. (WebCore::FrameView::unscheduleRelayout): Ditto.
  • page/ObjectContents.h: Remove unneeded includes.
  • rendering/render_frames.cpp: Removed include of <qtimer.h>.
  • rendering/render_layer.h:
  • rendering/render_layer.cpp: (WebCore::Marquee::Marquee): Use new style timers. (WebCore::Marquee::start): Ditto. (WebCore::Marquee::suspend): Ditto. (WebCore::Marquee::stop): Ditto. (WebCore::Marquee::updateMarqueeStyle): Ditto. (WebCore::Marquee::timerFired): Ditto.
2:36 PM Changeset in webkit [12514] by bdakin
  • 3 edits in trunk/WebCore

Patch by Darin. Reviewed by Beth.

Fix for <rdar://problem/4424126> REGRESSION(412-420+): yellow
highlight fails to follow cursor when mousing over star rating
(6232)

Event coordinates cannot be calculated until there is a target.
This patch restructures the code so that the coordinates are
initialized when the mouse event is created but are not calculated
until the target is set.

Jan 31, 2006:

10:30 PM Changeset in webkit [12513] by mjs
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dynamic/layer-hit-test-crash-expected.checksum: Added.
  • fast/dynamic/layer-hit-test-crash-expected.png: Added.
  • fast/dynamic/layer-hit-test-crash-expected.txt: Added.
  • fast/dynamic/layer-hit-test-crash.html: Added.

WebCore:

Reviewed by Darin.

  • rendering/render_layer.cpp: (WebCore::RenderLayer::hitTestLayer): Iterate vectors in a way that won't break on empty ones.
10:24 PM Changeset in webkit [12512] by mjs
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • fixed leak of hundreds of thousands of JS parser nodes on the layout tests, and added an exit counter that would catch them
  • kjs/nodes.cpp: (NodeCounter::~NodeCounter): Added debug-only node counter. (Node::Node): (Node::~Node):
  • kxmlcore/VectorTraits.h: Simple classes like RefPtr do in fact need destruction.
8:33 PM Changeset in webkit [12511] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • added deleteAllValues for HashSet as well as HashMap
  • fixed conversion from const_iterator to iterator, which I broke a while back
  • kxmlcore/HashMap.h: Updated copyright date.
  • kxmlcore/HashSet.h: (KXMLCore::deleteAllValues): Added.
  • kxmlcore/HashTable.h: (KXMLCore::HashTableIterator::operator const_iterator): Added.
6:44 PM Changeset in webkit [12510] by adele
  • 4 edits
    2 adds in trunk

LayoutTests:

  • fast/forms/input-changing-value-expected.txt: Added.
  • fast/forms/input-changing-value.html: Added.

WebCore:

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=6862
Input's value doesn't get updated after typing in new text field

Added test:
fast/forms/input-changing-value.html

Added an event listener for a DOMCharacterDataModifiedEvent on the inner div.
When we get the event, then we update the input element's value field.

There may be performance problems with this approach that we will have to
address before flipping the switch to use these new text fields.

  • rendering/RenderTextField.cpp: (WebCore::InputMutationListener::handleEvent): calls subtreeHasChanged (WebCore::m_mutationListener): (WebCore::RenderTextField::~RenderTextField): remove the event listener. (WebCore::RenderTextField::setStyle): Remove unnecessary setStyle on text node. It should inherit style from the div already. (WebCore::RenderTextField::updateFromElement): add the event listener. (WebCore::RenderTextField::subtreeHasChanged): updates the input element's value.
  • rendering/RenderTextField.h: (WebCore::InputMutationListener::InputMutationListener): Added. (WebCore::InputMutationListener::renderTextField): Added. (WebCore::InputMutationListener::setInputElement): Added.
5:49 PM Changeset in webkit [12509] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick.


  • fixed <rdar://problem/4267144> REGRESSION (10.4.2): Safari pages auto-scroll too easily during drag over content [5853]


There were two issues here:
(1) dragging over a non-editable webview (such as a typical Safari page) should not have
auto-scrolled at all; the fact that it did was an uninentional side effect of making
auto-scroll work for editable webviews a la Blot.
(2) the speed & hot area of the auto-scroll changed between 10.4.1 and 10.4.2.


I have a fix for (1), which is the much more important issue. I'll modify the bugzilla bug
to be about the remaining issue.

  • WebView.subproj/WebView.m: (-[WebView _autoscrollForDraggingInfo:timeDelta:]): do nothing if not editable (-[WebView _shouldAutoscrollForDraggingInfo:]): return NO if not editable
5:18 PM Changeset in webkit [12508] by thatcher
  • 11 edits
    4 adds in trunk

LayoutTests:

Adding test cases for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4959
Bug 4959: inline style not terminated properly after <form>

Updated older tests/results to work with the patch.
Some of the tests had an open <span> with no close.

  • editing/deleting/delete-image-003-expected.txt:
  • editing/deleting/delete-image-003.html:
  • editing/undo/redo-typing-001-expected.txt:
  • editing/undo/redo-typing-001.html:
  • editing/undo/undo-typing-001-expected.txt:
  • editing/undo/undo-typing-001.html:
  • fast/block/float/031.html:
  • fast/parser/residual-style-span-form-expected.checksum: Added.
  • fast/parser/residual-style-span-form-expected.png: Added.
  • fast/parser/residual-style-span-form-expected.txt: Added.
  • fast/parser/residual-style-span-form.html: Added.
  • fast/text/whitespace/006-expected.txt:

WebCore:

Reviewed by Dave Hyatt.
Landed by Timothy Hatcher.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=4959
Bug 4959: inline style not terminated properly after <form>

  • khtml/html/htmlparser.cpp: (HTMLParser::isResidualStyleTag): add <span> as residual style tag (HTMLParser::isAffectedByResidualStyle): add <form> as tag affected by residual style
4:24 PM Changeset in webkit [12507] by thatcher
  • 1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Adding -Wno-long-double to avoid a warning.

3:59 PM Changeset in webkit [12506] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick.


Support for programmatic scrolling one line at a time for PDFs. (We already had support for
programmatic scrolling one page at a time, and to top/end.)

  • WebView.subproj/WebPDFView.m: (-[WebPDFView _fakeKeyEventWithFunctionKey:]): generalized comment (-[WebPDFView scrollLineDown:]): pass a faked arrow-down key event (-[WebPDFView scrollLineUp:]): pass a faked arrow-up key event
3:38 PM Changeset in webkit [12505] by tomernic
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff Garen.

  • bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16): Fixed an invalid assertion that UTF8Chars is not NULL. It is valid for it to be NULL as long as UTF8Length is 0. This fixes an assertion failure on TOT at <​http://www.musicindiaonline.com/p/x/tJO0OOBME9.As1NMvHdW/>, where JavaScript is getting a NULL string back from some call on the Real Player plugin.
1:50 PM Changeset in webkit [12504] by vicki
  • 3 edits
    4 adds
    1 delete in trunk/WebCore

Reviewed by Geoff.

  • fix <rdar://problem/4426668> REGRESSION: sometimes URLs with named anchors in a page don't jump to proper location in document (6916). Added test cases for this fix and past link jumping bug fixes.
  • khtml/xml/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::getUpperLeftCorner): Traverse up the parent node chain until you find one that has a sibling.
  • manual-tests/linkjump-1.html: Added a note here - the bug for this test case is still broken in TOT.
  • manual-tests/linkjump-2.html: Added. Renamed scrollToAnchor.html, to group it with the rest of the link jumping tests.
  • manual-tests/linkjump-3.html: Added. Test case for this bug, <rdar://problem/4426668>.
  • manual-tests/linkjump-4.html: Added. Test case for past fix, <rdar://problem/4247537>.
  • manual-tests/linkjump-5.html: Added. Test case for past fix, <rdar://problem/4256060>.
  • manual-tests/scrollToAnchor.html: Removed.
12:41 PM Changeset in webkit [12503] by harrison
  • 1 edit
    4 adds in trunk/LayoutTests

Adding test cases for:
<rdar://problem/4423922> TOT REGRESSION (r12358): first iframe in pair fails to copy


  • editing/pasteboard/paste-empty-startcontainer-expected.png: Added.
  • editing/pasteboard/paste-empty-startcontainer-expected.checksum: Added.
  • editing/pasteboard/paste-empty-startcontainer-expected.txt: Added.
  • editing/pasteboard/paste-empty-startcontainer.html: Added.
12:41 PM Changeset in webkit [12502] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John.
<rdar://problem/4423922> TOT REGRESSION (r12358): first iframe in pair fails to copy

Layout test added:

  • editing/pasteboard/paste-empty-startcontainer.html


  • khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::startNode):
  • use empty non-textual m_startContainer itself if m_startOffset is 0, rather then nextSibling()
10:55 AM Changeset in webkit [12501] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adele.


  • fast/forms/selected-index-assert-expected.txt: Added.
  • fast/forms/selected-index-assert.html: Added.

WebCore:

Test: fast/forms/selected-index-assert.html.

Reviewed by Adele.


  • khtml/html/HTMLSelectElementImpl.cpp: (WebCore::HTMLSelectElementImpl::selectedIndex): Removed bogus assert. -1 is the correct value to return if no option is selected.
10:14 AM Changeset in webkit [12500] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Adele.

Fixing build bustage. Removing include of khtml_factory.h since it
has been removed.

9:45 AM Changeset in webkit [12499] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Hyatt.

  • fast/forms/button-cannot-be-nested-expected.checksum: Added.
  • fast/forms/button-cannot-be-nested-expected.png: Added.
  • fast/forms/button-cannot-be-nested-expected.txt: Added.
  • fast/forms/button-cannot-be-nested.html: Added.
9:45 AM Changeset in webkit [12498] by darin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • khtml/html/htmlparser.cpp: (HTMLParser::getNode): Add buttonTag to error handling table to take care of unclosed tags.
9:41 AM Changeset in webkit [12497] by darin
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Darin.


  • fast/parser/script-after-frameset-assert-expected.txt: Added.
  • fast/parser/script-after-frameset-assert.html: Added.
9:41 AM Changeset in webkit [12496] by darin
  • 2 edits in trunk/WebCore

Test: fast/parser/script-after-frameset-assert.html

Reviewed by Darin.


  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): Reset scriptNode to 0 if the script is being skipped.
9:36 AM Changeset in webkit [12495] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Darin.

  • fast/table/fixed-table-non-cell-in-row.html: Added.
  • fast/table/fixed-table-non-cell-in-row-expected.txt: Added.
  • fast/table/fixed-table-non-cell-in-row-expected.png: Added.
  • fast/table/fixed-table-non-cell-in-row-expected.checksum: Added.
9:31 AM Changeset in webkit [12494] by darin
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • rendering/table_layout.cpp: (WebCore::FixedTableLayout::calcWidthArray): Remove the assertion.
9:18 AM Changeset in webkit [12493] by andersca
  • 5 edits in trunk

2006-01-31 Anders Carlsson <​andersca@mac.com>

Reviewed by John.


  • khtml/ecma/kjs_html.cpp: (KJS::ImagePattern::createPattern): Don't mirror the x coordinate when creating the pattern.
9:09 AM Changeset in webkit [12492] by darin
  • 66 edits
    2 adds
    3 deletes in trunk

WebCore:

Reviewed by Hyatt.

  • added a Timer class
  • used the Timer class for the redirection timer
  • moved Frame, FrameView, MacFrame, and FrameNodeTree into WebCore namespace
  • removed more KWQ
  • ForwardingHeaders/khtml_factory.h: Removed.
  • kwq/KWQKHTMLFactory.cpp: Removed.
  • kwq/KWQKHTMLFactory.h: Removed.
  • platform/Timer.h: Added.
  • platform/mac/Timer.cpp: Added.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for added and removed files.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::init): Remove code to set up slotRedirect. (WebCore::Frame::checkCompleted): Call start/stopRedirectionTimer instead of using the redirection timer directly. (WebCore::Frame::scheduleRedirection): Ditto. (WebCore::Frame::scheduleLocationChange): Ditto. (WebCore::Frame::scheduleHistoryNavigation): Ditto. (WebCore::Frame::cancelRedirection): Ditto. (WebCore::Frame::redirectionTimerFired): Renamed from slotRedirect. (WebCore::Frame::slotParentCompleted): More startRedirectionTimer. (WebCore::Frame::startRedirectionTimer): Added. Virtual bottleneck to start the redirection timer. (WebCore::Frame::stopRedirectionTimer): Added. Virtual bottleneck to stop the redirection timer.
  • page/FramePrivate.h: Changed m_redirectionTimer from a QTimer to a Timer.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::startRedirectionTimer): Added. Avoids the need for the QTimer "monitor" feature that I had added a while back to implement the client-redirected callback. (WebCore::MacFrame::stopRedirectionTimer): Ditto.
  • kwq/KWQSlot.cpp: Removed slotRedirected.
  • ForwardingHeaders/ksvg2/KSVGPart.h: Removed using to put Frame into various namespaces (all of which are WebCore now anyway).
  • bindings/objc/DOMInternal.mm:
  • bridge/mac/BrowserExtensionMac.h:
  • bridge/mac/KWQKHTMLView.cpp:
  • bridge/mac/MacFrame.h:
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm:
  • bridge/mac/WebCorePageBridge.h:
  • bridge/mac/WebCorePageBridge.mm:
  • css/cssstyleselector.cpp:
  • css/cssstyleselector.h:
  • khtml/ecma/kjs_binding.cpp:
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_navigator.cpp:
  • khtml/ecma/kjs_navigator.h:
  • khtml/ecma/kjs_proxy.h:
  • khtml/ecma/kjs_window.h:
  • khtml/editing/SelectionController.h:
  • khtml/editing/jsediting.h:
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/html_documentimpl.h:
  • khtml/html/html_headimpl.h:
  • khtml/html/htmlparser.h:
  • khtml/html/htmltokenizer.h:
  • khtml/xml/DOMImplementationImpl.h:
  • khtml/xml/DocumentImpl.h:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/xml_tokenizer.h:
  • khtml/xsl/xslt_processorimpl.h:
  • ksvg2/svg/SVGDocumentImpl.cpp:
  • kwq/KWQClipboard.h:
  • kwq/KWQComboBox.mm:
  • kwq/KWQFileButton.h:
  • kwq/KWQFrame.mm:
  • kwq/KWQKJavaAppletWidget.h:
  • kwq/KWQListBox.mm:
  • kwq/KWQSignalStubs.cpp:
  • kwq/KWQSlider.mm:
  • kwq/KWQTextField.mm:
  • kwq/KWQWidget.mm:
  • kwq/WebCoreSettings.mm:
  • kwq/WebCoreTextRendererFactory.mm:
  • loader/DocLoader.h:
  • page/FrameTreeNode.cpp:
  • page/FrameTreeNode.h:
  • page/FrameView.cpp:
  • page/FrameView.h:
  • page/Page.cpp:
  • page/Page.h:
  • rendering/InlineTextBox.h:
  • rendering/font.cpp:
  • rendering/render_canvas.h:
  • rendering/render_frames.h:
  • rendering/render_object.h:
  • rendering/render_replaced.h: Updated for namespace and header changes.

WebKit:

Reviewed by Hyatt.

  • WebCoreSupport.subproj/WebFrameBridge.m: (-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): Updated for name change.
5:21 AM Changeset in webkit [12491] by mjs
  • 1 edit
    4 adds in trunk/LayoutTests

Added test case I forgot to commit earlier.


  • fast/parser/remove-block-in-residual-style.html: Added.
  • fast/parser/remove-block-in-residual-style-expected.checksum: Added.
  • fast/parser/remove-block-in-residual-style-expected.png: Added.
  • fast/parser/remove-block-in-residual-style-expected.txt: Added.

Jan 30, 2006:

11:41 PM Changeset in webkit [12490] by andersca
  • 2 edits in trunk/LayoutTests

2006-01-30 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

Update test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6907
REGRESSION: United.com menus messed up due to document.all/MSIE sniff


  • fast/dom/undetectable-document-all.html: Test that typeof document.all is undefined.
11:41 PM Changeset in webkit [12489] by andersca
  • 6 edits in trunk

2006-01-30 Anders Carlsson <​andersca@mac.com>

Reviewed by Darin.

Fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6907
REGRESSION: United.com menus messed up due to document.all/MSIE sniff


  • kjs/nodes.cpp: (typeStringForValue): Return "undefined" if the given object should masquerade as undefined.


  • kjs/object.h: (KJS::JSObject::masqueradeAsUndefined): Rename from isEqualToNull.


  • kjs/operations.cpp: (KJS::equal): Update for name change.
10:08 PM Changeset in webkit [12488] by darin
  • 4 edits in trunk/WebKitTools
  • Scripts/svn-apply: Added comments about things we should do to improve.
  • Scripts/svn-create-patch: Ditto.
  • Scripts/svn-unapply: Ditto.
10:08 PM Changeset in webkit [12487] by darin
  • 1 edit
    1 add in trunk/LayoutTests

Pointed out by Dave Kilzer.

  • added test result I forgot to check in
  • fast/dom/Range/range-exceptions-expected.txt: Added.
6:52 PM Changeset in webkit [12486] by ggaren
  • 4 edits in trunk/WebCore

Reviewed by mjs.

  • Speculative fix for <rdar://problem/4135845> Crash executing cross-frame script on timeout in KJS::ScheduledAction::execute

If we ever get a reproducible case of 4135845, I'll add a test for it.

This is a re-working of Maciej's fix for 3157014 (circa 2003!). Since
you can't reliably predict what the state of the page will be when
a timer fires, I've made the timer responsbile for making sure that
everything is OK to execute.

I tested @ ​http://www.javascriptkit.com/script/cut3.shtml with various
combinations of reload, back, and regular navigations with JS enabled/
disabled to ensure that the previous crash didn't return. I also ran a
leaks test and discovered some, but none unique to this patch. (See
<rdar://problem/4427420> TOT REGRESSION: Leaks seen on page with
JavaScript timer.)

  • khtml/ecma/kjs_window.cpp: (KJS::ScheduledAction::execute): Return early if there's no window object. (This happens when JavaScript is disabled.) (KJS::Window::retrieveWindow): Reversed a backwards ASSERT, increased prettiness. (The assert fired while I was testing. Not sure why we haven't seen it before.)
  • page/Frame.cpp: (Frame::didOpenURL): Returned setting of JavaScript enabled/disabled preference to its rightful place. This introduces a new behavior: now, the unload event does not fire after you've disabled JavaScript. That seems like a good thing. (See <rdar://problem/4426506> Disabling JavaScript should immediately end JavaScript execution.) (Frame::begin): Ditto.
5:03 PM Changeset in webkit [12485] by thatcher
  • 9 copies in tags/Safari-521.6.2

New tag.

5:00 PM Changeset in webkit [12484] by thatcher
  • 4 edits in branches/Safari-Leo-branch

Versioning and updated the copyright dates.

4:52 PM Changeset in webkit [12483] by thatcher
  • 1 delete in tags/Safari-521.6.2

Redoing this tag.

3:51 PM Changeset in webkit [12482] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Tim O.

Add -Wno-deprecated-declarations to the compile flags for WebNetscapePluginPackage.m.
<rdar://problem/4427068> LMGetCurApRefNum, CloseConnection and GetDiskFragment now deprecated.
When we workaround these we can remove this compile flag.

  • WebKit.xcodeproj/project.pbxproj:
3:45 PM Changeset in webkit [12481] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Justin.

Remove the only use of -[NSFont glyphPacking]. This method was deprecated in Tiger
and always returns NSNativeShortGlyphPacking.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer initWithFont:]):
12:14 PM Changeset in webkit [12480] by ggaren
  • 2 edits
    1 add in trunk/WebCore

Reviewed by Dave Harrison.

  • Fixed <rdar://problem/4378159> crash in KWQKHTMLPart::userGestureHint from javascript enabled/disabled inconsistency when pasting webpage into email or blot
  • page/Frame.cpp: (Frame::userGestureHint): Check root frame's jScript() for NULL instead of checking inner frame's jScript().


After init() has been called on a frame, but before begin() has been
called, the frame can have JavaScript enabled when its parent doesn't.
(That seems wrong, so I've filed <rdar://problem/4426499> Child frame
momentarily has JavaScript enabled even though parent frame doesn't.)


Regardless, it's better programming practice to NULL check the actual
pointer you're going to use, so that's what I've done here.

  • manual-tests/paste-crash.html: Added. (No automated test because the crash depends on JavaScript being disabled.)
10:56 AM Changeset in webkit [12479] by bdakin
  • 1 edit
    4 adds in trunk/LayoutTests

Layout test for <rdar://problem/4298052> Crash in
KWQCheckIfReloading at ​http://www.inquisitorx.com/beta/

10:45 AM Changeset in webkit [12478] by bdakin
  • 3 edits in trunk/WebCore

eviewed by Geoff

Fix for <rdar://problem/4298052> Crash in KWQCheckIfReloading at
​http://www.inquisitorx.com/beta/

It is possible for the DocLoader's frame to be nil when the
DocLoader is not nil, so we need nil checks.

10:31 AM Changeset in webkit [12477] by eseidel
  • 2 edits in trunk/WebCore

2006-01-30 Eric Seidel <​eseidel@apple.com>

Add #import "KWQFontMetrics.h" to fix no-svg build.

  • kwq/KWQPainter.mm:
1:03 AM Changeset in webkit [12476] by darin
  • 78 edits in trunk

LayoutTests:

  • updated test result for rect changes
  • fast/box-sizing/percentage-height-expected.txt: A bunch of strange empty clip rects are now dumping as (0,0) 0x0.

WebCore:

Reviewed by Eric.

  • cleanup of Int/Float-Size/Point/Rect classes

I did this as part of a redo of QMatrix, but I decided I should
land this part separately.

Eliminated the concept of a null rect or point, which used to be
indicated by negative width and height.

Changed right and bottom to to be, e.g., 2 for a rect at (0,0) 2x2.
The old code followed Qt's system that says right is 1 in those cases,
which is inappropriate for floating point, and old fashioned because
modern graphics systems use coordinates for lines between pixels, not
the pixels themselves.

Other API improvements to the point, size, and rect classes. For example,
functions named with verbs now always modify the object itself.

  • rendering/render_theme_mac.mm: (RenderThemeMac::paintButton): Fixed a bug where it said x() where it should say y().
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • kcanvas/KCanvasContainer.cpp:
  • kcanvas/KCanvasItem.cpp:
  • kcanvas/RenderSVGImage.cpp:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
  • khtml/ecma/kjs_dom.cpp:
  • khtml/ecma/kjs_window.cpp:
  • khtml/editing/SelectionController.cpp:
  • khtml/html/html_inlineimpl.cpp:
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/html_objectimpl.h:
  • khtml/misc/khtmllayout.h:
  • ksvg2/svg/SVGSVGElementImpl.cpp:
  • kwq/KWQAccObject.mm:
  • kwq/KWQComboBox.mm:
  • kwq/KWQFileButton.mm:
  • kwq/KWQFontMetrics.mm:
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm:
  • kwq/KWQRegion.cpp:
  • kwq/KWQRenderTreeDebug.cpp:
  • kwq/KWQScrollView.mm:
  • kwq/KWQWMatrix.cpp:
  • kwq/KWQWidget.h:
  • kwq/KWQWidget.mm:
  • kwq/KWQWindowWidget.mm:
  • loader/CachedImage.cpp:
  • page/Frame.cpp:
  • page/FrameView.cpp:
  • platform/FloatPoint.cpp:
  • platform/FloatPoint.h:
  • platform/FloatRect.cpp:
  • platform/FloatRect.h:
  • platform/FloatSize.cpp:
  • platform/FloatSize.h:
  • platform/Image.h:
  • platform/IntPoint.cpp:
  • platform/IntPoint.h:
  • platform/IntPointArray.cpp:
  • platform/IntPointArray.h:
  • platform/IntRect.cpp:
  • platform/IntRect.h:
  • platform/IntSize.cpp:
  • platform/IntSize.h:
  • platform/mac/FloatPoint.mm:
  • platform/mac/FloatRect.mm:
  • platform/mac/FloatSize.mm:
  • platform/mac/Image.mm:
  • platform/mac/IntPoint.mm:
  • platform/mac/IntRect.mm:
  • platform/mac/IntSize.mm:
  • platform/mac/Screen.mm:
  • rendering/InlineTextBox.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderTable.cpp:
  • rendering/RenderTableCell.cpp:
  • rendering/RenderText.cpp:
  • rendering/render_box.cpp:
  • rendering/render_canvas.cpp:
  • rendering/render_canvasimage.cpp:
  • rendering/render_flow.cpp:
  • rendering/render_form.cpp:
  • rendering/render_frames.cpp:
  • rendering/render_layer.cpp:
  • rendering/render_line.cpp:
  • rendering/render_list.cpp:
  • rendering/render_object.cpp:
  • rendering/render_object.h:
  • rendering/render_replaced.cpp:
12:42 AM Changeset in webkit [12475] by mjs
  • 15 edits
    1 delete in trunk/WebCore

Reviewed by Darin.

  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/device/KRenderingPaintServerGradient.cpp: (operator<<): Implement for Vector<KCGradientStop> (KRenderingPaintServerGradient::gradientStops): Use a Vector, not a subclass of QPtrList that sorts on every insert (compareStopOffset): Comparison function for sorting. (KRenderingPaintServerGradient::setGradientStops): Add a version that takes a Vector which sorts, and another which knows how to copy from another gradient paint server.
  • kcanvas/device/KRenderingPaintServerGradient.h: (makeGradientStop): Make a gradient stop pair.
  • kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz): use delete on stops cache (KRenderingPaintServerGradientQuartz::updateQuartzGradientStopsCache): adapt to Vector
  • kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
  • khtml/editing/visible_text.cpp: (khtml::compareBoxStart): Comparison function for sorting. (khtml::TextIterator::handleTextNode): Use Vector and std::sort instead of QSortedList for sorting. Keep current position as an index. (khtml::TextIterator::handleTextBox): Adapt for Vector use.
  • khtml/editing/visible_text.h:
  • ksvg2/svg/SVGGradientElementImpl.cpp: (SVGGradientElementImpl::rebuildStops): Use a Vector. Instead of modifying the existing one, make a fresh one and assign it.
  • ksvg2/svg/SVGLinearGradientElementImpl.cpp: (SVGLinearGradientElementImpl::buildGradient): don't copy item by item, just assign directly.
  • ksvg2/svg/SVGRadialGradientElementImpl.cpp: (SVGRadialGradientElementImpl::buildGradient): ditto
  • ksvg2/svg/SVGStopElementImpl.h:
  • kwq/KWQListImpl.cpp:
  • kwq/KWQPtrList.h: (QPtrList::sort): Removed.
  • kwq/KWQSortedList.h: Removed.
  • rendering/InlineTextBox.h: Remove now unneeded operator< and operator=

Jan 29, 2006:

11:27 PM Changeset in webkit [12474] by darin
  • 32 edits
    6 deletes in trunk/WebCore

Reviewed by Maciej.

  • killed more KWQ, KWinModule and QVariant
  • ForwardingHeaders/kwinmodule.h: Removed.
  • ForwardingHeaders/qvariant.h: Removed.
  • kwq/KWQKWinModule.h: Removed.
  • kwq/KWQKWinModule.mm: Removed.
  • kwq/KWQVariant.cpp: Removed.
  • kwq/KWQVariant.h: Removed.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for removal.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • khtml/ecma/kjs_binding.h:
  • khtml/ecma/kjs_binding.cpp: Remove QVariant stuff.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • khtml/ecma/kjs_proxy.h:
  • khtml/ecma/kjs_proxy.cpp: (WebCore::KJSProxyImpl::evaluate):
  • page/Frame.h:
  • page/Frame.cpp: (getString): (Frame::replaceContentsWithScriptResult): (Frame::executeScript): (Frame::executeScheduledScript): (Frame::changeLocation): (Frame::urlSelected): (Frame::submitForm): Changed to use JSValue instead of QVariant for result of executing JavaScript.
  • kwq/KWQObject.h: Removed a bunch of unneeded includes and forward declarations.
  • bridge/mac/MacFrame.mm:
  • khtml/ecma/kjs_window.h:
  • khtml/ecma/kjs_window.cpp:
  • khtml/html/html_inlineimpl.cpp:
  • khtml/html/htmltokenizer.cpp:
  • khtml/xml/DocumentImpl.cpp:
  • khtml/xml/NodeImpl.cpp:
  • khtml/xml/dom2_eventsimpl.cpp:
  • khtml/xml/xml_tokenizer.cpp:
  • kwq/KWQComboBox.mm:
  • kwq/KWQFileButton.mm:
  • kwq/KWQListBox.mm:
  • kwq/KWQObject.cpp:
  • kwq/KWQSlider.mm:
  • kwq/KWQTextArea.mm:
  • kwq/KWQTextField.mm:
  • loader/CachedImage.h:
  • page/FrameView.h:
  • page/FrameView.cpp:
  • rendering/render_form.cpp: Updated includes, since KWQObject.h now includes less. Also updated callers to executeScript since one overload was removed.
11:18 PM Changeset in webkit [12473] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • properly define Vector assignment operator; the private version was accidentally left in, and the template version is not enough to replace the default
  • kxmlcore/Vector.h: (KXMLCore::Vector::operator=):
11:13 PM Changeset in webkit [12472] by eseidel
  • 2 edits in trunk/WebCore

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Added back #include <qvaluelist.h> to fix WIN32 build.

  • rendering/render_style.h:
10:06 PM Changeset in webkit [12471] by darin
  • 50 edits
    2 adds
    11 deletes in trunk/WebCore

Reviewed by Hyatt (drag image fix) and Maciej (the rest).

  • fixed just-introduced crash dragging images

I don't know how to make a layout test for this.

  • kwq/KWQClipboard.mm: (WebCore::KWQClipboard::dragImage): Fixed crash on dragging by initializing m_dragImage to 0.
  • kwq/KWQApplication.h: Removed.
  • kwq/KWQApplication.mm: Removed.
  • kwq/KWQGlobal.cpp: Removed.
  • kwq/KWQKPartsEvent.cpp: Removed.
  • kwq/KWQKPartsEvent.h: Removed.
  • kwq/KWQPair.h: Removed.
  • kwq/KWQStyle.cpp: Removed.
  • kwq/KWQStyle.h: Removed.
  • ForwardingHeaders/kparts/event.h: Removed.
  • ForwardingHeaders/qapplication.h: Removed.
  • ForwardingHeaders/qstyle.h: Removed.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for above changes.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/Screen.h: Added. Replaces the desktop widget stuff in KWQApplication.mm.
  • platform/mac/Screen.mm: Added.
  • kwq/KWQDef.h: Removed everything except for kMin and kMax from here. We should port to std::min and std::max, and then we can get rid of this header altogether.
  • kwq/KWQKCursor.h: Removed setAutoHideCursor.
  • kwq/KWQKCursor.mm: Ditto.
  • kwq/KWQWidget.h: Removed style() and setStyle() functions.
  • kwq/KWQWidget.mm: Ditto.
  • khtml/ecma/kjs_window.h:
  • khtml/ecma/kjs_window.cpp: (KJS::Screen::Screen): Store a pointer to the Frame. (KJS::Screen::getValueProperty): Port to use the new Screen.h functions. (KJS::showModalDialog): Ditto. (KJS::Window::getValueProperty): Ditto. (KJS::WindowFunc::callAsFunction): Ditto.
  • khtml/khtml_events.h:
  • khtml/khtml_events.cpp: Removed much of the code here. This can be cut down even more.
  • khtml/misc/khtmllayout.h: Removed unused stuff and updated for KWQ changes.
  • kwq/KWQCString.cpp:
  • kwq/KWQKURL.mm:
  • kwq/KWQPainter.mm:
  • kwq/KWQRegExp.cpp:
  • kwq/KWQRenderTreeDebug.cpp:
  • kwq/KWQString.h:
  • kwq/KWQString.mm:
  • kwq/KWQTextCodec.cpp:
  • WebCore+SVG/KDOMSettings.cpp:
  • bridge/mac/MacFrame.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • css/cssparser.cpp:
  • kcanvas/KCanvasItem.cpp:
  • khtml/ecma/kjs_navigator.cpp:
  • khtml/html/HTMLSelectElementImpl.cpp:
  • khtml/html/html_tableimpl.h:
  • khtml/html/htmltokenizer.cpp:
  • khtml/misc/decoder.cpp:
  • ksvg2/css/KSVGCSSParser.cpp:
  • ksvg2/css/SVGRenderStyle.h:
  • page/Frame.h:
  • page/Frame.cpp:
  • page/FrameView.cpp:
  • platform/IntPointArray.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderTable.cpp:
  • rendering/bidi.cpp:
  • rendering/bidi.h:
  • rendering/render_form.cpp:
  • rendering/render_object.cpp:
  • rendering/render_object.h:
  • rendering/render_replaced.cpp:
  • rendering/render_style.h:
  • rendering/table_layout.cpp: Updated for above KWQ changes. Changed tabs to spaces.
9:58 PM Changeset in webkit [12470] by eseidel
  • 2 edits in trunk/JavaScriptCore

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Fix the build by applying a GCC-specific namespace hack.

  • kjs/lookup.h:
8:52 PM Changeset in webkit [12469] by eseidel
  • 2 edits in trunk/WebCore

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Fix build for Win32.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
8:50 PM Changeset in webkit [12468] by eseidel
  • 3 edits in trunk/JavaScriptCore

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Fix build on Win32.

  • kjs/lookup.h: fixed ::cacheGlobalObject
  • kxmlcore/Vector.h: (KXMLCore::Vector::operator[]): use unsigned long
4:54 PM Changeset in webkit [12467] by hyatt
  • 15 edits in trunk/WebCore

Fix for bug 6910, don't let Image be assignable or copiable. It will soon represent the actual
original Image (including the data) and as such must remain unique.

Reviewed by darin

  • kcanvas/KCanvasFilters.cpp: (KCanvasFEImage::~KCanvasFEImage): (KCanvasFEImage::setCachedImage):
  • kcanvas/KCanvasFilters.h: (KCanvasFEImage::KCanvasFEImage): (KCanvasFEImage::cachedImage):
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEImageQuartz::getCIFilter):
  • khtml/ecma/kjs_events.cpp: (KJS::ClipboardProtoFunc::callAsFunction):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::callAsFunction): (KJS::drawPattern): (KJS::_rh): (KJS::ImagePattern::~ImagePattern): (KJS::ImagePattern::createPattern):
  • khtml/ecma/kjs_html.h: (KJS::ImagePattern::cachedImage):
  • khtml/html/html_imageimpl.h: (WebCore::HTMLImageElementImpl::cachedImage):
  • khtml/xml/dom2_eventsimpl.h:
  • ksvg2/svg/SVGCursorElementImpl.cpp: (SVGCursorElementImpl::~SVGCursorElementImpl): (SVGCursorElementImpl::parseMappedAttribute):
  • ksvg2/svg/SVGCursorElementImpl.h: (KSVG::SVGCursorElementImpl::cachedImage):
  • ksvg2/svg/SVGFEImageElementImpl.cpp: (SVGFEImageElementImpl::~SVGFEImageElementImpl): (SVGFEImageElementImpl::parseMappedAttribute): (SVGFEImageElementImpl::notifyFinished):
  • kwq/KWQClipboard.h:
  • kwq/KWQClipboard.mm: (WebCore::KWQClipboard::dragImage): (WebCore::KWQClipboard::setDragImage): (WebCore::KWQClipboard::setDragImageElement): (WebCore::KWQClipboard::imageChanged): (WebCore::KWQClipboard::dragNSImage):
  • platform/Image.h:
3:40 PM Changeset in webkit [12466] by darin
  • 7 edits in trunk/WebCore

Reviewed by Hyatt.

  • rendering/render_image.h: (WebCore::RenderImage::image): Return a null image when m_cachedImage is 0. (WebCore::RenderImage::errorOccurred): Return false when m_cachedImage is 0.
  • rendering/render_image.cpp: (WebCore::RenderImage::nullImage): Added. Returns a global null image for use when we have no cached image.
  • rendering/render_object.h: Renamed the old setImage to imageChanged, the new name for the same function.
  • rendering/render_object.cpp: (WebCore::RenderObject::imageChanged): Ditto.
  • rendering/render_list.cpp: (RenderListMarker::imageChanged): Changed the call to parent to call the new imageChanged instead of the old setImage.
  • fixed something else that was causing some layout test crashes
  • kwq/KWQRenderTreeDebug.cpp: (externalRepresentation): Rearrange so we won't ever dereference a null pointer here.
2:24 PM Changeset in webkit [12465] by darin
  • 15 edits
    3 adds in trunk/LayoutTests

Reviewed by Darin.

  • fixed some tests that were missing test images
  • fast/replaced/resources/sample.gif: Added.
  • fast/replaced/resources/1x1-green.png: Added.
  • fast/replaced/resources/1x1-red.png: Added.
  • fast/replaced/001.html: Changed images to point to actual images.
  • fast/replaced/002.html: Ditto.
  • fast/replaced/003.html: Ditto.
  • fast/replaced/004.html: Ditto.
  • fast/replaced/002-expected.txt: Updated.
  • fast/replaced/003-expected.txt: Updated.
  • fast/replaced/001-expected.png: Updated.
  • fast/replaced/001-expected.checksum: Updated.
  • fast/replaced/002-expected.png: Updated.
  • fast/replaced/002-expected.checksum: Updated.
  • fast/replaced/003-expected.png: Updated.
  • fast/replaced/003-expected.checksum: Updated.
  • fast/replaced/004-expected.png: Updated.
  • fast/replaced/004-expected.checksum: Updated.
1:12 PM Changeset in webkit [12464] by mjs
  • 17 edits
    7 deletes in trunk/WebCore

Reviewed by Darin.

  • ForwardingHeaders/q3valuevector.h: Removed.
  • ForwardingHeaders/qptrvector.h: Removed.
  • ForwardingHeaders/qvector.h: Removed.
  • WebCore+SVG/KDOMSettings.cpp: (KDOMSettings::init): (KDOMSettings::isAdFiltered):
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge elementWithName:inForm:]): (-[WebCoreFrameBridge controlsInForm:]):
  • css/cssstyleselector.h:
  • khtml/html/HTMLCollectionImpl.cpp: (WebCore::HTMLCollectionImpl::updateNameCache): (WebCore::HTMLCollectionImpl::namedItems):
  • khtml/html/HTMLCollectionImpl.h:
  • khtml/html/HTMLFormCollectionImpl.cpp: (WebCore::HTMLFormCollectionImpl::HTMLFormCollectionImpl): (WebCore::HTMLFormCollectionImpl::calcLength): (WebCore::HTMLFormCollectionImpl::item): (WebCore::HTMLFormCollectionImpl::getNamedFormItem): (WebCore::HTMLFormCollectionImpl::updateNameCache):
  • khtml/html/HTMLFormElementImpl.cpp: (WebCore::HTMLFormElementImpl::~HTMLFormElementImpl): (WebCore::HTMLFormElementImpl::length): (WebCore::HTMLFormElementImpl::submitClick): (WebCore::HTMLFormElementImpl::formData): (WebCore::HTMLFormElementImpl::submit): (WebCore::HTMLFormElementImpl::reset): (WebCore::insertIntoVector): (WebCore::removeFromVector): (WebCore::HTMLFormElementImpl::formElementIndex): (WebCore::HTMLFormElementImpl::registerImgElement):
  • khtml/html/HTMLFormElementImpl.h:
  • ksvg2/svg/SVGTextElementImpl.cpp:
  • kwq/KWQComboBox.h:
  • kwq/KWQListBox.h:
  • kwq/KWQPtrVector.h: Removed.
  • kwq/KWQRenderTreeDebug.cpp: (writeLayers):
  • kwq/KWQValueVector.h: Removed.
  • kwq/KWQVectorImpl.cpp: Removed.
  • kwq/KWQVectorImpl.h: Removed.
  • loader/loader.cpp: (WebCore::Loader::cancelRequests):
  • rendering/render_layer.cpp: (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::hitTestLayer): (WebCore::compareZIndex): (WebCore::RenderLayer::updateZOrderLists): (WebCore::RenderLayer::collectLayers):
  • rendering/render_layer.h: (khtml::RenderLayer::posZOrderList): (khtml::RenderLayer::negZOrderList):
10:59 AM Changeset in webkit [12463] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Darin.

  • fast/table/border-collapsing/rtl-border-collapsing.html: Added.
  • fast/table/border-collapsing/rtl-border-collapsing-expected.txt: Added.
  • fast/table/border-collapsing/rtl-border-collapsing-expected.checksum: Added.
  • fast/table/border-collapsing/rtl-border-collapsing-expected.png: Added.
10:59 AM Changeset in webkit [12462] by darin
  • 5 edits in trunk/WebCore

Test: fast/table/border-collapsing/rtl-border-collapsing.html

Reviewed by Darin.

  • rendering/RenderTable.cpp: (WebCore::RenderTable::cellBefore): Renamed cellLeft to this. (WebCore::RenderTable::cellAfter): Renamed cellRight to this.
  • rendering/RenderTable.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedLeftBorder): Added the RTL case. (WebCore::RenderTableCell::collapsedRightBorder): Ditto. (WebCore::RenderTableCell::borderLeft): (WebCore::RenderTableCell::borderRight): (WebCore::RenderTableCell::collectBorders): (WebCore::RenderTableCell::paintCollapsedBorder):
  • rendering/RenderTableCell.h:
10:19 AM Changeset in webkit [12461] by darin
  • 1 edit
    10 adds in trunk/LayoutTests

Reviewed by Maciej.

  • fast/dom/Window/window-open-parent.html: Added.
  • fast/dom/Window/window-open-parent-no-parent.html: Added.
  • fast/dom/Window/window-open-self.html: Added.
  • fast/dom/Window/window-open-top.html: Added.
  • fast/dom/Window/resources: Added.
  • fast/dom/Window/resources/destination.html: Added.
  • fast/dom/Window/window-open-parent-expected.txt: Added.
  • fast/dom/Window/window-open-parent-no-parent-expected.txt: Added.
  • fast/dom/Window/window-open-self-expected.txt: Added.
  • fast/dom/Window/window-open-top-expected.txt: Added.
10:18 AM Changeset in webkit [12460] by darin
  • 1 edit in trunk/WebCore/khtml/html/htmlparser.cpp

Roll out file that was checked in by accident.

10:15 AM Changeset in webkit [12459] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

Tests:

  • fast/dom/Window/window-open-parent-no-parent.html: Added.
  • fast/dom/Window/window-open-parent.html: Added.
  • fast/dom/Window/window-open-self.html: Added.
  • fast/dom/Window/window-open-top.html: Added.
  • khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): Fix check for special frame names. These special frame names are supposed to always be unaffected by pop-up blocking. But the code instead was saying that the special frame names are always blocked. Oops!
10:11 AM Changeset in webkit [12458] by darin
  • 2 edits
    5 adds in trunk/LayoutTests
  • added a test for the names of range exceptions, which were wrong in my last commit until I made the fix Alexey suggested
  • fast/dom/Range: Added.
  • fast/dom/Range/range-exceptions.html: Added.
  • fast/dom/Range/resources: Added.
  • fast/dom/Range/resources/range-exceptions.js: Added.
  • fast/dom/Range/resources/TEMPLATE.html: Added.
  • fast/js/resources/js-test-pre.js: Escape & and < characters in the output so you can have tests with HTML fragments as expected results.
10:10 AM Changeset in webkit [12457] by darin
  • 2 edits in trunk/WebCore

Suggested by Alexey.

  • fixed something Alexey noticed in the new exception names

Test: fast/dom/Range/range-exceptions.html

  • khtml/ecma/kjs_binding.cpp: Added 0 to fix an off-by-one error for the names of the two DOM range exceptions.
7:11 AM Changeset in webkit [12456] by harrison
  • 1 edit
    8 adds in trunk/LayoutTests

Adding test cases for:
1) Arrowing up or down to an empty list item skipped the list item
2) Deleting the content of a list item made it so you could never get the cursor inside the empty item

  • editing/selection/move-by-line-002-expected.png: Added.
  • editing/selection/move-by-line-002-expected.checksum: Added.
  • editing/selection/move-by-line-002-expected.txt: Added.
  • editing/selection/move-by-line-002.html: Added.
  • editing/deleting/delete-listitem-002-expected.checksum: Added.
  • editing/deleting/delete-listitem-002-expected.png: Added.
  • editing/deleting/delete-listitem-002-expected.txt: Added.
  • editing/deleting/delete-listitem-002.html: Added.
7:06 AM Changeset in webkit [12455] by harrison
  • 4 edits in trunk/WebCore

Reviewed by John.

Fix two problems with editing around empty list items:
1) Arrowing up or down to an empty list item skipped the list item
2) Deleting the content of a list item made it so you could never get the cursor inside the empty item

Added tests:

  • selection/move-by-line-002.html
  • deleting/delete-listitem-002.html


  • khtml/editing/composite_edit_command.cpp: (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
  • special check for empty list item because list marker assures non-zero height()


  • khtml/xml/dom_position.cpp: (DOM::Position::inRenderedContent):
  • fix check wrt BRs because text box is not required


  • rendering/bidi.cpp: (khtml::RenderBlock::constructLine):
  • make sure that br by itself in a list item gets a text-style box


(khtml::RenderBlock::findNextLineBreak):

  • make sure that br by itself in a list item gets a box at all
6:40 AM Changeset in webkit [12454] by eseidel
  • 78 edits in trunk

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt & darin.

There are a few small, but intertwined fixes in this patch:

Remaining fixes for SVGTetris:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6889

Testing blocked by: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6905

Fix for CDF support:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6025

Updated test: svg/custom/simpleCDF.xml

Fix for filter updating:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6849

Testing blocked by: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6904

Also, as a side effect of 6849, fixed double-apply of filters, improving:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6713

Results updated for most tests, pixel results improved for filter tests.

  • kcanvas/KCanvasFilters.cpp: (KCanvasFilter::filterBBoxForItemBBox): moved into baseclass
  • kcanvas/KCanvasFilters.h:
  • kcanvas/RenderSVGImage.cpp: (RenderSVGImage::paint): use relativeBBox (RenderSVGImage::relativeBBox): added (RenderSVGImage::imageChanged): added (RenderSVGImage::getAbsoluteRepaintRect): fixed
  • kcanvas/RenderSVGImage.h: (KSVG::RenderSVGImage::imageChanged): added.
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::applyFilter): use new baseclass method (KCanvasFEFloodQuartz::getCIFilter): fixed.
  • kcanvas/device/quartz/KCanvasItemQuartz.h:
  • kcanvas/device/quartz/KCanvasItemQuartz.mm: (KCanvasItemQuartz::layout): update width/height (KCanvasItemQuartz::getAbsoluteRepaintRect): fixed. (KCanvasItemQuartz::requiresLayer): moved to .cpp (KCanvasItemQuartz::lineHeight): added. (KCanvasItemQuartz::baselinePosition): added.
  • kcanvas/device/quartz/KCanvasResourcesQuartz.h:
  • kcanvas/device/quartz/KCanvasResourcesQuartz.mm: (KCanvasContainerQuartz::canHaveChildren): moved to .cpp (KCanvasContainerQuartz::requiresLayer): moved to .cpp (KCanvasContainerQuartz::lineHeight): added. (KCanvasContainerQuartz::baselinePosition): added. (KCanvasContainerQuartz::paint): fixed. (KCanvasContainerQuartz::viewportTransform): fixed. (KCanvasContainerQuartz::getAbsoluteRepaintRect): fixed. (KCanvasContainerQuartz::absoluteTransform): fixed.
  • rendering/render_object.cpp: (WebCore::RenderObject::absoluteTransform): fixed apply order.
3:19 AM Changeset in webkit [12453] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Dave Hyatt.

  • kxmlcore/Vector.h: (KXMLCore::Vector::operator[]): Add unsigned overload
1:40 AM Changeset in webkit [12452] by eseidel
  • 4 edits
    4 adds in trunk

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

First set of fixes for SVG Tetris:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6889

Tests:

  • bridge/mac/MacFrame.mm: (MacFrame::keyEvent): pass key events to things other than HTML
  • ksvg2/svg/SVGSVGElementImpl.cpp: (WebCore::SVGSVGElementImpl::parseMappedAttribute): update viewport
1:09 AM Changeset in webkit [12451] by darin
  • 1 delete in trunk/LayoutTests/dom/xhtml/level2/html/HTMLIFrameElement11-expected.txt

Somehow this file was missed in the last commit. Since it's just a delete, do it without a new ChangeLog entry.

12:57 AM Changeset in webkit [12450] by darin
  • 21 edits
    10 deletes in trunk/LayoutTests
  • dom/xhtml/level1/core/hc_nodevalue03-expected.txt:
  • dom/xhtml/level3/core/canonicalform06-expected.txt:
  • dom/xhtml/level3/core/documentgetdoctype01-expected.txt:
  • dom/xhtml/level3/core/infoset06-expected.txt:
  • dom/xhtml/level3/core/infoset07-expected.txt:
  • dom/xhtml/level3/core/nodecomparedocumentposition02-expected.txt:
  • dom/xhtml/level3/core/nodeinsertbefore02-expected.txt:
  • dom/xhtml/level3/core/nodeinsertbefore05-expected.txt:
  • dom/xhtml/level3/core/nodeisequalnode17-expected.txt:
  • dom/xhtml/level3/core/noderemovechild04-expected.txt:
  • dom/xhtml/level3/core/noderemovechild05-expected.txt:
  • dom/xhtml/level3/core/nodereplacechild13-expected.txt:
  • dom/xhtml/level3/core/wellformed01-expected.txt:
  • dom/xhtml/level3/core/wellformed02-expected.txt:
  • dom/xhtml/level3/core/wellformed03-expected.txt:
  • dom/xhtml/level3/core/wellformed04-expected.txt:
  • for these, also changed the tests to be dumpAsText at the same time
  • fast/dom/outerText-no-element.html:
  • fast/dom/outerText-no-element-expected.txt:
  • fast/dynamic/outerHTML-no-element.html:
  • fast/dynamic/outerHTML-no-element-expected.txt:
  • fast/dom/outerText-no-element-expected.checksum: Removed.
  • fast/dom/outerText-no-element-expected.png: Removed.
  • fast/dynamic/outerHTML-no-element-expected.checksum: Removed.
  • fast/dynamic/outerHTML-no-element-expected.png: Removed.
  • removed test results for tests that are either disabled or not checked in
  • dom/xhtml/level2/html/HTMLIFrameElement11-expected.txt: Removed.
  • dom/xhtml/level3/core/documentadoptnode22-expected.txt: Removed.
  • editing/execCommand/boldCharacter-expected.txt: Removed.
  • fast/parser/remove-block-in-residual-style-expected.checksum: Removed.
  • fast/parser/remove-block-in-residual-style-expected.png: Removed.
  • fast/parser/remove-block-in-residual-style-expected.txt: Removed.
  • fast/plugins: Removed.
  • fast/plugins/netscape-back-forward-expected.txt: Removed.
  • fast/plugins/resources: Removed.
  • fast/plugins/resources/go-back.html: Removed.
12:26 AM Changeset in webkit [12449] by eseidel
  • 2 edits in trunk/WebCore

2006-01-29 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix SVG layout tests crash due to Vector change.

  • kcanvas/device/KRenderingDevice.cpp: (KRenderingDevice::currentContext): check isEmpty, return 0
12:04 AM Changeset in webkit [12448] by eseidel
  • 2 edits in trunk/WebCore

2006-01-28 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Remove bogus IntRect operator.

  • platform/FloatRect.h:

Jan 28, 2006:

11:45 PM Changeset in webkit [12447] by hyatt
  • 27 edits in trunk

WebCore:

Cleanup of RenderImage. Eliminate unneeded members and methods.

Reviewed by darin

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge elementAtPoint:]):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::callAsFunction): (KJS::drawPattern):
  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::attach):
  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLImageLoader::notifyFinished): (WebCore::HTMLImageElementImpl::attach):
  • khtml/html/html_imageimpl.h: (WebCore::HTMLImageElementImpl::compositeOperator):
  • khtml/html/html_objectimpl.cpp: (WebCore::HTMLObjectElementImpl::attach):
  • ksvg2/svg/SVGImageElementImpl.cpp: (SVGImageElementImpl::attach):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (WebCore::QPainter::drawImageAtPoint): (WebCore::QPainter::drawImageInRect): (WebCore::QPainter::drawImage): (WebCore::QPainter::drawFloatImage): (WebCore::QPainter::drawTiledImage): (WebCore::QPainter::drawScaledAndTiledImage):
  • kwq/WebCoreImageRenderer.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::ref): (WebCore::CachedImage::notifyObservers): (WebCore::CachedImage::data): (WebCore::CachedImage::error):
  • loader/CachedImage.h:
  • loader/CachedObjectClient.h: (WebCore::CachedObjectClient::imageChanged):
  • platform/Image.h: (WebCore::Image::):
  • platform/mac/Image.mm: (WebCore::Image::Image): (WebCore::Image::resetAnimation): (WebCore::Image::operator=): (WebCore::Image::stopAnimations): (WebCore::): (WebCore::Image::compositeOperatorFromString):
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/render_canvasimage.cpp: (WebCore::RenderCanvasImage::paint):
  • rendering/render_image.cpp: (WebCore::RenderImage::RenderImage): (WebCore::RenderImage::~RenderImage): (WebCore::RenderImage::setContentObject): (WebCore::RenderImage::setCachedImage): (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::resetAnimation): (WebCore::RenderImage::paint): (WebCore::RenderImage::layout): (WebCore::RenderImage::updateAltText): (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight):
  • rendering/render_image.h: (WebCore::RenderImage::cachedImage): (WebCore::RenderImage::image): (WebCore::RenderImage::errorOccurred):
  • rendering/render_list.cpp: (RenderListMarker::paint): (RenderListMarker::imageChanged):
  • rendering/render_list.h:
  • rendering/render_object.cpp: (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::setImage):
  • rendering/render_object.h:

WebKit:

Clean up RenderImage, eliminating unneeded members and methods.


Reviewed by darin

  • WebCoreSupport.subproj/WebImageRenderer.h:
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer copyWithZone:]): (-[WebImageRenderer size]): (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]):
11:42 PM Changeset in webkit [12446] by darin
  • 2 edits
    3 adds in trunk/LayoutTests

Reviewed by John Sullivan.

  • fast/js/date-constructor.html: Added.
  • fast/js/date-constructor-expected.txt: Added.
  • fast/js/resources/date-constructor.js: Added.
  • fast/js/resources/date-big-constructor.js: Formatting tweak.
11:42 PM Changeset in webkit [12445] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by John Sullivan.

  • khtml/ecma/kjs_binding.cpp: (KJS::setDOMException): Include the name of the exception in the error message.
11:38 PM Changeset in webkit [12444] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Eric.

  • fast/events/dispatch-to-handle-event.html: Added.
  • fast/events/dispatch-to-handle-event-expected.txt: Added.

WebCore:

Reviewed by Eric.

Test: fast/events/dispatch-to-handle-event.html

  • khtml/ecma/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent): Remove boolean that is always false, and correct the one place that was checking it to check the correct pointer instead.
10:52 PM Changeset in webkit [12443] by mjs
  • 9 edits
    1 delete in trunk/WebCore

Reviewed by Darin.

  • remove QPtrStack, replace with Vector or traverseNextNode as appropriate
  • WebCore.xcodeproj/project.pbxproj:
  • kcanvas/device/KRenderingDevice.cpp: (KRenderingDevice::currentContext): (KRenderingDevice::popContext): (KRenderingDevice::pushContext):
  • kcanvas/device/KRenderingDevice.h:
  • khtml/html/html_documentimpl.cpp:
  • khtml/xml/DocumentImpl.cpp:
  • khtml/xml/xml_tokenizer.cpp: (WebCore::XMLTokenizer::XMLTokenizer):
  • kwq/KWQAccObject.mm: (-[KWQAccObject addChildrenToArray:]):
  • kwq/KWQPainter.mm: (WebCore::QPainter::save): (WebCore::QPainter::restore):
  • kwq/KWQPtrStack.h: Removed.
  • ForwardingHeaders/qptrstack.h: Removed.
  • ForwardingHeaders/q3ptrstack.h: Removed.
10:47 PM Changeset in webkit [12442] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • miscellaneous Vector improvements
  • kxmlcore/Vector.h: (KXMLCore::Vector::at): Add range-checking asserts. (KXMLCore::Vector::first): Added as a convenience. (KXMLCore::Vector::last): Convenience for stack-style use. (KXMLCore::Vector::removeLast): ditto
10:25 PM Changeset in webkit [12441] by mjs
  • 1 edit
    1 add
    2 deletes in trunk/WebCore
  • added missing forwarding header to fix build.


  • ForwardingHeaders/kxmlcore/Vector.h: Added.
9:26 PM Changeset in webkit [12440] by darin
  • 2 edits in trunk/WebCore
  • khtml/ecma/kjs_binding.cpp: (KJS::setDOMException): Removed extra parameter to fix the build.
9:23 PM Changeset in webkit [12439] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • converted KWQKURL to use Vector :bugzilla.opendarwin.org/show_bug.cgi?id=6900

Use Vector in place of Array, and in place of the custom stack
buffers with overflow.


  • kwq/KWQKURL.mm: (KURL::KURL): (KURL::decode_string): (KURL::parse): (KURL::encode_string): (findHostnamesInMailToURL): (encodeHostnames):
8:30 PM Changeset in webkit [12438] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • khtml/ecma/kjs_binding.cpp: (KJS::setDOMException): Include the name of the exception in the error message.
8:18 PM Changeset in webkit [12437] by darin
  • 2 edits in trunk/JavaScriptCore
  • kjs/create_hash_table: Added missing license.
8:17 PM Changeset in webkit [12436] by darin
  • 2 edits in trunk/WebKitTools
  • DumpRenderTree/DumpRenderTree.m: (dump): Dump the image if it's not already there, even if the checksum is correct.
8:12 PM Changeset in webkit [12435] by mjs
  • 6 edits
    2 adds in trunk/JavaScriptCore

Reviewed by Dave Hyatt.


  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/internal.cpp: (KJS::Parser::saveNewNode): Apply Vector. (KJS::clearNewNodes): ditto
  • kjs/number_object.cpp: (integer_part_noexp): ditto (char_sequence): ditto
  • kjs/ustring.cpp: (KJS::UString::UTF8String): ditto
  • kxmlcore/HashMap.h: (KXMLCore::deleteAllValues): Tweaked this to only apply to HashMap, other versions are useful for other containers.
  • kxmlcore/Vector.h: Added. Implemented a Vector class, which should be usable for all Array/QVector style purposes, and also as a stack buffer with oversize handling. Also some helper classes to make vector operations as efficient as possible for POD types and for simple non-PODs like RefPtr. (KXMLCore::): (KXMLCore::VectorTypeOperations::destruct): (KXMLCore::VectorTypeOperations::initialize): (KXMLCore::VectorTypeOperations::move): (KXMLCore::VectorTypeOperations::uninitializedCopy): (KXMLCore::VectorTypeOperations::uninitializedFill): (KXMLCore::VectorBuffer::VectorBuffer): (KXMLCore::VectorBuffer::~VectorBuffer): (KXMLCore::VectorBuffer::deallocateBuffer): (KXMLCore::VectorBuffer::inlineBuffer): (KXMLCore::Vector::Vector): (KXMLCore::Vector::~Vector): (KXMLCore::Vector::size): (KXMLCore::Vector::capacity): (KXMLCore::Vector::isEmpty): (KXMLCore::Vector::at): (KXMLCore::Vector::operator[]): (KXMLCore::Vector::data): (KXMLCore::Vector::operator T*): (KXMLCore::Vector::operator const T*): (KXMLCore::Vector::begin): (KXMLCore::Vector::end): (KXMLCore::Vector::clear): (KXMLCore::Vector::fill): (KXMLCore::Vector::operator=): (KXMLCore::::Vector): (KXMLCore::::operator): (KXMLCore::::fill): (KXMLCore::::expandCapacity): (KXMLCore::::resize): (KXMLCore::::reserveCapacity): (KXMLCore::::append): (KXMLCore::deleteAllValues):
  • kxmlcore/VectorTraits.h: Added. (KXMLCore::VectorTraits): Traits to enable making Vector efficient for simple types.
5:50 PM Changeset in webkit [12434] by hyatt
  • 6 edits in trunk/WebCore

Eliminate three unused methods on Image: increase/DecreaseUseCount and flushRasterCache.

5:50 PM Changeset in webkit [12433] by hyatt
  • 1 edit in trunk/WebKit/WebCoreSupport.subproj/WebImageRenderer.m

Eliminate three unused methods on Image: increase/DecreaseUseCount and flushRasterCache.

5:32 PM Changeset in webkit [12432] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Darin.

  • fast/table/add-before-anonymous-child.html: Added.
  • fast/table/add-before-anonymous-child-expected.txt: Added.
  • fast/table/add-before-anonymous-child-expected.png: Added.
  • fast/table/add-before-anonymous-child-expected.checksum: Added.
5:29 PM Changeset in webkit [12431] by darin
  • 3 edits in trunk/WebCore

Test: fast/table/add-before-anonymous-child.html

Reviewed by Darin.

  • rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild): If beforeChild is inside an anonymous cell, insert into the cell.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): Changed comment.
4:58 PM Changeset in webkit [12430] by hyatt
  • 3 edits in trunk/WebCore

Eliminate the mask() method on Image. It's unused.

  • platform/Image.h:
  • platform/mac/Image.mm:
4:16 PM Changeset in webkit [12429] by hyatt
  • 1 edit in trunk/WebCore/ChangeLog

Fix Changelog typo.

4:15 PM Changeset in webkit [12428] by hyatt
  • 7 edits in trunk/WebCore

Clean up the Image class. Eliminate the MIME type memebr variable.
Eliminate an unused constructor. Fix the constructor to take
a QString rather than an NSString so that it's portable. Rename
the receivedData method to decode. Move canRenderImageType into
the Image class as a static method.

Reviewed by mjs

  • khtml/html/html_objectimpl.cpp: (WebCore::HTMLObjectElementImpl::isImageType):
  • kwq/KWQLoader.h:
  • kwq/KWQLoader.mm: (KWQResponseMIMEType):
  • loader/CachedImage.cpp: (WebCore::CachedImage::data):
  • platform/Image.h:
  • platform/mac/Image.mm: (WebCore::Image::supportsType): (WebCore::Image::Image): (WebCore::Image::~Image): (WebCore::Image::decode): (WebCore::Image::operator=):
2:18 AM Changeset in webkit [12427] by eseidel
  • 3 edits
    4 adds in trunk

2006-01-28 Alexander Kellett <​lypanov@kde.org>

Reviewed by eseidel.

SourceAlpha does not display until window is redrawn (resized)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6375

Test: svg/custom/filter-source-alpha.svg

  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFilterQuartz::inputImage):`
12:53 AM Changeset in webkit [12426] by ap
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16): Fallback to kCFStringEncodingWindowsLatin1 if the passed buffer is not valid UTF-8, preventing crashes.
12:52 AM Changeset in webkit [12425] by hyatt
  • 13 edits
    2 deletes in trunk/WebCore

Fix CachedImage.h/.cpp up. Lots of cleanup. Eliminated
unused code and cleaned up method and member names.

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLImageElementImpl::width): (WebCore::HTMLImageElementImpl::height):
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::CachedImage::ref): (WebCore::CachedImage::deref): (WebCore::CachedImage::image): (WebCore::CachedImage::imageSize): (WebCore::CachedImage::decodedRect): (WebCore::CachedImage::notifyObservers): (WebCore::CachedImage::clear): (WebCore::CachedImage::data): (WebCore::CachedImage::error): (WebCore::CachedImage::checkNotify):
  • loader/CachedImage.h: (WebCore::CachedImage::isDecoded): (WebCore::CachedImage::isErrorImage): (WebCore::CachedImage::schedule): (WebCore::CachedImage::isImage):
  • loader/CachedImageCallback.cpp: Removed.
  • loader/CachedImageCallback.h: Removed.
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests): (WebCore::Loader::slotFinished):
  • platform/Image.h:
  • platform/mac/Image.mm: (WebCore::Image::receivedData):
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/render_image.cpp: (WebCore::RenderImage::setImage): (WebCore::RenderImage::paint):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder):
  • rendering/render_list.cpp: (RenderListMarker::setImage):
  • rendering/render_object.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::paintBorder): (WebCore::RenderObject::setImage):
Note: See TracTimeline for information about the timeline view.