Timeline



Feb 7, 2006:

9:31 PM Changeset in webkit [12655] by mjs
  • 57 edits
    2 moves
    1 add in trunk/WebCore

Rubber stamped by Hyatt.

  • move kwq/KWQString.mm to platform/QString.cpp, split out nonportable parts, speculative port of one remaining nonportable bit to windows.
  • ForwardingHeaders/qstring.h:
  • WebCore+SVG/KDOMSettings.h:
  • WebCore+SVG/kdom.h:
  • WebCore.xcodeproj/project.pbxproj:
  • css/cssparser.h:
  • css/cssstyleselector.cpp:
  • kcanvas/KCanvasResources.h:
  • kcanvas/KCanvasTreeDebug.h:
  • khtml/ecma/kjs_window.h:
  • khtml/editing/html_interchange.cpp:
  • khtml/editing/visible_position.h:
  • khtml/editing/visible_text.h:
  • khtml/editing/visible_units.cpp:
  • khtml/html/FormDataList.h:
  • khtml/html/html_objectimpl.cpp:
  • khtml/html/htmltokenizer.h:
  • khtml/misc/decoder.h:
  • khtml/misc/formdata.h:
  • khtml/xbl/xbl_protohandler.cpp:
  • khtml/xml/dom_position.cpp:
  • khtml/xsl/xslt_processorimpl.h:
  • ksvg2/svg/SVGHelper.h:
  • ksvg2/svg/SVGPreserveAspectRatioImpl.cpp:
  • ksvg2/svg/SVGStyleElementImpl.cpp:
  • ksvg2/svg/SVGURIReferenceImpl.h:
  • ksvg2/svg/svgpathparser.cpp:
  • kwq/KWQAccObjectCache.mm:
  • kwq/KWQBuffer.h:
  • kwq/KWQEvent.h:
  • kwq/KWQFont.mm:
  • kwq/KWQFontFamily.h:
  • kwq/KWQFontMetrics.h:
  • kwq/KWQKConfigBase.h:
  • kwq/KWQKDebug.h:
  • kwq/KWQKHTMLSettings.h:
  • kwq/KWQKJobClasses.h:
  • kwq/KWQKJobClasses.mm:
  • kwq/KWQKLocale.mm:
  • kwq/KWQKSSLKeyGen.mm:
  • kwq/KWQKURL.h:
  • kwq/KWQLineEdit.h:
  • kwq/KWQRegExp.h:
  • kwq/KWQRenderTreeDebug.h:
  • kwq/KWQString.h: Removed.
  • kwq/KWQString.mm: Removed.
  • kwq/KWQStringList.h:
  • kwq/KWQTextCodec.h:
  • kwq/KWQTextStream.h:
  • kwq/KWQTextUtilities.mm:
  • kwq/WebCoreScriptDebugger.mm:
  • loader/Cache.h:
  • platform/Color.cpp:
  • platform/Color.h:
  • platform/QString.cpp: Added. (allocateHandle): (KWQStringData::KWQStringData): (QString::QString): (QString::insert): (QString::detach): (QString::remove): (QString::setLength): (QString::fill): (initializeHandleNodeBlock): (allocateNode): (freeHandle):
  • platform/QString.h: Added.
  • platform/SegmentedString.h:
  • platform/StringImpl.h:
  • platform/mac/Image.mm:
  • platform/mac/QString.mm: Added. (QString::setBufferFromCFString): (QString::fromCFString): (QString::fromNSString): (QString::getNSString): (QString::utf8): (QString::fromUtf8):
  • rendering/bidi.h:
  • rendering/break_lines.cpp:
7:05 PM Changeset in webkit [12654] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Update page directory in Win32 project to match what's there now.

7:01 PM Changeset in webkit [12653] by mjs
  • 12 edits
    1 delete in trunk/WebCore

Reviewed by Adele.

  • remove all remains of old-style frame tree, ChildFrame, ObjectContents and FrameList are all gone
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/BrowserExtension.h:
  • bridge/mac/BrowserExtensionMac.h:
  • bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
  • khtml/ecma/kjs_window.cpp: (KJS::createNewWindow): (KJS::Window::indexGetter): (KJS::Window::getOwnPropertySlot): (KJS::WindowFunc::callAsFunction): (KJS::FrameArray::getValueProperty): (KJS::FrameArray::indexGetter): (KJS::FrameArray::nameGetter): (KJS::FrameArray::getOwnPropertySlot):
  • kwq/KWQFrame.mm: (QFrame::setFrameStyle):
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::stopLoading): (WebCore::Frame::clear): (WebCore::Frame::stopAnimations): (WebCore::Frame::checkCompleted): (WebCore::Frame::checkEmitLoadEvent): (WebCore::Frame::requestFrame): (WebCore::Frame::requestObject): (WebCore::Frame::loadSubframe): (WebCore::Frame::findFrame): (WebCore::Frame::frameExists): (WebCore::Frame::setZoomFactor): (WebCore::Frame::frameNames): (WebCore::Frame::frames): (WebCore::Frame::childFrameNamed): (WebCore::Frame::slotPartRemoved): (WebCore::Frame::connectChild): (WebCore::Frame::disconnectChild): (WebCore::Frame::canCachePage): (WebCore::Frame::setPolicyBaseURL): (WebCore::Frame::treeNode): (WebCore::Frame::frameDetached):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/FrameTreeNode.h: (WebCore::FrameTreeNode::name): (WebCore::FrameTreeNode::parent): (WebCore::FrameTreeNode::nextSibling): (WebCore::FrameTreeNode::previousSibling): (WebCore::FrameTreeNode::firstChild): (WebCore::FrameTreeNode::lastChild): (WebCore::FrameTreeNode::childCount):
  • page/ObjectContents.h: Removed.
  • page/Plugin.h: (WebCore::Plugin::view):
6:39 PM Changeset in webkit [12652] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

  • test for <rdar://problem/3727939> Safari strips \0 characters from HTML tags making them valid
  • fast/encoding/decoder-allow-null-chars.html
  • fast/encoding/decoder-allow-null-chars-expected.txt

WebCore:

Reviewed by Maciej.

  • Fixed <rdar://problem/3727939> Safari strips \0 characters from HTML tags making them valid

Test: fast/encoding/decoder-allow-null-chars.html

  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::convertLatin1): Removed stripping of null characters (unwanted): ditto.
4:46 PM Changeset in webkit [12651] by hyatt
  • 3 edits
    2 adds in trunk/WebCore

Land the skeleton of a PNG decoder for Win32.

4:14 PM Changeset in webkit [12650] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Add bindings/js/JSEvents.cpp to the win32 build.

3:08 PM Changeset in webkit [12649] by eseidel
  • 6 edits
    1 delete in trunk/WebCore

2006-02-07 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Removed ImageSubset, making ImageViewer link directly to WebCore.

  • Viewer.vcproj:
  • WebCore.vcproj/ImageSubset: Removed.
  • WebCore.vcproj/ImageSubset/ImageSubset.vcproj: Removed.
  • WebCore.vcproj/WebCore.sln:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
1:36 PM Changeset in webkit [12648] by hyatt
  • 1 edit
    2 adds in trunk/WebCore/WebCore.vcproj

Add Image Subset of WebCore as a project to the win32 build for the Image Viewer app to link against.

1:32 PM Changeset in webkit [12647] by ggaren
  • 4 edits in trunk/WebCore

Reviewed by darin.

  • Fixed <rdar://problem/4425269> REGRESSION: wrong size pop-up when downloading attachment at webmail.mac.com (6882)

The bug was that the feature string parser didn't always initialize the
*Set variables, so WebCore assumed a height was set when it wasn't,
and used a garbage height variable.

While there, I fixed two other bugs: (1) The parser wasn't chewing up
as many characters as I thought it was. (Chewing up extra characters
is necessary to match Win IE.) (2) We considered \t and \f to be
whitespace, but Win IE doesn't.

  • manual-tests/window-open-features-parsing.html: Added these cases, fixed up comments.
  • bridge/BrowserExtension.h: Cleaned up declaration order a bit.
  • khtml/ecma/kjs_window.cpp: (KJS::isSeparator): New function, tells you if a character is a separator (KJS::parseWindowFeatures): Always initialize *Set to false. Drive parsing based on invalid characters ('separators') rather than valid ones, to match Win IE.
1:27 PM Changeset in webkit [12646] by darin
  • 8 edits in trunk/WebKitSite

Set more MIME types.

1:17 PM Changeset in webkit [12645] by darin
  • 81 edits in trunk/WebKitSite

Set a bunch of MIME types.

9:01 AM Changeset in webkit [12644] by ap
  • 10 edits
    9 adds in trunk

2006-02-07 Alexey Proskuryakov <​ap@nypop.com>

Reviewed by Timothy.

Convert JavaScript objects to appropriate AppleScript types, instead of only strings
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7012

WebKit:

  • WebView/WebView.m: (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Added.
  • WebView/WebViewPrivate.h:

WebCore:

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): Added. (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]): Added.

WebKitTools:

  • DumpRenderTree/AppleScriptController.h: Added.
  • DumpRenderTree/AppleScriptController.m: Added.
  • DumpRenderTree/DumpRenderTree.m: (-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]):
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

LayoutTests:

  • fast/AppleScript: Added.
  • fast/AppleScript/001-expected.txt: Added.
  • fast/AppleScript/001.html: Added.
  • fast/AppleScript/array-expected.txt: Added.
  • fast/AppleScript/array.html: Added.
  • fast/AppleScript/date-expected.txt: Added.
  • fast/AppleScript/date.html: Added.
3:31 AM Changeset in webkit [12643] by hyatt
  • 47 adds in trunk/WebCore/platform/image-decoders

Add libpng and the zlib supporting library in preparation for iplementing PNG decoding.

3:07 AM Changeset in webkit [12642] by hyatt
  • 3 edits
    5 moves in trunk/WebCore

FInal image renaming for Win32 gif stuff.

2:47 AM Changeset in webkit [12641] by hyatt
  • 6 edits
    3 moves
    1 delete in trunk/WebCore

Rename ImageDecoder to ImageSource.

Reviewed by mjs

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Image.cpp: (WebCore::Image::cacheFrame): (WebCore::Image::size): (WebCore::Image::setNativeData): (WebCore::Image::frameCount): (WebCore::Image::isSizeAvailable):
  • platform/Image.h:
  • platform/ImageDecoder.h: Removed.
  • platform/ImageSource.h: Added.
  • platform/cairo/ImageCairo.cpp: (WebCore::Image::drawInRect):
  • platform/cairo/ImageDecoderCairo.cpp: Removed.
  • platform/cairo/ImageSourceCairo.cpp: Added. (WebCore::createDecoderPlugin): (WebCore::ImageSource::ImageSource): (WebCore::ImageSource::~ImageSource): (WebCore::ImageSource::initialized): (WebCore::ImageSource::setData): (WebCore::ImageSource::isSizeAvailable): (WebCore::ImageSource::size): (WebCore::ImageSource::repetitionCount): (WebCore::ImageSource::frameCount): (WebCore::ImageSource::createFrameAtIndex): (WebCore::ImageSource::frameDurationAtIndex):
  • platform/mac/Image.mm: (WebCore::Image::drawInRect):
  • platform/mac/ImageData.mm: Removed.
  • platform/mac/ImageDecoder.cpp: Removed.
  • platform/mac/ImageSource.cpp: Added. (WebCore::ImageSource::ImageSource): (WebCore::ImageSource::~ImageSource): (WebCore::ImageSource::initialized): (WebCore::ImageSource::setData): (WebCore::ImageSource::isSizeAvailable): (WebCore::ImageSource::size): (WebCore::ImageSource::repetitionCount): (WebCore::ImageSource::frameCount): (WebCore::ImageSource::createFrameAtIndex): (WebCore::ImageSource::frameDurationAtIndex):
2:17 AM Changeset in webkit [12640] by hyatt
  • 22 edits
    2 deletes in trunk/WebCore

Combine ImageData and Image (the result ends up in Image).

Reviewed by mjs

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (-[DOMElement _image]): (-[DOMElement _imageTIFFRepresentation]):
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::fileWrapperForElement):
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (KCanvasFEImageQuartz::getCIFilter):
  • khtml/ecma/kjs_html.cpp: (KJS::KJS::Context2DFunction::callAsFunction): (KJS::drawPattern): (KJS::_rh): (KJS::ImagePattern::createPattern):
  • kwq/KWQClipboard.mm: (WebCore::KWQClipboard::dragNSImage):
  • kwq/KWQCursor.h:
  • kwq/KWQCursor.mm: (WebCore::createCustomCursor): (WebCore::QCursor::QCursor):
  • kwq/KWQPainter.h:
  • kwq/KWQPainter.mm: (WebCore::QPainter::drawImageAtPoint): (WebCore::QPainter::drawImageInRect): (WebCore::QPainter::drawImage): (WebCore::QPainter::drawFloatImage): (WebCore::QPainter::drawTiledImage): (WebCore::QPainter::drawScaledAndTiledImage):
  • loader/CachedImage.cpp: (WebCore::CachedImage::image):
  • loader/CachedImage.h:
  • page/FrameView.cpp: (WebCore::selectCursor):
  • platform/Image.cpp: (WebCore::Image::Image): (WebCore::Image::~Image): (WebCore::Image::invalidateData): (WebCore::Image::cacheFrame): (WebCore::Image::isNull): (WebCore::Image::size): (WebCore::Image::setData): (WebCore::Image::setNativeData): (WebCore::Image::frameCount): (WebCore::Image::isSizeAvailable): (WebCore::Image::frameAtIndex): (WebCore::Image::frameDurationAtIndex): (WebCore::Image::shouldAnimate): (WebCore::Image::startAnimation): (WebCore::Image::stopAnimation): (WebCore::Image::resetAnimation): (WebCore::Image::advanceAnimation): (WebCore::Image::rect):
  • platform/Image.h: (KXMLCore::): (WebCore::FrameData::m_duration): (WebCore::FrameData::~FrameData): (WebCore::Image::currentFrame): (WebCore::Image::animationObserver): (WebCore::Image::setIsPDF):
  • platform/ImageData.cpp: Removed.
  • platform/ImageData.h: Removed.
  • platform/cairo/ImageCairo.cpp: (WebCore::FrameData::clear): (WebCore::Image::initNativeData): (WebCore::Image::destroyNativeData): (WebCore::Image::invalidateNativeData): (WebCore::Image::drawInRect): (WebCore::Image::tileInRect): (WebCore::Image::scaleAndTileInRect):
  • platform/mac/Image.mm: (WebCore::FrameData::clear): (WebCore::Image::initNativeData): (WebCore::Image::destroyNativeData): (WebCore::Image::invalidateNativeData): (WebCore::Image::loadResource): (WebCore::Image::supportsType): (WebCore::Image::checkForSolidColor): (WebCore::Image::getTIFFRepresentation): (WebCore::Image::getNSImage): (WebCore::Image::getCGImageRef): (WebCore::Image::drawInRect): (WebCore::drawPattern): (WebCore::Image::tileInRect): (WebCore::Image::scaleAndTileInRect):
  • rendering/render_image.cpp: (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::resetAnimation): (WebCore::RenderImage::paint): (WebCore::RenderImage::nullImage):
  • rendering/render_image.h: (WebCore::RenderImage::image):
  • rendering/render_list.cpp: (RenderListItem::getAbsoluteRepaintRect): (RenderListMarker::paint): (RenderListMarker::calcMinMaxWidth):
  • rendering/render_object.cpp: (WebCore::RenderObject::paintBorderImage):
1:29 AM Changeset in webkit [12639] by mjs
  • 6 edits in trunk/WebKitSite

Reviewed by Darin. Landed by Maciej.


  • blog/wp-content/themes/webkit/style.css:
  • index.html:
  • quality/bugwriting.html:
  • quality/reduction.html:
  • webkitdev.css:
1:21 AM Changeset in webkit [12638] by mjs
  • 18 edits
    2 adds
    2 deletes in trunk

LayoutTests:

Reviewed by Eric.


  • fast/dom/HTMLObjectElement/object-as-frame-expected.txt: Added.
  • fast/dom/HTMLObjectElement/object-as-frame.html: Added.


  • fast/events/event-targets-expected.checksum: Removed.
  • fast/events/event-targets-expected.png: Removed.
  • fast/events/event-targets-expected.txt:
  • fast/events/event-targets.html:

WebCore:

Reviewed by Eric.



  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::MacFrame): pass along renderer (WebCore::MacFrame::nextKeyViewInFrameHierarchy): get owner element in newfangled way
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge removeChild:]): don't mess with renderer (-[WebCoreFrameBridge init]): call new designated initializer (-[WebCoreFrameBridge initWithRenderer:]): new designated initializer (-[WebCoreFrameBridge dealloc]): don't mess with renderer (-[WebCoreFrameBridge finalize]): ditto (-[WebCoreFrameBridge installInFrame:]): ditto
  • page/Frame.cpp: (WebCore::FrameList::find): get name from frame not ChildFrame (WebCore::Frame::init): take renderer parameter (WebCore::Frame::clear): clear m_plugins, not m_objects (WebCore::Frame::childBegin): updated comment (WebCore::Frame::stop): add check-completed for documentless case here (WebCore::Frame::checkCompleted): don't track separate completed flag in ChildFrame, use the sub Frame object's own (WebCore::Frame::checkEmitLoadEvent): ditto (WebCore::Frame::requestFrame): don't store renderer and name in ChildFrame, instead pass them along (WebCore::Frame::requestObject): ditto above (WebCore::Frame::loadPlugin): expect renderer parameter (WebCore::Frame::loadSubframe): expect renderer and name parameters (WebCore::Frame::slotChildStarted): don't mess with ChildFrame (WebCore::Frame::slotChildCompleted): ditto (WebCore::Frame::childFrame): don't check m_objects (WebCore::Frame::frameExists): fix spacing, remove obsolete check and comment (WebCore::Frame::frameNames): get name from frame (WebCore::Frame::ownerElement): simplify a lot since the Frame knows its owner renderer now (WebCore::Frame::ownerRenderer): added (WebCore::Frame::canCachePage): check m_plugins not m_objects
  • page/Frame.h:
  • page/FramePrivate.h: (WebCore::ChildFrame): Remove constructor, most fields. (WebCore::FramePrivate::FramePrivate): Pass ownerRenderer
  • rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget): Make sure to pass name attr to requestObject.

WebKit:

Reviewed by Eric.


  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initWithPage:webView:renderer:frameName:view:]): Pass along renderer. (-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): Pass along renderer.
  • WebCoreSupport/WebPageBridge.m: (-[WebPageBridge initWithMainFrameName:webView:frameView:]): Pass null for renderer.
  • WebView/WebView.m:
  • WebView/WebViewPrivate.h:

Feb 6, 2006:

11:48 PM Changeset in webkit [12637] by adele
  • 8 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/events/event-listener-on-link.html: Added.
  • fast/events/event-listener-on-link-expected.txt: Added.
  • fast/events/event-listener-on-link-expected.png: Added.
  • fast/events/event-listener-on-link-expected.checksum: Added.

WebCore:

Reviewed by Maciej.

Test: fast/events/event-listener-on-link.html

  • khtml/xml/dom_elementimpl.h: Added createAttrImplIfNeeded, removed allocateImpl, changed AttrImpl contructor to remove createTextChild bool, added createTextChild method, changed getAttributeNode, getAttributeNodeNS, getNamedItem, getNamedItemNS, and item to return PassRefPtrs. (DOM::ElementImpl::getAttributeNode):
  • khtml/xml/dom_elementimpl.cpp: (WebCore::AttributeImpl::createAttrImplIfNeeded): New method to replace allocateImpl. This will use a RefPtr for the AttrImpl, check for an existing AttrImpl, create one if there isn't one, and will call the new createTextChild. (WebCore::AttrImpl::AttrImpl): Moved creation of text child to new createTextChild method. If done in the constructor, the ref count is still 0, and the act of appending the text node could cause the AttrImpl to be destroyed. (WebCore::AttrImpl::createTextChild): Moved code from AttrImpl contructor. Also, I've added an assert to make sure that any callers of this have ref'd the AttrImpl. (WebCore::AttrImpl::cloneNode): Used RefPtr instead of PassRefPtr, and then called release() on it before returning. (WebCore::ElementImpl::cloneNode): ditto. (WebCore::ElementImpl::getAttributeNodeNS): Changed return type to PassRefPtr. (WebCore::NamedAttrMapImpl::getNamedItemNS): ditto. (WebCore::NamedAttrMapImpl::getNamedItem): ditto. Changed use of allocateImpl to createAttrImplIfNeeded (WebCore::NamedAttrMapImpl::setNamedItem): ditto. (WebCore::NamedAttrMapImpl::removeNamedItem): ditto. (WebCore::NamedAttrMapImpl::item): ditto.
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::createAttributeNS): Changed return type to PassRefPtr and removed bool from AttrImpl contructor call.
  • khtml/xml/DocumentImpl.h: Now returns a PassRefPtr for createAttribute and createAttributeNS. (WebCore::DocumentImpl::createAttribute):
  • khtml/xml/NamedNodeMapImpl.h: Now returns a PassRefPtr for getNamedItem, getNamedItemNS, and item. (WebCore::NamedNodeMapImpl::getNamedItem):
  • bindings/objc/DOM.mm: (-[DOMNamedNodeMap getNamedItem:]): Call get() since the methods discussed above now return PassRefPtrs. (-[DOMNamedNodeMap item:]): ditto. (-[DOMNamedNodeMap getNamedItemNS::]): ditto. (-[DOMDocument createAttribute:]): ditto. (-[DOMDocument createAttributeNS::]): ditto. (-[DOMElement getAttributeNode:]): ditto. (-[DOMElement getAttributeNodeNS::]): ditto.
11:37 PM Changeset in webkit [12636] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Darin.


  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::parseMappedAttribute): connect onfocus/onblur to focus/blur, not DOMFocusIn/DOMFocusOut
11:14 PM Changeset in webkit [12635] by mjs
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Darin.

  • fast/events/div-focus-expected.txt: Added.
  • fast/events/div-focus.html: Added.
11:07 PM Changeset in webkit [12634] by hyatt
  • 1 edit in trunk/WebCore/platform/Image.cpp

Fix build bustage on Mac.

11:06 PM Changeset in webkit [12633] by hyatt
  • 1 edit in trunk/WebCore/platform/Image.cpp

Fix build bustage on Mac.

10:57 PM Changeset in webkit [12632] by eseidel
  • 2 edits in trunk/WebCore

2006-02-06 Eric Seidel <​eseidel@apple.com>

Add svn:ignore properties for visual studio internals.

10:56 PM Changeset in webkit [12631] by eseidel
  • 2 edits in trunk/JavaScriptCore

2006-02-06 Eric Seidel <​eseidel@apple.com>

Add svn:ignore properties for visual studio internals.

10:52 PM Changeset in webkit [12630] by eseidel
  • 3 edits in trunk/WebKitTools

2006-02-06 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Fix build-webkit for use on win32 (unblocks buildbot usage).
​http://bugzilla.opendarwin.org/show_bug.cgi?id=7122

  • Scripts/build-webkit: use ifCygwin() to conditionalize builds
  • Scripts/webkitdirs.pm: add ifOSX() and ifCygwin()
10:30 PM Changeset in webkit [12629] by hyatt
  • 1 move in trunk/WebCore/platform/win/SystemTimeWin.cpp

Rename SystemTime.cpp to SystemTimeWin.cpp

10:29 PM Changeset in webkit [12628] by hyatt
  • 1 edit in trunk/WebCore/WebCore.vcproj/WebCore/WebCore.vcproj

Rename SystemTime.cpp to SystemTimeWin.cpp

10:28 PM Changeset in webkit [12627] by hyatt
  • 1 delete in trunk/WebCore/platform/win/ImageDecoderPlugin.h

Remove accidentally committed file.

10:15 PM Changeset in webkit [12626] by hyatt
  • 1 edit in trunk/WebCore/khtml/ecma/kjs_html.cpp

Fix more build bustage.

10:13 PM Changeset in webkit [12625] by hyatt
  • 3 edits
    21 adds in trunk/WebCore

Land image viewer test app.

10:11 PM Changeset in webkit [12624] by ap
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • No tests added - only changed functionality on WIN32, which should be covered by existing tests.
  • kjs/date_object.cpp: (gmtoffset): On WIN32, use the recommended global (_timezone rather than timezone). Updated comments. (KJS::timeZoneOffset): Removed, was basically the same as the above. (KJS::formatTime): Pass an UTC flag - UTC/local cannot be correctly selected on Windows based on struct tm itself. (KJS::DateInstance::getTime): Added. (KJS::DateInstance::getUTCTime): Added. (KJS::millisecondsToTM): Factored out from DateProtoFunc::callAsFunction(). (KJS::DateObjectImp::callAsFunction): Use the new parameter to formatTime(). (KJS::DateProtoFunc::callAsFunction): Updated for the other changes. The code for GetTimezoneOffset was incorrect on WIN32 - _daylight global has nothing to do with daylight savings time being in effect.
  • kjs/date_object.h: Added prototypes for new functions.
9:55 PM Changeset in webkit [12623] by hyatt
  • 1 delete in trunk/WebCore/platform/cairo/.cvsignore

Remove stray .cvsignore file accidentally committed.

9:51 PM Changeset in webkit [12622] by hyatt
  • 1 edit in trunk/WebCore/khtml/ecma/kjs_html.cpp

Fix build bustage. Missed a file.

9:37 PM Changeset in webkit [12621] by hyatt
  • 11 edits
    12 adds in trunk/WebCore

Land new image code (excluding the test app, work to do there still)

9:30 PM Changeset in webkit [12620] by hyatt
  • 8 adds
    1 delete in trunk/WebCore/platform/cairo/cairo

Commit remaining Cairo files.

9:13 PM Changeset in webkit [12619] by hyatt
  • 98 adds in trunk/WebCore/platform/cairo/cairo/src

Land Cairo itself.

9:10 PM Changeset in webkit [12618] by hyatt
  • 3 adds in trunk/WebCore/platform/cairo/pixman

Land pixman portion of Cairo.

9:04 PM Changeset in webkit [12617] by hyatt
  • 33 adds in trunk/WebCore/platform/cairo/pixman/src

Land pixman portion of Cairo.

8:51 PM Changeset in webkit [12616] by hyatt
  • 1 add in trunk/WebCore/platform/cairo/pixman/src

Commit cairo. Having to do this in pieces since the commit hangs otherwise.

8:51 PM Changeset in webkit [12615] by hyatt
  • 1 add in trunk/WebCore/platform/cairo/pixman

Commit cairo. Having to do this in pieces since the commit hangs otherwise.

8:50 PM Changeset in webkit [12614] by hyatt
  • 1 add in trunk/WebCore/platform/cairo/cairo/test

Commit cairo. Having to do this in pieces since the commit hangs otherwise.

8:50 PM Changeset in webkit [12613] by hyatt
  • 1 add in trunk/WebCore/platform/cairo/cairo/src

Commit cairo. Having to do this in pieces since the commit hangs otherwise.

8:48 PM Changeset in webkit [12612] by hyatt
  • 1 add in trunk/WebCore/platform/cairo/cairo

Commit cairo. Having to do this in pieces since the commit hangs otherwise.

8:48 PM Changeset in webkit [12611] by hyatt
  • 1 add in trunk/WebCore/platform/cairo

Commit cairo. Having to do this in pieces since the commit hangs otherwise.

7:39 PM Changeset in webkit [12610] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Darin and Eric.

  • fix <rdar://problem/4414918> REGRESSION: images dragged into contenteditable area end up outside of editable area (6525)
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:]): Moved code from elementAtPoint to this new method. This method takes a point and returns a NodeInfo for the deepest node at that point. (-[WebCoreFrameBridge elementAtPoint:]): Use new nodeInfoAtPoint method. (-[WebCoreFrameBridge _visiblePositionForPoint:]): Ditto.
7:16 PM Changeset in webkit [12609] by eseidel
  • 1 edit
    2 adds in trunk/WebKitTools

2006-02-06 Eric Seidel <​eseidel@apple.com>

Rubber-stamped by darin & mjs.

Added new support directory for build slave scripts.
Committing the first script, for use by the PLT's build slave.
This script is used to kick of the PLT (Page Load Test) slave.

  • BuildSlaveSupport: Added.
  • BuildSlaveSupport/run-performance-tests: Added.
6:47 PM Changeset in webkit [12608] by darin
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by NOBODY (OOPS!).

  • fast/overflow/scroll-vertical-not-horizontal.html: Added.
  • fast/overflow/scroll-vectical-not-horizontal-expected.txt: Added.
6:47 PM Changeset in webkit [12607] by darin
  • 2 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

Test: fast/overflow/scroll-vertical-not-horizontal.html

  • rendering/render_layer.cpp: (WebCore::RenderLayer::getRectToExpose): Fixed rectangle intersections so that the X and Y dimensions are independent, to fix the bug. Also restructured the function a bit so it's even easier to read and understand.
5:26 PM Changeset in webkit [12606] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Merged fix from TOT to Safari-2-0-branch

2005-11-01 Justin Garcia <​justin.garcia@apple.com>

Reviewed by darin

Fixes <rdar://problem/4074536> Seed: Mail crash adjusting quote level - KHTMLPart::computeAndSetTypingStyle

No test cases added, requires Mail

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge typingStyle]): Crashes were happening after a style was merged with itself. Mail was doing a setTypingStyle with a pointer to our internal typing style. Fix is to only hand out copies of our typingStyle.
5:16 PM Changeset in webkit [12605] by sullivan
  • 3 edits in trunk/WebKitLibraries
  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a: removed WKExecutableLinkedInTigerOrEarlier
5:15 PM Changeset in webkit [12604] by harrison
  • 2 edits in trunk/WebCore

Suggested by Darin.


  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::createContextualFragment):
  • make nextChild a RefPtr to survive possible DOM changes
5:10 PM Changeset in webkit [12603] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Maciej Stachowiak.

  • WebView/WebPDFView.m: (-[WebPDFView menuForEvent:]): Removed use of WKExecutableLinkedInTigerOrEarlier() by modifying backward-compatibility hack involving PDF view context menus. Now we only bother to make sure that the PDFKit- supplied context menu items are present in Safari, for the benefit of the open source folks using tip of tree WebKit but older released Safari; it's possible that some other existing WebKit apps won't show all the PDF view context menu items.
4:57 PM Changeset in webkit [12602] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-06 Eric Seidel <​eseidel@apple.com>

Rubber-stamped by darin.

Adding setSourceDir for scripts stored in non-standard locations.

  • Scripts/webkitdirs.pm:
4:09 PM Changeset in webkit [12601] by thatcher
  • 1 edit in branches/Safari-2-0-branch/JavaScriptCore/ChangeLog

Correct ChangeLog.

4:03 PM Changeset in webkit [12600] by thatcher
  • 8 edits in branches/Safari-2-0-branch

JavaScriptCore:

Reviewed by John Sullivan.

JavaScriptCore part of <rdar://problem/4211707> NPAPI ref count behavior differs with Mozilla

  • bindings/npruntime.cpp: (_NPN_ReleaseObject): Refactored part of this function out into _NPN_DeallocateObject. (_NPN_DeallocateObject): Forcibly deallocates the passed object, even if its refcount is greater than zero.
  • bindings/npruntime_impl.h: Declared _NPN_DeallocateObject().

WebCore:

Merged fix from TOT to Safari-2-0-branch

2006-01-16 Tim Omernick <​timo@apple.com>

Reviewed by John Sullivan.

WebCore part of <rdar://problem/4211707> NPAPI ref count behavior differs with Mozilla

  • bridge/mac/MacFrame.mm: (MacFrame::setView): Call _NPN_DeallocateObject() instead of _NPN_ReleaseObject() so that we don't leak if a plugin fails to release the window script object properly. Our old NPN_GetValue() did not properly retain the returned window script object. Because of this, many plugins have WebKit-specific workarounds to not release said window script object. Forcibly deallocating it here should prevent any such issues. This shouldn't cause any problems for plugins, since they should already be stopped and destroyed at this point. This also fixes a preexisting leak of the window script NPObject -- it was never actually being freed!

WebKit:

Merged fix from TOT to Safari-2-0-branch

2006-01-16 Tim Omernick <​timo@apple.com>

Reviewed by John Sullivan.

WebKit part of <rdar://problem/4211707> NPAPI ref count behavior differs with Mozilla

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView getVariable:value:]):

The returned window script object is expected to be retained, as described here:
<​http://www.mozilla.org/projects/plugins/npruntime.html#browseraccess>

3:35 PM Changeset in webkit [12599] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by John and Adele

Fix for <rdar://problem/4323167> REGRESSION (TOT): Crash in
RenderTable::colToEffCol entering text into text input field

Some of the autofill code assumes that the form's label is in a
table cell, but this is not necessarily the case. This fix checks
that the renderer is actually a table cell before treating it as
such.

11:56 AM Changeset in webkit [12598] by darin
  • 4 edits
    2 adds in trunk/WebCore

Reviewed by John.

  • page/Frame.h: Make redirectionTimerFired virtual.
  • bridge/mac/MacFrame.h: Override redirectionTimerFired.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::redirectionTimerFired): Send the redirectionTimerCancelled callback here, even though it has fired rather than being cancelled.
  • manual-tests/redirect.html: Added.
  • manual-tests/redirection-target.html: Added.
10:29 AM Changeset in webkit [12597] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John.


Fix TOT regression where Mail.app replies were getting truncated.
Was caused by 1/26/2006 checkin for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6754

No layout test because this code cannot be reached via JS operations.


  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::createContextualFragment):
  • restore code that sampled nextSibling() before node is removed
  • also, add asserts that the DOM mutation methods yield a 0 exception code, so problems can be caught closer to the cause.
1:35 AM Changeset in webkit [12596] by mjs
  • 2 edits in trunk/WebKit

Remove remaining .subproj references to fix release build.

  • WebKit.xcodeproj/project.pbxproj:
12:58 AM Changeset in webkit [12595] by mjs
  • 2 edits
    2 copies
    9 moves in trunk/WebKit

Rubber stamped by Hyatt.


  • renamed subproject directories to not end with .subproj
  • Carbon: renamed from Carbon.subproj
  • DOM: renamed from DOM.subproj
  • History: renamed from History.subproj
  • Misc: renamed from Misc.subproj
  • Panels: renamed from Panels.subproj
  • Plugins: renamed from Plugins.subproj
  • WebCoreSupport: renamed from WebCoreSupport.subproj
  • WebInspector: renamed from WebInspector.subproj
  • WebView: renamed from WebView.subproj
12:10 AM Changeset in webkit [12594] by mjs
  • 3 edits in trunk/WebKit

Ooops, I made a last-minute change to my last patch that broke the build - fixed.

  • WebView.subproj/WebFrame.m: (-[WebFrame _closeOldDataSources]): (-[WebFrame _detachFromParent]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _handledOnloadEvents]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _goToItem:withLoadType:]): (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]): (-[WebFrame _clientRedirectCancelled:]):
  • WebView.subproj/WebFramePrivate.h:

Feb 5, 2006:

11:49 PM Changeset in webkit [12593] by mjs
  • 5 edits in trunk/JavaScriptCore

Reviewed by Anders.


  • kjs/internal.cpp: (KJS::Parser::noteNodeCycle): (KJS::Parser::removeNodeCycle): (KJS::clearNewNodes):
  • kjs/internal.h:
  • kjs/nodes.cpp: (ElementNode::breakCycle): (PropertyListNode::breakCycle): (ArgumentListNode::breakCycle): (StatListNode::StatListNode): (StatListNode::breakCycle): (VarDeclListNode::breakCycle): (BlockNode::BlockNode): (ClauseListNode::breakCycle): (CaseBlockNode::CaseBlockNode): (ParameterNode::breakCycle): (SourceElementsNode::SourceElementsNode): (SourceElementsNode::breakCycle):
  • kjs/nodes.h: (KJS::Node::breakCycle): (KJS::ElementNode::ElementNode): (KJS::ArrayNode::ArrayNode): (KJS::PropertyListNode::PropertyListNode): (KJS::ObjectLiteralNode::ObjectLiteralNode): (KJS::ArgumentListNode::ArgumentListNode): (KJS::ArgumentsNode::ArgumentsNode): (KJS::VarDeclListNode::VarDeclListNode): (KJS::VarStatementNode::VarStatementNode): (KJS::ForNode::ForNode): (KJS::CaseClauseNode::CaseClauseNode): (KJS::ClauseListNode::ClauseListNode): (KJS::ParameterNode::ParameterNode): (KJS::FuncExprNode::FuncExprNode): (KJS::FuncDeclNode::FuncDeclNode):
11:25 PM Changeset in webkit [12592] by mjs
  • 11 edits in trunk/WebKit

Reviewed by Darin.


  • WebCoreSupport.subproj/WebFrameBridge.h:
  • WebCoreSupport.subproj/WebFrameBridge.m: (-[WebFrameBridge initWithPage:webView:frameName:view:]): (-[WebFrameBridge page]): (-[WebFrameBridge mainFrame]): (-[WebFrameBridge webView]): (-[WebFrameBridge createWindowWithURL:frameName:]): (-[WebFrameBridge showWindow]): (-[WebFrameBridge areToolbarsVisible]): (-[WebFrameBridge setToolbarsVisible:]): (-[WebFrameBridge isStatusbarVisible]): (-[WebFrameBridge setStatusbarVisible:]): (-[WebFrameBridge setWindowFrame:]): (-[WebFrameBridge windowFrame]): (-[WebFrameBridge setWindowContentRect:]): (-[WebFrameBridge windowContentRect]): (-[WebFrameBridge setWindowIsResizable:]): (-[WebFrameBridge windowIsResizable]): (-[WebFrameBridge firstResponder]): (-[WebFrameBridge makeFirstResponder:]): (-[WebFrameBridge closeWindowSoon]): (-[WebFrameBridge runJavaScriptAlertPanelWithMessage:]): (-[WebFrameBridge runJavaScriptConfirmPanelWithMessage:]): (-[WebFrameBridge canRunBeforeUnloadConfirmPanel]): (-[WebFrameBridge runBeforeUnloadConfirmPanelWithMessage:]): (-[WebFrameBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): (-[WebFrameBridge addMessageToConsole:]): (-[WebFrameBridge runOpenPanelForFileButtonWithResultListener:]): (-[WebFrameBridge setStatusText:]): (-[WebFrameBridge startLoadingResource:withURL:customHeaders:]): (-[WebFrameBridge startLoadingResource:withURL:customHeaders:postData:]): (-[WebFrameBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebFrameBridge focusWindow]): (-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebFrameBridge userAgentForURL:]): (-[WebFrameBridge _nextKeyViewOutsideWebFrameViewsWithValidityCheck:]): (-[WebFrameBridge previousKeyViewOutsideWebFrameViews]): (-[WebFrameBridge defersLoading]): (-[WebFrameBridge setDefersLoading:]): (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]): (-[WebFrameBridge _preferences]): (-[WebFrameBridge selectWordBeforeMenuEvent]): (-[WebFrameBridge historyLength]): (-[WebFrameBridge canGoBackOrForward:]): (-[WebFrameBridge goBackOrForward:]): (-[WebFrameBridge print]): (-[WebFrameBridge pollForAppletInView:]): (-[WebFrameBridge respondToChangedContents]): (-[WebFrameBridge respondToChangedSelection]): (-[WebFrameBridge undoManager]): (-[WebFrameBridge issueCutCommand]): (-[WebFrameBridge issueCopyCommand]): (-[WebFrameBridge issuePasteCommand]): (-[WebFrameBridge issuePasteAndMatchStyleCommand]): (-[WebFrameBridge canPaste]): (-[WebFrameBridge overrideMediaType]): (-[WebFrameBridge isEditable]): (-[WebFrameBridge shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): (-[WebFrameBridge shouldBeginEditing:]): (-[WebFrameBridge shouldEndEditing:]): (-[WebFrameBridge windowObjectCleared]): (-[WebFrameBridge spellCheckerDocumentTag]): (-[WebFrameBridge isContinuousSpellCheckingEnabled]): (-[WebFrameBridge didFirstLayout]): (-[WebFrameBridge dashboardRegionsChanged:]): (-[WebFrameBridge createModalDialogWithURL:]): (-[WebFrameBridge canRunModal]): (-[WebFrameBridge runModal]):
  • WebCoreSupport.subproj/WebPageBridge.h:
  • WebCoreSupport.subproj/WebPageBridge.m: (-[WebPageBridge initWithMainFrameName:webView:frameView:]): (-[WebPageBridge webView]):
  • WebView.subproj/WebDataSource.m: (-[WebDataSource _fileWrapperForURL:]): (-[WebDataSource _webView]): (-[WebDataSource _setLoading:]): (-[WebDataSource _startLoading:]): (-[WebDataSource _setTitle:]): (-[WebDataSource _setRequest:]): (-[WebDataSource _updateIconDatabaseWithURL:]): (-[WebDataSource _defersCallbacksChanged]): (-[WebDataSource _setWebFrame:]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame _traverseNextFrameStayWithin::]): (-[WebFrame _detachFromParent]): (-[WebFrame _setDataSource:]): (-[WebFrame _loadDataSource:withLoadType:formState:]): (-[WebFrame _initWithWebFrameView:webView:bridge:]): (-[WebFrame dealloc]): (-[WebFrame finalize]): (-[WebFrame webView]):
  • WebView.subproj/WebFrameView.m: (-[WebFrameView _webView]): (-[WebFrameView _goBack]): (-[WebFrameView _goForward]):
  • WebView.subproj/WebFrameViewInternal.h:
  • WebView.subproj/WebView.m: (-[WebView _createFrameNamed:inParent:allowsScrolling:]): (-[WebView _commonInitializationWithFrameName:groupName:]):
11:06 PM Changeset in webkit [12591] by andersca
  • 5 edits
    6 adds in trunk/WebCore

2006-02-05 Anders Carlsson <​andersca@mac.com>

Reviewed by Maciej.

  • JSCore.cpp: Add new generated files.


  • bindings/scripts/CodeGeneratorJS.pm: Add "IsIndex" extended attribute for parameters. Any parameter that is "unsigned long" and has this attribute will be checked to make sure that it's not < 0. If it is, an index size error exception will be thrown.


  • khtml/ecma/kjs_dom.cpp: (KJS::toAttr): Use JSAttr::info.


(KJS::getDOMNode):
Use new constructors.


  • khtml/ecma/kjs_dom.h: Remove classes that are generated now.


  • khtml/xml/Attr.idl: Added.
  • khtml/xml/CharacterData.idl: Added.
  • khtml/xml/Entity.idl: Added.
  • khtml/xml/Notation.idl: Added.
  • khtml/xml/ProcessingInstruction.idl: Added.
  • khtml/xml/Text.idl: Added.
9:57 PM Changeset in webkit [12590] by eseidel
  • 2 edits in trunk/WebKitSite

2006-02-05 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

General update to SVG project page, also link to status page.

  • projects/svg/index.html:
9:36 PM Changeset in webkit [12589] by eseidel
  • 4 adds in trunk/WebKitSite

2006-02-05 Eric Seidel <​eseidel@apple.com>

Rubber stamped by darin.

  • projects/svg/status.xml: Added.
  • projects/svg/svg-status.css: Added.
  • projects/svg/svg-status.xsl: Added.

2006-02-05 Eric Seidel <​eseidel@apple.com>

Adding ChangeLog :)


  • ChangeLog: Added.
6:36 PM Changeset in webkit [12588] by darin
  • 4 edits in trunk/LayoutTests
  • converted three more files from UTF-16 to ASCII that had no reason to be UTF-16
  • fast/dom/resources/top.html: Just straight conversion to ASCII.
  • fast/events/updateLayoutForHitTest.html: Converted one character to an entity, and reformatted the file a bit.
  • fast/text/line-breaks.html: Just straight conversion to ASCII.
3:07 PM Changeset in webkit [12587] by mjs
  • 11 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.


Re-landing test case for:

  • fast/events/iframe-object-onload-expected.txt: Added.
  • fast/events/iframe-object-onload.html: Added.


  • changed expected results and description for this test, unload should not fire in this case:


  • fast/events/onunload-body-property-expected.txt:
  • fast/events/onunload-body-property.html:


  • changed from UTF-16 to ASCII, there was no reason for this to be UTF-16.
  • fast/dom/attr_dead_doc.html:

WebCore:

Reviewed by Darin.


Re-landed the following with more fixes so it does not break tests:


Specific changes:


  • don't bother to nil-check the document, a node can never have a null document now
  • move temp event forgetting from dispatchEvent to dispatchGenericEvent
  • pass event down using RefPtr::release() to avoid ref thrashing
  • support default handlers even for non-bubbling events (only on target node) and skip calling default event handler explicitly in callers
  • dispatch a whole separate load event to a frame document's containing frame
  • don't let propagationStopped prevent this new event
  • remove bogus security check for iframe onload
  • dispatch window events on the document, not the body, and also for non-html
  • set onload, onunload, onbeforeunload from frameset tags on the window object
  • don't restrict load/unload events to HTML
  • send default handler to the dispatch object as previously
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::shouldClose):
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::parseMappedAttribute): (WebCore::HTMLFrameSetElementImpl::parseMappedAttribute):
  • khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::implicitClose):
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchEvent): (WebCore::NodeImpl::dispatchGenericEvent): (WebCore::NodeImpl::dispatchWindowEvent):
  • khtml/xml/NodeImpl.h:
  • page/Frame.cpp: (WebCore::Frame::stopLoading): (WebCore::Frame::setWindowHasFocus):
12:31 PM Changeset in webkit [12586] by darin
  • 8 edits
    1 add in trunk/WebCore

Reviewed by Geoff.

  • fix <rdar://problem/4197997> -[DOMHTMLSelectElement options] always returns an empty list
  • khtml/html/HTMLOptionsCollectionImpl.h: Changed to be a subclass of HTMLCollectionImpl.
  • khtml/html/HTMLOptionsCollectionImpl.cpp: Added.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Added new source file.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLOptionsCollection setLength:]): Handle possible exception. (-[DOMHTMLSelectElement options]): Add get() since this is now a PassRefPtr.
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::selectIndexGetter): Call options() instead of optionsHTMLCollection(). (KJS::HTMLElement::selectGetter): Ditto. (KJS::KJS::HTMLElement::put): Ditto. (KJS::HTMLElement::selectSetter): Ditto. (KJS::KJS::HTMLSelectCollection::put): Ditto.
  • khtml/html/HTMLSelectElementImpl.h: Tweaked formatting. Eliminated m_options. Changed m_minwidth and m_size to int instead of short. Removed optionsHTMLCollection(). Changed options() to return a PassRefPtr.
  • khtml/html/HTMLSelectElementImpl.cpp: (WebCore::HTMLSelectElementImpl::~HTMLSelectElementImpl): Get rid of code to drop m_options. (WebCore::HTMLSelectElementImpl::remove): Remove unnecesssary RefPtr use, since that's handled fine by removeChild. (WebCore::HTMLSelectElementImpl::options): Change to create a new HTMLOptionsCollectionImpl each time, like other collection calls. Maybe we should change this eventually to use a HashMap so we can pass out the same collection over and over again, or could have a pointer stored in the select element that's managed by the collection itself.
11:34 AM Changeset in webkit [12585] by darin
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by Maciej.

  • fast/forms/select-replace-option.html: Added.
  • fast/forms/select-replace-option-expected.txt: Added.
11:33 AM Changeset in webkit [12584] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Forgot to put reviewer name in.

11:33 AM Changeset in webkit [12583] by darin
  • 2 edits in trunk/WebCore

Reviewed by NOBODY (OOPS!).

Test: fast/forms/select-replace-option.html

  • khtml/ecma/kjs_html.cpp: (KJS::KJS::HTMLSelectCollection::put): Use optionsHTMLCollection, because options isn't really implemented yet.
11:18 AM Changeset in webkit [12582] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • kwq/KWQTextField.mm: (-[KWQTextFieldController setHasFocus:]): Add check for nil in case the blur event causes the KWQLineEdit to be destroyed.
11:17 AM Changeset in webkit [12581] by darin
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Maciej.

  • fast/replaced/object-param-no-name.html: Added.
  • fast/replaced/object-param-no-name-expected.txt: Added.
  • fixed test that I landed incorrectly earlier
  • fast/overflow/onscroll-layer-self-destruct.html: Removed Subversion property junk.
  • fast/overflow/onscroll-layer-self-destruct-expected.txt: Ditto.
11:16 AM Changeset in webkit [12580] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Test: fast/replaced/object-param-no-name.html

  • rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget): Check for empty name, and skip processing the name/value of that <param> element.
11:00 AM Changeset in webkit [12579] by darin
  • 1 edit
    2 deletes in trunk/LayoutTests
  • rolled out Maciej's event cleanup patch, which is causing problems

I believe he has a fix, and he'll re-land the patch with the fix later.

Original fix was <​http://bugzilla.opendarwin.org/show_bug.cgi?id=7079>.
Problems described in <​http://bugzilla.opendarwin.org/show_bug.cgi?id=7084>.

11:00 AM Changeset in webkit [12578] by darin
  • 4 edits in trunk/WebCore
  • rolled out Maciej's event cleanup patch, which is causing problems

I believe he has a fix, and he'll re-land the patch with the fix later.

Original fix was <​http://bugzilla.opendarwin.org/show_bug.cgi?id=7079>.
Problems described in <​http://bugzilla.opendarwin.org/show_bug.cgi?id=7084>.

10:19 AM Changeset in webkit [12577] by darin
  • 2 edits in trunk/WebCore
  • ksvg2/css/KSVGCSSParser.cpp: Remove config.h, since this is included by another .cpp file -- oops!
10:16 AM Changeset in webkit [12576] by darin
  • 7 edits
    2 deletes in trunk/WebCore

Discussed with Anders (didn't get real review).

  • fix build
  • WebCore+SVG/SVGNamesWrapper.cpp: Touch file, not getting rebuilt even though it includes config.h which changed.
  • WebCore+SVG/XLinkNamesWrapper.cpp: Ditto.
  • ksvg2/css/KSVGCSSParser.cpp: Added include of config.h.
  • platform/mac/ImageDecoder.cpp: Ditto.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Removed IntPoint.cpp and IntSize.cpp.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • platform/IntPoint.cpp: Removed. Was empty.
  • platform/IntSize.cpp: Removed. Was empty.
9:21 AM Changeset in webkit [12575] by darin
  • 1 edit in trunk/LayoutTests/ChangeLog

Reviewed by Maciej.

  • fast/overflow/onscroll-layer-self-destruct.html: Added.
  • fast/overflow/onscroll-layer-self-destruct-expected.txt: Added.
3:48 AM Changeset in webkit [12574] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Test: onscroll-layer-self-destruct.html

  • rendering/render_layer.cpp: (WebCore::RenderLayer::scrollToOffset): Don't send the scroll event until after we've done everything else we need to do.
2:37 AM Changeset in webkit [12573] by darin
  • 99 edits
    1 copy
    6 moves in trunk/WebCore

Rubber stamped by Maciej.

  • renamed DOMString and DOMStringImpl to String and StringImpl, and moved into platform
  • config.h: Put in transitional defines so old code can still refer to the classes as DOMString and DOMStringImpl.
  • platform/AtomicString.cpp: Added.
  • platform/AtomicString.h: Added.
  • platform/AtomicStringImpl.h: Added.
  • platform/PlatformString.h: Added.
  • platform/String.cpp: Added.
  • platform/StringImpl.cpp: Added.
  • platform/StringImpl.h: Added. Moved files here and renamed them. PlatformString.h would be named String.h except that conflicts with <string.h> on non-case-sensitive file systems.
  • khtml/xml/dom_atomicstring.cpp: Removed.
  • khtml/xml/dom_atomicstring.h: Removed.
  • khtml/xml/dom_stringimpl.cpp: Removed.
  • khtml/xml/dom_stringimpl.h: Removed.
  • khtml/dom/dom_string.cpp: Removed.
  • khtml/dom/dom_string.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: Updated for file adds and removes.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • WebCore+SVG/KDOMHeaders.h:
  • WebCore+SVG/Namespace.h:
  • WebCore+SVG/kdom.h:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMCSS.mm:
  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMInternal.mm:
  • bridge/BrowserExtension.h:
  • css/css_base.h:
  • css/css_computedstyle.cpp:
  • css/css_grammar.y:
  • css/css_ruleimpl.h:
  • css/css_stylesheetimpl.cpp:
  • css/css_stylesheetimpl.h:
  • css/css_valueimpl.cpp:
  • css/csshelper.cpp:
  • css/csshelper.h:
  • css/cssparser.h:
  • css/cssstyleselector.h:
  • kcanvas/KCanvasTreeDebug.cpp:
  • khtml/dom/dom2_events.h:
  • khtml/ecma/JSXMLHttpRequest.cpp:
  • khtml/ecma/kjs_html.cpp:
  • khtml/ecma/kjs_window.cpp:
  • khtml/editing/SelectionController.cpp:
  • khtml/editing/apply_style_command.cpp:
  • khtml/editing/delete_from_text_node_command.h:
  • khtml/editing/insert_into_text_node_command.h:
  • khtml/editing/jsediting.h:
  • khtml/editing/rebalance_whitespace_command.h:
  • khtml/editing/remove_css_property_command.h:
  • khtml/editing/typing_command.h:
  • khtml/html/FormDataList.h:
  • khtml/html/HTMLNameCollectionImpl.h:
  • khtml/html/html_baseimpl.cpp:
  • khtml/html/html_objectimpl.cpp:
  • khtml/khtml_events.h:
  • khtml/xbl/xbl_binding.h:
  • khtml/xbl/xbl_protobinding.h:
  • khtml/xbl/xbl_protohandler.h:
  • khtml/xbl/xbl_protoimplementation.h:
  • khtml/xml/DOMImplementationImpl.cpp:
  • khtml/xml/EventNames.h:
  • khtml/xml/NameNodeListImpl.h:
  • khtml/xml/NamedNodeMapImpl.h:
  • khtml/xml/NodeImpl.cpp:
  • khtml/xml/NodeImpl.h:
  • khtml/xml/dom2_eventsimpl.h:
  • khtml/xml/dom_atomicstringlist.h:
  • khtml/xml/dom_elementimpl.h:
  • khtml/xml/dom_qname.h:
  • khtml/xml/dom_xmlimpl.cpp:
  • khtml/xml/xml_tokenizer.h:
  • khtml/xsl/xsl_stylesheetimpl.cpp:
  • khtml/xsl/xslt_processorimpl.h:
  • ksvg2/misc/KCanvasRenderingStyle.cpp:
  • ksvg2/svg/SVGAngleImpl.h:
  • ksvg2/svg/SVGAnimateColorElementImpl.cpp:
  • ksvg2/svg/SVGAnimatedStringImpl.h:
  • ksvg2/svg/SVGAnimationElementImpl.cpp:
  • ksvg2/svg/SVGColorImpl.h:
  • ksvg2/svg/SVGDOMImplementationImpl.cpp:
  • ksvg2/svg/SVGElementImpl.cpp:
  • ksvg2/svg/SVGFitToViewBoxImpl.cpp:
  • ksvg2/svg/SVGLangSpaceImpl.cpp:
  • ksvg2/svg/SVGLangSpaceImpl.h:
  • ksvg2/svg/SVGLengthImpl.h:
  • ksvg2/svg/SVGMarkerElementImpl.cpp:
  • ksvg2/svg/SVGPaintImpl.h:
  • ksvg2/svg/SVGPathSegImpl.h:
  • ksvg2/svg/SVGPreserveAspectRatioImpl.cpp:
  • ksvg2/svg/SVGSVGElementImpl.cpp:
  • ksvg2/svg/SVGScriptElementImpl.cpp:
  • ksvg2/svg/SVGStringListImpl.h:
  • ksvg2/svg/SVGStylableImpl.h:
  • ksvg2/svg/SVGStyleElementImpl.cpp:
  • ksvg2/svg/SVGStyledElementImpl.cpp:
  • ksvg2/svg/SVGSymbolElementImpl.cpp:
  • ksvg2/svg/SVGViewElementImpl.cpp:
  • kwq/KWQAccObject.mm:
  • kwq/KWQFontFamily.h:
  • kwq/KWQFontFamily.mm:
  • kwq/KWQKJobClasses.h:
  • kwq/KWQKJobClasses.mm:
  • loader/Cache.h:
  • loader/CachedObject.h:
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.h:
  • loader/DocLoader.h:
  • page/Frame.cpp:
  • page/FrameTreeNode.h:
  • platform/SegmentedString.h:
  • rendering/render_image.h:
  • rendering/render_style.cpp:
  • xml/xmlhttprequest.cpp: Updated all includes to use new filenames.
1:53 AM Changeset in webkit [12572] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Hyatt.


  • fix default traits for classes to make sure default constructors get called
  • kxmlcore/VectorTraits.h: (KXMLCore::):
1:45 AM Changeset in webkit [12571] by mjs
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.


Test case for:

  • fast/events/iframe-object-onload-expected.txt: Added.
  • fast/events/iframe-object-onload.html: Added.

WebCore:

Reviewed by Darin.


Specific changes:


  • don't bother to nil-check the document, a node can never have a null document now
  • move temp event forgetting from dispatchEvent to dispatchGenericEvent
  • pass event down using RefPtr::release() to avoid ref thrashing
  • support default handlers even for non-bubbling events (only on target node) and skip calling default event handler explicitly in callers
  • dispatch a whole separate load event to a frame document's containing frame
  • don't let propagationStopped prevent this new event
  • remove bogus security check for iframe onload
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::shouldClose):
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::dispatchEvent): (WebCore::NodeImpl::dispatchGenericEvent): (WebCore::NodeImpl::dispatchWindowEvent):
  • khtml/xml/NodeImpl.h:
12:49 AM Changeset in webkit [12570] by andersca
  • 3 edits in trunk/WebCore

2006-02-05 Maciej Stachowiak <​mjs@apple.com>

Reviewed and landed by Anders.


12:29 AM Changeset in webkit [12569] by ap
  • 2 edits in trunk/WebCore

Fix by David Kilzer, reviewed by Darin, landed by ap (with a tweak suggested by Darin).

  • kwq/KWQPainter.mm: Include "FloatRect.h".

Feb 4, 2006:

9:44 PM Changeset in webkit [12568] by mjs
  • 14 edits in trunk/WebCore

Reviewed by Darin.

  • bindings/objc/DOM.mm: (-[DOMNode insertBefore::]): (-[DOMNode replaceChild::]): (-[DOMNode removeChild:]): (-[DOMNode appendChild:]):
  • khtml/ecma/kjs_dom.cpp: (KJS::DOMNodeProtoFunc::callAsFunction):
  • khtml/html/HTMLOptGroupElementImpl.cpp: (WebCore::HTMLOptGroupElementImpl::insertBefore): (WebCore::HTMLOptGroupElementImpl::replaceChild): (WebCore::HTMLOptGroupElementImpl::removeChild): (WebCore::HTMLOptGroupElementImpl::appendChild):
  • khtml/html/HTMLOptGroupElementImpl.h:
  • khtml/html/HTMLSelectElementImpl.cpp: (WebCore::HTMLSelectElementImpl::insertBefore): (WebCore::HTMLSelectElementImpl::replaceChild): (WebCore::HTMLSelectElementImpl::removeChild): (WebCore::HTMLSelectElementImpl::appendChild):
  • khtml/html/HTMLSelectElementImpl.h:
  • khtml/html/HTMLTextAreaElementImpl.cpp: (WebCore::HTMLTextAreaElementImpl::setDefaultValue):
  • khtml/html/html_tableimpl.cpp: (WebCore::HTMLTableElementImpl::createTFoot):
  • khtml/xml/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::insertBefore): (WebCore::ContainerNodeImpl::replaceChild): (WebCore::ContainerNodeImpl::removeChild): (WebCore::ContainerNodeImpl::appendChild):
  • khtml/xml/ContainerNodeImpl.h:
  • khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::insertBefore): (WebCore::NodeImpl::replaceChild): (WebCore::NodeImpl::removeChild): (WebCore::NodeImpl::appendChild):
  • khtml/xml/NodeImpl.h:
  • khtml/xml/xml_tokenizer.cpp: (WebCore::XMLTokenizer::insertErrorMessageBlock):
9:24 PM Changeset in webkit [12567] by mjs
  • 17 edits
    110 deletes in trunk

LayoutTests:

  • reverted CSS media queries patch, as it causes random crashes on the layout tests with a debug build.


  • fast/media/001-expected.checksum: Removed.
  • fast/media/001-expected.png: Removed.
  • fast/media/001-expected.txt: Removed.
  • fast/media/001.html: Removed.
  • fast/media/002-expected.checksum: Removed.
  • fast/media/002-expected.png: Removed.
  • fast/media/002-expected.txt: Removed.
  • fast/media/002.html: Removed.
  • fast/media/003-expected.checksum: Removed.
  • fast/media/003-expected.png: Removed.
  • fast/media/003-expected.txt: Removed.
  • fast/media/003.html: Removed.
  • fast/media/004-expected.checksum: Removed.
  • fast/media/004-expected.png: Removed.
  • fast/media/004-expected.txt: Removed.
  • fast/media/004.html: Removed.
  • fast/media/005-expected.checksum: Removed.
  • fast/media/005-expected.png: Removed.
  • fast/media/005-expected.txt: Removed.
  • fast/media/005.html: Removed.
  • fast/media/006-expected.checksum: Removed.
  • fast/media/006-expected.png: Removed.
  • fast/media/006-expected.txt: Removed.
  • fast/media/006.html: Removed.
  • fast/media/007-expected.checksum: Removed.
  • fast/media/007-expected.png: Removed.
  • fast/media/007-expected.txt: Removed.
  • fast/media/007.html: Removed.
  • fast/media/008-expected.checksum: Removed.
  • fast/media/008-expected.png: Removed.
  • fast/media/008-expected.txt: Removed.
  • fast/media/008.html: Removed.
  • fast/media/009-expected.checksum: Removed.
  • fast/media/009-expected.png: Removed.
  • fast/media/009-expected.txt: Removed.
  • fast/media/009.html: Removed.
  • fast/media/010-expected.checksum: Removed.
  • fast/media/010-expected.png: Removed.
  • fast/media/010-expected.txt: Removed.
  • fast/media/010.html: Removed.
  • fast/media/011-expected.checksum: Removed.
  • fast/media/011-expected.png: Removed.
  • fast/media/011-expected.txt: Removed.
  • fast/media/011.html: Removed.
  • fast/media/012-expected.checksum: Removed.
  • fast/media/012-expected.png: Removed.
  • fast/media/012-expected.txt: Removed.
  • fast/media/012.html: Removed.
  • fast/media/013-expected.checksum: Removed.
  • fast/media/013-expected.png: Removed.
  • fast/media/013-expected.txt: Removed.
  • fast/media/013.html: Removed.
  • fast/media/014-expected.checksum: Removed.
  • fast/media/014-expected.png: Removed.
  • fast/media/014-expected.txt: Removed.
  • fast/media/014.html: Removed.
  • fast/media/015-expected.checksum: Removed.
  • fast/media/015-expected.png: Removed.
  • fast/media/015-expected.txt: Removed.
  • fast/media/015.html: Removed.
  • fast/media/016-expected.checksum: Removed.
  • fast/media/016-expected.png: Removed.
  • fast/media/016-expected.txt: Removed.
  • fast/media/016.html: Removed.
  • fast/media/017-expected.checksum: Removed.
  • fast/media/017-expected.png: Removed.
  • fast/media/017-expected.txt: Removed.
  • fast/media/017.html: Removed.
  • fast/media/018-expected.checksum: Removed.
  • fast/media/018-expected.png: Removed.
  • fast/media/018-expected.txt: Removed.
  • fast/media/018.html: Removed.
  • fast/media/019-expected.checksum: Removed.
  • fast/media/019-expected.png: Removed.
  • fast/media/019-expected.txt: Removed.
  • fast/media/019.html: Removed.
  • fast/media/020-expected.checksum: Removed.
  • fast/media/020-expected.png: Removed.
  • fast/media/020-expected.txt: Removed.
  • fast/media/020.html: Removed.
  • fast/media/021-expected.checksum: Removed.
  • fast/media/021-expected.png: Removed.
  • fast/media/021-expected.txt: Removed.
  • fast/media/021.html: Removed.
  • fast/media/022-expected.checksum: Removed.
  • fast/media/022-expected.png: Removed.
  • fast/media/022-expected.txt: Removed.
  • fast/media/022.html: Removed.
  • fast/media/023-expected.checksum: Removed.
  • fast/media/023-expected.png: Removed.
  • fast/media/023-expected.txt: Removed.
  • fast/media/023.html: Removed.
  • fast/media/024-expected.checksum: Removed.
  • fast/media/024-expected.png: Removed.
  • fast/media/024-expected.txt: Removed.
  • fast/media/024.html: Removed.
  • fast/media/025-expected.checksum: Removed.
  • fast/media/025-expected.png: Removed.
  • fast/media/025-expected.txt: Removed.
  • fast/media/025.html: Removed.
  • fast/media/026-expected.checksum: Removed.
  • fast/media/026-expected.png: Removed.
  • fast/media/026.html: Removed.
  • fast/media/import-p-green.css: Removed.

WebCore:

  • reverted CSS media queries patch, as it causes random crashes on the layout tests with a debug build.


  • WebCore.xcodeproj/project.pbxproj:
  • css/css_grammar.y:
  • css/css_mediaqueryeval.cpp: Removed.
  • css/css_mediaqueryeval.h: Removed.
  • css/css_mediaqueryimpl.cpp: Removed.
  • css/css_mediaqueryimpl.h: Removed.
  • css/css_stylesheetimpl.cpp: (MediaListImpl::MediaListImpl): (MediaListImpl::contains): (MediaListImpl::deleteMedium): (MediaListImpl::mediaText): (MediaListImpl::setMediaText):
  • css/css_stylesheetimpl.h: (DOM::MediaListImpl::length): (DOM::MediaListImpl::item): (DOM::MediaListImpl::appendMedium):
  • css/css_valueimpl.h:
  • css/csshelper.h:
  • css/cssmediafeatures.in: Removed.
  • css/cssparser.cpp:
  • css/cssparser.h:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::~CSSStyleSelector): (WebCore::CSSStyleSelector::loadDefaultStyle): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
  • css/cssstyleselector.h:
  • css/makemediafeatures: Removed.
  • css/maketokenizer:
  • css/tokenizer.flex:
  • khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::process): (WebCore::HTMLLinkElementImpl::setStyleSheet): (WebCore::HTMLStyleElementImpl::childrenChanged):
  • platform/Screen.h:
  • platform/mac/Screen.mm:
5:48 PM Changeset in webkit [12566] by darin
  • 3 edits in trunk/WebKit

Reviewed by Maciej.

  • Misc.subproj/WebCoreStatistics.h:
  • Misc.subproj/WebCoreStatistics.m: (+[WebCoreStatistics javaScriptRootObjectTypeCounts]): javaScriptRootObjecTypeCounts -> javaScriptRootObjectTypeCounts
5:43 PM Changeset in webkit [12565] by darin
  • 1 edit
    3 adds in trunk/LayoutTests
  • fast/js/for-in-var-scope.html: Added.
  • fast/js/resources/for-in-var-scope.js: Added.
  • fast/js/for-in-var-scope-expected.txt: Added.
5:43 PM Changeset in webkit [12564] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Test: fast/js/for-in-var-scope.html

  • kjs/nodes.cpp: (valueForReadModifyAssignment): Use ALWAYS_INLINE macro. (ForInNode::execute): Break out of the scope chain loop once we find and set the loop variable. We don't want to set multiple loop variables. (ForInNode::processVarDecls): Process the declaration of the loop variable.
  • other cleanup
  • kjs/object.cpp: (KJS::tryGetAndCallProperty): Use ALWAYS_INLINE macro.
  • kxmlcore/FastMalloc.cpp: Change to use ALWAYS_INLINE macro from AlwaysInline.h instead of defining it here a second time.
5:09 PM Changeset in webkit [12563] by darin
  • 1 edit in trunk/LayoutTests/ChangeLog

Oops, rolled out part that wasn't supposed to be here.

5:07 PM Changeset in webkit [12562] by darin
  • 2 edits in trunk/LayoutTests
  • updated test result due to revised fix for <ol> number
  • fast/lists/olstart-expected.txt: Updated.
5:03 PM Changeset in webkit [12561] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/webkitdirs.pm: Add a compatibilty hack for people with old Configuration files that say Development or Deployment in them.
4:49 PM Changeset in webkit [12560] by darin
  • 4 edits in trunk/WebCore

Reviewed and tweaked by Darin.

  • fixed regressions caused by fix for bug 5776 earlier today
  • rendering/render_list.h: Remove m_value from RenderListMarker, add it to RenderListItem. A few other tweaks, including getting rid of "friend" relationship.
  • rendering/render_list.cpp: (RenderListItem::RenderListItem): Initialize m_value. (RenderListItem::setStyle): Restore old behavior of making no marker for LNONE case. (RenderListItem::calcValue): Work on m_value, not m_marker->m_value. (RenderListItem::resetValue): Reset m_value, even if there's no marker. (RenderListMarker::RenderListMarker): Remove code to set up m_value. (RenderListMarker::calcMinMaxWidth): Get marker value from list item.
  • rendering/RenderContainer.cpp: (updateListMarkerNumbers): Call resetValue by its new name.
3:29 PM Changeset in webkit [12559] by mjs
  • 10 edits in trunk

JavaScriptCore:

Reviewed by Hyatt.



  • kjs/collector.cpp: (KJS::Collector::numProtectedObjects): renamed from numReferencedObjects (KJS::typeName): (KJS::Collector::rootObjectTypeCounts): renamed from rootObjectClasses, use HashSet
  • kjs/collector.h: (KJS::Collector::isOutOfMemory): Renamed from outOfMemory.
  • kjs/nodes.cpp:

WebCore:

Reviewed by Hyatt.

  • kwq/WebCoreJavaScript.h:
  • kwq/WebCoreJavaScript.mm: (+[WebCoreJavaScript protectedObjectCount]): Renamed from referencedObjectCounts (+[WebCoreJavaScript rootObjectTypeCounts]): Renamed from rootObjectClasses, changed from NSSet to NSCountedSet.

WebKit:

Reviewed by Hyatt.

  • Misc.subproj/WebCoreStatistics.h:
  • Misc.subproj/WebCoreStatistics.m: (+[WebCoreStatistics javaScriptProtectedObjectsCount]): new (+[WebCoreStatistics javaScriptRootObjecTypeCounts]): new (+[WebCoreStatistics javaScriptRootObjectClasses]): deprecated (+[WebCoreStatistics javaScriptReferencedObjectsCount]): deprecated (+[WebCoreStatistics javaScriptNoGCAllowedObjectsCount]): Just return 0. Deprecated.
2:59 PM Changeset in webkit [12558] by mjs
  • 11 edits in trunk/WebCore

Reviewed by Darin.

  • WebCore.xcodeproj/project.pbxproj: reordered slightly.
  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::createFrame): Don't take isObject parameter, just check tag name
  • khtml/html/HTMLFormElementImpl.cpp: (WebCore::HTMLFormElementImpl::prepareSubmit): remove obsolete hasOnlyLocalReferences check
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::isURLAllowed): remove obsolete hasOnlyLocalReferences check
  • loader/DocLoader.cpp: (khtml::DocLoader::requestImage): remove obsolete hasOnlyLocalReferences check (khtml::DocLoader::requestStyleSheet): remove obsolete hasOnlyLocalReferences check (khtml::DocLoader::requestScript): remove obsolete hasOnlyLocalReferences check (khtml::DocLoader::requestXSLStyleSheet): remove obsolete hasOnlyLocalReferences check
  • page/Frame.cpp: (WebCore::Frame::requestFrame): refactored and simplified (WebCore::Frame::requestObject): ditto (WebCore::Frame::shouldUsePlugin): ditto (WebCore::Frame::loadPlugin): ditto (WebCore::Frame::loadSubframe): ditto (WebCore::Frame::frameNames): remove obsolete m_bPreloaded check (WebCore::Frame::frames): ditto (WebCore::Frame::connectChild): check isFrame, not child type (WebCore::Frame::disconnectChild): ditto (WebCore::Frame::handleFallbackContent): greatly simplify using onwerElement (WebCore::Frame::updateBaseURLForEmptyDocument): use ownerElement, notChildFrame (WebCore::Frame::onlyLocalReferences): removed (WebCore::Frame::setOnlyLocalReferences): removed
  • page/Frame.h:
  • page/FramePrivate.h: (WebCore::ChildFrame::ChildFrame): remove most fields.
  • rendering/render_frames.cpp: (WebCore::RenderPartObject::updateWidget): Remove redundant setting of base URL for child document of iframe, Frame itself takes care of this already
10:51 AM Changeset in webkit [12557] by darin
  • 4 edits in trunk/WebKitTools
  • Scripts/make-js-test-wrappers: Don't create a wrapper if there's a disabled wrapper already in the directory.
  • Scripts/svn-apply: Handle additions and deletions properly -- I've been noticing these haven't been working at all.
  • Scripts/svn-unapply: Ditto.
10:30 AM Changeset in webkit [12556] by darin
  • 1 edit in trunk/LayoutTests/ChangeLog

Fixed reviewer name.

8:42 AM Changeset in webkit [12555] by darin
  • 1 edit in trunk/WebCore/khtml/html/html_listimpl.cpp

Reviewed and tweaked by Darin.



Uses the DOM tree to calculate previous nodes and nest correctly

Tests:

  • fast/lists/olstart.html
  • fast/lists/ol-display-types.html
  • khtml/html/html_listimpl.cpp: (DOM::HTMLLIElementImpl::attach): remove calculation of start node value
  • rendering/render_list.cpp: (RenderListItem::setStyle): set up an m_marker even if the style is to not display the marker, to get the numbering right (enclosingList): gets the list enclosing the given node (previousListItemElement): gets the previous element in the list (RenderListItem::calcListValue): calculate the value correctly

Feb 3, 2006:

8:57 PM Changeset in webkit [12554] by darin
  • 1 edit
    8 adds in trunk/LayoutTests

Reviewed by NOBODY (OOPS!).


Layout tests for bug 5776: Generated numbers of ordered lists (OL) are
not calculated right

  • fast/lists/ol-display-types-expected.checksum: Added.
  • fast/lists/ol-display-types-expected.png: Added.
  • fast/lists/ol-display-types-expected.txt: Added.
  • fast/lists/ol-display-types.html: Added.
  • fast/lists/olstart-expected.checksum: Added.
  • fast/lists/olstart-expected.png: Added.
  • fast/lists/olstart-expected.txt: Added.
  • fast/lists/olstart.html: Added.
8:56 PM Changeset in webkit [12553] by darin
  • 2 edits in trunk/WebCore

Reviewed and tweaked by Darin.



Uses the DOM tree to calculate previous nodes and nest correctly

Tests:

  • fast/lists/olstart.html
  • fast/lists/ol-display-types.html
  • khtml/html/html_listimpl.cpp: (DOM::HTMLLIElementImpl::attach): remove calculation of start node value
  • rendering/render_list.cpp: (RenderListItem::setStyle): set up an m_marker even if the style is to not display the marker, to get the numbering right (enclosingList): gets the list enclosing the given node (previousListItemElement): gets the previous element in the list (RenderListItem::calcListValue): calculate the value correctly
6:54 PM Changeset in webkit [12552] by thatcher
  • 1 edit in trunk/WebCore/ChangeLog

Correct the ChangeLog to credit Kimmo Kinnunen <​kimmo.t.kinnunen@nokia.com>

6:14 PM Changeset in webkit [12551] by ggaren
  • 1 edit in trunk/WebCore/ChangeLog

beth felt like the changelog was judging her

6:12 PM Changeset in webkit [12550] by ggaren
  • 3 edits in trunk/WebCore

Reviewed beth.

  • Fixed <rdar://problem/4394868> window.open fails to parse "width=200px"

Cause: QString::toInt() is too aggressive; it parses letters as numbers.
The fix is to switch to DOMString. It's all the rage these days,
and its toInt() behavior matches what we want.

  • manual-tests/window-open-features-parsing.html: Added "px" case to giant evil string.
  • khtml/ecma/kjs_window.cpp: (KJS::setWindowFeature): (KJS::parseWindowFeatures): (KJS::WindowFunc::callAsFunction):
6:01 PM Changeset in webkit [12549] by thatcher
  • 17 edits
    111 adds in trunk

LayoutTests:

Reviewed by Dave Hyatt, Tim H.

Layout tests for:
Bug 4127: WebCore doesn't support Media Queries (CSS3 module)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4127

  • ChangeLog:
  • fast/media: Added.
  • fast/media/001-expected.checksum: Added.
  • fast/media/001-expected.png: Added.
  • fast/media/001-expected.txt: Added.
  • fast/media/001.html: Added.
  • fast/media/002-expected.checksum: Added.
  • fast/media/002-expected.png: Added.
  • fast/media/002-expected.txt: Added.
  • fast/media/002.html: Added.
  • fast/media/003-expected.checksum: Added.
  • fast/media/003-expected.png: Added.
  • fast/media/003-expected.txt: Added.
  • fast/media/003.html: Added.
  • fast/media/004-expected.checksum: Added.
  • fast/media/004-expected.png: Added.
  • fast/media/004-expected.txt: Added.
  • fast/media/004.html: Added.
  • fast/media/005-expected.checksum: Added.
  • fast/media/005-expected.png: Added.
  • fast/media/005-expected.txt: Added.
  • fast/media/005.html: Added.
  • fast/media/006-expected.checksum: Added.
  • fast/media/006-expected.png: Added.
  • fast/media/006-expected.txt: Added.
  • fast/media/006.html: Added.
  • fast/media/007-expected.checksum: Added.
  • fast/media/007-expected.png: Added.
  • fast/media/007-expected.txt: Added.
  • fast/media/007.html: Added.
  • fast/media/008-expected.checksum: Added.
  • fast/media/008-expected.png: Added.
  • fast/media/008-expected.txt: Added.
  • fast/media/008.html: Added.
  • fast/media/009-expected.checksum: Added.
  • fast/media/009-expected.png: Added.
  • fast/media/009-expected.txt: Added.
  • fast/media/009.html: Added.
  • fast/media/010-expected.checksum: Added.
  • fast/media/010-expected.png: Added.
  • fast/media/010-expected.txt: Added.
  • fast/media/010.html: Added.
  • fast/media/011-expected.checksum: Added.
  • fast/media/011-expected.png: Added.
  • fast/media/011-expected.txt: Added.
  • fast/media/011.html: Added.
  • fast/media/012-expected.checksum: Added.
  • fast/media/012-expected.png: Added.
  • fast/media/012-expected.txt: Added.
  • fast/media/012.html: Added.
  • fast/media/013-expected.checksum: Added.
  • fast/media/013-expected.png: Added.
  • fast/media/013-expected.txt: Added.
  • fast/media/013.html: Added.
  • fast/media/014-expected.checksum: Added.
  • fast/media/014-expected.png: Added.
  • fast/media/014-expected.txt: Added.
  • fast/media/014.html: Added.
  • fast/media/015-expected.checksum: Added.
  • fast/media/015-expected.png: Added.
  • fast/media/015-expected.txt: Added.
  • fast/media/015.html: Added.
  • fast/media/016-expected.checksum: Added.
  • fast/media/016-expected.png: Added.
  • fast/media/016-expected.txt: Added.
  • fast/media/016.html: Added.
  • fast/media/017-expected.checksum: Added.
  • fast/media/017-expected.png: Added.
  • fast/media/017-expected.txt: Added.
  • fast/media/017.html: Added.
  • fast/media/018-expected.checksum: Added.
  • fast/media/018-expected.png: Added.
  • fast/media/018-expected.txt: Added.
  • fast/media/018.html: Added.
  • fast/media/019-expected.checksum: Added.
  • fast/media/019-expected.png: Added.
  • fast/media/019-expected.txt: Added.
  • fast/media/019.html: Added.
  • fast/media/020-expected.checksum: Added.
  • fast/media/020-expected.png: Added.
  • fast/media/020-expected.txt: Added.
  • fast/media/020.html: Added.
  • fast/media/021-expected.checksum: Added.
  • fast/media/021-expected.png: Added.
  • fast/media/021-expected.txt: Added.
  • fast/media/021.html: Added.
  • fast/media/022-expected.checksum: Added.
  • fast/media/022-expected.png: Added.
  • fast/media/022-expected.txt: Added.
  • fast/media/022.html: Added.
  • fast/media/023-expected.checksum: Added.
  • fast/media/023-expected.png: Added.
  • fast/media/023-expected.txt: Added.
  • fast/media/023.html: Added.
  • fast/media/024-expected.checksum: Added.
  • fast/media/024-expected.png: Added.
  • fast/media/024-expected.txt: Added.
  • fast/media/024.html: Added.
  • fast/media/025-expected.checksum: Added.
  • fast/media/025-expected.png: Added.
  • fast/media/025-expected.txt: Added.
  • fast/media/025.html: Added.
  • fast/media/026-expected.checksum: Added.
  • fast/media/026-expected.png: Added.
  • fast/media/026.html: Added.
  • fast/media/import-p-green.css: Added.

WebCore:

Reviewed by Dave Hyatt and Tim H.

Bug 4127: WebCore doesn't support Media Queries (CSS3 module)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=4127

​http://www.w3.org/TR/css3-mediaqueries/

  • WebCore.xcodeproj/project.pbxproj:
  • css/css_grammar.y:
  • css/css_mediaqueryeval.cpp: Added. (MediaQueryEvaluator): (MediaQueryEvaluator::~MediaQueryEvaluator): (MediaQueryEvaluator::mediaTypeMatch): (applyRestrictor): (MediaQueryEvaluator::eval): (parseAspectRatio):
  • css/css_mediaqueryeval.h: Added.
  • css/css_mediaqueryimpl.cpp: Added. (MediaQueryExpImpl::MediaQueryExpImpl): (MediaQueryExpImpl::~MediaQueryExpImpl): (MediaQueryExpImpl::mediaFeature): (MediaQueryExpImpl::value): (MediaQueryImpl::MediaQueryImpl): (MediaQueryImpl::~MediaQueryImpl): (MediaQueryImpl::restrictor): (MediaQueryImpl::expressions): (MediaQueryImpl::mediaType): (MediaQueryImpl::operator==):
  • css/css_mediaqueryimpl.h: Added. (DOM::MediaQueryExpImpl::operator==): (DOM::MediaQueryExpListImpl::MediaQueryExpListImpl): (DOM::MediaQueryExpListImpl::append): (DOM::MediaQueryExpListImpl::list): (DOM::MediaQueryImpl::):
  • css/css_stylesheetimpl.cpp: (MediaListImpl::MediaListImpl): (MediaListImpl::deleteMedium): (mediaQueryAsDOMString): (MediaListImpl::mediaText): (MediaListImpl::setMediaText): (MediaListImpl::item): (MediaListImpl::appendMedium): (MediaListImpl::appendMediaQuery):
  • css/css_stylesheetimpl.h: (DOM::MediaListImpl::length): (DOM::MediaListImpl::mediaQueries):
  • css/css_valueimpl.h:
  • css/csshelper.h:
  • css/cssmediafeatures.in: Added.
  • css/cssparser.cpp: (CSSParser::parseMediaQuery):
  • css/cssparser.h:
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::CSSStyleSelector): (WebCore::CSSStyleSelector::init): (WebCore::CSSStyleSelector::~CSSStyleSelector): (WebCore::CSSStyleSelector::loadDefaultStyle): (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::styleRulesForElement): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::CSSStyleSelector::defaultStyleForRoot):
  • css/cssstyleselector.h:
  • css/makemediafeatures: Added.
  • css/maketokenizer:
  • css/tokenizer.flex:
  • khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::process): (WebCore::HTMLLinkElementImpl::setStyleSheet): (WebCore::HTMLStyleElementImpl::childrenChanged):
  • platform/Screen.h:
  • platform/mac/Screen.mm: (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome):
5:48 PM Changeset in webkit [12548] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Darin.


  • change spellchecker preflighting to happen via class methods instead of object methods.
  • WebView.subproj/WebView.m: (-[WebView setContinuousSpellCheckingEnabled:]): (+[WebView _preflightSpellCheckerNow:]): (+[WebView _preflightSpellChecker]):
3:34 PM Changeset in webkit [12547] by thatcher
  • 14 edits in trunk

JavaScriptCore:

Reviewed by Justin.

Renamed configuration names to Debug, Release and Production.

JavaScriptGlue:

Reviewed by Justin.

Renamed configuration names to Debug, Release and Production.

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Justin.

Renamed configuration names to Debug, Release and Production.

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Justin.

Renamed configuration names to Debug, Release and Production.

  • WebKit.xcodeproj/project.pbxproj:

WebKitTools:

Reviewed by Justin.

Renamed configuration names to Debug, Release and Production.

  • DrawTest/DrawTest.xcodeproj/project.pbxproj:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • Scripts/set-webkit-configuration:
  • Scripts/webkitdirs.pm:
2:46 PM Changeset in webkit [12546] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

No test cases added because this is an unreproducible crash.

This is a speculative fix for <rdar://problem/4048026>
CrashTracer: [BOUNCE BACK] 1219 crashes in Safari at
com.apple.WebCore: KHTMLParser::popOneBlock + 36

It seems possible that current could be nil when this function is
called, so the speculative fix is to add a nil check.

3:22 AM Changeset in webkit [12545] by hyatt
  • 4 edits
    6 adds in trunk/WebCore

Refactoring of the image classes to make them even more
portable.

Reviewed by mjs

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Image.cpp: (WebCore::m_animationObserver): (WebCore::Image::Image): (WebCore::Image::~Image): (WebCore::Image::resetAnimation): (WebCore::Image::setData): (WebCore::Image::isNull): (WebCore::Image::size): (WebCore::Image::rect): (WebCore::Image::width): (WebCore::Image::height): (WebCore::): (WebCore::Image::compositeOperatorFromString):
  • platform/ImageData.cpp: Added. (WebCore::FrameData::clear): (WebCore::ImageData::ImageData): (WebCore::ImageData::~ImageData): (WebCore::ImageData::invalidateData): (WebCore::ImageData::cacheFrame): (WebCore::ImageData::isNull): (WebCore::ImageData::size): (WebCore::ImageData::setData): (WebCore::ImageData::setNativeData): (WebCore::ImageData::frameCount): (WebCore::ImageData::isSizeAvailable): (WebCore::ImageData::frameAtIndex): (WebCore::ImageData::frameDurationAtIndex): (WebCore::ImageData::shouldAnimate): (WebCore::ImageData::startAnimation): (WebCore::ImageData::stopAnimation): (WebCore::ImageData::resetAnimation): (WebCore::ImageData::advanceAnimation):
  • platform/ImageData.h: Added. (KXMLCore::): (WebCore::FrameData::m_duration): (WebCore::FrameData::~FrameData): (WebCore::ImageData::setIsPDF): (WebCore::ImageData::currentFrame):
  • platform/ImageDecoder.h:
  • platform/mac/Image.mm: (WebCore::Image::loadResource): (WebCore::Image::supportsType): (WebCore::Image::getCGImageRef): (WebCore::Image::getNSImage): (WebCore::Image::getTIFFRepresentation): (WebCore::graphicsContext): (WebCore::setCompositingOperation): (WebCore::fillSolidColorInRect): (WebCore::Image::drawInRect): (WebCore::drawPattern): (WebCore::Image::tileInRect): (WebCore::Image::scaleAndTileInRect):
  • platform/mac/ImageData.mm: Added. (WebCore::setCompositingOperation): (WebCore::ImageData::invalidateAppleSpecificData): (WebCore::ImageData::checkForSolidColor): (WebCore::ImageData::getTIFFRepresentation): (WebCore::ImageData::getNSImage):
  • platform/mac/PDFDocumentImage.h: Added.
  • platform/mac/PDFDocumentImage.mm: Added. (WebCore::releasePDFDocumentData): (WebCore::PDFDocumentImage::PDFDocumentImage): (WebCore::PDFDocumentImage::~PDFDocumentImage): (WebCore::PDFDocumentImage::documentRef): (WebCore::PDFDocumentImage::mediaBox): (WebCore::PDFDocumentImage::bounds): (WebCore::PDFDocumentImage::adjustCTM): (WebCore::PDFDocumentImage::setCurrentPage): (WebCore::PDFDocumentImage::currentPage): (WebCore::PDFDocumentImage::pageCount): (WebCore::PDFDocumentImage::draw):
1:11 AM Changeset in webkit [12544] by hyatt
  • 3 edits
    2 adds in trunk/WebCore

Make a new class called ImageDecoder that wraps a CGImageSource.
This paves the way for ImageData to become portable as well.

Reviewed by mjs

  • WebCore.xcodeproj/project.pbxproj:
  • platform/ImageDecoder.h: Added.
  • platform/mac/Image.mm: (WebCore::ImageData::~ImageData): (WebCore::ImageData::invalidateData): (WebCore::ImageData::cacheFrame): (WebCore::ImageData::size): (WebCore::ImageData::setCFData): (WebCore::ImageData::frameCount): (WebCore::ImageData::isSizeAvailable): (WebCore::ImageData::drawInRect):
  • platform/mac/ImageDecoder.cpp: Added. (WebCore::ImageDecoder::ImageDecoder): (WebCore::ImageDecoder::~ImageDecoder): (WebCore::imageSourceOptions): (WebCore::ImageDecoder::initialized): (WebCore::ImageDecoder::setData): (WebCore::ImageDecoder::isSizeAvailable): (WebCore::ImageDecoder::size): (WebCore::ImageDecoder::repetitionCount): (WebCore::ImageDecoder::frameCount): (WebCore::ImageDecoder::createFrameAtIndex): (WebCore::ImageDecoder::frameDurationAtIndex):
Note: See TracTimeline for information about the timeline view.