Context Navigation

← Previous Period
Next Period →

Timeline

Feb 13, 2006:

8:19 PM Changeset in webkit [12791] by darin

23 edits
1 add in trunk

WebCore:

Reviewed by Maciej.

move pointer from frame to page here from WebKit

WebCore.xcodeproj/project.pbxproj: Added PageMac.h.

bridge/mac/PageMac.h: Added.

bridge/mac/MacFrame.h: Added a page parameter to the constructor.
bridge/mac/MacFrame.mm: (WebCore::MacFrame::MacFrame): Pass the page and renderer to the Frame constructor. Moved the call to Cache::init up into Frame, and got rid of the call to Frame::init since that's now handled by the constructor. Also put the code to create the browser extension object here. (WebCore::MacFrame::submitForm): Update for new method name. (WebCore::MacFrame::createFrame): Ditto. (WebCore::MacFrame::sendContextMenuEvent): Update since m_doc is a RefPtr.

bridge/mac/WebCoreFrameBridge.h: Changed parameters on init methods. Renamed the part method to impl. Added a page method.
bridge/mac/WebCoreFrameBridge.mm: (frameHasSelection): Change use of part method to impl. (-[WebCoreFrameBridge appendChild:]): Use m_frame directly instead of calling part method. (-[WebCoreFrameBridge removeChild:]): Ditto. (-[WebCoreFrameBridge initMainFrameWithPage:]): Added. Now does the first-time initialization only here and create a frame for a main frame. (-[WebCoreFrameBridge initSubframeWithRenderer:]): Added. Doesn't do the first-time initialization and creates a frame for a subframe. (-[WebCoreFrameBridge page]): Added. (-[WebCoreFrameBridge setOpener:]): Change to use impl method instead of part. (-[WebCoreFrameBridge executionContextForView:]): Ditto. (-[WebCoreFrameBridge impl]): Added.

bridge/mac/WebCorePageBridge.h: Removed init method and added setMainFrame: method and impl method.
bridge/mac/WebCorePageBridge.mm: (-[WebCorePageBridge init]): Changed to create a PageMac. (-[WebCorePageBridge setMainFrame:]): Added. (-[WebCorePageBridge impl]): Added.

bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
kwq/KWQAccObject.mm: (-[KWQAccObject rendererForView:]):
kwq/KWQComboBox.mm: (-[KWQPopUpButtonCell trackMouse:inRect:ofView:untilMouseUp:]):
kwq/KWQFileButton.mm: (KWQFileButton::focusPolicy):
kwq/KWQSlider.mm: (QSlider::focusPolicy):
kwq/KWQTextArea.mm: (-[KWQTextAreaTextView _isResizableByUser]): (-[KWQTextAreaTextView _trackResizeFromMouseDown:]): Change methods to get from bridge back to objects to be named "impl". The old one was named "part".

page/Frame.h: Added Page and RenderPart parameter to constructor. Added a page function. Removed the createBrowserExtension function.
page/Frame.cpp: (WebCore::parentFromOwnerRenderer): Added. Helper for constructor. (WebCore::Frame::Frame): Moved all the code from init into here. Also change to set the parent right from the start. (WebCore::Frame::stopLoading): Change since m_doc is now a RefPtr. (WebCore::Frame::clear): Ditto. (WebCore::Frame::document): Ditto. (WebCore::Frame::setDocument): Ditto. (WebCore::Frame::begin): Ditto. (WebCore::Frame::gotoAnchor): Ditto. (WebCore::Frame::typingStyle): Change since m_typingStyle is now a RefPtr. (WebCore::Frame::setTypingStyle): Ditto. (WebCore::Frame::clearTypingStyle): Ditto. (WebCore::Frame::isFrameSet): Change since m_doc is now a RefPtr. (WebCore::Frame::page): Added.

page/FramePrivate.h: Changed initialization to use member-initialization syntax. Removed unused m_frames. Changed m_doc and m_typingStyle to use RefPtr. Added an m_frame.

page/Page.h: Made destructor virtual so we could have a Mac derived class. Added a setMainFrame function and removed the mainFrame parameter from the constructor.
page/Page.cpp: (WebCore::Page::Page): Removed the mainFrame parameter. (WebCore::Page::setMainFrame): Added.

WebKit:

Reviewed by Maciej.

move pointer from frame to page over to WebCore

WebCoreSupport/WebPageBridge.m: (-[WebPageBridge initWithMainFrameName:webView:frameView:]): Call super init to create the page before creating the main frame and calling setMainFrame: with it.

WebCoreSupport/WebFrameBridge.h: Remove page pointer, and change init function parameters.
WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): New function that is used only for the main frame. Passes the page over to the other side of the bridge. (-[WebFrameBridge initSubframeWithRenderer:frameName:view:]): New function that is used only for subframes. Passes the renderer over to the other side of the bridge. (-[WebFrameBridge mainFrame]): (-[WebFrameBridge webView]): (-[WebFrameBridge createWindowWithURL:frameName:]): (-[WebFrameBridge showWindow]): (-[WebFrameBridge areToolbarsVisible]): (-[WebFrameBridge setToolbarsVisible:]): (-[WebFrameBridge isStatusbarVisible]): (-[WebFrameBridge setStatusbarVisible:]): (-[WebFrameBridge setWindowFrame:]): (-[WebFrameBridge windowFrame]): (-[WebFrameBridge setWindowContentRect:]): (-[WebFrameBridge windowContentRect]): (-[WebFrameBridge setWindowIsResizable:]): (-[WebFrameBridge windowIsResizable]): (-[WebFrameBridge firstResponder]): (-[WebFrameBridge makeFirstResponder:]): (-[WebFrameBridge closeWindowSoon]): (-[WebFrameBridge runJavaScriptAlertPanelWithMessage:]): (-[WebFrameBridge runJavaScriptConfirmPanelWithMessage:]): (-[WebFrameBridge canRunBeforeUnloadConfirmPanel]): (-[WebFrameBridge runBeforeUnloadConfirmPanelWithMessage:]): (-[WebFrameBridge runJavaScriptTextInputPanelWithPrompt:defaultText:returningText:]): (-[WebFrameBridge addMessageToConsole:]): (-[WebFrameBridge runOpenPanelForFileButtonWithResultListener:]): (-[WebFrameBridge setStatusText:]): (-[WebFrameBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): (-[WebFrameBridge focusWindow]): (-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebFrameBridge userAgentForURL:]): (-[WebFrameBridge _nextKeyViewOutsideWebFrameViewsWithValidityCheck:]): (-[WebFrameBridge previousKeyViewOutsideWebFrameViews]): (-[WebFrameBridge defersLoading]): (-[WebFrameBridge setDefersLoading:]): (-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]): (-[WebFrameBridge _preferences]): (-[WebFrameBridge selectWordBeforeMenuEvent]): (-[WebFrameBridge historyLength]): (-[WebFrameBridge canGoBackOrForward:]): (-[WebFrameBridge goBackOrForward:]): (-[WebFrameBridge print]): (-[WebFrameBridge pollForAppletInView:]): (-[WebFrameBridge respondToChangedContents]): (-[WebFrameBridge respondToChangedSelection]): (-[WebFrameBridge undoManager]): (-[WebFrameBridge issueCutCommand]): (-[WebFrameBridge issueCopyCommand]): (-[WebFrameBridge issuePasteCommand]): (-[WebFrameBridge issuePasteAndMatchStyleCommand]): (-[WebFrameBridge canPaste]): (-[WebFrameBridge overrideMediaType]): (-[WebFrameBridge isEditable]): (-[WebFrameBridge shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): (-[WebFrameBridge shouldBeginEditing:]): (-[WebFrameBridge shouldEndEditing:]): (-[WebFrameBridge windowObjectCleared]): (-[WebFrameBridge spellCheckerDocumentTag]): (-[WebFrameBridge isContinuousSpellCheckingEnabled]): (-[WebFrameBridge didFirstLayout]): (-[WebFrameBridge dashboardRegionsChanged:]): (-[WebFrameBridge createModalDialogWithURL:]): (-[WebFrameBridge canRunModal]): (-[WebFrameBridge runModal]): Change all calls to [_page webView] to use [self webView] instead.

8:11 PM Changeset in webkit [12790] by harrison

2 edits in trunk/LayoutTests

Updated test case after improving table deletion.

selection/move-between-blocks-no-001-expected.txt: Updated.

7:29 PM Changeset in webkit [12789] by harrison

8 edits in trunk/WebCore

Reviewed by Justin.

merge VisiblePosition:isCandidate() into Position::inRenderedContent() These functions were answering the same question in different ways! We only need one implementation.

khtml/editing/visible_position.cpp: (khtml::VisiblePosition::init): (khtml::VisiblePosition::previousVisiblePosition): (khtml::VisiblePosition::nextVisiblePosition): (khtml::VisiblePosition::deepEquivalent):
khtml/editing/visible_position.h:
dom/dom_position.cpp: (DOM::hasRenderedChildrenWithHeight): (DOM::Position::inRenderedContent):

improved table deletion. Fixes: delete back by word from just after table did not delete the table

delete forward by char or word did not delete the table
deleting back to a table and again did not delete the table

khtml/editing/htmlediting.cpp: (WebCore::isFirstVisiblePositionAfterTableElement): simpler implementation (WebCore::positionBeforePrecedingTableElement): simpler implementation (WebCore::isFirstVisiblePositionBeforeTableElement): new (WebCore::positionAfterFollowingTableElement): new
khtml/editing/htmlediting.h:
khtml/editing/SelectionController.cpp: (WebCore::SelectionController::modifyExtendingRightForward): select following table if granularity is char or word (WebCore::SelectionController::modifyExtendingLeftBackward): select preceding table if granularity is char or word
khtml/editing/typing_command.cpp: (khtml::TypingCommand::deleteKeyPressed): simpler implementation, and let other deleteKeyPressed do boundary checking (khtml::TypingCommand::forwardDeleteKeyPressed): simpler implementation, and let other forwardDeleteKeyPressed do boundary checking (khtml::TypingCommand::insertText): standard formatting (khtml::TypingCommand::insertLineBreak): standard formatting (khtml::TypingCommand::insertParagraphSeparatorInQuotedContent): standard formatting (khtml::TypingCommand::insertParagraphSeparator): standard formatting (khtml::TypingCommand::insertTextRunWithoutNewlines): standard formatting (khtml::TypingCommand::deleteKeyPressed): use SelectionController to extend selection, to get all the selection logic incl. table selection and editable/noneditable boundary checks (khtml::TypingCommand::forwardDeleteKeyPressed): use SelectionController to extend selection, to get all the selection logic incl. table selection and editable/noneditable boundary checks

5:01 PM Changeset in webkit [12788] by hyatt

2 edits in trunk/WebCore

Fix for bug 5605, XSLT fails to import to arbitrary depth. Make sure m_embedded is initialized to false
in the XSLTStyleSheetImpl constructor.

Reviewed by timo

Adding xslt-import-depth.xml to fast/xsl

khtml/xsl/xsl_stylesheetimpl.cpp: (DOM::XSLStyleSheetImpl::XSLStyleSheetImpl):

5:00 PM Changeset in webkit [12787] by hyatt

5 adds in trunk/LayoutTests/fast/xsl

Add layout test for import depth.

3:13 PM Changeset in webkit [12786] by hyatt

5 edits in trunk/WebCore

Fix Win32 WebCore bustage.

3:02 PM Changeset in webkit [12785] by eseidel

2 edits in trunk/WebCore

2006-02-12 Alexander Kellett <lypanov@kde.org>

Reviewed by eseidel.

Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7207.

No testcases as this is not possible to reproduce via anything
other than manual interaction.

kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::getCIFilterStack):

2:49 PM Changeset in webkit [12784] by hyatt

5 edits in trunk/JavaScriptCore

Fix Win32 JavaScriptCore bustage.

2:08 PM Changeset in webkit [12783] by thatcher

9 copies in tags/Safari-521.7

New Tag

2:02 PM Changeset in webkit [12782] by darin

55 edits
1 copy
2 moves
1 delete in trunk/WebCore

Reviewed by Hyatt.

moved QWidget to platform directory, renamed to Widget, split into cross-platform and platform-specific parts, removed some of the unused bits

ForwardingHeaders/qwidget.h: Removed.
kwq/KWQWidget.h: Removed.
kwq/KWQWidget.mm: Removed.

WebCore.vcproj/WebCore/WebCore.vcproj: Update for file removals and adds.
WebCore.xcodeproj/project.pbxproj: Ditto.

platform/Widget.h: Moved code here, fixed it up.
platform/Widget.cpp: Ditto.
platform/mac/WidgetMac.mm: Added.

bindings/objc/DOMHTML.mm: (viewForElement):
bridge/mac/KWQKHTMLView.cpp: (WebCore::FrameView::topLevelWidget):
bridge/mac/MacFrame.h:
bridge/mac/MacFrame.mm: (WebCore::MacFrame::createPlugin): (WebCore::MacFrame::nextKeyViewInFrame): (WebCore::MacFrame::nextKeyViewForWidget): (WebCore::MacFrame::currentEventIsMouseDownInWidget): (WebCore::MacFrame::bridgeForWidget): (WebCore::MacFrame::passMouseDownEventToWidget): (WebCore::MacFrame::passSubframeEventToSubframe): (WebCore::MacFrame::passWheelEventToChildWidget): (WebCore::MacFrame::getAppletInstanceForWidget): (WebCore::MacFrame::getEmbedInstanceForWidget): (WebCore::MacFrame::getObjectInstanceForWidget):
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge createFrameViewWithNSView:marginWidth:marginHeight:]): (-[WebCoreFrameBridge copyRenderNode:copier:]): (-[WebCoreFrameBridge elementForView:]): (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:]):
dom/DocumentImpl.cpp: (WebCore::widgetForNode): (WebCore::DocumentImpl::setFocusNode):
khtml/ecma/kjs_window.cpp: (KJS::Screen::getValueProperty): (KJS::WindowFunc::callAsFunction):
khtml/html/HTMLGenericFormElementImpl.cpp: (WebCore::HTMLGenericFormElementImpl::isKeyboardFocusable): (WebCore::HTMLGenericFormElementImpl::isMouseFocusable):
khtml/html/html_objectimpl.cpp: (WebCore::HTMLEmbedElementImpl::getEmbedInstance): (WebCore::HTMLObjectElementImpl::getObjectInstance):
kwq/KWQAccObject.mm: (-[KWQAccObject addChildrenToArray:]): (-[KWQAccObject attachmentView]): (-[KWQAccObject doAXTextMarkerForPosition:]):
kwq/KWQComboBox.h:
kwq/KWQComboBox.mm: (QComboBox::frameGeometry): (QComboBox::setFrameGeometry): (QComboBox::setFont): (QComboBox::focusPolicy): (-[KWQPopUpButtonCell widget]): (-[KWQPopUpButton widget]): (-[KWQPopUpButton mouseDown:]): (-[KWQPopUpButton becomeFirstResponder]): (-[KWQPopUpButton resignFirstResponder]): (-[KWQPopUpButton nextKeyView]): (-[KWQPopUpButton previousKeyView]):
kwq/KWQFileButton.h:
kwq/KWQFileButton.mm: (KWQFileButton::focusPolicy):
kwq/KWQFrame.h:
kwq/KWQKCursor.h:
kwq/KWQKJavaAppletWidget.h:
kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget):
kwq/KWQLineEdit.h:
kwq/KWQLineEdit.mm: (QLineEdit::setFont): (QLineEdit::setPalette): (QLineEdit::focusPolicy):
kwq/KWQListBox.h:
kwq/KWQListBox.mm: (QListBox::QListBox): (QListBox::focusPolicy): (QListBox::setFont): (-[KWQListBoxScrollView widget]): (-[KWQListBoxScrollView becomeFirstResponder]): (-[KWQTableView mouseDown:]): (-[KWQTableView widget]):
kwq/KWQPainter.h:
kwq/KWQRenderTreeDebug.cpp: (write):
kwq/KWQScrollBar.h:
kwq/KWQScrollBar.mm: (-[KWQScrollBar widget]): (-[KWQScrollBar mouseDown:]): (QScrollBar::QScrollBar): (QScrollBar::~QScrollBar):
kwq/KWQScrollView.h: (QScrollView::QScrollView):
kwq/KWQScrollView.mm: (QScrollView::viewport): (QScrollView::childX): (QScrollView::childY): (QScrollView::addChild): (QScrollView::removeChild):
kwq/KWQSlider.h:
kwq/KWQSlider.mm: (-[KWQSlider mouseDown:]): (-[KWQSlider widget]): (QSlider::setFont): (QSlider::focusPolicy):
kwq/KWQTextArea.mm: (-[KWQTextAreaTextView widget]):
kwq/KWQTextEdit.h:
kwq/KWQTextEdit.mm: (QTextEdit::QTextEdit): (QTextEdit::setFont): (QTextEdit::focusPolicy): (QTextEdit::setPalette):
kwq/KWQTextField.mm: (-[KWQTextFieldController widget]): (-[KWQTextFieldController textView:shouldHandleEvent:]): (-[KWQTextFieldController textView:didHandleEvent:]): (-[KWQTextField widget]): (-[KWQTextField nextKeyView]): (-[KWQTextField previousKeyView]): (-[KWQSecureTextField widget]): (-[KWQSecureTextField nextKeyView]): (-[KWQSecureTextField previousKeyView]): (-[KWQSearchField widget]): (-[KWQSearchField nextKeyView]): (-[KWQSearchField previousKeyView]):
kwq/KWQView.h:
kwq/KWQWindowWidget.h:
kwq/KWQWindowWidget.mm: (KWQWindowWidget::topLevelWidget):
page/Frame.cpp: (WebCore::isFrameElement): (WebCore::Frame::frameForWidget): (WebCore::Frame::nodeForWidget): (WebCore::Frame::setDocumentFocus): (WebCore::Frame::clearDocumentFocus): (WebCore::Frame::passWidgetMouseDownEventToWidget):
page/Frame.h:
page/FrameView.cpp: (WebCore::FrameView::FrameView): (WebCore::FrameView::init):
page/FrameView.h:
page/Plugin.h: (WebCore::Plugin::Plugin): (WebCore::Plugin::view):
platform/Screen.h:
platform/mac/ScreenMac.mm: (WebCore::screen): (WebCore::screenDepth): (WebCore::screenRect): (WebCore::usableScreenRect):
rendering/render_applet.cpp: (WebCore::RenderApplet::layout):
rendering/render_form.cpp: (WebCore::ComboBoxWidget::ComboBoxWidget): (WebCore::RenderSelect::createListBox):
rendering/render_form.h:
rendering/render_frames.cpp: (WebCore::RenderPart::setWidget):
rendering/render_frames.h:
rendering/render_object.cpp:
rendering/render_replaced.cpp: (WebCore::RenderWidget::resizeWidget): (WebCore::RenderWidget::setQWidget):
rendering/render_replaced.h: (WebCore::RenderWidget::widget): Change name from QWidget to Widget, a few other changes to get compiling.

1:57 PM Changeset in webkit [12781] by thatcher

8 edits in /

Versioning to 521.7

11:34 AM Changeset in webkit [12780] by thatcher

4 edits in trunk/JavaScriptCore

Reviewed by Darin.

Replaced the old NS_DURING exception blocking with @try/@catch.

JavaScriptCorePrefix.h: undef try and catch to workaround a C++ conflict
bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod): (ObjcInstance::invokeDefaultMethod): (ObjcInstance::setValueOfUndefinedField): (ObjcInstance::getValueOfUndefinedField):
bindings/objc/objc_runtime.mm: (ObjcField::valueFromInstance): (ObjcField::setValueToInstance): (ObjcArray::setValueAt): (ObjcArray::valueAt):

1:34 AM Changeset in webkit [12779] by darin

3 edits in trunk/JavaScriptCore

fix a couple problems building on Windows, based on requests from Krzysztof Kowalczyk <kkowalczyk@gmail.com>

kjs/JSImmediate.h: Change code using non-standard u_int32/64_t types to the standard uint32/64_t. Also removed curious "isIEEE()" function that checked the sizes of some types (and type sizes alone don't tell you if the floating point conforms to the IEEE-standard). Added missing include of <stdint.h>.

kjs/property_slot.h: Added missing include of <assert.h>.

Feb 12, 2006:

9:31 PM Changeset in webkit [12778] by darin

1 edit
5 adds in trunk/LayoutTests

Reviewed and tweaked by Darin.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7206 REGRESSION: PDF "images" no longer render within HTML pages

fast/replaced/page-as-image.html: Added.
fast/replaced/page-as-image-expected.txt: Added.
fast/replaced/page-as-image-expected.png: Added.
fast/replaced/page-as-image-expected.checksum: Added.
fast/replaced/resources/image.pdf: Added.

9:27 PM Changeset in webkit [12777] by darin

2 edits in trunk/WebCore

Reviewed by Hyatt.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7206 REGRESSION: PDF "images" no longer render within HTML pages

Test: fast/replaced/page-as-image.html

platform/Image.cpp: (WebCore::Image::setNativeData): Return false in the case where the PDF document has not been created yet.

8:11 PM Changeset in webkit [12776] by mjs

15 edits
14 deletes in trunk/LayoutTests

Rubber stamped by Geoff.

comment out remote <base> URLs, these were making the tests hang for a long time

This also made the affected tests start passing.

dom/xhtml/level2/html/HTMLBodyElement01-expected.checksum: Removed.
dom/xhtml/level2/html/HTMLBodyElement01-expected.png: Removed.
dom/xhtml/level2/html/HTMLBodyElement01-expected.txt:
dom/xhtml/level2/html/HTMLBodyElement01.xhtml:
dom/xhtml/level2/html/HTMLBodyElement02-expected.checksum: Removed.
dom/xhtml/level2/html/HTMLBodyElement02-expected.png: Removed.
dom/xhtml/level2/html/HTMLBodyElement02-expected.txt:
dom/xhtml/level2/html/HTMLBodyElement02.xhtml:
dom/xhtml/level2/html/HTMLBodyElement03-expected.checksum: Removed.
dom/xhtml/level2/html/HTMLBodyElement03-expected.png: Removed.
dom/xhtml/level2/html/HTMLBodyElement03-expected.txt:
dom/xhtml/level2/html/HTMLBodyElement03.xhtml:
dom/xhtml/level2/html/HTMLBodyElement04-expected.checksum: Removed.
dom/xhtml/level2/html/HTMLBodyElement04-expected.png: Removed.
dom/xhtml/level2/html/HTMLBodyElement04-expected.txt:
dom/xhtml/level2/html/HTMLBodyElement04.xhtml:
dom/xhtml/level2/html/HTMLBodyElement05-expected.checksum: Removed.
dom/xhtml/level2/html/HTMLBodyElement05-expected.png: Removed.
dom/xhtml/level2/html/HTMLBodyElement05-expected.txt:
dom/xhtml/level2/html/HTMLBodyElement05.xhtml:
dom/xhtml/level2/html/HTMLBodyElement06-expected.checksum: Removed.
dom/xhtml/level2/html/HTMLBodyElement06-expected.png: Removed.
dom/xhtml/level2/html/HTMLBodyElement06-expected.txt:
dom/xhtml/level2/html/HTMLBodyElement06.xhtml:
dom/xhtml/level2/html/body01-expected.checksum: Removed.
dom/xhtml/level2/html/body01-expected.png: Removed.
dom/xhtml/level2/html/body01-expected.txt:
dom/xhtml/level2/html/body01.xhtml:

7:06 PM Changeset in webkit [12775] by ggaren

2 edits in trunk/JavaScriptCore

Reviewed by darin.

Cleaned up testkjs, added new "run" functionality to allow scripting
tests from within JS. ("run" is a part of my new super-accurate
JS iBench.)

No regressions in run-javascriptcore-tests.

kjs/testkjs.cpp: (GlobalImp::className): (TestFunctionImp::): (TestFunctionImp::callAsFunction): (main): (run):

6:43 PM Changeset in webkit [12774] by darin

4 edits
1 move
3 adds
1 delete in trunk/WebCore

Reviewed by Maciej.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7209 reimplement Timer so it uses only a single timer from the underlying OS

WebCore.vcproj/WebCore/WebCore.vcproj: Removed old files, added new.
WebCore.xcodeproj/project.pbxproj: Ditto.

platform/Timer.h: Updated for new timer implementation.
platform/Timer.cpp: Added. Platform-independent implementation of timers in terms of a single shared timer. Uses a heap to implement a priority queue so we know which timer to fire first.

platform/SharedTimer.h: Added.
platform/mac/SharedTimerMac.cpp: Added.
platform/win/SharedTimerWin.cpp: Added.

platform/mac/TimerMac.cpp: Removed.
platform/win/TimerWin.cpp: Removed.

4:51 PM Changeset in webkit [12773] by eseidel

2 edits in trunk/WebCore

2006-02-12 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

loader/CachedXSLStyleSheet.cpp: removed duplicate copy of xbl code.

2:07 PM Changeset in webkit [12772] by eseidel

3 edits in trunk/WebKitSite

2006-02-12 Joost de Valk <jdevalk@opendarwin.org>

Reviewed by eseidel.

Added a little piece of text to the page about reductions, pointing to the bugzilla page.

Changed "Sign up for a" into "Create a" bugzilla account.

quality/reduction.html:
quality/reporting.html:

8:31 AM Changeset in webkit [12771] by mjs

2 edits in trunk/WebCore

Unreviewed build fix.

fix build

bindings/scripts/CodeGeneratorJS.pm: Update for splitting of the dom_textimpl.h header.

2:11 AM Changeset in webkit [12770] by mjs

7 edits
2 adds in trunk/WebKit

Reviewed by Hyatt.

factor WebArchive creation code out of other classes into new WebArchiver http://bugzilla.opendarwin.org/show_bug.cgi?id=7208

DOM/WebDOMOperations.m: (-[DOMNode webArchive]): (-[DOMRange webArchive]):
WebKit.xcodeproj/project.pbxproj:
WebView/WebArchiver.h: Added.
WebView/WebArchiver.m: Added. (+[WebArchiver _subframeArchivesForFrame:]): (+[WebArchiver archiveFrame:]): (+[WebArchiver _archiveCurrentStateForFrame:]): (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]): (+[WebArchiver archiveRange:]): (+[WebArchiver archiveNode:]): (+[WebArchiver archiveSelectionInFrame:]):
WebView/WebDataSource.m: (-[WebDataSource webArchive]):
WebView/WebDataSourcePrivate.h:
WebView/WebHTMLView.m: (-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]): (-[WebHTMLView _writeSelectionToPasteboard:]):
WebView/WebHTMLViewPrivate.h:

2:07 AM Changeset in webkit [12769] by mjs

1 edit in trunk/WebCore/ChangeLog

Correct tyop in ChangeLog

2:03 AM Changeset in webkit [12768] by mjs

13 edits
2 moves in trunk/WebCore

Reviewed by Darin.

rename FrameTreeNode to FameTree and treeNode() to tree() http://bugzilla.opendarwin.org/show_bug.cgi?id=7210

This may be slightly less accurate, but reads better.

WebCore.xcodeproj/project.pbxproj:
bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
bridge/mac/MacFrame.mm: (WebCore::MacFrame::submitForm): (WebCore::MacFrame::nextKeyViewInFrameHierarchy):
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge firstChild]): (-[WebCoreFrameBridge lastChild]): (-[WebCoreFrameBridge childCount]): (-[WebCoreFrameBridge previousSibling]): (-[WebCoreFrameBridge nextSibling]): (-[WebCoreFrameBridge appendChild:]): (-[WebCoreFrameBridge removeChild:]): (-[WebCoreFrameBridge setParent:]): (-[WebCoreFrameBridge parent]): (-[WebCoreFrameBridge setName:]): (-[WebCoreFrameBridge name]):
dom/DocumentImpl.cpp: (WebCore::DocumentImpl::parentDocument):
khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): (KJS::Window::put): (KJS::Window::isSafeScript): (KJS::WindowFunc::callAsFunction):
khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::isURLAllowed):
khtml/html/html_headimpl.cpp: (WebCore::HTMLLinkElementImpl::process):
page/Frame.cpp: (WebCore::Frame::stopLoading): (WebCore::Frame::clear): (WebCore::Frame::stopAnimations): (WebCore::Frame::checkCompleted): (WebCore::Frame::checkEmitLoadEvent): (WebCore::Frame::slotChildCompleted): (WebCore::Frame::findFrame): (WebCore::Frame::setZoomFactor): (WebCore::Frame::frameNames): (WebCore::Frame::frames): (WebCore::Frame::childFrameNamed): (WebCore::Frame::incrementFrameCount): (WebCore::Frame::decrementFrameCount): (WebCore::Frame::topLevelFrameCount): (WebCore::Frame::selectFrameElementInParentIfFullySelected): (WebCore::Frame::userGestureHint): (WebCore::Frame::canCachePage): (WebCore::Frame::updatePolicyBaseURL): (WebCore::Frame::setPolicyBaseURL): (WebCore::Frame::tree): (WebCore::Frame::frameDetached): (WebCore::Frame::updateBaseURLForEmptyDocument):
page/Frame.h:
page/FramePrivate.h:
page/FrameTree.cpp: Added. (WebCore::FrameTree::~FrameTree): (WebCore::FrameTree::setName): (WebCore::FrameTree::appendChild): (WebCore::FrameTree::removeChild):
page/FrameTree.h: Added. (WebCore::FrameTree::FrameTree):
page/FrameTreeNode.cpp: Removed.
page/FrameTreeNode.h: Removed.
rendering/render_frames.cpp: (WebCore::isURLAllowed):

12:50 AM Changeset in webkit [12767] by hyatt

4 edits in trunk/WebCore

Fix bug 7182, animated GIFs don't clear previous animation frames.

Feb 11, 2006:

7:10 PM Changeset in webkit [12766] by ggaren

3 edits in trunk/WebCore

Fixed bad free resulting from 0 legnth StringImpl

No test case because currently this bug only has the effect of a bad
free on exit().

platform/StringImpl.cpp: (WebCore::StringImpl::StringImpl): Factored varied approaches to initialization into two common routines: initWithChar and initWithQChar. The common rule is: if we're not going to allocate a string, make sure to set s to 0 so fastFree doesn't try to free it later. For speed, initWithQChar uses memcpy() -- that's the only difference between the two. (WebCore::StringImpl::initWithChar): (WebCore::StringImpl::initWithQChar):
platform/StringImpl.h:

5:18 PM Changeset in webkit [12765] by mjs

40 edits
8 copies
2 moves in trunk/WebCore

Rubber stamped by Eric.

split dom_textimpl.{h,cpp} by class.

WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOM.mm:
bridge/mac/MacFrame.mm:
dom/CDATASectionImpl.cpp: Added.
dom/CDATASectionImpl.h: Added.
dom/CharacterDataImpl.cpp: Added.
dom/CharacterDataImpl.h: Added.
dom/CommentImpl.cpp: Added.
dom/CommentImpl.h: Added.
dom/DocumentImpl.cpp:
dom/EditingTextImpl.cpp: Added.
dom/EditingTextImpl.h: Added.
dom/NodeImpl.cpp:
dom/TextImpl.cpp: Added.
dom/TextImpl.h: Added.
dom/dom2_rangeimpl.cpp:
dom/dom_elementimpl.cpp:
dom/dom_textimpl.cpp: Removed.
dom/dom_textimpl.h: Removed.
dom/xml_tokenizer.cpp:
khtml/ecma/kjs_dom.cpp:
khtml/ecma/kjs_html.cpp:
khtml/editing/SelectionController.cpp:
khtml/editing/apply_style_command.cpp:
khtml/editing/break_blockquote_command.cpp:
khtml/editing/composite_edit_command.cpp:
khtml/editing/delete_from_text_node_command.cpp:
khtml/editing/delete_selection_command.cpp:
khtml/editing/htmlediting.cpp:
khtml/editing/insert_into_text_node_command.cpp:
khtml/editing/insert_line_break_command.cpp:
khtml/editing/insert_paragraph_separator_command.cpp:
khtml/editing/insert_text_command.cpp:
khtml/editing/join_text_nodes_command.cpp:
khtml/editing/markup.cpp:
khtml/editing/rebalance_whitespace_command.cpp:
khtml/editing/replace_selection_command.cpp:
khtml/editing/split_text_node_command.cpp:
khtml/editing/split_text_node_containing_element.cpp:
khtml/editing/visible_position.cpp:
khtml/html/HTMLElementImpl.cpp:
khtml/html/HTMLKeygenElementImpl.cpp:
khtml/html/HTMLOptionElementImpl.cpp:
khtml/html/HTMLTextAreaElementImpl.cpp:
khtml/html/html_headimpl.cpp:
khtml/html/html_objectimpl.cpp:
khtml/html/htmlparser.cpp:
khtml/xsl/xslt_processorimpl.cpp:
page/Frame.cpp:
rendering/RenderText.h:
rendering/render_frames.cpp:

4:51 PM Changeset in webkit [12764] by eseidel

15 edits
4 adds in trunk

2006-02-11 Alexander Kellett <lypanov@kde.org>

Reviewed by eseidel.

Fixing http://bugzilla.opendarwin.org/show_bug.cgi?id=6942 Implement support for "em" and "ex" relative lengths.

Layout tests changes:

Fixed: svg/W3C-SVG-1.1/coords-units-03-b.svg
New: svg/custom/coords-relative-units-transforms.svg

4:21 PM Changeset in webkit [12763] by darin

2 edits
1 add in trunk/WebKitSite

Reviewed by Darin.

Added a Bugzilla page, which contains information about creating a Bugzilla account, what editbugs and canconfirm
bits are and how to get them.

Changed link in reporting page to link to Bugzilla page.

quality/bugzilla.html: Added.
quality/reporting.html:

4:09 PM Changeset in webkit [12762] by darin

2 edits
13 moves in trunk/WebCore

Rubber-stamped by Eric.

renamed all the platform/mac files to have a Mac suffix (Hyatt and I discussed this change recently)

WebCore.xcodeproj/project.pbxproj:
platform/mac/Color.mm: Removed.
platform/mac/ColorMac.mm: Added.
platform/mac/FloatPoint.mm: Removed.
platform/mac/FloatPointMac.mm: Added.
platform/mac/FloatRect.mm: Removed.
platform/mac/FloatRectMac.mm: Added.
platform/mac/FloatSize.mm: Removed.
platform/mac/FloatSizeMac.mm: Added.
platform/mac/Image.mm: Removed.
platform/mac/ImageMac.mm: Added.
platform/mac/ImageSource.cpp: Removed.
platform/mac/ImageSourceMac.cpp: Added.
platform/mac/IntPoint.mm: Removed.
platform/mac/IntPointMac.mm: Added.
platform/mac/IntRect.mm: Removed.
platform/mac/IntRectMac.mm: Added.
platform/mac/IntSize.mm: Removed.
platform/mac/IntSizeMac.mm: Added.
platform/mac/QString.mm: Removed.
platform/mac/QStringMac.mm: Added.
platform/mac/Screen.mm: Removed.
platform/mac/ScreenMac.mm: Added.
platform/mac/SystemTime.cpp: Removed.
platform/mac/SystemTimeMac.cpp: Added.
platform/mac/Timer.cpp: Removed.
platform/mac/TimerMac.cpp: Added.

3:54 PM Changeset in webkit [12761] by eseidel

327 edits in trunk/WebCore

2006-02-11 Eric Seidel <eseidel@apple.com>

Rubber-stamped by darin.

Push kcanvas into WebCore namespace.
Fix KSVG2 to use WebCore namespace.

Remove all uses of khtml: and KDOM:: from SVG code. Too many files changed to bother showing here.

3:38 PM Changeset in webkit [12760] by darin

2 edits in trunk/LayoutTests

Reviewed by Darin.

fast/events/event-targets.html: Fixed a small mistake in this test, noticed while checking that bug 3609 is fixed in tip of tree.

3:19 PM Changeset in webkit [12759] by eseidel

2 edits in trunk/WebKitSite

2006-02-12 Joost de Valk <jdevalk@opendarwin.org>

Reviewed by eseidel.

Changed 10.2 paragraph to say Mac OS X instead of just OS X
Detabified the file.

quality/reporting.html:

12:11 PM Changeset in webkit [12758] by adele

7 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

new test and updated results for http://bugzilla.opendarwin.org/show_bug.cgi?id=7054 Vertical scroll bars do not appear or do not scroll completely

fast/replaced/width100percent-expected.checksum: Updated.
fast/replaced/width100percent-expected.png: Updated.
fast/replaced/width100percent-expected.txt: Updated.
fast/table/edge-offsets-expected.checksum: Added.
fast/table/edge-offsets-expected.png: Added.
fast/table/edge-offsets-expected.txt: Added.
fast/table/edge-offsets.html: Added.

WebCore:

Test: fast/table/edge-offsets.html

Reviewed by Hyatt.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7054 Vertical scroll bars do not appear or do not scroll completely

rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::lowestPosition): Override the superclass implementation to return the lowest of all the cells' lowest positions and the section's. (WebCore::RenderTableSection::rightmostPosition): Ditto for rightmost. (WebCore::RenderTableSection::leftmostPosition): Ditto for leftmost.
rendering/RenderTableSection.h:

11:56 AM Changeset in webkit [12757] by adele

3 edits in trunk/WebCore

No test until we figure out how to make one.

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7189 XSLT result parsing stops prematurely

khtml/xsl/xslt_processorimpl.cpp: (DOM::XSLTProcessorImpl::createDocumentFromSource): Removed the call to setParsing(false) from here since it stopped parsing prematurely. Now the frame will call it when the tokenizer is finished.
page/Frame.cpp: (WebCore::Frame::clear): Disconnect the finishedParsing signal handler from the document. (WebCore::Frame::setDocument): Disconnect the signal handler from the old document and connect it to the new document.

11:39 AM Changeset in webkit [12756] by adele

6 edits
1 add in trunk/WebCore

Reviewed by Hyatt.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6821 Fix for 5983 will not always update hover correctly.

khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::hoveredNodeDetached): Added this method. Moved the hover logic from NodeImpl::detach here, modified to use the DOM tree instead of hoverAncestor, to handle the case that the hover node is a text node, and to schedule an update of hover state. (WebCore::DocumentImpl::activeChainNodeDetached): Added this method to trim the active chain above the node being detached.
khtml/xml/DocumentImpl.h:
khtml/xml/NodeImpl.cpp: (WebCore::NodeImpl::detach): Moved most of the hover logic out of here into DocumentImpl. Reset m_active and m_inActiveChain and call activeChainNodeDetached when detaching an active node.
manual-tests/bugzilla-6821.html: Added.
page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Added hover-state update timer. (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::~FrameView): (WebCore::FrameView::viewportMouseMoveEvent): (WebCore::FrameView::hoverTimerFired): Call DocumentImpl::prepareMouseEvent when the timer fires to cause hover state to update. (WebCore::FrameView::scheduleHoverStateUpdate): Added.
page/FrameView.h:

9:58 AM Changeset in webkit [12755] by darin

2 edits in trunk/WebKit

English.lproj/StringsNotToBeLocalized.txt: Updated paths for recent changes in directory structure.

8:03 AM Changeset in webkit [12754] by sullivan

3 edits in trunk/WebKit

Reviewed by John Sullivan.

Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7171 No description in WebKitErrors.m for WebKitErrorPlugInWillHandleLoad

English.lproj/Localizable.strings: Added new UI_STRING().
Misc/WebKitErrors.m: Added #define for description. (registerErrors): Added dictionary entry.

2:48 AM Changeset in webkit [12753] by ap

4 edits
12 adds in trunk

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3400 setting the .src of an iframe to the same value does not reload page

Test cases:

fast/frames/frame-set-same-location.html
fast/frames/frame-set-same-src.html
fast/frames/iframe-set-same-location.html
fast/frames/iframe-set-same-src.html

khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::setLocation): Remove the check for the new URL being different from the current one. Moved updateForNewURL() code into setLocation().
khtml/html/html_baseimpl.h:

2:34 AM Changeset in webkit [12752] by ap

2 edits in trunk/JavaScriptCore

Reviewed by Darin.

improve fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5163 RealPlayer.GetTitle() Crashes Safari/Dashboard

bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16): Use kCFStringEncodingISOLatin1 rather than kCFStringEncodingWindowsLatin1, because the latter encoding has holes, and conversion can still fail.

12:34 AM Changeset in webkit [12751] by eseidel

1 edit
9 adds in trunk/LayoutTests

2006-02-11 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Adding support for external entity declarations in XSLT.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7184
<rdar://problem/4271696> support external DTD references in XSLT

fast/parser/external-entities-expected.checksum: Added.
fast/parser/external-entities-expected.png: Added.
fast/parser/external-entities-expected.txt: Added.
fast/parser/external-entities-in-xslt-expected.txt: Added.
fast/parser/external-entities-in-xslt.xml: Added.
fast/parser/external-entities.xml: Added.
fast/parser/resources: Added.
fast/parser/resources/external-entities.dtd: Added.
fast/parser/resources/external-entities.xsl: Added.

12:15 AM Changeset in webkit [12750] by eseidel

5 edits in trunk/WebCore

2006-02-10 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

Adding support for external entity declarations in XSLT.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7184
<rdar://problem/4271696> support external DTD references in XSLT

dom/xml_tokenizer.cpp: (WebCore::OffsetBuffer::OffsetBuffer): new support class (WebCore::OffsetBuffer::readOutBytes): read method (WebCore::shouldAllowExternalLoad): for preventing common urls (WebCore::openFunc): now does a synchronous data load (WebCore::readFunc): returns data from the offset buffer (WebCore::closeFunc): deletes offset buffer (WebCore::setLoaderForLibXMLCallbacks): helper function (WebCore::createQStringParser): cleanup (WebCore::XMLTokenizer::finish):
dom/xml_tokenizer.h:
khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::parseString):
khtml/xsl/xsl_stylesheetimpl.h:

Feb 10, 2006:

11:35 PM Changeset in webkit [12749] by hyatt

1 edit in trunk/WebCore/platform/image-decoders/gif/GIFImageDecoder.cpp

Make sure the GIF decoder behaves properly when the first frame of a GIF does not cover the entire image.

11:07 PM Changeset in webkit [12748] by hyatt

14 edits in trunk/WebCore

Implement an optimization to detect whether or not an image has alpha and do a blit instead of a blend in that case. r=eric

6:16 PM Changeset in webkit [12747] by bdakin

1 edit
4 adds in trunk/LayoutTests

Reviewed by Hyatt

Layout test for <rdar://problem/4149655> Frequently reported crash,
repro at lastminute.se in khtml::RenderBlock::createLineBoxes

6:08 PM Changeset in webkit [12746] by bdakin

6 edits in trunk/WebCore

Reviewed by Hyatt

Fix for <rdar://problem/4149655> Frequently reported crash, repro
at lastminute.se in khtml::RenderBlock::createLineBoxes

Some crazy combination of an anonymous table, an inline form, and
generated content caused table objects to be added to a flow and
then split. This is very bad. Once the crash was fixed, there were
still some rendering issues that this patch also fixes. We needed
to make sure we only special case forms for non-CSS tables so that
the form and generated content render as expected.

5:36 PM Changeset in webkit [12745] by thatcher

2 edits in tags/WebCore-417.21/WebCore/khtml/ecma

Build fix

5:34 PM Changeset in webkit [12744] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore/khtml/ecma

Build fix.

5:18 PM Changeset in webkit [12743] by thatcher

3 copies in tags/WebCore-417.21/WebCore

New tag.

5:17 PM Changeset in webkit [12742] by thatcher

1 add in tags/WebCore-417.21

New tag

5:13 PM Changeset in webkit [12741] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Versioning WebCore-417.21

5:09 PM Changeset in webkit [12740] by eseidel

2 edits in branches/Safari-2-0-branch/WebCore

2006-02-10 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

<rdar://problem/4145813> hang in XMLHttpRequest::cancelRequests
No test case possible.

khtml/ecma/xmlhttprequest.cpp: (KJS::removeFromRequestsByDocument): (KJS::XMLHttpRequest::removeFromRequestsByDocument): (KJS::XMLHttpRequest::cancelRequests):

2:57 PM Changeset in webkit [12739] by darin

2 edits in trunk/WebKitSite

index.html: Fixed a typo in a link.

1:24 PM Changeset in webkit [12738] by thatcher

2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Tim O.

Rolling out r11800 and reworked Tim's original fix
to call _NPN_DeallocateObject in the destructor.

kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::~KWQKHTMLPart): (KWQKHTMLPart::setView): (KWQKHTMLPart::cleanupPluginRootObjects):

10:47 AM Changeset in webkit [12737] by ggaren

2 edits in trunk/JavaScriptCore

Reviewed by Darin.

Inlined RefPtr assignment operators. .7% performance win on super-accurate JS iBench.

kxmlcore/RefPtr.h: (KXMLCore::::operator):

9:31 AM Changeset in webkit [12736] by darin

2 edits in trunk/WebKitSite/coding

Some factual corrections and some updates to the coding style
document to reflect our current practices.

9:11 AM Changeset in webkit [12735] by darin

2 edits in trunk/WebKitSite

building/checkout.html: Fixed a spelling mistake.

8:41 AM Changeset in webkit [12734] by darin

4 edits in trunk/WebCore

fixed the build, this time for sure

bindings/js/JSDOMCore.cpp: Touch this file, since the project doesn't get the dependencies right.
bindings/js/JSDOMEvents.cpp: Ditto.

bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): Fix an uninitialized variable warning and also tightened the code for Boolean, String, and Number up a bit.

2:14 AM Changeset in webkit [12733] by andersca

36 edits in trunk/WebKitSite

2006-02-10 Joost de Valk <jdevalk@opendarwin.org>

Reviewed and landed by Anders.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7164
Code cleanup

Changed <div id="banner" to <h1 id="banner"
global cleanup of CSS and code

building/build.html:
building/checkout.html:
coding/coding-style.html:
coding/contributing.html:
contact.html:
index.html:
projects/accessibility/index.html:
projects/cleanup/index.html:
projects/compat/index.html:
projects/css/index.html:
projects/documentation/index.html:
projects/dom/index.html:
projects/editing/index.html:
projects/forms/index.html:
projects/html/index.html:
projects/index.html:
projects/javascript/index.html:
projects/layout/index.html:
projects/mathml/index.html:
projects/performance/index.html:
projects/plugins/index.html:
projects/portability/index.html:
projects/printing/index.html:
projects/svg/index.html:
projects/webkit/index.html:
projects/xml/index.html:
projects/xslt/index.html:
quality/bugpriorities.html:
quality/bugwriting.html:
quality/lifecycle.html:
quality/reduction.html:
quality/reporting.html:
quality/testing.html:
quality/testwriting.html:
webkitdev.css:

1:49 AM Changeset in webkit [12732] by hyatt

2 edits in trunk/WebCore/WebCore.vcproj

Improve the double buffering of the image viewer test app on win32 to do a source composit op and not a source-over op.

1:47 AM Changeset in webkit [12731] by hyatt

9 edits in trunk/WebCore/platform/cairo

Merge cairo fixes from Mozilla and one additional fix after discussion with vlad. Code is now smarter about knowing when to blt vs. alpha blend.

1:03 AM Changeset in webkit [12730] by ggaren

2 edits in trunk/JavaScriptCore

No review needed, just a build fix. This time for sure.

kjs/JSType.h:

12:42 AM Changeset in webkit [12729] by ggaren

13 edits in trunk

JavaScriptCore:

Reviewed by eric.

Fixed build. As it goes without saying, I will not mention that I blame Kevin.

JavaScriptCore.xcodeproj/project.pbxproj:
kjs/JSImmediate.cpp: (KJS::JSImmediate::toObject):

JavaScriptGlue:

Reviewed by eric.

Fixed build.

UserObjectImp.cpp: (UserObjectImp::toPrimitive):
UserObjectImp.h:

WebCore:

Reviewed by eric.

Fixed build.

bridge/mac/WebCoreFrameBridge.mm:
khtml/ecma/kjs_binding.h: (KJS::DOMFunction::toPrimitive):
khtml/ecma/kjs_dom.cpp: (KJS::DOMNode::toPrimitive): (KJS::DOMNodeList::toPrimitive):
khtml/ecma/kjs_dom.h:
khtml/ecma/kjs_window.cpp: (KJS::Location::toPrimitive): (KJS::Selection::toPrimitive):
khtml/ecma/kjs_window.h:

Feb 9, 2006:

10:42 PM Changeset in webkit [12728] by ggaren

27 edits
1 move
2 adds in trunk/JavaScriptCore

Reviewed by mjs.

Fixed <rdar://problem/4343730> Should switch ConstantValues (null, undefined, true, false) from JS objects to immediate values similar to SimpleNumber

2.0% performance gain on my new super-accurate version of JS iBench.
(I promise to land a version of it soon.)

The gist of the change:
(1) The SimpleNumber class (simple_number.h) is now the JSImmediate
class (JSImmediate.h/.cpp), and it handles not only numbers but also
null, undefined, true, and false.
(2) JSImmediate provides convenience methods for the bit masking
necessary to encode and decode immediate values.
(3) ConstantValues, BooleanImp, NullImp, and UndefinedImp are gone.
(4) JSCell no longer implements functions like getBoolean, because
only a JSImmediate can be a boolean.
(5) JSImmediate no longer uses ALWAYS_INLINE because there's no need,
and ALWAYS_INLINE is a non-portable option of last resort.
(6) Type is now JSType, and it resides in its own file, JSType.h.
Since I was there, I did some header include sorting as part of this
change.

The rest pretty much explains itself.

JavaScriptCore.xcodeproj/project.pbxproj: Removed simple_number.h, added JSImmediate.h/.cpp.
bindings/c/c_instance.cpp: (KJS::Bindings::CInstance::defaultValue):
bindings/c/c_instance.h:
bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant):
bindings/jni/jni_instance.cpp: (JavaInstance::defaultValue):
bindings/jni/jni_instance.h:
bindings/jni/jni_jsobject.cpp: (JavaJSObject::convertValueToJObject):
bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:originExecutionContext:executionContext:]): Standardized calls to use getXXX instead of hand-rolling JSValue functionality.
bindings/objc/objc_instance.h:
bindings/objc/objc_instance.mm: (ObjcInstance::getValueOfUndefinedField): (ObjcInstance::defaultValue):
bindings/objc/objc_runtime.h:
bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::type): (ObjcFallbackObjectImp::defaultValue):
bindings/runtime.h: (KJS::Bindings::Instance::getValueOfUndefinedField):
bindings/runtime_object.cpp: (RuntimeObjectImp::defaultValue):
bindings/runtime_object.h:
kjs/JSImmediate.h: Added. (KJS::JSImmediate::isImmediate): (KJS::JSImmediate::isNumber): (KJS::JSImmediate::isBoolean): (KJS::JSImmediate::isUndefinedOrNull): (KJS::JSImmediate::fromDouble): (KJS::JSImmediate::toDouble): (KJS::JSImmediate::toBoolean): (KJS::JSImmediate::trueImmediate): (KJS::JSImmediate::falseImmediate): (KJS::JSImmediate::NaNImmediate): (KJS::JSImmediate::undefinedImmediate): (KJS::JSImmediate::nullImmediate): (KJS::JSImmediate::tag): (KJS::JSImmediate::unTag): (KJS::JSImmediate::getTag): (KJS::JSImmediate::): (KJS::JSImmediate::isIEEE): (KJS::JSImmediate::is32bit): (KJS::JSImmediate::is64bit): (KJS::JSImmediate::NanAsBits): (KJS::JSImmediate::zeroAsBits): (KJS::JSImmediate::oneAsBits):
kjs/JSLock.cpp: (KJS::JSLock::lock): Removed hack-o-rama to initialize ConstantValues.
kjs/JSType.h: Added.
kjs/collector.cpp: (KJS::Collector::protect): (KJS::Collector::unprotect): (KJS::Collector::collect):
kjs/internal.cpp: (KJS::StringImp::toPrimitive): (KJS::NumberImp::toPrimitive): (KJS::NumberImp::toBoolean): (KJS::GetterSetterImp::toPrimitive):
kjs/internal.h: (KJS::StringImp::type): (KJS::NumberImp::type):
kjs/object.cpp: (KJS::JSObject::type): (KJS::tryGetAndCallProperty): Replaced "Are you one of the six things I'm looking for?" test with "Are you not the one thing I'm not looking for" test. (KJS::JSObject::defaultValue): (KJS::JSObject::toPrimitive):
kjs/object.h: (KJS::GetterSetterImp::type): (KJS::JSValue::isObject):
kjs/operations.cpp: (KJS::equal): (KJS::strictEqual): (KJS::add):
kjs/reference.cpp: (KJS::Reference::deleteValue):
kjs/simple_number.h: Removed.
kjs/string_object.cpp: (StringInstance::getOwnPropertySlot): fixed indentation
kjs/value.cpp: (KJS::JSValue::toObject): (KJS::jsNumberCell): New function to quarantine a PIC branch -- allows us to inline jsNumber without adding PIC branches to callers.
kjs/value.h: (KJS::jsUndefined): (KJS::jsNull): (KJS::jsNaN): (KJS::jsBoolean): (KJS::jsNumber): (KJS::JSValue::downcast): (KJS::JSValue::isUndefinedOrNull): (KJS::JSValue::isBoolean): (KJS::JSValue::isNumber): (KJS::JSValue::isString): (KJS::JSValue::isObject): (KJS::JSValue::getBoolean): (KJS::JSValue::getNumber): (KJS::JSValue::getString): (KJS::JSValue::getObject): (KJS::JSValue::getUInt32): (KJS::JSValue::mark): Replaced !JSImmediate::is() test with assertion, resulting in a slight performance gain. Callers should always check !marked() before calling mark(), so it's impossible to call mark on a JSImmediate. (KJS::JSValue::marked): (KJS::JSValue::type): (KJS::JSValue::toPrimitive): (KJS::JSValue::toBoolean): (KJS::JSValue::toNumber): (KJS::JSValue::toString):

5:30 PM Changeset in webkit [12727] by tomernic

3 edits in trunk/WebKit

Reviewed by Tim Hatcher.

<rdar://problem/4153419> CrashTracer: 576 crashes in Safari at com.apple.WebKit: NPN_DestroyStream + 56

I never could reproduce this crasher, which seems to be caused by the Speed Download plugin. However,
I did find a way to make the affected code more bulletproof for those who are experiencing the crash.

Plugins/WebBaseNetscapePluginStream.h: Keep a WebBaseNetscapePluginView instead of the WebNetscapePluginPackage, since the plugin view could potentially be deallocated before the stream finishes loading.
Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream _pluginCancelledConnectionError]): Use pluginView instead of plugin. (-[WebBaseNetscapePluginStream dealloc]): Assert that the plugin instance has been nulled out, since that's now part of the stream's teardown phase. Release pluginView instead of plugin. (-[WebBaseNetscapePluginStream setPluginPointer:]): Retain the plugin view instead of the plugin package, since the plugin view could be deallocated while the stream is running. This method now accepts a NULL argument so that we can easily clear out the pluginView backpointer (and other ivars derived from it). (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]): Use pluginView instead of plugin. (-[WebBaseNetscapePluginStream _destroyStream]): ditto (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): ditto (-[WebBaseNetscapePluginStream cancelLoadAndDestroyStreamWithError]): Set the plugin instance to NULL, so that the pluginView backpointer is released. This method is called for every plugin view's stream when the plugin view is stopped/destroyed. (-[WebBaseNetscapePluginStream _deliverData]): Use pluginView instead of plugin.

5:20 PM Changeset in webkit [12726] by darin

3 edits in trunk/WebCore

Reviewed by Hyatt.

<rdar://problem/4430614> RenderThemeMac crashes under GC

rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::RenderThemeMac): Initialize all the pointers. (WebCore::RenderThemeMac::setCheckboxCellState): Use KWQRetainNSRelease so we can retain a pointer to an ObjC object in a C++ class. (WebCore::RenderThemeMac::setRadioCellState): Ditto. (WebCore::RenderThemeMac::setButtonCellState): Ditto. (WebCore::RenderThemeMac::setTextFieldCellState): Ditto.

kwq/KWQResourceLoader.h: Remove unneeded forward declaration.

4:09 PM Changeset in webkit [12725] by darin

33 edits in trunk/WebCore

Reviewed by Eric and Geoff.

changed basic DOM mutation calls to assert that "this" is not floating, then added more uses of RefPtr to prevent the assertion from firing (at least during my testing and layout tests)

removed use of PassRefPtr as the type of a local variable; after talking with Maciej and Eric, this type of use is now "deprecated"

bindings/js/JSDOMCore.cpp: Touched this file to get things to build.

bindings/objc/DOM.mm: (-[DOMRange extractContents]): (-[DOMRange cloneContents]): (-[DOMRange cloneRange]):
khtml/ecma/kjs_range.cpp: (KJS::DOMRange::getValueProperty): (KJS::DOMRangeProtoFunc::callAsFunction):
khtml/editing/Selection.cpp: (WebCore::Selection::toRange):
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge documentFragmentWithMarkupString:baseURLString:]):
dom/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::insertBefore): (WebCore::ContainerNodeImpl::replaceChild): (WebCore::ContainerNodeImpl::removeChild): (WebCore::ContainerNodeImpl::appendChild):
dom/DocPtr.h: Removed uses of NULL and unused deprecated functions.
dom/dom2_rangeimpl.h:
dom/dom2_rangeimpl.cpp: (WebCore::RangeImpl::RangeImpl): (WebCore::RangeImpl::startContainer): (WebCore::RangeImpl::endContainer): (WebCore::RangeImpl::commonAncestorContainer): (WebCore::RangeImpl::setStart): (WebCore::RangeImpl::setEnd): (WebCore::RangeImpl::collapse): (WebCore::RangeImpl::compareBoundaryPoints): (WebCore::RangeImpl::boundaryPointsValid): (WebCore::RangeImpl::processContents): (WebCore::RangeImpl::extractContents): (WebCore::RangeImpl::cloneContents): (WebCore::RangeImpl::insertNode): (WebCore::RangeImpl::createContextualFragment): (WebCore::RangeImpl::detach): (WebCore::RangeImpl::cloneRange): (WebCore::RangeImpl::selectNodeContents): (WebCore::RangeImpl::surroundContents): (WebCore::RangeImpl::containedByReadOnly): (WebCore::RangeImpl::startPosition): (WebCore::RangeImpl::endPosition): (WebCore::RangeImpl::startNode): (WebCore::RangeImpl::editingStartPosition): (WebCore::rangeOfContents):
dom/dom_elementimpl.h:
dom/dom_elementimpl.cpp: (WebCore::AttrImpl::AttrImpl): (WebCore::AttrImpl::~AttrImpl): (WebCore::AttrImpl::setValue): (WebCore::AttrImpl::childTypeAllowed): (WebCore::AttrImpl::childrenChanged): (WebCore::ElementImpl::removeAttributeNode): (WebCore::NamedAttrMapImpl::clearAttributes): (WebCore::CSSMappedAttributeDeclarationImpl::~CSSMappedAttributeDeclarationImpl): (WebCore::MappedAttributeImpl::clone):
dom/DocumentFragmentImpl.cpp: (DOM::DocumentFragmentImpl::cloneNode):
dom/dom_xmlimpl.cpp: (WebCore::EntityReferenceImpl::cloneNode): (WebCore::ProcessingInstructionImpl::ProcessingInstructionImpl): (WebCore::ProcessingInstructionImpl::checkStyleSheet): (WebCore::ProcessingInstructionImpl::setStyleSheet):
dom/dom_position.cpp:
khtml/editing/break_blockquote_command.cpp: (WebCore::BreakBlockquoteCommand::doApply):
khtml/editing/composite_edit_command.cpp: (WebCore::CompositeEditCommand::appendBlockPlaceholder): (WebCore::CompositeEditCommand::insertBlockPlaceholder): (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): (WebCore::createBlockPlaceholderElement):
khtml/editing/delete_selection_command.cpp: (WebCore::DeleteSelectionCommand::insertPlaceholderForAncestorBlockContent): (WebCore::DeleteSelectionCommand::moveNodesAfterNode):
khtml/editing/html_interchange.cpp:
khtml/editing/htmlediting.cpp: (WebCore::rebalanceWhitespaceInTextNode): (WebCore::nonBreakingSpaceString): (WebCore::createDefaultParagraphElement): (WebCore::createBreakElement): (WebCore::createTabSpanElement):
khtml/editing/insert_line_break_command.cpp: (khtml::InsertLineBreakCommand::doApply):
khtml/editing/insert_paragraph_separator_command.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
khtml/editing/insert_paragraph_separator_command.h:
khtml/editing/insert_text_command.cpp: (khtml::InsertTextCommand::insertTab):
khtml/editing/markup.cpp: (khtml::createFragmentFromMarkup): (khtml::createParagraphContentsFromString): (khtml::createFragmentFromText): (khtml::createFragmentFromNodeList):
khtml/editing/rebalance_whitespace_command.cpp:
khtml/editing/replace_selection_command.cpp: (WebCore::ReplacementFragment::ReplacementFragment): (WebCore::ReplacementFragment::insertFragmentForTestRendering): (WebCore::ReplaceSelectionCommand::doApply):
khtml/editing/visible_text.cpp: (khtml::CharacterIterator::range): (khtml::findPlainText):
khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::cloneNode):
khtml/html/htmlparser.cpp: (HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
ksvg2/svg/SVGTransformableImpl.cpp: (SVGTransformableImpl::parseTransformAttribute):
ksvg2/svg/SVGUseElementImpl.cpp: (SVGUseElementImpl::closeRenderer):

1:33 PM Changeset in webkit [12724] by thatcher

1 edit in trunk/WebKit/ChangeLog

Adding eol-style.

1:31 PM Changeset in webkit [12723] by thatcher

1 copy
1 add in trunk/WebKit

Rolling over the ChangeLog.

11:22 AM Changeset in webkit [12722] by ap

3 edits in trunk/WebKitSite

Fixes by Mark Rowe and Joost de Valk. Reviewed by Darin. Landed by ap.

fixes from http://bugzilla.opendarwin.org/show_bug.cgi?id=4871 "Reporting Bugs" Page Should Prompt User To Test In Newest Version of WebKit

quality/reporting.html:
webkitdev.css: Added margin-bottom for li.

11:21 AM Changeset in webkit [12721] by tomernic

2 edits in trunk/WebKit

Reviewed by Darin Adler.

<rdar://problem/4198378> Crash on a CFRelease when visiting http://www.akella.com/

Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView requestWithURLCString:]): The true source of this crash is that the URL string is sometimes not NULL-terminated, which is the Real Player plugin's fault. That has been filed as 4439591. However, we can be more bulletproof here by switching the URL string encoding from Windows Latin 1 to ISO Latin 1, so that any NULL-terminated string can be represented. (As Darin and I found out last night, Windows Latin 1 has "holes" in certain character ranges and thus cannot encode arbitrary C strings).

2:16 AM Changeset in webkit [12720] by mjs

4 edits in trunk/WebCore

Reviewed and landed by Maciej.

Factor out common parts of Linear/Radial GradientQuartz
up into KRenderingPaintServerGradientQuartz.

Cleanup only, no layout tests needed or affected.

kcanvas/device/KRenderingPaintServer.h:
kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (KRenderingPaintServerGradientQuartz::updateQuartzGradientCache): (KRenderingPaintServerGradientQuartz::draw): (KRenderingPaintServerGradientQuartz::setup): (KRenderingPaintServerGradientQuartz::renderPath): (KRenderingPaintServerGradientQuartz::teardown):
kcanvas/device/quartz/KRenderingPaintServerQuartz.h: (KRenderingPaintServerLinearGradientQuartz::draw): (KRenderingPaintServerLinearGradientQuartz::setup): (KRenderingPaintServerLinearGradientQuartz::teardown): (KRenderingPaintServerLinearGradientQuartz::renderPath): (KRenderingPaintServerRadialGradientQuartz::draw): (KRenderingPaintServerRadialGradientQuartz::setup): (KRenderingPaintServerRadialGradientQuartz::teardown): (KRenderingPaintServerRadialGradientQuartz::renderPath):

1:54 AM Changeset in webkit [12719] by mjs

7 edits in trunk/WebCore

Reviewed by Hyatt.

various Frame cleanup:

Make Frame-related classes Noncopyable.
Remove nearly all of Frame's friends.
Remove some unused stuff.
Remove unneeded class forward declarations from Frame.h

page/Frame.cpp:
page/Frame.h:
page/FrameTreeNode.h: (WebCore::FrameTreeNode::FrameTreeNode): (WebCore::FrameTreeNode::name): (WebCore::FrameTreeNode::parent): (WebCore::FrameTreeNode::setParent): (WebCore::FrameTreeNode::nextSibling): (WebCore::FrameTreeNode::previousSibling): (WebCore::FrameTreeNode::firstChild): (WebCore::FrameTreeNode::lastChild): (WebCore::FrameTreeNode::childCount):
page/FrameView.cpp: (WebCore::FrameView::viewportMouseMoveEvent):
page/Page.h: (WebCore::Page::mainFrame):
page/Plugin.h: (WebCore::Plugin::Plugin): (WebCore::Plugin::view):

1:36 AM Changeset in webkit [12718] by mjs