Timeline



Feb 26, 2006:

10:34 PM Changeset in webkit [12999] by ggaren
  • 2 edits in trunk/WebKitSite

Reviewed by Maciej, landed by Geoff.

Change "Deployment" to "Release" and "Development" to "Debug".
Update latest Xcode version from 2.2 to 2.2.1.

  • building/build.html
10:30 PM Changeset in webkit [12998] by ggaren
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Maciej, landed by Geoff.

  • fast/forms/form-hides-table-expected.checksum: Added.
  • fast/forms/form-hides-table-expected.png: Added.
  • fast/forms/form-hides-table-expected.txt: Added.
  • fast/forms/form-hides-table.html: Added.
10:22 PM Changeset in webkit [12997] by ggaren
  • 3 edits
    2 adds in trunk

LayoutTests:

Test by Geoff, automated by me, reviewed by Darin.

  • fast/frames/empty-frame-document-expected.txt: Added.
  • fast/frames/empty-frame-document.html: Added.

WebKit:

Test: fast/frames/empty-frame-document.html

Reviewed by Darin.

The crash happened because an empty frame did not have a document.

  • WebView/WebFrame.m: (-[WebFrame _commitProvisionalLoad:]): Use "about:blank" instead of an empty URL for empty frames. This causes a document to be created for the frame.
8:08 PM Changeset in webkit [12996] by darin
  • 3 edits in trunk/WebCore
  • try again after seeing errors from buildbot
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
  • loader/CachedImage.cpp: (WebCore::CachedImage::data): Add APPLE ifdefs to two more uses of response.
7:50 PM Changeset in webkit [12995] by darin
  • 5 edits in trunk/WebCore
  • try again after seeing errors from buildbot
  • loader/CachedObject.cpp: (WebCore::CachedObject::~CachedObject):
  • loader/CachedObject.h: (WebCore::CachedObject::CachedObject):
  • loader/loader.cpp: Add APPLE ifdefs to calls to setResponse and setAllData.
  • platform/win/TemporaryLinkStubs.cpp: Add missing includes.
7:31 PM Changeset in webkit [12994] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • more Win32 link fixes
  • loader/CachedObject.h: Put some Mac-specific stuff inside APPLE ifdefs.
  • platform/win/TemporaryLinkStubs.cpp: Added more stubs.
7:08 PM Changeset in webkit [12993] by darin
  • 2 edits in trunk/WebCore
  • try again after seeing errors from buildbot
  • platform/win/TemporaryLinkStubs.cpp: Added more includes.
7:08 PM Changeset in webkit [12992] by darin
  • 2 edits in trunk/WebCore
  • try again after seeing errors from buildbot
  • platform/win/TemporaryLinkStubs.cpp: Added more includes.
7:03 PM Changeset in webkit [12991] by darin
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • work toward getting the Win32 build to link
  • WebCore.vcproj/WebCore/WebCore.vcproj: Added KWQObject.cpp.
  • platform/win/TemporaryLinkStubs.cpp: Added more stubs.

Feb 25, 2006:

8:51 PM Changeset in webkit [12990] by darin
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Added reviewer to an old change; I just noticed it was missing.

5:14 PM Changeset in webkit [12989] by ggaren
  • 9 edits
    18 adds in trunk/LayoutTests

RS by mjs.

-tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=5146
Re-landing results after adding missing png's to the test.

  • fast/replaced/resources/1x1-blue.png: Added.
  • fast/replaced/resources/square-blue-100x100.png: Added.
  • fast/replaced/maxheight-percent-expected.checksum: Added.
  • fast/replaced/maxheight-percent-expected.png: Added.
  • fast/replaced/maxheight-percent-expected.txt:
  • fast/replaced/maxheight-pxs-expected.checksum: Added.
  • fast/replaced/maxheight-pxs-expected.png: Added.
  • fast/replaced/maxheight-pxs-expected.txt:
  • fast/replaced/maxwidth-percent-expected.checksum: Added.
  • fast/replaced/maxwidth-percent-expected.png: Added.
  • fast/replaced/maxwidth-percent-expected.txt:
  • fast/replaced/maxwidth-pxs-expected.checksum: Added.
  • fast/replaced/maxwidth-pxs-expected.png: Added.
  • fast/replaced/maxwidth-pxs-expected.txt:
  • fast/replaced/minheight-percent-expected.checksum: Added.
  • fast/replaced/minheight-percent-expected.png: Added.
  • fast/replaced/minheight-percent-expected.txt:
  • fast/replaced/minheight-pxs-expected.checksum: Added.
  • fast/replaced/minheight-pxs-expected.png: Added.
  • fast/replaced/minheight-pxs-expected.txt:
  • fast/replaced/minwidth-percent-expected.checksum: Added.
  • fast/replaced/minwidth-percent-expected.png: Added.
  • fast/replaced/minwidth-percent-expected.txt:
  • fast/replaced/minwidth-pxs-expected.checksum: Added.
  • fast/replaced/minwidth-pxs-expected.png: Added.
  • fast/replaced/minwidth-pxs-expected.txt:

Feb 24, 2006:

7:48 PM Changeset in webkit [12988] by antti
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Hyatt.

  • fast/block/float/multiple-float-positioning-expected.checksum: Added.
  • fast/block/float/multiple-float-positioning-expected.png: Added.
  • fast/block/float/multiple-float-positioning-expected.txt: Added.
  • fast/block/float/multiple-float-positioning.html: Added.
7:46 PM Changeset in webkit [12987] by antti
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Test: fast/block/float/multiple-float-positioning.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionNewFloats): Correct iteration of the float list
6:57 PM Changeset in webkit [12986] by justing
  • 9 edits in trunk

LayoutTests:

Reviewed by justin


<http://bugzilla.opendarwin.org/show_bug.cgi?id=6933>
Selection extends beyond focus ring for some contentEditable divs

  • editing/selection/extend-by-word-002-expected.checksum:
  • editing/selection/extend-by-word-002-expected.png:
  • editing/selection/select-all-001-expected.checksum:
  • editing/selection/select-all-001-expected.png:
  • editing/selection/select-all-002-expected.checksum:
  • editing/selection/select-all-002-expected.png:

WebCore:

<http://bugzilla.opendarwin.org/show_bug.cgi?id=6933>
Selection extends beyond focus ring for some contentEditable divs

Reviewed by justin

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isSelectionRoot): Have root editable elements paint their own selection gaps.
6:25 PM Changeset in webkit [12985] by darin
  • 4 edits
    2 adds in trunk

LayoutTests:

  • test <rdar://problem/4456287> REGRESSION: assertion failure at mypage.apple.com in WebCore::TimerBase::nextFireInterval() const + 100 (Timer.cpp:188)
  • fast/dom/Window/redirect-with-timer.html: Added.
  • fast/dom/Window/redirect-with-timer-expected.txt: Added.

WebCore:

Reviewed by Maciej.

  • fix <rdar://problem/4456287> REGRESSION: assertion failure at mypage.apple.com in WebCore::TimerBase::nextFireInterval() const + 100 (Timer.cpp:188)

Test: fast/dom/Window/redirect-with-timer.html

  • platform/Timer.h: Made isActive no longer inline. Added inHeap function.
  • platform/Timer.cpp: Changed assertions to use inHeap function for clarity. (WebCore::TimerBase::isActive): Return true for timers that are ready to fire. They have a next fire time of 0, but they should still be considered active. (WebCore::TimerBase::checkConsistency): Correct the consistency check. The new rule is that timers with a next fire time of 0 are not in the heap, and all other timers are.
5:07 PM Changeset in webkit [12984] by justing
  • 58 edits in trunk

LayoutTests:

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7245>
caret does not display at the end of some lines in contenteditable divs

Reviewed by justin

  • editing/deleting/delete-block-merge-contents-018-expected.txt:
  • editing/deleting/delete-block-merge-contents-021-expected.txt:
  • editing/deleting/delete-line-end-ws-001-expected.txt:
  • editing/deleting/delete-line-end-ws-002-expected.txt:
  • editing/deleting/forward-delete-expected.txt:
  • editing/execCommand/boldSelection-expected.txt:
  • editing/execCommand/italicizeByCharacter-expected.txt:
  • editing/execCommand/modifyForeColorByCharacter-expected.txt:
  • editing/execCommand/print-expected.txt:
  • editing/execCommand/selectAll-expected.txt:
  • editing/execCommand/strikethroughSelection-expected.txt:
  • editing/inserting/insert-div-019-expected.txt:
  • editing/inserting/insert-div-027-expected.txt:
  • editing/inserting/typing-003-expected.txt:
  • editing/pasteboard/paste-text-012-expected.txt:
  • editing/pasteboard/paste-text-013-expected.txt:
  • editing/pasteboard/paste-text-014-expected.txt:
  • editing/selection/extend-by-character-003-expected.txt:
  • editing/selection/extend-by-character-005-expected.txt:
  • editing/selection/extend-by-word-002-expected.checksum:
  • editing/selection/extend-by-word-002-expected.png:
  • editing/selection/extend-by-word-002-expected.txt:
  • editing/selection/move-by-character-003-expected.txt:
  • editing/selection/move-by-character-005-expected.txt:
  • editing/selection/select-all-001-expected.txt:
  • editing/selection/select-all-002-expected.checksum:
  • editing/selection/select-all-002-expected.png:
  • editing/selection/select-all-002-expected.txt:
  • editing/selection/select-all-003-expected.txt:
  • editing/style/create-block-for-style-001-expected.txt:
  • editing/style/create-block-for-style-002-expected.txt:
  • editing/style/create-block-for-style-003-expected.txt:
  • editing/style/create-block-for-style-004-expected.txt:
  • editing/style/create-block-for-style-005-expected.txt:
  • editing/style/create-block-for-style-006-expected.txt:
  • editing/style/create-block-for-style-007-expected.txt:
  • editing/style/create-block-for-style-008-expected.txt:
  • editing/style/create-block-for-style-009-expected.txt:
  • editing/style/create-block-for-style-010-expected.txt:
  • editing/style/create-block-for-style-011-expected.txt:
  • editing/style/create-block-for-style-012-expected.txt:
  • editing/style/create-block-for-style-013-expected.txt:
  • editing/style/relative-font-size-change-001-expected.txt:
  • editing/style/relative-font-size-change-002-expected.txt:
  • editing/style/relative-font-size-change-003-expected.txt:
  • editing/style/relative-font-size-change-004-expected.txt:
  • fast/clip/outline-overflowClip-expected.txt:
  • fast/overflow/overflow-focus-ring-expected.checksum:
  • fast/overflow/overflow-focus-ring-expected.png:
  • fast/overflow/overflow-focus-ring-expected.txt:
  • fast/text/justified-text-rect-expected.checksum:
  • fast/text/justified-text-rect-expected.png:
  • fast/text/justified-text-rect-expected.txt:
  • fast/text/justified-text-rect.html:

WebCore:

<http://bugzilla.opendarwin.org/show_bug.cgi?id=7245>
caret does not display at the end of some lines in contenteditable divs

Reviewed by justin

  • khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::setContentEditable):
  • page/Frame.cpp: (WebCore::Frame::applyEditingStyleToElement): (WebCore::Frame::removeEditingStyleFromElement):
2:48 PM Changeset in webkit [12983] by eseidel
  • 11 edits
    3 moves in trunk/WebCore

2006-02-24 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Move dom_qname to QualifiedName and dom_atomicstringlist to AtomicStringList.

  • WebCore+SVG/KDOMHeaders.h:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • css/css_base.h:
  • dom/AtomicStringList.h: Added. (WebCore::AtomicStringList::AtomicStringList):
  • dom/QualifiedName.cpp: Added.
  • dom/QualifiedName.h: Added.
  • dom/dom_atomicstringlist.h: Removed.
  • dom/dom_elementimpl.h:
  • dom/dom_qname.cpp: Removed.
  • dom/dom_qname.h: Removed.
  • editing/RemoveNodeAttributeCommand.h:
  • editing/SetNodeAttributeCommand.h:
  • khtml/html/htmlnames.h:
  • khtml/html/htmltokenizer.h:
  • ksvg2/scripts/make_names.pl: update for new headers
2:36 PM Changeset in webkit [12982] by eseidel
  • 6 edits in trunk/WebCore

2006-02-24 Eric Seidel <eseidel@apple.com>

Reviewed by beth.

Made a few methods on frame pure virtual.
Added a bunch of stub functions for win32 linking.

  • bridge/mac/MacFrame.h:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::print): (WebCore::MacFrame::canUndo): (WebCore::MacFrame::canRedo): (WebCore::MacFrame::canPaste):
  • bridge/win/FrameWin.h:
  • page/Frame.h:
  • platform/win/TemporaryLinkStubs.cpp: (QTextEdit::sizeWithColumnsAndRows): (QLineEdit::maxLength): (QPainter::drawEllipse): (QTextEdit::setLineHeight): (QPainter::beginTransparencyLayer): (QLineEdit::selectedText): (Widget::setIsSelected): (QPainter::paintingDisabled): (QFontMetrics::selectionRectForText): (QTextEdit::getCursorPosition): (QSlider::QSlider): (WebCore::crossCursor): (WebCore::handCursor): (WebCore::moveCursor): (WebCore::iBeamCursor): (WebCore::waitCursor): (WebCore::helpCursor): (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor):
2:07 PM Changeset in webkit [12981] by ggaren
  • 5 edits
    16 adds in trunk

LayoutTests:

Reviewed by Hyatt.

-tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=5146

  • fast/replaced/maxheight-percent.html: Added.
  • fast/replaced/maxheight-pxs.html: Added.
  • fast/replaced/maxwidth-percent.html: Added.
  • fast/replaced/maxwidth-pxs.html: Added.
  • fast/replaced/minheight-percent.html: Added.
  • fast/replaced/minheight-pxs.html: Added.
  • fast/replaced/minwidth-percent.html: Added.
  • fast/replaced/minwidth-pxs.html: Added.
  • fast/replaced/resources/1x1-blue.png: Added.
  • fast/replaced/resources/square-blue-100x100.png: Added.

WebCore:

Reviewed by Hyatt, tweaked and landed by ggaren.

This patch is a port and adaptation of Allan Sandfeld Jensen's (carewolf)
patch of http://bugs.kde.org/show_bug.cgi?id=120107 with the needed
modifications to suit the Webcore tree. Makes images respect min/max
sizes and their intrinsic aspect ratios at the same time according to
CSS 2.1 (http://www.w3.org/TR/CSS21/visudet.html#min-max-widths).

Test: fast/replaced/maxheight-percent.html
Test: fast/replaced/maxheight-pxs.html
Test: fast/replaced/maxwidth-percent.html
Test: fast/replaced/maxwidth-pxs.html
Test: fast/replaced/minheight-percent.html
Test: fast/replaced/minheight-pxs.html
Test: fast/replaced/minwidth-percent.html
Test: fast/replaced/minwidth-pxs.html

  • rendering/render_box.cpp: (WebCore::RenderBox::calcReplacedWidth): (WebCore::RenderBox::calcReplacedWidthUsing): (WebCore::RenderBox::calcReplacedHeight): (WebCore::RenderBox::calcReplacedHeightUsing): Calculate percent heights correctly
  • rendering/render_image.cpp: Respect aspect ratios and calculate max/min (WebCore::RenderImage::calcReplacedWidth): (WebCore::RenderImage::calcReplacedHeight): (WebCore::RenderImage::calcAspectRatioWidth): Added (WebCore::RenderImage::calcAspectRatioHeight): Added (WebCore::RenderImage::calcMinMaxWidth): Added
  • rendering/render_image.h:
1:47 PM Changeset in webkit [12980] by vicki
  • 1 edit
    2 adds in trunk/WebCore
  • add missing resources for manual-tests/scrolling-nestedframesets.html
  • manual-tests/resources/testframe-link_text.html: Added.
  • manual-tests/resources/testframeset.html: Added.
1:31 PM Changeset in webkit [12979] by vicki
  • 1 edit
    1 add in trunk/WebCore
  • test case for <rdar://problem/4394910> calling Javascript window.close() does not trigger onbeforeunload event
  • manual-tests/onbeforeunload-close_with_javascript.html: Added.
1:25 PM Changeset in webkit [12978] by eseidel
  • 3 edits in trunk/WebCore

2006-02-24 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Add Path stubs for Win32 build.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp: (Path::Path): (Path::~Path): (Path::operator=): (Path::contains): (Path::translate): (Path::boundingRect):
1:13 PM Changeset in webkit [12977] by hyatt
  • 26 edits in trunk/WebCore

In preparation for the elimination of QFont and QFontMetrics, rename methods on RenderStyle. htmlFont() becomes simply
font(). The old font() method turns into qfont(). Also added a helper for obtaining the fontDescription() directly from
the RenderStyle (without first obtaining the htmlFont()).

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (-[DOMElement _font]):
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::attributedString): (WebCore::MacFrame::fontForSelection): (WebCore::MacFrame::fontAttributesForSelectionStart):
  • css/css_computedstyle.cpp: (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
  • css/css_valueimpl.cpp: (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::styleForElement): (WebCore::CSSStyleSelector::pseudoStyleForElement): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::checkForTextSizeAdjust): (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::recalcStyle):
  • editing/visible_text.cpp: (khtml::TextIterator::exitNode):
  • ksvg2/svg/SVGLengthImpl.cpp: (SVGLengthImpl::updateValue):
  • kwq/KWQAccObject.mm: (AXAttributeStringSetStyle):
  • rendering/InlineTextBox.cpp: (khtml::InlineTextBox::paint): (khtml::InlineTextBox::offsetForPosition):
  • rendering/RenderText.cpp: (WebCore::RenderText::shouldUseMonospaceCache): (WebCore::RenderText::font): (WebCore::RenderText::width): (WebCore::RenderText::htmlFont):
  • rendering/bidi.cpp: (khtml::RenderBlock::tabWidth): (khtml::RenderBlock::checkLinesForTextOverflow):
  • rendering/render_br.cpp: (WebCore::RenderBR::lineHeight):
  • rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::layoutVerticalBox):
  • rendering/render_flow.cpp: (WebCore::RenderFlow::lineHeight):
  • rendering/render_form.cpp: (WebCore::RenderFormElement::setStyle): (WebCore::RenderFormElement::addIntrinsicMarginsIfAllowed):
  • rendering/render_image.cpp: (WebCore::RenderImage::paint):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::paintDecorations): (WebCore::EllipsisBox::paint):
  • rendering/render_list.cpp: (RenderListItem::getAbsoluteRepaintRect): (RenderListMarker::paint):
  • rendering/render_object.cpp: (WebCore::RenderObject::lineHeight):
  • rendering/render_object.h: (WebCore::RenderObject::font):
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::setStyle):
  • rendering/render_style.h: (khtml::RenderStyle::font): (khtml::RenderStyle::fontDescription): (khtml::RenderStyle::qfont):
  • rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::setFontFromControlSize):
11:49 AM Changeset in webkit [12976] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • add link stubs for symbols only referenced from the link stubs file
  • platform/win/TemporaryLinkStubs.cpp: (KWQFileButton::focusPolicy): (QLineEdit::checksDescendantsForFocus): (KWQFileButton::baselinePosition): (QSlider::~QSlider): (QListBox::~QListBox): (KWQFileButton::frameGeometry): (KWQFileButton::~KWQFileButton): (QTextEdit::focusPolicy): (QSlider::focusPolicy): (QListBox::setEnabled): (QListBox::checksDescendantsForFocus): (QListBox::focusPolicy): (QLineEdit::baselinePosition): (QSlider::sizeHint): (QLineEdit::~QLineEdit): (QTextEdit::~QTextEdit): (QTextEdit::checksDescendantsForFocus): (QLineEdit::focusPolicy): (QScrollBar::~QScrollBar):
11:44 AM Changeset in webkit [12975] by mjs
  • 5 edits in trunk/WebCore

Rubber stamped by Eric.

  • fix up font.h inclues to be Font.h to fix build.
  • css/css_computedstyle.cpp:
  • css/css_valueimpl.cpp:
  • platform/Font.cpp:
  • rendering/render_style.h:
11:28 AM Changeset in webkit [12974] by eseidel
  • 2 edits in trunk/WebCore

2006-02-24 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Fix mac build by changing constants to an enum.

  • khtml/dom/dom2_events.h: (DOM::KeyboardEvent::):
11:19 AM Changeset in webkit [12973] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-24 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Make DumpRenderTree link against icu.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
11:15 AM Changeset in webkit [12972] by hyatt
  • 4 edits
    2 moves in trunk/WebCore

Move rendering/font to platform/Font.

Reviewed by mjs

  • WebCore.xcodeproj/project.pbxproj:
  • css/cssstyleselector.cpp:
  • platform/Font.cpp: Added.
  • platform/Font.h: Added.
  • rendering/font.cpp: Removed.
  • rendering/font.h: Removed.
  • rendering/render_theme_mac.mm:
11:11 AM Changeset in webkit [12971] by eseidel
  • 2 edits in trunk/WebCore

2006-02-24 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Remove delcarations causing duplicate symbols on win32.

  • khtml/dom/dom2_events.cpp:
11:02 AM Changeset in webkit [12970] by eseidel
  • 2 edits in trunk/WebCore

2006-02-24 Eric Seidel <eseidel@apple.com>

  • bridge/win/FrameWin.cpp: fix line endings
10:54 AM Changeset in webkit [12969] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-24 Eric Seidel <eseidel@apple.com>

Reviewed by mjs.

Make DumpRenderTree link against libxml, etc.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
10:36 AM Changeset in webkit [12968] by eseidel
  • 2 edits in trunk/WebCore

2006-02-24 Eric Seidel <eseidel@apple.com>

Reviewed by beth.

Removed WebCore
prefixes added using namespace WebCore, fixes win32 build.
  • platform/win/TemporaryLinkStubs.cpp: (QPainter::save): (Widget::enableFlushDrawing): (QPainter::drawHighlightForText): (QTextEdit::textWithHardLineBreaks): (QPainter::setPen): (QPainter::selectedTextBackgroundColor): (QPainter::fontMetrics): (Widget::show): (QLineEdit::setWritingDirection): (KWQFileButton::sizeForCharacterWidth): (QTextEdit::sizeWithColumnsAndRows): (iBeamCursor): (QPainter::misspellingLineThickness): (westResizeCursor): (Widget::isEnabled): (northWestResizeCursor): (QPainter::drawEllipse): (southWestResizeCursor): (Widget::focusPolicy): (waitCursor): (QPainter::endTransparencyLayer): (ScrollView::addChild): (Widget::~Widget): (QListBox::sizeForNumberOfLines): (FrameView::updateBorder): (QPainter::drawLineForText): (QPainter::QPainter): (QComboBox::focusPolicy): (QPainter::drawImageAtPoint): (QPainter::clearShadow): (eastResizeCursor): (QFontMetrics::boundingRect): (QPainter::beginTransparencyLayer): (northEastResizeCursor): (Widget::frameGeometry): (QPainter::addFocusRingRect): (QPainter::restore): (Widget::setEnabled): (QPainter::font): (QPainter::pen): (crossCursor): (Widget::setIsSelected): (handCursor): (QLineEdit::text): (Widget::unlockDrawingFocus): (QPainter::paintingDisabled): (northResizeCursor): (Widget::lockDrawingFocus): (QPainter::drawLine): (QPainter::setBrush): (QPainter::drawText): (QLineEdit::sizeForCharacterWidth): (Cursor::~Cursor): (QFontMetrics::selectionRectForText): (southResizeCursor): (moveCursor): (FrameView::isFrameView): (helpCursor): (QTextEdit::setWritingDirection): (Widget::setDrawingAlpha): (southEastResizeCursor): (QPainter::drawScaledAndTiledImage): (QPainter::drawImage): (QComboBox::setWritingDirection): (QComboBox::sizeHint): (QPainter::drawRect): (QPainter::drawTiledImage): (QPainter::clearFocusRing): (Widget::Widget): (QTextEdit::text): (QPainter::drawImageInRect): (Widget::disableFlushDrawing): (QPainter::initFocusRing): (QPainter::drawLineForMisspelling): (QComboBox::frameGeometry): (QListBox::setWritingDirection): (ScrollView::updateContents):
8:24 AM Changeset in webkit [12967] by darin
  • 20 edits
    1 copy
    2 moves in trunk/WebCore

Reviewed by Hyatt.

  • moved QScrollView from kwq to platform directory
  • kwq/KWQScrollView.h: Removed.
  • kwq/KWQScrollView.mm: Removed.
  • platform/ScrollBarMode.h: Added. Just the enum for scroll bar mode.
  • platform/ScrollView.h: Added. The rest of the former QScrollView.
  • platform/mac/ScrollViewMac.mm: Added.
  • WebCore.xcodeproj/project.pbxproj: Updated.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • platform/win/TemporaryLinkStubs.cpp: Updated.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::createFrame):
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::init): (WebCore::HTMLFrameElementImpl::parseMappedAttribute):
  • page/Frame.cpp: (WebCore::Frame::scrollbarsVisible): Changed scrolling constants to use new names.
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::bodySetter): Use FrameView instead of QScrollView for a local variable.
  • khtml/html/html_baseimpl.h: Use ScrollBarMode instead of QScrollView::ScrollBarMode.
  • kwq/KWQListBox.h: Use WebCore::ScrollView instead of QScrollView and WebCore::ScrollBarMode instead of QScrollView::ScrollBarMode.
  • kwq/KWQTextEdit.h: Ditto.
  • kwq/KWQTextEdit.mm: (QTextEdit::setScrollBarModes): Ditto. (QTextEdit::focusPolicy): Ditto.
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): Use ScrollBarMode instead of QScrollView::ScrollBarMode. (WebCore::FrameView::FrameView): Remove mention of QScrollView. (WebCore::FrameView::resetScrollBars): Rename QScrollView to ScrollView. (WebCore::FrameView::applyOverflowToViewport): Use newly-named constants. (WebCore::FrameView::layout): Ditto. (WebCore::FrameView::setScrollBarsMode): Rename QScrollView to ScrollView. (WebCore::FrameView::setVScrollBarMode): Ditto. (WebCore::FrameView::setHScrollBarMode): Ditto. (WebCore::FrameView::restoreScrollBar): Ditto.
  • platform/mac/MouseEventMac.mm: (WebCore::positionForEvent): Fixed comment.
  • platform/mac/WheelEventMac.mm: (WebCore::positionForEvent): Ditto.
  • platform/mac/WidgetMac.mm: (WebCore::Widget::getOuterView): Ditto.
  • rendering/render_form.cpp: (WebCore::RenderTextArea::setStyle): Use ScrollBarMode instead of QScrollView::ScrollBarMode, and new constants.
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize): Changed to use an IntRect to pass to updateContents so we can remove the overload. (WebCore::RenderPart::updateWidgetPosition): Remove unnecessary of QScrollView.
  • rendering/render_layer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Use FrameView instead of QScrollView. (WebCore::RenderLayer::setHasHorizontalScrollbar): Ditto. (WebCore::RenderLayer::setHasVerticalScrollbar): Ditto.
4:59 AM Changeset in webkit [12966] by andersca
  • 2 edits in trunk/WebKitTools

2006-02-24 Mitz Pettel <opendarwin.org@mitzpettel.com>

Reviewed and landed by Anders.


Prevent rendering to the offscreen window. -[NSWindow displayIfNeeded] was
getting called from the run loop, making the view render each test and thus slowing
down the tests.

  • DumpRenderTree/DumpRenderTree.m: (main): Set the offscreen window to not autodisplay.
1:14 AM Changeset in webkit [12965] by eseidel
  • 2 edits in trunk/WebCore

2006-02-24 Eric Seidel <eseidel@apple.com>

Reviewed by anders.

Fix the win32 build.

  • page/Frame.cpp: (WebCore::Frame::adjustPageHeight): (WebCore::Frame::forceLayoutWithPageWidthRange):
1:10 AM Changeset in webkit [12964] by ap
  • 2 edits
    60 adds in trunk/LayoutTests

Reviewed by Darin.

  • http/conf/httpd.conf: Enable send-as-is handler, required by the tests.
  • http/tests/xmlhttprequest/web-apps: Added (recursively).
12:01 AM Changeset in webkit [12963] by hyatt
  • 17 edits
    1 add in trunk/WebCore

Rename FontDef to FontDescription and move it into the platform directory.

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::attributedString):
  • css/css_computedstyle.cpp: (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
  • css/css_valueimpl.cpp: (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::checkForTextSizeAdjust): (WebCore::CSSStyleSelector::checkForGenericFamilyChange): (WebCore::CSSStyleSelector::setFontSize):
  • css/cssstyleselector.h:
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::recalcStyle):
  • editing/visible_text.cpp: (khtml::TextIterator::exitNode):
  • platform/FontDescription.h: Added. (WebCore::FontDescription::): (WebCore::FontDescription::FontDescription): (WebCore::FontDescription::operator!=): (WebCore::FontDescription::family): (WebCore::FontDescription::firstFamily): (WebCore::FontDescription::specifiedSize): (WebCore::FontDescription::computedSize): (WebCore::FontDescription::italic): (WebCore::FontDescription::computedPixelSize): (WebCore::FontDescription::smallCaps): (WebCore::FontDescription::isAbsoluteSize): (WebCore::FontDescription::weight): (WebCore::FontDescription::genericFamily): (WebCore::FontDescription::usePrinterFont): (WebCore::FontDescription::setFamily): (WebCore::FontDescription::setComputedSize): (WebCore::FontDescription::setSpecifiedSize): (WebCore::FontDescription::setItalic): (WebCore::FontDescription::setSmallCaps): (WebCore::FontDescription::setIsAbsoluteSize): (WebCore::FontDescription::setWeight): (WebCore::FontDescription::setGenericFamily): (WebCore::FontDescription::setUsePrinterFont): (WebCore::FontDescription::operator==):
  • rendering/RenderText.cpp: (WebCore::RenderText::widthFromCache): (WebCore::RenderText::trimmedMinMaxWidth):
  • rendering/bidi.cpp: (khtml::RenderBlock::computeHorizontalPositionsForLine):
  • rendering/font.cpp: (khtml::Font::selectionRectForText): (khtml::Font::drawHighlightForText): (khtml::Font::drawText): (khtml::Font::update):
  • rendering/font.h: (WebCore::Font::Font): (WebCore::Font::operator==): (WebCore::Font::fontDescription): (WebCore::Font::isSmallCaps): (WebCore::Font::wordSpacing): (WebCore::Font::floatWidth): (WebCore::Font::checkSelectionPoint): (WebCore::Font::width):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally):
  • rendering/render_list.cpp: (RenderListItem::getAbsoluteRepaintRect):
  • rendering/render_style.h: (khtml::RenderStyle::wordSpacing): (khtml::RenderStyle::letterSpacing): (khtml::RenderStyle::setFontDescription): (khtml::RenderStyle::setWordSpacing): (khtml::RenderStyle::setLetterSpacing):
  • rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::setFontFromControlSize):

Feb 23, 2006:

11:16 PM Changeset in webkit [12962] by mjs
  • 6 edits in trunk/WebCore
  • fix build by making some pointless changes to files that Xcode doesn't rebuild otherwise
  • bindings/js/JSDOMCore.cpp:
  • bindings/js/JSDOMEvents.cpp:
  • dom/Element.idl:
  • dom/WheelEvent.idl:


  • add -Y 3 flag to linking; this makes the linker say what files reference unresolved symbols


  • WebCore.xcodeproj/project.pbxproj:
10:29 PM Changeset in webkit [12961] by darin
  • 2 edits in trunk/JavaScriptCore
  • try to fix buildbot failure
  • bindings/c/c_utility.cpp: Touch this file, which seems to not have been recompiled after additional inlining was introduced (Xcode bug?).
9:37 PM Changeset in webkit [12960] by darin
  • 2 edits in trunk/WebCore
  • try to fix Windows build
  • platform/win/TemporaryLinkStubs.cpp: Removed childX/Y stubs.
9:32 PM Changeset in webkit [12959] by darin
  • 2 edits
    4 deletes in trunk/WebCore
  • fix Windows build
  • platform/win/TemporaryLinkStubs.cpp: Removed QPalette-related stubs
  • remove unused forwarding headers
  • ForwardingHeaders/kurl.h: Removed.
  • ForwardingHeaders/qlist.h: Removed.
  • ForwardingHeaders/qregion.h: Removed.
  • ForwardingHeaders/qsortedlist.h: Removed.
9:23 PM Changeset in webkit [12958] by darin
  • 24 edits
    2 moves
    1 add
    4 deletes in trunk/WebCore

Reviewed by Maciej.

  • removed QPalette, QRegion, QPrinter
  • added Path to replace QRegion
  • removed unused QScrollView functions
  • ForwardingHeaders/qpalette.h: Removed.
  • kwq/KWQPalette.h: Removed.
  • kwq/KWQPalette.mm: Removed.
  • kwq/KWQPrinter.h: Removed.
  • kwq/KWQRegion.cpp: Removed.
  • kwq/KWQRegion.h: Removed.
  • platform/Path.h: Added. Replaces QRegion.
  • platform/cg: Added.
  • platform/cg/PathCG.cpp: Added.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for file changes.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bridge/mac/MacFrame.mm: Removed use of KWQPrinter.h. (WebCore::MacFrame::khtmlMouseMoveEvent): Removed use of viewport().
  • bridge/mac/WebCoreFrameBridge.mm: Removed use of KWQPrinter.h.
  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLAreaElementImpl::getRect): Replaced QRegion with Path. (WebCore::HTMLAreaElementImpl::getRegion): Ditto.
  • khtml/html/html_imageimpl.h: Ditto.
  • kwq/KWQPainter.mm: Removed use of QRegion.
  • page/Frame.cpp: (WebCore::Frame::~Frame): Removed use of viewport().
  • page/FrameView.cpp: (WebCore::FrameView::FrameView): Ditto. (WebCore::FrameView::viewportMouseMoveEvent): Ditto.
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize): Ditto.
  • rendering/render_layer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Ditto.
  • kwq/KWQScrollView.h: Removed viewport(), hasVerticalScrollBar(), hasHorizontalScrollBar(), childX(), childY().
  • kwq/KWQScrollView.mm: Ditto.
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended): Removed use of QPalette that always yields white.
  • rendering/render_canvas.cpp: (WebCore::RenderCanvas::paintBoxDecorations): Ditto.
  • platform/Widget.h:
  • platform/mac/WidgetMac.mm: Removed palette() and setPalette().
  • kwq/KWQLineEdit.h: Replaced setPalette with setColors.
  • kwq/KWQLineEdit.mm: (QLineEdit::setColors): Replaced setPalette.
  • kwq/KWQTextEdit.h: Ditto.
  • kwq/KWQTextEdit.mm: (QTextEdit::setColors): Ditto.
  • rendering/render_form.cpp: (WebCore::RenderFormElement::updateFromElement): Removed call to setPalette. (WebCore::RenderLineEdit::updateFromElement): Added call to setColors. (WebCore::RenderTextArea::updateFromElement): Ditto.
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::paint): Removed use of childX and childY functions.
9:10 PM Changeset in webkit [12957] by mjs
  • 3 edits in trunk/WebCore

Reviewed by Darin.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • platform/KURL.cpp:
9:01 PM Changeset in webkit [12956] by mjs
  • 2 edits in trunk/WebCore
  • fix build (header name changed)
  • platform/mac/KURLMac.mm:
8:34 PM Changeset in webkit [12955] by mjs
  • 5 edits
    1 add in trunk/WebCore

Reviewed by Eric.

This gets rid of a couple hundred link errors.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • kwq/KWQFontMetrics.h:
  • kwq/KWQSignal.h: (KWQSignal::KWQSignal):
  • platform/win/TemporaryLinkStubs.cpp: Added. (notImplemented): (QLineEdit::selectAll): (WebCore::QPainter::save): (WebCore::Widget::enableFlushDrawing): (WebCore::QPainter::drawHighlightForText): (QFont::setPrinterFont): (QTextEdit::textWithHardLineBreaks): (QLineEdit::cursorPosition): (WebCore::QPainter::setPen): (WebCore::QPainter::selectedTextBackgroundColor): (WebCore::QPainter::fontMetrics): (WebCore::Widget::show): (QFont::setItalic): (QSlider::setValue): (QLineEdit::addSearchResult): (KWQFileButton::click): (QLineEdit::setWritingDirection): (KWQFileButton::sizeForCharacterWidth): (QTextEdit::sizeWithColumnsAndRows): (WebCore::iBeamCursor): (QComboBox::clear): (WebCore::QPainter::misspellingLineThickness): (QLineEdit::maxLength): (WebCore::westResizeCursor): (WebCore::Widget::isEnabled): (WebCore::northWestResizeCursor): (QTextEdit::selectionEnd): (QFont::determinePitch): (QTextEdit::setScrollBarModes): (WebCore::QPainter::drawEllipse): (WebCore::southWestResizeCursor): (QTextEdit::setReadOnly): (QListBox::appendItem): (WebCore::Widget::focusPolicy): (QTextEdit::selectAll): (WebCore::waitCursor): (WebCore::QPainter::endTransparencyLayer): (QScrollView::addChild): (QTextEdit::setDisabled): (QScrollBar::scroll): (WebCore::Widget::~Widget): (QListBox::sizeForNumberOfLines): (QScrollView::resizeContents): (QLineEdit::selectionStart): (QLineEdit::QLineEdit): (WebCore::FrameView::updateBorder): (QLineEdit::hasSelectedText): (QListBox::doneAppendingItems): (QScrollView::inWindow): (QScrollBar::setValue): (QTextEdit::hasSelectedText): (QTextEdit::selectionStart): (QFont::setWeight): (QScrollView::scrollXOffset): (QListBox::isSelected): (QLineEdit::setReadOnly): (WebCore::QPainter::drawLineForText): (QObject::disconnect): (WebCore::QPainter::QPainter): (QComboBox::~QComboBox): (QComboBox::focusPolicy): (WebCore::QPainter::drawImageAtPoint): (WebCore::QPainter::clearShadow): (QTextEdit::setLineHeight): (QMouseEvent::QMouseEvent): (WebCore::eastResizeCursor): (QScrollBar::setKnobProportion): (QFontMetrics::boundingRect): (QTextEdit::setSelectionStart): (WebCore::QPainter::beginTransparencyLayer): (WebCore::northEastResizeCursor): (WebCore::Widget::frameGeometry): (QListBox::setSelected): (WebCore::QPainter::addFocusRingRect): (QTextEdit::setCursorPosition): (WebCore::QPainter::restore): (QFontMetrics::width): (WebCore::Widget::setEnabled): (QTextEdit::setSelectionEnd): (QComboBox::populate): (QScrollView::setStaticBackground): (WebCore::QPainter::font): (QTextEdit::setAlignment): (QLineEdit::setCursorPosition): (WebCore::Widget::palette): (WebCore::QPainter::pen): (QFontMetrics::descent): (QListBox::QListBox): (QFontMetrics::ascent): (QLineEdit::selectedText): (WebCore::crossCursor): (WebCore::Widget::setIsSelected): (WebCore::handCursor): (QLineEdit::text): (WebCore::Widget::unlockDrawingFocus): (QLineEdit::setLiveSearch): (WebCore::QPainter::paintingDisabled): (WebCore::northResizeCursor): (QComboBox::QComboBox): (QSlider::setMaxValue): (WebCore::Widget::lockDrawingFocus): (WebCore::QPainter::drawLine): (WebCore::QPainter::setBrush): (QTextEdit::setSelectionRange): (WebCore::QPainter::drawText): (QScrollView::scrollPointRecursively): (QLineEdit::sizeForCharacterWidth): (WebCore::Cursor::~Cursor): (QFontMetrics::selectionRectForText): (WebCore::southResizeCursor): (QScrollView::suppressScrollBars): (QFontMetrics::checkSelectionPoint): (QTextEdit::getCursorPosition): (WebCore::moveCursor): (WebCore::FrameView::isFrameView): (QScrollBar::setSteps): (QLineEdit::setMaxLength): (QComboBox::baselinePosition): (QComboBox::appendItem): (WebCore::helpCursor): (QTextEdit::setWritingDirection): (WebCore::Widget::setDrawingAlpha): (QSlider::QSlider): (WebCore::southEastResizeCursor): (QScrollView::setVScrollBarMode): (WebCore::QPainter::drawScaledAndTiledImage): (QScrollView::scrollYOffset): (WebCore::QPainter::drawImage): (QComboBox::setCurrentItem): (QFontMetrics::height): (QComboBox::setWritingDirection): (QScrollView::setScrollBarsMode): (QComboBox::sizeHint): (WebCore::QPainter::drawRect): (QFont::setPixelSize): (QLineEdit::setSelection): (QLineEdit::setMaxResults): (QListBox::clear): (QLineEdit::edited): (WebCore::QPainter::drawTiledImage): (WebCore::QPainter::clearFocusRing): (WebCore::Widget::Widget): (QTextEdit::text): (WebCore::QPainter::drawImageInRect): (WebCore::Widget::disableFlushDrawing): (WebCore::QPainter::initFocusRing): (QSlider::setMinValue): (QTextEdit::setWordWrap): (WebCore::QPainter::drawLineForMisspelling): (QSlider::value): (QListBox::setSelectionMode): (QFontMetrics::lineSpacing): (QLineEdit::setEdited): (QComboBox::frameGeometry): (QListBox::setWritingDirection): (QLineEdit::setAlignment): (QScrollView::updateContents): (QFontMetrics::floatWidth): (QScrollView::setHScrollBarMode):
7:52 PM Changeset in webkit [12954] by mjs
  • 17 edits
    3 copies in trunk/WebCore

Reviewed by Eric.


  • WebCore.xcodeproj/project.pbxproj:
  • css/css_ruleimpl.cpp:
  • css/cssparser.cpp:
  • css/cssstyleselector.cpp:
  • dom/DocumentImpl.h:
  • khtml/html/html_baseimpl.cpp:
  • khtml/html/html_documentimpl.cpp:
  • khtml/html/html_headimpl.cpp:
  • khtml/xbl/xbl_binding.cpp:
  • ksvg2/svg/SVGDocumentImpl.cpp:
  • kwq/KWQTextCodec.cpp: (QTextCodec::codecForName): (QTextCodec::utf8Codec): (QTextCodec::codecForNameEightBitOnly): (QTextCodec::codecForLocale): (QTextCodec::name): (QTextCodec::makeDecoder):
  • kwq/KWQTextCodec.h:
  • loader/CachedObject.cpp:
  • loader/DocLoader.cpp:
  • page/Frame.h:
  • platform/KURL.cpp: Added. (KURL::decode_string): (encodeRelativeString):
  • platform/KURL.h: Added.
  • platform/mac/KURLMac.mm: Added. (KURL::getNSURL):
  • xml/xmlhttprequest.h:
7:08 PM Changeset in webkit [12953] by darin
  • 97 edits
    5 copies
    5 moves
    2 adds
    5 deletes in trunk/WebCore

Reviewed by John Sullivan.

  • moved QMouseEvent, QKeyEvent, QWheelEvent, and "Foundation extras" from kwq to platform directory
  • moved history function from kwq to bridge directory
  • eliminated QEvent, MousePressEvent, MouseDoubleClickEvent, MouseMoveEvent, MoveReleaseEvent, and DrawContents classes
  • merged NodeImpl::MouseEvent and the MouseEvent from khtml_events.h into a single class in the page directory
  • broke khtmllayout.h out into a file for the Length structure in the css directory and a file for the GapRects structure in the rendering directory
  • redid the Length structure to work more portably by not relying on bitfield layout and improve the names to no longer explicitly mention "width"
  • reduced use of QGuardedPtr and other uses of the QObject "destroyed" signal
  • ForwardingHeaders/kparts: Removed.
  • ForwardingHeaders/qevent.h: Removed.
  • khtml/khtml_events.cpp: Removed.
  • khtml/khtml_events.h: Removed.
  • khtml/misc/khtmllayout.h: Removed.
  • kwq/KWQEvent.h: Removed.
  • kwq/KWQEvent.mm: Removed.
  • kwq/KWQFoundationExtras.h: Removed.
  • kwq/KWQKHistoryProvider.mm: Removed.
  • kwq/KWQKPartsHistoryProvider.h: Removed.
  • bridge/History.h: Added.
  • bridge/mac/HistoryMac.mm: Added.
  • css/Length.h: Added.
  • page/MouseEventWithHitTestResults.h: Added.
  • platform/KeyEvent.h: Added.
  • platform/MouseEvent.h: Added.
  • platform/WheelEvent.h: Added.
  • platform/mac/FoundationExtras.h: Added.
  • platform/mac/KeyEventMac.mm: Added.
  • platform/mac/MouseEventMac.mm: Added.
  • platform/mac/WheelEventMac.mm: Added.
  • rendering/GapRects.h: Added.
  • WebCore.xcodeproj/project.pbxproj: Updated for above changes.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Updated for above changes.
  • bridge/mac/MacFrame.h: Removed unused parameters from urlSelected functions. Replaced MouseEvent, MousePressEvent, MouseMoveEvent, and MouseReleaseEvent with MouseEventWithHitTestResults.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::urlSelected): Removed unused parameters. (WebCore::MacFrame::wheelEvent): Changed to use WheelEvent. (WebCore::MacFrame::keyEvent): Changed to use KeyEvent. (WebCore::MacFrame::khtmlMousePressEvent): Changed parameter type. (WebCore::MacFrame::khtmlMouseMoveEvent): Ditto. (WebCore::MacFrame::khtmlMouseReleaseEvent): Ditto. (WebCore::MacFrame::passSubframeEventToSubframe): Ditto. (WebCore::MacFrame::mouseDown): Changed to use MouseEvent. (WebCore::MacFrame::mouseDragged): Ditto. (WebCore::MacFrame::mouseUp): Ditto. (WebCore::MacFrame::mouseMoved): Ditto. (WebCore::MacFrame::sendContextMenuEvent): Ditto.
  • css/csshelper.h: Removed a bunch of unused declarations.
  • dom/DocumentImpl.h:
  • dom/DocumentImpl.cpp: (WebCore::DocumentImpl::prepareMouseEvent): Changed to take a MouseEvent and return a MouseEventWithHitTestResults. (WebCore::DocumentImpl::defaultEventHandler): Changed to use KeyEvent.
  • dom/NodeImpl.h: Removed NodeImpl::MouseEvent and NodeImpl::MouseEventType.
  • dom/NodeImpl.cpp: (WebCore::NodeImpl::dispatchMouseEvent): Changed to always get the type and detail values from the caller, never from the event. Changed to use MouseEvent. (WebCore::NodeImpl::dispatchKeyEvent): Changed to use KeyEvent. (WebCore::NodeImpl::dispatchWheelEvent): Changed to use WheelEvent.
  • dom/dom2_eventsimpl.h:
  • dom/dom2_eventsimpl.cpp: (WebCore::KeyboardEventImpl::KeyboardEventImpl): Changed to use KeyEvent. (WebCore::KeyboardEventImpl::charCode): Ditto.
  • dom/dom_elementimpl.h: Removed unused mouseEventHandler function.
  • khtml/ecma/domparser.h: Use RefPtr instead of QGuardedPtr to hold the reference to the document.
  • khtml/ecma/kjs_proxy.h: (WebCore::KJSProxyImpl::haveInterpreter): Added. For use in the Frame destructor so we can get an existing KJS::Window object without creating a new interpreter and window object.
  • khtml/ecma/kjs_window.h: Merged WindowQObject into Window. Changed all the guarded pointers to Frame to use plain old pointers that are cleared by the Frame explicitly (by the function disconnectFrame). Made the pointers to all the sub-objects of KJS::Window be mutable so we don't have to const_cast in the functions to get (and lazily create) them.
  • khtml/ecma/kjs_window.cpp: (KJS::DOMWindowTimer::DOMWindowTimer): Use Window* instead of WindowQObject*. (KJS::History::disconnectFrame): Added. Clears m_frame. (KJS::FrameArray::disconnectFrame): Added. Clears m_frame. (KJS::Window::Window): Removed code to create a WindowQObject. (KJS::Window::~Window): Removed code to delete a WindowQObject. (KJS::Window::location): Remove now-unneeded const_cast. (KJS::Window::selection): Ditto. (KJS::Window::locationbar): Ditto. (KJS::Window::menubar): Ditto. (KJS::Window::personalbar): Ditto. (KJS::Window::statusbar): Ditto. (KJS::Window::toolbar): Ditto. (KJS::Window::scrollbars): Ditto. (KJS::Window::getValueProperty): Update since m_frame is now a raw pointer. (KJS::Window::getOwnPropertySlot): Ditto. (KJS::Window::toBoolean): Ditto. (KJS::Window::scheduleClose): Remove assert that WindowQObject* is not null. (KJS::Window::isSafeScript): Update since m_frame is now a raw pointer. (KJS::Window::clear): Remove code to delete a WindowQObject. Added a call to clearAllTimeouts instead. (KJS::Window::clearAllTimeouts): Added. Does equivalent of the WindowQObject destructor. (KJS::Window::installTimeout): Moved to Window from WindowQObject. (KJS::Window::pauseTimeouts): Ditto. (KJS::Window::resumeTimeouts): Ditto. (KJS::Window::clearTimeout): Ditto. (KJS::Window::timerFired): Ditto. (KJS::Window::disconnectFrame): Added. Sets all the frame pointers to 0. (KJS::FrameArray::getOwnPropertySlot): Update since m_frame is now a raw pointer. (KJS::Location::getOwnPropertySlot): Ditto. (KJS::Location::put): Ditto. (KJS::Selection::getOwnPropertySlot): Ditto. (KJS::BarInfo::getOwnPropertySlot): Ditto.
  • khtml/html/html_baseimpl.h: Forward-declare Length instead of including khtmllayout.h.
  • khtml/html/html_imageimpl.h: Ditto.
  • khtml/html/html_inlineimpl.cpp: (WebCore::HTMLAnchorElementImpl::defaultEventHandler): Changed to use KeyEvent and removed the code to extract the button and state from the DOM even to pass to urlSelected.
  • ksvg2/svg/SVGAElementImpl.cpp: (SVGAElementImpl::defaultEventHandler): Ditto.
  • khtml/html/htmltokenizer.cpp: (WebCore::HTMLTokenizer::timerFired): Change to use a RefPtr instead of a QGuardedPtr.
  • khtml/misc/helper.h:
  • khtml/misc/helper.cpp: Removed printpainter and setPrintPainter.
  • ksvg2/svg/SVGDocumentImpl.h:
  • ksvg2/svg/SVGDocumentImpl.cpp: (WebCore::SVGDocumentImpl::dispatchKeyEvent): Change to use KeyEvent.
  • kwq/KWQComboBox.mm: (-[KWQPopUpButton becomeFirstResponder]): (-[KWQPopUpButton resignFirstResponder]):
  • kwq/KWQFileButton.mm: (KWQFileButton::focusChanged):
  • kwq/KWQListBox.mm: (-[KWQTableView becomeFirstResponder]): (-[KWQTableView resignFirstResponder]):
  • kwq/KWQSlider.mm: (-[KWQSlider becomeFirstResponder]): (-[KWQSlider resignFirstResponder]):
  • kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]): (-[KWQTextAreaTextView resignFirstResponder]):
  • kwq/KWQTextField.mm: (-[KWQTextFieldController setHasFocus:]): Updated to use new eventFilterFocusIn/Out instead of the general purpose eventFilter function. This allows us to remove QEvent and the focus events.
  • kwq/KWQNamespace.h: Removed ButtonState.
  • kwq/KWQObject.h:
  • kwq/KWQObject.cpp: Replaced eventFilter function with eventFilterFocusIn and eventFilterFocusOut, allowing us to remove QEvent. Removed event function.
  • kwq/KWQSlot.cpp: (KWQSlot::KWQSlot): Removed the parentDestroyed slot. (KWQSlot::call): Ditto.
  • page/Frame.h:
  • page/Frame.cpp: (WebCore::UserStyleSheetLoader::UserStyleSheetLoader): Renamed from PartStyleSheetLoader. Removed a lot of unneeded null checks. Use a raw Frame pointer instead of a QGuardedPtr, and count on the Frame to delete us when it's being deleted. (WebCore::UserStyleSheetLoader::~UserStyleSheetLoader): No longer a virtual function. This is not a polymorphic class. (WebCore::UserStyleSheetLoader::setStyleSheet): Remove code to delete ourselves -- that's now the frame's responsibility. (WebCore::Frame::~Frame): Call disconnectFrame on the KJS::Window and delete m_userStyleSheetLoader. (WebCore::Frame::changeLocation): Update since urlSelected no longer takes button and state parameters. (WebCore::Frame::setUserStyleSheet): Delete existing loader to stop a load in progress before starting a new load. Store reference to loader. (WebCore::Frame::urlSelected): Remove button and state parameters and unused local variable hasTarget. (WebCore::Frame::selectClosestWordFromMouseEvent): Change from QMouseEvent to MouseEvent. (WebCore::Frame::handleMousePressEventDoubleClick): Change from MousePressEvent to MouseEventWithHitTestResults. (WebCore::Frame::handleMousePressEventTripleClick): Ditto. (WebCore::Frame::handleMousePressEventSingleClick): Ditto. (WebCore::Frame::khtmlMousePressEvent): Ditto. (WebCore::Frame::handleMouseMoveEventSelection): Change from MouseMoveEvent to MouseEventWithHitTestResults. (WebCore::Frame::khtmlMouseMoveEvent): Ditto. (WebCore::Frame::khtmlMouseReleaseEvent): Change from MouseReleaseEvent to MouseEventWithHitTestResults. (WebCore::Frame::khtmlMouseDoubleClickEvent): Change from MouseReleaseDoubleClickEvent to MouseEventWithHitTestResults. (WebCore::Frame::passWidgetMouseDownEventToWidget): Change from NodeImpl::MouseEvent to MouseEventWithHitTestResults.
  • page/FramePrivate.h: Added m_userStyleSheetLoader.
  • page/FrameView.h:
  • page/FrameView.cpp: (WebCore::FrameView::viewportMousePressEvent): Change from QMouseEvent to MouseEvent and from NodeImpl::MouseEvent to MouseEventWithHitTestResults. (WebCore::FrameView::viewportMouseDoubleClickEvent): Ditto. (WebCore::selectCursor): Ditto. (WebCore::FrameView::viewportMouseMoveEvent): Ditto. (WebCore::FrameView::viewportMouseReleaseEvent): Ditto. (WebCore::FrameView::keyPressEvent): Change from QKeyEvent to KeyEvent. (WebCore::FrameView::dispatchMouseEvent): Change from QMouseEvent to MouseEvent and from NodeImpl::MouseEvent to MouseEventWithHitTestResults. (WebCore::FrameView::viewportWheelEvent): Change from QWheelEvent to WheelEvent. (WebCore::FrameView::hoverTimerFired): Update for change to prepareMouseEvent parameters.
  • platform/Widget.h:
  • platform/Widget.cpp: Removed event function.
  • rendering/render_form.h: Removed LineEditWidget, ComboBoxWidget, TextAreaWidget.
  • rendering/render_form.cpp: (WebCore::RenderFormElement::slotClicked): Changed from QMouseEvent to MouseEvent. (WebCore::RenderFormElement::addIntrinsicMarginsIfAllowed): Updated for changes to the Length class. (WebCore::RenderSelect::setWidgetWritingDirection): Updated for removal of ComboBoxWidget. (WebCore::RenderSelect::slotSelected): Ditto. (WebCore::RenderSelect::createComboBox): Ditto.
  • rendering/render_replaced.h:
  • rendering/render_replaced.cpp: (WebCore::RenderWidget::destroy): Updated since removeEventFilter no longer takes a parameter. (WebCore::RenderWidget::setQWidget): Ditto. (WebCore::RenderWidget::eventFilterFocusIn): Added. Replaces eventFilter. (WebCore::RenderWidget::eventFilterFocusOut): Ditto.
  • css/css_computedstyle.cpp: (WebCore::valueForLength): (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
  • css/cssstyleselector.cpp: (WebCore::checkPseudoState): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
  • khtml/html/html_imageimpl.cpp: (WebCore::HTMLAreaElementImpl::getRegion):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::MarginInfo::MarginInfo): (WebCore::RenderBlock::isSelfCollapsingBlock): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::determineHorizontalPosition): (WebCore::RenderBlock::leftRelOffset): (WebCore::RenderBlock::rightRelOffset): (WebCore::RenderBlock::calcMinMaxWidth): (WebCore::getBPMWidth): (WebCore::RenderBlock::calcInlineMinMaxWidth): (WebCore::RenderBlock::calcBlockMinMaxWidth):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::calcWidth): (WebCore::RenderTable::layout):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::calcMinMaxWidth):
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild): (WebCore::RenderTableSection::addCell): (WebCore::RenderTableSection::calcRowHeight): (WebCore::RenderTableSection::layoutRows):
  • rendering/RenderText.h: (khtml::RenderText::marginLeft): (khtml::RenderText::marginRight):
  • rendering/bidi.cpp: (khtml::getBPMWidth):
  • rendering/render_applet.cpp: (WebCore::RenderApplet::createWidgetIfNecessary):
  • rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended): (WebCore::RenderBox::getClipRect): (WebCore::RenderBox::relativePositionOffset): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcWidthUsing): (WebCore::RenderBox::sizesToIntrinsicWidth): (WebCore::RenderBox::calcHorizontalMargins): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcHeightUsing): (WebCore::RenderBox::calcPercentageHeight): (WebCore::RenderBox::calcReplacedWidth): (WebCore::RenderBox::calcReplacedWidthUsing): (WebCore::RenderBox::calcReplacedHeight): (WebCore::RenderBox::calcReplacedHeightUsing): (WebCore::RenderBox::availableHeightUsing): (WebCore::RenderBox::calcVerticalMargins): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteVerticalValues):
  • rendering/render_br.cpp: (WebCore::RenderBR::lineHeight):
  • rendering/render_flexbox.cpp: (khtml::RenderFlexibleBox::calcHorizontalMinMaxWidth): (khtml::RenderFlexibleBox::calcVerticalMinMaxWidth): (khtml::RenderFlexibleBox::calcMinMaxWidth): (khtml::RenderFlexibleBox::allowedChildFlex):
  • rendering/render_flow.cpp: (WebCore::RenderFlow::lineHeight):
  • rendering/render_frames.cpp: (WebCore::RenderFrameSet::layout):
  • rendering/render_image.cpp: (WebCore::RenderImage::isWidthSpecified): (WebCore::RenderImage::isHeightSpecified):
  • rendering/render_layer.cpp: (WebCore::Marquee::direction): (WebCore::Marquee::start): (WebCore::Marquee::updateMarqueeStyle): (WebCore::Marquee::timerFired):
  • rendering/render_line.cpp: (WebCore::InlineFlowBox::marginLeft): (WebCore::InlineFlowBox::marginRight):
  • rendering/render_object.cpp: (WebCore::RenderObject::mustRepaintBackgroundOrBorder): (WebCore::RenderObject::paintBorderImage): (WebCore::RenderObject::paddingTop): (WebCore::RenderObject::paddingBottom): (WebCore::RenderObject::paddingLeft): (WebCore::RenderObject::paddingRight): (WebCore::RenderObject::getVerticalPosition): (WebCore::RenderObject::lineHeight): (WebCore::RenderObject::addDashboardRegions):
  • rendering/render_style.h:
  • rendering/render_theme_mac.mm: (WebCore::RenderThemeMac::addIntrinsicMargins):
  • rendering/table_layout.cpp: (WebCore::FixedTableLayout::calcWidthArray): (WebCore::FixedTableLayout::calcMinMaxWidth): (WebCore::FixedTableLayout::layout): (WebCore::AutoTableLayout::recalcColumn): (WebCore::AutoTableLayout::fullRecalc): (WebCore::AutoTableLayout::calcMinMaxWidth): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout): (WebCore::AutoTableLayout::calcPercentages): Updated for changes to the Length class. Also removed a check of the printpainter global, never used in WebCore.
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMCSS.mm:
  • bindings/objc/DOMHTML.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • css/csshelper.cpp:
  • editing/SelectionController.cpp:
  • khtml/ecma/kjs_html.h:
  • kwq/KWQAccObject.mm:
  • kwq/KWQAccObjectCache.mm:
  • kwq/KWQClipboard.mm:
  • kwq/KWQFont.mm:
  • kwq/KWQFontMetrics.mm:
  • kwq/KWQKJobClasses.mm:
  • kwq/KWQKURL.mm:
  • kwq/KWQLoader.mm:
  • kwq/KWQPageState.mm:
  • kwq/KWQPainter.mm:
  • kwq/WebCoreSettings.mm:
  • platform/StringImpl.cpp:
  • platform/mac/CursorMac.mm:
  • platform/mac/WidgetMac.mm:
  • rendering/RenderBlock.h:
  • rendering/render_canvas.cpp:
  • rendering/render_line.h:
  • rendering/render_style.cpp:
  • rendering/table_layout.h: Updated includes.
  • bindings/js/JSDOMCore.cpp: Touched, because I got strange failures if this didn't rebuild.
  • bindings/js/JSDOMEvents.cpp: Ditto.
6:00 PM Changeset in webkit [12952] by thatcher
  • 2 edits in trunk/WebKitLibraries

New build to fix the i386 arch. (The _cuEnc64 symbol was missing.)

  • libWebKitSystemInterface.a:
5:11 PM Changeset in webkit [12951] by eseidel
  • 10 edits
    1 add in trunk/WebCore

2006-02-23 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Fix linking of static constructed globals on win32.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • config.h:
  • dom/EventNames.cpp: (WebCore::EventNames::init):
  • dom/EventNames.h:
  • dom/dom_qname.cpp: (WebCore::QualifiedName::init):
  • dom/dom_qname.h:
  • khtml/html/htmlnames.cpp: (WebCore::HTMLNames::init):
  • khtml/html/htmlnames.h:
  • platform/AtomicString.cpp: (WebCore::AtomicString::init):
  • platform/StaticConstructors.h: Added.
4:20 PM Changeset in webkit [12950] by vicki
  • 2 edits in trunk/WebCore

Reviewed by Tim Omernick.


  • fix <rdar://problem/4394910> calling Javascript window.close() does not trigger onbeforeunload event

Check shouldClose() before actually scheduling a close.

shouldClose() checks for the onbeforeunload handler, displays the onbeforeunload dialog, and returns a
result based on whether the user clicks "OK" or "Cancel". In cases where the window is closed with cmd-w
or by clicking the red globe, shouldClose() is checked in the windowShouldClose delegate method. Since
windowShouldClose isn't invoked when a window is closed with Javascript, it makes sense to add a check
for shouldClose() in scheduleClose(), returning early when appropriate before the chain of events that
closes a window even gets started.

  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::scheduleClose): add a check for shouldClose()
11:52 AM Changeset in webkit [12949] by ggaren
  • 11 edits in trunk/JavaScriptCore

Reviewed by Darin, Maciej.

  • Inline some functions suggested by Shark. 2.9% speedup on super accurate JS iBench.

http://bugzilla.opendarwin.org/show_bug.cgi?id=7411
<rdar://problem/4448116>

  • kjs/nodes.h: (KJS::ArgumentsNode::evaluateList):
  • kjs/object.cpp:
  • kjs/object.h: (KJS::ScopeChain::release): (KJS::JSObject::toPrimitive):
  • kjs/scope_chain.cpp:
  • kjs/ustring.cpp:
  • kjs/ustring.h: (KJS::UString::toArrayIndex):
  • kjs/value.cpp:
  • kjs/value.h: (KJS::JSValue::toObject):
  • kxmlcore/FastMalloc.cpp: (KXMLCore::TCMalloc_ThreadCache_FreeList::Push): (KXMLCore::TCMalloc_ThreadCache_FreeList::Pop):
11:46 AM Changeset in webkit [12948] by vicki
  • 3 edits in trunk/WebCore

Reviewed by Hyatt.


  • fix <rdar://problem/4456004> onbeforeunload should cancel, and <rdar://problem/4453579> REGRESSION (TOT): onbeforeunload is broken (7421)
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::shouldClose): Onbeforeunload is a non-bubbling window event, so we should be using handleWindowEvent rather than dispatching a generic event on the body. It seems this only worked before because of incorrect code in other parts of the tree.
  • dom/dom2_eventsimpl.cpp: (WebCore::BeforeUnloadEventImpl::BeforeUnloadEventImpl): for this constructor, pass true for the cancel parameter
11:28 AM Changeset in webkit [12947] by ap
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

  • Turn http tests back on by default.
  • Wait for Apache to actually start serving requests.
  • Get user id from a built-in variable rather than an external command; don't pass the group.
  • Scripts/run-webkit-tests:
9:25 AM Changeset in webkit [12946] by ap
  • 2 edits in trunk/WebKitTools

Suggested by Mitz Pettel, reviewed by Darin.

  • Scripts/run-webkit-tests: Pass User and Group directives, so that Apache can run CGIs even if the permissions are 700 or 600.
8:39 AM Changeset in webkit [12945] by darin
  • 2 edits in trunk/WebKitTools

Collaborating with Alexey.

  • turn off http tests by default until we figure out how to get them to run even when permissions on CGI files are 700 instead of 755
  • Scripts/run-webkit-tests: Set $testHTTP to 0 instead of 1 for now.
1:01 AM Changeset in webkit [12944] by eseidel
  • 6 edits in trunk

2006-02-23 Eric Seidel <eseidel@apple.com>

Add *.user to ignore list.

12:55 AM Changeset in webkit [12943] by eseidel
  • 2 edits
    2 deletes in trunk/WebKitTools

2006-02-23 Eric Seidel <eseidel@apple.com>

Remove binary file which shouldn't have been commited (and add to ignore list).

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.ncb: Removed.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo: Removed.

Feb 22, 2006:

11:09 PM Changeset in webkit [12942] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Eric.

  • Scripts/run-webkit-tests: Put Apache log files in the right directory.
8:10 PM Changeset in webkit [12941] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-22 Eric Seidel <eseidel@apple.com>

Reviewed by Tim Hatcher.

Fix install-win-extras to not try to re-install setx if installed.

  • Scripts/install-win-extras:
7:52 PM Changeset in webkit [12940] by eseidel
  • 3 edits in trunk/WebKitTools

2006-02-22 Eric Seidel <eseidel@apple.com>

One more file possibly missing from previous commit?

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.ncb:
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo:
7:38 PM Changeset in webkit [12939] by eseidel
  • 3 edits in trunk/WebKitTools

2006-02-22 Eric Seidel <eseidel@apple.com>

Reviewed by justing.

Files missing from previous commit.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo:
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
7:27 PM Changeset in webkit [12938] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-22 Eric Seidel <eseidel@apple.com>

Rubber-stamped by justing.

Corrected path for DumpRenderTree.intermediate files

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo:
7:14 PM Changeset in webkit [12937] by eseidel
  • 2 edits in trunk/WebKitTools

2006-02-22 Eric Seidel <eseidel@apple.com>

Reviewed by justing.

Fixed build-dumprendertree to exit with correct error codes.

  • Scripts/build-dumprendertree:
6:49 PM Changeset in webkit [12936] by eseidel
  • 5 edits in trunk/WebKitTools

2006-02-22 Eric Seidel <eseidel@apple.com>

Reviewed by justing.

Update build scripts to generalize building on Win32, and allow
building of DumpRenderTree on Win32 from build-dumprendertree.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main):
  • Scripts/build-dumprendertree:
  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:
5:34 PM Changeset in webkit [12935] by thatcher
  • 15 adds in branches/Safari-1-3-branch

Fixing binary files messed up by cvs2svn.

4:56 PM Changeset in webkit [12934] by eseidel
  • 2 edits
    7 adds in trunk/WebKitTools

2006-02-22 Eric Seidel <eseidel@apple.com>

Reviewed by hyatt.

  • DumpRenderTree/DumpRenderTree.vcproj: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.ncb: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Added. (_tmain):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Added.
  • Scripts/build-webkit: make build-webkit cleanup after itself
4:36 PM Changeset in webkit [12933] by eseidel
  • 2 edits
    2 adds in trunk/WebCore

2006-02-22 Eric Seidel <eseidel@apple.com>

Reviewed by darin.

Adding stub FrameWin class to expose link errors.

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/FrameWin.cpp: Added.
  • bridge/win/FrameWin.h: Added. (WebCore::Win):
4:33 PM Changeset in webkit [12932] by mjs
  • 37 edits
    2 moves
    1 add
    1 delete in trunk/WebCore

Reviewed by Geoff.

  • move QStringList to platform, make it portable
  • ForwardingHeaders/qstringlist.h: Removed.
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DocumentImpl.h:
  • kcanvas/KCanvasFilters.h:
  • khtml/xbl/xbl_protohandler.cpp:
  • ksvg2/svg/SVGColorImpl.cpp:
  • ksvg2/svg/SVGComponentTransferFunctionElementImpl.cpp:
  • ksvg2/svg/SVGDOMImplementationImpl.h:
  • ksvg2/svg/SVGFEBlendElementImpl.cpp:
  • ksvg2/svg/SVGFEColorMatrixElementImpl.cpp:
  • ksvg2/svg/SVGFEComponentTransferElementImpl.cpp:
  • ksvg2/svg/SVGFECompositeElementImpl.cpp:
  • ksvg2/svg/SVGFEDiffuseLightingElementImpl.cpp:
  • ksvg2/svg/SVGFEDisplacementMapElementImpl.cpp:
  • ksvg2/svg/SVGFEFloodElementImpl.cpp:
  • ksvg2/svg/SVGFEGaussianBlurElementImpl.cpp:
  • ksvg2/svg/SVGFELightElementImpl.cpp:
  • ksvg2/svg/SVGFEMergeElementImpl.cpp:
  • ksvg2/svg/SVGFEOffsetElementImpl.cpp:
  • ksvg2/svg/SVGFESpecularLightingElementImpl.cpp:
  • ksvg2/svg/SVGFETileElementImpl.cpp:
  • ksvg2/svg/SVGFETurbulenceElementImpl.cpp:
  • ksvg2/svg/SVGFitToViewBoxImpl.cpp:
  • ksvg2/svg/SVGLengthListImpl.cpp:
  • ksvg2/svg/SVGNumberListImpl.cpp:
  • ksvg2/svg/SVGPreserveAspectRatioImpl.cpp:
  • ksvg2/svg/SVGStringListImpl.cpp:
  • ksvg2/svg/SVGStyledTransformableElementImpl.cpp:
  • ksvg2/svg/SVGTransformableImpl.cpp:
  • kwq/KWQClipboard.mm:
  • kwq/KWQKConfigBase.mm:
  • kwq/KWQKHTMLSettings.h:
  • kwq/KWQKLocale.h:
  • kwq/KWQKSSLKeyGen.h:
  • kwq/KWQStringList.h: Removed.
  • kwq/KWQStringList.mm: Removed.
  • loader/DocLoader.h:
  • page/Frame.h:
  • platform/QStringList.cpp: Added. (QStringList::split): (QStringList::pop_front):
  • platform/QStringList.h: Added.
  • platform/mac/QStringListMac.mm: Added. (QStringList::getNSArray):
Note: See TracTimeline for information about the timeline view.