Timeline



Mar 13, 2006:

11:40 PM Changeset in webkit [13281] by eseidel
  • 2 edits in trunk/WebCore

2006-03-13 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix mouse events to be window-relative.

  • platform/win/MouseEventWin.cpp: (WebCore::positionForEvent): (WebCore::globalPositionForEvent): (WebCore::MouseEvent::MouseEvent):
11:05 PM Changeset in webkit [13280] by eseidel
  • 3 edits in trunk/WebKitTools

2006-03-10 Eric Seidel <​eseidel@apple.com>

Reviewed by hyatt.

Add scrolling support into Spinneret.

  • Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::paint):
  • Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::createWebView): (WebKit::calculateScrollDelta): (WebKit::scrollMessageForKey): (WebKit::WebViewWndProc):
10:25 PM Changeset in webkit [13279] by eseidel
  • 3 edits in trunk/WebCore

2006-03-13 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Close DeviceContext leaks in Font code.
Also add moveCursor stub to make maps.google.com not crash.

  • platform/win/FontWin.cpp: (WebCore::getFontData): (WebCore::Font::floatWidth): (WebCore::Font::drawText):
  • platform/win/TemporaryLinkStubs.cpp: (Cursor::Cursor): (WebCore::moveCursor):
8:50 PM Changeset in webkit [13278] by eseidel
  • 4 edits in trunk/WebKitTools

2006-03-13 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Fix checksum generation on Intel machines.
Also moved to CGImage APIs instead of NSBitmapImageRep, may possibly
give a small speed boost now that it uses a shared buffer.

  • DumpRenderTree/DumpRenderTree.m: (main): (dump): (md5HashStringForBitmap):
  • DumpRenderTree/ImageDiff.m: (computePercentageDifferent):
7:30 PM Changeset in webkit [13277] by eseidel
  • 3 edits
    5 adds in trunk

2006-03-13 Eric Seidel <​eseidel@apple.com>

Reviewed by ggaren & TimH.

<rdar://problem/4473288> XSL file containing <xsl:include href="../Styles/EscapeString.xsl" /> fails to load file
XML_DTD_NODE objects in the tree were causing loadChildSheets to
fail to preload child stylesheets, this patch causes us to
correctly ignore all nodes besides the first XML_ELEMENT_NODE at
the root level when searching the tree for xsl:include statements
to pre-load.

Test: fast/xsl/xslt-second-level-import.xml

  • khtml/xsl/xsl_stylesheetimpl.cpp: (WebCore::XSLStyleSheetImpl::loadChildSheets):
6:26 PM Changeset in webkit [13276] by eseidel
  • 8 edits
    4 adds in trunk

2006-03-10 Rob Buis <​buis@kde.org>

Reviewed by darin. Landed by eseidel.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=7666:
dasharray on rounded rectangles is broken

Make sure the rounded rectangle is drawn clockwise, as outlined
in the specification.

Test: svg/custom/dashArrayOrigin.svg

  • kcanvas/KCanvasCreator.cpp: (WebCore::KCanvasCreator::createRoundedRectangle):
4:15 PM Changeset in webkit [13275] by thatcher
  • 4 copies in tags/WebCore-417.24/WebCore

New tag (part 2).

4:14 PM Changeset in webkit [13274] by thatcher
  • 1 add in tags/WebCore-417.24

New tag.

4:14 PM Changeset in webkit [13273] by thatcher
  • 5 copies in tags/JavaScriptCore-417.11/JavaScriptCore

New tag (part 2).

4:14 PM Changeset in webkit [13272] by thatcher
  • 1 add in tags/JavaScriptCore-417.11

New tag.

4:12 PM Changeset in webkit [13271] by thatcher
  • 4 edits in branches/Safari-2-0-branch

Versioning

4:09 PM Changeset in webkit [13270] by thatcher
  • 4 edits in branches/Safari-2-0-branch

Merged fix from TOT to Safari-2-0-branch

2006-02-16 Tim Omernick <​timo@apple.com>

Reviewed by Geoff.

<rdar://problem/4428609> Flash Player 8.0.22 can crash Safari (and WebKit apps)
with javascript disabled (7015)

Added a test case, manual-tests/NPN_Invoke. This is a skeleton of a Netscape
plugin which uses NPN_Invoke() to call the window.alert() JavaScript function.


  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::windowScriptNPObject): Removed the check Darin added to return 0 when JavaScript is disabled. This method cannot return 0, because plugins are not guaranteed to check for that. Removed my old fix for Radar 4428609 (7015) in favor of a better solution. Instead of creating a "dummy" JSObject to represent the window script object when JavaScript is disabled, we use the new JavaScriptCore bindings API to create a "no script" NPObject. This solution is better because it does not cause entry into any JavaScript interpreter code.
  • manual-tests/NPN_Invoke: Added.
  • manual-tests/NPN_Invoke/English.lproj: Added.
  • manual-tests/NPN_Invoke/English.lproj/Localized.r: Added.
  • manual-tests/NPN_Invoke/Info.plist: Added.
  • manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Added.
  • manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj: Added.
  • manual-tests/NPN_Invoke/main.c: Added.
  • manual-tests/NPN_Invoke/test.html: Added.
2:16 PM Changeset in webkit [13269] by ggaren
  • 4 edits in trunk/WebKit

Reviewed by timo.

  • Fixed the load progress indicator to give more incremental feedback, and to stop spending so much time near 100%.

I did two things:
(1) Fixed some bugs and a misspelling in the previous heuristic's
implementation
(2) Added two new rules to the heuristic:

(a) Treat the first layout as the half-way point.
(b) Just like we jump the first 10% to indicate that a load has
started, jump the last 10% to indicate that a load has finished.

Rule 2a is good for two reasons. First, it seems unnatural for loading
to be "more than half done" when you can't even see anything. Second,
in the early stages of laading our estimate of how much we'll need to
load is often off by as much as 6000% (e.g., cnn.com). So anything that
makes the progress indicator more conservative in the early stages of
loading is helpful.

Rule 2b is good because it's confusing for loading to be "100% done"
but still ongoing.

FIXME: The indicator still isn't perfect. For example, the old behavior
shows up @ moviefone.com. Two areas for future work:
(1) Estimate number of linked resources. Our code estimates the size
of a single resource, but does nothing to estimate the number of
resources that resource might link to. This is the key to why we're
so wrong at the beginning.
(2) Improve "when to do first layout" heuristic. A JavaScript query
for a style property forces layout, creating a phantom first layout
with no content, essentially nullifying 2a for certain pages.


Filed <rdar://problem/4475834> to track estimating the number of
linked resources. Phantom layouts are already on Hyatt's radar.

  • WebView/WebFrame.m: (-[WebFrame _setState:]): Update firstLayoutDone (-[WebFrame _numPendingOrLoadingRequests:]): Bug fix: In the recurisve case, query 'frame' instead of 'self', so that we actually recurse. (-[WebFrame _firstLayoutDone]): New method (-[WebFrame _didFirstLayout]): Update firstLayoutDone
  • WebView/WebFramePrivate.h: Added firstLayoutDone ivar
  • WebView/WebView.m: (-[WebView _incrementProgressForConnectionDelegate:data:]): (1) Implemented 2a and 2b (2) Bug fix: only update the 'last time I sent a notification' time if we actually send a notification. (3) Don't test for progress < 0 because ensuring progress < max also ensures max - progress > 0. (Do still test for progress > max because rounding errors make that a possibility -- although a very minor one.) (4) Query only the loading frame and its subframes for pending requests instead of defaulting to the main frame. This is a slight optimization in cases where the main frame did not begin the load, and it makes the code more consistent.
12:00 PM Changeset in webkit [13268] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Tim Hatcher.

  • Scripts/run-webkit-tests: Fix httpd handling to work on systems that have it named httpd-1.3 instead.
11:55 AM Changeset in webkit [13267] by ap
  • 2 edits in trunk/WebKitTools

Fix proposed by Mitz Pettel, reviewed by Darin.

  • Scripts/run-webkit-tests: Make test paths canonical, to form proper URLs (sequences of slashes are equivalent to a single slash in POSIX paths, but not in URLs).
11:29 AM Changeset in webkit [13266] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick.


  • fixed <rdar://problem/4475857> API: Setting a history item limit programmatically doesn't work
  • History/WebHistory.m: (-[WebHistoryPrivate _loadHistoryGuts:URL:error:]): use [self historyItemLimit], which prefers the explicitly-set value and falls back to the NSUserDefaults value, instead of using the NSUserDefaults value explicitly.

Mar 12, 2006:

2:17 PM Changeset in webkit [13265] by ap
  • 3 edits
    4 adds in trunk

Fix by Mitz Pettel, reviewed by Maciej.

Test: fast/events/drag-outside-window.html

  • rendering/render_layer.cpp: (WebCore::RenderLayer::containsPoint): Always return true for the root object to ensure that mouse events occurring outside the window target the document.
2:09 PM Changeset in webkit [13264] by ap
  • 5 edits in trunk/WebCore

No test - only reproducible when Safari imports the bookmarks.

  • dom/EventNames.cpp: (WebCore::EventNames::init): Initialize AtomicString before using it.
  • dom/QualifiedName.cpp: (WebCore::QualifiedName::init): Ditto.
  • khtml/html/htmlnames.cpp: (WebCore::HTMLNames::init): Ditto.
  • ksvg2/scripts/make_names.pl: Ditto.
12:30 PM Changeset in webkit [13263] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Maciej.

Test: plugins/invoke.html

  • bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16): Return a correct string length.
12:29 AM Changeset in webkit [13262] by ap
  • 3 edits
    16 adds in trunk

Patch by David Kilzer, reviewed by Darin.

WebCore:

  • khtml/html/htmlparser.cpp: (WebCore::HTMLParser::handleError): Refactored code.

LayoutTests:

These tests cover the changed code. No change in behavior.

  • fast/invalid/missing-address-end-tag-expected.checksum: Added.
  • fast/invalid/missing-address-end-tag-expected.png: Added.
  • fast/invalid/missing-address-end-tag-expected.txt: Added.
  • fast/invalid/missing-address-end-tag.html: Added.
  • fast/invalid/missing-dl-end-tag-expected.checksum: Added.
  • fast/invalid/missing-dl-end-tag-expected.png: Added.
  • fast/invalid/missing-dl-end-tag-expected.txt: Added.
  • fast/invalid/missing-dl-end-tag.html: Added.
  • fast/invalid/missing-dt-end-tag-expected.checksum: Added.
  • fast/invalid/missing-dt-end-tag-expected.png: Added.
  • fast/invalid/missing-dt-end-tag-expected.txt: Added.
  • fast/invalid/missing-dt-end-tag.html: Added.
  • fast/invalid/missing-font-end-tag-expected.checksum: Added.
  • fast/invalid/missing-font-end-tag-expected.png: Added.
  • fast/invalid/missing-font-end-tag-expected.txt: Added.
  • fast/invalid/missing-font-end-tag.html: Added.

Mar 10, 2006:

7:32 PM Changeset in webkit [13261] by darin
  • 2 edits in trunk/WebCore
  • fix Windows build
  • bridge/win/FrameWin.h: Removed declaration of generateFrameName.
7:30 PM Changeset in webkit [13260] by darin
  • 9 edits in trunk

WebCore:

Reviewed by Adele.

  • removed some unused stuff from Frame and MacFrame
  • page/Frame.h: Removed autoloadImages (the setter), enableMetaRefresh, setCharset, backgroundURL, findTextBegin, findTextNext, preloadStyleSheet, preloadScript, restored, onURL, selectionChanged, htmlError, openFile, updateActions, openURLInFrame, overURL, checkLinkSecurity, and cacheId.
  • page/FramePrivate.h: Removed m_restored, m_frameNameId, m_strSelectedURL, m_strSelectedURLTarget, m_bDnd, m_bClearing, m_bSecurityInQuestion, m_focusNodeRestored, m_focusNodeNumber, and m_newJSInterpreterExists.
  • page/Frame.cpp: (WebCore::Frame::didOpenURL): Removed use of m_restored, code to set m_bClearing. (WebCore::Frame::clear): Removed code to set m_bClearing and m_frameNameId. (WebCore::Frame::khtmlMousePressEvent): Removed code to set m_strSelectedURL and m_strSelectedURLTarget.
  • bridge/mac/MacFrame.h: Removed scheduleHistoryNavigation and requestedURLString.
  • bridge/mac/MacFrame.mm: (WebCore::MacFrame::openURLFromPageCache): Removed use of m_restored. Removed unused requestedURLString.
  • bridge/mac/WebCoreFrameBridge.h: Removed requestedURLString.

WebKit:

Reviewed by Adele.

  • WebCoreSupport/WebFrameBridge.m: Remove unused requestedURLString method.
7:25 PM Changeset in webkit [13259] by darin
  • 2 edits in trunk/WebCore
  • fix Windows build
  • page/FrameTree.cpp: Add include of <stdarg.h>.
7:21 PM Changeset in webkit [13258] by darin
  • 4 edits in trunk/WebKit

Reviewed by Geoff.

  • change how frame namespacing works to be more completely on the WebCore side
  • WebView/WebFrameInternal.h: Remove _setFrameNamespace: and _frameNamespace.
  • WebView/WebFrame.m: Ditto.
  • WebView/WebView.m: (-[WebView setGroupName:]): Call -[WebCorePageBridge setGroupName:]. (-[WebView groupName]): Call -[WebCorePageBridge groupName].
7:17 PM Changeset in webkit [13257] by darin
  • 23 edits
    1 move
    8 adds in trunk

LayoutTests:

Reviewed by Geoff, except for frame-name-reset, which was done by Alexey.

  • fast/dom/Window/open-existing-pop-up-blocking-expected.checksum: Added.
  • fast/dom/Window/open-existing-pop-up-blocking-expected.png: Added.
  • fast/dom/Window/open-existing-pop-up-blocking-expected.txt: Added.
  • fast/dom/Window/open-existing-pop-up-blocking.html: Added.
  • fast/dom/Window/resources/open-sibling-subframe.html: Added.
  • fast/dom/Window/resources/sibling-subframe-content.html: Added.
  • fast/frames/frame-name-reset.html: Added.
  • fast/frames/frame-name-reset-expected.txt: Added.

WebCore:

Reviewed by Geoff.

  • refactor frame-name-related functions into the FrameTree object
  • WebCore.xcodeproj/project.pbxproj: Update for rename.
  • bridge/mac/MacFrame.h: Remove generateFrameName.
  • bridge/mac/MacFrame.mm: Ditto.
  • bridge/mac/PageMac.h: Added a declaration for WebCorePageBridge.
  • bridge/mac/WebCoreFrameBridge.h: Remove _frameNamespace, generateFrameName, setFrameNamespace, frameNamespace.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge childFrameNamed:]): Change to call the new child function on the FrameTree. (-[WebCoreFrameBridge findFrameNamed:]): Change to call the new find function on the FrameTree. (-[WebCoreFrameBridge RenderObject::nodeInfoAtPoint:]): Change since the contentPart function has been renamed to contentFrame.
  • bridge/mac/WebCoreFrameNamespaces.h: Removed everything except for the one method still used on the WebKit side, framesInNamespace:.
  • bridge/mac/WebCoreFrameNamespaces.m: Renamed.
  • bridge/mac/WebCoreFrameNamespaces.mm: Added. Reimplemented the framesInNamespace method to use the namespace in WebCore::Page.
  • bridge/mac/WebCorePageBridge.h: Added setGroupName and groupName.
  • bridge/mac/WebCorePageBridge.mm: (-[WebCorePageBridge setGroupName:]): Added. Calls through to Page. (-[WebCorePageBridge groupName]): Ditto.
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLDocument::namedItemGetter): Changed to call contentFrame by its new name. (KJS::HTMLElement::frameGetter): Ditto. (KJS::HTMLElement::iFrameGetter): Ditto.
  • khtml/ecma/kjs_window.cpp: (KJS::Window::getValueProperty): Changed to call FrameTree::childCount instead of Frame::frames. (KJS::Window::childFrameGetter): Changed to call FrameTree::child instead of Frame::childFrameNamed. (KJS::Window::namedFrameGetter): Changed to call FrameTree::find instead of Frame::findFrame. (KJS::Window::indexGetter): Changed to call FrameTree::child instead of Frame::frames. (KJS::Window::getOwnPropertySlot): Changed to call FrameTree::child, FrameTree::find, and FrameTree::childCount instead of Frame::childFrameNamed, and Frame::findFrame, and Frame::frames. (KJS::WindowFunc::callAsFunction): Call FrameTree::find to check if the window is already open when considering whether to block a pop-up. (KJS::FrameArray::getValueProperty): Changed to call FrameTree::childCount instead of Frame::frames. (KJS::FrameArray::indexGetter): Changed to call FrameTree::child instead of Frame::frames. (KJS::FrameArray::nameGetter): Changed to call FrameTree::child instead of Frame::findFrame. (KJS::FrameArray::getOwnPropertySlot): Changed to call FrameTree::child, and FrameTree::childCount instead of Frame::findFrame and Frame::frames.
  • khtml/html/html_baseimpl.h:
  • khtml/html/html_baseimpl.cpp: (WebCore::HTMLFrameElementImpl::isURLAllowed): Changed to call Page::frameCount instead of Frame::topLevelFrameCount. (WebCore::HTMLFrameElementImpl::openURL): Changed to call FrameTree::child instead of Frame::findFrame. (WebCore::HTMLFrameElementImpl::attach): Changed to call Page::incrementFrameCount instead of Frame::incrementFrameCount. Changed to call FrameTree::uniqueChildName instead of Frame::requestFrameName. (WebCore::HTMLFrameElementImpl::close): Changed to call Page::decrementFrameCount instead of Frame::decrementFrameCount. Changed to call FrameTree::child instead of Frame::findFrame. (WebCore::HTMLFrameElementImpl::contentFrame): Renamed from contentPart. Also changed to call FrameTree::child instead of Frame::findFrame. (WebCore::HTMLFrameElementImpl::contentDocument): Updated for name change of contentFrame from contentPart. (WebCore::HTMLIFrameElementImpl::attach): Changed to call Page::incrementFrameCount instead of Frame::incrementFrameCount. Changed to call FrameTree::uniqueChildName instead of Frame::requestFrameName.
  • rendering/render_frames.cpp: (WebCore::isURLAllowed): Changed to call Page::frameCount instead of Frame::topLevelFrameCount.
  • page/Frame.h: Removed frameNames, frames, childFrameNamed, findFrame, currentFrame, frameExists, incrementFrameCount, decrementFrameCount, topLevelFrameCount, generateFrameName, and requestFrameName functions.
  • page/Frame.cpp: (WebCore::Frame::requestFrame): Changed to use FrameTree::child instead of Frame::childFrameNamed.
  • page/FrameTree.h: Changed name to an atomic string. Changed childCount to unsigned. Added isDescendantOf, traverseNext, child, find, uniqueChildName.
  • page/FrameTree.cpp: (WebCore::FrameTree::setName): Changed to call uniqueChildName to handle name duplication logic. (WebCore::FrameTree::uniqueChildName): Added. Checks for duplication and generates an appropriate frame name if there is a duplicate. (WebCore::FrameTree::child): Added. (WebCore::FrameTree::find): Added. (WebCore::FrameTree::isDescendantOf): Added. (WebCore::FrameTree::traverseNext): Added.
  • page/Page.h: Added setGroupName, groupName, frameNamespace, incrementFrameCount, decrementFrameCount, and frameCount.
  • page/Page.cpp: (WebCore::Page::Page): Initialize m_frameCount to 0. (WebCore::Page::~Page): Call setGroupName to remove the page from any group it's in. (WebCore::Page::setGroupName): Added. (WebCore::Page::frameNamespace): Added.
  • platform/win/TemporaryLinkStubs.cpp: Removed FrameWin::generateFrameName.
5:35 PM Changeset in webkit [13256] by justing
  • 2 edits in trunk/WebCore

Reviewed by darin, harrison


~3x speedup pasting plain text from the console

  • dom/dom_position.cpp: (WebCore::Position::next): (WebCore::Position::atEnd):
4:19 PM Changeset in webkit [13255] by hyatt
  • 3 edits
    3 adds in trunk/WebCore

Font refactoring on win32.

3:49 PM Changeset in webkit [13254] by thatcher
  • 5 copies in tags/Safari-521.9

New tag.

3:46 PM Changeset in webkit [13253] by thatcher
  • 4 edits in branches/Safari-Leo-branch

Versioning.

3:20 PM Changeset in webkit [13252] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • fix win32 networking to properly use async load API
  • platform/win/TransferJobWin.cpp: (WebCore::TransferJobWndProc): (WebCore::TransferJob::start):
1:15 PM Changeset in webkit [13251] by eseidel
  • 3 edits in trunk/WebCore

2006-03-10 Eric Seidel <​eseidel@apple.com>

Fix build.

  • platform/win/FontWin.cpp: (WebCore::getFontData):
  • platform/win/TemporaryLinkStubs.cpp:
1:13 PM Changeset in webkit [13250] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

  • Test for <rdar://problem/4469419> REGRESSION: RadioButtons are not checked in Safari when name attribute comes after checked attribute
  • fast/forms/radio-attr-order-expected.checksum: Added.
  • fast/forms/radio-attr-order-expected.png: Added.
  • fast/forms/radio-attr-order-expected.txt: Added.
  • fast/forms/radio-attr-order.html: Added.

WebCore:

Reviewed by Tim Hatcher.

  • fix for <rdar://problem/4469419> REGRESSION: RadioButtons are not checked in Safari when name attribute comes after checked attribute

Test: fast/forms/radio-attr-order.html

  • khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::parseMappedAttribute): When the name attribute gets parsed for radio buttons, if its supposed to be checked by default, call setChecked. Also, when the name changes on a checked button, we don't need to check that there's a form before removing it as the checked button for that group. That was an old check from when we required a form to keep track of checked buttons.
1:05 PM Changeset in webkit [13249] by eseidel
  • 24 edits in trunk/WebCore

2006-03-10 Eric Seidel <​eseidel@apple.com>

Reviewed by darin.

Add real ScrollViewWin implementation (fixes redraw bugs, adds ScrollBar support.)

  • platform/ScrollView.h:
  • platform/Widget.h:
  • platform/win/FontWin.cpp: (WebCore::getCairoFont): Fix crasher.
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::~ScrollView): (WebCore::ScrollView::updateContents): (WebCore::ScrollView::visibleWidth): (WebCore::ScrollView::visibleHeight): (WebCore::ScrollView::setContentsPos): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::contentsX): (WebCore::ScrollView::contentsY): (WebCore::ScrollView::contentsWidth): (WebCore::ScrollView::contentsHeight): (WebCore::ScrollView::viewportToContents): (WebCore::ScrollView::contentsToViewport): (WebCore::ScrollView::scrollXOffset): (WebCore::ScrollView::scrollYOffset): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::hScrollBarMode): (WebCore::ScrollView::vScrollBarMode): (WebCore::ScrollView::suppressScrollBars): (WebCore::ScrollView::setHScrollBarMode): (WebCore::ScrollView::setVScrollBarMode): (WebCore::ScrollView::setScrollBarsMode): (WebCore::ScrollView::setStaticBackground): (WebCore::ScrollView::updateScrollInfo): (WebCore::ScrollView::updateScrollBars):
  • platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::goBackOrForward): (BrowserExtensionWin::setIconURL): (ScrollView::scrollPointRecursively):
  • platform/win/WidgetWin.cpp: (WebCore::Widget::windowHandle): mark as const
11:28 AM Changeset in webkit [13248] by hyatt
  • 6 edits in trunk/WebCore

Rename the m_renderer variable to m_dataSet now that the class name
has changed.

Reviewed by adele

  • platform/Font.cpp: (WebCore::m_wordSpacing): (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::update):
  • platform/Font.h:
  • platform/FontDataSet.h:
  • platform/mac/FontMac.mm: (WebCore::Font::getWebCoreFont): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::lineSpacing): (WebCore::Font::xHeight): (WebCore::Font::isFixedPitch): (WebCore::Font::selectionRectForText): (WebCore::Font::drawText): (WebCore::Font::drawHighlightForText): (WebCore::Font::drawLineForText): (WebCore::Font::drawLineForMisspelling): (WebCore::Font::misspellingLineThickness): (WebCore::Font::floatWidth): (WebCore::Font::checkSelectionPoint):
  • platform/win/FontWin.cpp: (WebCore::FontData::FontData): (WebCore::FontData::~FontData): (WebCore::getFontData): (WebCore::FontDataSet::primaryFont): (WebCore::Font::floatWidth): (WebCore::Font::ascent): (WebCore::Font::descent): (WebCore::Font::xHeight): (WebCore::Font::lineSpacing): (WebCore::Font::isFixedPitch): (WebCore::Font::drawText):
10:58 AM Changeset in webkit [13247] by hyatt
  • 6 edits
    1 move in trunk/WebCore

Rename FontRenderer to FontDataSet.

Reviewed by adele

  • WebCore.xcodeproj/project.pbxproj:
  • platform/Font.cpp: (WebCore::Font::update):
  • platform/Font.h:
  • platform/FontDataSet.h: Added.
  • platform/FontRenderer.h: Removed.
  • platform/mac/FontMac.mm: (WebCore::FontDataSet::~FontDataSet): (WebCore::FontDataSet::getWebCoreFont): (WebCore::FontDataSet::getRenderer): (WebCore::FontDataSet::determinePitch): (WebCore::FontDataSet::invalidate):
  • platform/win/FontWin.cpp: (WebCore::getCairoFont): (WebCore::FontDataSet::~FontDataSet): (WebCore::FontDataSet::determinePitch): (WebCore::FontDataSet::invalidate): (WebCore::FontDataSet::primaryCairoFont):
10:40 AM Changeset in webkit [13246] by hyatt
  • 2 edits in trunk/WebCore/platform/win

FIx a couple of font crashers.

Mar 9, 2006:

11:37 PM Changeset in webkit [13245] by justing
  • 2 edits in trunk/WebCore

Reviewed by adele


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7692>
Should use an iterator in CompositeEditCommand::doUnapply()


~30% speedup of a big undo

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::doUnapply): (WebCore::CompositeEditCommand::doReapply):
6:20 PM Changeset in webkit [13244] by adele
  • 3 edits in trunk/WebCore

Reviewed by Tim O.

Removed unnecessary alerts in TextIterator advance methods.
We want to be able to use advance() even if the iterator is already at the end.

  • editing/visible_text.cpp: (khtml::TextIterator::advance): remove assert since TextIterator will just do nothing if its already at the end. (khtml::CharacterIterator::advance): ditto.
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::visiblePositionForIndex): Since the asserts in the iterator are removed, we don't have to check for it.atEnd() before calling advance.
4:13 PM Changeset in webkit [13243] by thatcher
  • 5 copies in tags/JavaScriptCore-417.10/JavaScriptCore

New tag (part two).

4:12 PM Changeset in webkit [13242] by thatcher
  • 1 add in tags/JavaScriptCore-417.10

New tag.

3:39 PM Changeset in webkit [13241] by hyatt
  • 2 edits in trunk/WebCore

Make text paint with the pen color on Win32. Force ClearType quality. Make the face validation case-insensitive.

3:30 PM Changeset in webkit [13240] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

  • fast/forms/input-appearance-visibility-expected.checksum: Added.
  • fast/forms/input-appearance-visibility-expected.png: Added.
  • fast/forms/input-appearance-visibility-expected.txt: Added.
  • fast/forms/input-appearance-visibility.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/forms/input-appearance-visibility.html

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::setStyle): Sets the style directly on the children of the inner div.
3:27 PM Changeset in webkit [13239] by thatcher
  • 1 edit in branches/Safari-2-0-branch/JavaScriptCore/Info.plist

Versioning

3:21 PM Changeset in webkit [13238] by thatcher
  • 3 edits in branches/Safari-2-0-branch/JavaScriptCore

Merged fix from TOT to Safari-2-0-branch

2006-02-16 Tim Omernick <​timo@apple.com>

Reviewed by Geoff.

<rdar://problem/4428609> Flash Player 8.0.22 can crash Safari (and WebKit apps) with
javascript disabled (7015)

  • bindings/NP_jsobject.cpp: (_NPN_CreateNoScriptObject): Returns an NPObject which is not bound to a JavaScript object. This kind of NPObject can be given to a plugin as the "window script object" when JavaScript is disabled. The object has a custom NPClass, NPNoScriptObjectClass, which has no defined methods. Because of this, none of the NPN_* functions called by the plugin on this "no script object" will cause entry into JavaScript code. (_NPN_InvokeDefault): Make sure the NPVariant is filled before returning from this function. This never mattered before because we never reached this case, having only created NPObjects of the class NPScriptObjectClass. (_NPN_Invoke): ditto (_NPN_Evaluate): ditto (_NPN_GetProperty): ditto
  • bindings/NP_jsobject.h: Declared _NPN_CreateNoScriptObject().
2:48 PM Changeset in webkit [13237] by hyatt
  • 1 edit in trunk/WebCore/platform/win/FontWin.cpp

SetBkMode to transparent so that TextOut doesn't erase the background when drawing text.

1:24 PM Changeset in webkit [13236] by hyatt
  • 8 edits
    2 adds in trunk/WebCore

Check in basic text rendering on Win32.

12:02 PM Changeset in webkit [13235] by justing
  • 3 edits in trunk/WebCore

Reviewed by harrison


Fixed formatting and changed functions to take in
a const Selection& instead of a Selection.

  • editing/ModifySelectionListLevelCommand.cpp: (WebCore::ModifySelectionListLevelCommand::canIncreaseSelectionListLevel): (WebCore::ModifySelectionListLevelCommand::canDecreaseSelectionListLevel): (WebCore::ModifySelectionListLevelCommand::increaseSelectionListLevel): (WebCore::ModifySelectionListLevelCommand::decreaseSelectionListLevel): (WebCore::modifySelectionListLevel): (WebCore::getStartEndListChildren): (WebCore::canIncreaseListLevel): (WebCore::canDecreaseListLevel): (WebCore::ModifySelectionListLevelCommand::increaseListLevel): (WebCore::ModifySelectionListLevelCommand::decreaseListLevel):
  • editing/ModifySelectionListLevelCommand.h:
11:43 AM Changeset in webkit [13234] by adele
  • 4 edits
    4 adds in trunk

LayoutTests:

  • fast/forms/input-appearance-selection-expected.checksum: Added.
  • fast/forms/input-appearance-selection-expected.png: Added.
  • fast/forms/input-appearance-selection-expected.txt: Added.
  • fast/forms/input-appearance-selection.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/input-appearance-selection.html

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): removed extra space. (WebCore::RenderTextField::select): Removed checks for document and m_div since there should always be a document and m_div will be initialized as the renderer gets attached. (WebCore::RenderTextField::selectionStart): Calls indexForVisiblePosition. (WebCore::RenderTextField::selectionEnd): ditto. (WebCore::RenderTextField::setSelectionStart): calls setSelectionRange. (WebCore::RenderTextField::setSelectionEnd): ditto. (WebCore::RenderTextField::setSelectionRange): gets VisiblePositions for both indices, and sets the selection. (WebCore::RenderTextField::visiblePositionForIndex): Added helper method. (WebCore::RenderTextField::indexForVisiblePosition): Added helper method.
  • rendering/RenderTextField.h: Added new helper methods for selection.
9:19 AM Changeset in webkit [13233] by darin
  • 5 edits in trunk/WebKitTools

Reviewed by John Sullivan.

  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_Destroy): Added code to release the plug-in object. This is the leak fix. (NPP_SetWindow): Remove unneeded code to store the window pointer.
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: Moved the browser global in here since it's declared in this file's header. Changed the code to set up the pluginClass structure to not use function pointer casts. Those are dangerous because they can hide many types of mismatch. And indeed when I did this I discovered that many functions were missing their boolean return values or had parameter declarations with the wrong types. (pluginGetProperty): Use STRINGZ_TO_NPVARIANT macro for greater simplicity and clarity. Added boolean return value: return true when successful and false when not. (pluginSetProperty): Added boolean return value, return false since we have no properties we can set. (pluginInvoke): Added boolean return value. Return true when successful and false when not. Use NPVARIANT macros where appropriate. Added a missing release for the return value from calling the browser. Changed code to put the strings in malloc buffers instead of relying on GCC's extension that allows variable-sized arrays on the stack. (pluginInvokeDefault): Added boolean return value, return false since we have no default function to call. (pluginInvalidate): Added missing parameter. Removed comment. (pluginAllocate): Removed unneeded cast. This is C code, not C++, so you don't have to cast the result of malloc. (pluginDeallocate): Removed uneeded cast.
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Removed some unneeded includes. Changed our PluginObject to use NPObject instead of re-declaring fields that match NPObject's fields. Removed unused NPWindow pointer.
8:35 AM Changeset in webkit [13232] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/events/event-sender-mouse-click-expected.txt: Added.
  • fast/events/event-sender-mouse-click.html: Added.

WebKitTools:

Test: fast/events/event-sender-mouse-click.html

Reviewed by Darin.

  • DumpRenderTree/DumpRenderTree.m: (+[EventSendingController isSelectorExcludedFromWebScript:]): (-[EventSendingController mouseClick]): Simulates a click in a native widget by queueing a mouseUp before sending the mouseDown, so that the widget's mouse tracking event loop doesn't hang indefinitely.
8:32 AM Changeset in webkit [13231] by darin
  • 3 edits
    1 copy
    8 moves
    6 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/canvas: Added.
  • fast/canvas/fillrect_gradient-expected.checksum: Added.
  • fast/canvas/fillrect_gradient-expected.png: Added.
  • fast/canvas/fillrect_gradient-expected.txt: Added.
  • fast/canvas/fillrect_gradient.html: Added.
  • moved other canvas tests here
  • fast/canvas/image-object-in-canvas-expected.checksum: Added.
  • fast/canvas/image-object-in-canvas-expected.png: Added.
  • fast/canvas/image-object-in-canvas-expected.txt: Added.
  • fast/canvas/image-object-in-canvas.html: Added.
  • fast/canvas/quadraticCurveTo-expected.checksum: Added.
  • fast/canvas/quadraticCurveTo-expected.png: Added.
  • fast/canvas/quadraticCurveTo-expected.txt: Added.
  • fast/canvas/quadraticCurveTo.xml: Added.
  • fast/canvas/resources: Added.
  • fast/canvas/resources/apple.gif: Added.
  • fast/dom/image-object-in-canvas-expected.checksum: Removed.
  • fast/dom/image-object-in-canvas-expected.png: Removed.
  • fast/dom/image-object-in-canvas-expected.txt: Removed.
  • fast/dom/image-object-in-canvas.html: Removed.
  • fast/dom/quadraticCurveTo-expected.checksum: Removed.
  • fast/dom/quadraticCurveTo-expected.png: Removed.
  • fast/dom/quadraticCurveTo-expected.txt: Removed.
  • fast/dom/quadraticCurveTo.xml: Removed.

WebCore:

Test: fast/canvas/fillrect_gradient.html

Reviewed by Darin.

  • khtml/ecma/kjs_html.cpp: (KJS::Context2DFunction::callAsFunction): Modified fillrect function to check and use a gradient if set. Builds a path to fill rects with a gradient.
8:10 AM Changeset in webkit [13230] by darin
  • 2 edits in trunk/WebCore

No test because this fixes an existing pixel test (and does not affect
the render tree).

Reviewed by Maciej.

  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): Restored AlignRight behavior.
8:05 AM Changeset in webkit [13229] by darin
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • rendering/render_line.cpp: (WebCore::EllipsisBox::paint): Replaced call to Font::drawText with GraphicsContext::drawText, which checks the paintingDisabled flag.
2:57 AM Changeset in webkit [13228] by mjs
  • 10 edits in trunk

WebCore:

Reviewed by Eric.

  • make link clicks work by propagating them up to a client
  • Viewer/ImageView.cpp:
  • bridge/win/FrameWin.cpp:
  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::incomingReferrer):

WebKitTools:

Reviewed by Eric.

  • make link clicks work by handling link click requests from WebCore
  • Spinneret/Spinneret/Spinneret.cpp: (updateLocationBar):
  • Spinneret/Spinneret/Spinneret.h:
  • Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::WebFrame): (WebKit::WebFrame::openURL): (WebKit::WebFrame::loadURL):
  • Spinneret/Spinneret/WebFrame.h:
1:52 AM Changeset in webkit [13227] by eseidel
  • 4 edits in trunk/WebKitTools

2006-03-08 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Focus URL bar on Spinneret launch, remove border from WebView.
Stop WebFrame from deleting the job (prevent crash).

  • Spinneret/Spinneret/Spinneret.cpp: (_tWinMain):
  • Spinneret/Spinneret/WebFrame.cpp: (WebKit::WebFrame::receivedAllData): (WebKit::WebFrame::paint):
  • Spinneret/Spinneret/WebView.cpp: (WebKit::WebView::createWebView):
1:49 AM Changeset in webkit [13226] by eseidel
  • 8 edits in trunk/WebCore

2006-03-09 Eric Seidel <​eseidel@apple.com>

Reviewed by mjs.

Add support for Timers under 10ms.
Fix random crashers due to multi-threaded loading.

  • platform/TransferJob.h:
  • platform/TransferJobInternal.h: (WebCore::TransferJobInternal::TransferJobInternal):
  • platform/Widget.h:
  • platform/win/SharedTimerWin.cpp: (WebCore::TimerWindowWndProc): (WebCore::initializeOffScreenTimerWindow): (WebCore::setSharedTimerFireTime):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::TransferJob::assembleResponseHeaders): (WebCore::TransferJob::retrieveCharset):
  • platform/win/TransferJobWin.cpp: (WebCore::addToOutstandingJobs): (WebCore::removeFromOutstandingJobs): (WebCore::lookupTransferJob): (WebCore::TransferJobWndProc): (WebCore::initializeOffScreenTransferJobWindow): (WebCore::TransferJob::~TransferJob): (WebCore::transferJobStatusCallback): (WebCore::TransferJob::start): (WebCore::TransferJob::cancel):
  • platform/win/WidgetWin.cpp:
Note: See TracTimeline for information about the timeline view.