Timeline



Jun 6, 2006:

8:14 PM Changeset in webkit [14758] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9322
Teach svn-create-patch to sort its output

  • Scripts/svn-create-patch: Clean up perl code. Sort patch output alphabetically by text files first, then by binary files.
8:13 PM Changeset in webkit [14757] by darin
  • 7 edits
    5 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/repaint/containing-block-position-change-expected.checksum: Added.
  • fast/repaint/containing-block-position-change-expected.png: Added.
  • fast/repaint/containing-block-position-change-expected.txt: Added.
  • fast/repaint/containing-block-position-change.html: Added.

WebCore:

Reviewed by Hyatt.

Test (repaint): fast/repaint/containing-block-position-change.html

  • manual-tests/containing-block-position-chage.html: Added.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Unrelated change: fixed typo from the RenderCanvas to RenderView rename. (WebCore::RenderBlock::removePositionedObject): Added a return immediately after removing the object. (WebCore::RenderBlock::removePositionedObjects): Added.
  • rendering/RenderBlock.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle): Added code to remove absolutely positioned descendants from the positioned objects list of their current containing block when they are going to have a new one as a result of this block's position property changing.
  • rendering/RenderObject.h: (WebCore::RenderObject::removePositionedObjects):
8:12 PM Changeset in webkit [14756] by darin
  • 4 edits in trunk/LayoutTests
  • fast/repaint/table-extra-bottom-grow.html: Removed unneeded line of code.
  • fast/repaint/table-extra-bottom-grow-expected.png: Regenerated.
  • fast/repaint/table-extra-bottom-grow-expected.checksum: Regenerated.
5:25 PM Changeset in webkit [14755] by thatcher
  • 1 copy in tags/WebCore-418.13/WebCore

Tag for WebCore 418.13 (part 2 of 2.)

5:25 PM Changeset in webkit [14754] by thatcher
  • 1 add in tags/WebCore-418.13

Tag for WebCore 418.13 (part 1 of 2.)

5:19 PM Changeset in webkit [14753] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

5:13 PM Changeset in webkit [14752] by ggaren
  • 5 edits in branches/Safari-2-0-branch/WebCore

Fix by Maciej, reviewed by Darin. I provided desk space.


Because the garbage collector suspends a thread while marking its stack,
mark methods must not call malloc, because they may end up stuck,
trying to acquire the malloc lock from a suspended thread.

The fix here is:
(1) Use a data member rather than a dictionary to track nodes that are
in the process of marking their subtrees.
(2) Avoid the case wheter calling getDOMNodeForDocument might allocate
the staticDOMNodesPerDocument dictionary.


  • khtml/ecma/kjs_binding.cpp: (KJS::ScriptInterpreter::domObjects): (KJS::ScriptInterpreter::domNodesPerDocument): (KJS::ScriptInterpreter::getDOMNodeForDocument):
  • khtml/ecma/kjs_dom.cpp: (DOMNode::mark):
  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::NodeImpl):
  • khtml/xml/dom_nodeimpl.h:
5:09 PM Changeset in webkit [14751] by justing
  • 86 edits
    12 adds in trunk

LayoutTests:

Reviewed by levi

Added to demonstrate fixes:

  • editing/pasteboard/merge-after-delete-expected.checksum: Added.
  • editing/pasteboard/merge-after-delete-expected.png: Added.
  • editing/pasteboard/merge-after-delete-expected.txt: Added.
  • editing/pasteboard/merge-after-delete.html: Added.
  • editing/inserting/line-break-expected.checksum: Added.
  • editing/inserting/line-break-expected.png: Added.
  • editing/inserting/line-break-expected.txt: Added.
  • editing/inserting/line-break.html: Added.
  • editing/inserting/multiple-lines-selected-expected.checksum: Added.
  • editing/inserting/multiple-lines-selected-expected.png: Added.
  • editing/inserting/multiple-lines-selected-expected.txt: Added.
  • editing/inserting/multiple-lines-selected.html: Added.


Fixed:

  • editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
  • editing/deleting/delete-3775172-fix-expected.txt:
  • editing/deleting/delete-3928305-fix-expected.txt:
  • editing/deleting/delete-3959464-fix-expected.checksum:
  • editing/deleting/delete-3959464-fix-expected.png:
  • editing/deleting/delete-3959464-fix-expected.txt:
  • editing/deleting/delete-4038408-fix-expected.checksum:
  • editing/deleting/delete-4038408-fix-expected.png:
  • editing/deleting/delete-4038408-fix-expected.txt:
  • editing/deleting/delete-4038408-fix.html:
  • editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
  • editing/deleting/delete-at-paragraph-boundaries-011-expected.checksum:
  • editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
  • editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
  • editing/deleting/delete-block-contents-001-expected.txt:
  • editing/deleting/delete-block-contents-002-expected.txt:
  • editing/deleting/delete-block-contents-003-expected.txt:
  • editing/deleting/delete-br-011-expected.checksum:
  • editing/deleting/delete-br-011-expected.png:
  • editing/deleting/delete-br-011-expected.txt:
  • editing/deleting/delete-image-004-expected.txt:
  • editing/deleting/delete-line-010-expected.txt:
  • editing/deleting/delete-line-015-expected.txt:
  • editing/deleting/delete-select-all-001-expected.checksum:
  • editing/deleting/delete-select-all-001-expected.png:
  • editing/deleting/delete-select-all-001-expected.txt:
  • editing/deleting/delete-select-all-002-expected.txt:
  • editing/deleting/delete-select-all-003-expected.checksum:
  • editing/deleting/delete-select-all-003-expected.png:
  • editing/deleting/delete-select-all-003-expected.txt:
  • editing/execCommand/insertImage-expected.checksum:
  • editing/execCommand/insertImage-expected.png:
  • editing/input/attributed-substring-from-range-lines-expected.txt:
  • editing/input/text-input-controller-expected.txt:
  • editing/inserting/insert-3654864-fix-expected.txt:
  • editing/inserting/insert-3659587-fix-expected.txt:
  • editing/inserting/insert-3775316-fix-expected.txt:
  • editing/inserting/insert-after-delete-001-expected.txt:
  • editing/inserting/insert-at-end-01-expected.txt:
  • editing/inserting/insert-at-end-02-expected.txt:
  • editing/inserting/insert-br-001-expected.txt:
  • editing/inserting/insert-br-005-expected.txt:
  • editing/pasteboard/4076267-3-expected.txt:
  • editing/pasteboard/4076267-expected.txt:
  • editing/pasteboard/drag-drop-modifies-page-expected.txt:
  • editing/pasteboard/paste-4035648-fix-expected.txt:
  • editing/pasteboard/paste-4039777-fix-expected.checksum:
  • editing/pasteboard/paste-4039777-fix-expected.png:
  • editing/pasteboard/paste-4039777-fix-expected.txt:
  • editing/pasteboard/paste-match-style-001-expected.txt:
  • editing/pasteboard/paste-match-style-002-expected.txt:
  • editing/pasteboard/smart-paste-006-expected.txt:
  • editing/pasteboard/smart-paste-007-expected.txt:
  • editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • editing/style/block-style-005-expected.txt:
  • editing/style/typing-style-002-expected.txt:
  • editing/unsupported-content/list-delete-001-expected.checksum:
  • editing/unsupported-content/list-delete-001-expected.png:
  • editing/unsupported-content/list-delete-001-expected.txt:
  • editing/unsupported-content/list-delete-002-expected.checksum:
  • editing/unsupported-content/list-delete-002-expected.png:
  • editing/unsupported-content/list-delete-002-expected.txt:
  • editing/unsupported-content/table-delete-001-expected.checksum:
  • editing/unsupported-content/table-delete-001-expected.png:
  • editing/unsupported-content/table-delete-001-expected.txt:
  • editing/unsupported-content/table-delete-003-expected.checksum:
  • editing/unsupported-content/table-delete-003-expected.png:
  • editing/unsupported-content/table-delete-003-expected.txt:
  • fast/text/attributed-substring-from-range.html:

WebCore:

Reviewed by levi

  • dom/Node.cpp: (WebCore::Node::firstDescendant): Added.
  • dom/Node.h:
  • dom/Range.cpp: Added a constructor that takes in Positions. (WebCore::Range::Range):
  • dom/Range.h:
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::insertNodeAt): Let this function insert children into empty containers. Calls canHaveChildrenForEditing. (WebCore::CompositeEditCommand::appendNode): Assert that the parent canHaveChildrenForEditing. (WebCore::CompositeEditCommand::moveParagraph): Tell ReplaceSelectionCommand to select the replacement so that moveParagraph's callers have a valid destination after the move.
  • editing/CompositeEditCommand.h: Moved removeFullySelectedNode to DeleteSelectionCommand, made deleteTextFromNode virtual so that DeleteSelectionCommand can update it's endingPosition.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): Removed m_startNode, used a local variable. (WebCore::DeleteSelectionCommand::initializeStartEnd): Fixed special element expansion. (WebCore::DeleteSelectionCommand::initializePositionData): Compute the endingPosition up front and keep track of it as nodes and text are removed. (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): Removed use of m_startNode. (WebCore::DeleteSelectionCommand::removeFullySelectedNode): Moved from CompositeEditCommand. Update m_endingPosition as we remove nodes. (WebCore::DeleteSelectionCommand::deleteTextFromNode): Update m_endingPosition as we delete text. (WebCore::DeleteSelectionCommand::handleGeneralDelete): Retain the start block. Cleaned up. (WebCore::DeleteSelectionCommand::mergeParagraphs): Recompute m_endingPosition since moveParagraph clobbers the old one. (WebCore::DeleteSelectionCommand::doApply): Fixed the logic for placeholder insertion after deletion. Make the placeholder decision before we do special element expansion.
  • editing/DeleteSelectionCommand.h:
  • editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply): Fixed a bug where an extra br was inserted and cleaned up the code.
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Deletion of the current selection should do a merge (added a testcase).
  • editing/RebalanceWhitespaceCommand.cpp: (WebCore::RebalanceWhitespaceCommand::doUnapply): Remove/insert in a way that will trigger a layout.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Ditto. Merge even when the incoming fragment has interchange newlines (added a testcase). Merge when the selection being pasted into starts at the start of a block because not doing so would leave one or more hanging empty blocks. (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Rebalance whitespace using rebalanceWhitespaceAt because rebalanceWhitespace requires a selection, and a selection can't be created until whitespace has been rebalanced.
  • editing/htmlediting.cpp: (WebCore::canHaveChildrenForEditing): Added.
  • editing/htmlediting.h:
5:03 PM Changeset in webkit [14750] by bdakin
  • 6 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4570475> Dashboard regions do not scale for
non-1.0 scale factors.

No test cases added since this only affects non-1.0 resolution
scale factors.

  • platform/FloatRect.cpp: (WebCore::FloatRect::scale): Added new function that scales a rect's origin and size by a given factor.
  • platform/FloatRect.h:
  • platform/IntRect.cpp: (WebCore::IntRect::scale): Same as above.
  • platform/IntRect.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::addDashboardRegions): After the bounds and clip rects on the Dashboard region have been calculated, get the user space scale factor, and if it is not 1.0, scale the rects.
4:12 PM Changeset in webkit [14749] by brmorris
  • 4 edits in S60/trunk

2006-06-06 Bradley <​bradley.morrison@nokia.com>

Reviewed by dacarson


  • WebKit\group\icons.mk


Added tabs back to icons.mk


  • JavaScriptCore\group\Bwinscw\JAVASCRIPTCOREU.DEF
  • WebCore\BWINS\WEBCOREU.DEF


Regenerated def files

3:58 PM Changeset in webkit [14748] by sullivan
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.


  • fixed <rdar://problem/4566087> REGRESSION (420+): Crash occurs while completing a find again query at ​http://www.apple.com/ (RenderObject::repaint(bool))


This wasn't a new problem in the code, but the recent use of DocumentMarkers for find results brought
it to the surface.

  • dom/Document.h: Use a RefPtr<Node> instead of a Node* in MarkerMap, so the node will be retained
  • dom/Document.cpp: (WebCore::Document::removeMarkers): Add a .get() to compensate for using RefPtr. Also, only repaint if this node actually had a marker removed. (WebCore::Document::repaintMarkers): Add a .get() to compensate for using RefPtr.
3:28 PM Changeset in webkit [14747] by adele
  • 2 edits in trunk/WebKit

Reviewed by Justin.

  • COM/WebView.cpp: (WebView::keyPress): Added case for VK_RETURN.
1:28 PM Changeset in webkit [14746] by brmorris
  • 2 edits in S60/trunk

2006-06-06 Sachin <​sachin.padma@nokia.com>

Reviewed by Zalan/Bradley


Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9332


  • WebKit\group\icons.mk


Search for GCCE in $(PLATFORM), not ARMV5.

12:10 PM Changeset in webkit [14745] by brmorris
  • 5 edits in S60/trunk

2006-06-06 Sachin <​sachin.padma@nokia.com>

Reviewed by Zalan/Bradley


Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9332


  • WebKit\group\icons.mk
  • WebKit\group\webkit.mmp
  • S60WebUi\WebUi\group\WebUi.mmp


Remove relative include paths for data_caging_paths.hrh,
rely on include path instead.


  • S60Internals\S60Headers.zip


Moved data_caging_paths.hrh out of oem to \epoc32\include.

11:26 AM Changeset in webkit [14744] by andersca
  • 3 edits
    2 adds in trunk

WebCore:

2006-06-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9325
clientWidth/clientHeight on document element in strict mode should return visible frame size


  • dom/Element.cpp: (WebCore::Element::clientWidth): (WebCore::Element::clientHeight): If we're the document element, and in strict mode, return the visible size of the frame.


LayoutTests:

2006-06-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9325
clientWidth/clientHeight on document element in strict mode should return visible frame size

  • fast/dom/client-width-height-expected.txt: Added.
  • fast/dom/client-width-height.html: Added.
10:55 AM Changeset in webkit [14743] by andersca
  • 7 edits in trunk

WebCore:

2006-06-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John.

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge containsPlugins]):
  • page/Frame.cpp: (WebCore::Frame::containsPlugins):
  • page/Frame.h: Add containsPlugins function which returns whether a frame contains plugins or not.

WebKit:

2006-06-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John.

  • WebView/WebFrame.m: (-[WebFrame _reloadForPluginChanges]): Don't traverse the view hierarchy looking for plugin views. Instead, just ask the frame whether it contains any plugins.

Jun 5, 2006:

10:59 PM Changeset in webkit [14742] by ggaren
  • 2 edits
    1 add in trunk/JavaScriptCore

Reviewed and landed by Geoff.

  • fix a regression in ecma_3/String/regress-104375.js
  • kjs/string_object.cpp: (substituteBackreferences): If a 2-digit back reference is out of range, parse it as a 1-digit reference (followed by the other digit). This matches Firefox's behavior.
8:52 PM Changeset in webkit [14741] by sfalken
  • 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

2006-06-06 Steve Falkenburg <​sfalken@apple.com>

Fix build break

  • platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::roundToDevicePixels):
8:13 PM Changeset in webkit [14740] by ddkilzer
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by mjs.

testcases for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=5564
'font' shorthand parsing should be more tolerant in quirks mode

  • fast/css/font_property_compatibility-expected.checksum: Added.
  • fast/css/font_property_compatibility-expected.png: Added.
  • fast/css/font_property_compatibility-expected.txt: Added.
  • fast/css/font_property_compatibility.html: Added.
  • fast/css/font_property_normal-expected.checksum: Added.
  • fast/css/font_property_normal-expected.png: Added.
  • fast/css/font_property_normal-expected.txt: Added.
  • fast/css/font_property_normal.html: Added.

WebCore:

Reviewed by mjs.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=5564
'font' shorthand parsing should be more tolerant in quirks mode

When not in strict mode accept font property specifications
lacking a font family part, like WinIE does.

  • css/cssparser.cpp: (WebCore::CSSParser::parseFont):
7:27 PM Changeset in webkit [14739] by bdakin
  • 10 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/4567520> Pixel cracks in weather widget at
1.83 scaling

To prevent pixel cracks at non-integral scaling factors, before we
call into CG to draw an image, we have to convert the rect to
device space, round the origin and size to integers in device
space, and convert back to user space.


No test cases added since this only affects non-1.0 resolution
scale factors.

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp: (WebCore::JSCanvasRenderingContext2D::drawImage): drawImage() now takes FloatRects.
  • html/CanvasPattern.cpp: (WebCore::patternCallback): Call roundToDevicePixels()
  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage): drawImage() now takes FloatRects and call roundToDevicePixels()
  • html/CanvasRenderingContext2D.h: drawImage() now takes FloatRects.
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::paint): Call roundToDevicePixels()
  • kcanvas/device/quartz/QuartzSupport.mm: (WebCore::debugDumpCGImageToFile): Same as above.
  • platform/GraphicsContext.h:
  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::roundToDevicePixels): Takes care of converting between coordinate spaces and rounding. (WebCore::GraphicsContext::drawLineForText):
  • platform/mac/ImageMac.mm: Call roundToDevicePixels() (WebCore::Image::draw): Same as above. (WebCore::drawPattern): Same as above.
6:51 PM Changeset in webkit [14738] by ddkilzer
  • 2 edits in trunk/LayoutTests

LayoutTests:

Reviewed by ggaren.

  • fast/dom/global-constructors-expected.txt: Fixed test results.
5:23 PM Changeset in webkit [14737] by hyatt
  • 1 edit in trunk/WebKit/COM/WebView.cpp

Fix for perf regression with single-processor windows machines on ibench.

3:12 PM Changeset in webkit [14736] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed By Maciej.
Darin already reviewed this change on the branch. See <rdar://problem/4317701>.


  • Fixed <rdar://problem/4291345> PCRE overflow in Safari JavaScriptCore

No test case because there's no behavior change.


  • pcre/pcre_compile.c: (read_repeat_counts): Check for integer overflow / out of bounds
10:15 AM Changeset in webkit [14735] by ggaren
  • 12 edits
    2 adds
    2 deletes in trunk

LayoutTests:

  • Merged test-prototypes.html into global-constructors.html
  • Added prototypes.html, which tests for some missing prototypes in DOM objects


  • fast/dom/global-constructors-expected.txt:
  • fast/dom/global-constructors.html:
  • fast/dom/prototypes-expected.txt: Added.
  • fast/dom/prototypes.html: Added.
  • fast/dom/test-prototypes-expected.txt: Removed.
  • fast/dom/test-prototypes.html: Removed.
  • fast/dom/undetectable-document-all-expected.txt: Updated to reflect change from "HTMLCollection" to "Collection"

WebCore:

Reviewed by Darin.

  • Added the built-in object prototype to DOM objects that were missing it so that primitive operations like == work on them.


  • Removed dead EventConstructor class (it's autogenerated now)


  • Changed HTML collections to describe themselves as "[object Collection]", to match IE.


  • Made DOMCSSRule constructor private because JSCSSRule is the class to use.


  • bindings/js/JSHTMLOptionElementConstructor.cpp: (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
  • bindings/js/kjs_css.cpp: (KJS::DOMStyleSheet::DOMStyleSheet): (KJS::DOMStyleSheetList::DOMStyleSheetList): (KJS::DOMCSSRule::DOMCSSRule): (KJS::DOMCSSValue::DOMCSSValue): (KJS::toJS): (KJS::DOMRGBColor::DOMRGBColor): (KJS::getDOMRGBColor): (KJS::DOMRect::DOMRect):
  • bindings/js/kjs_css.h:
  • bindings/js/kjs_dom.cpp: (KJS::DOMNodeList::DOMNodeList): (KJS::DOMExceptionConstructor::DOMExceptionConstructor): (KJS::DOMExceptionConstructor::getOwnPropertySlot): (KJS::): (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection):
  • bindings/js/kjs_dom.h: (KJS::DOMNamedNodesCollection::classInfo):
  • bindings/js/kjs_events.h:
  • bindings/js/kjs_html.cpp: (KJS::):
9:37 AM Changeset in webkit [14734] by ggaren
  • 4 edits in trunk/JavaScriptCore

Reviewed by aliu.

  • Changed CString length from int to size_t. We sould probably do this for UString, too. (Darin, if you're reading this: Maciej said so.)


  • kjs/function.cpp: (KJS::encode):
  • kjs/ustring.cpp: (KJS::CString::CString): (KJS::operator==):
  • kjs/ustring.h: (KJS::CString::size):

Jun 4, 2006:

10:20 PM Changeset in webkit [14733] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • bindings/js/kjs_window.cpp: Added include of <wtf/MathExtras.h>. (WebCore::floatFeature): Remove WIN32 ifdef around isnan. (WebCore::toJS): Add null checks.
9:15 PM Changeset in webkit [14732] by darin
  • 4 edits
    2 adds in trunk

LayoutTests:

  • fast/loader/link-no-URL.html: Added.
  • fast/loader/link-no-URL-expected.txt: Added.

WebCore:

Reviewed by Maciej.

Test: fast/loader/link-no-URL.html

  • loader/Cache.h:
  • loader/Cache.cpp: (WebCore::Cache::updateCacheStatus): Removed the URL parameter. Instead get the URL from the cached object itself. Callers were passing in the wrong URL. When it was a null string, it caused the crash mentioned above. But in other cases it may have caused some other minor problems as well. Added an assert to catch cases where the URL is null (should never happen). (WebCore::Cache::requestImage): Changed call site to not pass URL. (WebCore::Cache::requestStyleSheet): Ditto. (WebCore::Cache::requestScript): Ditto. (WebCore::Cache::requestXSLStyleSheet): Ditto. (WebCore::Cache::requestXBLDocument): Ditto.
8:09 PM Changeset in webkit [14731] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.


  • kjs/value.h: Removed redundant declarations
4:05 PM Changeset in webkit [14730] by darin
  • 2 edits in trunk/WebCore

Reviewed by Adele.

  • platform/mac/WebCoreTextField.mm: (inputElement): Added. Helper function to get the Objective-C wrapper for an input element associated with a QTextEdit. Returns nil if the element is not an input element. The bug was caused by passing a non-input element to the delegate methods. (-[KWQTextFieldController controlTextDidBeginEditing:]): Use inputElement and don't make the delegate call at all if there is none. This happens only with isindex elements; it's not important to have auto-fill work with those. (-[KWQTextFieldController controlTextDidEndEditing:]): Ditto. (-[KWQTextFieldController controlTextDidChange:]): Ditto. (-[KWQTextFieldController control:textShouldEndEditing:]): Ditto. (-[KWQTextFieldController control:textView:doCommandBySelector:]): Ditto. (-[KWQTextFieldController textView:shouldHandleEvent:]): Ditto.
4:03 PM Changeset in webkit [14729] by darin
  • 36 edits in trunk/WebCore

Reviewed by Anders.

  • fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8995 memory leak in XPath code -- seen in layout tests
  • fixed malloc error on exit due to SVGDOMImplementation destructor
  • attempted to fix the no-XPATH_SUPPORT build by adding an #if
  • changed around includes and header-file formatting in XPath code
  • bindings/scripts/CodeGeneratorJS.pm: Include PlatformString.h when generating the bindings for XPathNSResolver.
  • dom/DOMImplementation.h: Added a virtual destructor for the benefit of SVGDOMImplementation.
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::~DOMImplementation): Added.
  • ksvg2/svg/SVGDOMImplementation.h: Reformatted a bit, removed unneeded declarations.
  • ksvg2/svg/SVGDOMImplementation.cpp: (SVGDOMImplementation::~SVGDOMImplementation): Remove commented-out code. (SVGDOMImplementation::createDocument): Remove a reference to KDOMView.
  • xpath/XPathExpression.cpp: (WebCore::XPathExpression::createExpression): Called release to avoid a tiny bit of reference count churn. (WebCore::XPathExpression::evaluate): Set exception code explicitly, because the code relies on it being 0 when the function succeeds.
  • xpath/XPathResult.cpp: (WebCore::InvalidatingEventListener::InvalidatingEventListener): Removed unneeded target node data member. (WebCore::XPathResult::XPathResult): Updated for enum name changes and InvalidatingEventListener name change. Added an assertion.
  • xpath/impl/XPathFunctions.h: Removed the FunctionLibrary class. Changed the parameter for createFunction to be a String instead of char*.
  • xpath/impl/XPathFunctions.cpp: Got rid of local implementation of "round", and used <wtf/MathExtras.h> instead. Also removed unused Interval::asString. Marked all the Interval functions inline. (WebCore::XPath::FunSubstring::doEvaluate): Use lround() instead of (long)round(). (WebCore::XPath::FunLang::doEvaluate): Removed some unneeded temporary String variables. Use equalIgnoringCase() instead of calling lower() on two strings. (WebCore::XPath::createFunctionMap): Changed how this works so that it's all local to this function. Also removed a duplicate entry for the "last" function. (WebCore::XPath::createFunction): Changed from a member function to a separate function. Also changed so that if the args are not used in the function they are deleted. This was one of the sources of the storage leaks.
  • xpath/impl/XPathGrammar.y: Put XPATH_SUPPORT ifdef in. Replaced <num> with values of specific types (numop, eqop). Updated for name change from AxisType to Axis. Changed tokens that were declared as <str> but weren't actually using the string to be declared with no type (PLUS, MINUS, OR, AND, DOTDOT, SLASHSLASH). Replaced use of unregisterString, unregisterPredicateVector, and unregisterExpressionVector to call delete functions instead that both unregister and delete. Change call sites for createFunction to just use the String, removing the deprecatedString().latin1() call that is no longer needed. Added a call to unregisterParseNode that was missing in the "FilterExpr DescendantOrSelf RelativeLocationPath" production.
  • xpath/impl/XPathParser.h: Changed Token to hold a String, Step::Axis, NumericOp::Opcode, and EqTestOp::Opcode. The token ID number tells us which to use. Rearranged to put the private part of the Parser class last. Moved a number of private things inside the cpp file.
  • xpath/impl/XPathParser.cpp: (WebCore::XPath::charCat): Made this a separate function, instead of a static member. (WebCore::XPath::isAxisName): Ditto. Also put the global axis map inside the function, allowing use of a map instead of a map pointer. (WebCore::XPath::isNodeTypeName): Ditto. (WebCore::XPath::Parser::isOperatorContext): Made this const. (WebCore::XPath::Parser::makeTokenAndAdvance): Got rid of the "int" version of this. By using the actual types, we can safely use overload instead. (WebCore::XPath::Parser::lexString): Use substring() instead of deprecatedString().mid(). (WebCore::XPath::Parser::lexNumber): Ditto. (WebCore::XPath::Parser::lexNCName): Changed to return a bool and a String instead of a Token. This avoids the hack of using a token value of "ERROR + 1" which I found quite confusing and is also a bit more explicit. (WebCore::XPath::Parser::lexQName): Ditto. (WebCore::XPath::Parser::nextTokenInternal): Changed to adapt to the changes above and to remove some unneeded else statements. (WebCore::XPath::Parser::lex): Changed the logic that sets up yylval to use the token ID to decide what the type is. This matches what the grammar expects, and removes the need for the token object to track which part of the value is good and the need to reserve 0 to have a special meaning. (WebCore::XPath::Parser::parseStatement): Added code to delete the predicates and the expressions in the predicate and expression vectors. Before, we were only deleting the vectors. This was one of the sources of the storage leaks. (WebCore::XPath::Parser::deletePredicateVector): Renamed, and changed to delete the vector. However this does not delete the predicates in the vector. (WebCore::XPath::Parser::deleteExpressionVector): Renamed, and changed to delete the vector. However this does not delete the expressions in the vector. (WebCore::XPath::Parser::deleteString): Renamed, and changed to delete the string.
  • xpath/impl/XPathPredicate.h:
  • xpath/impl/XPathPredicate.cpp: (WebCore::XPath::NumericOp::NumericOp): Changed opcode from an int to an enum, and renamed to "opcode" instead of "opCode". (WebCore::XPath::NumericOp::doEvaluate): More of the same. (WebCore::XPath::EqTestOp::EqTestOp): Ditto. (WebCore::XPath::EqTestOp::doEvaluate): Ditto. (WebCore::XPath::LogicalOp::LogicalOp): Ditto. (WebCore::XPath::LogicalOp::shortCircuitOn): Ditto. (WebCore::XPath::Predicate::evaluate): Removed an unneeded "new".
  • xpath/impl/XPathStep.h:
  • xpath/impl/XPathStep.cpp: Renamed AxisType to Axis. Removed unused axisAsString function and default constructor.
  • xpath/impl/XPathValue.h: Renamed the type constants to have a Value suffix, instead of the underscore suffix used before on NodeVector and String.
  • xpath/impl/XPathValue.cpp: Updated for name change. Added asserts.
  • xpath/impl/XPathVariableReference.cpp: (WebCore::XPath::VariableReference::doEvaluate): Use a reference instead of a pointer.
  • xpath/XPathEvaluator.cpp:
  • xpath/XPathEvaluator.h:
  • xpath/XPathExpression.h:
  • xpath/XPathNSResolver.cpp:
  • xpath/XPathNSResolver.h:
  • xpath/XPathNamespace.cpp:
  • xpath/XPathNamespace.h:
  • xpath/XPathResult.h:
  • xpath/impl/XPathExpressionNode.cpp:
  • xpath/impl/XPathExpressionNode.h:
  • xpath/impl/XPathPath.cpp:
  • xpath/impl/XPathPath.h:
  • xpath/impl/XPathUtil.cpp:
  • xpath/impl/XPathUtil.h:
  • xpath/impl/XPathVariableReference.h: Reformatted and changed includes around; no substantive changes.
3:51 PM Changeset in webkit [14728] by darin
  • 5 edits in trunk/JavaScriptCore

Reviewed by Anders.

  • changed deleteAllValues so it can work on "const" collections Deleting the values affects the values, not the pointers in the collection, so it's legitimate to do it to a const collection, and a case of that actually came up in the XPath code.
  • wtf/HashMap.h: (WTF::deleteAllPairSeconds): Use const iterators. (WTF::deleteAllValues): Take const HashMap reference as a parameter.
  • wtf/HashSet.h: (WTF::deleteAllValues): Take const HashSet reference as a parameter, and use const iterators.
  • wtf/Vector.h: (WTF::deleteAllValues): Take const Vector reference as a parameter.
  • added more functions that are present in <math.h> on some platforms, but not on others; moved here from various files in WebCore
  • wtf/MathExtras.h: (isinf): Added. (isnan): Added. (lround): Added. (lroundf): Tweaked. (round): Added. (roundf): Tweaked. (signbit): Added.
3:41 PM Changeset in webkit [14727] by ddkilzer
  • 4 edits
    32 adds in trunk

LayoutTests:

Reviewed by hyatt.

  • fast/block/positioning/absolute-in-inline-ltr-2.html: Added.
  • fast/block/positioning/absolute-in-inline-ltr-3.html: Added.
  • fast/block/positioning/absolute-in-inline-ltr.html: Added.
  • fast/block/positioning/absolute-in-inline-rtl-2.html: Added.
  • fast/block/positioning/absolute-in-inline-rtl-3.html: Added.
  • fast/block/positioning/absolute-in-inline-rtl.html: Added.
  • fast/block/positioning/absolute-in-inline-short-ltr.html: Added.
  • fast/block/positioning/absolute-in-inline-short-rtl.html: Added.

WebCore:

Reviewed by hyatt.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockWidthForPositioned): (WebCore::RenderBox::containingBlockHeightForPositioned): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
  • rendering/RenderBox.h:
2:41 PM Changeset in webkit [14726] by brmorris
  • 3 edits in S60/trunk

2006-06-04 Bradley <​bradley.morrison@nokia.com>

Reviewed by nobody (oops!)


Webkit.rsg gets processed before webkit.mmp. Fix for nonfatal:


No rule to make target `\EPOC32\INCLUDE\Webkit.rsg'

2:07 PM Changeset in webkit [14725] by brmorris
  • 22 edits
    17 adds in S60/trunk

2006-06-04 Zalan <​zalan.bujtas@nokia.com>

Reviewed by Sachin/Bradley


This commit introduces S60 3.1 support to S60WebKit's
WebKit / BrowserCore (part 3 of 3).

2:04 PM Changeset in webkit [14724] by brmorris
  • 19 edits
    15 adds in S60/trunk

2006-06-04 Zalan <​zalan.bujtas@nokia.com>

Reviewed by Sachin/Bradley


This commit introduces S60 3.1 support to S60WebKit's
WebKit / Plugin and BrowserView (part 2.8 of 3).

1:58 PM Changeset in webkit [14723] by brmorris
  • 46 edits
    11 adds in S60/trunk

2006-06-04 Zalan <​zalan.bujtas@nokia.com>

Reviewed by Sachin/Bradley


This commit introduces S60 3.1 support to S60WebKit's
WebKit / BrowserControl (part 2.6 of 3).

1:54 PM Changeset in webkit [14722] by brmorris
  • 11 edits
    1 add in S60/trunk

2006-06-04 Zalan <​zalan.bujtas@nokia.com>

Reviewed by Sachin/Bradley


This commit introduces S60 3.1 support to S60WebKit's
WebKit / BrowserControl (part 2.2 of 3).

1:37 PM Changeset in webkit [14721] by ddkilzer
  • 3 edits in trunk/WebKitSite

WebKitSite:

Reviewed by ggaren.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9303
JavaScript error when loading WebKit blog page

  • blog/wp-content/themes/webkit/sidebar.php: Removed unused JavaScript. Synced with nav.inc.
  • nav.inc: Removed evil tabs--whitespace change only.
1:12 PM Changeset in webkit [14720] by brmorris
  • 77 edits in S60/trunk

2006-06-04 Zalan <​zalan.bujtas@nokia.com>

Reviewed by Sachin/Bradley


This commit introduces S60 3.1 support to S60WebKit's
Reindeer UI and WebCore (part 2 of 3).

1:05 PM Changeset in webkit [14719] by brmorris
  • 19 edits
    2 adds in S60/trunk

2006-06-04 Zalan <​zalan.bujtas@nokia.com>

Reviewed by Sachin/Bradley


This commit introduces S60 3.1 support to S60WebKit's
JavaScriptCore, MemoryManager and S60Internals (part 1 of 3).

11:52 AM Changeset in webkit [14718] by ddkilzer
  • 4 edits in trunk/WebKitTools

WebKitTools:

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9299
Teach svn-create-patch and friends to work with binary files

  • Scripts/svn-apply: Updated to use base64-encoded text for binary files when applying patches.
  • Scripts/svn-create-patch: Updated to include binary file content as base64-encoded text in patches.
  • Scripts/svn-unapply: Updated to recognize binary files when unapplying patches.
1:08 AM Changeset in webkit [14717] by andersca
  • 11 edits
    3 adds in trunk

WebCore:

2006-06-04 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9035
document.evaluate and createNSResolver miss on namespaced elements


  • xpath/XPathExpression.cpp: (WebCore::XPathExpression::createExpression): Pass the resolver to the parser.


  • xpath/XPathResult.cpp: (WebCore::XPathResult::iterateNext): Fix off-by-one error.


  • xpath/impl/XPathExpressionNode.h: (WebCore::XPath::EvaluationContext::EvaluationContext): Get rid of the resolver in the evaluation context.


  • xpath/impl/XPathGrammar.y: Fetch the resolver from the parser. Only return the local name.


  • xpath/impl/XPathParser.cpp: (WebCore::XPath::Parser::parseStatement):
  • xpath/impl/XPathParser.h: (WebCore::XPath::Parser::resolver): Update to hold the resolver.


  • xpath/impl/XPathStep.cpp: (WebCore::XPath::Step::Step): If the parser has stored a namespace URI, set it.


(WebCore::XPath::Step::nodeTestMatches):
Check namespace URIs.


  • xpath/impl/XPathStep.h: Add m_namespaceURI.

LayoutTests:

2006-06-04 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9035
document.evaluate and createNSResolver miss on namespaced elements

  • fast/xpath: Added.
  • fast/xpath/xpath-namespaces-expected.txt: Added.
  • fast/xpath/xpath-namespaces.html: Added.

Jun 3, 2006:

9:33 PM Changeset in webkit [14716] by ddkilzer
  • 1 edit
    1 add in trunk/LayoutTests

LayoutTests:

Reviewed by Eric.

Added missing pixel test output:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8848
TFOOT borders are copied to THEAD and TBODY

  • fast/table/border-collapsing/border-collapsing-head-foot-expected.png: Added.
3:23 PM Changeset in webkit [14715] by ddkilzer
  • 9 edits
    4 adds
    2 deletes in trunk

LayoutTests:

Reviewed by mjs. Tweaked and landed by ddkilzer.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7281
With java disabled wrong information is displayed.

  • fast/replaced/applet-rendering-java-disabled.html: Added.
  • fast/replaced/applet-rendering-java-disabled-expected.checksum: Added.
  • fast/replaced/applet-rendering-java-disabled-expected.html: Added.
  • fast/replaced/applet-rendering-java-disabled-expected.png: Added.
  • tables/mozilla_expected_failures/bugs/bug8499-expected.checksum: Changed after removing RenderEmptyApplet.
  • tables/mozilla_expected_failures/bugs/bug8499-expected.png: Ditto.
  • tables/mozilla_expected_failures/bugs/bug8499-expected.txt: Ditto.

WebCore:

Reviewed by mjs. Tweaked and landed by ddkilzer.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7281
With java disabled wrong information is displayed.

Test: fast/replaced/applet-rendering-java-disabled.html

Match WinIE, render applet content inline when java is
disabled.

  • WebCore.vcproj/WebCore/WebCore.vcproj: Removed RenderEmptyApplet.cpp and RenderEmptyApplet.h.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::createRenderer):
  • rendering/RenderEmptyApplet.cpp: Removed.
  • rendering/RenderEmptyApplet.h: Removed.
1:40 PM Changeset in webkit [14714] by thatcher
  • 3 edits
    5 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/dom/HTMLLinkElement/pending-stylesheet-count.html: Added.
  • fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.txt: Added.
  • fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.png: Added.
  • fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.checksum: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/dom/HTMLLinkElement/pending-stylesheet-count.html

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::~HTMLLinkElement): If the stylesheet was being loaded, call stylesheetLoaded() on the document, to keep the pending stylesheet count correct.
1:38 PM Changeset in webkit [14713] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9296
Performance improvement for svn-create-patch

  • Scripts/svn-create-patch: Undef $indexPath after all paths have been fixed for a given patch.
1:03 PM Changeset in webkit [14712] by darin
  • 2 edits in trunk/WebCore
  • fix Windows build
  • platform/Widget.h: Moved scaleFactor function out of Apple-specific section of the header into the common part.
11:37 AM Changeset in webkit [14711] by bdakin
  • 5 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/4537274> HiDPI: <canvas> needs to apply a
scale. <canvas> needs to scale itself along with whatever scale
factor is set on the window.

  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::createDrawingContext): Get the scale factor and use it to create a larger buffer and to scale the CGContext.
  • platform/Widget.h: Provide a new function that returns the user space scale factor.
  • platform/mac/WidgetMac.mm: (WebCore::Widget::scaleFactor): Get the scale factor from the window and return it.
  • platform/win/WidgetWin.cpp: (WebCore::Widget::scaleFactor): Just return 1.0f for now.
10:59 AM Changeset in webkit [14710] by ddkilzer
  • 3 edits in trunk/WebKitTools

WebKit:

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9290
Teach svn-apply and svn-unapply to patch ChangeLogs cleanly

  • Scripts/svn-apply: Fixed to apply ChangeLog patches without failing.
  • Scripts/svn-unapply: Ditto. Also simplified reversing a deletion.
12:16 AM Changeset in webkit [14709] by sfalken
  • 1 delete in trunk/WebKitWin

2006-06-03 Steve Falkenburg <​sfalken@apple.com>

Reviewed by hyatt.


Removed unused code.

12:15 AM Changeset in webkit [14708] by sfalken
  • 5 edits in trunk/WebKitTools

2006-06-03 Steve Falkenburg <​sfalken@apple.com>

Reviewed by hyatt.


Switch Spinneret to new hosting mechanism

  • Spinneret/Spinneret.sln:
  • Spinneret/Spinneret/Spinneret.cpp: (SpinneretWebHost::updateAddressBar): (SpinneretWebHost::QueryInterface): (SpinneretWebHost::AddRef): (SpinneretWebHost::Release): (resizeSubViews): (_tWinMain): (WndProc): (MyEditProc): (About): (loadURL):
  • Spinneret/Spinneret/Spinneret.h: (SpinneretWebHost::didStartProvisionalLoadForFrame): (SpinneretWebHost::didReceiveServerRedirectForProvisionalLoadForFrame): (SpinneretWebHost::didFailProvisionalLoadWithError): (SpinneretWebHost::didCommitLoadForFrame): (SpinneretWebHost::didReceiveTitle): (SpinneretWebHost::didReceiveIcon): (SpinneretWebHost::didFinishLoadForFrame): (SpinneretWebHost::didFailLoadWithError): (SpinneretWebHost::didChangeLocationWithinPageForFrame): (SpinneretWebHost::willPerformClientRedirectToURL): (SpinneretWebHost::didCancelClientRedirectForFrame): (SpinneretWebHost::willCloseFrame): (SpinneretWebHost::windowScriptObjectAvailable):
  • Spinneret/Spinneret/Spinneret.vcproj:
12:13 AM Changeset in webkit [14707] by sfalken
  • 2 edits in trunk/WebKit

2006-06-03 Steve Falkenburg <​sfalken@apple.com>

Reviewed by hyatt.


Add implementation of loadHTMLString for Spinneret

  • COM/WebFrame.cpp: (WebFrame::loadHTMLString):
12:10 AM Changeset in webkit [14706] by sfalken
  • 2 edits in trunk/WebCore

2006-06-03 Steve Falkenburg <​sfalken@apple.com>

Reviewed by hyatt.

Don't send empty referrers. Fixes image load fail on Spinneret default content.

  • platform/win/TransferJobWin.cpp: (WebCore::TransferJob::start):

Jun 2, 2006:

9:56 PM Changeset in webkit [14705] by ddkilzer
  • 3 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by ggaren.

Test: fast/js/string-replace-3.html

  • kjs/string_object.cpp: (substituteBackreferences): Added support for $& (matched substring), $` (everything preceding matched substring), $' (everything following matched substring) and 2-digit back references, and cleaned up a little.

LayoutTests:

Reviewed by ggaren.

  • fast/js/resources/string-replace-3.js: Added.
  • fast/js/string-replace-3-expected.txt: Added.
  • fast/js/string-replace-3.html: Added.
6:41 PM Changeset in webkit [14704] by adele
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Windows theme for textareas. Also made some formatting changes.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::supportsFocus): (WebCore::RenderThemeWin::getThemeData): (WebCore::RenderThemeWin::adjustButtonStyle): (WebCore::RenderThemeWin::adjustTextFieldStyle): (WebCore::RenderThemeWin::adjustTextAreaStyle): (WebCore::RenderThemeWin::paintTextArea):
  • rendering/RenderThemeWin.h: (WebCore::RenderThemeWin::supportsHover):
6:28 PM Changeset in webkit [14703] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Hyatt, checked in by Tim H.

Explicitly run perl on *.pl files instead of relying
on Windows shell figuring out which program to run for
this extention.

  • DerivedSources.make:
6:16 PM Changeset in webkit [14702] by adele
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

Set incremental linking to no. This seems to fix a build problem I was seeing
where dftables couldn't find a dll.

6:15 PM Changeset in webkit [14701] by thatcher
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by Hyatt, checked in by Tim H.

For: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9115
Added test case to test opacity layers, in particular, opacities
with a value of zero.

  • fast/css/ZeroOpacityLayers.html: Added.
  • fast/css/ZeroOpacityLayers-expected.txt: Added.
  • fast/css/ZeroOpacityLayers-expected.png: Added.
  • fast/css/ZeroOpacityLayers-expected.checksum: Added.
  • fast/css/ZeroOpacityLayers2.html: Added.
  • fast/css/ZeroOpacityLayers2-expected.txt: Added.
  • fast/css/ZeroOpacityLayers2-expected.png: Added.
  • fast/css/ZeroOpacityLayers2-expected.checksum: Added.

WebCore:

Reviewed by Hyatt, checked in by Tim H.

fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9115
Changed RenderLayer to only render layers that are not
totally transparent.

  • rendering/RenderLayer.cpp (RenderLayer::paintLayer): Changed function to also check if the layer is totally transparent and if it is, don't bother painting it.
5:52 PM Changeset in webkit [14700] by thatcher
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt, checked in by Tim H.

Adding testcase for bug 8223.

  • fast/dom/css-inline-style-important-expected.checksum: Added.
  • fast/dom/css-inline-style-important-expected.png: Added.
  • fast/dom/css-inline-style-important-expected.txt: Added.
  • fast/dom/css-inline-style-important.html: Added.

WebCore:

Reviewed by Hyatt, checked in by Tim H.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8223
WebKit fails to update style on element via DOM

Handle !important by detecting it and using a different code
path from normal priority.

  • bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::put):
  • css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::setProperty):
  • css/CSSStyleDeclaration.h:
5:19 PM Changeset in webkit [14699] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Geoff, checked in by Maciej.



  • dom/Element.cpp: (WebCore::Element::focus): Do the updateLayout call before calling isFocusable, since isFocusable looks at the size of the renderer.
3:35 PM Changeset in webkit [14698] by brmorris
  • 3 edits in S60/trunk

2006-06-02 Shyam <​Shyam.Sareen@nokia.com>

Reviewed by Zalan/Bradley


  • S60WebUi\HomePage\src\BookmarkPageGen.cpp
  • S60WebUi\HomePage\src\SettingsPageGen.cpp


  • Bookmarks & Setting Menu Options not working on hardware due to overzealous WINS flags.


Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=9256

2:57 PM Changeset in webkit [14697] by brmorris
  • 13 edits
    9 deletes in S60/trunk

2006-06-02 Bradley <​bradley.morrison@nokia.com>

Reviewed by Sachin


  • Webkit/BrowserControl
  • Webkit/BrowserView
  • S60Internals


  • This is a port of ccm task 11164 (WML interface changes)
2:49 PM Changeset in webkit [14696] by thatcher
  • 1 copy in tags/WebCore-418.12/WebCore

Tag for WebCore 418.12 (part 2 of 2.)

2:49 PM Changeset in webkit [14695] by thatcher
  • 1 add in tags/WebCore-418.12

Tag for WebCore 418.12 (part 1 of 2.)

2:49 PM Changeset in webkit [14694] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

2:47 PM Changeset in webkit [14693] by thatcher
  • 3 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Darin and Eric.

<rdar://problem/4523402> SUTiLondon: XSL file containing <xsl:include href="../Styles/EscapeString.xsl" /> fails to load file

The decoder was returning a null string for the EscapeString stylesheet because it didn't specify an encoding.
If we do not find an encoding we need to assume it is UTF-8.

We also need to load DTD files in xml documents for this test to fully work like Win IE.
Wrapping XMLTokenizer's xmlReadMemory with setLoaderForLibXMLCallbacks to load any files XML needs through the docLoader.

However, this further exposes <rdar://problem/4292995> (libxml2 looks for file in /etc/xml/catalog, but the file is not installed)
This causes Safari to show an error in the activity window about ​file:///etc/xml/catalog. To prevent this we can set
the XML_CATALOG_FILES environment variable to an empty string. We will only set this env var if it hasn't been set already.
This allows someone to launch Safari with a custom catalog if that was ever needed.

  • khtml/misc/decoder.cpp: (Decoder::decode):
  • khtml/xml/xml_tokenizer.cpp: (khtml::XMLTokenizer::setTransformSource):
1:50 PM Changeset in webkit [14692] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Maciej.



For a synchronous XMLHttpRequest, the JavaScript interpreter initiating
the request would deadlock with the JavaScript interpreter spawned by
the request to execute the PAC file.


The solution here is to temporarily drop the initiating interpreter's locks
before making the request, and re-acquire the locks afterwards. Because
the initiating interpreter waits for the request to complete before
continuing execution, it is free to drop its locks while the request
is in progress.

  • khtml/ecma/xmlhttprequest.cpp: (KJS::XMLHttpRequest::send):
12:35 PM Changeset in webkit [14691] by sfalken
  • 2 edits in trunk/WebKitTools

2006-06-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by darin.


Updated build script

  • Scripts/build-webkit:
12:35 PM Changeset in webkit [14690] by sfalken
  • 3 edits in trunk/WebKitWin

2006-06-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by darin.


Updated to latest hosting interface

  • WebFramePrivate.cpp: (WebKit::WebFramePrivate::openURL): (WebKit::WebFramePrivate::setTitle): (WebKit::WebFramePrivate::setStatusText):
  • WebFramePrivate.h:
12:34 PM Changeset in webkit [14689] by sfalken
  • 5 edits in trunk/WebCore

2006-06-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by darin.

Platform hookup fixes

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::setTitle): (WebCore::FrameWin::setStatusBarText):
  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::overrideMediaType):
  • platform/win/TransferJobWin.cpp: (WebCore::TransferJobWndProc): (WebCore::TransferJob::start): (WebCore::TransferJob::fileLoadTimer): (WebCore::TransferJob::cancel):
12:32 PM Changeset in webkit [14688] by sfalken
  • 1 edit
    61 adds in trunk/WebKit

2006-06-02 Steve Falkenburg <​sfalken@apple.com>

Reviewed by darin.

New hosting for Spinneret to avoid static linking

  • COM: Added.
  • COM/Interfaces: Added.
  • COM/Interfaces/DOMCSS.idl: Added.
  • COM/Interfaces/DOMCore.idl: Added.
  • COM/Interfaces/DOMHTML.idl: Added.
  • COM/Interfaces/DOMRange.idl: Added.
  • COM/Interfaces/IWebArchive.idl: Added.
  • COM/Interfaces/IWebAttributedString.idl: Added.
  • COM/Interfaces/IWebBackForwardList.idl: Added.
  • COM/Interfaces/IWebDataSource.idl: Added.
  • COM/Interfaces/IWebDocument.idl: Added.
  • COM/Interfaces/IWebDownload.idl: Added.
  • COM/Interfaces/IWebEditingDelegate.idl: Added.
  • COM/Interfaces/IWebError.idl: Added.
  • COM/Interfaces/IWebFrame.idl: Added.
  • COM/Interfaces/IWebFrameLoadDelegate.idl: Added.
  • COM/Interfaces/IWebFrameView.idl: Added.
  • COM/Interfaces/IWebHistoryItem.idl: Added.
  • COM/Interfaces/IWebIconDatabase.idl: Added.
  • COM/Interfaces/IWebImage.idl: Added.
  • COM/Interfaces/IWebMutableURLRequest.idl: Added.
  • COM/Interfaces/IWebNotification.idl: Added.
  • COM/Interfaces/IWebPolicyDelegate.idl: Added.
  • COM/Interfaces/IWebPreferences.idl: Added.
  • COM/Interfaces/IWebResource.idl: Added.
  • COM/Interfaces/IWebResourceLoadDelegate.idl: Added.
  • COM/Interfaces/IWebScriptObject.idl: Added.
  • COM/Interfaces/IWebUIDelegate.idl: Added.
  • COM/Interfaces/IWebURLAuthenticationChallenge.idl: Added.
  • COM/Interfaces/IWebURLRequest.idl: Added.
  • COM/Interfaces/IWebURLResponse.idl: Added.
  • COM/Interfaces/IWebUndoManager.idl: Added.
  • COM/Interfaces/IWebView.idl: Added.
  • COM/Interfaces/WebKit.idl: Added.
  • COM/WebBackForwardList.cpp: Added. (WebBackForwardList::WebBackForwardList): (WebBackForwardList::~WebBackForwardList): (WebBackForwardList::createInstance): (WebBackForwardList::QueryInterface): (WebBackForwardList::AddRef): (WebBackForwardList::Release): (WebBackForwardList::addItem): (WebBackForwardList::goBack): (WebBackForwardList::goForward): (WebBackForwardList::goToItem): (WebBackForwardList::backItem): (WebBackForwardList::currentItem): (WebBackForwardList::forwardItem): (WebBackForwardList::backListWithLimit): (WebBackForwardList::forwardListWithLimit): (WebBackForwardList::capacity): (WebBackForwardList::setCapacity): (WebBackForwardList::backListCount): (WebBackForwardList::forwardListCount): (WebBackForwardList::containsItem): (WebBackForwardList::itemAtIndex): (WebBackForwardList::setPageCacheSize): (WebBackForwardList::pageCacheSize):
  • COM/WebBackForwardList.h: Added.
  • COM/WebDataSource.cpp: Added. (WebDataSource::WebDataSource): (WebDataSource::~WebDataSource): (WebDataSource::createInstance): (WebDataSource::QueryInterface): (WebDataSource::AddRef): (WebDataSource::Release): (WebDataSource::initWithRequest): (WebDataSource::data): (WebDataSource::representation): (WebDataSource::webFrame): (WebDataSource::initialRequest): (WebDataSource::request): (WebDataSource::response): (WebDataSource::textEncodingName): (WebDataSource::isLoading): (WebDataSource::pageTitle): (WebDataSource::unreachableURL): (WebDataSource::webArchive): (WebDataSource::mainResource): (WebDataSource::subresources): (WebDataSource::subresourceForURL): (WebDataSource::addSubresource):
  • COM/WebDataSource.h: Added.
  • COM/WebFrame.cpp: Added. (WebFrame::WebFramePrivate::WebFramePrivate): (WebFrame::WebFramePrivate::~WebFramePrivate): (WebFrame::WebFrame): (WebFrame::~WebFrame): (WebFrame::createInstance): (WebFrame::QueryInterface): (WebFrame::AddRef): (WebFrame::Release): (WebFrame::initWithName): (WebFrame::name): (WebFrame::webView): (WebFrame::frameView): (WebFrame::DOMDocument): (WebFrame::frameElement): (WebFrame::loadRequest): (WebFrame::loadData): (WebFrame::loadHTMLString): (WebFrame::loadAlternateHTMLString): (WebFrame::loadArchive): (WebFrame::dataSource): (WebFrame::provisionalDataSource): (WebFrame::stopLoading): (WebFrame::reload): (WebFrame::findFrameNamed): (WebFrame::parentFrame): (WebFrame::childFrames): (WebFrame::paint): (WebFrame::impl): (WebFrame::loadDataSource): (WebFrame::loading): (WebFrame::goToItem): (WebFrame::loadItem): (WebSystemMainMemory): (WebFrame::getObjectCacheSize): (WebFrame::receivedRedirect): (WebFrame::receivedResponse): (WebFrame::receivedData): (WebFrame::receivedAllData): (WebFrame::openURL): (WebFrame::submitForm): (WebFrame::setTitle): (WebFrame::setStatusText):
  • COM/WebFrame.h: Added.
  • COM/WebHistoryItem.cpp: Added. (WebHistoryItem::WebHistoryItem): (WebHistoryItem::~WebHistoryItem): (WebHistoryItem::createInstance): (WebHistoryItem::QueryInterface): (WebHistoryItem::AddRef): (WebHistoryItem::Release): (WebHistoryItem::initWithURLString): (WebHistoryItem::originalURLString): (WebHistoryItem::URLString): (WebHistoryItem::title): (WebHistoryItem::lastVisitedTimeInterval): (WebHistoryItem::setAlternateTitle): (WebHistoryItem::alternateTitle): (WebHistoryItem::icon):
  • COM/WebHistoryItem.h: Added.
  • COM/WebIconDatabase.cpp: Added. (WebIconDatabase::WebIconDatabase): (WebIconDatabase::~WebIconDatabase): (WebIconDatabase::createInstance): (WebIconDatabase::QueryInterface): (WebIconDatabase::AddRef): (WebIconDatabase::Release): (WebIconDatabase::sharedIconDatabase): (WebIconDatabase::iconForURL): (WebIconDatabase::defaultIconWithSize): (WebIconDatabase::retainIconForURL): (WebIconDatabase::releaseIconForURL): (WebIconDatabase::delayDatabaseCleanup): (WebIconDatabase::allowDatabaseCleanup):
  • COM/WebIconDatabase.h: Added.
  • COM/WebKitClassFactory.cpp: Added. (WebKitClassFactory::WebKitClassFactory): (WebKitClassFactory::~WebKitClassFactory): (WebKitClassFactory::QueryInterface): (WebKitClassFactory::AddRef): (WebKitClassFactory::Release): (WebKitClassFactory::CreateInstance): (WebKitClassFactory::LockServer):
  • COM/WebKitClassFactory.h: Added.
  • COM/WebKitDLL.cpp: Added. (DllMain): (DllGetClassObject): (DllCanUnloadNow): (DllUnregisterServer): (DllRegisterServer):
  • COM/WebKitDLL.h: Added.
  • COM/WebMutableURLRequest.cpp: Added. (WebMutableURLRequest::WebMutableURLRequest): (WebMutableURLRequest::~WebMutableURLRequest): (WebMutableURLRequest::createInstance): (WebMutableURLRequest::QueryInterface): (WebMutableURLRequest::AddRef): (WebMutableURLRequest::Release): (WebMutableURLRequest::requestWithURL): (WebMutableURLRequest::allHTTPHeaderFields): (WebMutableURLRequest::cachePolicy): (WebMutableURLRequest::HTTPBody): (WebMutableURLRequest::HTTPBodyStream): (WebMutableURLRequest::HTTPMethod): (WebMutableURLRequest::HTTPShouldHandleCookies): (WebMutableURLRequest::initWithURL): (WebMutableURLRequest::mainDocumentURL): (WebMutableURLRequest::timeoutInterval): (WebMutableURLRequest::URL): (WebMutableURLRequest::valueForHTTPHeaderField): (WebMutableURLRequest::addValue): (WebMutableURLRequest::setAllHTTPHeaderFields): (WebMutableURLRequest::setCachePolicy): (WebMutableURLRequest::setHTTPBody): (WebMutableURLRequest::setHTTPBodyStream): (WebMutableURLRequest::setHTTPMethod): (WebMutableURLRequest::setHTTPShouldHandleCookies): (WebMutableURLRequest::setMainDocumentURL): (WebMutableURLRequest::setTimeoutInterval): (WebMutableURLRequest::setURL): (WebMutableURLRequest::setValue): (WebMutableURLRequest::setFormData): (WebMutableURLRequest::formData):
  • COM/WebMutableURLRequest.h: Added.
  • COM/WebView.cpp: Added. (WebView::WebView): (WebView::~WebView): (WebView::createInstance): (WebView::mouseMoved): (WebView::mouseDown): (WebView::mouseUp): (WebView::mouseDoubleClick): (WebView::keyPress): (registerWebView): (WebViewWndProc): (calculateScrollDelta): (scrollMessageForKey): (WebView::goToItem): (WebView::QueryInterface): (WebView::AddRef): (WebView::Release): (WebView::canShowMIMEType): (WebView::canShowMIMETypeAsHTML): (WebView::MIMETypesShownAsHTML): (WebView::setMIMETypesShownAsHTML): (WebView::URLFromPasteboard): (WebView::URLTitleFromPasteboard): (WebView::initWithFrame): (WebView::setUIDelegate): (WebView::uiDelegate): (WebView::setResourceLoadDelegate): (WebView::resourceLoadDelegate): (WebView::setDownloadDelegate): (WebView::downloadDelegate): (WebView::setFrameLoadDelegate): (WebView::frameLoadDelegate): (WebView::setPolicyDelegate): (WebView::policyDelegate): (WebView::mainFrame): (WebView::backForwardList): (WebView::setMaintainsBackForwardList): (WebView::goBack): (WebView::goForward): (WebView::goToBackForwardItem): (WebView::setTextSizeMultiplier): (WebView::textSizeMultiplier): (WebView::setApplicationNameForUserAgent): (WebView::applicationNameForUserAgent): (WebView::setCustomUserAgent): (WebView::customUserAgent): (WebView::userAgentForURL): (WebView::supportsTextEncoding): (WebView::setCustomTextEncodingName): (WebView::customTextEncodingName): (WebView::setMediaStyle): (WebView::mediaStyle): (WebView::stringByEvaluatingJavaScriptFromString): (WebView::windowScriptObject): (WebView::setPreferences): (WebView::preferences): (WebView::setPreferencesIdentifier): (WebView::preferencesIdentifier): (WebView::setHostWindow): (WebView::hostWindow): (WebView::searchFor): (WebView::registerViewClass): (WebView::takeStringURLFrom): (WebView::stopLoading): (WebView::reload): (WebView::canGoBack): (WebView::canGoForward): (WebView::canMakeTextLarger): (WebView::makeTextLarger): (WebView::canMakeTextSmaller): (WebView::makeTextSmaller): (WebView::computedStyleForElement): (WebView::editableDOMRangeForPoint): (WebView::setSelectedDOMRange): (WebView::selectedDOMRange): (WebView::selectionAffinity): (WebView::setEditable): (WebView::isEditable): (WebView::setTypingStyle): (WebView::typingStyle): (WebView::setSmartInsertDeleteEnabled): (WebView::smartInsertDeleteEnabled): (WebView::setContinuousSpellCheckingEnabled): (WebView::isContinuousSpellCheckingEnabled): (WebView::spellCheckerDocumentTag): (WebView::undoManager): (WebView::setEditingDelegate): (WebView::editingDelegate): (WebView::styleDeclarationWithText): (WebView::replaceSelectionWithNode): (WebView::replaceSelectionWithText): (WebView::replaceSelectionWithMarkupString): (WebView::replaceSelectionWithArchive): (WebView::deleteSelection): (WebView::applyStyle): (WebView::copy): (WebView::cut): (WebView::paste): (WebView::copyFont): (WebView::pasteFont): (WebView::delete_): (WebView::pasteAsPlainText): (WebView::pasteAsRichText): (WebView::changeFont): (WebView::changeAttributes): (WebView::changeDocumentBackgroundColor): (WebView::changeColor): (WebView::alignCenter): (WebView::alignJustified): (WebView::alignLeft): (WebView::alignRight): (WebView::checkSpelling): (WebView::showGuessPanel): (WebView::performFindPanelAction): (WebView::startSpeaking): (WebView::stopSpeaking): (WebView::viewWindow):
  • COM/WebView.h: Added.
  • WebKit.vcproj: Added.
  • WebKit.vcproj/Interfaces.vcproj: Added.
  • WebKit.vcproj/WebKit.def: Added.
  • WebKit.vcproj/WebKit.rc: Added.
  • WebKit.vcproj/WebKit.sln: Added.
  • WebKit.vcproj/WebKit.vcproj: Added.
  • WebKit.vcproj/WebKitGUID.vcproj: Added.
  • WebKit.vcproj/autoversion.h: Added.
  • WebKit.vcproj/resource.h: Added.
10:24 AM Changeset in webkit [14687] by darin
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/css-generated-content/016-expected.checksum: Added.
  • fast/css-generated-content/016-expected.png: Added.
  • fast/css-generated-content/016-expected.txt: Added.
  • fast/css-generated-content/016.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/css-generated-content/016.html

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): Don't share style if the unique bit is set. (WebCore::CSSStyleSelector::applyProperty): When applying the "attr" property, set the unique bit and add to m_selectorAttrs.
  • rendering/render_style.cpp: Did a lot of reformatting, and this one real change. (WebCore::RenderStyle::RenderStyle): Initialize m_unique to false.
  • rendering/render_style.h: (WebCore::RenderStyle::unique): Added. Returns value of m_unique. (WebCore::RenderStyle::setUnique): Added. Sets m_unique.
10:04 AM Changeset in webkit [14686] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Maciej.


The fix is to mark all DOM Nodes when collecting on an alternate thread --
not just the nodes that are still in a document.


Previously, the DOMObjectsMarker didn't mark DOM nodes that were not in
a document, since we assumed such nodes would either be (a) unreachable
or (b) reachable, and therefore marked elsewhere. However, it seems that
heap/stack entropy allows for (c) non-deterministically reachable by the
conservative garbage collector. So, ironically, we need to mark
DOM nodes that are not in a document to avoid crashing when trying to
mark them later.

  • khtml/ecma/kjs_binding.cpp: (KJS::DOMObjectsMarker::mark): (KJS::DOMObjectsMarker::markOnMainThread): (KJS::DOMObjectsMarker::markOnAlternateThread):
9:39 AM Changeset in webkit [14685] by darin
  • 3 edits in trunk/LayoutTests

Reviewed by Anders.

Updated test so that is will once again exercise the fix for
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9009

  • fast/table/empty-section-crash-expected.txt:
  • fast/table/empty-section-crash.html:
2:50 AM Changeset in webkit [14684] by ddkilzer
  • 3034 edits in trunk

LayoutTests:

Reviewed by mjs.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9183
Finish renaming of RenderCanvas to RenderView

  • editing/selection/7152-1-expected.checksum: Layout changed due to text change in HTML file.
  • editing/selection/7152-1-expected.png: Ditto.
  • editing/selection/7152-1-expected.txt: Ditto.
  • editing/selection/7152-1.html: Changed text in HTML content.
  • editing/selection/7152-2-expected.checksum: Layout changed due to text change in HTML file.
  • editing/selection/7152-2-expected.png: Ditto.
  • editing/selection/7152-2-expected.txt: Ditto.
  • editing/selection/7152-2.html: Changed text in HTML content.
  • *-expected.txt: Replaced "RenderCanvas" with "RenderView" in 3023 more files.

WebCore:

Reviewed by mjs.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9183
Finish renaming of RenderCanvas to RenderView

  • rendering/RenderView.h: Changed renderName from "RenderCanvas" to "RenderView".
12:29 AM Changeset in webkit [14683] by darin
  • 2 edits in trunk/WebKit
  • WebCoreSupport/WebImageRendererFactory.m: Fix crash on Safari startup by include NSObject as a superclass (oops!).
Note: See TracTimeline for information about the timeline view.