Timeline



Jun 16, 2006:

6:15 PM Changeset in webkit [14895] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9463
REGRESSION (r14879): Assertion failure in CSSParser::sinkFloatingSelector()
(m_floatingSelectors.contains(selector)) in some CSS tests

  • css/CSSGrammar.y: Create CSSSelector for FUNCTION using CSSParser::createFloatingSelector() instead of the bare constructor.
6:08 PM Changeset in webkit [14894] by harrison
  • 2 edits in trunk/WebCore

<rdar://problem/4565312> Mail has a weird drawing artifact with dotted red lines running across the window

Problem was that revision lost a check to not draw the markers
when paintingDisabled(). This led the markers to be drawn when
the window deactivated, at which time the view happens to be flipped.

It is similar but not the same as the Mail ToDo highlighting
issue, which is due to the custom highlight method
drawing when the focusView is nil. Mail team knows this
and has tested the fix.

  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspelling): Early return if paintingDisabled().
4:47 PM Changeset in webkit [14893] by andersca
  • 6 edits in trunk/JavaScriptCore

2006-06-17 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej and Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7080
Provide some way to stop a JavaScript infinite loop


  • kjs/completion.h: (KJS::): Add Interrupted completion type.


  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::GlobalFuncImp::callAsFunction): Only set the exception on the new ExecState if the current one has had one.


  • kjs/interpreter.cpp: (KJS::TimeoutChecker::startTimeoutCheck): (KJS::TimeoutChecker::stopTimeoutCheck): (KJS::TimeoutChecker::alarmHandler): (KJS::TimeoutChecker::pauseTimeoutCheck): (KJS::TimeoutChecker::resumeTimeoutCheck): New TimeoutChecker class which handles setting Interpreter::m_timedOut flag after a given period of time. This currently only works on Unix platforms where setitimer and signals are used.


(KJS::Interpreter::Interpreter):
Initialize new member variables.


(KJS::Interpreter::~Interpreter):
Destroy the timeout checker.


(KJS::Interpreter::startTimeoutCheck):
(KJS::Interpreter::stopTimeoutCheck):
(KJS::Interpreter::pauseTimeoutCheck):
(KJS::Interpreter::resumeTimeoutCheck):
Call the timeout checker.


(KJS::Interpreter::handleTimeout):
Called on timeout. Resets the m_timedOut flag and calls shouldInterruptScript.


  • kjs/interpreter.h: (KJS::Interpreter::setTimeoutTime): New function for setting the timeout time.


(KJS::Interpreter::shouldInterruptScript):
New function. The idea is that this should be overridden by subclasses in order to for example
pop up a dialog asking the user if the script should be interrupted.


(KJS::Interpreter::checkTimeout):
New function which checks the m_timedOut flag and calls handleTimeout if it's set.


  • kjs/nodes.cpp: (DoWhileNode::execute): (WhileNode::execute): (ForNode::execute): Call Interpreter::checkTimeout after each iteration of the loop.
4:45 PM Changeset in webkit [14892] by adele
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Adjust padding of inner div so text lines up with text fields.
Adjust height of textarea so it only leaves room for the horizontal
scrollbar if overflow is set to scroll, or if overflow is set to
auto and there's no word wrap.

These changes will be tested by current layout tests when the
new textarea implementation takes effect.

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): (WebCore::RenderTextField::calcHeight):
2:49 PM Changeset in webkit [14891] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Darin


  • fixed <rdar://problem/4590062> crash in marker code with particular set of steps on daringfireball.net
  • dom/Document.cpp: (WebCore::Document::addMarker): Store [it - markers.begin()] in a local variable before modifying markers, since modifying markers can change value of [it - markers.begin()].
2:10 PM Changeset in webkit [14890] by thatcher
  • 7 edits
    3 adds in trunk/WebKit

Reviewed by Tim O.

Exposes a distributed objects server for clients to register for script debugger calls.
For preformance concerns this is disabled by default, you will need to enable this per application.
To enable for Safari do this: defaults write com.apple.Safari WebKitScriptDebuggerEnabled -bool true

Clients will need to listen to the following distributed notification to discover servers:
WebScriptDebugServerDidLoadNotification

To discover servers that previously loaded before the client, the client needs to send the following notification:
WebScriptDebugServerQueryNotification

All servers will reply with the WebScriptDebugServerQueryReplyNotification notification that contains the
registered server connection name to use with distributed objects.

  • DefaultDelegates/WebScriptDebugServer.h: Added.
  • DefaultDelegates/WebScriptDebugServer.m: Added. (+[WebScriptDebugServer sharedScriptDebugServer]): (-[WebScriptDebugServer init]): (-[WebScriptDebugServer dealloc]): (-[WebScriptDebugServer serverQuery:]): (-[WebScriptDebugServer listenerConnectionDidDie:]): (-[WebScriptDebugServer addListener:]): (-[WebScriptDebugServer removeListener:]): (-[WebScriptDebugServer webView:didParseSource:fromURL:sourceId:forWebFrame:]): (-[WebScriptDebugServer webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
  • DefaultDelegates/WebScriptDebugServerPrivate.h: Added.
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge windowObjectCleared]):
  • WebKit.exp:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebScriptDebugDelegate.m: (-[WebScriptCallFrame parsedSource:fromURL:sourceId:]): (-[WebScriptCallFrame enteredFrame:sourceId:line:]): (-[WebScriptCallFrame hitStatement:sourceId:line:]): (-[WebScriptCallFrame leavingFrame:sourceId:line:]):
  • WebView/WebView.m: (+[WebView _developerExtrasEnabled]): (+[WebView _scriptDebuggerEnabled]): (-[WebView _menuForElement:defaultItems:]): (-[WebView _commonInitializationWithFrameName:groupName:]):
  • WebView/WebViewPrivate.h:
11:27 AM Changeset in webkit [14889] by adele
  • 12 edits in trunk

WebCore:

Reviewed by Alice.

Added code to draw Cocoa-like border for textareas instead of just using CSS.

  • WebCore.exp:
  • css/html4.css: Sets a 1px solid border.
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • rendering/RenderThemeMac.h: Formatting changes.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintTextArea): Uses new wkDrawBezeledTextArea to draw border.

WebKit:

Reviewed by Alice.

Added initialization for WKDrawBezeledTextArea.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

WebKitLibraries:

Reviewed by Alice.

  • WebKitSystemInterface.h: Added WKDrawBezeledTextArea().
  • libWebKitSystemInterface.a: ditto.
10:02 AM Changeset in webkit [14888] by adele
  • 1 edit
    1 add in trunk/LayoutTests

Reviewed by Maciej.

Adding missing expected result for test from yesterday.

  • fast/events/window-load-capture-expected.txt: Added.
6:13 AM Changeset in webkit [14887] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by hyatt.

  • fast/text/capitalize-empty-generated-string-expected.checksum: Added.
  • fast/text/capitalize-empty-generated-string-expected.png: Added.
  • fast/text/capitalize-empty-generated-string-expected.txt: Added.
  • fast/text/capitalize-empty-generated-string.html: Added.

WebCore:

Reviewed by hyatt.

Test: fast/text/capitalize-empty-generated-string.html

  • rendering/RenderText.cpp: (WebCore::RenderText::setText): Skip empty-string text renderers when looking for the previous character.

Jun 15, 2006:

5:45 PM Changeset in webkit [14886] by justing
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by levi

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8637>
REGRESSION (11-16-05): Selection gaps left behind after delete

  • fast/repaint/selection-after-delete-expected.checksum: Added.
  • fast/repaint/selection-after-delete-expected.png: Added.
  • fast/repaint/selection-after-delete-expected.txt: Added.
  • fast/repaint/selection-after-delete.html: Added.
  • fast/repaint/selection-after-remove-expected.checksum: Added.
  • fast/repaint/selection-after-remove-expected.png: Added.
  • fast/repaint/selection-after-remove-expected.txt: Added.
  • fast/repaint/selection-after-remove.html: Added.

WebCore:

Reviewed by levi

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8637>
REGRESSION (11-16-05): Selection gaps left behind after delete

  • editing/SelectionController.cpp: (WebCore::SelectionController::nodeWillBeRemoved): Invalidate the selection so that selection gaps are invalidated.
3:44 PM Changeset in webkit [14885] by thatcher
  • 1 copy in tags/WebCore-418.19/WebCore

Tag for WebCore 418.19 (part 2 of 2.)

3:44 PM Changeset in webkit [14884] by thatcher
  • 1 add in tags/WebCore-418.19

Tag for WebCore 418.19 (part 1 of 2.)

3:33 PM Changeset in webkit [14883] by thatcher
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Geoff and Darin.


Prefer the DWARF debugging symbols format for use in Xcode 2.3.

JavaScriptGlue:

Reviewed by Geoff and Darin.


Prefer the DWARF debugging symbols format for use in Xcode 2.3.

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Geoff and Darin.


Prefer the DWARF debugging symbols format for use in Xcode 2.3.

  • WebCore.xcodeproj/project.pbxproj:

WebKit:

Reviewed by Geoff and Darin.


Prefer the DWARF debugging symbols format for use in Xcode 2.3.

  • WebKit.xcodeproj/project.pbxproj:
3:31 PM Changeset in webkit [14882] by jdevalk
  • 4 edits in trunk/LayoutTests/fast/css

And now with the ugly line gone, and the proper expected test results

3:28 PM Changeset in webkit [14881] by jdevalk
  • 1 edit
    2 adds in trunk/LayoutTests/fast/css

update testresults

3:26 PM Changeset in webkit [14880] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/deleting/pruning-after-merge-2-expected.checksum: Added.
  • editing/deleting/pruning-after-merge-2-expected.png: Added.
  • editing/deleting/pruning-after-merge-2-expected.txt: Added.
  • editing/deleting/pruning-after-merge-2.html: Added.

WebCore:

Reviewed by harrison


  • editing/CompositeEditCommand.cpp: (WebCore::hasARenderedDescendant): (WebCore::CompositeEditCommand::prune): Ascend using the DOM (WebCore::CompositeEditCommand::moveParagraphs): Placeholder insertion during deletion is fixed, removing the fall back.
2:37 PM Changeset in webkit [14879] by jdevalk
  • 8 edits
    2 adds in trunk

Adding :lang support, patch by Nicholas Shanks, review by Hyatt

2:09 PM Changeset in webkit [14878] by jdevalk
  • 2 edits in trunk/WebKitSite

Improve wording of first paragraph of index.html

1:05 PM Changeset in webkit [14877] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9456>
REGRESSION (417.9.2-420+): Cmd-G doesn't work in Safari after double-click and Cmd-E

  • editing/execCommand/findString-2-expected.checksum: Added.
  • editing/execCommand/findString-2-expected.png: Added.
  • editing/execCommand/findString-2-expected.txt: Added.
  • editing/execCommand/findString-2.html: Added.

WebCore:

Reviewed by harrison


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9456>
REGRESSION (417.9.2-420+): Cmd-G doesn't work in Safari after double-click and Cmd-E


  • page/Frame.cpp: (WebCore::Frame::findString): When comparing the found range with what's currently selected a) build a selection with the found range to remove collapsed whitespace and b) compare ranges instead of selection objects to ignore the way that the current selection was made (to ignore the base and extent).
11:56 AM Changeset in webkit [14876] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

11:51 AM Changeset in webkit [14875] by justing
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by thatcher, harrison


<rdar://problem/4585175> 10.4.7 regression: Text from end of signature unexpectedly removed


Merged fix for:
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=8459>
REGRESSION: Content lost during a delete/merge of whitespace:pre text

  • khtml/editing/htmlediting.cpp: (khtml::hasARenderedDescendant): Added. (khtml::CompositeEditCommand::prune): Don't prune a leaf, the root editable element, or a container with one or more rendered descendants.
10:37 AM Changeset in webkit [14874] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim O.


Fixed bug in WebKit support for computing but not highlighting rects for text matches.

  • WebView/WebView.m: (-[WebView rectsForTextMatches]): leave out empty rects, and convert rects to WebView coordinates. Since this makes a batch of autoreleased NSValue objects, use a local autorelease pool
6:37 AM Changeset in webkit [14873] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

  • Plugins/WebPluginController.m: (-[WebPluginController _cancelOutstandingChecks]): add nil check before calling CFSetApplyFunction
4:12 AM Changeset in webkit [14872] by ddkilzer
  • 108 edits in trunk/WebCore

WebCore:

Reviewed by mjs.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9382
IDL files missing copyright/license headers

Add Apple BSD license and copyright to IDL files.

  • ksvg2/bindings/idl/svg/GetSVGDocument.idl:
  • ksvg2/bindings/idl/svg/SVGAElement.idl:
  • ksvg2/bindings/idl/svg/SVGAnimateColorElement.idl:
  • ksvg2/bindings/idl/svg/SVGAnimateElement.idl:
  • ksvg2/bindings/idl/svg/SVGAnimateTransformElement.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedAngle.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedBoolean.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedEnumeration.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedInteger.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedLengthList.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedNumber.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedNumberList.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedPathData.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedPoints.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedPreserveAspectRatio.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedRect.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedString.idl:
  • ksvg2/bindings/idl/svg/SVGAnimatedTransformList.idl:
  • ksvg2/bindings/idl/svg/SVGAnimationElement.idl:
  • ksvg2/bindings/idl/svg/SVGCircleElement.idl:
  • ksvg2/bindings/idl/svg/SVGClipPathElement.idl:
  • ksvg2/bindings/idl/svg/SVGComponentTransferFunctionElement.idl:
  • ksvg2/bindings/idl/svg/SVGCursorElement.idl:
  • ksvg2/bindings/idl/svg/SVGDOMImplementation.idl:
  • ksvg2/bindings/idl/svg/SVGDefsElement.idl:
  • ksvg2/bindings/idl/svg/SVGDescElement.idl:
  • ksvg2/bindings/idl/svg/SVGElementInstance.idl:
  • ksvg2/bindings/idl/svg/SVGElementInstanceList.idl:
  • ksvg2/bindings/idl/svg/SVGEllipseElement.idl:
  • ksvg2/bindings/idl/svg/SVGEvent.idl:
  • ksvg2/bindings/idl/svg/SVGException.idl:
  • ksvg2/bindings/idl/svg/SVGExternalResourcesRequired.idl:
  • ksvg2/bindings/idl/svg/SVGFEBlendElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEColorMatrixElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEComponentTransferElement.idl:
  • ksvg2/bindings/idl/svg/SVGFECompositeElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEFloodElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEFuncAElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEFuncBElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEFuncGElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEFuncRElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEGaussianBlurElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEImageElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEMergeElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEMergeNodeElement.idl:
  • ksvg2/bindings/idl/svg/SVGFEOffsetElement.idl:
  • ksvg2/bindings/idl/svg/SVGFETileElement.idl:
  • ksvg2/bindings/idl/svg/SVGFETurbulenceElement.idl:
  • ksvg2/bindings/idl/svg/SVGFilterElement.idl:
  • ksvg2/bindings/idl/svg/SVGFilterPrimitiveStandardAttributes.idl:
  • ksvg2/bindings/idl/svg/SVGFitToViewBox.idl:
  • ksvg2/bindings/idl/svg/SVGGElement.idl:
  • ksvg2/bindings/idl/svg/SVGGradientElement.idl:
  • ksvg2/bindings/idl/svg/SVGICCColor.idl:
  • ksvg2/bindings/idl/svg/SVGImageElement.idl:
  • ksvg2/bindings/idl/svg/SVGLangSpace.idl:
  • ksvg2/bindings/idl/svg/SVGLengthList.idl:
  • ksvg2/bindings/idl/svg/SVGLineElement.idl:
  • ksvg2/bindings/idl/svg/SVGLinearGradientElement.idl:
  • ksvg2/bindings/idl/svg/SVGLocatable.idl:
  • ksvg2/bindings/idl/svg/SVGMarkerElement.idl:
  • ksvg2/bindings/idl/svg/SVGNumberList.idl:
  • ksvg2/bindings/idl/svg/SVGPaint.idl:
  • ksvg2/bindings/idl/svg/SVGPathElement.idl:
  • ksvg2/bindings/idl/svg/SVGPathSeg.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegArc.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegClosePath.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubic.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubicSmooth.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadratic.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadraticSmooth.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegLineto.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegLinetoHorizontal.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegLinetoVertical.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegList.idl:
  • ksvg2/bindings/idl/svg/SVGPathSegMoveto.idl:
  • ksvg2/bindings/idl/svg/SVGPatternElement.idl:
  • ksvg2/bindings/idl/svg/SVGPointList.idl:
  • ksvg2/bindings/idl/svg/SVGPolygonElement.idl:
  • ksvg2/bindings/idl/svg/SVGPolylineElement.idl:
  • ksvg2/bindings/idl/svg/SVGPreserveAspectRatio.idl:
  • ksvg2/bindings/idl/svg/SVGRadialGradientElement.idl:
  • ksvg2/bindings/idl/svg/SVGRectElement.idl:
  • ksvg2/bindings/idl/svg/SVGRenderingIntent.idl:
  • ksvg2/bindings/idl/svg/SVGScriptElement.idl:
  • ksvg2/bindings/idl/svg/SVGSetElement.idl:
  • ksvg2/bindings/idl/svg/SVGStopElement.idl:
  • ksvg2/bindings/idl/svg/SVGStringList.idl:
  • ksvg2/bindings/idl/svg/SVGStylable.idl:
  • ksvg2/bindings/idl/svg/SVGStyleElement.idl:
  • ksvg2/bindings/idl/svg/SVGSwitchElement.idl:
  • ksvg2/bindings/idl/svg/SVGSymbolElement.idl:
  • ksvg2/bindings/idl/svg/SVGTSpanElement.idl:
  • ksvg2/bindings/idl/svg/SVGTests.idl:
  • ksvg2/bindings/idl/svg/SVGTextContentElement.idl:
  • ksvg2/bindings/idl/svg/SVGTextElement.idl:
  • ksvg2/bindings/idl/svg/SVGTextPositioningElement.idl:
  • ksvg2/bindings/idl/svg/SVGTitleElement.idl:
  • ksvg2/bindings/idl/svg/SVGTransformList.idl:
  • ksvg2/bindings/idl/svg/SVGTransformable.idl:
  • ksvg2/bindings/idl/svg/SVGURIReference.idl:
  • ksvg2/bindings/idl/svg/SVGUnitTypes.idl:
  • ksvg2/bindings/idl/svg/SVGUseElement.idl:
  • ksvg2/bindings/idl/svg/SVGViewElement.idl:
  • ksvg2/bindings/idl/svg/SVGZoomAndPan.idl:
  • ksvg2/bindings/idl/svg/SVGZoomEvent.idl:
  • ksvg2/svg/SVGAnimatedLength.idl:

Jun 14, 2006:

5:14 PM Changeset in webkit [14871] by thatcher
  • 1 copy in tags/WebCore-418.18/WebCore

New tag part 2.

5:12 PM Changeset in webkit [14870] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by levi


<rdar://problem/4439248>
REGRESSION(412-417): [RTL] Serious problem with RTL signatures in Mail.app in 10.4.4 (7766)

  • editing/pasteboard/copy-paste-bidi-expected.checksum: Added.
  • editing/pasteboard/copy-paste-bidi-expected.png: Added.
  • editing/pasteboard/copy-paste-bidi-expected.txt: Added.
  • editing/pasteboard/copy-paste-bidi.html: Added.

WebCore:

Reviewed by levi

<rdar://problem/4439248>
REGRESSION(412-417): [RTL] Serious problem with RTL signatures in Mail.app in 10.4.4 (7766)

  • editing/markup.cpp: (WebCore::renderedText): Use plainText so that we'll pull rendered text but in DOM order.
5:12 PM Changeset in webkit [14869] by thatcher
  • 1 add in tags/WebCore-418.18

Tag for WebCore 418.18 (part 1 of 2.)

4:23 PM Changeset in webkit [14868] by justing
  • 22 edits
    10 adds in trunk

LayoutTests:

Reviewed by justin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
TinyMCE: Implement execCommand(formatBlock, ...)

  • editing/deleting/delete-ws-fixup-002-expected.checksum:
  • editing/deleting/delete-ws-fixup-002-expected.png:
  • editing/deleting/delete-ws-fixup-002-expected.txt:
  • editing/deleting/delete-ws-fixup-002.html:
  • editing/execCommand/format-block-expected.checksum: Added.
  • editing/execCommand/format-block-expected.png: Added.
  • editing/execCommand/format-block-expected.txt: Added.
  • editing/execCommand/format-block-from-range-selection-expected.checksum: Added.
  • editing/execCommand/format-block-from-range-selection-expected.png: Added.
  • editing/execCommand/format-block-from-range-selection-expected.txt: Added.
  • editing/execCommand/format-block-from-range-selection.html: Added.
  • editing/execCommand/format-block.html: Added.

WebCore:

Reviewed by justin

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
TinyMCE: Implement execCommand(formatBlock, ...)

  • WebCore.xcodeproj/project.pbxproj: Added FormatBlock.{h,cpp} to the project.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
  • bridge/mac/WebCoreFrameBridge.h: Added WebUndoActions
  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraph): Added a preserveStyle bool. (WebCore::CompositeEditCommand::moveParagraphs): Ditto. downstream() the start or else we'll move collapsed whitespace and uncollapse it.
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): Don't update m_endingPosition because that's removeNode's responsibility. (WebCore::updatePositionForNodeRemoval): Added. (WebCore::DeleteSelectionCommand::removeNode): Turned removeFullySelectedNode into a virtual overload of removeNode so that we can update positions as we remove nodes. (WebCore::updatePositionForTextRemoval): Added. (WebCore::DeleteSelectionCommand::deleteTextFromNode): (WebCore::DeleteSelectionCommand::handleGeneralDelete): (WebCore::DeleteSelectionCommand::fixupWhitespace): Got rid of m_trailingWhitespaceValid since m_trailingWhitespace is always valid (we update it as we remove nodes). (WebCore::DeleteSelectionCommand::mergeParagraphs): (WebCore::DeleteSelectionCommand::doApply): Leading and trailing spaces should be fixed if they have collapsed before merging paragraphs.
  • editing/DeleteSelectionCommand.h:
  • editing/EditAction.h: (WebCore::):
  • editing/FormatBlockCommand.cpp: Added. (WebCore::FormatBlockCommand::FormatBlockCommand): (WebCore::FormatBlockCommand::modifyRange): Similar to InsertListCommand::modifyRange(). (WebCore::FormatBlockCommand::doApply):
  • editing/FormatBlockCommand.h: Added. (WebCore::FormatBlockCommand::editingAction):
  • editing/InsertListCommand.h: (WebCore::InsertListCommand::editingAction):
  • editing/JSEditor.cpp:
  • editing/MergeIdenticalElementsCommand.cpp: (WebCore::MergeIdenticalElementsCommand::doApply):
  • editing/htmlediting.cpp: (WebCore::validBlockTag): (WebCore::createElement):
  • editing/htmlediting.h:

WebKit:

Reviewed by justin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=7580>
TinyMCE: Implement execCommand(formatBlock, ...)


  • English.lproj/Localizable.strings:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge nameForUndoAction:]):
3:59 PM Changeset in webkit [14867] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4577988> GC: WebPluginController uses inefficient resurrecting enumeration

  • Plugins/WebPluginController.m: (cancelOutstandingCheck): (-[WebPluginController _cancelOutstandingChecks]): Use CFSetApplyFunction() instead of an enumerator to guard against modifications to the set while enumerating.
3:50 PM Changeset in webkit [14866] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

3:21 PM Changeset in webkit [14865] by mjs
  • 3 edits
    1 add in trunk

LayoutTests:

Test case by Anders, reviewed and tweaked by Maciej.


  • fixed <rdar://problem/4586051> 10.4.7 regression: 'Saved and recent' button on mapquest.com does not work


  • fast/events/window-load-capture.html: Added.

WebCore:

Reviewed by Anders.

  • fixed <rdar://problem/4586051> 10.4.7 regression: 'Saved and recent' button on mapquest.com does not work
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchWindowEvent):
2:51 PM Changeset in webkit [14864] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Written by mjs, reviewed by Tim H.

<rdar://problem/4586051> 10.4.7 regression: 'Saved and recent' button on mapquest.com does not work

  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchWindowEvent): Call window capturing event handlers, not just bubbling event handlers.
2:45 PM Changeset in webkit [14863] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by Beth.


  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/runtime_root.h: Changed "Interpreter.h" to "interpreter.h"
2:17 PM Changeset in webkit [14862] by hyatt
  • 4 edits
    2 moves in trunk/WebCore

Rename RenderSlider to DeprecatedSlider, so that I can start work on
the new NSView-less slider.

Reviewed by john

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::createRenderer):
  • rendering/DeprecatedSlider.cpp: Added. (WebCore::DeprecatedSlider::DeprecatedSlider): (WebCore::DeprecatedSlider::calcMinMaxWidth): (WebCore::DeprecatedSlider::updateFromElement): (WebCore::DeprecatedSlider::valueChanged):
  • rendering/DeprecatedSlider.h: Added. (WebCore::DeprecatedSlider::renderName):
  • rendering/RenderSlider.cpp: Removed.
  • rendering/RenderSlider.h: Removed.
10:04 AM Changeset in webkit [14861] by antti
  • 4 edits
    1 delete in S60/trunk

Reviewed by dacarson.

  • S60Internals/S60Headers.zip:
  • S60Internals/S60Libs.zip:
  • S60Internals/S60LibsGcce.zip:
  • S60Internals/SDK_GCCE_Patch.zip: Removed.

Jun 13, 2006:

10:54 PM Changeset in webkit [14860] by ggaren
  • 6 edits
    2 adds in trunk

LayoutTests:

Test for createHTMLDocument.

  • fast/dom/implementation-createHTMLDocument-expected.txt: Added.
  • fast/dom/implementation-createHTMLDocument.html: Added.

WebCore:

Reviewed by Maciej.


  • Fixed <rdar://problem/4562192> Creating a new DOMHTMLDocument appears challenging.


  • Added createHTMLDocument to Objc bindings, fixed up implementation to comply with the DOM 2 Candidate Recommendation in which is was defined. (It never made the final spec.) Also removed use of deprecatedString, to avoid unnecessary killing of puppies.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (-[DOMImplementation createHTMLDocument:]):
  • bindings/objc/DOMPrivate.h:
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): (WebCore::DOMImplementation::createHTMLDocument):
10:03 PM Changeset in webkit [14859] by mjs
  • 2 edits
    1 add in trunk/LayoutTests
  • fixed up results of the layout test I committed for 4583892, they were guaranteed to fail
  • fast/events/no-window-load-expected.txt:
  • fast/events/resources/greenbox.png: Added.
10:01 PM Changeset in webkit [14858] by ggaren
  • 1 edit
    1 add in trunk/LayoutTests

RS by MacDome. Added missing results for this test.

  • fast/css/xml-stylesheet-pi-not-in-prolog-expected.txt: Added.
6:35 PM Changeset in webkit [14857] by aliceli1
  • 2 edits
    2 adds in trunk

Reviewed by Adele.

fixed <rdar://problem/4457902> HTMLSelectElement.remove() can't handle an option obj being passed to it, results in hang on ​http://www.ibc-solar.de/www_ibc/fst_solarmonitoring.jsp

  • bindings/js/kjs_html.cpp: (KJS::HTMLElementFunction::callAsFunction): support this by converting the argument to an options object before passing to remove()
6:33 PM Changeset in webkit [14856] by darin
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

  • test for <rdar://problem/4585333> Changing location for weather on yahoo.com home page redirects to another page
  • fast/events/event-listener-html-non-html-confusion-expected.txt: Added.
  • fast/events/event-listener-html-non-html-confusion.html: Added.

WebCore:

Reviewed by Geoff.

  • fix <rdar://problem/4585333> Changing location for weather on yahoo.com home page redirects to another page

This patch fixes a bug where the event listener cache does not distinguish
HTML and non-HTML listeners. Incorrect behavior where stopPropagation also
prevented default masked a case of this bug on the yahoo.com home page until
we fixed bug 5180 on 2005-10-03.

Test: fast/events/event-listener-html-non-html-confusion.html

  • bindings/js/kjs_window.h: Add additional listener maps for HTML event listeners.
  • bindings/js/kjs_window.cpp: (KJS::Window::~Window): Go through the additional maps when clearing the window object pointer in event listeners. (KJS::Window::getJSEventListener): Look in the HTML or non-HTML map depending on the argument passed. (KJS::Window::getJSUnprotectedEventListener): Ditto.
  • bindings/js/kjs_events.cpp: (KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): Add to either the HTML or non-HTML map depending on the argument passed. (KJS::JSUnprotectedEventListener::~JSUnprotectedEventListener): Remove from either the HTML or non-HTML map depending on whether the HTML flag is set. (KJS::JSEventListener::JSEventListener): More of the same. (KJS::JSEventListener::~JSEventListener): Ditto. (KJS::JSLazyEventListener::parseCode): Same thing here. In a lazy event listener there is not a listener at construction time, thus the code here to put the listener into a map needs the HTML vs. non-HTML logic.
6:25 PM Changeset in webkit [14855] by mjs
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.


  • test case for <rdar://problem/4583892> 10.4.7 regression: Hang occurs when attempting to load search results at mapquest.com
  • fast/events/no-window-load-expected.txt: Added.
  • fast/events/no-window-load.html: Added.

WebCore:

Reviewed by Darin.


<rdar://problem/4583892> 10.4.7 regression: Hang occurs when attempting to load search results at mapquest.com

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent): Don't allow "load" events to propagate up to the window. We need this quirk to avoid site hangs, because they depend on an old Mozilla bug.
6:11 PM Changeset in webkit [14854] by thatcher
  • 1 delete in tags/WebCore-418.7/WebCore

Bad tag.

5:56 PM Changeset in webkit [14853] by thatcher
  • 1 copy in tags/WebCore-418.17/WebCore

New tag.

5:56 PM Changeset in webkit [14852] by thatcher
  • 1 delete in tags/WebCore-418.17/WebCore

Bad tag.

5:53 PM Changeset in webkit [14851] by thatcher
  • 1 copy in tags/WebCore-418.7/WebCore

New tag.

5:53 PM Changeset in webkit [14850] by thatcher
  • 1 delete in tags/WebCore-418.7/WebCore

Bad tag.

5:52 PM Changeset in webkit [14849] by thatcher
  • 1 edit in branches/Safari-2-0-branch/WebCore/ChangeLog

Versioning

5:46 PM Changeset in webkit [14848] by ggaren
  • 4 edits in branches/Safari-2-0-branch/WebCore

Patch by Darin, tweaked by me, reviewed by Harrison.

  • Fixed <rdar://problem/4584598> 10.4.7 regression: Changing location for weather on yahoo.com home page redirects to another page


We need to keep separate caches for HTML and non-HTML event listeners
so that, if you add one of each to the same node, the two don't clobber
each other.

  • khtml/ecma/kjs_events.cpp: (JSUnprotectedEventListener::JSUnprotectedEventListener): (JSUnprotectedEventListener::~JSUnprotectedEventListener): (JSEventListener::JSEventListener): (JSEventListener::~JSEventListener): (JSLazyEventListener::parseCode):
  • khtml/ecma/kjs_window.cpp: (Window::~Window): (Window::getJSEventListener): (Window::getJSUnprotectedEventListener):
  • khtml/ecma/kjs_window.h:
4:19 PM Changeset in webkit [14847] by antti
  • 7 edits
    12 adds in trunk

LayoutTests:

Reviewed by Hyatt

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9314

  • fast/block/positioning/relative-overflow-block-expected.checksum: Added.
  • fast/block/positioning/relative-overflow-block-expected.png: Added.
  • fast/block/positioning/relative-overflow-block-expected.txt: Added.
  • fast/block/positioning/relative-overflow-block.html: Added.
  • fast/block/positioning/relative-overflow-replaced-expected.checksum: Added.
  • fast/block/positioning/relative-overflow-replaced-expected.png: Added.
  • fast/block/positioning/relative-overflow-replaced-expected.txt: Added.
  • fast/block/positioning/relative-overflow-replaced-float-expected.checksum: Added.
  • fast/block/positioning/relative-overflow-replaced-float-expected.png: Added.
  • fast/block/positioning/relative-overflow-replaced-float-expected.txt: Added.
  • fast/block/positioning/relative-overflow-replaced-float.html: Added.
  • fast/block/positioning/relative-overflow-replaced.html: Added.

WebCore:

Reviewed by Hyatt.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9314
Relative positioned block size doesnt update root layer size

  • take relative positioning into account in leftmost/rightmost/lowestPosition()
  • ignore zero width/height boxes in leftmost/rightmost/lowestPosition()
  • split relativePositionOffset() to x and y functions


  • rendering/RenderBox.cpp: (WebCore::RenderBox::absolutePosition): (WebCore::RenderBox::relativePositionOffsetX): (WebCore::RenderBox::relativePositionOffsetY): (WebCore::RenderBox::lowestPosition): (WebCore::RenderBox::rightmostPosition): (WebCore::RenderBox::leftmostPosition):
  • rendering/RenderBox.h:
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::lowestPosition): (WebCore::RenderFlow::rightmostPosition): (WebCore::RenderFlow::leftmostPosition):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPosition):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::offsetLeft): (WebCore::RenderObject::offsetTop):
3:20 PM Changeset in webkit [14846] by andersca
  • 4 edits
    2 adds in trunk

WebCore:

2006-06-13 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Dave Hyatt.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9427
xml-stylesheet processing instructions outside of the prolog should have no effect.

  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet): Remove todo comment.


  • dom/xml_tokenizer.cpp: (WebCore::XMLTokenizer::processingInstruction): Only check for style sheet if the root element hasn't yet been encountered.

LayoutTests:

2006-06-13 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Dave Hyatt.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9427


  • fast/css/resources/xml-stylesheet-pi-not-in-prolog.css: Added.
  • fast/css/xml-stylesheet-pi-not-in-prolog.xml: Added.
3:19 PM Changeset in webkit [14845] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim O.


  • fixed <rdar://problem/4498606> REGRESSION (417.8-420+): 3 missing items (but extra separators) in context menu in Mail message body
  • WebView/WebView.m: (-[WebView _menuForElement:defaultItems:]): Add special-case hackery to recover from this SPI -> API mismatch.
2:58 PM Changeset in webkit [14844] by tomernic
  • 1 edit in trunk/WebKit/ChangeLog

Clarified my previous ChangeLog entry.

2:56 PM Changeset in webkit [14843] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Anders.

Fixed a recently-introduced assertion failure when handling 404 errors.

  • WebView/WebDataSource.m: (-[WebDataSource _handleFallbackContent]): Use the -[WebFrame _bridge] instead of -[WebDataSource _bridge]. The former is not valid until the data source has been committed, as is the case when the resource fails to load. The latter is safe to call at any time. This broke last night with Maciej's change to WebFrameResourceLoader. The old code used to call -[WebFrame _bridge].
1:17 PM Changeset in webkit [14842] by thatcher
  • 1 copy in tags/WebCore-418.17/WebCore

Tag for WebCore 418.17 (part 2 of 2.)

1:17 PM Changeset in webkit [14841] by thatcher
  • 1 add in tags/WebCore-418.17

Tag for WebCore 418.17 (part 1 of 2.)

1:15 PM Changeset in webkit [14840] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

12:56 PM Changeset in webkit [14839] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Harrison, landed by Tim H.

Handle window events for capture phase, except load events, this quirk is needed because
Mozilla used to not do the bubble or capture phase for image load events and sites mistakenly
put capturing load event listeners on the window

  • khtml/xml/dom_nodeimpl.cpp: (NodeImpl::dispatchGenericEvent):
6:37 AM Changeset in webkit [14838] by andersca
  • 6 edits in trunk

WebCore:

2006-06-13 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9406
REGRESSION: fix for bug 9390 broke two layout tests


  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData): Call finished() after setting up the document structure so we'll emit onload events.

WebKit:

2006-06-13 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9406
REGRESSION: fix for bug 9390 broke two layout tests

  • Plugins/WebPluginDatabase.h: (-[WebPluginDatabase isMIMETypeRegistered:]): Add new function isMIMETypeRegistered which returns whether a given MIME type has a plugin registered.
  • Plugins/WebPluginDatabase.m: (-[WebPluginDatabase init]): Init set of registered MIME types.


(-[WebPluginDatabase refresh]):
Add and remove MIME types from the set of registered MIME types when registering and unregistering
plugin MIME types.


(-[WebPluginDatabase dealloc]):
Release set of registered MIME types.


  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge determineObjectFromMIMEType:URL:]): Use isMIMETypeRegistered here.

Jun 12, 2006:

11:37 PM Changeset in webkit [14837] by ggaren
  • 1 edit
    1 add in trunk/WebCore

build fix -- forgot to svn add this file


  • ForwardingHeaders/kjs/SavedBuiltins.h: Added.
11:27 PM Changeset in webkit [14836] by ggaren
  • 2 edits in trunk/JavaScriptCore

build fix


  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject throwException:]): Restore assignment I accidentally deleted in previous commit
11:10 PM Changeset in webkit [14835] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fixed a bug in append(char) and append(UChar) where our intended copy-on-write semantics was ignored!

  • platform/String.cpp: (WebCore::String::append):
11:08 PM Changeset in webkit [14834] by ggaren
  • 29 edits
    2 copies
    1 move
    4 adds in trunk

JavaScriptCore:

Reviewed by TimO, Maciej.


  • Merged InterpreterImp code into Interpreter, which implements all interpreter functionality now. This is part of my continuing quest to create an external notion of JS "execution context" that is unified and simple -- something to replace the mix of Context, ContextImp, ExecState, Interpreter, InterpreterImp, and JSRun.


All tests pass. Leaks test has not regressed from its baseline ~207 leaks
with ~3460 leaked nodes.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bindings/NP_jsobject.cpp:
  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject throwException:]):
  • bindings/runtime_root.cpp:
  • bindings/runtime_root.h:
  • kjs/Context.cpp: (KJS::Context::Context):
  • kjs/ExecState.cpp: Added. (KJS::ExecState::lexicalInterpreter):
  • kjs/ExecState.h: Added. (KJS::ExecState::dynamicInterpreter):
  • kjs/SavedBuiltins.h: Added.
  • kjs/bool_object.cpp: (BooleanPrototype::BooleanPrototype):
  • kjs/collector.cpp: (KJS::Collector::collect): (KJS::Collector::numInterpreters):
  • kjs/context.h:
  • kjs/debugger.cpp: (Debugger::attach): (Debugger::detach):
  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::GlobalFuncImp::callAsFunction):
  • kjs/function_object.cpp: (FunctionObjectImp::construct):
  • kjs/internal.cpp:
  • kjs/internal.h:
  • kjs/interpreter.cpp: (KJS::interpreterMap): (KJS::Interpreter::Interpreter): (KJS::Interpreter::init): (KJS::Interpreter::~Interpreter): (KJS::Interpreter::globalObject): (KJS::Interpreter::initGlobalObject): (KJS::Interpreter::globalExec): (KJS::Interpreter::checkSyntax): (KJS::Interpreter::evaluate): (KJS::Interpreter::builtinObject): (KJS::Interpreter::builtinFunction): (KJS::Interpreter::builtinArray): (KJS::Interpreter::builtinBoolean): (KJS::Interpreter::builtinString): (KJS::Interpreter::builtinNumber): (KJS::Interpreter::builtinDate): (KJS::Interpreter::builtinRegExp): (KJS::Interpreter::builtinError): (KJS::Interpreter::builtinObjectPrototype): (KJS::Interpreter::builtinFunctionPrototype): (KJS::Interpreter::builtinArrayPrototype): (KJS::Interpreter::builtinBooleanPrototype): (KJS::Interpreter::builtinStringPrototype): (KJS::Interpreter::builtinNumberPrototype): (KJS::Interpreter::builtinDatePrototype): (KJS::Interpreter::builtinRegExpPrototype): (KJS::Interpreter::builtinErrorPrototype): (KJS::Interpreter::builtinEvalError): (KJS::Interpreter::builtinRangeError): (KJS::Interpreter::builtinReferenceError): (KJS::Interpreter::builtinSyntaxError): (KJS::Interpreter::builtinTypeError): (KJS::Interpreter::builtinURIError): (KJS::Interpreter::builtinEvalErrorPrototype): (KJS::Interpreter::builtinRangeErrorPrototype): (KJS::Interpreter::builtinReferenceErrorPrototype): (KJS::Interpreter::builtinSyntaxErrorPrototype): (KJS::Interpreter::builtinTypeErrorPrototype): (KJS::Interpreter::builtinURIErrorPrototype): (KJS::Interpreter::mark): (KJS::Interpreter::interpreterWithGlobalObject): (KJS::Interpreter::saveBuiltins): (KJS::Interpreter::restoreBuiltins):
  • kjs/interpreter.h: (KJS::Interpreter::setCompatMode): (KJS::Interpreter::compatMode): (KJS::Interpreter::firstInterpreter): (KJS::Interpreter::nextInterpreter): (KJS::Interpreter::prevInterpreter): (KJS::Interpreter::debugger): (KJS::Interpreter::setDebugger): (KJS::Interpreter::setContext): (KJS::Interpreter::context):
  • kjs/nodes.cpp: (StatementNode::hitStatement): (RegExpNode::evaluate):
  • kjs/protect.h:

JavaScriptGlue:

Reviewed by TimO, Maciej.


  • JSGlue part of merging InterpreterImp into Interpreter.


Since there's now a kjs forwarding header, I moved all forwarding
headers into a "ForwardingHeaders" directory, like in WebCore.

  • ForwardingHeaders: Added.
  • ForwardingHeaders/kjs: Added.
  • ForwardingHeaders/kjs/ExecState.h: Added.
  • ForwardingHeaders/wtf: Added.
  • JavaScriptGlue.xcodeproj/project.pbxproj:
  • config.h:
  • wtf: Removed.
  • wtf/AlwaysInline.h: Removed.
  • wtf/Assertions.h: Removed.
  • wtf/FastMalloc.h: Removed.
  • wtf/Forward.h: Removed.
  • wtf/HashCountedSet.h: Removed.
  • wtf/HashSet.h: Removed.
  • wtf/Noncopyable.h: Removed.
  • wtf/OwnArrayPtr.h: Removed.
  • wtf/OwnPtr.h: Removed.
  • wtf/PassRefPtr.h: Removed.
  • wtf/Platform.h: Removed.
  • wtf/RefPtr.h: Removed.
  • wtf/Vector.h: Removed.

WebCore:

Reviewed by TimO, Maciej.

  • WebCore part of merging InterpreterImp into Interpreter. No test because there's no behavior change.


A substantive change here is that ScriptInterpreter::mark must now chain to
Interpreter::mark, since Interpreter needs to mark the things that
InterpreterImp used to mark.


  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_binding.cpp:
  • bindings/js/kjs_window.cpp: (KJS::Window::put):
  • bridge/mac/WebCoreFrameBridge.mm:
  • bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]):
  • kwq/KWQPageState.mm:
10:09 PM Changeset in webkit [14833] by mjs
  • 3 edits in trunk/WebKit
  • fix for cocoa exception (whoops)
  • WebView/WebView.m: (+[WebView _generatedMIMETypeForURLScheme:]): put this back
  • WebView/WebDataSource.m: (+[WebDataSource _generatedMIMETypeForURLScheme:]): call WebView
8:36 PM Changeset in webkit [14832] by mjs
  • 8 edits in trunk/WebKit

Reviewed by Darin.


  • remove use of WebView and related from WebMainResourceLoader
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: (+[WebDataSource _generatedMIMETypeForURLScheme:]): (+[WebDataSource _representationExistsForURLScheme:]): (+[WebDataSource _canShowMIMEType:]): (-[WebDataSource _handleFallbackContent]): (-[WebDataSource _decidePolicyForMIMEType:decisionListener:]):
  • WebView/WebDataSourceInternal.h:
  • WebView/WebFrame.m: (-[WebFrame _isMainFrame]):
  • WebView/WebFrameInternal.h:
  • WebView/WebMainResourceLoader.m: (-[WebMainResourceLoader willSendRequest:redirectResponse:]): (-[WebMainResourceLoader continueAfterContentPolicy:response:]): (-[WebMainResourceLoader checkContentPolicyForResponse:]): (-[WebMainResourceLoader loadWithRequestNow:]):
  • WebView/WebView.m:
6:04 PM Changeset in webkit [14831] by beidson
  • 8 edits in trunk/WebCore

Reviewed by Maciej.

Changed String::ascii() to return a Vector<char> instead of const char*
This allows us to use it "regularly" as the returned vector will destruct
and not leak memory like the previous approach.
We can now do a String.ascii().data() to get a char* buffer instead of
String.deprecatedString().ascii(). It doesn't improve the style much but
dumping the memory-leak issue is a plus.

  • icon/IconDatabase.cpp: (WebCore::IconDatabase::open): (WebCore::IconDatabase::clearDatabase):
  • icon/SQLDatabase.cpp: (SQLDatabase::open):
  • icon/SQLStatement.cpp: (WebCore::SQLStatement::prepare): (WebCore::SQLStatement::step): (WebCore::SQLStatement::returnTextResults): (WebCore::SQLStatement::returnTextResults16): (WebCore::SQLStatement::returnIntResults): (WebCore::SQLStatement::returnInt64Results): (WebCore::SQLStatement::returnDoubleResults): In addition to the changes to the string classes, changed my database code over to the new preferred method.
  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::ascii):
  • platform/StringImpl.cpp: (WebCore::StringImpl::ascii):
  • platform/StringImpl.h:
5:27 PM Changeset in webkit [14830] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

<rdar://problem/4526052> intermittent assertion failure in -[WebBasePluginPackage dealloc] running layout tests

  • Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage _initWithPath:]): Renamed from -initWithPath:. Instead of releasing/deallocating self on error, return NO. (-[WebNetscapePluginPackage initWithPath:]): Call the new -_initWithPath:. If it returns NO, unload the plugin package before deallocating it.
4:16 PM Changeset in webkit [14829] by thatcher
  • 1 copy in tags/WebCore-418.16/WebCore

Tag for WebCore 418.16 (part 2 of 2.)

4:16 PM Changeset in webkit [14828] by thatcher
  • 1 add in tags/WebCore-418.16

Tag for WebCore 418.16 (part 1 of 2.)

4:03 PM Changeset in webkit [14827] by hyatt
  • 17 edits in trunk/WebCore

Add selection foreground color on Win32.

4:02 PM Changeset in webkit [14826] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.


  • page/Frame.cpp: (WebCore::Frame::markAllMatchesForText): Do a "fake" paint here so that the rectangles for the text matches will have been computed by the time this method returns.
3:43 PM Changeset in webkit [14825] by beidson
  • 4 edits in trunk/WebCore

Reviewed by Levi and Tim Omernick.

-Added a skeleton sqlite3 icon database file to IconDatabase
-Added functionality to validate and recreate this icon.db file
-Fixed some buggys in SQLDatabase.cpp

  • icon/IconDatabase.cpp: (WebCore::IconDatabase::open): (WebCore::IconDatabase::isValidDatabase): (WebCore::IconDatabase::clearDatabase): (WebCore::IconDatabase::recreateDatabase):
  • icon/IconDatabase.h:
  • icon/SQLStatement.cpp: (WebCore::SQLStatement::columnCount): (WebCore::SQLStatement::getColumnName): (WebCore::SQLStatement::getColumnName16): (WebCore::SQLStatement::getColumnText): (WebCore::SQLStatement::getColumnText16): (WebCore::SQLStatement::getColumnDouble): (WebCore::SQLStatement::getColumnInt): (WebCore::SQLStatement::getColumnInt64): (WebCore::SQLStatement::getColumnBlob): -Added checks to make sure we had a valid working sqlite3_statement as the sqlite3_* function calls weren't as error-tolerant as documentation advertised (maybe differences between the 3.3 docs I looked at and the 3.1.3 version installed on OSX)
1:54 PM Changeset in webkit [14824] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Versioning

1:53 PM Changeset in webkit [14823] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebCore

Reviewed by Maciej, Harrison.

Fixes <rdar://problem/4582172> frameset load events don't fire (can't login into Gmail account or see map at 511.org)

Framesets need to register their load, beforeunload and unload events with the window.

  • khtml/html/html_baseimpl.cpp: (HTMLFrameSetElementImpl::parseHTMLAttribute):
12:53 PM Changeset in webkit [14822] by hyatt
  • 3 edits in trunk/WebCore/platform

Fix Win32 build bustage.

12:02 PM Changeset in webkit [14821] by ggaren
  • 10 edits in trunk/JavaScriptCore

Reviewed by Maciej.


  • Have *.lut.h files #include lookup.h to eliminate surprising header include order dependency.
  • DerivedSources.make:
  • kjs/array_object.cpp:
  • kjs/date_object.cpp:
  • kjs/date_object.h: (KJS::DateProtoFunc::):
  • kjs/lexer.cpp:
  • kjs/math_object.cpp:
  • kjs/number_object.cpp:
  • kjs/regexp_object.cpp:
  • kjs/string_object.cpp:
11:07 AM Changeset in webkit [14820] by beidson
  • 7 edits
    3 adds in trunk/WebCore

Reviewed by Levi.

-Added SQLite helper wrappers to ease use of SQLite in the IconDatabase.
-Changed the base IconDatabase over to this new framework.

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge closeSharedDatabase]):

-By popular request, removed an annoying log message I'd accidentally left in

  • icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::open): (WebCore::IconDatabase::close): (WebCore::IconDatabase::~IconDatabase):
  • icon/IconDatabase.h: (WebCore::IconDatabase::isOpen):

-Changed over IconDatabase from direct sqlite3_* calls to the new SQLDatabase calls

  • icon/SQLDatabase.cpp: Added. (SQLDatabase::SQLDatabase): (SQLDatabase::open): (SQLDatabase::close): (SQLDatabase::executeCommand): (SQLDatabase::tableExists):
  • icon/SQLDatabase.h: Added. (WebCore::SQLDatabase::isOpen): (WebCore::SQLDatabase::getPath): (WebCore::SQLDatabase::lastError): (WebCore::SQLDatabase::lastErrorMsg): (WebCore::SQLStatement::isPrepared): (WebCore::SQLStatement::lastError): (WebCore::SQLStatement::lastErrorMsg):
  • icon/SQLStatement.cpp: Added. (WebCore::SQLStatement::SQLStatement): (WebCore::SQLStatement::~SQLStatement): (WebCore::SQLStatement::prepare): (WebCore::SQLStatement::step): (WebCore::SQLStatement::finalize): (WebCore::SQLStatement::reset): (WebCore::SQLStatement::executeCommand): (WebCore::SQLStatement::bindBlob): (WebCore::SQLStatement::bindText): (WebCore::SQLStatement::columnCount): (WebCore::SQLStatement::getColumnName): (WebCore::SQLStatement::getColumnName16): (WebCore::SQLStatement::getColumnText): (WebCore::SQLStatement::getColumnText16): (WebCore::SQLStatement::getColumnDouble): (WebCore::SQLStatement::getColumnInt): (WebCore::SQLStatement::getColumnInt64): (WebCore::SQLStatement::getColumnBlob): (WebCore::SQLStatement::returnTextResults): (WebCore::SQLStatement::returnTextResults16): (WebCore::SQLStatement::returnIntResults): (WebCore::SQLStatement::returnInt64Results): (WebCore::SQLStatement::returnDoubleResults):

-Initial checking of SQLDatabase framework

  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::String):

-Added an explicit UChar* constructor to our string class as much of sqlite3's UTF16 handling is based on
null-terminated UTF16 which we didn't yet support.

Note: See TracTimeline for information about the timeline view.