Timeline



Jun 20, 2006:

6:42 PM Changeset in webkit [14934] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej

Fixed capitalization mistake that I made, someone else fixed, then I accidentally made it go back to the old way

  • icon/SQLStatement.cpp:
6:29 PM Changeset in webkit [14933] by beidson
  • 16 edits
    1 add in trunk

WebCore:

Reviewed by Maciej.

More changes/additions setting the stage for the major IconDatabase hookup.

  • WebCore.xcodeproj/project.pbxproj: Added SQLTransaction.cpp
  • bridge/mac/WebCoreIconDatabaseBridge.h: Added call-throughs and translations to pass WebKit DB to WebCore DB
  • bridge/mac/WebCoreIconDatabaseBridge.mm: (+[WebCoreIconDatabaseBridge sharedBridgeInstance]): (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]): (-[WebCoreIconDatabaseBridge iconForURL:withSize:]): (-[WebCoreIconDatabaseBridge iconURLForURL:]): (-[WebCoreIconDatabaseBridge defaultIconWithSize:]): (-[WebCoreIconDatabaseBridge retainIconForURL:]): (-[WebCoreIconDatabaseBridge releaseIconForURL:]): (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]): (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]): (-[WebCoreIconDatabaseBridge _setIconURL:forURL:]): (-[WebCoreIconDatabaseBridge _hasIconForIconURL:]):
  • bridge/mac/WebCorePageBridge.mm: Added WebCore's IconDatabase logging channel to the user-prefs check (initializeLoggingChannelsIfNecessary):
  • icon/IconDatabase.cpp: Added stubs and basic SQL usage to create the sqlite DB and respond to WebKit calls (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::open): (WebCore::IconDatabase::close): (WebCore::IconDatabase::isValidDatabase): (WebCore::IconDatabase::recreateDatabase): (WebCore::IconDatabase::setPrivateBrowsingEnabled): (WebCore::IconDatabase::iconForURL): (WebCore::IconDatabase::iconURLForURL): (WebCore::IconDatabase::defaultIcon): (WebCore::IconDatabase::retainIconForURL): (WebCore::IconDatabase::releaseIconForURL): (WebCore::IconDatabase::setIconForIconURL): (WebCore::IconDatabase::setHaveNoIconForIconURL): (WebCore::IconDatabase::setIconURLForPageURL): (WebCore::IconDatabase::hasIconForIconURL):
  • icon/IconDatabase.h: WebIcon will be an internal class used in IconDatabase but is not complete yet (WebCore::WebIcon::getExpiration): (WebCore::WebIcon::getTouch):
  • icon/SQLDatabase.cpp: Added more SQLite convenience methods (SQLDatabase::setFullsync): (SQLDatabase::setBusyTimeout): (SQLDatabase::setBusyHandler):
  • icon/SQLDatabase.h:
  • icon/SQLStatement.cpp: (WebCore::SQLStatement::returnsAtLeastOneResult):
  • icon/SQLTransaction.cpp: Added basic commit/rollback support with this simple class (SQLTransaction::SQLTransaction): (SQLTransaction::~SQLTransaction): (SQLTransaction::begin): (SQLTransaction::commit): (SQLTransaction::rollback):

WebKit:

Reviewed by Maciej

Added calls through to the WebCoreIconDatabaseBridge for all the major WebIconDatabase API. For now these calls
are wrapped with #ifdef's and are for debugging only.

  • Misc/WebIconDatabase.h:
  • Misc/WebIconDatabase.m: (-[NSMutableDictionary _scaleIcon:toSize:]): (-[NSMutableDictionary init]): (-[NSMutableDictionary iconForURL:withSize:cache:]): (-[NSMutableDictionary iconURLForURL:]): (-[NSMutableDictionary retainIconForURL:]): (-[NSMutableDictionary releaseIconForURL:]): (-[WebIconDatabase _setHaveNoIconForIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _hasIconForIconURL:]):
  • Misc/WebIconLoader.m: (-[WebIconLoader didFinishLoading]):
  • Misc/WebKitLogging.h: Added a logging channel for WebIconDatabase debugging
  • Misc/WebKitLogging.m: (WebKitInitializeLoggingChannelsIfNecessary):
5:20 PM Changeset in webkit [14932] by thatcher
  • 3 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Make sure we clear the exception before returning so
that future calls will not fail because of an earlier
exception state. Assert on entry that the WebScriptObject
is working with an ExecState that dose not have an exception.
Document that evaluateWebScript and callWebScriptMethod return
WebUndefined when an exception is thrown.

  • bindings/objc/WebScriptObject.h:
  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): (-[WebScriptObject evaluateWebScript:]): (-[WebScriptObject setValue:forKey:]): (-[WebScriptObject valueForKey:]): (-[WebScriptObject removeWebScriptKey:]): (-[WebScriptObject webScriptValueAtIndex:]): (-[WebScriptObject setWebScriptValueAtIndex:value:]):
5:10 PM Changeset in webkit [14931] by adele
  • 14 edits
    8 adds in trunk

LayoutTests:

Reviewed by Maciej.

Tests for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8724
REGRESSION: onSelect handler doesn't work for text fields

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7676
REGRESSION: Selection methods on new text fields don't work if text field is hidden

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8867
REGRESSION: selectionStart/End return 0 for input element once it no longer has focus

  • fast/forms/double-focus-expected.txt:
  • fast/forms/input-selection-hidden-expected.txt: Added.
  • fast/forms/input-selection-hidden.html: Added.
  • fast/forms/input-selection-restore-expected.txt: Added.
  • fast/forms/input-selection-restore.html: Added.
  • fast/forms/input-text-paste-maxlength-expected.txt:
  • fast/forms/onselect-textarea-expected.txt: Added.
  • fast/forms/onselect-textarea.html: Added.
  • fast/forms/onselect-textfield-expected.txt: Added.
  • fast/forms/onselect-textfield.html: Added.
  • fast/forms/selection-functions-expected.txt:

WebCore:

Reviewed by Maciej.

Fixes for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=8724
REGRESSION: onSelect handler doesn't work for text fields

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7676
REGRESSION: Selection methods on new text fields don't work if text field is hidden

​http://bugzilla.opendarwin.org/show_bug.cgi?id=8867
REGRESSION: selectionStart/End return 0 for input element once it no longer has focus

Implemented onSelect for new text fields and textareas. Also fixed selection restore
behavior to better match other browsers and Safari 2.0 behavior.

Tests:

  • fast/forms/input-selection-restore.html
  • fast/forms/input-selection-hidden.html
  • fast/forms/onselect-textarea.html
  • fast/forms/onselect-textfield.html
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::cacheSelection): Added.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::init): Initializes cached selection. (WebCore::HTMLInputElement::selectionStart): If this element doesn't have focus, return the cached selection value. (WebCore::HTMLInputElement::selectionEnd): ditto. (WebCore::HTMLInputElement::setValue): Restore a caret at the starting point of the old selection. Matches Safari 2.0 behavior.
  • html/HTMLTextAreaElement.h: (WebCore::HTMLTextAreaElement::cacheSelection): Added.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::HTMLTextAreaElement): Initializes cached selection. (WebCore::HTMLTextAreaElement::selectionStart): If this element doesn't have focus, return the cached selection value. (WebCore::HTMLTextAreaElement::selectionEnd): ditto. (WebCore::HTMLTextAreaElement::focus): If this is the first focus, set a caret at the end of the text. Otherwise, restore the cached selection. This matches other browsers' behavior. (WebCore::HTMLTextAreaElement::setValue): Restore a caret at the starting point of the old selection. Matches Safari 2.0 behavior.
  • page/Frame.h: Added notifyRendererOfSelectionChange method.
  • page/Frame.cpp: (WebCore::Frame::notifyRendererOfSelectionChange): Added. Calls selectionChanged for text fields and textareas. Forwards a userTriggered argument so selectionChanged knows whether or not to fire onSelect. (WebCore::Frame::setSelection): Calls notifyRendererOfSelectionChange(false). This gets called for all selection changes, so the renderer can always update its cached selection values. (WebCore::Frame::handleMouseReleaseEvent): Calls notifyRendererOfSelectionChange(true) so onSelect will get fired when the user is done making a selection with the mouse.
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]): Calls notifyRendererOfSelectionChange(true) so onSelect gets fired when the user makes a selection with the keyboard. (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]): ditto.
  • rendering/RenderTextField.h: Add userTriggered parameter to selectionChanged.
  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::setSelectionRange): For visibility:hidden, cache the selection and return early since we won't be able to actually set the selection. (WebCore::RenderTextField::selectionChanged): Caches the selection. If the selection is a range, and its triggered by user action, then fire the onSelect event.
3:11 PM Changeset in webkit [14930] by andersca
  • 3 edits in trunk/WebCore

2006-06-21 Anders Carlsson <​acarlsson@apple.com>

  • bridge/win/FrameWin.cpp: (WebCore::shouldInterruptJavaScript):
  • bridge/win/FrameWin.h: Try fixing the Windows build.
3:07 PM Changeset in webkit [14929] by adele
  • 36 edits
    2 moves in trunk

RS by Tim Hatcher.

Renamed RenderSelect to DeprecatedRenderSelect to prepare for new popup menu and list menu implementations.


  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLOptionElement.h:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::createRenderer): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::reset): (WebCore::HTMLSelectElement::notifyOptionSelected):
  • html/HTMLSelectElement.h:
  • rendering/DeprecatedRenderSelect.cpp: Added. (WebCore::DeprecatedRenderSelect::DeprecatedRenderSelect): (WebCore::DeprecatedRenderSelect::setWidgetWritingDirection): (WebCore::DeprecatedRenderSelect::setStyle): (WebCore::DeprecatedRenderSelect::updateFromElement): (WebCore::DeprecatedRenderSelect::baselinePosition): (WebCore::DeprecatedRenderSelect::calcMinMaxWidth): (WebCore::DeprecatedRenderSelect::layout): (WebCore::DeprecatedRenderSelect::valueChanged): (WebCore::DeprecatedRenderSelect::selectionChanged): (WebCore::DeprecatedRenderSelect::setOptionsChanged): (WebCore::DeprecatedRenderSelect::createListBox): (WebCore::DeprecatedRenderSelect::updateSelection):
  • rendering/DeprecatedRenderSelect.h: Added. (WebCore::DeprecatedRenderSelect::renderName):
  • rendering/RenderSelect.cpp: Removed.
  • rendering/RenderSelect.h: Removed.
3:01 PM Changeset in webkit [14928] by andersca
  • 1 edit in trunk/WebCore/dom/xml_tokenizer.cpp

Commit for real this time - Not just the ChangeLog and some white-space

2:34 PM Changeset in webkit [14927] by andersca
  • 2 edits in trunk/WebCore

2006-06-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9509
Would like a way to pause/resume XML parsing

  • dom/xml_tokenizer.cpp: (WebCore::PendingCallbacks::PendingCallbacks): (WebCore::PendingCallbacks::appendStartElementNSCallback): (WebCore::PendingCallbacks::appendEndElementNSCallback): (WebCore::PendingCallbacks::appendCharactersCallback): (WebCore::PendingCallbacks::appendProcessingInstructionCallback): (WebCore::PendingCallbacks::appendCDATABlockCallback): (WebCore::PendingCallbacks::appendCommentCallback): (WebCore::PendingCallbacks::appendInternalSubsetCallback): (WebCore::PendingCallbacks::appendErrorCallback): (WebCore::PendingCallbacks::callAndRemoveFirstCallback): (WebCore::PendingCallbacks::isEmpty): (WebCore::PendingCallbacks::PendingCallback::~PendingCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::~PendingStartElementNSCallback): (WebCore::PendingCallbacks::PendingStartElementNSCallback::call): (WebCore::PendingCallbacks::PendingEndElementNSCallback::call): (WebCore::PendingCallbacks::PendingCharactersCallback::~PendingCharactersCallback): (WebCore::PendingCallbacks::PendingCharactersCallback::call): (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::~PendingProcessingInstructionCallback): (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::call): (WebCore::PendingCallbacks::PendingCDATABlockCallback::~PendingCDATABlockCallback): (WebCore::PendingCallbacks::PendingCDATABlockCallback::call): (WebCore::PendingCallbacks::PendingCommentCallback::~PendingCommentCallback): (WebCore::PendingCallbacks::PendingCommentCallback::call): (WebCore::PendingCallbacks::PendingInternalSubsetCallback::~PendingInternalSubsetCallback): (WebCore::PendingCallbacks::PendingInternalSubsetCallback::call): (WebCore::PendingCallbacks::): New classes which manage a list of pending SAX callbacks that have not yet been sent to the tokenizer.


(WebCore::XMLTokenizer::XMLTokenizer):
Initialize new member variables.


(WebCore::XMLTokenizer::~XMLTokenizer):
Delete PendingCallbacks object.


(WebCore::XMLTokenizer::write):
If the parser is paused, queue the data to be written.


(WebCore::XMLTokenizer::startElementNs):
(WebCore::XMLTokenizer::endElementNs):
(WebCore::XMLTokenizer::characters):
(WebCore::XMLTokenizer::error):
(WebCore::XMLTokenizer::processingInstruction):
(WebCore::XMLTokenizer::cdataBlock):
(WebCore::XMLTokenizer::comment):
(WebCore::XMLTokenizer::internalSubset):
If the parser has been paused, queue the callbacks instead.

(WebCore::XMLTokenizer::handleError):
New function, called by both ::error and :PendingCallbacks::callAndRemoveFirstCallback


(WebCore::XMLTokenizer::finish):
(WebCore::XMLTokenizer::pauseParsing):

Set m_parserPaused to true.


(WebCore::XMLTokenizer::resumeParsing):
Call the pending callbacks and then parse the pending source.

2:24 PM Changeset in webkit [14926] by hyatt
  • 3 edits in trunk/WebCore

Don't send the custom highlighter callback when painting is disabled.

Reviewed by harrison

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
2:04 PM Changeset in webkit [14925] by adele
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

  • WebView/WebMainResourceLoader.m: Added missing header to fix build on Leopard.
12:44 PM Changeset in webkit [14924] by andersca
  • 3 edits
    8 adds in trunk

WebCore:

2006-06-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John.

<rdar://problem/4592244> REGRESSION (417.9.3 - 420+): (some?) plain text files have all lines concatenated into one line

  • loader/TextDocument.cpp: (WebCore::TextTokenizer::checkBuffer): (WebCore::TextTokenizer::TextTokenizer): (WebCore::TextTokenizer::write): (WebCore::TextTokenizer::finish): Add a text buffer which is used for translation of CR and CRLF to plain LF, like the HTML tokenizer does.

LayoutTests:

2006-06-20 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John.

<rdar://problem/4592244> REGRESSION (417.9.3 - 420+): (some?) plain text files have all lines concatenated into one line

  • fast/text/plain-text-line-breaks-expected.checksum: Added.
  • fast/text/plain-text-line-breaks-expected.png: Added.
  • fast/text/plain-text-line-breaks-expected.txt: Added.
  • fast/text/plain-text-line-breaks.html: Added.
  • fast/text/resources/line-breaks-cr.txt: Added.
  • fast/text/resources/line-breaks-crlf.txt: Added.
  • fast/text/resources/line-breaks-lf.txt: Added.
12:12 PM Changeset in webkit [14923] by thatcher
  • 1 edit
    51 adds in trunk/WebKitTools

Reviewed by Darin.


Adds a JavaScript debugger, called Drosera. Named after
a genus of bug eating plants.

  • Drosera/DebuggerApplication.h: Added.
  • Drosera/DebuggerApplication.m: Added. (-[DebuggerApplication applicationDidFinishLaunching:]): (-[DebuggerApplication serverLoaded:]): (-[DebuggerApplication serverUnloaded:]): (-[DebuggerApplication awakeFromNib]): (-[DebuggerApplication showAttachPanel:]): (-[DebuggerApplication attach:]): (-[DebuggerApplication numberOfRowsInTableView:]): (-[DebuggerApplication tableView:objectValueForTableColumn:row:]): (-[DebuggerApplication tableView:willDisplayCell:forTableColumn:row:]): (-[DebuggerApplication tableViewSelectionDidChange:]):
  • Drosera/DebuggerDocument.h: Added.
  • Drosera/DebuggerDocument.m: Added. (+[WebScriptCallFrame isSelectorExcludedFromWebScript:]): (+[WebScriptCallFrame isKeyExcludedFromWebScript:]): (+[DebuggerDocument isSelectorExcludedFromWebScript:]): (+[DebuggerDocument isKeyExcludedFromWebScript:]): (-[DebuggerDocument initWithServerName:]): (-[DebuggerDocument windowWillClose:]): (-[DebuggerDocument dealloc]): (-[DebuggerDocument isPaused]): (-[DebuggerDocument pause]): (-[DebuggerDocument resume]): (-[DebuggerDocument step]): (-[DebuggerDocument windowNibName]): (-[DebuggerDocument windowDidLoad]): (-[DebuggerDocument switchToServerNamed:]): (-[DebuggerDocument applicationTerminating:]): (-[DebuggerDocument serverConnectionDidDie:]): (-[DebuggerDocument webView:windowScriptObjectAvailable:]): (-[DebuggerDocument webView:didFinishLoadForFrame:]): (-[DebuggerDocument webView:didParseSource:fromURL:sourceId:forWebFrame:]): (-[DebuggerDocument webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[DebuggerDocument webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[DebuggerDocument webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
  • Drosera/Drosera.pch: Added.
  • Drosera/Drosera.xcodeproj/project.pbxproj: Added.
  • Drosera/English.lproj/Debugger.nib/classes.nib: Added.
  • Drosera/English.lproj/Debugger.nib/info.nib: Added.
  • Drosera/English.lproj/Debugger.nib/keyedobjects.nib: Added.
  • Drosera/English.lproj/MainMenu.nib/classes.nib: Added.
  • Drosera/English.lproj/MainMenu.nib/info.nib: Added.
  • Drosera/English.lproj/MainMenu.nib/keyedobjects.nib: Added.
  • Drosera/Images/breakPoint.tif: Added.
  • Drosera/Images/breakPointDisabled.tif: Added.
  • Drosera/Images/continue.tif: Added.
  • Drosera/Images/finishFunction.tif: Added.
  • Drosera/Images/glossyFooterFill.tif: Added.
  • Drosera/Images/glossyHeader.png: Added.
  • Drosera/Images/gradientBackground.png: Added.
  • Drosera/Images/gutter.png: Added.
  • Drosera/Images/navLeftDisabled.png: Added.
  • Drosera/Images/navLeftNormal.png: Added.
  • Drosera/Images/navLeftPressed.png: Added.
  • Drosera/Images/navRightDisabled.png: Added.
  • Drosera/Images/navRightNormal.png: Added.
  • Drosera/Images/navRightPressed.png: Added.
  • Drosera/Images/pause.tif: Added.
  • Drosera/Images/popUpArrows.png: Added.
  • Drosera/Images/programCounter.tif: Added.
  • Drosera/Images/programCounterBreakPoint.tif: Added.
  • Drosera/Images/programCounterBreakPointDisabled.tif: Added.
  • Drosera/Images/run.tif: Added.
  • Drosera/Images/splitterBar.tif: Added.
  • Drosera/Images/splitterDimple.tif: Added.
  • Drosera/Images/step.tif: Added.
  • Drosera/Images/stepOver.tif: Added.
  • Drosera/Images/stop.tif: Added.
  • Drosera/Images/toolbarBackground.png: Added.
  • Drosera/Info.plist: Added.
  • Drosera/debugger.css: Added.
  • Drosera/debugger.html: Added.
  • Drosera/debugger.js: Added.
  • Drosera/main.m: Added. (main):
  • Drosera/viewer.css: Added.
  • Drosera/viewer.html: Added.
12:08 PM Changeset in webkit [14922] by thatcher
  • 5 edits in trunk/WebKit

Reviewed by Darin.

Removes the @try/@catch from the callbacks to improve performance,
simply check if the proxy object's connection is still valid first.
Listener objects are now required to be NSDistantObjects.

Adds pause, resume and step support. The debugger process use to handle this,
but it caused problems when there were multiple listeners.

Sends the bundle identifier in the notification userInfo dictionary along with
process name and process ID.

  • DefaultDelegates/WebScriptDebugServer.h:
  • DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer serverQuery:]): (-[WebScriptDebugServer addListener:]): (-[WebScriptDebugServer removeListener:]): (-[WebScriptDebugServer step]): (-[WebScriptDebugServer pause]): (-[WebScriptDebugServer resume]): (-[WebScriptDebugServer isPaused]): (-[WebScriptDebugServer suspendProcessIfPaused]): (-[WebScriptDebugServer webView:didParseSource:fromURL:sourceId:forWebFrame:]): (-[WebScriptDebugServer webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
  • DefaultDelegates/WebScriptDebugServerPrivate.h:
  • WebKit.exp:
1:14 AM Changeset in webkit [14921] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Eric.

  • fix crasher on one of the layout tests caused by my recent checkin
  • kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):

Jun 19, 2006:

10:17 PM Changeset in webkit [14920] by ap
  • 8 edits
    2 adds in trunk

Reviewed by Darin.

WebCore:

  • bindings/js/kjs_window.cpp: (KJS::LocationFunc::callAsFunction): Call scheduleRefresh() for Location::Reload.
  • page/Frame.h: Add scheduleRefresh(). Don't derive from TransferJob or implement its methods - that was used only for storing response HTTP headers, which was an overkill.
  • page/FramePrivate.h: Replace TransferJob with a HashMap for storing response headers.
  • page/Frame.cpp: (WebCore::Frame::didOpenURL): Don't needlessly change d->m_cachePolicy. Don't create a TransferJob. (WebCore::Frame::stopLoading): Directly access the metadata map, instead of going through a TransferJob. (WebCore::Frame::receivedFirstData): Ditto. (WebCore::Frame::addMetaData): Ditto. (WebCore::Frame::scheduleRefresh): A new function that schedules a refresh, similarly to what scheduleRedirection() does. (WebCore::Frame::changeLocation): Set request.reload attribute based on the current cache policy.

WebKit:

  • WebView/WebFrame.m: (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): Set a proper Cache-Control header for reload requests. (-[WebFrame loadRequest:]): Reset loadType to WebFrameLoadTypeStandard (after a reload, it stayed at WebFrameLoadTypeReload, so _addExtraFieldsToRequest erroneously added a Cache-Control header to them).

LayoutTests:

  • http/tests/misc/refresh-headers-expected.txt: Added.
  • http/tests/misc/refresh-headers.php: Added.
8:20 PM Changeset in webkit [14919] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Darin. Patch by Ben Goodger.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9501
Windows build fails with link error CharsetTable not defined

  • platform/make-charset-table.pl: (process_iana_charsets): Move test for equality to alias "None" until after normalization steps to ensure escape characters in the input data don't interfere with processing. Convert nearby tabs to 4 spaces in this function.
7:43 PM Changeset in webkit [14918] by mjs
  • 12 edits
    6 adds in trunk/WebCore

Reviewed by Darin.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=6946
"SVG shows invalidation issues in WebKit"


​http://www.treebuilder.de/default.asp?file=441875.xml
"Invalidation issues with "SVG 3d" demo"


​http://code.google.com/webstats/2005-12/pages.html
"SVG text doesn't repaint correctly"

  • kcanvas/KCanvasContainer.cpp: (WebCore::KCanvasContainer::computeAbsoluteRepaintRect): Override base class, and apply appropriate transforms, so damage rects in transformed SVG content get propagated up properly. (WebCore::KCanvasContainer::getAbsoluteRepaintRect): note a FIXME; this method seems wrong.
  • kcanvas/KCanvasContainer.h: Prototype new method.
  • css/svg.css: Don't apply overflow:hidden to foreignObject, since that makes it a RenderLayer so it paints twice.
  • kcanvas/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint): Transform the damage rect before passing it down to HTML content, so everything paints that is supposed to. Also handle opacity here since we won't get layers. (WebCore::RenderForeignObject::computeAbsoluteRepaintRect): Override base class, and apply appropriate transforms, so damage rects in HTML embedded in SVG get propagated up properly. (WebCore::RenderForeignObject::requiresLayer): Never use a RenderLayer. (WebCore::RenderForeignObject::layout): Make sure to dirty our previous bounds when layout changes, as by transform.
  • kcanvas/RenderForeignObject.h:
  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): Transform the damage rect when painting. Also handle opacity here since we won't get layers. (WebCore::RenderForeignObject::computeAbsoluteRepaintRect): Override base class, and apply appropriate transforms, so damage rects in SVG images get propagated up properly. (WebCore::RenderSVGImage::translationForAttributes): New helper method, factored out of below. (WebCore::RenderSVGImage::translateForAttributes): Use above. (WebCore::RenderSVGImage::requiresLayer): Never use a RenderLayer. (WebCore::RenderSVGImage::layout): Make sure to properly dirty the old bounds, accounting for transforms. (WebCore::RenderSVGImage::relativeBBox): Correct bbox computation.
  • kcanvas/RenderSVGImage.h:
  • kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::paint): Transform incoming damage rect. Handle opacity here since we won't get a layer. (WebCore::RenderSVGText::computeAbsoluteRepaintRect): Apply transforms. (WebCore::RenderSVGText::requiresLayer): Never use a RenderLayer. (WebCore::RenderSVGText::layout): Make sure to dirty the old bounds.
  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::roundToDevicePixels): Instead of transforming rect to device space and back to user space, do this for the origin and lower right corner of the rect. Otherwise the rect will get inflated if user space is rotated or skewed.
  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::layout): Make sure to dirty the old bounds. (WebCore::RenderPath::paint): Hhandle opacity here.


Bonus fix:


  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::nodeAtPoint): Fix hit testing. Wasn't applying the x/y attribute transform.
4:31 PM Changeset in webkit [14917] by thatcher
  • 1 edit in trunk/WebKit/WebView/WebView.h

Build fix.

3:58 PM Changeset in webkit [14916] by weinig
  • 40 edits
    20 copies
    2 moves in trunk/WebCore
2:58 PM Changeset in webkit [14915] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Darin.


  • added mechanism to notify UIDelegate when part of the webview is redrawn. For now, it only works for HTML views.
  • WebView/WebUIDelegatePrivate.h: Define a new UIDelegate method -webView:didDrawRect:
  • WebView/WebHTMLView.m: (-[WebView drawSingleRect:]): Call through to UIDelegate if it implements that method. I tested that this does not impact PLT numbers in the case where the delegate implements the method but does nothing in it.
2:39 PM Changeset in webkit [14914] by darin
  • 4 edits
    3 deletes in trunk/WebCore

Reviewed by Brady.

  • removed a few empty/unused files Brady found by tracking down the nm error message
  • editing/VisibleRange.cpp: Removed.
  • editing/VisibleRange.h: Removed.
  • kcanvas/KCanvasImage.cpp: Removed.
  • WebCore.vcproj/WebCore/WebCore.vcproj: Removed VisibleRange.cpp/h.
  • WebCore.xcodeproj/project.pbxproj: Removed VisibleRange.cpp/h and KCanvasImage.cpp.
  • WebCoreSources.bkl: Removed VisibleRange.cpp.
12:23 PM Changeset in webkit [14913] by andersca
  • 2 edits in trunk/JavaScriptCore

2006-06-19 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John.

  • kjs/interpreter.cpp: (KJS::TimeoutChecker::pauseTimeoutCheck): (KJS::TimeoutChecker::resumeTimeoutCheck): Fix argument order in setitimer calls.
9:42 AM Changeset in webkit [14912] by ap
  • 2 edits in trunk/WebCore

Reviewed by Darin.

It was only available in newly created windows, and became undefined after changing the URL
or reloading. Let's try removing it; hopefully, no-one will notice.

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScriptIfNeeded): Don't add window.debug.
9:15 AM Changeset in webkit [14911] by ap
  • 9 edits in trunk

Reviewed by Darin.

Test: LayoutTests/fast/encoding/invalid-UTF-8.html

  • dom/xml_tokenizer.cpp: (WebCore::getXHTMLEntity): Properly null-terminate the result. This didn't matter before, because the garbage at the end was guaranteed to be invalid UTF-8, and was omitted in appendOmittingUnwanted();
  • platform/StreamingTextDecoder.cpp: (WebCore::StreamingTextDecoder::appendOmittingBOM): Only omit BOM characters. Renamed back from appendOmittingUnwanted();

(WebCore::StreamingTextDecoder::convertUsingICU):

  • platform/StreamingTextDecoder.h: Update for the above function renaming.
3:51 AM Changeset in webkit [14910] by ddkilzer
  • 2 edits in trunk/WebKit

WebKit:

Reviewed by Maciej.

  • WebView/WebFrame.m: (-[WebFrame _checkLoadCompleteForThisFrame]): Avoid re-entering the delegate's -[webView:didFailProvisionalLoadWithError:forFrame].

Jun 18, 2006:

5:00 PM Changeset in webkit [14909] by ddkilzer
  • 3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9485
Teach svn-apply and svn-unapply to use full path names

  • Scripts/svn-apply: Changed to use full path names. Cleaned up code.
  • Scripts/svn-unapply: Ditto.
4:54 PM Changeset in webkit [14908] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9498
Remove dead code left in JSHTMLDocument::getOwnPropertySlot() from r14298 (Bug 7838)

  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::getOwnPropertySlot): Remove dead code.
3:20 PM Changeset in webkit [14907] by ddkilzer
  • 4 edits in trunk

LayoutTests:

Reviewed by ggaren.

  • fast/history/clicked-link-is-visited.html: Changed to use DOM mouse event.

WebCore:

Reviewed by ggaren.

  • manual-tests/redraw-page-cache-visited-links.html: Changed to use DOM mouse event.
10:58 AM Changeset in webkit [14906] by ddkilzer
  • 5 edits in trunk/WebKit

WebKit:

Reviewed by xenon.

  • WebInspector/WebInspector.m: (-[NSWindow setWebFrame:]): Added code to (de)register with the WebFrame the inspector is (no longer) targeting. (-_webFrameDetached:): Added. Moved the code that was previously in -[inspectedWindowWillClose:] here. This is called by the WebFrame when it is detached from its parent.
  • WebInspector/WebInspectorInternal.h:
  • WebView/WebFrame.m: (-[WebFramePrivate dealloc]): (-[WebFrame _detachFromParent]): Added code to notify all registered inspectors that the WebFrame is detaching. (-[WebFrame _addInspector:]): Added. (-[WebFrame _removeInspector:]): Added.
  • WebView/WebFrameInternal.h:
10:54 AM Changeset in webkit [14905] by ddkilzer
  • 7 edits
    7 adds in trunk

LayoutTests:

Reviewed by ggaren.

  • fast/history/clicked-link-is-visited-expected.checksum: Added.
  • fast/history/clicked-link-is-visited-expected.png: Added.
  • fast/history/clicked-link-is-visited-expected.txt: Added.
  • fast/history/clicked-link-is-visited.html: Added.
  • fast/history/resources/clicked-link-is-visited-2.html: Added.

WebCore:

Reviewed by ggaren.

  • manual-tests/redraw-page-cache-visited-links.html: Added note about window.history hack. Fixed coordinates for mouse events. Added call to keepWebHistory().
  • manual-tests/resources/redraw-page-cache-visited-links-2.html: Added note about window.history hack.

WebKitTools:

Reviewed by ggaren.

Test: LayoutTests/fast/history/clicked-link-is-visited.html

  • DumpRenderTree/DumpRenderTree.m: Add keepWebHistory function to layoutTestController (+[LayoutTestController isSelectorExcludedFromWebScript:]): Updated for keepWebHistory. (-[LayoutTestController keepWebHistory]): Added. We only set optional shared history if it is currently nil since keepWebHistory() might be called more than once incidentally for the same test. (dumpRenderTree): Set optional shared history in WebHistory to nil by default.
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Xcode 2.3 clean up.
10:11 AM Changeset in webkit [14904] by andersca
  • 16 edits in trunk

JavaScriptCore:

2006-06-18 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

  • kjs/interpreter.cpp: (KJS::TimeoutChecker::pauseTimeoutCheck): Do nothing if the timeout check hasn't been started.


(KJS::TimeoutChecker::resumeTimeoutCheck):
Do nothing if the timeout check hasn't been started.
Use the right signal handler when unblocking.


(KJS::Interpreter::handleTimeout):
pause/resume the timeout check around the call to
shouldInterruptScript().


WebCore:

2006-06-17 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::ScriptInterpreter): Set the default script timeout.


(KJS::ScriptInterpreter::shouldInterruptScript):
New function which asks the frame if the script should be interrupted.


  • bindings/js/kjs_binding.h:


  • bindings/js/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate): Add calls to startTimeoutCheck/stopTimeoutCheck


  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): Add calls to pauseTimeoutCheck/unpauseTimeoutCheck


(KJS::ScheduledAction::execute):
Add calls to startTimeoutCheck/stopTimeoutCheck


  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::shouldInterruptJavaScript): New function which asks the bridge if the script should be interrupted.


  • bridge/mac/WebCoreFrameBridge.h:
  • page/Frame.h: Add function declarations.


WebKit:

2006-06-18 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Geoff.

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge shouldInterruptJavaScript]): Ask the UI delegate if the script should be interrupted.


  • WebView/WebUIDelegatePrivate.h: Declare webViewShouldInterruptJavaScript: delegate method
12:00 AM Changeset in webkit [14903] by ap
  • 3 edits
    2 adds in trunk

Reviewed by ggaren.

Most of the properties were already fixed, this just adds adds a prototype to window.debug.

Test: fast/dom/everything-to-string.html

  • bindings/js/kjs_proxy.cpp: (WebCore::TestFunctionImp::TestFunctionImp): (WebCore::KJSProxy::initScriptIfNeeded):

Jun 17, 2006:

11:25 PM Changeset in webkit [14902] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9491
Windows build breaks in interpreter.cpp

  • kjs/interpreter.cpp (KJS::TimeoutChecker::pauseTimeoutCheck): (KJS::TimeoutChecker::resumeTimeoutCheck): Make sure to only assert equality with s_executingInterpreter when it is being used (i.e. when HAVE(SYS_TIME_H) == true)
9:22 PM Changeset in webkit [14901] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Maciej.

  • Fix capitalization issue for case-sensitive filesystems.
  • icon/SQLStatement.cpp: Change assertions.h to Assertions.h.
5:30 PM Changeset in webkit [14900] by ddkilzer
  • 2 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9477
REGRESSION: fast/dom/replaceChild.html crashes on WebKit ToT in debug build

  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): Refetch the debugger after executing the function in case the WebFrame it was running in has since been destroyed.
8:54 AM Changeset in webkit [14899] by adele
  • 7 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • css2.1/t0905-c5525-fltmult-00-d-g-expected.checksum: Updated.
  • css2.1/t0905-c5525-fltmult-00-d-g-expected.png: Updated.
  • css2.1/t0905-c5525-fltmult-00-d-g-expected.txt: Updated.
  • fast/block/float/table-relayout-expected.checksum: Added.
  • fast/block/float/table-relayout-expected.png: Added.
  • fast/block/float/table-relayout-expected.txt: Added.
  • fast/block/float/table-relayout.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/block/float/table-relayout.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout): Added marking of children that use lineWidth.
  • rendering/RenderBlock.h: Added a FIXME.
8:37 AM Changeset in webkit [14898] by adele
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Test cases for
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=6282>

  • fast/dom/select-selectedIndex-multiple.html: Added.
  • fast/dom/select-selectedIndex.html: Added.

WebCore:

Reviewed by Darin.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6282:
Adding new Option with new Option(text, value, defaultSelected, selected) fails to update selectedIndex

Update selectedIndex when a new option is added using javascript.

  • bindings/js/kjs_html.cpp: (KJS::JSHTMLSelectCollection::put):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): (WebCore::HTMLSelectElement::setOption): (WebCore::HTMLSelectElement::setLength):
  • html/HTMLSelectElement.h:
8:29 AM Changeset in webkit [14897] by adele
  • 4 edits
    1 add in trunk

WebCore:

Reviewed by Darin.

  • manual-tests/reset-initiatedDrag.html: Added.

WebKit:

Reviewed by Darin.

  • WebView/WebFrameView.m: (-[WebFrameView _setDocumentView:]): Reset the WebView's initiatedDrag flag when the document view is changed.
  • WebView/WebHTMLView.m: (-[WebHTMLView draggedImage:endedAt:operation:]): Changed the ASSERT to allow for drags that end after the view has been removed from the WebView.
3:48 AM Changeset in webkit [14896] by ddkilzer
  • 2 edits in trunk/JavaScriptCore

JavaScriptCore:

Reviewed by ggaren.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9476
REGRESSION: Reproducible crash after closing window after viewing
css2.1/t0803-c5501-imrgn-t-00-b-ag.html

  • kjs/debugger.cpp: (Debugger::detach): Call setDebugger(0) for all interpreters removed from the 'attached to a debugger' list.

Jun 16, 2006:

6:15 PM Changeset in webkit [14895] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9463
REGRESSION (r14879): Assertion failure in CSSParser::sinkFloatingSelector()
(m_floatingSelectors.contains(selector)) in some CSS tests

  • css/CSSGrammar.y: Create CSSSelector for FUNCTION using CSSParser::createFloatingSelector() instead of the bare constructor.
6:08 PM Changeset in webkit [14894] by harrison
  • 2 edits in trunk/WebCore

<rdar://problem/4565312> Mail has a weird drawing artifact with dotted red lines running across the window

Problem was that revision lost a check to not draw the markers
when paintingDisabled(). This led the markers to be drawn when
the window deactivated, at which time the view happens to be flipped.

It is similar but not the same as the Mail ToDo highlighting
issue, which is due to the custom highlight method
drawing when the focusView is nil. Mail team knows this
and has tested the fix.

  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspelling): Early return if paintingDisabled().
4:47 PM Changeset in webkit [14893] by andersca
  • 6 edits in trunk/JavaScriptCore

2006-06-17 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej and Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=7080
Provide some way to stop a JavaScript infinite loop


  • kjs/completion.h: (KJS::): Add Interrupted completion type.


  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::GlobalFuncImp::callAsFunction): Only set the exception on the new ExecState if the current one has had one.


  • kjs/interpreter.cpp: (KJS::TimeoutChecker::startTimeoutCheck): (KJS::TimeoutChecker::stopTimeoutCheck): (KJS::TimeoutChecker::alarmHandler): (KJS::TimeoutChecker::pauseTimeoutCheck): (KJS::TimeoutChecker::resumeTimeoutCheck): New TimeoutChecker class which handles setting Interpreter::m_timedOut flag after a given period of time. This currently only works on Unix platforms where setitimer and signals are used.


(KJS::Interpreter::Interpreter):
Initialize new member variables.


(KJS::Interpreter::~Interpreter):
Destroy the timeout checker.


(KJS::Interpreter::startTimeoutCheck):
(KJS::Interpreter::stopTimeoutCheck):
(KJS::Interpreter::pauseTimeoutCheck):
(KJS::Interpreter::resumeTimeoutCheck):
Call the timeout checker.


(KJS::Interpreter::handleTimeout):
Called on timeout. Resets the m_timedOut flag and calls shouldInterruptScript.


  • kjs/interpreter.h: (KJS::Interpreter::setTimeoutTime): New function for setting the timeout time.


(KJS::Interpreter::shouldInterruptScript):
New function. The idea is that this should be overridden by subclasses in order to for example
pop up a dialog asking the user if the script should be interrupted.


(KJS::Interpreter::checkTimeout):
New function which checks the m_timedOut flag and calls handleTimeout if it's set.


  • kjs/nodes.cpp: (DoWhileNode::execute): (WhileNode::execute): (ForNode::execute): Call Interpreter::checkTimeout after each iteration of the loop.
4:45 PM Changeset in webkit [14892] by adele
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Adjust padding of inner div so text lines up with text fields.
Adjust height of textarea so it only leaves room for the horizontal
scrollbar if overflow is set to scroll, or if overflow is set to
auto and there's no word wrap.

These changes will be tested by current layout tests when the
new textarea implementation takes effect.

  • rendering/RenderTextField.cpp: (WebCore::RenderTextField::createDivStyle): (WebCore::RenderTextField::calcHeight):
2:49 PM Changeset in webkit [14891] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Darin


  • fixed <rdar://problem/4590062> crash in marker code with particular set of steps on daringfireball.net
  • dom/Document.cpp: (WebCore::Document::addMarker): Store [it - markers.begin()] in a local variable before modifying markers, since modifying markers can change value of [it - markers.begin()].
2:10 PM Changeset in webkit [14890] by thatcher
  • 7 edits
    3 adds in trunk/WebKit

Reviewed by Tim O.

Exposes a distributed objects server for clients to register for script debugger calls.
For preformance concerns this is disabled by default, you will need to enable this per application.
To enable for Safari do this: defaults write com.apple.Safari WebKitScriptDebuggerEnabled -bool true

Clients will need to listen to the following distributed notification to discover servers:
WebScriptDebugServerDidLoadNotification

To discover servers that previously loaded before the client, the client needs to send the following notification:
WebScriptDebugServerQueryNotification

All servers will reply with the WebScriptDebugServerQueryReplyNotification notification that contains the
registered server connection name to use with distributed objects.

  • DefaultDelegates/WebScriptDebugServer.h: Added.
  • DefaultDelegates/WebScriptDebugServer.m: Added. (+[WebScriptDebugServer sharedScriptDebugServer]): (-[WebScriptDebugServer init]): (-[WebScriptDebugServer dealloc]): (-[WebScriptDebugServer serverQuery:]): (-[WebScriptDebugServer listenerConnectionDidDie:]): (-[WebScriptDebugServer addListener:]): (-[WebScriptDebugServer removeListener:]): (-[WebScriptDebugServer webView:didParseSource:fromURL:sourceId:forWebFrame:]): (-[WebScriptDebugServer webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willLeaveCallFrame:sourceId:line:forWebFrame:]):
  • DefaultDelegates/WebScriptDebugServerPrivate.h: Added.
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge windowObjectCleared]):
  • WebKit.exp:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebScriptDebugDelegate.m: (-[WebScriptCallFrame parsedSource:fromURL:sourceId:]): (-[WebScriptCallFrame enteredFrame:sourceId:line:]): (-[WebScriptCallFrame hitStatement:sourceId:line:]): (-[WebScriptCallFrame leavingFrame:sourceId:line:]):
  • WebView/WebView.m: (+[WebView _developerExtrasEnabled]): (+[WebView _scriptDebuggerEnabled]): (-[WebView _menuForElement:defaultItems:]): (-[WebView _commonInitializationWithFrameName:groupName:]):
  • WebView/WebViewPrivate.h:
11:27 AM Changeset in webkit [14889] by adele
  • 12 edits in trunk

WebCore:

Reviewed by Alice.

Added code to draw Cocoa-like border for textareas instead of just using CSS.

  • WebCore.exp:
  • css/html4.css: Sets a 1px solid border.
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • rendering/RenderThemeMac.h: Formatting changes.
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintTextArea): Uses new wkDrawBezeledTextArea to draw border.

WebKit:

Reviewed by Alice.

Added initialization for WKDrawBezeledTextArea.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

WebKitLibraries:

Reviewed by Alice.

  • WebKitSystemInterface.h: Added WKDrawBezeledTextArea().
  • libWebKitSystemInterface.a: ditto.
10:02 AM Changeset in webkit [14888] by adele
  • 1 edit
    1 add in trunk/LayoutTests

Reviewed by Maciej.

Adding missing expected result for test from yesterday.

  • fast/events/window-load-capture-expected.txt: Added.
6:13 AM Changeset in webkit [14887] by ddkilzer
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by hyatt.

  • fast/text/capitalize-empty-generated-string-expected.checksum: Added.
  • fast/text/capitalize-empty-generated-string-expected.png: Added.
  • fast/text/capitalize-empty-generated-string-expected.txt: Added.
  • fast/text/capitalize-empty-generated-string.html: Added.

WebCore:

Reviewed by hyatt.

Test: fast/text/capitalize-empty-generated-string.html

  • rendering/RenderText.cpp: (WebCore::RenderText::setText): Skip empty-string text renderers when looking for the previous character.
Note: See TracTimeline for information about the timeline view.