Timeline



Aug 2, 2006:

11:08 PM Changeset in webkit [15763] by thatcher
  • 2 edits in trunk/WebKit

Rubber stamped by Maciej.

Adding back resultsWithXpathQuery, removed by Darin's earlier change.
This function is called from ObjC, but not used from JavaScript.

4:18 PM Changeset in webkit [15762] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

Bug 9632: [Drosera] syntax highlighting is slow (reproducible 40 second hang)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9632

Do not change the file source when normalizing the line endings.
We use this file source to compare against new versions of the source
as it comes in, so we can skip re-syntax highlighting if they are the same.
The problem is apparent on yahoo.com since they have mixed line endings and
once we normalize them the source will always be different. This was
compounded by the fact that yahoo has around 40 inline scripts. Each
inline script causes us to check if the main document has more loaded,
that is when we compare the source strings. Since they are always different
we would syntax highlight yahoo.com 40 times! We do check source length before
doing a more expensive string comparison, but the lengths were the same.

  • Drosera/debugger.js:
4:15 PM Changeset in webkit [15761] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Darin.

Bug 10200: [Drosera] Deadlock between Drosera and Safari while loading page
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10200

Prevent reentrancy in our debugger callbacks. This was causing a deadlock in Drosera because
suspendProcessIfPaused was being called during a DO call into Safari.

Preventing reentrancy also prevents scripts that Drosera injects and evaluates from showing
up in rare cases (such as a iframe loading about:blank). I thought this would prevent cases
where you call a function from the console and expect it to break on a breakpoint in them, but
this appears to never have worked even without this change. When that is figured out we can
reconsider a better solution to reentrancy. I have filed that as bug 10214.

I also removed the NSRunLoop runMode:beforeDate: calls since DO handles this for us since
we don't use "onway void" as the return type for the callbacks. Note: using onway void for
the listener callbacks causes bad synchronization issues and obscure crashes.

  • DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer webView:didLoadMainResourceForDataSource:]): (-[WebScriptDebugServer webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[WebScriptDebugServer webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]): (-[WebScriptDebugServer webView:didEnterCallFrame:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willExecuteStatement:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:willLeaveCallFrame:sourceId:line:forWebFrame:]): (-[WebScriptDebugServer webView:exceptionWasRaised:sourceId:line:forWebFrame:]):
  • DefaultDelegates/WebScriptDebugServerPrivate.h:
3:59 PM Changeset in webkit [15760] by hyatt
  • 4 edits in trunk/WebCore

Abstract RenderLayer scrollbar creation and destruction so that there
is a clean spot in which to drop in engine scrollbar stuff.

Reviewed by timo

  • platform/ScrollBar.h: (WebCore::ScrollBar::hasPlatformScrollBars):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::destroyScrollbar): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar):
  • rendering/RenderLayer.h:
3:58 PM Changeset in webkit [15759] by ggaren
  • 2 edits
    1 add in trunk/WebKitSite

Reviewed by TimO.


Tweaked the build instructions a bit.

  • building/build.html:
  • building/debug.png: Added.
3:47 PM RecentChanges created by trac
3:47 PM SandBox created by trac
3:47 PM TitleIndex created by trac
3:47 PM CamelCase created by trac
3:47 PM TracAccessibility created by trac
3:47 PM TracAdmin created by trac
3:47 PM TracBackup created by trac
3:47 PM TracBrowser created by trac
3:47 PM TracCgi created by trac
3:47 PM TracInstall created by trac
3:47 PM TracInterfaceCustomization created by trac
3:47 PM TracLinks created by trac
3:47 PM TracChangeset created by trac
3:47 PM TracEnvironment created by trac
3:47 PM TracFastCgi created by trac
3:47 PM TracGuide created by trac
3:47 PM TracRss created by trac
3:47 PM TracImport created by trac
3:47 PM TracIni created by trac
3:47 PM TracLogging created by trac
3:47 PM TracModPython created by trac
3:47 PM TracNotification created by trac
3:47 PM TracPermissions created by trac
3:47 PM TracPlugins created by trac
3:47 PM TracQuery created by trac
3:47 PM TracReports created by trac
3:47 PM TracRoadmap created by trac
3:47 PM TracSearch created by trac
3:47 PM TracStandalone created by trac
3:47 PM TracSupport created by trac
3:47 PM TracSyntaxColoring created by trac
3:47 PM TracTickets created by trac
3:47 PM WikiHtml created by trac
3:47 PM TracTicketsCustomFields created by trac
3:47 PM TracTimeline created by trac
3:47 PM TracUnicode created by trac
3:47 PM TracUpgrade created by trac
3:47 PM TracWiki created by trac
3:47 PM WikiDeletePage created by trac
3:47 PM WikiFormatting created by trac
3:47 PM WikiMacros created by trac
3:47 PM WikiPageNames created by trac
3:47 PM WikiProcessors created by trac
3:47 PM WikiRestructuredText created by trac
3:47 PM WikiRestructuredTextLinks created by trac
3:47 PM WikiStart created by trac
3:47 PM InterWiki edited by trac
(diff)
3:47 PM TracFineGrainedPermissions created by trac
3:47 PM TracFastCgi edited by trac
(diff)
3:47 PM TracEnvironment edited by trac
(diff)
3:47 PM TracChangeset edited by trac
(diff)
3:47 PM TracCgi edited by trac
(diff)
3:47 PM InterTrac edited by trac
(diff)
3:47 PM TracRevisionLog edited by trac
(diff)
3:47 PM TracUpgrade edited by trac
(diff)
3:47 PM TracUnicode edited by trac
(diff)
3:47 PM TracTimeline edited by trac
(diff)
3:47 PM TracTicketsCustomFields edited by trac
(diff)
3:47 PM TracTickets edited by trac
(diff)
3:47 PM WikiProcessors edited by trac
(diff)
3:47 PM WikiMacros edited by trac
(diff)
3:47 PM WikiFormatting edited by trac
(diff)
3:47 PM WikiRestructuredTextLinks edited by trac
(diff)
3:47 PM WikiRestructuredText edited by trac
(diff)
3:47 PM WikiPageNames edited by trac
(diff)
3:47 PM WikiHtml edited by trac
(diff)
3:47 PM WikiDeletePage edited by trac
(diff)
3:47 PM TracWorkflow created by trac
3:47 PM TracWiki edited by trac
(diff)
3:47 PM TracSyntaxColoring edited by trac
(diff)
3:47 PM TracSupport edited by trac
(diff)
3:47 PM TracStandalone edited by trac
(diff)
3:47 PM TracSearch edited by trac
(diff)
3:47 PM TracRss edited by trac
(diff)
3:47 PM TracRoadmap edited by trac
(diff)
3:47 PM TracReports edited by trac
(diff)
3:47 PM TracQuery edited by trac
(diff)
3:47 PM TracPlugins edited by trac
(diff)
3:47 PM TracPermissions edited by trac
(diff)
3:47 PM TracNotification edited by trac
(diff)
3:47 PM TracNavigation created by trac
3:47 PM TracModPython edited by trac
(diff)
3:47 PM TracLogging edited by trac
(diff)
3:47 PM TracLinks edited by trac
(diff)
3:47 PM TracInterfaceCustomization edited by trac
(diff)
3:47 PM TracInstall edited by trac
(diff)
3:47 PM TracIni edited by trac
(diff)
3:47 PM TracImport edited by trac
(diff)
3:47 PM TracGuide edited by trac
(diff)
3:47 PM TracBrowser edited by trac
(diff)
3:47 PM TracBackup edited by trac
(diff)
3:47 PM TracAdmin edited by trac
(diff)
3:47 PM TracAccessibility edited by trac
(diff)
3:47 PM TitleIndex edited by trac
(diff)
3:47 PM RecentChanges edited by trac
(diff)
3:47 PM PageTemplates created by trac
3:47 PM CamelCase edited by trac
(diff)
1:32 PM Changeset in webkit [15758] by ap
  • 3 edits
    4 adds
    4 deletes in trunk

Fix by Mitz Pettel, reviewed by Darin.

Test: fast/replaced/image-solid-color-with-alpha.html

  • platform/mac/ImageMac.mm: (WebCore::Image::checkForSolidColor): Changed to divide each color component by the alpha component. You need to do that since the bitmap context has premultiplied alpha but m_solidColor should be non-premultiplied.
1:26 PM Changeset in webkit [15757] by aroben
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • Fixed build
  • kjs/date_object.cpp: (KJS::formatTime):
12:06 PM Changeset in webkit [15756] by mjs
  • 3 edits in trunk/WebKit

Reviewed by John.


  • fix assertion failure on layout tests by stopping plugins from loading at a clearly defined time
  • add more assertions for safety
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): Removed obsolete comment. (-[WebDataSource _updateLoading]): Add assertion ensuring this method is only called at a time when this data source is the one that might be loading for a frame. (-[WebDataSource _stopLoading]): Stop loading plugins as a FIXME suggests we should.
  • WebView/WebFrameLoader.m: (-[WebFrameLoader isLoadingPlugIns]): New helper method. (-[WebFrameLoader isLoading]): Consider plugin loads too - otherwise we won't stop them at stopLoading time.
11:35 AM Changeset in webkit [15755] by darin
  • 2 edits in trunk/WebKitSite
  • building/checkout.html: Fix a typo: "OpenSource" instead of "Open Source".
11:14 AM Changeset in webkit [15754] by aroben
  • 4 edits in trunk

WebCore:

Reviewed by Brady.

  • Remove redundant #include
  • loader/loader.cpp:

WebKit:

Reviewed by Brady.

  • Rename TransferJob to ResourceLoader (this file was forgotten in an earlier change by Maciej)
  • COM/WebView.cpp:
11:13 AM Changeset in webkit [15753] by thatcher
  • 3 edits
    1 add in trunk/WebKitTools

Reviewed by Timothy.

Bug 9931: [Drosera] Needs a cool icon
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9931

  • Drosera/Drosera.icns: Added.
  • Drosera/Drosera.xcodeproj/project.pbxproj:
  • Drosera/Info.plist:
11:07 AM Changeset in webkit [15752] by brmorris
  • 2 edits in S60/trunk/WebKit

2006-08-02 ligman <​joseph.ligman@nokia.com>

Reviewed by Yongjun, landed by Bradley.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10194
Assigned a default element type to keep the focus from being undefined.
TWebCoreFocusedElementType elType = EWebCoreElementNone;


  • BrowserView/src/WebKitControl.cpp: (CWebKitControl::FinalProgressComplete):
1:11 AM Changeset in webkit [15751] by mjs
  • 8 edits in trunk/WebKit

Reviewed by Adele.


  • Change things around so WebFrameLoader tracks the main and provisional data source, as well as the frame load state, pulling much code out of WebFrame along the way.


The most significant aspects of this change are:


  • management of WebDataSources and WebFrameState was moved into WebFrameLoader
  • there is now just one WebFrameLoader shared between the primary and provisional data source
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _updateLoading]): (-[WebDataSource _loadIcon]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource _stopLoading]): (-[WebDataSource _startLoading]): (-[WebDataSource _addSubresourceLoader:]): (-[WebDataSource _removeSubresourceLoader:]): (-[WebDataSource _addPlugInStreamLoader:]): (-[WebDataSource _removePlugInStreamLoader:]): (-[WebDataSource _defersCallbacksChanged]): (-[WebDataSource _stopLoadingWithError:]): (-[WebDataSource _revertToProvisionalState]): (-[WebDataSource _setupForReplaceByMIMEType:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource data]): (-[WebDataSource isLoading]):
  • WebView/WebFrame.m: (-[WebFramePrivate init]): (-[WebFramePrivate dealloc]): (-[WebFrame _closeOldDataSources]): (-[WebFrame _detachFromParent]): (-[WebFrame _makeDocumentView]): (-[WebFrame _receivedMainResourceError:]): (-[WebFrame _transitionToCommitted:]): (+[WebFrame _timeOfLastCompletedLoad]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _continueAfterWillSubmitForm:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrame _initWithWebFrameView:webView:bridge:]): (-[WebFrame _frameLoader]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _prepareForDataSourceReplacement]): (-[WebFrame _frameLoadCompleted]): (-[WebFrame provisionalDataSource]): (-[WebFrame dataSource]): (-[WebFrame stopLoading]):
  • WebView/WebFrameInternal.h:
  • WebView/WebFrameLoader.h:
  • WebView/WebFrameLoader.m: (-[WebFrameLoader initWithWebFrame:]): (-[WebFrameLoader dealloc]): (-[WebFrameLoader dataSource]): (-[WebFrameLoader _setDataSource:]): (-[WebFrameLoader clearDataSource]): (-[WebFrameLoader provisionalDataSource]): (-[WebFrameLoader _setProvisionalDataSource:]): (-[WebFrameLoader _clearProvisionalDataSource]): (-[WebFrameLoader state]): (+[WebFrameLoader timeOfLastCompletedLoad]): (-[WebFrameLoader _setState:]): (-[WebFrameLoader clearProvisionalLoad]): (-[WebFrameLoader markLoadComplete]): (-[WebFrameLoader commitProvisionalLoad]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader startLoading]): (-[WebFrameLoader startProvisionalLoad:]): (-[WebFrameLoader setupForReplace]):
  • WebView/WebFramePrivate.h:

Aug 1, 2006:

4:06 PM Changeset in webkit [15750] by tomernic
  • 4 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4480737> Flash crashes after it replaces itself via a document.write()


I kind of hate to do this, but this is the best way to work around buggy plug-ins like Flash that assume that
NPP_Destroy() cannot be called while the browser is calling one of its other plug-in functions. The classic
situation is a plug-in that replaces itself via an NPN_Invoke() that executes a document.write().

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]): Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions. (-[WebBaseNetscapePluginView setWindowIfNecessary]): ditto (-[WebBaseNetscapePluginView start]): It should not be possible to start a plug-in instance while we are calling into it (one of those chicken/egg problems). Added a sanity-checking assertion. (-[WebBaseNetscapePluginView stop]): If we're already calling a plug-in function, do not call NPP_Destroy(). The plug-in function we are calling may assume that its instance->pdata, or other memory freed by NPP_Destroy(), is valid and unchanged until said plugin-function returns. (-[WebBaseNetscapePluginView pluginScriptableObject]): Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions. (-[WebBaseNetscapePluginView willCallPlugInFunction]): Increment plug-in function call depth. (-[WebBaseNetscapePluginView didCallPlugInFunction]): Decrement plug-in function call depth. Stop if we're supposed to stop. (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions. (-[WebBaseNetscapePluginView webFrame:didFinishLoadWithReason:]): ditto (-[WebBaseNetscapePluginView _printedPluginBitmap]): ditto
  • Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]): Call -willCallPlugInFunction and -didCallPlugInFunction around calls to the NPP_* functions. (-[WebBaseNetscapePluginStream _destroyStream]): ditto (-[WebBaseNetscapePluginStream _deliverData]): ditto
4:04 PM Changeset in webkit [15749] by brmorris
  • 1 copy in S60/tags/s60-RnD-06wk31_rc1

Tagging S60 RnD w31 '06 release candidate 1

3:58 PM Changeset in webkit [15748] by brmorris
  • 3 edits in S60/trunk/WebKit

2006-08-01 hongzhao <​hong.a.zhao@nokia.com>

Reviewed by Yongjun.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10184
Sound continues after page closes in Bookmark view.

  • Plugin/inc/PluginAdapterInterface.h: (MPluginNotifier::): Added EPluginInvisible
  • Plugin/src/PluginWin.cpp: (CPluginWin::MakeVisible): Sends message to Plugin notifier
3:53 PM Changeset in webkit [15747] by mjs
  • 2 edits in trunk/WebKit
  • fix build after last change
  • WebView/WebFrame.m: (-[WebFrame _checkLoadCompleteForThisFrame]):
3:43 PM Changeset in webkit [15746] by brmorris
  • 6 edits in S60/trunk/WebKit

2006-07-31 vbradley <​vincent.bradley@nokia.com>

Reviewed by Yongun & Sachin

Add changes to allow the user to send plugin content to viewer.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10130

  • BrowserControl/src/BrCtl.cpp:
  • BrowserView/inc/PluginControl.h:
  • BrowserView/src/PluginControl.cpp:
  • Plugin/inc/PluginWin.h:
  • Plugin/src/PluginWin.cpp:
3:08 PM Changeset in webkit [15745] by brmorris
  • 5 edits in S60/trunk

2006-08-01 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Sachin/Youngjun.


Horizontal scroll not working with WML pages.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10092

  • BrowserControl/src/BrCtlScrollingProvider.cpp: (CBrCtlScrollingProvider::ResizeBrCtlView): Set the view rectangle in WML view.
3:05 PM Changeset in webkit [15744] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Beth.

  • revert part of my last fix that broke the Safari bookmarks view


  • WebView/WebFrame.m: (-[WebFrame _checkLoadCompleteForThisFrame]): still send layout message for non-HTML views
1:20 PM Changeset in webkit [15743] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Anders.

Fixed an assertion failure I ran into while debugging <rdar://problem/4652683>.

  • Plugins/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView redeliverStream]): Don't clear the "instance" ivar here. This code was refactored here from the old WebNetscapePluginRepresentation, which also had an "instance" ivar. It is never appropriate to clear a plug-in view's instance. That is done when the plug-in is destroyed.
1:17 PM Changeset in webkit [15742] by brmorris
  • 2 edits in S60/trunk/WebKit

2006-07-28 zhalu <​zhaosong.lu@nokia.com>

Reviewed by Youngjun.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10149

  • BrowserView/src/WebKitView.cpp: (CWebKitView::ProgressAndImageDecodeComplete): Now calls ScheduleRepaint()
1:06 PM Changeset in webkit [15741] by brmorris
  • 2 edits in S60/trunk/WebKit

2006-08-01 naguo <​George.Guo@nokia.com>

Reviewed by Yongjun.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10189

  • ResourceLoader/src/HttpDownloadObserver.cpp: (CHttpDownloadObserver::FindDownloadL): Make sure the download is not completed before start it
12:09 PM Changeset in webkit [15740] by brmorris
  • 2 edits in S60/trunk/WebCore

2006-08-01 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10185

www.euromaster.fi crash due to memory corruption.

  • kwq/KWQKURL.cpp: (KURL::KURL): free buffer (KURL::parse): free path_buffer not buffer
11:41 AM Changeset in webkit [15739] by ggaren
  • 2 edits
    3 adds in trunk/WebKitSite

Reviewed by Beth.


  • Added instructions for debugging in Xcode
  • building/build-window.png: Added.
  • building/build.html:
  • building/custom-executable.png: Added.
  • building/info-tab.png: Added.
11:38 AM Changeset in webkit [15738] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Geoff.


  • some refactoring in preparation for moving more stuff to WebFrameLoader.
  • WebView/WebFrame.m: (-[WebFrame _clearDataSource]): (-[WebFrame _detachFromParent]): (-[WebFrame _commitProvisionalLoad]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _clearProvisionalLoad]): (-[WebFrame _markLoadComplete]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _startProvisionalLoad:]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrame stopLoading]):
11:03 AM Changeset in webkit [15737] by brmorris
  • 5 edits in S60/trunk/WebKit

2006-08-01 ligman <​joseph.ligman@nokia.com>

Reviewed by Yongjun.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10131

Implemented MCoeForegroundObserver at CPluginWin to process
background/foreground events independently of changes in focus.

  • Plugin/inc/PluginLoader.h:
  • Plugin/inc/PluginSkin.h:
  • Plugin/inc/PluginWin.h:
  • Plugin/src/PluginWin.cpp: (CPluginWin::ConstructL): (CPluginWin::~CPluginWin): (CPluginWin::SizeChanged): (CPluginWin::ProcessEventL): (CPluginWin::HandleControlEventL): (CPluginWin::ViewFocusChanged): (CPluginWin::SetPluginFocusL): (CPluginWin::HandleGainingForeground): (CPluginWin::HandleLosingForeground):
10:57 AM Changeset in webkit [15736] by brmorris
  • 4 edits in S60/trunk

2006-08-01 zhalu <​zhaosong.lu@nokia.com>

Reviewed by Yongjun.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10174

  • BrowserCore/Formcontrols/src/FControlButtonSkin.cpp: (CFormButtonSkin::Draw): Now sets alpha
9:40 AM Changeset in webkit [15735] by darin
  • 4 edits in trunk

LayoutTests:

  • updated a test affected by changes to the DumpRenderTree tool to return a current mouse position
  • fast/inline/dirtyLinesForInline-expected.txt: Updated.

WebKitTools:

  • fix a bug in my recent change where the mouse position at the end of the last test would affect the results of the next test
  • DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): Set lastMousePosition to 0.

Jul 31, 2006:

11:15 PM Changeset in webkit [15734] by darin
  • 12 edits in trunk

LayoutTests:

Reviewed by Darin.

  • fast/css/hsl-color-expected.checksum:
  • fast/css/hsl-color-expected.png:
  • fast/css/hsl-color-expected.txt:
  • fast/forms/input-disabled-color-expected.checksum:
  • fast/forms/input-disabled-color-expected.png:
  • fast/forms/input-disabled-color-expected.txt:

WebCore:

Reviewed by Darin.


Fixes scaling issue and fixes Color to follow style guidelines.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
  • platform/Color.cpp: (WebCore::calcHue): (WebCore::makeRGBAFromHSLA): (WebCore::Color::Color): (WebCore::Color::name): (WebCore::Color::setNamedColor): (WebCore::Color::light): (WebCore::Color::dark): (WebCore::blend):
  • platform/Color.h: (WebCore::Color::Color): (WebCore::Color::isValid): (WebCore::Color::red): (WebCore::Color::green): (WebCore::Color::blue): (WebCore::Color::alpha): (WebCore::Color::rgb): (WebCore::Color::setRGB): (WebCore::operator==): (WebCore::operator!=):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorder):
11:13 PM Changeset in webkit [15733] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/backgrounds/solid-color-context-restore-expected.checksum: Added.
  • fast/backgrounds/solid-color-context-restore-expected.png: Added.
  • fast/backgrounds/solid-color-context-restore-expected.txt: Added.
  • fast/backgrounds/solid-color-context-restore.html: Added.

WebCore:

Reviewed by Darin.

Pixel test: fast/backgrounds/solid-color-context-restore.html

  • platform/mac/ImageMac.mm: (WebCore::Image::draw): Added calls to preserve the graphics context around the painting of a solid color image. (WebCore::Image::drawTiled): Ditto.
11:10 PM Changeset in webkit [15732] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10182
Bug 10182: [Drosera] Evaluating expressions in Console is slow when current frame has many variables

  • Drosera/console.js: String.indexOf returns -1 when the string is not found. Correct the logic to not reload local variable list unless an '=' character is in the expression.
11:00 PM Changeset in webkit [15731] by darin
  • 5 edits in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/events/objc-event-api-expected.txt: Updated test results for changes in the DumpRenderTree tool.

WebKitTools:

Reviewed by Maciej.

  • DumpRenderTree/DumpRenderTree.m: (main): Add pose so we can implement +[NSEvent mouseLocation]. Put the window at a predictable location in flipped coordinates, since those are the coordinates that we use. (+[DumpRenderTreeEvent mouseLocation]): Implement this, since it's used for mouse event handling inside WebHTMLView.
  • DumpRenderTree/EventSendingController.m: (+[EventSendingController initialize]): Removed unused webkitDomEventProperties array. (-[EventSendingController init]): Removed, since the whole thing was a no-op. (-[EventSendingController mouseMoveToX:Y:]): Convert the x,y pair to window coordinates. The old code probably worked OK, but this is needed to be correct. (-[EventSendingController handleEvent:]): Put clientX/Y before screenX/Y and removed the flipping code from screenY. We didn't really need to flip screenY -- what was actually happening was that the position that DumpRenderTree chose was in non-flipped coordinates, and with that fixed we can just dump the screenY as-is.
10:15 PM Changeset in webkit [15730] by mjs
  • 25 edits
    10 moves in trunk

WebCore:

Rubber-stamped by Tim Hatcher.

  • renamed TransferJob to ResourceLoader
  • Projects/gdk/webcore-gdk.bkl:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bridge/mac/FrameMac.mm:
  • bridge/mac/WebCoreResourceLoaderImp.h:
  • bridge/mac/WebCoreResourceLoaderImp.mm: (-[WebCoreResourceLoaderImp redirectedToURL:]): (-[WebCoreResourceLoaderImp addData:]): (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
  • bridge/win/FrameWin.cpp:
  • dom/XMLTokenizer.cpp: (WebCore::openFunc):
  • loader/Cache.cpp:
  • loader/LoaderFunctions.h:
  • loader/loader.cpp: (WebCore::Loader::servePendingRequests): (WebCore::Loader::receivedAllData): (WebCore::Loader::receivedResponse): (WebCore::Loader::receivedData): (WebCore::Loader::cancelRequests): (WebCore::Loader::jobForRequest):
  • loader/loader.h:
  • loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest):
  • platform/ResourceLoader.cpp: Added. (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::isErrorPage): (WebCore::ResourceLoader::error): (WebCore::ResourceLoader::setError): (WebCore::ResourceLoader::queryMetaData): (WebCore::ResourceLoader::addMetaData): (WebCore::ResourceLoader::kill): (WebCore::ResourceLoader::url): (WebCore::ResourceLoader::postData): (WebCore::ResourceLoader::method): (WebCore::ResourceLoader::client):
  • platform/ResourceLoader.h: Added. (WebCore::ResourceLoader::getInternal):
  • platform/ResourceLoaderClient.h: Added. (WebCore::ResourceLoaderClient::~ResourceLoaderClient): (WebCore::ResourceLoaderClient::receivedRedirect): (WebCore::ResourceLoaderClient::receivedResponse): (WebCore::ResourceLoaderClient::receivedData): (WebCore::ResourceLoaderClient::receivedAllData):
  • platform/ResourceLoaderInternal.h: Added. (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
  • platform/TransferJob.cpp: Removed.
  • platform/TransferJob.h: Removed.
  • platform/TransferJobClient.h: Removed.
  • platform/TransferJobInternal.h: Removed.
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::openURL): (WebCore::FrameGdk::urlSelected): (WebCore::FrameGdk::receivedData): (WebCore::FrameGdk::receivedAllData):
  • platform/gdk/FrameGdk.h:
  • platform/gdk/ResourceLoaderCurl.cpp: Added. (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::cancel):
  • platform/gdk/ResourceLoaderManager.cpp: Added. (WebCore::ResourceLoaderManager::ResourceLoaderManager): (WebCore::ResourceLoaderManager::get): (WebCore::ResourceLoaderManager::useSimpleTransfer): (WebCore::writeCallback): (WebCore::ResourceLoaderManager::downloadTimerCallback): (WebCore::ResourceLoaderManager::remove): (WebCore::ResourceLoaderManager::add): (WebCore::ResourceLoaderManager::cancel):
  • platform/gdk/ResourceLoaderManager.h: Added.
  • platform/gdk/TemporaryLinkStubs.cpp: (WebCore::ServeSynchronousRequest): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::retrieveCharset):
  • platform/gdk/TransferJobCurl.cpp: Removed.
  • platform/gdk/TransferJobManager.cpp: Removed.
  • platform/gdk/TransferJobManager.h: Removed.
  • platform/mac/ResourceLoaderMac.mm: Added. (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::retrieveCharset): (WebCore::ResourceLoader::setLoader): (WebCore::ResourceLoader::receivedResponse): (WebCore::ResourceLoader::cancel):
  • platform/mac/TransferJobMac.mm: Removed.
  • platform/win/ResourceLoaderWin.cpp: Added. (WebCore::addToOutstandingJobs): (WebCore::lookupResourceLoader): (WebCore::ResourceLoaderWndProc): (WebCore::initializeOffScreenResourceLoaderWindow): (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::fileLoadTimer): (WebCore::ResourceLoader::cancel):
  • platform/win/ResourceLoaderWin.h: Added.
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::ServeSynchronousRequest): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::retrieveCharset):
  • platform/win/TransferJobWin.cpp: Removed.
  • platform/win/TransferJobWin.h: Removed.
  • xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): (WebCore::XMLHttpRequest::receivedAllData): (WebCore::XMLHttpRequest::receivedRedirect): (WebCore::XMLHttpRequest::receivedData):
  • xml/xmlhttprequest.h:

WebKit:

Reviewed by Tim Hatcher.


  • renamed TransferJob to ResourceLoader in WebCore
  • COM/WebFrame.cpp: (WebFrame::loadDataSource): (WebFrame::receivedRedirect): (WebFrame::receivedResponse): (WebFrame::receivedData): (WebFrame::receivedAllData): (WebFrame::setStatusText):
  • COM/WebFrame.h:
9:54 PM Changeset in webkit [15729] by darin
  • 4 edits in trunk/WebKit

Reviewed by Maciej.

  • omit the margin and padding boxes for display types where they are ignored
  • use CSS instead of properties for table spacing and padding as suggested by Tim H.
  • WebInspector/webInspector/inspector.css: Added rules for spacing and padding. Added rules that hide the margin and padding boxes (borders and all but the center cell) when the hide attribute is present.
  • WebInspector/webInspector/inspector.html: Added classes for the rules above. Removed cellpadding and cellspacing attributes.
  • WebInspector/webInspector/inspector.js: Added code to hide/show the margin and padding boxes based on the display type.
9:14 PM Changeset in webkit [15728] by darin
  • 3 edits in trunk/WebCore

Reviewed by Hyatt.

  • removed obsolete cell margin hack
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcVerticalMargins): Set top and bottom margins to 0 for table cells instead of -16384. No effect on layout (including layout tests).
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added a few comments about differences between this class and the what the CSS specification says about computed style.
9:00 PM Changeset in webkit [15727] by thatcher
  • 3 edits
    8 adds in trunk

LayoutTests:

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9738
Bug 9738: Unqualified :hover selector ignored in strict parsing mode

  • fast/selectors/unqualified-hover-quirks-expected.checksum: Added.
  • fast/selectors/unqualified-hover-quirks-expected.png: Added.
  • fast/selectors/unqualified-hover-quirks-expected.txt: Added.
  • fast/selectors/unqualified-hover-quirks.html: Added.
  • fast/selectors/unqualified-hover-strict-expected.checksum: Added.
  • fast/selectors/unqualified-hover-strict-expected.png: Added.
  • fast/selectors/unqualified-hover-strict-expected.txt: Added.
  • fast/selectors/unqualified-hover-strict.html: Added.

WebCore:

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=9738
Bug 9738: Unqualified :hover selector ignored in strict parsing mode

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkSelector): Restrict the :hover and :active exclusion based on onlyHoverActive to quirks mode.
8:54 PM Changeset in webkit [15726] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Darin.

Fixes <​http://bugzilla.opendarwin.org/show_bug.cgi?id=10159>
"REGRESSION: delegate returning no menu elements crashes webkit"

No automated test, because there's no way to programmatically open a context menu,
no manual test because there's no way to customize the context menu delegate.

  • WebView/WebView.m: (-[WebView _menuForElement:defaultItems:]): Make sure the context menu returned some menu items before accessing the first one.
8:51 PM Changeset in webkit [15725] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10178
Bug 10178: [Drosera] Selecting a frame in the stack list should take you to that location in the source

  • Drosera/debugger.js: Keep a stack that contains the source file and line number references for outer frames. Use this stack to determine which file and line to highlight when a stack frame is selected.
8:48 PM Changeset in webkit [15724] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10175
Bug 10175: [Drosera] Anonymous functions show up as "(global scope)" in stack list

  • Drosera/DebuggerDocument.m: (-[WebScriptObject currentFunctionStack]): If the frame has a caller it isn't the global scope.
7:27 PM Changeset in webkit [15723] by hyatt
  • 1 add in trunk/WebCore/platform/ScrollBar.cpp

Add ScrollBar.cpp to fix the build.

7:25 PM Changeset in webkit [15722] by hyatt
  • 7 edits in trunk/WebCore

Fix for bug 10179, digg.com scrolls slowly. Improve fixed positioning
and fixed backgrounds so that a count of them is kept on the FrameView.
This allows us to switch slow scrolling on and off as these objects come
and go.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): (WebCore::CSSStyleSelector::applyProperty):
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::layout): (WebCore::FrameView::useSlowRepaints): (WebCore::FrameView::setUseSlowRepaints): (WebCore::FrameView::addSlowRepaintObject): (WebCore::FrameView::removeSlowRepaintObject):
  • page/FrameView.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):
  • rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
6:50 PM Changeset in webkit [15721] by hyatt
  • 11 edits
    2 adds
    1 delete in trunk/WebCore

Begin disentangling of scrollbar logic in preparation for engine-implemented
scrollbars. Split ScrollBar into two classes, an abstract base (still named
ScrollBar) and a new PlatformScrollBar subclass. This subclass is used only
by platforms that want to continue to use a platform scrollbar (rather than
the engine one).

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLCanvasElement.h:
  • page/Frame.cpp:
  • platform/PlatformScrollBar.h: Added. (WebCore::PlatformScrollBar::isWidget):
  • platform/ScrollBar.h: (WebCore::ScrollBarClient::~ScrollBarClient): (WebCore::ScrollBar::~ScrollBar): (WebCore::ScrollBar::orientation): (WebCore::ScrollBar::value): (WebCore::ScrollBar::client):
  • platform/mac/PlatformScrollBarMac.mm: Added. (-[WebCoreScrollBar initWithPlatformScrollBar:]): (-[WebCoreScrollBar detachPlatformScrollBar]): (-[WebCoreScrollBar scroll:]): (-[WebCoreScrollBar widget]): (-[WebCoreScrollBar mouseDown:]): (WebCore::PlatformScrollBar::PlatformScrollBar): (WebCore::PlatformScrollBar::~PlatformScrollBar): (WebCore::PlatformScrollBar::setScrollBarValue): (WebCore::PlatformScrollBar::setKnobProportion): (WebCore::PlatformScrollBar::scrollbarHit): (WebCore::PlatformScrollBar::width): (WebCore::PlatformScrollBar::height): (WebCore::PlatformScrollBar::setRect): (WebCore::PlatformScrollBar::setEnabled): (WebCore::PlatformScrollBar::paint):
  • platform/mac/ScrollBarMac.mm: Removed.
  • platform/mac/WebCoreTextArea.mm:
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInScrollbar):
  • rendering/RenderFormElement.cpp:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::horizontalScrollbarWidget): (WebCore::RenderLayer::verticalScrollbarWidget): (WebCore::RenderLayer::valueChanged): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::positionScrollbars):
  • rendering/RenderLayer.h:
  • rendering/RenderWidget.h:
5:05 PM Changeset in webkit [15720] by adele
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by John and Anders.

  • Test for <rdar://problem/4380576> onChange does not get called when field changed by return key
  • fast/forms/onchange-enter-submit-expected.txt: Added.
  • fast/forms/onchange-enter-submit.html: Added.

WebCore:

Reviewed by John and Anders.

  • Fix for <rdar://problem/4380576> onChange does not get called when field changed by return key

Test: fast/forms/onchange-enter-submit.html

Blur (which will fire onChange appropriately) before submitting a form when pressing Enter.
This matches the sequence of events fired in WinIE.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::defaultEventHandler):
4:55 PM Changeset in webkit [15719] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/4658194> REGRESSION: "Search in Google"
and "Search in Spotlight" fail to work on text selected in a frame

Use selectedFrame to get the frame with the text selection.

  • WebView/WebView.m: (-[WebView _searchWithGoogleFromMenu:]): (-[WebView _searchWithSpotlightFromMenu:]):
3:27 PM Changeset in webkit [15718] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Kevin.

Moved string debug function outside of the WebCore namespace so that it's
easier to call in the debugger. I will never doubt Darin again (x100).

  • platform/String.cpp: (string):
2:06 PM Changeset in webkit [15717] by hyatt
  • 1 edit in trunk/WebCore/rendering/RenderLayer.cpp

Get rid of the -50000 nonsense on scrollbars when they're first added to overflow blocks.

1:59 PM Changeset in webkit [15716] by hyatt
  • 2 edits in trunk/WebCore

Partial fix for 5453. Improve overflow so that when it changes
dynamically from scroll/auto to hidden that we properly hide the
scrollbars. Also refine the dirty dashboard region updating so that
it only happens if the scrollbars genuinely come and go.

Also eliminate the extra repaint of the entire block. This should not be
necessary, since the scrollbars repaint themselves already and children
will repaint already if they move.

Reviewed by darin

Adding test case from bug into fast/overflow/dynamic-hidden.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
1:58 PM Changeset in webkit [15715] by hyatt
  • 4 adds in trunk/LayoutTests/fast/overflow

Add layout test for bug 5453.

12:49 PM Changeset in webkit [15714] by justing
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by justin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9507>
Empty style spans created in applyInlineStyle
<rdar://problem/4515463>
REGRESSION: Blot and Mail both do a very poor job of pasting the main www.apple.com page

  • editing/pasteboard/paste-4039777-fix-expected.txt:
  • editing/pasteboard/testcase-9507-expected.checksum: Added.
  • editing/pasteboard/testcase-9507-expected.png: Added.
  • editing/pasteboard/testcase-9507-expected.txt: Added.
  • editing/pasteboard/testcase-9507.html: Added.
  • editing/unsupported-content/table-delete-001-expected.txt:
  • editing/selection/selectNode-expected.png:
  • editing/selection/selectNode-expected.checksum:
  • editing/selection/selectNode-expected.txt:

WebCore:

Reviewed by justin


<​http://bugzilla.opendarwin.org/show_bug.cgi?id=9507>
Empty style spans created in applyInlineStyle


Improves paste fidelity because some of these empty font/style spans had a non-zero
size and were messing up the layout of pasted content:
<rdar://problem/4515463>
REGRESSION: Blot and Mail both do a very poor job of pasting the main www.apple.com page

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyle): Use the adjusted start node instead of start.node(). Don't do any application if the endpoints are swapped. Adjust endNode if the start node is a descendant of it, so that the pre-order traversal will terminate properly.
12:14 PM Changeset in webkit [15713] by darin
  • 4 edits in trunk/WebKit

Reviewed by Tim Hatcher.

  • WebInspector/webInspector/inspector.css: Add styles for the new metrics pane.
  • WebInspector/webInspector/inspector.html: Add the new metrics pane, starting with the table to show the box model.
  • WebInspector/webInspector/inspector.js: Add the new metrics pane. Add back some "title" attributes so we have more tooltips. Removed the optional parameter to getComputedStyle.
11:44 AM Changeset in webkit [15712] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • platform/String.cpp: (WebCore::string): Added a debugging function to create a String from a const char*.
11:21 AM Changeset in webkit [15711] by thatcher
  • 1 edit in trunk/WebKit/ChangeLog

Update ChangeLog with bug link.

9:13 AM Changeset in webkit [15710] by andersca
  • 2 edits in trunk/WebKit

2006-07-31 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John.

  • Plugins/WebPluginDatabase.m: (-[WebPluginDatabase refresh]): Create a mutable set instead of a mutable array.
8:43 AM Changeset in webkit [15709] by andersca
  • 2 edits in trunk/WebCore

2006-07-31 Anders Carlsson <​acarlsson@apple.com>

  • css/CSSPrimitiveValue.cpp: Fix windows build.
1:44 AM Changeset in webkit [15708] by ggaren
  • 2 edits
    1 copy
    1 move
    1 delete in trunk/WebCore

Reinstating my last change. Everything builds now.

1:41 AM Changeset in webkit [15707] by darin
  • 4 edits in trunk

LayoutTests:

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10167
Bug 10167: REGRESSION(r15688): ASSERTION FAILED: _private->mouseDownEvent != nil in layout tests

  • fast/events/objc-event-api-expected.txt: Update test results.

WebKitTools:

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10167
Bug 10167: REGRESSION(r15688): ASSERTION FAILED: _private->mouseDownEvent != nil in layout tests

  • DumpRenderTree/EventSendingController.m: Don't set the mouse down flag in keyDown handler.
1:31 AM Changeset in webkit [15706] by ggaren
  • 2 edits
    2 copies
    2 deletes in trunk/WebCore

Backing out my last change because it causes a build failure in some
configurations. This seems to be the cleanest way to get svn to cooperate.

12:26 AM Changeset in webkit [15705] by darin
  • 3 edits
    2 deletes in trunk/LayoutTests
  • editing/pasteboard/paste-table-002-expected.txt: Corrected one result affected by my recent change to getComputedStyle.
  • editing/pasteboard/paste-table-002.html: Converted to a text test, since it dumps the serialized form of hte result.
  • editing/pasteboard/paste-table-002-expected.checksum: Removed.
  • editing/pasteboard/paste-table-002-expected.png: Removed.
12:17 AM Changeset in webkit [15704] by ggaren
  • 2 edits
    1 copy
    1 move
    1 delete in trunk/WebCore

Reviewed by Maciej.

Moved files around to make WebCore's structure clearer
and easier to explain.

DerivedSources/JS* -> bindings/js/DerivedSources/ (so JS* files
show up when you search inside bindings/js/, but are marked, at
the same time, as files that you should not edit manually)

WebCore+SVG/DOMList.h -> ksvg2/svg/ (only files inside ksvg2/svg/
use DOMList.h)

icon -> loader/icon

I tested that everything still builds.

12:07 AM Changeset in webkit [15703] by darin
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

  • WebInspector/webInspector/inspector.js: Fix bug where a null property value leads to an empty style pane.

Jul 30, 2006:

11:52 PM Changeset in webkit [15702] by darin
  • 10 edits
    2 adds in trunk

LayoutTests:

  • test that displays all computed style -- demonstrates bug fixes I just made to the computed style class and also acts as a regression test for the existence of all of them and the basic format for a default object
  • fast/css/computed-style-expected.txt: Added.
  • fast/css/computed-style.html: Added.

WebCore:

Reviewed by Tim Hatcher.

  • some improvements for the benefit of the style pane of the inspector
  • css/CSSComputedStyleDeclaration.cpp: Removed background-position and border-spacing from the list of properties that show up in computed style, because of background-position-x, background-position-y, -webkit-border-horizontal-spacing and -webkit-border-vertical-spacing. (WebCore::valueForLength): Added handling for undefinedLength, intrinsic, and min-intrinsic. (WebCore::primitiveValueFromLength): Removed code that would add a space to the string for no good reason. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added a special case for a line clamp of -1, which should come back as "none" rather than an actual "-1". (WebCore::CSSComputedStyleDeclaration::length): Return 0 if the declaration has no corresponding node or no renderer. (WebCore::CSSComputedStyleDeclaration::item): Check against length() so that the two stay consistent rather than using a constant.
  • css/CSSPrimitiveValue.cpp: (WebCore::isCSSTokenizerIdentifier): Added. (WebCore::isCSSTokenizerURL): Added. (WebCore::quoteString): Added. (WebCore::quoteStringIfNeeded): Changed to quote strings in many more cases -- any cases where they would not parse in the CSS parser otherwise. The main case this affects is font names with spaces in them. (WebCore::quoteURLIfNeeded): Added. (WebCore::CSSPrimitiveValue::cssText): Use quoteURLIfNeeded in the case where we're making the text form of a URI.
  • css/tokenizer.flex: Whitespace tweaks to line things up better.

WebKit:

Reviewed by Tim Hatcher.

  • some improvements for the inspector
  • WebInspector/WebInspector.m: (+sharedWebInspector:): Fixed bug that could cause the inspector to be garbage collected if used in an application with GC enabled. (-dealloc): Removed a call to a non-existent close method. (-window): Added a custom WebPreferences object and called setPrivateBrowsingEnabled:YES so the inspector won't appear in the history menu. Also call setProhibitsMainFrameScrolling:YES to try to get rid of trouble where the inspector scrolls when dragging.
  • WebInspector/webInspector/inspector.css: Added style for the new color swatch, and JavaScript properties. More of the style should be shared between the panes, but this should be OK for now.
  • WebInspector/webInspector/inspector.html: Added a first cut at a JavaScript properties pane. Needs work, but better than nothing.
  • WebInspector/webInspector/inspector.js: Lots of improvements:
  • Omit "typical" property values from computed style display, making it much shorter.
  • Use the words "black", "white", and "transparent" when appropriate for color values.
  • Refactored the loaded() function to get rid of repetitive scrollbar setup.
  • Added a new scrollarea for the JavaScript properties pane.
  • Simplified refreshScrollbars() -- we now refresh all scrollbars every time, which does no harm.
  • Removed unused resultsWithXpathQuery().
  • Use [] instead of "new Array()" and {} instead of "new Object()".
  • Removed unused xpathForNode().
  • Changed style pane to display the style for a text node's parent instead of saying it can't display the style for text.
  • Fixed regression I caused a while back by checking the length of a computed style and not trying to display anything if its length is 0. Before this change and the corresponding change in WebCore, we'd see a complete list of all styles with the empty string as the value for each one.
  • Changed the name of the computedStyle flag on the style rules array to isComputedStyle to make it easier to understand it's a boolean.
  • Fixed an error in the code that does !important scanning where it was trying to do a special case for computed style, but was checking the computed style flag on the wrong object.
  • Added populateStyleListItem() function to factor out things in common between the items in the top level list and the expanded tree for shorthand properties.
  • Added code to make a color swatch next to the textual representation for any property that contains a color.
  • Implemented a first cut at a simple JavaScript properties pane.
11:15 PM Changeset in webkit [15701] by thatcher
  • 3 edits in trunk/WebKitTools

Reviewed by Maciej.

Bug 9686: [Drosera] Need the ability to break into Drosera on Javascript exceptions
​http://bugzilla.opendarwin.org/show_bug.cgi?id=9686

  • Drosera/DebuggerDocument.m: (-[WebScriptObject switchToServerNamed:]): Remove as listener before resuming to ensure that the server does not try and notify us of events related to the resumption. (-[WebScriptObject webView:exceptionWasRaised:sourceId:line:forWebFrame:]): Delegate call through to JavaScript.
  • Drosera/debugger.js: Pause debugger when exception is raised.
4:02 PM Changeset in webkit [15700] by ggaren
  • 3 edits in trunk/WebKitSite

Reviewed by Beth.


  • Tweaked the checkout and build instructions to make them simpler and clearer.
  • building/build.html:
  • building/checkout.html:

Jul 29, 2006:

9:31 PM Changeset in webkit [15699] by eseidel
  • 3 edits
    3 deletes in trunk/WebCore

2006-07-30 Eric Seidel <​eric@eseidel.com>

Reviewed by gramps!

Remove some unused SVG code.

  • ksvg2/ecma/Ecma.cpp: Removed.
  • ksvg2/ecma/Ecma.h: Removed.
  • ksvg2/ecma/GlobalObject.cpp: remove a couple dead functions.
  • ksvg2/ecma/GlobalObject.h: add a comment about this dead code.
  • ksvg2/ecma/SVGLookup.h: Removed.
5:04 PM Changeset in webkit [15698] by darin
  • 38 edits in trunk

JavaScriptCore:

  • Removed tabs from these source files that still had them. We don't use them; that way source files look fine in editors that have tabs set to 8 spaces or to 4 spaces.
  • Removed allow-tabs Subversion property from the files too.
  • bindings/NP_jsobject.cpp:
  • bindings/c/c_utility.cpp:
  • bindings/jni/jni_runtime.cpp:
  • bindings/jni/jni_utility.cpp:
  • bindings/objc/objc_utility.mm:
  • bindings/runtime.cpp:
  • bindings/runtime_method.cpp:
  • bindings/testbindings.cpp:
  • bindings/testbindings.mm:
  • kjs/date_object.cpp:
  • kjs/function.cpp:
  • kjs/list.cpp:
  • kjs/nodes.cpp:
  • kjs/nodes.h:
  • kjs/string_object.cpp:
  • kjs/ustring.cpp:

WebCore:

  • Removed tabs from these source files that still had them. We don't use them; that way source files look fine in editors that have tabs set to 8 spaces or to 4 spaces.
  • Removed allow-tabs Subversion property from the files too.
  • bindings/objc/WebScriptObject.h:
  • bindings/objc/WebScriptObject.mm:
  • platform/FontData.cpp:

WebKit:

  • Removed tabs from these source files that still had them. We don't use them; that way source files look fine in editors that have tabs set to 8 spaces or to 4 spaces.
  • Removed allow-tabs Subversion property from the files too.
  • DefaultDelegates/WebDefaultPolicyDelegate.m:
  • History/WebHistory.m:
  • Misc/WebDownload.m:
  • Misc/WebIconDatabase.m:
  • Misc/WebKitErrors.m:
  • Misc/WebKitLogging.m:
  • Misc/WebNSDataExtras.m:
  • Misc/WebNSFileManagerExtras.m:
  • Panels/WebPanelAuthenticationHandler.m:
  • Plugins/WebBaseNetscapePluginView.m:
  • Plugins/npfunctions.h:
  • WebCoreSupport/WebSubresourceLoader.m:
  • WebView/WebMainResourceLoader.m:
  • WebView/WebView.h:
  • WebView/WebView.m:
4:41 PM Changeset in webkit [15697] by darin
  • 2 edits in trunk/JavaScriptCore
  • tests/mozilla/expected.html: Update test results now that regress-185165.js is succeeding. I suspect Anders fix for bug 4620655 is the reason.
4:15 PM Changeset in webkit [15696] by weinig
  • 225 edits in trunk

JavaScriptCore:

Reviewed by Darin.

Changes include:

  • Removing trailing semicolon from namespace braces.
  • Removing trailing comma from last enum declaration.
  • Updating to match style guidelines.
  • Adding missing newline to the end of the file.
  • Turning on gcc warning for missing newline at the end of a source file (GCC_WARN_ABOUT_MISSING_NEWLINE in Xcode, -Wnewline in gcc).
  • Alphabetical sorting of Xcode source list files.
  • Replace use of non-portable variable-size array with Vector.
  • Use C-style comments instead of C++ comments in files that might be included by either C or C++ files.
  • API/JSCallbackConstructor.cpp: (KJS::JSCallbackConstructor::construct):
  • API/JSCallbackFunction.cpp: (KJS::JSCallbackFunction::callAsFunction):
  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::construct): (KJS::JSCallbackObject::callAsFunction):
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCorePrefix.h:
  • bindings/jni/jni_class.cpp: (JavaClass::fieldNamed):
  • bindings/jni/jni_class.h:
  • bindings/jni/jni_instance.cpp: (JavaInstance::JavaInstance): (JavaInstance::valueOf):
  • bindings/jni/jni_objc.mm: (KJS::Bindings::dispatchJNICall):
  • bindings/jni/jni_runtime.cpp: (JavaParameter::JavaParameter): (JavaArray::JavaArray):
  • bindings/jni/jni_runtime.h:
  • bindings/jni/jni_utility.h:
  • bindings/objc/objc_instance.h:
  • bindings/runtime_array.h:
  • kjs/collector.h:
  • kjs/config.h:
  • kjs/ustring.cpp:
  • wtf/Platform.h:

JavaScriptGlue:

Reviewed by Darin.

Changes include:

  • Turning on gcc warning for missing newline at the end of a source file (GCC_WARN_ABOUT_MISSING_NEWLINE in Xcode, -Wnewline in gcc).
  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Reviewed by Darin.

Changes include:

  • Removing trailing semicolon from namespace braces.
  • Removing trailing comma from last enum declaration.
  • Updating to match style guidelines.
  • Adding missing newline to the end of the file.
  • Turning on gcc warning for missing newline at the end of a source file (GCC_WARN_ABOUT_MISSING_NEWLINE in Xcode, -Wnewline in gcc).
  • Alphabetical sorting of Xcode source list files.
  • Use abs() function from <math.h> instead of ABS() macro.
  • Use C-style comments instead of C++ comments in files that might be included by either C or C++ files.
  • Use -numeric_limits<double>::infinity() instead of -HUGE_VAL.
  • WebCore+SVG/DOMList.h:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCorePrefix.h:
  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:
  • bindings/js/JSXSLTProcessor.h:
  • bindings/js/kjs_domnode.h: (KJS::DOMNode::):
  • bindings/objc/DOMCSS.h: (-[DOMCSSValue enum]):
  • bindings/objc/DOMCore.h: (-[DOMImplementation createDocument:::]):
  • bindings/objc/DOMEvents.h: (-[DOMOverflowEvent enum]):
  • bindings/objc/DOMRange.h:
  • bindings/objc/DOMTraversal.h:
  • bindings/objc/DOMXPath.h: (-[DOMXPathNSResolver lookupNamespaceURI:]):
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreKeyboardAccess.h:
  • css/makeprop:
  • css/makevalues:
  • dom/ChildNodeList.h:
  • dom/DocPtr.h:
  • dom/Document.h: (WebCore::Document::):
  • dom/DocumentMarker.h: (WebCore::DocumentMarker::): (WebCore::DocumentMarker::operator==): (WebCore::DocumentMarker::operator!=):
  • dom/EventTargetNode.h:
  • dom/KeyboardEvent.h: (WebCore::KeyboardEvent::):
  • dom/NameNodeList.h: (WebCore::NameNodeList::rootNodeChildrenChanged):
  • dom/QualifiedName.cpp:
  • editing/TypingCommand.h: (WebCore::TypingCommand::):
  • editing/UnlinkCommand.h: (WebCore::UnlinkCommand::editingAction):
  • html/FormDataList.h: (WebCore::FormDataListItem::FormDataListItem): (WebCore::FormDataList::appendData):
  • html/HTMLBlockquoteElement.h:
  • html/HTMLDivElement.h:
  • html/HTMLFormElement.h:
  • html/HTMLHRElement.h:
  • html/HTMLHeadingElement.h:
  • html/HTMLMarqueeElement.h:
  • html/HTMLParagraphElement.h:
  • html/HTMLPlugInElement.h:
  • html/HTMLPreElement.h:
  • html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::State::):
  • icon/IconDatabase.cpp:
  • icon/SQLStatement.cpp:
  • kcanvas/KCanvasFilters.h: (WebCore::): (WebCore::KCanvasPoint3F::KCanvasPoint3F): (WebCore::KCanvasFilter::KCanvasFilter): (WebCore::KCanvasFilter::~KCanvasFilter): (WebCore::KCanvasFilterEffect::~KCanvasFilterEffect): (WebCore::KCComponentTransferFunction::KCComponentTransferFunction): (WebCore::KCanvasFEConvolveMatrix::KCanvasFEConvolveMatrix): (WebCore::KCLightSource::KCLightSource): (WebCore::KCDistantLightSource::KCDistantLightSource): (WebCore::KCPointLightSource::KCPointLightSource): (WebCore::KCSpotLightSource::KCSpotLightSource): (WebCore::KCanvasFEDiffuseLighting::KCanvasFEDiffuseLighting): (WebCore::KCanvasFEDisplacementMap::KCanvasFEDisplacementMap): (WebCore::KCanvasFEImage::KCanvasFEImage): (WebCore::KCanvasFESpecularLighting::KCanvasFESpecularLighting):
  • kcanvas/RenderSVGImage.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h:
  • ksvg2/css/SVGRenderStyle.h: (WebCore::SVGRenderStyle::InheritedFlags::): (WebCore::SVGRenderStyle::NonInheritedFlags::):
  • ksvg2/css/SVGRenderStyleDefs.h: (WebCore::):
  • ksvg2/events/SVGZoomEvent.h:
  • ksvg2/ksvg.h: (WebCore::):
  • ksvg2/misc/KCanvasRenderingStyle.h:
  • ksvg2/misc/SVGImageLoader.h:
  • ksvg2/scripts/make_names.pl:
  • ksvg2/svg/SVGAElement.h:
  • ksvg2/svg/SVGAngle.h:
  • ksvg2/svg/SVGAnimateColorElement.h:
  • ksvg2/svg/SVGAnimateElement.h:
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGAnimatedAngle.h:
  • ksvg2/svg/SVGAnimatedBoolean.h:
  • ksvg2/svg/SVGAnimatedColor.h:
  • ksvg2/svg/SVGAnimatedEnumeration.h:
  • ksvg2/svg/SVGAnimatedInteger.h:
  • ksvg2/svg/SVGAnimatedLength.h:
  • ksvg2/svg/SVGAnimatedLengthList.h:
  • ksvg2/svg/SVGAnimatedNumber.h:
  • ksvg2/svg/SVGAnimatedNumberList.h:
  • ksvg2/svg/SVGAnimatedPathData.h:
  • ksvg2/svg/SVGAnimatedPoints.h:
  • ksvg2/svg/SVGAnimatedPreserveAspectRatio.h:
  • ksvg2/svg/SVGAnimatedRect.h:
  • ksvg2/svg/SVGAnimatedString.h:
  • ksvg2/svg/SVGAnimatedTemplate.h:
  • ksvg2/svg/SVGAnimatedTransformList.h:
  • ksvg2/svg/SVGAnimationElement.cpp: (SVGAnimationElement::calculateCurrentValueItem): (SVGAnimationElement::calculateRelativeTimePercentage):
  • ksvg2/svg/SVGAnimationElement.h: (WebCore::):
  • ksvg2/svg/SVGCircleElement.h:
  • ksvg2/svg/SVGClipPathElement.h:
  • ksvg2/svg/SVGColor.h:
  • ksvg2/svg/SVGComponentTransferFunctionElement.h:
  • ksvg2/svg/SVGCursorElement.h:
  • ksvg2/svg/SVGDOMImplementation.h:
  • ksvg2/svg/SVGDefsElement.h:
  • ksvg2/svg/SVGDescElement.h:
  • ksvg2/svg/SVGDocument.h:
  • ksvg2/svg/SVGElement.h: (WebCore::SVGElement::rendererIsNeeded): (WebCore::svg_dynamic_cast):
  • ksvg2/svg/SVGElementInstance.h:
  • ksvg2/svg/SVGElementInstanceList.h:
  • ksvg2/svg/SVGEllipseElement.h:
  • ksvg2/svg/SVGExternalResourcesRequired.h:
  • ksvg2/svg/SVGFEBlendElement.h:
  • ksvg2/svg/SVGFEColorMatrixElement.h:
  • ksvg2/svg/SVGFEComponentTransferElement.h:
  • ksvg2/svg/SVGFECompositeElement.h:
  • ksvg2/svg/SVGFEDiffuseLightingElement.h:
  • ksvg2/svg/SVGFEDisplacementMapElement.h:
  • ksvg2/svg/SVGFEDistantLightElement.h:
  • ksvg2/svg/SVGFEFloodElement.h:
  • ksvg2/svg/SVGFEFuncAElement.h:
  • ksvg2/svg/SVGFEFuncBElement.h:
  • ksvg2/svg/SVGFEFuncGElement.h:
  • ksvg2/svg/SVGFEFuncRElement.h:
  • ksvg2/svg/SVGFEGaussianBlurElement.h:
  • ksvg2/svg/SVGFEImageElement.h:
  • ksvg2/svg/SVGFELightElement.h:
  • ksvg2/svg/SVGFEMergeElement.h:
  • ksvg2/svg/SVGFEMergeNodeElement.h:
  • ksvg2/svg/SVGFEOffsetElement.h:
  • ksvg2/svg/SVGFEPointLightElement.h:
  • ksvg2/svg/SVGFESpecularLightingElement.h:
  • ksvg2/svg/SVGFESpotLightElement.h:
  • ksvg2/svg/SVGFETileElement.h:
  • ksvg2/svg/SVGFETurbulenceElement.h:
  • ksvg2/svg/SVGFilterElement.h:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
  • ksvg2/svg/SVGFitToViewBox.h:
  • ksvg2/svg/SVGForeignObjectElement.cpp:
  • ksvg2/svg/SVGForeignObjectElement.h:
  • ksvg2/svg/SVGGElement.h:
  • ksvg2/svg/SVGGradientElement.h:
  • ksvg2/svg/SVGHelper.h: (WebCore::):
  • ksvg2/svg/SVGImageElement.h:
  • ksvg2/svg/SVGLangSpace.h:
  • ksvg2/svg/SVGLength.h:
  • ksvg2/svg/SVGLengthList.h:
  • ksvg2/svg/SVGLineElement.h:
  • ksvg2/svg/SVGLinearGradientElement.h:
  • ksvg2/svg/SVGList.h:
  • ksvg2/svg/SVGLocatable.h:
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.h:
  • ksvg2/svg/SVGMatrix.h:
  • ksvg2/svg/SVGNumber.h:
  • ksvg2/svg/SVGNumberList.h:
  • ksvg2/svg/SVGPaint.h:
  • ksvg2/svg/SVGPathElement.h:
  • ksvg2/svg/SVGPathSeg.h:
  • ksvg2/svg/SVGPathSegArc.h:
  • ksvg2/svg/SVGPathSegClosePath.h:
  • ksvg2/svg/SVGPathSegCurvetoCubic.h:
  • ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
  • ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
  • ksvg2/svg/SVGPathSegLineto.h:
  • ksvg2/svg/SVGPathSegLinetoHorizontal.h:
  • ksvg2/svg/SVGPathSegLinetoVertical.h:
  • ksvg2/svg/SVGPathSegList.h:
  • ksvg2/svg/SVGPathSegMoveto.h:
  • ksvg2/svg/SVGPatternElement.h:
  • ksvg2/svg/SVGPoint.h:
  • ksvg2/svg/SVGPointList.h:
  • ksvg2/svg/SVGPolyElement.h:
  • ksvg2/svg/SVGPolygonElement.h:
  • ksvg2/svg/SVGPolylineElement.h:
  • ksvg2/svg/SVGPreserveAspectRatio.h:
  • ksvg2/svg/SVGRadialGradientElement.h:
  • ksvg2/svg/SVGRect.h:
  • ksvg2/svg/SVGRectElement.h:
  • ksvg2/svg/SVGSVGElement.h:
  • ksvg2/svg/SVGScriptElement.h:
  • ksvg2/svg/SVGSetElement.h:
  • ksvg2/svg/SVGStopElement.h:
  • ksvg2/svg/SVGStringList.h:
  • ksvg2/svg/SVGStylable.h:
  • ksvg2/svg/SVGStyleElement.h:
  • ksvg2/svg/SVGStyledElement.h: (WebCore::SVGStyledElement::rendererIsNeeded): (WebCore::SVGStyledElement::canvasResource):
  • ksvg2/svg/SVGStyledLocatableElement.h:
  • ksvg2/svg/SVGStyledTransformableElement.h:
  • ksvg2/svg/SVGSwitchElement.h:
  • ksvg2/svg/SVGSymbolElement.h:
  • ksvg2/svg/SVGTRefElement.h:
  • ksvg2/svg/SVGTSpanElement.h:
  • ksvg2/svg/SVGTests.h:
  • ksvg2/svg/SVGTextContentElement.h:
  • ksvg2/svg/SVGTextElement.h:
  • ksvg2/svg/SVGTextPositioningElement.h:
  • ksvg2/svg/SVGTitleElement.h:
  • ksvg2/svg/SVGTransform.h:
  • ksvg2/svg/SVGTransformList.h:
  • ksvg2/svg/SVGTransformable.h:
  • ksvg2/svg/SVGURIReference.h:
  • ksvg2/svg/SVGUseElement.h:
  • ksvg2/svg/SVGViewElement.h:
  • ksvg2/svg/SVGZoomAndPan.h:
  • ksvg2/svg/svgpathparser.h:
  • page/Frame.h: (WebCore::):
  • platform/AffineTransform.h:
  • platform/FontCache.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
  • platform/FontData.cpp: (WebCore::FontData::FontData):
  • platform/FontData.h:
  • platform/TextBox.h: (WebCore::TextBox::):
  • platform/Timer.cpp: (WebCore::TimerBase::heapPop):
  • platform/mac/FontCacheMac.mm:
  • platform/mac/GlyphMapMac.cpp:
  • platform/mac/WebFontCache.mm: (betterChoice):
  • rendering/DeprecatedRenderSelect.cpp: (WebCore::DeprecatedRenderSelect::setWidgetWritingDirection):
  • rendering/EllipsisBox.h:
  • rendering/RenderBR.h: (WebCore::RenderBR::renderName): (WebCore::RenderBR::width):
  • rendering/RenderBlock.h: (WebCore::):
  • rendering/RenderFlexibleBox.h:
  • rendering/RenderFlow.h: (WebCore::RenderFlow::RenderFlow):
  • rendering/RenderFrame.cpp:
  • rendering/bidi.h:
  • rendering/break_lines.cpp:

WebKit:

Reviewed by Darin.

Changes include:

  • Adding missing newline to the end of the file.
  • Turning on gcc warning for missing newline at the end of a source file (GCC_WARN_ABOUT_MISSING_NEWLINE in Xcode, -Wnewline in gcc).
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebResourcePrivate.h:
4:09 PM Changeset in webkit [15695] by darin
  • 32 edits in trunk

Clear stray executable bits.

3:50 PM Changeset in webkit [15694] by darin
  • 2 edits in trunk/WebCore/editing

Clear some stray executable bits.

2:05 PM Changeset in webkit [15693] by rwlbuis
  • 1 edit in trunk/LayoutTests/dom/xhtml/level2/html/HTMLDocument04-expected.txt

Remove the output produced by an alert, so
hopefully buildbot will not complain anymore :)

1:25 PM Changeset in webkit [15692] by rwlbuis
  • 6 edits in trunk

Reviewed by Geoff.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10151
ghostmap XHTML + SVG fails due to javascript undefined exception

Make sure document.URL works when called from a non-HTML document.

8:44 AM Changeset in webkit [15691] by darin
  • 14 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Darin.

  • fixes for Linux build
  • JavaScriptCoreSources.bkl: Added new files to build, kjs/PropertyNameArray.cpp and kjs/testkjs.cpp, and removed old files.

WebCore:

Reviewed and tweaked by Darin.

  • fixes for Linux build (still might not compile, since Darin tweaked but was unable to test).
  • WebCoreSources.bkl: Added some new sources, removed some obsolete ones.
  • Projects/gdk/webcore-gdk.bkl: Added RenderPopupMenuGdk.cpp
  • html/HTMLPlugInElement.h: Removed incorrect syntax with class name before ::.
  • platform/gdk/FrameGdk.h:
  • platform/gdk/FrameGdk.cpp: Updated parameters of constructor. Moved a couple stubs out of this file.
  • platform/gdk/RenderPopupMenuGdk.h: Added.
  • platform/gdk/RenderPopupMenuGdk.cpp: Added. Just a file full of empty stubs.
  • platform/gdk/RenderThemeGdk.h:
  • platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::createPopupMenu): Added.
  • platform/gdk/TemporaryLinkStubs.cpp: Add some new stubs.

WebKitTools:

Reviewed by Darin.

  • fixes for Linux build
  • GdkLauncher/mk: Added call to bakefile_gen before calling make.
  • GdkLauncher/gdklauncher.bkl: Tweak comment.
8:43 AM Changeset in webkit [15690] by darin
  • 3 edits in trunk/LayoutTests
  • changed this test to a plain-text one and added text explaining what it tests
  • fast/forms/input-named-action-overrides-action-attribute.html: Added explanation text, got rid of some incorrect HTML syntax, added a call to dumpAsText(), and used a paragraph element instead of a span element for the result.
  • fast/forms/input-named-action-overrides-action-attribute-expected.txt: Updated.
8:21 AM Changeset in webkit [15689] by darin
  • 2 edits in trunk/WebCore

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10022
Bug 10022: REGRESSION: Crash in WebCore::XMLTokenizer::characters

  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::resumeParsing): If the write() call resulted in new callbacks being added, don't call through to end() just yet.
8:19 AM Changeset in webkit [15688] by darin
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by John Sullivan.

  • manual-tests/subview-click-assertion.html: Added.

WebKit:

Reviewed by John Sullivan.

  • WebView/WebHTMLView.m: (-[WebHTMLView _setMouseDownEvent:]): Moved into the WebHTMLViewFileInternal category and changed to accept nil. (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Copy the hit HTMLView's mouse down event to the top HTMLView. (-[WebHTMLView acceptsFirstMouse:]): Added a call to _setMouseDownEvent:nil before returning. (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): Added a call to _setMouseDownEvent:nil before returning. (-[WebHTMLView mouseUp:]): Added a call to _setMouseDownEvent:nil to clear the event set in mouseDown: (and used during dragging). (-[WebHTMLView _delegateDragSourceActionMask]): Copy the hit HTMLView's mouse down event to the top HTMLView.
8:06 AM Changeset in webkit [15687] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8587 / <rdar://problem/4631844>
REGRESSION: {display:list-item} items outside an ol or ul element don't number correctly

  • fast/lists/ordered-list-with-no-ol-tag-expected.checksum: Added.
  • fast/lists/ordered-list-with-no-ol-tag-expected.png: Added.
  • fast/lists/ordered-list-with-no-ol-tag-expected.txt: Added.
  • fast/lists/ordered-list-with-no-ol-tag.html: Added.

WebCore:

Reviewed by Darin.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=8587 / <rdar://problem/4631844>
REGRESSION: {display:list-item} items outside an ol or ul element don't number correctly

  • rendering/RenderListItem.cpp: (WebCore::enclosingList): If no real list element is found, use parent instead. (WebCore::previousListItem): Check list elements to see if they are list items -- the old code assumed that a list would never be a list item but this is entirely possible with CSS and especially with the new rule that means any DOM element could act as a list.
7:56 AM Changeset in webkit [15686] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

Fix ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10147
REGRESSION: custom attribute values set via javascript are not persistent

Test: fast/dom/Element/setAttribute-case-insensitivity.html

  • dom/Element.cpp: (WebCore::Element::setAttribute): Use the lowercased localName for retrieving the old value, too.
7:53 AM Changeset in webkit [15685] by darin
  • 1 edit
    4 deletes in trunk/LayoutTests
  • rolled out the test for bug 9753, since we rolled out the fix we'll bring back the test when we bring back the fix
  • svg/custom/width-full-percentage-expected.checksum: Removed.
  • svg/custom/width-full-percentage-expected.png: Removed.
  • svg/custom/width-full-percentage-expected.txt: Removed.
  • svg/custom/width-full-percentage.svg: Removed.
Note: See TracTimeline for information about the timeline view.