Timeline



Aug 14, 2006:

11:40 PM Changeset in webkit [15872] by eseidel
  • 69 edits
    7 adds in trunk

2006-08-14 Eric Seidel <​eric@eseidel.com>

Reviewed by mjs.

<mask>, <marker>, <pattern> inside <defs> do not work
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6548

  • ksvg2/svg/SVGDefsElement.cpp: (WebCore::SVGDefsElement::SVGDefsElement): moved to .cpp file (WebCore::SVGDefsElement::isValid): moved to .cpp file (WebCore::SVGDefsElement::rendererIsNeeded): Added. (WebCore::SVGDefsElement::createRenderer): Added.
  • ksvg2/svg/SVGDefsElement.h:
  • ksvg2/svg/SVGGElement.cpp: (WebCore::SVGGElement::SVGGElement): adjusted spacing (WebCore::SVGGElement::parseMappedAttribute): adjusted spacing (WebCore::SVGDummyElement::SVGDummyElement): adjusted spacing
11:37 PM Changeset in webkit [15871] by eseidel
  • 2 edits in trunk/WebKitSite

2006-08-15 Eric Seidel <​eric@eseidel.com>

Reviewed by TimH.

  • projects/svg/status.xml: updated to reflect current SVG status
11:12 PM Changeset in webkit [15870] by eseidel
  • 39 edits
    3 copies in trunk

2006-08-14 Eric Seidel <​eric@eseidel.com>

Reviewed by darin and mjs.


Add better SVGLoad event support.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=6010
There will still need to be additional support added for <link> and <script> elements.
Not all of the error -> loaded -> error transition cases work yet.

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent):
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::dispatchLoadEvent):
  • html/HTMLImageLoader.h: (WebCore::HTMLImageLoader::haveFiredLoadEvent): (WebCore::HTMLImageLoader::setHaveFiredLoadEvent):
  • ksvg2/misc/SVGImageLoader.cpp: (WebCore::SVGImageLoader::SVGImageLoader): (WebCore::SVGImageLoader::dispatchLoadEvent):
  • ksvg2/misc/SVGImageLoader.h:
  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::parseMappedAttribute):
  • ksvg2/svg/SVGAnimatedBoolean.h:
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::SVGElement): (WebCore::SVGElement::parseMappedAttribute): (WebCore::SVGElement::haveLoadedRequiredResources): (WebCore::SVGElement::sendSVGLoadEventIfPossible): (WebCore::SVGElement::closeRenderer):
  • ksvg2/svg/SVGElement.h: (WebCore::SVGElement::rendererIsNeeded): (WebCore::svg_dynamic_cast):
  • ksvg2/svg/SVGExternalResourcesRequired.h:
  • ksvg2/svg/SVGImageElement.cpp: (SVGImageElement::SVGImageElement): (SVGImageElement::haveLoadedRequiredResources):
  • ksvg2/svg/SVGImageElement.h:
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::parseMappedAttribute):
  • ksvg2/svg/SVGScriptElement.cpp: (WebCore::SVGScriptElement::SVGScriptElement): (WebCore::SVGScriptElement::parseMappedAttribute): (WebCore::SVGScriptElement::executeScript):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::callReadyStateChangeListener): use new Event() instead of createEvent
10:38 PM Changeset in webkit [15869] by mjs
  • 6 edits in trunk/WebKit

Reviewed by Beth.


  • remove many (but not all) WebKit dependencies from WebNetscapePlugInStreamLoader (it still depends on WebNetscapePluginStream).
  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader fileDoesNotExistErrorWithResponse:]):
  • Loader/WebNetscapePlugInStreamLoader.h:
  • Loader/WebNetscapePlugInStreamLoader.m: (-[WebNetscapePlugInStreamLoader initWithStream:frameLoader:]): (-[WebNetscapePlugInStreamLoader releaseResources]): (-[WebNetscapePlugInStreamLoader didReceiveResponse:]):
  • Plugins/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
10:18 PM Changeset in webkit [15868] by mjs
  • 1 edit
    1 add in trunk/LayoutTests

Missing expected results for last test.

  • http/tests/plugins/interrupted-get-url-expected.txt: Added.
8:52 PM Changeset in webkit [15867] by mjs
  • 3 edits
    5 adds in trunk

LayoutTests:

Test case not reviewed but the patch was reviewed by Tim Omernick.


  • http/tests/plugins/interrupted-get-url.html: Added.
  • http/tests/plugins/resources/interrupted-get-url-success.html: Added.
  • http/tests/plugins/resources/slow-resource.pl: Added.

WebKit:

Reviewed by Tim Omernick.


  • Loader/WebNetscapePlugInStreamLoader.m: (-[WebNetscapePlugInStreamLoader initWithStream:view:]): Set the frame loader for this stream. (-[WebNetscapePlugInStreamLoader cancelWithError:]): Make sure to destroy the stream as well; otherwise, when we try to clean up later, we won't have the right context.
5:59 PM Changeset in webkit [15866] by andersca
  • 9 edits
    4 adds in trunk/WebCore

2006-08-14 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10393
Autogenerate NodeIterator and TreeWalker.


  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj: Add new files.


  • bindings/js/JSNodeIteratorCustom.cpp: Added. (WebCore::JSNodeIterator::mark):
  • bindings/js/JSTreeWalkerCustom.cpp: Added. (WebCore::JSTreeWalker::mark):


  • bindings/js/kjs_traversal.cpp:
  • bindings/js/kjs_traversal.h: Remove implementations of DOMNodeIterator and DOMTreeWalker.
  • bindings/scripts/CodeGeneratorJS.pm: Add "CustomMarkFunction" attribute for classes where mark() needs to be overridden.


  • bindings/objc/DOM.mm: (-[DOMNodeIterator detach]):
  • dom/NodeIterator.cpp: (WebCore::NodeIterator::detach):
  • dom/NodeIterator.h: Get rid of exception in detach, it isn't used at all and this function can't throw an exception according to the spec.
  • dom/NodeIterator.idl: Added.
  • dom/TreeWalker.idl: Added.
5:03 PM Changeset in webkit [15865] by beidson
  • 4 edits in trunk/WebCore

Reviewed by John

The changes are plentiful, but small, mostly to improve performance
1) Add a bool flag to SiteIcon to stop it from querying the database over and over
2) Added a pageURL->iconURL hashmap to cache database results, as an optimization
3) Fix a bug in setIconURLForPageURL code where the pageURL would still point to an old icon
4) Added isIconURLRetained() to optimize the retain count check
5) Prune old, unused code

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::imageDataForIconID): Removed unused code (WebCore::IconDatabase::imageDataForIconURL): Removed unused code (WebCore::IconDatabase::imageDataForPageURL): Removed unused code (WebCore::IconDatabase::isIconExpiredForIconURL): Removed LOG msg (WebCore::IconDatabase::isIconExpiredForPageURL): Removed LOG msg (WebCore::IconDatabase::iconURLForPageURL): Added a hashmap cache to avoid common queries (WebCore::IconDatabase::releaseIconForURL): Changed to is isRetained() instead of retainCount() (WebCore::IconDatabase::isIconURLRetained): Added - we don't care about the actual retain count for an icon so much as whether or not it is retained (WebCore::IconDatabase::setIconURLForPageURL): If the new and old iconURLs are the same, skip the SQLite code
  • loader/icon/IconDatabase.h: Added new methods/variables
  • loader/icon/SiteIcon.cpp: (SiteIcon::SiteIcon): Added a flag so it only queries the database for icon data once (SiteIcon::getImage): Ditto
4:22 PM Changeset in webkit [15864] by hyatt
  • 1 edit in trunk/WebCore/html/HTMLTokenizer.cpp

Land a wording tweak to a comment I made.

3:05 PM Changeset in webkit [15863] by yongjzha
  • 2 edits in S60/trunk/WebKit

006-08-14 ligman <​joseph.ligman@nokia.com>

Reviewed by yongjzha
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10335
Browser crashes on exit because ~CPluginSkin trys to make use of the
iBrCtlSoftkeysObserver in it's destructor. The iBrCtlSoftkeysObserver is not
always owned by CBrCtl and therefore could be deleted prematurely. When the CPluginSkin
tried to make use of it, it was no longer valid and it was not set to NULL. To resolve this
the object destruction was rearranged in CBrCtl to delete the CWebKitControl after deleting
all of the observers and setting them to NULL.


Change the order of how ojects are destructed in ~CBrCtl
set observer pointers to NULL

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::~CBrCtl): (CBrCtl::UpdateDefaultSoftkeysL):
2:43 PM Changeset in webkit [15862] by hyatt
  • 2 edits
    4 adds in trunk

Fix for bug 10385, add more support for crappy pseudo-XML-in-HTML.

Reviewed by ggaren

Added fast/parser/bad-xml-slash.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
1:48 PM Changeset in webkit [15861] by hyatt
  • 2 edits in trunk/WebKit

Fix for Radar bug 4478840, Safari should not reduce null events sent to
plug-ins in windows that are inactive but visible.

With this fix you can view videos in visible background windows on YouTube
(for example) and not see any drop in frame rate.

Reviewed by timo

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView restartNullEvents]):
1:17 PM Changeset in webkit [15860] by thatcher
  • 7 edits in branches/Safari-1-3-branch/WebCore

Merged fix from Safari-2-0-branch to Safari-1-3-branch

2006-08-04 Beth Dakin <Beth Dakin>

Reviewed by me/Hyatt.

Mostly this is merging over Hyatt's fix with r15801. Some other
things needed to be tweaked though. This is a better fix for
<rdar://problem/4541255> Safari hangs at ​http://www.kutilek.de/
safari-test/ somewhere from
WebCore::RenderBlock::layoutInlineChildren(bool)

  • khtml/rendering/render_box.cpp: (RenderBox::deleteLineBoxWrapper): Call remove.
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_list.cpp: (RenderListItem::updateMarkerLocation): Call remove.
  • khtml/rendering/render_list.h: (khtml::ListMarkerBox:::InlineBox):
  • khtml/rendering/render_object.cpp: Back out old fix. (RenderObject::remove):
  • khtml/rendering/render_object.h: Back out old fix.
12:23 PM Changeset in webkit [15859] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by John Sullivan.

  • fast/parser/title-error-test-expected.checksum: Added.
  • fast/parser/title-error-test-expected.png: Added.
  • fast/parser/title-error-test-expected.txt: Added.
  • fast/parser/title-error-test.html: Added.

WebCore:

Reviewed by John Sullivan.

Test: fast/parser/title-error-test.html

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): Fixed an error handling case that was skipping until a </style> tag in code that was shared between both <title> and <style>. Also rearranged the code a tiny bit.
12:16 PM Changeset in webkit [15858] by thatcher
  • 3 edits in branches/Safari-1-3-branch/WebCore

Merged fix from Safari-2-0-branch to Safari-1-3-branch

2006-07-28 Beth Dakin <Beth Dakin>

Rubber stamped by Maciej.

Fix for <rdar://problem/4541255> Safari hangs at ​http://
www.kutilek.de/safari-test/ somewhere from
WebCore::RenderBlock::layoutInlineChildren(bool)

This is the same fix that Maciej and I did a week ago for 4529398.
Rolling it onto the branch because it fixes this crash too!

  • WebCore.xcodeproj/project.pbxproj: Project file wars.
  • khtml/rendering/render_list.cpp: (ListMarkerBox::detach): Remove from parent when detaching. (ListMarkerBox::operator delete):
  • khtml/rendering/render_list.h:
12:14 PM Changeset in webkit [15857] by darin
  • 3 edits in trunk/WebCore

Reviewed by Hyatt.

  • platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): Rearrange code so that "delete this" is called any time the function returns false -- ownership was inconsistent before.
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::removeChildNode): Call deleteLineBoxWrapper even when documentBeingDestroyed() is true, because some of what it does has to be done during destruction. A little awkward since I preserved the order of operations. Perhaps we could structure this better later.
10:13 AM Changeset in webkit [15856] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan and Geoff Garen.

<rdar://problem/3854950> AX Seed: Blackboard Learning Systems - frame names need to be put in AXDescription AXAttribute

Test cases added: None. Manual AX testing is way too awkward, and automated testing
is not possible. See following bug...

<rdar://problem/4256882> Need automated testing support for accessibility APIs

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityDescription]): For a web area, return the name of the owning frame or iframe.


(-[WebCoreAXObject accessibilityAttributeNames]):
Advertize NSAccessibilityDescriptionAttribute.


(-[WebCoreAXObject rendererForView:]):
Clean up some old naming.

9:32 AM Changeset in webkit [15855] by andersca
  • 6 edits
    6 adds
    4 deletes in trunk/WebCore

2006-08-11 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10353
XMLSerializer and DOMParser should have real implementations


Make real implementation files for DOMParser and XMLSerializer and wrap them
using our bindings generation.


  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMParser.cpp: Removed.
  • bindings/js/JSDOMParser.h: Removed.
  • bindings/js/JSXMLSerializer.cpp: Removed.
  • bindings/js/JSXMLSerializer.h: Removed.
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
  • bindings/js/kjs_window.h: (KJS::Window::):
  • page/DOMWindow.idl:
  • xml/DOMParser.cpp: Added. (WebCore::DOMParser::parseFromString):
  • xml/DOMParser.h: Added.
  • xml/DOMParser.idl: Added.
  • xml/XMLSerializer.cpp: Added. (WebCore::XMLSerializer::serializeToString):
  • xml/XMLSerializer.h: Added.
  • xml/XMLSerializer.idl: Added.
2:01 AM Changeset in webkit [15854] by mjs
  • 7 edits in trunk

WebCore:

Reviewed by Brady.

  • removed WebKit-level dependencies from WebFormDataStream. Use WebCore version of system interface
  • WebCore.exp: export new functions
  • platform/mac/WebCoreSystemInterface.h: Added CFReadStream related functions
  • platform/mac/WebCoreSystemInterface.mm: ditto

WebKit:

Reviewed by Brady.


  • removed WebKit-level dependencies from WebFormDataStream. Use WebCore version of system interface
  • Loader/WebFormDataStream.m: (formCanRead): (formEventCallback): (webSetHTTPBody):
  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
12:20 AM Changeset in webkit [15853] by mjs
  • 2 edits
    2 moves in trunk/WebKit

Rubber stamped by Brady.


  • move WebFormDataStream from WebView to Loader
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebFormDataStream.h: Removed.
  • WebView/WebFormDataStream.m: Removed.
12:09 AM Changeset in webkit [15852] by mjs
  • 4 edits in trunk/WebKit

Reviewed by Brady.


  • remove WebKit dependencies from WebSubresourceLoader, except WebFormDataStream


(WebFormDataStream will be moved into the Loader directory soon)

  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]):
  • Loader/WebSubresourceLoader.m: (isConditionalRequest): (hasCaseInsensitivePrefix): (isFileURLString): (setHTTPReferrer): (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):

Aug 13, 2006:

11:50 PM Changeset in webkit [15851] by beidson
  • 2 edits
    2 moves in trunk/WebKit

Reviewed by Maciej

Relocated the WebIconLoaders

  • Misc/WebIconLoader.h: Moved to Loader/
  • Misc/WebIconLoader.m: Moved to Loader/
  • WebKit.xcodeproj/project.pbxproj:
11:46 PM Changeset in webkit [15850] by beidson
  • 1 edit in trunk/WebKit/ChangeLog

Fixed my inaccurately stated Changelog

11:45 PM Changeset in webkit [15849] by mjs
  • 3 edits in trunk/WebKit

Reviewed by Beth.


  • removed non-Loader WebKit dependencies from WebDataProtocol for real (whoops) and fix some typos.
  • Loader/WebDataProtocol.m: (isCaseInsensitiveEqual): Added. (+[WebDataProtocol _webIsDataProtocolURL:]): Avoid WebKit calls. (-[WebDataProtocol startLoading]): ditto
  • Loader/WebFrameLoader.m: (isCaseInsensitiveEqual): Fixed spelling from isCaseSensitiveEqual. (-[WebFrameLoader _canUseResourceForRequest:]): Use proper call.
11:44 PM Changeset in webkit [15848] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Maciej

The way of detecting a failed icon load before was to try and construct
an image from the icon and if that image construction failed, mark the icon
as missing.
A much more efficient way is to check for a 404 response. We'll still
check for invalid image data, but most servers will correctly return 404
on a missing icon.


  • Misc/WebIconLoader.m: (-[WebIconLoader didFinishLoading]): Added check for 404 response
8:22 PM Changeset in webkit [15847] by mjs
  • 9 edits
    2 moves in trunk/WebKit

Reviewed by Darin.


  • remove all non-Loader dependencies from WebLoader


As part of this I moved WebDataProtocol to the loader directory
and removed dependencies on the rest of WebKit from that too.

  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader setDefersCallbacks:]): (-[WebFrameLoader stopLoading]): (-[WebFrameLoader cancelledErrorWithRequest:]): (-[WebFrameLoader clearArchivedResources]): (-[WebFrameLoader deliverArchivedResources]): (-[WebFrameLoader deliverArchivedResourcesAfterDelay]): (isCaseSensitiveEqual): (-[WebFrameLoader _canUseResourceForRequest:]): (-[WebFrameLoader _canUseResourceWithResponse:]): (-[WebFrameLoader pendingArchivedResources]): (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): (-[WebFrameLoader archiveLoadPendingForLoader:]): (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
  • Loader/WebLoader.h:
  • Loader/WebLoader.m: (-[NSURLProtocol releaseResources]): (-[NSURLProtocol loadWithRequest:]): (-[NSURLProtocol setDefersCallbacks:]): (-[NSURLProtocol addData:allAtOnce:]): (-[NSURLProtocol resourceData]): (-[NSURLProtocol didReceiveData:lengthReceived:allAtOnce:]): (-[NSURLProtocol connection:didReceiveData:lengthReceived:]): (-[NSURLProtocol cancelWithError:]): (-[NSURLProtocol cancelledError]):
  • Loader/WebMainResourceLoader.m: (-[WebMainResourceLoader addData:allAtOnce:]): (-[WebMainResourceLoader didReceiveData:lengthReceived:allAtOnce:]):
  • Loader/WebNetscapePlugInStreamLoader.m: (-[WebNetscapePlugInStreamLoader didReceiveData:lengthReceived:allAtOnce:]):
  • Loader/WebSubresourceLoader.m: (-[WebSubresourceLoader didReceiveData:lengthReceived:allAtOnce:]):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataProtocol.h: Removed.
  • WebView/WebDataProtocol.m: Removed.
8:06 PM Changeset in webkit [15846] by mjs
  • 22 edits
    1 copy
    2 adds in trunk

JavaScriptCore:

Reviewed (and tweaked a little) by Maciej.


  • shrank the size of JSObject by 8 bytes and made the corresponding reduction to the cell size, resulting in a 1.2% speed improvement on JS iBench (and probably overall memory savings).

This was done by removing _scope and _internalValue data members
from JSObject and moving them only to the subclasses that actually
make use of them.


  • kjs/object.cpp: (KJS::JSObject::mark): No need to mark scope or internal value here.
  • kjs/object.h: (KJS::JSObject::JSObject): Don't initialize them.
  • kjs/JSWrapperObject.cpp: Added. New base class for object types that wrap primitive values (Number, String, Boolean, Date). (KJS::JSWrapperObject::mark):
  • kjs/JSWrapperObject.h: Added. (KJS::JSWrapperObject::JSWrapperObject): (KJS::JSWrapperObject::internalValue): (KJS::JSWrapperObject::setInternalValue):
  • kjs/array_object.cpp: (ArrayPrototype::ArrayPrototype): Don't set useless internal value.
  • kjs/bool_object.cpp: (BooleanInstance::BooleanInstance): Inherit from JSWrapperObject. (BooleanProtoFunc::callAsFunction): Fixed to account for fact that not all JSObjects have an internal value. (BooleanObjectImp::construct): ditto.
  • kjs/bool_object.h:
  • kjs/collector.cpp: Lowered cell size to 48. (KJS::Collector::allocate): meaningless whitespace change
  • kjs/date_object.cpp: (KJS::DateInstance::DateInstance): Inherit from JSWrapperObject. (KJS::DateProtoFunc::callAsFunction): adjusted for move of internalValue (KJS::DateObjectImp::construct): ditto
  • kjs/date_object.h:
  • kjs/error_object.cpp: (ErrorPrototype::ErrorPrototype): don't set internal value
  • kjs/function.cpp: move _scope and related handling here (KJS::FunctionImp::mark): mark scope
  • kjs/function.h: (KJS::FunctionImp::scope): moved here from JSObject (KJS::FunctionImp::setScope): ditto
  • kjs/number_object.cpp: (NumberInstance::NumberInstance): inherit from JSWrapperObject (NumberProtoFunc::callAsFunction): adjusted (NumberObjectImp::construct): adjusted
  • kjs/number_object.h: shring RegExp-related objects a little
  • kjs/regexp_object.cpp: (RegExpPrototype::RegExpPrototype): Adjust for size tweaks (RegExpObjectImp::RegExpObjectImp): ditto
  • kjs/regexp_object.h:
  • kjs/string_object.cpp: (StringInstance::StringInstance): inherit from JSWrapperObject (StringProtoFunc::callAsFunction): adjusted
  • kjs/string_object.h:
  • JavaScriptCore.exp: Exported new methods as needed.
  • JavaScriptCore.xcodeproj/project.pbxproj: Added new files to build.

WebCore:

Reviewed (and tweaked a little) by Maciej.


  • shrank the size of JSObject by 8 bytes and made the corresponding reduction to the cell size, resulting in a 1.2% speed improvement on JS iBench (and probably overall memory savings).

The WebCore part of this is to expect only FunctionImp to have a scope, not all JSObjects.


  • bindings/js/kjs_events.cpp: (KJS::JSLazyEventListener::parseCode):

Aug 12, 2006:

6:38 PM Changeset in webkit [15845] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=10111> - Menu flickers over Flash content
<rdar://problem/3052546> Plugins don't work with z-index (overlapping elements, etc.)

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Don't just clip to the dirty region for "transparent" plug-ins -- do it for all plug-ins. This is a generally useful thing to do, as it prevents the plug-in from drawing over parts of the window that have already been drawn and are not expected to be redrawn in the same update.

Aug 11, 2006:

10:59 PM Changeset in webkit [15844] by eseidel
  • 3 edits in trunk/WebCore

2006-08-12 Eric Seidel <​eric@eseidel.com>

Reviewed by hyatt and mjs.

Fix two missing null checks causing layout test crashes.

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): check e for null (null for pseudo styles)
  • kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::requiresLayer): check parent()->element() for null
10:46 PM Changeset in webkit [15843] by ddkilzer
  • 4 edits in trunk/LayoutTests

LayoutTests:

Reviewed by NOBODY (layout test fix).

Additional layout test fixes from hyatt's "Eliminate RenderImageButton" change
in r15839. See also r15840 for more layout test fixes.

  • tables/mozilla/bugs/bug19599-expected.txt: Changed RenderImageButton to RenderImage.
  • tables/mozilla/bugs/bug24200-expected.txt: Ditto.
  • tables/mozilla/bugs/bug4527-expected.txt: Ditto.
9:07 PM Changeset in webkit [15842] by eseidel
  • 15 edits
    4 adds in trunk

2006-08-11 Eric Seidel <​eric@eseidel.com>

Reviewed by andersca.

The outermost <svg> element needs to clip itself
​http://bugzilla.opendarwin.org/show_bug.cgi?id=5358

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): adjust for SVG overflow rules
  • kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::requiresLayer): only require layers for absolute/relative positioning of outermost SVG (WebCore::RenderSVGContainer::paint):
  • kcanvas/device/KRenderingDevice.h:
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h: remove dead methods
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: remove dead methods (WebCore::KRenderingDeviceContextQuartz::KRenderingDeviceContextQuartz):
  • ksvg2/svg/SVGPaint.cpp: spacing changes (WebCore::SVGPaint::SVGPaint): spacing cleanup
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::parseMappedAttribute): spacing cleanup
  • platform/GraphicsContext.h: Added concatCTM
  • platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::concatCTM): Added.
8:22 PM Changeset in webkit [15841] by beidson
  • 7 edits in trunk

WebCore:

Reviewed by Maciej

Renamed a method/parameter for clarity and consistency, as well as some style
cleanups and removing some ridiculously verbose log messages.
Also added an _isEmpty method to the database and bridge for WebKit's use.
Finally, added a central way for both WebKit and WebCore to get the icon database filename

  • bridge/mac/WebCoreIconDatabaseBridge.h: Added _isEmpty and defaultDatabaseFilename
  • bridge/mac/WebCoreIconDatabaseBridge.mm: Removed an unnecessary semicolon off most of these methods (-[WebCoreIconDatabaseBridge openSharedDatabaseWithPath:]): (-[WebCoreIconDatabaseBridge closeSharedDatabase]): (-[WebCoreIconDatabaseBridge isOpen]): (-[WebCoreIconDatabaseBridge _isEmpty]): Added (-[WebCoreIconDatabaseBridge setPrivateBrowsingEnabled:]): (-[WebCoreIconDatabaseBridge privateBrowsingEnabled]): (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]): (-[WebCoreIconDatabaseBridge iconURLForPageURL:]): (-[WebCoreIconDatabaseBridge defaultIconWithSize:]): (-[WebCoreIconDatabaseBridge retainIconForURL:]): (-[WebCoreIconDatabaseBridge releaseIconForURL:]): (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]): (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]): (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]): (-[WebCoreIconDatabaseBridge _hasIconForIconURL:]): (-[WebCoreIconDatabaseBridge defaultDatabaseFilename]): Added
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::defaultDatabaseFilename): Added (WebCore::IconDatabase::open): (WebCore::IconDatabase::isEmpty): Added (WebCore::IconDatabase::retainIconForURL): Removed log message (WebCore::IconDatabase::releaseIconForURL): Removed log message
  • loader/icon/IconDatabase.h:

WebKit:

Reviewed by John, Timo, Adele, and Darin

In addition to a few style/good-practice cleanups, this patch will convert the old icon database
format to the WebCore format if the WebCore db is empty (implying this conversion has yet to take
place). After the conversion, it will delete all traces of the old format to free the unneeded space

  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): (-[WebIconDatabase _setIconURL:forURL:]): Changed the bridge's name for this method to be more clear (-[WebIconDatabase _createFileDatabase]): (-[WebIconDatabase _iconDataForIconURL:]): This grabs the raw data for use in the conversion function (-[WebIconDatabase _convertToWebCoreFormat]): This does the actual conversion
4:53 PM Changeset in webkit [15840] by hyatt
  • 5 edits in trunk/LayoutTests/fast/forms

Update layout tests for removal of RenderImageButton

4:52 PM Changeset in webkit [15839] by hyatt
  • 5 edits in trunk/WebCore

Eliminate RenderImageButton.

Reviewed by darin

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject isImageButton]):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::createRenderer):
  • rendering/RenderImage.h: (WebCore::RenderImage::isImage):
4:49 PM Changeset in webkit [15838] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Brady.

Test case for <rdar://problem/4656274>
REGRESSION: option elements are selected when added regardless of "selected" property

  • fast/forms/option-constructor-selected-expected.txt: Added.
  • fast/forms/option-constructor-selected.html: Added.

WebCore:

Reviewed by Brady.

  • Fix for <rdar://problem/4656274> REGRESSION: option elements are selected when added regardless of "selected" property

Test: fast/forms/option-constructor-selected.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setOption): When adding an option element, check that the option element is selected before calling setSelectedIndex.
4:06 PM Changeset in webkit [15837] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.


Needed for <rdar://problem/4678070>.

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView sendEvent:]): Changed an assertion to an early return. It should be possible to send events, especially updateEvt (for image capturing purposes), to off-screen plug-ins. It just doesn't work right now. See <rdar://problem/4318269>.
3:35 PM Changeset in webkit [15836] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Darin


  • fixed <rdar://problem/4522894> Would be nice if Safari shrank pages a little if necessary to avoid printing an almost-empty page
  • WebView/WebHTMLView.m: (-[NSArray knowsPageRange:]): If the last page has a short-enough orphan (< 1/10 of the page height is the number I pulled out of ... the air), then we adjust the scale factor slightly and check whether this reduces the page count and thus eliminates the orphan.
2:26 PM Changeset in webkit [15835] by hyatt
  • 4 adds in trunk/LayoutTests/fast/dynamic

Add layout test for link bug.

2:18 PM Changeset in webkit [15834] by hyatt
  • 4 edits in trunk/WebCore

Fix for bug 10349, make sure to call setChanged when an anchor changes
from not being a link to being a link (and vice versa).

Test is in fast/dynamic/link-href-change.html

Reviewed by darin

  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::HTMLAnchorElement): (WebCore::HTMLAnchorElement::parseMappedAttribute):
  • html/HTMLAnchorElement.h:
  • html/HTMLAreaElement.cpp: (WebCore::HTMLAreaElement::parseMappedAttribute):
1:58 PM Changeset in webkit [15833] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Revert an over-optimization step that messed up the HashSet lookup.

10:46 AM Changeset in webkit [15832] by oliver
  • 2 edits in trunk/WebCore

Removing unnecessary comment from patch for bug 10346

10:15 AM Changeset in webkit [15831] by oliver
  • 2 edits in trunk/WebCore

Fix for bug #10346, fixes regression in svg image layout

Aug 10, 2006:

5:28 PM Changeset in webkit [15830] by andersca
  • 4 edits
    33 copies
    1 delete in trunk/WebCore

2006-08-10 Anders Carlsson <​acarlsson@apple.com>

Rubber-stamped by Maciej.

Move xpath to xml.


  • DerivedSources.make:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • xpath/XPathEvaluator.cpp: Removed.
  • xpath/XPathEvaluator.h: Removed.
  • xpath/XPathEvaluator.idl: Removed.
  • xpath/XPathExpression.cpp: Removed.
  • xpath/XPathExpression.h: Removed.
  • xpath/XPathExpression.idl: Removed.
  • xpath/XPathNSResolver.cpp: Removed.
  • xpath/XPathNSResolver.h: Removed.
  • xpath/XPathNSResolver.idl: Removed.
  • xpath/XPathNamespace.cpp: Removed.
  • xpath/XPathNamespace.h: Removed.
  • xpath/XPathResult.cpp: Removed.
  • xpath/XPathResult.h: Removed.
  • xpath/XPathResult.idl: Removed.
  • xpath/impl/XPathExpressionNode.cpp: Removed.
  • xpath/impl/XPathExpressionNode.h: Removed.
  • xpath/impl/XPathFunctions.cpp: Removed.
  • xpath/impl/XPathFunctions.h: Removed.
  • xpath/impl/XPathGrammar.y: Removed.
  • xpath/impl/XPathParser.cpp: Removed.
  • xpath/impl/XPathParser.h: Removed.
  • xpath/impl/XPathPath.cpp: Removed.
  • xpath/impl/XPathPath.h: Removed.
  • xpath/impl/XPathPredicate.cpp: Removed.
  • xpath/impl/XPathPredicate.h: Removed.
  • xpath/impl/XPathStep.cpp: Removed.
  • xpath/impl/XPathStep.h: Removed.
  • xpath/impl/XPathUtil.cpp: Removed.
  • xpath/impl/XPathUtil.h: Removed.
  • xpath/impl/XPathValue.cpp: Removed.
  • xpath/impl/XPathValue.h: Removed.
  • xpath/impl/XPathVariableReference.cpp: Removed.
  • xpath/impl/XPathVariableReference.h: Removed.
1:37 PM Changeset in webkit [15829] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/4600112> REGRESSION: VO no longer able to review text within an edit field on web pages

Test cases added: None. Manual AX testing is way too awkward, and automated testing
is not possible. See following bug...

<rdar://problem/4256882> Need automated testing support for accessibility APIs

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject value]): Add handling for text input fields.
Note: See TracTimeline for information about the timeline view.