Context Navigation

← Previous Period
Next Period →

Timeline

Aug 27, 2006:

10:59 PM Changeset in webkit [16069] by beidson

2 edits in trunk/WebCore

Reviewed by Maciej

Rewrote StringImpl::replace(UChar, StringImpl*)

platform/StringImpl.cpp: (WebCore::StringImpl::replace):

8:33 PM Changeset in webkit [16068] by weinig

31 edits
10 adds in trunk

WebCore:

Reviewed by Tim H.

patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=4624 WebCore needs autogenerated Obj-C DOM bindings

First round of auto-generated Objective C DOM bindings, starting
with the DOM Core.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOM.mm: (-[DOMNode description]): (-[DOMNode KJS::Bindings::]): (-[DOMNode dispatchEvent:]): (-[DOMNamedNodeMap _initWithNamedNodeMap:]): (+[DOMNamedNodeMap _namedNodeMapWith:]): (-[DOMNodeList _initWithNodeList:]): (+[DOMNodeList _nodeListWith:]): (-[DOMImplementation _initWithDOMImplementation:]): (+[DOMImplementation _DOMImplementationWith:]): (-[DOMImplementation _DOMImplementation]): (+[DOMDocumentFragment _documentFragmentWith:]): (-[DOMDocumentFragment _fragment]): (-[DOMDocument createCSSStyleDeclaration]): (+[DOMDocument _documentWith:]): (-[DOMDocument _document]): (-[DOMDocument _ownerElement]): (+[DOMAttr _attrWith:]): (-[DOMAttr _attr]): (+[DOMDocumentType _documentTypeWith:WebCore::]): (-[DOMDocumentType WebCore::]): (+[DOMText _textWith:WebCore::]): (+[DOMComment _commentWith:WebCore::]): (+[DOMCDATASection _CDATASectionWith:WebCore::]): (+[DOMProcessingInstruction _processingInstructionWith:WebCore::]): (+[DOMEntityReference _entityReferenceWith:WebCore::]):
bindings/objc/DOMCSS.h:
bindings/objc/DOMCSS.mm:
bindings/objc/DOMCore.h:
bindings/objc/DOMEvents.h:
bindings/objc/DOMEvents.mm:
bindings/objc/DOMExtensions.h:
bindings/objc/DOMHTML.mm: (+[DOMHTMLDocument _HTMLDocumentWith:WebCore::]):
bindings/objc/DOMHTMLInternal.h:
bindings/objc/DOMImplementationFront.h:
bindings/objc/DOMInternal.h:
bindings/objc/DOMNode.h: Added.
bindings/objc/DOMNode.mm: Added. (-[DOMNode dealloc]): (-[DOMNode finalize]): (-[DOMNode nodeName]): (-[DOMNode nodeValue]): (-[DOMNode setNodeValue:]): (-[DOMNode nodeType]): (-[DOMNode parentNode]): (-[DOMNode childNodes]): (-[DOMNode firstChild]): (-[DOMNode lastChild]): (-[DOMNode previousSibling]): (-[DOMNode nextSibling]): (-[DOMNode attributes]): (-[DOMNode ownerDocument]): (-[DOMNode insertBefore::]): (-[DOMNode replaceChild::]): (-[DOMNode removeChild:]): (-[DOMNode appendChild:]): (-[DOMNode hasChildNodes]): (-[DOMNode cloneNode:]): (-[DOMNode normalize]): (-[DOMNode isSupported::]): (-[DOMNode namespaceURI]): (-[DOMNode prefix]): (-[DOMNode setPrefix:]): (-[DOMNode localName]): (-[DOMNode hasAttributes]): (-[DOMNode isSameNode:]): (-[DOMNode isEqualNode:]): (-[DOMNode isDefaultNamespace:]): (-[DOMNode lookupPrefix:]): (-[DOMNode lookupNamespaceURI:]): (-[DOMNode textContent]): (-[DOMNode setTextContent:]): (-[DOMNode boundingBox]): (-[DOMNode lineBoxRects]):
bindings/objc/DOMObject.h: Added.
bindings/objc/DOMObject.mm: Added. (-[DOMObject init]): (-[DOMObject dealloc]): (-[DOMObject finalize]): (-[DOMObject copyWithZone:]): (-[DOMObject sheet]):
bindings/objc/DOMPrivate.h:
bindings/objc/DOMRange.h:
bindings/objc/DOMStylesheets.h:
bindings/objc/DOMTraversal.h:
bindings/objc/DOMViews.h:
bindings/objc/DOMViews.mm:
bindings/objc/DOMXPath.h:
bindings/objc/DOMXPath.mm:
bindings/scripts/CodeGenerator.pm:
bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/CodeGeneratorObjC.pm: Added.
dom/Attr.idl:
dom/CDATASection.idl: Added.
dom/Comment.idl: Added.
dom/DOMImplementation.idl:
dom/Document.idl:
dom/Element.idl:
dom/EntityReference.idl: Added.
dom/NamedNodeMap.idl: Added.
dom/NodeList.idl: Added.
dom/ProcessingInstruction.idl:

WebKit:

Reviewed by Tim H.

patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=4624 WebCore needs autogenerated Obj-C DOM bindings

First round of auto-generated Objective C DOM bindings, starting
with the DOM Core.

WebKit.xcodeproj/project.pbxproj:

5:26 PM Changeset in webkit [16067] by thatcher

2 edits
3 adds in trunk

Reviewed by Anders.

Drosera will be built when you type make.

Drosera/Makefile: Added.
Makefile: Added.
Makefile.shared: Added.

4:12 PM Changeset in webkit [16066] by thatcher

2 edits in trunk/WebCore

Reviewed by Tim H.

Fix crash in LayoutTests/css1/font_properties/font.html,
by implementing FontData::smallCapsFontData.

platform/qt/FontDataQt.cpp: (WebCore::FontData::platformDestroy): (WebCore::FontData::smallCapsFontData):

3:57 PM Changeset in webkit [16065] by beidson

2 edits in trunk/WebCore

Reviewed by Maciej

Plugged a leak in StringImpl::replace()

platform/StringImpl.cpp: (WebCore::StringImpl::replace):

3:29 PM Changeset in webkit [16064] by andersca

5 edits in trunk/WebCore

2006-08-27 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed and landed by Anders.

Remove most annoying notImplemented() usages and
implement some missing ScrollViewQt functions.
Much nicer output when invoking run-webkit-tests.

platform/qt/FrameQt.cpp: (WebCore::FrameQt::saveDocumentState): (WebCore::FrameQt::restoreDocumentState): (WebCore::FrameQt::clearUndoRedoOperations): (WebCore::FrameQt::partClearedInBegin):
platform/qt/ResourceLoaderManager.cpp: (WebCore::headerCallback): (WebCore::ResourceLoaderManager::downloadTimerCallback):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::updateContents): (WebCore::ScrollView::suppressScrollBars): (WebCore::ScrollView::setStaticBackground): (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild):
platform/qt/TemporaryLinkStubs.cpp: (WebCore::historyContains): (WebCore::CheckCacheObjectStatus): (WebCore::CheckIfReloading): (loadResourceIntoArray): (WebCore::PlugInInfoStore::supportsMIMEType):

3:18 PM Changeset in webkit [16063] by andersca

1 edit in trunk/CMakeLists.txt

Forgot this too (doh!)

3:07 PM Changeset in webkit [16062] by andersca

1 edit in trunk/WebKitTools/Scripts/install-win-extras

Didn't mean to commit this!

3:03 PM Changeset in webkit [16061] by andersca

1 edit
5 adds in trunk/WebKitTools

2006-08-27 Anders Carlsson <acarlsson@apple.com>

Forgot to add these.

DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Added.
DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: Added. (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::~DumpRenderTree): (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::readStdin): (WebCore::DumpRenderTree::checkLoaded):
DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h: Added.
DumpRenderTree/DumpRenderTree.qtproj/main.cpp: Added. (main):

2:53 PM Changeset in webkit [16060] by andersca

5 edits in trunk/WebKitTools

2006-08-27 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Eric, landed by Anders.

Add DumpRenderTree support for Qt/Linux.

DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Added.
DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: Added. (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::~DumpRenderTree): (WebCore::DumpRenderTree::open): (WebCore::DumpRenderTree::readStdin): (WebCore::DumpRenderTree::checkLoaded):
DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h: Added.
DumpRenderTree/DumpRenderTree.qtproj/main.cpp: Added. (main):
Scripts/build-dumprendertree:
Scripts/run-webkit-tests:
Scripts/webkitdirs.pm:

2:47 PM Changeset in webkit [16059] by andersca

2 edits in trunk/WebCore

2006-08-27 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed and landed by Anders.

Fix Qt build (add SVGMetaDataElement.cpp to build system)

CMakeLists.txt:

2:40 PM Changeset in webkit [16058] by eseidel

5 edits
2 deletes in trunk/WebCore

2006-08-27 Eric Seidel <eric@eseidel.com>

Reviewed by andersca.

No logic changes. Just cleanup.

ksvg2/svg/SVGAngle.cpp: (SVGAngle::SVGAngle): (SVGAngle::unitType): (SVGAngle::valueAsString): (SVGAngle::newValueSpecifiedUnits): (SVGAngle::convertToSpecifiedUnits):
ksvg2/svg/SVGAngle.h:
ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::unitType): (WebCore::SVGLength::newValueSpecifiedUnits): (WebCore::SVGLength::convertToSpecifiedUnits): (WebCore::SVGLength::updateValue): (WebCore::SVGLength::updateValueInSpecifiedUnits):
ksvg2/svg/SVGLength.h:
platform/BitmapImage.cpp: Removed.
platform/BitmapImage.h: Removed.

2:30 PM Changeset in webkit [16057] by beidson

1 edit in trunk/WebCore/ChangeLog

God, that ChangeLog entry was bad...

2:28 PM Changeset in webkit [16056] by beidson

4 edits in trunk/WebCore

Reviewed by Anders

-Changed all of the commonly used queries to keep around pre-prepared statements and bind
their arguments instead of constructing a messy.
-Changed some code in pruneUnretainedIconsOnStartup regarding transactions

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): Initializers (WebCore::IconDatabase::close): Wipe all the preprepared statements (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Better handling of transactions (WebCore::readySQLStatement): Make sure a preprepared statement is ready to go for a fooQuery() (WebCore::IconDatabase::pageURLTableIsEmptyQuery): Added a comment (WebCore::IconDatabase::imageDataForIconURLQuery): Use preprepared statement + binding (WebCore::IconDatabase::timeStampForIconURLQuery): ditto (WebCore::IconDatabase::iconURLForPageURLQuery): ditto (WebCore::IconDatabase::forgetPageURLQuery): ditto (WebCore::IconDatabase::setIconIDForPageURLQuery): ditto (WebCore::IconDatabase::getIconIDForIconURLQuery): ditto (WebCore::IconDatabase::addIconForIconURLQuery): ditto (WebCore::IconDatabase::hasIconForIconURLQuery): ditto
loader/icon/IconDatabase.h: Added fooQuery() and *m_fooStatements
loader/icon/SQLStatement.h: (WebCore::SQLStatement::database): Added

12:27 PM Changeset in webkit [16055] by rwlbuis

2 edits in trunk/WebCore

Reviewed by Eric. Landed by rwlbuis.

Fix switch logic.

3:47 AM Changeset in webkit [16054] by rwlbuis

58 edits
6 deletes in trunk

Reviewed by Eric.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10557
KCanvasPath should be replace by platform/Path

Refactoring out the KCanvasPath class.

12:09 AM Changeset in webkit [16053] by eseidel

7 edits
4 adds in trunk

2006-08-26 Eric Seidel <eric@eseidel.com>

Reviewed by hyatt.

pointer-events attribute does not work.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10415

kcanvas/RenderPath.cpp: (WebCore::RenderPath::pointerEventsHitRules): new function to contain pointer-events hit logic (WebCore::RenderPath::nodeAtPoint): respect pointer-events property
kcanvas/RenderPath.h: (WebCore::RenderPath::PointerEventsHitRules::PointerEventsHitRules):
ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
ksvg2/svg/SVGPaint.cpp: Fix this to use a real enum value (WebCore::SVGPaint::SVGPaint): (WebCore::SVGPaint::paintType): (WebCore::SVGPaint::uri): (WebCore::SVGPaint::setUri): (WebCore::SVGPaint::setPaint):
ksvg2/svg/SVGPaint.h:

Aug 26, 2006:

3:45 PM Changeset in webkit [16052] by rwlbuis

6 edits
7 adds in trunk

Reviewed by Eric.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10558
SVG should have support for <metadata> element

Add support for metadata tag.

2:51 AM Changeset in webkit [16051] by ap

3 edits in trunk/WebCore

Reviewed by Eric.

Daily Qt build fixes :-)

platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawConvexPolygon):
platform/qt/ImageQt.cpp: (WebCore::Image::initPlatformData): (WebCore::Image::invalidatePlatformData): (WebCore::Image::loadPlatformResource):

1:11 AM Changeset in webkit [16050] by hyatt

2 edits in trunk/WebCore

Fix the ifdef in Path.h to be CG.

platform/Path.h:

12:48 AM Changeset in webkit [16049] by hyatt

2 edits in trunk/WebCore

Fix Mac build bustage (lots of float/int confusion). I am not sure
whether rounding was desired or not... this is just a band-aid to get
the build working again.

rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintMenuListButton): (WebCore::RenderThemeMac::adjustMenuListButtonStyle):

Aug 25, 2006:

11:49 PM Changeset in webkit [16048] by hyatt

13 edits
1 add in trunk/WebCore

More refactoring of image to disentangle graphics (e.g., Cairo) from
platform (e.g., Windows).

WebCore.vcproj/WebCore/WebCore.vcproj: Add ImageWin to project.

loader/Cache.cpp: (WebCore::Cache::init):
loader/icon/IconDataCache.cpp: (WebCore::IconDataCache::loadImageFromResource): Renamed loadResource to loadPlatformResource to try to make it more clear that this call is implemented on each OS (and not by graphics libraries).

platform/Image.cpp: (WebCore::Image::Image): (WebCore::Image::~Image): (WebCore::Image::invalidateData): (WebCore::Image::size): (WebCore::Image::setData): (WebCore::Image::setNativeData): Fix up the PDF code to not be considered platform data any more, since PDF rendering is not for a specific OS.

Renamed the methods that set OS-specific data (like NSImage) to PlatformData
instead of NativeData.

platform/Image.h: Shifted the PDF members into CG defines. Made CGImageRef a CG define. Renamed methods to reflect that they are OS-specific and not graphics-library-specific.

platform/cairo/ImageCairo.cpp: Removed the platform data methods. Other platforms besides Windows that use Cairo will need to account for this change by adding these methods to their OS Image*.cpp file.

platform/cg/ImageCG.cpp: (WebCore::Image::drawTiled): Add FIXMEs to the wkpattern stuff.

platform/cg/PDFDocumentImage.cpp: Shouldn't have #imports in .cpp.

platform/mac/ImageMac.mm: (WebCore::Image::initPlatformData): (WebCore::Image::invalidatePlatformData): (WebCore::Image::loadPlatformResource): (WebCore::Image::getTIFFRepresentation): Add the platform data initializers to the Mac Image file. Move the TIFF representation there as well, since this is only used by Mac code.

platform/win/ImageWin.cpp: Added. (WebCore::Image::initPlatformData): (WebCore::Image::invalidatePlatformData): (WebCore::Image::loadPlatformResource): (WebCore::Image::supportsType): Similar work for Windows. Add stubs for possible future HBITMAP returns in the platform data methods.

rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintResizeControl):
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintResizeControl): loadResource -> loadPlatformResource

11:45 PM Changeset in webkit [22124] by hyatt

1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

Add ImageWin to project.

10:31 PM Changeset in webkit [22123] by hyatt

8 edits in branches/WindowsMerge

WebCoreWin:

Land CG/Cairo refactoring (and add some winsock2.h). (I do not really
understand why the winsock2.h stuff would suddenly be needed.)

platform/win/ResourceLoaderWin.h:
platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::setAlpha): (GraphicsContext::drawFocusRing): (GraphicsContext::drawLineForMisspelling): (GraphicsContext::setCompositeOperation):
plugins/win/PluginPackageWin.h:
plugins/win/PluginViewWin.h:
plugins/win/npapi.cpp:
rendering/RenderThemeWin.cpp: (WebCore::prepareForDrawing): (WebCore::doneDrawing):

WebKitWin:

Add code path for doing painting of a WebFrame using CG.

WebFrame.cpp: (WebFrame::paint):

6:59 PM Changeset in webkit [16047] by aroben

2 edits in trunk/WebCore

Rubber-stamped by Adele.

Fixed build.

platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawConvexPolygon):

5:37 PM Changeset in webkit [16046] by beidson

2 edits in trunk/WebKit

Reviewed by Tim Hatcher

Fixed up some leaks on [WebIconDatabase init]

Misc/WebIconDatabase.m: (-[WebIconDatabase init]):

5:33 PM Changeset in webkit [16045] by adele

15 edits in trunk

LayoutTests:

Updated results for addition of -webkit-text-security.

fast/css/computed-style-expected.txt:

WebCore:

Patch by Francisco, Reviewed by me.

Preparation for switch to new text field implementation of password field.

Added -webkit-text-security property.

Tests: updated fast/css/computed-style-expected.txt

css/CSSPropertyNames.in: Added -webkit-text-security.
css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added cases for textSecurity.
css/cssparser.cpp: (WebCore::CSSParser::parseValue): ditto.
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): ditto.
css/html4.css: Added style for password field to use -webkit-text-security.

html/HTMLInputElement.cpp: Check appearance property to decide which renderer to use. (WebCore::HTMLInputElement::selectionStart): (WebCore::HTMLInputElement::selectionEnd): (WebCore::HTMLInputElement::setSelectionStart): (WebCore::HTMLInputElement::setSelectionEnd): (WebCore::HTMLInputElement::select): (WebCore::HTMLInputElement::setSelectionRange): (WebCore::HTMLInputElement::createRenderer):
html/HTMLInputElement.h: (WebCore::HTMLInputElement::isNonWidgetTextField): Added check for password.

platform/StringImpl.cpp: (WebCore::StringImpl::secure): Added. Converts a string to replace characters with one character, like a bullet.
platform/StringImpl.h:

rendering/RenderStyle.cpp: (WebCore::StyleCSS3InheritedData::StyleCSS3InheritedData): Initialize textSecurity. (WebCore::RenderStyle::diff): Added case for textSecurity.
rendering/RenderStyle.h: (WebCore::): (WebCore::RenderStyle::textSecurity): Added. (WebCore::RenderStyle::setTextSecurity): Added. (WebCore::RenderStyle::initialTextSecurity): Added.
rendering/RenderText.cpp: (WebCore::RenderText::setStyle): Added case for textSecurity. (WebCore::RenderText::setText): ditto.

4:44 PM Changeset in webkit [16044] by adele

94 edits
8 adds in trunk

LayoutTests:

Reviewed by Hyatt.

New tests and updated tests for styled selects.

fast/borders/borderRadiusInvalidColor-expected.checksum: Added.
fast/borders/borderRadiusInvalidColor-expected.png: Added.
fast/borders/borderRadiusInvalidColor-expected.txt: Added.
fast/borders/borderRadiusInvalidColor.html: Added.

fast/forms/select-baseline-expected.checksum: Added.
fast/forms/select-baseline-expected.png: Added.
fast/forms/select-baseline-expected.txt: Added.
fast/forms/select-baseline.html: Added.

editing/pasteboard/4641033-expected.txt:
editing/selection/replaced-boundaries-3-expected.txt:
editing/selection/select-box-expected.txt:
fast/block/margin-collapse/103-expected.txt:
fast/forms/001-expected.checksum:
fast/forms/001-expected.png:
fast/forms/001-expected.txt:
fast/forms/003-expected.txt:
fast/forms/004-expected.txt:
fast/forms/HTMLOptionElement_label01-expected.txt:
fast/forms/HTMLOptionElement_label02-expected.txt:
fast/forms/HTMLOptionElement_label03-expected.txt:
fast/forms/HTMLOptionElement_label04-expected.txt:
fast/forms/HTMLOptionElement_label06-expected.txt:
fast/forms/HTMLOptionElement_label07-expected.txt:
fast/forms/form-element-geometry-expected.checksum:
fast/forms/form-element-geometry-expected.png:
fast/forms/form-element-geometry-expected.txt:
fast/forms/option-script-expected.txt:
fast/forms/option-text-clip-expected.txt:
fast/forms/select-change-listbox-to-popup-expected.txt:
fast/forms/select-selected-expected.txt:
fast/forms/select-style-expected.txt:
fast/forms/select-visual-hebrew-expected.txt:
fast/invalid/014-expected.txt:
fast/parser/document-write-option-expected.txt:
fast/replaced/width100percent-expected.txt:
http/tests/navigation/anchor-basic-expected.txt:
http/tests/navigation/anchor-frames-expected.txt:
http/tests/navigation/anchor-goback-expected.txt:
http/tests/navigation/anchor-subframeload-expected.txt:
http/tests/navigation/javascriptlink-basic-expected.txt:
http/tests/navigation/javascriptlink-frames-expected.txt:
http/tests/navigation/javascriptlink-goback-expected.txt:
http/tests/navigation/javascriptlink-subframeload-expected.txt:
http/tests/navigation/metaredirect-basic-expected.txt:
http/tests/navigation/metaredirect-frames-expected.txt:
http/tests/navigation/metaredirect-goback-expected.txt:
http/tests/navigation/metaredirect-subframeload-expected.txt:
http/tests/navigation/post-goback2-expected.txt:
http/tests/navigation/postredirect-goback2-expected.txt:
http/tests/navigation/redirect302-basic-expected.txt:
http/tests/navigation/redirect302-frames-expected.txt:
http/tests/navigation/redirect302-goback-expected.txt:
http/tests/navigation/redirect302-subframeload-expected.txt:
http/tests/navigation/relativeanchor-basic-expected.txt:
http/tests/navigation/relativeanchor-frames-expected.txt:
http/tests/navigation/relativeanchor-goback-expected.txt:
http/tests/navigation/slowmetaredirect-basic-expected.txt:
http/tests/navigation/slowtimerredirect-basic-expected.txt:
http/tests/navigation/success200-basic-expected.txt:
http/tests/navigation/success200-frames-expected.txt:
http/tests/navigation/success200-frames-loadsame-expected.txt:
http/tests/navigation/success200-goback-expected.txt:
http/tests/navigation/success200-loadsame-expected.txt:
http/tests/navigation/success200-reload-expected.txt:
http/tests/navigation/success200-subframeload-expected.txt:
http/tests/navigation/timerredirect-basic-expected.txt:
http/tests/navigation/timerredirect-frames-expected.txt:
http/tests/navigation/timerredirect-goback-expected.txt:
http/tests/navigation/timerredirect-subframeload-expected.txt:
tables/mozilla/bugs/bug1188-expected.txt:
tables/mozilla/bugs/bug18359-expected.txt:
tables/mozilla/bugs/bug2479-3-expected.txt:
tables/mozilla/bugs/bug2479-4-expected.txt:
tables/mozilla/bugs/bug29326-expected.txt:
tables/mozilla/bugs/bug33855-expected.txt:
tables/mozilla/bugs/bug4382-expected.txt:
tables/mozilla/bugs/bug96334-expected.txt:
tables/mozilla/core/margins-expected.txt:
tables/mozilla/dom/tableDom-expected.txt:
tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:

WebCore:

Reviewed by Hyatt.

Enable styling for popup menus. Also fixed baseline calculation for buttons and selects.

Tests: fast/forms/select-baseline.html

fast/borders/borderRadiusInvalidColor.html

updated: fast/forms/select-style-expected.txt and more...

css/html4.css: Added style rules for styled select elements.

platform/GraphicsContext.h: Added argument for antialiasing.
platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawConvexPolygon): ditto.
platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawConvexPolygon): ditto.

rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorderArc): Added textColor argument so this can be used when the border color is invalid. (WebCore::RenderObject::drawBorder): Removed invalidisInvert since its dead code (any callers that set this to true were already ensuring that their color was valid). Updated drawConvexPolygon call to use FloatPoints instead of IntPoints. (WebCore::RenderObject::paintBorder): Updated to remove invalidisInvert argument from drawBorder call. (WebCore::RenderObject::paintOutline): ditto.
rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintOutlineForLine): ditto.
rendering/RenderObject.h: Updated arguments for drawBorder and drawBorderArc.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::getBaselineOfLastLineBox): Changed isRootLineBox argument to true when setting line height. Added case for when there's no children to check for hasLineIfEmpty.
rendering/RenderBlock.h:
rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Changed isRootLineBox argument to true when setting line height.
rendering/RenderButton.h: (WebCore::RenderButton::hasLineIfEmpty): Added so buttons always get a line height.
rendering/RenderMenuList.h: (WebCore::RenderMenuList::hasLineIfEmpty): ditto.
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutHorizontalBox): Added code to check hasLineIfEmpty to give flex boxes line height. (WebCore::RenderFlexibleBox::layoutVerticalBox): ditto.

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Moved the appearance adjustment code into adjust style.
rendering/RenderBox.cpp: (WebCore::RenderBox::paintBoxDecorations): Lets the theme paint "decorations", like the arrow control and gradients immediately after painting the background.

rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): This now checks whether the control is styled, and adjusts the appearance property appropriately. For styled selects, instead of setting the appearance to none, which is what we do for other styled controls, we set the appearance to MenulistButtonAppearance, which indicates that we will draw the arrow controls and button appearance in the engine. (WebCore::RenderTheme::paintDecorations): Added. Paints MenulistButtonAppearance in a different function, so the arrow control will draw at the right time (after the background). (WebCore::RenderTheme::paint): Added case for MenulistButtonAppearance. (WebCore::RenderTheme::paintBorderOnly): ditto. (WebCore::RenderTheme::isControlContainer): Removed cases for MenuListAppearance and MenulistButtonAppearance since the baseline is no longer provided by the theme. (WebCore::RenderTheme::adjustMenuListButtonStyle): Added.
rendering/RenderTheme.h: (WebCore::RenderTheme::paintMenuListButton): Added.

rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled): Removed code that made selects unstyle-able. (WebCore::RenderThemeMac::baselinePosition): Removed cases for MenuListAppearance and MenulistButtonAppearance. (WebCore::RenderThemeMac::popupButtonPadding): Added top and bottom padding so empty popups have the right baseline. (WebCore::TopGradientInterpolate): Added. (WebCore::BottomGradientInterpolate): Added. (WebCore::MainGradientInterpolate): Added. (WebCore::RenderThemeMac::paintMenuListButtonGradients): Added. Draws gradients for styled popup menu button appearance. (WebCore::RenderThemeMac::paintMenuListButton): Calls paintMenuListButtonGradients, and draws arrow control. (WebCore::RenderThemeMac::adjustMenuListButtonStyle): Added to set padding and border radius to account for the arrow control size and font size.

3:57 PM Changeset in webkit [16043] by beidson

2 edits in trunk/WebCore

Reviewed by Adam

Changed some time()-related code to be more platform independent

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::isIconExpiredForIconURL): (WebCore::IconDatabase::getOrCreateIconDataCache): (WebCore::IconDatabase::setIconDataForIconURL):

3:25 PM Changeset in webkit [16042] by harrison

2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4416432> Radio buttons and Checkboxes in AXWebAreas don't fill in their AXTitle attribute

bridge/mac/WebCoreAXObject.mm: (labelForElement): New. Returns the HTMLLabelElement, if any, for the specified Element.

(-[WebCoreAXObject title]):
For input elements, return the innerHTML() of the labelForElement().

2:42 PM Changeset in webkit [16041] by zbujtas

2 edits in S60/trunk/WebCore

2006-08-25 bujtas <zbujtas@gmail.com>

Reviewed by Sriram.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10570
fix null pointer crash. check if tokenizer is null.

khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::HTMLObjectElementImpl):

2:28 PM Changeset in webkit [16040] by beidson

2 edits in trunk/WebCore

Reviewed by Tim Hatcher

Changed some debugging-only code to be more platform independent

WebCore.xcodeproj/project.pbxproj:
loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): (WebCore::IconDatabase::syncDatabase):

1:46 PM Changeset in webkit [16039] by brmorris

1 edit
1 add in S60/trunk/S60Internals

2006-08-25 sareen <shyam.sareen@nokia.com>

Reviewed by Sachin, landed by Brad.
DESC: Added central repository files
http://bugzilla.opendarwin.org/show_bug.cgi?id=10567

S60CenResp.zip: Added.

12:23 PM Changeset in webkit [16038] by spadma

2 edits in S60/trunk/WebKit

2006-08-25 naguo <George.Guo@nokia.com>

Reviewed by Sachin.
DESC: The BrCtl should sent a keydown and keyup too for ECommandMakeCall
http://bugzilla.opendarwin.org/show_bug.cgi?id=10548

BrowserControl/src/BrCtl.cpp: (CBrCtl::HandleCommandL):

12:06 PM Changeset in webkit [16037] by spadma

2 edits in S60/trunk/WebKit

2006-08-25 sareen <shyam.sareen@nokia.com>

Reviewed by Sachin.
DESC: Set value as per cache configurable parameter
as per center repository.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10567

ResourceLoader/CacheSrc/HttpCacheManager.cpp: (CHttpCacheManager::CreateCacheHandlersL):

11:54 AM Changeset in webkit [16036] by zbujtas

6 edits
1 delete in S60/trunk/S60WebUi

2006-08-25 w3liu <wei.liu@nokia.com>

Reviewed by Zalan Bujtas

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10564
ifdefs of obslete flags should be removed for Reindeer UI.

ChangeLog:
HomePage/group/HomePage.mmp:
HomePage/src/DllEntryPoint.cpp: Removed
WebUi/group/WebUi.mmp:
WebUi/src/WebUiApp.cpp:
WebUi/src/WebUiObserver.cpp:
WebUi/src/WebUiSettings.cpp: (CWebUiSettings::NewL): (CWebUiSettings::ResetSettingsDbL): (CWebUiSettings::DoSettingsActionL): (CWebUiSettings::UpdateSettingDb): (CWebUiSettings::SetEngineSettingL): (CWebUiSettings::GetSettingByCRIdL): (CWebUiSettings::GetSettingByNameL): (CWebUiSettings::SetSettingByNameL):

11:23 AM Changeset in webkit [16035] by aroben

5 edits in trunk/WebCore

Reviewed/landed by Adam.

Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10561
Qt platform build fixes.

platform/qt/FrameQt.h:
platform/qt/ScreenQt.cpp: (WebCore::qwidgetForPage): (WebCore::screenRect): (WebCore::screenDepth): (WebCore::usableScreenRect):
platform/qt/TemporaryLinkStubs.cpp: (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome):
platform/qt/WidgetQt.cpp:

9:51 AM Changeset in webkit [16034] by aroben

4 edits in trunk/WebCore

Reviewed/landed by Adam.

Finally fix font caching. WebKit+Qt now works
out of the box without any further patches :-)

platform/qt/FontDataQt.cpp: (WebCore::FontData::platformDestroy):
platform/qt/FontPlatformData.h:
platform/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::isFixedPitch): (WebCore::FontPlatformData::font): (WebCore::FontPlatformData::fontPtr): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::operator==):

9:46 AM Changeset in webkit [16033] by aroben

20 edits in trunk/WebCore

Reviewed/landed by Adam.

Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10559
Confirm to WebKit style guide - last fixes :-)

platform/ResourceLoaderClient.h:
platform/qt/ComboBoxQt.cpp:
platform/qt/FrameQt.cpp: (WebCore::doScroll): (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::openURL): (WebCore::FrameQt::submitForm): (WebCore::FrameQt::setTitle): (WebCore::FrameQt::passSubframeEventToSubframe): (WebCore::FrameQt::registerCommandForUndo): (WebCore::FrameQt::registerCommandForRedo): (WebCore::FrameQt::keyEvent): (WebCore::FrameQt::setFrameGeometry):
platform/qt/GlyphMapQt.cpp: (WebCore::GlyphMap::fillPage):
platform/qt/GraphicsContextQt.cpp: (WebCore::toQtCompositionMode): (WebCore::toQtLineCap): (WebCore::toQtLineJoin): (WebCore::TextShadow::TextShadow): (WebCore::GraphicsContextPlatformPrivate::p):
platform/qt/ImageQt.cpp: (WebCore::FrameData::clear): (WebCore::Image::supportsType):
platform/qt/IntSizeQt.cpp:
platform/qt/LineEditQt.cpp:
platform/qt/ListBoxQt.cpp:
platform/qt/PageQt.cpp: (WebCore::Page::windowRect):
platform/qt/PathQt.cpp: (WebCore::Path::~Path):
platform/qt/ResourceLoaderCurl.cpp: (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::retrieveCharset): (WebCore::ResourceLoader::receivedResponse):
platform/qt/ResourceLoaderManager.cpp: (WebCore::headerCallback): (WebCore::ResourceLoaderManager::downloadTimerCallback): (WebCore::ResourceLoaderManager::add):
platform/qt/ScreenQt.cpp: (WebCore::screenRect): (WebCore::usableScreenRect):
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::ScrollView): (WebCore::ScrollView::~ScrollView): (WebCore::ScrollView::setParentWidget): (WebCore::ScrollView::addChild):
platform/qt/SharedTimerQt.cpp: (WebCore::setSharedTimerFiredFunction):
platform/qt/SharedTimerQt.h: (WebCore::SharedTimerQt::SharedTimerQt): (WebCore::SharedTimerQt::fire):
platform/qt/SystemTimeQt.cpp: (WebCore::currentTime):
platform/qt/TextEditQt.cpp: (WebCore::PlatformTextEdit::setParentWidget): (WebCore::PlatformTextEdit::text): (WebCore::PlatformTextEdit::sizeWithColumnsAndRows):

Aug 24, 2006:

9:04 PM Changeset in webkit [16032] by thatcher

2 edits in trunk/WebKitSite

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10444 Navigation links overlap the Spam Karma 2 footer

blog/wp-content/themes/webkit/style.css: Hide the footer altogether.

6:27 PM Changeset in webkit [22122] by sfalken

17 edits
3 adds in branches/WindowsMerge/WebKitWin

5:41 PM Changeset in webkit [16031] by thatcher

3 edits in trunk/WebKit

Reviewed by Darin.

WebView/WebFrame.m: (-[WebFrame _updateBackground]): reworded the comment about scroll view and setDrawsBackground:YES
WebView/WebView.m: (-[WebViewPrivate dealloc]): release the background color

5:32 PM Changeset in webkit [16030] by harrison

2 edits in trunk/WebCore

Reviewed by Justin.

Follow up for...
<rdar://problem/4471481> Represent misspellings in AXAttributedStringForTextMarkerRange

Fix bug I introduced in r15959.

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeValue:]): Use topDocument in case we are in a subframe (we want the start/end of the overall page).

4:50 PM Changeset in webkit [16029] by beidson

2 edits in trunk/WebCore

Reviewed by Alice

Fixed my previous checkin, which was pruning the users entire icon db on startup everytime

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::retainIconForPageURL): Bind the PageURL to argument 1, as SQL bindings are indexed to 1, not 0

4:32 PM Changeset in webkit [16028] by ggaren

17 edits in trunk/WebCore

4:22 PM Changeset in webkit [22121] by ggaren

8 edits in branches/WindowsMerge

4:09 PM Changeset in webkit [16027] by thatcher

13 edits in trunk

WebCore:

Reviewed by Hyatt.

Allow changing the background color WebCore draws under transparent page backgrounds.
No automated way to test. All tests pass, no performance regression.

bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setBaseBackgroundColor:]):
page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameView::baseBackgroundColor): (WebCore::FrameView::setBaseBackgroundColor):
page/FrameView.h:
rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended):
rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):

WebKit:

Reviewed by Hyatt.

WebView API to allow changing the background color that draws under transparent page backgrounds.

WebView/WebFrame.m: (-[WebFrame _makeDocumentView]): (-[WebFrame _updateBackground]):
WebView/WebFrameInternal.h:
WebView/WebFrameView.m: (-[WebFrameView drawRect:]):
WebView/WebView.m: (-[WebView setBackgroundColor:]): (-[WebView backgroundColor]): (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView setDrawsBackground:]):
WebView/WebViewPrivate.h:

3:07 PM Changeset in webkit [16026] by darin

81 edits
2 adds in trunk

LayoutTests:

Reviewed by Justin.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10169 REGRESSION: NativeTextArea: Text dragged from <input type=text> to textarea disappears

fast/forms/drag-into-textarea-expected.txt: Added.
fast/forms/drag-into-textarea.html: Added.

WebCore:

Reviewed by Justin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10169 REGRESSION: NativeTextArea: Text dragged from <input type=text> to textarea disappears
eliminate the EditCommandPtr class from editing; use PassRefPtr and RefPtr instead
other editing-related cleanup

Test: fast/forms/drag-into-textarea.html

bridge/mac/FrameMac.h: Changed EditCommandPtr parameters to use PassRefPtr<EditCommand> instead.
bridge/win/FrameWin.h: Ditto.
bridge/mac/FrameMac.mm: (WebCore::FrameMac::registerCommandForUndoOrRedo): Ditto. (WebCore::FrameMac::registerCommandForUndo): Ditto. (WebCore::FrameMac::registerCommandForRedo): Ditto.

bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): Use applyCommand instead of EditCommandPtr. Also remove now-unneeded document parameter. (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]): Ditto. (-[WebCoreFrameBridge deleteSelectionWithSmartDelete:]): Ditto.

editing/AppendNodeCommand.h: Removed document parameter from constructor. Changed new child parameter to be a PassRefPtr. Reversed order of child and parent parameters.
editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::AppendNodeCommand): Ditto. (WebCore::AppendNodeCommand::doApply): Ditto. (WebCore::AppendNodeCommand::doUnapply): Ditto.

editing/ApplyStyleCommand.h: Removed document parameter from constructor.
editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::ApplyStyleCommand): Ditto.

editing/BreakBlockquoteCommand.h: Removed unneeded include of DeprecatedPtrList.h.
editing/BreakBlockquoteCommand.cpp: Moved the include of DeprecatedPtrList.h here. (WebCore::BreakBlockquoteCommand::doApply): Changed code to construct a Selection explicitly since setEndingSelection is no longer overloaded for Position.

editing/CompositeEditCommand.h: Added isFirstCommand function. Changed m_cmds from a DeprecatedValueList<EditCommandPtr> to a Vector<RefPtr<EditCommand>> and renamed it m_commands and made both doUnapply and doReapply private.
editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::doUnapply): Rewrote to use m_commands. (WebCore::CompositeEditCommand::doReapply): Ditto. (WebCore::CompositeEditCommand::applyCommandToComposite): Removed code to explicitly set up starting and ending selection -- now done inside setParent. Rewrote to use m_commands. (WebCore::CompositeEditCommand::applyStyle): Changed to not use EditCommandPtr. (WebCore::CompositeEditCommand::applyStyledElement): Ditto. (WebCore::CompositeEditCommand::removeStyledElement): Ditto. (WebCore::CompositeEditCommand::insertParagraphSeparator): Ditto. (WebCore::CompositeEditCommand::insertNodeBefore): Ditto. (WebCore::CompositeEditCommand::appendNode): Ditto. (WebCore::CompositeEditCommand::removeNode): Ditto. (WebCore::CompositeEditCommand::removeNodePreservingChildren): Ditto. (WebCore::CompositeEditCommand::splitTextNode): Ditto. (WebCore::CompositeEditCommand::splitElement): Ditto. (WebCore::CompositeEditCommand::mergeIdenticalElements): Ditto. (WebCore::CompositeEditCommand::wrapContentsInDummySpan): Ditto. (WebCore::CompositeEditCommand::splitTextNodeContainingElement): Ditto. (WebCore::CompositeEditCommand::joinTextNodes): Ditto. (WebCore::CompositeEditCommand::inputText): Ditto. (WebCore::CompositeEditCommand::insertTextIntoNode): Ditto. (WebCore::CompositeEditCommand::deleteTextFromNode): Ditto. (WebCore::CompositeEditCommand::replaceTextInNode): Ditto. (WebCore::CompositeEditCommand::deleteSelection): Ditto. (WebCore::CompositeEditCommand::removeCSSProperty): Ditto. (WebCore::CompositeEditCommand::removeNodeAttribute): Ditto. Also fixed a bug where the code would not remove an empty attribute -- will not come up in practice, but wrong in theory. (WebCore::CompositeEditCommand::setNodeAttribute): Changed to not use EditCommandPtr. (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): Ditto. (WebCore::CompositeEditCommand::deleteInsignificantText): Rewrote to use a for loop. (WebCore::CompositeEditCommand::moveParagraphs): Changed to not use EditCommandPtr. (WebCore::CompositeEditCommand::breakOutOfEmptyListItem): Changed code to construct a Selection explicitly since setEndingSelection is no longer overloaded for Position. (WebCore::createBlockPlaceholderElement): Collapsed this code so that the block placeholder class string is no longer spread across multiple functions. Perhaps we can get rid of this altogether at some point.

editing/DeleteFromTextNodeCommand.h: Removed unneeded document parameter from one constructor. Also removed unneeded destructor.
editing/DeleteFromTextNodeCommand.cpp: (WebCore::DeleteFromTextNodeCommand::DeleteFromTextNodeCommand): Ditto.

editing/DeleteSelectionCommand.h: Removed unneeded document parameter from one constructor.
editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): Ditto.

editing/EditCommand.h: Removed ECommandState, isCompositeStep(), parent(), state(), setState(), and most overloads of setStartingSelection() and setEndingSelection(). Made document() protected and non-virtual. Made setStartingSelection() setEndingSelection(), and styleAtPosition() protected. Made doApply(), doUnapply(), and doReapply() private. Added startingRootEditableElement(), endingRootEditableElement(), m_startingRootEditableElement, and m_endingRootEditableElement, which are needed so we can determine which editable elements an editing operation affects. Changed setParent() and m_parent to use CompositeEditCommand instead of EditCommand. Removed EditCommandPtr. Added applyCommand() function that's convenient to use on a newly-created command.
editing/EditCommand.cpp: (WebCore::EditCommand::EditCommand): Removed initialization for m_state, and added it for starting and ending root editable elements. (WebCore::EditCommand::apply): Simplified check for top level by just checking m_parent. Removed code to assert and set m_start. Eliminated use of EditCommandPtr. (WebCore::EditCommand::unapply): Ditto. (WebCore::EditCommand::reapply): Ditto. (WebCore::EditCommand::setStartingSelection): Changed to set root editable element too. Also made this not change the starting selection of the parent unless this is the first command in the parent -- didn't make sense the way it was. (WebCore::EditCommand::setEndingSelection): Changed to set root editable element too. (WebCore::EditCommand::setParent): Added code to set the starting and ending selection on the child based on the ending selection of the parent, formerly done by callers. (WebCore::applyCommand): Added.

editing/FormatBlockCommand.h: Tweaked formatting.
editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::FormatBlockCommand): Ditto.
editing/InsertLineBreakCommand.h: Ditto.
editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::doApply):

editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::splitTreeToNode): Removed use of EditCommandPtr. (WebCore::IndentOutdentCommand::outdentParagraph): Updated for change to list type enum. (WebCore::IndentOutdentCommand::outdentRegion): Removed use of EditCommandPtr.

editing/InsertIntoTextNodeCommand.h: Removed unneeded document parameter to constructor.
editing/InsertIntoTextNodeCommand.cpp: (WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand): Ditto.

editing/InsertListCommand.h: Renamed EListType to EList, and took the "Type" suffix off the constants.
editing/InsertListCommand.cpp: (WebCore::InsertListCommand::InsertListCommand): Ditto. (WebCore::InsertListCommand::doApply): Ditto.

editing/InsertNodeBeforeCommand.h: Removed unneeded document parameter from constructor and changed the parameter of the node to insert to a PassRefPtr.
editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::InsertNodeBeforeCommand): Ditto.

editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Remvoed use of EditCommandPtr.

editing/InsertTextCommand.h: Changed insertTab to take const Position&.
editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Ditto. (WebCore::InsertTextCommand::insertTab): Ditto.

editing/JSEditor.h: Tweaked formatting and names.
editing/JSEditor.cpp: Ditto. Also changed places that use EditCommandPtr.

editing/JoinTextNodesCommand.h: Removed unneeeded document pointer
editing/JoinTextNodesCommand.cpp: (WebCore::JoinTextNodesCommand::JoinTextNodesCommand): Ditto.
editing/MergeIdenticalElementsCommand.h: Ditto.
editing/MergeIdenticalElementsCommand.cpp: (WebCore::MergeIdenticalElementsCommand::MergeIdenticalElementsCommand): Ditto.

editing/ModifySelectionListLevel.h: Changed EListType to be named Type and be a member of IncreaseSelectionListLevelCommand. Also changed m_listElement to be a RefPtr<Node>.
editing/ModifySelectionListLevel.cpp: (WebCore::getStartEndListChildren): Changed parameters to be references instead of pointers. (WebCore::IncreaseSelectionListLevelCommand::IncreaseSelectionListLevelCommand): Changed to use Type instead of EListType. (WebCore::canIncreaseListLevel): Changed parameters to be references instead of pointers. (WebCore::IncreaseSelectionListLevelCommand::doApply): Updated for change to canIncreaseListLevel. (WebCore::IncreaseSelectionListLevelCommand::canIncreaseSelectionListLevel): Ditto. (WebCore::IncreaseSelectionListLevelCommand::increaseSelectionListLevelWithType): Changed to not use EditCommandPtr. (WebCore::canDecreaseListLevel): Changed parameters to be references instead of pointers. (WebCore::DecreaseSelectionListLevelCommand::doApply): Updated for change to canDecreaseListLevel. (WebCore::DecreaseSelectionListLevelCommand::canDecreaseSelectionListLevel): Ditto. (WebCore::DecreaseSelectionListLevelCommand::decreaseSelectionListLevel): Changed to not use EditCommandPtr.

editing/MoveSelectionCommand.h: Removed unnecessary document parameter and changed the fragment parameter to be a PassRefPtr.
editing/MoveSelectionCommand.cpp: (WebCore::MoveSelectionCommand::MoveSelectionCommand): Ditto. (WebCore::MoveSelectionCommand::doApply): Got rid of use of EditCommandPtr.

editing/RebalanceWhitespaceCommand.h: Removed unnecessary document parameter.
editing/RebalanceWhitespaceCommand.cpp: (WebCore::RebalanceWhitespaceCommand::RebalanceWhitespaceCommand): Ditto. (WebCore::RebalanceWhitespaceCommand::doApply): Got rid of use of EditCommandPtr.

editing/RemoveCSSPropertyCommand.h: Tweaked formatting.

editing/RemoveNodeAttributeCommand.h: Removed unnecessary document parameter.
editing/RemoveNodeAttributeCommand.cpp: (WebCore::RemoveNodeAttributeCommand::RemoveNodeAttributeCommand): Ditto.

editing/RemoveNodeCommand.h: Removed unnecessary document parameter.
editing/RemoveNodeCommand.cpp: (WebCore::RemoveNodeCommand::RemoveNodeCommand): Ditto.

editing/RemoveNodePreservingChildrenCommand.h: Removed unnecessary document parameter.
editing/RemoveNodePreservingChildrenCommand.cpp: (WebCore::RemoveNodePreservingChildrenCommand::RemoveNodePreservingChildrenCommand): Ditto.

editing/ReplaceSelectionCommand.h: Change fragment parameter to a PassRefPtr.
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): Ditto. (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand): Ditto. (WebCore::ReplaceSelectionCommand::doApply): Ditto. (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Ditto.

editing/Selection.h: Changed SEL_DEFAULT_AFFINITY to be a constant rather than a macro. Added constructors that take visible positions. Changed setBase and setExtent to take const Position& for better efficiency.
editing/Selection.cpp: (WebCore::Selection::Selection): Removed unnecessary double initialization of m_state and m_baseIsFirst in existing constructors. Added VisiblePosition-based constructors.

editing/SetNodeAttributeCommand.h: Removed unnneeded document parameter.
editing/SetNodeAttributeCommand.cpp: (WebCore::SetNodeAttributeCommand::SetNodeAttributeCommand): Ditto.

editing/SplitElementCommand.h: Removed unnneeded document parameter.
editing/SplitElementCommand.cpp: (WebCore::SplitElementCommand::SplitElementCommand): Ditto.

editing/SplitTextNodeCommand.h: Removed unnneeded document parameter.
editing/SplitTextNodeCommand.cpp: (WebCore::SplitTextNodeCommand::SplitTextNodeCommand): Ditto.

editing/SplitTextNodeContainingElementCommand.h: Removed unnneeded document parameter.
editing/SplitTextNodeContainingElementCommand.cpp: (WebCore::SplitTextNodeContainingElementCommand::SplitTextNodeContainingElementCommand): Ditto.

editing/TypingCommand.h: Replaced uses of EditCommandPtr with EditCommand*. Renamed openForMoveTyping() with isOpenForMoreTyping().
editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteKeyPressed): Updated to remove use of EditCommandPtr. (WebCore::TypingCommand::forwardDeleteKeyPressed): Ditto. (WebCore::TypingCommand::insertText): Ditto. (WebCore::TypingCommand::insertLineBreak): Ditto. (WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent): Ditto. (WebCore::TypingCommand::insertParagraphSeparator): Ditto. (WebCore::TypingCommand::isOpenForMoreTypingCommand): Ditto. (WebCore::TypingCommand::closeTyping): Ditto. (WebCore::TypingCommand::typingAddedToOpenCommand): Ditto. (WebCore::TypingCommand::insertTextRunWithoutNewlines): Ditto.

editing/WrapContentsInDummySpanCommand.h: Removed unnneeded document parameter.
editing/WrapContentsInDummySpanCommand.cpp: (WebCore::WrapContentsInDummySpanCommand::WrapContentsInDummySpanCommand): Ditto.

editing/htmlediting.h: Changed type of NON_BREAKING_SPACE to UChar instead of unsigned short.

page/Frame.h: Changed lastEditCommand() to return an EditCommand* and changed appliedEditing(), unappliedEditing(), reappliedEditing(), registerCommandForUndo(), and registerCommandForRedo() to take PassRefPtr<EditCommand>.
page/FramePrivate.h: Changed m_lastEditCommand to be a RefPtr<EditCommand>.
page/Frame.cpp: (WebCore::Frame::didOpenURL): Fixed for change to m_lastEditCommand. (WebCore::Frame::setFocusNodeIfNeeded): Call the rootEditableElement function from Selection to simplify the code. (WebCore::Frame::selectAll): Ditto. (WebCore::Frame::lastEditCommand): Updated for change to m_lastEditCommand. (WebCore::dispatchEditableContentChangedEvents): Added. This sends an event to both of the root editable elements involved in a change -- the start selection might be in a different element than the end selection. (WebCore::Frame::appliedEditing): Changed to call dispatchEditableContentChangedEvents, and to do it before setting the ending selection. Also update to use PassRefPtr instead of EditCommandPtr and change the order of setting m_lastEditCommand since passing it to registerCommandForUndo will take ownership and set it to 0. (WebCore::Frame::unappliedEditing): Ditto. (WebCore::Frame::reappliedEditing): Ditto. (WebCore::Frame::computeAndSetTypingStyle): Updated for removal of EditCommandPtr. (WebCore::Frame::applyStyle): Ditto. (WebCore::Frame::applyParagraphStyle): Ditto.

platform/gdk/FrameGdk.h: Updated for above changes.
platform/gdk/TemporaryLinkStubs.cpp: Updated for above changes.
platform/win/TemporaryLinkStubs.cpp: Updated for above changes.

2:41 PM Changeset in webkit [22120] by ggaren

2 edits
1 add in branches/WindowsMerge/WebCore

Reviewed by Hyatt.

Branching PageWin.cpp from r15969.

WebCore.vcproj/WebCore.vcproj:
bridge/win/PageWin.cpp: Added. (WebCore::Page::Page): (WebCore::Page::windowRect): (WebCore::Page::setWindowRect):

2:39 PM Changeset in webkit [16025] by spadma

5 edits in S60/trunk

2006-08-24 sareen <shyam.sareen@nokia.com>

Reviewed by Sachin.
Change the name of the data member iVodaphoneCache.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10430

ResourceLoader/CacheInc/HttpCacheManager.h:
ResourceLoader/CacheSrc/HttpCacheManager.cpp: (CHttpCacheManager::~CHttpCacheManager): (CHttpCacheManager::RequestL): (CHttpCacheManager::ReceivedResponseHeadersL): (CHttpCacheManager::Find): (CHttpCacheManager::CreateCacheHandlersL): (CHttpCacheManager::CacheHandler):

2:04 PM Changeset in webkit [16024] by zbujtas

5 edits in S60/trunk

2006-08-24 bujtas <zbujtas@gmail.com>

Reviewed by Yongjun.

check for null when the ustring is expanded

kjs/ustring.cpp: (KJS::UChar::toLower): (KJS::UChar::toUpper): (KJS::UString::Rep::computeHash): (KJS::UString::expandCapacity): (KJS::UString::UString): (KJS::UString::from): (KJS::UString::append): (KJS::UString::ascii): (KJS::UString::toDouble): (KJS::UString::toStrictUInt32): (KJS::operator==):
kjs/ustring.h:

2:01 PM Changeset in webkit [16023] by spadma

2 edits in S60/trunk/WebKit

2006-08-24 ligman <joseph.ligman@nokia.com>

Reviewed by Sachin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10545
Application crashing with unhandled exception when exiting/destructing. This is caused when
LoadFaviconL leaves but is not handled in CWebKitBridge::DocumentComplete. Introduce
a TRAP_IGNORE to catch the leave. The leave is caused by lack of memory when trying to create
a CUrlRequestInfo.

BrowserView/src/webkitbridge.cpp: (CWebKitBridge::DocumentComplete):

1:18 PM Changeset in webkit [16022] by rwlbuis

2 edits
3 adds in trunk

Reviewed by Eric. Landed by rwlbuis.

Add QtLauncher (was testunity before), which provides a
standalone "browser" to test the Qt platform stuff.

1:10 PM Changeset in webkit [16021] by zbujtas

2 edits in S60/trunk/WebCore

2006-08-22 ligman <joseph.ligman@nokia.com>

Reviewed by Zalan Bujtas.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10461
Each character is saved as two bytes, but the charset was not being set to ucs-2. This
caused some saved pages with single byte encoding to load improperly. To fix set
the character set to ucs-2 before saving the page.

WARNING: NO TEST CASES ADDED OR CHANGED

bridge/WebCoreBridge.cpp: (CWebCoreBridge::GetPageDataL):

1:10 PM Changeset in webkit [16020] by beidson

5 edits in trunk/WebCore

Reviewed by Alice

<rdar://problem/4697973> - Unacceptable delay on startup
<rdar://problem/4690949> - Need to correctly prune unretained pageurls and icons on startup

This patch was started by me and finished by Mark Rowe - we now special case all retains during
startup into one huge sql transaction. Also we track PageURL retains instead of IconURLs so pruning works right.
Testing with reasonable sets of bookmarks/history (3000), startup time is neglibile. Testing with a huge set of
bookmarks (40,000), startup has a noticable delay, but reasonable, and is inline with shipping safari which also
has a noticeable delay.

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::open): adding an initialStartupTransaction and pageRetainStatement (WebCore::IconDatabase::close): do cleanup on the initialStartupSQL stuff (WebCore::IconDatabase::retainIconForPageURL): Track initial PageURL retains in the temporary table (WebCore::IconDatabase::releaseIconForPageURL): Ditto (WebCore::IconDatabase::retainIconURL): We no longer special case this on startup (WebCore::IconDatabase::releaseIconURL): We no longer special case this on startup (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Handle the big transaction correctly and quickly (WebCore::IconDatabase::syncDatabase): Change the timing log message
loader/icon/IconDatabase.h:
loader/icon/SQLStatement.cpp: (WebCore::SQLStatement::bindText16): Added this - for reusing commonly used statements by just rebinding parameters.
loader/icon/SQLStatement.h:

12:56 PM Changeset in webkit [16019] by thatcher

2 edits in trunk/WebKit

Reviewed by Darin.

Fix for Mail stationary. Selecting a stationary item would cause this exception.
* -[WebSubresourceLoader copyWithZone:]: selector not recognized
Uncaught exception - * -[WebSubresourceLoader copyWithZone:]: selector not recognized

Loader/WebFrameLoader.m: (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]): Use _webkit_setObject:forUncopiedKey: when addign the resource to pendingArchivedResources.

12:54 PM Changeset in webkit [16018] by rwlbuis

1 add in trunk/WebCore/platform/qt/qt-encodings.txt

This file was listed in a previous ChangeLog, but not actually committed, fixing.

12:15 PM Changeset in webkit [16017] by brmorris

2 edits in S60/trunk/S60Tools

2006-08-24 brmorris <bradley.morrison@nokia.com>

Reviewed by Zalan.
Update ChangeLog entry template
http://bugzilla.opendarwin.org/show_bug.cgi?id=10544

prepare-ChangeLog.bat: Template contains DESC and Bugzilla Url

11:50 AM Changeset in webkit [16016] by aroben

10 edits in trunk/WebCore

Reviewed/landed by Adam.

Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support

CMakeLists.txt:

Remove KCanvasMatrix.cpp because it no longer exists
Remove platform/qt/test

platform/FloatSize.h:
platform/image-decoders/bmp/BMPImageDecoder.cpp:
platform/image-decoders/gif/GIFImageDecoder.cpp:
platform/image-decoders/gif/GIFImageReader.cpp:
platform/image-decoders/ico/ICOImageDecoder.cpp:
platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
platform/image-decoders/png/PNGImageDecoder.cpp:
platform/image-decoders/xbm/XBMImageDecoder.cpp:

Added PLATFORM(QT) hooks in the image-decoders/, as they also need
to work for Qt, not only for Cairo.

platform/qt/qt-encodings.txt: Added (required for build).

11:35 AM Changeset in webkit [16015] by aroben

2 edits in trunk/WebCore

Fixing a typo from last patch.

11:32 AM Changeset in webkit [16014] by aroben

32 edits in trunk/WebCore

Reviewed/landed by Adam.

Final cleanup to conform to WebKit coding style!

10:02 AM Changeset in webkit [16013] by andersca

3 edits
4 adds in trunk/WebCore

2006-08-24 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed and landed by Anders.

Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support

CMakeLists.txt:
platform/qt/FrameQt.cpp: Added. (WebCore::doScroll): (WebCore::FrameView::isFrameView): (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::init): (WebCore::FrameQt::~FrameQt): (WebCore::FrameQt::openURL): (WebCore::FrameQt::submitForm): (WebCore::FrameQt::urlSelected): (WebCore::FrameQt::userAgent): (WebCore::FrameQt::runJavaScriptAlert): (WebCore::FrameQt::runJavaScriptConfirm): (WebCore::FrameQt::locationbarVisible): (WebCore::FrameQt::setTitle): (WebCore::FrameQt::createFrame): (WebCore::FrameQt::passWheelEventToChildWidget): (WebCore::FrameQt::passSubframeEventToSubframe): (WebCore::FrameQt::objectContentType): (WebCore::FrameQt::createPlugin): (WebCore::FrameQt::passMouseDownEventToWidget): (WebCore::FrameQt::menubarVisible): (WebCore::FrameQt::personalbarVisible): (WebCore::FrameQt::statusbarVisible): (WebCore::FrameQt::toolbarVisible): (WebCore::FrameQt::createEmptyDocument): (WebCore::FrameQt::markedTextRange): (WebCore::FrameQt::incomingReferrer): (WebCore::FrameQt::mimeTypeForFileName): (WebCore::FrameQt::markMisspellingsInAdjacentWords): (WebCore::FrameQt::markMisspellings): (WebCore::FrameQt::lastEventIsMouseUp): (WebCore::FrameQt::saveDocumentState): (WebCore::FrameQt::restoreDocumentState): (WebCore::FrameQt::openURLRequest): (WebCore::FrameQt::scheduleClose): (WebCore::FrameQt::unfocusWindow): (WebCore::FrameQt::focusWindow): (WebCore::FrameQt::overrideMediaType): (WebCore::FrameQt::addMessageToConsole): (WebCore::FrameQt::runJavaScriptPrompt): (WebCore::FrameQt::getEmbedInstanceForWidget): (WebCore::FrameQt::getObjectInstanceForWidget): (WebCore::FrameQt::getAppletInstanceForWidget): (WebCore::FrameQt::registerCommandForUndo): (WebCore::FrameQt::registerCommandForRedo): (WebCore::FrameQt::clearUndoRedoOperations): (WebCore::FrameQt::issueUndoCommand): (WebCore::FrameQt::issueRedoCommand): (WebCore::FrameQt::issueCutCommand): (WebCore::FrameQt::issueCopyCommand): (WebCore::FrameQt::issuePasteCommand): (WebCore::FrameQt::issuePasteAndMatchStyleCommand): (WebCore::FrameQt::issueTransposeCommand): (WebCore::FrameQt::respondToChangedSelection): (WebCore::FrameQt::respondToChangedContents): (WebCore::FrameQt::shouldChangeSelection): (WebCore::FrameQt::partClearedInBegin): (WebCore::FrameQt::canGoBackOrForward): (WebCore::FrameQt::handledOnloadEvents): (WebCore::FrameQt::canPaste): (WebCore::FrameQt::canRedo): (WebCore::FrameQt::canUndo): (WebCore::FrameQt::print): (WebCore::FrameQt::shouldInterruptJavaScript): (WebCore::FrameQt::keyEvent): (WebCore::FrameQt::receivedResponse): (WebCore::FrameQt::receivedData): (WebCore::FrameQt::receivedAllData): (WebCore::FrameQt::setFrameGeometry):
platform/qt/FrameQt.h: Added.
platform/qt/ScrollViewCanvasQt.cpp: Added. (WebCore::ScrollViewCanvasQt::ScrollViewCanvasQt): (WebCore::ScrollViewCanvasQt::paintEvent): (WebCore::ScrollViewCanvasQt::sizeHint): (WebCore::ScrollViewCanvasQt::mouseMoveEvent): (WebCore::ScrollViewCanvasQt::mousePressEvent): (WebCore::ScrollViewCanvasQt::mouseReleaseEvent): (WebCore::ScrollViewCanvasQt::keyPressEvent): (WebCore::ScrollViewCanvasQt::keyReleaseEvent): (WebCore::ScrollViewCanvasQt::handleKeyEvent):
platform/qt/ScrollViewCanvasQt.h: Added.
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::setParentWidget):

9:49 AM Changeset in webkit [16012] by ap

1 edit
6 adds in trunk/WebCore

Reviewed by ap.

Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support

platform/qt/FontCacheQt.cpp: Added. (WebCore::FontCache::platformInit): (WebCore::FontCache::getFontDataForCharacters): (WebCore::FontCache::getSimilarFontPlatformData): (WebCore::FontCache::getLastResortFallbackFont): (WebCore::FontCache::createFontPlatformData):
platform/qt/FontDataQt.cpp: Added. (WebCore::FontData::platformInit): (WebCore::FontData::platformDestroy): (WebCore::FontData::smallCapsFontData): (WebCore::FontData::containsCharacters): (WebCore::FontData::determinePitch): (WebCore::FontData::platformWidthForGlyph):
platform/qt/FontPlatformData.h: Added.
platform/qt/FontPlatformDataQt.cpp: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::operator=): (WebCore::FontPlatformData::~FontPlatformData): (WebCore::FontPlatformData::isFixedPitch): (WebCore::FontPlatformData::setFont): (WebCore::FontPlatformData::font): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::operator==):
platform/qt/FontQt.cpp: Added. (WebCore::Font::operator QFont): (WebCore::Font::drawGlyphs): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText):
platform/qt/GlyphMapQt.cpp: Added. (WebCore::GlyphMap::fillPage):

9:40 AM Changeset in webkit [16011] by harrison

51 edits in trunk

LayoutTests:

Updated expected results for this change:

<rdar://problem/4522205> Represent controls in AXAttributedStringForTextMarkerRange

editing/selection/anchor-focus1-expected.txt:
editing/selection/anchor-focus2-expected.txt:
editing/selection/anchor-focus3-expected.txt:
editing/selection/move-begin-end-expected.txt:
fast/dom/Element/onclick-case-expected.txt:
fast/dom/HTMLInputElement/size-as-number-expected.txt:
fast/dom/document-all-input-expected.txt:
fast/dom/option-properties-expected.txt:
fast/events/objc-keyboard-event-creation-expected.txt:
fast/events/onsubmit-bubbling-expected.txt:
fast/forms/access-key-expected.txt:
fast/forms/activate-and-disabled-elements-expected.txt:
fast/forms/button-in-forms-collection-expected.txt:
fast/forms/check-box-enter-key-expected.txt:
fast/forms/cursor-position-expected.txt:
fast/forms/display-none-in-onchange-keyboard-expected.txt:
fast/forms/domstring-replace-crash-expected.txt:
fast/forms/double-focus-expected.txt:
fast/forms/element-by-name-expected.txt:
fast/forms/empty-get-expected.txt:
fast/forms/focus-expected.txt:
fast/forms/form-get-multipart-expected.txt:
fast/forms/form-get-multipart2-expected.txt:
fast/forms/form-get-multipart3-expected.txt:
fast/forms/form-post-urlencoded-expected.txt:
fast/forms/input-appearance-elementFromPoint-expected.txt:
fast/forms/input-appearance-maxlength-expected.txt:
fast/forms/input-changing-value-expected.txt:
fast/forms/input-delete-expected.txt:
fast/forms/input-selection-hidden-expected.txt:
fast/forms/input-selection-restore-expected.txt:
fast/forms/input-text-enter-expected.txt:
fast/forms/input-truncate-newline-expected.txt:
fast/forms/legend-access-key-expected.txt:
fast/forms/onchange-enter-submit-expected.txt:
fast/forms/onselect-textarea-expected.txt:
fast/forms/onselect-textfield-expected.txt:
fast/forms/paste-into-textarea-expected.txt:
fast/forms/plaintext-mode-1-expected.txt:
fast/forms/select-remove-option-expected.txt:
fast/forms/select-replace-option-expected.txt:
fast/forms/select-reset-expected.txt:
fast/forms/selection-functions-expected.txt:
fast/forms/text-field-setvalue-crash-expected.txt:
fast/forms/textarea-crlf-expected.txt:
fast/forms/textarea-scrolled-endline-caret-expected.txt:
fast/forms/textarea-setvalue-submit-expected.txt:
fast/forms/textfield-focus-out-expected.txt:

WebCore:

Reinstate r15966 because layout test changes are correct.

<rdar://problem/4522205> Represent controls in AXAttributedStringForTextMarkerRange

editing/TextIterator.cpp: (WebCore::TextIterator::advance):

9:25 AM Changeset in webkit [16010] by ap

4 edits in trunk/WebCore

Reviewed by ap.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support (Part II)

Adapt the KCanvas Qt device to Rob's KCanvasMatrix removal.
Use AffineTransform everywhere instead.

kcanvas/device/qt/KRenderingDeviceQt.cpp: (WebCore::KRenderingDeviceContextQt::KRenderingDeviceContextQt): (WebCore::KRenderingDeviceContextQt::concatCTM): (WebCore::KRenderingDeviceContextQt::ctm):
kcanvas/device/qt/KRenderingDeviceQt.h:
kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp: (WebCore::KRenderingPaintServerLinearGradientQt::setup): (WebCore::KRenderingPaintServerRadialGradientQt::setup):

9:19 AM Changeset in webkit [16009] by ap

3 edits in trunk/JavaScriptCore

Reviewed, tweaked and landed by ap

http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support (Part II)

CMakeLists.txt: Adjust to Anders' build fixes.
wtf/Platform.h: Fix define for the Qt platform (we don't use/need Cairo.)

3:04 AM Changeset in webkit [16008] by rwlbuis

3 edits
4 adds in trunk

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10524
svg transform: comma delimiting breaks display

Properly parse transforms which use ',' as seperators.

12:12 AM Changeset in webkit [16007] by mjs

3 edits in trunk/WebKit

Reviewed by Adele.

fix assertion which I accidentally changed to one that sometimes fails http://bugzilla.opendarwin.org/show_bug.cgi?id=10531

Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState dealloc]):
WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource dealloc]):

Aug 23, 2006:

11:22 PM Changeset in webkit [16006] by mjs

7 edits in trunk/WebKit

Reviewed by Brady.

move WebFrame code that creates WebDataSources down to WebFrameLoader, in preparation for WebFrameLoader just holding on to WebDocumentLoadState

Loader/WebFrameLoader.h:
Loader/WebFrameLoader.m: (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]):
WebView/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _shouldReloadToHandleUnreachableURLFromRequest:]): (-[WebFrame loadRequest:]): (-[WebFrame loadArchive:]): (-[WebFrame reload]):
WebView/WebFrameInternal.h:
WebView/WebFramePrivate.h:
WebView/WebView.m: (-[WebView setCustomTextEncodingName:]):

10:59 PM Changeset in webkit [16005] by beidson

5 edits in trunk/WebKit

Reviewed by Maciej

First pass at pruning unused WebIconDatabase code. Focus on removing methods that simply
have no place in the new DB at all. A few renames and a few important FIXMEs result, but no
functionality changes.

Loader/WebIconLoader.m: (-[WebIconLoader didFinishLoading]): Call to WebIconDatabase instead of directly to the bridge
Misc/WebIconDatabase.h:
Misc/WebIconDatabase.m: (-[WebIconDatabase init]): (-[WebIconDatabase iconForURL:withSize:cache:]): (-[WebIconDatabase iconURLForURL:]): (-[WebIconDatabase defaultIconWithSize:]): (-[WebIconDatabase retainIconForURL:]): (-[WebIconDatabase releaseIconForURL:]): (-[WebIconDatabase removeAllIcons]): (-[WebIconDatabase _setIconData:forIconURL:]): (-[WebIconDatabase _setHaveNoIconForIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _hasEntryForIconURL:]): (-[WebIconDatabase _applicationWillTerminate:]): (-[WebIconDatabase _resetCachedWebPreferences:]):
Misc/WebIconDatabasePrivate.h: Changed setIcon: to setIconData:

9:15 PM Changeset in webkit [16004] by mjs

4 edits
2 adds in trunk/WebKit

Reviewed by Adele.

started factoring most of the guts of WebDataSource into a new class

WebDocumentLoadState is decoupled from the rest of WebKit and will
be moved down to WebCore. I only moved one of the data fields of
WebDataSource for now.

Loader/WebDocumentLoadState.h: Added.
Loader/WebDocumentLoadState.m: Added. (-[WebDocumentLoadState initWithRequest:]): New class. (-[WebDocumentLoadState dealloc]): (-[WebDocumentLoadState setFrameLoader:]): (-[WebDocumentLoadState setMainResourceData:]): (-[WebDocumentLoadState mainResourceData]):
Loader/WebFrameLoader.m: (-[WebFrameLoader _setDataSource:]): Remove redundant _setWebFrame: call, it would have been called already by this point. (-[WebFrameLoader _setProvisionalDataSource:]): ditto.
WebKit.xcodeproj/project.pbxproj:
WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _setWebFrame:]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource initWithRequest:]): (-[WebDataSource data]):

6:28 PM Changeset in webkit [16003] by mjs

3 edits in trunk/WebKit

Reviewed by Adele.

refactoring of WebDataSource in preparation for moving a bunch of it to a new class

minimize WebDataSourceInternal.h to be only methods called from outside WebDataSource
reduce Private category implementation to be only the SPI methods
make new Internal and FileInternal categories which contain the remainder (depending on whether they are called from outside of WebDataSource)

WebView/WebDataSource.m: (-[WebDataSource _setMainDocumentError:]): (addTypesFromClass): (+[WebDataSource _representationClassForMIMEType:]): (-[WebDataSource _commitIfReady]): (-[WebDataSource _commitLoadWithData:]): (-[WebDataSource _doesProgressiveLoadWithMIMEType:]): (-[WebDataSource _addResponse:]): (-[WebDataSource _revertToProvisionalState]): (-[WebDataSource _mainDocumentError]): (-[WebDataSource _addSubframeArchives:]): (-[WebDataSource _fileWrapperForURL:]): (+[WebDataSource _repTypesAllowImageTypeOmission:]): (-[WebDataSource _decidePolicyForMIMEType:decisionListener:]): (-[WebDataSource _finishedLoading]): (-[WebDataSource _setResponse:]): (-[WebDataSource _setRequest:]): (-[WebDataSource _setupForReplaceByMIMEType:]): (-[WebDataSource _receivedMainResourceError:complete:]): (-[WebDataSource _mainReceivedError:complete:]): (-[WebDataSource _defersCallbacks]): (-[WebDataSource _downloadWithLoadingConnection:request:response:proxy:]): (-[WebDataSource _didFailLoadingWithError:forResource:]): (-[WebDataSource _didFinishLoadingForResource:]): (-[WebDataSource _didReceiveData:contentLength:forResource:]): (-[WebDataSource _didReceiveResponse:forResource:]): (-[WebDataSource _didCancelAuthenticationChallenge:forResource:]): (-[WebDataSource _didReceiveAuthenticationChallenge:forResource:]): (-[WebDataSource _willSendRequest:forResource:redirectResponse:]): (-[WebDataSource _identifierForInitialRequest:]): (-[WebDataSource _archivedSubresourceForURL:]): (-[WebDataSource _startLoading]): (-[WebDataSource _stopRecordingResponses]): (-[WebDataSource _loadingStartedTime]): (-[WebDataSource _replaceSelectionWithArchive:selectReplacement:]): (-[WebDataSource _documentFragmentWithArchive:]): (-[WebDataSource _documentFragmentWithImageResource:]): (-[WebDataSource _imageElementWithImageResource:]): (-[WebDataSource _title]): (-[WebDataSource _isStopping]): (-[WebDataSource _setWebFrame:]): (-[WebDataSource _URL]): (-[WebDataSource _loadFromPageCache:]): (-[WebDataSource _popSubframeArchiveWithName:]): (-[WebDataSource _setIsClientRedirect:]): (-[WebDataSource _setURL:]): (-[WebDataSource _setLastCheckedRequest:]): (-[WebDataSource _defersCallbacksChanged]): (-[WebDataSource _lastCheckedRequest]): (-[WebDataSource _stopLoading]): (-[WebDataSource _bridge]): (-[WebDataSource _webView]): (-[WebDataSource _triggeringAction]): (-[WebDataSource _setTriggeringAction:]): (-[WebDataSource __adoptRequest:]): (-[WebDataSource _isDocumentHTML]): (-[WebDataSource _stopLoadingWithError:]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource _responses]): (-[WebDataSource _makeRepresentation]): (-[WebDataSource _isClientRedirect]): (-[WebDataSource _originalRequest]): (-[WebDataSource _URLForHistory]): (-[WebDataSource _addToUnarchiveState:]): (-[WebDataSource _setOverrideEncoding:]): (-[WebDataSource _setIconURL:]): (-[WebDataSource _setIconURL:withType:]): (-[WebDataSource _overrideEncoding]): (-[WebDataSource _setTitle:]):
WebView/WebDataSourceInternal.h:

6:01 PM Changeset in webkit [16002] by hyatt

1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Fix Mac bustage.

5:38 PM Changeset in webkit [16001] by darin

2 edits in trunk/WebCore

Reviewed by Maciej.

added an assert to make it slightly easier to debug the common case of calling document() on a node of 0

dom/Node.h: (WebCore::Node::document): ASSERT(this).

5:04 PM Changeset in webkit [16000] by hyatt

3 edits in trunk/JavaScriptCore

Fix Platform.h to include #defines for graphics features.

Reviewed by darin

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
wtf/Platform.h:

5:02 PM Changeset in webkit [15999] by hyatt

41 edits
7 copies
3 moves
1 add in trunk/WebCore

Refactor Cairo and CoreGraphics to use platform ifdefs. This patch
separates the graphics engines from their respective platforms and replaces
#ifdef PLATFORM(MAC) and PLATFORM(WIN) with PLATFORM(CG) and PLATFORM(CAIRO).

Reviewed by darin

WebCore.xcodeproj/project.pbxproj:
platform/AffineTransform.h:
platform/Color.h:
platform/Cursor.h:
platform/FloatPoint.h:
platform/FloatRect.h:
platform/FloatSize.h:
platform/Font.h:
platform/FontData.h:
platform/GlyphBuffer.h: (WebCore::GlyphBuffer::glyphAt): (WebCore::GlyphBuffer::advanceAt): (WebCore::GlyphBuffer::add):
platform/GraphicsContext.h:
platform/Image.h:
platform/ImageSource.h:
platform/IntPoint.h:
platform/IntRect.h:
platform/IntSize.h:
platform/ResourceLoader.h:
platform/ResourceLoaderClient.h:
platform/Widget.h:
platform/cairo/GraphicsContextCairo.cpp:
platform/cairo/ImageCairo.cpp:
platform/cairo/ImageSourceCairo.cpp:
platform/cg/AffineTransformCG.cpp:
platform/cg/FloatPointCG.cpp: Added.
platform/cg/FloatRectCG.cpp: Added.
platform/cg/FloatSizeCG.cpp: Added.
platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::GraphicsContext): (WebCore::GraphicsContext::~GraphicsContext): (WebCore::GraphicsContext::setFocusRingClip): (WebCore::GraphicsContext::clearFocusRingClip): (WebCore::GraphicsContext::platformContext): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine):
platform/cg/GraphicsContextPlatformPrivate.h: Added. (WebCore::GraphicsContextPlatformPrivate:::m_cgContext): (WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
platform/cg/ImageCG.cpp: Added. (WebCore::Image::drawTiled):
platform/cg/ImageSourceCG.cpp: Added.
platform/cg/IntPointCG.cpp: Added.
platform/cg/IntRectCG.cpp: Added.
platform/cg/IntSizeCG.cpp: Added.
platform/cg/PDFDocumentImage.cpp: Added. (WebCore::PDFDocumentImage::adjustCTM):
platform/cg/PDFDocumentImage.h: Added.
platform/cg/PathCG.cpp:
platform/image-decoders/bmp/BMPImageDecoder.cpp:
platform/image-decoders/gif/GIFImageDecoder.cpp:
platform/image-decoders/gif/GIFImageReader.cpp:
platform/image-decoders/ico/ICOImageDecoder.cpp:
platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
platform/image-decoders/png/PNGImageDecoder.cpp:
platform/image-decoders/xbm/XBMImageDecoder.cpp:
platform/mac/FloatPointMac.mm:
platform/mac/FloatRectMac.mm:
platform/mac/FloatSizeMac.mm:
platform/mac/GraphicsContextMac.mm:
platform/mac/ImageMac.mm:
platform/mac/ImageSourceMac.cpp: Removed.
platform/mac/IntPointMac.mm:
platform/mac/IntRectMac.mm:
platform/mac/IntSizeMac.mm:
platform/mac/PDFDocumentImage.h: Removed.
platform/mac/PDFDocumentImage.mm: Removed.

4:54 PM Changeset in webkit [22119] by adachan

2 edits in branches/WindowsMerge/WebKitWin

4:46 PM Changeset in webkit [15998] by justing

2 edits in trunk/LayoutTests

I forgot to check in these expected results yesterday.

2:42 PM Changeset in webkit [22118] by aroben

2 edits in branches/WindowsMerge/WebCore

Reviewed by Ada.

Fixed placement of popups when document is scrolled.

2:36 PM Changeset in webkit [15997] by hyatt

2 edits in trunk/WebCore

Remove the ifdef for platform scrollbars vs. engine scrollbars until
engine scrollbars actually exist.

platform/ScrollBar.h: (WebCore::ScrollBar::hasPlatformScrollBars):

2:33 PM Changeset in webkit [15996] by justing

3 edits in trunk/WebCore

Reviewed by harrison

Removed the poorly named next/previousVisiblePosition
and use next/previousCandidate and next/previousVisuallyDistinctCandidate.
Removed the unused VisiblePosition::maxOffset()

editing/VisiblePosition.cpp: (WebCore::VisiblePosition::next): (WebCore::VisiblePosition::previous): (WebCore::VisiblePosition::canonicalPosition):
editing/VisiblePosition.h:

2:06 PM Changeset in webkit [15995] by beidson

2 edits in trunk/WebKit

Reviewed by John Sullivan

/me crosses fingers
Flip the switch to the new Icon Database
Massive code pruning is coming up

WebKitPrefix.h: Flipped the switch

2:04 PM Changeset in webkit [15994] by rwlbuis

1 edit
3 adds in trunk/WebCore

Reviewed by Alexey. Landed by rwlbuis.

Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support (Part II)

1:48 PM Changeset in webkit [15993] by beidson

2 edits in trunk/WebKit

Reviewed by Beth
Since I just pushed the default URL icon from WebKit to WebCore, but
WebKit was still using its version of the default icon, this patch makes it
use the WebCore version

Misc/WebIconDatabase.m: (-[WebIconDatabase defaultIconWithSize:]):

12:31 PM Changeset in webkit [15992] by beidson

6 edits
1 add in trunk/WebCore

Reviewed by Adele

Moved default URL icon from WebKit to WebCore

Resources/urlIcon.tiff: Added.
WebCore.xcodeproj/project.pbxproj:
loader/icon/IconDataCache.cpp: (WebCore::IconDataCache::loadImageFromResource):
loader/icon/IconDataCache.h:
loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::IconDatabase): (WebCore::IconDatabase::defaultIcon):
loader/icon/IconDatabase.h:

11:24 AM Changeset in webkit [22117] by sfalken

2 edits in branches/WindowsMerge/WebCore

2006-08-23 Steve Falkenburg <sfalken@apple.com>

Build fix (many of our include paths were wrong!)

WebCore.vcproj/WebCore.vcproj:

11:08 AM Changeset in webkit [15991] by aroben

6 edits in trunk/WebCore

Reviewed by Darin, Adele.

Some popup refactoring/cleanup.

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::defaultEventHandler):
rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::RenderMenuList): (WebCore::RenderMenuList::~RenderMenuList): (WebCore::RenderMenuList::showPopup): (WebCore::RenderMenuList::hidePopup):
rendering/RenderMenuList.h: (WebCore::RenderMenuList::popup): (WebCore::RenderMenuList::popupIsVisible):
rendering/RenderPopupMenu.h:
rendering/RenderPopupMenuMac.h: (WebCore::RenderPopupMenuMac::hidePopup):

11:03 AM Changeset in webkit [22116] by aroben

4 edits
1 add in branches/WindowsMerge/WebCore

Reviewed by Darin, Lou, Adele.

Initial implementation of <select> elements on Windows.

WebCore.vcproj/WebCore.vcproj:

Added RenderPopupMenuWin.cpp

platform/win/TemporaryLinkStubs.cpp: (RenderPopupMenuWin::addGroupLabel):
rendering/RenderPopupMenuWin.cpp: Added. (WebCore::RenderPopupMenuWin::RenderPopupMenuWin): (WebCore::RenderPopupMenuWin::~RenderPopupMenuWin): (WebCore::RenderPopupMenuWin::clear): (WebCore::RenderPopupMenuWin::populate): (WebCore::RenderPopupMenuWin::showPopup): (WebCore::RenderPopupMenuWin::hidePopup): (WebCore::RenderPopupMenuWin::setPositionAndSize): (WebCore::RenderPopupMenuWin::addOption): (WebCore::RenderPopupMenuWin::down): (WebCore::RenderPopupMenuWin::up): (WebCore::registerPopup): (WebCore::PopupWndProc):
rendering/RenderPopupMenuWin.h:

Added useful properties.

(WebCore::RenderPopupMenuWin::popupHandle):
(WebCore::RenderPopupMenuWin::containerHandle):
(WebCore::RenderPopupMenuWin::wasClicked):
(WebCore::RenderPopupMenuWin::setWasClicked):

rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::RenderThemeWin): (WebCore::RenderThemeWin::openButtonTheme): (WebCore::RenderThemeWin::openTextFieldTheme): (WebCore::RenderThemeWin::openMenuListTheme): (WebCore::RenderThemeWin::close): (WebCore::RenderThemeWin::supportsFocus): (WebCore::RenderThemeWin::determineState): (WebCore::RenderThemeWin::getThemeData): (WebCore::RenderThemeWin::paintButton): (WebCore::RenderThemeWin::paintTextField):

Refactored the above methods and added cases for
MenulistAppearance where appropriate.

(WebCore::RenderThemeWin::paintMenuList):
(WebCore::RenderThemeWin::adjustMenuListStyle):

Implemented the above methods.

rendering/RenderThemeWin.h:

10:44 AM Changeset in webkit [15990] by andersca

10 edits in trunk/JavaScriptCore

2006-08-23 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.

Make the bindings compile without CoreFoundation.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
bindings/c/c_instance.cpp:
bindings/c/c_utility.cpp: (KJS::Bindings::convertUTF8ToUTF16):
bindings/npapi.h:
bindings/runtime.cpp: (KJS::Bindings::Instance::createBindingForLanguageInstance): (KJS::Bindings::Instance::createLanguageInstanceForValue):
bindings/runtime_root.cpp:
bindings/runtime_root.h:
kjs/interpreter.cpp: (KJS::Interpreter::createLanguageInstanceForValue):
kjs/interpreter.h:

9:18 AM Changeset in webkit [15989] by rwlbuis

1 edit
4 adds in trunk/WebCore

Reviewed by Anders. Landed by rwlbuis.

Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10467
WebKit should have Qt platform support

Note: StringQt.cpp is not part of the original patch, but was
mistakenly omitted from earlier 10467 patch.

7:58 AM Changeset in webkit [15988] by zbujtas

5 edits in S60/trunk/WebKit

2006-08-22 bujtas <zbujtas@gmail.com>

Reviewed by Sachin.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10515
limit the textarea height so that it can not go beyond
the screen height (it is already done for the width)

BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::SetHeight): (CFormInputSkin::SizeForCharacterWidth):
BrowserView/inc/WebKitView.h:
BrowserView/src/WebKitFrame.cpp: (CWebKitFrame::ConstructL): (CWebKitFrame::~CWebKitFrame): (CWebKitFrame::CalcBidiWidth): (CWebKitFrame::FocusedPlugin):
BrowserView/src/WebKitView.cpp: (CWebKitView::FocusChanged): (CWebKitView::MaxBidiSize):

12:29 AM Changeset in webkit [15987] by beidson

5 edits in trunk/WebCore

Reviewed by Maciej

Added escapeSQLString() - a helper to escape strings to be used in textual SQL queries

WebCore.xcodeproj/project.pbxproj: Reordered some files
loader/icon/IconDataCache.cpp: Use the new escapeSQLString() (WebCore::IconDataCache::writeToDatabase):
loader/icon/IconDatabase.cpp: Use the new escapeSQLString() throughout (WebCore::IconDatabase::retainIconURL): (WebCore::IconDatabase::releaseIconURL): (WebCore::IconDatabase::forgetIconForIconURLFromDatabase): (WebCore::IconDatabase::establishIconIDForIconURL): (WebCore::imageDataForIconURLQuery): (WebCore::timeStampForIconURLQuery): (WebCore::iconURLForPageURLQuery): (WebCore::forgetPageURLQuery): (WebCore::setIconIDForPageURLQuery): (WebCore::getIconIDForIconURLQuery): (WebCore::addIconForIconURLQuery): (WebCore::hasIconForIconURLQuery):
loader/icon/SQLDatabase.h: (WebCore::escapeSQLString): Added

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed