Timeline



Sep 1, 2006:

6:43 PM Changeset in webkit [16191] by hyatt
  • 6 edits in trunk/WebCore

Fix for 10682, refine the FOUC paint suppression logic so that it
is only triggered when FOUC would really have occurred.

Reviewed by aroben

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::styleForElement):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::updateLayoutIgnorePendingStylesheets): (WebCore::Document::updateStyleSelector):
  • dom/Document.h: (WebCore::Document::haveStylesheetsLoaded): (WebCore::Document::): (WebCore::Document::didLayoutWithPendingStylesheets):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
6:10 PM Changeset in webkit [16190] by aroben
  • 11 edits in trunk

2006-09-01 MorganL <​morlmor@yahoo.com>

Reviewed by Darin. Updated/landed by Adam.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10553
Windows build fixes

5:57 PM Changeset in webkit [16189] by beidson
  • 6 edits in trunk/WebCore

Reviewed by Tim Omernick

Added an SQLDatabase logging channel. Changed all SQLDatabase and SQLStatement errors to use this new channel.
Also, as a popular request from other contributers, added a log for all prepare(), step(), finalize(), and reset()s
Also, fixed a grammar error in my previous ChangeLog entry.

  • bridge/mac/WebCorePageBridge.mm: (initializeLoggingChannelsIfNecessary): Initialize the new channel
  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::setBusyTimeout): Use SQLDatabase logging channel (WebCore::SQLDatabase::setBusyHandler): ditto (WebCore::SQLDatabase::clearAllTables): ditto (WebCore::SQLDatabase::runVacuumCommand): ditto
  • loader/icon/SQLStatement.cpp: (WebCore::SQLStatement::prepare): Added a log (WebCore::SQLStatement::step): ditto (WebCore::SQLStatement::finalize): ditto (WebCore::SQLStatement::reset): ditto (WebCore::SQLStatement::getColumnBlob): Use SQLDatabase logging channel (WebCore::SQLStatement::returnTextResults): ditto (WebCore::SQLStatement::returnTextResults16): ditto (WebCore::SQLStatement::returnIntResults): ditto (WebCore::SQLStatement::returnInt64Results): ditto (WebCore::SQLStatement::returnDoubleResults): ditto
  • platform/Logging.cpp: (WebCore::): Added new logging channel
  • platform/Logging.h: ditto
5:55 PM Changeset in webkit [16188] by adele
  • 20 edits in trunk

LayoutTests:

Reviewed by Tim Omernick.

Updated results for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=6990
Switch to use new text field implementation for <input type="password">

  • dom/html/level2/html/HTMLInputElement22-expected.txt:
  • dom/xhtml/level2/html/HTMLInputElement22-expected.txt:
  • fast/events/event-sender-mouse-click.html:
  • fast/forms/input-appearance-height-expected.checksum:
  • fast/forms/input-appearance-height-expected.txt:
  • fast/forms/input-type-change-in-onfocus-mouse-expected.txt:
  • fast/forms/input-value-expected.checksum:
  • fast/forms/input-value-expected.png:
  • fast/forms/input-value-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug92647-1-expected.checksum:
  • tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
  • tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:

Updated from switch to style-able selects

  • fast/forms/option-strip-whitespace-expected.checksum:
  • fast/forms/option-strip-whitespace-expected.png:
  • fast/forms/option-strip-whitespace-expected.txt:

WebCore:

Reviewed by Tim Omernick.

  • css/html4.css: Give input[password] the same style properties as normal text fields.
  • html/HTMLInputElement.cpp: Removed checks for TextFieldAppearance. (WebCore::HTMLInputElement::selectionStart): (WebCore::HTMLInputElement::selectionEnd): (WebCore::HTMLInputElement::setSelectionStart): (WebCore::HTMLInputElement::setSelectionEnd): (WebCore::HTMLInputElement::select): (WebCore::HTMLInputElement::setSelectionRange): (WebCore::HTMLInputElement::createRenderer):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::isNonWidgetTextField):
5:03 PM Changeset in webkit [16187] by beidson
  • 8 edits in trunk/WebCore

Reviewed by John (though Sarge review a previous patch of mine in an attempt to review this one)

Added some constants for SQL Result Codes to SQLDatabase.h
This way, users of SQLDatabase can access all necessary SQLite functionality
without having access to sqlite3.h.
Also reordered some files in the xcodeproj and some #includes

  • WebCore.xcodeproj/project.pbxproj: Reordered some files
  • loader/icon/IconDataCache.cpp: (WebCore::IconDataCache::writeToDatabase): Use our new result codes
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::sharedIconDatabase): Use our new result codes (WebCore::IconDatabase::retainIconForPageURL): Use our new result codes (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Use our new result codes (WebCore::IconDatabase::addIconForIconURLQuery): Use our new result codes (WebCore::IconDatabase::hasIconForIconURLQuery): Use our new result codes
  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::lastError): Moved from header to eliminate dependency on sqlite3.h in header (WebCore::SQLDatabase::lastErrorMsg): Ditto
  • loader/icon/SQLDatabase.h: Removed #include <sqlite3.h>
  • loader/icon/SQLStatement.cpp: Added #include <sqlite3.h>
  • loader/icon/SQLStatement.h: Removed #include <sqlite3.h>
4:53 PM Changeset in webkit [16186] by beidson
  • 1 edit in trunk/WebKit/ChangeLog

My ChangeLog grammar needs reviewing, apparently (fixed last ChangeLog)

4:20 PM Changeset in webkit [16185] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Darin

A "never should be reach" method was reached - lets not release the shared database bridge, esp
since we never retain it!

  • Misc/WebIconDatabase.m: (-[WebIconDatabase _applicationWillTerminate:]): Don't release the bridge
3:57 PM Changeset in webkit [16184] by hyatt
  • 4 adds in trunk/LayoutTests/fast/flexbox

Add flexbox test.

3:56 PM Changeset in webkit [16183] by hyatt
  • 2 edits in trunk/WebCore

Fix for 10680, contrained flexbox is not shrinking flexible children
properly. (Fixing in case it's hit by the file upload control.)

Reviewed by aroben

Adding 026.html to fast/flexbox.

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::allowedChildFlex):
2:52 PM Changeset in webkit [16182] by eseidel
  • 4 edits in trunk/WebCore

2006-09-01 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Implement support for multiple parents in the SVG idls.

For class "FooBar" go through all parents recursively,
collect their attributes & functions & constants and
add them directly into the class "FooBar".

(Note: It is NOT enabled by default for now - still some things related to SVGAnimated* need to be solved first)

  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/generate-bindings.pl:
2:50 PM Changeset in webkit [16181] by eseidel
  • 6 edits in trunk

2006-09-02 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by hyatt. Landed by eseidel.

Fix build on Linux.

  • CMakeLists.txt: Add platform/CString.cpp.
  • platform/qt/FrameQt.cpp: Correct repsondToChangedContents() signature
  • platform/qt/FrameQt.h:: Correct respondToChangedContents() signature
2:41 PM Changeset in webkit [16180] by darin
  • 9 edits in trunk

WebCore:

Reviewed by Brady.

  • a few small tweaks to the icon database bridge
  • bridge/mac/WebCoreIconDatabaseBridge.h: Removed unnecessary declarations. Renamed sharedBridgeInstance to sharedInstance.
  • bridge/mac/WebCoreIconDatabaseBridge.mm: Put functions inside WebCore namespace. (WebCore::IconDatabase::loadIconFromURL): Updated for sharedInstance namespace.

WebKit:

Reviewed by Brady.

  • a few small tweaks to the icon database bridge
  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): Updated for name change.
  • WebCoreSupport/WebIconDatabaseBridge.h: Removed unneeded declarations.
  • WebCoreSupport/WebIconDatabaseBridge.m: (-[WebIconDatabaseBridge init]): Added. Always returns nil since you're not supposed to allocate one of these. (-[WebIconDatabaseBridge _init]): Renamed from init. Used internally to make the shared instance. Added the "self = [super init]" idiom even though it's not important in this case just to be consistent. (-[WebIconDatabaseBridge releaseCachedLoaderForIconURL:]): Moved this up in the file so it can be called without declaring it in the header. (+[WebIconDatabaseBridge sharedInstance]): Renamed. Calls the new _init. Also use CFRetain for compatibility. (-[WebIconDatabaseBridge dealloc]): Emptied this out and made it just assert (false). (-[WebIconDatabaseBridge finalize]): Added and made it assert (false) too.
2:21 PM Changeset in webkit [16179] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Adele.

Bug 10677: Omit "-webkit-text-security: none;" from the computed style list
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10677

2:00 PM Changeset in webkit [22139] by sfalken
  • 5 edits in branches/WindowsMerge
1:09 PM Changeset in webkit [16178] by thatcher
  • 5 edits in trunk

LayoutTests:

Reviewed by Darin.

  • updated results, null is not round-tripped through the bindings because of regressions the original change caused in other applications.
  • added an echo for "undefined".
  • plugins/bindings-test-expected.txt:
  • plugins/bindings-test.html:

WebCore:

Reviewed by Darin.

<rdar://problem/4651318> REGRESSION: can't drag library items to widget in Dashcode
<rdar://problem/4701626> REGRESSION: Unit Converter widget doesn't work convert data in its fields

jsNull should not be returned as NSNull because existing applications do not
expect that return value. Return as nil for backwards compatibility.

  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:originExecutionContext:executionContext:]):
1:05 PM Changeset in webkit [16177] by ap
  • 4 edits in trunk/JavaScriptCore

2006-09-01 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by ap.

Fix build on Linux (C89 without gcc extensions enabled).

  • pcre/pcre_internal.h: Use C style comments.
  • wtf/Assertions.h: Use C style comments.
  • wtf/Platform.h: Use C style comments.
12:48 PM Changeset in webkit [16176] by ap
  • 2 edits in trunk/WebCore

Build fix.

  • loader/Decoder.cpp: (Decoder::Decoder): Use String::latin1().
12:36 PM Changeset in webkit [16175] by ap
  • 12 edits
    18 adds in trunk

Reviewed by Eric.

WebCore:

  • loader/Decoder.cpp: (Decoder::Decoder): Decoder now knows what kind of content it is decoding. Also, the browser default encoding can now be passed directly to the constructor, to streamline the logic. (Decoder::decode): Add support for @charset, differentiate between HTML and XML. (Decoder::setEncodingName): Style cleanup. (Decoder::encodingName): Ditto. (Decoder::flush): Ditto.
  • loader/Decoder.h: (WebCore::Decoder::):
  • bridge/mac/WebCoreEncodings.mm: Pass a content type of text/html to Decoder.
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): (WebCore::CachedCSSStyleSheet::setCharset): (WebCore::CachedCSSStyleSheet::data):
  • loader/CachedCSSStyleSheet.h: Use Decoder instead of TextEncoding::toUnicode() to enable @charset support.
  • loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::CachedXBLDocument): Pass a content type.
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet): Ditto. (WebCore::CachedXSLStyleSheet::data): Flush the decoder to be safe.
  • page/Frame.cpp: (WebCore::Frame::write): Pass a content type and a default encoding to the Decoder.
  • xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): Pass the output document MIME type.
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::receivedData): Ditto.

LayoutTests:

  • fast/encoding/css-charset-expected.txt: Added.
  • fast/encoding/css-charset.css: Added.
  • fast/encoding/css-charset.html: Added.
  • fast/encoding/css-charset-evil-expected.txt: Added.
  • fast/encoding/css-charset-evil.css: Added.
  • fast/encoding/css-charset-evil.html: Added.
  • fast/encoding/default-xhtml-encoding-expected.txt: Added.
  • fast/encoding/default-xhtml-encoding.xhtml: Added.
  • fast/encoding/meta-in-xhtml-expected.txt: Added.
  • fast/encoding/meta-in-xhtml.xhtml: Added.
  • fast/encoding/pseudo-xml-2-expected.txt: Added.
  • fast/encoding/pseudo-xml-2.html: Added.
  • fast/encoding/pseudo-xml-3-expected.txt: Added.
  • fast/encoding/pseudo-xml-3.html: Added.
  • fast/encoding/pseudo-xml-4-expected.txt: Added.
  • fast/encoding/pseudo-xml-4.html: Added.
  • fast/encoding/pseudo-xml-expected.txt: Added.
  • fast/encoding/pseudo-xml.html: Added.
12:01 PM Changeset in webkit [16174] by adele
  • 5 edits in trunk/WebCore

Reviewed by John.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::setSecureKeyboardEntry): Enable and disable Roman keyboards when switching in and out of this mode. (WebCore::FrameMac::isSecureKeyboardEntry): Changed secureKeyboardEntry to isSecureKeyboardEntry.
  • bridge/mac/FrameMac.h: ditto.
  • page/Frame.cpp: (WebCore::Frame::setIsActive): ditto.
  • page/Frame.h: (WebCore::Frame::isSecureKeyboardEntry): ditto.
11:07 AM Changeset in webkit [22138] by adachan
  • 3 edits in branches/WindowsMerge/WebCore

2006-09-01 Ada Chan <​adachan@apple.com>

Reviewed by lamadio.

Fixed build break.

10:21 AM Changeset in webkit [16173] by adele
  • 2 edits in trunk/WebCore

Reviewed by John.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Don't smart replace when the selection being replaces is in a password field.

Aug 31, 2006:

9:08 PM Changeset in webkit [16172] by thatcher
  • 12 edits
    4 adds in trunk

WebCore:

Reviewed by Tim H.


Auto-generates DOMHTMLAnchorElement, DOMHTMLAreaElement,
DOMHTMLBaseFontElement, DOMHTMLFontElement, DOMHTMLFrameElement,
DOMHTMLFrameSetElement, DOMHTMLHRElement, DOMHTMLIFrameElement,
DOMHTMLImageElement, DOMHTMLMapElement, DOMHTMLModElement,
DOMHTMLObjectElement, DOMHTMLParamElement, DOMHTMLScriptElement,
DOMHTMLTableCaptionElement, DOMHTMLTableCellElement,
DOMHTMLTableColElement, DOMHTMLTableElement, DOMHTMLTableRowElement,
and DOMHTMLTableSectionElement.

Splits DOMHTMLAppletElement and DOMHTMLOptionElement into their own
files.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMHTML.h:
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLAnchorElement absoluteLinkURL]): (-[DOMHTMLImageElement altDisplayString]): (-[DOMHTMLImageElement absoluteImageURL]): (-[DOMHTMLImageElement WebCore::]): (-[DOMHTMLObjectElement absoluteImageURL]): (-[DOMHTMLObjectElement WebCore::]): (+[DOMHTMLTableCaptionElement _tableCaptionElementWith:]): (-[DOMHTMLTableCaptionElement _tableCaptionElement]): (+[DOMHTMLTableSectionElement _tableSectionElementWith:]): (-[DOMHTMLTableSectionElement _tableSectionElement]): (+[DOMHTMLTableElement _tableElementWith:]): (-[DOMHTMLTableElement _tableElement]): (+[DOMHTMLTableCellElement _tableCellElementWith:]): (-[DOMHTMLTableCellElement _tableCellElement]):
  • bindings/objc/DOMHTMLAppletElement.h: Added.
  • bindings/objc/DOMHTMLAppletElement.mm: Added. (-[DOMHTMLAppletElement WebCore::]): (-[DOMHTMLAppletElement align]): (-[DOMHTMLAppletElement setAlign:]): (-[DOMHTMLAppletElement alt]): (-[DOMHTMLAppletElement setAlt:]): (-[DOMHTMLAppletElement archive]): (-[DOMHTMLAppletElement setArchive:]): (-[DOMHTMLAppletElement code]): (-[DOMHTMLAppletElement setCode:]): (-[DOMHTMLAppletElement codeBase]): (-[DOMHTMLAppletElement setCodeBase:]): (-[DOMHTMLAppletElement height]): (-[DOMHTMLAppletElement setHeight:]): (-[DOMHTMLAppletElement hspace]): (-[DOMHTMLAppletElement setHspace:]): (-[DOMHTMLAppletElement name]): (-[DOMHTMLAppletElement setName:]): (-[DOMHTMLAppletElement object]): (-[DOMHTMLAppletElement setObject:]): (-[DOMHTMLAppletElement vspace]): (-[DOMHTMLAppletElement setVspace:]): (-[DOMHTMLAppletElement width]): (-[DOMHTMLAppletElement setWidth:]):
  • bindings/objc/DOMHTMLInternal.h:
  • bindings/objc/DOMHTMLOptionElement.h: Added.
  • bindings/objc/DOMHTMLOptionElement.mm: Added. (-[DOMHTMLOptionElement WebCore::]): (-[DOMHTMLOptionElement form]): (-[DOMHTMLOptionElement defaultSelected]): (-[DOMHTMLOptionElement setDefaultSelected:]): (-[DOMHTMLOptionElement text]): (-[DOMHTMLOptionElement index]): (-[DOMHTMLOptionElement disabled]): (-[DOMHTMLOptionElement setDisabled:]): (-[DOMHTMLOptionElement label]): (-[DOMHTMLOptionElement setLabel:]): (-[DOMHTMLOptionElement selected]): (-[DOMHTMLOptionElement setSelected:]): (-[DOMHTMLOptionElement value]): (-[DOMHTMLOptionElement setValue:]):
  • bindings/objc/DOMPrivate.h:
  • bindings/scripts/CodeGeneratorObjC.pm:

WebKit:

Reviewed by Tim H.

  • MigrateHeaders.make:
8:58 PM Changeset in webkit [22137] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-09-01 Steve Falkenburg <​sfalken@apple.com>

Reviewed by kevin.


Fix back/forward regression.


Combining the two receivedAllData methods into one broke back/forward navigation,
since we put the resetting of m_quickRedirectComing and m_loadType at the start
of the combined method, but have code in the rest of receivedAllData that
relies on these having their old values.

  • WebFrame.cpp: (WebFrame::receivedAllData):


7:28 PM Changeset in webkit [16171] by aliceli1
  • 11 edits in trunk

LayoutTests:

Reviewed by Darin.

Revised expected results for an isindex element because of
<rdar://problem/4463870> Switch to use new text field implementation for <isindex>
Now the field is rendered as a textfield

  • fast/dom/isindex-002-expected.checksum:
  • fast/dom/isindex-002-expected.png:
  • fast/dom/isindex-002-expected.txt:

WebCore:

Reviewed by Darin.

Fixed <rdar://problem/4463870> Switch to use new text field implementation for <isindex>

  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isTextField]): moved isindex from the list of nonTextInputTypes to the list of textInputTypes
  • css/html4.css: added isindex to certain rules that applied to input fields
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::canHaveSelection): (WebCore::HTMLInputElement::selectionStart): (WebCore::HTMLInputElement::selectionEnd): (WebCore::HTMLInputElement::setSelectionStart): (WebCore::HTMLInputElement::setSelectionEnd): (WebCore::HTMLInputElement::select): (WebCore::HTMLInputElement::setSelectionRange): (WebCore::HTMLInputElement::createRenderer): for the 8 methods above, moved the case for isindex to the same case as text
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::isNonWidgetTextField): added isindex to this test
  • html/HTMLIsIndexElement.idl: HTMLIsIndexElement inherits from HTMLInputElement
  • rendering/RenderLineEdit.cpp: (WebCore::RenderLineEdit::RenderLineEdit): removed the case for isindex since we changed the renderer type from a RenderLineEdit to a RenderTextControl in WebCore::HTMLInputElement::createRenderer()
6:57 PM Changeset in webkit [16170] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: Prepare for another round of renaming.
6:13 PM Changeset in webkit [16169] by harrison
  • 11 edits in trunk/WebCore

Reviewed by Adele.

<rdar://problem/4708119> REGRESSION: Cannot observe an AXTextField element directly

... and most of
<rdar://problem/4708022> REGRESSION: TextRange-based attributes are missing from text fields
<rdar://problem/4709515> REGRESSION: Expose text areas

Remaining work for those two bugs in new bugs:

<rdar://problem/4712101> Support NSAccessibilityVisibleCharacterRangeAttribute for AXTextField and AXTextArea elements
<rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements
<rdar://problem/4712125> Support setting NSAccessibilitySelectedTextAttribute for AXTextField and AXTextArea elements

  • bridge/AXObjectCache.h: (WebCore::AXObjectCache::postNotificationToElement):
  • bridge/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::postNotification): (WebCore::AXObjectCache::postNotificationToElement): Removed postNotificationToTopWebArea. postNotification now posts to input element or top web area, as appropriate. postNotificationToElement posts to the specified element itself.


  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::respondToChangedContents): Take a selection. Pass the starting position's renderer to postNotification so that postNotification can post to the appropriate input element, if any.


  • bridge/mac/WebCoreAXObject.h:
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject isWebArea]): (-[WebCoreAXObject isAnchor]): (-[WebCoreAXObject isTextRange]): New convenience methods.


(-[WebCoreAXObject role]):
(-[WebCoreAXObject roleDescription])
(-[WebCoreAXObject value]):
(-[WebCoreAXObject accessibilityDescription]):
Support AXTextField and AXTextArea.

(-[WebCoreAXObject accessibilityShouldUseUniqueId]):
Register AXTextField and AXTextArea elements so notifications to them can be observed.


(-[WebCoreAXObject accessibilityIsIgnored]):
Use new convenience method isWebArea.

(-[WebCoreAXObject accessibilityAttributeNames]):
Simplify the array creation.
Add text range support.


(-[WebCoreAXObject accessibilityAttributeValue:]):
Add text range support.


(-[WebCoreAXObject canSetFocusAttribute]):
(-[WebCoreAXObject canSetValueAttribute]):
(-[WebCoreAXObject canSetTextRangeAttributes]):
New convenience methods.


(-[WebCoreAXObject accessibilityIsAttributeSettable:]):
(-[WebCoreAXObject accessibilitySetValue:forAttribute:]):
Add text range support.

(-[WebCoreAXObject observableObject]):
New to locate text field or text area to notify.


  • dom/Document.cpp: (WebCore::Document::updateSelection): Post AXSelectedTextChanged notification with new selection's start node. postNotification will send it to the input element, if there is one, or the top WebArea.


(WebCore::Document::implicitClose):
Use postNotificationToElement now that it acts like the old postNotification.


  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::appliedEditing): (WebCore::Frame::unappliedEditing): (WebCore::Frame::reappliedEditing): Pass the selection of interest to respondToChangedContents.


  • page/FrameView.cpp: (WebCore::FrameView::layout): Use postNotificationToElement now that it acts like the old postNotification.
6:12 PM Changeset in webkit [16168] by sfalken
  • 3 edits in trunk/JavaScriptCore

2006-09-01 Steve Falkenburg <​sfalken@apple.com>

Fix build.

6:11 PM Changeset in webkit [22136] by andersca
  • 3 edits
    1 add in branches/WindowsMerge/WebCore

2006-08-31 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Steve.

Add our own internal config.h so we can make changes to it.


  • WebCore.vcproj/WebCore.vcproj: Add config.h to the file list, move the KXMLCORE_PLATFORM_CF to the new config.h file


  • config.h: Added.


  • platform/win/ResourceLoaderWin.cpp: Include config.h
5:17 PM Changeset in webkit [16167] by adele
  • 9 edits in trunk

WebCore:

Reviewed by Darin.

WebCore part of fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10666
Password: Disallow Spelling, Font, Speech, and Writing Direction context menu

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge isSelectionInPasswordField]): Added.
  • page/Frame.cpp: (WebCore::Frame::isSelectionInPasswordField): Added.
  • page/Frame.h:

WebKit:

Reviewed by Darin.

WebKit part of fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10666
Password: Disallow Spelling, Font, Speech, and Writing Direction context menu

  • DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): Check that the selection isn't in a password field before adding these items to the default editing context menu.

Search In Google, Search In Spotlight, Look up in Dictionary, Spelling, Font, Speech, Writing Direction

  • WebView/WebHTMLView.m: (-[WebHTMLView _isSelectionInPasswordField]): Added.
  • WebView/WebHTMLViewPrivate.h:
4:48 PM Changeset in webkit [22135] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

Fix build bustage.

4:43 PM Changeset in webkit [16166] by andersca
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Forgot the ChangeLog

4:15 PM Changeset in webkit [22134] by hyatt
  • 3 edits in branches/WindowsMerge/WebCore

Add a platform scrollbar class for Windows. Doesn't really work yet.

4:11 PM Changeset in webkit [16165] by antti
  • 2 edits in S60/trunk/WebCore

2006-08-31 bujtas <​zbujtas@gmail.com>

Reviewed by Antti Koivisto.
DESC: do not call updateStyleAttributeIfNeeded when the
element is removed from doc
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10662

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/xml/dom_elementimpl.cpp: (AttrImpl::toString): (ElementImpl::scrollIntoView): (ElementImpl::blur): (ElementImpl::getAttributeNS): (ElementImpl::setAttribute): (ElementImpl::setAttributeMap): (ElementImpl::isURLAttribute): (ElementImpl::removedFromDocument): (ElementImpl::recalcStyle): (ElementImpl::dispatchAttrRemovalEvent): (ElementImpl::dispatchAttrAdditionEvent): (ElementImpl::openTagStartToString): (ElementImpl::toString): (ElementImpl::updateId): (ElementImpl::formatForDebugger): (NamedAttrMapImpl::setNamedItem): (NamedAttrMapImpl::removeNamedItem): (NamedAttrMapImpl::clearAttributes): (NamedAttrMapImpl::operator=): (NamedAttrMapImpl::addAttribute): (NamedAttrMapImpl::removeAttribute):
3:59 PM Changeset in webkit [16164] by andersca
  • 4 edits
    1 add in trunk/JavaScriptCore

2006-08-31 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.


Add new portability functions to MathExtras.h and add StringExtras.h which is for
string portability functions.


  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • bindings/c/c_instance.cpp:
  • kjs/date_object.cpp:
  • wtf/MathExtras.h: (copysign): (isfinite):
  • wtf/StringExtras.h: Added. (snprintf): (strncasecmp):
3:55 PM Changeset in webkit [16163] by andersca
  • 3 edits in trunk/JavaScriptCore

2006-08-31 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim H.


Fix Windows build.


  • JavaScriptCore.vcproj/dftables/dftables.vcproj:
  • pcre/pcre_internal.h:
3:44 PM Changeset in webkit [16162] by thatcher
  • 1 edit in trunk/WebKit/DOM/WebDOMOperations.m

Build fix to avoid a property name conflict warning.

3:31 PM Changeset in webkit [16161] by andersca
  • 1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog

3:26 PM Changeset in webkit [16160] by andersca
  • 10 edits in trunk/WebCore

2006-08-31 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Tim H, Hyatt.

  • WebCore.xcodeproj/project.pbxproj: Add KURLCFNet.cpp


  • platform/KURL.h: Get rid of include, add KURL constructor that takes a CFURLRef.


  • platform/PlatformString.h:
  • platform/StringImpl.h: Get rid of include.


  • platform/cf/KURLCFNet.cpp: (WebCore::KURL::KURL): Add constructor.


  • platform/cf/ResourceLoaderCFNet.cpp: Fix includes.


  • platform/cf/StringCF.cpp: (WebCore::String::createCFString): Move this here from PlatformString.h


  • platform/cf/StringImplCF.cpp: (WebCore::StringImpl::createCFString): Fix cast.


  • platform/mac/KURLMac.mm: Move createCFURL() to KURLCFNet.cpp
2:59 PM Changeset in webkit [16159] by hyatt
  • 2 edits in trunk/WebCore

Make ScrollBar.cpp able to be compiled on Win32.

2:54 PM Changeset in webkit [16158] by thatcher
  • 3 edits in trunk/WebCore

Build fixes for ppc64 and x86_64, and fixes needed now that we use -Wshorten-64-to-32.

2:52 PM Changeset in webkit [16157] by beidson
  • 1 edit in trunk/WebCore/loader/icon/IconDatabase.h

Renamed an argument in a header for clarity (meant to go with last checkin)

2:44 PM Changeset in webkit [16156] by thatcher
  • 2 edits in trunk/JavaScriptCore/API

Build fixes for ppc64 and x86_64 now that we use -Wshorten-64-to-32.

2:28 PM Changeset in webkit [16155] by thatcher
  • 7 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Band-aid fix for PCRE to compile for ppc64 and x86_64 now that
we use -Wshorten-64-to-32. Adds an INT_CAST macro that ASSERTs
the value <= INT_MAX.

I filed <rdar://problem/4712064> to track the need to verify
PCRE's 64-bit compliance.

  • pcre/pcre_compile.c: (complete_callout): (compile_branch): (compile_regex): (pcre_compile2):
  • pcre/pcre_exec.c: (match): (pcre_exec):
  • pcre/pcre_get.c: (pcre_get_substring_list):
  • pcre/pcre_internal.h:
  • pcre/pcre_tables.c:
  • pcre/pcre_try_flipped.c: (_pcre_try_flipped):
2:26 PM Changeset in webkit [16154] by beidson
  • 3 edits in trunk/WebCore

Reviewed by John

Cleaned up my last patch after further considerations

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Uses the new checkForDanglingPageURLs to check for and fix danglers. Does so in all builds (changed from debug only in my last patch) (WebCore::IconDatabase::syncDatabase): Uses the new checkForDanglingPageURLs to check for danglers (WebCore::IconDatabase::checkForDanglingPageURLs): This checks and, if asked via an arg, prunes the dangling pageURLs
  • loader/icon/IconDatabase.h:
2:05 PM Changeset in webkit [16153] by andersca
  • 4 edits
    2 adds in trunk/WebCore

2006-08-31 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

Add CString. CString is a simple, null-terminated byte buffer that supports data
sharing. Its main use is to be a better const char*.


Also add latin1 and utf8 methods to String which returns CStrings.


  • platform/CString.cpp: Added. (WebCore::CString::CString): (WebCore::CString::init): (WebCore::CString::data): (WebCore::CString::length): (WebCore::CString::deprecatedCString):
  • platform/CString.h: Added. (WebCore::CStringBuffer::CStringBuffer): (WebCore::CStringBuffer::data): (WebCore::CStringBuffer::length): (WebCore::CString::CString): (WebCore::CString::operator const char*): (WebCore::CString::isNull):
  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::latin1): (WebCore::String::utf8):
2:01 PM Changeset in webkit [22133] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-08-31 Anders Carlsson <​acarlsson@apple.com>

Fix the build.

  • WebCore.vcproj/WebCore.vcproj:
1:26 PM Changeset in webkit [16152] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Hyatt

Previously mentioned ASSERT was hit right away by folks, as we first need to bring their old icon.db into consistency
Changed the ASSERT to a LOG_ERROR and added a method for debug builds to bring a DB back together.

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Check for the danglers and prune them out (WebCore::IconDatabase::syncDatabase): Check for the danglers and log the error (WebCore::IconDatabase::pruneDanglingPageURLs): Prune the danglers
  • loader/icon/IconDatabase.h:
1:25 PM Changeset in webkit [16151] by antti
  • 2 edits in S60/trunk/WebCore
12:40 PM Changeset in webkit [16150] by spadma
  • 2 edits in S60/trunk/WebCore

2006-08-31 spadma <​sachin.padma@nokia.com>

Reviewed by Sriram.
DESC: Set the focused element type to none when no anchor is focused
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10659

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::tabbedNavigation):
11:57 AM Changeset in webkit [16149] by spadma
  • 2 edits in S60/trunk/WebKit

2006-08-31 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin/Yongjun.
DESC: Set the current page Url.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL): (CWebKitLoader::LoadResourceL):
11:22 AM Changeset in webkit [16148] by thatcher
  • 1 edit in trunk/WebCore/bindings/objc/DOMHTML.mm

Build fix to avoid name conflicts with generated properties.

10:38 AM Changeset in webkit [16147] by beidson
  • 5 edits in trunk/WebCore

Reviewed by Hyatt

Fixed an error where an Icon's IconID could change without the change being reflected in the PageURL table,
causing icons to be pruned before their time and pages to lose their icons. This is because I misunderstood
how SQLite handles the "ON CONFLICT REPLACE" condition, which is to delete the row and re-insert instead of
perform an update. Also added an assertion to make sure this doesn't happen again.

  • loader/icon/IconDataCache.cpp: (WebCore::IconDataCache::writeToDatabase): Instead of one INSERT relying on SQLites conflict handling, broke this into an UPDATE attempt followed by the initial INSERT
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::createDatabaseTables): Slight tweak to the database schema to prevent this from happening in the future. Note this change will not cause incompatibility with the current schema, therefore I didn't update the official database version number (WebCore::IconDatabase::syncDatabase): Added an ASSERT to look for this condition in the future
  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::lastChanges): Added this SQLite accessor to see if an UPDATE command actually changed a row
  • loader/icon/SQLDatabase.h: Ditto
10:37 AM Changeset in webkit [22132] by sfalken
  • 20 edits
    4 adds in branches/WindowsMerge
10:20 AM Changeset in webkit [16146] by weinig
  • 13 edits in trunk

WebCore:

Reviewed by Tim H.

Auto-generates DOMHTMLBRElement, DOMHTMLButtonElement, DOMHTMLDListElement,
DOMHTMLDirectoryElement, DOMHTMLDivElement, DOMHTMLFieldSetElement,
DOMHTMLHeadingElement, DOMHTMLInputElement, DOMHTMLLIElement, DOMHTMLLabelElement,
DOMHTMLLegendElement, DOMHTMLMenuElement, DOMHTMLOListElement, DOMHTMLOptGroupElement,
DOMHTMLParagraphElement, DOMHTMLPreElement, DOMHTMLQuoteElement, DOMHTMLSelectElement,
DOMHTMLTextAreaElement, and DOMHTMLUListElement.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMHTML.h:
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement altDisplayString]): (-[DOMHTMLInputElement absoluteImageURL]): (-[DOMHTMLInputElement WebCore::]): (-[DOMHTMLInputElement _rectOnScreen]): (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]): (-[DOMHTMLInputElement _selectedRange]): (-[DOMHTMLInputElement _setAutofilled:]):
  • bindings/objc/DOMHTMLInternal.h:
  • bindings/objc/DOMPrivate.h:
  • bindings/scripts/CodeGeneratorObjC.pm:

WebKit:

Reviewed by Tim H.

  • MigrateHeaders.make:
  • WebKit.xcodeproj/project.pbxproj:
9:31 AM Changeset in webkit [16145] by adele
  • 10 edits in trunk

WebCore:

Reviewed by John Sullivan.

Removing use of SPI in favor of Carbon API to enable and disable secure event input.

  • WebCore.exp: Removed wkSecureEventInput and wkSetSecureEventInput.
  • platform/mac/WebCoreSystemInterface.h: ditto.
  • platform/mac/WebCoreSystemInterface.mm: ditto.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::setSecureKeyboardEntry): Uses EnableSecureEventInput and DisableSecureEventInput. (WebCore::FrameMac::secureKeyboardEntry): Uses IsSecureEventInputEnabled.

WebKit:

Reviewed by John Sullivan.

Removed wkSecureEventInput and wkSetSecureEventInput, since this can be done with API.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

WebKitLibraries:

Reviewed by John Sullivan.

Removed wkSecureEventInput and wkSetSecureEventInput, since this can be done with API.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
9:25 AM Changeset in webkit [16144] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Omernick


  • fixed <rdar://problem/4711200> Loading history would be faster if it bypassed NSURL API for local files
  • History/WebHistory.m: (-[WebHistoryPrivate _loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]): Load file URLs using [NSDictionary dictionaryWithContentsOfFile:]. I also cleaned up some minor style issues in this method, and I removed the support for old NSArray-style history files (which we stopped using before Safari 1.0).
9:06 AM Changeset in webkit [16143] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-08-30 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Antti Koivisto.

WARNING: NO TEST CASES ADDED OR CHANGED


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10646

  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition):
9:02 AM Changeset in webkit [16142] by zbujtas
  • 8 edits in S60/trunk/WebCore

2006-08-29 yadavall <​koivisto@iki.fi>

Reviewed by Antti Koivisto.

WARNING: NO TEST CASES ADDED OR CHANGED


​http://bugzilla.opendarwin.org/show_bug.cgi?id=9077

  • khtml/editing/markup.cpp: (khtml::endMarkup):
  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::createTokenizer):
  • khtml/html/html_documentimpl.h:
  • khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseComment):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::~DocumentImpl): (DocumentImpl::documentElement):
  • khtml/xml/dom_docimpl.h:
8:38 AM Changeset in webkit [16141] by zbujtas
  • 2 edits in S60/trunk/MemoryManager

2006-08-31 yongjzha <​yongjun.zhang@nokia.com>

Reviewed by Zalan
DESC: debug
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10212

  • Src/Allocator.cpp: (CPlainAllocator::ReAllocate):
8:10 AM Changeset in webkit [16140] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-08-28 bujtas <​zbujtas@gmail.com>

Reviewed by Antti Koivisto.
DESC: backgroung image is not ref-ed properly.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10619

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/rendering/render_object.cpp: (RenderObject::setStyle):
8:00 AM Changeset in webkit [16139] by brmorris
  • 2 edits in S60/trunk

2006-08-29 brmorris <​bradley.morrison@nokia.com>

Reviewed by Zalan.
DESC: runATF sometimes does not detect test suite finished.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10625

  • runATF.bat: fork emulator launch, add END block to restore start.rsc

Aug 30, 2006:

11:22 PM Changeset in webkit [16138] by beidson
  • 2 edits in trunk/WebCore

Reviewed by "common sense" (and Maciej)

Fixed two logging typos

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::syncDatabase):
7:09 PM Changeset in webkit [16137] by adele
  • 2 edits in trunk/WebCore

Adding missing nil check for focus node.

  • page/Frame.cpp: (WebCore::Frame::setIsActive):
6:50 PM Changeset in webkit [16136] by adele
  • 14 edits in trunk

WebCore:

Reviewed by Hyatt.

WebCore part of fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10575
Enable secure input mode for new password fields

  • WebCore.exp: Added wkSetSecureEventInput and wkSecureEventInput.
  • platform/mac/WebCoreSystemInterface.h: ditto.
  • platform/mac/WebCoreSystemInterface.mm: ditto.
  • page/Frame.cpp: (WebCore::Frame::setIsActive): Enables and disables secure keyboard entry based on whether the frame becomes active.
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::setSecureKeyboardEntry): Added. Calls wkSetSecureEventInput. (WebCore::FrameMac::secureKeyboardEntry): Added. Calls wkSecureEventInput.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::dispatchFocusEvent): For password fields, enable secure keyboard entry. (WebCore::HTMLInputElement::dispatchBlurEvent): For password fields, disable secure keyboard entry.
  • page/Frame.h: (WebCore::Frame::setSecureKeyboardEntry): (WebCore::Frame::secureKeyboardEntry):

WebKit:

Reviewed by Hyatt.

WebKit part of fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10575
Enable secure input mode for new password fields

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

WebKitLibraries:

Reviewed by Hyatt.

Updated for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10575
Enable secure input mode for new password fields

  • WebKitSystemInterface.h: Added WKSetSecureEventInput and WKSecureEventInput;
  • libWebKitSystemInterface.a:
6:15 PM Changeset in webkit [16135] by thatcher
  • 1 edit in trunk/WebKit/WebCoreSupport/WebIconDatabaseBridge.m

Build fix.

5:20 PM Changeset in webkit [16134] by darin
  • 15 edits
    1 add in trunk/WebCore

Reviewed by Tim Hatcher.

  • eliminated the need for UsesPassRefPtr in IDL files
  • got rid of the category mechanism for ObjC generated DOM headers (after discussions with Tim H where we decided it's not needed)
  • simplified use of macro inside ObjC generated code
  • ForwardingHeaders/wtf/GetPtr.h: Added.
  • bindings/scripts/CodeGeneratorObjC.pm: Removed code to handle categories. Eliminated use of DOM_cast since that's for the protection of human programmers -- the script won't make mistakes that it needs to catch. Changed macro to always be named IMPL instead of incorporating the class name. Use WTF::getPtr to extract the pointer, and removed the code that uses .get() to extract the pointer in the PassRefPtr case.
  • dom/Attr.idl: Removed all uses of UsesPassRefPtr and ObjCCatagory.
  • dom/DOMImplementation.idl: Ditto.
  • dom/Document.idl: Ditto.
  • dom/Element.idl: Ditto.
  • dom/NamedNodeMap.idl: Ditto.
  • html/HTMLDocument.idl: Ditto.
  • html/HTMLElement.idl: Ditto.
  • html/HTMLFormElement.idl: Ditto.
  • html/HTMLMapElement.idl: Ditto.
  • html/HTMLSelectElement.idl: Ditto.
  • html/HTMLTableElement.idl: Ditto.
  • html/HTMLTableRowElement.idl: Ditto.
  • html/HTMLTableSectionElement.idl: Ditto.
5:12 PM Changeset in webkit [16133] by darin
  • 7 edits
    1 add in trunk/JavaScriptCore

Reviewed by Tim Hatcher.

  • add WTF::getPtr, a function template that makes it possible to write generic code that gets a raw pointer out of any of our pointer types
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/GetPtr.h: Added.
  • wtf/ListRefPtr.h: (WTF::getPtr): Added.
  • wtf/OwnArrayPtr.h: (WTF::getPtr): Added.
  • wtf/OwnPtr.h: (WTF::getPtr): Added.
  • wtf/PassRefPtr.h: (WTF::getPtr): Added.
  • wtf/RefPtr.h: (WTF::getPtr): Added.
4:32 PM Changeset in webkit [16132] by beidson
  • 7 edits in trunk

WebCore:

Reviewed by John

<rdar://problem/4707718> - Instead of faking the user out with an in-memory icon database if their
~/Library/Safari/Icons is unwritable, we'll actually fail to open the icon database and the app will
run as if it was disabled via a preference.
Also took the opportunity to change some ASSERTS() to reasonable behavior

  • bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge openSharedDatabaseWithPath:]): NSLog on failure so the user has a chance to figure out there's a problem. (-[WebCoreIconDatabaseBridge closeSharedDatabase]): (-[WebCoreIconDatabaseBridge iconForPageURL:withSize:]): From here on, just replaced ASSERTS() with reasonable behavior (-[WebCoreIconDatabaseBridge iconURLForPageURL:]): (-[WebCoreIconDatabaseBridge defaultIconWithSize:]): (-[WebCoreIconDatabaseBridge retainIconForURL:]): (-[WebCoreIconDatabaseBridge releaseIconForURL:]): (-[WebCoreIconDatabaseBridge _setIconData:forIconURL:]): (-[WebCoreIconDatabaseBridge _setHaveNoIconForIconURL:]): (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]): (-[WebCoreIconDatabaseBridge _hasEntryForIconURL:]):
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open): If we fail to open, return false (WebCore::IconDatabase::~IconDatabase): cleanup better
  • loader/icon/IconDatabase.h:

WebKit:

Reviewed by John

<rdar://problem/4707718> Change behavior so if the WebCore::IconDatabase can't open, WebKit releases the bridge and
continues on as if the IconDatabase is disabled.


  • Misc/WebIconDatabase.m: (-[WebIconDatabase init]): Release the bridge on failure to open
  • WebCoreSupport/WebIconDatabaseBridge.m: (+[WebIconDatabaseBridge sharedBridgeInstance]): Moved static shared instance out as a global (-[WebIconDatabaseBridge dealloc]): Clear pointer to the shared instance
4:27 PM Changeset in webkit [16131] by thatcher
  • 2 edits
    1 add in trunk/WebKit

Reviewed by Darin.

Simplify the header copies from WebCore and JavaScriptCore.
Headers that need to be migrated from the other projects need
to be added to MigrateHeaders.make.

  • MigrateHeaders.make: Added.
  • WebKit.xcodeproj/project.pbxproj:
3:09 PM Changeset in webkit [16130] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/4708007> REGRESSION: text field inside a webpage no longer has settable AXValueAttribute
<rdar://problem/4707479> REGRESSION: controls inside a webpage no longer have settable AXFocusedAttribute

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject canSetFocusAttribute]): (-[WebCoreAXObject canSetValueAttribute]): New utility methods. Text fields and buttons are focusable. Text fields can have their value set. We need not make popupbutton value settable because AppKit does not.


(-[WebCoreAXObject accessibilityIsAttributeSettable:]):
Call new utility methods.


(-[WebCoreAXObject accessibilitySetValue:forAttribute:]):
Set focus for text field or button.
Set value for text field.

2:46 PM Changeset in webkit [16129] by hyatt
  • 6 edits in trunk/WebCore

Fix for bugs 9000 and 10606. Add code to suppress painting when
a FOUC situation would otherwise occur. There will still typically be
a flash to white, but at least the wrong content won't show.

Reviewed by darin

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::updateLayoutIgnorePendingStylesheets): (WebCore::Document::preferredStylesheetSet): (WebCore::Document::selectedStylesheetSet): (WebCore::Document::setSelectedStylesheetSet): (WebCore::Document::stylesheetLoaded): (WebCore::Document::updateStyleSelector):
  • dom/Document.h: (WebCore::Document::haveStylesheetsLoaded):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): (WebCore::isSubframe): (WebCore::RenderLayer::hitTest):
  • rendering/RenderView.cpp: (WebCore::RenderView::repaintViewRectangle):
2:19 PM Changeset in webkit [16128] by weinig
  • 1 edit in trunk/WebKit/WebKit.xcodeproj/project.pbxproj

Fix build for Drosera.

2:12 PM Changeset in webkit [16127] by spadma
  • 17 edits in S60/trunk/WebKit

2006-08-30 ligman <​joseph.ligman@nokia.com>

Reviewed by Sachin.
DESC: Requests that are not handled by ResolveLinkL or ResolveEmbeddedLinkL need a status
returned from BufferLoader's RequestL method. The following methods are modified to return
a status code: QueueTransaction, SubmitTransaction, DoSubmitTransaction, SubmitTransaction, DoSubmit.
If the return type is not KErrNone (which can only happen in the case of a BufferTransaction) try
to request the transaction from another transaction type.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=10605

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
  • ResourceLoader/inc/AboutTransaction.h:
  • ResourceLoader/inc/BaseTransaction.h:
  • ResourceLoader/inc/BufferTransaction.h:
  • ResourceLoader/inc/DataTransaction.h:
  • ResourceLoader/inc/FileTransaction.h:
  • ResourceLoader/inc/HttpTransaction.h: (CHttpTransaction::SetIsRedirected): (CHttpTransaction::IsRedirected):
  • ResourceLoader/inc/UrlLoader.h:
  • ResourceLoader/src/AboutTransaction.cpp: (CAboutTransaction::DoSubmitL):
  • ResourceLoader/src/BaseTransaction.cpp: (CBaseTransaction::BaseConstructL): (CBaseTransaction::SubmitTransaction):
  • ResourceLoader/src/BufferTransaction.cpp: (CBufferTransaction::~CBufferTransaction): (CBufferTransaction::SubmitTransaction): (CBufferTransaction::DoSubmitL): (CBufferTransaction::HandleClientDataChunkL):
  • ResourceLoader/src/DataTransaction.cpp: (CDataTransaction::DoSubmitL): (CDataTransaction::CreateHeaderResponseLC):
  • ResourceLoader/src/FileTransaction.cpp: (CFileTransaction::DoSubmitL): (CFileTransaction::CreateHeaderResponseLC): (CFileTransaction::MHFRunL): (CFileTransaction::ParseFileNameLC): (CFileTransaction::ContentEncoding):
  • ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::DoSubmitL):
  • ResourceLoader/src/RequestDispatcher.cpp: (CRequestDispatcher::DispatchL):
  • ResourceLoader/src/UrlLoader.cpp: (CUrlLoader::RequestL): (CUrlLoader::QueueTransaction): (CUrlLoader::SubmitNextTransaction): (CUrlLoader::DoSubmitTransaction):
1:47 PM Changeset in webkit [16126] by rwlbuis
  • 4 edits in trunk/WebCore

2006-08-31 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Eric. Landed by rwlbuis.

Apply Rob's fixes in RenderPathQt too -> unbreak build.

1:36 PM Changeset in webkit [16125] by weinig
  • 12 edits
    2 adds in trunk

WebCore:

Reviewed by Tim H.

Auto-generates DOMHTMLBaseElement, DOMHTMLBodyElement, DOMHTMLHeadElement,
DOMHTMLHtmlElement, DOMHTMLIsIndexElement, DOMHTMLLinkElement,
DOMHTMLMetaElement, DOMHTMLStyleElement and DOMHTMLTitleElement.

Splits DOMHTMLDocument into it's own files.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMHTML.h:
  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMHTMLDocument.h: Added.
  • bindings/objc/DOMHTMLDocument.mm: Added. (-[DOMHTMLDocument WebCore::]): (-[DOMHTMLDocument title]): (-[DOMHTMLDocument setTitle:]): (-[DOMHTMLDocument referrer]): (-[DOMHTMLDocument domain]): (-[DOMHTMLDocument URL]): (-[DOMHTMLDocument body]): (-[DOMHTMLDocument setBody:]): (-[DOMHTMLDocument images]): (-[DOMHTMLDocument applets]): (-[DOMHTMLDocument links]): (-[DOMHTMLDocument forms]): (-[DOMHTMLDocument anchors]): (-[DOMHTMLDocument cookie]): (-[DOMHTMLDocument setCookie:]): (-[DOMHTMLDocument open]): (-[DOMHTMLDocument close]): (-[DOMHTMLDocument write:]): (-[DOMHTMLDocument writeln:]): (-[DOMHTMLDocument getElementById:]): (-[DOMHTMLDocument getElementsByName:]): (-[DOMHTMLDocument createDocumentFragmentWithMarkupString:baseURL:]): (-[DOMHTMLDocument createDocumentFragmentWithText:]):
  • bindings/objc/DOMHTMLInternal.h:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • html/HTMLDocument.idl:

WebKit:

Reviewed by Tim H.

  • WebKit.xcodeproj/project.pbxproj:
1:24 PM Changeset in webkit [16124] by eseidel
  • 3 edits in trunk/WebCore

2006-08-30 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel.

Use QColor <-> Color conversion operator, instead of faking it.

  • platform/qt/FontQt.cpp: (WebCore::Font::drawGlyphs):
  • platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::fillRect):
1:20 PM Changeset in webkit [16123] by rwlbuis
  • 9 edits in trunk

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10586
pointer-events has issues when things are not stroked/filled

Add a param to fillContains/strokeContains to indicate
whether we still want hit testing when there is no fill/stroke.

1:00 PM Changeset in webkit [16122] by justing
  • 15 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4700297>
REGRESSION: After replacing a misspelled word in a sentence, the selection extends to end of current line


Fixed:

  • editing/pasteboard/smart-paste-002-expected.checksum:
  • editing/pasteboard/smart-paste-002-expected.png:
  • editing/pasteboard/smart-paste-002-expected.txt: Added to demonstrate fix:
  • editing/pasteboard/4700297-expected.checksum: Added.
  • editing/pasteboard/4700297-expected.png: Added.
  • editing/pasteboard/4700297-expected.txt: Added.
  • editing/pasteboard/4700297.html: Added. Removed a superfluous style span:
  • editing/deleting/pruning-after-merge-1-expected.txt:
  • editing/pasteboard/interchange-newline-1-expected.txt:
  • editing/pasteboard/paste-text-019-expected.checksum:
  • editing/pasteboard/paste-text-019-expected.png:
  • editing/pasteboard/paste-text-019-expected.txt:
  • editing/selection/drag-to-contenteditable-iframe-expected.txt: Accidently checked in bad results yesterday:
  • editing/pasteboard/copy-paste-bidi-expected.txt: Equivalent render tree:
  • editing/pasteboard/smart-paste-001-expected.txt:

WebCore:

Reviewed by harrison


<rdar://problem/4700297>
REGRESSION: After replacing a misspelled word in a sentence, the selection extends to end of current line

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Rebalance whitespace around insertionPos before insertion because the content might cause a collapse, e.g. inserting <div>foo</div> at hello world.
  • editing/htmlediting.cpp: (WebCore::rebalanceWhitespaceInTextNode): Rebalance with all nbsps for simplicity, we can produce sequences of regular spaces and nbsps on serialization (10636).
12:37 PM Changeset in webkit [16121] by eseidel
  • 3 edits in trunk/WebCore

2006-08-30 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel.

The old solution was slow & does not work correctly.
Move the QString -> DeprecatedString conversion into
DeprectedString.cpp, to be able to access allocateHandle().

  • platform/DeprecatedString.cpp: (WebCore::DeprecatedString::DeprecatedString):
  • platform/qt/StringQt.cpp:
12:16 PM Changeset in webkit [16120] by aroben
  • 2 edits in trunk/WebCore

Reviewed/landed by Adam.

Implement containsCharacters() / determinePitch() functions.

  • platform/qt/FontDataQt.cpp: (WebCore::FontData::containsCharacters): (WebCore::FontData::determinePitch):
11:58 AM Changeset in webkit [16119] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Darin's rubberstamp

We apparently have a fancy delateAllValues() helper for HashMap/Sets - I'll use that instead

  • WebCore.xcodeproj/project.pbxproj:
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::removeAllIcons):
11:48 AM Changeset in webkit [16118] by ggaren
  • 3 edits in trunk/WebKitTools

Reviewed by ggaren.

  • Verification of exceptions thrown in a plugin. Test for bug 10114.
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/ObjCPlugin.m: (+[ObjCPlugin isSelectorExcludedFromWebScript:]): (+[ObjCPlugin webScriptNameForSelector:]): (-[ObjCPlugin throwIfArgumentIsNotHello:]):
11:45 AM Changeset in webkit [16117] by ggaren
  • 9 edits in trunk

JavaScriptCore:

Reviewed, tweaked by ggaren.


  • kjs/ExecState.cpp: (KJS::ExecState::ExecState):
  • kjs/ExecState.h:
  • kjs/context.h: (KJS::Context::setExecState): (KJS::Context::execState):

LayoutTests:

Reviewed by ggaren.

WebCore:

Reviewed, tweaked by ggaren.


11:32 AM Changeset in webkit [16116] by adele
  • 10 edits in trunk

WebCore:

Reviewed by Darin.

  • page/Frame.cpp: (WebCore::Frame::mayCopy): Added. Checks to see if the selection is within a password field.
  • page/Frame.h: Added mayCopy.
  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::handleMouseMoveEvent): Checks mayCopy before starting a drag. (WebCore::FrameMac::mayDHTMLCut): Renamed to match the bridge method. This also checks mayCopy now. (WebCore::FrameMac::mayDHTMLCopy): ditto. (WebCore::FrameMac::tryDHTMLCut): ditto. (WebCore::FrameMac::tryDHTMLCopy): ditto. (WebCore::FrameMac::mayDHTMLPaste): Renamed to match the bridge function. (WebCore::FrameMac::tryDHTMLPaste): ditto.
  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge mayCopy]): Calls the renamed method on frame. (-[WebCoreFrameBridge mayDHTMLCut]): ditto. (-[WebCoreFrameBridge mayDHTMLCopy]): ditto. (-[WebCoreFrameBridge mayDHTMLPaste]): ditto. (-[WebCoreFrameBridge tryDHTMLCut]): ditto. (-[WebCoreFrameBridge tryDHTMLCopy]): ditto. (-[WebCoreFrameBridge tryDHTMLPaste]): ditto.
  • css/html4.css: Added !important to the -webkit-text-security property for password fields.

WebKit:

Reviewed by Darin.

WebKit part of fix for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10576
Disallow copy from new password fields

  • WebView/WebHTMLView.m: (-[WebHTMLView _canCopy]): Now also calls across the bridge to ask if it mayCopy. (-[WebHTMLView _canCut]): Calls _canCopy now. (-[NSArray validateUserInterfaceItem:]): Calls _canCut when validating the "Cut" menu item. This used to call _canDelete (which used to be the same as _canCut), but now _canCut also checks _canCopy.
11:29 AM Changeset in webkit [16115] by thatcher
  • 9 edits in trunk

JavaScriptCore:

Reviewed by Tim H.

Commit KDE related tweaks, to be able to
differentiate between a Qt-only or a KDE build.

  • CMakeLists.txt: Install wtf-unity library.
  • wtf/Platform.h: Add define for the KDE platform.

WebCore:

Reviewed by Tim H.

Commit KDE related tweaks, to be able to
differentiate between a Qt-only or a KDE build.

  • CMakeLists.txt: Move global variables up to trunk/CMakeLists.txt.

Also rename USE_WEBKIT_SVG_SUPPORT to WEBKIT_USE_SVG_SUPPORT.

WebKitTools:

Reviewed by Tim H.

Commit KDE related tweaks, to be able to
differentiate between a Qt-only or a KDE build.

  • DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt: Add ksvg2/ includes.
  • QtLauncher/CMakeLists.txt: Add ksvg2/ includes.
11:24 AM Changeset in webkit [16114] by thatcher
  • 3 edits in trunk/WebCore

Rubber-stamped by Brady.

Fix for the generated headers to make the build work
during "installhdrs" builds. Also export DOM headers
using the #import <WebCore/DOM*.h> syntax.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorObjC.pm:
11:15 AM Changeset in webkit [16113] by brmorris
  • 1 copy in S60/branches/s60-RnD-06wk35

Branching for release S60 RnD release 2006w35

9:50 AM Changeset in webkit [16112] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Eric and Tim H.

Bug 10634: -webView:dragDestinationActionMaskForDraggingInfo: is ignored
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10634


Remove the check for canShowFile: from _web_bestURL: since
it shouldn't be concerned with whether or not the view
can show the URL, merely return the most appropriate URL.

  • Misc/WebNSPasteboardExtras.m: (-[NSPasteboard _web_bestURL]):
  • Misc/WebNSViewExtras.m: (-[NSView _web_dragOperationForDraggingInfo:]):
1:11 AM Changeset in webkit [16111] by beidson
  • 9 edits in trunk

WebCore:

Reviewed by Kevin Decker (Sarge)

<rdar://problem/4678414> - New IconDB needs to delete icons when asked
<rdar://problem/4707718> - If user's Icon directory is unwritable, Safari will crash at startup

  • bridge/mac/WebCoreIconDatabaseBridge.h:
  • bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge removeAllIcons]): Added
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open): If DB file is not writeable, create an in-memory DB for this session (WebCore::IconDatabase::close): Use new deleteAllPreparedStatements() (WebCore::IconDatabase::removeAllIcons): Actually implemented (WebCore::IconDatabase::deleteAllPreparedStatements): Added for convinience/consistency (WebCore::IconDatabase::setPrivateBrowsingEnabled): Use new SQLDatabase::clearAllTables()
  • loader/icon/IconDatabase.h:
  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::clearAllTables): Moved this from IconDatabase as it actually belongs here (WebCore::SQLDatabase::vacuum): Added
  • loader/icon/SQLDatabase.h: (WebCore::SQLDatabase::path): changed name from getPath()

WebKit:

Reviewed by Kevin Decker (Sarge)

<rdar://problem/4678414> - New IconDB needs to delete icons when asked

  • Misc/WebIconDatabase.m: (-[WebIconDatabase removeAllIcons]): Call through to WebCore to remove icons, then send notification

Aug 29, 2006:

10:07 PM Changeset in webkit [16110] by beidson
  • 7 edits in trunk

WebCore:

Reviewed by Alice

Added a truth value to setIconURLForPageURL so WebKit can avoid sending a notification
This is a win on the iBench

  • bridge/mac/WebCoreIconDatabaseBridge.h:
  • bridge/mac/WebCoreIconDatabaseBridge.mm: (-[WebCoreIconDatabaseBridge _setIconURL:forPageURL:]):
  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::setIconURLForPageURL):
  • loader/icon/IconDatabase.h:

WebKit:

Reviewed by Alice

Added a truth value check for to setIconURL:forURL so WebKit can avoid sending a notification
This is a win on the iBench

  • Misc/WebIconDatabase.m: (-[WebIconDatabase _setIconURL:forURL:]):
9:59 PM Changeset in webkit [16109] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Brady.

Fixed <rdar://problem/4702021> REGRESSION: WebClip and Weather widgets shift downward vertically on screen after I drag them out from dashboard configure bar

  • platform/mac/ScreenMac.mm: (WebCore::flipScreenRect): reverted the one line in this method back to what it was before r15765. This changed caused window.screenY to be incorrect.
5:48 PM Changeset in webkit [16108] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • test for <rdar://problem/4701494> REGRESSION: Scrollbar on EPSN widget doesn't scroll (also affects Widgets widget, web inspector)
  • fast/css/computed-style-negative-top-expected.txt: Added.
  • fast/css/computed-style-negative-top.html: Added.

WebCore:

Reviewed by Hyatt.

  • fix <rdar://problem/4701494> REGRESSION: Scrollbar on EPSN widget doesn't scroll (also affects Widgets widget, web inspector)

The bug was that we would return "none" for computed style properties when they were
exactly "-1px".

Test: fast/css/computed-style-negative-top.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForLength): Moved special case for "undefined length" out of here. (WebCore::valueForMaxLength): Moved it into here. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Use valueForMaxLength only for max-height and max-width.
4:35 PM Changeset in webkit [16107] by eseidel
  • 2 edits in trunk/WebCore

2006-08-29 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel.

Add path-related SVG JavaScript bindings to generation.

  • CMakeLists.txt:
4:19 PM Changeset in webkit [16106] by eseidel
  • 8 edits
    9 copies
    14 moves in trunk/WebCore

2006-08-29 Eric Seidel <​eric@eseidel.com>

Reviewed by kevin.

Re-enable path-related SVG JavaScript bindings.
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10623
Split all SVGPathSeg*.idl files into Abs and Rel pieces.
Move all SVGPath*.idl files into ksvg2/svg

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorJS.pm: Special case Abs and Rel header includes
  • ksvg2/bindings/idl/svg/SVGAnimatedNumber.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathElement.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSeg.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegArc.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegClosePath.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubic.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoCubicSmooth.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadratic.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegCurvetoQuadraticSmooth.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegLineto.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegLinetoHorizontal.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegLinetoVertical.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegList.idl: Removed.
  • ksvg2/bindings/idl/svg/SVGPathSegMoveto.idl: Removed.
  • ksvg2/ksvg.h: move SVGPathSegment enum
  • ksvg2/svg/SVGPathElement.cpp: move SVGPathSegment enum (WebCore::SVGPathElement::toPathData):
  • ksvg2/svg/SVGPathSeg.cpp: (WebCore::SVGPathSeg::SVGPathSeg):
  • ksvg2/svg/SVGPathSeg.h: (WebCore::SVGPathSeg::):
  • ksvg2/svg/SVGPathSegArcAbs.idl: Added.
  • ksvg2/svg/SVGPathSegArcRel.idl: Added.
  • ksvg2/svg/SVGPathSegCurvetoCubicAbs.idl: Added.
  • ksvg2/svg/SVGPathSegCurvetoCubicRel.idl: Added.
  • ksvg2/svg/SVGPathSegCurvetoCubicSmoothAbs.idl: Added.
  • ksvg2/svg/SVGPathSegCurvetoCubicSmoothRel.idl: Added.
  • ksvg2/svg/SVGPathSegCurvetoQuadraticAbs.idl: Added.
  • ksvg2/svg/SVGPathSegCurvetoQuadraticRel.idl: Added.
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl: Added.
  • ksvg2/svg/SVGPathSegCurvetoQuadraticSmoothRel.idl: Added.
  • ksvg2/svg/SVGPathSegLinetoAbs.idl: Added.
  • ksvg2/svg/SVGPathSegLinetoHorizontalAbs.idl: Added.
  • ksvg2/svg/SVGPathSegLinetoHorizontalRel.idl: Added.
  • ksvg2/svg/SVGPathSegLinetoRel.idl: Added.
  • ksvg2/svg/SVGPathSegLinetoVerticalAbs.idl: Added.
  • ksvg2/svg/SVGPathSegLinetoVerticalRel.idl: Added.
  • ksvg2/svg/SVGPathSegMovetoAbs.idl: Added.
  • ksvg2/svg/SVGPathSegMovetoRel.idl: Added.
4:13 PM Changeset in webkit [16105] by andersca
  • 1 edit in trunk/CMakeLists.txt

Forgot this

3:52 PM Changeset in webkit [16104] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Tim Hatcher.

  • Scripts/gdb-safari: Set DYLD_FRAMEWORK_PATH inside gdb instead of setting it in gdb's environment to work around what seems to be a bug in some versions of gdb.
3:49 PM Changeset in webkit [16103] by andersca
  • 7 edits
    1 add
    1 delete in trunk/WebCore

2006-08-28 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Eric, landed by Anders.

Fixes one chunk of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10604

Finish Unity merging. Remove libcurl usage, in favour of KIO.
This makes the regression testing fly! IO processing is way faster now.

  • CMakeLists.txt:
  • platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
  • platform/qt/FrameQt.cpp: (WebCore::FrameQt::openURL): (WebCore::FrameQt::submitForm): (WebCore::FrameQt::urlSelected): (WebCore::FrameQt::createEmptyDocument): (WebCore::FrameQt::receivedData): (WebCore::FrameQt::receivedAllData):
  • platform/qt/FrameQt.h:
  • platform/qt/ResourceLoaderCurl.cpp: Removed.
  • platform/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::ResourceLoaderManager): (WebCore::ResourceLoaderManager::~ResourceLoaderManager): (WebCore::ResourceLoaderManager::self): (WebCore::ResourceLoaderManager::slotData): (WebCore::ResourceLoaderManager::slotMimetype): (WebCore::ResourceLoaderManager::slotResult): (WebCore::ResourceLoaderManager::remove): (WebCore::ResourceLoaderManager::add):
  • platform/qt/ResourceLoaderManager.h:
  • platform/qt/ResourceLoaderQt.cpp: Added. (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::cancel): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::retrieveCharset): (WebCore::ResourceLoader::receivedResponse):
3:37 PM Changeset in webkit [16102] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatchers rubber stamp

Removed some accidentally left-in console spew during the conversion to the new DB


  • Misc/WebIconDatabase.m: (objectFromPathForKey): Nuked some NSLogs
3:24 PM Changeset in webkit [22131] by sfalken
  • 1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

Fix build

3:14 PM Changeset in webkit [16101] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Darin Adler.

<rdar://problem/4688618> REGRESSION(10.4.7-9A241): JMol java applet fails in Safari not Firefox

No layout test for now because Java doesn't work in DumpRenderTree.

  • Plugins/WebPluginDatabase.m: (-[WebPluginDatabase refresh]): Add each plug-in MIME type to registeredMIMETypes, even if we don't register a document view class for the MIME type. This fixes -[WebPluginDatabase isMIMETypeRegistered:] and thus fallback content for Java applets (we were always rendering fallback content, if any, for Java applets).
2:58 PM Changeset in webkit [16100] by thatcher
  • 3 edits in trunk/WebCore

Reviewed by Eric.

Bug 10632: Objective-C DOM should use the @property syntax for DOM attributes
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10632

Generate @property when MACOSX_DEPLOYMENT_TARGET is >= 10.5.
This is backwards compatible with the getter/setter methods.
Generate setter arguments with a "new" prefix to avoid the property
name conflict warning. Also removes some whitespace and the comments
that we added to the headers. This makes the headers look like what we ship now.

  • bindings/objc/DOMCSS.mm: (-[DOMDocument getComputedStyle::]): renamed a local variable to avoid the property name conflict. (-[DOMDocument getMatchedCSSRules::]): ditto.
  • bindings/scripts/CodeGeneratorObjC.pm: generate @property in the headers.
2:57 PM Changeset in webkit [22130] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Land remaining CG integration patch.

2:40 PM Changeset in webkit [16099] by andersca
  • 2 edits in trunk/WebCore

2006-08-30 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by Anders.

Fix time calculation, by using a correct calculation. Calling time()
returns a number of seconds, aka. an integer. Fix it by using gettimeofday().
Patch originally proposed by Ronan Meneu <​rmeneu@origyn.fr>

  • platform/qt/SystemTimeQt.cpp: (WebCore::currentTime):
1:43 PM Changeset in webkit [22129] by hyatt
  • 5 edits
    11 adds in branches/WindowsMerge/WebCore

This patch lands all the font changes. It does not patch the project file
yet, since this was done on Mac. Will switch to Win32 after landing this
and then fix any glitches.

  • platform/cairo/cairo-all.c: Added.
  • platform/cairo/pixman-all.c: Added.
  • platform/image-decoders/jpeg/jpeg-part1.c: Added.
  • platform/image-decoders/jpeg/jpeg-part2.c: Added.
  • platform/image-decoders/jpeg/jpeg-part3.c: Added.
  • platform/image-decoders/png/png-part1.c: Added.
  • platform/image-decoders/png/png-part2.c: Added.
  • platform/win/FontDataWin.cpp: (WebCore::FontData::platformInit): (WebCore::FontData::platformDestroy): (WebCore::FontData::platformWidthForGlyph):
  • platform/win/FontPlatformData.h: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::cgFont): (WebCore::FontPlatformData::operator==):
  • platform/win/FontPlatformDataWin.cpp: (WebCore::m_size):
  • platform/win/FontWin.cpp: (WebCore::Font::drawGlyphs):
1:33 PM Changeset in webkit [16098] by weinig
  • 29 edits
    12 adds in trunk

WebCore:

Reviewed by Tim H.

Auto-generates DOMHTMLCollection, DOMHTMLElement, DOMHTMLFormElement,
and DOMHTMLOptionsCollection, and lays groundwork for the rest of the
HTML DOM bindings by adding/fixing the appropriate IDL's and updating
the CodeGeneratorObjC.pm build script.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMHTML.h:
  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMHTMLInternal.h:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCollection.idl: Added.
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl: Added.
  • html/HTMLFrameSetElement.idl: Added.
  • html/HTMLIFrameElement.idl: Added.
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLObjectElement.idl: Added.
  • html/HTMLOptionsCollection.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLSelectElement.idl: Added.
  • html/HTMLStyleElement.idl:
  • html/HTMLTableCaptionElement.idl: Added.
  • html/HTMLTableCellElement.idl: Added.
  • html/HTMLTableColElement.idl: Added.
  • html/HTMLTableElement.idl: Added.
  • html/HTMLTableRowElement.idl: Added.
  • html/HTMLTableSectionElement.idl: Added.
  • html/HTMLTextAreaElement.idl:

WebKit:

Reviewed by Tim H.

Auto-generates DOMHTMLCollection, DOMHTMLElement, DOMHTMLFormElement,
and DOMHTMLOptionsCollection.

  • WebKit.xcodeproj/project.pbxproj:
1:05 PM Changeset in webkit [16097] by ap
  • 2 edits in trunk/WebCore

2006-08-29 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by ap.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10629.
Drawing convex polygons is broken in the Qt platform.

  • platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawConvexPolygon):
12:16 PM Changeset in webkit [16096] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Eric.

Implementing font hashing properly, fixes weird crashes in HashMap.

  • platform/qt/FontPlatformData.h:
  • platform/qt/FontPlatformDataQt.cpp: (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::hash):
12:11 PM Changeset in webkit [16095] by ggaren
  • 2 edits in trunk/WebCore

Reviewed by ggaren.

Fix scrollbars to reappear after the first layouting.

  • platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::suppressScrollBars):
11:58 AM Changeset in webkit [16094] by andersca
  • 6 edits
    2 copies
    3 adds
    1 delete in trunk/WebCore

2006-08-29 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin and Geoff.

Move the CF String functions to separate files in platform/cf.
Also, move the files in platform/cfnet to platform/cf.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/PlatformString.h:
  • platform/StringImpl.h:
  • platform/cf/StringCF.cpp: Added. (WebCore::String::String):
  • platform/cf/StringImplCF.cpp: Added. (WebCore::StringImpl::createCFString):
  • platform/cfnet/KURLCFNet.cpp: Removed.
  • platform/cfnet/ResourceLoaderCFNet.cpp: Removed.
  • platform/mac/StringImplMac.mm:
  • platform/mac/StringMac.mm:
11:57 AM Changeset in webkit [22128] by hyatt
  • 2 edits
    4 adds in branches/WindowsMerge/WebCore

Forking the font files in preparation for dropping in CG code.

Reviewed by adam

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/FontDataWin.cpp: Added. (WebCore::FontData::platformInit): (WebCore::FontData::platformDestroy): (WebCore::FontData::smallCapsFontData): (WebCore::FontData::containsCharacters): (WebCore::FontData::determinePitch): (WebCore::FontData::platformWidthForGlyph):
  • platform/win/FontPlatformData.h: Added. (WebCore::FontPlatformData::FontPlatformData): (WebCore::FontPlatformData::hfont): (WebCore::FontPlatformData::fontFace): (WebCore::FontPlatformData::scaledFont): (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::hash): (WebCore::FontPlatformData::operator==):
  • platform/win/FontPlatformDataWin.cpp: Added. (WebCore::m_size): (WebCore::FontPlatformData::~FontPlatformData):
  • platform/win/FontWin.cpp: Added. (WebCore::notImplemented): (WebCore::Font::drawGlyphs): (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
11:56 AM Changeset in webkit [16093] by ggaren
  • 3 edits in trunk/WebCore

Rolling out a change I included by accident in my last commit.


  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::passMouseDownEventToWidget):
  • platform/mac/SharedTimerMac.cpp: (WebCore::setSharedTimerFireTime):
10:30 AM Changeset in webkit [16092] by spadma
  • 3 edits in S60/trunk/WebKit

2006-08-29 yaharon <​yael.aharon@nokia.com>

Reviewed by Sachin.
Fix build warnings and export cache header file

  • BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::HandlePointerEventL):
  • group/bld.inf:
10:25 AM Changeset in webkit [16091] by beidson
  • 6 edits
    4 deletes in trunk/WebKit

Reviewed by Darin

Short of a few small snippets that still need to be pushed to WebCore, this
is a final prune of WebIconDatabase. WebFileDatabase and WebLRUFileList are gone
and the small remaining snippets of WebFileDatabase code that were still important
are now in static functions in WebIconDatabase.m

  • Loader/WebIconLoader.m: (-[WebIconLoader didFinishLoading]): Removed the flag
  • Misc/WebFileDatabase.h: Removed.
  • Misc/WebFileDatabase.m: Removed.
  • Misc/WebIconDatabase.m: (+[WebIconDatabase sharedIconDatabase]): (-[WebIconDatabase init]): (-[WebIconDatabase iconForURL:withSize:cache:]): (-[WebIconDatabase iconURLForURL:]): (-[WebIconDatabase defaultIconWithSize:]): (-[WebIconDatabase retainIconForURL:]): (-[WebIconDatabase releaseIconForURL:]): (-[WebIconDatabase _isEnabled]): (-[WebIconDatabase _setIconData:forIconURL:]): (-[WebIconDatabase _setHaveNoIconForIconURL:]): (-[WebIconDatabase _setIconURL:forURL:]): (-[WebIconDatabase _hasEntryForIconURL:]): (-[WebIconDatabase _applicationWillTerminate:]): (-[WebIconDatabase _resetCachedWebPreferences:]): (uniqueFilePathForKey): Added from WebFileDatabase (objectFromPathForKey): Added from WebFileDatabase (iconDataFromPathForIconURL): (-[WebIconDatabase _convertToWebCoreFormat]): Make use of static functions and local variables instead of using WebFileDatabase and WebIconDatabase variables that are now obsolete
  • Misc/WebIconDatabasePrivate.h: Removed alot of obsoleted members
  • Misc/WebLRUFileList.h: Removed.
  • Misc/WebLRUFileList.m: Removed.
  • WebKit.xcodeproj/project.pbxproj: Deleted 4 files
  • WebKitPrefix.h: Removed ICONDEBUG
10:07 AM Changeset in webkit [22127] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-08-29 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Ada.

  • WebKitDLL.cpp: (DllMain): Set the global instance handle.
8:33 AM Changeset in webkit [16090] by spadma
  • 2 edits in S60/trunk/WebKit

2006-08-28 zhalu <​zhaosong.lu@nokia.com>

Reviewed by Sachin.
DESC: Update the minimap setting from pagescaler
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10504

  • BrowserView/src/WebKitView.cpp: (CWebKitView::InitializePageScalerL):

Aug 28, 2006:

6:13 PM Changeset in webkit [16089] by ggaren
  • 14 edits
    3 adds in trunk

Reviewed by Maciej.


Added support for experimental CFNetwork-based loader (not turned on yet).


While I was there, I did the following platform cleanup:

  • Windows now uses USE(WININET) instead of PLATFORM(WIN_OS), to match the USE(CFNETWORK) idiom.
  • Removed some #includes of windows.h in platform-independent headers.
  • Changed #ifdef APPLE to PLATFORM(MAC)
  • Fixed some build bustage, including case-sensitive filesystem bustage.
  • loader/loader.cpp: (WebCore::Loader::receivedAllData):
  • platform/Cursor.h:
  • platform/KURL.h:
  • platform/ResourceLoader.h:
  • platform/ResourceLoaderClient.h:
  • platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
  • platform/cfnet/KURLCFNet.cpp: Added. (WebCore::KURL::createCFURL):
  • platform/cfnet/ResourceLoaderCFNet.cpp: Added. (WebCore::willSendRequest): (WebCore::didReceiveChallenge): (WebCore::didCancelChallenge): (WebCore::didReceiveResponse): (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::willCacheResponse): (WebCore::addHeadersFromString): (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): (WebCore::ResourceLoader::~ResourceLoader): (WebCore::arrayFromFormData): (WebCore::emptyPerform): (WebCore::runLoaderThread): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::cancel):
  • platform/win/CursorWin.cpp:
6:05 PM Changeset in webkit [22126] by ggaren
  • 14 edits in branches/WindowsMerge

Reviewed by Maciej.

Landed CFNetwork loader, off by default. To enable, define:

KXMLCORE_PLATFORM_CF
KXMLCORE_USE_CFNETWORK

CFNetwork uses winsock2. If you do this, you need to make sure that winsock2.h
is included before windows.h in any translation unit in which it's used.
A lot of the jiggering in this patch is devoted to that.


  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/ResourceLoaderWin.cpp: Removed reliance on PlatformData since it wasn't being used, and removing it made easy work of integrating CFNetwork in a Windows-independent way. (WebCore::ResourceLoaderWndProc): (WebCore::ResourceLoader::fileLoadTimer): (WebCore::ResourceLoader::cancel):
  • platform/win/TemporaryLinkStubs.cpp: (Path::contains):
  • platform/win/WidgetWin.cpp:
  • plugins/win/PluginDatabaseWin.cpp:
  • plugins/win/PluginPackageWin.h:
  • plugins/win/PluginViewWin.h:
  • plugins/win/npapi.cpp:
  • rendering/RenderPopupMenuWin.cpp:
  • rendering/RenderPopupMenuWin.h:
  • rendering/RenderThemeWin.cpp:
5:59 PM Changeset in webkit [22125] by adachan
  • 4 edits in branches/WindowsMerge
5:35 PM Changeset in webkit [16088] by justing
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/inserting/redo-expected.checksum: Added.
  • editing/inserting/redo-expected.png: Added.
  • editing/inserting/redo-expected.txt: Added.
  • editing/inserting/redo.html: Added.
  • editing/pasteboard/copy-paste-bidi-expected.txt:

WebCore:

Reviewed by harrison


<rdar://problem/4700341>
REGRESSION: In new mail message, caret isn't placed at end of line after redoing typing

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Added a FIXME.
  • page/Frame.cpp: (WebCore::Frame::reappliedEditing): Restore the endingSelection(), not the startingSelection().
5:30 PM Changeset in webkit [16087] by tomernic
  • 2 edits in trunk/WebKit

Reviewed by Darin Adler.

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView createPluginScriptableObject]): Removed a bogus typecast.
4:18 PM Changeset in webkit [16086] by tomernic
  • 7 edits in trunk

WebCore:

Reviewed by John Sullivan.

Part of <rdar://problem/4481553> NetscapeMoviePlugIn example code scripting doesn't work in Firefox (4319)
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4319>: NetscapeMoviePlugIn example code scripting doesn't work
in Firefox

No test cases added, since this is essentially a leak fix.

A brief history of NPP_GetValue(), NPObjects, and reference counting.

Earlier versions of WebKit incorrectly interpreted the NPRuntime reference counting rules. We failed to take
into account the fact that plug-ins are required to retain NPObjects before returning them. This creates several
classes of interesting plug-ins:

1) Plug-ins tested in WebKit and other browsers. These plug-ins may have WebKit-specific workarounds to not retain

the returned NPObject, thus avoiding the memory leak in WebKit.

2) Plug-ins tested only in other browsers. These plug-ins must already retain their NPObjects, since other browsers

implemented the NPRuntime retain/release rules correctly. These plug-ins likely work in WebKit, but probably leak
NPObjects since WebKit adds its own retain in addition to the plug-in's retain.

3) Plug-ins tested only in WebKit, that fail to retain their NPObjects before returning them.

Such plug-ins are guaranteed to crash in other browsers due to the missing expected retain. These plug-ins
work in older WebKits because WebKit did not expect the plug-in to retain the NPObject. Now that our retain
rules match other browsers, these plug-ins may crash due to the difference in retain/release behavior. We could
potentially detect that situation and correct it here, but I consider it a bug that the plug-in did not follow the
documented NPRuntime reference counting rules. Furthermore, it is extremely unlikely that someone would develop
a Netscape plug-in and test it *only* in WebKit. The entire purpose of creating a Netscape plugin is so that it
works in all browsers!

4) Plug-ins tested only in WebKit, that properly retain their NPObjects before returning them.

These plug-ins probably work in other browsers, and leak their NPObjects in older WebKits because of WebKit's
extra retain. A developer of this type of plug-in is probably unaware of the NPObject leak. A more savvy developer
would create a plug-in that fits into category #1.


I am changing our NPP_GetValue() behavior to match Firefox and other browsers -- the plug-in is now expected to retain the
returned NPObject, and the browser is expected to release it when done. This means that plug-ins in category #3 need to be
changed so that they don't crash in Safari. However, such plug-ins already crash in every other browser, so I do not feel that
this needs to be handled specifically by WebKit.

  • bridge/mac/FrameMac.mm: Changed -pluginScriptableObject to -createPluginScriptableObject to make clearer the contract that the method must return a retained NPObject. Also changed it to return an actual NPObject* instead of a void*. There is only one caller of this method, and only one implementor. Using void* here is a needless abstraction. It's an NPObject*! Admit it! (WebCore::getInstanceForView): Release the NPObject after creating the bindings instance. This is the actual bug fix.

WebKit:

Reviewed by John Sullivan.

Part of <rdar://problem/4481553> NetscapeMoviePlugIn example code scripting doesn't work in Firefox (4319)
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4319>: NetscapeMoviePlugIn example code scripting doesn't work
in Firefox

  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView createPluginScriptableObject]): Renamed this method (see corresponding WebCore ChangeLog entry for an explanation). Style changes.

WebKitTools:

Reviewed by John Sullivan.

Part of <rdar://problem/4481553> NetscapeMoviePlugIn example code scripting doesn't work in Firefox (4319)
<​http://bugzilla.opendarwin.org/show_bug.cgi?id=4319>: NetscapeMoviePlugIn example code scripting doesn't work
in Firefox

  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_GetValue): WebKit's NPP_GetValue() reference counting behavior has been changed to match Firefox. NPObject return values are expected to be retained by the plug-in, and released by the caller.
3:56 PM Changeset in webkit [16085] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-08-28 w3liu <​wei.liu@nokia.com>

Reviewed by Zalan Bujtas (​zbujtas@gmail.com).
DESC: Some foreign site encoding errors -- due to encoding alias "X-MS950-HKSCS".
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10607

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQCharsetData.c:
3:48 PM Changeset in webkit [16084] by zbujtas
  • 2 edits in S60/trunk/WebCore

2006-08-25 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Zalan.

WARNING: NO TEST CASES ADDED OR CHANGED

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10573


  • khtml/rendering/render_block.cpp: (khtml::RenderBlock::setStyle):
2:19 PM Changeset in webkit [16083] by brmorris
  • 18 edits in S60/branches/printing_sabina

2006-08-28 sabina <​sabina.siddiqi@nokia.com>

Reviewed by Bradley.


First cut at print implementation.


​http://bugzilla.opendarwin.org/show_bug.cgi?id=9739

  • S60.hrh: Print flags
  • S60StaticLibs.zip: Printing libs
  • WebUi/data/WebUi.rss:
    • WebUi/inc/WebUi.hrh:
    • WebUi/inc/WebUiAppUi.h:
    • WebUi/inc/WebUiLoadObserver.h: (CWebUiLoadObserver::OffScreenBitmapH):
    • WebUi/inc/WebUiWindow.h: (CWebUiWindow::DialogsProvider): (CWebUiWindow::LoadObserver):
    • WebUi/src/WebUiAppUi.cpp: (CWebUiAppUi::ConstructL): (CWebUiAppUi::HandleCommandL): (CWebUiAppUi::ActiveView):
    • WebUi/src/WebUiLoadObserver.cpp: (CWebUiLoadObserver::NewL): (CWebUiLoadObserver::HandleBrowserLoadEventL): (CWebUiLoadObserver::GetProgressInfo):
    • khtml/khtml_part.cpp: (KHTMLPart::print):
    • BrowserView/inc/webkitbridge.h:
    • BrowserView/src/WebKitControl.cpp: (CWebKitControl::FinalProgressComplete):
    • BrowserView/src/webkitbridge.cpp: (CWebKitBridge::Print): (CWebKitBridge::PrintBandL): (CWebKitBridge::NotifyBandPrinted): (CWebKitBridge::NotifyPrintStarted): (CWebKitBridge::NotifyPrintEnded):
    • group/webkit.mmp:
2:08 PM Changeset in webkit [16082] by brmorris
  • 1 copy in S60/branches/printing_sabina

New feature branch

1:43 PM Changeset in webkit [16081] by aliceli1
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff.

Added tests for <rdar://problem/4548537> Document.domain and other attributes are blank for an iframe created with document.write

  • http/tests/misc/iframe-domain-test-expected.txt: Added.
  • http/tests/misc/iframe-domain-test.html: Added.

WebCore:

Reviewed by Geoff.

Fixed <rdar://problem/4548537> Document.domain and other attributes are blank for an iframe created with document.write

  • dom/Document.cpp: (WebCore::Document::open): set the document's url to the parent's url and re-located the code that does this to occur before calling the frame's didExplicitOpen()
  • page/Frame.cpp: (WebCore::Frame::didExplicitOpen): set the frame's url to the document's url
12:00 PM Changeset in webkit [16080] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Adele and Adam

Added an optimization to return early if there's no replacements to be made

  • platform/StringImpl.cpp: (WebCore::StringImpl::replace):
11:49 AM Changeset in webkit [16079] by ap
  • 3 edits
    2 adds in trunk/WebCore

2006-08-28 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by ap.

Fixes one chunk of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10604
Provide stub implementation of RenderPopupMenuQt.

  • CMakeLists.txt:
  • platform/qt/RenderPopupMenuQt.cpp: Added. (WebCore::RenderPopupMenuQt::RenderPopupMenuQt): (WebCore::RenderPopupMenuQt::~RenderPopupMenuQt): (WebCore::RenderPopupMenuQt::clear): (WebCore::RenderPopupMenuQt::populate): (WebCore::RenderPopupMenuQt::showPopup): (WebCore::RenderPopupMenuQt::hidePopup): (WebCore::RenderPopupMenuQt::addSeparator): (WebCore::RenderPopupMenuQt::addGroupLabel): (WebCore::RenderPopupMenuQt::addOption):
  • platform/qt/RenderPopupMenuQt.h: Added.
  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::systemFont): (WebCore::RenderThemeQt::createPopupMenu):
11:40 AM Changeset in webkit [16078] by ap
  • 3 edits in trunk/WebCore

2006-08-28 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by ap.

Fixes one chunk of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10604
Offer QString -> DeprecatedString conversion.

  • platform/DeprecatedString.h:
  • platform/qt/StringQt.cpp: (WebCore::DeprecatedString::DeprecatedString):
11:37 AM Changeset in webkit [16077] by ap
  • 5 edits in trunk

2006-08-28 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Tim Hatcher.

Fixes one chunk of: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10604

WebCore:

  • platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::systemFont): Remove annoying notImplemented() usage in systemFont()

WebKitTools:

  • DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::checkLoaded): Faster polling for isLoaded() in Qt's DumpRenderTree.
  • Scripts/run-webkit-tests: Use -expected-qt.txt etc.. output in run-webkit-test if isQt().
11:25 AM Changeset in webkit [16076] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

  • kjs/list.h: Use explicit in constructor (as appropriate).
11:22 AM Changeset in webkit [16075] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Tim Hatcher.

  • Scripts/build-drosera: Fix behavior when there are multiple options.
11:22 AM Changeset in webkit [16074] by beidson
  • 5 edits
    2 copies in trunk/WebKit

Reviewed by Tim Hatcher's rubberstamp

Rolled out my last change (16070 - pruning WebFileDatabase code) as it caused a difficult-to-track down
failure in layout tests on a release build.

  • Misc/WebFileDatabase.h:
  • Misc/WebFileDatabase.m: (+[WebFileDatabaseOp opWithCode:key:object:]): (-[WebFileDatabaseOp initWithCode:key:object:]): (-[WebFileDatabaseOp opcode]): (-[WebFileDatabaseOp key]): (-[WebFileDatabaseOp object]): (-[WebFileDatabaseOp perform:]): (-[WebFileDatabaseOp dealloc]): (SetThreadPriority): (-[WebFileDatabase _createLRUList:]): (-[WebFileDatabase _truncateToSizeLimit:]): (+[WebFileDatabase _syncLoop:]): (databaseInit): (-[WebFileDatabase setTimer]): (-[WebFileDatabase setObject:forKey:]): (-[WebFileDatabase removeObjectForKey:]): (-[WebFileDatabase removeAllObjects]): (-[WebFileDatabase objectForKey:]): (-[WebFileDatabase performSetObject:forKey:]): (-[WebFileDatabase performRemoveObjectForKey:]): (-[WebFileDatabase open]): (-[WebFileDatabase close]): (-[WebFileDatabase lazySync:]): (-[WebFileDatabase sync]): (-[WebFileDatabase sizeLimit]): (-[WebFileDatabase count]): (-[WebFileDatabase usage]): (-[WebFileDatabase setSizeLimit:]):
  • Misc/WebIconDatabase.m: (-[WebIconDatabase _createFileDatabase]): (-[WebIconDatabase _loadIconDictionaries]):
  • WebKit.xcodeproj/project.pbxproj:
11:18 AM Changeset in webkit [16073] by darin
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher.

  • WebInspector/webInspector/inspector.js: Add "resize: none" to the list of default values for CSS properties so it will be omitted from most displays of computed style.
8:54 AM Changeset in webkit [16072] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/3942647> Support AXStyleTextMarkerRangeForTextMarker parameterized attribute

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityParameterizedAttributeNames]): Add AXStyleTextMarkerRangeForTextMarker.


(startOfStyleRange):
(endOfStyleRange):
Return first/last VisiblePosition in range having the same style has the specified VisiblePosition.

(-[WebCoreAXObject doAXStyleTextMarkerRangeForTextMarker:]):
Return AXTextMarkerRange for startOfStyleRange/endOfStyleRange of the specified AXTextMarker.


(-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
Call doAXStyleTextMarkerRangeForTextMarker for AXStyleTextMarkerRangeForTextMarker.

8:46 AM Changeset in webkit [16071] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4517383> Hide all images used for spacing purpose in AX

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityIsIgnored]): Check for one-dimensional image Check whether rendered image was stretched from one-dimensional file image
2:18 AM Changeset in webkit [16070] by beidson
  • 5 edits
    2 deletes in trunk/WebKit

Reviewed by Maciej

Major prune of unnecessary WebFileDatabase code. In the end, what
useful code that remains in WebFileDatabase will likely be moved directly
into WebIconDatabase

  • Misc/WebFileDatabase.h:
  • Misc/WebFileDatabase.m: (-[WebFileDatabase initWithPath:]): (-[WebFileDatabase objectForKey:]): (-[WebFileDatabase open]): (-[WebFileDatabase close]):
  • Misc/WebIconDatabase.m: (-[WebIconDatabase _createFileDatabase]): (-[WebIconDatabase _loadIconDictionaries]):
  • Misc/WebLRUFileList.h: Removed.
  • Misc/WebLRUFileList.m: Removed.
  • WebKit.xcodeproj/project.pbxproj:
Note: See TracTimeline for information about the timeline view.