Context Navigation

← Previous Period
Next Period →

Timeline

Sep 4, 2006:

10:05 PM Changeset in webkit [16226] by ap

9 edits in trunk

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10716
XMLHttpRequest.responseText is null if HTTP response is empty

Extended existing tests:

http/tests/xmlhttrequest/zero-length-response.html
http/tests/xmlhttrequest/zero-length-response-sync.html

xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): Initialize responseText to an empty string. (WebCore::XMLHttpRequest::open): Reset responseText to an empty string.
bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::getValueProperty): Return null rather than undefined for nil responseXML.

7:45 PM Changeset in webkit [16225] by thatcher

27 edits
1 add in trunk

WebCore:

Reviewed by Darin.

Bug 10714: ObjC autogeneration needs safe-guards against easily modifying the public API
http://bugzilla.opendarwin.org/show_bug.cgi?id=10714

New PublicDOMInterfaces.h file is consulted when generating the ObjC DOM files. All public DOM class interfaces, properties and methods need to be in this file. Anything not in the file will be generated into the appropriate private header file. During generation if something changed or is missing in the public API a build error will occur. New interfaces added to the IDLs files will now not automatically be reflected in the public ObjC API. Methods commented out in PublicDOMInterfaces.h are pending public and will be uncommented once approved.

Removed most of the Exclude=ObjC uses from the IDL files. This attribute was mostly used to prevent changes to the public headers.

Make a new parameter name if the original conflicts with a property name.

Simplified the generation code for dealing with exceptions.

Moved file opens to WriteData. Files are unlinked before being opened to work around a Leopard file truncation bug.

Fixed #imports for DOMImplementation to be DOMDOMImplementation.h

WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOMCSS.h:
bindings/objc/DOMCore.h:
bindings/objc/DOMExtensions.h:
bindings/objc/DOMHTMLInternal.h:
bindings/objc/DOMPrivate.h:
bindings/objc/PublicDOMInterfaces.h: Added.
bindings/scripts/CodeGeneratorObjC.pm:
dom/Document.idl:
dom/Element.idl:
dom/NamedNodeMap.idl:
dom/ProcessingInstruction.idl:
html/HTMLAnchorElement.idl:
html/HTMLAreaElement.idl:
html/HTMLBodyElement.idl:
html/HTMLButtonElement.idl:
html/HTMLImageElement.idl:
html/HTMLInputElement.idl:
html/HTMLLabelElement.idl:
html/HTMLLegendElement.idl:
html/HTMLLinkElement.idl:
html/HTMLOptionsCollection.idl:
html/HTMLPreElement.idl:
html/HTMLStyleElement.idl:
html/HTMLTextAreaElement.idl:

WebKit:

Reviewed by Darin.

Bug 10714: ObjC autogeneration needs safe-guards against easily modifying the public API
http://bugzilla.opendarwin.org/show_bug.cgi?id=10714

Added the new private DOM headers.
Factored out the common commands into variables.
Made WebDashboardRegion.h private again.
Rename DOMDOMImplementation.h to DOMImplementation.h when files are migrated. Also fixes up #imports.

MigrateHeaders.make:

4:36 PM Changeset in webkit [16224] by darin

2 edits in trunk/WebKitTools

Scripts/do-webcore-rename: More renaming plans.

4:16 PM Changeset in webkit [16223] by thatcher

1 edit in trunk/WebKit/WebInspector/WebInspector.m

Another build fix now that the old style ObjC methods are deprecated.

4:10 PM Changeset in webkit [16222] by thatcher

7 edits in trunk

Build fixes now that the old style ObjC methods are deprecated.

3:57 PM Changeset in webkit [16221] by weinig

2 edits in trunk/WebCore

Reviewed by Tim H.

Continue fixing the build, I forgot this in my previous patch!

platform/qt/PathQt.cpp: (WebCore::Path::apply):

3:43 PM Changeset in webkit [16220] by weinig

3 edits in trunk/WebCore

Reviewed by Tim H.

Fix build on Qt/Linux.

CMakeLists.txt:
platform/qt/PathQt.cpp: (WebCore::Path::transform):

3:28 PM Changeset in webkit [16219] by weinig

3 edits
3 adds
1 delete in trunk

WebKitQt:

Reviewed by Tim H.

Fixes last part of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10644
Move QtLauncher down to WebKitQt.

QtLauncher/CMakeLists.txt: Added.
QtLauncher/main.cpp: Added. (main):

WebKitTools:

Reviewed by Tim H.

Fixes last part of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10644
Move QtLauncher down to WebKitQt.

QtLauncher/CMakeLists.txt: Removed.
QtLauncher/main.cpp: Removed.

12:49 PM Changeset in webkit [16218] by ap

1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

The project file didn't get committed with my last checking.

11:34 AM Changeset in webkit [16217] by ap

12 edits
3 adds in trunk

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10676
@charset rules not accessible via DOM

Test: fast/encoding/css-charset-dom.html

WebCore.xcodeproj/project.pbxproj: Added CSSCharsetRule.cpp
bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleSheet::getValueProperty): Separated Rules and CssRules, since now they behave differently.

css/CSSCharsetRule.h: Make the constructor take an encoding.
css/CSSCharsetRule.cpp: Added.

css/CSSGrammar.y: Create CSSStylesheetRules as necessary.

css/CSSRuleList.cpp: (WebCore::CSSRuleList::CSSRuleList):
css/CSSRuleList.h:
css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::cssRules):
css/CSSStyleSheet.h: Skip charset rules in IE compatibility mode.

css/StyleBase.h: (WebCore::StyleBase::isCharsetRule): Fixed a typo.

css/cssparser.cpp: (WebCore::CSSParser::createCharsetRule):
css/cssparser.h: Added createCharsetRule().

10:37 AM Changeset in webkit [16216] by weinig

4 edits
2 adds in trunk/WebCore

Reviewed by Darin.

Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10644
Let FrameQt operate on a FrameQtClient, just like Win/Mac handle it.

CMakeLists.txt:
platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::~FrameQt): (WebCore::FrameQt::openURL): (WebCore::FrameQt::submitForm): (WebCore::FrameQt::urlSelected):
platform/qt/FrameQt.h:
platform/qt/FrameQtClient.cpp: Added. (WebCore::FrameQtClientDefault::FrameQtClientDefault): (WebCore::FrameQtClientDefault::~FrameQtClientDefault): (WebCore::FrameQtClientDefault::setFrame): (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::submitForm): (WebCore::FrameQtClientDefault::receivedResponse): (WebCore::FrameQtClientDefault::receivedData): (WebCore::FrameQtClientDefault::receivedAllData):
platform/qt/FrameQtClient.h: Added. (WebCore::FrameQtClient::~FrameQtClient):

10:34 AM Changeset in webkit [16215] by weinig

4 edits
2 adds in trunk/WebKitTools

Reviewed by Darin.

Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10644
Adjust DumpRenderTree to the FrameQtClient changes.

DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt:
DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::~DumpRenderTree): (WebCore::DumpRenderTree::frame):
DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTreeClient.cpp: Added. (WebCore::DumpRenderTreeClient::DumpRenderTreeClient): (WebCore::DumpRenderTreeClient::~DumpRenderTreeClient):
DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTreeClient.h: Added.

10:11 AM Changeset in webkit [16214] by weinig

1 edit
16 adds in trunk

2:31 AM Changeset in webkit [16213] by eseidel

2 edits in trunk/WebCore

2006-09-04 Eric Seidel <eric@eseidel.com>

Reviewed by andersca.

Clean-up style and spacing.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10724
No tests needed, no functional changes.

ksvg2/svg/svgpathparser.cpp: (WebCore::parseCoord): (WebCore::SVGPolyParser::parsePoints): (WebCore::SVGPathParser::parseSVG): (WebCore::SVGPathParser::calculateArc): (WebCore::SVGPathParser::svgLineToHorizontal): (WebCore::SVGPathParser::svgLineToVertical): (WebCore::SVGPathParser::svgCurveToCubicSmooth): (WebCore::SVGPathParser::svgCurveToQuadratic): (WebCore::SVGPathParser::svgCurveToQuadraticSmooth): (WebCore::SVGPathParser::svgArcTo):

2:22 AM Changeset in webkit [16212] by rwlbuis

3 edits
4 adds in trunk

Reviewed by Eric.

http://bugzilla.opendarwin.org/show_bug.cgi?id=6546
clipPath data does not respect transforms

Get the transform from the dom element and adjust
the clip path with it.

12:57 AM Changeset in webkit [16211] by rwlbuis

2 edits in trunk/WebCore

Reviewed by Eric.

This code should have gone in as part of:
http://bugzilla.opendarwin.org/show_bug.cgi?id=10696
It addresses the comments there, also we use double instead
of float now in calculations.

Sep 3, 2006:

7:11 PM Changeset in webkit [16210] by weinig

13 edits
2 adds in trunk

WebCore:

Reviewed by Darin and Tim H.

patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10711 Auto-generate the Objective-C DOM Stylesheet bindings

Auto-generates DOMMediaList, DOMStyleSheet, and DOMStyleSheetList.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOMCSS.mm: (+[DOMStyleSheet _styleSheetWith:]): (+[DOMCSSStyleSheet _CSSStyleSheetWith:]):
bindings/objc/DOMCSSInternal.h:
bindings/objc/DOMInternal.h:
bindings/objc/DOMObject.mm: (-[DOMObject sheet]):
bindings/objc/DOMPrivate.h:
bindings/objc/DOMStylesheets.h:
bindings/objc/DOMUtility.mm: (KJS::ScriptInterpreter::createObjcInstanceForValue):
bindings/scripts/CodeGeneratorObjC.pm:
css/StyleSheet.idl: Added.
css/StyleSheetList.idl: Added.

WebKit:

Reviewed by Darin and Tim H.

patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10711 Auto-generate the Objective-C DOM Stylesheet bindings

MigrateHeaders.make:

6:00 PM Changeset in webkit [16209] by weinig

1 add in trunk/WebCore/platform/Path.cpp

Build fix.

3:19 PM Changeset in webkit [16208] by darin

2 edits in trunk/WebKitTools

Scripts/do-webcore-rename: More renaming plans.

2:46 PM Changeset in webkit [16207] by thatcher

1 edit in trunk/WebCore/bindings/objc/DOMHTML.mm

Build fix to avoid warning about property name conflict.

2:31 PM Changeset in webkit [16206] by rwlbuis

38 edits in trunk/WebCore

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10696
RenderPathQuartz and RenderPathQt should not be needed

Cleanup of code related to RenderPath.

2:20 PM Changeset in webkit [16205] by thatcher

1 edit in trunk/WebCore/ChangeLog

Fix a typo Darin called out, but I forgot to change.

2:11 PM Changeset in webkit [16204] by thatcher

1 edit in trunk/WebCore/bindings/scripts/CodeGeneratorObjC.pm

Build fix.

1:48 PM Changeset in webkit [16203] by thatcher

5 edits in trunk

Changing the ignore rule for *.perspective to *.perspective*. This ignores the new .perspectivev3 file.

1:42 PM Changeset in webkit [16202] by thatcher

1 edit in trunk/WebCore/WebCore.xcodeproj

Changing the ignore rule for *.perspective to *.perspective*. This ignores the new .perspectivev3 file.

1:38 PM Changeset in webkit [16201] by thatcher

30 edits in trunk/WebCore

Reviewed by Darin.

Bug 10685: ObjC DOM should have no unnamed parameters
http://bugzilla.opendarwin.org/show_bug.cgi?id=10685

The ObjC code generation script now outputs parameter prefixes for methods that have more than 1 parameter. This prefix is simply the parameter name. Some parameter names have been changed in the IDL files to produce better prefixes. If an extended attribute of "ObjCPrefix" exists on a parameter we will use that for the prefix.

A backwards compatible version of the method is placed in a category with a deprecation marco for 10.5 and later. This step only happens if the IDL extended attribute "OldStyleObjC" is defined. All new functions in IDL should not get this attribute.

Made the $interfaceMethodSelector regex in IDLStructure.pm allow "=" so parameter extended attributes can have values.

Moved RemoveExcludedAttributesAndFunctions to CodeGenerator.pm so it can be shared between the two generators.

Removed the die when we encounter a getter that uses exceptions. Sam Weinig added support for this in an earlier change.

Check if $ENV{"MACOSX_DEPLOYMENT_TARGET"} is defined before we compare. This caused a perl warning when generating on other platforms.

The ObjC generation will not happen on platforms other than Mac OS. This is determined by the "OS" env variable Xcode sets. This check is in the DerivedSources.make.

Added a way to skip generation if the constructor of the specific generator returns undef. Not used yet.

Many cleanup tweaks in CodeGeneratorObjC.pm.

Removed IDL and CSS files from the project's resource copy phase, these do no need to be in WebCore's resources.

DerivedSources.make
WebCore.xcodeproj/project.pbxproj
bindings/scripts/CodeGenerator.pm
bindings/scripts/CodeGeneratorJS.pm
bindings/scripts/CodeGeneratorObjC.pm
bindings/scripts/IDLStructure.pm
css/CSSMediaRule.idl
css/CSSPrimitiveValue.idl
css/CSSStyleDeclaration.idl
css/CSSStyleSheet.idl
dom/CharacterData.idl
dom/DOMImplementation.idl
dom/Document.idl
dom/Element.idl
dom/KeyboardEvent.idl
dom/MouseEvent.idl
dom/MutationEvent.idl
dom/NamedNodeMap.idl
dom/UIEvent.idl
html/HTMLCanvasElement.idl
html/HTMLSelectElement.idl
ksvg2/bindings/idl/svg/SVGLengthList.idl
ksvg2/bindings/idl/svg/SVGNumberList.idl
ksvg2/bindings/idl/svg/SVGPointList.idl
ksvg2/bindings/idl/svg/SVGStringList.idl
ksvg2/bindings/idl/svg/SVGTextContentElement.idl
ksvg2/bindings/idl/svg/SVGTransformList.idl
ksvg2/svg/SVGSVGElement.idl
page/DOMWindow.idl

12:08 PM Changeset in webkit [16200] by ap

11 edits in trunk

Reviewed by Tim H.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10693
Convert JavaScript arrays to AppleScript lists

JavaScriptCore:

JavaScriptCore.exp: Export ArrayInstance::info and ArrayInstance::getItem().
kjs/array_instance.h:
kjs/array_object.cpp: (ArrayInstance::getItem): Added a method to access array items from C++.

WebCore:

bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): Added a case for ArrayInstance.

LayoutTests:

fast/AppleScript/array-expected.txt:
fast/AppleScript/array.html: Updated results, added a test for circular dependencies.

WebKitTools:

DumpRenderTree/AppleScriptController.m: (convertAEDescToObject): (-[AppleScriptController doJavaScript:]): Support printing AEDescLists.

10:28 AM Changeset in webkit [16199] by ap

1 edit in trunk/LayoutTests/http/tests/incremental/slow-utf8-html.pl

http/tests/incremental/slow-utf8-html-diffs.txt
Set executable bit that was lost when re-applying the patch.

9:59 AM Changeset in webkit [16198] by ap

3 edits
4 adds in trunk

Reviewed by Eric.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10697
REGRESSION (r16175): Errors in incremental decoding of UTF-8

Tests:

http/tests/incremental/slow-utf8-html.pl
fast/encoding/charset-invalid.html

loader/Decoder.cpp: (Decoder::Decoder): Ensure that we have a valid encoding. Get its name via TextEncoding, to match the logic in setEncodingName(). (Decoder::setEncodingName): Only set m_encodingName if the encoding is valid. Rely on TextEncoding constructor to lowercase it if necessary. (Decoder::decode): Use setEncodingName() to apply encoding from BOM. Don't try to ensure the validity of encoding - it is enforced by class constructor and setEncodingName().

6:45 AM Changeset in webkit [16197] by weinig

1 edit in trunk/WebCore/bindings/objc/DOMRGBColor.h

Fixes build for regression tests.

2:25 AM Changeset in webkit [16196] by ap

4 edits
2 moves
1 add
2 deletes in trunk/LayoutTests

Reviewed by Tim H.

http://bugzilla.opendarwin.org/show_bug.cgi?id=4508
Layout tests access an external server

fast/backgrounds/repeat/noRepeatCorrectClip.html: Use a local resource (it was already present, but the test still pointed to a remote one).
fast/dom/HTMLImageElement/image-src-absolute-url-expected.txt:
fast/dom/HTMLImageElement/image-src-absolute-url.html: Use a non-existent file URL instead of a non-existent http one.
fast/loader/docLoaderFrame-expected.checksum: Removed.
fast/loader/docLoaderFrame-expected.png: Removed.
fast/loader/docLoaderFrame-expected.txt: Removed.
fast/loader/docLoaderFrame.html: Removed.
http/tests/xmlhttprequest/docLoaderFrame-expected.txt: Added.
http/tests/xmlhttprequest/docLoaderFrame.html: Added.
http/tests/xmlhttprequest/resources/docLoaderFrame-data.html: Added. Use a local resource. Also, turned the test into a text one, and used waitUntilDone to make it actually work.

Sep 2, 2006:

7:10 PM Changeset in webkit [16195] by weinig

17 edits
11 adds in trunk

WebCore:

Reviewed by Tim H.

patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10684 Auto-generate the Objective-C DOM CSS bindings

Auto-generates DOMCSSCharsetRule, DOMCSSFontFaceRule, DOMCSSImportRule,
DOMCSSMediaRule, DOMCSSPageRule, DOMCSSPrimitiveValue, DOMCSSRule,
DOMCSSRuleList, DOMCSSStyleDeclaration, DOMCSSStyleRule, DOMCSSStyleSheet,
DOMCSSUnknownRule, DOMCSSValue, DOMCSSValueList, DOMCounter, and DOMRect.

Splits DOMRGBColor into its own files.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOMCSS.h:
bindings/objc/DOMCSS.mm: (+[DOMCSSStyleSheet _CSSStyleSheetWith:]): (+[DOMCSSPrimitiveValue _valueWith:]):
bindings/objc/DOMCSSInternal.h:
bindings/objc/DOMExtensions.h:
bindings/objc/DOMInternal.h:
bindings/objc/DOMRGBColor.h: Added.
bindings/objc/DOMRGBColor.mm: Added. (getWrapperForRGB): (setWrapperForRGB): (removeWrapperForRGB): (-[DOMRGBColor dealloc]): (-[DOMRGBColor finalize]): (-[DOMRGBColor red]): (-[DOMRGBColor green]): (-[DOMRGBColor blue]): (-[DOMRGBColor alpha]): (-[DOMRGBColor color]): (-[DOMRGBColor _initWithRGB:WebCore::]): (+[DOMRGBColor _RGBColorWithRGB:WebCore::]):
bindings/scripts/CodeGeneratorObjC.pm:
css/CSSCharsetRule.idl: Added.
css/CSSFontFaceRule.idl: Added.
css/CSSImportRule.idl: Added.
css/CSSMediaRule.idl: Added.
css/CSSPageRule.idl: Added.
css/CSSRule.idl:
css/CSSStyleDeclaration.idl:
css/CSSStyleRule.idl: Added.
css/CSSStyleSheet.idl: Added.
css/CSSUnknownRule.idl: Added.
css/CSSValue.idl:
css/MediaList.idl:
css/RGBColor.idl: Added.
css/Rect.idl:
css/RectImpl.h:

WebKit:

Reviewed by Tim H.

patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10684 Auto-generate the Objective-C DOM CSS bindings

MigrateHeaders.make:

12:19 PM Changeset in webkit [16194] by thatcher

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Justin.

Testcase for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=10579
AppleStyleCommand::applyBlockStyle crash

editing/style/table-selection-expected.checksum: Added.
editing/style/table-selection-expected.png: Added.
editing/style/table-selection-expected.txt: Added.
editing/style/table-selection.html: Added.

WebCore:

Reviewed by Justin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10579
AppleStyleCommand::applyBlockStyle crash

editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): Prevent a crash by making sure that the 'beyondEnd' node is after the start node.

12:15 PM Changeset in webkit [16193] by thatcher

10 edits in trunk

JavaScriptCore:

Reviewed by Tim H.

Bug 10454: Unix bakefile fixes
http://bugzilla.opendarwin.org/show_bug.cgi?id=10454

JavaScriptCoreSources.bkl:

WebCore:

Reviewed by Tim H.

Bug 10454: Unix bakefile fixes
http://bugzilla.opendarwin.org/show_bug.cgi?id=10454

WebCoreSources.bkl:
platform/gdk/RenderPopupMenuGdk.cpp: (WebCore::RenderPopupMenuGdk::RenderPopupMenuGdk):
platform/gdk/RenderPopupMenuGdk.h:
platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::createPopupMenu): (WebCore::RenderThemeGdk::systemFont):
platform/gdk/RenderThemeGdk.h:
platform/gdk/TemporaryLinkStubs.cpp:
webcore-base.bkl:

10:25 AM Changeset in webkit [16192] by adele

6 edits in trunk/WebCore

Reviewed by Anders.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10667 Password: Double-click should select-all to avoid exposing word boundaries

Test: fast/forms/password-doubleclick-selection.html

editing/visible_units.cpp: (WebCore::previousBoundary): When searching for boundaries in renderers that use the textSecurity property, convert characters in strings to alpha-numeric characters (in this case, all 'x's) so that every character isn't treated as a punctuation boundary. (WebCore::nextBoundary): ditto.
editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Updated to use the renderer's string instead of the node value. This matches the base class implementation of handleTextNode.

Code cleanup.

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Avoid unnecessary check for password field case if the smart replace condition is false.
page/Frame.cpp: (WebCore::Frame::mayCopy): Removed duplicate code. Calls isSelectionInPasswordField now.
rendering/RenderText.cpp: (WebCore::RenderText::setText): Updated formatting.

Sep 1, 2006:

6:43 PM Changeset in webkit [16191] by hyatt

6 edits in trunk/WebCore

Fix for 10682, refine the FOUC paint suppression logic so that it
is only triggered when FOUC would really have occurred.

Reviewed by aroben

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::styleForElement):
dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::updateLayoutIgnorePendingStylesheets): (WebCore::Document::updateStyleSelector):
dom/Document.h: (WebCore::Document::haveStylesheetsLoaded): (WebCore::Document::): (WebCore::Document::didLayoutWithPendingStylesheets):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):

6:10 PM Changeset in webkit [16190] by aroben

11 edits in trunk

2006-09-01 MorganL <morlmor@yahoo.com>

Reviewed by Darin. Updated/landed by Adam.

Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10553
Windows build fixes

5:57 PM Changeset in webkit [16189] by beidson

6 edits in trunk/WebCore

Reviewed by Tim Omernick

Added an SQLDatabase logging channel. Changed all SQLDatabase and SQLStatement errors to use this new channel.
Also, as a popular request from other contributers, added a log for all prepare(), step(), finalize(), and reset()s
Also, fixed a grammar error in my previous ChangeLog entry.

bridge/mac/WebCorePageBridge.mm: (initializeLoggingChannelsIfNecessary): Initialize the new channel
loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::setBusyTimeout): Use SQLDatabase logging channel (WebCore::SQLDatabase::setBusyHandler): ditto (WebCore::SQLDatabase::clearAllTables): ditto (WebCore::SQLDatabase::runVacuumCommand): ditto
loader/icon/SQLStatement.cpp: (WebCore::SQLStatement::prepare): Added a log (WebCore::SQLStatement::step): ditto (WebCore::SQLStatement::finalize): ditto (WebCore::SQLStatement::reset): ditto (WebCore::SQLStatement::getColumnBlob): Use SQLDatabase logging channel (WebCore::SQLStatement::returnTextResults): ditto (WebCore::SQLStatement::returnTextResults16): ditto (WebCore::SQLStatement::returnIntResults): ditto (WebCore::SQLStatement::returnInt64Results): ditto (WebCore::SQLStatement::returnDoubleResults): ditto
platform/Logging.cpp: (WebCore::): Added new logging channel
platform/Logging.h: ditto

5:55 PM Changeset in webkit [16188] by adele

20 edits in trunk

LayoutTests:

Reviewed by Tim Omernick.

Updated results for http://bugzilla.opendarwin.org/show_bug.cgi?id=6990
Switch to use new text field implementation for <input type="password">

dom/html/level2/html/HTMLInputElement22-expected.txt:
dom/xhtml/level2/html/HTMLInputElement22-expected.txt:
fast/events/event-sender-mouse-click.html:
fast/forms/input-appearance-height-expected.checksum:
fast/forms/input-appearance-height-expected.txt:
fast/forms/input-type-change-in-onfocus-mouse-expected.txt:
fast/forms/input-value-expected.checksum:
fast/forms/input-value-expected.png:
fast/forms/input-value-expected.txt:
tables/mozilla_expected_failures/bugs/bug92647-1-expected.checksum:
tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:

Updated from switch to style-able selects

fast/forms/option-strip-whitespace-expected.checksum:
fast/forms/option-strip-whitespace-expected.png:
fast/forms/option-strip-whitespace-expected.txt:

WebCore:

Reviewed by Tim Omernick.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6990 Switch to use new text field implementation for <input type="password">

css/html4.css: Give input[password] the same style properties as normal text fields.
html/HTMLInputElement.cpp: Removed checks for TextFieldAppearance. (WebCore::HTMLInputElement::selectionStart): (WebCore::HTMLInputElement::selectionEnd): (WebCore::HTMLInputElement::setSelectionStart): (WebCore::HTMLInputElement::setSelectionEnd): (WebCore::HTMLInputElement::select): (WebCore::HTMLInputElement::setSelectionRange): (WebCore::HTMLInputElement::createRenderer):
html/HTMLInputElement.h: (WebCore::HTMLInputElement::isNonWidgetTextField):

5:03 PM Changeset in webkit [16187] by beidson

8 edits in trunk/WebCore

Reviewed by John (though Sarge review a previous patch of mine in an attempt to review this one)

Added some constants for SQL Result Codes to SQLDatabase.h
This way, users of SQLDatabase can access all necessary SQLite functionality
without having access to sqlite3.h.
Also reordered some files in the xcodeproj and some #includes

WebCore.xcodeproj/project.pbxproj: Reordered some files
loader/icon/IconDataCache.cpp: (WebCore::IconDataCache::writeToDatabase): Use our new result codes
loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::sharedIconDatabase): Use our new result codes (WebCore::IconDatabase::retainIconForPageURL): Use our new result codes (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Use our new result codes (WebCore::IconDatabase::addIconForIconURLQuery): Use our new result codes (WebCore::IconDatabase::hasIconForIconURLQuery): Use our new result codes
loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::lastError): Moved from header to eliminate dependency on sqlite3.h in header (WebCore::SQLDatabase::lastErrorMsg): Ditto
loader/icon/SQLDatabase.h: Removed #include <sqlite3.h>
loader/icon/SQLStatement.cpp: Added #include <sqlite3.h>
loader/icon/SQLStatement.h: Removed #include <sqlite3.h>

4:53 PM Changeset in webkit [16186] by beidson

1 edit in trunk/WebKit/ChangeLog

My ChangeLog grammar needs reviewing, apparently (fixed last ChangeLog)

4:20 PM Changeset in webkit [16185] by beidson

2 edits in trunk/WebKit

Reviewed by Darin

A "never should be reach" method was reached - lets not release the shared database bridge, esp
since we never retain it!

Misc/WebIconDatabase.m: (-[WebIconDatabase _applicationWillTerminate:]): Don't release the bridge

3:57 PM Changeset in webkit [16184] by hyatt

4 adds in trunk/LayoutTests/fast/flexbox

Add flexbox test.

3:56 PM Changeset in webkit [16183] by hyatt

2 edits in trunk/WebCore

Fix for 10680, contrained flexbox is not shrinking flexible children
properly. (Fixing in case it's hit by the file upload control.)

Reviewed by aroben

Adding 026.html to fast/flexbox.

rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::allowedChildFlex):

2:52 PM Changeset in webkit [16182] by eseidel

4 edits in trunk/WebCore

2006-09-01 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Implement support for multiple parents in the SVG idls.

For class "FooBar" go through all parents recursively,
collect their attributes & functions & constants and
add them directly into the class "FooBar".

(Note: It is NOT enabled by default for now - still some things related to SVGAnimated* need to be solved first)

bindings/scripts/CodeGenerator.pm:
bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/generate-bindings.pl:

2:50 PM Changeset in webkit [16181] by eseidel

6 edits in trunk

2006-09-02 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by hyatt. Landed by eseidel.

Fix build on Linux.

CMakeLists.txt: Add platform/CString.cpp.
platform/qt/FrameQt.cpp: Correct repsondToChangedContents() signature
platform/qt/FrameQt.h:: Correct respondToChangedContents() signature

2:41 PM Changeset in webkit [16180] by darin

9 edits in trunk

WebCore:

Reviewed by Brady.

a few small tweaks to the icon database bridge

bridge/mac/WebCoreIconDatabaseBridge.h: Removed unnecessary declarations. Renamed sharedBridgeInstance to sharedInstance.
bridge/mac/WebCoreIconDatabaseBridge.mm: Put functions inside WebCore namespace. (WebCore::IconDatabase::loadIconFromURL): Updated for sharedInstance namespace.

WebKit:

Reviewed by Brady.

a few small tweaks to the icon database bridge

Misc/WebIconDatabase.m: (-[WebIconDatabase init]): Updated for name change.

WebCoreSupport/WebIconDatabaseBridge.h: Removed unneeded declarations.
WebCoreSupport/WebIconDatabaseBridge.m: (-[WebIconDatabaseBridge init]): Added. Always returns nil since you're not supposed to allocate one of these. (-[WebIconDatabaseBridge _init]): Renamed from init. Used internally to make the shared instance. Added the "self = [super init]" idiom even though it's not important in this case just to be consistent. (-[WebIconDatabaseBridge releaseCachedLoaderForIconURL:]): Moved this up in the file so it can be called without declaring it in the header. (+[WebIconDatabaseBridge sharedInstance]): Renamed. Calls the new _init. Also use CFRetain for compatibility. (-[WebIconDatabaseBridge dealloc]): Emptied this out and made it just assert (false). (-[WebIconDatabaseBridge finalize]): Added and made it assert (false) too.

2:21 PM Changeset in webkit [16179] by thatcher

2 edits in trunk/WebKit

Reviewed by Adele.

Bug 10677: Omit "-webkit-text-security: none;" from the computed style list
http://bugzilla.opendarwin.org/show_bug.cgi?id=10677

WebInspector/webInspector/inspector.js:

2:00 PM Changeset in webkit [22139] by sfalken

5 edits in branches/WindowsMerge

1:09 PM Changeset in webkit [16178] by thatcher

5 edits in trunk

LayoutTests:

Reviewed by Darin.

updated results, null is not round-tripped through the bindings because of regressions the original change caused in other applications.
added an echo for "undefined".

plugins/bindings-test-expected.txt:
plugins/bindings-test.html:

WebCore:

Reviewed by Darin.

<rdar://problem/4651318> REGRESSION: can't drag library items to widget in Dashcode
<rdar://problem/4701626> REGRESSION: Unit Converter widget doesn't work convert data in its fields

jsNull should not be returned as NSNull because existing applications do not
expect that return value. Return as nil for backwards compatibility.

bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:originExecutionContext:executionContext:]):

1:05 PM Changeset in webkit [16177] by ap

4 edits in trunk/JavaScriptCore

2006-09-01 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed and landed by ap.

Fix build on Linux (C89 without gcc extensions enabled).

pcre/pcre_internal.h: Use C style comments.
wtf/Assertions.h: Use C style comments.
wtf/Platform.h: Use C style comments.

12:48 PM Changeset in webkit [16176] by ap

2 edits in trunk/WebCore

Build fix.

loader/Decoder.cpp: (Decoder::Decoder): Use String::latin1().

12:36 PM Changeset in webkit [16175] by ap

12 edits
18 adds in trunk

Reviewed by Eric.

http://bugzilla.opendarwin.org/show_bug.cgi?id=5620 Should only honor encoding from <meta> in HTML

http://bugzilla.opendarwin.org/show_bug.cgi?id=9783 An XML declaration without an explicit encoding incorrectly triggers UTF-8 encoding in an HTML document

http://bugzilla.opendarwin.org/show_bug.cgi?id=10155 CSS2: @charset is not supported

WebCore:

loader/Decoder.cpp: (Decoder::Decoder): Decoder now knows what kind of content it is decoding. Also, the browser default encoding can now be passed directly to the constructor, to streamline the logic. (Decoder::decode): Add support for @charset, differentiate between HTML and XML. (Decoder::setEncodingName): Style cleanup. (Decoder::encodingName): Ditto. (Decoder::flush): Ditto.
loader/Decoder.h: (WebCore::Decoder::):

bridge/mac/WebCoreEncodings.mm: Pass a content type of text/html to Decoder.

loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): (WebCore::CachedCSSStyleSheet::setCharset): (WebCore::CachedCSSStyleSheet::data):
loader/CachedCSSStyleSheet.h: Use Decoder instead of TextEncoding::toUnicode() to enable @charset support.

loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::CachedXBLDocument): Pass a content type.
loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet): Ditto. (WebCore::CachedXSLStyleSheet::data): Flush the decoder to be safe.

page/Frame.cpp: (WebCore::Frame::write): Pass a content type and a default encoding to the Decoder.
xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::createDocumentFromSource): Pass the output document MIME type.
xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::receivedData): Ditto.

LayoutTests:

fast/encoding/css-charset-expected.txt: Added.
fast/encoding/css-charset.css: Added.
fast/encoding/css-charset.html: Added.
fast/encoding/css-charset-evil-expected.txt: Added.
fast/encoding/css-charset-evil.css: Added.
fast/encoding/css-charset-evil.html: Added.
fast/encoding/default-xhtml-encoding-expected.txt: Added.
fast/encoding/default-xhtml-encoding.xhtml: Added.
fast/encoding/meta-in-xhtml-expected.txt: Added.
fast/encoding/meta-in-xhtml.xhtml: Added.
fast/encoding/pseudo-xml-2-expected.txt: Added.
fast/encoding/pseudo-xml-2.html: Added.
fast/encoding/pseudo-xml-3-expected.txt: Added.
fast/encoding/pseudo-xml-3.html: Added.
fast/encoding/pseudo-xml-4-expected.txt: Added.
fast/encoding/pseudo-xml-4.html: Added.
fast/encoding/pseudo-xml-expected.txt: Added.
fast/encoding/pseudo-xml.html: Added.

12:01 PM Changeset in webkit [16174] by adele

5 edits in trunk/WebCore

Reviewed by John.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10580 Password: New secure text field allows non-Roman text entry

bridge/mac/FrameMac.mm: (WebCore::FrameMac::setSecureKeyboardEntry): Enable and disable Roman keyboards when switching in and out of this mode. (WebCore::FrameMac::isSecureKeyboardEntry): Changed secureKeyboardEntry to isSecureKeyboardEntry.
bridge/mac/FrameMac.h: ditto.
page/Frame.cpp: (WebCore::Frame::setIsActive): ditto.
page/Frame.h: (WebCore::Frame::isSecureKeyboardEntry): ditto.

11:07 AM Changeset in webkit [22138] by adachan

3 edits in branches/WindowsMerge/WebCore

2006-09-01 Ada Chan <adachan@apple.com>

Reviewed by lamadio.

Fixed build break.

10:21 AM Changeset in webkit [16173] by adele

2 edits in trunk/WebCore

Reviewed by John.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10665 Password: Disable smartReplace for new password fields

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Don't smart replace when the selection being replaces is in a password field.

Aug 31, 2006:

9:08 PM Changeset in webkit [16172] by thatcher

12 edits
4 adds in trunk

WebCore:

Reviewed by Tim H.

patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10669 Auto-generate the remaining Objective-C HTML DOM bindings

Auto-generates DOMHTMLAnchorElement, DOMHTMLAreaElement,
DOMHTMLBaseFontElement, DOMHTMLFontElement, DOMHTMLFrameElement,
DOMHTMLFrameSetElement, DOMHTMLHRElement, DOMHTMLIFrameElement,
DOMHTMLImageElement, DOMHTMLMapElement, DOMHTMLModElement,
DOMHTMLObjectElement, DOMHTMLParamElement, DOMHTMLScriptElement,
DOMHTMLTableCaptionElement, DOMHTMLTableCellElement,
DOMHTMLTableColElement, DOMHTMLTableElement, DOMHTMLTableRowElement,
and DOMHTMLTableSectionElement.

Splits DOMHTMLAppletElement and DOMHTMLOptionElement into their own
files.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOM.mm:
bindings/objc/DOMExtensions.h:
bindings/objc/DOMHTML.h:
bindings/objc/DOMHTML.mm: (-[DOMHTMLAnchorElement absoluteLinkURL]): (-[DOMHTMLImageElement altDisplayString]): (-[DOMHTMLImageElement absoluteImageURL]): (-[DOMHTMLImageElement WebCore::]): (-[DOMHTMLObjectElement absoluteImageURL]): (-[DOMHTMLObjectElement WebCore::]): (+[DOMHTMLTableCaptionElement _tableCaptionElementWith:]): (-[DOMHTMLTableCaptionElement _tableCaptionElement]): (+[DOMHTMLTableSectionElement _tableSectionElementWith:]): (-[DOMHTMLTableSectionElement _tableSectionElement]): (+[DOMHTMLTableElement _tableElementWith:]): (-[DOMHTMLTableElement _tableElement]): (+[DOMHTMLTableCellElement _tableCellElementWith:]): (-[DOMHTMLTableCellElement _tableCellElement]):
bindings/objc/DOMHTMLAppletElement.h: Added.
bindings/objc/DOMHTMLAppletElement.mm: Added. (-[DOMHTMLAppletElement WebCore::]): (-[DOMHTMLAppletElement align]): (-[DOMHTMLAppletElement setAlign:]): (-[DOMHTMLAppletElement alt]): (-[DOMHTMLAppletElement setAlt:]): (-[DOMHTMLAppletElement archive]): (-[DOMHTMLAppletElement setArchive:]): (-[DOMHTMLAppletElement code]): (-[DOMHTMLAppletElement setCode:]): (-[DOMHTMLAppletElement codeBase]): (-[DOMHTMLAppletElement setCodeBase:]): (-[DOMHTMLAppletElement height]): (-[DOMHTMLAppletElement setHeight:]): (-[DOMHTMLAppletElement hspace]): (-[DOMHTMLAppletElement setHspace:]): (-[DOMHTMLAppletElement name]): (-[DOMHTMLAppletElement setName:]): (-[DOMHTMLAppletElement object]): (-[DOMHTMLAppletElement setObject:]): (-[DOMHTMLAppletElement vspace]): (-[DOMHTMLAppletElement setVspace:]): (-[DOMHTMLAppletElement width]): (-[DOMHTMLAppletElement setWidth:]):
bindings/objc/DOMHTMLInternal.h:
bindings/objc/DOMHTMLOptionElement.h: Added.
bindings/objc/DOMHTMLOptionElement.mm: Added. (-[DOMHTMLOptionElement WebCore::]): (-[DOMHTMLOptionElement form]): (-[DOMHTMLOptionElement defaultSelected]): (-[DOMHTMLOptionElement setDefaultSelected:]): (-[DOMHTMLOptionElement text]): (-[DOMHTMLOptionElement index]): (-[DOMHTMLOptionElement disabled]): (-[DOMHTMLOptionElement setDisabled:]): (-[DOMHTMLOptionElement label]): (-[DOMHTMLOptionElement setLabel:]): (-[DOMHTMLOptionElement selected]): (-[DOMHTMLOptionElement setSelected:]): (-[DOMHTMLOptionElement value]): (-[DOMHTMLOptionElement setValue:]):
bindings/objc/DOMPrivate.h:
bindings/scripts/CodeGeneratorObjC.pm:

WebKit:

Reviewed by Tim H.

patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10669 Auto-generate the remaining Objective-C HTML DOM bindings

MigrateHeaders.make:

8:58 PM Changeset in webkit [22137] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

2006-09-01 Steve Falkenburg <sfalken@apple.com>

Reviewed by kevin.

Fix back/forward regression.

Combining the two receivedAllData methods into one broke back/forward navigation,
since we put the resetting of m_quickRedirectComing and m_loadType at the start
of the combined method, but have code in the rest of receivedAllData that
relies on these having their old values.

WebFrame.cpp: (WebFrame::receivedAllData):

7:28 PM Changeset in webkit [16171] by aliceli1

11 edits in trunk

LayoutTests:

Reviewed by Darin.

Revised expected results for an isindex element because of
<rdar://problem/4463870> Switch to use new text field implementation for <isindex>
Now the field is rendered as a textfield

fast/dom/isindex-002-expected.checksum:
fast/dom/isindex-002-expected.png:
fast/dom/isindex-002-expected.txt:

WebCore:

Reviewed by Darin.

Fixed <rdar://problem/4463870> Switch to use new text field implementation for <isindex>

bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isTextField]): moved isindex from the list of nonTextInputTypes to the list of textInputTypes
css/html4.css: added isindex to certain rules that applied to input fields
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::canHaveSelection): (WebCore::HTMLInputElement::selectionStart): (WebCore::HTMLInputElement::selectionEnd): (WebCore::HTMLInputElement::setSelectionStart): (WebCore::HTMLInputElement::setSelectionEnd): (WebCore::HTMLInputElement::select): (WebCore::HTMLInputElement::setSelectionRange): (WebCore::HTMLInputElement::createRenderer): for the 8 methods above, moved the case for isindex to the same case as text
html/HTMLInputElement.h: (WebCore::HTMLInputElement::isNonWidgetTextField): added isindex to this test
html/HTMLIsIndexElement.idl: HTMLIsIndexElement inherits from HTMLInputElement
rendering/RenderLineEdit.cpp: (WebCore::RenderLineEdit::RenderLineEdit): removed the case for isindex since we changed the renderer type from a RenderLineEdit to a RenderTextControl in WebCore::HTMLInputElement::createRenderer()

6:57 PM Changeset in webkit [16170] by darin

2 edits in trunk/WebKitTools

Scripts/do-webcore-rename: Prepare for another round of renaming.

6:13 PM Changeset in webkit [16169] by harrison

11 edits in trunk/WebCore

Reviewed by Adele.

<rdar://problem/4708119> REGRESSION: Cannot observe an AXTextField element directly

... and most of
<rdar://problem/4708022> REGRESSION: TextRange-based attributes are missing from text fields
<rdar://problem/4709515> REGRESSION: Expose text areas

Remaining work for those two bugs in new bugs:

<rdar://problem/4712101> Support NSAccessibilityVisibleCharacterRangeAttribute for AXTextField and AXTextArea elements
<rdar://problem/4712111> Support NSAccessibilityInsertionPointLineNumberAttribute for AXTextArea elements
<rdar://problem/4712125> Support setting NSAccessibilitySelectedTextAttribute for AXTextField and AXTextArea elements

bridge/AXObjectCache.h: (WebCore::AXObjectCache::postNotificationToElement):
bridge/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::postNotification): (WebCore::AXObjectCache::postNotificationToElement): Removed postNotificationToTopWebArea. postNotification now posts to input element or top web area, as appropriate. postNotificationToElement posts to the specified element itself.

bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::respondToChangedContents): Take a selection. Pass the starting position's renderer to postNotification so that postNotification can post to the appropriate input element, if any.

bridge/mac/WebCoreAXObject.h:
bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject isWebArea]): (-[WebCoreAXObject isAnchor]): (-[WebCoreAXObject isTextRange]): New convenience methods.

(-[WebCoreAXObject role]):
(-[WebCoreAXObject roleDescription])
(-[WebCoreAXObject value]):
(-[WebCoreAXObject accessibilityDescription]):
Support AXTextField and AXTextArea.

(-[WebCoreAXObject accessibilityShouldUseUniqueId]):
Register AXTextField and AXTextArea elements so notifications to them can be observed.

(-[WebCoreAXObject accessibilityIsIgnored]):
Use new convenience method isWebArea.

(-[WebCoreAXObject accessibilityAttributeNames]):
Simplify the array creation.
Add text range support.

(-[WebCoreAXObject accessibilityAttributeValue:]):
Add text range support.

(-[WebCoreAXObject canSetFocusAttribute]):
(-[WebCoreAXObject canSetValueAttribute]):
(-[WebCoreAXObject canSetTextRangeAttributes]):
New convenience methods.

(-[WebCoreAXObject accessibilityIsAttributeSettable:]):
(-[WebCoreAXObject accessibilitySetValue:forAttribute:]):
Add text range support.

(-[WebCoreAXObject observableObject]):
New to locate text field or text area to notify.

dom/Document.cpp: (WebCore::Document::updateSelection): Post AXSelectedTextChanged notification with new selection's start node. postNotification will send it to the input element, if there is one, or the top WebArea.

(WebCore::Document::implicitClose):
Use postNotificationToElement now that it acts like the old postNotification.

page/Frame.h:
page/Frame.cpp: (WebCore::Frame::appliedEditing): (WebCore::Frame::unappliedEditing): (WebCore::Frame::reappliedEditing): Pass the selection of interest to respondToChangedContents.

page/FrameView.cpp: (WebCore::FrameView::layout): Use postNotificationToElement now that it acts like the old postNotification.

6:12 PM Changeset in webkit [16168] by sfalken

3 edits in trunk/JavaScriptCore

2006-09-01 Steve Falkenburg <sfalken@apple.com>

Fix build.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
JavaScriptCore.vcproj/dftables/dftables.vcproj:

6:11 PM Changeset in webkit [22136] by andersca

3 edits
1 add in branches/WindowsMerge/WebCore

2006-08-31 Anders Carlsson <acarlsson@apple.com>

Reviewed by Steve.

Add our own internal config.h so we can make changes to it.

WebCore.vcproj/WebCore.vcproj: Add config.h to the file list, move the KXMLCORE_PLATFORM_CF to the new config.h file

config.h: Added.

platform/win/ResourceLoaderWin.cpp: Include config.h

5:17 PM Changeset in webkit [16167] by adele

9 edits in trunk

WebCore:

Reviewed by Darin.

WebCore part of fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10666
Password: Disallow Spelling, Font, Speech, and Writing Direction context menu

bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge isSelectionInPasswordField]): Added.
page/Frame.cpp: (WebCore::Frame::isSelectionInPasswordField): Added.
page/Frame.h:

WebKit:

Reviewed by Darin.

WebKit part of fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10666
Password: Disallow Spelling, Font, Speech, and Writing Direction context menu

DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): Check that the selection isn't in a password field before adding these items to the default editing context menu.

Search In Google, Search In Spotlight, Look up in Dictionary, Spelling, Font, Speech, Writing Direction

WebView/WebHTMLView.m: (-[WebHTMLView _isSelectionInPasswordField]): Added.
WebView/WebHTMLViewPrivate.h:

4:48 PM Changeset in webkit [22135] by hyatt

1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

Fix build bustage.

4:43 PM Changeset in webkit [16166] by andersca

1 edit in trunk/JavaScriptCore/ChangeLog

Forgot the ChangeLog

4:15 PM Changeset in webkit [22134] by hyatt

3 edits in branches/WindowsMerge/WebCore

Add a platform scrollbar class for Windows. Doesn't really work yet.

4:11 PM Changeset in webkit [16165] by antti

2 edits in S60/trunk/WebCore

2006-08-31 bujtas <zbujtas@gmail.com>

Reviewed by Antti Koivisto.
DESC: do not call updateStyleAttributeIfNeeded when the
element is removed from doc
http://bugzilla.opendarwin.org/show_bug.cgi?id=10662

WARNING: NO TEST CASES ADDED OR CHANGED

khtml/xml/dom_elementimpl.cpp: (AttrImpl::toString): (ElementImpl::scrollIntoView): (ElementImpl::blur): (ElementImpl::getAttributeNS): (ElementImpl::setAttribute): (ElementImpl::setAttributeMap): (ElementImpl::isURLAttribute): (ElementImpl::removedFromDocument): (ElementImpl::recalcStyle): (ElementImpl::dispatchAttrRemovalEvent): (ElementImpl::dispatchAttrAdditionEvent): (ElementImpl::openTagStartToString): (ElementImpl::toString): (ElementImpl::updateId): (ElementImpl::formatForDebugger): (NamedAttrMapImpl::setNamedItem): (NamedAttrMapImpl::removeNamedItem): (NamedAttrMapImpl::clearAttributes): (NamedAttrMapImpl::operator=): (NamedAttrMapImpl::addAttribute): (NamedAttrMapImpl::removeAttribute):

3:59 PM Changeset in webkit [16164] by andersca

4 edits
1 add in trunk/JavaScriptCore

2006-08-31 Anders Carlsson <acarlsson@apple.com>

Reviewed by Darin.

Add new portability functions to MathExtras.h and add StringExtras.h which is for
string portability functions.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
bindings/c/c_instance.cpp:
kjs/date_object.cpp:
wtf/MathExtras.h: (copysign): (isfinite):
wtf/StringExtras.h: Added. (snprintf): (strncasecmp):

3:55 PM Changeset in webkit [16163] by andersca

3 edits in trunk/JavaScriptCore

2006-08-31 Anders Carlsson <acarlsson@apple.com>

Reviewed by Tim H.

Fix Windows build.

JavaScriptCore.vcproj/dftables/dftables.vcproj:
pcre/pcre_internal.h:

3:44 PM Changeset in webkit [16162] by thatcher

1 edit in trunk/WebKit/DOM/WebDOMOperations.m

Build fix to avoid a property name conflict warning.

3:31 PM Changeset in webkit [16161] by andersca

1 edit in trunk/WebCore/ChangeLog

Fix ChangeLog

3:26 PM Changeset in webkit [16160] by andersca

10 edits in trunk/WebCore

2006-08-31 Anders Carlsson <acarlsson@apple.com>

Reviewed by Tim H, Hyatt.

WebCore.xcodeproj/project.pbxproj: Add KURLCFNet.cpp

platform/KURL.h: Get rid of include, add KURL constructor that takes a CFURLRef.

platform/PlatformString.h:
platform/StringImpl.h: Get rid of include.

platform/cf/KURLCFNet.cpp: (WebCore::KURL::KURL): Add constructor.

platform/cf/ResourceLoaderCFNet.cpp: Fix includes.

platform/cf/StringCF.cpp: (WebCore::String::createCFString): Move this here from PlatformString.h

platform/cf/StringImplCF.cpp: (WebCore::StringImpl::createCFString): Fix cast.

platform/mac/KURLMac.mm: Move createCFURL() to KURLCFNet.cpp

2:59 PM Changeset in webkit [16159] by hyatt

2 edits in trunk/WebCore

Make ScrollBar.cpp able to be compiled on Win32.

2:54 PM Changeset in webkit [16158] by thatcher

3 edits in trunk/WebCore

Build fixes for ppc64 and x86_64, and fixes needed now that we use -Wshorten-64-to-32.

2:52 PM Changeset in webkit [16157] by beidson

1 edit in trunk/WebCore/loader/icon/IconDatabase.h

Renamed an argument in a header for clarity (meant to go with last checkin)

2:44 PM Changeset in webkit [16156] by thatcher

2 edits in trunk/JavaScriptCore/API

Build fixes for ppc64 and x86_64 now that we use -Wshorten-64-to-32.

2:28 PM Changeset in webkit [16155] by thatcher

7 edits in trunk/JavaScriptCore

Reviewed by Geoff.

Band-aid fix for PCRE to compile for ppc64 and x86_64 now that
we use -Wshorten-64-to-32. Adds an INT_CAST macro that ASSERTs
the value <= INT_MAX.

I filed <rdar://problem/4712064> to track the need to verify
PCRE's 64-bit compliance.

pcre/pcre_compile.c: (complete_callout): (compile_branch): (compile_regex): (pcre_compile2):
pcre/pcre_exec.c: (match): (pcre_exec):
pcre/pcre_get.c: (pcre_get_substring_list):
pcre/pcre_internal.h:
pcre/pcre_tables.c:
pcre/pcre_try_flipped.c: (_pcre_try_flipped):

2:26 PM Changeset in webkit [16154] by beidson

3 edits in trunk/WebCore

Reviewed by John

Cleaned up my last patch after further considerations

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Uses the new checkForDanglingPageURLs to check for and fix danglers. Does so in all builds (changed from debug only in my last patch) (WebCore::IconDatabase::syncDatabase): Uses the new checkForDanglingPageURLs to check for danglers (WebCore::IconDatabase::checkForDanglingPageURLs): This checks and, if asked via an arg, prunes the dangling pageURLs
loader/icon/IconDatabase.h:

2:05 PM Changeset in webkit [16153] by andersca

4 edits
2 adds in trunk/WebCore

2006-08-31 Anders Carlsson <acarlsson@apple.com>

Reviewed by Maciej.

Add CString. CString is a simple, null-terminated byte buffer that supports data
sharing. Its main use is to be a better const char*.

Also add latin1 and utf8 methods to String which returns CStrings.

platform/CString.cpp: Added. (WebCore::CString::CString): (WebCore::CString::init): (WebCore::CString::data): (WebCore::CString::length): (WebCore::CString::deprecatedCString):
platform/CString.h: Added. (WebCore::CStringBuffer::CStringBuffer): (WebCore::CStringBuffer::data): (WebCore::CStringBuffer::length): (WebCore::CString::CString): (WebCore::CString::operator const char*): (WebCore::CString::isNull):
platform/PlatformString.h:
platform/String.cpp: (WebCore::String::latin1): (WebCore::String::utf8):

2:01 PM Changeset in webkit [22133] by andersca

2 edits in branches/WindowsMerge/WebCore

2006-08-31 Anders Carlsson <acarlsson@apple.com>

Fix the build.

WebCore.vcproj/WebCore.vcproj:

1:26 PM Changeset in webkit [16152] by beidson

3 edits in trunk/WebCore

Reviewed by Hyatt

Previously mentioned ASSERT was hit right away by folks, as we first need to bring their old icon.db into consistency
Changed the ASSERT to a LOG_ERROR and added a method for debug builds to bring a DB back together.

loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::pruneUnretainedIconsOnStartup): Check for the danglers and prune them out (WebCore::IconDatabase::syncDatabase): Check for the danglers and log the error (WebCore::IconDatabase::pruneDanglingPageURLs): Prune the danglers
loader/icon/IconDatabase.h:

1:25 PM Changeset in webkit [16151] by antti

2 edits in S60/trunk/WebCore

12:40 PM Changeset in webkit [16150] by spadma

2 edits in S60/trunk/WebCore

2006-08-31 spadma <sachin.padma@nokia.com>

Reviewed by Sriram.
DESC: Set the focused element type to none when no anchor is focused
http://bugzilla.opendarwin.org/show_bug.cgi?id=10659

WARNING: NO TEST CASES ADDED OR CHANGED

kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::tabbedNavigation):

11:57 AM Changeset in webkit [16149] by spadma

2 edits in S60/trunk/WebKit

2006-08-31 ligman <joseph.ligman@nokia.com>

Reviewed by Sachin/Yongjun.
DESC: Set the current page Url.
http://bugzilla.opendarwin.org/show_bug.cgi?id=

BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL): (CWebKitLoader::LoadResourceL):

11:22 AM Changeset in webkit [16148] by thatcher

1 edit in trunk/WebCore/bindings/objc/DOMHTML.mm

Build fix to avoid name conflicts with generated properties.

10:38 AM Changeset in webkit [16147] by beidson

5 edits in trunk/WebCore

Reviewed by Hyatt

Fixed an error where an Icon's IconID could change without the change being reflected in the PageURL table,
causing icons to be pruned before their time and pages to lose their icons. This is because I misunderstood
how SQLite handles the "ON CONFLICT REPLACE" condition, which is to delete the row and re-insert instead of
perform an update. Also added an assertion to make sure this doesn't happen again.

loader/icon/IconDataCache.cpp: (WebCore::IconDataCache::writeToDatabase): Instead of one INSERT relying on SQLites conflict handling, broke this into an UPDATE attempt followed by the initial INSERT
loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::createDatabaseTables): Slight tweak to the database schema to prevent this from happening in the future. Note this change will not cause incompatibility with the current schema, therefore I didn't update the official database version number (WebCore::IconDatabase::syncDatabase): Added an ASSERT to look for this condition in the future
loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::lastChanges): Added this SQLite accessor to see if an UPDATE command actually changed a row
loader/icon/SQLDatabase.h: Ditto

10:37 AM Changeset in webkit [22132] by sfalken

20 edits
4 adds in branches/WindowsMerge

10:20 AM Changeset in webkit [16146] by weinig

13 edits in trunk

WebCore:

Reviewed by Tim H.

patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10653 Auto-generate another 20 Objective-C DOM HTML bindings

Auto-generates DOMHTMLBRElement, DOMHTMLButtonElement, DOMHTMLDListElement,
DOMHTMLDirectoryElement, DOMHTMLDivElement, DOMHTMLFieldSetElement,
DOMHTMLHeadingElement, DOMHTMLInputElement, DOMHTMLLIElement, DOMHTMLLabelElement,
DOMHTMLLegendElement, DOMHTMLMenuElement, DOMHTMLOListElement, DOMHTMLOptGroupElement,
DOMHTMLParagraphElement, DOMHTMLPreElement, DOMHTMLQuoteElement, DOMHTMLSelectElement,
DOMHTMLTextAreaElement, and DOMHTMLUListElement.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOM.mm:
bindings/objc/DOMExtensions.h:
bindings/objc/DOMHTML.h:
bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement altDisplayString]): (-[DOMHTMLInputElement absoluteImageURL]): (-[DOMHTMLInputElement WebCore::]): (-[DOMHTMLInputElement _rectOnScreen]): (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]): (-[DOMHTMLInputElement _selectedRange]): (-[DOMHTMLInputElement _setAutofilled:]):
bindings/objc/DOMHTMLInternal.h:
bindings/objc/DOMPrivate.h:
bindings/scripts/CodeGeneratorObjC.pm:

WebKit:

Reviewed by Tim H.

patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10653 Auto-generate another 20 Objective-C DOM HTML bindings

MigrateHeaders.make:
WebKit.xcodeproj/project.pbxproj:

9:31 AM Changeset in webkit [16145] by adele

10 edits in trunk

WebCore:

Reviewed by John Sullivan.

Removing use of SPI in favor of Carbon API to enable and disable secure event input.

WebCore.exp: Removed wkSecureEventInput and wkSetSecureEventInput.
platform/mac/WebCoreSystemInterface.h: ditto.
platform/mac/WebCoreSystemInterface.mm: ditto.

bridge/mac/FrameMac.mm: (WebCore::FrameMac::setSecureKeyboardEntry): Uses EnableSecureEventInput and DisableSecureEventInput. (WebCore::FrameMac::secureKeyboardEntry): Uses IsSecureEventInputEnabled.

WebKit:

Reviewed by John Sullivan.

Removed wkSecureEventInput and wkSetSecureEventInput, since this can be done with API.

WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):

WebKitLibraries:

Reviewed by John Sullivan.

Removed wkSecureEventInput and wkSetSecureEventInput, since this can be done with API.

WebKitSystemInterface.h:
libWebKitSystemInterface.a:

9:25 AM Changeset in webkit [16144] by sullivan

2 edits in trunk/WebKit

Reviewed by Tim Omernick

fixed <rdar://problem/4711200> Loading history would be faster if it bypassed NSURL API for local files

History/WebHistory.m: (-[WebHistoryPrivate _loadHistoryGutsFromURL:savedItemsCount:collectDiscardedItemsInto:error:]): Load file URLs using [NSDictionary dictionaryWithContentsOfFile:]. I also cleaned up some minor style issues in this method, and I removed the support for old NSArray-style history files (which we stopped using before Safari 1.0).

9:06 AM Changeset in webkit [16143] by zbujtas

2 edits in S60/trunk/WebCore

2006-08-30 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Antti Koivisto.

WARNING: NO TEST CASES ADDED OR CHANGED

http://bugzilla.opendarwin.org/show_bug.cgi?id=10646

kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition):

9:02 AM Changeset in webkit [16142] by zbujtas

8 edits in S60/trunk/WebCore

2006-08-29 yadavall <koivisto@iki.fi>

Reviewed by Antti Koivisto.

WARNING: NO TEST CASES ADDED OR CHANGED

http://bugzilla.opendarwin.org/show_bug.cgi?id=9077

khtml/editing/markup.cpp: (khtml::endMarkup):
khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::createTokenizer):
khtml/html/html_documentimpl.h:
khtml/html/htmlparser.cpp: (KHTMLParser::getElement):
khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseComment):
khtml/xml/dom_docimpl.cpp: (DocumentImpl::~DocumentImpl): (DocumentImpl::documentElement):
khtml/xml/dom_docimpl.h:

8:38 AM Changeset in webkit [16141] by zbujtas