Context Navigation

editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): Added check for empty vector.
editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Ditto.

2:43 PM Changeset in webkit [16256] by spadma

28 edits in S60/trunk

2006-09-06 vbradley <vincent.bradley@nokia.com>

Reviewed by Sachin Padma.
DESC: Removed the obsolete flag RD_BROWSER_VIDEO_PLUGIN
http://bugzilla.opendarwin.org/show_bug.cgi?id=10258

BrowserControl/src/BrCtl.cpp: (CBrCtl::HandleCommandL): (CBrCtl::AddOptionMenuItemsL):
BrowserView/inc/WebKitView.h:
BrowserView/inc/webkitbridge.h: (CWebKitBridge::IsTabbedNavigationEnabled):
BrowserView/src/HttpLoaderEventToUiListener.cpp: (CHttpLoaderEventToUiListener::ConnectionRequest):
BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::NavigateWithCursor): (CKeyEventHandler::HandleActivateKeysL):
BrowserView/src/WebKitControl.cpp: (CWebKitControl::FinalProgressComplete):
BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::CursorUpdate):
BrowserView/src/WebKitView.cpp: (CWebKitView::CWebKitView): (CWebKitView::ConstructL): (CWebKitView::FocusChanged): (CWebKitView::ResetFlags):
BrowserView/src/webkitbridge.cpp: (CWebKitBridge::NotifyMetaData):
Plugin/inc/PluginWin.h: (CPluginWin::IsPluginFocus): (CPluginWin::SetOptionMenuHandler):
Plugin/src/PluginSkin.cpp: (CPluginSkin::ConstructL):
Plugin/src/PluginWin.cpp: (CPluginWin::MakeVisible): (CPluginWin::HandlePluginCommandL):
group/BrowserView.mmp:

2:39 PM Changeset in webkit [16255] by darin

2 edits in trunk/WebKitTools

More renaming plans.

2:00 PM Changeset in webkit [16254] by spadma

2 edits in S60/trunk/WebKit

2006-09-06 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Sachin Padma
DESC: Fix the condition which checks if it is a reload
http://bugzilla.opendarwin.org/show_bug.cgi?id=10627

BrowserView/src/webkitbridge.cpp: (CWebKitBridge::LoadUrlL):

1:34 PM Changeset in webkit [16253] by zbujtas

2 edits in S60/trunk/WebCore

2006-09-06 bujtas <zbujtas@gmail.com>

Reviewed by Antti Koivisto
DESC: fix .innerhtml crash in htmlparser by adding
extra refcount to the htmlstackelem to protect nodes in
the stack.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10756

WARNING: NO TEST CASES ADDED OR CHANGED

khtml/html/htmlparser.cpp: (KHTMLParser::handleResidualStyleCloseTagAcrossBlocks): (KHTMLParser::popBlock):

11:45 AM Changeset in webkit [22144] by aroben

9 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin.

Fixed various Windows build issues caused by previous checkins.

bridge/win/FrameWin.h: Added missing #include, updated Selection to SelectionController.
platform/win/FontWin.cpp: Reorganized #includes. (WebCore::Font::drawGlyphs): Used a const_cast hack to fix ultimately broken code.
platform/win/ResourceLoaderWin.cpp: Added missing #include of CString.h and removed double #include of config.h. (WebCore::ResourceLoaderWndProc): Removed use of String::ascii. (WebCore::ResourceLoader::start): Ditto.
platform/win/TemporaryLinkStubs.cpp: Added missing stubs. (FrameWin::markMisspellings): (FrameWin::shouldChangeSelection): (FrameWin::respondToChangedSelection): (FrameWin::respondToChangedContents): (FrameWin::handledOnloadEvents): (FrameWin::createPlugin): (FrameWin::objectContentType):
rendering/RenderPopupMenuWin.cpp: Added missing #include.

WebKitWin:

Reviewed by Darin.

Fixed various Windows build problems caused by previous checkins.

WebKitDLL.h: Disable deprecation warning triggered by using std::copy on a Vector.
WebView.cpp: (WebView::keyPress): Rename selection to selectionController.

11:31 AM Changeset in webkit [16252] by thatcher

2 edits in trunk/WebCore

Reviewed and tweaked by Tim H.

<rdar://problem/4564955> WebKit doesn't trigger Auto Font Activation

If we don't find the font in the available fonts list, call [NSFont fontWithName:size:]
to trigger a search that will include auto activation. No PLT or iBench perf impact.
No layout tests affected. Not testable in an automated way that will work on all systems.

platform/mac/WebFontCache.mm: (+[WebFontCache fontWithFamily:traits:size:]):

10:17 AM Changeset in webkit [16251] by ap

10 edits
1 delete in trunk/WebCore

2006-09-06 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed and landed by ap.

Fix Qt/Linux build.

CMakeLists.txt: Take out CharacterData.cpp from build / add new Text* files to build.
platform/qt/BrowserExtensionQt.cpp: Add wtf/Platform.h include.
platform/qt/FontCacheQt.cpp: Add FontData.h include.
platform/qt/FontQt.cpp: (WebCore::Font::drawGlyphs): Fix constness in reinterpret_cast.
platform/qt/FrameQt.cpp: (WebCore::FrameQt::markMisspellings): Change "SelectionController" param type to "Selection". (WebCore::FrameQt::respondToChangedSelection): Ditto. (WebCore::FrameQt::respondToChangedContents): Ditto. (WebCore::FrameQt::shouldChangeSelection): Ditto.
platform/qt/FrameQt.h: Ditto.
platform/qt/ImageQt.cpp: (WebCore::Image::supportsType): Fix String->QString conversion.
platform/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::add): Fix String->DeprecatedString conversion.
platform/qt/ScrollViewCanvasQt.cpp: (WebCore::ScrollViewCanvasQt::handleKeyEvent): Adapt to SelectionController signature changes.
platform/qt/qt-encodings.txt: Removed.

9:23 AM Changeset in webkit [16250] by darin

77 edits
1 add in trunk/WebCore

Reviewed by Tim Hatcher.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10675 tweak font-related headers and convert lists to vectors

One major change was to greatly reduce the number of files that include Font.h.
Another was to convert many uses of DeprecatedPtrList/DeprecatedValueList to Vector.

WebCore.xcodeproj/project.pbxproj: Added TextStyle.h.

bindings/objc/DOM.mm: (-[DOMElement _font]): Changed to not depend on Font::getNSFont since a WebCore::Font represents more than one NSFont.

bindings/objc/DOMNode.mm: (-[DOMNode lineBoxRects]): Updated to use Vector.
bridge/mac/FormDataMac.mm: (WebCore::arrayFromFormData): Ditto.
bridge/mac/FrameViewMac.mm: (WebCore::FrameView::updateDashboardRegions): Ditto.
css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Ditto.
dom/Document.cpp: (WebCore::Document::dashboardRegions): Ditto. (WebCore::Document::setDashboardRegions): Ditto.
dom/Document.h: Ditto.
editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::removeUnrenderedNodes): Ditto.
html/FormDataList.h: Ditto.
html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isFocusable): Ditto.
html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData): Ditto.
kcanvas/RenderPath.cpp: (WebCore::RenderPath::absoluteRects): Ditto.
kcanvas/RenderPath.h: Ditto.
kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::absoluteRects): Ditto.
kcanvas/RenderSVGImage.h: Ditto.
kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::absoluteRects): Ditto.
kcanvas/RenderSVGText.h: Ditto.
loader/FormData.cpp: (WebCore::FormData::flatten): Ditto. (WebCore::FormData::flattenToString): Ditto.
loader/FormData.h: (WebCore::FormData::elements): Ditto.
loader/mac/LoaderFunctionsMac.mm: (WebCore::ServeSynchronousRequest): Ditto.
page/Frame.cpp: (WebCore::Frame::markedTextUnderlines): Ditto.
page/Frame.h: Ditto.
page/FramePrivate.h: Ditto.
platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): Ditto.
rendering/InlineTextBox.h: Ditto.
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint): Ditto. (WebCore::InlineTextBox::paintMarkedTextUnderline): Ditto.
rendering/RenderContainer.h: Ditto.
rendering/RenderContainer.cpp: (WebCore::RenderContainer::lineBoxRects): Ditto.
rendering/RenderInline.h: Ditto.
rendering/RenderInline.cpp: (WebCore::RenderInline::absoluteRects): Ditto.
rendering/RenderObject.h: Ditto.
rendering/RenderObject.cpp: (WebCore::RenderObject::lineBoxRects): Ditto. (WebCore::RenderObject::absoluteRects): Ditto. (WebCore::RenderObject::absoluteBoundingBoxRect): Ditto. (WebCore::RenderObject::addDashboardRegions): Ditto. (WebCore::RenderObject::collectDashboardRegions): Ditto.
rendering/RenderStyle.h: Ditto.
rendering/RenderStyle.cpp: (WebCore::RenderStyle::initialDashboardRegions): Ditto. (WebCore::RenderStyle::noneDashboardRegions): Ditto.
rendering/RenderText.h: Ditto.
rendering/RenderText.cpp: (WebCore::RenderText::absoluteRects): Ditto. (WebCore::RenderText::lineBoxRects): Ditto.
rendering/RenderView.h: Ditto.
rendering/RenderView.cpp: (WebCore::RenderView::absoluteRects): Ditto.

bridge/mac/FrameMac.mm: (WebCore::FrameMac::attributedString): Updated to use Vector and changed to not depend on getNSFont on a Font. (WebCore::FrameMac::fontForSelection): Changed to not depend on Font::getNSFont. (WebCore::FrameMac::fontAttributesForSelectionStart): Ditto. (WebCore::convertAttributesToUnderlines): Updated to use Vector. (WebCore::FrameMac::setMarkedTextRange): Ditto. (WebCore::FrameMac::dashboardRegionsDictionary): Ditto.

bridge/mac/WebCoreAXObject.mm: (boundingBoxRect): Updated to use Vector. (AXAttributeStringSetStyle): Changed to not depend on Font::getNSFont.

bridge/mac/WebCoreStringTruncator.mm: Updated includes.
page/Settings.h: Ditto.
platform/mac/WebCoreTextRenderer.mm: Ditto.
rendering/EllipsisBox.cpp: Ditto.

editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): Updated to use a Vector that we iterate in reverse order instead of a linked list that we reverse by prepending elements instead of adding to the end.
editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Ditto.

loader/DocLoader.h: Removed unneeded include of DeprecatedPtrList.h.

platform/Font.h: Moved TextStyle to a separate header. Removed Font::getNSFont.
platform/Font.cpp: Changed to use const instead of #define. (WebCore::Font::width): Overloaded this so we don't have a default parameter, which eliminates the need to have TextStyle defined to compiler the Font.h header.

platform/TextStyle.h: Added.

platform/FontData.h: Added a forward declaration of ATSUStyle so this header can stand alone.

platform/FontFallbackList.h: Tweaks.
platform/FontFallbackList.cpp: Tweaks.

platform/FontFamily.h: Removed unneeded NSString declaration. Simplified class by using Shared and RefPtr, which resulted in removing many explicit functions.
platform/FontFamily.cpp: More of the same.

platform/GlyphBuffer.h: Removed unneeded MAX_GLYPH_EXPANSION and GLYPH_BUFFER_SIZE macros.

platform/GlyphMap.h: Removed unneeded include of GlyphBuffer.h, which was included only for the typedef of Glyph; there's no reason to not just repeat that typedef here since C++ allows multiple typedefs if they match. Renamed the cGlyphPageSize constant to GlyphPage::size.
platform/GlyphMap.cpp: Changed NO_BREAK_SPACE and ZERO_WIDTH_SPACE macros into constants. Updated for cGlyphPageSize change.
platform/mac/GlyphMapMac.cpp: Updated for cGlyphPageSize change.

platform/GlyphWidthMap.h: Removed unneeded include of GlyphBuffer.h, which was included only for the typedef of Glyph; there's no reason to not just repeat that typedef here since C++ allows multiple typedefs if they match. Renamed the cGlyphWidthPageSize constant to GlyphWidthPage::size.
platform/GlyphWidthMap.cpp: Updated for cGlyphWidthPageSize change.

platform/GraphicsContext.h: Removed unneeded include of Font.h. Changed drawText function to use overloading instead of default parameters to allow TextStyle to be optional. This cuts the dependency on TextStyle.
platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText): Added overload.

platform/Image.h: Removed unneeded forward declaration of IntSize.

platform/mac/FontCacheMac.mm: (WebCore::FontCache::getFontDataForCharacters): Changed to not depend on Font::getNSFont.
platform/mac/ListBoxMac.mm: (-[WebCoreTableView fontChanged]): Ditto.
platform/mac/TextFieldMac.mm: (-[NSSearchFieldCell _addStringToRecentSearches:]): Ditto.
rendering/RenderPopupMenuMac.mm: (WebCore::RenderPopupMenuMac::showPopup): Ditto. (WebCore::RenderPopupMenuMac::addGroupLabel): Ditto. (WebCore::RenderPopupMenuMac::addOption): Ditto.

platform/mac/FontDataMac.mm: Fixed includes. Converted a bunch of macros to be constants and inline functions instead.

platform/mac/FontMac.mm: Fixed includes.
platform/mac/PopUpButtonMac.mm: Ditto.
rendering/RenderMenuList.cpp: Ditto.
rendering/RenderTextControl.cpp: Ditto.

platform/mac/WebCoreSystemInterface.h: Fixes so this header stands alone and is compatible with all 4 of C, ObjC, C++, ObjC++.

9:11 AM Changeset in webkit [16249] by ap

2 edits in trunk/WebKit

MigrateHeaders.make: Fixed a double slash in "$(PRIVATE_HEADERS_DIR)DOMCharacterDataPrivate.h" (this was reported to cause a build failure under certain circumstances).

12:09 AM Changeset in webkit [16248] by aroben

9 edits in trunk

2006-09-05 MorganL <morlmor@yahoocom>

Reviewed/landed by aroben.

Fixes bug 10743: Windows build is busted.

WebCore:

WebCore.vcproj/WebCore/WebCore.vcproj:
bridge/win/FrameWin.h:
platform/ResourceLoaderInternal.h:
platform/TextEncodingRegistry.cpp:
platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoaderWndProc): (WebCore::ResourceLoader::start):
platform/win/TemporaryLinkStubs.cpp: (FrameWin::markMisspellings): (FrameWin::shouldChangeSelection): (FrameWin::respondToChangedSelection): (FrameWin::respondToChangedContents): (RenderThemeWin::adjustMenuListStyle):

WebKit:

COM/WebView.cpp: (WebView::keyPress):

Sep 5, 2006:

11:02 PM Changeset in webkit [16247] by darin

5 edits in trunk/WebCore

some quick build fixes

bridge/mac/WebCoreAXObject.mm: Remove use of WebCore::UChar.
bridge/mac/WebCoreFrameBridge.mm: Ditto. Also remove include of CharsetNames.h.
css/CSSGrammar.y: Remove use of WebCore::UChar.
platform/UChar.h: Back out WebCore::UChar for now.

10:23 PM Changeset in webkit [16246] by thatcher

2 edits in trunk/WebKit

Reviewed by Darin.

Drastically simplified the makefile for migrating headers from
WebCore and JavaScriptCore. The old version was always copying the files.

MigrateHeaders.make:

10:18 PM Changeset in webkit [22143] by darin

1 edit in branches/WindowsMerge/WebCore/platform/win/TemporaryLinkStubs.cpp

Cleared a couple of stray executable bits.

9:40 PM Changeset in webkit [16245] by darin

93 edits
14 adds
3 deletes in trunk

LayoutTests:

Reviewed by Alexey.

test for bug where the charset in a link element for a CSS stylesheet is ignored. I noticed this while working on new text encoding machinery.

fast/encoding/css-link-charset-expected.txt: Added.
fast/encoding/css-link-charset.css: Added.
fast/encoding/css-link-charset.html: Added.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10681 REGRESSION: Reproducible crash at Wikipedia (Alexey wrote this one, I reviewed.)

fast/forms/form-data-encoding-normalization-overrun-expected.txt: Added.
fast/forms/form-data-encoding-normalization-overrun.html: Added.

and a tweak to an existing test

fast/forms/form-data-encoding.html: Changed to dump encoded URL so it's easier to diagnose this when it fails.

WebCore:

Reviewed by Alexey.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10728 text encodings should work without a numeric ID

includes a fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10681 REGRESSION: Reproducible crash at Wikipedia

fixed a bug where link elements would not set the charset properly for CSS stylesheets they loaded

converted DeprecatedString code paths that are related to decoding web pages to use String instead, to ensure that conversion back and forth won't hurt performance

Test: fast/encoding/css-link-charset.html
Test: fast/forms/form-data-encoding-normalization-overrun.html

Coverage for encoding issues is pretty good, so we probably don't need more
tests to land this. Our existing tests did find issues with this patch while
it was under development. And I suppose it would be nice to have even more tests.

platform/TextEncoding.h:
platform/TextEncoding.cpp: (WebCore::addEncodingName): Added. Used to build up the set used by isJapanese. (WebCore::TextEncoding::TextEncoding): Removed boolean "eight bit only" parameter and added an overload for String as well as const char*. Simplified because now the only data member is m_name -- calls the registry's atomicCanonicalTextEncodingName function to make the name canonical (resolve aliases) and atomic (use a single pointer for each encoding name so we can compare and hash efficiently). (WebCore::TextEncoding::decode): Renamed from toUnicode. Just a simple wrapper on top of TextDecoder that can be used when the data to decode is all present at once. (WebCore::TextEncoding::encode): Renamed from fromUnicode. Handles the normalization and then uses the registry to get a codec to handle the rest. (WebCore::TextEncoding::usesVisualOrdering): New implementation that compares with the name of the only encoding that uses visual ordering. We blur the concepts a bit so that we treat the visual ordering and logical ordering variations as two separate encodings. (WebCore::TextEncoding::isJapanese): New implementation that uses a set to efficiently determine if an encoding is Japanese. (WebCore::TextEncoding::backslashAsCurrencySymbol): New implementation that compares with the names of the two encodings that have the strange backslash. (WebCore::TextEncoding::closest8BitEquivalent): Added. Replaces the old "eight bit only" boolean parameter to the constructor. (WebCore::ASCIIEncoding): Added. (WebCore::Latin1Encoding): Added. (WebCore::UTF16BigEndianEncoding): Added. (WebCore::UTF16LittleEndianEncoding): Added. (WebCore::UTF8Encoding): Added. (WebCore::WindowsLatin1Encoding): Added.

platform/TextEncodingRegistry.h: Added.
platform/TextEncodingRegistry.cpp: Added. Keeps a table of all the character set aliases and names and another of all the codecs and parameters for each name.

platform/TextDecoder.h: Added.
platform/TextDecoder.cpp: Added. Contains logic to look for a BOM and hand the data to the proper codec, based on code that used to be in both the ICU and Mac codecs.

platform/StreamingTextDecoder.h: Renamed class to TextCodec. We'll rename the files in a later check-in. Moved creation functions into TextEncodingRegistry.h. Added typedefs of the registrar function types so classes derived from this one can use them without including the TextEncodingRegistry header. Renamed toUnicode and fromUnicode to decode and encode. Changed the parameter and return types so that the parameters are pointers to the data and the return types are String and CString.
platform/StreamingTextDecoder.cpp: (WebCore::TextCodec::appendOmittingBOM): Added. Helper function used by multiple classes derived from this one.

platform/TextCodecLatin1.h: Added.
platform/TextCodecLatin1.cpp: Added. Contains logic to handle encoding and decoding Windows Latin-1, based on code that used to be in both the ICU and Mac codecs.

platform/TextCodecUTF16.h: Added.
platform/TextCodecUTF16.cpp: Added. Contains logic to handle encoding and decoding UTF-16, based on code that used to be in both the ICU and Mac codecs.

platform/StreamingTextDecoderICU.h: Renamed class to TextCodecICU. We'll rename the files in a later check-in. Removed all the functions having to do with handling BOM, UTF-16, and Latin-1; those are now handled elsewhere. Removed textEncodingSupported because that's superseded by the registry. Added registry hook functions.
platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::registerEncodingNames): Added. Registers all encodings that ICU can handle with the "IANA" standard. Also includes a special case for a particular type of encoding for Hebrew that uses logical ordering. Also includes aliases that are not in ICU but that were historically known to WebKit for encodings that ICU handles. (WebCore::newTextCodecICU): Added. Used by registerCodecs. (WebCore::TextCodecICU::registerCodecs): Added. Registers codecs for the same encodings as above. (WebCore::TextCodecICU::TextCodecICU): Much simplified since this now only handles the actual ICU encoding and decoding. (WebCore::TextCodecICU::~TextCodecICU): Renamed. (WebCore::TextCodecICU::releaseICUConverter): Changed to be a const member function. (WebCore::TextCodecICU::createICUConverter): Changed to be a const member function and to check if the cached converter can be reused in a simpler way. (WebCore::TextCodecICU::decode): Updated for changes to types. (WebCore::TextCodecICU::encode): Updated for changes to types, and removed normalization since this is now handled by the caller.

platform/mac/StreamingTextDecoderMac.h: Renamed class to TextCodecMac. We'll rename the files in a later check-in. Removed all the functions having to do with handling BOM, UTF-16, and Latin-1; those are now handled elsewhere. Removed textEncodingSupported because that's superseded by the registry. Added registry hook functions.
platform/mac/StreamingTextDecoderMac.cpp: (WebCore::TextCodecMac::registerEncodingNames): Added. Registers encodings based on the charset table generated by the make-charset-table.pl perl script. (WebCore::newTextCodecMac): Added. Used by registerCodecs. (WebCore::TextCodecMac::registerCodecs): Added. Registers codecs for the same encodings as above. (WebCore::TextCodecMac::TextCodecMac): Much simplified since this now only handles the actual TEC/CF encoding and decoding. (WebCore::TextCodecMac::~TextCodecMac): Renamed. (WebCore::TextCodecMac::releaseTECConverter): Changed to be a const member function. (WebCore::TextCodecMac::createTECConverter): Changed to be a const member function. (WebCore::TextCodecMac::decode): Updated for changes to types. (WebCore::TextCodecMac::encode): Updated for changes to types, and removed normalization since this is now handled by the caller.

platform/mac/mac-encodings.txt: Removed most of the names in this file. This now only includes encodings where we want to use Mac OS X Carbon Text Encoding Converter, which is only encodings that are not supported by ICU.
platform/make-charset-table.pl: Removed flags from output. We don't use them any more.
platform/CharsetData.h: Changed from a platform-independent header into a Macintosh-specific one. A later patch should move this and rename it. Also subsumes ExtraCFEncodings.h.

WebCore.xcodeproj/project.pbxproj: Added new files. Changed the prefix on the "make character sets" rule to be kTextEncoding instead of kCFStringEncoding.

loader/Decoder.h: Change the default encoding parameter to the constructor to be a TextEncoding object. Renamed setEncodingName to setEncoding, and made it take a TextEncoding for the encoding. Removed the encodingName and visuallyOrdered functions, since TextEncoding supports both directly in a straightforward way. Changed both decode and flush functions to return String instead of DeprecatedString. Added a number of private functions to factor this class a bit more so it's easier to read. Got rid of a number of redundant data members. Changed the buffer to a Vector<char>.
loader/Decoder.cpp: (WebCore::Decoder::determineContentType): Added. Used by constructor to determine the content type based on the passed-in MIME type. (WebCore::Decoder::defaultEncoding): Added. Used by constructor to determine the default encoding based on the passed in default and the content type. (WebCore::Decoder::Decoder): Changed to use the functions above. Also renamed m_reachedBody to m_checkedForHeadCharset. (WebCore::Decoder::setEncoding): Renamed and changed to take an encoding rather than an encoding name. (WebCore::Decoder::checkForBOM): Factored out of decode. (WebCore::Decoder::checkForCSSCharset): Factored out of decode. (WebCore::Decoder::checkForHeadCharset): Factored out of decode. (WebCore::Decoder::detectJapaneseEncoding): Factored out of decode. (WebCore::Decoder::decode): Refactored so it's no longer one huge function. Changed to use the new Vector<char> and the new API for TextDecoder. (WebCore::Decoder::flush): Added code to empty out the buffer. Not an issue in practice since we don't re-use the decoder after flushing it.

platform/UChar.h: Added. Has the type named WebCore::UChar that we'll be switching to. We'll switch away from the ICU ::UChar type, because we don't want to be so closely tied to ICU -- include this instead of <unicode/umachine.h>.

platform/PlatformString.h:
platform/String.cpp: (WebCore::String::latin1): Updated for changes to TextEncoding. (WebCore::String::utf8): Ditto. (WebCore::String::newUninitialized): Added. Gives a way to create a String and then write directly into its buffer.

platform/StringImpl.h: Changed return value for charactersWithNullTermination to be a const UChar*. While it's true that this function changes the underlying StringImpl, the characters still shouldn't be modified with the returned pointer.
platform/StringImpl.cpp: (WebCore::StringImpl::charactersWithNullTermination): Updated for change above. (WebCore::StringImpl::newUninitialized): Added. Gives a way to create a StringImpl and then write directly into its buffer.

platform/CString.h:
platform/CString.cpp: (WebCore::CString::newUninitialized): Added. Gives a way to create a CString and then write directly into its buffer.

bridge/mac/WebCoreFrameBridge.h: Removed textEncoding method, and replaced +[WebCoreFrameBridge stringWithData:textEncoding:] with -[WebCoreFrameBridge stringWithData:] to avoid having to pass text encoding IDs around.
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setEncoding:userChosen:]): Removed now-unneeded conversion to DeprecatedString. (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]): Ditto. (-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]): Ditto. (-[WebCoreFrameBridge referrer]): Removed now-unneeded call to getNSString. (-[WebCoreFrameBridge stringWithData:]): Added. Asks the document's decoder what its encoding is, and decodes using that. (+[WebCoreFrameBridge stringWithData:textEncodingName:]): Simplified so it no longer involved a text encoding ID number. (-[WebCoreFrameBridge smartInsertForString:replacingRange:beforeString:afterString:]): Changed to use UChar instead of DeprecatedChar. (-[WebCoreFrameBridge documentFragmentWithMarkupString:baseURLString:]): Removed now-unneeded conversion to DeprecatedString. (-[WebCoreFrameBridge documentFragmentWithText:inContext:]): Ditto.

html/HTMLFormElement.cpp: (WebCore::encodeCString): Changed parameter to CString. (WebCore::HTMLFormElement::formData): Updated code for improvements to TextEncoding.

loader/CachedCSSStyleSheet.h:
loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): Fixed mistake where the decoder was created without passing in the character set. Also changed from DeprecatedString to String. (WebCore::CachedCSSStyleSheet::setCharset): More of the same.

bindings/js/kjs_window.h: (KJS::ScheduledAction::ScheduledAction): Changed to use String instead of DeprecatedString, UChar instead of DeprecatedChar, CString instead of DeprecatedCString, etc.
bridge/mac/FormDataMac.mm: (WebCore::arrayFromFormData): Ditto.
bridge/mac/FrameMac.h: Ditto.
bridge/mac/FrameMac.mm: (WebCore::FrameMac::isCharacterSmartReplaceExempt): Ditto.
bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject helpText]): Ditto. (-[WebCoreAXObject value]): Ditto. (-[WebCoreAXObject accessibilityDescription]): Ditto. (-[WebCoreAXObject doAXStringForTextMarkerRange:]): Ditto.
bridge/mac/WebCoreEncodings.mm: (+[WebCoreEncodings decodeData:]): Ditto. Also fixed code that does a deref without a ref to use RefPtr instead.
bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame evaluateWebScript:]): Ditto.
bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings setDefaultTextEncoding:]): Ditto.
css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent): Ditto.
css/cssparser.cpp: (WebCore::CSSParser::lex): Ditto.
dom/Document.h:
dom/Document.cpp: (WebCore::Document::setCharset): Ditto. (WebCore::Document::write): Ditto. (WebCore::Document::determineParseMode): Ditto.
dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet): Ditto.
dom/XMLTokenizer.h:
dom/XMLTokenizer.cpp: (WebCore::shouldAllowExternalLoad): Ditto. (WebCore::createStringParser): Ditto. (WebCore::XMLTokenizer::write): Ditto. (WebCore::toString): Ditto. (WebCore::handleElementAttributes): Ditto. (WebCore::XMLTokenizer::startElementNs): Ditto. (WebCore::XMLTokenizer::endElementNs): Ditto. (WebCore::XMLTokenizer::characters): Ditto. (WebCore::XMLTokenizer::processingInstruction): Ditto. (WebCore::XMLTokenizer::cdataBlock): Ditto. (WebCore::XMLTokenizer::comment): Ditto. (WebCore::XMLTokenizer::internalSubset): Ditto. (WebCore::getXHTMLEntity): Ditto. (WebCore::externalSubsetHandler): Ditto. (WebCore::XMLTokenizer::initializeParserContext): Ditto. (WebCore::XMLTokenizer::notifyFinished): Ditto. (WebCore::xmlDocPtrForString): Ditto. (WebCore::parseXMLDocumentFragment): Ditto. (WebCore::attributesStartElementNsHandler): Ditto. (WebCore::parseAttributes): Ditto.
html/FormDataList.h:
html/FormDataList.cpp: (WebCore::FormDataList::appendString): Ditto. Also changed to call the encoding function by its new name and with new parameters. (WebCore::FormDataList::appendFile): Ditto.
html/HTMLDocument.h:
html/HTMLDocument.cpp: (WebCore::parseDocTypePart): Ditto. (WebCore::containsString): Ditto. (WebCore::parseDocTypeDeclaration): Ditto. (WebCore::HTMLDocument::determineParseMode): Ditto.
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::appendFormData): Ditto.
html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::parseMappedAttribute): Ditto.
html/HTMLTokenizer.h:
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): Ditto. (WebCore::HTMLTokenizer::parseTag): Ditto. (WebCore::HTMLTokenizer::write): Ditto. (WebCore::HTMLTokenizer::finish): Ditto. (WebCore::parseHTMLDocumentFragment): Ditto.
loader/Cache.h:
loader/Cache.cpp: (WebCore::Cache::requestStyleSheet): Ditto. (WebCore::Cache::requestScript): Ditto.
loader/CachedResource.h: Ditto.
loader/CachedScript.h:
loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript): Ditto. (WebCore::CachedScript::ref): Ditto. (WebCore::CachedScript::deref): Ditto. (WebCore::CachedScript::setCharset): Ditto. (WebCore::CachedScript::data): Ditto. (WebCore::CachedScript::checkNotify): Ditto.
loader/CachedXBLDocument.h:
loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::setCharset): Ditto.
loader/CachedXSLStyleSheet.h:
loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::setCharset): Ditto.
loader/DocLoader.cpp: (WebCore::DocLoader::requestStyleSheet): Ditto. (WebCore::DocLoader::requestScript): Ditto.
loader/DocLoader.h: Ditto.
loader/FormData.h:
loader/FormData.cpp: (WebCore::FormData::FormData): Ditto. (WebCore::FormData::appendFile): Ditto. (WebCore::FormData::flattenToString): Ditto.
page/Frame.h:
page/FramePrivate.h:
page/Frame.cpp: (WebCore::UserStyleSheetLoader::setStyleSheet): Ditto. (WebCore::getString): Ditto. (WebCore::Frame::replaceContentsWithScriptResult): Ditto. (WebCore::Frame::executeScript): Ditto. (WebCore::Frame::clear): Ditto. (WebCore::Frame::write): Ditto. (WebCore::Frame::endIfNotLoading): Ditto. (WebCore::Frame::baseTarget): Ditto. (WebCore::Frame::scheduleRedirection): Ditto. (WebCore::Frame::scheduleLocationChange): Ditto. (WebCore::Frame::scheduleHistoryNavigation): Ditto. (WebCore::Frame::changeLocation): Ditto. (WebCore::Frame::redirectionTimerFired): Ditto. (WebCore::Frame::encoding): Ditto. (WebCore::Frame::submitForm): Ditto. (WebCore::Frame::referrer): Ditto. (WebCore::Frame::isCharacterSmartReplaceExempt): Ditto. (WebCore::Frame::setEncoding): Ditto.
page/Settings.h: Ditto.
platform/SegmentedString.h: Ditto.
platform/SegmentedString.cpp: Ditto.
xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::parseString): Ditto.
xml/XSLTProcessor.cpp: (WebCore::transformTextStringToXHTMLDocumentString): Ditto. (WebCore::XSLTProcessor::createDocumentFromSource): Ditto.
xml/xmlhttprequest.h:
xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::open): Ditto. (WebCore::XMLHttpRequest::send): Ditto. (WebCore::XMLHttpRequest::receivedData): Ditto.

platform/DeprecatedString.cpp: (WebCore::DeprecatedString::fromUtf8): Updated for changes to TextEncoding. (WebCore::DeprecatedString::utf8): Ditto.

platform/KURL.h:
platform/KURL.cpp: (WebCore::KURL::KURL): Updated to overload based on presence or absence of TextEncoding rather than having a default. (WebCore::KURL::init): Moved body of constructor in here. Updated to use the new TextEncoding interface. (WebCore::KURL::decode_string): Updated to overload based on presence or absence of TextEncoding rather than having a default. Updated to use the new TextEncoding interface. (WebCore::encodeRelativeString): Updated to use the new TextEncoding interface.

platform/Font.cpp: (WebCore::WidthIterator::normalizeVoicingMarks): Fixed code to use U_ZERO_ERROR instead of a typecast.

bindings/js/kjs_proxy.h: Removed unneeded declaration of DeprecatedString.
platform/GraphicsContext.h: Ditto.

platform/GraphicsContext.cpp: Removed unneeded include of "DeprecatedString.h".
rendering/break_lines.cpp: Ditto.
xml/XMLSerializer.cpp: Ditto.

platform/mac/FontDataMac.mm: Removed unneeded include of <unicode/unorm.h>.

platform/CharsetNames.h: Emptied out this file. A later patch could remove it.
platform/CharsetNames.cpp: Ditto.
platform/mac/ExtraCFEncodings.h: Ditto.

WebKit:

Reviewed by Alexey.

WebKit side of changes to encoding

WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation documentSource]): Changed to call new -[WebCoreFrameBridge stringWithData:] instead of the calling the old methods that used a CFStringEncoding: -[WebCoreFrameBridge textEncoding] and +[WebCoreFrameBridge stringWithData:textEncoding:].

WebView/WebResource.m: (-[WebResource _stringValue]): Removed special case for nil encoding name. The bridge itself now has the rule that "nil encoding name means Latin-1", so we don't need to check for nil.

WebView/WebFrame.m: (-[WebFrame _checkLoadComplete]): Retain the frame until we get the parent frame while walking up parent frames, because it's possible for _checkLoadCompleteForThisFrame to release the last reference to the frame. (Not reviewed; needed to run performance tests successfully.)

9:40 PM Changeset in webkit [22142] by darin

2 edits in branches/WindowsMerge/WebCore

build fix part of http://bugzilla.opendarwin.org/show_bug.cgi?id=10728 text encodings should work without a numeric ID

WebCore.vcproj/WebCore.vcproj: Update for new headers.

8:36 PM Changeset in webkit [16244] by eseidel

127 edits in trunk/WebCore

2006-09-05 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10490

-> Remove all SVGAnimated* usage from ksvg2.
This is all done using a set of macros which live in svg/SVGElement.h
(ANIMATED_PROPERTY_DECLARATIONS / ANIMATED_PROPERTY_DEFINITIONS).
Transform all properties to this new concept using Eric ruby script.

-> Replace all usages of "property()->baseVal()" with "propertyBaseValue()".
-> Replace all usages of "property()->setBaseVal()" with "setPropertyBaseValue()".

-> Add "virtual const SVGElement* contextElement() const".
This concept allows to access the document (needed to access the SVGDocumentExtensions)
from lowest-base-classes like SVGURIReference / SVGExternalResourcesRequired etc.

These classes contain this contextElement() function as pure virtual functions.
The topmost classes (like SVGCircleElement) implement this function with "return this".

-> Move default value initialization to constructors.
As the lazy_create usage, which was involved in default property initialization,
has been removed, we need to do the initialization in the constructor.

This forces us to fix the SVGLength class, as calling viewportElement() from the
constructor does not work. This SVGLength cleanup is one of the next things to fix.

bindings/scripts/CodeGeneratorJS.pm:
kcanvas/RenderForeignObject.cpp: (WebCore::RenderForeignObject::translationForAttributes):
kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::relativeBBox): (WebCore::RenderSVGImage::getAbsoluteRepaintRect): (WebCore::RenderSVGImage::translationForAttributes):
kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::translationForAttributes):
ksvg2/misc/KSVGTimeScheduler.cpp: (WebCore::SVGTimer::notifyAll):
ksvg2/misc/SVGDocumentExtensions.cpp:
ksvg2/misc/SVGDocumentExtensions.h: (WebCore::SVGDocumentExtensions::baseValueMap): (WebCore::SVGDocumentExtensions::baseValue): (WebCore::SVGDocumentExtensions::setBaseValue): (WebCore::SVGDocumentExtensions::hasBaseValue): (WebCore::String): (WebCore::bool): (WebCore::double):
ksvg2/misc/SVGImageLoader.cpp: (WebCore::SVGImageLoader::updateFromElement):
ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::parseMappedAttribute): (WebCore::SVGAElement::defaultEventHandler):
ksvg2/svg/SVGAElement.h: (WebCore::SVGAElement::contextElement):
ksvg2/svg/SVGAnimateColorElement.h: (WebCore::SVGAnimateColorElement::contextElement):
ksvg2/svg/SVGAnimateElement.h: (WebCore::SVGAnimateElement::contextElement):
ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::handleTimerEvent): (WebCore::SVGAnimateTransformElement::initialMatrix):
ksvg2/svg/SVGAnimateTransformElement.h: (WebCore::SVGAnimateTransformElement::contextElement):
ksvg2/svg/SVGCircleElement.cpp: (SVGCircleElement::SVGCircleElement): (SVGCircleElement::parseMappedAttribute): (SVGCircleElement::toPathData): (SVGCircleElement::pushAttributeContext):
ksvg2/svg/SVGCircleElement.h: (WebCore::SVGCircleElement::contextElement):
ksvg2/svg/SVGClipPathElement.cpp: (SVGClipPathElement::SVGClipPathElement): (SVGClipPathElement::parseMappedAttribute): (SVGClipPathElement::canvasResource):
ksvg2/svg/SVGClipPathElement.h: (WebCore::SVGClipPathElement::contextElement):
ksvg2/svg/SVGComponentTransferFunctionElement.cpp: (SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): (SVGComponentTransferFunctionElement::parseMappedAttribute): (SVGComponentTransferFunctionElement::transferFunction):
ksvg2/svg/SVGComponentTransferFunctionElement.h:
ksvg2/svg/SVGCursorElement.cpp: (SVGCursorElement::SVGCursorElement): (SVGCursorElement::parseMappedAttribute):
ksvg2/svg/SVGCursorElement.h: (WebCore::SVGCursorElement::contextElement):
ksvg2/svg/SVGDefsElement.h: (WebCore::SVGDefsElement::contextElement):
ksvg2/svg/SVGElement.h:
ksvg2/svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::SVGEllipseElement): (WebCore::SVGEllipseElement::parseMappedAttribute): (WebCore::SVGEllipseElement::toPathData): (WebCore::SVGEllipseElement::pushAttributeContext):
ksvg2/svg/SVGEllipseElement.h: (WebCore::SVGEllipseElement::contextElement):
ksvg2/svg/SVGExternalResourcesRequired.cpp: (WebCore::SVGExternalResourcesRequired::SVGExternalResourcesRequired): (WebCore::SVGExternalResourcesRequired::parseMappedAttribute):
ksvg2/svg/SVGExternalResourcesRequired.h:
ksvg2/svg/SVGFEBlendElement.cpp: (SVGFEBlendElement::SVGFEBlendElement): (SVGFEBlendElement::parseMappedAttribute): (SVGFEBlendElement::filterEffect):
ksvg2/svg/SVGFEBlendElement.h: (WebCore::SVGFEBlendElement::contextElement):
ksvg2/svg/SVGFEColorMatrixElement.cpp: (SVGFEColorMatrixElement::SVGFEColorMatrixElement): (SVGFEColorMatrixElement::parseMappedAttribute): (SVGFEColorMatrixElement::filterEffect):
ksvg2/svg/SVGFEColorMatrixElement.h: (WebCore::SVGFEColorMatrixElement::contextElement):
ksvg2/svg/SVGFEComponentTransferElement.cpp: (SVGFEComponentTransferElement::SVGFEComponentTransferElement): (SVGFEComponentTransferElement::parseMappedAttribute): (SVGFEComponentTransferElement::filterEffect):
ksvg2/svg/SVGFEComponentTransferElement.h: (WebCore::SVGFEComponentTransferElement::contextElement):
ksvg2/svg/SVGFECompositeElement.cpp: (SVGFECompositeElement::SVGFECompositeElement): (SVGFECompositeElement::parseMappedAttribute): (SVGFECompositeElement::filterEffect):
ksvg2/svg/SVGFECompositeElement.h: (WebCore::SVGFECompositeElement::contextElement):
ksvg2/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement): (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute): (WebCore::SVGFEDiffuseLightingElement::filterEffect):
ksvg2/svg/SVGFEDiffuseLightingElement.h: (WebCore::SVGFEDiffuseLightingElement::contextElement):
ksvg2/svg/SVGFEDisplacementMapElement.cpp: (SVGFEDisplacementMapElement::SVGFEDisplacementMapElement): (SVGFEDisplacementMapElement::parseMappedAttribute): (SVGFEDisplacementMapElement::filterEffect):
ksvg2/svg/SVGFEDisplacementMapElement.h: (WebCore::SVGFEDisplacementMapElement::contextElement):
ksvg2/svg/SVGFEDistantLightElement.cpp: (WebCore::SVGFEDistantLightElement::lightSource):
ksvg2/svg/SVGFEFloodElement.cpp: (SVGFEFloodElement::parseMappedAttribute): (SVGFEFloodElement::filterEffect):
ksvg2/svg/SVGFEFloodElement.h: (WebCore::SVGFEFloodElement::contextElement):
ksvg2/svg/SVGFEGaussianBlurElement.cpp: (SVGFEGaussianBlurElement::SVGFEGaussianBlurElement): (SVGFEGaussianBlurElement::parseMappedAttribute): (SVGFEGaussianBlurElement::filterEffect):
ksvg2/svg/SVGFEGaussianBlurElement.h: (WebCore::SVGFEGaussianBlurElement::contextElement):
ksvg2/svg/SVGFEImageElement.cpp: (SVGFEImageElement::SVGFEImageElement): (SVGFEImageElement::parseMappedAttribute):
ksvg2/svg/SVGFEImageElement.h: (WebCore::SVGFEImageElement::contextElement):
ksvg2/svg/SVGFELightElement.cpp: (SVGFELightElement::SVGFELightElement): (SVGFELightElement::parseMappedAttribute):
ksvg2/svg/SVGFELightElement.h:
ksvg2/svg/SVGFEMergeElement.cpp: (SVGFEMergeElement::SVGFEMergeElement): (SVGFEMergeElement::filterEffect):
ksvg2/svg/SVGFEMergeElement.h: (WebCore::SVGFEMergeElement::contextElement):
ksvg2/svg/SVGFEMergeNodeElement.cpp: (SVGFEMergeNodeElement::parseMappedAttribute):
ksvg2/svg/SVGFEMergeNodeElement.h: (WebCore::SVGFEMergeNodeElement::contextElement):
ksvg2/svg/SVGFEOffsetElement.cpp: (SVGFEOffsetElement::SVGFEOffsetElement): (SVGFEOffsetElement::parseMappedAttribute): (SVGFEOffsetElement::filterEffect):
ksvg2/svg/SVGFEOffsetElement.h: (WebCore::SVGFEOffsetElement::contextElement):
ksvg2/svg/SVGFEPointLightElement.cpp: (WebCore::SVGFEPointLightElement::lightSource):
ksvg2/svg/SVGFESpecularLightingElement.cpp: (SVGFESpecularLightingElement::SVGFESpecularLightingElement): (SVGFESpecularLightingElement::parseMappedAttribute): (SVGFESpecularLightingElement::filterEffect):
ksvg2/svg/SVGFESpecularLightingElement.h: (WebCore::SVGFESpecularLightingElement::contextElement):
ksvg2/svg/SVGFESpotLightElement.cpp: (WebCore::SVGFESpotLightElement::lightSource):
ksvg2/svg/SVGFETileElement.cpp: (SVGFETileElement::parseMappedAttribute): (SVGFETileElement::filterEffect):
ksvg2/svg/SVGFETileElement.h: (WebCore::SVGFETileElement::contextElement):
ksvg2/svg/SVGFETurbulenceElement.cpp: (SVGFETurbulenceElement::SVGFETurbulenceElement): (SVGFETurbulenceElement::parseMappedAttribute): (SVGFETurbulenceElement::filterEffect):
ksvg2/svg/SVGFETurbulenceElement.h: (WebCore::SVGFETurbulenceElement::contextElement):
ksvg2/svg/SVGFilterElement.cpp: (SVGFilterElement::SVGFilterElement): (SVGFilterElement::parseMappedAttribute): (SVGFilterElement::canvasResource):
ksvg2/svg/SVGFilterElement.h: (WebCore::SVGFilterElement::contextElement):
ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp: (SVGFilterPrimitiveStandardAttributes::SVGFilterPrimitiveStandardAttributes): (SVGFilterPrimitiveStandardAttributes::~SVGFilterPrimitiveStandardAttributes): (SVGFilterPrimitiveStandardAttributes::parseMappedAttribute): (SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h: (WebCore::SVGFilterPrimitiveStandardAttributes::contextElement):
ksvg2/svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::SVGFitToViewBox): (WebCore::SVGFitToViewBox::parseViewBox): (WebCore::SVGFitToViewBox::viewBoxToViewTransform): (WebCore::SVGFitToViewBox::parseMappedAttribute):
ksvg2/svg/SVGFitToViewBox.h:
ksvg2/svg/SVGForeignObjectElement.cpp: (WebCore::SVGForeignObjectElement::SVGForeignObjectElement): (WebCore::SVGForeignObjectElement::parseMappedAttribute):
ksvg2/svg/SVGForeignObjectElement.h: (WebCore::SVGForeignObjectElement::isValid): (WebCore::SVGForeignObjectElement::contextElement):
ksvg2/svg/SVGGElement.h: (WebCore::SVGGElement::contextElement):
ksvg2/svg/SVGGradientElement.cpp: (SVGGradientElement::SVGGradientElement): (SVGGradientElement::parseMappedAttribute): (SVGGradientElement::rebuildStops):
ksvg2/svg/SVGGradientElement.h:
ksvg2/svg/SVGHelper.cpp: (WebCore::SVGHelper::PercentageOfViewport):
ksvg2/svg/SVGImageElement.cpp: (SVGImageElement::SVGImageElement): (SVGImageElement::parseMappedAttribute): (SVGImageElement::haveLoadedRequiredResources):
ksvg2/svg/SVGImageElement.h: (WebCore::SVGImageElement::contextElement):
ksvg2/svg/SVGLangSpace.h:
ksvg2/svg/SVGLength.cpp:
ksvg2/svg/SVGLineElement.cpp: (SVGLineElement::SVGLineElement): (SVGLineElement::parseMappedAttribute): (SVGLineElement::toPathData): (SVGLineElement::pushAttributeContext):
ksvg2/svg/SVGLineElement.h: (WebCore::SVGLineElement::contextElement):
ksvg2/svg/SVGLinearGradientElement.cpp: (SVGLinearGradientElement::SVGLinearGradientElement): (SVGLinearGradientElement::parseMappedAttribute): (SVGLinearGradientElement::buildGradient):
ksvg2/svg/SVGLinearGradientElement.h: (WebCore::SVGLinearGradientElement::contextElement):
ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::SVGMarkerElement): (WebCore::SVGMarkerElement::parseMappedAttribute): (WebCore::SVGMarkerElement::setOrientToAuto): (WebCore::SVGMarkerElement::setOrientToAngle): (WebCore::SVGMarkerElement::canvasResource):
ksvg2/svg/SVGMarkerElement.h: (WebCore::SVGMarkerElement::contextElement):
ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::attributeChanged): (WebCore::SVGMaskElement::parseMappedAttribute): (WebCore::SVGMaskElement::drawMaskerContent):
ksvg2/svg/SVGMaskElement.h: (WebCore::SVGMaskElement::contextElement):
ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::SVGPathElement):
ksvg2/svg/SVGPathElement.h: (WebCore::SVGPathElement::isValid): (WebCore::SVGPathElement::contextElement):
ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement): (WebCore::SVGPatternElement::parseMappedAttribute): (WebCore::SVGPatternElement::pushAttributeContext): (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::drawPatternContentIntoTile): (WebCore::SVGPatternElement::notifyAttributeChange): (WebCore::SVGPatternElement::getCTM):
ksvg2/svg/SVGPatternElement.h: (WebCore::SVGPatternElement::contextElement):
ksvg2/svg/SVGPolyElement.h: (WebCore::SVGPolyElement::contextElement):
ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::SVGRadialGradientElement): (WebCore::SVGRadialGradientElement::~SVGRadialGradientElement): (WebCore::SVGRadialGradientElement::parseMappedAttribute): (WebCore::SVGRadialGradientElement::buildGradient):
ksvg2/svg/SVGRadialGradientElement.h: (WebCore::SVGRadialGradientElement::contextElement):
ksvg2/svg/SVGRectElement.cpp: (WebCore::SVGRectElement::SVGRectElement): (WebCore::SVGRectElement::parseMappedAttribute): (WebCore::SVGRectElement::toPathData): (WebCore::SVGRectElement::pushAttributeContext):
ksvg2/svg/SVGRectElement.h: (WebCore::SVGRectElement::contextElement):
ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement): (WebCore::SVGSVGElement::~SVGSVGElement): (WebCore::SVGSVGElement::viewport): (WebCore::SVGSVGElement::parseMappedAttribute): (WebCore::SVGSVGElement::getCTM): (WebCore::SVGSVGElement::getScreenCTM): (WebCore::SVGSVGElement::createRenderer):
ksvg2/svg/SVGSVGElement.h: (WebCore::SVGSVGElement::contextElement):
ksvg2/svg/SVGScriptElement.h: (WebCore::SVGScriptElement::contextElement):
ksvg2/svg/SVGSetElement.h: (WebCore::SVGSetElement::contextElement):
ksvg2/svg/SVGStopElement.cpp: (SVGStopElement::SVGStopElement): (SVGStopElement::parseMappedAttribute):
ksvg2/svg/SVGStopElement.h:
ksvg2/svg/SVGStylable.h:
ksvg2/svg/SVGStyledElement.cpp:
ksvg2/svg/SVGStyledElement.h:
ksvg2/svg/SVGStyledTransformableElement.cpp: (SVGStyledTransformableElement::SVGStyledTransformableElement): (SVGStyledTransformableElement::parseMappedAttribute):
ksvg2/svg/SVGStyledTransformableElement.h:
ksvg2/svg/SVGSwitchElement.cpp:
ksvg2/svg/SVGSwitchElement.h: (WebCore::SVGSwitchElement::contextElement):
ksvg2/svg/SVGSymbolElement.h: (WebCore::SVGSymbolElement::contextElement):
ksvg2/svg/SVGTRefElement.cpp: (SVGTRefElement::updateReferencedText):
ksvg2/svg/SVGTRefElement.h: (WebCore::SVGTRefElement::contextElement):
ksvg2/svg/SVGTSpanElement.h: (WebCore::SVGTSpanElement::contextElement):
ksvg2/svg/SVGTextContentElement.cpp: (SVGTextContentElement::SVGTextContentElement): (SVGTextContentElement::parseMappedAttribute):
ksvg2/svg/SVGTextContentElement.h:
ksvg2/svg/SVGTextElement.cpp: (WebCore::SVGTextElement::SVGTextElement): (WebCore::SVGTextElement::parseMappedAttribute):
ksvg2/svg/SVGTextElement.h: (WebCore::SVGTextElement::contextElement):
ksvg2/svg/SVGTextPositioningElement.cpp: (SVGTextPositioningElement::SVGTextPositioningElement): (SVGTextPositioningElement::parseMappedAttribute):
ksvg2/svg/SVGTextPositioningElement.h:
ksvg2/svg/SVGTransformable.cpp:
ksvg2/svg/SVGTransformable.h:
ksvg2/svg/SVGURIReference.cpp: (SVGURIReference::parseMappedAttribute):
ksvg2/svg/SVGURIReference.h:
ksvg2/svg/SVGUseElement.cpp: (SVGUseElement::SVGUseElement): (SVGUseElement::parseMappedAttribute): (SVGUseElement::closeRenderer):
ksvg2/svg/SVGUseElement.h: (WebCore::SVGUseElement::contextElement):
ksvg2/svg/SVGViewElement.h: (WebCore::SVGViewElement::contextElement):

8:26 PM Changeset in webkit [16243] by eseidel

5 edits in trunk/WebCore

2006-09-05 Eric Seidel <eric@eseidel.com>

Reviewed by aroben.

Speed up path parsing by removing string copies.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10722

Tests already cover path parsing.

ksvg2/svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::parseViewBox):
ksvg2/svg/svgpathparser.cpp: (WebCore::skipOptionalSpaces): Added. (WebCore::skipOptionalSpacesOrComma): Added. (WebCore::parseCoord): (WebCore::SVGPolyParser::parsePoints): (WebCore::SVGPathParser::parseSVG):

7:59 PM Changeset in webkit [16242] by weinig

6 edits in trunk/WebCore

Reviewed by Tim H.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10742
More Objective-C DOM auto-generation cleanup

Factor out implementation type-getters into their own function and standardize naming as was done for type-makers (ie. HTML and CSS prefixing for method names).

bindings/objc/DOMCSS.mm: (-[DOMCSSStyleDeclaration getPropertyShorthand:]): (-[DOMCSSStyleDeclaration isPropertyImplicit:]): (-[DOMCSSStyleDeclaration _CSSStyleDeclaration]):
bindings/objc/DOMHTML.mm: (-[DOMHTMLTableCaptionElement _HTMLTableCaptionElement]): (-[DOMHTMLTableSectionElement _HTMLTableSectionElement]): (-[DOMHTMLTableElement _HTMLTableElement]): (-[DOMHTMLTableCellElement _HTMLTableCellElement]): (-[DOMHTMLEmbedElement _HTMLEmbedElement]): (-[DOMHTMLEmbedElement align]): (-[DOMHTMLEmbedElement setAlign:]): (-[DOMHTMLEmbedElement height]): (-[DOMHTMLEmbedElement setHeight:]): (-[DOMHTMLEmbedElement name]): (-[DOMHTMLEmbedElement setName:]): (-[DOMHTMLEmbedElement src]): (-[DOMHTMLEmbedElement setSrc:]): (-[DOMHTMLEmbedElement type]): (-[DOMHTMLEmbedElement setType:]): (-[DOMHTMLEmbedElement width]): (-[DOMHTMLEmbedElement setWidth:]):
bindings/objc/DOMInternal.h:
bindings/scripts/CodeGeneratorObjC.pm:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setTypingStyle:withUndoAction:]): (-[WebCoreFrameBridge applyStyle:withUndoAction:]): (-[WebCoreFrameBridge applyParagraphStyle:withUndoAction:]): (-[WebCoreFrameBridge selectionStartHasStyle:]): (-[WebCoreFrameBridge selectionHasStyle:]):

7:30 PM Changeset in webkit [16241] by thatcher

5 edits
2 copies in trunk/WebCore

Rolling out my earlier change, which broke the build for Tiger.

5:48 PM Changeset in webkit [16240] by thatcher

5 edits
2 deletes in trunk/WebCore

Reviewed by John.

Removing the DOMImplementationFront workaround for an older GCC bug.
This changes requires Xcode 2.3 or later.

WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOM.mm: (-[DOMImplementation _initWithDOMImplementation:WebCore::]): (+[DOMImplementation _DOMImplementationWith:WebCore::]): (-[DOMImplementation WebCore::]):
bindings/objc/DOMImplementationFront.cpp: Removed.
bindings/objc/DOMImplementationFront.h: Removed.
bindings/objc/DOMInternal.h:
bindings/scripts/CodeGeneratorObjC.pm: remove DOMImplementationFront and some cleanup to under variables in WriteData

4:55 PM Changeset in webkit [16239] by darin

2 edits in trunk/WebKitTools

Scripts/do-webcore-rename: More renaming plans.

4:38 PM Changeset in webkit [16238] by adele

4 edits in trunk/WebCore

Reviewed by Adam.

Removed dead code for password field.

platform/mac/TextFieldMac.mm: (-[NSSearchFieldCell _addStringToRecentSearches:]):
platform/mac/WebCoreTextField.h:
platform/mac/WebCoreTextField.mm:

3:35 PM Changeset in webkit [16237] by justing

273 edits in trunk

LayoutTests:

Reviewed by thatcher

Setup for <rdar://problem/4344550> Misspellings aren't marked after undo delete

Fixed:

editing/pasteboard/4641033-expected.checksum:
editing/pasteboard/4641033-expected.png:
editing/execCommand/outdent-selection-expected.checksum:
editing/execCommand/outdent-selection-expected.png:

Added a didChangeSelection notification that was absent before:

editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
editing/deleting/delete-3608430-fix-expected.txt:
editing/deleting/delete-3608462-fix-expected.txt:
editing/deleting/delete-3775172-fix-expected.txt:
editing/deleting/delete-3800834-fix-expected.txt:
editing/deleting/delete-3857753-fix-expected.txt:
editing/deleting/delete-3865854-fix-expected.txt:
editing/deleting/delete-3928305-fix-expected.txt:
editing/deleting/delete-3959464-fix-expected.txt:
editing/deleting/delete-4038408-fix-expected.txt:
editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
editing/deleting/delete-block-contents-001-expected.txt:
editing/deleting/delete-block-contents-002-expected.txt:
editing/deleting/delete-block-contents-003-expected.txt:
editing/deleting/delete-block-merge-contents-001-expected.txt:
editing/deleting/delete-block-merge-contents-002-expected.txt:
editing/deleting/delete-block-merge-contents-003-expected.txt:
editing/deleting/delete-block-merge-contents-004-expected.txt:
editing/deleting/delete-block-merge-contents-005-expected.txt:
editing/deleting/delete-block-merge-contents-006-expected.txt:
editing/deleting/delete-block-merge-contents-007-expected.txt:
editing/deleting/delete-block-merge-contents-008-expected.txt:
editing/deleting/delete-block-merge-contents-009-expected.txt:
editing/deleting/delete-block-merge-contents-010-expected.txt:
editing/deleting/delete-block-merge-contents-012-expected.txt:
editing/deleting/delete-block-merge-contents-013-expected.txt:
editing/deleting/delete-block-merge-contents-014-expected.txt:
editing/deleting/delete-block-merge-contents-015-expected.txt:
editing/deleting/delete-block-merge-contents-016-expected.txt:
editing/deleting/delete-block-merge-contents-017-expected.txt:
editing/deleting/delete-block-merge-contents-018-expected.txt:
editing/deleting/delete-block-merge-contents-019-expected.txt:
editing/deleting/delete-block-merge-contents-020-expected.txt:
editing/deleting/delete-block-merge-contents-021-expected.txt:
editing/deleting/delete-block-merge-contents-022-expected.txt:
editing/deleting/delete-block-merge-contents-023-expected.txt:
editing/deleting/delete-block-merge-contents-024-expected.txt:
editing/deleting/delete-block-table-expected.txt:
editing/deleting/delete-br-008-expected.txt:
editing/deleting/delete-br-010-expected.txt:
editing/deleting/delete-br-011-expected.txt:
editing/deleting/delete-first-list-item-expected.txt:
editing/deleting/delete-image-001-expected.txt:
editing/deleting/delete-image-002-expected.txt:
editing/deleting/delete-image-003-expected.txt:
editing/deleting/delete-image-004-expected.txt:
editing/deleting/delete-line-001-expected.txt:
editing/deleting/delete-line-002-expected.txt:
editing/deleting/delete-line-003-expected.txt:
editing/deleting/delete-line-004-expected.txt:
editing/deleting/delete-line-005-expected.txt:
editing/deleting/delete-line-006-expected.txt:
editing/deleting/delete-line-007-expected.txt:
editing/deleting/delete-line-008-expected.txt:
editing/deleting/delete-line-009-expected.txt:
editing/deleting/delete-line-010-expected.txt:
editing/deleting/delete-line-011-expected.txt:
editing/deleting/delete-line-012-expected.txt:
editing/deleting/delete-line-013-expected.txt:
editing/deleting/delete-line-014-expected.txt:
editing/deleting/delete-line-015-expected.txt:
editing/deleting/delete-line-016-expected.txt:
editing/deleting/delete-line-017-expected.txt:
editing/deleting/delete-listitem-001-expected.txt:
editing/deleting/delete-listitem-002-expected.txt:
editing/deleting/delete-mixed-editable-content-001-expected.txt:
editing/deleting/delete-select-all-001-expected.txt:
editing/deleting/delete-select-all-002-expected.txt:
editing/deleting/delete-select-all-003-expected.txt:
editing/deleting/merge-different-styles-expected.txt:
editing/deleting/merge-endOfParagraph-expected.txt:
editing/deleting/merge-no-br-expected.txt:
editing/deleting/pruning-after-merge-1-expected.txt:
editing/deleting/pruning-after-merge-2-expected.txt:
editing/deleting/table-cells-expected.txt:
editing/execCommand/boldSelection-expected.txt:
editing/execCommand/create-list-from-range-selection-expected.txt:
editing/execCommand/createLink-expected.txt:
editing/execCommand/format-block-expected.txt:
editing/execCommand/format-block-from-range-selection-expected.txt:
editing/execCommand/format-block-with-braces-expected.txt:
editing/execCommand/format-block-with-trailing-br-expected.txt:
editing/execCommand/hilitecolor-expected.txt:
editing/execCommand/indent-list-item-expected.txt:
editing/execCommand/indent-selection-expected.txt:
editing/execCommand/insert-list-and-stitch-expected.txt:
editing/execCommand/insert-list-with-id-expected.txt:
editing/execCommand/insertHTML-expected.txt:
editing/execCommand/insertHorizontalRule-expected.txt:
editing/execCommand/remove-formatting-expected.txt:
editing/execCommand/remove-list-from-range-selection-expected.txt:
editing/execCommand/remove-list-items-expected.txt:
editing/execCommand/strikethroughSelection-expected.txt:
editing/execCommand/switch-list-type-expected.txt:
editing/execCommand/unlink-expected.txt:
editing/input/text-input-controller-expected.txt:
editing/inserting/insert-3654864-fix-expected.txt:
editing/inserting/insert-3659587-fix-expected.txt:
editing/inserting/insert-3775316-fix-expected.txt:
editing/inserting/insert-3851164-fix-expected.txt:
editing/inserting/insert-3907422-fix-expected.txt:
editing/inserting/insert-after-delete-001-expected.txt:
editing/inserting/insert-div-001-expected.txt:
editing/inserting/insert-div-002-expected.txt:
editing/inserting/insert-div-003-expected.txt:
editing/inserting/insert-div-005-expected.txt:
editing/inserting/insert-div-007-expected.txt:
editing/inserting/insert-div-009-expected.txt:
editing/inserting/insert-div-010-expected.txt:
editing/inserting/insert-div-020-expected.txt:
editing/inserting/insert-div-023-expected.txt:
editing/inserting/insert-div-024-expected.txt:
editing/inserting/insert-div-025-expected.txt:
editing/inserting/insert-div-026-expected.txt:
editing/inserting/multiple-lines-selected-expected.txt:
editing/inserting/paragraph-separator-03-expected.txt:
editing/inserting/paragraph-separator-in-table-2-expected.txt:
editing/inserting/redo-expected.txt:
editing/inserting/return-key-with-selection-001-expected.txt:
editing/inserting/return-key-with-selection-002-expected.txt:
editing/inserting/return-key-with-selection-003-expected.txt:
editing/pasteboard/3976872-expected.txt:
editing/pasteboard/4076267-3-expected.txt:
editing/pasteboard/4076267-expected.txt:
editing/pasteboard/4700297-expected.txt:
editing/pasteboard/8145-3-expected.txt:
editing/pasteboard/block-wrappers-necessary-expected.txt:
editing/pasteboard/copy-paste-bidi-expected.txt:
editing/pasteboard/displaced-generic-placeholder-expected.txt:
editing/pasteboard/displaced-placeholder-expected.txt:
editing/pasteboard/display-block-on-spans-expected.txt:
editing/pasteboard/drag-drop-modifies-page-expected.txt:
editing/pasteboard/interchange-newline-2-expected.txt:
editing/pasteboard/merge-after-delete-1-expected.txt:
editing/pasteboard/merge-after-delete-2-expected.txt:
editing/pasteboard/merge-after-delete-expected.txt:
editing/pasteboard/merge-end-3-expected.txt:
editing/pasteboard/merge-end-5-expected.txt:
editing/pasteboard/merge-end-blockquote-expected.txt:
editing/pasteboard/merge-end-list-expected.txt:
editing/pasteboard/merge-end-table-expected.txt:
editing/pasteboard/paste-4035648-fix-expected.txt:
editing/pasteboard/paste-4039777-fix-expected.txt:
editing/pasteboard/paste-line-endings-001-expected.txt:
editing/pasteboard/paste-line-endings-006-expected.txt:
editing/pasteboard/paste-match-style-001-expected.txt:
editing/pasteboard/paste-match-style-002-expected.txt:
editing/pasteboard/paste-pre-001-expected.txt:
editing/pasteboard/paste-pre-002-expected.txt:
editing/pasteboard/paste-table-002-expected.txt:
editing/pasteboard/paste-table-003-expected.txt:
editing/pasteboard/paste-text-006-expected.txt:
editing/pasteboard/paste-text-007-expected.txt:
editing/pasteboard/paste-text-010-expected.txt:
editing/pasteboard/paste-text-011-expected.txt:
editing/pasteboard/paste-text-015-expected.txt:
editing/pasteboard/paste-text-016-expected.txt:
editing/pasteboard/paste-text-017-expected.txt:
editing/pasteboard/paste-text-018-expected.txt:
editing/pasteboard/prevent-block-nesting-01-expected.txt:
editing/pasteboard/smart-paste-003-expected.txt:
editing/pasteboard/smart-paste-004-expected.txt:
editing/pasteboard/smart-paste-005-expected.txt:
editing/pasteboard/smart-paste-006-expected.txt:
editing/pasteboard/smart-paste-007-expected.txt:
editing/pasteboard/smart-paste-008-expected.txt:
editing/pasteboard/testcase-9507-expected.txt:
editing/pasteboard/undoable-fragment-removes-expected.txt:
editing/selection/expanding-selections-expected.txt:
editing/selection/expanding-selections2-expected.txt:
editing/selection/node-removal-1-expected.txt:
editing/selection/node-removal-2-expected.txt:
editing/selection/select-all-iframe-expected.txt:
editing/selection/skip-non-editable-1-expected.txt:
editing/selection/triple-click-in-pre-expected.txt:
editing/style/apple-style-editable-mix-expected.txt:
editing/style/block-style-004-expected.txt:
editing/style/block-style-005-expected.txt:
editing/style/block-style-006-expected.txt:
editing/style/create-block-for-style-001-expected.txt:
editing/style/create-block-for-style-002-expected.txt:
editing/style/create-block-for-style-003-expected.txt:
editing/style/create-block-for-style-004-expected.txt:
editing/style/create-block-for-style-007-expected.txt:
editing/style/create-block-for-style-009-expected.txt:
editing/style/create-block-for-style-010-expected.txt:
editing/style/create-block-for-style-011-expected.txt:
editing/style/create-block-for-style-012-expected.txt:
editing/style/create-block-for-style-013-expected.txt:
editing/style/designmode-expected.txt:
editing/style/relative-font-size-change-001-expected.txt:
editing/style/relative-font-size-change-002-expected.txt:
editing/style/remove-underline-across-paragraph-expected.txt:
editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
editing/style/remove-underline-after-paragraph-expected.txt:
editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
editing/style/remove-underline-from-stylesheet-expected.txt:
editing/style/smoosh-styles-001-expected.txt:
editing/style/smoosh-styles-002-expected.txt:
editing/style/smoosh-styles-003-expected.txt:
editing/style/style-3681552-fix-001-expected.txt:
editing/style/style-3681552-fix-002-expected.txt:
editing/style/style-3690704-fix-expected.txt:
editing/style/style-3998892-fix-expected.txt:
editing/style/style-boundary-001-expected.txt:
editing/style/style-boundary-003-expected.txt:
editing/style/style-boundary-004-expected.txt:
editing/style/typing-style-001-expected.txt:
editing/style/typing-style-003-expected.txt:
editing/undo/undo-misspellings-expected.txt:
editing/unsupported-content/list-delete-001-expected.txt:
editing/unsupported-content/list-delete-002-expected.txt:
editing/unsupported-content/list-delete-003-expected.txt:
editing/unsupported-content/table-delete-001-expected.txt:
editing/unsupported-content/table-delete-002-expected.txt:
editing/unsupported-content/table-delete-003-expected.txt:
fast/forms/attributed-strings-expected.txt:
fast/forms/cursor-position-expected.txt:
fast/forms/drag-into-textarea-expected.txt:
fast/forms/input-appearance-maxlength-expected.txt:
fast/forms/input-paste-undo-expected.txt:
fast/forms/input-selection-restore-expected.txt:
fast/forms/input-text-paste-maxlength-expected.txt:
fast/forms/selection-functions-expected.txt:
fast/forms/text-field-setvalue-crash-expected.txt:
fast/forms/textarea-paste-newline-expected.txt:

WebCore:

Reviewed by thatcher

Setup for <rdar://problem/4344550> Misspellings aren't marked after undo delete

Fixes:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=6498>
SelectionController's setters should notify delegates of selection changes

Moved setSelection from Frame to SelectionController.
I haven't moved any of the work that's done as a result of a
Selection change to SelectionController yet.
Make fewer uses of SelectionControllers. They're now only used for
the Frame's selection, the Page's drag caret, and functions that
need to do Selection expansion.

bindings/js/kjs_window.cpp: (KJS::Selection::getValueProperty): (KJS::Selection::toString): (KJS::SelectionFunc::callAsFunction):
bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): (WebCore::FrameMac::dispatchCPPEvent): (WebCore::FrameMac::fontForSelection): (WebCore::FrameMac::baseWritingDirectionForSelectionStart): (WebCore::FrameMac::markMisspellingsInAdjacentWords): (WebCore::FrameMac::markMisspellings): (WebCore::FrameMac::respondToChangedSelection): (WebCore::FrameMac::shouldChangeSelection): (WebCore::FrameMac::shouldDeleteSelection): (WebCore::FrameMac::respondToChangedContents):
bridge/mac/PageMac.mm: (WebCore::Page::Page):
bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeValue:]): (-[WebCoreAXObject doAXTextMarkerRangeForLine:]): (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]): (-[WebCoreAXObject doAXTextMarkerRangeForUnorderedTextMarkers:]): (-[WebCoreAXObject doSetAXSelectedTextMarkerRange:]):
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge isSelectionEditable]): (-[WebCoreFrameBridge isSelectionRichlyEditable]): (-[WebCoreFrameBridge selectionState]): (-[WebCoreFrameBridge deselectText]): (-[WebCoreFrameBridge selectedAttributedString]): (-[WebCoreFrameBridge rangeByExpandingSelectionWithGranularity:]): (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:direction:granularity:]): (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]): (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:verticalDistance:]): (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]): (-[WebCoreFrameBridge setSelectedDOMRange:affinity:closeTyping:]): (-[WebCoreFrameBridge selectedDOMRange]): (-[WebCoreFrameBridge selectNSRange:]): (-[WebCoreFrameBridge selectedNSRange]): (-[WebCoreFrameBridge selectionAffinity]): (-[WebCoreFrameBridge replaceSelectionWithText:selectReplacement:smartReplace:]): (-[WebCoreFrameBridge setSelectionToDragCaret]): (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]): (-[WebCoreFrameBridge moveDragCaretToPoint:]): (-[WebCoreFrameBridge removeDragCaret]): (-[WebCoreFrameBridge dragCaretDOMRange]): (-[WebCoreFrameBridge isDragCaretRichlyEditable]): (-[WebCoreFrameBridge editableDOMRangeForPoint:]): (-[WebCoreFrameBridge ensureSelectionVisible]): (-[WebCoreFrameBridge rangeOfCharactersAroundCaret]):
bridge/win/PageWin.cpp: (WebCore::Page::Page):
dom/Document.cpp: (WebCore::Document::updateSelection): (WebCore::Document::clearSelectionIfNeeded): (WebCore::Document::notifyBeforeNodeRemoval):
dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
editing/EditCommand.cpp: (WebCore::EditCommand::EditCommand):
editing/JSEditor.cpp:
editing/ModifySelectionListLevel.cpp: (WebCore::IncreaseSelectionListLevelCommand::canIncreaseSelectionListLevel): (WebCore::DecreaseSelectionListLevelCommand::canDecreaseSelectionListLevel):
editing/Selection.cpp: (WebCore::Selection::setBase): (WebCore::Selection::setExtent):
editing/Selection.h: (WebCore::Selection::extent):
editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController): (WebCore::SelectionController::moveTo): (WebCore::SelectionController::setSelection): (WebCore::SelectionController::nodeWillBeRemoved): (WebCore::SelectionController::modify): (WebCore::SelectionController::clear): (WebCore::SelectionController::setBase): (WebCore::SelectionController::setExtent):
editing/SelectionController.h:
editing/TypingCommand.cpp: (WebCore::TypingCommand::insertText): (WebCore::TypingCommand::deleteKeyPressed): (WebCore::TypingCommand::forwardDeleteKeyPressed):
editing/VisiblePosition.cpp: (WebCore::VisiblePosition::caretRect):
editing/VisiblePosition.h:
html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
page/Frame.cpp: (WebCore::Frame::selectedText): (WebCore::Frame::hasSelection): (WebCore::Frame::selectionController): (WebCore::Frame::dragCaretController): (WebCore::Frame::notifyRendererOfSelectionChange): (WebCore::Frame::invalidateSelection): (WebCore::Frame::clearCaretRectIfNeeded): (WebCore::Frame::setFocusNodeIfNeeded): (WebCore::Frame::selectionLayoutChanged): (WebCore::Frame::caretBlinkTimerFired): (WebCore::Frame::paintCaret): (WebCore::Frame::paintDragCaret): (WebCore::Frame::isPointInsideSelection): (WebCore::Frame::selectClosestWordFromMouseEvent): (WebCore::Frame::handleMousePressEventDoubleClick): (WebCore::Frame::handleMousePressEventTripleClick): (WebCore::Frame::handleMousePressEventSingleClick): (WebCore::Frame::handleMouseMoveEvent): (WebCore::Frame::handleMouseReleaseEvent): (WebCore::Frame::selectAll): (WebCore::Frame::selectContentsOfNode): (WebCore::Frame::shouldChangeSelection): (WebCore::Frame::shouldDeleteSelection): (WebCore::Frame::isSelectionInPasswordField): (WebCore::Frame::appliedEditing): (WebCore::Frame::unappliedEditing): (WebCore::Frame::reappliedEditing): (WebCore::Frame::computeAndSetTypingStyle): (WebCore::Frame::applyStyle): (WebCore::Frame::applyParagraphStyle): (WebCore::Frame::selectionListState): (WebCore::Frame::selectionHasStyle): (WebCore::Frame::selectionComputedStyle): (WebCore::Frame::selectFrameElementInParentIfFullySelected): (WebCore::Frame::currentForm): (WebCore::Frame::revealSelection): (WebCore::Frame::centerSelectionInVisibleArea): (WebCore::Frame::styleForSelectionStart): (WebCore::Frame::setSelectionFromNone): (WebCore::Frame::findString):
page/Frame.h:
page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate):
page/FrameView.cpp: (WebCore::FrameView::clear):
page/Page.cpp: (WebCore::Page::dragCaretController):
page/Page.h:
rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret):
rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll):
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::selectionStart): (WebCore::RenderTextControl::selectionEnd): (WebCore::RenderTextControl::setSelectionRange): (WebCore::RenderTextControl::selectionChanged):
rendering/RenderTreeAsText.cpp: (WebCore::writeSelection):

2:48 PM Changeset in webkit [16236] by spadma

8 edits in S60/trunk/WebKit

2006-09-05 winship <Stephen.Winship@nokia.com>

Reviewed by Sachin.
DESC: Auto Form Fill usability changes
http://bugzilla.opendarwin.org/show_bug.cgi?id=10642

BrowserCore/Formcontrols/inc/FControlInputSkin.h:
BrowserCore/Formcontrols/inc/FControlSelectListBox.h: (CControlSelectListBox::IsFocused):
BrowserCore/Formcontrols/inc/FControlSelectWidget.h:
BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::SetSize): (CFormInputSkin::TextChanged): (CFormInputSkin::OkToExit): (CFormInputSkin::ListBoxKeyEventL): (CFormInputSkin::ActivateL): (CFormInputSkin::DestroyList): (CFormInputSkin::UpdatePopupL):
BrowserCore/Formcontrols/src/FControlSelectListBox.cpp: (CControlSelectListBox::ConstructL): (CControlSelectListBox::UpdateContentL): (CControlSelectListBox::SetFocus):
BrowserCore/Formcontrols/src/FControlSelectWidget.cpp: (CControlSelectWidget::CControlSelectWidget): (CControlSelectWidget::ConstructL): (CControlSelectWidget::ConstructListBoxL): (CControlSelectWidget::NewL): (CControlSelectWidget::~CControlSelectWidget): (CControlSelectWidget::PositionListBox): (CControlSelectWidget::SetList): (CControlSelectWidget::FilterContentL): (CControlSelectWidget::OfferKeyEventL): (CControlSelectWidget::CountComponentControls): (CControlSelectWidget::SizeChanged): (CControlSelectWidget::HandleListBoxEventL): (CControlSelectWidget::SimulateDoneKeyL):
ChangeLog:
group/BrowserCore.mmp:

2:14 PM Changeset in webkit [22141] by sfalken

10 edits
2 adds in branches/WindowsMerge/WebKitWin

2006-09-05 Steve Falkenburg <sfalken@apple.com>

Reviewed by Lou Amadio.

Currently we are saving a copy of the raw data in the FrameView (to
return when requested via IWebDataSource::data). This needs to be
shared with CFNetwork once CFNetwork integration is complete.

Also fixed a problem with autofill where we'd crash on pages with
non-autofillable form elements.

2:10 PM Changeset in webkit [16235] by thatcher

2 edits in trunk/WebKit

Reviewed by Tim O.

<rdar://problem/4682225> conflicting typedefs in Netscape plug-in headers

Plugins/npfunctions.h: fix the return type for NPN_IntFromIdentifierProcPtr to be int32_t

1:18 PM Changeset in webkit [16234] by brmorris

2 edits in S60/trunk

2006-09-05 brmorris <bradley.morrison@nokia.com>

Reviewed by me.
DESC: Include test index number in test results
http://bugzilla.opendarwin.org/show_bug.cgi?id=10678

runATF.bat:

1:13 PM Changeset in webkit [16233] by thatcher

3 edits in trunk/JavaScriptCore

Reviewed by Tim O.

<rdar://problem/4715840> SEL is not char*

bindings/objc/objc_class.mm: (KJS::Bindings::ObjcClass::methodsNamed): use sel_getName instead of a char* cast.
bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::callAsFunction): ditto

12:04 PM Changeset in webkit [16232] by adele

2 edits in trunk/WebCore

Reviewed by Adam.

Let the engine draw the focus ring for styled menu lists.

rendering/RenderTheme.cpp: (WebCore::RenderTheme::supportsFocusRing): Added case for MenulistButtonAppearance.

10:54 AM Changeset in webkit [16231] by adele

3 edits in trunk/WebCore

Reviewed by Adam.

Fix for <rdar://problem/4706463> REGRESSION: Must click twice on <select> elements for menu to show

rendering/RenderPopupMenuMac.h:
rendering/RenderPopupMenuMac.mm: (WebCore::RenderPopupMenuMac::showPopup): Moved call to dismiss popup into hidePopup method. Now calls RenderMenuList::hidePopup which will update the m_popupIsVisible flag on the menu list before hiding the popup. (WebCore::RenderPopupMenuMac::hidePopup): Added.

10:26 AM Changeset in webkit [16230] by thatcher

5 edits in trunk/WebCore/bindings

Build fix for when XPATH_SUPPORT is not defined.

9:57 AM Changeset in webkit [16229] by weinig

24 edits
5 deletes in trunk/WebCore

Reviewed by Tim H.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10738
Consolidate the Objective-C DOM Bindings Internal files into DOMInternal.h

Consolidate DOMHTMLInternal.h, DOMCSSInternal.h, DOMEventsInternal.h, DOMViewsInternal.h and DOMXPathInternal.h into DOMInternal.h.

Rename the "type-makers" (used to make a binding from an implementation type) so that all the HTML ones begin with the prefix HTML. Did the same for the CSS.

Auto-generate a couple more methods from DOMExtensions.h.

Various cleanups of the Objective-C auto-generation code.

WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOM.mm: (-[DOMDocument createCSSStyleDeclaration]):
bindings/objc/DOMCSS.mm: (+[DOMCSSRuleList _CSSRuleListWith:]): (+[DOMCSSRule _CSSRuleWith:]): (+[DOMCSSStyleDeclaration _CSSStyleDeclarationWith:]): (+[DOMCSSValue _CSSValueWith:]): (+[DOMCSSPrimitiveValue _CSSPrimitiveValueWith:]): (-[DOMDocument getComputedStyle::]): (-[DOMDocument getMatchedCSSRules::]):
bindings/objc/DOMCSSInternal.h: Removed.
bindings/objc/DOMEvents.mm:
bindings/objc/DOMEventsInternal.h: Removed.
bindings/objc/DOMEventsNonstandard.mm:
bindings/objc/DOMExtensions.h:
bindings/objc/DOMHTML.mm: (+[DOMHTMLCollection _HTMLCollectionWith:]): (+[DOMHTMLOptionsCollection _HTMLOptionsCollectionWith:]): (+[DOMHTMLElement _HTMLElementWith:]): (+[DOMHTMLFormElement _HTMLFormElementWith:]): (+[DOMHTMLTableCaptionElement _HTMLTableCaptionElementWith:]): (+[DOMHTMLTableSectionElement _HTMLTableSectionElementWith:]): (+[DOMHTMLTableElement _HTMLTableElementWith:]): (+[DOMHTMLTableCellElement _HTMLTableCellElementWith:]):
bindings/objc/DOMHTMLAppletElement.mm:
bindings/objc/DOMHTMLDocument.mm: (-[DOMHTMLDocument body]): (-[DOMHTMLDocument images]): (-[DOMHTMLDocument applets]): (-[DOMHTMLDocument links]): (-[DOMHTMLDocument forms]): (-[DOMHTMLDocument anchors]):
bindings/objc/DOMHTMLInternal.h: Removed.
bindings/objc/DOMHTMLOptionElement.mm: (-[DOMHTMLOptionElement form]):
bindings/objc/DOMInternal.h:
bindings/objc/DOMRGBColor.mm: (setWrapperForRGB): (-[DOMRGBColor red]): (-[DOMRGBColor green]): (-[DOMRGBColor blue]): (-[DOMRGBColor alpha]):
bindings/objc/DOMUtility.mm: (KJS::ScriptInterpreter::createObjcInstanceForValue):
bindings/objc/DOMViews.mm: (-[DOMAbstractView WebCore::]): (-[DOMAbstractView _initWithAbstractView:WebCore::]): (+[DOMAbstractView _abstractViewWith:WebCore::]):
bindings/objc/DOMViewsInternal.h: Removed.
bindings/objc/DOMXPath.mm:
bindings/objc/DOMXPathInternal.h: Removed.
bindings/objc/PublicDOMInterfaces.h:
bindings/scripts/CodeGeneratorObjC.pm:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge typingStyle]):
html/HTMLAnchorElement.idl:
html/HTMLAreaElement.idl:
html/HTMLImageElement.idl:
html/HTMLInputElement.idl:
html/HTMLLinkElement.idl:

9:24 AM Changeset in webkit [16228] by thatcher

1 edit in trunk/WebCore/DerivedSources.make

Build fix. Remove the now duplicate OS check and add PublicDOMInterfaces.h to the dependancy list for ObjC DOM files.

12:29 AM Changeset in webkit [22140] by sfalken

1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

Fix build

12:27 AM Changeset in webkit [16227] by sfalken

2 edits in trunk/WebCore

2006-09-05 Steve Falkenburg <sfalken@apple.com>

Conditionalize new DOM headers for ObjC only

DerivedSources.make:

Sep 4, 2006:

10:05 PM Changeset in webkit [16226] by ap

9 edits in trunk

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10716
XMLHttpRequest.responseText is null if HTTP response is empty

Extended existing tests:

http/tests/xmlhttrequest/zero-length-response.html
http/tests/xmlhttrequest/zero-length-response-sync.html

xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): Initialize responseText to an empty string. (WebCore::XMLHttpRequest::open): Reset responseText to an empty string.
bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::getValueProperty): Return null rather than undefined for nil responseXML.

7:45 PM Changeset in webkit [16225] by thatcher

27 edits
1 add in trunk

WebCore:

Reviewed by Darin.

Bug 10714: ObjC autogeneration needs safe-guards against easily modifying the public API
http://bugzilla.opendarwin.org/show_bug.cgi?id=10714

New PublicDOMInterfaces.h file is consulted when generating the ObjC DOM files. All public DOM class interfaces, properties and methods need to be in this file. Anything not in the file will be generated into the appropriate private header file. During generation if something changed or is missing in the public API a build error will occur. New interfaces added to the IDLs files will now not automatically be reflected in the public ObjC API. Methods commented out in PublicDOMInterfaces.h are pending public and will be uncommented once approved.

Removed most of the Exclude=ObjC uses from the IDL files. This attribute was mostly used to prevent changes to the public headers.

Make a new parameter name if the original conflicts with a property name.

Simplified the generation code for dealing with exceptions.

Moved file opens to WriteData. Files are unlinked before being opened to work around a Leopard file truncation bug.

Fixed #imports for DOMImplementation to be DOMDOMImplementation.h

WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOMCSS.h:
bindings/objc/DOMCore.h:
bindings/objc/DOMExtensions.h:
bindings/objc/DOMHTMLInternal.h:
bindings/objc/DOMPrivate.h:
bindings/objc/PublicDOMInterfaces.h: Added.
bindings/scripts/CodeGeneratorObjC.pm:
dom/Document.idl:
dom/Element.idl:
dom/NamedNodeMap.idl:
dom/ProcessingInstruction.idl:
html/HTMLAnchorElement.idl:
html/HTMLAreaElement.idl:
html/HTMLBodyElement.idl:
html/HTMLButtonElement.idl:
html/HTMLImageElement.idl:
html/HTMLInputElement.idl:
html/HTMLLabelElement.idl:
html/HTMLLegendElement.idl:
html/HTMLLinkElement.idl:
html/HTMLOptionsCollection.idl:
html/HTMLPreElement.idl:
html/HTMLStyleElement.idl:
html/HTMLTextAreaElement.idl:

WebKit:

Reviewed by Darin.

Bug 10714: ObjC autogeneration needs safe-guards against easily modifying the public API
http://bugzilla.opendarwin.org/show_bug.cgi?id=10714

Added the new private DOM headers.
Factored out the common commands into variables.
Made WebDashboardRegion.h private again.
Rename DOMDOMImplementation.h to DOMImplementation.h when files are migrated. Also fixes up #imports.

MigrateHeaders.make:

4:36 PM Changeset in webkit [16224] by darin

2 edits in trunk/WebKitTools

Scripts/do-webcore-rename: More renaming plans.

4:16 PM Changeset in webkit [16223] by thatcher

1 edit in trunk/WebKit/WebInspector/WebInspector.m

Another build fix now that the old style ObjC methods are deprecated.

4:10 PM Changeset in webkit [16222] by thatcher

7 edits in trunk

Build fixes now that the old style ObjC methods are deprecated.

3:57 PM Changeset in webkit [16221] by weinig

2 edits in trunk/WebCore

Reviewed by Tim H.

Continue fixing the build, I forgot this in my previous patch!

platform/qt/PathQt.cpp: (WebCore::Path::apply):

3:43 PM Changeset in webkit [16220] by weinig

3 edits in trunk/WebCore

Reviewed by Tim H.

Fix build on Qt/Linux.

CMakeLists.txt:
platform/qt/PathQt.cpp: (WebCore::Path::transform):

3:28 PM Changeset in webkit [16219] by weinig

3 edits
3 adds
1 delete in trunk

WebKitQt:

Reviewed by Tim H.

Fixes last part of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10644
Move QtLauncher down to WebKitQt.

QtLauncher/CMakeLists.txt: Added.
QtLauncher/main.cpp: Added. (main):

WebKitTools:

Reviewed by Tim H.

Fixes last part of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10644
Move QtLauncher down to WebKitQt.

QtLauncher/CMakeLists.txt: Removed.
QtLauncher/main.cpp: Removed.

12:49 PM Changeset in webkit [16218] by ap

1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

The project file didn't get committed with my last checking.

11:34 AM Changeset in webkit [16217] by ap

12 edits
3 adds in trunk

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10676
@charset rules not accessible via DOM

Test: fast/encoding/css-charset-dom.html

WebCore.xcodeproj/project.pbxproj: Added CSSCharsetRule.cpp
bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleSheet::getValueProperty): Separated Rules and CssRules, since now they behave differently.

css/CSSCharsetRule.h: Make the constructor take an encoding.
css/CSSCharsetRule.cpp: Added.

css/CSSGrammar.y: Create CSSStylesheetRules as necessary.

css/CSSRuleList.cpp: (WebCore::CSSRuleList::CSSRuleList):
css/CSSRuleList.h:
css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::cssRules):
css/CSSStyleSheet.h: Skip charset rules in IE compatibility mode.

css/StyleBase.h: (WebCore::StyleBase::isCharsetRule): Fixed a typo.

css/cssparser.cpp: (WebCore::CSSParser::createCharsetRule):
css/cssparser.h: Added createCharsetRule().

10:37 AM Changeset in webkit [16216] by weinig

4 edits
2 adds in trunk/WebCore

Reviewed by Darin.

Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10644
Let FrameQt operate on a FrameQtClient, just like Win/Mac handle it.

CMakeLists.txt:
platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::~FrameQt): (WebCore::FrameQt::openURL): (WebCore::FrameQt::submitForm): (WebCore::FrameQt::urlSelected):
platform/qt/FrameQt.h:
platform/qt/FrameQtClient.cpp: Added. (WebCore::FrameQtClientDefault::FrameQtClientDefault): (WebCore::FrameQtClientDefault::~FrameQtClientDefault): (WebCore::FrameQtClientDefault::setFrame): (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::submitForm): (WebCore::FrameQtClientDefault::receivedResponse): (WebCore::FrameQtClientDefault::receivedData): (WebCore::FrameQtClientDefault::receivedAllData):
platform/qt/FrameQtClient.h: Added. (WebCore::FrameQtClient::~FrameQtClient):

10:34 AM Changeset in webkit [16215] by weinig

4 edits
2 adds in trunk/WebKitTools

Reviewed by Darin.

Fixes parts of: http://bugzilla.opendarwin.org/show_bug.cgi?id=10644
Adjust DumpRenderTree to the FrameQtClient changes.

DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt:
DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree): (WebCore::DumpRenderTree::~DumpRenderTree): (WebCore::DumpRenderTree::frame):
DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.h:
DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTreeClient.cpp: Added. (WebCore::DumpRenderTreeClient::DumpRenderTreeClient): (WebCore::DumpRenderTreeClient::~DumpRenderTreeClient):
DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTreeClient.h: Added.

10:11 AM Changeset in webkit [16214] by weinig

1 edit
16 adds in trunk

2:31 AM Changeset in webkit [16213] by eseidel

2 edits in trunk/WebCore

2006-09-04 Eric Seidel <eric@eseidel.com>

Reviewed by andersca.

Clean-up style and spacing.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10724
No tests needed, no functional changes.

ksvg2/svg/svgpathparser.cpp: (WebCore::parseCoord): (WebCore::SVGPolyParser::parsePoints): (WebCore::SVGPathParser::parseSVG): (WebCore::SVGPathParser::calculateArc): (WebCore::SVGPathParser::svgLineToHorizontal): (WebCore::SVGPathParser::svgLineToVertical): (WebCore::SVGPathParser::svgCurveToCubicSmooth): (WebCore::SVGPathParser::svgCurveToQuadratic): (WebCore::SVGPathParser::svgCurveToQuadraticSmooth): (WebCore::SVGPathParser::svgArcTo):

2:22 AM Changeset in webkit [16212] by rwlbuis

3 edits
4 adds in trunk

Reviewed by Eric.

http://bugzilla.opendarwin.org/show_bug.cgi?id=6546
clipPath data does not respect transforms

Get the transform from the dom element and adjust
the clip path with it.

12:57 AM Changeset in webkit [16211] by rwlbuis

2 edits in trunk/WebCore

Reviewed by Eric.

This code should have gone in as part of:
http://bugzilla.opendarwin.org/show_bug.cgi?id=10696
It addresses the comments there, also we use double instead
of float now in calculations.

Sep 3, 2006:

7:11 PM Changeset in webkit [16210] by weinig

13 edits
2 adds in trunk

WebCore:

Reviewed by Darin and Tim H.

patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10711 Auto-generate the Objective-C DOM Stylesheet bindings

Auto-generates DOMMediaList, DOMStyleSheet, and DOMStyleSheetList.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOMCSS.mm: (+[DOMStyleSheet _styleSheetWith:]): (+[DOMCSSStyleSheet _CSSStyleSheetWith:]):
bindings/objc/DOMCSSInternal.h:
bindings/objc/DOMInternal.h:
bindings/objc/DOMObject.mm: (-[DOMObject sheet]):
bindings/objc/DOMPrivate.h:
bindings/objc/DOMStylesheets.h:
bindings/objc/DOMUtility.mm: (KJS::ScriptInterpreter::createObjcInstanceForValue):
bindings/scripts/CodeGeneratorObjC.pm:
css/StyleSheet.idl: Added.
css/StyleSheetList.idl: Added.

WebKit:

Reviewed by Darin and Tim H.

patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10711 Auto-generate the Objective-C DOM Stylesheet bindings

MigrateHeaders.make:

6:00 PM Changeset in webkit [16209] by weinig

1 add in trunk/WebCore/platform/Path.cpp

Build fix.

3:19 PM Changeset in webkit [16208] by darin

2 edits in trunk/WebKitTools

Scripts/do-webcore-rename: More renaming plans.

2:46 PM Changeset in webkit [16207] by thatcher

1 edit in trunk/WebCore/bindings/objc/DOMHTML.mm

Build fix to avoid warning about property name conflict.

2:31 PM Changeset in webkit [16206] by rwlbuis

38 edits in trunk/WebCore

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10696
RenderPathQuartz and RenderPathQt should not be needed

Cleanup of code related to RenderPath.

2:20 PM Changeset in webkit [16205] by thatcher

1 edit in trunk/WebCore/ChangeLog

Fix a typo Darin called out, but I forgot to change.

2:11 PM Changeset in webkit [16204] by thatcher

1 edit in trunk/WebCore/bindings/scripts/CodeGeneratorObjC.pm

Build fix.

1:48 PM Changeset in webkit [16203] by thatcher

5 edits in trunk

Changing the ignore rule for *.perspective to *.perspective*. This ignores the new .perspectivev3 file.

1:42 PM Changeset in webkit [16202] by thatcher

1 edit in trunk/WebCore/WebCore.xcodeproj

Changing the ignore rule for *.perspective to *.perspective*. This ignores the new .perspectivev3 file.

1:38 PM Changeset in webkit [16201] by thatcher

30 edits in trunk/WebCore

Reviewed by Darin.

Bug 10685: ObjC DOM should have no unnamed parameters
http://bugzilla.opendarwin.org/show_bug.cgi?id=10685

The ObjC code generation script now outputs parameter prefixes for methods that have more than 1 parameter. This prefix is simply the parameter name. Some parameter names have been changed in the IDL files to produce better prefixes. If an extended attribute of "ObjCPrefix" exists on a parameter we will use that for the prefix.

A backwards compatible version of the method is placed in a category with a deprecation marco for 10.5 and later. This step only happens if the IDL extended attribute "OldStyleObjC" is defined. All new functions in IDL should not get this attribute.

Made the $interfaceMethodSelector regex in IDLStructure.pm allow "=" so parameter extended attributes can have values.

Moved RemoveExcludedAttributesAndFunctions to CodeGenerator.pm so it can be shared between the two generators.

Removed the die when we encounter a getter that uses exceptions. Sam Weinig added support for this in an earlier change.

Check if $ENV{"MACOSX_DEPLOYMENT_TARGET"} is defined before we compare. This caused a perl warning when generating on other platforms.

The ObjC generation will not happen on platforms other than Mac OS. This is determined by the "OS" env variable Xcode sets. This check is in the DerivedSources.make.

Added a way to skip generation if the constructor of the specific generator returns undef. Not used yet.

Many cleanup tweaks in CodeGeneratorObjC.pm.

Removed IDL and CSS files from the project's resource copy phase, these do no need to be in WebCore's resources.

DerivedSources.make
WebCore.xcodeproj/project.pbxproj
bindings/scripts/CodeGenerator.pm
bindings/scripts/CodeGeneratorJS.pm
bindings/scripts/CodeGeneratorObjC.pm
bindings/scripts/IDLStructure.pm
css/CSSMediaRule.idl
css/CSSPrimitiveValue.idl
css/CSSStyleDeclaration.idl
css/CSSStyleSheet.idl
dom/CharacterData.idl
dom/DOMImplementation.idl
dom/Document.idl
dom/Element.idl
dom/KeyboardEvent.idl
dom/MouseEvent.idl
dom/MutationEvent.idl
dom/NamedNodeMap.idl
dom/UIEvent.idl
html/HTMLCanvasElement.idl
html/HTMLSelectElement.idl
ksvg2/bindings/idl/svg/SVGLengthList.idl
ksvg2/bindings/idl/svg/SVGNumberList.idl
ksvg2/bindings/idl/svg/SVGPointList.idl
ksvg2/bindings/idl/svg/SVGStringList.idl
ksvg2/bindings/idl/svg/SVGTextContentElement.idl
ksvg2/bindings/idl/svg/SVGTransformList.idl
ksvg2/svg/SVGSVGElement.idl
page/DOMWindow.idl

12:08 PM Changeset in webkit [16200] by ap

11 edits in trunk

Reviewed by Tim H.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10693
Convert JavaScript arrays to AppleScript lists

JavaScriptCore:

JavaScriptCore.exp: Export ArrayInstance::info and ArrayInstance::getItem().
kjs/array_instance.h:
kjs/array_object.cpp: (ArrayInstance::getItem): Added a method to access array items from C++.

WebCore:

bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): Added a case for ArrayInstance.

LayoutTests:

fast/AppleScript/array-expected.txt:
fast/AppleScript/array.html: Updated results, added a test for circular dependencies.

WebKitTools:

DumpRenderTree/AppleScriptController.m: (convertAEDescToObject): (-[AppleScriptController doJavaScript:]): Support printing AEDescLists.

10:28 AM Changeset in webkit [16199] by ap

1 edit in trunk/LayoutTests/http/tests/incremental/slow-utf8-html.pl

http/tests/incremental/slow-utf8-html-diffs.txt
Set executable bit that was lost when re-applying the patch.

9:59 AM Changeset in webkit [16198] by ap

3 edits
4 adds in trunk

Reviewed by Eric.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10697
REGRESSION (r16175): Errors in incremental decoding of UTF-8

Tests:

http/tests/incremental/slow-utf8-html.pl
fast/encoding/charset-invalid.html

loader/Decoder.cpp: (Decoder::Decoder): Ensure that we have a valid encoding. Get its name via TextEncoding, to match the logic in setEncodingName(). (Decoder::setEncodingName): Only set m_encodingName if the encoding is valid. Rely on TextEncoding constructor to lowercase it if necessary. (Decoder::decode): Use setEncodingName() to apply encoding from BOM. Don't try to ensure the validity of encoding - it is enforced by class constructor and setEncodingName().

6:45 AM Changeset in webkit [16197] by weinig

1 edit in trunk/WebCore/bindings/objc/DOMRGBColor.h

Fixes build for regression tests.

2:25 AM Changeset in webkit [16196] by ap

4 edits
2 moves
1 add
2 deletes in trunk/LayoutTests

Reviewed by Tim H.

http://bugzilla.opendarwin.org/show_bug.cgi?id=4508
Layout tests access an external server

fast/backgrounds/repeat/noRepeatCorrectClip.html: Use a local resource (it was already present, but the test still pointed to a remote one).
fast/dom/HTMLImageElement/image-src-absolute-url-expected.txt:
fast/dom/HTMLImageElement/image-src-absolute-url.html: Use a non-existent file URL instead of a non-existent http one.
fast/loader/docLoaderFrame-expected.checksum: Removed.
fast/loader/docLoaderFrame-expected.png: Removed.
fast/loader/docLoaderFrame-expected.txt: Removed.
fast/loader/docLoaderFrame.html: Removed.
http/tests/xmlhttprequest/docLoaderFrame-expected.txt: Added.
http/tests/xmlhttprequest/docLoaderFrame.html: Added.
http/tests/xmlhttprequest/resources/docLoaderFrame-data.html: Added. Use a local resource. Also, turned the test into a text one, and used waitUntilDone to make it actually work.

Sep 2, 2006:

7:10 PM Changeset in webkit [16195] by weinig

17 edits
11 adds in trunk

WebCore:

Reviewed by Tim H.

patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10684 Auto-generate the Objective-C DOM CSS bindings

Auto-generates DOMCSSCharsetRule, DOMCSSFontFaceRule, DOMCSSImportRule,
DOMCSSMediaRule, DOMCSSPageRule, DOMCSSPrimitiveValue, DOMCSSRule,
DOMCSSRuleList, DOMCSSStyleDeclaration, DOMCSSStyleRule, DOMCSSStyleSheet,
DOMCSSUnknownRule, DOMCSSValue, DOMCSSValueList, DOMCounter, and DOMRect.

Splits DOMRGBColor into its own files.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOMCSS.h:
bindings/objc/DOMCSS.mm: (+[DOMCSSStyleSheet _CSSStyleSheetWith:]): (+[DOMCSSPrimitiveValue _valueWith:]):
bindings/objc/DOMCSSInternal.h:
bindings/objc/DOMExtensions.h:
bindings/objc/DOMInternal.h:
bindings/objc/DOMRGBColor.h: Added.
bindings/objc/DOMRGBColor.mm: Added. (getWrapperForRGB): (setWrapperForRGB): (removeWrapperForRGB): (-[DOMRGBColor dealloc]): (-[DOMRGBColor finalize]): (-[DOMRGBColor red]): (-[DOMRGBColor green]): (-[DOMRGBColor blue]): (-[DOMRGBColor alpha]): (-[DOMRGBColor color]): (-[DOMRGBColor _initWithRGB:WebCore::]): (+[DOMRGBColor _RGBColorWithRGB:WebCore::]):
bindings/scripts/CodeGeneratorObjC.pm:
css/CSSCharsetRule.idl: Added.
css/CSSFontFaceRule.idl: Added.
css/CSSImportRule.idl: Added.
css/CSSMediaRule.idl: Added.
css/CSSPageRule.idl: Added.
css/CSSRule.idl:
css/CSSStyleDeclaration.idl:
css/CSSStyleRule.idl: Added.
css/CSSStyleSheet.idl: Added.
css/CSSUnknownRule.idl: Added.
css/CSSValue.idl:
css/MediaList.idl:
css/RGBColor.idl: Added.
css/Rect.idl:
css/RectImpl.h:

WebKit:

Reviewed by Tim H.

patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10684 Auto-generate the Objective-C DOM CSS bindings

MigrateHeaders.make:

12:19 PM Changeset in webkit [16194] by thatcher

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Justin.

Testcase for:
http://bugzilla.opendarwin.org/show_bug.cgi?id=10579
AppleStyleCommand::applyBlockStyle crash

editing/style/table-selection-expected.checksum: Added.
editing/style/table-selection-expected.png: Added.
editing/style/table-selection-expected.txt: Added.
editing/style/table-selection.html: Added.

WebCore:

Reviewed by Justin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10579
AppleStyleCommand::applyBlockStyle crash

editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle): Prevent a crash by making sure that the 'beyondEnd' node is after the start node.

12:15 PM Changeset in webkit [16193] by thatcher

10 edits in trunk

JavaScriptCore:

Reviewed by Tim H.

Bug 10454: Unix bakefile fixes
http://bugzilla.opendarwin.org/show_bug.cgi?id=10454

JavaScriptCoreSources.bkl:

WebCore:

Reviewed by Tim H.

Bug 10454: Unix bakefile fixes
http://bugzilla.opendarwin.org/show_bug.cgi?id=10454

WebCoreSources.bkl:
platform/gdk/RenderPopupMenuGdk.cpp: (WebCore::RenderPopupMenuGdk::RenderPopupMenuGdk):
platform/gdk/RenderPopupMenuGdk.h:
platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::createPopupMenu): (WebCore::RenderThemeGdk::systemFont):
platform/gdk/RenderThemeGdk.h:
platform/gdk/TemporaryLinkStubs.cpp:
webcore-base.bkl:

10:25 AM Changeset in webkit [16192] by adele

6 edits in trunk/WebCore

Reviewed by Anders.

Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10667 Password: Double-click should select-all to avoid exposing word boundaries

Test: fast/forms/password-doubleclick-selection.html

editing/visible_units.cpp: (WebCore::previousBoundary): When searching for boundaries in renderers that use the textSecurity property, convert characters in strings to alpha-numeric characters (in this case, all 'x's) so that every character isn't treated as a punctuation boundary. (WebCore::nextBoundary): ditto.
editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Updated to use the renderer's string instead of the node value. This matches the base class implementation of handleTextNode.

Code cleanup.

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Avoid unnecessary check for password field case if the smart replace condition is false.
page/Frame.cpp: (WebCore::Frame::mayCopy): Removed duplicate code. Calls isSelectionInPasswordField now.
rendering/RenderText.cpp: (WebCore::RenderText::setText): Updated formatting.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed