Context Navigation

Despite the fact that some people built okay without this change, it sure was biting me,
probably because I just wiped my build directory for a fresh build -
Today's earlier removal of DOMList.h needed to occur in MigrateHeaders.make, as well

MigrateHeaders.make: removed DOMList.h

7:45 PM Changeset in webkit [16312] by beidson

2 edits in trunk/JavaScriptCore

Build fix - I think Tim's last checkin wasn't tested on Tiger, possibly. I simply
commented out the undefined constants until he can have a chance to make the right call

bindings/objc/objc_utility.mm: (KJS::Bindings::objcValueTypeForType): Commented out undefined symbols

5:22 PM Changeset in webkit [16311] by thatcher

1 edit in trunk/WebCore/bridge/mac/FrameMac.mm

Build fix. KeyScript is deprecated in Leopard, we need a new solution for this <rdar://problem/4727607>

4:57 PM Changeset in webkit [16310] by thatcher

4 edits in trunk/JavaScriptCore

Reviewed by Tim O. and Darin.

Add support for more method signatures affecting ObjC methods called from JavaScript:

Added unsigned types and long long.
Allow methods that use const, oneway, bycopy and byref type modifiers.

bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod):
bindings/objc/objc_utility.h: (KJS::Bindings::):
bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue): (KJS::Bindings::convertObjcValueToValue): (KJS::Bindings::objcValueTypeForType):

4:11 PM Changeset in webkit [16309] by adele

2 edits in trunk/WebCore

Reviewed by Adele.

Fix Qt/Linux build.

CMakeLists.txt: Add dom/RangeException.idl to build & fix feature defines.

2:42 PM Changeset in webkit [16308] by eseidel

104 edits
14 adds
34 deletes in trunk

2006-09-11 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10750

This finally fixes the SVGAnimated* classes JS bindings!

Move all SVGAnimated*.idl files from ksvg2/bindings/idl/svg to ksvg2/svg
Adjust XCode/Qt build files to generate the new idl files

Remove all SVGAnimated* primitives cpp implementations (Angle/Boolean/Color/Enumeration/Integer/Length/

LengthList/Number/NumberList/PreserveAspectRatio/
Rect/String/TransformList)

Remove unneeded methods from CodeGenerator.pm and add new helper function: IsSVGAnimatedType
Adjust CodeGeneratorJS.pm to the new SVGAnimated* tear-off concept

Add two new macros: ANIMATED_PROPERTY_EMPTY_DECLARATIONS / ANIMATED_PROPERTY_FORWARD_DECLARATIONS. This is used to fix multiple-inheritance issues in SVG with properties, similar like SVGTests::isValid() was fixed.

Rewrote SVGList using WTF::Vector, instead of DeprecatedPtrList and killed DOMList. (SVGAnimated*Lists work again now)

Adjust macros in SVGElement to create the "*Animated" tear-off classes.

Adjust all SVG classes which use the ANIMATED macros to include the ClassName as first param in the header.

CMakeLists.txt:
DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/scripts/CodeGenerator.pm:
bindings/scripts/CodeGeneratorJS.pm:
kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::adjustRectsForAspectRatio): (WebCore::RenderSVGImage::paint):
kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::translationForAttributes):
ksvg2/ksvg.h:
ksvg2/misc/SVGDocumentExtensions.h: (WebCore::FloatRect):
ksvg2/svg/SVGAElement.h:
ksvg2/svg/SVGAnimateColorElement.cpp:
ksvg2/svg/SVGAnimateColorElement.h:
ksvg2/svg/SVGAnimateTransformElement.h:
ksvg2/svg/SVGAnimatedTemplate.h: (WebCore::SVGAnimatedTemplate::~SVGAnimatedTemplate):
ksvg2/svg/SVGAnimationElement.h:
ksvg2/svg/SVGCircleElement.h:
ksvg2/svg/SVGClipPathElement.h:
ksvg2/svg/SVGComponentTransferFunctionElement.cpp: (SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): (SVGComponentTransferFunctionElement::transferFunction):
ksvg2/svg/SVGComponentTransferFunctionElement.h:
ksvg2/svg/SVGCursorElement.h:
ksvg2/svg/SVGDefsElement.h:
ksvg2/svg/SVGElement.h:
ksvg2/svg/SVGElementInstanceList.cpp: (WebCore::SVGElementInstanceList::SVGElementInstanceList):
ksvg2/svg/SVGElementInstanceList.h:
ksvg2/svg/SVGEllipseElement.h:
ksvg2/svg/SVGExternalResourcesRequired.h:
ksvg2/svg/SVGFEBlendElement.h:
ksvg2/svg/SVGFEColorMatrixElement.cpp: (SVGFEColorMatrixElement::SVGFEColorMatrixElement): (SVGFEColorMatrixElement::parseMappedAttribute): (SVGFEColorMatrixElement::filterEffect):
ksvg2/svg/SVGFEColorMatrixElement.h:
ksvg2/svg/SVGFEComponentTransferElement.h:
ksvg2/svg/SVGFECompositeElement.h:
ksvg2/svg/SVGFEDiffuseLightingElement.h:
ksvg2/svg/SVGFEDisplacementMapElement.h:
ksvg2/svg/SVGFEFloodElement.h:
ksvg2/svg/SVGFEGaussianBlurElement.h:
ksvg2/svg/SVGFEImageElement.h:
ksvg2/svg/SVGFELightElement.h:
ksvg2/svg/SVGFEMergeNodeElement.h:
ksvg2/svg/SVGFEOffsetElement.h:
ksvg2/svg/SVGFESpecularLightingElement.h:
ksvg2/svg/SVGFETileElement.h:
ksvg2/svg/SVGFETurbulenceElement.h:
ksvg2/svg/SVGFilterElement.h:
ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
ksvg2/svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::SVGFitToViewBox): (WebCore::SVGFitToViewBox::parseViewBox): (WebCore::SVGFitToViewBox::viewBoxToViewTransform):
ksvg2/svg/SVGFitToViewBox.h:
ksvg2/svg/SVGForeignObjectElement.h:
ksvg2/svg/SVGGElement.h:
ksvg2/svg/SVGGradientElement.cpp: (SVGGradientElement::SVGGradientElement):
ksvg2/svg/SVGGradientElement.h:
ksvg2/svg/SVGHelper.cpp: (WebCore::SVGHelper::PercentageOfViewport):
ksvg2/svg/SVGImageElement.h:
ksvg2/svg/SVGLength.cpp:
ksvg2/svg/SVGLengthList.cpp: (WebCore::SVGLengthList::SVGLengthList): (WebCore::SVGLengthList::parse):
ksvg2/svg/SVGLengthList.h:
ksvg2/svg/SVGLineElement.h:
ksvg2/svg/SVGLinearGradientElement.h:
ksvg2/svg/SVGList.h: (WebCore::SVGListBase::SVGListBase): (WebCore::SVGListBase::~SVGListBase): (WebCore::SVGListBase::numberOfItems): (WebCore::SVGListBase::clear): (WebCore::SVGListBase::initialize): (WebCore::SVGListBase::getFirst): (WebCore::SVGListBase::getLast): (WebCore::SVGListBase::getItem): (WebCore::SVGListBase::insertItemBefore): (WebCore::SVGListBase::replaceItem): (WebCore::SVGListBase::removeItem): (WebCore::SVGListBase::appendItem): (WebCore::SVGList::nullItem): (WebCore::):
ksvg2/svg/SVGLocatable.cpp:
ksvg2/svg/SVGMarkerElement.h:
ksvg2/svg/SVGMaskElement.h:
ksvg2/svg/SVGNumberList.cpp: (SVGNumberList::SVGNumberList): (SVGNumberList::parse):
ksvg2/svg/SVGNumberList.h:
ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::pathSegList):
ksvg2/svg/SVGPathElement.h:
ksvg2/svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::SVGPathSegList):
ksvg2/svg/SVGPathSegList.h:
ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement):
ksvg2/svg/SVGPatternElement.h:
ksvg2/svg/SVGPointList.cpp: (SVGPointList::SVGPointList):
ksvg2/svg/SVGPointList.h:
ksvg2/svg/SVGPolyElement.cpp: (SVGPolyElement::points): (SVGPolyElement::svgPolyTo): (SVGPolyElement::notifyAttributeChange):
ksvg2/svg/SVGPolyElement.h:
ksvg2/svg/SVGPolygonElement.cpp: (SVGPolygonElement::toPathData):
ksvg2/svg/SVGPolylineElement.cpp: (SVGPolylineElement::toPathData):
ksvg2/svg/SVGPreserveAspectRatio.h: (WebCore::SVGPreserveAspectRatio::):
ksvg2/svg/SVGRadialGradientElement.h:
ksvg2/svg/SVGRectElement.h:
ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement): (WebCore::SVGSVGElement::parseMappedAttribute): (WebCore::SVGSVGElement::createRenderer):
ksvg2/svg/SVGSVGElement.h:
ksvg2/svg/SVGScriptElement.h:
ksvg2/svg/SVGStopElement.h:
ksvg2/svg/SVGStringList.cpp: (WebCore::SVGStringList::SVGStringList): (WebCore::SVGStringList::reset):
ksvg2/svg/SVGStringList.h:
ksvg2/svg/SVGStyledElement.h:
ksvg2/svg/SVGStyledLocatableElement.cpp:
ksvg2/svg/SVGStyledTransformableElement.cpp: (SVGStyledTransformableElement::SVGStyledTransformableElement):
ksvg2/svg/SVGStyledTransformableElement.h:
ksvg2/svg/SVGSwitchElement.h:
ksvg2/svg/SVGSymbolElement.h:
ksvg2/svg/SVGTRefElement.h:
ksvg2/svg/SVGTests.cpp: (WebCore::SVGTests::isValid):
ksvg2/svg/SVGTextContentElement.h:
ksvg2/svg/SVGTextElement.cpp: (WebCore::SVGTextElement::SVGTextElement):
ksvg2/svg/SVGTextElement.h:
ksvg2/svg/SVGTextPositioningElement.cpp: (SVGTextPositioningElement::SVGTextPositioningElement): (SVGTextPositioningElement::parseMappedAttribute):
ksvg2/svg/SVGTextPositioningElement.h:
ksvg2/svg/SVGTransformList.cpp: (SVGTransformList::SVGTransformList): (SVGTransformList::createSVGTransformFromMatrix): (SVGTransformList::consolidate): (SVGTransformList::concatenate):
ksvg2/svg/SVGTransformList.h:
ksvg2/svg/SVGURIReference.h:
ksvg2/svg/SVGUseElement.h:
ksvg2/svg/SVGViewElement.h:

2:09 PM Changeset in webkit [22159] by andersca

2 edits in branches/WindowsMerge/WebCore

2006-09-11 Anders Carlsson <acarlsson@apple.com>

WebCore.vcproj/WebCore.vcproj: Fix build.

2:07 PM Changeset in webkit [16307] by kmccullo

1 edit in trunk/WebCore/platform/mac/LocalCurrentGraphicsContext.h

Build fix

1:58 PM Changeset in webkit [16306] by beidson

1 edit in trunk/WebCore/ChangeLog

ChangeLog date fix

1:48 PM Changeset in webkit [16305] by aroben

3 edits
2 moves in trunk/WebCore

Rubberstamped by Adele.

Rename LocalGraphicsContext.{h,mm} to
LocalCurrentGraphicsContext.{h,mm} to match the class name.

WebCore.xcodeproj/project.pbxproj:
platform/mac/LocalCurrentGraphicsContext.mm: Added.
platform/mac/LocalCurrentGraphicsContext.h: Added.
platform/mac/LocalGraphicsContext.h: Removed.
platform/mac/LocalGraphicsContext.mm: Removed.
rendering/RenderThemeMac.mm: Fix #include to match renamed file

1:36 PM Changeset in webkit [22158] by andersca

1 edit
2 adds in branches/WindowsMerge/WebCore

2006-09-11 Anders Carlsson <acarlsson@apple.com>

Reviewed by Tim O and Maciej.

Add plugin stream object.

plugins/win/PluginStreamWin.cpp: Added. (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::setRequestHeaders): (WebCore::PluginStreamWin::setPostData): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::stop): (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::cancelAndDestroyStream): (WebCore::PluginStreamWin::destroyStream): (WebCore::PluginStreamWin::delayDeliveryTimerFired): (WebCore::PluginStreamWin::deliverData): (WebCore::PluginStreamWin::receivedResponse): (WebCore::PluginStreamWin::receivedData): (WebCore::PluginStreamWin::receivedAllData):
plugins/win/PluginStreamWin.h: Added.

1:34 PM Changeset in webkit [16304] by beidson

1 edit in trunk/WebCore/ChangeLog

Conflict marker removed

1:29 PM Changeset in webkit [16303] by beidson

2 edits in trunk/WebCore

Build fix

WebCore.xcodeproj/project.pbxproj:

11:46 AM Changeset in webkit [16302] by kmccullo

11 edits
4 adds in trunk

LayoutTests:

Reviewed by Darin.

ChangeLog:
fast/dom/Range/range-compareNode-expected.txt: Added.
fast/dom/Range/range-compareNode.html: Added.
fast/dom/Range/range-comparePoint.html:

WebCore:

Reviewed by Darin.

Implements comparePoint on the Range class

Exposes RangeExceptions in JavaScript

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/js/kjs_binding.cpp:
bindings/objc/DOMInternal.mm:
dom/Range.cpp: (WebCore::Range::comparePoint): (WebCore::Range::compareNode):
dom/Range.h: (WebCore::Range::):
dom/Range.idl:
dom/RangeException.h: Added. (WebCore::):
dom/RangeException.idl: Added.
page/DOMWindow.idl:

11:41 AM Changeset in webkit [16301] by aroben

3 edits
2 adds in trunk/WebCore

Reviewed by timo.

Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10812
Move LocalGraphicsContext out of RenderThemeMac

WebCore.xcodeproj/project.pbxproj:
platform/mac/LocalGraphicsContext.h: Added.
platform/mac/LocalGraphicsContext.mm: Added. (WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext): (WebCore::LocalCurrentGraphicsContext::~LocalCurrentGraphicsContext):
rendering/RenderThemeMac.mm:

11:20 AM Changeset in webkit [22157] by beidson

7 edits
1 add in branches/WindowsMerge

Initial IconDatabase hookup for Boomer
(Don't expect to have icons till I hook up the loaders!)

10:38 AM Changeset in webkit [16300] by darin

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Darin.

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10323 REGRESSION: javascript: URL containing '
' gets passed as ''

fast/dom/javascript-backslash-expected.txt: Added.
fast/dom/javascript-backslash.html: Added.

WebCore:

Reviewed by Darin.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10323 REGRESSION: javascript: URL containing '
' gets passed as ''

Test: fast/dom/javascript-backslash.html

platform/KURL.cpp: (WebCore::KURL::init): Don't do backslash substitution in JavaScript URLs.

10:11 AM Changeset in webkit [16299] by weinig

28 edits in trunk/WebCore

Reviewed by Darin and Tim H.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10792
Remove the [Exclude=LANGUAGE] idiom from IDL's and code generators
for something better

Replaces [Exclude=LANGUAGE] idiom with preprocessor #if defined(LANGUAGE) idiom.

Assorted whitespace changes to IDL files.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOMEvents.h:
bindings/scripts/CodeGenerator.pm:
bindings/scripts/CodeGeneratorJS.pm:
bindings/scripts/CodeGeneratorObjC.pm:
css/CSSRule.idl:
css/CSSStyleDeclaration.idl:
css/CSSValue.idl:
dom/DOMImplementation.idl:
dom/Document.idl:
dom/Element.idl:
dom/Event.idl:
dom/KeyboardEvent.idl:
dom/MouseEvent.idl:
dom/NamedNodeMap.idl:
dom/NodeFilter.idl:
dom/UIEvent.idl:
dom/WheelEvent.idl:
html/HTMLAnchorElement.idl:
html/HTMLAreaElement.idl:
html/HTMLDocument.idl:
html/HTMLElement.idl:
html/HTMLImageElement.idl:
html/HTMLInputElement.idl:
html/HTMLLinkElement.idl:
html/HTMLOptionsCollection.idl:

7:49 AM Changeset in webkit [16298] by darin

3 edits
2 deletes in trunk/LayoutTests

converted a test to plain text (makes it platform independent; fixes a failure)

fast/events/ondragenter-expected.checksum: Removed.
fast/events/ondragenter-expected.png: Removed.
fast/events/ondragenter-expected.txt:
fast/events/ondragenter.html:

12:28 AM Changeset in webkit [16297] by hyatt

3 edits in trunk/WebCore

Fix an unwitting victim of the kMin->min change. calcBlockMinMaxWidth
was accidentally renamed to calcBlominMaxWidth.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcMinMaxWidth): (WebCore::RenderBlock::calcBlockMinMaxWidth):
rendering/RenderBlock.h:

Sep 10, 2006:

11:37 PM Changeset in webkit [16296] by hyatt

15 edits in trunk/WebCore

Rework the printer font stuff a little bit so that the Font API doesn't
have to be changed.

Reviewed by eseidel

WebCore.xcodeproj/project.pbxproj:
bridge/mac/WebCoreStringTruncator.mm: (truncateString): (+[WebCoreStringTruncator widthOfString:font:]):
platform/Font.cpp: (WebCore::Font::drawSimpleText):
platform/Font.h:
platform/TextStyle.h: (WebCore::TextStyle::TextStyle): (WebCore::TextStyle::attemptFontSubstitution): (WebCore::TextStyle::setRTL):
platform/mac/FontMac.mm: (WebCore::m_wordSpacing): (WebCore::Font::drawGlyphs):
platform/mac/ListBoxMac.mm: (itemTextRenderer): (groupLabelTextRenderer): (-[WebCoreTableView drawRow:clipRect:]):
platform/mac/PopUpButtonMac.mm: (PopUpButton::sizeHint):
platform/mac/TextFieldMac.mm: (-[NSSearchFieldCell _addStringToRecentSearches:]):
platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint): (WebCoreTextFloatWidth):
rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):

11:32 PM Changeset in webkit [22156] by hyatt

1 edit in branches/WindowsMerge/WebCore/platform/win/FontWin.cpp

Remove usePrinterFont param from Cairo drawGlyphs code path. (CG code path was unpatched so no need to revert it.

11:16 PM Changeset in webkit [16295] by beidson

3 edits in trunk/WebCore

10:23 PM Changeset in webkit [16294] by beidson

2 edits in trunk/WebCore

Reviewed by Maciej

Added specialized HashTraits

platform/IntSizeHash.h:

9:42 PM Changeset in webkit [22155] by hyatt

1 edit in branches/WindowsMerge/WebCore/ChangeLog

Remove the addIntrinsicMargins code from the theme. I did this
in the open source version but forgot to do it in the internal
version.

rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustButtonStyle): (WebCore::RenderThemeWin::adjustTextFieldStyle): (WebCore::RenderThemeWin::adjustTextAreaStyle): (WebCore::RenderThemeWin::adjustMenuListStyle):

7:48 PM Changeset in webkit [16293] by darin

3 edits
2 deletes in trunk/LayoutTests

converted a text to plain text (makes it platform independent; fixes a failure)

fast/text/plain-text-line-breaks-expected.checksum: Removed.
fast/text/plain-text-line-breaks-expected.png: Removed.
fast/text/plain-text-line-breaks-expected.txt: Regenerated.
fast/text/plain-text-line-breaks.html: Added a call to dumpAsText().

7:26 PM Changeset in webkit [16292] by beidson

3 edits in trunk/WebCore

Forgetting header #define protection is BAAAAAD
(and re-alphabatized the project file)

WebCore.xcodeproj/project.pbxproj:
platform/IntSizeHash.h:

7:13 PM Changeset in webkit [16291] by beidson

3 edits
1 add in trunk/WebCore

Reviewed by Maciej

Moved the custom IntSize hash out of IconDatabase into a more generally useful file

WebCore.xcodeproj/project.pbxproj:
loader/icon/IconDatabase.h:
platform/IntSizeHash.h: Added.

5:14 PM Changeset in webkit [22154] by beidson

2 edits in branches/WindowsMerge/WebCore

Build fix

4:33 PM Changeset in webkit [16290] by hyatt

58 edits in trunk/LayoutTests/fast/forms

Land new results.

4:27 PM Changeset in webkit [16289] by hyatt

11 edits in trunk/WebCore

Fix for bug 10801, form controls that get styled suddenly lose their
intrinsic margins. Move the intrinsic margin addition code into
adjustRenderStyle and get it out of the theme code and the old form control
code.

Reviewed by aroben

css/cssstyleselector.cpp: (WebCore::addIntrinsicMargins): (WebCore::CSSStyleSelector::adjustRenderStyle):
css/html4.css:
rendering/DeprecatedRenderSelect.h: (WebCore::DeprecatedRenderSelect::calcReplacedHeight):
rendering/DeprecatedSlider.h:
rendering/RenderFormElement.cpp: (WebCore::RenderFormElement::setStyle):
rendering/RenderFormElement.h:
rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize):
rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustButtonStyle): (WebCore::RenderThemeMac::adjustTextFieldStyle): (WebCore::RenderThemeMac::adjustTextAreaStyle): (WebCore::RenderThemeMac::adjustMenuListStyle): (WebCore::RenderThemeMac::adjustMenuListButtonStyle):
rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustButtonStyle): (WebCore::RenderThemeWin::adjustTextFieldStyle): (WebCore::RenderThemeWin::adjustTextAreaStyle):

1:22 PM Changeset in webkit [16288] by darin

2 edits in trunk/WebKit

Reviewed by Brady.

fix http://bugzilla.opendarwin.org/show_bug.cgi?id=10547 REGRESSION: Links that should open in a new window open in the same window, while opening another blank window

WebView/WebFrame.m: (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): Changed a mistaken "self" to "frame", which was the cause of the bug. Also fixed the method so that it won't crash if createWebViewWithRequest does something that has a side effect of releasing this WebView or this frame by retaining "self" and "frame" as needed. Also fixed a problem where the code to set "opener" was backwards, and would set the opener of the old frame to point to the new frame instead of vice versa.

1:21 PM Changeset in webkit [16287] by darin

1 edit
2 adds in trunk/WebCore

test for http://bugzilla.opendarwin.org/show_bug.cgi?id=10547

manual-tests/target-test.html: Added.
manual-tests/targeted.html: Added.

12:53 PM Changeset in webkit [16286] by eseidel

18 edits in trunk/WebCore

2006-09-10 Eric Seidel <eric@eseidel.com>

Reviewed by darin.

Remove a bunch more NSGraphicsContext related code.
Add a LocalCurrentGraphicsContext to simplify methods which need to call up into AppKit controls (and thus depend on the [NSGraphicsContext currentContext] being set correctly)
Add an "isPrinting" flag to many of the text drawing functions in order to avoid the need for a GraphicsContext::isPrinting() function.

No tests were harmed in the making of this patch.

bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge drawRect:]):
kcanvas/device/quartz/KRenderingDeviceQuartz.h: (WebCore::KRenderingDeviceContextQuartz::cgContext): (WebCore::KRenderingDeviceQuartz::isBuffered):
kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceContextQuartz::KRenderingDeviceContextQuartz): (WebCore::KRenderingDeviceContextQuartz::~KRenderingDeviceContextQuartz):
kcanvas/device/quartz/QuartzSupport.mm:
platform/Font.cpp: (WebCore::Font::drawSimpleText): (WebCore::Font::drawText):
platform/Font.h:
platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText):
platform/GraphicsContext.h:
platform/mac/FileButtonMac.mm: (-[WebFileChooserButton drawRect:]):
platform/mac/FontMac.mm: (WebCore::ATSULayoutParameters::ATSULayoutParameters): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::drawComplexText): (WebCore::Font::drawGlyphs):
platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspelling):
platform/mac/ListBoxMac.mm: (-[WebCoreTableView drawRow:clipRect:]):
platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint):
rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
rendering/RenderThemeMac.mm: (WebCore::WebCoreNSGraphicsContextBridge::WebCoreNSGraphicsContextBridge): (WebCore::WebCoreNSGraphicsContextBridge::~WebCoreNSGraphicsContextBridge): (WebCore::RenderThemeMac::paintButton): (WebCore::RenderThemeMac::paintTextField): (WebCore::RenderThemeMac::paintTextArea):

11:17 AM Changeset in webkit [16285] by ap

2 edits in trunk/WebKitQt

Reviewed and landed by ap.

Fix QtLauncher - it is supposed to create a FrameView on its own nowadays.

QtLauncher/main.cpp: (main):

12:54 AM Changeset in webkit [22153] by sfalken

4 edits in branches/WindowsMerge

12:41 AM Changeset in webkit [16284] by sfalken

4 edits in trunk/WebCore

2006-09-09 Steve Falkenburg <sfalken@apple.com>

Reviewed by aroben.

Fixes to work with string API changes.

platform/cf/ResourceLoaderCFNet.cpp: (WebCore::arrayFromFormData): (WebCore::ResourceLoader::start):
platform/cf/StringCF.cpp:
platform/cf/StringImplCF.cpp:

12:40 AM Changeset in webkit [16283] by sfalken

1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj

2006-09-09 Steve Falkenburg <sfalken@apple.com>

Reviewed by aroben.

Add missing copy command.
Support finding icu headers in multiple locations.

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

12:19 AM Changeset in webkit [22152] by sfalken

7 edits in branches/WindowsMerge

Sep 9, 2006:

11:28 PM Changeset in webkit [22151] by aroben

1 edit in branches/WindowsMerge/WebCore/ChangeLog

Reviewed by hyatt.

Remove unnecessary calls to setAffectedBy{Active,Hover}Rules

rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustMenuListStyle): Remove unnecessary calls

10:52 PM Changeset in webkit [16282] by hyatt

4 adds in trunk/LayoutTests/fast/forms

Add test for textarea scrollwidth and height.

10:47 PM Changeset in webkit [16281] by hyatt

4 adds in trunk/LayoutTests/fast/block/positioning

Add layout test for bug 10719.

10:37 PM Changeset in webkit [16280] by hyatt

8 edits in trunk/WebCore

Fix for Bugzilla bug 5500, scrollLeft/Top/Width/Height properties not supported
on textarea. Refactored the DOM getters and setters to go through the renderer
instead of right to the layer. The renderer functions are virtual so that the
text control can subclass and forward to its anonymous div.

Fix for Bugzilla bug 10719, When positioned objects are sizing using their
containing block width as a guide, they should not ever use the line width like
non-positioned objects do.

Reviewed by aroben

WebCore.xcodeproj/project.pbxproj:
dom/Element.cpp: (WebCore::Element::scrollLeft): (WebCore::Element::scrollTop): (WebCore::Element::setScrollLeft): (WebCore::Element::setScrollTop):
rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockWidthForPositioned):
rendering/RenderObject.cpp: (WebCore::RenderObject::clientWidth): (WebCore::RenderObject::clientHeight): (WebCore::RenderObject::scrollWidth): (WebCore::RenderObject::scrollHeight): (WebCore::RenderObject::scrollLeft): (WebCore::RenderObject::scrollTop): (WebCore::RenderObject::setScrollLeft): (WebCore::RenderObject::setScrollTop): (WebCore::RenderObject::hasStaticX): (WebCore::RenderObject::hasStaticY):
rendering/RenderObject.h: (WebCore::RenderObject::clientLeft): (WebCore::RenderObject::clientTop):
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::scrollWidth): (WebCore::RenderTextControl::scrollHeight): (WebCore::RenderTextControl::scrollLeft): (WebCore::RenderTextControl::scrollTop): (WebCore::RenderTextControl::setScrollLeft): (WebCore::RenderTextControl::setScrollTop):
rendering/RenderTextControl.h:

9:55 PM Changeset in webkit [16279] by hyatt

4 edits in trunk/WebCore

Implement support for the WinIE clientLeft and clientTop extensions.

Reviewed by aroben

dom/Element.cpp: (WebCore::Element::clientLeft): (WebCore::Element::clientTop):
dom/Element.h:
dom/Element.idl:
rendering/RenderObject.h: (WebCore::RenderObject::clientLeft): (WebCore::RenderObject::clientTop):

7:36 PM Changeset in webkit [16278] by weinig

12 edits in trunk

WebCore:

Reviewed by Eric.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10795
Auto-generate the Objective-C DOM XPath bindings

Auto-generates DOMXPathExpression, DOMXPathNSResolver and DOMXPathResult.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOMPrivate.h:
bindings/objc/DOMXPath.h:
bindings/objc/DOMXPath.mm:
bindings/objc/PublicDOMInterfaces.h:
xml/XPathExpression.idl:
xml/XPathNSResolver.idl:
xml/XPathResult.idl:

WebKit:

Reviewed by Eric.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10795
Auto-generate the Objective-C DOM XPath bindings

MigrateHeaders.make:

3:05 PM Changeset in webkit [16277] by weinig

23 edits
3 adds
1 delete in trunk

WebCore:

Reviewed by Eric.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10791
Even More Objective-C DOM auto-generation cleanup

Auto-generate some remaining extension methods for DOMDocument and DOMCSSStyleDeclaration.

Split DOMHTMLEmbedElement into it's own files. It can't be auto-generated yet because the Objective-C interface is significantly different from the implementation interface. Since HTMLEmbedElement is not in the W3C spec, this is somewhat of a gray area.

Auto-generate DOMEventListener protocol.

Clean up the IDL files by separating the extensions from the specified methods and attributes.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOM.mm:
bindings/objc/DOMCSS.mm:
bindings/objc/DOMEventListener.h: Removed.
bindings/objc/DOMExtensions.h:
bindings/objc/DOMHTML.h:
bindings/objc/DOMHTML.mm:
bindings/objc/DOMHTMLEmbedElement.h: Added.
bindings/objc/DOMHTMLEmbedElement.mm: Added. (-[DOMHTMLEmbedElement align]): (-[DOMHTMLEmbedElement setAlign:]): (-[DOMHTMLEmbedElement height]): (-[DOMHTMLEmbedElement setHeight:]): (-[DOMHTMLEmbedElement name]): (-[DOMHTMLEmbedElement setName:]): (-[DOMHTMLEmbedElement src]): (-[DOMHTMLEmbedElement setSrc:]): (-[DOMHTMLEmbedElement type]): (-[DOMHTMLEmbedElement setType:]): (-[DOMHTMLEmbedElement width]): (-[DOMHTMLEmbedElement setWidth:]):
bindings/objc/DOMPrivate.h:
bindings/objc/PublicDOMInterfaces.h:
css/CSSStyleDeclaration.idl:
dom/Document.idl:
dom/KeyboardEvent.h:
dom/KeyboardEvent.idl:
dom/MouseEvent.idl:
dom/MutationEvent.idl:
dom/OverflowEvent.idl:
dom/UIEvent.idl:
dom/WheelEvent.idl:
html/HTMLEmbedElement.idl: Added.

WebKit:

Reviewed by Eric.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10791
Even More Objective-C DOM auto-generation cleanup

MigrateHeaders.make:

WebKitTools:

Reviewed by Eric.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10791
Even More Objective-C DOM auto-generation cleanup

Change to use new, more Objectice-C'ish version of DOMKeyboardEvent's initKeyboardEvent. Fixes an error with regression test for fast/events/dblclick-addEventListener.html.

DumpRenderTree/EventSendingController.m: (-[EventSendingController fireKeyboardEventsToElement:]):

1:29 PM Changeset in webkit [16276] by eseidel

47 edits in trunk/WebCore

2006-09-09 Eric Seidel <eric@eseidel.com>

Reviewed by Tim H.

Remove DeprecatedString usage and fix style.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10787

No tests were harmed in the making of this patch.

kcanvas/KCanvasFilters.cpp: (WebCore::KCanvasFilterEffect::in): (WebCore::KCanvasFilterEffect::setIn): (WebCore::KCanvasFilterEffect::result): (WebCore::KCanvasFilterEffect::setResult): (WebCore::KCanvasFEMerge::externalRepresentation):
kcanvas/KCanvasFilters.h: (WebCore::KCanvasFEBlend::in2): (WebCore::KCanvasFEBlend::setIn2): (WebCore::KCanvasFEComposite::in2): (WebCore::KCanvasFEComposite::setIn2): (WebCore::KCanvasFEDisplacementMap::in2): (WebCore::KCanvasFEDisplacementMap::setIn2): (WebCore::KCanvasFEMerge::mergeInputs): (WebCore::KCanvasFEMerge::setMergeInputs):
kcanvas/KCanvasResources.cpp: (WebCore::KCanvasResource::idInRegistry): (WebCore::KCanvasResource::setIdInRegistry): (WebCore::getResourceById):
kcanvas/KCanvasResources.h:
kcanvas/RenderPath.cpp: (WebCore::RenderPath::getAbsoluteRepaintRect): (WebCore::RenderPath::paint): (WebCore::RenderPath::drawMarkersIfNeeded):
kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::getAbsoluteRepaintRect):
kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::getAbsoluteRepaintRect):
kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):
kcanvas/device/KRenderingPaintServer.h: (WebCore::KRenderingPaintServer::idInRegistry): (WebCore::KRenderingPaintServer::setIdInRegistry):
kcanvas/device/quartz/KCanvasFilterQuartz.h:
kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::imageForName): (WebCore::KCanvasFilterQuartz::setImageForName): (WebCore::KCanvasFEMergeQuartz::getCIFilter):
ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
ksvg2/css/SVGRenderStyle.cpp:
ksvg2/css/SVGRenderStyle.h:
ksvg2/css/SVGRenderStyleDefs.h:
ksvg2/ecma/GlobalObject.cpp: (GlobalObject::get):
ksvg2/misc/KSVGTimeScheduler.cpp: (WebCore::SVGTimer::notifyAll):
ksvg2/svg/SVGDescElement.cpp: (WebCore::SVGDescElement::SVGDescElement): (WebCore::SVGDescElement::description):
ksvg2/svg/SVGDescElement.h:
ksvg2/svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::SVGFEBlendElement): (WebCore::SVGFEBlendElement::filterEffect):
ksvg2/svg/SVGFEColorMatrixElement.cpp: (SVGFEColorMatrixElement::SVGFEColorMatrixElement): (SVGFEColorMatrixElement::filterEffect):
ksvg2/svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement): (WebCore::SVGFEComponentTransferElement::filterEffect):
ksvg2/svg/SVGFECompositeElement.cpp: (SVGFECompositeElement::SVGFECompositeElement): (SVGFECompositeElement::filterEffect):
ksvg2/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement): (WebCore::SVGFEDiffuseLightingElement::filterEffect):
ksvg2/svg/SVGFEDisplacementMapElement.cpp: (SVGFEDisplacementMapElement::SVGFEDisplacementMapElement): (SVGFEDisplacementMapElement::filterEffect):
ksvg2/svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::SVGFEFloodElement): (WebCore::SVGFEFloodElement::filterEffect):
ksvg2/svg/SVGFEGaussianBlurElement.cpp: (SVGFEGaussianBlurElement::SVGFEGaussianBlurElement): (SVGFEGaussianBlurElement::filterEffect):
ksvg2/svg/SVGFELightElement.cpp:
ksvg2/svg/SVGFEMergeElement.cpp: (SVGFEMergeElement::filterEffect):
ksvg2/svg/SVGFEOffsetElement.cpp: (SVGFEOffsetElement::SVGFEOffsetElement): (SVGFEOffsetElement::filterEffect):
ksvg2/svg/SVGFESpecularLightingElement.cpp: (SVGFESpecularLightingElement::SVGFESpecularLightingElement): (SVGFESpecularLightingElement::filterEffect):
ksvg2/svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::SVGFETileElement): (WebCore::SVGFETileElement::filterEffect):
ksvg2/svg/SVGFETurbulenceElement.cpp: (SVGFETurbulenceElement::SVGFETurbulenceElement):
ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp: (SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
ksvg2/svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::parseViewBox): (WebCore::SVGFitToViewBox::parseMappedAttribute):
ksvg2/svg/SVGFitToViewBox.h:
ksvg2/svg/SVGLinearGradientElement.cpp: (SVGLinearGradientElement::buildGradient):
ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::notifyAttributeChange):
ksvg2/svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio): (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio): (WebCore::SVGPreserveAspectRatio::getCTM):
ksvg2/svg/SVGPreserveAspectRatio.h:
ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
ksvg2/svg/SVGStyleElement.cpp:
ksvg2/svg/SVGStyledTransformableElement.cpp:
ksvg2/svg/SVGViewElement.cpp: (WebCore::SVGViewElement::SVGViewElement): (WebCore::SVGViewElement::parseMappedAttribute):
ksvg2/svg/SVGZoomAndPan.cpp: (WebCore::SVGZoomAndPan::SVGZoomAndPan):

8:35 AM Changeset in webkit [16275] by thatcher

3 edits
2 adds in trunk

LayoutTests:

Adds a test for the CSS URL quoting logic.

fast/inspector/cssURLQuotes-expected.txt: Added.
fast/inspector/cssURLQuotes.html: Added.

WebCore:

Reviewed by Tim H.

<rdar://problem/4699166> REGRESSION: Background images in Mail stationery do not load

Fixes the quoting logic. The previous logic did not account for the
CSS tokenizer's regex character range between * and ~ as valid in URL types.

css/CSSPrimitiveValue.cpp: (WebCore::isCSSTokenizerURL):

3:54 AM Changeset in webkit [16274] by ap

4 edits in trunk

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10759 fast/AppleScript/array.html test failing

WebCore:

bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): Convert integer values to typeSInt32 AE descriptors.

LayoutTests:

fast/AppleScript/001-expected.txt: Updated results.

Sep 8, 2006:

6:56 PM Changeset in webkit [16273] by eseidel

51 edits in trunk/WebCore

2006-09-08 Eric Seidel <eric@eseidel.com>

Reviewed by darin.

Replace incorrect fooBaseValue() calls with foo() calls instead.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10746

With the previously broken animation system, we had both base and anim values
but they were not automatically connected/disconnected when animation started and stopped.
So the animVals were basically never used (since they were always wrong).
Now, animVal and baseVal are handled correctly.

There are only 3 places in the code where we will ever need to use the BaseValue accessor variants.

SVGAnimated* DOM bindings
Animation Code
parseMappedAttribute implementations

kcanvas/RenderForeignObject.cpp: (WebCore::RenderForeignObject::translationForAttributes):
kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::relativeBBox): (WebCore::RenderSVGImage::getAbsoluteRepaintRect): (WebCore::RenderSVGImage::translationForAttributes):
kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::translationForAttributes):
ksvg2/misc/SVGImageLoader.cpp: (WebCore::SVGImageLoader::updateFromElement):
ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler):
ksvg2/svg/SVGCircleElement.cpp: (SVGCircleElement::parseMappedAttribute): (SVGCircleElement::toPathData): (SVGCircleElement::pushAttributeContext): (SVGCircleElement::hasPercentageValues):
ksvg2/svg/SVGClipPathElement.cpp: (SVGClipPathElement::canvasResource):
ksvg2/svg/SVGComponentTransferFunctionElement.cpp: (SVGComponentTransferFunctionElement::transferFunction):
ksvg2/svg/SVGCursorElement.cpp: (SVGCursorElement::parseMappedAttribute):
ksvg2/svg/SVGEllipseElement.cpp: (WebCore::SVGEllipseElement::parseMappedAttribute): (WebCore::SVGEllipseElement::toPathData): (WebCore::SVGEllipseElement::pushAttributeContext): (WebCore::SVGEllipseElement::hasPercentageValues):
ksvg2/svg/SVGFEBlendElement.cpp: (SVGFEBlendElement::filterEffect):
ksvg2/svg/SVGFEColorMatrixElement.cpp: (SVGFEColorMatrixElement::filterEffect):
ksvg2/svg/SVGFEComponentTransferElement.cpp: (SVGFEComponentTransferElement::filterEffect):
ksvg2/svg/SVGFECompositeElement.cpp: (SVGFECompositeElement::filterEffect):
ksvg2/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::filterEffect):
ksvg2/svg/SVGFEDisplacementMapElement.cpp: (SVGFEDisplacementMapElement::filterEffect):
ksvg2/svg/SVGFEDistantLightElement.cpp: (WebCore::SVGFEDistantLightElement::lightSource):
ksvg2/svg/SVGFEFloodElement.cpp: (SVGFEFloodElement::filterEffect):
ksvg2/svg/SVGFEGaussianBlurElement.cpp: (SVGFEGaussianBlurElement::filterEffect):
ksvg2/svg/SVGFEImageElement.cpp: (SVGFEImageElement::parseMappedAttribute):
ksvg2/svg/SVGFEMergeElement.cpp: (SVGFEMergeElement::SVGFEMergeElement): (SVGFEMergeElement::filterEffect):
ksvg2/svg/SVGFEOffsetElement.cpp: (SVGFEOffsetElement::filterEffect):
ksvg2/svg/SVGFEPointLightElement.cpp: (WebCore::SVGFEPointLightElement::SVGFEPointLightElement): (WebCore::SVGFEPointLightElement::lightSource):
ksvg2/svg/SVGFESpecularLightingElement.cpp: (SVGFESpecularLightingElement::filterEffect):
ksvg2/svg/SVGFESpotLightElement.cpp: (WebCore::SVGFESpotLightElement::lightSource):
ksvg2/svg/SVGFETileElement.cpp: (SVGFETileElement::filterEffect):
ksvg2/svg/SVGFETurbulenceElement.cpp: (SVGFETurbulenceElement::filterEffect):
ksvg2/svg/SVGFilterElement.cpp: (SVGFilterElement::canvasResource):
ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp: (SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
ksvg2/svg/SVGGradientElement.cpp: (SVGGradientElement::rebuildStops):
ksvg2/svg/SVGHelper.cpp: (WebCore::SVGHelper::PercentageOfViewport):
ksvg2/svg/SVGLineElement.cpp: (SVGLineElement::toPathData): (SVGLineElement::pushAttributeContext): (SVGLineElement::hasPercentageValues):
ksvg2/svg/SVGLinearGradientElement.cpp: (SVGLinearGradientElement::buildGradient):
ksvg2/svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::canvasResource):
ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::attributeChanged): (WebCore::SVGMaskElement::drawMaskerContent):
ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::pushAttributeContext): (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::drawPatternContentIntoTile): (WebCore::SVGPatternElement::notifyAttributeChange): (WebCore::SVGPatternElement::getCTM):
ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
ksvg2/svg/SVGRectElement.cpp: (WebCore::SVGRectElement::toPathData): (WebCore::SVGRectElement::pushAttributeContext): (WebCore::SVGRectElement::hasPercentageValues):
ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::viewport): (WebCore::SVGSVGElement::parseMappedAttribute): (WebCore::SVGSVGElement::getCTM): (WebCore::SVGSVGElement::getScreenCTM): (WebCore::SVGSVGElement::createRenderer):
ksvg2/svg/SVGTRefElement.cpp: (SVGTRefElement::updateReferencedText):
ksvg2/svg/SVGUseElement.cpp: (SVGUseElement::closeRenderer):

6:46 PM Changeset in webkit [16272] by eseidel

2 edits in trunk/WebCore

2006-09-08 Eric Seidel <eric@eseidel.com>

Reviewed by beth.

Remove the last vestiges of KDOM (KDOMCSSValue and KDOMCSSValueList)
http://bugzilla.opendarwin.org/show_bug.cgi?id=10778

ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue): (WebCore::CSSParser::parseSVGStrokeDasharray): (WebCore::CSSParser::parseSVGPaint): (WebCore::CSSParser::parseSVGColor):

6:35 PM Changeset in webkit [16271] by tomernic

4 edits in trunk/WebKit

Reviewed by Brady Eidson.

Rolled out Maciej's code cleanup from 8/22. It turns out that keeping the "loading" flag
is a useful optimization, as it avoids many Objective-C method calls while polling resources
for their load state.

This fixes a 3-4% PLT performance regression (as measured on my MacBook Pro).

Loader/WebFrameLoader.m: (-[WebFrameLoader addPlugInStreamLoader:]): (-[WebFrameLoader removePlugInStreamLoader:]): (-[WebFrameLoader addSubresourceLoader:]): (-[WebFrameLoader removeSubresourceLoader:]):
WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _prepareForLoadStart]): (-[WebDataSource _setLoading:]): (-[WebDataSource _updateLoading]): (-[WebDataSource _startLoading]): (-[WebDataSource _stopLoading]): (-[WebDataSource _setPrimaryLoadComplete:]): (-[WebDataSource isLoading]):
WebView/WebDataSourceInternal.h:

5:11 PM Changeset in webkit [16270] by kmccullo

2 edits in trunk/WebKitSite

Reviewed by Adel.

this patch brought to you by the letter 'c'

coding/coding-style.html:

3:48 PM Changeset in webkit [22150] by beidson

4 edits in branches/WindowsMerge/WebKitWin

Stubs for Icon Database Path preferences

5:51 AM Changeset in webkit [16269] by zbujtas

5 edits in S60/trunk

2006-09-08 ligman <joseph.ligman@nokia.com>

Reviewed by Zalan Bujtas.
DESC: The text buffer returned from CWebCoreBridge::GetNextRenderTextForSmartLinksL
was getting prematurely deleted. To resolve, store a copy in the WebCore and remove
the copy from Webkit since it is no longer needed.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10498

WARNING: NO TEST CASES ADDED OR CHANGED

bridge/WebCoreBridge.cpp: (CWebCoreBridge::~CWebCoreBridge): (CWebCoreBridge::GetNextRenderTextForSmartLinksL): (CWebCoreBridge::GetRenderTextArea):
bridge/WebCoreBridge.h:

Sep 7, 2006:

4:48 PM Changeset in webkit [16268] by bdakin

4 edits in branches/Safari-2-0-branch/WebKit

Reviewed by Darin sort of and Maciej definitely.

Fix for <rdar://problem/4719149> Crash caused by malformed frame
setup. This is the same bug as 3853672, which has been fixed on TOT
for a while. We feel like this fix is much safer for the branch
though.

WebKit.xcodeproj/project.pbxproj: Version wars.
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[NSURLProtocol releaseResources]): Added comment for assertion that will be hit. (-[NSURLProtocol didFailWithError:]): Added comment for assertion that will be hit.
WebView.subproj/WebDataSource.m: (-[WebDataSource _receivedMainResourceError:complete:]): Retain and release all of the pieces involved with sending the error.

3:06 PM Changeset in webkit [16267] by weinig

13 edits
1 add in trunk

WebCore:

Reviewed by Darin and Tim H.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10774
Auto-generate the Objective-C DOM Traversal bindings

Auto-generates DOMNodeIterator and DOMTreeWalker.

Splits out DOMNodeFilter into its own file.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOM.mm:
bindings/objc/DOMNodeFilter.h: Added.
bindings/objc/DOMTraversal.h:
bindings/objc/PublicDOMInterfaces.h:
bindings/scripts/CodeGeneratorObjC.pm:
dom/NodeFilter.idl:
dom/NodeIterator.idl:
dom/Range.idl:
dom/TreeWalker.idl:

WebKit:

Reviewed by Darin and Tim H.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10774
Auto-generate the Objective-C DOM Traversal bindings

MigrateHeaders.make:

3:06 PM Changeset in webkit [16266] by spadma

2 edits in S60/trunk/WebKit

2006-09-07 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Check if the pageUrl is Null before setting it as currentUrl
http://bugzilla.opendarwin.org/show_bug.cgi?id=

BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL): (CWebKitLoader::LoadResourceL):

12:40 PM Changeset in webkit [16265] by spadma

5 edits in S60/trunk/WebKit

2006-09-07 zhalu <zhaosong.lu@nokia.com>

Reviewed by Sachin.
DESC: Disable the form autofill feature for embedded browser and make sure there is no crash on accessing the autofill database.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10754

BrowserControl/src/BrCtl.cpp: (CBrCtl::HandleCommandL):
BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::CFormInputSkin): (CFormInputSkin::SetText): (CFormInputSkin::ActivateL):
BrowserView/inc/WebKitControl.h: (CWebKitControl::FormDataManagerL):
BrowserView/src/webkitbridge.cpp: (CWebKitBridge::SaveFormData):

11:45 AM Changeset in webkit [16264] by aroben

5 edits in trunk/WebCore

2006-09-07 MorganL <morlmor@yahoo.com>

Reviewed by Darin, landed by Adam.

Fixes part of bug 10743: Windows build busted.

platform/win/FontCacheWin.cpp: Add missing #include, set svn:eol-style to native (WebCore::FontCache::getFontLinkInterface): (WebCore::FontCache::getFontDataForCharacters):
platform/win/FontDataWin.cpp: Ditto. (WebCore::FontData::platformWidthForGlyph):
platform/win/FontWin.cpp: Add missing #include, band-aid over const problem with GlyphBufferGlyph (WebCore::Font::drawGlyphs):
platform/win/ResourceLoaderWin.cpp: Add missing #include, change .ascii() to .latin1() (WebCore::ResourceLoaderWndProc): (WebCore::ResourceLoader::start):

11:27 AM Changeset in webkit [22149] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

2006-09-07 Steve Falkenburg <sfalken@apple.com>

Reviewed by Lou Amadio.

Fix CFArray allocator usage for cases where we store CF types in the array.

WebHistory.cpp: (WebHistory::WebHistory): (WebHistory::datesArray):

10:37 AM Changeset in webkit [16263] by ap

4 edits
4 adds in trunk

Reviewed by Darin.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10753
REGRESSION: The beginning of a CSS file is missing

Test: http/tests/incremental/slow-utf8-css.pl

loader/Decoder.cpp: (WebCore::Decoder::checkForCSSCharset): Use the same buffering logic as used for HTML. (WebCore::Decoder::decode):
loader/Decoder.h: Added a return value and a movedDataToBuffer parameter to checkForCSSCharset().

10:08 AM Changeset in webkit [16262] by weinig

17 edits
4 adds
1 delete in trunk

WebCore:

Reviewed by Darin.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10766
Auto-generate the Objective-C DOM Events bindings

Auto-generates DOMEvent, DOMKeyboardEvent, DOMMouseEvent, DOMMutationEvent, DOMOverflowEvent, DOMUIEvent, and DOMWheelEvent.

Splits out DOMEventListener and DOMEventTarget into their own files.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOMEventListener.h: Added.
bindings/objc/DOMEventTarget.h: Added.
bindings/objc/DOMEvents.h:
bindings/objc/DOMEvents.mm: (-[DOMEvent WebCore::]): (-[DOMEvent _initWithEvent:WebCore::]): (+[DOMEvent _eventWith:WebCore::]):
bindings/objc/DOMEventsNonstandard.mm: Removed.
bindings/objc/DOMNode.h:
bindings/objc/PublicDOMInterfaces.h:
bindings/scripts/CodeGenerator.pm:
bindings/scripts/CodeGeneratorObjC.pm:
dom/Event.idl:
dom/EventListener.idl: Added.
dom/EventTarget.idl: Added.
dom/KeyboardEvent.idl:
dom/MouseEvent.idl:
dom/UIEvent.idl:
dom/WheelEvent.idl:

WebKit:

Reviewed by Darin.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10766
Auto-generate the Objective-C DOM Events bindings

MigrateHeaders.make:
WebKit.xcodeproj/project.pbxproj:

8:48 AM Changeset in webkit [16261] by zbujtas

2 edits in S60/trunk/WebCore

2006-09-07 bujtas <zbujtas@gmail.com>

Reviewed by Sriram Yadavalli.
DESC: do not call tabbednavigation when the document
is null.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10767

WARNING: NO TEST CASES ADDED OR CHANGED

bridge/WebCoreBridge.cpp: (CWebCoreBridge::TabbedNavigation):

7:33 AM Changeset in webkit [16260] by spadma

2 edits in S60/trunk/WebKit

2006-09-07 hongzhao <hong.a.zhao@nokia.com>

Reviewed by Sachin.
DESC: [S60] OfferKeyEventL() doesn't return a correct response value if it doesn't do anything
http://bugzilla.opendarwin.org/show_bug.cgi?id=10737

Plugin/src/PluginWin.cpp: (CPluginWin::OfferKeyEventL):

2:03 AM Changeset in webkit [16259] by rwlbuis

227 edits
4 adds in trunk

WebCore:

Reviewed by Maciej.

http://bugzilla.opendarwin.org/show_bug.cgi?id=9753
SVG with width and height 100% leaves room for scrollbar on the right.

Relayout children of svg containers, except svg shapes that do not depend on percentages.

LayoutTests:

Reviewed by Maciej.

New test case for
<http://bugzilla.opendarwin.org/show_bug.cgi?id=9753>
SVG with width and height 100% leaves room for scrollbar on the right.

Also Updated .txt files (all text blocks are wider) and some updated
pixel tests (some text is layouted differently because of wider text blocks).

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed