Timeline



Sep 13, 2006:

10:10 PM Changeset in webkit [22170] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-09-13 Steve Falkenburg <sfalken@apple.com>

Fixes for submission of WebCore. Doesn't affect build.

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcproj/merge-opensource.sh:
10:03 PM Changeset in webkit [16358] by bdash
  • 2 edits in trunk/WebCore

2006-09-13 Mark Rowe <opendarwin.org@bdash.net.nz>

Reviewed by Adam.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10834
Bug 10834: FileChooser constructor in FileChooserMac appears to overretain m_controller

  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::FileChooser): Don't over-retain the OpenPanelController.
9:47 PM Changeset in webkit [16357] by aroben
  • 30 edits in trunk/LayoutTests

Rubberstamped by hyatt.

Updating tables results after hyatt landed a fix for
http://bugzilla.opendarwin.org/show_bug.cgi?id=8126
Padding must not apply to columns

  • tables/mozilla/bugs/bug139524-2-expected.txt:
  • tables/mozilla/bugs/bug139524-4-expected.txt:
  • tables/mozilla/bugs/bug32841-expected.txt:
  • tables/mozilla/dom/appendCol2-expected.txt:
  • tables/mozilla/dom/deleteCol1-expected.txt:
  • tables/mozilla/dom/deleteCol2-expected.txt:
  • tables/mozilla/dom/deleteCol3-expected.txt:
  • tables/mozilla/dom/deleteColGroup1-expected.txt:
  • tables/mozilla/dom/deleteColGroup2-expected.txt:
  • tables/mozilla/dom/insertColGroups1-expected.txt:
  • tables/mozilla/dom/insertColGroups2-expected.txt:
  • tables/mozilla/dom/insertCols1-expected.txt:
  • tables/mozilla/dom/insertCols2-expected.txt:
  • tables/mozilla/dom/insertCols3-expected.txt:
  • tables/mozilla/dom/insertCols4-expected.txt:
  • tables/mozilla/dom/insertCols5-expected.txt:
  • tables/mozilla/marvin/body_col-expected.txt:
  • tables/mozilla/marvin/x_col_span-expected.txt:
  • tables/mozilla/marvin/x_col_width_px-expected.txt:
  • tables/mozilla/marvin/x_colgroup_span-expected.txt:
  • tables/mozilla/other/body_col-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
  • tables/mozilla_expected_failures/core/cols1-expected.txt:
  • tables/mozilla_expected_failures/dom/appendCol1-expected.txt:
  • tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt:
  • tables/mozilla_expected_failures/other/test4-expected.txt:
9:41 PM Changeset in webkit [16356] by bdash
  • 2 edits in trunk/WebCore

2006-09-13 Mark Rowe <opendarwin.org@bdash.net.nz>

Reviewed by Eric.

http://bugzilla.opendarwin.org/show_bug.cgi?id=10836
Bug 10836: REGRESSION: Mac implementation of Font::drawGlyphs leaks a CGColorRef

  • platform/mac/FontMac.mm: (WebCore::Font::drawComplexText): Release CGColorRef after use. (WebCore::Font::drawGlyphs): Ditto.
7:27 PM Changeset in webkit [16355] by andersca
  • 3 edits in trunk/WebCore

2006-09-14 Anders Carlsson <acarlsson@apple.com>

Try fixing the Win32 build.


  • bridge/win/FrameWin.h:
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::bindingRootObject):
6:59 PM Changeset in webkit [16354] by sfalken
  • 5 edits
    1 add in trunk/JavaScriptCore

2006-09-12 Steve Falkenburg <sfalken@apple.com>

Reviewed by Ada.


Build tweaks (doing JavaScriptCore now since it doesn't have
dependencies).

6:57 PM Changeset in webkit [22169] by sfalken
  • 24 edits
    3 adds in branches/WindowsMerge
6:56 PM Changeset in webkit [16353] by andersca
  • 14 edits in trunk/WebCore

2006-09-14 Anders Carlsson <acarlsson@apple.com>

Reviewed by Tim O.

Add USE defines for the generic JavaScriptCore bindings as well as NPAPI bindings.


  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::createLanguageInstanceForValue):
  • bindings/js/kjs_dom.cpp: (KJS::getRuntimeObject):
  • bridge/mac/FrameMac.h:
  • config.h:
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::~HTMLAppletElement): (WebCore::HTMLAppletElement::detach):
  • html/HTMLAppletElement.h:
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::~HTMLEmbedElement): (WebCore::HTMLEmbedElement::detach):
  • html/HTMLEmbedElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::~HTMLObjectElement): (WebCore::HTMLObjectElement::detach):
  • html/HTMLObjectElement.h:
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::HTMLPlugInElement): (WebCore::HTMLPlugInElement::~HTMLPlugInElement): (WebCore::HTMLPlugInElement::createNPObject):
  • html/HTMLPlugInElement.h:
  • page/Frame.h:
6:13 PM Changeset in webkit [22168] by adachan
  • 3 edits in branches/WindowsMerge/WebKitWin

2006-09-13 Ada Chan <adachan@apple.com>

Reviewed by sfalken


  • WebBackForwardList::containsItem()
    • we can break once we've found the item
  • Fixed a crashing bug with WebNotificationCenter::addObserver.
4:56 PM Changeset in webkit [22167] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Build fix

  • WebCore.vcproj/WebCore.vcproj: Rename KHTML_XSLT to XSLT_SUPPORT, remove KHTML_NO_XBL
  • config.h: Ditto.
4:01 PM Changeset in webkit [16352] by thatcher
  • 1 edit in tags/WebCore-521.26.1/WebCore/Info.plist

Versioning

3:59 PM Changeset in webkit [16351] by thatcher
  • 1 copy in tags/WebCore-521.26.1/WebCore

New tag part two.

3:58 PM Changeset in webkit [16350] by thatcher
  • 1 add in tags/WebCore-521.26.1

New tag.

3:55 PM Changeset in webkit [22166] by aroben
  • 3 edits
    2 adds in branches/WindowsMerge/WebCore

Reviewed by beidson.

Initial implementation of Icon, FileChooser on Windows.

  • WebCore.vcproj/WebCore.vcproj: Added FileChooserWin.cpp, IconWin.cpp
  • platform/win/FileChooserWin.cpp: Added. (WebCore::FileChooser::FileChooser): (WebCore::FileChooser::openFileChooser): (WebCore::FileChooser::basenameForWidth): (WebCore::FileChooser::uploadControlDetaching): (WebCore::FileChooser::chooseFile):
  • platform/win/IconWin.cpp: Added. (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::newIconForFile): (WebCore::Icon::paint):
  • platform/win/TemporaryLinkStubs.cpp: Removed FileChooser, Icon stub functions
3:18 PM Changeset in webkit [16349] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Tim O.

<rdar://problem/4726416> obsolete confusing "ADVISORY NOTE" comment in WebHistory.h

Removed the "ADVISORY NOTE: This method may change for the 1.0 SDK" comments.

  • History/WebHistory.h:
3:10 PM Changeset in webkit [16348] by hyatt
  • 33 edits in trunk/WebCore

Clean up the XBL and XSLT ifdefs to be consistent with the SVG
and XPath ifdefs. KHTML_NO_XBL is flipped and is now XBL_SUPPORT.
KHTML_XSLT is now XSLT_SUPPORT.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSXSLTProcessor.cpp:
  • bindings/js/JSXSLTProcessor.h:
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty):
  • config.h:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document): (WebCore::Document::recalcStyleSelector):
  • dom/Document.h: (WebCore::Document::bindingManager):
  • dom/Node.cpp: (WebCore::Node::createRendererIfNeeded):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::ProcessingInstruction): (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::setStyleSheet):
  • dom/ProcessingInstruction.h:
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::processingInstruction): (WebCore::XMLTokenizer::insertErrorMessageBlock):
  • dom/XMLTokenizer.h:
  • loader/Cache.cpp: (WebCore::Cache::getStatistics):
  • loader/Cache.h:
  • loader/CachedResource.h: (WebCore::CachedResource::):
  • loader/CachedResourceClient.h:
  • loader/CachedXBLDocument.cpp:
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.cpp:
  • loader/CachedXSLStyleSheet.h:
  • loader/DocLoader.cpp:
  • loader/DocLoader.h:
  • rendering/RenderStyle.cpp: (WebCore::StyleCSS3NonInheritedData::StyleCSS3NonInheritedData): (WebCore::StyleCSS3NonInheritedData::~StyleCSS3NonInheritedData): (WebCore::StyleCSS3NonInheritedData::operator==):
  • rendering/RenderStyle.h:
  • xml/XSLImportRule.cpp:
  • xml/XSLImportRule.h:
  • xml/XSLStyleSheet.cpp:
  • xml/XSLStyleSheet.h:
  • xml/XSLTProcessor.cpp:
  • xml/XSLTProcessor.h:
3:07 PM Changeset in webkit [16347] by eseidel
  • 4 edits in trunk/WebCore

2006-09-13 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Fix newly introduced memory leaks in SVG.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10835

  • ksvg2/svg/SVGList.h: (WebCore::SVGListBase::~SVGListBase): (WebCore::SVGListBase::clearVector): (WebCore::SVGListBase::clear): (WebCore::SVGList::clearVector): (WebCore::):
  • ksvg2/svg/SVGNumberList.cpp: s/float/double/ - forgot that! (SVGNumberList::SVGNumberList):
  • ksvg2/svg/SVGNumberList.h: Ditto.
2:30 PM Changeset in webkit [22165] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

2006-09-13 Anders Carlsson <acarlsson@apple.com>

Reviewed by Tim O.

Implement postURL and postURLNotify.

  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::cancelAndDestroyStream):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::loadURL): (WebCore::PluginViewWin::getURLNotify): (WebCore::PluginViewWin::getURL): (WebCore::startsWithBlankLine): (WebCore::locationAfterFirstBlankLine): (WebCore::findEOL): (WebCore::capitalizeRFC822HeaderFieldName): (WebCore::parseRFC822HeaderFields): (WebCore::PluginViewWin::handlePost): (WebCore::PluginViewWin::postURLNotify): (WebCore::PluginViewWin::postURL):
  • plugins/win/PluginViewWin.h:
2:10 PM Changeset in webkit [22164] by lamadio
  • 2 edits in branches/WindowsMerge/WebCore
11:37 AM Changeset in webkit [16346] by aroben
  • 3 edits in trunk/WebCore

2006-09-13 MorganL <morlmor@yahoo.com>

Reviewed/landed by aroben.

Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10833
Windows build needs fixed after move to engine-rendered file upload widget

  • WebCore.vcproj/WebCore/WebCore.vcproj: Add RenderFileUpload files, remove RenderFileButton files
  • platform/win/TemporaryLinkStubs.cpp: Add stubs for FileChooser, Icon (FileChooser::FileChooser): (FileChooser::~FileChooser): (FileChooser::openFileChooser): (FileChooser::basenameForWidth): (FileChooser::uploadControlDetaching): (FileChooser::chooseFile): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (Icon::Icon): (Icon::~Icon): (Icon::newIconForFile): (Icon::paint):
11:15 AM Changeset in webkit [16345] by aroben
  • 2 edits in trunk/WebCore

2006-09-13 MorganL <morlmor@yahoo.com>

Reviewed/landed by aroben.

Fixes http://bugzilla.opendarwin.org/attachment.cgi?id=10537
Webkit WebCore build fails on Windows

  • WebCore.vcproj/WebCore/build-generated-files.sh: export SOURCE_ROOT variable
9:16 AM Changeset in webkit [16344] by thatcher
  • 2 adds in trunk/WebCore/platform/qt

Forgot these added files.

9:12 AM Changeset in webkit [16343] by thatcher
  • 4 edits in trunk/WebCore

Reviewed by Tim H.

Fix Qt/Linux build.

  • CMakeLists.txt: Change SVGZoomEvent.idl location & add RenderFileUploadControl
  • platform/Icon.h: Add wtf/Platform.h include
  • platform/qt/FileChooserQt.cpp: Added as stub. Easy to implement though. (WebCore::FileChooser::FileChooser): (WebCore::FileChooser::~FileChooser): (WebCore::FileChooser::openFileChooser): (WebCore::FileChooser::basenameForWidth): (WebCore::FileChooser::uploadControlDetaching): (WebCore::FileChooser::chooseFile):
  • platform/qt/IconQt.cpp: Added as stub. (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::newIconForFile): (WebCore::Icon::paint):
  • platform/qt/TemporaryLinkStubs.cpp: Remove old RenderFileButton code & some new *Labels needed (searchableIndexIntroduction): (fileButtonChooseFileLabel): (fileButtonNoFileSelectedLabel):
12:47 AM Changeset in webkit [22163] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix

  • WebCore.vcproj/build-generated-files.sh: Export SOURCE_ROOT which is now used by CodeGenerator.pm
12:08 AM Changeset in webkit [16342] by aroben
  • 3 edits in trunk/WebCore

Reviewed by eseidel.

Switch back to passing relative paths to generate-bindings.pl when
generating JS bindings.

  • DerivedSources.make: Pass in relative paths to generate-bindings.pl
  • bindings/scripts/CodeGenerator.pm: Make ScanDirectory never call chdir and always construct absolute paths instead.

Sep 12, 2006:

11:23 PM Changeset in webkit [16341] by hyatt
  • 4 edits in trunk/WebCore

Fix for bug 3244, implement html4 label support.

Reviewed by mjs, aroben

Added fast/events/label-focus.html

  • css/html4.css:
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::formElement): (WebCore::HTMLLabelElement::setActive): (WebCore::HTMLLabelElement::setHovered): (WebCore::HTMLLabelElement::defaultEventHandler):
  • html/HTMLLabelElement.h:
11:20 PM Changeset in webkit [16340] by hyatt
  • 4 adds in trunk/LayoutTests/fast/events

New label layout test.

10:37 PM Changeset in webkit [16339] by eseidel
  • 3 edits
    4 adds in trunk

2006-09-12 Julien Palmas <julien.palmas@gmail.com>

Reviewed by darin. Landed by eseidel.

  • ksvg2/svg/svgpathparser.cpp: (WebCore::SVGPolyParser::parsePoints):
6:28 PM Changeset in webkit [16338] by kmccullo
  • 5 edits
    3 adds in trunk

LayoutTests:

Reviewed by Andersca, Maciej, Brady.

  • fast/dom/Range/range-intersectsNode-expected.txt: Added.
  • fast/dom/Range/range-intersectsNode.html: Added.
  • fast/dom/Range/resources/intersectsNode.js: Added.

WebCore:

Reviewed by Andersca, Maciej, Brady.

  • Implemented intersectsNode in the Range Class to be compliant with Mozilla standard
  • dom/Range.cpp: (WebCore::Range::intersectsNode):
  • dom/Range.h:
  • dom/Range.idl:
6:18 PM Changeset in webkit [16337] by eseidel
  • 19 edits
    84 adds
    1 delete in trunk

2006-09-12 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Test: svg/W3C-SVG-1.1/struct-dom-01-b.svg (fixed)
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10826


Also finally fixes some long outstanding bugs:
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=9190
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=9229
Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10413

Enable all JavaScript SVG bindings. Builds on Qt/Linux & OSX.

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp:
  • ksvg2/svg/SVGAElement.idl: Added.
  • ksvg2/svg/SVGAngle.idl:
  • ksvg2/svg/SVGAnimateColorElement.idl: Added.
  • ksvg2/svg/SVGAnimateElement.idl: Added.
  • ksvg2/svg/SVGAnimateTransformElement.idl: Added.
  • ksvg2/svg/SVGAnimatedLengthList.idl: Added.
  • ksvg2/svg/SVGAnimatedNumberList.idl: Added.
  • ksvg2/svg/SVGAnimatedTransformList.idl: Added.
  • ksvg2/svg/SVGAnimationElement.idl: Added.
  • ksvg2/svg/SVGCircleElement.idl: Added.
  • ksvg2/svg/SVGClipPathElement.idl: Added.
  • ksvg2/svg/SVGColor.idl:
  • ksvg2/svg/SVGComponentTransferFunctionElement.idl: Added.
  • ksvg2/svg/SVGCursorElement.idl: Added.
  • ksvg2/svg/SVGDefsElement.idl: Added.
  • ksvg2/svg/SVGDescElement.idl: Added.
  • ksvg2/svg/SVGEllipseElement.idl: Added.
  • ksvg2/svg/SVGEvent.idl:
  • ksvg2/svg/SVGExternalResourcesRequired.idl: Added.
  • ksvg2/svg/SVGFEBlendElement.idl: Added.
  • ksvg2/svg/SVGFEColorMatrixElement.idl: Added.
  • ksvg2/svg/SVGFEComponentTransferElement.idl: Added.
  • ksvg2/svg/SVGFECompositeElement.idl: Added.
  • ksvg2/svg/SVGFEDiffuseLightingElement.idl: Added.
  • ksvg2/svg/SVGFEDisplacementMapElement.idl: Added.
  • ksvg2/svg/SVGFEDistantLightElement.idl: Added.
  • ksvg2/svg/SVGFEFloodElement.idl: Added.
  • ksvg2/svg/SVGFEFuncAElement.idl: Added.
  • ksvg2/svg/SVGFEFuncBElement.idl: Added.
  • ksvg2/svg/SVGFEFuncGElement.idl: Added.
  • ksvg2/svg/SVGFEFuncRElement.idl: Added.
  • ksvg2/svg/SVGFEGaussianBlurElement.idl: Added.
  • ksvg2/svg/SVGFEImageElement.idl: Added.
  • ksvg2/svg/SVGFEMergeElement.idl: Added.
  • ksvg2/svg/SVGFEMergeNodeElement.idl: Added.
  • ksvg2/svg/SVGFEOffsetElement.idl: Added.
  • ksvg2/svg/SVGFEPointLightElement.idl: Added.
  • ksvg2/svg/SVGFESpecularLightingElement.idl: Added.
  • ksvg2/svg/SVGFESpotLightElement.idl: Added.
  • ksvg2/svg/SVGFETileElement.idl: Added.
  • ksvg2/svg/SVGFETurbulenceElement.idl: Added.
  • ksvg2/svg/SVGFilterElement.idl: Added.
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl: Added.
  • ksvg2/svg/SVGFitToViewBox.idl: Added.
  • ksvg2/svg/SVGForeignObjectElement.idl: Added.
  • ksvg2/svg/SVGGElement.idl: Added.
  • ksvg2/svg/SVGGradientElement.idl: Added.
  • ksvg2/svg/SVGImageElement.idl: Added.
  • ksvg2/svg/SVGLangSpace.idl: Added.
  • ksvg2/svg/SVGLength.idl:
  • ksvg2/svg/SVGLengthList.idl: Added.
  • ksvg2/svg/SVGLineElement.idl: Added.
  • ksvg2/svg/SVGLinearGradientElement.idl: Added.
  • ksvg2/svg/SVGLocatable.idl: Added.
  • ksvg2/svg/SVGMarkerElement.idl: Added.
  • ksvg2/svg/SVGMaskElement.idl: Added.
  • ksvg2/svg/SVGNumberList.idl: Added.
  • ksvg2/svg/SVGPaint.idl: Added.
  • ksvg2/svg/SVGPathElement.idl:
  • ksvg2/svg/SVGPathSeg.idl:
  • ksvg2/svg/SVGPatternElement.idl: Added.
  • ksvg2/svg/SVGPointList.idl: Added.
  • ksvg2/svg/SVGPolygonElement.idl: Added.
  • ksvg2/svg/SVGPolylineElement.idl: Added.
  • ksvg2/svg/SVGPreserveAspectRatio.idl:
  • ksvg2/svg/SVGRadialGradientElement.idl: Added.
  • ksvg2/svg/SVGRectElement.idl: Added.
  • ksvg2/svg/SVGRenderingIntent.idl: Added.
  • ksvg2/svg/SVGSVGElement.idl:
  • ksvg2/svg/SVGScriptElement.idl: Added.
  • ksvg2/svg/SVGSetElement.idl: Added.
  • ksvg2/svg/SVGStopElement.idl: Added.
  • ksvg2/svg/SVGStringList.idl: Added.
  • ksvg2/svg/SVGStylable.idl: Added.
  • ksvg2/svg/SVGStyleElement.idl: Added.
  • ksvg2/svg/SVGSwitchElement.idl: Added.
  • ksvg2/svg/SVGSymbolElement.idl: Added.
  • ksvg2/svg/SVGTRefElement.idl: Added.
  • ksvg2/svg/SVGTSpanElement.idl: Added.
  • ksvg2/svg/SVGTests.idl: Added.
  • ksvg2/svg/SVGTextContentElement.idl: Added.
  • ksvg2/svg/SVGTextElement.idl: Added.
  • ksvg2/svg/SVGTextPositioningElement.idl: Added.
  • ksvg2/svg/SVGTitleElement.idl: Added.
  • ksvg2/svg/SVGTransform.idl:
  • ksvg2/svg/SVGTransformList.idl: Added.
  • ksvg2/svg/SVGTransformable.idl: Added.
  • ksvg2/svg/SVGURIReference.idl: Added.
  • ksvg2/svg/SVGUnitTypes.idl: Added.
  • ksvg2/svg/SVGUseElement.idl: Added.
  • ksvg2/svg/SVGViewElement.idl: Added.
  • ksvg2/svg/SVGZoomAndPan.idl: Added.
  • ksvg2/svg/SVGZoomEvent.idl: Added.
5:25 PM Changeset in webkit [16336] by aroben
  • 5 edits in trunk/WebCore

Reviewed by timo, ggaren.

Make Icon ref-counted.

  • platform/FileChooser.h: Store m_icon as a RefPtr instead of auto_ptr.
  • platform/Icon.h: Inherit from Shared<Icon>
  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::chooseFile): Update m_icon usage
  • platform/mac/IconMac.mm: (WebCore::Icon::newIconForFile): Return a RefPtr instead of an auto_ptr
5:08 PM Changeset in webkit [16335] by thatcher
  • 6 edits
    9 copies
    12 adds in tags/Safari-521.26

New tag.

4:57 PM Changeset in webkit [16334] by thatcher
  • 8 edits in /

Fixing the versioning.

3:33 PM Changeset in webkit [16333] by thatcher
  • 12 adds in tags/Safari-521.21/WebKit/DOM

Old DOM headers for 521.21 until the new DOM API is approved.

3:30 PM Changeset in webkit [16332] by thatcher
  • 6 edits
    9 copies in tags/Safari-521.21/OpenSource

Tagging for version 521.21

3:26 PM Changeset in webkit [16331] by thatcher
  • 8 edits in /

Versioning

2:19 PM Changeset in webkit [16330] by rwlbuis
  • 85 edits
    2 adds in trunk/WebCore

Reviewed by Anders.

Add exception codes to SVGList functions, adjust all code using it.

Move SVGPaintType enums from ksvg.h into SVGPaint (needed for js generation)
Move SVGUnitTypes enums from ksvg.h into it's own file SVGUnitType.h (ditto)
Move SVGRenderingIntent enums from ksvg.h into it's own file SVGRenderingIntent.h (ditto)
Move SVGZoomAndPan enums from ksvg.h into SVGSVGElement (ditto)
Move SVGFE* related enums into their respecitive classes.

Fix JSSVGNumber to operator on doubles, instead of floats.

2:11 PM Changeset in webkit [16329] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Adele Peterson.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::doTextFieldCommandFromEvent): Don't call textField:doCommandBySelector: with a nil selector. This was indirectly causing a (valid) assertion failure in some Safari code.
2:09 PM Changeset in webkit [16328] by harrison
  • 2 edits in trunk/WebCore

Reviewed by John Sullivan.

<rdar://problem/4717841> Setting AXFocused to true does not activate the insertion point in text field

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilitySetValue:forAttribute:]): For AXFocus, use focus() if the node is an element, so that selection is set. Matches tabbing behavior in text fields and text areas.
1:59 PM Changeset in webkit [16327] by thatcher
  • 1 edit in trunk/WebCore/bindings/scripts/generate-bindings.pl

Build fix for the the no-svg bot.

1:57 PM Changeset in webkit [16326] by aroben
  • 6 edits in trunk/WebCore

Reviewed by adele.

Make uploading work with the new file upload control.

  • css/html4.css: Remove unnecessary style (this is already done in RenderFileUpload.cpp)
  • html/HTMLInputElement.cpp: Don't get the button text from the value attribute for file controls. (WebCore::HTMLInputElement::valueWithDefault):
  • platform/mac/FileChooserMac.mm: Call RenderFileUploadControl::valueChanged when the user selects a file. (WebCore::FileChooser::chooseFile):
  • rendering/RenderFileUploadControl.cpp: Add valueChanged() method to update the form and fire the onChange event. (WebCore::RenderFileUploadControl::valueChanged): (WebCore::RenderFileUploadControl::updateFromElement):
  • rendering/RenderFileUploadControl.h: Add valueChanged() declaration.
1:52 PM Changeset in webkit [16325] by zbujtas
  • 15 edits
    1 add in S60/trunk

2006-09-11 yadavall <sriram.yadavalli@nokia.com>

Reviewed by Zalan Bujtas
DESC:Toolbar not working in 3.1
http://bugzilla.opendarwin.org/show_bug.cgi?id=10668

  • BrowserControl/inc/BrCtl.h:
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::HandleCommandL): (CBrCtl::SendCommandsToClient):
  • BrowserView/inc/WebKitView.h:
  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleOfferKeyEventL): (CKeyEventHandler::HandleActivateKeysL):
  • BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::CursorUpdate):
  • BrowserView/src/WebKitView.cpp: (CWebKitView::~CWebKitView): (CWebKitView::Draw):
  • group/BrowserView.mmp:
  • group/webkit.mmp:
  • rom/webkit.iby:
  • rom/webkitResources.iby:
1:43 PM Changeset in webkit [22162] by andersca
  • 6 edits in branches/WindowsMerge/WebCore

2006-09-12 Anders Carlsson <acarlsson@apple.com>

Reviewed by Tim O.

Add scripting support for plugins.


  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin): (WebCore::FrameWin::addPluginRootObject): (WebCore::FrameWin::cleanupPluginObjects): (WebCore::FrameWin::bindingRootObject): (WebCore::FrameWin::windowScriptNPObject):
  • bridge/win/FrameWin.h:
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::getValue):
  • plugins/win/npapi.cpp: (NPN_RequestRead): (NPN_InvalidateRect): (NPN_InvalidateRegion): (NPN_ForceRedraw):
12:59 PM Changeset in webkit [16324] by aroben
  • 2 edits in trunk/WebCore

Adding rules to html4.css to style the button in file upload controls.

  • css/html4.css:
12:42 PM Changeset in webkit [16323] by aroben
  • 14 edits
    6 adds
    4 deletes in trunk/WebCore

Reviewed many times by darin, hyatt.

Switch to new engine-based implementation of <input type="file">

  • WebCore.exp: Remove obsolete symbol WebCoreFileButton
  • WebCore.xcodeproj/project.pbxproj: Remove files for old widget-based control, add files for new engine-based control
  • css/CSSSelector.cpp: Add support for new '-webkit-file-upload-button' pseudo element (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: Ditto. (WebCore::CSSSelector::):
  • css/cssstyleselector.cpp: Ditto. (WebCore::CSSStyleSelector::checkOneSelector):
  • html/HTMLInputElement.cpp: Send click events to new control (WebCore::HTMLInputElement::select): (WebCore::HTMLInputElement::click): (WebCore::HTMLInputElement::createRenderer): (WebCore::HTMLInputElement::valueWithDefault): (WebCore::HTMLInputElement::defaultEventHandler):
  • html/HTMLTextFieldInnerElement.h: Add 'virtual' keyword (WebCore::HTMLTextFieldInnerElement::shadowParentNode):
  • platform/FileButton.h: Removed.
  • platform/FileChooser.h: Added. This is the replacement for FileButton.h (WebCore::FileChooser::filename): (WebCore::FileChooser::icon): (WebCore::FileChooser::uploadControl): (WebCore::FileChooser::document):
  • platform/Icon.h: Added new platform-specific class representing a file icon.
  • platform/LocalizedStrings.h:
  • platform/mac/FileButtonMac.mm: Removed.
  • platform/mac/FileChooserMac.mm: Added. This is the replacement for FileButtonMac.mm (-[OpenPanelController initWithFileChooser:]): (-[OpenPanelController fileChooserDetachingSoon]): (-[OpenPanelController beginSheet]): (-[OpenPanelController chooseFilename:]): (-[OpenPanelController cancel]): (WebCore::FileChooser::FileChooser): (WebCore::FileChooser::~FileChooser): (WebCore::FileChooser::openFileChooser): (WebCore::FileChooser::basenameForWidth): (WebCore::FileChooser::uploadControlDetaching): (WebCore::FileChooser::chooseFile):
  • platform/mac/IconMac.mm: Added. (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::newIconForFile): (WebCore::Icon::paint):
  • platform/mac/LocalizedStringsMac.mm: Call across bridge to get localized strings. (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel):
  • rendering/RenderButton.cpp: Extract method setText() from updateFromElement. (WebCore::RenderButton::updateFromElement): (WebCore::RenderButton::setText):
  • rendering/RenderButton.h: Add declaration for new setText method.
  • rendering/RenderFileButton.cpp: Removed.
  • rendering/RenderFileButton.h: Removed.
  • rendering/RenderFileUploadControl.cpp: Added. This is the replacement for RenderFileButton.cpp. (WebCore::RenderFileUploadInnerFileBox::renderName): (WebCore::HTMLFileUploadInnerButtonElement::isShadowNode): (WebCore::HTMLFileUploadInnerButtonElement::shadowParentNode): (WebCore::RenderFileUploadControl::RenderFileUploadControl): (WebCore::RenderFileUploadControl::~RenderFileUploadControl): (WebCore::RenderFileUploadControl::setStyle): (WebCore::RenderFileUploadControl::updateIconAndFilename): (WebCore::RenderFileUploadControl::click): (WebCore::RenderFileUploadControl::updateFromElement): (WebCore::RenderFileUploadControl::maxFilenameWidth): (WebCore::RenderFileUploadControl::createButtonStyle): (WebCore::RenderFileUploadControl::paintObject): (WebCore::RenderFileUploadInnerFileBox::RenderFileUploadInnerFileBox): (WebCore::RenderFileUploadInnerFileBox::setStyle): (WebCore::RenderFileUploadInnerFileBox::layout): (WebCore::RenderFileUploadInnerFileBox::setHasIcon): (WebCore::RenderFileUploadInnerFileBox::setFilename): (WebCore::RenderFileUploadInnerFileBox::calcMinMaxWidth): (WebCore::HTMLFileUploadInnerButtonElement::HTMLFileUploadInnerButtonElement): (WebCore::HTMLFileUploadInnerButtonElement::createRenderer):
  • rendering/RenderFileUploadControl.h: Added. This is the replacement for RenderFileButton.h. (WebCore::RenderFileUploadControl::renderName):
  • rendering/RenderStyle.cpp: Add support for -webkit-file-upload-button pseudo element. (WebCore::): (WebCore::pseudoBit):
  • rendering/RenderStyle.h: Ditto. (WebCore::RenderStyle::):
12:37 PM Changeset in webkit [22161] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed many times by darin, hyatt.

Add stubs for new engine-based file upload control implementation and
Icon class.

  • WebCore.vcproj/WebCore.vcproj: Add new engine-based files, remove old widget-based files.
  • platform/win/TemporaryLinkStubs.cpp: Add stubs for FileChooser and Icon methods, and add two new LocalizedString methods. (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (FileChooser::FileChooser): (FileChooser::~FileChooser): (FileChooser::openFileChooser): (FileChooser::basenameForWidth): (FileChooser::uploadControlDetaching): (Icon::~Icon): (Icon::paint):
10:48 AM Changeset in webkit [16322] by andersca
  • 5 edits in trunk/WebCore

2006-09-12 Anders Carlsson <acarlsson@apple.com>

Reviewed by John Sullivan.

Do the plugin object cleanup in Frame::clear instead of setView.


  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::setView): (WebCore::FrameMac::cleanupPluginObjects):
  • page/Frame.cpp: (WebCore::Frame::clear):
  • page/Frame.h:
9:43 AM Changeset in webkit [16321] by aroben
  • 2 edits in trunk/WebCore

2006-09-12 MorganL <morlmor@yahoo.com>

Reviewed/landed by aroben.

Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10822
windows build is busted

  • WebCore.vcproj/WebCore/WebCore.vcproj: Add missing JSRangeException.{cpp,h} to project
9:31 AM Changeset in webkit [22160] by andersca
  • 4 edits in branches/WindowsMerge/WebCore

2006-09-11 Anders Carlsson <acarlsson@apple.com>

Reviewed by Tim O.

Add stream and URL handling to PluginViewWin. Include PluginStreamWin.cpp in the build.
Also fix a number of bugs discovered when loading various plugins.


  • WebCore.vcproj/WebCore.vcproj:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginRequestWin::PluginRequestWin): (WebCore::PluginRequestWin::url): (WebCore::PluginRequestWin::target): (WebCore::PluginRequestWin::notifyData): (WebCore::PluginRequestWin::sendNotification): (WebCore::scriptStringIfJavaScriptURL): (WebCore::registerPluginView): (WebCore::PluginViewWndProc): (WebCore::PluginViewWin::updateSize): (WebCore::PluginViewWin::setFrameGeometry): (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::stop): (WebCore::createUTF8String): (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::requestTimerFired): (WebCore::PluginViewWin::scheduleRequest): (WebCore::PluginViewWin::loadURL): (WebCore::makeURL): (WebCore::PluginViewWin::getURLNotify): (WebCore::PluginViewWin::getURL): (WebCore::PluginViewWin::newStream): (WebCore::PluginViewWin::write): (WebCore::PluginViewWin::destroyStream): (WebCore::PluginViewWin::userAgent): (WebCore::PluginViewWin::~PluginViewWin): (WebCore::PluginViewWin::PluginViewWin):
  • plugins/win/PluginViewWin.h:
12:28 AM Changeset in webkit [16320] by hyatt
  • 4 adds in trunk/LayoutTests/fast/forms

Add fieldset layout test.

12:26 AM Changeset in webkit [16319] by hyatt
  • 5 edits in trunk/WebCore

Fix fieldsets so that they properly expand to enclose overhanging floats
when the fieldset has auto height. This is a nifty undocumented behavior
of the fieldset element. The bug is 3898.

Reviewed by mjs

Added fast/forms/fieldset-with-float.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
  • rendering/RenderFieldset.h: (WebCore::RenderFieldset::renderName): (WebCore::RenderFieldset::expandsToEncloseOverhangingFloats):
  • rendering/RenderObject.h: (WebCore::RenderObject::expandsToEncloseOverhangingFloats):
  • rendering/RenderTableCell.h: (WebCore::RenderTableCell::expandsToEncloseOverhangingFloats):
12:02 AM Changeset in webkit [16318] by eseidel
  • 2 edits in trunk/WebCore

2006-09-11 Eric Seidel <eric@eseidel.com>

Reviewed by hyatt.


REGRESSION: When dragging a link on a page, the selected link doesn't display it's name or URL
http://bugzilla.opendarwin.org/show_bug.cgi?id=10819
http://bugzilla.opendarwin.org/show_bug.cgi?id=10814

No test cases were harmed in the coding of the patch.

  • platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint):

Sep 11, 2006:

10:39 PM Changeset in webkit [16317] by aroben
  • 2 edits in trunk/WebKit

2006-09-11 MorganL <morlmor@yahoo.com>

Reviewed/landed by aroben.

Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10765
Windows build busted due to std::copy usage in Vector.h

  • WebKit.vcproj/WebKit.vcproj: Define _SCL_SECURE_NO_DEPRECATE to get rid of deprecation warnings on std::copy
10:06 PM Changeset in webkit [16316] by hyatt
  • 3 edits in trunk/LayoutTests/fast/table

Land updated table test.

9:52 PM Changeset in webkit [16315] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 8126, column widths apply to the border boxes of cells.

Reviewed by aroben

  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::styleOrColWidth):
8:58 PM Changeset in webkit [16314] by thatcher
  • 1 edit in trunk/JavaScriptCore/bindings/objc/objc_utility.mm

Better Tiger build fix.

8:53 PM Changeset in webkit [16313] by beidson
  • 2 edits in trunk/WebKit

Despite the fact that some people built okay without this change, it sure was biting me,
probably because I just wiped my build directory for a fresh build -
Today's earlier removal of DOMList.h needed to occur in MigrateHeaders.make, as well

  • MigrateHeaders.make: removed DOMList.h
7:45 PM Changeset in webkit [16312] by beidson
  • 2 edits in trunk/JavaScriptCore

Build fix - I think Tim's last checkin wasn't tested on Tiger, possibly. I simply
commented out the undefined constants until he can have a chance to make the right call

  • bindings/objc/objc_utility.mm: (KJS::Bindings::objcValueTypeForType): Commented out undefined symbols
5:22 PM Changeset in webkit [16311] by thatcher
  • 1 edit in trunk/WebCore/bridge/mac/FrameMac.mm

Build fix. KeyScript is deprecated in Leopard, we need a new solution for this <rdar://problem/4727607>

4:57 PM Changeset in webkit [16310] by thatcher
  • 4 edits in trunk/JavaScriptCore

Reviewed by Tim O. and Darin.

Add support for more method signatures affecting ObjC methods called from JavaScript:

  • Added unsigned types and long long.
  • Allow methods that use const, oneway, bycopy and byref type modifiers.
  • bindings/objc/objc_instance.mm: (ObjcInstance::invokeMethod):
  • bindings/objc/objc_utility.h: (KJS::Bindings::):
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue): (KJS::Bindings::convertObjcValueToValue): (KJS::Bindings::objcValueTypeForType):
4:11 PM Changeset in webkit [16309] by adele
  • 2 edits in trunk/WebCore

Reviewed by Adele.

Fix Qt/Linux build.

  • CMakeLists.txt: Add dom/RangeException.idl to build & fix feature defines.
2:42 PM Changeset in webkit [16308] by eseidel
  • 104 edits
    14 adds
    34 deletes in trunk

2006-09-11 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=10750

This finally fixes the SVGAnimated* classes JS bindings!

  • Move all SVGAnimated*.idl files from ksvg2/bindings/idl/svg to ksvg2/svg
  • Adjust XCode/Qt build files to generate the new idl files
  • Remove all SVGAnimated* primitives cpp implementations (Angle/Boolean/Color/Enumeration/Integer/Length/

LengthList/Number/NumberList/PreserveAspectRatio/
Rect/String/TransformList)

  • Remove unneeded methods from CodeGenerator.pm and add new helper function: IsSVGAnimatedType
  • Adjust CodeGeneratorJS.pm to the new SVGAnimated* tear-off concept
  • Add two new macros: ANIMATED_PROPERTY_EMPTY_DECLARATIONS / ANIMATED_PROPERTY_FORWARD_DECLARATIONS. This is used to fix multiple-inheritance issues in SVG with properties, similar like SVGTests::isValid() was fixed.
  • Rewrote SVGList using WTF::Vector, instead of DeprecatedPtrList and killed DOMList. (SVGAnimated*Lists work again now)
  • Adjust macros in SVGElement to create the "*Animated" tear-off classes.
  • Adjust all SVG classes which use the ANIMATED macros to include the ClassName as first param in the header.
  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::adjustRectsForAspectRatio): (WebCore::RenderSVGImage::paint):
  • kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::translationForAttributes):
  • ksvg2/ksvg.h:
  • ksvg2/misc/SVGDocumentExtensions.h: (WebCore::FloatRect):
  • ksvg2/svg/SVGAElement.h:
  • ksvg2/svg/SVGAnimateColorElement.cpp:
  • ksvg2/svg/SVGAnimateColorElement.h:
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGAnimatedTemplate.h: (WebCore::SVGAnimatedTemplate::~SVGAnimatedTemplate):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGCircleElement.h:
  • ksvg2/svg/SVGClipPathElement.h:
  • ksvg2/svg/SVGComponentTransferFunctionElement.cpp: (SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement): (SVGComponentTransferFunctionElement::transferFunction):
  • ksvg2/svg/SVGComponentTransferFunctionElement.h:
  • ksvg2/svg/SVGCursorElement.h:
  • ksvg2/svg/SVGDefsElement.h:
  • ksvg2/svg/SVGElement.h:
  • ksvg2/svg/SVGElementInstanceList.cpp: (WebCore::SVGElementInstanceList::SVGElementInstanceList):
  • ksvg2/svg/SVGElementInstanceList.h:
  • ksvg2/svg/SVGEllipseElement.h:
  • ksvg2/svg/SVGExternalResourcesRequired.h:
  • ksvg2/svg/SVGFEBlendElement.h:
  • ksvg2/svg/SVGFEColorMatrixElement.cpp: (SVGFEColorMatrixElement::SVGFEColorMatrixElement): (SVGFEColorMatrixElement::parseMappedAttribute): (SVGFEColorMatrixElement::filterEffect):
  • ksvg2/svg/SVGFEColorMatrixElement.h:
  • ksvg2/svg/SVGFEComponentTransferElement.h:
  • ksvg2/svg/SVGFECompositeElement.h:
  • ksvg2/svg/SVGFEDiffuseLightingElement.h:
  • ksvg2/svg/SVGFEDisplacementMapElement.h:
  • ksvg2/svg/SVGFEFloodElement.h:
  • ksvg2/svg/SVGFEGaussianBlurElement.h:
  • ksvg2/svg/SVGFEImageElement.h:
  • ksvg2/svg/SVGFELightElement.h:
  • ksvg2/svg/SVGFEMergeNodeElement.h:
  • ksvg2/svg/SVGFEOffsetElement.h:
  • ksvg2/svg/SVGFESpecularLightingElement.h:
  • ksvg2/svg/SVGFETileElement.h:
  • ksvg2/svg/SVGFETurbulenceElement.h:
  • ksvg2/svg/SVGFilterElement.h:
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
  • ksvg2/svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::SVGFitToViewBox): (WebCore::SVGFitToViewBox::parseViewBox): (WebCore::SVGFitToViewBox::viewBoxToViewTransform):
  • ksvg2/svg/SVGFitToViewBox.h:
  • ksvg2/svg/SVGForeignObjectElement.h:
  • ksvg2/svg/SVGGElement.h:
  • ksvg2/svg/SVGGradientElement.cpp: (SVGGradientElement::SVGGradientElement):
  • ksvg2/svg/SVGGradientElement.h:
  • ksvg2/svg/SVGHelper.cpp: (WebCore::SVGHelper::PercentageOfViewport):
  • ksvg2/svg/SVGImageElement.h:
  • ksvg2/svg/SVGLength.cpp:
  • ksvg2/svg/SVGLengthList.cpp: (WebCore::SVGLengthList::SVGLengthList): (WebCore::SVGLengthList::parse):
  • ksvg2/svg/SVGLengthList.h:
  • ksvg2/svg/SVGLineElement.h:
  • ksvg2/svg/SVGLinearGradientElement.h:
  • ksvg2/svg/SVGList.h: (WebCore::SVGListBase::SVGListBase): (WebCore::SVGListBase::~SVGListBase): (WebCore::SVGListBase::numberOfItems): (WebCore::SVGListBase::clear): (WebCore::SVGListBase::initialize): (WebCore::SVGListBase::getFirst): (WebCore::SVGListBase::getLast): (WebCore::SVGListBase::getItem): (WebCore::SVGListBase::insertItemBefore): (WebCore::SVGListBase::replaceItem): (WebCore::SVGListBase::removeItem): (WebCore::SVGListBase::appendItem): (WebCore::SVGList::nullItem): (WebCore::):
  • ksvg2/svg/SVGLocatable.cpp:
  • ksvg2/svg/SVGMarkerElement.h:
  • ksvg2/svg/SVGMaskElement.h:
  • ksvg2/svg/SVGNumberList.cpp: (SVGNumberList::SVGNumberList): (SVGNumberList::parse):
  • ksvg2/svg/SVGNumberList.h:
  • ksvg2/svg/SVGPathElement.cpp: (WebCore::SVGPathElement::pathSegList):
  • ksvg2/svg/SVGPathElement.h:
  • ksvg2/svg/SVGPathSegList.cpp: (WebCore::SVGPathSegList::SVGPathSegList):
  • ksvg2/svg/SVGPathSegList.h:
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::SVGPatternElement):
  • ksvg2/svg/SVGPatternElement.h:
  • ksvg2/svg/SVGPointList.cpp: (SVGPointList::SVGPointList):
  • ksvg2/svg/SVGPointList.h:
  • ksvg2/svg/SVGPolyElement.cpp: (SVGPolyElement::points): (SVGPolyElement::svgPolyTo): (SVGPolyElement::notifyAttributeChange):
  • ksvg2/svg/SVGPolyElement.h:
  • ksvg2/svg/SVGPolygonElement.cpp: (SVGPolygonElement::toPathData):
  • ksvg2/svg/SVGPolylineElement.cpp: (SVGPolylineElement::toPathData):
  • ksvg2/svg/SVGPreserveAspectRatio.h: (WebCore::SVGPreserveAspectRatio::):
  • ksvg2/svg/SVGRadialGradientElement.h:
  • ksvg2/svg/SVGRectElement.h:
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement): (WebCore::SVGSVGElement::parseMappedAttribute): (WebCore::SVGSVGElement::createRenderer):
  • ksvg2/svg/SVGSVGElement.h:
  • ksvg2/svg/SVGScriptElement.h:
  • ksvg2/svg/SVGStopElement.h:
  • ksvg2/svg/SVGStringList.cpp: (WebCore::SVGStringList::SVGStringList): (WebCore::SVGStringList::reset):
  • ksvg2/svg/SVGStringList.h:
  • ksvg2/svg/SVGStyledElement.h:
  • ksvg2/svg/SVGStyledLocatableElement.cpp:
  • ksvg2/svg/SVGStyledTransformableElement.cpp: (SVGStyledTransformableElement::SVGStyledTransformableElement):
  • ksvg2/svg/SVGStyledTransformableElement.h:
  • ksvg2/svg/SVGSwitchElement.h:
  • ksvg2/svg/SVGSymbolElement.h:
  • ksvg2/svg/SVGTRefElement.h:
  • ksvg2/svg/SVGTests.cpp: (WebCore::SVGTests::isValid):
  • ksvg2/svg/SVGTextContentElement.h:
  • ksvg2/svg/SVGTextElement.cpp: (WebCore::SVGTextElement::SVGTextElement):
  • ksvg2/svg/SVGTextElement.h:
  • ksvg2/svg/SVGTextPositioningElement.cpp: (SVGTextPositioningElement::SVGTextPositioningElement): (SVGTextPositioningElement::parseMappedAttribute):
  • ksvg2/svg/SVGTextPositioningElement.h:
  • ksvg2/svg/SVGTransformList.cpp: (SVGTransformList::SVGTransformList): (SVGTransformList::createSVGTransformFromMatrix): (SVGTransformList::consolidate): (SVGTransformList::concatenate):
  • ksvg2/svg/SVGTransformList.h:
  • ksvg2/svg/SVGURIReference.h:
  • ksvg2/svg/SVGUseElement.h:
  • ksvg2/svg/SVGViewElement.h:
2:09 PM Changeset in webkit [22159] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-09-11 Anders Carlsson <acarlsson@apple.com>

  • WebCore.vcproj/WebCore.vcproj: Fix build.
2:07 PM Changeset in webkit [16307] by kmccullo
  • 1 edit in trunk/WebCore/platform/mac/LocalCurrentGraphicsContext.h

Build fix

1:58 PM Changeset in webkit [16306] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

ChangeLog date fix

1:48 PM Changeset in webkit [16305] by aroben
  • 3 edits
    2 moves in trunk/WebCore

Rubberstamped by Adele.

Rename LocalGraphicsContext.{h,mm} to
LocalCurrentGraphicsContext.{h,mm} to match the class name.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/LocalCurrentGraphicsContext.mm: Added.
  • platform/mac/LocalCurrentGraphicsContext.h: Added.
  • platform/mac/LocalGraphicsContext.h: Removed.
  • platform/mac/LocalGraphicsContext.mm: Removed.
  • rendering/RenderThemeMac.mm: Fix #include to match renamed file
1:36 PM Changeset in webkit [22158] by andersca
  • 1 edit
    2 adds in branches/WindowsMerge/WebCore

2006-09-11 Anders Carlsson <acarlsson@apple.com>

Reviewed by Tim O and Maciej.

Add plugin stream object.


  • plugins/win/PluginStreamWin.cpp: Added. (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::setRequestHeaders): (WebCore::PluginStreamWin::setPostData): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::stop): (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::cancelAndDestroyStream): (WebCore::PluginStreamWin::destroyStream): (WebCore::PluginStreamWin::delayDeliveryTimerFired): (WebCore::PluginStreamWin::deliverData): (WebCore::PluginStreamWin::receivedResponse): (WebCore::PluginStreamWin::receivedData): (WebCore::PluginStreamWin::receivedAllData):
  • plugins/win/PluginStreamWin.h: Added.
1:34 PM Changeset in webkit [16304] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

Conflict marker removed

1:29 PM Changeset in webkit [16303] by beidson
  • 2 edits in trunk/WebCore

Build fix

  • WebCore.xcodeproj/project.pbxproj:
11:46 AM Changeset in webkit [16302] by kmccullo
  • 11 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • ChangeLog:
  • fast/dom/Range/range-compareNode-expected.txt: Added.
  • fast/dom/Range/range-compareNode.html: Added.
  • fast/dom/Range/range-comparePoint.html:

WebCore:

Reviewed by Darin.

  • Implements comparePoint on the Range class
  • Exposes RangeExceptions in JavaScript
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_binding.cpp:
  • bindings/objc/DOMInternal.mm:
  • dom/Range.cpp: (WebCore::Range::comparePoint): (WebCore::Range::compareNode):
  • dom/Range.h: (WebCore::Range::):
  • dom/Range.idl:
  • dom/RangeException.h: Added. (WebCore::):
  • dom/RangeException.idl: Added.
  • page/DOMWindow.idl:
11:41 AM Changeset in webkit [16301] by aroben
  • 3 edits
    2 adds in trunk/WebCore

Reviewed by timo.

Fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=10812
Move LocalGraphicsContext out of RenderThemeMac

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/LocalGraphicsContext.h: Added.
  • platform/mac/LocalGraphicsContext.mm: Added. (WebCore::LocalCurrentGraphicsContext::LocalCurrentGraphicsContext): (WebCore::LocalCurrentGraphicsContext::~LocalCurrentGraphicsContext):
  • rendering/RenderThemeMac.mm:
11:20 AM Changeset in webkit [22157] by beidson
  • 7 edits
    1 add in branches/WindowsMerge

Initial IconDatabase hookup for Boomer
(Don't expect to have icons till I hook up the loaders!)

10:38 AM Changeset in webkit [16300] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/javascript-backslash-expected.txt: Added.
  • fast/dom/javascript-backslash.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/dom/javascript-backslash.html

  • platform/KURL.cpp: (WebCore::KURL::init): Don't do backslash substitution in JavaScript URLs.
10:11 AM Changeset in webkit [16299] by weinig
  • 28 edits in trunk/WebCore

Reviewed by Darin and Tim H.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10792
Remove the [Exclude=LANGUAGE] idiom from IDL's and code generators
for something better

  • Replaces [Exclude=LANGUAGE] idiom with preprocessor #if defined(LANGUAGE) idiom.
  • Assorted whitespace changes to IDL files.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMEvents.h:
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSValue.idl:
  • dom/DOMImplementation.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Event.idl:
  • dom/KeyboardEvent.idl:
  • dom/MouseEvent.idl:
  • dom/NamedNodeMap.idl:
  • dom/NodeFilter.idl:
  • dom/UIEvent.idl:
  • dom/WheelEvent.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLOptionsCollection.idl:
7:49 AM Changeset in webkit [16298] by darin
  • 3 edits
    2 deletes in trunk/LayoutTests
  • converted a test to plain text (makes it platform independent; fixes a failure)
  • fast/events/ondragenter-expected.checksum: Removed.
  • fast/events/ondragenter-expected.png: Removed.
  • fast/events/ondragenter-expected.txt:
  • fast/events/ondragenter.html:
12:28 AM Changeset in webkit [16297] by hyatt
  • 3 edits in trunk/WebCore

Fix an unwitting victim of the kMin->min change. calcBlockMinMaxWidth
was accidentally renamed to calcBlominMaxWidth.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcMinMaxWidth): (WebCore::RenderBlock::calcBlockMinMaxWidth):
  • rendering/RenderBlock.h:

Sep 10, 2006:

11:37 PM Changeset in webkit [16296] by hyatt
  • 15 edits in trunk/WebCore

Rework the printer font stuff a little bit so that the Font API doesn't
have to be changed.

Reviewed by eseidel

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreStringTruncator.mm: (truncateString): (+[WebCoreStringTruncator widthOfString:font:]):
  • platform/Font.cpp: (WebCore::Font::drawSimpleText):
  • platform/Font.h:
  • platform/TextStyle.h: (WebCore::TextStyle::TextStyle): (WebCore::TextStyle::attemptFontSubstitution): (WebCore::TextStyle::setRTL):
  • platform/mac/FontMac.mm: (WebCore::m_wordSpacing): (WebCore::Font::drawGlyphs):
  • platform/mac/ListBoxMac.mm: (itemTextRenderer): (groupLabelTextRenderer): (-[WebCoreTableView drawRow:clipRect:]):
  • platform/mac/PopUpButtonMac.mm: (PopUpButton::sizeHint):
  • platform/mac/TextFieldMac.mm: (-[NSSearchFieldCell _addStringToRecentSearches:]):
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint): (WebCoreTextFloatWidth):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
11:32 PM Changeset in webkit [22156] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/FontWin.cpp

Remove usePrinterFont param from Cairo drawGlyphs code path. (CG code path was unpatched so no need to revert it.

11:16 PM Changeset in webkit [16295] by beidson
  • 3 edits in trunk/WebCore
10:23 PM Changeset in webkit [16294] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej

Added specialized HashTraits

  • platform/IntSizeHash.h:
9:42 PM Changeset in webkit [22155] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Remove the addIntrinsicMargins code from the theme. I did this
in the open source version but forgot to do it in the internal
version.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustButtonStyle): (WebCore::RenderThemeWin::adjustTextFieldStyle): (WebCore::RenderThemeWin::adjustTextAreaStyle): (WebCore::RenderThemeWin::adjustMenuListStyle):
7:48 PM Changeset in webkit [16293] by darin
  • 3 edits
    2 deletes in trunk/LayoutTests
  • converted a text to plain text (makes it platform independent; fixes a failure)
  • fast/text/plain-text-line-breaks-expected.checksum: Removed.
  • fast/text/plain-text-line-breaks-expected.png: Removed.
  • fast/text/plain-text-line-breaks-expected.txt: Regenerated.
  • fast/text/plain-text-line-breaks.html: Added a call to dumpAsText().
7:26 PM Changeset in webkit [16292] by beidson
  • 3 edits in trunk/WebCore

Forgetting header #define protection is BAAAAAD
(and re-alphabatized the project file)

  • WebCore.xcodeproj/project.pbxproj:
  • platform/IntSizeHash.h:
7:13 PM Changeset in webkit [16291] by beidson
  • 3 edits
    1 add in trunk/WebCore

Reviewed by Maciej

Moved the custom IntSize hash out of IconDatabase into a more generally useful file

  • WebCore.xcodeproj/project.pbxproj:
  • loader/icon/IconDatabase.h:
  • platform/IntSizeHash.h: Added.
5:14 PM Changeset in webkit [22154] by beidson
  • 2 edits in branches/WindowsMerge/WebCore

Build fix

4:33 PM Changeset in webkit [16290] by hyatt
  • 58 edits in trunk/LayoutTests/fast/forms

Land new results.

4:27 PM Changeset in webkit [16289] by hyatt
  • 11 edits in trunk/WebCore

Fix for bug 10801, form controls that get styled suddenly lose their
intrinsic margins. Move the intrinsic margin addition code into
adjustRenderStyle and get it out of the theme code and the old form control
code.

Reviewed by aroben

  • css/cssstyleselector.cpp: (WebCore::addIntrinsicMargins): (WebCore::CSSStyleSelector::adjustRenderStyle):
  • css/html4.css:
  • rendering/DeprecatedRenderSelect.h: (WebCore::DeprecatedRenderSelect::calcReplacedHeight):
  • rendering/DeprecatedSlider.h:
  • rendering/RenderFormElement.cpp: (WebCore::RenderFormElement::setStyle):
  • rendering/RenderFormElement.h:
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::resize):
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustButtonStyle): (WebCore::RenderThemeMac::adjustTextFieldStyle): (WebCore::RenderThemeMac::adjustTextAreaStyle): (WebCore::RenderThemeMac::adjustMenuListStyle): (WebCore::RenderThemeMac::adjustMenuListButtonStyle):
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustButtonStyle): (WebCore::RenderThemeWin::adjustTextFieldStyle): (WebCore::RenderThemeWin::adjustTextAreaStyle):
1:22 PM Changeset in webkit [16288] by darin
  • 2 edits in trunk/WebKit

Reviewed by Brady.

  • WebView/WebFrame.m: (-[WebFrame _continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): Changed a mistaken "self" to "frame", which was the cause of the bug. Also fixed the method so that it won't crash if createWebViewWithRequest does something that has a side effect of releasing this WebView or this frame by retaining "self" and "frame" as needed. Also fixed a problem where the code to set "opener" was backwards, and would set the opener of the old frame to point to the new frame instead of vice versa.
1:21 PM Changeset in webkit [16287] by darin
  • 1 edit
    2 adds in trunk/WebCore
  • manual-tests/target-test.html: Added.
  • manual-tests/targeted.html: Added.
12:53 PM Changeset in webkit [16286] by eseidel
  • 18 edits in trunk/WebCore

2006-09-10 Eric Seidel <eric@eseidel.com>

Reviewed by darin.


Remove a bunch more NSGraphicsContext related code.
Add a LocalCurrentGraphicsContext to simplify methods which need to call up into AppKit controls (and thus depend on the [NSGraphicsContext currentContext] being set correctly)
Add an "isPrinting" flag to many of the text drawing functions in order to avoid the need for a GraphicsContext::isPrinting() function.

No tests were harmed in the making of this patch.

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge drawRect:]):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.h: (WebCore::KRenderingDeviceContextQuartz::cgContext): (WebCore::KRenderingDeviceQuartz::isBuffered):
  • kcanvas/device/quartz/KRenderingDeviceQuartz.mm: (WebCore::KRenderingDeviceContextQuartz::KRenderingDeviceContextQuartz): (WebCore::KRenderingDeviceContextQuartz::~KRenderingDeviceContextQuartz):
  • kcanvas/device/quartz/QuartzSupport.mm:
  • platform/Font.cpp: (WebCore::Font::drawSimpleText): (WebCore::Font::drawText):
  • platform/Font.h:
  • platform/GraphicsContext.cpp: (WebCore::GraphicsContext::drawText):
  • platform/GraphicsContext.h:
  • platform/mac/FileButtonMac.mm: (-[WebFileChooserButton drawRect:]):
  • platform/mac/FontMac.mm: (WebCore::ATSULayoutParameters::ATSULayoutParameters): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::drawComplexText): (WebCore::Font::drawGlyphs):
  • platform/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspelling):
  • platform/mac/ListBoxMac.mm: (-[WebCoreTableView drawRow:clipRect:]):
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paint):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
  • rendering/RenderThemeMac.mm: (WebCore::WebCoreNSGraphicsContextBridge::WebCoreNSGraphicsContextBridge): (WebCore::WebCoreNSGraphicsContextBridge::~WebCoreNSGraphicsContextBridge): (WebCore::RenderThemeMac::paintButton): (WebCore::RenderThemeMac::paintTextField): (WebCore::RenderThemeMac::paintTextArea):
11:17 AM Changeset in webkit [16285] by ap
  • 2 edits in trunk/WebKitQt

Reviewed and landed by ap.

Fix QtLauncher - it is supposed to create a FrameView on its own nowadays.

  • QtLauncher/main.cpp: (main):
12:54 AM Changeset in webkit [22153] by sfalken
  • 4 edits in branches/WindowsMerge
12:41 AM Changeset in webkit [16284] by sfalken
  • 4 edits in trunk/WebCore

2006-09-09 Steve Falkenburg <sfalken@apple.com>

Reviewed by aroben.

Fixes to work with string API changes.

  • platform/cf/ResourceLoaderCFNet.cpp: (WebCore::arrayFromFormData): (WebCore::ResourceLoader::start):
  • platform/cf/StringCF.cpp:
  • platform/cf/StringImplCF.cpp:
12:40 AM Changeset in webkit [16283] by sfalken
  • 1 edit in trunk/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj

2006-09-09 Steve Falkenburg <sfalken@apple.com>

Reviewed by aroben.


Add missing copy command.
Support finding icu headers in multiple locations.

12:19 AM Changeset in webkit [22152] by sfalken
  • 7 edits in branches/WindowsMerge

Sep 9, 2006:

11:28 PM Changeset in webkit [22151] by aroben
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Reviewed by hyatt.

Remove unnecessary calls to setAffectedBy{Active,Hover}Rules

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustMenuListStyle): Remove unnecessary calls
10:52 PM Changeset in webkit [16282] by hyatt
  • 4 adds in trunk/LayoutTests/fast/forms

Add test for textarea scrollwidth and height.

10:47 PM Changeset in webkit [16281] by hyatt
  • 4 adds in trunk/LayoutTests/fast/block/positioning

Add layout test for bug 10719.

10:37 PM Changeset in webkit [16280] by hyatt
  • 8 edits in trunk/WebCore

Fix for Bugzilla bug 5500, scrollLeft/Top/Width/Height properties not supported
on textarea. Refactored the DOM getters and setters to go through the renderer
instead of right to the layer. The renderer functions are virtual so that the
text control can subclass and forward to its anonymous div.

Fix for Bugzilla bug 10719, When positioned objects are sizing using their
containing block width as a guide, they should not ever use the line width like
non-positioned objects do.

Reviewed by aroben

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Element.cpp: (WebCore::Element::scrollLeft): (WebCore::Element::scrollTop): (WebCore::Element::setScrollLeft): (WebCore::Element::setScrollTop):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockWidthForPositioned):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::clientWidth): (WebCore::RenderObject::clientHeight): (WebCore::RenderObject::scrollWidth): (WebCore::RenderObject::scrollHeight): (WebCore::RenderObject::scrollLeft): (WebCore::RenderObject::scrollTop): (WebCore::RenderObject::setScrollLeft): (WebCore::RenderObject::setScrollTop): (WebCore::RenderObject::hasStaticX): (WebCore::RenderObject::hasStaticY):
  • rendering/RenderObject.h: (WebCore::RenderObject::clientLeft): (WebCore::RenderObject::clientTop):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::scrollWidth): (WebCore::RenderTextControl::scrollHeight): (WebCore::RenderTextControl::scrollLeft): (WebCore::RenderTextControl::scrollTop): (WebCore::RenderTextControl::setScrollLeft): (WebCore::RenderTextControl::setScrollTop):
  • rendering/RenderTextControl.h:
9:55 PM Changeset in webkit [16279] by hyatt
  • 4 edits in trunk/WebCore

Implement support for the WinIE clientLeft and clientTop extensions.

Reviewed by aroben

  • dom/Element.cpp: (WebCore::Element::clientLeft): (WebCore::Element::clientTop):
  • dom/Element.h:
  • dom/Element.idl:
  • rendering/RenderObject.h: (WebCore::RenderObject::clientLeft): (WebCore::RenderObject::clientTop):
7:36 PM Changeset in webkit [16278] by weinig
  • 12 edits in trunk

WebCore:

Reviewed by Eric.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10795
Auto-generate the Objective-C DOM XPath bindings

  • Auto-generates DOMXPathExpression, DOMXPathNSResolver and DOMXPathResult.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/DOMXPath.h:
  • bindings/objc/DOMXPath.mm:
  • bindings/objc/PublicDOMInterfaces.h:
  • xml/XPathExpression.idl:
  • xml/XPathNSResolver.idl:
  • xml/XPathResult.idl:

WebKit:

Reviewed by Eric.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10795
Auto-generate the Objective-C DOM XPath bindings

  • MigrateHeaders.make:
3:05 PM Changeset in webkit [16277] by weinig
  • 23 edits
    3 adds
    1 delete in trunk

WebCore:

Reviewed by Eric.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10791
Even More Objective-C DOM auto-generation cleanup

  • Auto-generate some remaining extension methods for DOMDocument and DOMCSSStyleDeclaration.
  • Split DOMHTMLEmbedElement into it's own files. It can't be auto-generated yet because the Objective-C interface is significantly different from the implementation interface. Since HTMLEmbedElement is not in the W3C spec, this is somewhat of a gray area.
  • Auto-generate DOMEventListener protocol.
  • Clean up the IDL files by separating the extensions from the specified methods and attributes.
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm:
  • bindings/objc/DOMCSS.mm:
  • bindings/objc/DOMEventListener.h: Removed.
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMHTML.h:
  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMHTMLEmbedElement.h: Added.
  • bindings/objc/DOMHTMLEmbedElement.mm: Added. (-[DOMHTMLEmbedElement align]): (-[DOMHTMLEmbedElement setAlign:]): (-[DOMHTMLEmbedElement height]): (-[DOMHTMLEmbedElement setHeight:]): (-[DOMHTMLEmbedElement name]): (-[DOMHTMLEmbedElement setName:]): (-[DOMHTMLEmbedElement src]): (-[DOMHTMLEmbedElement setSrc:]): (-[DOMHTMLEmbedElement type]): (-[DOMHTMLEmbedElement setType:]): (-[DOMHTMLEmbedElement width]): (-[DOMHTMLEmbedElement setWidth:]):
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/PublicDOMInterfaces.h:
  • css/CSSStyleDeclaration.idl:
  • dom/Document.idl:
  • dom/KeyboardEvent.h:
  • dom/KeyboardEvent.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/OverflowEvent.idl:
  • dom/UIEvent.idl:
  • dom/WheelEvent.idl:
  • html/HTMLEmbedElement.idl: Added.

WebKit:

Reviewed by Eric.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10791
Even More Objective-C DOM auto-generation cleanup

  • MigrateHeaders.make:

WebKitTools:

Reviewed by Eric.

Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=10791
Even More Objective-C DOM auto-generation cleanup

  • Change to use new, more Objectice-C'ish version of DOMKeyboardEvent's initKeyboardEvent. Fixes an error with regression test for fast/events/dblclick-addEventListener.html.
  • DumpRenderTree/EventSendingController.m: (-[EventSendingController fireKeyboardEventsToElement:]):
1:29 PM Changeset in webkit [16276] by eseidel
  • 47 edits in trunk/WebCore

2006-09-09 Eric Seidel <eric@eseidel.com>

Reviewed by Tim H.


Remove DeprecatedString usage and fix style.
http://bugzilla.opendarwin.org/show_bug.cgi?id=10787

No tests were harmed in the making of this patch.

  • kcanvas/KCanvasFilters.cpp: (WebCore::KCanvasFilterEffect::in): (WebCore::KCanvasFilterEffect::setIn): (WebCore::KCanvasFilterEffect::result): (WebCore::KCanvasFilterEffect::setResult): (WebCore::KCanvasFEMerge::externalRepresentation):
  • kcanvas/KCanvasFilters.h: (WebCore::KCanvasFEBlend::in2): (WebCore::KCanvasFEBlend::setIn2): (WebCore::KCanvasFEComposite::in2): (WebCore::KCanvasFEComposite::setIn2): (WebCore::KCanvasFEDisplacementMap::in2): (WebCore::KCanvasFEDisplacementMap::setIn2): (WebCore::KCanvasFEMerge::mergeInputs): (WebCore::KCanvasFEMerge::setMergeInputs):
  • kcanvas/KCanvasResources.cpp: (WebCore::KCanvasResource::idInRegistry): (WebCore::KCanvasResource::setIdInRegistry): (WebCore::getResourceById):
  • kcanvas/KCanvasResources.h:
  • kcanvas/RenderPath.cpp: (WebCore::RenderPath::getAbsoluteRepaintRect): (WebCore::RenderPath::paint): (WebCore::RenderPath::drawMarkersIfNeeded):
  • kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::getAbsoluteRepaintRect):
  • kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint): (WebCore::RenderSVGImage::getAbsoluteRepaintRect):
  • kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):
  • kcanvas/device/KRenderingPaintServer.h: (WebCore::KRenderingPaintServer::idInRegistry): (WebCore::KRenderingPaintServer::setIdInRegistry):
  • kcanvas/device/quartz/KCanvasFilterQuartz.h:
  • kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::imageForName): (WebCore::KCanvasFilterQuartz::setImageForName): (WebCore::KCanvasFEMergeQuartz::getCIFilter):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • ksvg2/css/SVGRenderStyle.cpp:
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/css/SVGRenderStyleDefs.h:
  • ksvg2/ecma/GlobalObject.cpp: (GlobalObject::get):
  • ksvg2/misc/KSVGTimeScheduler.cpp: (WebCore::SVGTimer::notifyAll):
  • ksvg2/svg/SVGDescElement.cpp: (WebCore::SVGDescElement::SVGDescElement): (WebCore::SVGDescElement::description):
  • ksvg2/svg/SVGDescElement.h:
  • ksvg2/svg/SVGFEBlendElement.cpp: (WebCore::SVGFEBlendElement::SVGFEBlendElement): (WebCore::SVGFEBlendElement::filterEffect):
  • ksvg2/svg/SVGFEColorMatrixElement.cpp: (SVGFEColorMatrixElement::SVGFEColorMatrixElement): (SVGFEColorMatrixElement::filterEffect):
  • ksvg2/svg/SVGFEComponentTransferElement.cpp: (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement): (WebCore::SVGFEComponentTransferElement::filterEffect):
  • ksvg2/svg/SVGFECompositeElement.cpp: (SVGFECompositeElement::SVGFECompositeElement): (SVGFECompositeElement::filterEffect):
  • ksvg2/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement): (WebCore::SVGFEDiffuseLightingElement::filterEffect):
  • ksvg2/svg/SVGFEDisplacementMapElement.cpp: (SVGFEDisplacementMapElement::SVGFEDisplacementMapElement): (SVGFEDisplacementMapElement::filterEffect):
  • ksvg2/svg/SVGFEFloodElement.cpp: (WebCore::SVGFEFloodElement::SVGFEFloodElement): (WebCore::SVGFEFloodElement::filterEffect):
  • ksvg2/svg/SVGFEGaussianBlurElement.cpp: (SVGFEGaussianBlurElement::SVGFEGaussianBlurElement): (SVGFEGaussianBlurElement::filterEffect):
  • ksvg2/svg/SVGFELightElement.cpp:
  • ksvg2/svg/SVGFEMergeElement.cpp: (SVGFEMergeElement::filterEffect):
  • ksvg2/svg/SVGFEOffsetElement.cpp: (SVGFEOffsetElement::SVGFEOffsetElement): (SVGFEOffsetElement::filterEffect):
  • ksvg2/svg/SVGFESpecularLightingElement.cpp: (SVGFESpecularLightingElement::SVGFESpecularLightingElement): (SVGFESpecularLightingElement::filterEffect):
  • ksvg2/svg/SVGFETileElement.cpp: (WebCore::SVGFETileElement::SVGFETileElement): (WebCore::SVGFETileElement::filterEffect):
  • ksvg2/svg/SVGFETurbulenceElement.cpp: (SVGFETurbulenceElement::SVGFETurbulenceElement):
  • ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp: (SVGFilterPrimitiveStandardAttributes::setStandardAttributes):
  • ksvg2/svg/SVGFitToViewBox.cpp: (WebCore::SVGFitToViewBox::parseViewBox): (WebCore::SVGFitToViewBox::parseMappedAttribute):
  • ksvg2/svg/SVGFitToViewBox.h:
  • ksvg2/svg/SVGLinearGradientElement.cpp: (SVGLinearGradientElement::buildGradient):
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::fillAttributesFromReferencePattern): (WebCore::SVGPatternElement::notifyAttributeChange):
  • ksvg2/svg/SVGPreserveAspectRatio.cpp: (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio): (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio): (WebCore::SVGPreserveAspectRatio::getCTM):
  • ksvg2/svg/SVGPreserveAspectRatio.h:
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::buildGradient):
  • ksvg2/svg/SVGStyleElement.cpp:
  • ksvg2/svg/SVGStyledTransformableElement.cpp:
  • ksvg2/svg/SVGViewElement.cpp: (WebCore::SVGViewElement::SVGViewElement): (WebCore::SVGViewElement::parseMappedAttribute):
  • ksvg2/svg/SVGZoomAndPan.cpp: (WebCore::SVGZoomAndPan::SVGZoomAndPan):
8:35 AM Changeset in webkit [16275] by thatcher
  • 3 edits
    2 adds in trunk

LayoutTests:

Adds a test for the CSS URL quoting logic.

  • fast/inspector/cssURLQuotes-expected.txt: Added.
  • fast/inspector/cssURLQuotes.html: Added.

WebCore:

Reviewed by Tim H.

<rdar://problem/4699166> REGRESSION: Background images in Mail stationery do not load


Fixes the quoting logic. The previous logic did not account for the
CSS tokenizer's regex character range between * and ~ as valid in URL types.

  • css/CSSPrimitiveValue.cpp: (WebCore::isCSSTokenizerURL):
3:54 AM Changeset in webkit [16274] by ap
  • 4 edits in trunk

Reviewed by Darin.

WebCore:

  • bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): Convert integer values to typeSInt32 AE descriptors.

LayoutTests:

  • fast/AppleScript/001-expected.txt: Updated results.
Note: See TracTimeline for information about the timeline view.