Timeline



Sep 18, 2006:

11:23 PM Changeset in webkit [16442] by hyatt
  • 2 edits in trunk/WebCore

Fix for 9805, <hr> not positioned properly following a previous empty sibling
that had clear:both set on it. Update self-collapsing block clearance
behavior to match what is specified in the latest draft of CSS2.1.

Reviewed by Eric

Added fast/block/margin-collapse/empty-clear-blocks.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::handleBottomOfBlock):
7:47 PM Changeset in webkit [22185] by beidson
  • 4 edits in branches/WindowsMerge/WebCore

YABF and merged an open source change

7:36 PM Changeset in webkit [16441] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Brady, landed by Brady

Send receivedResponse callback to ResourceLoaderClient when loading
file URLs.

See ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10845

  • platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::fileLoadTimer):
7:21 PM Changeset in webkit [16440] by beidson
  • 16 edits in trunk

WebCore:

Reviewed by Anders

<rdar://problem/3028061> - WebKit never updates favicon
The WebKit enforced expiration date for icons has worked for some time, but the
move to the new Icon Loader broke the "always get the icon if the user refreshes the page"
functionality. This patch fixes that up, along with some other architectural improvements,
the main one being that WebCore::Document now contains an iconURL for the Frame to query if needed.

  • bridge/mac/FrameMac.h: Added isLoadTypeReload()
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::isLoadTypeReload): Implementation, calls into the bridge
  • bridge/mac/WebCoreFrameBridge.h: Added isLoadTypeReload:
  • bridge/win/FrameWin.h: Added isLoadTypeReload() for temporary link stub
  • dom/Document.h: Added m_iconURL (WebCore::Document::iconURL): Added (WebCore::Document::setIconURL): Ditto
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process): Sets the iconURL in the Document instead of the Frame
  • page/Frame.cpp: (WebCore::Frame::iconURL): Calculates the iconURL based on the document, then the default favicon.ico url (WebCore::Frame::endIfNotLoading): Checks for the load type - always loads icon on Reload
  • page/Frame.h: Nuked setIconURL(), added isLoadTypeReload()
  • page/FramePrivate.h: Nuked IconURL
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::isLoadTypeReload):

WebKit:

Reviewed by Anders

Implement a bridge method so WebCore can find the reload type of a frame load

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge isLoadTypeReload]):
7:10 PM Changeset in webkit [22184] by hyatt
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/WebKit.vcproj

Fix more build bustage. Remove CoreGraphics.lib from the set of linked against libraries.

6:55 PM Changeset in webkit [22183] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/WebCore.vcproj/WebCore.vcproj

Fix build bustage caused by removal of ColorCG.cpp I guess?

5:53 PM Changeset in webkit [22182] by seangies
  • 2 edits in branches/WindowsMerge/WebCore

Support bold & italics text with CG on Windows

4:44 PM Changeset in webkit [22181] by seangies
  • 7 edits in branches/WindowsMerge

Last few CoreGraphics integration compile fixes

4:15 PM Changeset in webkit [16439] by weinig
  • 3 edits in trunk/WebCore

Reviewed by Tim H.

  • Re-add private method [DOMRGBColor _color] to DOMPrivate.h as it is it turns out that AppKit uses it.
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/DOMRGBColor.mm: (-[DOMRGBColor _color]):
2:40 PM Changeset in webkit [16438] by weinig
  • 18 edits
    6 adds
    1 delete in trunk

WebCore:

Reviewed by Tim H.

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10903
Yet Another Objective-C Bindings Patch

  • Whitespace cleanup for IDLParser.pm
  • Split DOMException, DOMRangeException, DOMXPathException, DOMEventsException and DOMAbstractView into their own files.
  • Remove private method [DOMRGBColor _color] from DOMPrivate.h as it is not used and a public method is available now.
  • Remove internal method [DOMDocument _ownerElement] from DOMInternal.h as it not used.
  • Auto-generate method isContentEditable for DOMNode.
  • General cleanup of bindings code including removing unneeded #imports and whitespace cleanup
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (addElementClass): (elementClass): (-[DOMNode _initWithNode:WebCore::]): (+[DOMNode _nodeWith:WebCore::]): (-[DOMNode WebCore::]): (-[DOMNode KJS::Bindings::]): (-[DOMNode addEventListener:::]): (-[DOMNode removeEventListener:::]): (-[DOMNode dispatchEvent:]): (-[DOMElement image]): (-[DOMElement _font]): (-[DOMElement _imageTIFFRepresentation]): (-[DOMElement _getURLAttribute:]): (-[DOMElement _NPObject]): (-[DOMElement isFocused]): (-[DOMRange dealloc]): (-[DOMRange finalize]): (-[DOMRange description]): (-[DOMRange startContainer]): (-[DOMRange startOffset]): (-[DOMRange endContainer]): (-[DOMRange endOffset]): (-[DOMRange collapsed]): (-[DOMRange commonAncestorContainer]): (-[DOMRange setStart::]): (-[DOMRange setEnd::]): (-[DOMRange setStartBefore:]): (-[DOMRange setStartAfter:]): (-[DOMRange setEndBefore:]): (-[DOMRange setEndAfter:]): (-[DOMRange collapse:]): (-[DOMRange selectNode:]): (-[DOMRange selectNodeContents:]): (-[DOMRange compareBoundaryPoints::]): (-[DOMRange deleteContents]): (-[DOMRange extractContents]): (-[DOMRange cloneContents]): (-[DOMRange insertNode:]): (-[DOMRange surroundContents:]): (-[DOMRange cloneRange]): (-[DOMRange toString]): (-[DOMRange detach]): (-[DOMRange _initWithRange:WebCore::]): (+[DOMRange _rangeWith:WebCore::]): (-[DOMRange WebCore::]): (-[DOMNodeFilter _initWithNodeFilter:WebCore::]): (+[DOMNodeFilter _nodeFilterWith:WebCore::]): (-[DOMNodeFilter WebCore::]): (-[DOMNodeFilter dealloc]): (-[DOMNodeFilter finalize]): (-[DOMNodeIterator _initWithNodeIterator:WebCore::filter:]): (-[DOMNodeIterator WebCore::]): (+[DOMNodeIterator _nodeIteratorWith:WebCore::filter:]): (-[DOMTreeWalker _initWithTreeWalker:WebCore::filter:]): (-[DOMTreeWalker WebCore::]): (+[DOMTreeWalker _treeWalkerWith:WebCore::filter:]): (ObjCNodeFilterCondition::acceptNode): (-[DOMDocument createNodeIterator::::]): (-[DOMDocument createTreeWalker::::]): (ObjCEventListener::find): (ObjCEventListener::create): (ObjCEventListener::handleEvent):
  • bindings/objc/DOMAbstractView.h: Added.
  • bindings/objc/DOMAbstractView.mm: Added. (-[DOMAbstractView document]): (-[DOMAbstractView WebCore::]): (-[DOMAbstractView _initWithAbstractView:WebCore::]): (+[DOMAbstractView _abstractViewWith:WebCore::]):
  • bindings/objc/DOMCSS.mm: (-[DOMStyleSheet _initWithStyleSheet:WebCore::]): (+[DOMStyleSheet _styleSheetWith:WebCore::]): (+[DOMCSSStyleSheet _CSSStyleSheetWith:WebCore::]): (-[DOMCSSRule _initWithRule:WebCore::]): (+[DOMCSSRule _CSSRuleWith:WebCore::]): (-[DOMCSSValue _initWithValue:WebCore::]): (+[DOMCSSValue _CSSValueWith:WebCore::]): (+[DOMCSSPrimitiveValue _CSSPrimitiveValueWith:WebCore::]): (-[DOMDocument getComputedStyle::]): (-[DOMDocument getMatchedCSSRules::]):
  • bindings/objc/DOMCore.h:
  • bindings/objc/DOMEventException.h: Added.
  • bindings/objc/DOMEvents.h:
  • bindings/objc/DOMEvents.mm:
  • bindings/objc/DOMException.h: Added.
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument _createDocumentFragmentWithMarkupString:baseURLString:]): (viewForElement): (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]): (-[DOMHTMLInputElement _selectedRange]): (-[DOMHTMLInputElement _setAutofilled:]):
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMObject.h:
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/DOMRange.h:
  • bindings/objc/DOMRangeException.h: Added.
  • bindings/objc/DOMViews.h:
  • bindings/objc/DOMViews.mm: Removed.
  • bindings/objc/DOMXPath.h:
  • bindings/objc/DOMXPathException.h: Added.
  • bindings/scripts/IDLParser.pm:
  • dom/Node.idl:

WebKit:

Reviewed by Tim H.

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10903
Yet Another Objective-C Bindings Patch

  • MigrateHeaders.make:
2:37 PM Changeset in webkit [16437] by harrison
  • 5 edits in trunk/WebKit

Reviewed by John Sullivan.

<rdar://problem/4494340> REGRESSION: Making the font size bigger/smaller in an HTML message doesn't affect the body until you reopen it

Problem was the public API -[WebView setTextSizeMultiplier] did not notify anyone that the value changed.


  • WebView/WebDocumentInternal.h: Add _textSizeMultiplierChanged to the _WebDocumentTextSizing protocol.


  • WebView/WebHTMLView.m: (-[WebHTMLView _textSizeMultiplierChanged]): Send [self _updateTextSizeMultiplier].


  • WebView/WebPDFView.m: (-[WebPDFView _textSizeMultiplierChanged]): ASSERT_NOT_REACHED() because WebPDFView does not track the common multiplier.


  • WebView/WebView.m: (-[WebView setTextSizeMultiplier:]): Send [self _notifyTextSizeMultiplierChanged];


(-[WebView _performTextSizingSelector:withObject:onTrackingDocs:selForNonTrackingDocs:newScaleFactor:]):
Alter the _textSizeMultiplier directly so that notification is not sent.
Minor formatting.


(-[WebView _notifyTextSizeMultiplierChanged]):
New. Send _textSizeMultiplierChanged to all document views that track the common multiplier.

1:50 PM Changeset in webkit [22180] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix (release).

  • WebHistory.cpp: (_WebCoreHistoryProvider::containsItemForURLLatin1): Remove unused HRESULT. (_WebCoreHistoryProvider::containsItemForURLUnicode): Ditto.
1:42 PM Changeset in webkit [16436] by beidson
  • 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

ACTUAL Windows build fix

1:32 PM Changeset in webkit [16435] by beidson
  • 2 edits in trunk/WebCore

Windows build fix

  • platform/win/TemporaryLinkStubs.cpp: (IconDatabase::setIconURLForPageURL):
12:56 PM Changeset in webkit [22179] by andersca
  • 7 adds in branches/WindowsMerge/WebKitTools

2006-09-18 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John.

Fork DumpRenderTree from OpenSource repository (r16433).


  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.sln: Added.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: Added. (loadResourceIntoArray): (localFileTest): (dumpRenderTreeMain): (dumpRenderTreeToStdOut): (serializeToStdOut): (main):
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Added.
12:20 PM Changeset in webkit [16434] by hyatt
  • 4 adds in trunk/LayoutTests/fast/block/float

Add layout test for float bug.

12:12 PM Changeset in webkit [16433] by hyatt
  • 2 edits in trunk/WebCore

Fix for bug 3969, hr width doesn't update when it clears a float. This
was also a problem with tables and overflow sections.

Reviewed by Eric

Added fast/block/float/width-update-after-clear.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded):
12:07 PM Changeset in webkit [16432] by hyatt
  • 171 edits in trunk/LayoutTests/tables

Update table layout test results.

12:06 PM Changeset in webkit [16431] by hyatt
  • 140 edits in trunk/LayoutTests/tables/mozilla_expected_failures/marvin

Update table layout test results.

12:05 PM Changeset in webkit [16430] by hyatt
  • 114 edits in trunk/LayoutTests/tables/mozilla_expected_failures/bugs

Update table layout test results.

12:00 PM Changeset in webkit [16429] by hyatt
  • 568 edits in trunk/LayoutTests/tables/mozilla/marvin

Update table layout test results.

11:55 AM Changeset in webkit [16428] by hyatt
  • 469 edits in trunk/LayoutTests/tables/mozilla/bugs

Update table layout test results.

11:51 AM Changeset in webkit [22178] by beidson
  • 3 edits in branches/WindowsMerge/WebCore

Build Fix

11:45 AM Changeset in webkit [22177] by seangies
  • 2 edits
    1 add in branches/WindowsMerge/WebCore

Forked FontCacheWin.cpp from OpenSource tree r16421

11:19 AM Changeset in webkit [16427] by thatcher
  • 2 edits in tags/WebKit-521.26.1/WebKit

Build fix and versioning.

11:16 AM Changeset in webkit [16426] by thatcher
  • 1 copy in tags/WebKit-521.26.1/WebKit

New tag part 2

11:15 AM Changeset in webkit [16425] by brmorris
  • 1 copy in S60/branches/3.1m

Creating new branch.

11:14 AM Changeset in webkit [16424] by thatcher
  • 1 add in tags/WebKit-521.26.1

New tag part 1.

11:13 AM Changeset in webkit [16423] by beidson
  • 7 edits in trunk/WebCore

Reviewed by John

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10907
REGRESSION: New Icon Loaders don't handle certain non-server-root URLs correctly

  • bridge/mac/FrameMac.h: Changed originalRequestURL() to virtual
  • bridge/win/FrameWin.h: Added originalRequestURL()
  • loader/icon/IconLoader.cpp: (IconLoader::receivedAllData): Moved the "pageURL to iconURL mapping logic" to Frame::commitIconURLToIconDatabase()
  • page/Frame.cpp: (WebCore::Frame::iconURL): Construct the icon URL from *only* the protocol and host of the frame's url. (WebCore::Frame::endIfNotLoading): Call commitIconURLToIconDatabase() if we're not kicking off an icon load (WebCore::Frame::commitIconURLToIconDatabase): Map the completed doc's pageURL to the iconURL
  • page/Frame.h: Added pure virtual originalRequestURL()
  • platform/win/TemporaryLinkStubs.cpp: (FrameWin::originalRequestURL): Added
11:11 AM Changeset in webkit [16422] by thatcher
  • 1 edit in trunk/WebKit/WebInspector/WebInspector.m

Build fix, NSIntMapValueCallBacks is deprecated infavor of the new name NSIntegerMapValueCallBacks. Just make a new NSMapTableValueCallBacks of {NULL, NULL, NULL} to make it build on new or older systems.

2:25 AM Changeset in webkit [16421] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10807
REGRESSION (r16259): Repro crash on manual-tests/svg-repaint-image.svg

Make sure the paint method is not exited without popping
context and transparency layer.

2:16 AM Changeset in webkit [16420] by bdash
  • 2 edits in trunk/WebCore

2006-09-18 Graham Dennis <​graham.dennis@gmail.com>

Reviewed by Eric.



  • bindings/scripts/CodeGeneratorObjC.pm: For each file generated add a #ifdef <something>_SUPPORT / #endif pair if the idl file has a Conditional extended attribute

Sep 17, 2006:

11:45 PM Changeset in webkit [16419] by eseidel
  • 2 edits in trunk/WebCore

2006-09-17 Eric Seidel <​eric@eseidel.com>

Reviewed by ap.


REGRESSION (r16245): double-clicking on javascript exceptions fails to show source
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10813

  • bridge/mac/WebCoreFrameBridge.mm: (+[WebCoreFrameBridge stringWithData:textEncodingName:]):
11:14 PM Changeset in webkit [16418] by eseidel
  • 2 edits in trunk/LayoutTests

2006-09-17 Eric Seidel <​eric@eseidel.com>

Reviewed by hyatt.

  • fast/js/window-properties.html: make work in Firefox (hangs IE)
10:03 PM Changeset in webkit [16417] by ap
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10779
REGRESSION: Animated GIF ignores frame intervals and loops infinitely

No test possible.

  • platform/Image.cpp: (WebCore::Image::shouldAnimate): Don't check that there is more than one frame, maybe the rest just hasn't been loaded yet. (WebCore::Image::startAnimation): Move the frame count check here - there is no need to start animating before we get at least two frames.
9:46 PM Changeset in webkit [16416] by eseidel
  • 1 edit
    2 adds in trunk/LayoutTests

2006-09-17 Eric Seidel <​eric@eseidel.com>

Add a textual dump of the window object property tree.

Reviewed by Sarge.

  • fast/js/window-properties-expected.txt: Added.
  • fast/js/window-properties.html: Added.
5:48 PM Changeset in webkit [16415] by hyatt
  • 6 edits in trunk/LayoutTests/tables/mozilla/bugs

Land updated tests for font changes.

5:46 PM Changeset in webkit [16414] by hyatt
  • 3 edits in trunk/LayoutTests/css2.1

Land updated tests for font changes.

5:45 PM Changeset in webkit [16413] by hyatt
  • 6 edits in trunk/LayoutTests/css1/font_properties

Land updated tests for font changes.

4:17 PM Changeset in webkit [16412] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Sarge

IconLoader now gracefully handles the condition where there's no document in the frame
(ie. PDFs)

  • loader/icon/IconLoader.cpp: (IconLoader::startLoading):
4:06 PM Changeset in webkit [16411] by hyatt
  • 5 edits in trunk/WebCore

Fix for bug 10899, rework how CSS keywords work to be smarter about
using the correct size when generic families change (e.g., monospace to
serif and vice versa).

Reviewed by aroben

Added fast/text/basic/generic-family-changes.html

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::checkForGenericFamilyChange): (WebCore::CSSStyleSelector::fontSizeForKeyword):
  • css/cssstyleselector.h:
  • dom/Document.cpp: (WebCore::Document::recalcStyle):
  • platform/FontDescription.h: (WebCore::FontDescription::FontDescription): (WebCore::FontDescription::keywordSize): (WebCore::FontDescription::setKeywordSize): (WebCore::FontDescription::operator==):
4:04 PM Changeset in webkit [16410] by hyatt
  • 1 edit
    4 adds in trunk/LayoutTests

Adding layout test for bug 10899.

  • fast/text/basic/generic-family-changes-expected.checksum: Added.
  • fast/text/basic/generic-family-changes-expected.png: Added.
  • fast/text/basic/generic-family-changes-expected.txt: Added.
  • fast/text/basic/generic-family-changes.html: Added.
2:39 PM Changeset in webkit [16409] by aroben
  • 4 edits in trunk/WebKitTools

Reviewed by hyatt, sfalken.

Get DumpRenderTree compiling and limping along on Windows.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (loadResourceIntoArray): Added this function that WebCore::ImageWin needs from WebKit (main): Add NULL argument to Page constructor.
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Remove incorrect "wininet.dll" argument to CC, fix JavaScriptCore.lib path, add *_SECURE_NO_DEPRECATE #defines
  • Scripts/webkitdirs.pm: Fix JavaScriptCore.lib path
1:18 PM Changeset in webkit [16408] by ap
  • 4 edits
    2 adds in trunk

Reviewed by Brady.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10852
REGRESSION: Reproducible crash in XMLHttpRequest::abort()

Test: http/tests/xmlhttprequest/xhr-onunload.html

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send): Check the return value of ResourceLoader::start().
  • loader/icon/IconLoader.cpp: (IconLoader::startLoading): Fix a similar latent bug here.
12:37 PM Changeset in webkit [16407] by aroben
  • 2 edits in trunk/WebCore

Build fix.

  • loader/icon/IconDatabase.cpp:
12:29 PM Changeset in webkit [22176] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fix.

  • WebView.cpp: (WebView::keyPress): Add new "userTriggered" argument to calls to SelectionController::modify
12:24 PM Changeset in webkit [16406] by hyatt
  • 1 edit in trunk/LayoutTests/fast/text/whitespace/013-expected.txt

Land updated results from font fix yesterday.

11:36 AM Changeset in webkit [16405] by andersca
  • 29 edits in trunk/WebCore

2006-09-17 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Brady.

Add simplifyWhiteSpace and stripWhiteSpace to the String class.
Change the XSLT Parameter Map to use Strings instead of StringImpls.
General cleanup.

  • bindings/js/JSXSLTProcessor.cpp: (KJS::XSLTProcessorProtoFunc::callAsFunction):
  • bindings/js/kjs_events.cpp: (KJS::JSAbstractEventListener::handleEvent):
  • bindings/js/kjs_window.cpp: (KJS::ScheduledAction::execute):
  • css/MediaList.cpp: (WebCore::MediaList::setMediaText):
  • dom/Document.cpp: (WebCore::Document::processHttpEquiv):
  • editing/ApplyStyleCommand.cpp: (WebCore::StyleChange::init):
  • html/HTMLDocument.cpp: (WebCore::parseDocTypeDeclaration):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::parseMappedAttribute):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::attach): (WebCore::HTMLObjectElement::setComplete): (WebCore::HTMLObjectElement::detach): (WebCore::HTMLObjectElement::recalcStyle): (WebCore::HTMLObjectElement::childrenChanged): (WebCore::HTMLObjectElement::isImageType):
  • html/HTMLObjectElement.h:
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::value):
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::appendFormData):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag):
  • ksvg2/svg/SVGColor.cpp: (WebCore::SVGColor::setRGBColor):
  • ksvg2/svg/SVGDescElement.cpp: (WebCore::SVGDescElement::description):
  • platform/PlatformString.h:
  • platform/String.cpp: (WebCore::String::stripWhiteSpace): (WebCore::String::simplifyWhiteSpace):
  • platform/StringImpl.cpp: (WebCore::isSpace): (WebCore::parseLength): (WebCore::StringImpl::stripWhiteSpace): (WebCore::StringImpl::simplifyWhiteSpace): (WebCore::StringImpl::toInt):
  • platform/StringImpl.h:
  • platform/mac/ClipboardMac.mm: (WebCore::cocoaTypeFromMIMEType):
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):
  • xml/XPathFunctions.cpp: (WebCore::XPath::FunNormalizeSpace::doEvaluate):
  • xml/XPathGrammar.y:
  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodeTestMatches):
  • xml/XSLStyleSheet.cpp: (WebCore::XSLStyleSheet::loadChildSheets): (WebCore::XSLStyleSheet::locateStylesheetSubResource):
  • xml/XSLTProcessor.cpp: (WebCore::xsltParamArrayFromParameterMap): (WebCore::XSLTProcessor::setParameter): (WebCore::XSLTProcessor::getParameter): (WebCore::XSLTProcessor::removeParameter):
  • xml/XSLTProcessor.h:
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::getStatusText):
8:28 AM Changeset in webkit [16404] by hyatt
  • 4 adds in trunk/LayoutTests/fast/forms

Add fieldset layout test.

8:27 AM Changeset in webkit [16403] by hyatt
  • 7 edits in trunk/WebCore

Fix for bugzilla bugs 10895 and 6336, fieldsets misbehaving when floats
are declared right before the fieldsets. It turns out fieldsets in other
browsers avoid floats (like overflow:auto/hidden/scroll sections do), so
adding that behavior to fieldset fixes the bug.

Made avoidsFloats virtual and did some refactoring to make tables, flexboxes
and fieldsets all subclass.

Reviewed by anders

Added fast/forms/float-before-fieldset.html

  • rendering/RenderFieldset.h: (WebCore::RenderFieldset::avoidsFloats):
  • rendering/RenderFlexibleBox.h: (WebCore::RenderFlexibleBox::avoidsFloats):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::avoidsFloats):
  • rendering/RenderObject.h:
  • rendering/RenderTable.h: (WebCore::RenderTable::avoidsFloats):
7:35 AM Changeset in webkit [16402] by hyatt
  • 1 edit in trunk/LayoutTests/tables/mozilla/bugs/bug24200.html

Update buggy table test to not have a degenrate column structure.

7:35 AM Changeset in webkit [16401] by hyatt
  • 1 edit in trunk/LayoutTests/tables/mozilla_expected_failures/core/table_rules.html

Update buggy table test to say rules=groups and not rules=group

1:00 AM Changeset in webkit [16400] by hyatt
  • 4 adds in trunk/LayoutTests/fast/table

Add frame/rules layout test.

12:57 AM Changeset in webkit [16399] by hyatt
  • 9 edits in trunk/WebCore

Fix for bugzilla bug 3240, implement support for the HTML4 "frame" and
"rules" attributes on tables.

Reviewed by bradee-oh

Well-covered by existing layout tests.

  • html/HTMLTableCellElement.cpp: (WebCore::HTMLTableCellElement::additionalAttributeStyleDecl):
  • html/HTMLTableColElement.cpp: (WebCore::HTMLTableColElement::additionalAttributeStyleDecl):
  • html/HTMLTableColElement.h:
  • html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::HTMLTableElement): (WebCore::HTMLTableElement::~HTMLTableElement): (WebCore::HTMLTableElement::setCaption): (WebCore::HTMLTableElement::setTHead): (WebCore::HTMLTableElement::setTFoot): (WebCore::HTMLTableElement::setTBody): (WebCore::HTMLTableElement::createTHead): (WebCore::HTMLTableElement::deleteTHead): (WebCore::HTMLTableElement::createTFoot): (WebCore::HTMLTableElement::deleteTFoot): (WebCore::HTMLTableElement::createCaption): (WebCore::HTMLTableElement::deleteCaption): (WebCore::HTMLTableElement::insertRow): (WebCore::HTMLTableElement::deleteRow): (WebCore::HTMLTableElement::addChild): (WebCore::HTMLTableElement::childrenChanged): (WebCore::HTMLTableElement::mapToEntry): (WebCore::HTMLTableElement::parseMappedAttribute): (WebCore::HTMLTableElement::additionalAttributeStyleDecl): (WebCore::HTMLTableElement::getSharedCellDecl): (WebCore::HTMLTableElement::getSharedGroupDecl): (WebCore::HTMLTableElement::attach):
  • html/HTMLTableElement.h: (WebCore::HTMLTableElement::caption): (WebCore::HTMLTableElement::tHead): (WebCore::HTMLTableElement::tFoot): (WebCore::HTMLTableElement::):
  • html/HTMLTableRowElement.h:
  • html/HTMLTableSectionElement.cpp: (WebCore::HTMLTableSectionElement::additionalAttributeStyleDecl):
  • html/HTMLTableSectionElement.h:
12:43 AM Changeset in webkit [16398] by hyatt
  • 4 adds in trunk/LayoutTests/fast/text/basic

Add layout test for bug 4192.

12:39 AM Changeset in webkit [16397] by hyatt
  • 1 edit in trunk/WebCore/ChangeLog

Fix for bugzilla bug 4192, font size wrong for <tt> elements that
specify their own new font-family list. Make sure to always
reset the generic family along with the family list when mapping in
new font-family values.

Reviewed by bradee-oh

fast/text/basic/generic-family-reset.html

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
12:39 AM Changeset in webkit [16396] by hyatt
  • 2 edits in trunk/WebCore

Fix for bugzilla bug 4129, font size wrong for <tt> elements that
specify their own new font-family list. Make sure to always
reset the generic family along with the family list when mapping in
new font-family values.

Reviewed by bradee-oh

fast/text/basic/generic-family-reset.html

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
12:29 AM Changeset in webkit [16395] by beidson
  • 18 edits
    2 deletes in trunk

WebCore:

Reviewed by Hyatt

Pruning code relating to WebKit's icon loader

  • bridge/mac/WebCoreIconDatabaseBridge.h:
  • bridge/mac/WebCoreIconDatabaseBridge.mm:
  • loader/icon/IconDatabase.h:
  • page/Frame.cpp: (WebCore::Frame::endIfNotLoading): Moved a FIXME in from WebKit's IconLoader to its new home

WebKit:

Reviewed by Hyatt

WebIconLoader is dead, long live WebCore::IconLoader
(code prune)

  • Loader/WebFrameLoader.h:
  • Loader/WebFrameLoader.m: (-[WebFrameLoader dealloc]): (-[WebFrameLoader commitProvisionalLoad]):
  • Loader/WebIconLoader.h: Removed.
  • Loader/WebIconLoader.m: Removed.
  • Misc/WebIconDatabase.h:
  • Misc/WebIconDatabase.m:
  • Misc/WebIconDatabasePrivate.h:
  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge notifyIconChanged:]):
  • WebCoreSupport/WebIconDatabaseBridge.h:
  • WebCoreSupport/WebIconDatabaseBridge.m: (-[WebIconDatabaseBridge _init]): (-[WebIconDatabaseBridge _setIconData:forIconURL:]): (-[WebIconDatabaseBridge _setHaveNoIconForIconURL:]):
  • WebKit.exp:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _stopLoading]): (-[WebDataSource _setPrimaryLoadComplete:]):
  • WebView/WebDataSourceInternal.h:

Sep 16, 2006:

2:13 PM Changeset in webkit [16394] by weinig
  • 9 edits
    2 deletes in trunk/WebCore

Reviewed by Tim H.

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10885
Auto-generate DOMHTMLDocument for the Objective-C bindings

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMHTML.mm: (-[DOMHTMLDocument createDocumentFragmentWithText:]):
  • bindings/objc/DOMHTMLDocument.h: Removed.
  • bindings/objc/DOMHTMLDocument.mm: Removed.
  • bindings/objc/PublicDOMInterfaces.h:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • html/HTMLDocument.idl:
  • platform/DeprecatedString.h: (WebCore::DeprecatedString::operator NSString*):
9:15 AM Changeset in webkit [16393] by rwlbuis
  • 15 edits in trunk/WebCore

Reviewed by Eric.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10866
Code in kcanvas/ should not use Private

Remove Private classes and tweak coding style.

8:13 AM Changeset in webkit [16392] by bdash
  • 4 edits in trunk

2006-09-16 Mark Rowe <​opendarwin.org@bdash.net.nz>

Reviewed by Anders.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10887
Fix build error

  • bindings/objc/DOMPrivate.h: Remove reference to DOMEventPrivate.h.

2006-09-16 Mark Rowe <​opendarwin.org@bdash.net.nz>

Reviewed by Anders.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10887
Fix build error

  • MigrateHeaders.make: Remove reference to DOMEventPrivate.h.
8:11 AM Changeset in webkit [16391] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Anders.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10886
REGRESSION (r16387): Reproducible crash when mousing over HTML document

  • Special case method [DOMNode ownerDocument] to call document() instead or ownerDocument() to return to the old behavior.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorObjC.pm:

Sep 15, 2006:

9:19 PM Changeset in webkit [16390] by beidson
  • 1 edit in trunk/WebCore/ChangeLog

My ChangeLog msg got out of order. *sigh*

9:17 PM Changeset in webkit [16389] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Brady.

Make new style ObjC methods public API.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/PublicDOMInterfaces.h:
9:04 PM Changeset in webkit [16388] by thatcher
  • 6 edits in trunk

WebCore:

Reviewed by Brady.

Make new style ObjC methods public API.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMPrivate.h:
  • bindings/objc/PublicDOMInterfaces.h:

WebKit:

Reviewed by Brady.

Make new style ObjC methods public API.

  • MigrateHeaders.make:
8:30 PM Changeset in webkit [16387] by weinig
  • 11 edits
    2 deletes in trunk

WebCore:

Reviewed by Tim H.

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10870
Auto-generate DOMNode for the Objective-C bindings

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOM.mm: (-[DOMNode boundingBox]): (-[DOMNode lineBoxRects]):
  • bindings/objc/DOMEvents.h:
  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMNode.h: Removed.
  • bindings/objc/DOMNode.mm: Removed.
  • bindings/objc/PublicDOMInterfaces.h:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • dom/Node.idl:

WebKit:

Reviewed by Tim H.

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10870
Auto-generate DOMNode for the Objective-C bindings

  • MigrateHeaders.make:
7:24 PM Changeset in webkit [16386] by thatcher
  • 10 edits in trunk

WebCore:

Reviewed by Justin.

Removed alter selection logic from WebCoreFrameBridge and moved to SelectionController.

  • bridge/mac/WebCoreFrameBridge.h:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge centerSelectionInVisibleArea]): (-[WebCoreFrameBridge rangeByExpandingSelectionWithGranularity:]): (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:direction:granularity:]): (-[WebCoreFrameBridge alterCurrentSelection:direction:granularity:]): (-[WebCoreFrameBridge alterCurrentSelection:verticalDistance:]): (-[WebCoreFrameBridge replaceMarkedTextWithText:]): (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): (-[WebCoreFrameBridge increaseSelectionListLevel]): (-[WebCoreFrameBridge increaseSelectionListLevelOrdered]): (-[WebCoreFrameBridge increaseSelectionListLevelUnordered]): (-[WebCoreFrameBridge decreaseSelectionListLevel]): (-[WebCoreFrameBridge insertLineBreak]): (-[WebCoreFrameBridge insertParagraphSeparator]): (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]): (-[WebCoreFrameBridge insertText:selectInsertedText:]): (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:]): (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:]): (createMouseEventFromDraggingInfo):
  • editing/SelectionController.cpp: (WebCore::SelectionController::moveTo): (WebCore::SelectionController::setSelection): (WebCore::SelectionController::modify): (WebCore::SelectionController::setBase): (WebCore::SelectionController::setExtent):
  • editing/SelectionController.h:
  • page/Frame.cpp: (WebCore::Frame::revealSelection): (WebCore::Frame::revealCaret):
  • page/Frame.h:

WebKit:

Reviewed by Justin.

Call the bridge directly for alter selection calls. All of this logic is now
in WebCore's SelectionController.

  • WebView/WebHTMLView.m: (-[NSArray moveBackward:]): (-[NSArray moveBackwardAndModifySelection:]): (-[NSArray moveDown:]): (-[NSArray moveDownAndModifySelection:]): (-[NSArray moveForward:]): (-[NSArray moveForwardAndModifySelection:]): (-[NSArray moveLeft:]): (-[NSArray moveLeftAndModifySelection:]): (-[NSArray moveRight:]): (-[NSArray moveRightAndModifySelection:]): (-[NSArray moveToBeginningOfDocument:]): (-[NSArray moveToBeginningOfDocumentAndModifySelection:]): (-[NSArray moveToBeginningOfSentence:]): (-[NSArray moveToBeginningOfSentenceAndModifySelection:]): (-[NSArray moveToBeginningOfLine:]): (-[NSArray moveToBeginningOfLineAndModifySelection:]): (-[NSArray moveToBeginningOfParagraph:]): (-[NSArray moveToBeginningOfParagraphAndModifySelection:]): (-[NSArray moveToEndOfDocument:]): (-[NSArray moveToEndOfDocumentAndModifySelection:]): (-[NSArray moveToEndOfSentence:]): (-[NSArray moveToEndOfSentenceAndModifySelection:]): (-[NSArray moveToEndOfLine:]): (-[NSArray moveToEndOfLineAndModifySelection:]): (-[NSArray moveToEndOfParagraph:]): (-[NSArray moveToEndOfParagraphAndModifySelection:]): (-[NSArray moveParagraphBackwardAndModifySelection:]): (-[NSArray moveParagraphForwardAndModifySelection:]): (-[NSArray moveUp:]): (-[NSArray moveUpAndModifySelection:]): (-[NSArray moveWordBackward:]): (-[NSArray moveWordBackwardAndModifySelection:]): (-[NSArray moveWordForward:]): (-[NSArray moveWordForwardAndModifySelection:]): (-[NSArray moveWordLeft:]): (-[NSArray moveWordLeftAndModifySelection:]): (-[NSArray moveWordRight:]): (-[NSArray moveWordRightAndModifySelection:]): (-[NSArray pageUp:]): (-[NSArray pageDown:]): (-[NSArray pageUpAndModifySelection:]): (-[NSArray pageDownAndModifySelection:]):
6:40 PM Changeset in webkit [16385] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Anders

Added the ability to get a mutable char* from a CString, which will copy the internal
buffer if the ref count is greater than 1 so your mutable char* won't affect any other
referrer of that buffer.

  • platform/CString.cpp: (WebCore::CString::mutableData): (WebCore::CString::copyBufferIfNeeded):
  • platform/CString.h:
6:17 PM Changeset in webkit [16384] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4674869>
REGRESSION: selecting text to write over results in cursor jumping to middle of next line

  • editing/deleting/whitespace-pre-1-expected.checksum: Added.
  • editing/deleting/whitespace-pre-1-expected.png: Added.
  • editing/deleting/whitespace-pre-1-expected.txt: Added.
  • editing/deleting/whitespace-pre-1.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4674869>
REGRESSION: selecting text to write over results in cursor jumping to middle of next line

  • editing/SelectionController.cpp: (WebCore::SelectionController::modify): Added lineBoundary to test fix.
  • editing/visible_units.cpp: (WebCore::endOfLine): If the last box on the line is a lineBreak, return the position before it, not after it.
5:55 PM Changeset in webkit [16383] by bdash
  • 4 edits in trunk/WebKitTools

2006-09-15 Mark Rowe <​opendarwin.org@bdash.net.nz>

Reviewed by Brady.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10635
Bug 10635: Buildbot configuration in SVN is out of sync with build.webkit.org

  • BuildSlaveSupport/build.webkit.org-config/webkit/builders.py: Reorder build slaves within build factories in an attempt to spread the load evenly.
  • BuildSlaveSupport/build.webkit.org-config/webkit/status.py: Return to sending status emails to <svnuser>@opensource.apple.com addresses.
  • BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Update configuration to match changes in Buildbot. Always do clean SVG builds.
5:39 PM Changeset in webkit [16382] by bdash
  • 18 edits
    1 add in trunk

2006-09-15 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Adam.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10864
Bug 10864: Linux\GDK build fixes

  • JavaScriptCoreSources.bkl:
  • jscore.bkl:

2006-09-15 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Adam.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10864
Bug 10864: Linux\GDK build fixes

  • Projects/gdk/webcore-gdk.bkl:
  • WebCoreSources.bkl:
  • platform/gdk/FontCacheGdk.cpp:
  • platform/gdk/FontDataGdk.cpp: (WebCore::FontData::platformInit):
  • platform/gdk/FontGdk.cpp: (WebCore::Font::drawGlyphs):
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::handleGdkEvent):
  • platform/gdk/FrameGdk.h:
  • platform/gdk/ImageGdk.cpp: Added. (WebCore::Image::initPlatformData): (WebCore::Image::invalidatePlatformData): (WebCore::Image::loadPlatformResource): (WebCore::Image::supportsType):
  • platform/gdk/RenderPopupMenuGdk.cpp: (WebCore::RenderPopupMenuGdk::hidePopup):
  • platform/gdk/RenderPopupMenuGdk.h:
  • platform/gdk/ScreenGdk.cpp: (WebCore::drawableForPage): (WebCore::screenRect): (WebCore::screenDepth): (WebCore::usableScreenRect): (WebCore::scaleFactor):
  • platform/gdk/SystemTimeLinux.cpp: (WebCore::currentTime):
  • platform/gdk/TemporaryLinkStubs.cpp: (FrameGdk::bindingRootObject): (FrameGdk::markMisspellings): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (FrameGdk::shouldChangeSelection): (FrameGdk::respondToChangedSelection): (FrameGdk::respondToChangedContents): (Path::contains): (PlatformScrollBar::PlatformScrollBar): (PlatformScrollBar::~PlatformScrollBar): (PlatformScrollBar::width): (PlatformScrollBar::height): (PlatformScrollBar::setEnabled): (PlatformScrollBar::paint): (PlatformScrollBar::setScrollBarValue): (PlatformScrollBar::setKnobProportion): (PlatformScrollBar::setRect): (ScrollBar::ScrollBar): (FileChooser::FileChooser): (FileChooser::~FileChooser): (FileChooser::openFileChooser): (FileChooser::basenameForWidth): (FileChooser::uploadControlDetaching): (FileChooser::chooseFile): (Icon::Icon): (Icon::~Icon): (Icon::newIconForFile): (Icon::paint): (IconLoader::stopLoading): (IconLoader::startLoading): (IconLoader::createForFrame): (IconDatabase::isIconExpiredForIconURL): (IconDatabase::hasEntryForIconURL): (IconDatabase::sharedIconDatabase):
  • platform/gdk/WidgetGdk.cpp:
  • webcore-base.bkl:
5:36 PM Changeset in webkit [16381] by thatcher
  • 3 edits in trunk/LayoutTests

Reviewed by Justin.

Updating results to new expected values.

  • fast/lists/drag-into-marker-expected.txt:
  • fast/repaint/selection-after-delete-expected.txt:
5:26 PM Changeset in webkit [16380] by aroben
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

4:57 PM Changeset in webkit [16379] by thatcher
  • 3 edits in trunk/LayoutTests

Reviewed by Justin.

Updating results to new expected values.

  • editing/inserting/4278698-expected.txt:
  • fast/dom/window-xy-properties-expected.txt:
4:55 PM Changeset in webkit [16378] by bdash
  • 18 edits
    1 add in trunk/WebCore

2006-09-15 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Eric.

Fixes: ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10835
Fix svg memory leaks.

Reworked SVGList to deal with RefPtr's for ptr types
which makes manual refcounting unnecessary, and is much safer.

Removing all virtual functions (nullItem) from SVGList, and
also remove SVGListBase. Switch to a similar concept like
Vector/VectorTraits (see new file SVGListTraits.h).

Credits go to Eric/Maciej for the inspiration.

  • CMakeLists.txt: Add SVGListTraits.cpp to build
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Generator changes for SVGTransform/PathSeg/LengthList (now RefPtr based)
  • kcanvas/RenderSVGText.cpp: Add some get() methods, as SVGLengthList is RefPtr based now. (WebCore::RenderSVGText::translationForAttributes):
  • ksvg2/svg/SVGAnimateTransformElement.cpp: Add some get() methods, as SVGTransformList is RefPtr based now. (WebCore::SVGAnimateTransformElement::handleTimerEvent):
  • ksvg2/svg/SVGElementInstanceList.cpp: Be RefPtr based. (WebCore::SVGElementInstanceList::SVGElementInstanceList):
  • ksvg2/svg/SVGElementInstanceList.h:
  • ksvg2/svg/SVGLengthList.cpp: Ditto. (WebCore::SVGLengthList::SVGLengthList):
  • ksvg2/svg/SVGLengthList.h: Ditto.
  • ksvg2/svg/SVGList.h: Rewrote, as described above. (WebCore::SVGListTypeOperations::nullItem): (WebCore::SVGList::SVGList): (WebCore::SVGList::~SVGList): (WebCore::SVGList::clear): (WebCore::SVGList::getFirst): (WebCore::SVGList::getLast): (WebCore::SVGList::getItem): (WebCore::SVGList::replaceItem): (WebCore::SVGList::removeItem):
  • ksvg2/svg/SVGListTraits.cpp: Added.
  • ksvg2/svg/SVGListTraits.h: Added. (WebCore::):
  • ksvg2/svg/SVGPathElement.cpp: Add some get() methods, as SVGPathSegList is RefPtr based now. (WebCore::SVGPathElement::toPathData):
  • ksvg2/svg/SVGPathSegList.cpp: Be RefPtr based. (WebCore::SVGPathSegList::SVGPathSegList):
  • ksvg2/svg/SVGPathSegList.h: Ditto.
  • ksvg2/svg/SVGTransform.cpp: Style cleanup. (SVGTransform::SVGTransform):
  • ksvg2/svg/SVGTransformList.cpp: Be RefPtr based. (SVGTransformList::SVGTransformList): (SVGTransformList::createSVGTransformFromMatrix): (SVGTransformList::consolidate):
  • ksvg2/svg/SVGTransformList.h: Ditto.
  • ksvg2/svg/SVGTransformable.cpp: Fix RefPtr usage of SVGTransform. (SVGTransformable::parseTransformAttribute):
4:30 PM Changeset in webkit [16377] by eseidel
  • 5 edits in trunk/WebCore

2006-09-15 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Fix build on Qt/Linux and implement Frame::addMessageToConsole to
be able to see javascript errors for instance.

  • CMakeLists.txt:
  • platform/qt/FrameQt.h:
  • platform/qt/FrameQt.cpp: Implement addMessageToConsole. (WebCore::FrameQt::bindingRootObject):
  • platform/qt/TemporaryLinkStubs.cp (WebCore::IconDatabase::hasEntryForIconURL): (WebCore::IconDatabase::sharedIconDatabase):
3:47 PM Changeset in webkit [16376] by andersca
  • 2 edits in trunk/JavaScriptCore

2006-09-15 Anders Carlsson <​acarlsson@apple.com>

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Fix the release build.
3:31 PM Changeset in webkit [16375] by aroben
  • 2 edits in trunk/WebKit

Reviewed by eseidel.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10876
containsItemForURLUnicode uses matchLetter instead of
matchUnicodeLetter

Small fixes for _WebCoreHistoryProvider.

  • History/WebHistory.m: Consistently use BUFFER_SIZE #define (-[_WebCoreHistoryProvider containsItemForURLLatin1:length:]): (-[_WebCoreHistoryProvider containsItemForURLUnicode:length:]): Replace incorrect call to matchLetter to matchUnicodeLetter
3:23 PM Changeset in webkit [16374] by weinig
  • 35 edits in trunk/WebCore

Reviewed by Tim H.

Patch for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10869
Auto-generate the internal methods for the Objective-C bindings

  • Auto-generates the internal method (ie. the _fooBar and _fooBarWith methods) implementations where standard. For cases where a custom implementation was needed, added a [ObjCNoInternal] extended attribute to the corresponding IDL.
  • Some general cleanup of some of the non-generated bindings, to bring them in- line with what the generated bindings look like.
  • bindings/objc/DOM.mm: (-[DOMNode description]):
  • bindings/objc/DOMCSS.mm: (-[DOMCSSPrimitiveValue WebCore::]): (-[DOMDocument getComputedStyle::]): (-[DOMDocument getMatchedCSSRules::]):
  • bindings/objc/DOMEvents.mm: (-[DOMEvent WebCore::]):
  • bindings/objc/DOMHTML.mm:
  • bindings/objc/DOMHTMLDocument.mm: (-[DOMHTMLDocument title]): (-[DOMHTMLDocument setTitle:]): (-[DOMHTMLDocument referrer]): (-[DOMHTMLDocument domain]): (-[DOMHTMLDocument URL]): (-[DOMHTMLDocument body]): (-[DOMHTMLDocument setBody:]): (-[DOMHTMLDocument images]): (-[DOMHTMLDocument applets]): (-[DOMHTMLDocument links]): (-[DOMHTMLDocument forms]): (-[DOMHTMLDocument anchors]): (-[DOMHTMLDocument cookie]): (-[DOMHTMLDocument setCookie:]): (-[DOMHTMLDocument open]): (-[DOMHTMLDocument close]): (-[DOMHTMLDocument write:]): (-[DOMHTMLDocument writeln:]): (-[DOMHTMLDocument getElementById:]): (-[DOMHTMLDocument getElementsByName:]): (-[DOMHTMLDocument WebCore::]): (+[DOMHTMLDocument _HTMLDocumentWith:WebCore::]):
  • bindings/objc/DOMHTMLOptionElement.mm: (-[DOMHTMLOptionElement form]): (-[DOMHTMLOptionElement defaultSelected]): (-[DOMHTMLOptionElement setDefaultSelected:]): (-[DOMHTMLOptionElement text]): (-[DOMHTMLOptionElement index]): (-[DOMHTMLOptionElement disabled]): (-[DOMHTMLOptionElement setDisabled:]): (-[DOMHTMLOptionElement label]): (-[DOMHTMLOptionElement setLabel:]): (-[DOMHTMLOptionElement selected]): (-[DOMHTMLOptionElement setSelected:]): (-[DOMHTMLOptionElement value]): (-[DOMHTMLOptionElement setValue:]): (-[DOMHTMLOptionElement WebCore::]): (+[DOMHTMLOptionElement _HTMLOptionElementWith:WebCore::]):
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMNode.mm: (-[DOMNode dealloc]): (-[DOMNode finalize]): (-[DOMNode nodeName]): (-[DOMNode nodeValue]): (-[DOMNode setNodeValue:]): (-[DOMNode nodeType]): (-[DOMNode parentNode]): (-[DOMNode childNodes]): (-[DOMNode firstChild]): (-[DOMNode lastChild]): (-[DOMNode previousSibling]): (-[DOMNode nextSibling]): (-[DOMNode attributes]): (-[DOMNode ownerDocument]): (-[DOMNode insertBefore::]): (-[DOMNode replaceChild::]): (-[DOMNode removeChild:]): (-[DOMNode appendChild:]): (-[DOMNode hasChildNodes]): (-[DOMNode cloneNode:]): (-[DOMNode normalize]): (-[DOMNode isSupported::]): (-[DOMNode namespaceURI]): (-[DOMNode prefix]): (-[DOMNode setPrefix:]): (-[DOMNode localName]): (-[DOMNode hasAttributes]): (-[DOMNode isSameNode:]): (-[DOMNode isEqualNode:]): (-[DOMNode isDefaultNamespace:]): (-[DOMNode lookupPrefix:]): (-[DOMNode lookupNamespaceURI:]): (-[DOMNode textContent]): (-[DOMNode setTextContent:]): (-[DOMNode boundingBox]): (-[DOMNode lineBoxRects]):
  • bindings/objc/DOMObject.mm: (-[DOMObject _init]):
  • bindings/objc/DOMXPath.mm: (-[DOMNativeXPathNSResolver dealloc]): (-[DOMNativeXPathNSResolver finalize]): (-[DOMNativeXPathNSResolver WebCore::]): (-[DOMNativeXPathNSResolver _initWithXPathNSResolver:WebCore::]): (+[DOMNativeXPathNSResolver _xpathNSResolverWith:WebCore::]): (-[DOMNativeXPathNSResolver lookupNamespaceURI:]):
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]): (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]):
  • css/CSSCharsetRule.idl:
  • css/CSSFontFaceRule.idl:
  • css/CSSImportRule.idl:
  • css/CSSMediaRule.idl:
  • css/CSSPageRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/CSSRule.idl:
  • css/CSSStyleRule.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSUnknownRule.idl:
  • css/CSSValue.idl:
  • css/CSSValueList.idl:
  • css/StyleSheet.idl:
  • dom/Event.idl:
  • dom/KeyboardEvent.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/NodeIterator.idl:
  • dom/OverflowEvent.idl:
  • dom/TreeWalker.idl:
  • dom/UIEvent.idl:
  • dom/WheelEvent.idl:
3:10 PM Changeset in webkit [16373] by aroben
  • 7 edits in trunk

WebCore:

Reviewed by timothy.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10865
New file upload control should match the width of the old one

Make width of new file upload control match the old one as closely as
possible.

  • rendering/RenderFileUploadControl.cpp:

LayoutTests:

Reviewed by timothy.

Part of ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10865
New file upload control should match the width of the old one

Update tests to match new file upload control.

  • fast/forms/file-input-disabled-expected.txt:
  • fast/forms/form-element-geometry-expected.txt:
  • fast/forms/input-appearance-height-expected.txt:
  • fast/forms/input-value-expected.txt:
3:01 PM Changeset in webkit [16372] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Eric.

Remove the SVG IDL files from the Copy Resources phase.

  • WebCore.xcodeproj/project.pbxproj:
2:52 PM Changeset in webkit [16371] by andersca
  • 11 edits
    1 add in trunk/JavaScriptCore

2006-09-15 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Steve.

Add JavaScriptCore API to the build.

  • API/JSBase.cpp:
  • API/JSCallbackConstructor.cpp:
  • API/JSCallbackFunction.cpp:
  • API/JSCallbackObject.cpp:
  • API/JSClassRef.cpp:
  • API/JSContextRef.cpp:
  • API/JSObjectRef.cpp:
  • API/JSStringRef.cpp:
  • API/JSValueRef.cpp:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • os-win32/stdbool.h: Added.
2:48 PM Changeset in webkit [22175] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-09-15 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Steve.

1:58 PM Changeset in webkit [22174] by aroben
  • 6 edits
    3 adds in branches/WindowsMerge

WebCore:

Reviewed by sfalken.

Implement historyContains() on Windows (rdar://4733770)

  • WebCore.vcproj/WebCore.vcproj: Add platform\win\WebCoreHistory.{cpp,h} and bridge\win\HistoryWin.cpp to project.
  • bridge/win/HistoryWin.cpp: Added. (WebCore::historyContains):
  • platform/win/TemporaryLinkStubs.cpp: Remove stub for WebCore::historyContains()
  • platform/win/WebCoreHistory.cpp: Added. (WebCore::WebCoreHistory::setHistoryProvider): (WebCore::WebCoreHistory::historyProvider):
  • platform/win/WebCoreHistory.h: Added.

WebKit:

Reviewed by sfalken.

Implement historyContains() on Windows (rdar://4733770)

  • WebHistory.cpp: Add new private _WebCoreHistoryProvider class. (WebHistory::setOptionalSharedHistory): Call WebCore::WebCoreHistory::setHistoryProvider so that WebCore can access history. (WebHistory::itemForURL): Extract itemForURLString method. (WebHistory::itemForURLString): Added. (WebHistory::containsItemForURLString): Added. (_WebCoreHistoryProvider::_WebCoreHistoryProvider): Added. (_WebCoreHistoryProvider::~_WebCoreHistoryProvider): Added. (matchLetter): Ported from Mac's WebHistory.m. (matchUnicodeLetter): Ditto. (_WebCoreHistoryProvider::containsItemForURLLatin1): Ditto. (_WebCoreHistoryProvider::containsItemForURLUnicode): Ditto.
  • WebHistory.h: Fix typo: IID_WebHistoryItemPrivate --> IID_WebHistoryPrivate, added new methods to IWebHistoryPrivate and WebHistory
11:09 AM Changeset in webkit [16370] by kmccullo
  • 3 edits in trunk/LayoutTests
  • just layout test result changes
  • fast/dom/Range/range-compareNode-expected.txt:
  • fast/dom/Range/range-intersectsNode-expected.txt:
2:38 AM Changeset in webkit [16369] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Eric Siedel

Dumped the use of CGColorRef and directly use the floating point data from
WebCore::Color

This fixes the performance regression found between 16285 and 16286

  • platform/mac/FontMac.mm: (WebCore::Font::drawComplexText): (WebCore::Font::drawGlyphs):

Sep 14, 2006:

11:09 PM Changeset in webkit [16368] by bdash
  • 4 edits in trunk/WebCore

2006-09-14 Mark Rowe <​opendarwin.org@bdash.net.nz>

Reviewed by Adam.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=10838
Bug 10838: REGRESSION: Leaking of WebScriptObjectPrivate

FrameMac relies on its cleanupPluginObjects being called to perform cleanup. The virtual
Frame::cleanupPluginObjects method is called from Frame's destructor, which results
in Frame::cleanupPluginObjects being called rather than FrameMac::cleanupPluginObjects.

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::~FrameMac): Call cancelAndClear to ensure that FrameMac::cleanupPluginObjects will be called from Frame::clear
  • page/Frame.cpp: (WebCore::Frame::~Frame): Use cancelAndClear. (WebCore::Frame::cancelAndClear): Move cancellation and clearing into a separate method that FrameMac can use.
  • page/Frame.h:
4:44 PM Changeset in webkit [16367] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej's rubber stamp

Exact same fix I just made, but in the other method I horked up
Also added a reference to the bugzilla in comments

  • page/Frame.cpp: (WebCore::Frame::endIfNotLoading): (WebCore::Frame::stop):
3:58 PM Changeset in webkit [16366] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej

Fixed a bad iFrame crash, resolving some of the layout test badness


  • page/Frame.cpp: (WebCore::Frame::endIfNotLoading):
  • Added a RefPtr to protect the frame itself to prevent its destruction during this method
12:52 PM Changeset in webkit [16365] by justing
  • 9 edits
    12 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4655880> Up/Down arrows skip over To Do

  • editing/selection/mixed-editability-3-expected.checksum: Added.
  • editing/selection/mixed-editability-3-expected.png: Added.
  • editing/selection/mixed-editability-3-expected.txt: Added.
  • editing/selection/mixed-editability-3.html: Added.
  • editing/selection/mixed-editability-4-expected.checksum: Added.
  • editing/selection/mixed-editability-4-expected.png: Added.
  • editing/selection/mixed-editability-4-expected.txt: Added.
  • editing/selection/mixed-editability-4.html: Added.
  • editing/selection/mixed-editability-5-expected.checksum: Added.
  • editing/selection/mixed-editability-5-expected.png: Added.
  • editing/selection/mixed-editability-5-expected.txt: Added.
  • editing/selection/mixed-editability-5.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4655880> Up/Down arrows skip over To Do

  • bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge canDeleteRange:]): Added a FIXME.
  • dom/Node.cpp: Removed the unused inSameRootEditableElement.
  • dom/Node.h:
  • editing/SelectionController.cpp: (WebCore::SelectionController::modify): Added documentboundary to granularities in order test a fix.
  • editing/visible_units.cpp: (WebCore::previousLinePosition): Use highestEditableRoot so that this function can move from editable content into editable content that's embedded in non-editable content. (WebCore::nextLinePosition): Ditto. (WebCore::startOfEditableContent): Renamed from startOfEditableRoot and use highestEditableRoot. This is the behavior that callers desire. This fixes Command + Up/Down. (WebCore::endOfEditableContent): Ditto.
  • editing/visible_units.h:
10:34 AM Changeset in webkit [22173] by sfalken
  • 4 edits in branches/WindowsMerge

2006-09-14 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Lou Amadio.

iBench fix - fix null deref in form submission case without a form element.

  • WebFrame.cpp: (WebFrame::submitForm):

2006-09-14 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Lou Amadio.

iBench fix - fix WinInet form post code to not reference a stale pointer.
(found by Application Verifier)

  • platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoaderWndProc):
10:30 AM Changeset in webkit [22172] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by sfalken.

A little #include cleanup

  • WebCore.vcproj/WebCore.vcproj: Add loader/icon to AdditionalIncludeDirectories
  • platform/win/TemporaryLinkStubs.cpp: Remove "loader/icon" from #include of IconLoader.h
10:07 AM Changeset in webkit [16364] by aroben
  • 3 edits in trunk/WebCore

2006-09-14 Karthik Kumar <​karthikkumar@gmail.com>

Reviewed by timothy. Landed by aroben.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10856
Windows build fixes after r16360

  • WebCore.vcproj/WebCore/WebCore.vcproj: Add loader\icon to AdditionalIncludeDirectories
  • platform/win/TemporaryLinkStubs.cpp: Add link stubs for IconLoader, IconDatabase (IconLoader::stopLoading): (IconLoader::startLoading): (IconLoader::createForFrame): (IconDatabase::isIconExpiredForIconURL): (IconDatabase::hasEntryForIconURL): (IconDatabase::sharedIconDatabase):
2:00 AM Changeset in webkit [16363] by beidson
  • 4 edits in trunk/WebCore

Part of a build fix - rest will be filling in some temporary link stubs

1:50 AM Changeset in webkit [22171] by beidson
  • 3 edits in branches/WindowsMerge/WebCore

Build Fix

1:08 AM Changeset in webkit [16362] by bdash
  • 7 edits in trunk

2006-09-14 Graham Dennis <​graham.dennis@gmail.com>

Reviewed by Justin Garcia.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Prevent a crash by makeing sure that the 'beyondEnd' node is after the start node.

2006-09-14 Graham Dennis <​graham.dennis@gmail.com>

Reviewed by Justin Garcia.

Modified testcase for:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10726
Crash in ApplyStyleCommand::applyRelativeFontStyleChange

  • editing/style/table-selection-expected.checksum:
  • editing/style/table-selection-expected.png:
  • editing/style/table-selection-expected.txt:
  • editing/style/table-selection.html: This testcase was for 10579, which is very similar to this bug (10726) Now the testcase tests both bugs.
12:29 AM Changeset in webkit [16361] by bdash
  • 3 edits in trunk/WebCore

2006-09-14 MorganL <​morlmor@yahoo.com>

Reviewed by Brady.

Fixes ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10845
Various bugs/crashes in ResourceLoaderWin with local files.

  • platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
  • platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): (WebCore::ResourceLoader::fileLoadTimer):
12:20 AM Changeset in webkit [16360] by beidson
  • 17 edits
    3 adds in trunk

WebCore:

Reviewed by Maciej

Icon loads now take place in WebCore

  • WebCore.xcodeproj/project.pbxproj:
  • bridge/BrowserExtension.h:
  • bridge/mac/BrowserExtensionMac.h:
  • bridge/mac/BrowserExtensionMac.mm:
  • Moved enforcement of a Mozilla Favicon extension elsewhere


  • bridge/mac/FrameMac.h:
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::originalRequestURL):
  • Added accessor to "original request URL"


  • bridge/mac/WebCoreFrameBridge.h:
  • Removed methods to set the iconURL as all loading is now done in WebCore
  • Added call throughs to notify WebKit an Icon is done loading, and a to get the original request URL


  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):
  • Moved enforcement of a Mozilla Favicon extension elsewhere


  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::setIconURLForPageURL):
  • Changed an ASSERT to correctly handle a sketchy (invalid) situation
  • loader/icon/IconLoader.h: Added.
  • loader/icon/IconLoader.cpp: Added. (IconLoader::IconLoader): (IconLoader::createForFrame):
  • Static factory method with a private constructor to enforce "you MUST have a Frame to create an IconLoader" semantics (IconLoader::~IconLoader): (IconLoader::startLoading): (IconLoader::stopLoading): (IconLoader::receivedData):
  • ResourceLoaderClient delegate (IconLoader::receivedAllData):
  • Ditto
  • loader/mac/IconLoaderMac.mm: Added. (IconLoader::receivedResponse): (IconLoader::notifyIconChanged):
  • For now, these are platform specific methods
  • One to get the HTTP response code of an icon load
  • The other to call through to the app when the icon has changed (loaded)
  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::iconURL): (WebCore::Frame::setIconURL):
  • Frame objects now have an inherent icon URL and a way to calculate/access it (WebCore::Frame::endIfNotLoading):
  • This is where we actually kick off the IconLoader (WebCore::Frame::stop):
  • Added call to stop loading the icon
  • page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): (WebCore::FramePrivate::~FramePrivate):
  • Added the icon URL as a private member
  • Added the IconLoader as a private member, and clean it up on deletion
  • platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start): Added a valuable ASSERT

WebKit:

Reviewed by Maciej

Add infrastructure to support icon loads taking place in WebCore
Will remove WebKit icon loaders in a later patch

  • WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge notifyIconChanged:]): (-[WebFrameBridge originalRequestURL]):
  • Nuked two old, obsolete methods
  • Added bridge for notifying of an icon change
  • Added bridge for getting the "original request URL" which is still needed until that info is available in the WebCore loaders
  • WebView/WebDataSource.m: (-[WebDataSource _loadIcon]):
  • Empty body just for now, as it still gets called - next patch will prune all the old impl out
12:01 AM Changeset in webkit [16359] by hyatt
  • 5 edits in trunk/WebCore

Fix for 10841, unable to check checkboxes inside labels.

Reviewed by xenon, bradee-oh

  • css/html4.css:
  • dom/Element.cpp: (WebCore::Element::contains):
  • dom/Element.h:
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::defaultEventHandler):
Note: See TracTimeline for information about the timeline view.