Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Oct 7, 2006:

11:15 PM Changeset in webkit [22337] by hyatt

• 1 edit in branches/WindowsMerge/WebCore/ChangeLog

Add code to paint the Windows Classic/2000 look for scrollbars.

6:08 PM Changeset in webkit [16886] by andersca

• 2 edits in trunk/WebCore

2006-10-07 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

Remove crossDomain, it was unused and is one of the last functions that use DeprecatedStringList.

• loader/loader.cpp: (WebCore::Loader::servePendingRequests):

5:44 PM Changeset in webkit [16885] by andersca

• 18 edits in trunk/WebCore

2006-10-07 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

Convert a bunch of RefPtr<StringImpl> to String.

• bridge/mac/FrameMac.h:
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::didTellBridgeAboutLoad): (WebCore::FrameMac::haveToldBridgeAboutLoad):
• dom/BeforeUnloadEvent.cpp: (WebCore::BeforeUnloadEvent::storeResult):
• dom/BeforeUnloadEvent.h: (WebCore::BeforeUnloadEvent::result):
• dom/Document.cpp: (WebCore::Document::createEntityReference):
• dom/Entity.cpp: (WebCore::Entity::Entity): (WebCore::Entity::nodeName): (WebCore::Entity::toString):
• dom/Entity.h: (WebCore::Entity::publicId): (WebCore::Entity::systemId): (WebCore::Entity::notationName):
• dom/EntityReference.cpp: (WebCore::EntityReference::EntityReference): (WebCore::EntityReference::nodeName): (WebCore::EntityReference::cloneNode): (WebCore::EntityReference::toString):
• dom/EntityReference.h:
• dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::KeyboardEvent): (WebCore::KeyboardEvent::initKeyboardEvent):
• dom/KeyboardEvent.h: (WebCore::KeyboardEvent::keyIdentifier):
• dom/MutationEvent.cpp: (WebCore::MutationEvent::MutationEvent): (WebCore::MutationEvent::initMutationEvent):
• dom/MutationEvent.h: (WebCore::MutationEvent::prevValue): (WebCore::MutationEvent::newValue): (WebCore::MutationEvent::attrName):
• dom/Notation.cpp: (WebCore::Notation::Notation): (WebCore::Notation::nodeName):
• dom/Notation.h: (WebCore::Notation::publicId): (WebCore::Notation::systemId):
• dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::ProcessingInstruction): (WebCore::ProcessingInstruction::setData): (WebCore::ProcessingInstruction::nodeName): (WebCore::ProcessingInstruction::nodeValue): (WebCore::ProcessingInstruction::cloneNode): (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::toString):
• dom/ProcessingInstruction.h: (WebCore::ProcessingInstruction::target): (WebCore::ProcessingInstruction::data): (WebCore::ProcessingInstruction::localHref):

3:49 PM Changeset in webkit [22336] by hyatt

• 2 edits in branches/WindowsMerge/WebCore

Make sure frames honor scrolling modes and margins.

12:22 PM Changeset in webkit [22335] by aroben

• 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders.

Merge of OpenSource r16884
​http://bugs.webkit.org/show_bug.cgi?id=11199
Update Session History when a load is committed rather than completed.

• WebFrame.cpp: (WebFrame::receivedResponse): (WebFrame::receivedAllData):

11:53 AM Changeset in webkit [16884] by aroben

• 2 edits in trunk/WebKit

Reviewed/landed by Adam.

​http://bugs.webkit.org/show_bug.cgi?id=11199
Update Session History when a load is committed rather than completed.

• COM/WebFrame.cpp: (WebFrame::receivedResponse): (WebFrame::receivedAllData):

11:42 AM Changeset in webkit [22334] by aroben

• 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve.

Fix for failed ASSERT on iBench.

• WebFrame.cpp: (WebFrame::receivedAllData): Be a bit more lenient about what ResourceLoader has called WebFrame::receivedAllData

10:24 AM Changeset in webkit [16883] by weinig

• 24 edits in trunk/WebCore

Reviewed by Tim H.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11206
10 more SVG Objective-C auto-generated bindings

• Auto-generate DOMSVGFilterElement, DOMSVGFitToViewBox, DOMSVGForeignObjectElement, DOMSVGGElement, DOMSVGGradientElement, DOMSVGImageElement, DOMSVGLineElement, DOMSVGLinearGradientElement, DOMSVGMarkerElement, DOMSVGMaskElement and DOMSVGPaint.

• Auto-generate the text method for DOMRange.

• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• bindings/objc/DOM.mm:
• bindings/objc/DOMExtensions.h:
• bindings/objc/DOMInternal.h:
• bindings/objc/DOMPrivate.h:
• bindings/objc/DOMRGBColor.mm:
• bindings/objc/DOMSVG.h:
• bindings/objc/PublicDOMInterfaces.h:
• bindings/scripts/CodeGeneratorObjC.pm:
• dom/Range.idl:
• ksvg2/svg/SVGFilterElement.cpp:
• ksvg2/svg/SVGFilterElement.h:
• ksvg2/svg/SVGFilterElement.idl:
• ksvg2/svg/SVGForeignObjectElement.idl:
• ksvg2/svg/SVGGElement.idl:
• ksvg2/svg/SVGGradientElement.idl:
• ksvg2/svg/SVGImageElement.idl:
• ksvg2/svg/SVGLineElement.idl:
• ksvg2/svg/SVGLinearGradientElement.idl:
• ksvg2/svg/SVGMarkerElement.idl:
• ksvg2/svg/SVGMaskElement.idl:
• ksvg2/svg/SVGPaint.idl:

5:58 AM Changeset in webkit [16882] by weinig

• 14 edits
  1 move
  1 add
  3 deletes in trunk

WebCore:

Reviewed by Tim H.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11198
Auto-generate a few more Objective-C DOM interfaces

• Fully auto-generate DOMAbstractView and DOMRange.

• Auto-generate just the interface for DOMRGBColor.

• Add DOMRanges.h as the new top level file for Ranges module.

• Add DOMRanges.h and DOMXPath.h to DOM.mm

• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• bindings/objc/DOM.h:
• bindings/objc/DOM.mm:
• bindings/objc/DOMAbstractView.h: Removed.
• bindings/objc/DOMAbstractView.mm: Removed.
• bindings/objc/DOMInternal.h:
• bindings/objc/DOMPrivate.h:
• bindings/objc/DOMRGBColor.h: Removed.
• bindings/objc/DOMRGBColor.mm:
• bindings/objc/DOMRange.h: Removed.
• bindings/objc/DOMRanges.h: Added.
• bindings/objc/PublicDOMInterfaces.h:
• bindings/scripts/CodeGeneratorObjC.pm:
• css/RGBColor.idl:
• dom/Range.idl:
• page/AbstractView.idl: Added.

WebKit:

Reviewed by Tim H.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11198
Auto-generate a few more Objective-C DOM interfaces

• MigrateHeaders.make:

5:39 AM Changeset in webkit [16881] by bdash

• 3 edits
  4 adds in trunk

2006-10-07 Andrew Wellington <​proton@wiretapped.net>

Reviewed by Eric.

Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit
​http://bugzilla.opendarwin.org/show_bug.cgi?id=10837

Return null when there is no frame. This matches Firefox.

• bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::getValueProperty):

2006-10-07 Andrew Wellington <​proton@wiretapped.net>

Reviewed by Eric.

Test for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10837
Bug 10837: REGRESSION: Yahoo New Charts Crashes WebKit

• fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.checksum: Added.
• fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.png: Added.
• fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.txt: Added.
• fast/dom/HTMLDocument/frameless-location-bugzilla10837.html: Added.

5:04 AM Changeset in webkit [16880] by hyatt

• 2 edits in trunk/WebCore/platform

Fix win32 and qt bustage.

4:41 AM Changeset in webkit [16879] by hyatt

• 5 edits in trunk/WebCore

Implement scroll corner painting (a white rect fill) for overflow areas to cover up
scrollbar joins properly.

Refactor painting of scrollbars and resizers into common functions. Eliminate the
extra 20 bytes per RenderLayer by cutting out m_resizerImage and m_resizerControlRect.

Reviewed by mitz

• page/FrameView.cpp: (WebCore::selectCursor): (WebCore::FrameView::handleMouseMoveEvent):
• platform/mac/PlatformScrollBar.h: (WebCore::PlatformScrollbar::horizontalScrollbarHeight): (WebCore::PlatformScrollbar::verticalScrollbarWidth):
• rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::scrollCornerRect): (WebCore::RenderLayer::positionOverflowControls): (WebCore::RenderLayer::paintOverflowControls): (WebCore::RenderLayer::isPointInResizeControl): (WebCore::RenderLayer::paintLayer):
• rendering/RenderLayer.h:

3:42 AM Changeset in webkit [16878] by bdash

• 2 edits in trunk/WebKit

2006-10-07 Mark Rowe <​bdash@webkit.org>

Reviewed by Mitz.

Fix memory leak from -[WebDocumentLoadState setTitle:].

• Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState setTitle:]): Ensure 'trimmed' is released even when length is zero, and untangle the confusing logic around this case.

2:32 AM Changeset in webkit [16877] by bdash

• 6 edits in trunk/WebCore

2006-10-07 Mark Rowe <​bdash@webkit.org>

Reviewed by Mitz.

Linux/Gdk build fixes, primarily consisting of s/ScrollBar/Scrollbar/ and
matching recent ResourceLoader changes.

• platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::openURL): (WebCore::FrameGdk::urlSelected):
• platform/gdk/PlatformScrollBar.h:
• platform/gdk/ResourceLoaderCurl.cpp: (WebCore::ResourceLoader::start):
• platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::hScrollbarMode): (WebCore::ScrollView::vScrollbarMode): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode):
• platform/gdk/TemporaryLinkStubs.cpp: (FrameView::passMousePressEventToScrollbar): (Widget::removeFromParent): (ScrollView::addChild): (ScrollView::updateScrollbars): (ScrollView::scrollbarUnderMouse): (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::~PlatformScrollbar): (PlatformScrollbar::width): (PlatformScrollbar::height): (PlatformScrollbar::setEnabled): (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion): (PlatformScrollbar::setRect): (Scrollbar::Scrollbar): (Scrollbar::setSteps): (Scrollbar::scroll): (Scrollbar::setValue): (Scrollbar::setProportion):

1:20 AM Changeset in webkit [22333] by hyatt

• 1 edit in branches/WindowsMerge/WebCore/platform/win/ScrollViewWin.cpp

Fix build bustage from earlier checkin.

1:18 AM Changeset in webkit [22332] by hyatt

• 2 edits in branches/WindowsMerge/WebCore

Fix resizer coordinate space error.

Oct 6, 2006:

11:57 PM Changeset in webkit [22331] by hyatt

• 1 edit in branches/WindowsMerge/WebCore/platform/win/ScrollViewWin.cpp

Better fix for scrollbars coming and going affecting plugin clip.

11:32 PM Changeset in webkit [22330] by hyatt

• 2 edits in branches/WindowsMerge/WebCore

Update plugin clipping when scrollbars come/go.

11:06 PM Changeset in webkit [16876] by hyatt

• 1 edit in trunk/WebCore/platform/qt/ScrollViewQt.cpp

Fix Qt bustage.

11:04 PM Changeset in webkit [16875] by hyatt

• 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

Fix win32 bustage.

11:03 PM Changeset in webkit [16874] by hyatt

• 1 edit in trunk/WebCore/platform/mac/ScrollViewMac.mm

Remove x/y from the log message on debug Mac builds.

10:56 PM Changeset in webkit [22329] by hyatt

• 2 edits in branches/WindowsMerge/WebCore

Improve performance of plugin clipping when scrolling.

10:55 PM Changeset in webkit [16873] by beidson

• 16 edits in trunk/WebKit

Reviewed by Darin

Refactored a whole bunch of WebFramePrivate.h SPI to WebFrameInternal

• DefaultDelegates/WebDefaultContextMenuDelegate.m:
• History/WebHistoryItem.m:
• Loader/WebFrameLoader.h:
• Misc/WebCoreStatistics.m:
• Misc/WebElementDictionary.m:
• Plugins/WebNetscapePluginEmbeddedView.m:
• Plugins/WebPluginController.m:
• WebCoreSupport/WebViewFactory.m:
• WebView/WebArchiver.m:
• WebView/WebDataSource.m:
• WebView/WebFrame.m: (-[WebFrame _isDescendantOfFrame:]): (-[WebFrame _setShouldCreateRenderers:]): (-[WebFrame _bodyBackgroundColor]): (-[WebFrame _isFrameSet]): (-[WebFrame _firstLayoutDone]): (-[WebFrame _loadType]):
• WebView/WebFrameInternal.h:
• WebView/WebFramePrivate.h:
• WebView/WebHTMLRepresentation.m:
• WebView/WebScriptDebugDelegate.m:

10:43 PM Changeset in webkit [22328] by hyatt

• 4 edits in branches/WindowsMerge/WebCore

Implement clipping of plugins on Win32.

10:32 PM Changeset in webkit [16872] by hyatt

• 10 edits in trunk/WebCore

Add a new method for obtaining accurate window-level clip rectangles. Can be used even by windowed plugins to clip properly.

8:31 PM Changeset in webkit [16871] by bdash

• 3 edits
  3 adds in trunk/WebKitTools

2006-10-06 David Smith <​catfish.man@gmail.com>

Reviewed by Timothy.

Bug 9665: [Drosera] Conditional breakpoints. ​http://bugs.webkit.org/show_bug.cgi?id=9665

• Drosera/Drosera.xcodeproj/project.pbxproj: Added new files
• Drosera/breakpointEditor.css: Added.
• Drosera/breakpointEditor.html: Added.
• Drosera/breakpointEditor.js: Added.
• Drosera/debugger.js: Added conditional breakpoint support, and the ability to open the breakpoint editor window on option-clicking a breakpoint.

6:57 PM Changeset in webkit [22327] by ggaren

• 6 edits in branches/WindowsMerge

WebCoreWin:

Fixed <rdar://4768789> Crash on ebay.com in Frame::didOpenURL

The issue was a resource loader making a callback to a
frame after the frame had been destroyed. This doesn't happen on Mac
because Mac WebKit cancels all loads before tearing down frames.

The solution is to add a callback to Win WebKit to allow a frame
to cancel its main resource load. This is a temporary work-around.
It is temporary because it doesn't address pending subresource loads.
The long-term solution we anticipate is to have a legitimate loader
inside WebCore.

• ChangeLog:
• bridge/win/FrameWin.cpp: (WebCore::FrameWin::~FrameWin):
• bridge/win/FrameWin.h:

WebKitWin:

Reviewed by Adam Roben, esq.

Fixed <rdar://4768789> Crash on ebay.com in Frame::didOpenURL

The issue was a resource loader making a callback to a
frame after the frame had been destroyed. This doesn't happen on Mac
because Mac WebKit cancels all loads before tearing down frames.

The solution is to add a callback to Win WebKit to allow a frame
to cancel its main resource load. This is a temporary work-around.
It is temporary because it doesn't address pending subresource loads.
The long-term solution we anticipate is to have a legitimate loader
inside WebCore.

• WebFrame.cpp: (WebFrame::loadDataSource): (WebFrame::stopMainResourceLoad): (WebFrame::receivedAllData):
• WebFrame.h:

5:42 PM Changeset in webkit [16870] by mjs

• 6 edits in trunk/WebKit

Reviewed by Darin.

• Move all delegate dispatching code out of WebDataSource.

• Loader/WebFrameLoader.m: (-[WebFrameLoader startLoading]): (-[WebFrameLoader _identifierForInitialRequest:]): (-[WebFrameLoader _willSendRequest:forResource:redirectResponse:]): (-[WebFrameLoader _didReceiveAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didCancelAuthenticationChallenge:forResource:]): (-[WebFrameLoader _didReceiveResponse:forResource:]): (-[WebFrameLoader _didReceiveData:contentLength:forResource:]): (-[WebFrameLoader _didFinishLoadingForResource:]): (-[WebFrameLoader _didFailLoadingWithError:forResource:]): (-[WebFrameLoader _receivedMainResourceError:complete:]): (-[WebFrameLoader _downloadWithLoadingConnection:request:response:proxy:]): (-[WebFrameLoader _checkContentPolicyForMIMEType:andCall:withSelector:]):
• WebView/WebDataSource.m: (-[WebDataSource _setLoadingFromPageCache:]): (-[WebDataSource _stopLoadingWithError:]):
• WebView/WebDataSourceInternal.h:

5:36 PM Changeset in webkit [16869] by darin

• 6 edits in trunk/WebKit

Reviewed by Maciej.

• moved firstLayoutDone BOOL from WebFrame to WebFrameLoader

• Loader/WebFrameLoader.h:
• Loader/WebFrameLoader.m: (-[WebFrameLoader didFirstLayout]): (-[WebFrameLoader provisionalLoadStarted]): (-[WebFrameLoader frameLoadCompleted]): (-[WebFrameLoader firstLayoutDone]):
• WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge didFirstLayout]):
• WebView/WebFrame.m: (-[WebFrame _firstLayoutDone]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame _frameLoadCompleted]): (-[WebFrame _restoreScrollPositionAndViewState]):
• WebView/WebFrameInternal.h:

5:19 PM Changeset in webkit [16868] by darin

• 8 edits in trunk/WebKit

Reviewed by Maciej.

• moved more data and the corresponding code from WebFrame to WebFrameLoader

• Loader/WebFrameLoader.h:
• Loader/WebFrameLoader.m: (-[WebFrameLoader cannotShowMIMETypeForURL:]): (-[WebFrameLoader _checkNavigationPolicyForRequest:andCall:withSelector:]): (-[WebFrameLoader shouldReloadToHandleUnreachableURLFromRequest:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]): (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]): (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrameLoader _continueAfterNewWindowPolicy:]): (-[WebFrameLoader checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader continueAfterWillSubmitForm:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDataSource:withLoadType:formState:]): (-[WebFrameLoader handleUnimplementablePolicyWithErrorCode:forURL:]): (-[WebFrameLoader delegateIsHandlingProvisionalLoadError]): (-[WebFrameLoader setDelegateIsHandlingProvisionalLoadError:]):
• Loader/WebFrameLoaderClient.h:
• WebView/WebFrame.m: (-[NSView setWebFrame::]): (-[WebFramePrivate dealloc]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadItem:withLoadType:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): (-[WebFrame _loadRequest:inFrameNamed:]): (-[WebFrame stopLoading]): (-[WebFrame _resetBackForwardList]): (-[WebFrame _quickRedirectComing]): (-[WebFrame _provisionalItemIsTarget]): (-[WebFrame _loadProvisionalItemFromPageCache]):
• WebView/WebFrameInternal.h:
• WebView/WebFramePrivate.h:

• WebKit.xcodeproj/project.pbxproj:

4:00 PM Changeset in webkit [22326] by sfalken

• 2 edits in branches/WindowsMerge/WebKitWin

2006-10-06 Steve Falkenburg <​sfalken@apple.com>

Use a better versioning scheme.

Out version #s for Boomer are the same as the last Mac
submission + the addition of "b".

This first versioned submission is 521.28b

2006-10-06 Steve Falkenburg <​sfalken@apple.com>

Use a better versioning scheme.

Out version #s for Boomer are the same as the last Mac
submission + the addition of "b".

This first versioned submission is 521.28b

• WebKit.vcproj/WebKit.rc:

3:49 PM Changeset in webkit [16867] by mjs

• 2 edits in trunk/WebKit

Rubber stamped by Darin.

• removed includes of unused headers.

• WebView/WebDataSource.m:

3:42 PM Changeset in webkit [16866] by mjs

• 3 edits in trunk/WebKit

Not reviewed.

• fix build breakage

• Loader/WebFrameLoader.m: (-[WebFrameLoader willChangeTitleForDocumentLoadState:]): (-[WebFrameLoader didChangeTitleForDocumentLoadState:]):

3:38 PM Changeset in webkit [16865] by mjs

• 11 edits in trunk/WebKit

Reviewed by Darin.

• move remaining movable WebDataSource fields to WebDocumentLoadState

• Loader/WebDocumentLoadState.h:
• Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState dealloc]): (-[WebDocumentLoadState isLoadingInAPISense]): (-[WebDocumentLoadState addResponse:]): (-[WebDocumentLoadState stopRecordingResponses]): (-[WebDocumentLoadState title]): (-[WebDocumentLoadState setLastCheckedRequest:]): (-[WebDocumentLoadState lastCheckedRequest]): (-[WebDocumentLoadState triggeringAction]): (-[WebDocumentLoadState setTriggeringAction:]): (-[WebDocumentLoadState responses]): (-[WebDocumentLoadState setOverrideEncoding:]): (-[WebDocumentLoadState overrideEncoding]): (-[WebDocumentLoadState setTitle:]):
• Loader/WebFrameLoader.h:
• Loader/WebFrameLoader.m: (-[WebFrameLoader _setState:]): (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]): (-[WebFrameLoader reload]): (-[WebFrameLoader willChangeTitleForDocumentLoadState:]): (-[WebFrameLoader didChangeTitleForDocumentLoadState:]):
• WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge setTitle:]): (-[WebFrameBridge receivedData:textEncodingName:]):
• WebView/WebDataSource.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _didReceiveResponse:forResource:]): (-[WebDataSource textEncodingName]):
• WebView/WebDataSourceInternal.h:
• WebView/WebFrame.m: (-[WebFrame _opened]): (-[WebFrame _checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _addChild:]): (-[WebFrame _loadDataSource:withLoadType:formState:]):
• WebView/WebHTMLRepresentation.m: (-[WebHTMLRepresentation title]):
• WebView/WebView.m: (-[WebView _mainFrameOverrideEncoding]):

3:32 PM Changeset in webkit [16864] by thatcher

• 1 copy in tags/Safari-521.28b

New tag.

3:20 PM Changeset in webkit [22325] by sfalken

• 2 edits in branches/WindowsMerge/WebKitWin

2006-10-06 Steve Falkenburg <​sfalken@apple.com>

Bump version number.

• WebKit.vcproj/WebKit.rc:

2006-10-06 Steve Falkenburg <​sfalken@apple.com>

Bump version number.

2:52 PM Changeset in webkit [16863] by darin

• 6 edits in trunk/WebKit

Reviewed by Maciej.

• moved loadType into WebFrameLoader

• WebView/WebFramePrivate.h: Removed _setLoadType, but not _loadType because it's currently used by Safari.

• Loader/WebFrameLoader.h:
• Loader/WebFrameLoader.m: (-[WebFrameLoader _loadRequest:archive:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader isReplacing]): (-[WebFrameLoader setReplacing]): (-[WebFrameLoader loadType]): (-[WebFrameLoader setLoadType:]):
• WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge isLoadTypeReload]):
• WebView/WebFrame.m: (-[WebFrame _loadType]): (-[WebFrame _transitionToCommitted:]): (-[WebFrame _commitProvisionalLoad:]): (-[WebFrame _opened]): (-[WebFrame _checkLoadCompleteForThisFrame]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrame _loadURL:referrer:intoChild:]): (-[WebFrame _currentBackForwardListItemToResetTo]): (-[WebFrame _itemForRestoringDocState]): (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrame _didFirstLayout]): (-[WebFrame _addExtraFieldsToRequest:mainResource:alwaysFromRequest:]): (-[WebFrame _provisionalLoadStarted]): (-[WebFrame loadRequest:]):

2:34 PM Changeset in webkit [22324] by sfalken

• 7 edits in branches/WindowsMerge

2006-10-06 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam, Lou.

<rdar://4754295> Corrupt history.plist = crash on startup

Fix improper CF usage that likely led to retain/release imbalances.

Resizer fixes.
We now properly invalidate and draw overlapping contents or opaque.
Fix capture state after resize by posting a mouse up to balance the one that gets eaten (Thanks, Lou!)

2:25 PM Changeset in webkit [16862] by sfalken

• 3 edits in trunk/WebCore

2006-10-06 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

Add another method we'll need for scrollbar dodging

• platform/ScrollView.h:
• platform/win/TemporaryLinkStubs.cpp: (ScrollView::resizerOverlapsContent):

2:25 PM Changeset in webkit [16861] by darin

• 6 edits
  1 add in trunk/WebKit

Reviewed by Maciej.

• added WebFrameLoaderClient protocol -- to be used to make WebFrameLoader forget all about WebFrame

• Loader/WebDocumentLoadState.h: Added comment about Maciej's planned renaming here.
• Loader/WebFrameLoader.h:
• Loader/WebFrameLoader.m: Renamed webFrame to client and added the new protocol. Eventually we'll be removing the dependency on WebFrame entirely.
• WebView/WebFrame.m: (-[WebFrame _initWithWebFrameView:webView:bridge:]): Update to call the method by its new name.

• Loader/WebFrameLoaderClient.h: Added.
• WebKit.xcodeproj/project.pbxproj: Updated for new file, sorted things.

2:13 PM Changeset in webkit [16860] by weinig

• 14 edits
  9 deletes in trunk/WebCore

Reviewed by Tim H.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11191
Auto-generate the interfaces even for Objective-C DOM
bindings that need custom implementations

• Fully auto-generate DOMEventTarget, DOMNodeFilter and DOMHTMLOptionElement.

• Auto-generate just the interface for DOMHTMLAppletElement, DOMHTMLEmbedElement, DOMSVGNumber, DOMSVGPoint and DOMSVGRect using the new IDL property ObjCCustomImplementation.

• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• bindings/objc/DOMEventTarget.h: Removed.
• bindings/objc/DOMHTMLAppletElement.h: Removed.
• bindings/objc/DOMHTMLEmbedElement.h: Removed.
• bindings/objc/DOMHTMLOptionElement.h: Removed.
• bindings/objc/DOMHTMLOptionElement.mm: Removed.
• bindings/objc/DOMInternal.h:
• bindings/objc/DOMNodeFilter.h: Removed.
• bindings/objc/DOMSVGNumber.h: Removed.
• bindings/objc/DOMSVGPoint.h: Removed.
• bindings/objc/DOMSVGPoint.mm: (-[DOMSVGPoint matrixTransform:]):
• bindings/objc/DOMSVGRect.h: Removed.
• bindings/objc/PublicDOMInterfaces.h:
• bindings/scripts/CodeGeneratorObjC.pm:
• dom/EventTarget.idl:
• html/HTMLAppletElement.idl:
• html/HTMLEmbedElement.idl:
• html/HTMLOptionElement.idl:
• ksvg2/svg/SVGNumber.idl:
• ksvg2/svg/SVGPoint.idl:
• ksvg2/svg/SVGRect.idl:

2:11 PM Changeset in webkit [16859] by mjs

• 2 edits in trunk/WebKit

Reviewed by Darin.

• segregate WebFrame methods into ones that should be moved into WebFrameLoader and ones that don't need to

Also removed useless WebFrameLoader part

• WebView/WebFrame.m: (-[WebFramePrivate dealloc]):

2:04 PM Changeset in webkit [22323] by andersca

• 2 edits in branches/WindowsMerge/WebCore

2006-10-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam.

• plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::defaultPluginPaths): Add (commented out) WMP plugin check.

1:53 PM Changeset in webkit [22322] by andersca

• 2 edits
  5 adds in branches/WindowsMerge/WebKitTools

2006-10-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

Land new version of DumpRenderTree that uses the WebKit APIs.

1:48 PM Changeset in webkit [16858] by thatcher

• 4 edits in trunk

WebCore:

Reviewed by Tim H.

Make Qt/Linux compile again completly.

• platform/qt/WidgetQt.cpp: (WebCore::Widget::removeFromParent):

WebKitTools:

Reviewed by Tim H.

Fix Qt/Linux build by adapting the s/ScrollBar/Scrollbar/ changes.

• DumpRenderTree/DumpRenderTree.qtproj/DumpRenderTree.cpp: (WebCore::DumpRenderTree::DumpRenderTree):

1:42 PM Changeset in webkit [16857] by mjs

• 8 edits in trunk/WebKit

Reviewed by Anders.

• moved more data from WebDataSource to WebDocumentLoadState

• Loader/WebDocumentLoadState.h:
• Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState commitLoadWithData:]): (-[WebDocumentLoadState prepareForLoadStart]): (-[WebDocumentLoadState loadingStartedTime]): (-[WebDocumentLoadState setIsClientRedirect:]): (-[WebDocumentLoadState isClientRedirect]): (-[WebDocumentLoadState setPrimaryLoadComplete:]): (-[WebDocumentLoadState isLoadingInAPISense]):
• Loader/WebFrameLoader.h:
• Loader/WebFrameLoader.m: (-[WebFrameLoader _setState:]): (-[WebFrameLoader _finishedLoading]): (-[WebFrameLoader documentLoadState:mainReceivedCompleteError:]): (-[WebFrameLoader prepareForLoadStart]): (-[WebFrameLoader subframeIsLoading]):
• WebView/WebDataSource.m: (-[WebDataSource _fileWrapperForURL:]): (-[WebDataSource _startLoading]): (-[WebDataSource _loadFromPageCache:]): (-[WebDataSource isLoading]):
• WebView/WebDataSourceInternal.h:
• WebView/WebFrame.m: (-[WebFrame _transitionToCommitted:]): (-[WebFrame _opened]): (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):

1:36 PM Changeset in webkit [16856] by thatcher

• 4 edits in trunk/WebCore

Reviewed by Tim H.

Fix Qt/Linux build by adapting the s/ScrollBar/Scrollbar/ patch.

• platform/qt/PlatformScrollBar.h:
• platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::hScrollbarMode): (WebCore::ScrollView::vScrollbarMode): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::scrollbarUnderMouse):
• platform/qt/TemporaryLinkStubs.cpp: (WebCore::Scrollbar::Scrollbar): (WebCore::Scrollbar::setSteps): (WebCore::Scrollbar::scroll): (WebCore::Scrollbar::setValue): (WebCore::Scrollbar::setProportion): (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::~PlatformScrollbar): (WebCore::PlatformScrollbar::width): (WebCore::PlatformScrollbar::height): (WebCore::PlatformScrollbar::setEnabled): (WebCore::PlatformScrollbar::paint): (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion): (WebCore::PlatformScrollbar::setRect): (FrameView::passMousePressEventToScrollbar):

11:26 AM Changeset in webkit [22321] by andersca

• 2 edits in branches/WindowsMerge/WebCore

2006-10-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Brady and Geoff.

<rdar://problems/4769023>
Crash on cnettv.com - PluginStreamWin::receivedResponse

• platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoaderWndProc): If the Content-Type header is missing, try to figure o ut the content type from the file extension. Failing that, just use "application/octet-stream".

11:16 AM Changeset in webkit [16855] by kmccullo

• 4 edits in trunk/JavaScriptCore

Reviewed by Brady.

DST and TimeZones were wrong in some cases, specifically on some of the dates where DST changes.

• kjs/DateMath.cpp: (KJS::equivalentYearForDST): (KJS::getUTCOffset): (KJS::getDSTOffsetSimple): (KJS::getDSTOffset): (KJS::dateToMseconds): (KJS::msToTM):
• kjs/DateMath.h:
• kjs/date_object.cpp: (KJS::gmtoffset):

11:03 AM Changeset in webkit [16854] by brmorris

• 4 deletes in S60/branches/scriptable_plugins/WebCore

Remove some tmp files from revision control.

10:55 AM Changeset in webkit [16853] by ap

• 2 edits in trunk/WebKit

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11183
REGRESSION: Safari loads error pages unstyled

• WebView/WebFrame.m: (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): Use utf-8 encoding instead of the string's "fastest" encoding.

7:52 AM Changeset in webkit [16852] by yongjzha

• 3 edits in S60/trunk/WebKit

2006-10-06 yaharon <​yael.aharon@nokia.com>

Reviewed by Yongjun Zhang
DESC: Match page overview touch behavior to UI spec
​http://bugs.webkit.org/show_bug.cgi?id=11179

• BrowserView/inc/PointerEventHandler.h:
• BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::HandlePointerEventL): (CPointerEventHandler::HandlePageScalerPointerEventL): (CPointerEventHandler::AutoScroll):

5:28 AM Changeset in webkit [16851] by zbujtas

• 3 edits in S60/branches/3.1m/WebCore

2006-10-05 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas
DESC: Prevent multiple form submission
​http://bugs.webkit.org/show_bug.cgi?id=11170

merged from trunk r16849

WARNING: NO TEST CASES ADDED OR CHANGED

• kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm): (KWQKHTMLPart::KeyEvent): (KWQKHTMLPart::MouseDown): (KWQKHTMLPart::prepareForUserAction):
• kwq/KWQKHTMLPart.h:

5:25 AM Changeset in webkit [16850] by weinig

• 36 edits
  6 adds in trunk/WebCore

Reviewed by Tim H.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11177
Another round of Objective-C SVG DOM bindings auto-generation

• Auto-generate DOMSVGAnimatedNumberList, DOMSVGAnimatedRect, DOMSVGComponentTransferFunctionElement, DOMSVGFEBlendElement, DOMSVGFEColorMatrixElement, DOMSVGFEComponentTransferElement, DOMSVGFECompositeElement, DOMSVGFEDiffuseLightingElement, DOMSVGFEDisplacementMapElement, DOMSVGFEDistantLightElement, DOMSVGFEFloodElement, DOMSVGFEFuncAElement, DOMSVGFEFuncBElement, DOMSVGFEFuncGElement, DOMSVGFEFuncRElement, DOMSVGFEGaussianBlurElement, DOMSVGFEImageElement, DOMSVGFEMergeElement, DOMSVGFEMergeNodeElement, DOMSVGFEOffsetElement, DOMSVGFEPointLightElement, DOMSVGFESpecularLightingElement, DOMSVGFESpotLightElement, DOMSVGFETileElement, DOMSVGFETurbulenceElement, DOMSVGFilterPrimitiveStandardAttributes and DOMSVGNumberList.

• Adds interfaces and implementation stubs for DOMSVGNumber, DOMSVGPoint and DOMSVGRect.

• IDL clean up.

• Make numOctaves in SVGFETurbulenceElement use a long instead of an int in it's macro declaration and definition.

• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• bindings/objc/DOMCSS.mm: (+[DOMCSSValue _CSSValueWith:WebCore::]):
• bindings/objc/DOMInternal.h:
• bindings/objc/DOMSVG.h:
• bindings/objc/DOMSVGNumber.h: Added.
• bindings/objc/DOMSVGNumber.mm: Added. (-[DOMSVGNumber dealloc]): (-[DOMSVGNumber finalize]): (-[DOMSVGNumber value]): (-[DOMSVGNumber setValue:]): (-[DOMSVGNumber _SVGNumber]): (-[DOMSVGNumber _initWithFloat:]): (+[DOMSVGNumber _SVGNumberWith:]):
• bindings/objc/DOMSVGPoint.h: Added.
• bindings/objc/DOMSVGPoint.mm: Added. (-[DOMSVGPoint dealloc]): (-[DOMSVGPoint finalize]): (-[DOMSVGPoint x]): (-[DOMSVGPoint setX:]): (-[DOMSVGPoint y]): (-[DOMSVGPoint setY:]): (-[DOMSVGPoint WebCore::]): (-[DOMSVGPoint _initWithFloatPoint:WebCore::]): (+[DOMSVGPoint _SVGPointWith:WebCore::]):
• bindings/objc/DOMSVGRect.h: Added.
• bindings/objc/DOMSVGRect.mm: Added. (-[DOMSVGRect dealloc]): (-[DOMSVGRect finalize]): (-[DOMSVGRect x]): (-[DOMSVGRect setX:]): (-[DOMSVGRect y]): (-[DOMSVGRect setY:]): (-[DOMSVGRect width]): (-[DOMSVGRect setWidth:]): (-[DOMSVGRect height]): (-[DOMSVGRect setHeight:]): (-[DOMSVGRect WebCore::]): (-[DOMSVGRect _initWithFloatRect:WebCore::]): (+[DOMSVGRect _SVGRectWith:WebCore::]):
• bindings/scripts/CodeGeneratorObjC.pm:
• ksvg2/svg/SVGAnimatedNumberList.idl:
• ksvg2/svg/SVGAnimatedRect.idl:
• ksvg2/svg/SVGComponentTransferFunctionElement.idl:
• ksvg2/svg/SVGCursorElement.idl:
• ksvg2/svg/SVGFEBlendElement.idl:
• ksvg2/svg/SVGFEColorMatrixElement.idl:
• ksvg2/svg/SVGFEComponentTransferElement.idl:
• ksvg2/svg/SVGFECompositeElement.idl:
• ksvg2/svg/SVGFEDiffuseLightingElement.idl:
• ksvg2/svg/SVGFEDisplacementMapElement.idl:
• ksvg2/svg/SVGFEDistantLightElement.idl:
• ksvg2/svg/SVGFEFloodElement.idl:
• ksvg2/svg/SVGFEFuncAElement.idl:
• ksvg2/svg/SVGFEFuncBElement.idl:
• ksvg2/svg/SVGFEFuncGElement.idl:
• ksvg2/svg/SVGFEFuncRElement.idl:
• ksvg2/svg/SVGFEGaussianBlurElement.idl:
• ksvg2/svg/SVGFEImageElement.idl:
• ksvg2/svg/SVGFEMergeElement.idl:
• ksvg2/svg/SVGFEMergeNodeElement.idl:
• ksvg2/svg/SVGFEOffsetElement.idl:
• ksvg2/svg/SVGFEPointLightElement.idl:
• ksvg2/svg/SVGFESpecularLightingElement.idl:
• ksvg2/svg/SVGFESpotLightElement.idl:
• ksvg2/svg/SVGFETileElement.idl:
• ksvg2/svg/SVGFETurbulenceElement.cpp:
• ksvg2/svg/SVGFETurbulenceElement.h:
• ksvg2/svg/SVGFETurbulenceElement.idl:
• ksvg2/svg/SVGNumberList.idl:

5:21 AM Changeset in webkit [16849] by zbujtas

• 3 edits in S60/trunk/WebCore

2006-10-05 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Zalan Bujtas
DESC: Prevent multiple form submission
​http://bugs.webkit.org/show_bug.cgi?id=11170

WARNING: NO TEST CASES ADDED OR CHANGED

• kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::submitForm): (KWQKHTMLPart::KeyEvent): (KWQKHTMLPart::MouseDown): (KWQKHTMLPart::prepareForUserAction):
• kwq/KWQKHTMLPart.h:

4:18 AM Changeset in webkit [16848] by mjs

• 4 edits in trunk/WebKit

Reviewed by Adam.

• fixed the following bugs:

​http://bugs.webkit.org/show_bug.cgi?id=11136
"REGRESSION: Safari snippet editor doesn't work"
​http://bugs.webkit.org/show_bug.cgi?id=11140
"REGRESSION: view source window blank"
​http://bugs.webkit.org/show_bug.cgi?id=11146
"REGRESSION: Instead of showing the error page, Safari opens its Resources folder in the Finder"

Possibly more.

• Loader/WebDocumentLoadState.h:
• Loader/WebDocumentLoadState.m: (-[WebDocumentLoadState actualRequest]): New method.
• WebView/WebDataSource.m: (-[WebDataSource _startLoading]): We need to make sure not to start loading the main resource with the fake external request for an applewebdata: request.

3:30 AM Changeset in webkit [16847] by hyatt

• 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

Fix win32 bustage.

3:28 AM Changeset in webkit [16846] by hyatt

• 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

Fix win32 bustage.

3:22 AM Changeset in webkit [16845] by hyatt

• 5 edits in trunk/WebCore

Fix build bustage on many platforms by making sure the includes of ScrollBar stay the way they were.

3:18 AM Changeset in webkit [16844] by aroben

• 3 edits in trunk/WebCore

Backing out my previous change.

• WebCore.xcodeproj/project.pbxproj:
• page/FrameView.cpp: (WebCore::FrameView::adjustViewSize):

3:18 AM Changeset in webkit [22320] by hyatt

• 2 edits in branches/WindowsMerge/WebCore

Fix open source build bustage by moving windowResizerRect into ScrollViewWin.

3:17 AM Changeset in webkit [16843] by hyatt

• 3 edits in trunk/WebCore

Fix build bustage like... everywhere.

3:06 AM Changeset in webkit [16842] by aroben

• 3 edits in trunk/WebCore

Build fix.

• WebCore.xcodeproj/project.pbxproj:
• page/FrameView.cpp: (WebCore::FrameView::windowResizerRect):

3:01 AM Changeset in webkit [16841] by hyatt

• 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

Fix win32 bustage.

2:48 AM Changeset in webkit [22319] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

Some loader improvements, courtesy of Steve.

Functionally, the improvements are these:

1. Support HTTP Authentication
2. Respect WinInet errors better

There are also some general code cleanups, like extracting the creation
of an HTTP request into its own method.

• platform/win/ResourceLoaderWin.cpp: Add dwError field to JobLoadStatus to store WinInet error codes. Also removed the globalInternetHandle() function as the global HINTERNET is now only needed within startHTTPRequest. (WebCore::ResourceLoaderWndProc): Respect error codes and add HTTP Authentication support. Also, process HTTP status codes as ints instead of strings. (WebCore::ResourceLoaderInternal::~ResourceLoaderInternal): Cleanup m_formData (WebCore::transferJobStatusCallback): Cleanup the code, and set dwError. (WebCore::ResourceLoader::startHTTPRequest): New method to start a new HTTP request. (WebCore::ResourceLoader::start): Restructure code.

2:43 AM Changeset in webkit [16840] by aroben

• 4 edits in trunk/WebCore

Reviewed by Maciej.

More loader tweaks.

• platform/ResourceLoader.h:
• platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
• platform/win/TemporaryLinkStubs.cpp: (WebCore::ResourceLoader::newHTTPRequest):

2:16 AM Changeset in webkit [22318] by hyatt

• 2 edits in branches/WindowsMerge/WebCore

Fix cnn.com plugins. Fix a crash from not unparenting scrollbars of a scrollview in its destructor.

1:23 AM Changeset in webkit [22317] by hyatt

• 2 edits in branches/WindowsMerge/WebCore

Fix plugins being mispositioned on osnews.com

12:50 AM Changeset in webkit [22316] by sfalken

• 12 edits in branches/WindowsMerge

2006-10-05 Steve Falkenburg <​sfalken@apple.com>

Reviewed by aroben.

Allow window to be resized via the gripper (bottom right rect adjacent to scrollbars).
Add a method to reset the candidate URLs when a page load completes.
Add implementations for resizer related UI delegate callbacks.
Move gripper drawing into DrawingUtilities.

2006-10-06 Steve Falkenburg <​sfalken@apple.com>

Reviewed by aroben.

Scrollbars now dodge resizing gripper.
Resizing gripper now paints via web ui delegate.
Debug vcproj fixes.
Fix redirects to search.com.
Add support for painting and cursor tracking of resizer.

• Interfaces/IWebUIDelegatePrivate.idl: added webViewDrawResizer.
• WebFrame.cpp: (WebFrame::paint): added gripper drawing code. (WebFrame::receivedResponse): tell the app when we commit a page load. (WebFrame::windowResizerRect): added. (WebFrame::paintGripper): added.
• WebFrame.h: added windowResizerRect, paintGripper.
• WebKit.vcproj/WebKit.vcproj: Link against debug libs, debug MSVC library in debug build.
• WebView.cpp: (WebView::WebView): (WebView::~WebView): (WebView::inResizer): (WebViewWndProc): (WebView::setUIDelegate):
• WebView.h:

2006-10-05 Steve Falkenburg <​sfalken@apple.com>

Reviewed by aroben.

Scrollbars now dodge resizing gripper.

• bridge/win/FrameViewWin.cpp: (WebCore::FrameView::windowResizerRect): added.
• bridge/win/FrameWin.cpp: (WebCore::FrameWin::windowResizerRect): added.
• bridge/win/FrameWin.h:
• platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::updateScrollbars): Scrollbars now dodge resizing gripper.

12:44 AM Changeset in webkit [16839] by sfalken

• 7 edits in trunk/WebCore

2006-10-05 Steve Falkenburg <​sfalken@apple.com>

Reviewed by aroben.

Stub out some methods that we'll be able to use to dodge a window resizer.

• bridge/win/FrameWin.h:
• page/Frame.h: (WebCore::Frame::windowResizerRect):
• page/FrameView.h:
• platform/ScrollView.h: (WebCore::ScrollView::windowResizerRect):
• platform/Widget.h:
• platform/win/TemporaryLinkStubs.cpp: (FrameView::windowResizerRect): (Widget::setParent): (Widget::parent): (FrameWin::windowResizerRect):

Oct 5, 2006:

11:19 PM Changeset in webkit [22315] by hyatt

• 2 edits in branches/WindowsMerge/WebCore

Fix scrollview resizing to do updatescrollbars even for iframes. Matches Mac better and makes iframes stop showing scrollbars when they shouldn't.

11:14 PM Changeset in webkit [16838] by hyatt

• 2 edits in trunk/WebCore

Stub out setFrameGeometry.

10:53 PM Changeset in webkit [22314] by hyatt

• 1 edit in branches/WindowsMerge/WebCore/platform/win/GraphicsContextWin.cpp

Implement proper clipping and transforms for themed form controls.

10:45 PM Changeset in webkit [22313] by hyatt

• 6 edits in branches/WindowsMerge

Implement proper clipping and transforms for themed form controls.

10:30 PM Changeset in webkit [16837] by hyatt

• 1 edit in trunk/WebCore/platform/cg/GraphicsContextCG.cpp

Temporary hack.

10:18 PM Changeset in webkit [16836] by adele

• 5 edits in trunk/WebCore

Reverting autoscroll fix. I need to rework this a little.

• page/Frame.cpp: (WebCore::Frame::handleAutoscroll): (WebCore::Frame::autoscrollTimerFired): (WebCore::Frame::stopAutoscrollTimer):
• page/Frame.h:
• rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer):
• rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox):

9:48 PM Changeset in webkit [16835] by andersca

• 2 edits in trunk/WebKitTools

2006-10-05 Oliver Hunt <​ohunt@apple.com>

Reviewed by Anders.

• Scripts/run-webkit-tests: Fix pixel tests.

8:57 PM Changeset in webkit [16834] by aliceli1

• 2 edits in trunk/WebCore

Reviewed by Adam.

Fixed <rdar://problem/4731778>

• editing/CommandByName.cpp: (WebCore::Frame::Command::): was calling the wrong enabledFn for arrow selection and navigation

8:34 PM Changeset in webkit [16833] by adele

• 5 edits in trunk/WebCore

Reviewed by Maciej.

• Fix for <rdar://problem/4707489> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active <input type="text"> and <rdar://problem/4707519> After timers fix, crash below RenderLayer::autoscroll after moving/destroying active textarea

• rendering/RenderLayer.cpp: (WebCore::RenderLayer::~RenderLayer): If the renderer is being autoscrolled, then stop the autoscroll timer.
• rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): ditto.

• page/Frame.cpp: Added getter and setter for the renderer being autoscrolled. (WebCore::Frame::handleAutoscroll): (WebCore::Frame::autoscrollTimerFired): (WebCore::Frame::autoscrollRenderer): (WebCore::Frame::setAutoscrollRenderer): (WebCore::Frame::stopAutoscrollTimer):
• page/Frame.h:

7:48 PM Changeset in webkit [16832] by bdash

• 7 edits in trunk/WebCore

2006-10-05 Don Gibson <​dgibson77@gmail.com>

Reviewed by Eric.

Fix win32 build bustage after ggaren's Scrollbar renaming changes.
Properly include PlatformScrollBar.h in WbCore.vcproj.
Clean up WidgetWin.cpp a bit.

• WebCore.vcproj/WebCore/WebCore.vcproj:
• platform/Widget.h:
• platform/win/PlatformScrollBar.h:
• platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::hScrollbarMode): (WebCore::ScrollView::vScrollbarMode): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::updateScrollbars):
• platform/win/TemporaryLinkStubs.cpp: (FrameView::passMousePressEventToScrollbar): (Widget::removeFromParent): (ScrollView::scrollbarUnderMouse): (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::~PlatformScrollbar): (PlatformScrollbar::width): (PlatformScrollbar::height): (PlatformScrollbar::setEnabled): (PlatformScrollbar::paint): (PlatformScrollbar::updateThumbPosition): (PlatformScrollbar::updateThumbProportion): (PlatformScrollbar::setRect): (Scrollbar::Scrollbar): (Scrollbar::setSteps): (Scrollbar::scroll): (Scrollbar::setValue): (Scrollbar::setProportion):
• platform/win/WidgetWin.cpp: (WebCore::WidgetPrivate::WidgetPrivate): (WebCore::Widget::Widget): (WebCore::Widget::setContainingWindow): (WebCore::Widget::containingWindow):

6:23 PM Changeset in webkit [16831] by adele

• 5 edits in trunk/WebKit

Reviewed by the letter 'B'.

More build fixes.

• WebKit.xcodeproj/project.pbxproj:
• WebView/WebDynamicScrollBarsView.h:
• WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): (-[WebDynamicScrollBarsView setAllowsScrolling:]): (-[WebDynamicScrollBarsView allowsScrolling]): (-[WebDynamicScrollBarsView setAllowsHorizontalScrolling:]): (-[WebDynamicScrollBarsView setAllowsVerticalScrolling:]): (-[WebDynamicScrollBarsView allowsHorizontalScrolling]): (-[WebDynamicScrollBarsView allowsVerticalScrolling]): (-[WebDynamicScrollBarsView horizontalScrollingMode]): (-[WebDynamicScrollBarsView verticalScrollingMode]): (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]): (-[WebDynamicScrollBarsView setVerticalScrollingMode:]): (-[WebDynamicScrollBarsView setScrollingMode:]):
• WebView/WebView.m: (-[WebView setAlwaysShowVerticalScroller:]): (-[WebView alwaysShowVerticalScroller]): (-[WebView setAlwaysShowHorizontalScroller:]): (-[WebView alwaysShowHorizontalScroller]):

6:03 PM Changeset in webkit [22312] by ggaren

• 2 edits in branches/WindowsMerge/WebCore

build fix.

• platform/win/WidgetWin.cpp: (WebCore::Widget::~Widget): (WebCore::Widget::setParent): (WebCore::Widget::parent): (WebCore::Widget::removeFromParent):

6:01 PM Changeset in webkit [16830] by ggaren

• 14 edits in trunk/WebCore

build fix.

• WebCore.xcodeproj/project.pbxproj:
• bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
• bridge/mac/FrameMac.mm: (WebCore::FrameMac::createFrame):
• bridge/mac/FrameViewMac.mm: (WebCore::FrameView::passMousePressEventToScrollbar):
• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge installInFrame:]):
• bridge/mac/WebCoreFrameView.h:
• platform/ScrollBar.cpp:
• platform/Widget.h:
• platform/mac/PlatformScrollBar.h:
• platform/mac/PlatformScrollBarMac.mm: (NSControlSizeForScrollBarControlSize): (-[WebCoreScrollBar initWithPlatformScrollbar:]): (-[WebCoreScrollBar detachPlatformScrollbar]): (-[WebCoreScrollBar scroll:]): (-[WebCoreScrollBar widget]): (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::~PlatformScrollbar): (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion): (WebCore::PlatformScrollbar::scrollbarHit): (WebCore::PlatformScrollbar::width): (WebCore::PlatformScrollbar::height): (WebCore::PlatformScrollbar::setRect): (WebCore::PlatformScrollbar::setEnabled): (WebCore::PlatformScrollbar::paint):
• platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::vScrollbarMode): (WebCore::ScrollView::hScrollbarMode): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::scrollbarUnderMouse):
• platform/mac/WidgetMac.mm: (WebCore::Widget::removeFromParent):
• rendering/RenderLayer.cpp: (WebCore::RenderLayer::destroyScrollbar):

5:02 PM Changeset in webkit [16829] by eseidel

• 2 edits in trunk/WebKitSite

2006-10-05 Eric Seidel <​eric@eseidel.com>

Reviewed by Tim H.

• coding/coding-style.html: use css styles, add example for whitespace, add example for c++ constructors

4:16 PM Changeset in webkit [22311] by lamadio

• 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/WebKitGUID.vcproj

Correct a build break when the build directory is outside the source tree.

3:58 PM Changeset in webkit [16828] by brmorris

• 1 edit in S60/trunk/S60Internals/S60DynamicLibs.zip

Fix runtime break introduced in r16809: added RecentUrlStore.dll

3:38 PM Changeset in webkit [22310] by hyatt

• 1 edit in branches/WindowsMerge/WebCore/platform/win/ScrollViewWin.cpp

Fix addClip->clip renaming bustage.

3:26 PM Changeset in webkit [16827] by bdash

• 1 edit
  4 adds in trunk/WebCore

2006-10-06 Mitz Pettel <​mitz@webkit.org>

​http://bugs.webkit.org/show_bug.cgi?id=8276
Fix broken manual test added back in r13990.

Add resource forks for test resources.

• manual-tests/resources/plain-text-paste/._1.textClipping: Added.
• manual-tests/resources/plain-text-paste/._2.textClipping: Added.
• manual-tests/resources/plain-text-paste/._4.txt: Added.
• manual-tests/resources/plain-text-paste/._5.webloc: Added.

3:21 PM Changeset in webkit [22309] by hyatt

• 2 edits in branches/WindowsMerge/WebCore

Stub out GraphicsContextPlatformPrivate methods so that the HDC can
be updated when clips/transforms are applied.

Reviewed by darin

• platform/cg/GraphicsContextPlatformPrivate.h: (WebCore::GraphicsContextPlatformPrivate::save): (WebCore::GraphicsContextPlatformPrivate::restore): (WebCore::GraphicsContextPlatformPrivate::clip): (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate): (WebCore::GraphicsContextPlatformPrivate::concatCTM):

3:19 PM Changeset in webkit [22308] by aroben

• 1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

Build fix.

• WebKit.vcproj/WebKitGUID.vcproj: Fix patch to IWebFramePrivate_i.c

3:16 PM Changeset in webkit [22307] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Build fix.

• platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::BrowserExtensionWin): Change Frame* to FrameWin*

3:14 PM Changeset in webkit [16826] by hyatt

• 18 edits in trunk/WebCore

Rename addClip to clip.

Reviewed by darin

• kcanvas/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):
• kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
• kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
• platform/GraphicsContext.h:
• platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clip):
• platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::scale): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::concatCTM):
• platform/cg/GraphicsContextPlatformPrivate.h: (WebCore::GraphicsContextPlatformPrivate::save): (WebCore::GraphicsContextPlatformPrivate::restore): (WebCore::GraphicsContextPlatformPrivate::clip): (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate): (WebCore::GraphicsContextPlatformPrivate::concatCTM):
• platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::addInnerRoundedRectClip): (WebCore::GraphicsContext::addRoundedRectClip):
• rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintBackground): (WebCore::InlineFlowBox::paintBackgroundAndBorder):
• rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintTextMatchMarker):
• rendering/RenderBox.cpp: (WebCore::RenderBox::paintBackgroundExtended):
• rendering/RenderButton.cpp: (WebCore::RenderButton::paintObject):
• rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
• rendering/RenderLayer.cpp: (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::setClip):
• rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintObject):
• rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::paintObject):
• rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintBackgroundsBehindCell):

3:11 PM Changeset in webkit [22306] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Build fix. Remove RenderImageButton.{h,cpp}.

• WebCore.vcproj/WebCore.vcproj:

3:03 PM Changeset in webkit [16825] by bdash

• 4 edits
  2 deletes in trunk/WebCore

2006-10-05 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

• ​http://bugs.webkit.org/show_bug.cgi?id=10386 Delete RenderImageButton.* and remove references from .vcproj and .bkl files

• CMakeLists.txt:
• WebCore.vcproj/WebCore/WebCore.vcproj:
• WebCoreSources.bkl:
• rendering/RenderImageButton.cpp: Removed.
• rendering/RenderImageButton.h: Removed.

2:56 PM Changeset in webkit [16824] by bdash

• 2 edits in trunk/WebCore

2006-10-05 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by Darin.

• ​http://bugs.webkit.org/show_bug.cgi?id=11067 manual-tests/scrollbar-hittest2.html is invalid

• manual-tests/scrollbar-hittest2.html:

2:53 PM Changeset in webkit [16823] by bdash

• 3 edits in trunk/WebKit

2006-10-05 Vladimir Olexa <​vladimir.olexa@gmail.com>

Reviewed by Timothy.

Bug: ​http://bugs.webkit.org/show_bug.cgi?id=9887
Continuous spell checking now remembers user's setting. The change is applied globally,
meaning, both TextArea and TextField are affected when either of them enables/disables
spell checking.

• WebView/WebPreferenceKeysPrivate.h: added a define for WebContinuousSpellCheckingEnabled
• WebView/WebView.m: (-[WebViewPrivate init]): reads WebContinuousSpellCheckingEnabled from NSUserDefaults (-[WebView setContinuousSpellCheckingEnabled:]): (-[WebView isContinuousSpellCheckingEnabled]):

2:43 PM Changeset in webkit [16822] by bdash

• 2 edits in trunk/WebKit

2006-10-05 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Darin.

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=11162

• COM/WebFrame.cpp: (WebFrame::loadDataSource): (WebFrame::receivedResponse):

2:40 PM Changeset in webkit [16821] by bdash

• 3 edits in trunk/WebCore

2006-10-05 David Carson <​dacarson@gmail.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11152
Adjust the tokenizer chunk size to be smaller for
mobile devices, and also decrease the yield timer
for the tokenizer so that it can resume earlier.

• html/HTMLTokenizer.cpp:
• config.h:

2:38 PM Changeset in webkit [16820] by aroben

• 2 edits in trunk/WebCore

Removing accidentally-checked-in do-nothing code.

• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):

2:35 PM Changeset in webkit [16819] by bdash

• 2 edits in trunk/WebCore

2006-10-05 David Carson <​dacarson@gmail.com>

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11158
Initialize class variables

• rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer):

2:33 PM Changeset in webkit [22305] by andersca

• 9 edits
  1 add in branches/WindowsMerge/WebKitWin

2006-10-05 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

A couple of changes needed for the new DumpRenderTree.

• DOMCoreClasses.cpp: (DOMDocument::documentElement): Implement.

• DOMHTMLClasses.cpp: (DOMHTMLElement::innerHTML): (DOMHTMLElement::setInnerHTML): (DOMHTMLElement::innerText): (DOMHTMLElement::setInnerText):
• DOMHTMLClasses.h: (DOMHTMLFormElement::innerHTML): (DOMHTMLFormElement::setInnerHTML): (DOMHTMLFormElement::innerText): (DOMHTMLFormElement::setInnerText): (DOMHTMLSelectElement::innerHTML): (DOMHTMLSelectElement::setInnerHTML): (DOMHTMLSelectElement::innerText): (DOMHTMLSelectElement::setInnerText): (DOMHTMLOptionElement::innerHTML): (DOMHTMLOptionElement::setInnerHTML): (DOMHTMLOptionElement::innerText): (DOMHTMLOptionElement::setInnerText): (DOMHTMLInputElement::innerHTML): (DOMHTMLInputElement::setInnerHTML): (DOMHTMLInputElement::innerText): (DOMHTMLInputElement::setInnerText): (DOMHTMLTextAreaElement::innerHTML): (DOMHTMLTextAreaElement::setInnerHTML): (DOMHTMLTextAreaElement::innerText): (DOMHTMLTextAreaElement::setInnerText):
• Interfaces/DOMHTML.idl: Implement innerText and add stubs for innerHTML, setInnerHTML and setInnerText.

• Interfaces/IWebFramePrivate.idl: Added.
• WebFrame.cpp: (WebFrame::QueryInterface): (WebFrame::renderTreeAsExternalRepresentation): (WebFrame::receivedAllData): Call Frame::end() before calling the frame load delegate methods. This matches the mac behavior.

(WebFrame::didFirstLayout):
(WebFrame::handledOnloadEvents):
Add null checks for frameLoadDelegatePriv, all clients might not use it.

• WebFrame.h:
• WebKit.vcproj/Interfaces.vcproj:
• WebKit.vcproj/WebKitGUID.vcproj: Add new interface, IWebFramePrivate, which supports getting the render tree as text.

1:27 PM Changeset in webkit [16818] by aroben

• 7 edits in trunk

2006-10-05 Don Gibson <​dgibson77@gmail.com>

WebCore:

Reviewed by Darin, landed by Adam.

​http://bugs.webkit.org/show_bug.cgi?id=11176
Fix win32 build, adapt to Maciej's ResourceLoader changes.

• platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::start):

WebKit:

Reviewed by Darin, landed by Adam.

​http://bugs.webkit.org/show_bug.cgi?id=11176
Fix win32 build, adapt to Maciej's ResourceLoader changes.

• COM/WebFrame.cpp: (WebFrame::loadDataSource):

1:22 PM Changeset in webkit [16817] by ap

• 10 edits
  1 add in trunk

2006-10-05 Marvin Decker <​marv.decker@gmail.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=10989
Provide a way for embedders to implement BrowserExtensionWin

WebCore:

• WebCore.vcproj/WebCore/WebCore.vcproj:
• bridge/win/BrowserExtensionWin.cpp: Added. (BrowserExtensionWin::BrowserExtensionWin): (BrowserExtensionWin::setTypedIconURL): (BrowserExtensionWin::setIconURL): (BrowserExtensionWin::getHistoryLength): (BrowserExtensionWin::canRunModal): (BrowserExtensionWin::createNewWindow): (BrowserExtensionWin::canRunModalNow): (BrowserExtensionWin::runModal): (BrowserExtensionWin::goBackOrForward): (BrowserExtensionWin::historyURL):
• bridge/win/BrowserExtensionWin.h:
• bridge/win/FrameWin.cpp: (WebCore::FrameWin::createNewWindow):
• bridge/win/FrameWin.h:
• platform/win/TemporaryLinkStubs.cpp:

WebKit:

• COM/Interfaces/IWebUIDelegate.idl:
• COM/WebFrame.cpp: (WebFrame::createNewWindow):
• COM/WebFrame.h:

1:17 PM Changeset in webkit [16816] by brmorris

• 1 edit in S60/trunk/S60Internals/S60DynamicLibs.zip

More break fixes: updating Toolbar.* in S60/S60Internals/S60DynamicLibs.zip

1:01 PM Changeset in webkit [22304] by ggaren

• 4 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

Fixed <rdar://problem/4766987>

• renamed ScrollBar to Scrollbar and scroll bar to scrollbar in every case except for file names.

• fixed RenderLayer to properly tear down scrollbars, removing them from their parents.

• bridge/win/FrameViewWin.cpp: (WebCore::FrameView::passMousePressEventToScrollbar):
• platform/win/PlatformScrollBar.h: (WebCore::):
• platform/win/PlatformScrollBarWin.cpp: (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::~PlatformScrollbar): (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion): (WebCore::PlatformScrollbar::invalidateTrack): (WebCore::PlatformScrollbar::invalidatePart): (WebCore::PlatformScrollbar::width): (WebCore::PlatformScrollbar::height): (WebCore::PlatformScrollbar::setRect): (WebCore::PlatformScrollbar::setEnabled): (WebCore::PlatformScrollbar::paint): (WebCore::PlatformScrollbar::backButtonRect): (WebCore::PlatformScrollbar::forwardButtonRect): (WebCore::PlatformScrollbar::trackRect): (WebCore::PlatformScrollbar::thumbRect): (WebCore::PlatformScrollbar::gripperRect): (WebCore::PlatformScrollbar::splitTrack): (WebCore::PlatformScrollbar::thumbPosition): (WebCore::PlatformScrollbar::thumbLength): (WebCore::PlatformScrollbar::trackLength): (WebCore::PlatformScrollbar::paintButton): (WebCore::PlatformScrollbar::paintTrack): (WebCore::PlatformScrollbar::paintThumb): (WebCore::PlatformScrollbar::paintGripper): (WebCore::PlatformScrollbar::hitTest): (WebCore::PlatformScrollbar::handleMouseMoveEvent): (WebCore::PlatformScrollbar::handleMouseOutEvent): (WebCore::PlatformScrollbar::handleMousePressEvent): (WebCore::PlatformScrollbar::handleMouseReleaseEvent): (WebCore::PlatformScrollbar::startTimerIfNeeded): (WebCore::PlatformScrollbar::stopTimerIfNeeded): (WebCore::PlatformScrollbar::autoscrollPressedPart): (WebCore::PlatformScrollbar::autoscrollTimerFired): (WebCore::PlatformScrollbar::pressedPartScrollDirection): (WebCore::PlatformScrollbar::pressedPartScrollGranularity): (WebCore::PlatformScrollbar::thumbUnderMouse): (WebCore::PlatformScrollbar::themeChanged): (WebCore::PlatformScrollbar::horizontalScrollbarHeight): (WebCore::PlatformScrollbar::verticalScrollbarWidth):
• platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::ScrollViewPrivate::setHasHorizontalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::setHasVerticalScrollbar): (WebCore::ScrollView::ScrollViewPrivate::valueChanged): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::hScrollbarMode): (WebCore::ScrollView::vScrollbarMode): (WebCore::ScrollView::suppressScrollbars): (WebCore::ScrollView::setHScrollbarMode): (WebCore::ScrollView::setVScrollbarMode): (WebCore::ScrollView::setScrollbarsMode): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::paint): (WebCore::ScrollView::themeChanged):

12:59 PM Changeset in webkit [16815] by ggaren

• 21 edits in trunk/WebCore

Reviewed by Darin.

Fixed <rdar://problem/4766987>

• renamed ScrollBar to Scrollbar and scroll bar to scrollbar in every case except for file names.

• fixed RenderLayer to properly tear down scrollbars, removing them from their parents.

• bindings/js/kjs_window.cpp: (KJS::showModalDialog): (KJS::setWindowFeature): (KJS::parseWindowFeatures):
• bridge/BrowserExtension.h:
• dom/Document.cpp: (WebCore::Document::setInPageCache):
• html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::init): (WebCore::HTMLFrameElement::parseMappedAttribute):
• html/HTMLFrameElement.h: (WebCore::HTMLFrameElement::scrollingMode):
• page/Frame.cpp: (WebCore::Frame::finishedParsing): (WebCore::Frame::scrollbarsVisible):
• page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::~FrameView): (WebCore::FrameView::resetScrollbars): (WebCore::FrameView::clear): (WebCore::FrameView::initScrollbars): (WebCore::FrameView::applyOverflowToViewport): (WebCore::FrameView::layout): (WebCore::FrameView::handleMousePressEvent): (WebCore::selectCursor): (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::setScrollbarsMode): (WebCore::FrameView::setVScrollbarMode): (WebCore::FrameView::setHScrollbarMode): (WebCore::FrameView::restoreScrollbar): (WebCore::FrameView::dispatchMouseEvent): (WebCore::FrameView::scrollbarMoved):
• page/FrameView.h:
• page/MouseEventWithHitTestResults.cpp: (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
• page/MouseEventWithHitTestResults.h: (WebCore::MouseEventWithHitTestResults::scrollbar):
• platform/ScrollBar.cpp: (WebCore::Scrollbar::Scrollbar): (WebCore::Scrollbar::setValue): (WebCore::Scrollbar::setProportion): (WebCore::Scrollbar::setSteps): (WebCore::Scrollbar::scroll):
• platform/ScrollBar.h: (WebCore::): (WebCore::ScrollbarClient::~ScrollbarClient): (WebCore::Scrollbar::~Scrollbar): (WebCore::Scrollbar::orientation): (WebCore::Scrollbar::controlSize): (WebCore::Scrollbar::hasPlatformScrollbars): (WebCore::Scrollbar::client):
• platform/ScrollBarMode.h: (WebCore::):
• platform/ScrollView.h:
• rendering/RenderBlock.cpp: (WebCore::RenderBlock::isPointInScrollbar):
• rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::horizontaScrollbarWidget): (WebCore::RenderLayer::verticalScrollbarWidget): (WebCore::RenderLayer::valueChanged): (WebCore::RenderLayer::createScrollbar): (WebCore::RenderLayer::destroyScrollbar): (WebCore::RenderLayer::setHasHorizontalScrollbar): (WebCore::RenderLayer::setHasVerticalScrollbar): (WebCore::RenderLayer::verticalScrollbarWidth): (WebCore::RenderLayer::horizontalScrollbarHeight): (WebCore::RenderLayer::updateScrollInfoAfterLayout):
• rendering/RenderLayer.h: (WebCore::RenderLayer::horizontalScrollbar): (WebCore::RenderLayer::verticalScrollbar):
• rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): (WebCore::RenderListBox::calcMinMaxWidth): (WebCore::RenderListBox::isPointInScrollbar): (WebCore::RenderListBox::optionAtPoint): (WebCore::RenderListBox::valueChanged):
• rendering/RenderListBox.h:
• rendering/RenderObject.h: (WebCore::RenderObject::NodeInfo::scrollbar): (WebCore::RenderObject::NodeInfo::setScrollbar):

12:58 PM Changeset in webkit [16814] by andersca

• 2 edits in trunk/WebKitTools

2006-10-04 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Darin.

• Scripts/run-webkit-tests: Add an environment variable, WebKitExpectedTestResultsDirectory, which controls where expected test results should be.

12:38 PM Changeset in webkit [16813] by ap

• 2 edits in trunk/WebKitTools

2006-10-05 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by ap.

Cmake: make it possible to install the libraries after having built using 'build-webkit'.
Just set the "WebKitInstallationPrefix" environment variable to your desired prefix.

• Scripts/webkitdirs.pm:

11:27 AM Changeset in webkit [16812] by brmorris

• 2 edits in S60/trunk/S60Internals

Fix build break introduced in r16809 by updating toolbar.h in S60Headers.zip

10:57 AM Changeset in webkit [16811] by ap

• 2 edits in trunk/WebCore

2006-10-05 Don Gibson <​dgibson77@gmail.com>

Reviewed by Adam.

​http://bugs.webkit.org/show_bug.cgi?id=11138
Incorrect mouse event generation on Windows

• platform/win/MouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): (1) Set mouse button even for non-click-related messages. (2) Track clicks correctly for all buttons, not just the left button.

10:48 AM Changeset in webkit [16810] by ap

• 8 edits in trunk/WebCore

2006-10-05 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed and landed by ap.

Fix Qt/Linux build, adapt to Eric's Quartz changes and to Maciej's ResourceLoader changes.

• kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp: (WebCore::KRenderingPaintServerLinearGradientQt::renderPath): (WebCore::KRenderingPaintServerLinearGradientQt::setup): (WebCore::KRenderingPaintServerRadialGradientQt::setup): (WebCore::KRenderingPaintServerRadialGradientQt::renderPath):
• kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp: (WebCore::KRenderingPaintServerPatternQt::renderPath):
• kcanvas/device/qt/KRenderingPaintServerQt.cpp: (WebCore::KRenderingPaintServerQt::setPenProperties):
• kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp: (WebCore::KRenderingPaintServerSolidQt::setup): (WebCore::KRenderingPaintServerSolidQt::renderPath):
• kcanvas/device/qt/RenderPathQt.cpp: (WebCore::getPathStroke):

10:37 AM Changeset in webkit [16809] by yongjzha

• 5 edits in S60/trunk/WebKit

2006-10-05 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Zhang Yongjun.
DESC: Enable touch ui on browser toolbar
​http://bugs.webkit.org/show_bug.cgi?id=11156

• BrowserView/inc/PointerEventHandler.h:
• BrowserView/inc/WebKitView.h:
• BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::HandlePointerEventL): (CPointerEventHandler::HandleToolBarPointerEventL):
• BrowserView/src/WebKitView.cpp: (CWebKitView::LaunchToolBarL): (CWebKitView::NodeUnderPointer):

10:20 AM Changeset in webkit [16808] by darin

• 2 edits in trunk/JavaScriptCore

Reviewed by Kevin McCullough.

• wtf/Assertions.cpp: Fix build when _DEBUG is not defined.

9:44 AM Changeset in webkit [16807] by ap

• 3 edits
  23 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11054
REGRESSION: Traditional Chinese encoding in login authentication

1. Treat GB2312 encoding as GBK (its more modern superset), to match other browsers.
2. On the Web, GB2312 is encoded as EUC-CN or HZ, while ICU provides a native encoding for encoding GB_2312-80 and several others. So, we need to override this behavior, too.

WebCore:

• platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::registerEncodingNames):

LayoutTests:

Each of these tests is passed by Firefox 1.5 and/or WinIE 6.

• fast/encoding/GBK/EUC-CN-expected.txt: Added.
• fast/encoding/GBK/EUC-CN.html: Added.
• fast/encoding/GBK/chinese-expected.txt: Added.
• fast/encoding/GBK/chinese.html: Added.
• fast/encoding/GBK/cn-gb-expected.txt: Added.
• fast/encoding/GBK/cn-gb.html: Added.
• fast/encoding/GBK/csgb2312-expected.txt: Added.
• fast/encoding/GBK/csgb2312.html: Added.
• fast/encoding/GBK/csgb231280-expected.txt: Added.
• fast/encoding/GBK/csgb231280.html: Added.
• fast/encoding/GBK/gb2312-expected.txt: Added.
• fast/encoding/GBK/gb2312.html: Added.
• fast/encoding/GBK/gb_2312-80-expected.txt: Added.
• fast/encoding/GBK/gb_2312-80.html: Added.
• fast/encoding/GBK/gbk-expected.txt: Added.
• fast/encoding/GBK/gbk.html: Added.
• fast/encoding/GBK/iso-ir-58-expected.txt: Added.
• fast/encoding/GBK/iso-ir-58.html: Added.
• fast/encoding/GBK/x-euc-cn-expected.txt: Added.
• fast/encoding/GBK/x-euc-cn.html: Added.
• fast/encoding/GBK/x-gbk-expected.txt: Added.
• fast/encoding/GBK/x-gbk.html: Added.

6:59 AM Changeset in webkit [16806] by eseidel

• 2 edits
  1 delete in trunk/WebCore

2006-10-05 Eric Seidel <​eric@eseidel.com>

Reviewed by mjs.

Removed dead code.
Filed ​http://bugs.webkit.org/show_bug.cgi?id=11167 to for followup on removed FIXMEs

• WebCore.xcodeproj/project.pbxproj:
• ksvg2/ecma/GlobalObject.cpp: Removed.
• ksvg2/ecma/GlobalObject.h: Removed.

6:56 AM Changeset in webkit [22303] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej.

Fixes <rdar://problem/4757387>
Unable to sign on to my.yahoo.com

This patch fixes a number of bugs that all resulted in not being able
to log on to many websites. The problems were that we weren't allowing
redirects between HTTP and HTTPS sites and weren't correctly handling
redirects from POST requests to GET requests.

• platform/win/ResourceLoaderWin.cpp: (WebCore::globalInternetHandle): Move internetHandle and callbackHandle into file scope, and add this function to initialize them. (WebCore::logLastError): Add this debug logging function to give more readable WinInet error messages. (WebCore::ResourceLoaderWndProc): The most substantial change here is to allow redirects from POST to GET to function correctly. To do this we have to create a new HINTERNET for the GET. We also have to be sure not to try to read from our now-invalid handles after the redirect. (WebCore::transferJobStatusCallback): Rename timerId to jobId, since that's what it is. (WebCore::ResourceLoader::start): Call new static initializer, and pass flags to allow HTTP<->HTTPS redirects. Also change a few delete calls to kill().

6:54 AM Changeset in webkit [16805] by aroben

• 2 edits in trunk/WebCore

Reviewed by Maciej.

Small ResourceLoaderInternal tweak.

• platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):

6:52 AM Changeset in webkit [16804] by eseidel

• 26 edits in trunk/WebCore

2006-10-05 Eric Seidel <​eric@eseidel.com>

Reviewed by mjs.

More incremental KCanvas cleanup and optimization.
Added SVGRenderStyle::hasFill() and hasStroke() removed more KSVGPainterFactory methods.
Optimized dash array usage to not malloc.
Also removed un-needed KSVGRenderingStyle includes.

• kcanvas/KCanvasTreeDebug.cpp: (WebCore::operator<<):
• kcanvas/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint):
• kcanvas/device/quartz/KCanvasItemQuartz.mm: (WebCore::RenderPath::strokeBBox):
• kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm: (WebCore::KRenderingPaintServerGradientQuartz::setup): (WebCore::KRenderingPaintServerGradientQuartz::renderPath): (WebCore::KRenderingPaintServerGradientQuartz::teardown):
• kcanvas/device/quartz/KRenderingPaintServerQuartz.mm: (WebCore::KRenderingPaintServerSolidQuartz::setup): (WebCore::KRenderingPaintServerSolidQuartz::renderPath): (WebCore::KRenderingPaintServerPatternQuartz::setup): (WebCore::KRenderingPaintServerPatternQuartz::renderPath):
• kcanvas/device/quartz/QuartzSupport.mm: (WebCore::applyStrokeStyleToContext):
• ksvg2/css/SVGRenderStyle.h: (WebCore::SVGRenderStyle::hasStroke): (WebCore::SVGRenderStyle::hasFill):
• ksvg2/misc/KCanvasRenderingStyle.cpp: (WebCore::KSVGPainterFactory::fillPaintServer): (WebCore::KSVGPainterFactory::strokePaintServer):
• ksvg2/misc/KCanvasRenderingStyle.h:

6:15 AM Changeset in webkit [16803] by mjs

• 13 edits in trunk/WebCore

Reviewed by Adam.

• changed ResourceLoader to be refcounted

It keeps a ref on itself while loading as well. This makes
for a much saner memory management model than the previous.

• bridge/mac/WebCoreResourceLoaderImp.mm: (-[WebCoreResourceLoaderImp finishJobAndHandle:]):
• dom/XMLTokenizer.cpp: (WebCore::openFunc):
• loader/icon/IconLoader.cpp: (IconLoader::IconLoader): (IconLoader::~IconLoader): (IconLoader::startLoading): (IconLoader::stopLoading): (IconLoader::receivedData):
• loader/icon/IconLoader.h:
• loader/loader.cpp: (WebCore::Loader::servePendingRequests):
• platform/ResourceLoader.cpp: (WebCore::ResourceLoader::create): (WebCore::ResourceLoader::kill):
• platform/ResourceLoader.h:
• platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
• platform/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::start):
• xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
• xml/xmlhttprequest.h:

5:59 AM Changeset in webkit [16802] by eseidel

• 5 edits in trunk/WebCore

2006-10-05 Eric Seidel <​eric@eseidel.com>

Reviewed by mjs.

Improve SVG opacity performance by clipping to the object bbox before starting a new opacity layer.
​http://bugs.webkit.org/show_bug.cgi?id=11163

No SVG performance tests yet.

• kcanvas/RenderForeignObject.cpp: (WebCore::RenderForeignObject::paint):
• kcanvas/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
• kcanvas/RenderSVGImage.cpp: (WebCore::RenderSVGImage::paint):
• kcanvas/RenderSVGText.cpp: (WebCore::RenderSVGText::paint):

5:51 AM Changeset in webkit [22302] by mjs

• 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

• changed ResourceLoader to be refcounted

It keeps a ref on itself while loading as well. This makes
for a much saner memory management model than the previous.

In addition, keep it ref'd across all of ResourceLoaderWndProc
to avoid sending messages to jobs that get deleted partway.

This fixes <rdar://problem/4766859> Crash in ResourceLoaderWndProc - line 232 at televisionwithoutpity.com, washingtonpost.com

• platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoaderWndProc): (WebCore::ResourceLoader::start):
• plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): (WebCore::PluginStreamWin::start): (WebCore::PluginStreamWin::stop):
• plugins/win/PluginStreamWin.h:

WebKitWin:

Reviewed by Adam.

• changed ResourceLoader to be refcounted

It keeps a ref on itself while loading as well. This makes
for a much saner memory management model than the previous.

In addition, keep it ref'd across all of ResourceLoaderWndProc
to avoid sending messages to jobs that get deleted partway.

This fixes <rdar://problem/4766859> Crash in ResourceLoaderWndProc - line 232 at televisionwithoutpity.com, washingtonpost.com

• WebFrame.cpp: (WebFrame::loadDataSource):

2:03 AM Changeset in webkit [22301] by hyatt

• 7 edits in branches/WindowsMerge

Make key events get delivered properly to iframes and frames.

1:58 AM Changeset in webkit [16801] by hyatt

• 4 edits in trunk/WebCore

Widget focusability work.

Oct 4, 2006:

9:58 PM Changeset in webkit [16800] by andersca

• 2 edits in trunk/LayoutTests

2006-10-04 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam.

• fast/frames/frame-src-attribute-expected.txt: Update test result.

8:08 PM Changeset in webkit [16799] by aroben

• 4 edits in trunk/WebCore

Reviewed by Maciej and Tim H.

Copy some WebKit frame lifetime logic into WebCore -- just a step
along the path to frame lifetime being handled completely in WebCore.

• bridge/mac/FrameMac.mm: (WebCore::FrameMac::setView): Move platform-independent parts of this method into Frame.
• page/Frame.cpp: (WebCore::Frame::setView): Adding platform-independent parts of FrameMac::setView (WebCore::Frame::detachChildren): New method to accomplish what -[WebFrameBridge _detachChildren] currently does. (WebCore::Frame::clear): Call detachChildren
• page/Frame.h: Add declaration for detachChildren

8:06 PM Changeset in webkit [22300] by aroben

• 3 edits in branches/WindowsMerge/WebCore

Reviewed by Maciej and Tim H.

Fixes <rdar://problem/4760991>
Flash content doesn't go away when navigating to a new page

Actually destroy subframes when detaching.

• bridge/win/FrameWin.cpp: (WebCore::FrameWin::frameDetached):
• bridge/win/FrameWin.h:

7:02 PM Changeset in webkit [22299] by andersca

• 2 edits in branches/WindowsMerge/WebCore

2006-10-05 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

<rdar://problem/4762998>
REGRESSION: dragging to select text does not work

• platform/win/PlatformMouseEventWin.cpp: (WebCore::PlatformMouseEvent::PlatformMouseEvent): Set the correct button for WM_MOUSEMOVE events.

6:42 PM Changeset in webkit [16798] by kmccullo

• 3 edits in trunk/JavaScriptCore

Reviewed by Adam.

• Removed an unnecessary assert that was stopping many pages. tm_gmtoff was not set for UTC time in mozilla but is always set for us.

• kjs/DateMath.cpp: (KJS::getUTCOffset): (KJS::msToTM):
• kjs/date_object.cpp: (KJS::gmtoffset): (KJS::formatTime):

6:07 PM Changeset in webkit [16797] by ggaren

• 2 edits in trunk/JavaScriptCore

Patch by Darin and me, reviewed by Maciej.

Fixed <rdar://problem/4518397> REGRESSION(?): Oft-seen but unrepro crash

in JavaScript garbage collection (KJS::Collector::collect())

<rdar://problem/4752492> Crash in KJS::collect

The issue here was allocating one garbage-collected object in the midst
of allocating a second garbage-collected object. In such a case, the
zeroIfFree word lies.

• kjs/collector.cpp: (KJS::Collector::allocate): (KJS::Collector::collect):

5:21 PM Changeset in webkit [16796] by bdash

• 4 edits in trunk/WebKitTools

2006-10-04 Mark Rowe <​bdash@webkit.org>

Reviewed by Stephanie.

Switch the Qt buildbot to the standard set of build steps.
Have JavaScriptCoreTest check the output of run-javascriptcore-tests to
see if any regressions were spotted, and fail the test if so.

• BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
• BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
• BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:

5:19 PM Changeset in webkit [16795] by kmccullo

• 2 edits in trunk/JavaScriptCore

Reviewed by Adam.

• Layout test fix

• kjs/DateMath.cpp: (KJS::dateToDayInYear): accept and correctly handle negative months

4:30 PM Changeset in webkit [22298] by andersca

• 2 edits in branches/WindowsMerge/WebCore

2006-10-05 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam.

rdar://problem/4757081
Crashes/hangs when using Flash 8 plugin (Flash 9 works MUCH better)

• plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::startStream): Encode javascript URLs before passing them to the plugin.

4:16 PM Changeset in webkit [16794] by aliceli1

• 2 edits in trunk/WebCore

Reviewed by Darin.

Fixed <rdar://problem/4758577> REGRESSION: Business and People widgets fails to complete search query

• xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::setRequestHeader): removed exception set when the request is not open yet

3:57 PM Changeset in webkit [16793] by kmccullo

• 2 edits in trunk/JavaScriptCore

build fix

• kjs/DateMath.cpp: (KJS::dateToDayInYear):

3:27 PM Changeset in webkit [16792] by brmorris

• 24 edits
  10 adds in S60/branches/scriptable_plugins/JavaScriptCore

Landing initial version of scriptable plugins support (part 2 of 2).

3:26 PM Changeset in webkit [16791] by brmorris

• 24 edits
  5 adds in S60/branches/scriptable_plugins

Landing scriptable plugins support (part 1 of 2).

3:25 PM Changeset in webkit [16790] by bdash

• 2 edits in trunk/JavaScriptCore

2006-10-05 Mark Rowe <​bdash@webkit.org>

Reviewed by maculloch.

Gdk build fix.

• JavaScriptCoreSources.bkl: Add DateMath.cpp to file list.

3:17 PM Changeset in webkit [16789] by brmorris

• 1 copy in S60/branches/scriptable_plugins

New feature branch created from r16325.

3:14 PM Changeset in webkit [22297] by adele

• 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

• Fix for <rdar://problem/4762933> When typing past the end of a text field, the field doesn't auto-scroll to display the active caret

Reveal the selection after inserting text.

• WebView.cpp: (WebViewWndProc):

3:13 PM WikiRestructuredText edited by trac

(diff)

3:13 PM TracTicketsCustomFields edited by trac

(diff)

3:13 PM TracNotification edited by trac

(diff)

3:13 PM TracRepositoryAdmin created by trac

3:13 PM TracFastCgi edited by trac

(diff)

3:13 PM TracIni edited by trac

(diff)

3:13 PM TracPermissions edited by trac

(diff)

3:13 PM TracTickets edited by trac

(diff)

3:13 PM TracUpgrade edited by trac

(diff)

3:13 PM TracWiki edited by trac

(diff)

3:13 PM TracImport edited by trac

(diff)

3:13 PM TracRoadmap edited by trac

(diff)

3:13 PM SandBox edited by trac

(diff)

3:13 PM TracReports edited by trac

(diff)

3:13 PM WikiMacros edited by trac

(diff)

3:13 PM TracInterfaceCustomization edited by trac

(diff)

3:13 PM TracModPython edited by trac

(diff)

3:13 PM TracFineGrainedPermissions edited by trac

(diff)

3:13 PM TracSyntaxColoring edited by trac

(diff)

3:13 PM TracSupport edited by trac

(diff)

3:13 PM TracUnicode edited by trac

(diff)

3:13 PM TracSearch edited by trac

(diff)

3:13 PM TracTimeline edited by trac

(diff)

3:13 PM InterTrac edited by trac

(diff)

3:13 PM TracQuery edited by trac

(diff)

3:13 PM TracLogging edited by trac

(diff)

3:13 PM TracBrowser edited by trac

(diff)

3:13 PM PageTemplates edited by trac

(diff)

3:13 PM WikiProcessors edited by trac

(diff)

3:13 PM TracLinks edited by trac

(diff)

3:13 PM TracEnvironment edited by trac

(diff)

3:13 PM TracStandalone edited by trac

(diff)

3:13 PM TracModWSGI created by trac

3:13 PM WikiDeletePage edited by trac

(diff)

3:13 PM WikiHtml edited by trac

(diff)

3:13 PM TracInstall edited by trac

(diff)

3:13 PM TracCgi edited by trac

(diff)

3:13 PM TracPlugins edited by trac

(diff)

3:13 PM TracRevisionLog edited by trac

(diff)

3:13 PM TracChangeset edited by trac

(diff)

3:13 PM WikiFormatting edited by trac

(diff)

3:13 PM TracWorkflow edited by trac

(diff)

3:13 PM TracAdmin edited by trac

(diff)

3:13 PM TracNavigation edited by trac

(diff)

3:13 PM TracGuide edited by trac

(diff)

3:13 PM InterWiki edited by trac

(diff)

3:13 PM TracBackup edited by trac

(diff)

3:13 PM CamelCase edited by trac

(diff)

3:13 PM WikiPageNames edited by trac

(diff)

3:13 PM TracRss edited by trac

(diff)

3:13 PM WikiRestructuredTextLinks edited by trac

(diff)

3:13 PM TracAccessibility edited by trac

(diff)

2:27 PM Changeset in webkit [16788] by kmccullo

• 2 edits in trunk/JavaScriptCore

Reviewed by aroben

• build fix

• JavaScriptCore.xcodeproj/project.pbxproj:

2:11 PM Changeset in webkit [16787] by bdash

• 2 edits in trunk/JavaScriptCore

2006-10-04 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Mitz.

Fix Qt/Linux build by adding DateMath.cpp to compilation.

• CMakeLists.txt: Also replace tabs with spaces.

2:08 PM Changeset in webkit [16786] by kmccullo

• 2 edits in trunk/JavaScriptCore

Reviewed by DethBakin.

• Apparently the build bot uses an older version of XCode which warns about conversions and the newest version does not. I hope this fixes the build but I cann't be sure on my system.

• kjs/DateMath.cpp: (KJS::msToYear): (KJS::dayInYear): (KJS::dateToDayInYear):

1:44 PM Changeset in webkit [16785] by thatcher

• 2 edits in trunk/WebKitTools

Reviewed by Mitz Pettel!

Bug 10708: [Drosera] Make the console input plaintext-only
​http://bugs.webkit.org/show_bug.cgi?id=10708

Change the console input -webkit-user-modify property to
read-write-plaintext-only.

• Drosera/console.css:

1:40 PM Changeset in webkit [22296] by darin

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

• platform/win/NotImplemented.h: Changed implementation to use Assertions.h. Also fixed both macros to be single-statement macros.

1:37 PM Changeset in webkit [16784] by thatcher

• 2 edits in trunk/WebKitTools

Reviewed by Tim H.

Bug 10473: [Drosera] Overlapping text in JavaScript Console
​http://bugs.webkit.org/show_bug.cgi?id=10473

Using min-height instead of height to avoid overlapping text.

• ChangeLog:
• Drosera/console.css:

1:35 PM Changeset in webkit [16783] by kmccullo

• 3 edits in trunk/JavaScriptCore

Reviewed by Adam.

• wtf/Assertions.cpp: Changed assertion formatting to omit the "======" lines so you can see more assertions in less space. Also improved format of file/line information so it works with more development environments.

1:34 PM Changeset in webkit [16782] by darin

• 2 edits in trunk/JavaScriptCore

Reviewed by Adam.

• wtf/Assertions.cpp: Changed assertion formatting to omit the "======" lines so you can see more assertions in less space. Also improved format of file/line information so it works with more development environments.

11:37 AM Changeset in webkit [16781] by thatcher

• 2 edits in trunk/WebKitTools

Reviewed by Tim H.

Added a bash-style command history.

• Drosera/console.js:

11:36 AM Changeset in webkit [16780] by kmccullo

• 6 edits
  2 adds in trunk/JavaScriptCore

Reviewed by GGaren

• This is a big makeover for our Date implemenetation. This solves many platform specific issues, specifically dates before 1970, and simplifies some ugly code. The purpose of this was to get us to pass many of the JavaScriptCore tests on windows.

• JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
• JavaScriptCore.xcodeproj/project.pbxproj:
• kjs/DateMath.cpp: Added. (KJS::): (KJS::daysInYear): (KJS::daysFrom1970ToYear): (KJS::msFrom1970ToYear): (KJS::msToDays): (KJS::msToYear): (KJS::isLeapYear): (KJS::isInLeapYear): (KJS::dayInYear): (KJS::msToMilliseconds): (KJS::msToWeekDay): (KJS::msToSeconds): (KJS::msToMinutes): (KJS::msToHours): (KJS::msToMonth): (KJS::msToDayInMonth): (KJS::monthToDayInYear): (KJS::timeToMseconds): (KJS::dateToDayInYear): (KJS::equivalentYearForDST): (KJS::getUTCOffset): (KJS::getDSTOffsetSimple): (KJS::getDSTOffset): (KJS::localTimeToUTC): (KJS::UTCToLocalTime): (KJS::dateToMseconds): (KJS::msToTM): (KJS::isDST):
• kjs/DateMath.h: Added. (KJS::):
• kjs/date_object.cpp: (KJS::gmtoffset): (KJS::formatTime): (KJS::DateInstance::getTime): (KJS::DateInstance::getUTCTime): (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): (KJS::DateObjectFuncImp::callAsFunction): (KJS::parseDate):
• kjs/testkjs.cpp:
• os-win32/stdint.h:

11:34 AM Changeset in webkit [22295] by darin

• 7 edits
  2 adds in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

• fix <rdar://problem/4764253> frame targeting not implemented.

• bridge/win/FrameWin.h: Added new window boolean to openURL. Also changed type from DeprecatedString to String.
• bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): Added logic to do frame targeting.

• platform/win/BString.h: Added. Convenience for working with BSTR and handling allocation/free.
• platform/win/BString.cpp: Added.
• WebCore.vcproj/WebCore.vcproj: Added new files.

WebKitWin:

Reviewed by Adam.

• fix <rdar://problem/4764253> frame targeting not implemented.

• WebFrame.h: Added newWindow parameter to openURL and changed the URL parameter to a String.
• WebFrame.cpp: (WebFrame::openURL): Changed code to use BString to convert the String to a BSTR. Also respect the newWindow parameter and changed the new window code slightly, adding a FIXME.

11:04 AM Changeset in webkit [16779] by andersca

• 2 edits in trunk/WebCore

2006-10-04 Anders Carlsson <​acarlsson@apple.com>

Reviewed by John Sullivan.

<rdar://problem/4654328>
Safari Crashes in WebCore::PluginTokenizer::writeRawData If I Try to Open a SWF File With Plug-ins Turned Off

• loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData): Only send the data to the plug-in if plug-ins are enabled, otherwise just silently eat it.

1:43 AM Changeset in webkit [16778] by hyatt

• 1 edit in trunk/WebCore/platform/gdk/TemporaryLinkStubs.cpp

Fix Gdk bustage.

1:39 AM Changeset in webkit [16777] by hyatt

• 1 edit in trunk/WebCore/platform/gdk/TemporaryLinkStubs.cpp

Fix Gdk bustage.

1:26 AM Changeset in webkit [16776] by hyatt

• 2 edits in trunk/WebCore/platform

Fix more win32 and qt bustage.

1:21 AM Changeset in webkit [16775] by hyatt

• 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

Fix more win32 bustage.

1:19 AM Changeset in webkit [16774] by hyatt

• 1 edit in trunk/WebCore/platform/win/TemporaryLinkStubs.cpp

Fix more win32 bustage.

1:11 AM Changeset in webkit [16773] by hyatt

• 1 edit in trunk/WebCore/platform/gdk/TemporaryLinkStubs.cpp

Fix Gdk bustage.

1:10 AM Changeset in webkit [16772] by hyatt

• 1 edit in trunk/WebCore/platform/qt/TemporaryLinkStubs.cpp

Fix Qt bustage.

1:09 AM Changeset in webkit [16771] by hyatt

• 1 edit in trunk/WebCore/platform/gdk/WidgetGdk.cpp

Fix Gdk bustage.

1:06 AM Changeset in webkit [16770] by hyatt

• 2 edits in trunk/WebCore/platform/qt

Fix Qt bustage.

1:05 AM Changeset in webkit [16769] by hyatt

• 1 edit in trunk/WebCore/platform/win/ScrollViewWin.cpp

Fix Win32 bustage.

12:53 AM Changeset in webkit [16768] by hyatt

• 1 edit in trunk/WebCore/platform/win/ScrollViewWin.cpp

Fix Win32 bustage.

12:52 AM Changeset in webkit [16767] by hyatt

• 2 edits in trunk/WebCore/platform/win

Fix Win32 bustage.

12:22 AM Changeset in webkit [22294] by hyatt

• 4 edits in branches/WindowsMerge/WebKitWin

Fix the textfield caret by not doing layouts every time we paint.

Oct 3, 2006:

9:50 PM Changeset in webkit [22293] by hyatt

• 1 edit in branches/WindowsMerge/WebCore/platform/win/WidgetWin.cpp

Move function into WidgetWin.cpp, since I made it windows only but had left it in Widget.cpp (breaking mac)

9:45 PM Changeset in webkit [16766] by hyatt

• 1 edit in trunk/WebCore/platform/Widget.cpp

Fix mac build bustage.

9:34 PM Changeset in webkit [16765] by ap

• 5 edits in trunk

Reviewed by Tim H.

​http://bugs.webkit.org/show_bug.cgi?id=11130
Convert "undefined" to AE missing value

WebCore:

• bridge/mac/WebCoreFrameBridge.mm: (aeDescFromJSValue): return missing value for UndefinedType.

LayoutTests:

• fast/AppleScript/001-expected.txt:
• fast/AppleScript/array-expected.txt: Updated the results.

9:26 PM Changeset in webkit [22292] by hyatt

• 7 edits in branches/WindowsMerge/WebCore

Land the new scrollview.

9:26 PM Changeset in webkit [22291] by hyatt

• 4 edits in branches/WindowsMerge/WebKitWin

Improve painting to not always use the unioned invalidation rect.

9:22 PM Changeset in webkit [16764] by hyatt

• 18 edits in trunk/WebCore

Scrolling work.

8:36 PM Changeset in webkit [16763] by bdash

• 2 edits in trunk/WebKit

2006-10-04 Mark Rowe <​bdash@webkit.org>

Reviewed by NOBODY (build fix).

• WebView/WebView.m: (-[WebView scrollDOMRangeToVisible:]): Move scrollDOMRangeToVisible: into the correct category.

7:51 PM Changeset in webkit [16762] by bdash

• 2 edits in trunk

Update bug URLs in the two patches that I just landed.

7:46 PM Changeset in webkit [16761] by bdash

• 6 edits in trunk

2006-09-26 David Smith <​catfish.man@gmail.com>

Reviewed by Timothy.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=3723
Add -scrollDOMRangeToVisible:

No automated tests are possible as this code path isn't reachable from JavaScript.

• bridge/mac/WebCoreFrameBridge.h:
• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge scrollDOMRangeToVisible:]):

2006-09-26 David Smith <​catfish.man@gmail.com>

Reviewed by Timothy.

​http://bugzilla.opendarwin.org/show_bug.cgi?id=3723
Add -scrollDOMRangeToVisible:

• WebView/WebView.m: (-[WebView scrollDOMRangeToVisible:]):
• WebView/WebViewPrivate.h:

7:31 PM Changeset in webkit [16760] by bdash

• 13 edits in trunk

2006-10-03 Graham Dennis <​graham.dennis@gmail.com>

Reviewed by Timothy.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=10338>
When contentEditable, cursor doesn't change to hand

Allow the behaviour of editable links to be specified by a WebPreference
The preference WebKitEditableLinkBehavior has four options:

• AlwaysLive: Safari 2.0 behaviour
• OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
• LiveWhenNotFocused: Editable links are live only when their editable block is not

focused, or when the shift key is pressed

• DefaultBehavior: This is the same as OnlyLiveWithShiftKey.

No layout tests, just a modification of a manual-test as it isn't possible to test
this automatically.

• bridge/mac/WebCoreSettings.h:
• bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings setEditableLinkBehavior:]): (-[WebCoreSettings editableLinkBehavior]):
• html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::HTMLAnchorElement): (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::setActive):
• html/HTMLAnchorElement.h:
• manual-tests/contenteditable-link.html:
• page/FrameView.cpp: (WebCore::nodeIsNotBeingEdited): (WebCore::selectCursor):
• page/Settings.h: (WebCore::Settings::): (WebCore::Settings::Settings): (WebCore::Settings::editableLinkBehavior): (WebCore::Settings::setEditableLinkBehavior):

2006-10-03 Graham Dennis <​graham.dennis@gmail.com>

Reviewed by Timothy.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=10338>
When contentEditable, cursor doesn't change to hand

Allow the behaviour of editable links to be specified by a WebPreference
The preference WebKitEditableLinkBehavior has four options:

• AlwaysLive: Safari 2.0 behaviour
• OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
• LiveWhenNotFocused: Editable links are live only when their editable block is not

focused, or when the shift key is pressed

• DefaultBehavior: This is the same as OnlyLiveWithShiftKey.

No layout tests, just a modification of a manual-test as it isn't possible to test
this automatically.

• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.m: (+[WebPreferences initialize]): (-[WebPreferences editableLinkBehavior]): (-[WebPreferences setEditableLinkBehavior:]):
• WebView/WebPreferencesPrivate.h:
• WebView/WebView.m: (-[WebView _updateWebCoreSettingsFromPreferences:]):

6:28 PM Changeset in webkit [22290] by aroben

• 2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

Improvements to error handling in PluginStreamWin.

• plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::deliverData): Fail quietly if called after termination (due to bad error handling in ResourceLoaderWin), ASSERT if called before stream has been started. (WebCore::PluginStreamWin::receivedData): Ditto. (WebCore::PluginStreamWin::receivedAllData): Ditto.

6:12 PM Changeset in webkit [16759] by bdakin

• 3 edits in trunk/WebCore

Reviewed Darin.

No test cases needed.

Implemented a version of StringImpl::append that takes a UChar* and
a length.

• platform/StringImpl.cpp: (WebCore::StringImpl::append): (WebCore::StringImpl::insert): Call new append instead of making a new StringImpl.
• platform/StringImpl.h:

6:10 PM Changeset in webkit [16758] by andersca

• 2 edits in trunk/WebKitTools

2006-10-03 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Adam and Brady.

• DumpRenderTree/DumpRenderTree.m: (main): Update URL to Ahem.ttf

6:09 PM Changeset in webkit [16757] by bdash

• 2 edits in trunk/WebCore

2006-10-03 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Darin.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11099
HttpSendRequestEx results in ERROR_HTTP_HEADER_NOT_FOUND

• platform/win/ResourceLoaderWin.cpp: (WebCore::ResourceLoader::onHandleCreated):

5:42 PM Changeset in webkit [22289] by aroben

• 3 edits in branches/WindowsMerge/WebCore

Reviewed by Anders.

Fixes <rdar://problem/4760963>
Failed ASSERT in PluginStreamWin::~PluginStreamWin at espn.com

We now store the state of a stream as a tri-state enum in
m_streamState. This allows us to differentiate between before and after the
stream has been started.

• plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::PluginStreamWin): Initialize members of m_stream struct individually. (WebCore::PluginStreamWin::~PluginStreamWin): (WebCore::PluginStreamWin::startStream): (WebCore::PluginStreamWin::destroyStream): (WebCore::PluginStreamWin::deliverData): Return early if the stream isn't started. (WebCore::PluginStreamWin::receivedData): Ditto. (WebCore::PluginStreamWin::receivedAllData): Ditto.
• plugins/win/PluginStreamWin.h: (WebCore::): Add PluginStreamState enum.

4:50 PM Changeset in webkit [16756] by thatcher

• 5 edits in tags/WebCore-521.28.1/WebCore

Merging a fix for bug 4671286 (r16737).

4:48 PM Changeset in webkit [16755] by thatcher

• 2 edits in tags/WebCore-521.28.1/WebCore

Reviewed by Hyatt.

Fix for ​http://bugzilla.opendarwin.org/show_bug.cgi?id=10842
REGRESSION (r15418): contenteditable div truncates rightmost Japanese character

Make sure we only break after a space (and not any other valid line-break) if
the style is -webkit-line-break: after-white-space (e.g. for a contentEditable div).
I also did a logic shuffle at Mitz's request to prevent doing an if on the same expression
twice in quick succession.

• rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak):

4:46 PM Changeset in webkit [16754] by thatcher

• 3 edits in tags/WebCore-521.28.1/WebCore

Merging a fix for 4717965 and 4712111 (r16567).

4:28 PM Changeset in webkit [16753] by thatcher

• 1 edit in tags/WebCore-521.28.1/WebCore/Info.plist

Versioning

4:28 PM Changeset in webkit [16752] by justing

• 7 edits
  8 adds in trunk

LayoutTests:

Reviewed by harrison

• editing/execCommand/paste-1-expected.checksum: Added.
• editing/execCommand/paste-1-expected.png: Added.
• editing/execCommand/paste-1-expected.txt: Added.
• editing/execCommand/paste-1.html: Added.
• editing/execCommand/paste-2-expected.checksum: Added.
• editing/execCommand/paste-2-expected.png: Added.
• editing/execCommand/paste-2-expected.txt: Added.
• editing/execCommand/paste-2.html: Added.

WebKit:

Reviewed by harrison

execCommand("Cut"/"Copy"/"Paste") broken in editable subframes.

• WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge issueCutCommand]): Issue the command on the WebHTMLView, not the WebView. (-[WebFrameBridge issueCopyCommand]): Ditto. (-[WebFrameBridge issuePasteCommand]): Ditto. (-[WebFrameBridge issuePasteAndMatchStyleCommand]): Ditto. (-[WebFrameBridge issueTransposeCommand]): Fixed formatting. (-[WebFrameBridge canPaste]): Ask the WebHTMLView, not the WebView.
• WebView/WebHTMLView.m: (-[WebHTMLView copy:]): Moved to WebInternal (-[WebHTMLView cut:]): Ditto. (-[WebHTMLView paste:]): Ditto. (-[WebHTMLView pasteAsPlainText:]): Ditto.
• WebView/WebHTMLViewInternal.h:
• WebView/WebView.m: Removed the now unused _canPaste.
• WebView/WebViewInternal.h: Ditto.

4:25 PM Changeset in webkit [16751] by thatcher

• 1 copy in tags/WebCore-521.28.1/WebCore

New tag part 2.

4:24 PM Changeset in webkit [16750] by thatcher

• 1 add in tags/WebCore-521.28.1

New tag.

4:24 PM Changeset in webkit [16749] by thatcher

• 1 delete in WebCore-521.28.1

Bad tag.

4:23 PM Changeset in webkit [16748] by thatcher

• 1 add in WebCore-521.28.1

New tag.

4:19 PM Changeset in webkit [16747] by bdakin

• 9 edits in trunk/LayoutTests

Reviewed by Geoff.

Changing these two counters tests so they pass on the BuildBot.

• fast/css/counters/counter04-expected.checksum:
• fast/css/counters/counter04-expected.png:
• fast/css/counters/counter04-expected.txt:
• fast/css/counters/counter04.html:
• fast/css/counters/counters04-expected.checksum:
• fast/css/counters/counters04-expected.png:
• fast/css/counters/counters04-expected.txt:
• fast/css/counters/counters04.html:

4:00 PM Changeset in webkit [16746] by justing

• 4 edits in trunk/LayoutTests

Reviewed by geoff

Fixed a typo, updating expected results.

• editing/execCommand/create-list-with-hr-expected.checksum:
• editing/execCommand/create-list-with-hr-expected.png:
• editing/execCommand/create-list-with-hr-expected.txt:

4:00 PM Changeset in webkit [16745] by ggaren

• 6 edits in trunk/WebCore

Feared, loathed, reviewed by Darin.

More frame/iframe merging. Merged IFRAME::willRemove and IFRAME::detach
into FRAME, plus other cleanup.

No new behavior, so no new test. Layout tests pass. Basic browsing and
Mail editing seem to work.

• dom/Node.cpp: (WebCore::Node::detach): Removed random commented-out code.
• html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::isURLAllowed): (1) Removed reference to FrameView, to dissociate frame loading from rendering. (2) Renamed newURL to completeURL because the difference between newURL and URLString is that newURL is a KURL that is the complete version of URLString, not that it is new. (WebCore::HTMLFrameElement::willRemove): (1) Removed close() call and moved close() code into willRemove(), also removing close() call from detach(), since willRemove is the well-defined place from DOM tear-down, not detach(). (2) Removed manual renderer detach code because the DOM is not responsible for managing the render tree. I confirmed that this change not regress <rdar://problem/4132581>. (3) Removed questionable ASSERT. The ASSERT assumed that iframe elements lost their content frames after being removed from the DOM. That's our current behavior, but it's going to change in future rounds of refactoring. This also fixes <rdar://problem/4750835>. (WebCore::HTMLFrameElement::setLocation): Removed wacky manual calls to attach/detach, because the render tree should not be in charge of deciding when to load.
• html/HTMLFrameElement.h:
• html/HTMLIFrameElement.cpp: (WebCore::HTMLIFrameElement::attach): Renamed renderPart to renderPartObject, because the renderer is a renderPartObject, not a renderPart.
• html/HTMLIFrameElement.h:

3:46 PM Changeset in webkit [16744] by darin

• 2 edits in trunk/WebKitTools

• Scripts/commit-log-editor: Added missing "close" call. Oops!

3:14 PM Changeset in webkit [16743] by bdash

• 2 edits in trunk/WebCore

2006-10-03 Mark Rowe <​bdash@webkit.org>

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=11137
Bug 11137: GdkLauncher dies with "pure virtual method called" if
window is closed while page still loading

• platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::~FrameGdk): Call cancelAndClear to allow virtual methods to be called before the FrameGdk portion of "this" is torn down.

2:53 PM Changeset in webkit [16742] by justing

• 2 edits in trunk/WebKit

Reviewed by geoff

<rdar://problem/4763519> REGRESSION: Multipart/x-mixed-replace sub-resources fail to load

• Loader/WebSubresourceLoader.m: (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]): Enable multipart/x-mixed-replace support on the request. This line was accidently removed during some loader refactoring.

2:10 PM Changeset in webkit [22288] by aroben

• 8 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin.

Fixes <rdar://problem/4603342>
Keyboard navigability

Implement tabbing between form elements (in the single-frame case).

• bridge/win/FrameWin.cpp: Add methods to determine tabbing preferences. (WebCore::FrameWin::tabsToLinks): (WebCore::FrameWin::tabsToAllControls):
• bridge/win/FrameWin.h: Add tabsToLinks() to FrameWinClient
• platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::scrollPointRecursively): Implemented for single-frame case.
• platform/win/TemporaryLinkStubs.cpp: Remove stub for now-implemented ScrollView::scrollPointsRecursively

WebKitWin:

Reviewed by Darin.

Part of fix for <rdar://problem/4603342>
Keyboard navigability

Implement methods to determine tabbing preferences.

• WebFrame.cpp: (WebFrame::tabsToLinks):
• WebFrame.h:

2:09 PM Changeset in webkit [16741] by aroben

• 4 edits in trunk/WebCore

Reviewed by Darin.

Handle tab key presses in the DOM.

• dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Add tab key handling.
• page/FrameView.cpp: (WebCore::FrameView::advanceFocus): Rename and reimplement focusNextPrevNode. Now we just call Element::focus().
• page/FrameView.h: Rename focusNextPrevNode to advanceFocus and make it public.

12:01 PM Changeset in webkit [16740] by justing

• 2 edits in trunk/WebCore

Reviewed by mjs

<rdar://problem/4760612>
TOT REGRESSION: Repro assertion failure when forwarding draft in Range::compareBoundaryPoints

No layout test possible, attributedStringFrom:(DOMNode*)...etc isn't available to DRT.

• dom/Range.cpp: (WebCore::Range::boundaryPointsValid): compareBoundaryPoints asserts that the incoming positions are non-null since most of it's callers would be in a bad state if the positions were null. boundaryPointsValid, which calls compareBoundaryPoints, is an exception. Instead of removing the assert I've added nil checks in boundaryPointsValid, to keep it from entering compareBoundaryPoints and hitting the assert.

11:55 AM Changeset in webkit [16739] by adele

• 2 edits in trunk/WebCore

Reviewed by Geoff.

Make code for turning off new listbox implementation mac-only, since there's no implementation on other platforms.

• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcStyle): (WebCore::HTMLSelectElement::isKeyboardFocusable): (WebCore::HTMLSelectElement::isMouseFocusable): (WebCore::HTMLSelectElement::createRenderer): (WebCore::HTMLSelectElement::setRecalcListItems): (WebCore::HTMLSelectElement::notifyOptionSelected): (WebCore::HTMLSelectElement::defaultEventHandler):

11:18 AM Changeset in webkit [16738] by darin

• 2 edits in trunk/WebCore

2006-10-04 Darin Adler <Darin Adler>

Reviewed by Geoff.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=11132 Caret disappears when you're typing

• editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): Remove unnecessary call to clearCaretRectIfNeeded. The recomputeCaretRect now takes care of this. (WebCore::SelectionController::recomputeCaretRect): Explicitly set m_needsLayout to false so we can get the old caret repaint rect. Later we need to change the design so getting the rect doesn't have a side effect of causing a layout without invalidation.

11:16 AM Changeset in webkit [22287] by darin

• 2 edits in branches/WindowsMerge/WebKitWin

2006-10-04 Darin Adler <Darin Adler>

Reviewed by Adam.

• WebView.cpp: (WebView::handleMouseEvent): Pass message when creating a PlatformMouseEvent.

7:44 AM Changeset in webkit [16737] by harrison

• 10 edits in trunk

LayoutTests:

Reviewed by Maciej.

<rdar://problem/4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.

Updated test so that it actually shows the caret rect for the caret position.
Before, it was showing the caret rect for the 9th character of the test description.

• fast/text/justified-text-rect-expected.checksum:
• fast/text/justified-text-rect-expected.png:
• fast/text/justified-text-rect-expected.txt:
• fast/text/justified-text-rect.html:

WebCore:

Reviewed by Maciej.

<rdar://problem/4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.

Updated test:

• fast/text/justified-text-rect.html

• bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge convertToNSRange:]): (-[WebCoreFrameBridge convertToDOMRange:]): Make the selection's root editable element (or the document itself) be the basis for NSRange conversions. This supports "shadow DOM" like that for text fields and text areas.

• editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Pass the document element as the scope.

• editing/TextIterator.cpp: (WebCore::TextIterator::rangeFromLocationAndLength): Make the first parameter the scope.

• editing/TextIterator.h: Make the first parameter of rangeFromLocationAndLength() the scope.

5:14 AM Changeset in webkit [16736] by eseidel

• 4 edits in trunk/WebKitTools

2006-10-03 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Offer a way for BuildBot to not colorize the cmake output, when building
with the 'build-webkit' script. Add "--color" / "--no-color" option pair.

Default is colorize output, though only Qt platform handles this for now.

• Scripts/build-dumprendertree:
• Scripts/build-webkit:
• Scripts/webkitdirs.pm:

3:49 AM Changeset in webkit [16735] by eseidel

• 5 edits in trunk/WebKitTools

2006-10-03 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by eseidel. Landed by eseidel.

Make all important scripts work with Qt/Linux.

You can safely use this now:
set-configuration-release --debug && build-webkit && run-javascriptcore-tests && run-webkit-tests

• Scripts/build-dumprendertree:
• Scripts/run-javascriptcore-tests:
• Scripts/run-webkit-tests:
• Scripts/webkitdirs.pm:

2:46 AM Changeset in webkit [16734] by bdash

• 4 edits in trunk

2006-10-03 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Eric.

build-webkit tweak: Use WebKitBuild/$config as output dir (Release/Debug).

• Scripts/webkitdirs.pm:

2006-10-03 Nikolas Zimmermann <​zimmermann@kde.org>

Reviewed by Eric.

Fix Qt/Linux build.

• CMakeLists.txt: Add counter related files.

2:42 AM Changeset in webkit [16733] by bdash

• 9 edits
  1 add in trunk

2006-10-03 Mark Rowe <​bdash@webkit.org>

Reviewed by Eric.

Stop Bakefile-generated Makefile from running `pkg-config' multiple times per file.

• presets.bkl: Make use of "options" and Python commands to run pkg-config etc up front.

2006-10-03 Mark Rowe <​bdash@webkit.org>

Reviewed by Eric.

​http://bugs.webkit.org/show_bug.cgi?id=10981
Linux/GDK build fixes

Based on a patch by Krzysztof Kowalczyk.

• WebCoreSources.bkl:
• platform/gdk/FrameGdk.cpp: (WebCore::doScroll): (WebCore::FrameGdk::handleGdkEvent):
• platform/gdk/PlatformScrollBar.h: Added. (WebCore::PlatformScrollBar::isWidget):
• platform/gdk/ScrollViewGdk.cpp:
• platform/gdk/TemporaryLinkStubs.cpp: (FrameView::passMousePressEventToScrollbar): (FrameView::passMousePressEventToSubframe): (FrameView::passMouseReleaseEventToSubframe): (FrameView::passMouseMoveEventToSubframe): (FrameView::passWheelEventToSubframe): (Cursor::Cursor): (Widget::invalidate): (Widget::invalidateRect): (ScrollView::wheelEvent): (ScrollView::convertToContainingWindow): (ScrollView::convertFromContainingWindow): (GraphicsContext::clip): (PlatformScrollBar::PlatformScrollBar): (PlatformScrollBar::updateThumbPosition): (PlatformScrollBar::updateThumbProportion): (ScrollBar::ScrollBar): (ScrollBar::setProportion): (WebCore::supportedKeySizes): (WebCore::signedPublicKeyAndChallengeString):
• platform/gdk/WheelEventGdk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
• platform/gdk/WidgetGdk.cpp: (WebCore::Widget::convertToContainingWindow): (WebCore::Widget::convertFromContainingWindow):