Context Navigation

← Previous Period
Next Period →

Timeline

Oct 17, 2006:

11:04 PM Changeset in webkit [17104] by ggaren

2 edits in trunk/WebCore

Reviewed by Anders.

Factored common scaling code into a helper function.

platform/mac/ScreenMac.mm: (WebCore::scale): (WebCore::scaleScreenRectToPageCoordinates): (WebCore::scalePageRectToScreenCoordinates):

10:52 PM Changeset in webkit [22379] by sfalken

11 edits in branches/WindowsMerge

2006-10-17 Steve Falkenburg <sfalken@apple.com>

Reviewed by ggaren.

<rdar://4781999> History menu gets borked if you visit a page with no title.
<rdar://4782002> The History menu is frequently utterly corrupted, with incorrect favicons next to mismatched titles.
<rdar://4780252> Page titles in History menu are incorrect
<rdar://4760334> Pages without title show an old title instead of a default title

2006-10-17 Steve Falkenburg <sfalken@apple.com>

Reviewed by ggaren.

<rdar://4781999> History menu gets borked if you visit a page with no title.
<rdar://4782002> The History menu is frequently utterly corrupted, with incorrect favicons next to mismatched titles.
<rdar://4780252> Page titles in History menu are incorrect
<rdar://4760334> Pages without title show an old title instead of a default title

Interfaces/IWebHistoryItemPrivate.idl: added setTitle to set title for a page after we receive it
WebFrame.cpp: Removed unnecessary WebFramePrivate::title (WebFrame::goToItem): Get back/forward list via frame-aware getter (WebFrame::receivedRedirect): Use BString (WebFrame::receivedResponse): Use BString. Get back/forward list, history via frame-aware getters. (WebFrame::createFrame): Use BString (WebFrame::submitForm): Clean up up BSTR usage (WebFrame::setTitle): Set title in back/forward, history when received (WebFrame::backForwardList): Frame-aware getter for back/forward (WebFrame::webHistory): Frame-aware getter for history
WebFrame.h: Added frame-aware getters for history, back/forward
WebHistory.cpp: Reorder includes. (WebHistory::QueryInterface): Support QI to WebHistory via CLSID (avoids yucky static cast in other places)
WebHistoryItem.cpp: (WebHistoryItem::setTitle): Added
WebHistoryItem.h: Added setTitle
WebView.cpp: (WebView::QueryInterface): Support QI to WebView via CLSID

2006-10-17 Steve Falkenburg <sfalken@apple.com>

Build fix

platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::createNewWindow):

10:46 PM Changeset in webkit [17103] by sfalken

9 edits in trunk/WebCore

2006-10-17 Steve Falkenburg <sfalken@apple.com>

Build fixes

bridge/win/BrowserExtensionWin.cpp: (WebCore::BrowserExtensionWin::createNewWindow):
bridge/win/BrowserExtensionWin.h:
bridge/win/FrameWin.cpp: (WebCore::FrameWin::createNewWindow):
bridge/win/FrameWin.h:
platform/gdk/BrowserExtensionGdk.h:
platform/gdk/TemporaryLinkStubs.cpp: (BrowserExtensionGdk::createNewWindow):
platform/qt/BrowserExtensionQt.cpp: (WebCore::BrowserExtensionQt::createNewWindow):
platform/qt/BrowserExtensionQt.h:

10:16 PM Changeset in webkit [22378] by ggaren

2 edits in branches/WindowsMerge/WebCore

Reviewed by Anders.

Added WindowFeatures.h to the project.

WebCore.vcproj/WebCore.vcproj:

10:13 PM Changeset in webkit [17102] by ggaren

7 edits
1 copy in trunk/WebCore

Reviewed by Anders.

Renamed WindowArgs to WindowFeatures, and moved it into its own header.
("Features" is the term of art in IE documentation. "Args" is pirate
talk.)

WebCore.xcodeproj/project.pbxproj:
bindings/js/kjs_window.cpp: (KJS::createNewWindow): (KJS::showModalDialog): (KJS::setWindowFeature): (KJS::parseWindowFeatures): (KJS::constrainToVisible): (KJS::WindowFunc::callAsFunction):
bridge/BrowserExtension.h:
bridge/WindowFeatures.h: Added.
bridge/mac/BrowserExtensionMac.h:
bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):

9:16 PM Changeset in webkit [22377] by sfalken

1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/WebKit.vcproj

9:15 PM Changeset in webkit [22376] by sfalken

2 edits in branches/WindowsMerge/WebCore

2006-10-17 Steve Falkenburg <sfalken@apple.com>

Reviewed by Maciej.

Turn off a very noisy warning (unknown pragma) caused by an Interfacer include

WebCore.vcproj/WebCore.vcproj:

9:09 PM Changeset in webkit [17101] by sfalken

2 edits in trunk/JavaScriptCore

2006-10-17 Steve Falkenburg <sfalken@apple.com>

Reviewed by Maciej.

Adjust include paths

JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

8:04 PM Changeset in webkit [17100] by weinig

18 edits
8 copies
1 move
1 delete in trunk/WebCore

Reviewed by Tim H.

Patch for http://bugs.webkit.org/show_bug.cgi?id=11268
Implement the Objective-C DOM bindings for SVGNumber, SVGRect, and SVGPoint

Adds implementation for DOMSVGNumber, DOMSVGRect, and DOMSVGPoint.

Moves the contents of ksvg/bindings/js/ to bindings/js/.

Moves SVGZoomEvent.idl from ksvg/svg/ to ksvg/events/.

Adds isSVGColor() and isSVGPaint() methods to StyleBase, matching the other CSSValue classing, and allowing the bindings to allocate appropriately.

Removes #ifdefs around the getBBox() method in SVGLocatable.idl allowing generation for Objective-C.

Assorted style cleanups.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/objc/DOMCSS.mm: (+[DOMCSSValue _CSSValueWith:WebCore::]):
bindings/objc/DOMEvents.mm: (+[DOMEvent _eventWith:WebCore::]):
bindings/objc/DOMSVG.h:
bindings/objc/DOMSVGNumber.mm: (-[DOMSVGNumber dealloc]): (-[DOMSVGNumber finalize]): (-[DOMSVGNumber value]): (-[DOMSVGNumber setValue:]): (-[DOMSVGNumber _SVGNumber]): (-[DOMSVGNumber _initWithFloat:]): (+[DOMSVGNumber _SVGNumberWith:]):
bindings/objc/DOMSVGPoint.mm: (-[DOMSVGPoint dealloc]): (-[DOMSVGPoint finalize]): (-[DOMSVGPoint x]): (-[DOMSVGPoint setX:]): (-[DOMSVGPoint y]): (-[DOMSVGPoint setY:]): (-[DOMSVGPoint WebCore::]): (-[DOMSVGPoint _initWithFloatPoint:WebCore::]): (+[DOMSVGPoint _SVGPointWith:WebCore::]):
bindings/objc/DOMSVGRect.mm: (-[DOMSVGRect dealloc]): (-[DOMSVGRect finalize]): (-[DOMSVGRect x]): (-[DOMSVGRect setX:]): (-[DOMSVGRect y]): (-[DOMSVGRect setY:]): (-[DOMSVGRect width]): (-[DOMSVGRect setWidth:]): (-[DOMSVGRect height]): (-[DOMSVGRect setHeight:]): (-[DOMSVGRect WebCore::]): (-[DOMSVGRect _initWithFloatRect:WebCore::]): (+[DOMSVGRect _SVGRectWith:WebCore::]):
bindings/scripts/CodeGeneratorObjC.pm:
css/StyleBase.h: (WebCore::StyleBase::isSVGColor): (WebCore::StyleBase::isSVGPaint):
ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp: Removed.
ksvg2/bindings/js/JSSVGElementWrapperFactory.h: Removed.
ksvg2/bindings/js/JSSVGNumber.cpp: Removed.
ksvg2/bindings/js/JSSVGNumber.h: Removed.
ksvg2/bindings/js/JSSVGPoint.cpp: Removed.
ksvg2/bindings/js/JSSVGPoint.h: Removed.
ksvg2/bindings/js/JSSVGRect.cpp: Removed.
ksvg2/bindings/js/JSSVGRect.h: Removed.
ksvg2/svg/SVGColor.h: (WebCore::SVGColor::isSVGColor):
ksvg2/svg/SVGFECompositeElement.idl:
ksvg2/svg/SVGFEFloodElement.idl:
ksvg2/svg/SVGLocatable.idl:
ksvg2/svg/SVGMarkerElement.idl:
ksvg2/svg/SVGPaint.h: (WebCore::SVGPaint::isSVGPaint):
ksvg2/svg/SVGRectElement.idl:
ksvg2/svg/SVGZoomEvent.idl: Removed.

7:12 PM Changeset in webkit [17099] by hyatt

1 edit in trunk/WebCore/ChangeLog

Fix changelog file list. It wasn't right.

7:10 PM Changeset in webkit [17098] by hyatt

5 edits in trunk/WebCore

Prepare for the elimination of the RenderLayer for <html> elements. The layer is still present,
but this patch makes everything work without a root layer being around.

Reviewed by beth

WebCore.xcodeproj/project.pbxproj:
platform/KURL.cpp: Removed.
platform/KURL.h: Removed.
rendering/RenderBlock.cpp: (WebCore::RenderBlock::paint): (WebCore::RenderBlock::paintChildren): (WebCore::RenderBlock::nodeAtPoint):
rendering/RenderLayer.cpp: (WebCore::frameVisibleRect): (WebCore::RenderLayer::hitTest): (WebCore::RenderLayer::hitTestLayer): (WebCore::RenderLayer::intersectsDamageRect):
rendering/RenderObject.cpp: (WebCore::RenderObject::setInnerNode):
rendering/RenderView.cpp: (WebCore::RenderView::paint):

6:56 PM Changeset in webkit [17097] by hyatt

15 edits in trunk/WebCore

Back out my previous patch to the WebCore memory cache.

loader/Cache.cpp: (WebCore::Cache::flush): (WebCore::Cache::setSize): (WebCore::Cache::getLRUListFor): (WebCore::Cache::removeFromLRUList): (WebCore::Cache::insertInLRUList):
loader/Cache.h:
loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::deref):
loader/CachedCSSStyleSheet.h:
loader/CachedImage.cpp: (WebCore::CachedImage::deref):
loader/CachedImage.h:
loader/CachedResource.cpp: (WebCore::CachedResource::setRequest): (WebCore::CachedResource::deref):
loader/CachedResource.h: (WebCore::CachedResource::allowInLRUList):
loader/CachedScript.cpp: (WebCore::CachedScript::deref):
loader/CachedScript.h:
loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::deref):
loader/CachedXBLDocument.h:
loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::deref):
loader/CachedXSLStyleSheet.h:

6:31 PM Changeset in webkit [17096] by oliver

2 edits in trunk/WebCore

2006-10-17 Oliver Hunt <oliver@apple.com>

Reviewed by Anders.

Make north and east resize cursors use correct image

platform/win/CursorWin.cpp: (WebCore::eastResizeCursor): (WebCore::northResizeCursor):

5:39 PM Changeset in webkit [22375] by oliver

6 edits in branches/WindowsMerge

2006-10-17 Oliver Hunt <oliver@apple.com>

Reviewed by Brady.

Fixed alpha in favicons, added composite operation conversion
for cg

rdar://problem/4758934

platform/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::setCompositeOperation):
platform/win/ImageWin.cpp: (WebCore::Image::getHBITMAP):
platform/win/TemporaryLinkStubs.cpp: (GraphicsContext::drawLineForMisspelling):

Fix flickering cursor

WebView.cpp: (registerWebViewWindowClass):

5:30 PM Changeset in webkit [17095] by oliver

5 edits in trunk/WebCore

2006-10-17 Oliver Hunt <oliver@apple.com>

Reviewed by Brady

Various cursor fixes

page/FrameView.cpp: (WebCore::FrameView::handleMouseMoveEvent):
platform/Cursor.h:
platform/mac/CursorMac.mm: (WebCore::pointerCursor):
platform/win/CursorWin.cpp: (WebCore::supportsAlphaCursors): (WebCore::Cursor::Cursor): (WebCore::Cursor::~Cursor): (WebCore::pointerCursor):

5:28 PM Changeset in webkit [17094] by justing

3 edits
4 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/4776665>
REGRESSION: In Mail, caret is visible when the message body isn't focused

editing/selection/4776665-expected.checksum: Added.
editing/selection/4776665-expected.png: Added.
editing/selection/4776665-expected.txt: Added.
editing/selection/4776665.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4776665>
REGRESSION: In Mail, caret is visible when the message body isn't focused

page/Frame.cpp: (WebCore::Frame::paintCaret): If a caret blink timer is ever on in error (like when the frame that contains the caret isn't focused) then we don't want to paint the caret. We should eventually move to using a single bool for caret painting.

4:52 PM Changeset in webkit [17093] by justing

3 edits
5 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/4774354>
REGRESSION: In Gmail, caret reappears when dragging a selection over some text in the message body

fast/repaint/4774354-expected.checksum: Added.
fast/repaint/4774354-expected.png: Added.
fast/repaint/4774354-expected.txt: Added.
fast/repaint/4774354.html: Added.
fast/repaint/resources/contenteditable-iframe-src.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4774354>
REGRESSION: In Gmail, caret reappears when dragging a selection over some text in the message body

Functions call recomputCaretRect to see if the caret rect has changed,
and, if it has, they invalidate (repaint) it. recomputeCaretRect was
returning false if the caret turned into a range selection or was blown
away.

editing/SelectionController.cpp: (WebCore::SelectionController::recomputeCaretRect): Don't early return if !isCaret(). Obtain the FrameView* using the m_frame pointer, because m_sel may now be null.

4:37 PM Changeset in webkit [17092] by ggaren

10 edits in trunk/WebCore

Reviewed by Brady.

BrowserExtension cleanup.

Removed unnecessary #include of BrowserExtension in Frame.h, added #includes to compensate in other files.

Removed unused versions of createNewWindow.

bindings/js/kjs_window.cpp:
bridge/BrowserExtension.h:
bridge/mac/BrowserExtensionMac.h:
bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
bridge/mac/WebCoreFrameBridge.mm:
html/HTMLFormElement.cpp:
loader/mac/LoaderFunctionsMac.mm:
page/Frame.h:
page/FramePrivate.h:

2:46 PM Changeset in webkit [17091] by kmccullo

3 edits in trunk/JavaScriptCore

Reviewed by Brady.

Fixes a JavaScriptCore math issue on win.

kjs/math_object.cpp: (MathFuncImp::callAsFunction):
wtf/MathExtras.h: (wtf_atan2):

2:20 PM Changeset in webkit [22374] by ggaren

2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Added HTMLFrameElementBase to the project.

WebCore.vcproj/WebCore.vcproj:

2:17 PM Changeset in webkit [17090] by ggaren

9 edits
2 copies in trunk/WebCore

Reviewed by Adam.

Fixed "FIXME: Violates Liskov Substitution principle."

IFRAME was never a true subclass of FRAME, since they disagreed on a
number of behaviors, which, confusingly, IFRAME just overrode and contradicted.

The fix here is to factor out things common to IFRAME and FRAME into a
common base class, HTMLFrameElementBase.

I also changed some " *" to "* " and added #includes in files that implicitly
assumed that HTMLIFrameElement.h #included HTMLFrameElement.h.

12:47 PM Changeset in webkit [17089] by justing

3 edits
4 adds in trunk

LayoutTests:

Reviewed by sullivan

<rdar://problem/4776765>
REGRESSION: Caret's ghost left behind after inserting a paragraph separator (11237)

fast/repaint/4776765-expected.checksum: Added.
fast/repaint/4776765-expected.png: Added.
fast/repaint/4776765-expected.txt: Added.
fast/repaint/4776765.html: Added.

WebCore:

Reviewed by sullivan

<rdar://problem/4776765>
REGRESSION: Caret's ghost left behind after inserting a paragraph separator (11237)

We set m_needsLayout to false and call caretRect() in the hopes that it will give us
the old caret rect. It in fact corrects the caret rect for an offset that it
believes is due to scrolling but which is actually due to a change in selection
without an accompanying layout. So it returns the new caret rect regardless of
what m_needsLayout is set to.

editing/SelectionController.cpp: (WebCore::repaintRectForCaret): Moved the code from caretRepaintRect that adds a one pixel slop to this new function. (WebCore::SelectionController::caretRepaintRect): Moved this code to repaintRectForCaret. (WebCore::SelectionController::recomputeCaretRect): Compare the old caret rect to the new one that's computed with a fresh layout. If they are different, invalidate both repaint rects.

12:11 PM Changeset in webkit [17088] by thatcher

1 copy in tags/WebKit-312.8.1/WebKit

Tag for WebKit 312.8.1 (part 2 of 2.)

12:11 PM Changeset in webkit [17087] by thatcher

1 add in tags/WebKit-312.8.1

Tag for WebKit 312.8.1 (part 1 of 2.)

12:11 PM Changeset in webkit [17086] by thatcher

2 edits in branches/Safari-1-3-branch/WebKit

Versioning to 312.8.1

12:08 PM Changeset in webkit [17085] by thatcher

3 edits in branches/Safari-1-3-branch/WebKit

Merged fix from Safari-2-0-branch to Safari-1-3-branch

2006-09-07 Beth Dakin <Beth Dakin>

Reviewed by Darin sort of and Maciej definitely.

Fix for <rdar://problem/4719149> Crash caused by malformed frame
setup. This is the same bug as 3853672, which has been fixed on TOT
for a while. We feel like this fix is much safer for the branch
though.

WebKit.xcodeproj/project.pbxproj: Version wars.
WebView.subproj/WebBaseResourceHandleDelegate.m: (-[NSURLProtocol releaseResources]): Added comment for assertion that will be hit. (-[NSURLProtocol didFailWithError:]): Added comment for assertion that will be hit.
WebView.subproj/WebDataSource.m: (-[WebDataSource _receivedMainResourceError:complete:]): Retain and release all of the pieces involved with sending the error.

12:06 PM Changeset in webkit [17084] by aliceli1

4 edits in trunk/LayoutTests

Reviewed by Tim Hatcher.

When nodes are removed, selections are cleared, and when http://bugs.webkit.org/show_bug.cgi?id=6498 was fixed, we started sending didChangeSelection notifications. Updating the test results fixes some of the tests mentioned in http://bugs.webkit.org/show_bug.cgi?id=10924

fast/dynamic/move-node-with-selection-expected.txt:
fast/events/dblclick-addEventListener-expected.txt:
fast/events/updateLayoutForHitTest-expected.txt:

11:58 AM Changeset in webkit [22373] by aroben

2 edits in branches/WindowsMerge/WebCore

Reviewed by Geoff.

A couple of cleanups that Geoff suggested after my last checkin.

platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::setPositionAndSize):

11:47 AM Changeset in webkit [22372] by aroben

2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

Fix: <rdar://problem/4772506> <select> popup menu should not clip items
when width: is set.

Popups are now sized and positioned as follows:

Popups are at least as wide as the <select> control on the page.
Popups for LTR <select>s are right-aligned with the <select>, popups for RTL <select>s are left-aligned. This means the scrollbar in the popup will always line up with the dropdown button in the <select>.
Popups try to be wide enough to fit their widest item, but will shrink to ensure they don't extend off the screen.

platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::setPositionAndSize):

11:07 AM Changeset in webkit [17083] by harrison

2 edits in trunk/WebCore

Reviewed by Adele.

<rdar://problem/4770453> VO not honoring secure edit fields in web pages

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject isPasswordField]): New. Checks for input with inputType() of PASSWORD.

(-[WebCoreAXObject subrole]):
Returns NSAccessibilitySecureTextFieldSubrole if [self isPasswordField].

(-[WebCoreAXObject roleDescription]):
Pass [self subrole] instead of nil when calling NSAccessibilityRoleDescription.

(-[WebCoreAXObject value]):
Return nil if [self isPasswordField].

(-[WebCoreAXObject accessibilityAttributeNames]):
Return generic attributes if [self isPasswordField].

(-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
Return empty array if [self isPasswordField].

9:51 AM Changeset in webkit [17082] by thatcher

1 copy in tags/WebKit-418.9.1/WebKit

Tag for WebKit 418.9.1 (part 2 of 2.)

9:50 AM Changeset in webkit [17081] by thatcher

1 add in tags/WebKit-418.9.1

Tag for WebKit 418.9.1 (part 1 of 2.)

9:49 AM Changeset in webkit [17080] by aliceli1

3 edits in trunk/LayoutTests

Reviewed by aroben.

updating test results after r17068 - http://bugs.webkit.org/show_bug.cgi?id=11320

fast/block/float/013-expected.checksum:
fast/block/float/013-expected.txt:

9:42 AM Changeset in webkit [17079] by thatcher

2 edits in branches/Safari-2-0-branch/WebKit

Versioning to 418.9.1

9:36 AM Changeset in webkit [17078] by aroben

3 edits in trunk/LayoutTests

Reviewed by Adele.

Fixes http://bugs.webkit.org/show_bug.cgi?id=11214
http/tests/xmlhttprequest/exceptions.html needs new results

Updating results after r16794.

http/tests/xmlhttprequest/exceptions-expected.txt:
http/tests/xmlhttprequest/exceptions.html: Add comments about why we don't follow the XHR spec.

7:59 AM Changeset in webkit [17077] by brmorris

2 edits in S60/trunk/S60Internals

2006-10-13 brmorris <thisisbradley@gmail.com>

Reviewed by me.
DESC: Updated RVCT supporting libs.
http://bugs.webkit.org/show_bug.cgi?id=9435

target/RVCT/S60LibsRVCT.zip: Toolbar.dll & recentstore.dll

1:52 AM Changeset in webkit [17076] by hyatt

2 edits in trunk/WebCore

Fix "flash to white' problem on yahoo.com as it finishes loading. Refine the FOUC suppression
code so that it will only run if the body still has no renderer.

dom/Document.cpp: (WebCore::Document::updateLayoutIgnorePendingStylesheets):

12:32 AM Changeset in webkit [17075] by hyatt

15 edits in trunk/WebCore

Fix a bug where the WebCore memory cache could grow without bound during extended browsing
sessions.

Reviewed by mjs

loader/Cache.cpp: (WebCore::Cache::flush): (WebCore::Cache::setSize): (WebCore::Cache::getLRUListFor): (WebCore::Cache::removeFromLRUList): (WebCore::Cache::insertInLRUList):
loader/Cache.h:
loader/CachedCSSStyleSheet.cpp:
loader/CachedCSSStyleSheet.h:
loader/CachedImage.cpp:
loader/CachedImage.h:
loader/CachedResource.cpp: (WebCore::CachedResource::setRequest): (WebCore::CachedResource::deref):
loader/CachedResource.h: (WebCore::CachedResource::allowInLRUList):
loader/CachedScript.cpp:
loader/CachedScript.h:
loader/CachedXBLDocument.cpp:
loader/CachedXBLDocument.h:
loader/CachedXSLStyleSheet.cpp:
loader/CachedXSLStyleSheet.h:

Oct 16, 2006:

5:51 PM Changeset in webkit [22371] by aroben

2 edits in branches/WindowsMerge/WebCore

Reviewed by Kevin.

Fix: <rdar://problem/4758923> <select> menu text doesn't draw right
aligned on right-to-left sites

platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::show): Pass appropriate styles to CreateWindowEx so that we get a left-aligned scrollbar in RTL popups. (WebCore::PopupMenu::drawItem): Set text to be right-aligned and draw RTL when direction:rtl is set. (WebCore::PopupWndProc): Add 1px of vertical height to each menu item to match RenderListBox.
rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintMenuList): Draw the dropdown button on the left when in RTL. (WebCore::RenderThemeWin::adjustMenuListStyle): Set padding to allow for the dropdown button being on the left in RTL.

5:48 PM Changeset in webkit [17074] by justing

8 edits
8 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/3655385>
Editing: -indent: method unimplemented

editing/execCommand/nsresponder-indent-expected.checksum: Added.
editing/execCommand/nsresponder-indent-expected.png: Added.
editing/execCommand/nsresponder-indent-expected.txt: Added.
editing/execCommand/nsresponder-indent.html: Added.
editing/execCommand/nsresponder-outdent-expected.checksum: Added.
editing/execCommand/nsresponder-outdent-expected.png: Added.
editing/execCommand/nsresponder-outdent-expected.txt: Added.
editing/execCommand/nsresponder-outdent.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/3655385>
Editing: -indent: method unimplemented

Added Frame and bridge methods.

bridge/mac/WebCoreFrameBridge.h:
bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge indent]): (-[WebCoreFrameBridge outdent]):
page/Frame.cpp: (WebCore::Frame::indent): (WebCore::Frame::outdent):
page/Frame.h:

WebKit:

Reviewed by harrison

<rdar://problem/3655385>
Editing: -indent: method unimplemented

WebView/WebHTMLView.m: (-[NSArray validateUserInterfaceItem:]): Only allow indent:/outdent: in richly editable areas. (-[NSArray indent:]): (-[NSArray outdent:]):

5:35 PM Changeset in webkit [17073] by kmccullo

2 edits in trunk/JavaScriptCore

Reviewed by Geof.

Removed unecessary global specifiers.

kjs/math_object.cpp: (MathFuncImp::callAsFunction):

5:10 PM Changeset in webkit [22370] by lamadio

2 edits in branches/WindowsMerge/WebKitWin

4:12 PM Changeset in webkit [17072] by kmccullo

2 edits in trunk/JavaScriptCore

Reviewed by John.

Fixes a compile order issue for testkjs on win.

JavaScriptCore.vcproj/testkjs/testkjs.vcproj:

2:57 PM Changeset in webkit [22369] by aroben

1 edit in branches/WindowsMerge/WebCore/ChangeLog

Added forgotten <rdar://problem/4710456> reference to old entry.

2:54 PM Changeset in webkit [22368] by aroben

2 edits in branches/WindowsMerge/WebCore

Reviewed by John.

Forgot to save these changes John suggested before checking in.

platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::drawItem):

2:52 PM Changeset in webkit [22367] by aroben

3 edits in branches/WindowsMerge/WebCore

Reviewed by John.

Fix: <rdar://problem/4709480> Implement option groups
Fix: <rdar://problem/4785693> Use CG to draw popup menu items
Fix: <rdar://problem/4709487> Implement separators in <select> popups
Fix: <rdar://problem/4709358> Move CreateWindowEx calls out of PopupMenu constructor

platform/win/PopupMenuWin.cpp: Added some now-required #includes, moved some constants into the WebCore namespace. (WebCore::PopupMenu::PopupMenu): Moved CreateWindowEx calls into PopupMenu::show(). (WebCore::PopupMenu::show): Pass LBS_OWNERDRAWFIXED to CreateWindowEx to assume responsibility for drawing menu itesm. Removed call to set the font on the popup menu, as CG will take care of this. (WebCore::addString): Added to help with the PopupMenu::add* methods. (WebCore::PopupMenu::addOption): Use addString. (WebCore::PopupMenu::addGroupLabel): Ditto, and moved from TemporaryLinkStubs.cpp. (WebCore::PopupMenu::addSeparator): Ditto. (WebCore::PopupMenu::down): Skip items that are not enabled <option> elements, and tell the popup menu to set the selection to the element we end up on. (WebCore::PopupMenu::up): Ditto. (WebCore::PopupMenu::drawItem): Added. This is the method that is called to draw each item in the menu. (WebCore::PopupWndProc): Add cases for WM_MEASUREITEM and WM_DRAWITEM messages (required now that we're drawing the menu items ourselves). In the cases for arrow key presses, return -2 to signify that we're handling all aspects of changing the selection.
platform/win/TemporaryLinkStubs.cpp: Removed PopupMenu::addSeparator and PopupMenu::addGroupLabel.

2:44 PM Changeset in webkit [17071] by aroben

4 edits in trunk/WebCore

Reviewed by John.

More menulist cleanup/tweaking.

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Renamed 'index' parameter to 'optionIndex' for clarity. (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Skip over items that are not enabled <option> elements when using arrow keys, and make sure we pass an option index to setSelectedIndex.
platform/PopupMenu.h: (WebCore::PopupMenu::setWasClicked): Specify default argument.
rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setTextFromOption): Strip whitespace from option text before setting the control text so that options within <optgroup>s don't appear indented in the actual control.

1:52 PM Changeset in webkit [17070] by weinig

9 edits in trunk/WebCore

Reviewed by Adam.

Win32 build fix.

WebCore.vcproj/WebCore/WebCore.vcproj:
bridge/win/BrowserExtensionWin.cpp: (WebCore::BrowserExtensionWin::createNewWindow):
bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::submitForm): (WebCore::FrameWin::createNewWindow):
bridge/win/FrameWin.h:
loader/loader.cpp: (WebCore::Loader::receivedResponse):
platform/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::getWindowsContext): (WebCore::GraphicsContext::releaseWindowsContext):
platform/win/TemporaryLinkStubs.cpp: (FrameWin::openURLRequest): (WebCore::ServeSynchronousRequest): (WebCore::CheckIfReloading): (WebCore::IsResponseURLEqualToURL): (WebCore::ResponseMIMEType): (WebCore::ResponseIsMultipart): (WebCore::CacheObjectExpiresTime): (CachedResource::setResponse): (CachedResource::setAllData):
rendering/RenderThemeWin.cpp: (WebCore::doneDrawing): (WebCore::RenderThemeWin::paintButton): (WebCore::RenderThemeWin::paintTextField):

11:17 AM Changeset in webkit [17069] by brmorris

2 edits in S60/trunk/WebCore

2006-10-16 brmorris <thisisbradley@gmail.com>

Reviewed by Zalan.
DESC: Fix build break in render_frames.cpp caused by r17066

kwq/KWQWidget.h: (QWidget::focusable): Is available when not RD_32_BROWSER

1:29 AM Changeset in webkit [17068] by hyatt

4 edits in trunk/WebCore

Fix for bug 9347, positioned elements have the wrong containing block. This is a change from CSS2 to
CSS2.1. In the absence of any other enclosing positioned elements, the containing block for a positioned
element is the initial containing block (our RenderView).

Reviewed by mjs

Test cases added to fast/block/positioning for quirks and strict modes.

rendering/RenderBlock.cpp: (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition):
rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockHeightForPositioned): (WebCore::RenderBox::calcAbsoluteVertical):
rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::container):

1:27 AM Changeset in webkit [17067] by hyatt

8 adds in trunk/LayoutTests/fast/block/positioning

Add test cases for bug 9347.

Oct 15, 2006:

7:00 PM Changeset in webkit [17066] by zbujtas

7 edits in S60/trunk/WebCore

2006-10-13 sareen <shyam.sareen@nokia.com>

Reviewed by bujtas <zbujtas@gmail.com>
DESC: New Enum need to add for finding the whether the plugin

is interactive or not.

http://bugs.webkit.org/show_bug.cgi?id=11281

WARNING: NO TEST CASES ADDED OR CHANGED

bridge/WebCoreWidget.h:
khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::isFocusable): (HTMLObjectElementImpl::isFocusable):
khtml/rendering/render_frames.cpp:
khtml/rendering/render_frames.h:
kwq/KWQObjectWidget.cpp:
kwq/KWQObjectWidget.h:

6:33 PM Changeset in webkit [17065] by bdash

16 edits in trunk

2006-10-15 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by Anders.

Remove junk (as gcc calls it) after #else clause.

wtf/FastMalloc.cpp: (WTF::do_free):

2006-10-15 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by Anders.

Misc Gdk/Linux build fixes.

platform/gdk/BrowserExtensionGdk.h:
platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected):
platform/gdk/FrameGdk.h:
platform/gdk/RenderPopupMenuGdk.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::addSeparator): (WebCore::PopupMenu::addGroupLabel): (WebCore::PopupMenu::addOption):
platform/gdk/RenderPopupMenuGdk.h:
platform/gdk/RenderThemeGdk.cpp:
platform/gdk/RenderThemeGdk.h: (WebCore::RenderThemeGdk::RenderThemeGdk):
platform/gdk/TemporaryLinkStubs.cpp: (BrowserExtensionGdk::createNewWindow): (BrowserExtensionGdk::BrowserExtensionGdk): (BrowserExtensionGdk::setTypedIconURL): (BrowserExtensionGdk::setIconURL): (BrowserExtensionGdk::getHistoryLength): (WebCore::CheckIfReloading): (WebCore::CacheObjectExpiresTime): (WebCore::ResponseURL): (WebCore::IsResponseURLEqualToURL): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData): (FileChooser::disconnectUploadControl):
rendering/RenderTheme.h:
rendering/RenderThemeMac.h:

2006-10-15 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by Anders.

Make compiler not complain about unused gk. SpinneretWebHost was not setting
initial refcount upon creation, so it is completely bogus.

GdkLauncher/main.cpp: (main):
Spinneret/Spinneret/Spinneret.h: (SpinneretWebHost::SpinneretWebHost):

3:22 PM Changeset in webkit [17064] by weinig

7 edits in trunk/WebCore

Reviewed by Mitz.

Fix for http://bugs.webkit.org/show_bug.cgi?id=11294
Add getModifierState method to KeyboardEvent

bindings/objc/DOMEvents.h:
bindings/objc/DOMEvents.mm:
bindings/objc/PublicDOMInterfaces.h:
dom/KeyboardEvent.cpp: (WebCore::KeyboardEvent::getModifierState):
dom/KeyboardEvent.h:
dom/KeyboardEvent.idl:

2:44 PM Changeset in webkit [22366] by aroben

2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Geoff, Anders.

Fix crash on startup.

We were crashing somewhere inside Frame::setResourceRequest. I'm not
sure what change made this start crashing.

WebFrame.cpp: (WebFrame::receivedResponse): Remove useless calls to Frame::resourceRequest and Frame::setResourceRequest.

1:52 PM Changeset in webkit [22365] by aroben

2 edits in branches/WindowsMerge/WebCore

Build fix.

Merge OpenSource r17056 to TemporaryLinkStubs.cpp.

platform/win/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::IsResponseURLEqualToURL): (WebCore::ResponseURL): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):

12:20 PM Changeset in webkit [17063] by ap

14 edits
1 add in trunk/WebCore

2006-10-15 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed and landed by ap.

Changed PlatformResponse handling for Qt. Don't just store
a QString object containing the data but a new PlatformResponseQt struct
containing data and url, and store it as pointer. This is compatible
to the OS X handling and removes the Qt plaform specific hacks from
CachedCSSStyleSheet, CachedResource & loader.

Add new file LoaderFunctionsQt, similar to LoaderFunctionsMac, and move
all methods from TemporaryLinkStubs related to loading in there, and implement
some like ServeSynchronousRequest (yay for xslt handling!).

CMakeLists.txt:
loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
loader/CachedResource.h: (WebCore::CachedResource::CachedResource):
loader/loader.cpp: (WebCore::Loader::receivedResponse):
platform/ResourceLoaderClient.h:
platform/ResourceLoaderInternal.h:
platform/qt/FrameQt.cpp: (WebCore::FrameQt::~FrameQt): (WebCore::FrameQt::createEmptyDocument):
platform/qt/FrameQt.h: (WebCore::QtFrame):
platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::setFrame): (WebCore::FrameQtClientDefault::openURL): (WebCore::FrameQtClientDefault::loadFinished): (WebCore::FrameQtClientDefault::receivedAllData):
platform/qt/FrameQtClient.h:
platform/qt/LoaderFunctionsQt.cpp: Added. (WebCore::ServeSynchronousRequest): (WebCore::NumberOfPendingOrLoadingRequests): (WebCore::CheckIfReloading): (WebCore::CheckCacheObjectStatus): (WebCore::IsResponseURLEqualToURL): (WebCore::ResponseURL): (WebCore::ResponseMIMEType): (WebCore::ResponseIsMultipart): (WebCore::CacheObjectExpiresTime): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
platform/qt/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::remove):
platform/qt/ResourceLoaderQt.cpp: (WebCore::ResourceLoader::~ResourceLoader): (WebCore::ResourceLoader::start): (WebCore::ResourceLoader::assembleResponseHeaders): (WebCore::ResourceLoader::receivedResponse):
platform/qt/TemporaryLinkStubs.cpp:

3:00 AM Changeset in webkit [17062] by rwlbuis

31 edits in trunk/WebCore

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg basic datastructure classes.

Oct 14, 2006:

5:31 PM Changeset in webkit [17061] by oliver

10 edits in trunk/WebCore

2006-10-15 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Oliver.

Implement some functions in FrameQt / ScrollViewQt.

Added comments what needs to be done in quite some places,
marked some functions as no-ops.

CMakeLists.txt:
platform/qt/FrameQt.cpp: (WebCore::FrameQt::FrameQt): (WebCore::FrameQt::runJavaScriptConfirm): (WebCore::FrameQt::locationbarVisible): (WebCore::FrameQt::createFrame): (WebCore::FrameQt::passSubframeEventToSubframe): (WebCore::FrameQt::menubarVisible): (WebCore::FrameQt::personalbarVisible): (WebCore::FrameQt::statusbarVisible): (WebCore::FrameQt::toolbarVisible): (WebCore::FrameQt::markedTextRange): (WebCore::FrameQt::lastEventIsMouseUp): (WebCore::FrameQt::openURLRequest): (WebCore::FrameQt::scheduleClose): (WebCore::FrameQt::unfocusWindow): (WebCore::FrameQt::focusWindow): (WebCore::FrameQt::overrideMediaType): (WebCore::FrameQt::runJavaScriptPrompt): (WebCore::FrameQt::bindingRootObject): (WebCore::FrameQt::addPluginRootObject): (WebCore::FrameQt::registerCommandForUndo): (WebCore::FrameQt::registerCommandForRedo): (WebCore::FrameQt::clearUndoRedoOperations): (WebCore::FrameQt::respondToChangedSelection): (WebCore::FrameQt::respondToChangedContents): (WebCore::FrameQt::shouldChangeSelection): (WebCore::FrameQt::canGoBackOrForward): (WebCore::FrameQt::canPaste): (WebCore::FrameQt::canRedo): (WebCore::FrameQt::canUndo):
platform/qt/FrameQt.h:
platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::runJavaScriptAlert): (WebCore::FrameQtClientDefault::runJavaScriptConfirm): (WebCore::FrameQtClientDefault::runJavaScriptPrompt): (WebCore::FrameQtClientDefault::menubarVisible): (WebCore::FrameQtClientDefault::toolbarVisible): (WebCore::FrameQtClientDefault::statusbarVisible): (WebCore::FrameQtClientDefault::personalbarVisible): (WebCore::FrameQtClientDefault::locationbarVisible):
platform/qt/FrameQtClient.h:
platform/qt/ImageSourceQt.cpp:
platform/qt/RenderThemeQt.cpp:
platform/qt/ScrollViewQt.cpp: (WebCore::ScrollView::scrollPointRecursively):
platform/qt/TemporaryLinkStubs.cpp: (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):

5:04 PM Changeset in webkit [17060] by oliver

2 edits in trunk/WebKitTools

2006-10-15 Nikolas Zimmermann <zimmermann@kde.org>

Reviewed by Oliver.

Add another hanging test, to the "to be skipped" list.

DumpRenderTree/DumpRenderTree.qtproj/tests-skipped.txt:

10:38 AM Changeset in webkit [17059] by harrison

2 edits in trunk/WebCore

Reviewed by Geoff.

<rdar://problem/4775213> REGRESSION: Can't from tab from last link on the page to URL address field
<rdar://problem/4783926> REGRESSION: Typing tab key enters no text

The problem is that EventTargetNode::defaultEventHandler() calls event->setDefaultHandled() regardless
of whether frame->view()->advanceFocus() actually changed the focus.

Trivial fix is to preventDefault() only if advanceFocus() returns true.

No test is possible because DumpRenderTree sets the WebView preference to tab to links, and that preference cannot be changed dynamically after the webview is initialized. Also, the "tab from last link" is not testable because DumpRenderTree uses the WebView for the whole window, so tabs can't shift focus out of the WebView regardless.

dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler):

10:21 AM Changeset in webkit [17058] by weinig

3 edits in trunk/WebKitTools

Reviewed by Anders.

Some fixes to get the Qt BuildSlave to run the LayoutTests.

Scripts/build-dumprendertree: No need to call cmake again.
Scripts/run-webkit-tests: Expose LD_LIBRARY_PATH.

5:53 AM Changeset in webkit [17057] by weinig

10 edits in trunk/WebCore

Reviewed by Mitz.

Fix Qt/Linux build & some little fixes:

Adapt to Maciej's FrameLoadRequest changes.
Fix response handling - don't try to compare with '0' - for us it's a non-ptr QString object.
Actually call setAllData from loader/loader.cpp (David Carson forgot that in his last commit)
Fix CacheObjectExpiresTime/ResponseIsMultipart signature.

loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
loader/CachedResource.h: (WebCore::CachedResource::CachedResource):
loader/loader.cpp: (WebCore::Loader::receivedAllData): (WebCore::Loader::receivedResponse):
platform/qt/BrowserExtensionQt.cpp: (WebCore::BrowserExtensionQt::createNewWindow):
platform/qt/BrowserExtensionQt.h:
platform/qt/FrameQt.cpp: (WebCore::FrameQt::submitForm): (WebCore::FrameQt::urlSelected): (WebCore::FrameQt::openURLRequest):
platform/qt/FrameQt.h:
platform/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setURLForRect):
platform/qt/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::ResponseIsMultipart): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):

2:42 AM Changeset in webkit [17056] by bdash

10 edits in trunk/WebCore

2006-10-14 David Carson <dacarson@gmail.com>

Reviewed by Maciej.

Fix: http://bugs.webkit.org/show_bug.cgi?id=11257
Removed Mac platform dependance, changed WebCore functions to
use PlatformResponse/PlatformData rather than NSURLResponse/
NSData.

loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::checkNotify):
loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
loader/CachedResource.cpp: (WebCore::CachedResource::~CachedResource):
loader/CachedResource.h: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::response): (WebCore::CachedResource::allData):
loader/LoaderFunctions.h:
loader/loader.cpp: (WebCore::Loader::receivedResponse):
loader/mac/LoaderFunctionsMac.mm: (WebCore::ResponseMIMEType): (WebCore::ResponseIsMultipart): (WebCore::CacheObjectExpiresTime): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
platform/qt/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):
platform/win/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::CachedResource::setResponse): (WebCore::CachedResource::setAllData):

2:39 AM Changeset in webkit [17055] by bdash

7 edits in trunk

2006-10-14 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by Maciej.

Define KXMLCORE_USE_CURL for platforms that wish to use CURL as
networking, and set it for GDK build

wtf/Platform.h:

2006-10-14 Krzysztof Kowalczyk <kkowalczyk@gmail.com>

Reviewed by Maciej.

Fix GDK build by defining FrameGdkClient() constructor as non-virtual.
Pure virtual classes require non-pure destructor, who knew.

Make CURL networking dependent on USE(CURL) instead of PLATFORM(GDK),
so that other platforms can also use CURL, if they wish.

Silence compiler warning about unused variable in SharedTimerLinux.cpp

platform/ResourceLoaderInternal.h: (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
platform/gdk/FrameGdk.h: (WebCore::FrameGdkClient::~FrameGdkClient):
platform/gdk/ResourceLoaderManager.cpp: (WebCore::ResourceLoaderManager::downloadTimerCallback):
platform/gdk/SharedTimerLinux.cpp: (WebCore::stopSharedTimer):

Oct 13, 2006:

7:44 PM Changeset in webkit [17054] by bdakin

3 edits in trunk/WebCore

Reviewed by Geoff.

Build fix from my last check-in. Make hasOutlineAnnotation() non-
inline so that we don't have to include Document.h in
RenderObject.h
Doing so causes a build failure in WebKit, and it probably isn't a
good idea anyway.

rendering/RenderObject.cpp: (WebCore::RenderObject::hasOutlineAnnotation):
rendering/RenderObject.h: (WebCore::RenderObject::hasOutline):

6:37 PM Changeset in webkit [17053] by ggaren

3 edits
2 adds in trunk/WebKitSite

Reviewed by Beth.

Split build, run, and debug steps into separate pages. Darin recommended
this a while back.

building/build.html:
building/checkout.html:
building/debug.html: Added.
building/run.html: Added.
nav.inc:

6:12 PM Changeset in webkit [17052] by bdakin

12 edits in trunk/WebCore

Patch written mostly by Ken Kraisler, but also by me.

Reviewed by Hyatt.

Fix for http://bugs.webkit.org/show_bug.cgi?id=10216 and <rdar://
problem/3391162> PDF created by printing should have live
hyperlinks

platform/GraphicsContext.cpp: (WebCore::GraphicsContext::focusRingBoundingRect):
platform/GraphicsContext.h:
platform/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setURLForRect):
platform/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setURLForRect): Implement method to add URL link to PDF document.
rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paint): Ask hasOutline() instead of querying the outline width
rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject): Same as above.
rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintLines): Call the new paintOutline() (WebCore::RenderFlow::paintOutline): Take care of focus ring and pdf url rects, and outline painting.
rendering/RenderFlow.h:
rendering/RenderObject.cpp: (WebCore::RenderObject::addPDFURLRect): Declaration to apply a PDF link to a rectanglular region. (WebCore::RenderObject::paintOutline): Take care of pdf rects as well as focus ring painting.
rendering/RenderObject.h: (WebCore::RenderObject::hasOutlineAnnotation): Returns true is the element is a link and we are printing. (WebCore::RenderObject::hasOutline): Returns true is the style has an outline and hasOutlineAnnotation() is true.
rendering/RenderStyle.h: (WebCore::RenderStyle::hasOutline): Returns true if outlineWidth is greater than 0 and outlineStyle is greater than BHIDDEN.

4:58 PM Changeset in webkit [17051] by justing

3 edits
2 adds in trunk

LayoutTests:

Reviewed by ggaren and harrison

<rdar://problem/4744008>
9A270: Mail crashes when I try to paste large items from Safari

editing/pasteboard/4744008-expected.txt: Added.
editing/pasteboard/4744008.html: Added.

WebCore:

Reviewed by ggaren and harrison

<rdar://problem/4744008>
9A270: Mail crashes when I try to paste large items from Safari

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Even though we put nodes in the hash map in pre-order, they don't necessary come out of the iterator that way. If a node is a redundant style span and one of its pruned ancestors comes off the hash map after it, and that ancestor is a redundant style span or font tag, we will try to remove it even though it has already been removed and we'll crash. The test case added with the fix depends on our hash map implementation because it requires that a particular redundant style span come out of the iterator before its parent. So, it may eventually not provide coverage for the fix.

4:56 PM Changeset in webkit [22364] by mjs

5 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

split FrameLoadRequest off from ResourceRequest - it's a ResourceRequest plus frame name plus lockHistory bool

WebCore.vcproj/WebCore.vcproj:
bridge/win/FrameWin.cpp: (WebCore::FrameWin::urlSelected): (WebCore::FrameWin::submitForm):
bridge/win/FrameWin.h:
platform/win/TemporaryLinkStubs.cpp: (BrowserExtensionWin::createNewWindow): (IconLoader::notifyIconChanged):

4:54 PM Changeset in webkit [17050] by mjs

12 edits
1 add in trunk/WebCore

Reviewed by Darin.

split FrameLoadRequest off from ResourceRequest - it's a ResourceRequest plus frame name plus lockHistory bool

WebCore.xcodeproj/project.pbxproj:
bindings/js/kjs_window.cpp: (KJS::createNewWindow): (KJS::WindowFunc::callAsFunction):
bridge/BrowserExtension.h:
bridge/mac/BrowserExtensionMac.h:
bridge/mac/BrowserExtensionMac.mm: (WebCore::BrowserExtensionMac::createNewWindow):
bridge/mac/FrameMac.h:
bridge/mac/FrameMac.mm: (WebCore::FrameMac::submitForm): (WebCore::FrameMac::openURLRequest): (WebCore::FrameMac::urlSelected):
bridge/win/BrowserExtensionWin.h:
page/Frame.cpp: (WebCore::Frame::changeLocation): (WebCore::Frame::urlSelected): (WebCore::Frame::requestFrame): (WebCore::Frame::submitForm):
page/Frame.h:
page/FrameLoadRequest.h: Added. (WebCore::FrameLoadRequest::FrameLoadRequest): (WebCore::FrameLoadRequest::lockHistory): (WebCore::FrameLoadRequest::setLockHistory):
page/ResourceRequest.h: (WebCore::ResourceRequest::ResourceRequest):

4:50 PM Changeset in webkit [17049] by sullivan

2 edits in trunk/WebCore

Reviewed by Maciej

loader/mac/WebFrameLoader.mm: (-[WebFrameLoader loadDocumentLoader:]): Replace ASSERT(!policyDocumentLoader) with code that handles this case. This can happen when loading a page during a decidePolicyForNavigationAction callback.

4:45 PM Changeset in webkit [17048] by mjs

1 edit
1 copy in trunk/WebKit

Not reviewed, build fix.

icu/unicode/putil.h: Added - needed for build if you don't have apple internal headers.

4:16 PM Changeset in webkit [17047] by mjs

1 edit
1 copy in trunk/WebKit

Not reviewed, build fix.

icu/unicode/ustring.h: Added - needed for build if you don't have apple internal headers.

3:14 PM Changeset in webkit [22363] by hyatt

5 edits in branches/WindowsMerge/WebCore

Make form controls work in transparency layers.

3:12 PM Changeset in webkit [22362] by hyatt

2 edits in branches/WindowsMerge/WebKitWin

Make sure the backing store flushes properly when the theme changes.

3:09 PM Changeset in webkit [17046] by hyatt

4 edits in trunk/WebCore

Transparency layer work.

2:45 PM Changeset in webkit [17045] by spadma

2 edits in S60/trunk/WebKit

2006-10-13 zhalu <zhaosong.lu@nokia.com>

Reviewed by Sachin.
DESC: Don't need to set the focus. The listbox itself will set the focus when receiving key event.
Otherwise, it will cause problem in input. Here is a little explaination: When the form data saving is enabled,
the CControlSelectWidget::FilterContentL is called whenever a 'letter' is committed.
The function calls the the listbox's setFocus(). This setFocus triggers a CommitInlineEditL action in
CAknFepManager. If users press the key in a normal speed, there is no problem because there is nothing
for committing. But if users press two keys(not two letters on the same key) very quickly, the second key
will be commited by the SetFocus() of the first key and the cursor in the editbox will move to the third
key position. The result is that it seems not letting you insert some key in the second position.

http://bugs.webkit.org/show_bug.cgi?id=11192

BrowserCore/Formcontrols/src/FControlSelectWidget.cpp: (CControlSelectWidget::FilterContentL):

2:42 PM Changeset in webkit [17044] by mjs

3 edits in trunk/WebKit

Reviewed by Anders.

add a bunch of casts to get this compiling with older Xcode versions

(I used static_cast so it will be easier to find and remove these once we have completely moved
on to a new enough compiler version.)

Plugins/WebBaseNetscapePluginView.m: (+[WebBaseNetscapePluginView getCarbonEvent:]): (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]): (-[WebBaseNetscapePluginView fixWindowPort]): (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView _createWindowlessAGLContext]): (-[WebBaseNetscapePluginView _reshapeAGLWindow]): (-[WebBaseNetscapePluginView _aglOffscreenImageForDrawingInRect:]):
WebKit.xcodeproj/project.pbxproj:

2:35 PM Changeset in webkit [17043] by brmorris

2 edits
1 move in S60/trunk/S60WebUi

2006-10-13 brmorris <thisisbradley@gmail.com>

Reviewed by Zalan.
DESC: Updates to reindeer sisx installation.
http://bugs.webkit.org/show_bug.cgi?id=9435

WebUi/install/Reindeer.pkg: Added.
WebUi/install/WebUi.pkg: Removed.
WebUi/install/buildsis.bat:

2:18 PM Changeset in webkit [17042] by spadma

7 edits in S60/trunk/WebKit

2006-10-13 sareen <shyam.sareen@nokia.com>

Reviewed by (Sachin.padma@nokia.com).
DESC: New Enum need to add for finding the whether the plugin

is interactive or not.

http://bugs.webkit.org/show_bug.cgi?id=11281.

Plugin/inc/PluginAdapterInterface.h: (MPluginAdapter::SetOptionMenuHandler):
Plugin/inc/PluginSkin.h:
Plugin/inc/PluginWin.h:
Plugin/inc/npapi.h:
Plugin/src/PluginSkin.cpp:
Plugin/src/PluginWin.cpp: (CPluginWin::ConstructL): (CPluginWin::IsContentInteractive):

2:04 PM Changeset in webkit [17041] by rwlbuis

11 edits in trunk/WebCore

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg paint server classes.

1:22 PM Changeset in webkit [17040] by ggaren

10 edits
4 adds in trunk

LayoutTests:

Tests for accessing renderer-dependent properties from a javascript: URL.

fast/frames/frame-js-url-clientWidth-expected.txt: Added.
fast/frames/frame-js-url-clientWidth.html: Added.
fast/frames/iframe-js-url-clientWidth-expected.txt: Added.
fast/frames/iframe-js-url-clientWidth.html: Added.

WebCore:

Reviewed by Darin, John.

Merged more frame and iframe code
Fixed a bug where iframes returned incorrect values for renderer-dependent properties during javascript: loads because they didn't have renderers at load time

PLT insists this is a small performance win. Don't believe its lies.

bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::frameGetter): Renamed frameWidth and frameHeight to width and height, for consistency with the rest of the DOM.
dom/ContainerNode.cpp: (WebCore::ContainerNode::queuePostAttachCallback): Added a post-attach callback queue that gets drained after the render tree is fully constructed. Currently, this is only used for frame loading. (WebCore::ContainerNode::attach):
dom/ContainerNode.h:
html/HTMLFrameElement.cpp: (WebCore::HTMLFrameElement::insertedIntoDocument): Removed frame loading from attach() because loading iframes during attach() causes a crash. Moved frame loading logic into insertedIntoDocument(). That's a more logical place for it because document insertion is what triggers frame loading. Made frame loading a post-attach callback, instead of an immediate action, to fix the incorrect values bug. (WebCore::HTMLFrameElement::attach): Added setWidget call that used to be in HTMLIFrameElement::attach. IFRAME requires this call. FRAME will soon require this call, once I remove the call from WebKit. (WebCore::HTMLFrameElement::setLocation): (WebCore::HTMLFrameElement::width): (WebCore::HTMLFrameElement::height):
html/HTMLFrameElement.h: Made openURL non-virtual to avoid the unnecessary killing of puppies.
html/HTMLIFrameElement.cpp: Merged code into HTMLFrameElement (WebCore::HTMLIFrameElement::rendererIsNeeded): (WebCore::HTMLIFrameElement::createRenderer): (WebCore::HTMLIFrameElement::insertedIntoDocument): (WebCore::HTMLIFrameElement::removedFromDocument): (WebCore::HTMLIFrameElement::attach):
page/FrameView.h: Removed unused method.

12:21 PM Changeset in webkit [17039] by rwlbuis

2 edits in trunk/WebKitTools

Reviewed by Eric.

Force --no-http on Qt/Linux.

12:10 PM Changeset in webkit [17038] by rwlbuis

1 add
2 deletes in trunk/WebCore/platform/qt

Add PopupMenuQt.cpp, remove RenderPopupMenuQt.*, as per WildFox' request.

11:56 AM Changeset in webkit [17037] by kmccullo

4 edits in trunk/JavaScriptCore

Reviewed by Kevin McCullough.

Fixes http://bugs.webkit.org/show_bug.cgi?id=11283
Fixes Qt/Linux and Windows build

kjs/DateMath.cpp:
kjs/DateMath.h:
kjs/date_object.cpp: (KJS::DateProtoFunc::callAsFunction):

11:17 AM Changeset in webkit [17036] by harrison

12 edits
4 adds in trunk

LayoutTests:

Reviewed by Justin.

<rdar://problem/4746860> Mail crash in WebCore::CSSMutableStyleDeclaration::merge(WebCore::CSSMutableStyleDeclaration*, bool)

editing/style/style-boundary-005.html: Added. Matches steps from bug.
editing/execCommand/hilitecolor-expected.txt: Updated (no empty Apple style spans).
editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Updated (no empty Apple style spans).
editing/style/remove-underline-in-bold-expected.txt: Updated (no empty Apple style spans).
editing/style/typing-style-003-expected.txt: Updated (no empty Apple style spans).

WebCore:

Reviewed by Justin.

<rdar://problem/4746860> Mail crash in WebCore::CSSMutableStyleDeclaration::merge(WebCore::CSSMutableStyleDeclaration*, bool)

Tests added or changed:

editing/style/style-boundary-005.html: Added. Matches steps from bug.
editing/execCommand/hilitecolor-expected.txt: Updated (no empty Apple style spans).
editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Updated (no empty Apple style spans).
editing/style/remove-underline-in-bold-expected.txt: Updated (no empty Apple style spans).
editing/style/typing-style-003-expected.txt: Updated (no empty Apple style spans).

dom/Text.cpp: (WebCore::Text::splitText): Comment changes.

editing/ApplyStyleCommand.cpp: (WebCore::isUnstyledStyleSpan): Renamed from isEmptyStyleSpan.

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
Rename emptySpans local to unstyledSpans.

(WebCore::dummySpanAncestorForNode):
New. To locate Apple style span created when splitting a text node.

(WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans):
Renamed from cleanUpEmptyStyleSpans. Algorithm changed to scan children
of dummy span's parents, rather than traversing up from start and
end locations. Old algorithm would miss empty spans in the bug case.

(WebCore::ApplyStyleCommand::applyInlineStyle):
Use dummySpanAncestorForNode() and cleanupUnstyledAppleStyleSpans().

(WebCore::ApplyStyleCommand::removeCSSStyle):
Renamed isEmptyStyleSpan() to isUnstyledStyleSpan().

(WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
Comment changes.

editing/ApplyStyleCommand.h: Renamed cleanUpEmptyStyleSpans() to cleanupUnstyledAppleStyleSpans().

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Allow for Apple style span to be unstyled, because old email may have this in the DOM. Use !node->hasChildNodes() instead of !node->firstChild().

editing/SplitTextNodeCommand.cpp: (WebCore::SplitTextNodeCommand::doApply): Comment changes.

rendering/RenderTreeAsText.cpp: (WebCore::isEmptyOrUnstyledAppleStyleSpan): (WebCore::operator<<): Flag empty or unstyled AppleStyleSpa nbecause we never want to leave them in the DOM

11:14 AM Changeset in webkit [17035] by rwlbuis

1 add in trunk/WebKitTools/DumpRenderTree/DumpRenderTree.qtproj/tests-skipped.txt

Adding a file that should have gone in in r17021, as requested by WildFox.

11:08 AM Changeset in webkit [17034] by adele

6 edits in trunk/WebCore

Reviewed by Eric.

Fix Qt/Linux build after Adele's popup menu changes.

CMakeLists.txt:
platform/qt/FileChooserQt.cpp: (WebCore::FileChooser::disconnectUploadControl):
platform/qt/PopupMenuQt.cpp: Added. (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::~PopupMenu): (WebCore::PopupMenu::clear): (WebCore::PopupMenu::populate): (WebCore::PopupMenu::show): (WebCore::PopupMenu::hide): (WebCore::PopupMenu::addSeparator): (WebCore::PopupMenu::addGroupLabel): (WebCore::PopupMenu::addOption):
platform/qt/RenderPopupMenuQt.cpp: Removed.
platform/qt/RenderPopupMenuQt.h: Removed.
platform/qt/RenderThemeQt.cpp:

10:57 AM Changeset in webkit [17033] by kmccullo

3 edits in trunk/WebKitTools

Reviewed by Adam.

Gets JavaScripCore tests running on windows.

Scripts/run-javascriptcore-tests:
Scripts/webkitdirs.pm:

10:48 AM Changeset in webkit [17032] by kmccullo

3 edits in trunk/WebCore

Reviewed by Darin.

fixed build failure

WebCore.xcodeproj/project.pbxproj:
loader/mac/WebFrameLoader.mm:

10:31 AM Changeset in webkit [17031] by kmccullo

5 edits in trunk/JavaScriptCore

Reviewed by Adam, Geoff, Darin.

Fixed displaying the UTC offset and time zone string, as well as renamed the GregorianDateTime structure and clean up.

ChangeLog:
kjs/DateMath.cpp: (KJS::getUTCOffset): (KJS::getDSTOffsetSimple): (KJS::gregorianDateTimeToMS): (KJS::msToGregorianDateTime):
kjs/DateMath.h: (KJS::GregorianDateTime::GregorianDateTime): (KJS::GregorianDateTime::~GregorianDateTime): (KJS::GregorianDateTime::toTM):
kjs/date_object.cpp: (KJS::gmtoffset): (KJS::formatDate): (KJS::formatDateUTCVariant): (KJS::formatTime): (KJS::fillStructuresUsingTimeArgs): (KJS::fillStructuresUsingDateArgs): (KJS::DateInstance::getTime): (KJS::DateInstance::getUTCTime): (KJS::DateProtoFunc::callAsFunction): (KJS::DateObjectImp::construct): (KJS::DateObjectImp::callAsFunction): (KJS::DateObjectFuncImp::callAsFunction): (KJS::parseDate):
kjs/date_object.h:

10:22 AM Changeset in webkit [17030] by kmccullo

2 edits in trunk/WebKit

Changed by Darin, reviewed by me.

Plugins/WebNetscapePluginStream.m: Fixed case of import so we can compile on case-sensitive file system.

10:07 AM Changeset in webkit [17029] by darin

14 edits
1 copy
1 add in trunk

WebCore:

Reviewed by Adele.

converted WebFormState from Objective-C to C++

WebCore.exp: Added a new symbol, changed one symbol from C to C++.

WebCore.xcodeproj/project.pbxproj: Made lots of headers "private" instead of "project". Added UChar.h and FrameLoaderTypes.h.

loader/FrameLoaderTypes.h: Added. Has enums from WebFrameLoader.h.

loader/mac/WebFormState.h: Converted class to C++.
loader/mac/WebFormState.mm: Ditto.

loader/mac/WebFrameLoader.h:
loader/mac/WebFrameLoader.mm: (-[WebFrameLoader loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): (-[WebFrameLoader continueFragmentScrollAfterNavigationPolicy:formState:]): (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]): (-[WebFrameLoader invalidatePendingPolicyDecisionCallingDefaultAction:]): (-[WebFrameLoader checkNewWindowPolicyForRequest:action:frameName:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterNewWindowPolicy:]): (-[WebFrameLoader checkNavigationPolicyForRequest:documentLoader:formState:andCall:withSelector:]): (-[WebFrameLoader continueAfterNavigationPolicy:]): (-[WebFrameLoader continueLoadRequestAfterNavigationPolicy:formState:]): (-[WebFrameLoader loadDocumentLoader:withLoadType:formState:]): (-[WebFrameLoader continueLoadRequestAfterNewWindowPolicy:frameName:formState:]): (-[WebFrameLoader postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Changed Objective-C WebFormState uses to C++ WebCore::FormState.

WebKit:

Reviewed by Adele.

converted WebFormState from Objective-C to C++

ForwardingHeaders: Added an entire copy of WebCore's forwarding headers here. We should eventually come up with a more-elegant solution.

WebKit.xcodeproj/project.pbxproj: Added ForwardingHeaders to the include paths. Converted many files from Objective-C to Objective-C++. In a later check-in, I'll rename them to .mm instead of .m. Removed C-only warning options for now. In a later check-in I will add these back in a way that omits them for C++.

Plugins/WebPluginContainerCheck.m: Updated for header changes.

WebView/WebFrameInternal.h: Updated for header changes. Removed WebFrameLoaderClient category so this file can still be used by Objective-C code (not just Objective-C++).

WebView/WebFrame.m: Put WebFrameLoaderClient category in here. (-[WebFrame _loadItem:withLoadType:]): Changed to use 0 instead of nil for FormState and fixed enum code for C++ compatibility. (-[WebFrame _initWithWebFrameView:webView:bridge:]): Added call to setFrameLoaderClient: here. (-[WebFrame _updateHistoryForCommit]): Fixed enum code for C++ compatibility. (-[WebFrame _updateHistoryForReload]): Ditto.

WebCoreSupport/WebFrameBridge.m: (-[WebFrameBridge initMainFrameWithPage:frameName:view:]): Removed call to setFrameLoaderClient:. (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]): Ditto. (-[WebFrameBridge _retrieveKeyboardUIModeFromPreferences:]): Fixed enum code for C++ compatibility. (-[WebFrameBridge runModal]): Changed code to not use "namespace" as a local variable name.

WebView/WebPDFView.m: Added extern "C" so this can compile as Objective-C++.

7:36 AM Changeset in webkit [17028] by adele

5 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4768591> REGRESSION: List box selection color should just be a darker version of regular selection color

rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground):
rendering/RenderTheme.cpp: (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor): (WebCore::RenderTheme::activeListBoxSelectionForegroundColor): (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor): (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::activeListBoxSelectionBackgroundColor):

5:56 AM Changeset in webkit [17027] by rwlbuis

23 edits in trunk/WebCore

Reviewed by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=11217
Cleanup svg coding style

Cleanup coding style in svg structure classes.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed