⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 6, 2006:

11:40 PM Changeset in webkit [22484] by sfalken
  • 3 edits in branches/WindowsMerge/WebKitWin

2006-11-06 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Geoff.


Export JavaScriptCore C API via WebKit.

  • WebKit.vcproj/WebKit.def:
  • WebKit.vcproj/WebKit_debug.def:
11:15 PM Changeset in webkit [17640] by bdakin
  • 6 edits
    6 adds in trunk

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/4820814> A crash occurs at
WebCore::HitTestResult::spellingToolTip() when mousing down on
iframe at www.macsurfer.com

The bug here is that the source of the iframe is only a comment,
and we were not properly constructing the frame because it was
sort-of empty but not.

  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::childAllowed): newChild is NOT allowed if it is a comment node.
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError): if n is a comment node and there is no head, we create a head, insert in the document, and add the comment node as a child. This is what Firefox does too.
  • page/FrameView.cpp: (WebCore::FrameView::handleMousePressEvent): Safe-guard for the fix. It is possible to get a mouse event without a target node, so we null check it. (Of course, in the case of this bug, it should not have been null, but it is a good thing to check for anyway.
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::spellingToolTip): Null-check m_innerNonSharedNode.

Layout Tests:

Reviewed by Hyatt.

Test for <rdar://problem/4820814> A crash occurs at
WebCore::HitTestResult::spellingToolTip() when mousing down on
iframe at www.macsurfer.com

  • fast/frames/onlyCommentInIFrame-expected.checksum: Added.
  • fast/frames/onlyCommentInIFrame-expected.png: Added.
  • fast/frames/onlyCommentInIFrame-expected.txt: Added.
  • fast/frames/onlyCommentInIFrame.html: Added.
  • fast/frames/resources/comment.html: Added.
  • fast/frames/resources/commentX.xhtml: Added.
9:42 PM Changeset in webkit [17639] by ggaren
  • 13 edits in trunk/LayoutTests

New results. The originals were incorrect.

  • svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.png:
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.png:
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum:
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.png:
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum:
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.png:
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.txt:
9:27 PM Changeset in webkit [22483] by kmccullo
  • 4 edits in branches/WindowsMerge

WebCoreWin:

-Fix test fields accepting text.

  • WebCore.vcproj/WebCore.vcproj:

WebKitWin:

-Fix test fields accepting text.

  • WebKit.vcproj/WebKit.vcproj:
7:32 PM Changeset in webkit [17638] by justing
  • 5 edits
    8 adds in trunk

LayoutTests:

Reviewed by harrison

  • editing/execCommand/4641880-1-expected.checksum: Added.
  • editing/execCommand/4641880-1-expected.png: Added.
  • editing/execCommand/4641880-1-expected.txt: Added.
  • editing/execCommand/4641880-1.html: Added.
  • editing/execCommand/4641880-2-expected.checksum: Added.
  • editing/execCommand/4641880-2-expected.png: Added.
  • editing/execCommand/4641880-2-expected.txt: Added.
  • editing/execCommand/4641880-2.html: Added.

WebCore:

Reviewed by harrison


<rdar://problem/4641880>
Setting bullets to existing text grabs subsequent paragraph


When a selection ends at the start of a paragraph, we rarely paint
the selection gap before that paragraph, because there often is no gap.
In a case like this, it's not obvious to the user that the selection
ends "inside" that paragraph, so it would be confusing if
InsertUn{Ordered}List and Indent/Outdent operated on that paragraph.


  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply): Moved the check for editability of the selection to a more appropriate place. Change the endingSelection if it ends at the start of a paragraph.
  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::doApply): Ditto.
  • editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Ditto.
7:25 PM Changeset in webkit [17637] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Sarge

<rdar://problem/4822911> - ASSERTION was a little overzealous.
Toned it down a bit.

  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::didFinishLoading): Toned down assertion
6:34 PM Changeset in webkit [22482] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-11-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Dave Hyatt.

<rdar://problem/4778180>
wikipedia.org crashes when loading


  • platform/win/GlyphMapWin.cpp: (WebCore::GlyphMap::fillPage): Don't call GetGlyphIndices on buffers larger than the page size. GetGlyphIndicies doesn't know anything about Unicode supplementary characters and will overwrite the local buffer if the passed-in buffer is bigger than the page size.
6:33 PM Changeset in webkit [22481] by andersca
  • 1 edit
    1 add in branches/WindowsMerge/WebCore

2006-11-06 Anders Carlsson <​acarlsson@apple.com>

Fork GlyphMapWin.cpp


  • platform/win/GlyphMapWin.cpp: Added. (WebCore::GlyphMap::fillPage):
5:48 PM Changeset in webkit [22480] by ggaren
  • 2 edits
    2 adds in branches/WindowsMerge/WebKitWin

Oops. Forgot to add these files.


Changed comment that Darin mentioned, too.

  • WebChromeClient.cpp:
  • WebScreenClient.cpp: Added. (WebScreenClient::create): (WebScreenClient::WebScreenClient): (WebScreenClient::depth): (WebScreenClient::depthPerComponent): (WebScreenClient::isMonochrome): (WebScreenClient::rect): (WebScreenClient::usableRect):
  • WebScreenClient.h: Added.
5:09 PM Changeset in webkit [17636] by bdash
  • 14 edits
    1 add in trunk

2006-11-06 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Maciej.

Remove warning about garbage after #else. #else clause applies for all
non-mac platforms, not only win.

  • kjs/date_object.cpp:

2006-11-06 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Maciej.

Linux\Gdk build fixes.

  • loader/icon/IconDatabase.cpp:
  • loader/icon/SQLStatement.h:
  • platform/gdk/ChromeClientGdk.h: Added. (WebCore::ChromeClientGdk::~ChromeClientGdk):
  • platform/gdk/CursorGdk.cpp: (WebCore::pointerCursor):
  • platform/gdk/FrameGdk.cpp: (WebCore::doScroll): (WebCore::FrameGdk::FrameGdk): (WebCore::FrameGdk::submitForm): (WebCore::FrameGdk::urlSelected): (WebCore::FrameGdk::openURL): (WebCore::FrameGdk::handleGdkEvent):
  • platform/gdk/FrameGdk.h: (WebCore::FrameGdk::client):
  • platform/gdk/RenderPopupMenuGdk.cpp: (WebCore::PopupMenu::updateFromElement):
  • platform/gdk/ScreenGdk.cpp:
  • platform/gdk/TemporaryLinkStubs.cpp: (Slider::focusPolicy): (WebCore::ServeSynchronousRequest): (FrameGdk::goBackOrForward): (FrameGdk::getHistoryLength): (FrameGdk::historyURL): (ChromeClientGdk::canRunModal): (ChromeClientGdk::runModal): (WebCore::systemBeep): (WebCore::CachedResource::setPlatformResponse): (Path::transform): (ResourceLoader::loadsBlocked): (IconLoader::notifyIconChanged):
  • platform/network/gdk/ResourceHandleManager.cpp: (WebCore::writeCallback): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::remove): (WebCore::ResourceHandleManager::add):

2006-11-06 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Maciej.

Linux\gdk build fixes.

  • GdkLauncher/main.cpp: (LauncherFrameGdk::LauncherFrameGdk): (main):
5:08 PM Changeset in webkit [17635] by thatcher
  • 1 edit in trunk/WebCore/WebCore.exp

64-bit build fix, take two.

5:04 PM Changeset in webkit [17634] by thatcher
  • 1 edit in trunk/WebCore/WebCore.exp

Build fix for 64-bit.

4:56 PM Changeset in webkit [17633] by ggaren
  • 2 edits in trunk/WebKit

Reviewed by Darin.


Accidentally rolled out this change when removing the WebPageBridge. Now
putting it back.

  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]):
4:47 PM S60Buzilla created by bradley.morrison@nokia.com
initial revision
4:30 PM Changeset in webkit [17632] by ggaren
  • 2 edits in trunk/WebCore

build fix.


  • WebCore.xcodeproj/project.pbxproj:
4:29 PM S60Webkit edited by bradley.morrison@nokia.com
minor type fixed (diff)
4:26 PM S60Reindeer created by bradley.morrison@nokia.com
4:01 PM Changeset in webkit [22479] by ggaren
  • 10 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin.

Hooked up the Chrome and Screen clients on Windows.


  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/PageWin.cpp:
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::calculatePositionAndSize):
  • platform/win/TemporaryLinkStubs.cpp:

WebKitWin:

Reviewed by Darin.


Stubbed out the Chrome and Screen clients.

  • WebChromeClient.cpp: (WebChromeClient::setWindowRect): (WebChromeClient::windowRect): (WebChromeClient::pageRect): (WebChromeClient::scaleFactor): (WebChromeClient::focus): (WebChromeClient::unfocus): (WebChromeClient::createWindow): (WebChromeClient::createModalDialog): (WebChromeClient::show): (WebChromeClient::setToolbarsVisible): (WebChromeClient::toolbarsVisible): (WebChromeClient::setStatusbarVisible): (WebChromeClient::statusbarVisible): (WebChromeClient::setScrollbarsVisible): (WebChromeClient::scrollbarsVisible): (WebChromeClient::setMenubarVisible): (WebChromeClient::menubarVisible): (WebChromeClient::setResizable):
  • WebChromeClient.h:
  • WebKit.vcproj/WebKit.vcproj:
  • WebView.cpp: (WebView::initWithFrame):
3:56 PM Changeset in webkit [17631] by ggaren
  • 38 edits
    6 adds
    8 deletes in trunk

WebCore:

Reviewed by Maciej, Anders, Darin.

Removed the Page bridge. Beefed up Chrome. Added Screen and ScreenClient.
Fixed a minor where WebCore would always assume it was displayed on the
monitor containing the menubar. window.open and window.showModalDialog
are now cross-platform.


Layout tests, manual-tests/show-modal-dialog, and manual-tests/
window-open-features-parsing all pass. I verified the new screen functionality
by running in DRT, and checking whether WebCore knew it was off-screen.


Some refactoring remains, as all were not pleased by this design. I see
in my future another patch.

  • bindings/js/kjs_window.cpp: Screen is now a stand-alone object with a client, to encapsulate asking the platform questions about the screen occupied by the page. (Previously, we always assumed we were on screen 0, which was a bug.)
  • bridge/mac/WebCoreFrameBridge.mm: (createMouseEventFromDraggingInfo): Reversed argument order, to match other functions. (-[WebCoreFrameBridge dragSourceMovedTo:]): ditto (-[WebCoreFrameBridge dragSourceEndedAt:operation:]): ditto
  • bridge/mac/WebCoreFrameNamespaces.h: Removed. Dead Code.
  • bridge/mac/WebCoreFrameNamespaces.mm: Removed. Dead Code.
  • bridge/mac/WebCorePageBridge.h: Removed. Dead Code.
  • bridge/mac/WebCorePageBridge.mm: Removed. Dead Code.
  • manual-tests/window-open-features-parsing.html: Updated for accuracy. (In this case, neither size nor position is specified, so you should get the default window size and position.)
  • page/Screen.cpp: Added. Includes screen-related helper functions used in WebCore and WebKit.
  • platform/PlatformMouseEvent.h: Exported common code so it doesn't have to be duplicated. Renamed "position" to "point" since both were used, and "point" seemed clearer.
  • platform/Screen.h: Removed. Dead Code.
  • platform/mac/LoggingMac.mm: Added. Moved code here from WebCorePageBridge initialization.

WebKit:

Reviewed by Maciej, Darin, Anders.

Removed the Page bridge. Beefed up Chrome. Added Screen and ScreenClient.


(WebChromeClient::pageRect): It may seem weird for the page to ask the Chrome/ChromeClient
about its own dimensions. The idea here is that we're asking the Chrome how
much space it has devoted to the page. We have API for this (-webViewContentRect), but
it was documented incorrectly (even Safari used it wrong), so we don't use
it anymore. Once we fix our API/documentation, we can return to making a
delegate callback to ask for the page's size.
(WebChromeClient::createWindow): Changed to take a FrameLoadRequest with
an appropriate referrer, instead of making up its own.
(WebChromeClient::createModalDialog): Changed to take a FrameLoadRequest with
an appropriate referrer, instead of broken out parcels.

  • WebCoreSupport/WebPageBridge.h: Removed. Dead Code.
  • WebCoreSupport/WebPageBridge.mm: Removed. Dead Code.
  • WebCoreSupport/WebScreenClient.h: Added.
  • WebCoreSupport/WebScreenClient.mm: Added.
  • WebView/WebView.mm: Added NULL checks for new _private->page, since it's not NULL-safe like the bridge was, and it gets cleared before dealloc.
3:36 PM S60CheckoutAndBuild created by bradley.morrison@nokia.com
3:09 PM S60ConfigureComputer created by bradley.morrison@nokia.com
2:44 PM Changeset in webkit [17630] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2006-11-06 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (​sachin.padma@nokia.com).
DESC: Enable toolbar capability support
​http://bugs.webkit.org/show_bug.cgi?id=11528

  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):
2:44 PM Changeset in webkit [17629] by gdennis
  • 13 edits in trunk

WebCore:

Reviewed by Tim Hatcher.

Part of patch for ​http://bugs.webkit.org/show_bug.cgi?id=11323
Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref


No layout tests added as this must be tested manually by the test
WebCore/manual-tests/contenteditable-link.html

  • WebCore.exp: Exported HitTestResult::isLiveLink().
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::HTMLAnchorElement): (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::isLiveLink):
  • html/HTMLAnchorElement.h: added m_wasShiftKeyDownOnMouseDown variable to track shift key status.
  • manual-tests/contenteditable-link.html: Added description about link dragging behaviour.
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::isLiveLink): Added.
  • rendering/HitTestResult.h:

WebKit:

Reviewed by Tim Hatcher.

Part of patch for ​http://bugs.webkit.org/show_bug.cgi?id=11323
Link dragging behaviour does not obey WebKitEditableLinkBehavior WebPref

  • DefaultDelegates/WebDefaultUIDelegate.m: (-[NSApplication webView:dragSourceActionMaskForPoint:]): Logic moved to WebHTMLView's _mayStartDragAtEventLocation
  • Misc/WebElementDictionary.m: added isLiveLink (+[WebElementDictionary initializeLookupTable]): (-[WebElementDictionary _isLiveLink]):
  • WebView/WebHTMLView.m: (-[WebHTMLView _mayStartDragAtEventLocation:]): Editable links should only be followed if isLiveLink is true (-[WebHTMLView _isMoveDrag:]): A drag of a live editable link is not a move (-[WebHTMLView draggingUpdatedWithDraggingInfo:actionMask:]): (-[WebHTMLView concludeDragForDraggingInfo:actionMask:]):
  • WebView/WebView.mm: added WebElementLinkIsLiveKey
  • WebView/WebViewPrivate.h: ditto
2:43 PM BuildBot edited by bdash@webkit.org
Update some links and stuff (diff)
2:43 PM Changeset in webkit [17628] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-06 yadavall <​sriram.yadavalli@nokia.com>

Reviewed by Sachin Padma (​Sachin.Padma@nokia.com).
DESC: Enable toolbar capability
​http://bugs.webkit.org/show_bug.cgi?id=11528

  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):
2:42 PM BuildBot edited by bdash@webkit.org
Update Twisted download instructions (diff)
2:39 PM BuildBot edited by bdash@webkit.org
Import of BuildBot instrutions (diff)
2:37 PM BuildBot created by bdash@webkit.org
Import of BuildBot instrutions
2:36 PM S60Webkit edited by bradley.morrison@nokia.com
(diff)
2:30 PM S60Webkit edited by bradley.morrison@nokia.com
(diff)
2:30 PM S60Webkit edited by bradley.morrison@nokia.com
(diff)
2:05 PM S60Webkit created by bradley.morrison@nokia.com
1:23 PM Changeset in webkit [17627] by thatcher
  • 6 edits in trunk/WebKitSite

Reviewed by Anders.

Update the site with new wiki and Trac links.

  • blog/wp-content/themes/webkit/sidebar.php:
  • building/build.html:
  • index.html:
  • nav.inc:
  • projects/svg/index.html:
1:03 PM Changeset in webkit [17626] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Oliver

Fixes <rdar://problem/4812674> and ​http://bugs.webkit.org/show_bug.cgi?id=11530
For now, we have to not load favicons when we have no Document - linking directly
to PDFs being the common case

  • loader/icon/IconLoader.cpp: (WebCore::IconLoader::startLoading): Check for the document and return if none
1:00 PM Changeset in webkit [22478] by bdakin
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders.

Oops! Silly mistake!

  • WebElementPropertyBag.cpp: (convertStringToVariant):
12:56 PM Changeset in webkit [22477] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2006-11-06 Steve Falkenburg <​sfalken@apple.com>

Fix build

  • WebMutableURLRequest.cpp:
12:20 PM Changeset in webkit [17625] by spadma
  • 2 edits in S60/trunk/WebKit

2006-11-06 yaharon <​yael.aharon@nokia.com>

Reviewed by Sachin.
DESC: Place curet under the cursor position when activating an input box
​http://bugs.webkit.org/show_bug.cgi?id=11533

  • BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::SetCursorPositionL):
12:14 PM Changeset in webkit [17624] by spadma
  • 4 edits in S60/trunk/WebKit

2006-11-06 yaharon <​yael.aharon@nokia.com>

Reviewed by Sachin.
DESC: [S60] Remove toolbar in touch environment
​http://bugs.webkit.org/show_bug.cgi?id=11527

  • BrowserView/inc/PointerEventHandler.h:
  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):
  • BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::HandlePointerEventL):
11:27 AM Changeset in webkit [17623] by oliver
  • 1 edit
    4 moves
    12 adds in trunk/LayoutTests

2006-11-06 Oliver Hunt <​oliver@apple.com>

Reviewed by Mitz.

  • svg/W3C-SVG-1.1/text-intro-01-t-expected.checksum: Added.
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.png: Added.
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Added.
  • svg/W3C-SVG-1.1/text-intro-01-t.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.checksum: Added.
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.png: Added.
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Added.
  • svg/W3C-SVG-1.1/text-intro-02-b.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.checksum: Added.
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.png: Added.
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
  • svg/W3C-SVG-1.1/text-intro-03-b.svg-disabled: Removed.
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.checksum: Added.
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.png: Added.
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Added.
  • svg/W3C-SVG-1.1/text-intro-04-t.svg-disabled: Removed.
11:05 AM Changeset in webkit [17622] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Dave Harrison

<rdar://problem/4801066>
Added a critical null frameLoader() check

  • loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::loadNow):
10:26 AM Changeset in webkit [22476] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

2006-11-06 Anders Carlsson <​acarlsson@apple.com>

Reviewed by Maciej.

Copy npfunctions.h to WebKitOutputDir.


  • WebCore.vcproj/WebCore.vcproj:
10:08 AM Changeset in webkit [17621] by harrison
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/4813973> Pressing delete key to remove empty quoted line leaves cursor mis-positioned

  • editing/deleting/delete-br-012-expected.checksum: Added.
  • editing/deleting/delete-br-012-expected.png: Added.
  • editing/deleting/delete-br-012-expected.txt: Added.
  • editing/deleting/delete-br-012.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/4813973> Pressing delete key to remove empty quoted line leaves cursor mis-positioned

Test:

  • editing/deleting/delete-br-012.html


  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): Update m_endingPosition when preventing merge. Also removed setting of m_mergeBlocksAfterDelete when this function returns true, because is is not checked in this case.
9:47 AM Changeset in webkit [17620] by ap
  • 2 edits in trunk/WebKitTools

Build fix, approved in principle by Tim H.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Disable deprecated warnings for main.c (TestNetscapePlugin), as it now uses QuickDraw to convert mouse event coordinates.
9:08 AM Changeset in webkit [17619] by thatcher
  • 2 edits in trunk/WebKitTools

Reviewed by Maciej.

Bug 11525: [Drosera] function menu doesn't understand object.method = function() {} syntax
​http://bugs.webkit.org/show_bug.cgi?id=11525

  • Drosera/debugger.js: imporved the function name code
7:55 AM Changeset in webkit [22475] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-11-06 Steve Falkenburg <​sfalken@apple.com>

Fix double-include of FormData.cpp/.h.

  • WebCore.vcproj/WebCore.vcproj:
6:19 AM Changeset in webkit [17618] by ap
  • 5 edits in trunk/LayoutTests

Reviewed by Sam Weinig.

Fix a layout test failure that happened with additional fonts installed - replace a fancy
Unicode character with a plain asterisk.

  • css2.1/t0905-c414-flt-00-d-expected.checksum:
  • css2.1/t0905-c414-flt-00-d-expected.png:
  • css2.1/t0905-c414-flt-00-d-expected.txt:
  • css2.1/t0905-c414-flt-00-d.html:
5:08 AM Changeset in webkit [17617] by ap
  • 5 edits in trunk

Reviewed by Maciej.

Make sure that alerts and delegate output made after notifyDone() are ignored, rather than
being attributed to the next test.

WebKitTools:

  • DumpRenderTree/EditingDelegate.m: (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]): (-[EditingDelegate webView:shouldEndEditingInDOMRange:]): (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldDeleteDOMRange:]): (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]): (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]): (-[EditingDelegate webViewDidBeginEditing:]): (-[EditingDelegate webViewDidChange:]): (-[EditingDelegate webViewDidEndEditing:]): (-[EditingDelegate webViewDidChangeTypingStyle:]): (-[EditingDelegate webViewDidChangeSelection:]):
  • DumpRenderTree/UIDelegate.m: (-[UIDelegate webView:runJavaScriptAlertPanelWithMessage:]):

LayoutTests:

Removed leftover results from the previous test.

  • editing/selection/drag-to-contenteditable-iframe-expected.txt:
5:03 AM Changeset in webkit [17616] by bdash
  • 3 edits in trunk/LayoutTests

2006-11-07 Mark Rowe <​bdash@webkit.org>

​http://bugs.webkit.org/show_bug.cgi?id=11526
Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg

Correctly updated tests results.

  • fast/dom/HTMLMetaElement/meta-attributes-expected.txt:
  • fast/dom/HTMLMetaElement/meta-attributes.html:
4:54 AM Changeset in webkit [17615] by bdash
  • 17 edits in trunk

2006-11-06 Mark Rowe <​bdash@webkit.org>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11526
Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg

Update DOMNode::toString to always use className rather than preferring nodeName.

  • bindings/js/kjs_dom.cpp: (KJS::DOMNode::toString): Match the format returned by valueOf.

2006-11-06 Mark Rowe <​bdash@webkit.org>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11526
Bug 11526: REGRESSION(r17610): Layout test failure in svg/custom/create-metadata-element.svg

Updated test results for change from nodeName to className in DOMNode::toString.

  • fast/dom/HTMLMetaElement/meta-attributes-expected.txt:
  • fast/dom/prototype-chain-expected.txt:
  • fast/dom/replace-first-child-expected.txt:
  • fast/events/mouseclick-target-and-positioning-expected.txt:
  • fast/forms/input-appearance-preventDefault-expected.checksum:
  • fast/forms/input-appearance-preventDefault-expected.png:
  • fast/forms/input-appearance-preventDefault-expected.txt:
  • fast/loader/loadInProgress-expected.txt:
  • fast/tokenizer/external-script-document-write-expected.checksum:
  • fast/tokenizer/external-script-document-write-expected.png:
  • fast/tokenizer/external-script-document-write-expected.txt:
  • traversal/stay-within-root-expected.checksum:
  • traversal/stay-within-root-expected.png:
  • traversal/stay-within-root-expected.txt:
4:36 AM Changeset in webkit [22474] by mjs
  • 2 edits in branches/WindowsMerge/WebCore
  • build fixes, adjusted for file move
  • WebCore.vcproj/WebCore.vcproj:
3:08 AM Changeset in webkit [17614] by bdash
  • 2 edits in trunk/WebKitTools

2006-11-06 Mark Rowe <​bdash@webkit.org>

Reviewed by Alexey.

Fix "Undefined subroutine &main::WEXITSTATUS" when build-dumprendertree fails.

  • Scripts/run-webkit-tests: import the POSIX module.
2:57 AM Changeset in webkit [17613] by bdash
  • 1 edit in trunk/WebKit/WebCoreSupport/WebFrameBridge.mm

Clean build fix after r17607: removed obselete header include.

1:16 AM Changeset in webkit [17612] by oliver
  • 2 edits in trunk/WebCore

2006-11-06 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej.

Fix RTL text in SVG to have correct positioning

  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::placeBoxesHorizontally):
12:43 AM Changeset in webkit [17611] by ap
  • 7 edits
    2 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11517
REGRESSION: Flash clicks/interactivity not working properly

WebCore:

  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::handleMouseMoveEvent): (WebCore::FrameMac::handleMouseReleaseEvent): Restore parts of event dispatching that were removed when fixing bug 7323 - just bypass those for subframes.

WebKitTools:

Teach TestNetscapePlugin to log events passed to it. To enable, set eventLoggingEnabled to true:

<embed name="plg" type="application/x-webkit-test-netscape" width=100 height=100></embed>
<script>

plg.eventLoggingEnabled = true;
use eventSender to simulate events...

</script>

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (pluginGetProperty): (pluginSetProperty): (pluginAllocate):
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: (NPP_HandleEvent):

LayoutTests:

  • plugins/mouse-events-expected.txt: Added.
  • plugins/mouse-events.html: Added.
12:30 AM Changeset in webkit [17610] by bdash
  • 3 edits
    3 adds in trunk

2006-11-06 Mark Rowe <​bdash@webkit.org>

Reviewed by the wonderful Mitz Pettel.

​http://bugs.webkit.org/show_bug.cgi?id=11524
Bug 11524: REGRESSION(r9842): Array.prototype.join should use ToString operator rather than calling toString on each element

  • kjs/array_object.cpp: (ArrayProtoFunc::callAsFunction): Use ToString operator on each element rather than calling their toString method.

2006-11-06 Mark Rowe <​bdash@webkit.org>

Reviewed by the wonderful Mitz Pettel.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=11524
Bug 11524: REGRESSION(r9842): Array.prototype.join should use ToString operator rather than calling toString on each element

  • fast/js/array-join-bug-11524-expected.txt: Added.
  • fast/js/array-join-bug-11524.html: Added.
  • fast/js/resources/array-join-bug-11524.js: Added.

Nov 5, 2006:

11:03 PM Changeset in webkit [22473] by bdakin
  • 8 edits
    2 adds in branches/WindowsMerge

WebKit:

Reviewed by Steve and Anders. And sort of Maciej.

Here is a basic implementation of elementAtPoint for Boomer.

  • Interfaces/IWebView.idl: The definitions of the WebElementPropertyBag keys.
  • MarshallingHelpers.cpp: (MarshallingHelpers::intRectToSafeArray): New safe array creation function that creates a safe array out of an IntRect.
  • MarshallingHelpers.h:
  • WebElementPropertyBag.cpp: Added. This is the equivalent of WebElementDictionary on the Mac. (WebElementPropertyBag::WebElementPropertyBag): (WebElementPropertyBag::~WebElementPropertyBag): (WebElementPropertyBag::QueryInterface): (WebElementPropertyBag::AddRef): (WebElementPropertyBag::Release): (isEqual): (convertStringToVariant): (WebElementPropertyBag::Read): This is the bulk of the class. It compares the input key to all of the possible keys and calls the appropriate function for each. (WebElementPropertyBag::Write): Writing is not actually allowed.
  • WebElementPropertyBag.h: Added.
  • WebKit.vcproj/WebKit.vcproj:
  • WebView.cpp: (WebView::elementAtPoint): Call into frame to get the HitTestResult for the point and set elementDictionary to the WebElementPropertyBag for the result.

WebCore:

Reviewed by Steve and Anders.

Add client() fucntion to FrameWin to return the FrameClient.

  • bridge/win/FrameWin.h: (WebCore::FrameWin::client):
10:05 PM Changeset in webkit [17609] by darin
  • 14 edits in trunk/WebCore
  • quick attempt to fix the no-SVG build
  • platform/graphics/svg/SVGResource.cpp:
  • platform/graphics/svg/SVGResource.h:
  • platform/graphics/svg/SVGResourceClipper.cpp:
  • platform/graphics/svg/SVGResourceClipper.h:
  • platform/graphics/svg/SVGResourceImage.h:
  • platform/graphics/svg/SVGResourceMarker.cpp:
  • platform/graphics/svg/SVGResourceMarker.h:
  • platform/graphics/svg/SVGResourceMasker.cpp:
  • platform/graphics/svg/SVGResourceMasker.h:
  • platform/graphics/svg/cg/SVGResourceMaskerCg.h:
  • platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
  • platform/graphics/svg/qt/SVGResourceImageQt.cpp:
  • platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added #ifdef SVG_SUPPORT to these files.
7:38 PM Changeset in webkit [22472] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-11-05 Steve Falkenburg <​sfalken@apple.com>

Fix build

  • WebCore.vcproj/WebCore.vcproj:
7:15 PM Changeset in webkit [17608] by mjs
  • 2 edits in trunk/WebCore

Reviewed & landed by Maciej.

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=11265

  • platform/win/ResourceLoaderWin.cpp: (WebCore::transferJobStatusCallback): (WebCore::ResourceLoader::start):
6:55 PM Changeset in webkit [17607] by mjs
  • 8 edits
    4 moves in trunk

WebCore:

Reviewed by Oliver.

  • moved FormData and FormDataStream to platform/network directory
  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac/WebCoreFrameBridge.mm:
  • loader/FormData.cpp: Removed.
  • loader/FormData.h: Removed.
  • loader/mac/FormDataStream.h: Removed.
  • loader/mac/FormDataStream.m: Removed.
  • loader/mac/FrameLoaderMac.mm:
  • loader/mac/SubresourceLoaderMac.mm:
  • platform/network/mac/FormDataStreamMac.h: Added.
  • platform/network/mac/FormDataStreamMac.mm: Added.
  • platform/network/mac/ResourceRequestMac.mm:

WebKit:

Reviewed by Oliver.


  • removed unneeded (and obsolete) header includes
  • WebCoreSupport/WebFrameBridge.mm:
  • WebView/WebFrame.mm:
4:04 PM Changeset in webkit [22471] by sfalken
  • 3 edits in branches/WindowsMerge/WebKitWin

2006-11-05 Steve Falkenburg <​sfalken@apple.com>

Fix build breaks

  • WebFrame.cpp:
  • WebFrame.h:
3:54 PM Changeset in webkit [22470] by sfalken
  • 3 edits in branches/WindowsMerge/WebCore

2006-11-05 Steve Falkenburg <​sfalken@apple.com>

Fix build breaks

  • bridge/win/FrameWin.cpp:
  • bridge/win/PageWin.cpp:
3:52 PM Changeset in webkit [17606] by sfalken
  • 3 edits in trunk/WebCore

2006-11-05 Steve Falkenburg <​sfalken@apple.com>

Fix build breaks

  • loader/DocumentLoader.h:
  • platform/win/ScreenWin.cpp:
3:14 PM Changeset in webkit [17605] by darin
  • 3 edits in trunk/WebKit
  • WebKit part of Frame.h check-in (forgot to land it)
  • WebCoreSupport/WebFrameBridge.h:
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge textViewWasFirstResponderAtMouseDownTime:]): (-[WebFrameBridge shouldInterruptJavaScript]): (-[WebFrameBridge saveDocumentState:]): (-[WebFrameBridge previousKeyViewOutsideWebFrameViews]): (-[WebFrameBridge valueForKey:keys:values:]): (-[WebFrameBridge getObjectCacheSize]): (-[WebFrameBridge startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): (-[WebFrameBridge mayStartDragAtEventLocation:]): (-[WebFrameBridge canGoBackOrForward:]): (-[WebFrameBridge goBackOrForward:]): (-[WebFrameBridge print]): (-[WebFrameBridge getAppletInView:]): (-[WebFrameBridge pollForAppletInView:]): (-[WebFrameBridge respondToChangedContents]): (-[WebFrameBridge respondToChangedSelection]): (-[WebFrameBridge setIsSelected:forView:]):
2:02 PM Changeset in webkit [17604] by darin
  • 37 edits in trunk/WebCore

Reviewed by Geoff.

  • more preparation for splitting up Frame into sub-pieces
  • removed unnecessary includes from Frame.h
  • page/Frame.h: Removed unneeded includes and forward declarations. Added additional forward declarations. Removed the constant NoXPosForVerticalArrowNavigation, now moved inside SelectionController. Created sections of functions to be moved into Chrome, Editor, EventHandler, FrameLoader, SelectionController, and the Platform directory, as well as marking one function for deletion.
  • page/FramePrivate.h: Removed the definition of the constructor and destructor and removed unnecessary includes.
  • page/FrameView.h: Removed unneeded forward declarations and friend declarations. Created a section of functions and data to be moved into EventHandler.
  • bridge/mac/FrameMac.h: Removed unneeded forward declarations. Created sections of functions and data to be moved into Chrome, Editor, EventHandler, FrameLoader, and the Platform directory.
  • bridge/mac/WebCoreFrameBridge.h: Removed obsolete comment. Removed unused methods areScrollbarsVisible, nextValidKeyViewOutsideWebFrameViews, and fileWrapperForURL:.
  • page/Frame.cpp: (WebCore::Frame::begin): Added an overload, so Frame.h doesn't have to include KURL.h just for the KURL default constructor. (WebCore::FramePrivate::FramePrivate): Moved here from FramePrivate.h. (WebCore::FramePrivate::~FramePrivate): Ditto.
  • page/FrameView.cpp: Removed unused scrollbarMoved and scrollingSelf booleans, scrollbarMoved and cleared funcitons. (WebCore::FrameView::clear): Moved the code from the cleared function in here. (WebCore::FrameView::scrollTo): Removed code to set scrollingSelf.
  • bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): Updated for changes to header.
  • editing/SelectionController.cpp: (WebCore::SelectionController::setSelection): (WebCore::SelectionController::xPosForVerticalArrowNavigation): Moved NoXPosForVerticalArrowNavigation into this file.
  • bindings/js/kjs_events.cpp:
  • bindings/js/kjs_html.cpp:
  • bindings/js/kjs_window.cpp:
  • bridge/mac/WebCoreAXObject.mm:
  • bridge/mac/WebCoreFrameBridge.mm:
  • css/cssstyleselector.cpp:
  • dom/Document.cpp:
  • dom/Element.cpp:
  • dom/EventTargetNode.cpp:
  • dom/MouseRelatedEvent.cpp:
  • dom/XMLTokenizer.cpp:
  • html/HTMLBaseElement.cpp:
  • html/HTMLDocument.cpp:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLFrameElementBase.cpp:
  • html/HTMLGenericFormElement.cpp:
  • html/HTMLObjectElement.cpp:
  • html/HTMLTokenizer.cpp:
  • loader/mac/FrameLoaderMac.mm:
  • page/PageState.cpp:
  • rendering/RenderApplet.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderLayer.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderPartObject.cpp:
  • rendering/RenderTreeAsText.cpp:
  • xml/XSLTProcessor.cpp: Added includes as needed to keep compiling, since there are fewer includes in Frame.h.
12:36 AM Changeset in webkit [17603] by ap
  • 2 edits in trunk/WebCore

Reviewed by Dave Harrison.

​http://bugs.webkit.org/show_bug.cgi?id=11402
REGRESSION: onChange does not work anymore for 1st item in popup

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::HTMLSelectElement): (WebCore::HTMLSelectElement::reset): Set m_lastOnChangeIndex to -1.
Note: See TracTimeline for information about the timeline view.