Timeline
Nov 18, 2006:
- 11:20 PM Changeset in webkit [22563] by
-
- 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION
Bump version for submit
- 11:18 PM Changeset in webkit [17851] by
-
- 1 copy in tags/Safari-521.31b
New tag.
- 6:44 PM Changeset in webkit [17850] by
-
- 59 edits41 copies61 adds6 deletes in trunk/WebCore
Reviewed by Oliver.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11596
Split up KCanvasFilters & KCanvasFilterQuartz into several
new classes (SVGFEBlend, SVGFEComposite...) and move them
into platform/graphics/svg. This is still a temporary location,
as discussed with Darin; the whole platform/graphics/svg directory
will probably be moved into ksvg2/ in near future.
This commit removes the duplicated enumerations in the svg filter
classes and within kcanvas. ksvg2/ and platform/graphics/svg share
their enums now.
- 4:47 PM Changeset in webkit [17849] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Darin.
Add tests for crash when garbage collecting node iterators and tree walkers
without a node filter.
- fast/dom/node-filter-gc-expected.txt: Added.
- fast/dom/node-filter-gc.html: Added.
- 3:45 PM Changeset in webkit [22562] by
-
- 2 edits in branches/WindowsMerge/WebCore
Build fix from OpenSource r17841.
- platform/win/CursorWin.cpp: New method stubs. (WebCore::aliasCursor): (WebCore::progressCursor): (WebCore::noDropCursor):
- 2:59 PM Changeset in webkit [17848] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Maciej.
Testcase for:
http://bugs.webkit.org/show_bug.cgi?id=11321
Element with :target pseudo-class still matched after fragment identifier change
- fast/css/target-fragment-match-expected.checksum: Added.
- fast/css/target-fragment-match-expected.png: Added.
- fast/css/target-fragment-match-expected.txt: Added.
- fast/css/target-fragment-match.html: Added.
WebCore:
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=11321
Element with :target pseudo-class still matched after fragment identifier change
Make sure the page does a style recalculation and possible rendering
when navigating back from a page with an anchor to a page without
an anchor.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor):
- 12:58 PM Changeset in webkit [17847] by
-
- 10 edits2 adds in trunk
2006-11-18 Don Gibson <dgibson77@gmail.com>
Reviewed by Sam Weinig.
http://bugs.webkit.org/show_bug.cgi?id=11634:
Fix segfault on startup for Windows build. Also fix segfault when
typing in a URL.
Clean up some of the style of the patch that landed in r17816.
WebCore:
- WebCore.vcproj/WebCore/WebCore.vcproj:
- bridge/win/ChromeClientWin.h: (WebCore::ChromeClientWin::~ChromeClientWin): (WebCore::ChromeClientWin::ref): (WebCore::ChromeClientWin::deref):
- bridge/win/ContextMenuClientWin.h: (WebCore::ContextMenuClientWin::~ContextMenuClientWin): (WebCore::ContextMenuClientWin::ref): (WebCore::ContextMenuClientWin::deref):
- bridge/win/EditorClientWin.h: (WebCore::EditorClientWin::~EditorClientWin): (WebCore::EditorClientWin::ref): (WebCore::EditorClientWin::deref):
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
- bridge/win/FrameWin.h: (WebCore::Win):
- loader/win/FrameLoaderClientWin.h: Added. (WebCore::FrameLoaderClientWin::~FrameLoaderClientWin): (WebCore::FrameLoaderClientWin::ref): (WebCore::FrameLoaderClientWin::deref):
- platform/win/TemporaryLinkStubs.cpp: (WebCore::ChromeClientWin::createWindow): (WebCore::ChromeClientWin::createModalDialog): (WebCore::EditorClientWin::selectWordBeforeMenuEvent): (WebCore::EditorClientWin::isEditable): (WebCore::EditorClientWin::shouldBeginEditing): (WebCore::EditorClientWin::shouldEndEditing): (WebCore::EditorClientWin::shouldApplyStyle): (WebCore::EditorClientWin::didBeginEditing): (WebCore::EditorClientWin::respondToChangedContents): (WebCore::EditorClientWin::didEndEditing): (WebCore::EditorClientWin::registerCommandForUndo): (WebCore::EditorClientWin::registerCommandForRedo): (WebCore::EditorClientWin::clearUndoRedoOperations): (WebCore::EditorClientWin::canUndo): (WebCore::EditorClientWin::canRedo): (WebCore::EditorClientWin::undo): (WebCore::EditorClientWin::redo): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::createPlugin): (WebCore::FrameLoaderClientWin::hasWebView): (WebCore::FrameLoaderClientWin::hasFrameView): (WebCore::FrameLoaderClientWin::hasBackForwardList): (WebCore::FrameLoaderClientWin::resetBackForwardList): (WebCore::FrameLoaderClientWin::provisionalItemIsTarget): (WebCore::FrameLoaderClientWin::loadProvisionalItemFromPageCache): (WebCore::FrameLoaderClientWin::invalidateCurrentItemPageCache): (WebCore::FrameLoaderClientWin::privateBrowsingEnabled): (WebCore::FrameLoaderClientWin::makeDocumentView): (WebCore::FrameLoaderClientWin::makeRepresentation): (WebCore::FrameLoaderClientWin::forceLayout): (WebCore::FrameLoaderClientWin::forceLayoutForNonHTML): (WebCore::FrameLoaderClientWin::updateHistoryForCommit): (WebCore::FrameLoaderClientWin::updateHistoryForBackForwardNavigation): (WebCore::FrameLoaderClientWin::updateHistoryForReload): (WebCore::FrameLoaderClientWin::updateHistoryForStandardLoad): (WebCore::FrameLoaderClientWin::updateHistoryForInternalLoad): (WebCore::FrameLoaderClientWin::updateHistoryAfterClientRedirect): (WebCore::FrameLoaderClientWin::setCopiesOnScroll): (WebCore::FrameLoaderClientWin::tokenForLoadErrorReset): (WebCore::FrameLoaderClientWin::resetAfterLoadError): (WebCore::FrameLoaderClientWin::doNotResetAfterLoadError): (WebCore::FrameLoaderClientWin::willCloseDocument): (WebCore::FrameLoaderClientWin::detachedFromParent1): (WebCore::FrameLoaderClientWin::detachedFromParent2): (WebCore::FrameLoaderClientWin::detachedFromParent3): (WebCore::FrameLoaderClientWin::detachedFromParent4): (WebCore::FrameLoaderClientWin::loadedFromPageCache): (WebCore::FrameLoaderClientWin::dispatchDidHandleOnloadEvents): (WebCore::FrameLoaderClientWin::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebCore::FrameLoaderClientWin::dispatchDidCancelClientRedirect): (WebCore::FrameLoaderClientWin::dispatchWillPerformClientRedirect): (WebCore::FrameLoaderClientWin::dispatchDidChangeLocationWithinPage): (WebCore::FrameLoaderClientWin::dispatchWillClose): (WebCore::FrameLoaderClientWin::dispatchDidReceiveIcon): (WebCore::FrameLoaderClientWin::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientWin::dispatchDidReceiveTitle): (WebCore::FrameLoaderClientWin::dispatchDidCommitLoad): (WebCore::FrameLoaderClientWin::dispatchDidFinishLoad): (WebCore::FrameLoaderClientWin::dispatchDidFirstLayout): (WebCore::FrameLoaderClientWin::dispatchShow): (WebCore::FrameLoaderClientWin::cancelPolicyCheck): (WebCore::FrameLoaderClientWin::dispatchWillSubmitForm): (WebCore::FrameLoaderClientWin::dispatchDidLoadMainResource): (WebCore::FrameLoaderClientWin::clearLoadingFromPageCache): (WebCore::FrameLoaderClientWin::isLoadingFromPageCache): (WebCore::FrameLoaderClientWin::revertToProvisionalState): (WebCore::FrameLoaderClientWin::clearUnarchivingState): (WebCore::FrameLoaderClientWin::progressStarted): (WebCore::FrameLoaderClientWin::progressCompleted): (WebCore::FrameLoaderClientWin::setMainFrameDocumentReady): (WebCore::FrameLoaderClientWin::willChangeTitle): (WebCore::FrameLoaderClientWin::didChangeTitle): (WebCore::FrameLoaderClientWin::finishedLoading): (WebCore::FrameLoaderClientWin::finalSetupForReplace): (WebCore::FrameLoaderClientWin::setDefersLoading): (WebCore::FrameLoaderClientWin::isArchiveLoadPending): (WebCore::FrameLoaderClientWin::cancelPendingArchiveLoad): (WebCore::FrameLoaderClientWin::clearArchivedResources): (WebCore::FrameLoaderClientWin::canShowMIMEType): (WebCore::FrameLoaderClientWin::representationExistsForURLScheme): (WebCore::FrameLoaderClientWin::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientWin::frameLoadCompleted): (WebCore::FrameLoaderClientWin::restoreScrollPositionAndViewState): (WebCore::FrameLoaderClientWin::provisionalLoadStarted): (WebCore::FrameLoaderClientWin::shouldTreatURLAsSameAsCurrent): (WebCore::FrameLoaderClientWin::addHistoryItemForFragmentScroll): (WebCore::FrameLoaderClientWin::didFinishLoad): (WebCore::FrameLoaderClientWin::prepareForDataSourceReplacement): (WebCore::FrameLoaderClientWin::setTitle): (WebCore::FrameLoaderClientWin::userAgent):
WebKit:
- COM/WebFrame.cpp: (WebFrame::initWithName):
- 12:19 PM Changeset in webkit [17846] by
-
- 2 edits in S60/branches/3.1m/WebCore
2006-11-16 rathnasa <sornalatha.rathnasamy@nokia.com>
Reviewed by Zalan Bujtas <zbujtas@gmail.com>.
Merged from 3.2 r17845
DESC: Image map using ID attribute cannot be activated
http://bugs.webkit.org/show_bug.cgi?id=11618
WARNING: NO TEST CASES ADDED OR CHANGED
- khtml/html/html_imageimpl.cpp: (HTMLMapElementImpl::parseHTMLAttribute):
- 12:17 PM Changeset in webkit [17845] by
-
- 2 edits in S60/trunk/WebCore
2006-11-16 rathnasa <sornalatha.rathnasamy@nokia.com>
Reviewed by Zalan Bujtas <zbujtas@gmail.com>.
DESC: Image map using ID attribute cannot be activated
http://bugs.webkit.org/show_bug.cgi?id=11618
WARNING: NO TEST CASES ADDED OR CHANGED
- khtml/html/html_imageimpl.cpp: (HTMLMapElementImpl::parseHTMLAttribute):
- 11:29 AM Changeset in webkit [17844] by
-
- 2 edits in S60/trunk/WebCore
2006-11-16 yadavall <sriram.yadavalli@nokia.com>
Reviewed by Zalan Bujtas (zbujtas@gmail.com).
DESC: Fix for tabbed navigation
http://bugs.webkit.org/show_bug.cgi?id=11619
WARNING: NO TEST CASES ADDED OR CHANGED
- kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::getNewTabbedCursorPosition):
- 11:25 AM Changeset in webkit [17843] by
-
- 2 edits in S60/trunk/WebCore
2006-11-16 shkeller <shaun.keller@nokia.com>
Reviewed by zalan.
DESC: render object of image type was wrongly typecast and move brace so changelog script works
http://bugs.webkit.org/show_bug.cgi?id=11608
WARNING: NO TEST CASES ADDED OR CHANGED
- khtml/html/html_objectimpl.cpp: (HTMLEmbedElementImpl::isFocusable): (HTMLObjectElementImpl::getObjectInstance): (HTMLObjectElementImpl::isFocusable):
- 5:52 AM Changeset in webkit [17842] by
-
- 5 edits in trunk
Reviewed by Rob (yay!).
http://bugs.webkit.org/show_bug.cgi?id=11640
XMLHttpRequest produces undefined:undefined HTTP authentication
WebCore:
- bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Treat undefined credentials as missing ones.
LayoutTests:
- http/tests/xmlhttprequest/basic-auth-expected.txt:
- http/tests/xmlhttprequest/basic-auth.html: Added tests for undefined.
- 3:24 AM Nightly Builds edited by
- Changed to talk about Safari extensions in general rather than about a … (diff)
- 3:01 AM Known incompatibilities between open-source WebKit and Safari edited by
- Deleted obsolete information. The context menu items are present and … (diff)
- 2:00 AM Changeset in webkit [17841] by
-
- 9 edits3 adds in trunk/WebCore
2006-11-17 Lars Naesbye Christensen <larsnaesbye@stud.ku.dk>
Reviewed by Tim H.
http://bugs.webkit.org/show_bug.cgi?id=11638
[CSS 2.1+3] add support for alias, progress, no-drop and not-allowed cursor styles
- Resources/aliasCursor.png: Added.
- Resources/noDropCursor.png: Added.
- Resources/progressCursor.png: Added.
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
- css/CSSValueKeywords.in:
- manual-tests/cursor.html:
- page/EventHandler.cpp: (WebCore::selectCursor):
- platform/Cursor.h:
- platform/mac/CursorMac.mm: (WebCore::handCursor): (WebCore::aliasCursor): (WebCore::progressCursor): (WebCore::noDropCursor):
- rendering/RenderStyle.h: (WebCore::):
- 1:30 AM Changeset in webkit [17840] by
-
- 2 edits in trunk/WebKitSite
2006-11-18 Mitz Pettel <mitz@webkit.org>
Reviewed by Maciej.
Gender-neutrality fix.
- coding/contributing.html:
- 1:29 AM Changeset in webkit [17839] by
-
- 2 edits in trunk/WebCore
2006-11-18 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam.
Properly adjust CFAbsoluteTime to time_t to fix date calculations.
Compare lastModified w/ MAX_TIME_T when setting last modified date
instead of comparing expiration against MAX_TIME_T.
- platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::getResourceResponse): Add kCFAbsoluteTimeIntervalSince1970 in assignment
Nov 17, 2006:
- 9:57 PM Changeset in webkit [17838] by
-
- 10 edits in trunk/WebCore
Reviewed by Geoff.
More conversions from DeprecatedValueList to Vector and HashSet.
- css/CSSValueList.cpp: (WebCore::CSSValueList::~CSSValueList): (WebCore::CSSValueList::append): (WebCore::CSSValueList::cssText):
- css/CSSValueList.h: (WebCore::CSSValueList::length): (WebCore::CSSValueList::item):
- dom/Document.cpp: (WebCore::Document::attachNodeIterator): (WebCore::Document::notifyBeforeNodeRemoval):
- dom/Document.h:
- ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::notifyAttributeChange):
- ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::notifyClientsToRepaint):
- platform/graphics/svg/SVGResource.cpp: (WebCore::SVGResource::invalidate): (WebCore::SVGResource::addClient):
- platform/graphics/svg/SVGResource.h:
- rendering/RenderBlock.h:
- 7:29 PM Changeset in webkit [22561] by
-
- 19 edits in branches/WindowsMerge
WebCoreWin:
Reviewed by Adam.
Add #defines in config.h to prevent the min and max macros from being used.
- bridge/win/FrameWin.cpp:
- config.h:
- platform/win/FontCacheWin.cpp: (WebCore::FontCache::createFontPlatformData):
- platform/win/PopupMenuWin.cpp:
- plugins/win/PluginStreamWin.cpp:
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handlePost):
WebKitWin:
Reviewed by Adam.
Make sure that all .cpp files and none of the headers include config.h.
- MemoryStream.cpp:
- WebBackForwardList.cpp:
- WebBackForwardList.h:
- WebElementPropertyBag.cpp:
- WebHTMLRepresentation.cpp:
- WebKitClassFactory.cpp:
- WebKitDLL.cpp:
- WebMutableURLRequest.cpp:
- WebMutableURLRequest.h:
- WebURLResponse.cpp:
- WebURLResponse.h:
- 7:15 PM Changeset in webkit [17837] by
-
- 4 edits in trunk/JavaScriptCore
2006-11-17 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adam.
Make sure that we always use std::min and std::max instead of macros.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- kjs/config.h:
- wtf/Vector.h:
- 7:09 PM Changeset in webkit [22560] by
-
- 2 edits in branches/WindowsMerge/WebCore
Reviewed by Adam.
- Fixes Targetted Form Submission to now work. Radar: 4762693
- ChangeLog:
- loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::submitForm):
- 6:24 PM Changeset in webkit [17836] by
-
- 1 edit in trunk/WebCore/editing/EditCommand.cpp
Fixing the assertion failure, forgot to remove an enable() call.
- 5:24 PM Changeset in webkit [17835] by
-
- 1 edit8 copies in tags/Safari-521.31
New tag.
- 5:21 PM Changeset in webkit [17834] by
-
- 6 edits in /
Versioning
- 5:06 PM Changeset in webkit [17833] by
-
- 3 edits in trunk/WebCore
Reviewed by Harrison.
<rdar://problem/4796730> table deletion elements are serialized out if they are visible when innerHTML or a Web Archive is made
Disable the delete button controller when cloning nodes, Mail does this before saving a draft.
- dom/ContainerNode.cpp: (WebCore::ContainerNode::cloneChildNodes):
- editing/markup.cpp: (WebCore::createFragmentFromNodes):
- 5:04 PM Changeset in webkit [17832] by
-
- 9 edits12 adds in trunk
LayoutTests:
Reviewed by harrison
<rdar://problem/4237467> REGRESSION: Pasting word from quoted text quotes the destination
<rdar://problem/4017358> quoted text is wrong color, when pasted as quotation
Fixed:
- editing/pasteboard/merge-end-blockquote-expected.checksum:
- editing/pasteboard/merge-end-blockquote-expected.png:
- editing/pasteboard/merge-end-blockquote-expected.txt:
- editing/pasteboard/merge-end-blockquote.html:
Added:
- editing/pasteboard/paste-blockquote-1-expected.checksum: Added.
- editing/pasteboard/paste-blockquote-1-expected.png: Added.
- editing/pasteboard/paste-blockquote-1-expected.txt: Added.
- editing/pasteboard/paste-blockquote-1.html: Added.
- editing/pasteboard/paste-blockquote-2-expected.checksum: Added.
- editing/pasteboard/paste-blockquote-2-expected.png: Added.
- editing/pasteboard/paste-blockquote-2-expected.txt: Added.
- editing/pasteboard/paste-blockquote-2.html: Added.
- editing/pasteboard/paste-blockquote-3-expected.checksum: Added.
- editing/pasteboard/paste-blockquote-3-expected.png: Added.
- editing/pasteboard/paste-blockquote-3-expected.txt: Added.
- editing/pasteboard/paste-blockquote-3.html: Added.
WebCore:
Reviewed by harrison
<rdar://problem/4237467> REGRESSION: Pasting word from quoted text quotes the destination
<rdar://problem/4017358> quoted text is wrong color, when pasted as quotation
- editing/ReplaceSelectionCommand.cpp: (WebCore::isMailPasteAsQuotationNode): Added. Checks for the node that Mail wraps around an incoming fragment when it wants it to be pasted with quoting (no merging should be done). (WebCore::ReplaceSelectionCommand::removeNodePreservingChildren): Added this virtual method in order to adjust the nodes that ReplaceSelectionCommand tracks. (WebCore::ReplaceSelectionCommand::shouldMerge): Don't merge from content inside a Mail Paste as Quotation node. Allow merging from Mail blockquotes. (WebCore::ReplaceSelectionCommand::removeRedundantStyles): When pasting into a Mail blockquote, we ignore the parts of the source document's default style that are overriden by styles from the Mail blockquote. This is necessary in order for text that's black (because black is the source document's default font color) to appear blue/green/whatever when it's pasted into a Mail blockquote. (WebCore::ReplaceSelectionCommand::handlePasteAsQuotationNode): Turn an inserted Mail Paste as Quotation node into a normal Mail blockquote. This will prevent a copied blockquote that was inserted into the document using Paste as Quotation from triggering Paste as Quotation behavior when it's pasted. (WebCore::ReplaceSelectionCommand::doApply): Call the new/altered methods.
- editing/ReplaceSelectionCommand.h:
- editing/markup.cpp: (WebCore::styleFromMatchedRulesForElement): Put this code into a subroutine. (WebCore::removeEnclosingMailBlockquoteStyle): Added. (WebCore::startMarkup): When wrapping text nodes in style spans, leave out styles that Mail blockquotes contribute, so that Mail blockquote styles can be differentiated from styles that the user has applied. When creating markup for elements, do the same thing. (WebCore::createMarkup): Call the new subroutine.
- 4:22 PM Changeset in webkit [17831] by
-
- 1 edit in trunk/WebKit/WebKit.xcodeproj/project.pbxproj
Forgoet the project change.
- 4:21 PM Changeset in webkit [17830] by
-
- 2 edits in trunk/WebKit
Reviewed by Geoff.
<rdar://problem/4841044> Temporarily default Mail.app editable link clicking behavior, until they do it themselves
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebView.mm: (+[WebView initialize]): (-[WebView setPreferences:]):
- 4:04 PM Changeset in webkit [22559] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
Reviewed by Adele.
- fix leak of Document ref count seen in updateCounterpartURLForRSS
- WebScriptObject.h: Changed destructor to be virtual. Without this, when the COM object was released we wouldn't release the underlying WebCore::Node.
- 12:14 PM Changeset in webkit [17829] by
-
- 2 edits in trunk/WebCore
Reviewed by Mitz.
http://bugs.webkit.org/show_bug.cgi?id=11635
Bug 11635: Fix potential issue with non-xslt build
Fix the issue and do style guideline corrections.
- 11:47 AM Changeset in webkit [17828] by
-
- 3 edits in trunk/WebCore
Reviewed by Harrison.
<rdar://problem/4843131> text entry is slow inside element that has the deletion rectangle around it
Only disable/enable the delete button inside applyCommand() to prevent slowing down typing.
This reintroduces <rdar://problem/4796657> table deletion outline does not always follow the table size as editing occurs inside
- editing/EditCommand.cpp: (WebCore::EditCommand::apply): (WebCore::EditCommand::unapply): (WebCore::EditCommand::reapply): (WebCore::applyCommand):
- editing/EditCommand.h:
- 11:42 AM Changeset in webkit [22558] by
-
- 4 edits in branches/WindowsMerge/WebKitWin
WebKitWin:
Reviewed by Adele.
- fix leak of WebView when you close a tab or window
- Interfaces/IWebView.idl: Added a close function, like the close method we added to WebView on the Macintosh side.
- WebView.h: Added close function.
- WebView.cpp: (WebView::close): First cut at implementation of close.
- 11:23 AM Changeset in webkit [17827] by
-
- 13 edits5 adds in trunk
Reviewed by Mitz. Landed by Niko.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11617
Adapt to latest API changes, fixing Qt/Linux build.
- 11:21 AM Changeset in webkit [17826] by
-
- 2 edits in trunk/WebCore
Reviewed by Adele.
<rdar://problem/4799899> Frame::revealSelection() only scrolls the startContainer's layer
Replace an assert with a fixme that refers to this bug.
- page/Frame.cpp: (WebCore::Frame::revealSelection):
Nov 16, 2006:
- 7:04 PM Changeset in webkit [22557] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
WebKitWin:
Reviewed by Steve, Ada.
Added new WebMenuItemBaseApplicationTag to the WebMenuItemTag enum to
keep WebKit apps from conflicting with WebKit context menu identifiers.
- Interfaces/IWebUIDelegate.idl:
- 6:11 PM Changeset in webkit [17825] by
-
- 10 edits4 adds in trunk
LayoutTests:
Reviewed and landed by Brady
Testcase for:
http://bugs.webkit.org/show_bug.cgi?id=11590
Bug 11590: REGRESSION (r17726-r17742): Wikipedia page intermittently loads but doesn't render
- fast/css/import-rule-regression-11590-expected.txt: Added.
- fast/css/import-rule-regression-11590.html: Added.
- fast/css/resources/imports.css: Added.
- fast/css/resources/style.css: Added.
WebCore:
Reviewed and landed by Brady
Fixes http://bugs.webkit.org/show_bug.cgi?id=11590 -
REGRESSION (r17726-r17742): Wikipedia page intermittently loads but doesn't render
Fix the regression by setting m_loadCompleted correctly.
- css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::checkLoaded):
- dom/Node.h: (WebCore::Node::sheetLoaded):
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::sheetLoaded):
- dom/ProcessingInstruction.h:
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::sheetLoaded):
- html/HTMLLinkElement.h:
- html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::sheetLoaded):
- html/HTMLStyleElement.h:
- 5:06 PM Changeset in webkit [17824] by
-
- 8 edits1 add in trunk/WebCore
Reviewed by Beth.
<rdar://problem/4056100> REGRESSION (Tiger): Deleting top part of reply email leaves fails to clear text at end of message
The problem was triggered by the fact that the parent div was changing both
in position and in height. The renderer normally bifurcates its logic for
x-position changes vs height changes.
Call repaintDuringLayoutIfMoved() with old rect (incl. width and height) instead of just the old position.
Test added:
- manual-tests/delete-into-nested-block.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::positionNewFloats):
- rendering/RenderBox.cpp: (WebCore::RenderBox::repaintDuringLayoutIfMoved):
- rendering/RenderBox.h:
- rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::placeChild):
- rendering/RenderObject.cpp: (WebCore::RenderObject::repaintDuringLayoutIfMoved):
- rendering/RenderObject.h:
- rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::layoutRows):
- 4:07 PM Changeset in webkit [22556] by
-
- 1 edit in branches/WindowsMerge/WebCore/ChangeLog
Reviewed by Adam.
Added theme for sider.
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::sliderTheme): (WebCore::RenderThemeWin::close): (WebCore::RenderThemeWin::determineSliderThumbState): (WebCore::RenderThemeWin::getClassicThemeData): (WebCore::RenderThemeWin::getThemeData): (WebCore::drawControl): (WebCore::RenderThemeWin::paintSliderTrack): (WebCore::RenderThemeWin::paintSliderThumb): (WebCore::RenderThemeWin::adjustSliderThumbSize):
- rendering/RenderThemeWin.h:
- 4:03 PM Changeset in webkit [17823] by
-
- 7 edits in trunk/WebCore
Reviewed by Adam.
Slider cleanup. Let the theme set the size of the slider thumb.
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::setStyle): Moving the thumb's appearance adjustment to createThumbStyle. (WebCore::RenderSlider::createThumbStyle): (WebCore::RenderSlider::layout): Let the theme set the size of the thumb.
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustSliderThumbSize): Added.
- rendering/RenderTheme.h: ditto.
- rendering/RenderThemeMac.h: ditto.
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustSliderThumbSize): ditto.
- 3:34 PM Changeset in webkit [17822] by
-
- 3 edits in S60/branches/3.1m/WebKit
2006-11-15 yaharon <yael.aharon@nokia.com>
Reviewed by Sachin.
DESC: [S60] EJXO-6UUCVJ: Browser: The Saved page folder is empty after saving a page.
http://bugs.webkit.org/show_bug.cgi?id=110606
- BrowserView/inc/WebKitControl.h:
- BrowserView/src/WebKitControl.cpp: (CWebKitControl::CWebKitControl): (CWebKitControl::PageInfoLC): (CWebKitControl::HandleLoaderCommandL): (CWebKitControl::LoadUrlL):
- 3:27 PM Changeset in webkit [17821] by
-
- 3 edits in S60/trunk/WebKit
2006-11-15 yaharon <yael.aharon@nokia.com>
Reviewed by Sachin.
DESC: [S60] EJXO-6UUCVJ: Browser: The Saved page folder is empty after saving a page.
http://bugs.webkit.org/show_bug.cgi?id=110606
- BrowserView/inc/WebKitControl.h:
- BrowserView/src/WebKitControl.cpp: (CWebKitControl::CWebKitControl): (CWebKitControl::PageInfoLC): (CWebKitControl::HandleLoaderCommandL): (CWebKitControl::LoadUrlL):
- 3:24 PM Changeset in webkit [17820] by
-
- 7 edits in S60/trunk/WebKit
2006-11-16 yadavall <sriram.yadavalli@nokia.com>
Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: Fix copyright issues
http://bugs.webkit.org/show_bug.cgi?id=11620
- BrowserView/inc/WidgetExtension.h:
- BrowserView/inc/WidgetPreferences.h:
- BrowserView/inc/WidgetRenderer.h:
- BrowserView/src/WidgetExtension.cpp:
- BrowserView/src/WidgetPreferences.cpp:
- BrowserView/src/WidgetRenderer.cpp: (TWidgetRenderer::TWidgetRenderer): (TWidgetRenderer::PrepareForTransitionL): (TWidgetRenderer::PerformTransitionL): (TWidgetRenderer::TransitionCb): (TWidgetRenderer::DrawFadeMaskL): (TWidgetRenderer::DrawTransition):
- 2:54 PM Changeset in webkit [17819] by
-
- 2 edits in S60/trunk/WebKit
2006-11-15 rathnasa <sornalatha.rathnasamy@nokia.com>
Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: Feeds Engine / Form element in feed article: If input box is selected the browser crashes.
http://bugs.webkit.org/show_bug.cgi?id=11603
- BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::SetCursorPositionL):
- 1:22 PM Changeset in webkit [17818] by
-
- 19 edits in trunk/WebCore
Reviewed by Darin.
Use Vector instead of DeprecatedValueList in a few places.
- bindings/js/kjs_dom.cpp: (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection): (KJS::DOMNamedNodesCollection::lengthGetter): (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
- bindings/js/kjs_dom.h:
- bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::namedItemGetter): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLCollection::getNamedItems):
- bindings/objc/DOM.mm:
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::dashboardRegionsDictionary):
- css/CSSStyleDeclaration.cpp: (WebCore::CSSStyleDeclaration::diff):
- html/HTMLCollection.cpp: (WebCore::HTMLCollection::namedItems):
- html/HTMLCollection.h:
- kcanvas/KCanvasFilters.cpp: (WebCore::KCanvasFilter::externalRepresentation):
- kcanvas/KCanvasFilters.h: (WebCore::KCanvasFEColorMatrix::values): (WebCore::KCanvasFEColorMatrix::setValues): (WebCore::KCanvasFEConvolveMatrix::kernel): (WebCore::KCanvasFEConvolveMatrix::setKernel):
- kcanvas/device/quartz/KCanvasFilterQuartz.mm: (WebCore::KCanvasFilterQuartz::getCIFilterStack): (WebCore::KCanvasFEColorMatrixQuartz::getCIFilter):
- ksvg2/svg/SVGFEColorMatrixElement.cpp: (WebCore::SVGFEColorMatrixElement::filterEffect):
- platform/graphics/svg/SVGResourceClipper.h:
- platform/graphics/svg/cg/SVGResourceClipperCg.cpp: (WebCore::SVGResourceClipper::applyClip):
- platform/network/FormData.h:
- rendering/RenderPath.h:
- rendering/SVGRenderTreeAsText.h: (WebCore::operator<<):
- 1:03 PM Changeset in webkit [17817] by
-
- 2 edits in trunk/WebCore
Reviewed by Tim.
- editing/markup.cpp: (WebCore::createMarkup): Add null-checks for the frame, it might not exist for all documents.
- 12:32 PM Changeset in webkit [17816] by
-
- 23 edits2 adds1 delete in trunk
2006-11-16 Don Gibson <dgibson77@gmail.com>
Reviewed and landed by ap.
http://bugs.webkit.org/show_bug.cgi?id=11509:
Windows build bustage.
Also reorganizes WebCore.vcproj to add files whose absence wasn't
causing compile errors, but which should have been there, and to
make the include directory ordering (and contents) sane.
Also reorganizes TemporaryLinkStubs.cpp to put headers and
function groups in alphabetical order, and ensure that all functions
in the file call notImplemented().
WebCore:
- WebCore.vcproj/WebCore/WebCore.vcproj:
- bridge/win/ChromeClientWin.h: (WebCore::ChromeClientWin::ref): (WebCore::ChromeClientWin::deref):
- bridge/win/ContextMenuClientWin.h: Added. (WebCore::ContextMenuClientWin::~ContextMenuClientWin): (WebCore::ContextMenuClientWin::ref): (WebCore::ContextMenuClientWin::deref):
- bridge/win/EditorClientWin.h:
- bridge/win/FrameWin.cpp: (WebCore::FrameWin::~FrameWin): (WebCore::FrameWin::keyPress):
- bridge/win/FrameWin.h:
- bridge/win/PageWin.cpp: Removed.
- editing/EditCommand.h:
- loader/FormState.h:
- loader/FrameLoader.h:
- page/EventHandler.cpp:
- platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes):
- platform/graphics/win/ImageWin.cpp:
- platform/network/ResourceError.cpp:
- platform/network/ResourceHandleInternal.h:
- platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::onHandleCreated): (WebCore::ResourceHandle::onRequestRedirected): (WebCore::ResourceHandle::start): (WebCore::ResourceHandle::cancel):
- platform/win/ScreenWin.cpp: (WebCore::monitorInfo): (WebCore::screenRect): (WebCore::screenAvailableRect): (WebCore::screenDepth):
- platform/win/SoundWin.cpp: Added. (WebCore::systemBeep):
- platform/win/TemporaryLinkStubs.cpp: (WebCore::CacheObjectExpiresTime): (WebCore::CheckCacheObjectStatus): (WebCore::CheckIfReloading): (WebCore::defaultLanguage): (WebCore::fileButtonChooseFileLabel): (WebCore::fileButtonNoFileSelectedLabel): (WebCore::findNextSentenceFromIndex): (WebCore::findNextWordFromIndex): (WebCore::findSentenceBoundary): (WebCore::findWordBoundary): (WebCore::focusRingColor): (WebCore::historyContains): (WebCore::inputElementAltText): (WebCore::IsResponseURLEqualToURL): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::moveCursor): (WebCore::verticalTextCursor): (WebCore::refreshPlugins): (WebCore::resetButtonDefaultLabel): (WebCore::ResponseIsMultipart): (WebCore::ResponseMIMEType): (WebCore::ResponseURL): (WebCore::screenDepthPerComponent): (WebCore::screenIsMonochrome): (WebCore::searchableIndexIntroduction): (WebCore::ServeSynchronousRequest): (WebCore::setFocusRingColorChangeFunction): (WebCore::submitButtonDefaultLabel): (WebCore::CachedResource::setPlatformResponse): (WebCore::CachedResource::setAllData): (WebCore::ChromeClientWin::setWindowRect): (WebCore::ChromeClientWin::windowRect): (WebCore::ChromeClientWin::pageRect): (WebCore::ChromeClientWin::scaleFactor): (WebCore::ChromeClientWin::focus): (WebCore::ChromeClientWin::unfocus): (WebCore::ChromeClientWin::createWindow): (WebCore::ChromeClientWin::createModalDialog): (WebCore::ChromeClientWin::show): (WebCore::ChromeClientWin::canRunModal): (WebCore::ChromeClientWin::runModal): (WebCore::ChromeClientWin::setToolbarsVisible): (WebCore::ChromeClientWin::toolbarsVisible): (WebCore::ChromeClientWin::setStatusbarVisible): (WebCore::ChromeClientWin::statusbarVisible): (WebCore::ChromeClientWin::setScrollbarsVisible): (WebCore::ChromeClientWin::scrollbarsVisible): (WebCore::ChromeClientWin::setMenubarVisible): (WebCore::ChromeClientWin::menubarVisible): (WebCore::ChromeClientWin::setResizable): (WebCore::ContextMenu::appendItem): (WebCore::ContextMenuClientWin::addCustomContextMenuItems): (WebCore::DocumentLoader::setFrame): (WebCore::DocumentLoader::frameLoader): (WebCore::DocumentLoader::URL): (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::setLoading): (WebCore::DocumentLoader::updateLoading): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::isLoadingInAPISense): (WebCore::DocumentLoader::stopRecordingResponses): (WebCore::EditorClientWin::shouldDeleteRange): (WebCore::EditorClientWin::shouldShowDeleteInterface): (WebCore::EditorClientWin::isContinuousSpellCheckingEnabled): (WebCore::EditorClientWin::isGrammarCheckingEnabled): (WebCore::EditorClientWin::spellCheckerDocumentTag): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::handleMouseUp): (WebCore::EventHandler::lastEventIsMouseUp): (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::passWheelEventToSubframe): (WebCore::EventHandler::passWidgetMouseDownEventToWidget): (WebCore::EventHandler::passMousePressEventToScrollbar): (WebCore::EventHandler::shouldDragAutoNode): (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::tabsToLinks): (WebCore::Frame::setNeedsReapplyStyles): (WebCore::FrameLoader::didFirstLayout): (WebCore::FrameLoader::overrideMediaType): (WebCore::FrameLoader::createJavaAppletWidget): (WebCore::FrameLoader::redirectDataToPlugin): (WebCore::FrameLoader::getHistoryLength): (WebCore::FrameLoader::setTitle): (WebCore::FrameLoader::referrer): (WebCore::FrameLoader::saveDocumentState): (WebCore::FrameLoader::restoreDocumentState): (WebCore::FrameLoader::goBackOrForward): (WebCore::FrameLoader::historyURL): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::partClearedInBegin): (WebCore::FrameLoader::originalRequestURL): (WebCore::FrameLoader::canGoBackOrForward): (WebCore::FrameLoader::objectContentType): (WebCore::FrameLoader::createPlugin): (WebCore::FrameLoader::detachFromParent): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameView::updateBorder): (WebCore::FrameWin::bindingRootObject): (WebCore::FrameWin::canPaste): (WebCore::FrameWin::issuePasteAndMatchStyleCommand): (WebCore::FrameWin::markedTextRange): (WebCore::FrameWin::passSubframeEventToSubframe): (WebCore::FrameWin::lastEventIsMouseUp): (WebCore::FrameWin::addMessageToConsole): (WebCore::FrameWin::shouldChangeSelection): (WebCore::FrameWin::respondToChangedSelection): (WebCore::FrameWin::clearUndoRedoOperations): (WebCore::FrameWin::markMisspellingsInAdjacentWords): (WebCore::FrameWin::respondToChangedContents): (WebCore::GraphicsContext::addRoundedRectClip): (WebCore::GraphicsContext::setShadow): (WebCore::GraphicsContext::clearShadow): (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::clearRect): (WebCore::GraphicsContext::strokeRect): (WebCore::GraphicsContext::setLineWidth): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit): (WebCore::GraphicsContext::setAlpha): (WebCore::GraphicsContext::setCompositeOperation): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale): (WebCore::Icon::Icon): (WebCore::Icon::~Icon): (WebCore::Icon::newIconForFile): (WebCore::Icon::paint): (WebCore::IconDatabase::isIconExpiredForIconURL): (WebCore::IconDatabase::hasEntryForIconURL): (WebCore::IconDatabase::sharedIconDatabase): (WebCore::IconDatabase::setIconURLForPageURL): (WebCore::IconDatabase::setIconDataForIconURL): (WebCore::Image::drawTiled): (WebCore::Image::getHBITMAP): (WebCore::Path::Path): (WebCore::Path::~Path): (WebCore::Path::contains): (WebCore::Path::translate): (WebCore::Path::boundingRect): (WebCore::Path::operator=): (WebCore::Path::clear): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArcTo): (WebCore::Path::closeSubpath): (WebCore::Path::addArc): (WebCore::Path::addRect): (WebCore::Path::addEllipse): (WebCore::Path::transform): (WebCore::PlatformMouseEvent::PlatformMouseEvent): (WebCore::PlatformScrollbar::PlatformScrollbar): (WebCore::PlatformScrollbar::~PlatformScrollbar): (WebCore::PlatformScrollbar::width): (WebCore::PlatformScrollbar::height): (WebCore::PlatformScrollbar::setEnabled): (WebCore::PlatformScrollbar::paint): (WebCore::PlatformScrollbar::updateThumbPosition): (WebCore::PlatformScrollbar::updateThumbProportion): (WebCore::PlatformScrollbar::setRect): (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex): (WebCore::PlugInInfoStore::pluginCount): (WebCore::PlugInInfoStore::supportsMIMEType): (WebCore::PolicyCheck::PolicyCheck): (WebCore::PolicyCheck::clear): (WebCore::PolicyCheck::clearRequest): (WebCore::PolicyCheck::call): (WebCore::RenderThemeWin::systemFont): (WebCore::RenderThemeWin::paintMenuList): (WebCore::RenderThemeWin::adjustMenuListStyle): (WebCore::ResourceLoader::cancel): (WebCore::ScrollView::addChild): (WebCore::ScrollView::removeChild): (WebCore::ScrollView::scrollPointRecursively): (WebCore::ScrollView::inWindow): (WebCore::ScrollView::paint): (WebCore::ScrollView::wheelEvent): (WebCore::ScrollView::themeChanged): (WebCore::ScrollView::convertChildToSelf): (WebCore::ScrollView::convertSelfToChild): (WebCore::ScrollView::geometryChanged): (WebCore::ScrollView::scrollbarUnderMouse): (WebCore::ScrollView::setFrameGeometry): (WebCore::ScrollView::windowResizerRect): (WebCore::ScrollView::resizerOverlapsContent): (WebCore::TextField::selectAll): (WebCore::TextField::addSearchResult): (WebCore::TextField::selectionStart): (WebCore::TextField::hasSelectedText): (WebCore::TextField::selectedText): (WebCore::TextField::setAutoSaveName): (WebCore::TextField::checksDescendantsForFocus): (WebCore::TextField::setSelection): (WebCore::TextField::setMaxResults): (WebCore::TextField::edited): (WebCore::TextField::focusPolicy): (WebCore::TextField::TextField): (WebCore::TextField::~TextField): (WebCore::TextField::setFont): (WebCore::TextField::setAlignment): (WebCore::TextField::setWritingDirection): (WebCore::TextField::maxLength): (WebCore::TextField::setMaxLength): (WebCore::TextField::text): (WebCore::TextField::setText): (WebCore::TextField::cursorPosition): (WebCore::TextField::setCursorPosition): (WebCore::TextField::setEdited): (WebCore::TextField::setReadOnly): (WebCore::TextField::setPlaceholderString): (WebCore::TextField::setColors): (WebCore::TextField::sizeForCharacterWidth): (WebCore::TextField::baselinePosition): (WebCore::TextField::setLiveSearch): (WebCore::Widget::enableFlushDrawing): (WebCore::Widget::isEnabled): (WebCore::Widget::focusPolicy): (WebCore::Widget::disableFlushDrawing): (WebCore::Widget::removeFromParent): (WebCore::Widget::lockDrawingFocus): (WebCore::Widget::unlockDrawingFocus): (WebCore::Widget::capturingMouse): (WebCore::Widget::setCapturingMouse): (WebCore::Widget::capturingTarget): (WebCore::Widget::capturingChild): (WebCore::Widget::setCapturingChild): (WebCore::Widget::convertChildToSelf): (WebCore::Widget::convertSelfToChild): (WebCore::Widget::setParent): (WebCore::Widget::parent): (WebCore::Widget::setEnabled): (WebCore::Widget::paint): (WebCore::Widget::setIsSelected): (WebCore::Widget::invalidate): (WebCore::Widget::invalidateRect):
- platform/win/WidgetWin.cpp: (WebCore::Widget::clearFocus):
WebKit:
- COM/WebFrame.cpp: (WebFrame::initWithName): (WebFrame::loadHTMLString): (WebFrame::stopLoading): (WebFrame::reload): (WebFrame::loadDataSource): (WebFrame::didReceiveData): (WebFrame::receivedResponse): (WebFrame::receivedAllData):
- COM/WebFrame.h:
- COM/WebView.cpp: (WebView::mouseMoved): (WebView::mouseDown): (WebView::mouseUp): (WebView::mouseDoubleClick):
- WebKit.vcproj/WebKit.vcproj:
- 11:58 AM Changeset in webkit [17815] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam.
<rdar://problem/4796730> table deletion elements are serialized out if they are visible when innerHTML or a Web Archive is made
- editing/markup.cpp: (WebCore::createMarkup): disable the delete button so it's elements are not serialized into the markup
- 11:52 AM Changeset in webkit [17814] by
-
- 3 edits in trunk/WebCore
Rubberstamped by Maciej.
Making the code valgrind clean.
- 11:49 AM Changeset in webkit [17813] by
-
- 2 edits in trunk/WebKit
Reviewed by Tim.
<rdar://problem/4841123>
REGRESSION: Crash in WebCore::Range::boundaryPointsValid when replying to a mail Message
- Misc/WebNSAttributedStringExtras.m: (+[NSAttributedString _web_attributedStringFromRange:]): If the range passed in is null, return null. When this function was in the bridge, it would never get called with a null range when nothing was selected. Instead, the range would just have invalid boundary points.
- 10:35 AM Changeset in webkit [17812] by
-
- 1 edit in trunk/WebCore/editing/DeleteButtonController.h
Adding back a correct version of this assert.
- 9:59 AM Changeset in webkit [17811] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin and Tim.
<rdar://problem/4799949> REGRESSION: Crash in FrameMac::eventMayStartDrag() by clicking on a page
- page/mac/EventHandlerMac.mm: (WebCore::EventHandler::eventMayStartDrag): Add nil check of hitTest's result.innerNode().
- 9:52 AM Changeset in webkit [17810] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/4836897> Deletion rectangle disappears when multiple list items are selected
Consider the container of the selection range for deletion before asking enclosingNodeOfType().
- editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableElement):
- 9:09 AM Changeset in webkit [17809] by
-
- 6 edits in S60/branches/3.1m/WebKit
2006-11-16 spadma <Sachin.Padma@nokia.com>
Reviewed by Yongjun.
DESC: [S60] Modify Autoload Images and Objects setting to include enabling/disabling of flash.
http://bugs.webkit.org/show_bug.cgi?id=11605
- BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
- BrowserView/inc/BrowserSettingsContainer.h:
- BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
- BrowserView/src/WebKitControl.cpp: (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL):
- Plugin/src/PluginSkin.cpp: (CPluginSkin::ConstructL):
- 12:43 AM Changeset in webkit [17808] by
-
- 3 edits in trunk/WebCore
Reviewed by hyatt.
Removal of unused m_styleElement.
Nov 15, 2006:
- 11:14 PM Changeset in webkit [17807] by
-
- 4 edits in trunk/WebCore
Build fix.
Rename the items in the ContextMenuAction enum so that they don't
conflict with WebKit names.
- WebCore.xcodeproj/project.pbxproj:
- platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):
- platform/ContextMenu.h: (WebCore::): (WebCore::ContextMenuItem::ContextMenuItem):
- 10:56 PM Changeset in webkit [17806] by
-
- 4 edits in trunk/WebCore
Reviewed by Anders.
Change m_contextMenu to an OwnPtr.
- WebCore.xcodeproj/project.pbxproj:
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent):
- page/ContextMenuController.h:
- 10:50 PM Changeset in webkit [22555] by
-
- 8 edits2 copies in branches/WindowsMerge
WebCoreWin:
Reviewed by Anders.
Added new ContextMenuClient and ContextMenuController classes.
- WebCore.vcproj/WebCore.vcproj: Added new files.
- platform/win/ContextMenuWin.cpp: Added method implementations Beth forgot to check in in r11129. (WebCore::ContextMenu::itemCount): (WebCore::ContextMenu::appendItem):
WebKitWin:
Reviewed by Anders.
Added new WebContextMenuClient class, and moved context menu-related
code there from WebChromeClient.
- WebChromeClient.cpp: (WebChromeClient::setResizable):
- WebChromeClient.h:
- WebContextMenuClient.cpp: Added. (WebContextMenuClient::create): (WebContextMenuClient::WebContextMenuClient): (WebContextMenuClient::ref): (WebContextMenuClient::deref): (WebContextMenuClient::addCustomContextMenuItems):
- WebContextMenuClient.h: Added.
- WebKit.vcproj/WebKit.vcproj: Added new files.
- WebView.cpp: (WebView::initWithFrame):
- 10:43 PM Changeset in webkit [17805] by
-
- 15 edits5 copies in trunk
WebCore:
Reviewed by Anders.
Add new ContextMenuController and ContextMenuClient classes, and move
context menu responsibilities from Chrome and ChromeClient to them.
- WebCore.exp:
- WebCore.xcodeproj/project.pbxproj: Add new files to project, and alphabetize some others.
- page/Chrome.cpp: Remove context menu-related code.
- page/Chrome.h: Ditto.
- page/ChromeClient.h:
- page/ContextMenuClient.h: Added.
- page/ContextMenuController.cpp: Added. (WebCore::ContextMenuController::ContextMenuController): (WebCore::ContextMenuController::~ContextMenuController): (WebCore::ContextMenuController::handleContextMenuEvent): (WebCore::ContextMenuController::contextMenuActionSelected):
- page/ContextMenuController.h: Added. (WebCore::ContextMenuController::client):
- page/Page.cpp: Every Page now has a ContextMenuController. (WebCore::Page::Page):
- page/Page.h: Made m_dragCaretController and m_chrome objects instead of pointers to objects. (WebCore::Page::contextMenuController):
- platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Removed the call to Chrome to ask the delegate to add its menu items, and moved the code from the static addDefaultItems function into this method.
- platform/ContextMenu.h: (WebCore::ContextMenu::show): Added an empty method body since this method is now called from ContextMenuController (although no one calls into ContextMenuController yet, so it's OK for this to be empty). (WebCore::ContextMenu::hide): Ditto.
WebKit:
Reviewed by Anders.
Added new WebContextMenuClient class to act as WebCore's ChromeClient,
and moved context menu-related code there from WebChromeClient.
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
- WebCoreSupport/WebContextMenuClient.h: Added. (WebContextMenuClient::webView):
- WebCoreSupport/WebContextMenuClient.mm: Added. (WebContextMenuClient::create): (WebContextMenuClient::WebContextMenuClient): (WebContextMenuClient::ref): (WebContextMenuClient::deref): (WebContextMenuClient::addCustomContextMenuItems):
- WebKit.xcodeproj/project.pbxproj: Added new files.
- WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]):
- 9:53 PM Changeset in webkit [17804] by
-
- 1 edit in trunk/WebCore/editing/DeleteButtonController.h
Removing this assert until I can look into the problem further.
- 8:23 PM Changeset in webkit [17803] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin.
Add null checks on the node filter, they can be null if no filter was passed to the respective
create functions.
- bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::mark):
- bindings/js/JSTreeWalkerCustom.cpp: (WebCore::JSTreeWalker::mark):
- 7:13 PM Changeset in webkit [22554] by
-
- 3 edits in branches/WindowsMerge/WebCore
Reviewed by Anders Carlsson.
Fixed flash of plug-in content outside its containing iframe while
scrolling the iframe.
The problem was that the plug-in would draw between our call to MoveWindow
and our call to SetWindowRgn. The solution here is to lock all updates in
the plug-in's HWND until we've called both MoveWindow and SetWindowRgn.
Tested with Quicktime and Flash.
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateHwnd): (WebCore::PluginViewWin::setFrameGeometry): (WebCore::PluginViewWin::geometryChanged):
- plugins/win/PluginViewWin.h: Removed bogus invalidate parameter to updateHwnd.
- 7:07 PM Changeset in webkit [17802] by
-
- 4 edits in trunk/WebCore
2006-11-15 Oliver Hunt <oliver@apple.com>
Reviewed by Anders.
Allow <embed> and <object> tags to include non-plugin
content when plugins are disabled
Fixes <rdar://problems/4839488>
- html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::rendererIsNeeded):
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::rendererIsNeeded):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject):
- 6:34 PM Changeset in webkit [17801] by
-
- 2 edits in trunk/WebCore
Build fix. Another type problem that I don't see locally.
- rendering/RenderSlider.cpp: (WebCore::RenderSlider::setPositionFromValue):
- 6:24 PM Changeset in webkit [17800] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam.
Adding MathExtras header.
- rendering/RenderSlider.cpp:
- 6:00 PM Changeset in webkit [17799] by
-
- 5 edits in trunk/WebCore
Reviewed by Harrison.
<rdar://problem/4832894> Crash deleting an element inside a list while deletion rectangle is visible (compareBoundaryPoints)
- Disable and hide the deletion UI for each editing command. This prevents editing commands from being affected by the deletion UI elements we insert. The deletion UI is then shown after the editing commands are completely done.
- Multiple calls to DeleteButtonController's disable() needed to be paired with the same number of enable() calls before the deletion UI is enabled again. This allows for nested editing commands to be called without thrashing the deletion UI.
- Make sure the the renderers are currently reflecting the latest style changes, so call updateLayoutIgnorePendingStylesheets().
- editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::DeleteButtonController): (WebCore::isDeletableElement): (WebCore::DeleteButtonController::respondToChangedSelection): check the enabled state (WebCore::DeleteButtonController::respondToChangedContents): check the enabled state (WebCore::DeleteButtonController::show): call isDeletableElement() to make sure the element is allowed (WebCore::DeleteButtonController::deleteTarget): check the enabled state
- editing/DeleteButtonController.h: (WebCore::DeleteButtonController::disable): (WebCore::DeleteButtonController::enable): (WebCore::DeleteButtonController::enabled):
- editing/EditCommand.cpp: (WebCore::EditCommand::apply): hide and disable the deletion UI, then show at the end (WebCore::EditCommand::unapply): ditto (WebCore::EditCommand::reapply): ditto
- 5:46 PM Changeset in webkit [22553] by
-
- 3 edits in branches/WindowsMerge/WebCore
Reviewed by Adam.
Adding RenderSlider class, and removing DeprecatedSlider and Slider classes.
- WebCore.vcproj/WebCore.vcproj:
- platform/win/TemporaryLinkStubs.cpp:
- 5:42 PM Changeset in webkit [17798] by
-
- 20 edits2 adds4 deletes in trunk
LayoutTests:
Reviewed by Adam.
Updating results for new slider implementation.
- fast/forms/input-appearance-height-expected.checksum:
- fast/forms/input-appearance-height-expected.png:
- fast/forms/input-appearance-height-expected.txt:
WebCore:
Reviewed by Adam.
New implementation of slider control.
- WebCore.xcodeproj/project.pbxproj: Removed DeprecatedSlider and Slider classes, added RenderSlider class.
- rendering/DeprecatedSlider.cpp: Removed.
- rendering/DeprecatedSlider.h: Removed.
- platform/Slider.h: Removed.
- platform/mac/SliderMac.mm: Removed.
- platform/win/TemporaryLinkStubs.cpp:
- css/CSSSelector.h: (WebCore::CSSSelector::): Added PseudoElement for thumb, PseudoSliderThumb.
- css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType): Added code for "-webkit-slider-thumb".
- css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):
- rendering/RenderStyle.cpp: (WebCore::): (WebCore::pseudoBit):
- rendering/RenderStyle.h: (WebCore::RenderStyle::):
- css/html4.css: Added style for input[type="range"] and input[type="range"]::-webkit-slider-thumb
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::createRenderer): Create RenderSlider for input type="range" elements. (WebCore::HTMLInputElement::defaultEventHandler): Allow the renderer to forward events, and set thumb position when click occurs on the track.
- page/EventHandler.cpp: Added concept of a node that will capture all mouse events. This will be used by the slider thumb, so it can continue to capture mouse move events during the drag, even though those events aren't directly over the slider. (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::setCapturingMouseEventsNode): (WebCore::EventHandler::dispatchMouseEvent): If the capturingMouseEventsNode is set, then dispatch all mouse events to that node.
- page/EventHandler.h:
- rendering/RenderSlider.cpp: Added. (WebCore::HTMLSliderThumbElement::isShadowNode): (WebCore::HTMLSliderThumbElement::shadowParentNode): (WebCore::HTMLSliderThumbElement::inDragMode): Keeps track of whether or not the thumb is in drag mode. (WebCore::HTMLSliderThumbElement::HTMLSliderThumbElement): (WebCore::HTMLSliderThumbElement::defaultEventHandler): Handles positioning of slider thumb during drag. (WebCore::RenderSlider::RenderSlider): (WebCore::RenderSlider::~RenderSlider): (WebCore::RenderSlider::baselinePosition): (WebCore::RenderSlider::calcMinMaxWidth): (WebCore::RenderSlider::setStyle): (WebCore::RenderSlider::createThumbStyle): (WebCore::RenderSlider::layout): Positions the thumb to be centered on the track. (WebCore::RenderSlider::updateFromElement): (WebCore::RenderSlider::mouseEventIsInThumb): (WebCore::RenderSlider::setValueForPosition): (WebCore::RenderSlider::setPositionFromValue): (WebCore::RenderSlider::positionForOffset): (WebCore::RenderSlider::valueChanged): (WebCore::RenderSlider::currentPosition): (WebCore::RenderSlider::setCurrentPosition): (WebCore::RenderSlider::trackSize): (WebCore::RenderSlider::forwardEvent): (WebCore::RenderSlider::inDragMode):
- rendering/RenderSlider.h: Added. (WebCore::RenderSlider::renderName):
- rendering/RenderTheme.cpp: Added drawing code for slider track and thumb.
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::paintBorderOnly):
(WebCore::RenderTheme::paintDecorations):
(WebCore::RenderTheme::adjustSliderTrackStyle):
(WebCore::RenderTheme::adjustSliderThumbStyle):
- rendering/RenderTheme.h: (WebCore::RenderTheme::paintSliderTrack): (WebCore::RenderTheme::paintSliderThumb):
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::RenderThemeMac): (WebCore::TrackGradientInterpolate): (WebCore::RenderThemeMac::paintSliderTrack): (WebCore::RenderThemeMac::paintSliderThumb): (WebCore::RenderThemeMac::adjustSliderTrackStyle): (WebCore::RenderThemeMac::adjustSliderThumbStyle):
- 5:36 PM Changeset in webkit [17797] by
-
- 1 edit1 add in trunk/WebCore
Reviewed by Adam.
Oops! Forgot to add this!
- platform/mac/ContextMenuMac.mm: Added. (-[MenuTarget forwardContextMenuAction:initWithContextMenu:WebCore::]): (-[MenuTarget WebCore::]): (-[MenuTarget setMenu:WebCore::]): (-[MenuTarget forwardContextMenuAction:]): (getNSMenuItem): (ContextMenu::appendItem): (ContextMenu::itemCount): (ContextMenu::insertItem): (ContextMenu::setPlatformMenuDescription):
- 5:33 PM Changeset in webkit [22552] by
-
- 5 edits1 add in branches/WindowsMerge
WebCore:
Reviewed by Adam and Beth.
Internal side of r17796.
- WebCore.vcproj/WebCore.vcproj:
- platform/win/ContextMenuWin.cpp: Added. (WebCore::ContextMenu::insertItem): (WebCore::ContextMenu::setPlatformMenuDescription):
WebKit:
Reviewed by Adam and Beth.
Internal side of r17796.
- WebChromeClient.cpp: (WebChromeClient::addCustomContextMenuItems):
- WebChromeClient.h:
- 5:27 PM Changeset in webkit [17796] by
-
- 10 edits2 adds in trunk
WebCore:
Reviewed by Adam and Beth.
Initial cut at pushing Context Menus into WebCore. Nobody actually
calls this code just yet.
- WebCore.exp:
- WebCore.xcodeproj/project.pbxproj:
- page/Chrome.cpp: (WebCore::Chrome::addCustomContextMenuItems): Use the chrome to call into addContextMenuItems on the UIDelegate.
- page/Chrome.h:
- page/ChromeClient.h:
- platform/ContextMenu.cpp: Added. (WebCore::addDefaultItems): (WebCore::ContextMenu::populate):
- platform/ContextMenu.h: Added. (WebCore::): (WebCore::ContextMenuItem::ContextMenuItem): (WebCore::ContextMenu::ContextMenu): (WebCore::ContextMenu::hitTestResult): (WebCore::ContextMenu::platformMenuDescription):
WebKit:
Reviewed by Adam & Beth.
WebKit side of first cut at engine context menus. Use the client to
call into the UIDelegate.
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::addCustomContextMenuItems):
- WebKit.xcodeproj/project.pbxproj:
- 4:56 PM Changeset in webkit [17795] by
-
- 2 edits2 moves in trunk/WebKit
Reviewed by Maciej
Quick change of files to ObjC++ for BF cache re-write
- History/WebBackForwardList.m: Removed.
- History/WebBackForwardList.mm: Added.
- History/WebHistoryItem.m: Removed.
- History/WebHistoryItem.mm: Added.
- WebKit.xcodeproj/project.pbxproj:
- 3:49 PM Changeset in webkit [17794] by
-
- 2 edits in trunk/WebCore
Reviewed by Hyatt.
- Fix for <rdar://problem/4780306> REGRESSION: clicking in textarea does not set selection at PunBB.org
- css/html4.css: Removed "-webkit-user-select: ignore" for labels.
- 2:34 PM Changeset in webkit [17793] by
-
- 7 edits in S60/trunk/WebKit
2006-11-08 spadma <Sachin.Padma@nokia.com>
Reviewed by Yongjun.
DESC: [S60] Modify Autoload Images and Objects setting to include enabling/disabling of flash.
http://bugs.webkit.org/show_bug.cgi?id=11605
- BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
- BrowserView/inc/BrowserSettingsContainer.h:
- BrowserView/inc/WebKitControl.h: (CWebKitControl::PluginHandler): (CWebKitControl::AccessPointId): (CWebKitControl::SetAccessPointId):
- BrowserView/src/BrowserSettingsContainer.cpp: (CBrowserSettingsContainer::InsertDefaultSettingsL):
- BrowserView/src/WebKitControl.cpp: (CWebKitControl::CWebKitControl): (CWebKitControl::SetBrowserSettingL): (CWebKitControl::GetBrowserSettingL):
- Plugin/src/PluginSkin.cpp: (CPluginSkin::NewL): (CPluginSkin::ConstructL):
- 2:08 PM Changeset in webkit [22551] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
2006-11-15 Ada Chan <adachan@apple.com>
Reviewed by Steve.
Fixed a bad free in DllRegisterServer.
- 1:44 PM Changeset in webkit [17792] by
-
- 4 edits in trunk/WebKit
Reviewed by Sarge
SPI addition
- WebView/WebFrame.mm: (-[WebFrame _recursive_resumeNullEventsForAllNetscapePlugins]):
- WebView/WebFrameInternal.h:
- WebView/WebFramePrivate.h:
- 12:09 PM Changeset in webkit [17791] by
-
- 5 edits in S60/branches/3.1m/WebKit
2006-11-15 spadma <Sachin.Padma@nokia.com>
Reviewed by Zalan.
DESC: [S60] Browser: The phone can't login on the html web page
http://bugs.webkit.org/show_bug.cgi?id=11602
- BrowserControl/src/WKWmlInterfaceImpl.cpp: (CWKWmlInterfaceImpl::WKWmlLoadUrlL):
- BrowserView/inc/WebKitLoader.h:
- BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
- BrowserView/src/webkitbridge.cpp: (CWebKitBridge::CreateWindowWithUrl): (CWebKitBridge::CreateChildFrameNamed): (CWebKitBridge::LoadUrlL):
- 12:06 PM Changeset in webkit [17790] by
-
- 5 edits in S60/trunk/WebKit
2006-11-15 spadma <Sachin.Padma@nokia.com>
Reviewed by Zalan.
DESC: [S60] Browser: The phone can't login on the html web page
http://bugs.webkit.org/show_bug.cgi?id=11602
- BrowserControl/src/WKWmlInterfaceImpl.cpp: (CWKWmlInterfaceImpl::WKWmlLoadUrlL):
- BrowserView/inc/WebKitLoader.h:
- BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPageL):
- BrowserView/src/webkitbridge.cpp: (CWebKitBridge::CreateWindowWithUrl): (CWebKitBridge::CreateChildFrameNamed): (CWebKitBridge::LoadUrlL):
- 12:04 PM Changeset in webkit [17789] by
-
- 3 edits in S60/trunk/WebCore
2006-11-13 ligman <joseph.ligman@nokia.com>
Reviewed by Sachin.
DESC: Valid email address cannot be identified on a page when smart text is on. Remove garbage characters from being appended to descriptor prior to calling the FindItemEngine.
http://bugs.webkit.org/show_bug.cgi?id=11589
WARNING: NO TEST CASES ADDED OR CHANGED
- bridge/WebCoreBridge.cpp: (CWebCoreBridge::~CWebCoreBridge): (CWebCoreBridge::GetNextRenderTextForSmartLinksL):
- bridge/WebCoreBridge.h:
- 11:46 AM Changeset in webkit [17788] by
-
- 3 edits in trunk/WebKit
Reviewed by Adele
<rdar://problem/4838729> - Replace mistakenly removed SPI
- WebView/WebHTMLView.m: (-[WebHTMLView _handleAutoscrollForMouseDragged:]):
- WebView/WebHTMLViewPrivate.h:
- 11:41 AM Changeset in webkit [17787] by
-
- 4 edits in trunk
Explicitly set GCC 4 for all of our projects, since the system default can be GCC 3.3.
- 11:35 AM Changeset in webkit [17786] by
-
- 3 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/4836034> REGRESSION: Hang while spell-checking (advanceToNextMisspelling)
Test:
- manual-tests/keep_spelling_markers.html: Updated to include checking for this bug.
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::advanceToNextMisspelling): it.advance() even when current string is a single space.
- 11:25 AM Changeset in webkit [22550] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
2006-11-15 Steve Falkenburg <sfalken@apple.com>
Take another pass at fixing COM registration
- WebKitDLL.cpp: (substituteGUID):
- 11:24 AM Changeset in webkit [17785] by
-
- 4 edits in trunk/WebCore
Reviewed by lamadio
Backing out macro expansion
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLElement.cpp: (WebCore::HTMLElement::isRecognizedTagName):
- ksvg2/scripts/make_names.pl:
- 10:41 AM Changeset in webkit [17784] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/4770453> VO not honoring secure edit fields in web pages
The remaining problem was the password fields would return their contents
even though they did not advertise that they could. Apparently, VoiceOver
does not read the ads.
- bridge/mac/WebCoreAXObject.mm: (isPasswordFieldElement): (-[WebCoreAXObject isPasswordField]): (-[WebCoreAXObject textMarkerForVisiblePosition:]): (-[WebCoreAXObject accessibilityAttributeValue:]): (-[WebCoreAXObject doAXStringForRange:]):
- 10:21 AM Changeset in webkit [22549] by
-
- 8 edits in branches/WindowsMerge
WebCoreWin:
2006-11-15 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
Remove some (now) obsolete methods.
- bridge/win/FrameWin.h:
- platform/win/TemporaryLinkStubs.cpp: (FrameWin::unfocusWindow): (FrameWin::getAppletInstanceForWidget): (FrameWin::issuePasteCommand): (FrameWin::respondToChangedSelection):
WebKitWin:
2006-11-15 Anders Carlsson <acarlsson@apple.com>
Reviewed by Darin.
Add an undo manager to the editor client. Make it possible for applications to invoke undo/redo.
- Interfaces/IWebView.idl:
- WebEditorClient.cpp: (WebUndoManager::WebUndoManager): (WebUndoManager::~WebUndoManager): (WebUndoManager::clearCommands): (WebUndoManager::registerCommand): (WebUndoManager::undo): (WebUndoManager::redo): (WebUndoManager::canUndo): (WebUndoManager::canRedo): (WebUndoManager::undoOrRedo): (WebEditorClient::WebEditorClient): (WebEditorUndoCommand::WebEditorUndoCommand): (WebEditorUndoCommand::execute): (WebEditorClient::registerCommandForUndo): (WebEditorClient::registerCommandForRedo): (WebEditorClient::clearUndoRedoOperations): (WebEditorClient::canUndo): (WebEditorClient::canRedo): (WebEditorClient::undo): (WebEditorClient::redo):
- WebEditorClient.h:
- WebView.cpp: (WebView::execCommand):
- 10:19 AM Changeset in webkit [17783] by
-
- 3 edits in trunk/WebCore
2006-11-13 Lou Amadio <lamadio@apple.com>
Reviewed by Darin Adler, Maciej Stachowiak
Cleanup: Expanded macros in generated files
- html/HTMLElement.cpp: (WebCore::HTMLElement::isRecognizedTagName):
- ksvg2/scripts/make_names.pl:
- 10:01 AM Changeset in webkit [22548] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
2006-11-15 Steve Falkenburg <sfalken@apple.com>
Fix bug in my last check-in preventing proper COM registration
- WebKitDLL.cpp: (DllRegisterServer):
- 9:34 AM Changeset in webkit [17782] by
-
- 4 edits in trunk/WebCore
Reviewed by Geoff.
Use Vector instead of DeprecatedPtrList.
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyBlockStyle):
- editing/BreakBlockquoteCommand.cpp:
- rendering/RenderFlow.cpp: (WebCore::RenderFlow::paintOutline):
- 9:24 AM Changeset in webkit [17781] by
-
- 5 edits in trunk/WebKit
Reviewed by Adele.
isTargetItem is used by DRT, so make it private instead of internal.
- History/WebHistoryItem.m: (-[WebHistoryItem isTargetItem]):
- History/WebHistoryItemInternal.h:
- History/WebHistoryItemPrivate.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
- 8:51 AM Changeset in webkit [22547] by
-
- 2 edits in branches/WindowsMerge/WebCore
2006-11-15 Steve Falkenburg <sfalken@apple.com>
Remove header from vcproj that no longer exists
- WebCore.vcproj/WebCore.vcproj:
- 8:40 AM Changeset in webkit [22546] by
-
- 2 edits in branches/WindowsMerge/WebCore
2006-11-15 Steve Falkenburg <sfalken@apple.com>
Fix the B&I build
- WebCore.vcproj/WebCore.vcproj:
- 7:52 AM Changeset in webkit [22545] by
-
- 4 edits in branches/WindowsMerge/WebKitWin
2006-11-15 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam.
Use separate CLSIDs for buildbot builds.
This allows independent installs of an official build (for everyday web browsing/dogfooding)
alongside a developer build (to write code, debug in Visual Studio).
- Interfaces/WebKit.idl: Add a second set of CLSIDs for builbot-based builds.
- WebKit.vcproj/Interfaces.vcproj: Add a preprocessor define BUILDBOT set to 1 for official builds, 0 otherwise (use #if to check).
- WebKitDLL.cpp: Convert CLSIDs to strings via code instead of copying string literals from elsewhere. (substituteGUID): Added. (DllUnregisterServer): Substitute CLSIDs into reg keys. (DllRegisterServer): Substitute CLSIDs into reg keys.
2006-11-15 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam.
Use separate CLSIDs for buildbot builds.
This allows independent installs of an official build (for everyday web browsing/dogfooding)
alongside a developer build (to write code, debug in Visual Studio).
- 4:21 AM Writing Layout Tests for DumpRenderTree edited by
- (diff)
- 4:15 AM Writing Layout Tests for DumpRenderTree edited by
- Added some don'ts (diff)
- 2:12 AM Changeset in webkit [22544] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
It's too early in the morning to be fixing the build.
- WebEditorClient.cpp: (WebEditorClient::selectWordBeforeMenuEvent): (WebEditorClient::isEditable):
- 2:05 AM Changeset in webkit [22543] by
-
- 3 edits in branches/WindowsMerge/WebKitWin
Build fix.
- WebEditorClient.cpp: (selectWordBeforeMenuEvent): (isEditable):
- WebEditorClient.h:
- 1:45 AM Changeset in webkit [17780] by
-
- 2 edits in trunk/WebCore
Build fix.
- page/EventHandler.h:
- 1:29 AM Changeset in webkit [17779] by
-
- 10 edits1 add in trunk/WebKit
Reviewed by Maciej
Split much of unused WebHistoryItemPrivate.h SPI into WebHistoryItemInternal.h
- History/WebBackForwardList.m:
- History/WebHistory.m:
- History/WebHistoryItem.m: (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]): (-[WebHistoryItem initWithURL:title:]): (-[WebHistoryItem visitCount]): (-[WebHistoryItem RSSFeedReferrer]): (-[WebHistoryItem setRSSFeedReferrer:]): (-[WebHistoryItem children]): (-[WebHistoryItem dictionaryRepresentation]): (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]): (+[WebHistoryItem _releaseAllPendingPageCaches]): (-[WebHistoryItem URL]): (-[WebHistoryItem target]): (-[WebHistoryItem _setLastVisitedTimeInterval:]): (-[WebHistoryItem _lastVisitedDate]): (-[WebHistoryItem targetItem]):
- History/WebHistoryItemInternal.h: Added.
- History/WebHistoryItemPrivate.h:
- WebCoreSupport/WebFrameBridge.mm:
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebFrame.mm:
- WebView/WebView.mm:
Nov 14, 2006:
- 10:57 PM Changeset in webkit [17778] by
-
- 4 edits1 delete in trunk/WebKitSite
2006-11-14 Matt Lilek <pewtermoose@gmail.com>
Reviewed by Tim Hatcher.
Moved the web developer page to the wiki, adding link to the Drosera page.
- .htaccess: Add permanent redirect to the new page on the wiki.
- contact.html: Trac numbers are no longer one off.
- nav.inc:
- webdevelopers/index.html: Removed.
- webdevelopers/webkit_version.html: Removed.
- webdevelopers/webkit_version.js: Removed.
- webdevelopers/webkit_version_xl.html: Removed.
- webdevelopers/webkit_version_xl.js: Removed.
- 10:09 PM Changeset in webkit [17777] by
-
- 15 edits in trunk
WebCore:
Reviewed by Geoff.
Moving things off the bridge and onto clients.
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::selectWordBeforeMenuEvent): (WebEditorClient::isEditable):
- WebCoreSupport/WebFrameBridge.mm:
- WebKit.xcodeproj/project.pbxproj:
WebKit:
Reviewed by Geoff.
Move things off the bridge, and move sendContextMenuEvent() from
EventHandlerMac to EventHandler.
- WebCore.exp:
- WebCore.xcodeproj/project.pbxproj:
- bridge/EditorClient.h:
- bridge/mac/WebCoreFrameBridge.h:
- editing/Editor.cpp: (WebCore::Editor::selectWordBeforeMenuEvent): (WebCore::Editor::clientIsEditable):
- editing/Editor.h:
- page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent):
- page/EventHandler.h:
- page/mac/EventHandlerMac.mm:
- 9:42 PM Changeset in webkit [17776] by
-
- 13 edits in trunk
WebCore:
Reviewed by Harrison.
<rdar://problem/4766635> Safari should never follow links in editable areas (add a WebKitEditableLinkNeverLive option)
Adds an EditableLinkNeverLive setting that will make links in editable areas always dead.
- bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings setEditableLinkBehavior:]):
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): (WebCore::HTMLAnchorElement::setActive): (WebCore::HTMLAnchorElement::isLiveLink):
- page/FrameView.cpp: (WebCore::selectCursor):
- page/Settings.h: (WebCore::Settings::):
WebKit:
Reviewed by Harrison.
<rdar://problem/4766635> Safari should never follow links in editable areas (add a WebKitEditableLinkNeverLive option)
Adds an Open Link, Open Link in New Window and Copy Link to the editing context menu.
Adds a new WebKitEditableLinkNeverLive preference value that maps to WebCore's EditableLinkNeverLive.
- DefaultDelegates/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]): (-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultUIDelegate requestWithURL:includingReferrerFromFrame:]): (-[WebDefaultUIDelegate openNewWindowWithURL:element:]): (-[WebDefaultUIDelegate openLink:]):
- English.lproj/Localizable.strings:
- WebKit.exp:
- WebView/WebPreferences.m: (-[WebPreferences editableLinkBehavior]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebUIDelegatePrivate.h:
- 9:28 PM WebKit Team edited by
- (diff)
- 9:17 PM Changeset in webkit [17775] by
-
- 2 edits in trunk/WebCore
2006-11-14 Mark Rowe <bdash@webkit.org>
Reviewed by Oliver.
Build fix
- bindings/scripts/CodeGenerator.pm:
- 9:06 PM Changeset in webkit [17774] by
-
- 4 edits in trunk
WebCore:
Turns out I wasn't forcing DWARF on the world at all,
it's now the default!
- WebCore.xcodeproj/project.pbxproj:
WebKit:
Turns out I wasn't forcing DWARF on the world at all,
it's now the default!
- WebKit.xcodeproj/project.pbxproj:
- 9:01 PM Changeset in webkit [17773] by
-
- 4 edits in trunk
WebCore:
I must stop trying to force DWARF on the world.
- WebCore.xcodeproj/project.pbxproj:
WebKit:
I must stop trying to force DWARF on the world.
- WebKit.xcodeproj/project.pbxproj:
- 7:52 PM Changeset in webkit [17772] by
-
- 14 edits4 adds in trunk
LayoutTests:
Reviewed by harrison
<rdar://problem/4806874>
Missing background image after paste
Checking in new expected results for fixes:
- editing/inserting/insert-3851164-fix-expected.checksum:
- editing/inserting/insert-3851164-fix-expected.png:
- editing/selection/drag-in-iframe-expected.checksum:
- editing/selection/drag-in-iframe-expected.png:
Same, but also removing an outdated comment about a bug:
- editing/pasteboard/paste-text-019-expected.checksum:
- editing/pasteboard/paste-text-019-expected.png:
- editing/pasteboard/paste-text-019-expected.txt:
- editing/pasteboard/paste-text-019.html:
Added:
- editing/pasteboard/4806874-expected.checksum: Added.
- editing/pasteboard/4806874-expected.png: Added.
- editing/pasteboard/4806874-expected.txt: Added.
- editing/pasteboard/4806874.html: Added.
Equivalent render trees:
- editing/inserting/insert-3907422-fix-expected.txt:
- editing/pasteboard/paste-text-011-expected.txt:
- editing/pasteboard/paste-text-015-expected.txt:
WebCore:
Reviewed by harrison
<rdar://problem/4806874>
Missing background image after paste
- editing/markup.cpp: (WebCore::createMarkup): If the body is fully selected, add a div with its CSS properties to the markup. Migrated a use of enclosingBlockFlowElement to enclosingBlock to fix an infinite loop when pasting <div><input></div>.
- 7:20 PM Changeset in webkit [17771] by
-
- 2 edits in trunk/WebCore
2006-11-14 Anders Carlsson <acarlsson@apple.com>
Reviewed by Adam.
Add Undo/Redo to execCommand.
- editing/Editor.cpp: (WebCore::execRedo): (WebCore::execUndo): (WebCore::canRedo): (WebCore::canUndo): (WebCore::CommandEntry::):
- 7:16 PM WikiStart edited by
- forgot a page (diff)
- 7:15 PM WikiStart edited by
- linking to the pages I added (diff)
- 7:12 PM WebDevelopers created by
- Web developer oriented resources
- 7:12 PM DetectingWebKit created by
- Moved this from the website
- 7:12 PM Drosera created by
- Some rough Drosera documentation
- 7:00 PM WebKit Team edited by
- (diff)
- 6:59 PM WebKit Team edited by
- (diff)
- 6:52 PM WebKit Team edited by
- (diff)
- 6:45 PM WebKit Team edited by
- Clean up a few cobwebs (diff)
- 5:40 PM Changeset in webkit [22542] by
-
- 1 edit in branches/WindowsMerge/WebCore/ChangeLog
Fixed reviewer name (Anders).
- 5:34 PM Changeset in webkit [22541] by
-
- 8 edits3 adds in branches/WindowsMerge
WebCoreWin:
Reviewed by NOBODY (OOPS!).
- update for creation of EventHandler
- WebCore.vcproj/WebCore.vcproj: Added EventHandler.cpp/h/Win.cpp.
- bridge/win/FrameWin.h: Moved virtual functions lastEventIsMouseUp, tabsToLinks, and tabsToAllControls to EventHandler.
- bridge/win/FrameWin.cpp: Ditto.
- bridge/win/FrameViewWin.cpp: Moved passMousePressEventToSubframe and similar functions to EventHandler.
- page/win/EventHandlerWin.cpp: Added. Code from FrameViewWin and FrameWin.
- platform/win/PlatformScrollBarWin.cpp: (WebCore::PlatformScrollbar::handleMouseReleaseEvent): Call the setMousePressed function in its new home in EventHandler.
- platform/win/TemporaryLinkStubs.cpp: Moved lastEventIsMouseUp stub to EventHandler.
WebKitWin:
Reviewed by Anders.
- update for creation of EventHandler
- WebView.cpp: (WebView::handleMouseEvent): Call methods now moved to EventHandler. (WebView::mouseWheel): Ditto. (WebView::elementAtPoint): Ditto.
- 5:29 PM Changeset in webkit [17770] by
-
- 43 edits5 adds1 delete in trunk
WebCore:
Reviewed by Anders.
- created EventHandler class, moved event handling code from both Frame and FrameView in there
- added ScrollTypes.h header so you can include the scroller-related enums without all of Scrollbar.h
- page/EventHandler.cpp: Added.
- page/EventHandler.h: Added.
- page/mac/EventHandlerMac.mm: Added.
- platform/ScrollBarMode.h: Removed.
- platform/ScrollTypes.h: Added.
- WebCore.exp:
- WebCore.xcodeproj/project.pbxproj:
- bridge/mac/FrameMac.h:
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::FrameMac): (WebCore::FrameMac::~FrameMac): (WebCore::FrameMac::bridgeForWidget): (WebCore::FrameMac::imageFromRect):
- bridge/mac/FrameViewMac.mm:
- bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge scrollOverflowInDirection:granularity:]): (-[WebCoreFrameBridge nextKeyView]): (-[WebCoreFrameBridge previousKeyView]): (-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]): (-[WebCoreFrameBridge _visiblePositionForPoint:]): (-[WebCoreFrameBridge dragOperationForDraggingInfo:]): (-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): (-[WebCoreFrameBridge concludeDragForDraggingInfo:]): (-[WebCoreFrameBridge dragSourceMovedTo:]): (-[WebCoreFrameBridge dragSourceEndedAt:operation:]):
- dom/Document.cpp: (WebCore::Document::hoveredNodeDetached):
- dom/Element.h:
- dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler):
- editing/SelectionController.cpp: (WebCore::SelectionController::SelectionController):
- editing/SelectionController.h: (WebCore::SelectionController::setCaretBlinkingSuspended): (WebCore::SelectionController::isCaretBlinkingSuspended):
- html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::isKeyboardFocusable):
- html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::setFocus):
- html/HTMLFrameElementBase.h:
- html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::isKeyboardFocusable):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler):
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): (WebCore::FrameLoader::open):
- page/Frame.cpp: (WebCore::Frame::caretBlinkTimerFired): (WebCore::Frame::frameForWidget): (WebCore::Frame::eventHandler): (WebCore::Frame::setProhibitsScrolling): (WebCore::FramePrivate::FramePrivate):
- page/Frame.h:
- page/FramePrivate.h:
- page/FrameView.cpp: (WebCore::FrameViewPrivate::FrameViewPrivate): (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::FrameView): (WebCore::FrameView::~FrameView): (WebCore::FrameView::clear): (WebCore::FrameView::adjustViewSize): (WebCore::FrameView::addRepaintInfo): (WebCore::FrameView::layout): (WebCore::FrameView::scrollPointRecursively): (WebCore::FrameView::setContentsPos): (WebCore::FrameView::scheduleRelayoutOfSubtree): (WebCore::FrameView::scheduleEvent): (WebCore::FrameView::updateOverflowStatus): (WebCore::FrameView::dispatchScheduledEvents): (WebCore::FrameView::windowClipRectForLayer): (WebCore::FrameView::handleMouseMoveEvent): (WebCore::FrameView::handleMouseReleaseEvent):
- page/FrameView.h:
- page/PageState.cpp: (WebCore::PageState::PageState): (WebCore::PageState::restore):
- page/PageState.h:
- platform/ScrollBar.h:
- platform/ScrollView.h:
- platform/mac/ClipboardMac.mm:
- platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show):
- platform/mac/SliderMac.mm: (-[WebCoreSlider becomeFirstResponder]): (-[WebCoreSlider nextKeyView]): (-[WebCoreSlider previousKeyView]): (-[WebCoreSlider canBecomeKeyView]): (Slider::focusPolicy):
- platform/mac/WebCoreTextField.mm: (-[WebCoreTextFieldController textView:shouldHandleEvent:]): (-[WebCoreTextFieldController setHasFocus:]): (-[WebCoreSearchField nextKeyView]): (-[WebCoreSearchField previousKeyView]): (-[WebCoreSearchFieldCell _addStringToRecentSearches:]):
- platform/mac/WidgetMac.mm: (WebCore::Widget::hasFocus): (WebCore::Widget::clearFocus):
- rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::setResizing):
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): (WebCore::RenderLayer::resize): (WebCore::RenderLayer::updateOverflowStatus):
- rendering/RenderLayer.h:
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::autoscroll):
- rendering/RenderObject.cpp: (WebCore::RenderObject::draggableNode): (WebCore::RenderObject::destroy):
- rendering/RenderObject.h: (WebCore::RenderObject::RepaintInfo::RepaintInfo):
- rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::viewCleared):
WebKit:
Reviewed by Anders.
- update for creation of EventHandler
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::actionDictionary):
- WebView/WebHTMLView.m: (-[WebHTMLView _updateMouseoverWithEvent:]): (-[NSArray menuForEvent:]): (-[NSArray scrollWheel:]): (-[NSArray acceptsFirstMouse:]): (-[NSArray shouldDelayWindowOrderingForEvent:]): (-[NSArray mouseDown:]): (-[NSArray mouseDragged:]): (-[NSArray mouseUp:]): (-[NSArray keyDown:]): (-[NSArray keyUp:]): (-[NSArray performKeyEquivalent:]): (-[WebHTMLView elementAtPoint:allowShadowContent:]):
- 5:21 PM Changeset in webkit [17769] by
-
- 2 edits in trunk/WebKit
Fix build for real this time.
- WebCoreSupport/WebEditorClient.mm: (-[WebEditCommand initWithEditCommand:WebCore::]): (-[WebEditCommand dealloc]): (-[WebEditCommand finalize]): (+[WebEditCommand commandWithEditCommand:]): (-[WebEditCommand command]):
- 5:07 PM Changeset in webkit [17768] by
-
- 2 edits in trunk/WebKit
2006-11-14 Anders Carlsson <acarlsson@apple.com>
Try fixing the build.
- WebCoreSupport/WebEditorClient.mm: (-[WebEditorUndoTarget undoEditing:]): (-[WebEditorUndoTarget redoEditing:]):
- 5:07 PM Changeset in webkit [22540] by
-
- 3 edits in branches/WindowsMerge/WebKitWin
2006-11-14 Anders Carlsson <acarlsson@apple.com>
Build fix.
- WebEditorClient.cpp: (WebEditorClient::registerCommandForUndo): (WebEditorClient::registerCommandForRedo): (WebEditorClient::clearUndoRedoOperations): (WebEditorClient::canUndo): (WebEditorClient::canRedo): (WebEditorClient::undo): (WebEditorClient::redo):
- WebEditorClient.h:
- 4:36 PM Changeset in webkit [17767] by
-
- 19 edits2 deletes in trunk
WebCore:
Reviewed by Darin.
Let the editor client handle undo/redo.
- WebCore.exp:
- WebCore.xcodeproj/project.pbxproj:
- bridge/EditorClient.h:
- bridge/mac/FrameMac.h:
- bridge/mac/FrameMac.mm: (WebCore::FrameMac::canUndo): (WebCore::FrameMac::canRedo):
- bridge/mac/WebCoreEditCommand.h: Removed.
- bridge/mac/WebCoreEditCommand.mm: Removed.
- bridge/mac/WebCoreFrameBridge.h:
- bridge/mac/WebCoreFrameBridge.mm:
- editing/Editor.cpp: (WebCore::Editor::appliedEditing): (WebCore::Editor::unappliedEditing): (WebCore::Editor::reappliedEditing):
- editing/JSEditor.cpp:
- loader/FrameLoader.cpp: (WebCore::FrameLoader::closeURL):
- page/Frame.cpp:
- page/Frame.h:
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::updateFromElement):
WebKit:
Reviewed by Darin.
Move undo/redo handling into WebEditorClient.
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm: (WebEditorClient::WebEditorClient): (WebEditorClient::~WebEditorClient): (-[WebEditCommand initWithEditCommand:WebCore::]): (-[WebEditCommand dealloc]): (-[WebEditCommand finalize]): (+[WebEditCommand commandWithEditCommand:]): (-[WebEditCommand command]): (-[WebEditorUndoTarget undoEditing:]): (-[WebEditorUndoTarget redoEditing:]): (undoNameForEditAction): (WebEditorClient::registerCommandForUndoOrRedo): (WebEditorClient::registerCommandForUndo): (WebEditorClient::registerCommandForRedo): (WebEditorClient::clearUndoRedoOperations): (WebEditorClient::canUndo): (WebEditorClient::canRedo): (WebEditorClient::undo): (WebEditorClient::redo):
- WebCoreSupport/WebFrameBridge.mm:
- WebKit.xcodeproj/project.pbxproj:
- 3:02 PM Web Inspector edited by
- Add how to use with OmniWeb (diff)
- 2:33 PM Changeset in webkit [17766] by
-
- 5 edits in trunk/WebCore
Reviewed and landed by Brady
Fix Qt/Linux build.
- ChangeLog:
- loader/qt/FrameLoaderQt.cpp: (WebCore::FrameLoader::submitForm):
- platform/network/qt/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::add):
- platform/qt/FrameQtClient.cpp: (WebCore::FrameQtClientDefault::submitForm):
- platform/qt/FrameQtClient.h:
- 1:51 PM Changeset in webkit [17765] by
-
- 1 edit in trunk/WebKitSite/nav.inc
Fixing the site.
- 1:45 PM Changeset in webkit [17764] by
-
- 1 copy in tags/Safari-521.30.1b
New tag.
- 1:44 PM Changeset in webkit [17763] by
-
- 3 edits in trunk/WebKitSite
2006-11-14 Mark Rowe <bdash@webkit.org>
Reviewed by Tim Hatcher.
http://bugs.webkit.org/show_bug.cgi?id=9529
Bug 9529: Navigation HTML duplicated on webkit.org web site
- blog/wp-content/themes/webkit/sidebar.php: Include navigation from nav.inc rather than duplicating it here.
- nav.inc: Generate WordPress archive list if included from within WordPress.
- 11:56 AM Changeset in webkit [22539] by
-
- 2 edits in branches/WindowsMerge/WebKitWin
Reviewed by Anders
Additional tweek to the FormData change
- WebFrame.cpp: (WebFrame::loadDataSource):
- 11:52 AM Changeset in webkit [17762] by
-
- 9 edits in trunk/WebCore
Reviewed by Anders
Cleanup of my patch last night and merging with aroben-style changes from this morning
(More ref-counted FormData stuff)
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm):
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::postData):
- platform/network/ResourceHandle.h:
- platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::setHTTPBody):
- platform/network/mac/FormDataStreamMac.h:
- platform/network/mac/FormDataStreamMac.mm: (WebCore::getStreamFormDatas): (WebCore::formCreate): (WebCore::formFinalize): (WebCore::setHTTPBody): (WebCore::httpBodyFromStream):
- platform/network/mac/ResourceRequestMac.mm: (WebCore::getResourceRequest):
- 11:44 AM Changeset in webkit [22538] by
-
- 15 edits in branches/WindowsMerge/WebKitWin
WebKitWin:
Reviewed by Steve.
Replace all instances of DebugBreak() with ASSERT_NOT_REACHED() so that
it will be compiled out for Release builds.
- DOMCSSClasses.cpp:
- DOMCoreClasses.cpp:
- DOMHTMLClasses.cpp:
- WebBackForwardList.cpp:
- WebDataSource.cpp:
- WebFrame.cpp:
- WebHTMLRepresentation.cpp:
- WebHistoryItem.cpp:
- WebIconDatabase.cpp:
- WebMutableURLRequest.cpp:
- WebNotification.cpp:
- WebPreferences.cpp:
- WebScriptObject.cpp:
- WebView.cpp:
- 10:57 AM Changeset in webkit [17761] by
-
- 3 edits6 adds in trunk
2006-11-14 Rob Buis <buis@kde.org>
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11575
Bug 11575: REGRESSION: WebCore crash in CSSParser/HTMLTokenizer
Test: fast/css/css-imports.html
- css/CSSImportRule.cpp: (WebCore::CSSImportRule::insertedIntoParent): Fix the crash by testing for null pointer.
- 10:11 AM Changeset in webkit [17760] by
-
- 4 edits1 add in trunk
Reviewed by Tim H.
http://bugs.webkit.org/show_bug.cgi?id=3387
Redundant keydown, keypress, keyup events sent for arrow keys
Added another layer of ugly hacks around AppKit event dispatching.
- For arrow keys, keyDown: is invoked after performKeyEquivalent:, so had to store _private->keyDownEvent in both methods, and make it persist after leaving them.
- For Esc, AppKit calls performKeyEquivalent: with a fake event of some kind, use [NSApp currentEvent] to check for this to prevent it from being passed to WebCore.
Test: manual-tests/arrow-key-events.html
- WebView/WebHTMLView.m: (-[NSMutableDictionary dealloc]): (-[NSArray keyDown:]): (-[NSArray keyUp:]): (-[NSArray performKeyEquivalent:]):
- WebView/WebHTMLViewInternal.h:
- 10:06 AM Changeset in webkit [17759] by
-
- 5 edits in trunk/WebCore
2006-11-14 Darin Adler <Darin Adler>
Reviewed by Adam.
Fix up usages of FormData within CFNet loader code.
- platform/network/ResourceRequest.h: (WebCore::ResourceRequest::httpBody):
- platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::getStreamFormDatas): Store RefPtr<FormData>s in the streamFormDatas HashMap. (WebCore::formCreate): (WebCore::formFinalize): Removed delete because the remove() will deref and delete if necessary. (WebCore::setHTTPBody): Changed parameter to PassRefPtr. (WebCore::httpBodyFromStream):
- platform/network/cf/FormDataStreamCFNet.h: Fix declarations.
- platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::getResourceRequest):
- 7:39 AM Changeset in webkit [17758] by
-
- 4 edits in S60/trunk/WebKit
2006-11-10 yadavall <sriram.yadavalli@nokia.com>
Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: If ths phone is in Chinese mode, donot enable anti-aliasing.
http://bugzilla.opendarwin.org/show_bug.cgi?id=11569
- BrowserCore/Renderers/src/TextRendererFactory.cpp:
- 7:25 AM Changeset in webkit [17757] by
-
- 4 edits in S60/branches/3.1m/WebKit
2006-11-10 yadavall <sriram.yadavalli@nokia.com>
Reviewed by Sachin Padma (sachin.padma@nokia.com).
DESC: If ths phone is in Chinese mode, donot enable anti-aliasing.
http://bugzilla.opendarwin.org/show_bug.cgi?id=11569
- BrowserCore/Renderers/src/TextRendererFactory.cpp:
- 3:55 AM Changeset in webkit [17756] by
-
- 2 edits in trunk/WebCore
2006-11-14 Greg Jackson <gjspanner@gmail.com>
Reviewed by Darin.
Preserves any pre-existing value for WEBCORE_NAVIGATOR_PLATFORM
rather than overriding it based on platform detection.
- bindings/js/kjs_navigator.cpp:
- 2:13 AM BuildingGdk edited by
- (diff)
- 2:11 AM BuildingGdk created by