Timeline



Dec 18, 2006:

11:45 PM Changeset in webkit [18303] by hyatt
  • 2 edits in trunk/WebCore

Make sure a stroke style is set for list bullets.

Reviewed by mitz

  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
10:28 PM Changeset in webkit [22690] by adachan
  • 10 edits in branches/WindowsMerge

2006-12-18 Ada Chan <​adachan@apple.com>

Reviewed by Adam.


Fixed <rdar://4850800> Pop-up window opens with same size as parent window, and app crashes when closing pop-up

  • Corrected the height set on the max/min/restore/close buttons on the top-right of the safari win to take into account its top margin.
  • Implemented the calls we need to close window via script.
  • Added runBeforeUnloadConfirmPanelWithMessage to IWebUIDelegate.
  • implemented canRunBeforeUnloadConfirmPanel, runBeforeUnloadConfirmPanel, and closeWindowSoon in WebChromeClient
  • implemented WebView::closeWindow().

Removed scheduleClose() from FrameWin. The implementation has
been moved to Frame.cpp.

10:15 PM Changeset in webkit [18302] by adachan
  • 22 edits in trunk

2006-12-18 Ada Chan <​adachan@apple.com>

Reviewed by Adam.


Moved canRunBeforeUnloadConfirmPanel, runBeforeUnloadConfirmPanel, and closeWindowSoon
from WebCoreFrameBridge to Chrome.
Moved implementation of Frame::scheduleClose to Frame.cpp.

9:53 PM Changeset in webkit [22689] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/PopupMenuWin.cpp

Fix Boomer build bustage from Pen conversion.

9:48 PM Changeset in webkit [22688] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Alice


Fixes <rdar://4821724> - Wrong site icon displays for sites who don't actually have an icon


We judged whether or not a site has an icon based on whether or not the IconDatabase returned
a valid Image.
In the case of sites without an icon, we actually get returned a valid Image with dimensions 0x0.
WebKit on OS X correctly handles this case via NSImage goodness - now we manually handle it on Windows

  • WebIconDatabase.cpp: (WebIconDatabase::iconForURL): Check the width() as an additional case to fallback to the default icon
9:30 PM Changeset in webkit [18301] by aliceli1
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Adam.

Test case for <rdar://problem/4766174> REGRESSION(r16081): Aspect eWFM: Unable to log in

  • http/tests/misc/location-test-xsl-style-sheet-expected.txt: Added.
  • http/tests/misc/location-test-xsl-style-sheet.xml: Added.
  • http/tests/misc/resources/location-test-xsl-style-sheet.xsl: Added.

WebCore:

Reviewed by Adam.

Fixed <rdar://problem/4766174> REGRESSION(r16081): Aspect eWFM: Unable to log in

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didExplicitOpen):
9:23 PM Changeset in webkit [18300] by hyatt
  • 1 edit in trunk/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

Fix Qt build bustage by removing uses of Pen and replacing with new stroke APIS.

9:22 PM Changeset in webkit [22687] by sfalken
  • 5 edits in branches/WindowsMerge/WebKitWin

2006-12-18 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.


Added loadType to IWebFramePrivate.

  • Interfaces/IWebFramePrivate.idl: Added loadType
  • WebFrame.cpp: Fixed line endings (WebFrame::loadType): Added
  • WebFrame.h: Fixed line endings
  • WebKit.vcproj/WebKit.vcproj: Moved WebLocalizableStrings.h to proper folder
9:18 PM Changeset in webkit [18299] by hyatt
  • 1 edit in trunk/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

Fix spelling error in Qt code..

9:17 PM Changeset in webkit [18298] by hyatt
  • 1 edit in trunk/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

Fix Qt build bustage by removing uses of Pen and replacing with new stroke APIS.

9:02 PM Changeset in webkit [18297] by hyatt
  • 1 edit in trunk/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

Fix Qt build bustage by removing setPlatformPen.

8:58 PM Changeset in webkit [18296] by hyatt
  • 2 edits in trunk/WebCore

Add save/restore calls around the painting of text areas on Mac, since the methods in question
alter the current fill color in CG destructively.

Reviewed by olliej

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintButton): (WebCore::RenderThemeMac::paintTextField): (WebCore::RenderThemeMac::paintTextArea): (WebCore::RenderThemeMac::paintSliderTrack): (WebCore::RenderThemeMac::paintSliderThumb):
8:31 PM Changeset in webkit [18295] by hyatt
  • 2 edits in trunk/WebCore

Fix list markers to properly stroke and fill. I screwed this up when changing how text draws.

Reviewed by olliej

  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
8:21 PM Changeset in webkit [22686] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Adam and Oliver.

<rdar://problem/4856014> Target weekly ad doesn't work.


Store the real base URL and use it for requests.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::getURLNotify): (WebCore::PluginViewWin::getURL): (WebCore::PluginViewWin::handlePost): (WebCore::PluginViewWin::PluginViewWin):
  • plugins/win/PluginViewWin.h:
8:16 PM Changeset in webkit [22685] by hyatt
  • 1 edit in branches/WindowsMerge/WebCore/platform/win/FontWin.cpp

Boomer side of pen removal changes.

8:00 PM Changeset in webkit [18294] by hyatt
  • 18 edits in trunk/WebCore

Eliminate the Pen object in favor of separate stroke variables, since most code just wants to set the
stroke color. This also makes it easier for us to push only stroke color through into CG synchronously
while leaving the others alone.

Reviewed by olliej

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContext::setStrokeThickness): (WebCore::GraphicsContext::setStrokeStyle): (WebCore::GraphicsContext::setStrokeColor): (WebCore::GraphicsContext::strokeThickness): (WebCore::GraphicsContext::strokeStyle): (WebCore::GraphicsContext::strokeColor): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeThickness):
  • platform/graphics/GraphicsContext.h: (WebCore::):
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::drawEllipse): (WebCore::GraphicsContext::drawArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::GraphicsContext::drawLineForText): (WebCore::GraphicsContext::setPlatformStrokeColor):
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::toQPenStyle): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::setPlatformStrokeStyle): (WebCore::GraphicsContext::setPlatformStrokeThickness):
  • platform/mac/FontMac.mm: (WebCore::Font::drawComplexText): (WebCore::Font::drawGlyphs):
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintDecorations):
  • rendering/InlineTextBox.cpp: (WebCore::updateTextColor): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintDecoration): (WebCore::InlineTextBox::paintMarkedTextUnderline):
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintObject):
  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:
  • rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::paint):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::drawBorderArc): (WebCore::RenderObject::drawBorder):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::paint):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint):
  • rendering/RenderText.cpp:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButton):
6:44 PM Changeset in webkit [22684] by darin
  • 2 edits in branches/WindowsMerge/WebCore
  • platform/win/FontWin.cpp: (WebCore::Font::drawGlyphs): Fix build, wrong variable name.
6:30 PM Changeset in webkit [18293] by darin
  • 7 edits in trunk/WebCore

Reviewed by Adele.

  • change DOMActivate events to be created as a part of default handling of click events instead of having the sender of the click event also send a DOMActivate event
  • fixed some edge cases in the slider thumb element handler; since this is inside a shadow DOM, it's likely none of these can arise in practice

No easy way to test the command-click part since the behavior is in Safari.
To make a test we'd have to provide JavaScript access to the modifiers passed
to the policy delegate or have some way to query the underlying event from
JavaScript.

  • dom/EventTargetNode.cpp: Change all assert to ASSERT. (WebCore::EventTargetNode::dispatchMouseEvent): Renamed some local variables for clarity. Added a RefPtr for relatedTarget since it might be deallocated by the handlers for the click event and is used in the code that creates the dblclick event. Removed the code to create a DOMActivate event, since that's now done in the default event handler for the click event. (WebCore::EventTargetNode::defaultEventHandler): Added code to check for a click event and dispatch a DOMActivate event using the click event as the underlying event. The part of this that fixes the bug is that we use the click event as the underlying event; the old code used the same underlying event as for the click event, not the click event itself. The underlying event for the click event is usually 0, since we propagate the key state to the click event instead of using an underlying event in the common case.
  • dom/Document.cpp: (WebCore::Document::defaultEventHandler): Added call to the base class's defaultEventHandler function, except in the case where the event is already handled.
  • html/HTMLInputElement.h: Removed clickX() and clickY().
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::appendFormData): Use xPos and yPos directly, so we can remove clickX() and clickY(). (WebCore::HTMLInputElement::defaultEventHandler): Removed code that calls setDefaultHandled for click events since we are just recording the x and y coordinates of the events; that's not "handling" an event, and setting the flag prevents us from calling the base class's default event handler, which is now needed to submmit the form.
  • rendering/RenderSlider.cpp: (WebCore::HTMLSliderThumbElement::defaultEventHandler): Added some missing isMouseEvent checks in code that casts to a MouseEvent. Added check document()->frame() in code that manipulates the frame so that fake events, which might happen when there's no frame, can't cause a crash. Added an m_inDragMode check so we don't try to handle mouseup events when we are not handling a drag. Remove the setDefaultHandled call from the mousemove case, because mousemove events are observed, and not "handled" in the "nobody else should look at this event" sense. Added a call to the base class's default event handler, and some return statements so that we won't call it when the event has been handled.
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::defaultEventHandler): Removed an unneeded "return" for a function that has no return value.
6:04 PM Changeset in webkit [18292] by bdash
  • 2 edits in trunk/LayoutTests

2006-12-18 Mark Rowe <​bdash@webkit.org>

Reviewed by Brady.

Bug 11870: Bug 11866 caused layout test regression in fast/forms/input-value.html
​http://bugs.webkit.org/show_bug.cgi?id=11870

  • fast/forms/input-value-expected.txt: Updated results.
5:38 PM Changeset in webkit [18291] by bdakin
  • 4 edits
    4 adds in trunk

WebCore:

Fix for <rdar://problem/4749770> WebCore crashes on a blog website
in WebCore::InlineBox::root() + 6

We null-check inlineBoxWrapper everywhere else in the code except
for these 3 spots. This patch adds them in. Only one of the checks
is required to fix the crash. What we render for the test case now
matches shipping Safari, but still seems wrong because we do not
match Firefox. I will file a follow-up about the rendering problem.

  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::positionListMarker): This is the required null-check.
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::setSelectionState): Null-check for safety. (WebCore::RenderListMarker::selectionRect): Same.

LayoutTests:

Reviewed by Adele.

Test case for <rdar://problem/4749770> WebCore crashes on a blog
website in WebCore::InlineBox::root() + 6

  • fast/lists/inlineBoxWrapperNullCheck-expected.checksum: Added.
  • fast/lists/inlineBoxWrapperNullCheck-expected.png: Added.
  • fast/lists/inlineBoxWrapperNullCheck-expected.txt: Added.
  • fast/lists/inlineBoxWrapperNullCheck.html: Added.
5:26 PM Changeset in webkit [22683] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Boomer side of my changes for filling/stroking of text.

Reviewed by olliej

  • platform/win/FontWin.cpp: (WebCore::Font::drawGlyphs):
5:18 PM Changeset in webkit [18290] by hyatt
  • 14 edits in trunk/WebCore

Fix performance regression caused by adding setting of stroke colors as well as fill colors to every font drawing
call on Mac. Fix is rather involved:

(1) Fill color is now updated in CG synchronously. There is no more delay in the push. I used the model that
Qt added for this, setPlatformFillColor, so we're the same now.

(2) Text was being drawn using the pen color, which is tantamount to using the stroke color. Since text in HTML
is really a fill and not a stroke, all cross-platform code that draws text has been patched to use fill instead
of the pen.

(3) Added a new API to GraphicsContext to set the text drawing mode to any combination of fill/stroke/clip.
Ports should implement setPlatformTextDrawingMode or just query the mode in their drawGlyphs/drawComplexText
method on their Font class to get the new functionality.

(4) InlineTextBox will set the fill and stroke colors appropriately now rather than always assuming fill.

(5) Fixed a bug in GraphicsContextCG where fillRectWithColor was updating the CG fill color in the state object
as a side effect, creating a mismatch between CG's fill color and the stored cross-platform fill color.

Reviewed by olliej

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState): (WebCore::GraphicsContext::textDrawingMode): (WebCore::GraphicsContext::setTextDrawingMode): (WebCore::GraphicsContext::setPlatformTextDrawingMode): (WebCore::GraphicsContext::setPlatformPen):
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::setPlatformTextDrawingMode): (WebCore::GraphicsContext::setPlatformFillColor):
  • platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::SVGPaintServerGradient::teardown): (WebCore::SVGPaintServerGradient::setup):
  • platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp: (WebCore::SVGPaintServerPattern::setup): (WebCore::SVGPaintServerPattern::teardown):
  • platform/graphics/svg/cg/SVGPaintServerSolidCg.cpp: (WebCore::SVGPaintServerSolid::setup):
  • platform/mac/FontMac.mm: (WebCore::Font::drawComplexText): (WebCore::Font::drawGlyphs):
  • platform/mac/WebCoreTextRenderer.mm: (WebCoreDrawTextAtPoint):
  • rendering/EllipsisBox.cpp: (WebCore::EllipsisBox::paint):
  • rendering/InlineTextBox.cpp: (WebCore::correctedTextColor): (WebCore::updateTextColor): (WebCore::InlineTextBox::paint): (WebCore::InlineTextBox::paintSelection): (WebCore::InlineTextBox::paintMarkedTextBackground): (WebCore::InlineTextBox::paintTextMatchMarker):
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::paint):
3:28 PM Changeset in webkit [18289] by bdash
  • 3 edits
    5 adds in trunk

2006-12-18 Dex Deacon <​occupant4@gmail.com>

Reviewed by Maciej.

Bug 11760: Animated GIFs with offsets crash WebKit
​http://bugs.webkit.org/show_bug.cgi?id=11760

  • platform/image-decoders/gif/GIFImageDecoder.cpp: ensure we don't write past the end of the image buffer when the offset is nonzero. also fix the way we composite frames when animating. (WebCore::GIFImageDecoder::initFrameBuffer): (WebCore::GIFImageDecoder::haveDecodedRow):

2006-12-18 Dex Deacon <​occupant4@gmail.com>

Reviewed by Maciej.

Layout tests for ​http://bugs.webkit.org/show_bug.cgi?id=11760

  • ChangeLog:
  • fast/images/animated-gif-with-offsets-expected.txt: Added.
  • fast/images/animated-gif-with-offsets.html: Added.
  • fast/images/resources/animated-gif-with-offsets.gif: Added.
3:22 PM Changeset in webkit [18288] by bdash
  • 3 edits
    4 adds in trunk

2006-12-18 Kirby White <​KWhiteRight@gmail.com>

Reviewed by Darin.

Changed hidden input controls to reset to their initial values
when the form is reset. Also added layout tests for resetting
other input controls.

Fixes ​http://bugs.webkit.org/show_bug.cgi?id=11866

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::storesValueSeparateFromAttribute):

2006-12-18 Kirby White <​KWhiteRight@gmail.com>

Reviewed by Darin.

Layout tests for ​http://bugs.webkit.org/show_bug.cgi?id=11866

  • fast/dom/HTMLInputElement/input-checked-reset-expected.txt: Added.
  • fast/dom/HTMLInputElement/input-checked-reset.html: Added.
  • fast/dom/HTMLInputElement/input-text-reset-expected.txt: Added.
  • fast/dom/HTMLInputElement/input-text-reset.html: Added.
2:57 PM Changeset in webkit [22682] by aliceli1
  • 4 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

<rdar://problem/4853363> hook up various deletion-related functions in WebView

  • WebCore.vcproj/WebCore.vcproj: Added file EditorDeleteAction.h

WebKitWin:

Reviewed by Adam.

<rdar://problem/4853363> hook up various deletion-related functions in WebView

  • WebView.cpp: (WebView::execCommand): Removed the case for ForwardDelete, since it shouldn't be handled there (WebView::deleteSelection): Implemented (WebView::copy): (WebView::cut): (WebView::paste): (WebView::delete_): Use the Editor's execCommand for these editor-responsible functions
2:49 PM Changeset in webkit [18287] by aliceli1
  • 1 edit
    1 add in trunk/WebCore

Oops forgot a file.

  • editing/EditorDeleteAction.h: Added. (WebCore::):
2:47 PM Changeset in webkit [18286] by aliceli1
  • 11 edits in trunk

WebCore:

Reviewed by Adam.

Have the Editor handle deletion instead of WebHTMLView

  • WebCore.exp: Exposed Editor::deleteWithDirection and ::deleteRange()
  • WebCore.xcodeproj/project.pbxproj: Added EditorDeleteAction.h
  • editing/Editor.cpp: (WebCore::Editor::deleteRange): (WebCore::Editor::deleteWithDirection): Implemented

(WebCore::Editor::deleteSelectionWithSmartDelete):
Overloaded to take no params, in which case canSmartCopyOrDelete is called

(WebCore::execCopy):
(WebCore::execCut):
(WebCore::execDelete):
(WebCore::execPaste):
Call the editor instead of asking frame to cut/copy/paste/delete

(WebCore::execBackwardDelete):
(WebCore::execForwardDelete):
Call deleteWithDirection instead of just executing a TypingCommand

(WebCore::CommandEntry::):
distinguished delete (which deletes selection) from backwards delete (single character, no selection)

(WebCore::Editor::cut):
(WebCore::Editor::performDelete):
Trivial changes

  • editing/Editor.h: Added some functons. (WebCore::Editor::setStartNewKillRingSequence): (WebCore::Editor::propogateDOMException): (WebCore::Editor::addToKillRing):
  • editing/mac/EditorMac.mm: Factored out support for Kill Rings to this file
  • platform/mac/PasteboardMac.mm: Trivial change

WebKit:

Reviewed by Adam.

Have the Editor handle deletion instead of WebHTMLView

  • WebKitPrefix.h: Turned on WebCore deletion
  • WebView/WebHTMLViewInternal.h: Moved ownership of startNewKillRingSequence to the WebCore::Editor
  • WebView/WebHTMLView.m: (-[NSArray becomeFirstResponder]): Use the Editor's startNewKillRingSequence flag

(-[NSArray deleteForward:]):
(-[NSArray deleteBackward:]):
(-[NSArray deleteWordForward:]):
(-[NSArray deleteWordBackward:]):
(-[NSArray deleteToBeginningOfLine:]):
(-[NSArray deleteToEndOfLine:]):
(-[NSArray deleteToBeginningOfParagraph:]):
(-[NSArray deleteToEndOfParagraph:]):
(-[NSArray deleteToMark:]):
use Editor::deleteWithDirection instead of WebHTMLView's

2:39 PM Changeset in webkit [22681] by kmccullo
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Oliver.

  • Remove CG header includes in OpenSource files
  • config.h:
  • platform/graphics/cg/GraphicsContextPlatformPrivate.h:

WebKitWin:

Reviewed by Oliver.

  • Remove CG header includes in open source files
  • WebView.cpp:
2:32 PM Changeset in webkit [18285] by kmccullo
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

  • Removed CG header include
  • platform/graphics/ImageSource.h:
2:18 PM Changeset in webkit [18284] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher

  • fixed <rdar://problem/4887764> GMAIL: Crash occurs at WebCore::Range::cloneRange() when I ctrl-click in a empty list item
  • editing/mac/EditorMac.mm: (WebCore::isRangeUngrammatical): bail out immediately for nil range (which selectionController()->toRange().get() can return). Also save some work by bailing out immediately for collapsed ranges.
1:36 PM Changeset in webkit [18283] by yongjzha
  • 2 edits in S60/branches/3.1m/WebKit

2006-12-13 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: TSW Id:ELMA-6W2CGN - Browser: Fail to upload an image again
​http://bugs.webkit.org/show_bug.cgi?id=11817

  • ResourceLoader/src/PostDataItems.cpp: (CFileDataItem::~CFileDataItem): (CFileDataItem::DataL):
1:31 PM Changeset in webkit [18282] by yongjzha
  • 3 edits in S60/branches/3.1m/WebKit

2006-12-15 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by Yongjun Zhang and Steve Winship.
DESC: TSW id:EYWG-6W7B4F: Error note "Program closed:BrowserNG" after clicking Submit button on test page
​http://bugs.webkit.org/show_bug.cgi?id=11781

  • BrowserView/inc/FormDataAutoFillStore.h:
  • BrowserView/src/FormDataAutoFillStore.cpp: (CFormDataAutoFillStore::GetDataL): (CFormDataAutoFillStore::DeleteData): (CFormDataAutoFillStore::InsertData): (CFormDataAutoFillStore::SaveData): (CFormDataAutoFillStore::CreateDatabase): (CFormDataAutoFillStore::CreateFormDataTableL):
1:28 PM Changeset in webkit [18281] by spadma
  • 6 edits in S60/branches/3.1m

2006-12-18 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Minimap and toolbar are displayed under flash content
​http://bugs.webkit.org/show_bug.cgi?id=11707

  • BrowserView/inc/WebKitToolBarInterface.h:
  • BrowserView/inc/WebKitView.h:
  • BrowserView/src/WebKitView.cpp: (CWebKitView::PageControlView): (CWebKitView::ResetFlags):
1:21 PM Changeset in webkit [18280] by yongjzha
  • 2 edits in S60/trunk/WebKit

2006-12-13 rathnasa <​sornalatha.rathnasamy@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: TSW Id:ELMA-6W2CGN - Browser: Fail to upload an image again
​http://bugs.webkit.org/show_bug.cgi?id=11817

  • ResourceLoader/src/PostDataItems.cpp: (CFileDataItem::~CFileDataItem): (CFileDataItem::DataL):
1:00 PM Changeset in webkit [18279] by spadma
  • 6 edits in S60/trunk

2006-12-18 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Minimap and toolbar are displayed under flash content
​http://bugs.webkit.org/show_bug.cgi?id=11707

  • BrowserView/inc/WebKitToolBarInterface.h:
  • BrowserView/inc/WebKitView.h:
  • BrowserView/src/WebKitView.cpp: (CWebKitView::PageControlView): (CWebKitView::ResetFlags):
12:27 PM Changeset in webkit [18278] by ap
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by Mitz.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=7170
`window.parent.[frameName].location=' fails if the target frame has not yet loaded a document

  • fast/frames/resources/set-unloaded-frame-location-1.html: Added.
  • fast/frames/resources/set-unloaded-frame-location-2.html: Added.
  • fast/frames/set-unloaded-frame-location-expected.txt: Added.
  • fast/frames/set-unloaded-frame-location.html: Added.
11:41 AM Changeset in webkit [18277] by thatcher
  • 1 copy in tags/WebKit-419/WebKit

New tag (part 2.)

11:41 AM Changeset in webkit [18276] by thatcher
  • 1 add in tags/WebKit-419

new tag (part 1.)

11:27 AM Changeset in webkit [18275] by thatcher
  • 2 edits in branches/Safari-2-0-branch/WebKit

Versioning.

10:44 AM Changeset in webkit [18274] by aliceli1
  • 2 edits in trunk/WebCore

Leopard build fix.

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded):
9:58 AM Changeset in webkit [22680] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Build fixes.

  • WebCore.vcproj/WebCore.vcproj: Removed deleted files.
  • platform/win/CursorWin.cpp: Added missing method. (WebCore::noneCursor):

Dec 17, 2006:

2:23 PM Changeset in webkit [18273] by zack
  • 2 edits in trunk/WebCore

fix compiltion, after the const changes

1:48 PM Changeset in webkit [18272] by rwlbuis
  • 1 edit
    1 add in trunk/LayoutTests

Reviewed by Eric.

Add missing checksum file, thnx to Wildfox for noticing.

1:29 PM Changeset in webkit [18271] by zimmermann
  • 6 edits in trunk

Reviewed by Eric.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=10956

Long standing regression. The old code in FontMac.mm, used set the fill/stroke
color "[nsColor(graphicsContext->pen().color()) set];", and current code only
sets the fill color. Reverting to old behaviour fixes gradient-on-stroke-of-text.

11:25 AM Changeset in webkit [18270] by ap
  • 14 edits
    1 add in trunk/WebCore

2006-12-17 Lars Naesbye Christensen <​larsnaesbye@stud.ku.dk>

Reviewed, tweaked and landed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=11798
[CSS 3] missing cursor support for 'none'

  • Resources/noneCursor.png: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSValueKeywords.in:
  • css/cssparser.cpp: Also fixed previously broken -webkit-background-composite: copy.
  • manual-tests/cursor.html:
  • page/EventHandler.cpp: (WebCore::selectCursor):
  • platform/Cursor.h:
  • platform/gdk/CursorGdk.cpp: (WebCore::noneCursor):
  • platform/mac/CursorMac.mm: (WebCore::noneCursor):
  • platform/qt/CursorQt.cpp: (WebCore::noneCursor):
  • platform/win/CursorWin.cpp: (WebCore::noneCursor):
  • rendering/RenderStyle.h: (WebCore::):
5:24 AM SVG TODO List - Short notes edited by zimmermann@kde.org
(diff)
4:52 AM Changeset in webkit [18269] by zimmermann
  • 2 edits in trunk/WebCore

Build fix, not reviewed.

This should hopefully fix Qt build.

  • ksvg2/svg/SVGLength.cpp: Include math.h for Qt/Linux build.
4:47 AM Changeset in webkit [18268] by zimmermann
  • 55 edits
    2 deletes in trunk/WebCore

Reviewed by Rob.

Remove SVGHelper class. Move the last static function "parseSeparatedList"
to the only place using it: SVGAnimationElement. Update all build files.

Remove any lazy_create macro usage, by what it does - cleaner.

4:16 AM Changeset in webkit [18267] by zimmermann
  • 60 edits in trunk

Reviewed by Rob.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11813

Pass SVGLength around by value, remove any SVGLength* usage.
Bindings work fine, as the SVG POD JS Wrapper stuff is already in svn.

No new regressions, none fixed. But the code itself is much cleaner.
And some problems with width-full-percentage.svg have been fixed, viewport
clipping works in any case now, also for percentual width/height values set on <svg>.

Still unsure if we can simulate window resizes in a layout test,
not through "width/height" property changes, but directly in any way.
If anyone knows if we can do that, please drop me a line.

3:58 AM Changeset in webkit [18266] by hausmann
  • 2 edits in trunk/JavaScriptCore

make testkjs.pro work on machines other than mine :)

2:50 AM Changeset in webkit [18265] by hausmann
  • 3 edits
    1 add in trunk

for the Qt build also build testkjs now

Dec 16, 2006:

8:11 PM Changeset in webkit [18264] by weinig
  • 406 edits in trunk

LayoutTests:

Reviewed by Maciej.

Update tests for ​http://bugs.webkit.org/show_bug.cgi?id=11856
Update renderName() methods to return current class names.

  • dom/svg/level3/xpath/Conformance_ID-expected.txt:
  • editing/inserting/before-after-input-element-expected.txt:
  • editing/pasteboard/4806874-expected.txt:
  • editing/pasteboard/drop-text-without-selection-expected.txt:
  • editing/pasteboard/input-field-1-expected.txt:
  • editing/pasteboard/nested-blocks-with-text-area-expected.txt:
  • editing/pasteboard/nested-blocks-with-text-field-expected.txt:
  • editing/pasteboard/pasting-tabs-expected.txt:
  • editing/selection/3690703-2-expected.txt:
  • editing/selection/3690703-expected.txt:
  • editing/selection/3690719-expected.txt:
  • editing/selection/drag-select-1-expected.txt:
  • editing/selection/select-from-textfield-outwards-expected.txt:
  • fast/block/float/032-expected.txt:
  • fast/block/margin-collapse/103-expected.txt:
  • fast/css/resize-corner-tracking-expected.txt:
  • fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • fast/dom/isindex-002-expected.txt:
  • fast/dynamic/008-expected.txt:
  • fast/events/label-focus-expected.txt:
  • fast/forms/8250-expected.txt:
  • fast/forms/encoding-test-expected.txt:
  • fast/forms/fieldset-align-expected.txt:
  • fast/forms/floating-textfield-relayout-expected.txt:
  • fast/forms/form-element-geometry-expected.txt:
  • fast/forms/input-appearance-bkcolor-expected.txt:
  • fast/forms/input-appearance-default-bkcolor-expected.txt:
  • fast/forms/input-appearance-disabled-expected.txt:
  • fast/forms/input-appearance-focus-expected.txt:
  • fast/forms/input-appearance-height-expected.txt:
  • fast/forms/input-appearance-minWidth-expected.txt:
  • fast/forms/input-appearance-preventDefault-expected.txt:
  • fast/forms/input-appearance-readonly-expected.txt:
  • fast/forms/input-appearance-selection-expected.txt:
  • fast/forms/input-appearance-visibility-expected.txt:
  • fast/forms/input-appearance-width-expected.txt:
  • fast/forms/input-baseline-expected.txt:
  • fast/forms/input-disabled-color-expected.txt:
  • fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • fast/forms/input-maxlength-2-expected.txt:
  • fast/forms/input-paste-undo-expected.txt:
  • fast/forms/input-readonly-dimmed-expected.txt:
  • fast/forms/input-readonly-empty-expected.txt:
  • fast/forms/input-spaces-expected.txt:
  • fast/forms/input-table-expected.txt:
  • fast/forms/input-text-click-inside-expected.txt:
  • fast/forms/input-text-click-outside-expected.txt:
  • fast/forms/input-text-double-click-expected.txt:
  • fast/forms/input-text-drag-down-expected.txt:
  • fast/forms/input-text-maxlength-expected.txt:
  • fast/forms/input-text-option-delete-expected.txt:
  • fast/forms/input-text-paste-maxlength-expected.txt:
  • fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • fast/forms/input-text-self-emptying-click-expected.txt:
  • fast/forms/input-type-change2-expected.txt:
  • fast/forms/input-value-expected.txt:
  • fast/forms/input-width-expected.txt:
  • fast/forms/minWidthPercent-expected.txt:
  • fast/forms/negativeLineHeight-expected.txt:
  • fast/forms/plaintext-mode-2-expected.txt:
  • fast/forms/tabbing-input-iframe-expected.txt:
  • fast/forms/textAreaLineHeight-expected.txt:
  • fast/forms/textarea-scroll-height-expected.txt:
  • fast/forms/textarea-scrollbar-expected.txt:
  • fast/forms/textarea-scrolled-type-expected.txt:
  • fast/forms/textarea-setinnerhtml-expected.txt:
  • fast/forms/textfield-drag-into-disabled-expected.txt:
  • fast/forms/visual-hebrew-text-field-expected.txt:
  • fast/lists/dynamic-marker-crash-expected.txt:
  • fast/overflow/overflow-x-y-expected.txt:
  • fast/replaced/width100percent-expected.txt:
  • fast/table/003-expected.txt:
  • fast/table/colspanMinWidth-expected.txt:
  • fast/table/spanOverlapRepaint-expected.txt:
  • fast/table/text-field-baseline-expected.txt:
  • fast/text/international/rtl-white-space-pre-wrap-expected.txt:
  • fast/text/textIteratorNilRenderer-expected.txt:
  • http/tests/navigation/anchor-basic-expected.txt:
  • http/tests/navigation/anchor-frames-expected.txt:
  • http/tests/navigation/anchor-goback-expected.txt:
  • http/tests/navigation/anchor-subframeload-expected.txt:
  • http/tests/navigation/javascriptlink-basic-expected.txt:
  • http/tests/navigation/javascriptlink-frames-expected.txt:
  • http/tests/navigation/javascriptlink-goback-expected.txt:
  • http/tests/navigation/javascriptlink-subframeload-expected.txt:
  • http/tests/navigation/metaredirect-basic-expected.txt:
  • http/tests/navigation/metaredirect-frames-expected.txt:
  • http/tests/navigation/metaredirect-goback-expected.txt:
  • http/tests/navigation/metaredirect-subframeload-expected.txt:
  • http/tests/navigation/post-goback2-expected.txt:
  • http/tests/navigation/postredirect-goback2-expected.txt:
  • http/tests/navigation/redirect302-basic-expected.txt:
  • http/tests/navigation/redirect302-frames-expected.txt:
  • http/tests/navigation/redirect302-goback-expected.txt:
  • http/tests/navigation/redirect302-subframeload-expected.txt:
  • http/tests/navigation/relativeanchor-basic-expected.txt:
  • http/tests/navigation/relativeanchor-frames-expected.txt:
  • http/tests/navigation/relativeanchor-goback-expected.txt:
  • http/tests/navigation/slowmetaredirect-basic-expected.txt:
  • http/tests/navigation/slowtimerredirect-basic-expected.txt:
  • http/tests/navigation/success200-basic-expected.txt:
  • http/tests/navigation/success200-frames-expected.txt:
  • http/tests/navigation/success200-frames-loadsame-expected.txt:
  • http/tests/navigation/success200-goback-expected.txt:
  • http/tests/navigation/success200-loadsame-expected.txt:
  • http/tests/navigation/success200-reload-expected.txt:
  • http/tests/navigation/success200-subframeload-expected.txt:
  • http/tests/navigation/timerredirect-basic-expected.txt:
  • http/tests/navigation/timerredirect-frames-expected.txt:
  • http/tests/navigation/timerredirect-goback-expected.txt:
  • http/tests/navigation/timerredirect-subframeload-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt:
  • svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
  • svg/W3C-SVG-1.1/color-prof-01-f-expected.txt:
  • svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
  • svg/W3C-SVG-1.1/color-prop-02-f-expected.txt:
  • svg/W3C-SVG-1.1/color-prop-03-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
  • svg/W3C-SVG-1.1/coords-units-01-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-units-03-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
  • svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
  • svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
  • svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
  • svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
  • svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-order-01-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-order-02-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-order-03-b-expected.txt:
  • svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
  • svg/W3C-SVG-1.1/linking-a-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-a-02-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-a-03-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-a-04-t-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
  • svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-03-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • svg/W3C-SVG-1.1/masking-path-05-f-expected.txt:
  • svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt:
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
  • svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
  • svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-01-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-02-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-03-f-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-04-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-05-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-06-t-expected.txt:
  • svg/W3C-SVG-1.1/paths-data-07-t-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
  • svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-01-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-02-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-03-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-02-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-03-b-expected.txt:
  • svg/W3C-SVG-1.1/script-handle-04-b-expected.txt:
  • svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt:
  • svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-frag-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-group-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-group-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-03-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.txt:
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-css-01-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-css-02-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-css-03-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt:
  • svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
  • svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt:
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.txt:
  • svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tref-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
  • svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
  • svg/custom/SVGNumber-interface-expected.txt:
  • svg/custom/SVGPoint-interface-expected.txt:
  • svg/custom/SVGPoint-matrixTransform-expected.txt:
  • svg/custom/SVGRect-interface-expected.txt:
  • svg/custom/baseval-animval-equality-expected.txt:
  • svg/custom/class-selector-expected.txt:
  • svg/custom/clip-path-with-transform-expected.txt:
  • svg/custom/conditional-processing-outside-switch-expected.txt:
  • svg/custom/control-points-for-S-and-T-expected.txt:
  • svg/custom/coords-relative-units-transforms-expected.txt:
  • svg/custom/create-metadata-element-expected.txt:
  • svg/custom/createelement-expected.txt:
  • svg/custom/dasharrayOrigin-expected.txt:
  • svg/custom/display-none-expected.txt:
  • svg/custom/dynamic-empty-path-expected.txt:
  • svg/custom/empty-merge-expected.txt:
  • svg/custom/evt-onload-expected.txt:
  • svg/custom/feComponentTransfer-Discrete-expected.txt:
  • svg/custom/feComponentTransfer-Gamma-expected.txt:
  • svg/custom/feComponentTransfer-Linear-expected.txt:
  • svg/custom/feComponentTransfer-Table-expected.txt:
  • svg/custom/feDisplacementMap-01-expected.txt:
  • svg/custom/fill-update-expected.txt:
  • svg/custom/filter-source-alpha-expected.txt:
  • svg/custom/foreign-object-skew-expected.txt:
  • svg/custom/fractional-rects-expected.txt:
  • svg/custom/getTransformToElement-expected.txt:
  • svg/custom/getsvgdocument-expected.txt:
  • svg/custom/gradient-attr-update-expected.txt:
  • svg/custom/gradient-stroke-width-expected.txt:
  • svg/custom/grayscale-gradient-mask-expected.txt:
  • svg/custom/hover-default-fill-expected.txt:
  • svg/custom/image-clipped-hit-expected.txt:
  • svg/custom/image-with-transform-clip-filter-expected.txt:
  • svg/custom/inner-percent-expected.txt:
  • svg/custom/invalid-css-expected.txt:
  • svg/custom/invalid-fill-expected.txt:
  • svg/custom/invalid-transforms-expected.txt:
  • svg/custom/invalid-viewbox1-expected.txt:
  • svg/custom/invalid-viewbox2-expected.txt:
  • svg/custom/junk-data-expected.txt:
  • svg/custom/marker-overflow-clip-expected.txt:
  • svg/custom/mask-inside-defs-expected.txt:
  • svg/custom/missing-xlink-expected.txt:
  • svg/custom/non-opaque-filters-expected.txt:
  • svg/custom/path-bad-data-expected.txt:
  • svg/custom/path-update-expected.txt:
  • svg/custom/pattern-in-defs-expected.txt:
  • svg/custom/pattern-y-offset-expected.txt:
  • svg/custom/percentage-rect-expected.txt:
  • svg/custom/percentage-rect2-expected.txt:
  • svg/custom/pointer-events-path-expected.txt:
  • svg/custom/polyline-hittest-expected.txt:
  • svg/custom/polyline-invalid-points-expected.txt:
  • svg/custom/polyline-setattribute-points-null-expected.txt:
  • svg/custom/recursive-clippath-expected.txt:
  • svg/custom/rootelement-expected.txt:
  • svg/custom/rounded-rects-expected.txt:
  • svg/custom/sheet-title-expected.txt:
  • svg/custom/simpleCDF-expected.txt:
  • svg/custom/svg-overflow-types-expected.txt:
  • svg/custom/svgpolyparser-extra-space-expected.txt:
  • svg/custom/text-clip-expected.txt:
  • svg/custom/text-ctm-expected.txt:
  • svg/custom/text-filter-expected.txt:
  • svg/custom/text-gradient-no-content-expected.txt:
  • svg/custom/text-hit-test-expected.txt:
  • svg/custom/text-image-opacity-expected.txt:
  • svg/custom/transform-ignore-after-invalid-expected.txt:
  • svg/custom/transform-invalid-expected.txt:
  • svg/custom/transform-scale-parse-expected.txt:
  • svg/custom/transform-with-ending-space-expected.txt:
  • svg/custom/tref-update-expected.txt:
  • svg/custom/use-forward-refs-expected.txt:
  • svg/custom/viewport-clip-expected.txt:
  • svg/custom/viewport-em-expected.txt:
  • svg/custom/viewport-no-width-height-expected.txt:
  • svg/custom/viewport-update-expected.txt:
  • svg/custom/viewport-update2-expected.txt:
  • svg/custom/width-full-percentage-expected.txt:
  • svg/hixie/cascade/002-expected.txt:
  • svg/hixie/viewbox/003-expected.txt:
  • tables/mozilla/bugs/45621-expected.txt:
  • tables/mozilla/bugs/bug1188-expected.txt:
  • tables/mozilla/bugs/bug12384-expected.txt:
  • tables/mozilla/bugs/bug18359-expected.txt:
  • tables/mozilla/bugs/bug194024-expected.txt:
  • tables/mozilla/bugs/bug24200-expected.txt:
  • tables/mozilla/bugs/bug2479-3-expected.txt:
  • tables/mozilla/bugs/bug2479-4-expected.txt:
  • tables/mozilla/bugs/bug28928-expected.txt:
  • tables/mozilla/bugs/bug30559-expected.txt:
  • tables/mozilla/bugs/bug30692-expected.txt:
  • tables/mozilla/bugs/bug4382-expected.txt:
  • tables/mozilla/bugs/bug4527-expected.txt:
  • tables/mozilla/bugs/bug46368-1-expected.txt:
  • tables/mozilla/bugs/bug46368-2-expected.txt:
  • tables/mozilla/bugs/bug51037-expected.txt:
  • tables/mozilla/bugs/bug55545-expected.txt:
  • tables/mozilla/bugs/bug59354-expected.txt:
  • tables/mozilla/bugs/bug7342-expected.txt:
  • tables/mozilla/bugs/bug96334-expected.txt:
  • tables/mozilla/bugs/bug99948-expected.txt:
  • tables/mozilla/dom/tableDom-expected.txt:
  • tables/mozilla/other/move_row-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug2479-2-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
  • tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:

WebCore:

Reviewed by Maciej.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11856
Update renderName() methods to return current class names.

  • rendering/RenderPath.h: (WebCore::RenderPath::renderName): Returns "RenderPath" instead of "KCanvasItem".
  • rendering/RenderSVGContainer.h: (WebCore::RenderSVGContainer::renderName): Returns "RenderSVGContainer" instead of "KCanvasContainer".
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::renderName): Returns "RenderTextControl" instead of "RenderTextField".
3:43 PM Changeset in webkit [22679] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

2006-12-16 Beth Dakin <Beth Dakin>

Reviewed by Adam (and partially Geoff).

Boomer side of making WebCore Context Menus support state and
enabled/disabled, and re-architecture of ContextMenuItem.

  • platform/win/ContextMenuItemWin.cpp: ContextMenuItem class holds the platformDescription as the sole member variable. Changes to account for this. (WebCore::ContextMenuItem::ContextMenuItem): Same. (WebCore::ContextMenuItem::releasePlatformDescription): Same. (WebCore::ContextMenuItem::type): Same (WebCore::ContextMenuItem::platformSubMenu): Same. (WebCore::ContextMenuItem::setType): Same. (WebCore::ContextMenuItem::setTitle): Same. (WebCore::ContextMenuItem::setSubMenu): Same. (WebCore::ContextMenuItem::setChecked): Same. (WebCore::ContextMenuItem::setEnabled): Same.
  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::insertItem): Takes ownership of the item by calling releasePlatformDescription() (WebCore::ContextMenu::appendItem): Same. (WebCore::ContextMenu::itemWithAction): This is the new at(). Since we are no longer using notifybypos, we instead need a way to find a menu item by its action. (Its ID.) (WebCore::ContextMenu::setPlatformDescription): No longer use notifybypos.
3:36 PM Changeset in webkit [18263] by weinig
  • 27 edits in trunk/WebCore

Reviewed by Mitz.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11844
Code Cleanup for more of the rendering code

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::calcMinMaxWidth):
  • rendering/RenderText.cpp: (WebCore::RenderText::RenderText): (WebCore::RenderText::setStyle): (WebCore::RenderText::destroy): (WebCore::RenderText::attachTextBox): (WebCore::RenderText::findNextInlineTextBox): (WebCore::RenderText::positionForCoordinates): (WebCore::firstRendererOnNextLine): (WebCore::lastRendererOnPrevLine): (WebCore::RenderText::caretRect): (WebCore::RenderText::posOfChar): (WebCore::RenderText::allAscii): (WebCore::RenderText::shouldUseMonospaceCache): (WebCore::RenderText::cacheWidths): (WebCore::RenderText::widthFromCache): (WebCore::RenderText::trimmedMinMaxWidth): (WebCore::RenderText::calcMinMaxWidth): (WebCore::isSpaceAccordingToStyle): (WebCore::RenderText::containsOnlyWhitespace): (WebCore::RenderText::minXPos): (WebCore::RenderText::setSelectionState): (WebCore::RenderText::setTextWithOffset): (WebCore::RenderText::setText): (WebCore::RenderText::position): (WebCore::RenderText::width): (WebCore::RenderText::getAbsoluteRepaintRect): (WebCore::RenderText::selectionRect): (WebCore::RenderText::verticalPositionHint): (WebCore::RenderText::font): (WebCore::RenderText::caretMinOffset): (WebCore::RenderText::caretMaxOffset): (WebCore::RenderText::previousOffset): (WebCore::RenderText::nextOffset): (WebCore::RenderText::inlineBox):
  • rendering/RenderText.h: (WebCore::RenderText::isTextFragment): (WebCore::RenderText::data): (WebCore::RenderText::string): (WebCore::RenderText::paint): (WebCore::RenderText::layout): (WebCore::RenderText::nodeAtPoint): (WebCore::RenderText::length): (WebCore::RenderText::text): (WebCore::RenderText::stringLength):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::setStyle): (WebCore::disabledTextColor): (WebCore::RenderTextControl::createInnerBlockStyle): (WebCore::RenderTextControl::createInnerTextStyle): (WebCore::RenderTextControl::createResultsButtonStyle): (WebCore::RenderTextControl::createCancelButtonStyle): (WebCore::RenderTextControl::showPlaceholderIfNeeded): (WebCore::RenderTextControl::hidePlaceholderIfNeeded): (WebCore::RenderTextControl::createSubtreeIfNeeded): (WebCore::RenderTextControl::updateFromElement): (WebCore::RenderTextControl::selectionStart): (WebCore::RenderTextControl::setSelectionRange): (WebCore::RenderTextControl::visiblePositionForIndex): (WebCore::RenderTextControl::subtreeHasChanged): (WebCore::RenderTextControl::textWithHardLineBreaks): (WebCore::RenderTextControl::calcHeight): (WebCore::RenderTextControl::nodeAtPoint): (WebCore::RenderTextControl::layout): (WebCore::RenderTextControl::calcMinMaxWidth): (WebCore::RenderTextControl::addSearchResult): (WebCore::RenderTextControl::showPopup): (WebCore::RenderTextControl::itemText): (WebCore::RenderTextControl::itemIsEnabled): (WebCore::RenderTextControl::listSize): (WebCore::RenderTextControl::scroll):
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::renderName): (WebCore::RenderTextControl::removeLeftoverAnonymousBoxes):
  • rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::RenderTextFragment): (WebCore::RenderTextFragment::originalString):
  • rendering/RenderTextFragment.h: (WebCore::RenderTextFragment::isTextFragment):
  • rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::isControlStyled): (WebCore::RenderTheme::stateChanged): (WebCore::RenderTheme::adjustCheckboxStyle): (WebCore::RenderTheme::adjustRadioStyle):
  • rendering/RenderTheme.h: (WebCore::):
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::RenderThemeMac): (WebCore::RenderThemeMac::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeMac::activeListBoxSelectionBackgroundColor): (WebCore::RenderThemeMac::systemFont): (WebCore::RenderThemeMac::isControlStyled): (WebCore::RenderThemeMac::adjustRepaintRect): (WebCore::RenderThemeMac::updateCheckedState): (WebCore::RenderThemeMac::controlSupportsTints): (WebCore::RenderThemeMac::setFontFromControlSize): (WebCore::RenderThemeMac::paintCheckbox): (WebCore::RenderThemeMac::checkboxMargins): (WebCore::RenderThemeMac::setCheckboxCellState): (WebCore::RenderThemeMac::setCheckboxSize): (WebCore::RenderThemeMac::paintRadio): (WebCore::RenderThemeMac::radioMargins): (WebCore::RenderThemeMac::setRadioCellState): (WebCore::RenderThemeMac::setRadioSize): (WebCore::RenderThemeMac::adjustButtonStyle): (WebCore::RenderThemeMac::buttonMargins): (WebCore::RenderThemeMac::setButtonSize): (WebCore::RenderThemeMac::setButtonCellState): (WebCore::RenderThemeMac::adjustTextFieldStyle): (WebCore::RenderThemeMac::adjustTextAreaStyle): (WebCore::RenderThemeMac::popupButtonMargins): (WebCore::RenderThemeMac::popupButtonPadding): (WebCore::TopGradientInterpolate): (WebCore::BottomGradientInterpolate): (WebCore::MainGradientInterpolate): (WebCore::TrackGradientInterpolate): (WebCore::RenderThemeMac::paintMenuListButtonGradients): (WebCore::RenderThemeMac::paintMenuListButton): (WebCore::RenderThemeMac::adjustMenuListStyle): (WebCore::RenderThemeMac::adjustMenuListButtonStyle): (WebCore::RenderThemeMac::paintSliderTrack): (WebCore::RenderThemeMac::paintSliderThumb): (WebCore::RenderThemeMac::paintSearchField): (WebCore::RenderThemeMac::setSearchCellState): (WebCore::RenderThemeMac::adjustSearchFieldStyle): (WebCore::RenderThemeMac::paintSearchFieldCancelButton): (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
  • rendering/RenderTreeAsText.cpp: (WebCore::operator<<): (WebCore::writeIndent): (WebCore::printBorderStyle): (WebCore::getTagName): (WebCore::isEmptyOrUnstyledAppleStyleSpan): (WebCore::writeTextRun): (WebCore::write): (WebCore::writeLayers): (WebCore::nodePosition): (WebCore::writeSelection):
  • rendering/RenderTreeAsText.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::RenderView): (WebCore::RenderView::calcMinMaxWidth): (WebCore::RenderView::layout): (WebCore::RenderView::absolutePosition): (WebCore::RenderView::paint): (WebCore::RenderView::repaintViewRectangle): (WebCore::rendererAfterPosition): (WebCore::RenderView::selectionRect): (WebCore::RenderView::setSelection): (WebCore::RenderView::selectionStartEnd): (WebCore::RenderView::updateWidgetPositions): (WebCore::RenderView::addWidget): (WebCore::RenderView::removeWidget): (WebCore::RenderView::viewRect): (WebCore::RenderView::docHeight): (WebCore::RenderView::docWidth): (WebCore::RenderView::setBestTruncatedAt):
  • rendering/RenderView.h: (WebCore::RenderView::renderName): (WebCore::RenderView::selectionStart): (WebCore::RenderView::selectionEnd):
  • rendering/RenderWidget.cpp: (WebCore::RenderWidget::destroy): (WebCore::RenderWidget::resizeWidget): (WebCore::RenderWidget::setStyle): (WebCore::RenderWidget::paint): (WebCore::RenderWidget::updateWidgetPosition): (WebCore::RenderWidget::setSelectionState):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::placeEllipsis): (WebCore::RootInlineBox::fillLineSelectionGap): (WebCore::RootInlineBox::selectionState): (WebCore::RootInlineBox::firstSelectedBox): (WebCore::RootInlineBox::lastSelectedBox): (WebCore::RootInlineBox::selectionTop): (WebCore::RootInlineBox::closestLeafChildForXPos):
  • rendering/RootInlineBox.h: (WebCore::RootInlineBox::isRootInlineBox): (WebCore::RootInlineBox::setVerticalOverflowPositions): (WebCore::RootInlineBox::setHorizontalOverflowPositions): (WebCore::RootInlineBox::setVerticalSelectionPositions): (WebCore::RootInlineBox::lineBreakObj): (WebCore::RootInlineBox::lineBreakPos): (WebCore::RootInlineBox::setLineBreakPos): (WebCore::RootInlineBox::blockHeight): (WebCore::RootInlineBox::setBlockHeight): (WebCore::RootInlineBox::endsWithBreak): (WebCore::RootInlineBox::setEndsWithBreak):
  • rendering/SVGInlineFlowBox.cpp: (WebCore::SVGInlineFlowBox::paint): (WebCore::paintSVGInlineFlow): (WebCore::translateBox): (WebCore::placePositionedBoxesHorizontally): (WebCore::placeBoxesVerticallyWithAbsBaseline): (WebCore::placeSVGFlowVertically):
  • rendering/SVGInlineFlowBox.h:
  • rendering/SVGRenderTreeAsText.cpp: (WebCore::TextStreamSeparator::TextStreamSeparator): (WebCore::operator<<): (WebCore::hasFractions): (WebCore::writeIndent): (WebCore::writeStyle): (WebCore::getTagName): (WebCore::write): (WebCore::writeRenderResources):
  • rendering/SVGRenderTreeAsText.h: (WebCore::operator<<):
  • rendering/SVGRootInlineBox.cpp: (WebCore::SVGRootInlineBox::paint): (WebCore::SVGRootInlineBox::placeBoxesHorizontally):
  • rendering/SVGRootInlineBox.h:
  • rendering/TableLayout.h:
3:34 PM Changeset in webkit [18262] by aroben
  • 3 edits in trunk/WebCore

Build fixes.

  • platform/ContextMenuItem.h: Fixed const declarations.
  • platform/mac/ContextMenuItemMac.mm: Dito. (WebCore::ContextMenuItem::type): (WebCore::ContextMenuItem::setTitle): (WebCore::ContextMenuItem::setChecked): (WebCore::ContextMenuItem::setEnabled):
1:30 PM Changeset in webkit [18261] by adele
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=11189
<rdar://problem/4770249> REGRESSION (NativeListBox): When a list box has focus, pressing command- A (select all) doesn't selected all items in list

  • fast/forms/listbox-select-all-expected.txt: Added.
  • fast/forms/listbox-select-all.html: Added.

WebCore:

Reviewed by Maciej.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11189
<rdar://problem/4770249> REGRESSION (NativeListBox): When a list box has focus, pressing command- A (select all) doesn't selected all items in list

Test: fast/forms/listbox-select-all.html

  • dom/Node.h: We should try to find a more appropriate place to put these methods. (WebCore::Node::canSelectAll): Added. (WebCore::Node::selectAll): Added.
  • editing/SelectionController.cpp: (WebCore::SelectionController::selectAll): Before selecting editable content, give the focused node a chance to select its content.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::selectAll): Selects all items in a multi-select list box. Single-select list boxes will just do nothing, but we still want the select to handle this case when it has focus, rather than selecting other content.
  • html/HTMLSelectElement.h: (WebCore::HTMLSelectElement::canSelectAll): Returns true for list boxes.
10:44 AM Changeset in webkit [18260] by yongjzha
  • 2 edits in S60/branches/3.1m/WebKit

2006-12-14 hongzhao <​hong.a.zhao@nokia.com>

Reviewed by Yongjun <​yongjun.zhang@nokia.com>
DESC:
​http://bugzilla.opendarwin.org/show_bug.cgi?id=11810

  • Plugin/src/PluginWin.cpp: (CPluginWin::ViewFocusChanged): (CPluginWin::HandleGainingForeground): (CPluginWin::HandleLosingForeground):
9:37 AM Changeset in webkit [18259] by yongjzha
  • 2 edits in S60/trunk/WebKit

2006-12-14 hongzhao <​hong.a.zhao@nokia.com>

Reviewed by Yongjun <​yongjun.zhang@nokia.com>
DESC:
​http://bugs.webkit.org/show_bug.cgi?id=11810

  • Plugin/src/PluginWin.cpp: (CPluginWin::ViewFocusChanged): (CPluginWin::HandleGainingForeground): (CPluginWin::HandleLosingForeground):
8:54 AM Changeset in webkit [18258] by zack
  • 1 edit
    1 add in trunk/WebCore

Add a stub for SearchPopupMenu for Qt.

8:45 AM Changeset in webkit [18257] by zack
  • 9 edits in trunk

Adjust Qt code to the last nights changes (make it compile)

4:31 AM Changeset in webkit [18256] by ap
  • 2 edits in trunk/JavaScriptCore

Reviewed by Rob.

A deleted object was accessed to prepare RegExp construction error messages.

  • kjs/regexp_object.cpp: (RegExpObjectImp::construct): Wrap the RegExp into an OwnPtr.
2:56 AM Changeset in webkit [18255] by adele
  • 2 edits in trunk/WebCore

One more...

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment):
2:51 AM Changeset in webkit [18254] by adele
  • 2 edits in trunk/WebCore

Missed one instance of isNonWidgetTextField.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply):
2:47 AM Changeset in webkit [18253] by ap
  • 3 edits in trunk/WebCore

2006-12-16 Hunter L. Williams <​hlwebkit@gmail.com>

Reviewed by Adele.

Fix mouse wheel scrolling in <textarea> controls.

  • rendering/RenderTextControl.cpp:
  • rendering/RenderTextControl.h: Override |scroll| on RenderTextControl to forward the call to the RenderObject of the inner m_innerText, which has a layer that can be scrolled.
2:44 AM Changeset in webkit [22678] by adele
  • 3 edits in branches/WindowsMerge/WebCore

RS by Adam.

Removed TextField, RenderLineEdit classes.

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp:
2:38 AM Changeset in webkit [18252] by adele
  • 5 edits
    6 deletes in trunk/WebCore

RS by Adam.

Removed RenderLineEdit, TextField, WebCoreTextField classes, and use of isNonWidgetTextField,

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isKeyboardFocusable): (WebCore::HTMLInputElement::isMouseFocusable): (WebCore::HTMLInputElement::focus): (WebCore::HTMLInputElement::updateFocusAppearance): (WebCore::HTMLInputElement::aboutToUnload): (WebCore::HTMLInputElement::dispatchFocusEvent): (WebCore::HTMLInputElement::dispatchBlurEvent): (WebCore::HTMLInputElement::setValue): (WebCore::HTMLInputElement::defaultEventHandler):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::isTextField):
  • html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLTextFieldInnerTextElement::defaultEventHandler):
  • platform/TextField.h: Removed.
  • platform/mac/TextFieldMac.mm: Removed.
  • platform/mac/WebCoreTextField.h: Removed.
  • platform/mac/WebCoreTextField.mm: Removed.
  • rendering/RenderLineEdit.cpp: Removed.
  • rendering/RenderLineEdit.h: Removed.
2:35 AM WebKit Team edited by Adam Roben
(diff)
2:35 AM WebKit Team edited by Adam Roben
(diff)
2:18 AM Changeset in webkit [18251] by adele
  • 1 edit
    2 adds in trunk/WebCore

Two more files I forgot to svn add for search fields.

  • platform/SearchPopupMenu.h: Added. (WebCore::SearchPopupMenu::create):
  • platform/mac/SearchPopupMenuMac.mm: Added. (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::autosaveKey): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches):
2:12 AM Changeset in webkit [18250] by adele
  • 1 edit
    1 add in trunk/WebCore

Reviewed by Adam.

  • platform/PopupMenuClient.h: Added. Broken out of PopupMenu class. (WebCore::PopupMenuClient::~PopupMenuClient):
2:00 AM Changeset in webkit [18249] by ap
  • 3 edits in trunk/LayoutTests

2006-12-16 Mitz Pettel <​mitz@webkit.org>

Reviewed by Oliver.

  • editing/selection/select-all-005-expected.txt: Reverted to the original expected result for this test.
  • editing/selection/select-all-005.html: Eliminated a script element that was added outside the body, so that the selection will encompass the entire html element as originally intended.
1:57 AM Changeset in webkit [22677] by adele
  • 4 edits
    1 add in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adam.

Added PopupMenu and theme code for:
<rdar://problem/4463829> Switch to use new search field implementation for <input type="search">

  • WebCore.vcproj/WebCore.vcproj:
  • platform/graphics/win/IconWin.cpp: (WebCore::Icon::Icon):
  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::setFocusedIndex): (WebCore::PopupWndProc):
  • platform/win/SearchPopupMenuWin.cpp: Added. (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::autosaveKey): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches):
  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::paintSearchField): (WebCore::RenderThemeWin::adjustSearchFieldStyle): (WebCore::RenderThemeWin::paintSearchFieldCancelButton): (WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeWin::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeWin::paintSearchFieldDecoration): (WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeWin::paintSearchFieldResultsDecoration): (WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeWin::paintSearchFieldResultsButton):
  • rendering/RenderThemeWin.h:
1:56 AM Changeset in webkit [18248] by adele
  • 38 edits in trunk

LayoutTests:

Reviewed by Adam.

Updated test results for:
<rdar://problem/4463829> Switch to use new search field implementation for <input type="search">

  • fast/events/onchange-searchfield-expected.txt:
  • fast/forms/input-appearance-height-expected.checksum:
  • fast/forms/input-appearance-height-expected.png:
  • fast/forms/input-appearance-height-expected.txt:

WebCore:

Reviewed by Adam.

WebCore part of fix for:
<rdar://problem/4463829> Switch to use new search field implementation for <input type="search">

  • WebCore.xcodeproj/project.pbxproj: Added SearchPopupMenu.h, SearchPopupMenuMac.mm, and PopupMenuClient.h.

Added pseudo classes and corresponding values for -webkit appearance for the cancel button and for the three types of "decoration" that
correspond to the different functions of the magnifier glass in the search field. One for the button that will show and hide the
recent searches menu. One for decoration when the results attribute is set, but no results are saved. And one for decoration
when no results attribute is set. We added these different pseudo elements so that RenderTextControl can decide which pseudo class
is appropriate, and each theme can decide for itself which kind of image is appropriate for each function.


  • css/CSSSelector.cpp: (WebCore::CSSSelector::extractPseudoType):
  • css/CSSSelector.h: (WebCore::CSSSelector::): Added to PseudoType enum.
  • css/CSSValueKeywords.in: Added searchfield-decoration, searchfield-results-decoration, searchfield-results-button, searchfield-cancel-button values.
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::checkOneSelector): Added cases for -webkit-search-cancel-button, -webkit-search-decoration, -webkit-search-results-decoration, -webkit-search-results-button
  • rendering/RenderStyle.cpp: Addes new pseudoBits for matching pseudoIds. (WebCore::): (WebCore::pseudoBit):
  • rendering/RenderStyle.h: Added new appearance values and pseudoIds. (WebCore::): (WebCore::RenderStyle::):
  • css/html4.css: Added style for input[type=search], and the new pseudo elements.

The structure of the shadow DOM for new search field adds an intermediate block that contains 3 inline-blocks for the magnifier, text element, and cancel button.
Since the tree has become deeper, some editing and event code that used to check for a shadowParent, really needs to check the shadowAncestorNode.

  • editing/Editor.cpp: (WebCore::Editor::dispatchCPPEvent): Check shadowAncestorNode instead of shadowParentNode.
  • editing/Selection.cpp: (WebCore::Selection::adjustForEditableContent): ditto.
  • editing/htmlediting.cpp: (WebCore::firstEditablePositionAfterPositionInRoot): ditto. (WebCore::lastEditablePositionBeforePositionInRoot): ditto.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): ditto. (WebCore::ReplaceSelectionCommand::shouldMerge): Nil check enclosingBlock call. I ran into this while testing search fields in mixed editability. (WebCore::ReplaceSelectionCommand::doApply): ditto.
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Remove use of RenderLineEdit.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::selectionStart): ditto. (WebCore::HTMLInputElement::selectionEnd): ditto. (WebCore::HTMLInputElement::setSelectionStart): ditto. (WebCore::HTMLInputElement::setSelectionEnd): ditto. (WebCore::HTMLInputElement::select): ditto. (WebCore::HTMLInputElement::setSelectionRange): ditto. (WebCore::HTMLInputElement::parseMappedAttribute): ditto. (WebCore::HTMLInputElement::createRenderer): ditto. (WebCore::HTMLInputElement::defaultEventHandler): ditto. (WebCore::HTMLInputElement::addSearchResult): Added. Calls addSearchResult on the renderer.
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::isNonWidgetTextField): Added case for search field. (WebCore::HTMLInputElement::isSearchField): Added.
  • platform/PopupMenu.h: Broke PopupMenuClient out into a separate file.
  • platform/PopupMenuClient.h: Added. (WebCore::PopupMenuClient::~PopupMenuClient):
  • platform/graphics/Icon.h:
  • platform/SearchPopupMenu.h: Added. Saves and loads recent search vector. (WebCore::SearchPopupMenu::create):
  • platform/mac/SearchPopupMenuMac.mm: Added. (WebCore::SearchPopupMenu::SearchPopupMenu): (WebCore::autosaveKey): (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches):
  • html/HTMLTextFieldInnerElement.h: Reorganized this class. Added subclasses HTMLTextFieldInnerTextElement, HTMLSearchFieldResultsButtonElement, HTMLSearchFieldCancelButtonElement (WebCore::HTMLTextFieldInnerElement::isMouseFocusable): Added. Returns false so setFocusNodeIfNeeded will try to focus the input element instead of nodes in the shadow tree. (WebCore::HTMLTextFieldInnerElement::isShadowNode): Now returns whether or not a shadowParent has been specified.
    • html/HTMLTextFieldInnerElement.cpp:

(WebCore::HTMLTextFieldInnerTextElement::HTMLTextFieldInnerTextElement):
(WebCore::HTMLTextFieldInnerTextElement::defaultEventHandler): Moved this from the old HTMLTextFieldInnerElement class.
(WebCore::HTMLSearchFieldResultsButtonElement::HTMLSearchFieldResultsButtonElement):
(WebCore::HTMLSearchFieldResultsButtonElement::defaultEventHandler): Shows and hides recent searches menu.
(WebCore::HTMLSearchFieldCancelButtonElement::HTMLSearchFieldCancelButtonElement):
(WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler): On mouse up, clears the value from the text field.

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::listSize): Changed return type to unsigned.
    • rendering/RenderMenuList.h: (WebCore::RenderMenuList::valueShouldChangeOnHotTrack): Added.


  • WebCore.exp: Export _wkDrawTextFieldCellFocusRing.
  • platform/mac/WebCoreSystemInterface.h: Added wkDrawTextFieldCellFocusRing
  • platform/mac/WebCoreSystemInterface.mm: ditto.
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::popupIsVisible): Added so HTMLSearchFieldResultsButtonElement knows whether or not the menu is already up. (WebCore::RenderTextControl::shouldPopOver): Added as a PopupClient method so the results menu shows up under the control instead of over. (WebCore::RenderTextControl::valueShouldChangeOnHotTrack):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): Initialize m_placeholderIsVisible, m_searchPopup, and m_searchPopupIsVisible. (WebCore::RenderTextControl::~RenderTextControl): Detach the node at the top of the shadow tree (m_innerBlock for search fields, and m_innerText for other text controls). (WebCore::RenderTextControl::setStyle): Sets style on new elements. (WebCore::disabledTextColor): Added so this can be used in setPlaceholder. (WebCore::RenderTextControl::createInnerBlockStyle): Added. (WebCore::RenderTextControl::createInnerTextStyle): Added. (WebCore::RenderTextControl::createResultsButtonStyle): Added. (WebCore::RenderTextControl::createCancelButtonStyle): Added. (WebCore::RenderTextControl::showPlaceholderIfNeeded): Added. Shows the placeholder if there's no value and the field doesn't have focus. (WebCore::RenderTextControl::hidePlaceholderIfNeeded): Added. Clears the placeholder if there's a value or the field has focus. (WebCore::RenderTextControl::createSubtreeIfNeeded): Added. Creates all of the shadow tree elements. (WebCore::RenderTextControl::updateFromElement): Calls showPlaceholderIfNeeded. (WebCore::RenderTextControl::visiblePositionForIndex): Renaming (m_div to m_innerText). (WebCore::RenderTextControl::indexForVisiblePosition): ditto. (WebCore::RenderTextControl::updateCancelButtonVisibility): Shows and hides cancel button based on the value of the control. (WebCore::RenderTextControl::subtreeHasChanged): Fires onSearch if the incremental attribute is set. (WebCore::RenderTextControl::text): Renaming. (WebCore::RenderTextControl::textWithHardLineBreaks): ditto. (WebCore::RenderTextControl::calcHeight): Take the size of the results button and cancel button into account when calculating height. (WebCore::RenderTextControl::nodeAtPoint): Act as if we've hit the shadow tree elements based on the x coordinate of the mouse event. (WebCore::RenderTextControl::layout): Set the height and width of the text block taking the other shadow tree elements into account. (WebCore::RenderTextControl::calcMinMaxWidth): Take new shadow tree elements into account when calculating width. (WebCore::RenderTextControl::forwardEvent): Forward events to appropriate shadow nodes. (WebCore::RenderTextControl::scrollWidth): Renaming. (WebCore::RenderTextControl::scrollHeight): ditto. (WebCore::RenderTextControl::scrollLeft): ditto. (WebCore::RenderTextControl::scrollTop): ditto. (WebCore::RenderTextControl::setScrollLeft): ditto. (WebCore::RenderTextControl::setScrollTop): ditto. (WebCore::RenderTextControl::autosaveName): ditto. (WebCore::RenderTextControl::addSearchResult): Added. Saves value to search result list. (WebCore::RenderTextControl::onSearch): Added. Dispatches search event. (WebCore::RenderTextControl::showPopup): Added. Loads searches, and displays menu. (WebCore::RenderTextControl::hidePopup): Added PopupClient method. (WebCore::RenderTextControl::valueChanged): Added PopupClient method. Interprets the selected menu item index, and either sets the value and fires onSearch, or clears all recent searches for this autosave name. (WebCore::RenderTextControl::itemText): Added PopupClient method. (WebCore::RenderTextControl::itemIsEnabled): Added PopupClient method. (WebCore::RenderTextControl::itemStyle): ditto. (WebCore::RenderTextControl::clientStyle): ditto. (WebCore::RenderTextControl::clientDocument): ditto. (WebCore::RenderTextControl::clientPaddingLeft): ditto. (WebCore::RenderTextControl::clientPaddingRight): ditto. (WebCore::RenderTextControl::listSize): ditto. (WebCore::RenderTextControl::selectedIndex): ditto. (WebCore::RenderTextControl::itemIsSeparator): ditto. (WebCore::RenderTextControl::itemIsLabel): ditto. (WebCore::RenderTextControl::itemIsSelected): ditto. (WebCore::RenderTextControl::setTextFromItem): ditto.
  • rendering/RenderTheme.cpp: Added search field theme. (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::paintDecorations): (WebCore::RenderTheme::isControlStyled): Returns false for search fields, until we've worked out the kinks. (WebCore::RenderTheme::adjustSearchFieldStyle): (WebCore::RenderTheme::adjustSearchFieldCancelButtonStyle): (WebCore::RenderTheme::adjustSearchFieldDecorationStyle): (WebCore::RenderTheme::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderTheme::adjustSearchFieldResultsButtonStyle):
  • rendering/RenderTheme.h: (WebCore::RenderTheme::paintSearchField): (WebCore::RenderTheme::paintSearchFieldCancelButton): (WebCore::RenderTheme::paintSearchFieldDecoration): (WebCore::RenderTheme::paintSearchFieldResultsDecoration): (WebCore::RenderTheme::paintSearchFieldResultsButton):
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::RenderThemeMac): (WebCore::RenderThemeMac::sizeForSystemFont): Added. Compares style's font to systemFontSizeForControlSize to determine what controlSize to use after a style's font has already been initially adjusted. (WebCore::RenderThemeMac::controlSizeForSystemFont): Added. ditto. (WebCore::RenderThemeMac::paintCheckbox): (WebCore::RenderThemeMac::paintRadio): (WebCore::RenderThemeMac::menuListSizes): (WebCore::RenderThemeMac::minimumMenuListSize): Uses sizeForSystemFont instead of hardcoded adjusted font sizes. (WebCore::RenderThemeMac::paintSearchField): (WebCore::RenderThemeMac::setSearchCellState): (WebCore::RenderThemeMac::adjustSearchFieldStyle): (WebCore::RenderThemeMac::paintSearchFieldCancelButton): (WebCore::RenderThemeMac::cancelButtonSizes): (WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle): (WebCore::RenderThemeMac::resultsButtonSizes): (WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle): (WebCore::RenderThemeMac::paintSearchFieldDecoration): (WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle): (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): (WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle): (WebCore::RenderThemeMac::paintSearchFieldResultsButton):

WebKit:

Reviewed by Adam.

WebKit part of fix for:
<rdar://problem/4463829> Switch to use new search field implementation for <input type="search">

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Initialize WKDrawTextFieldCellFocusRing.
  • WebInspector/webInspector/inspector.css: Set -webkit-user-select:text and text-shadow:none on the search field. These are both properties that we didn't honor in the old control, and the inherited values didn't work or look right.
1:51 AM Changeset in webkit [18247] by ap
  • 3 edits
    2 adds in trunk

2006-12-16 Mitz Pettel <​mitz@webkit.org>

Reviewed by Alexey.

Test: editing/execCommand/findString-3.html

  • wtf/unicode/icu/UnicodeIcu.h: (WTF::Unicode::foldCase): Changed to not return an error if the result fits in the buffer without a null terminator.
1:50 AM Changeset in webkit [18246] by adele
  • 3 edits in trunk/WebKitLibraries

Reviewed by Adam.

WebKitLibraries part of fix for:
<rdar://problem/4463829> Switch to use new search field implementation for <input type="search">

Added wkDrawTextFieldCellFocusRing.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterface.a:
1:45 AM Changeset in webkit [22676] by bdakin
  • 5 edits in branches/WindowsMerge/WebKitWin

WebCoreWin:

Reviewed by Adam.

Boomer side of making WebCore Context Menus support state and
enabled/disabled, and re-architecture of ContextMenuItem.

  • platform/win/ContextMenuItemWin.cpp: ContextMenuItem class holds the platformDescription as the sole member variable. Changes to account for this. (WebCore::ContextMenuItem::ContextMenuItem): Same. (WebCore::ContextMenuItem::releasePlatformDescription): Same. (WebCore::ContextMenuItem::type): Same (WebCore::ContextMenuItem::platformSubMenu): Same. (WebCore::ContextMenuItem::setType): Same. (WebCore::ContextMenuItem::setTitle): Same. (WebCore::ContextMenuItem::setSubMenu): Same. (WebCore::ContextMenuItem::setChecked): Same. (WebCore::ContextMenuItem::setEnabled): Same.
  • platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::insertItem): Takes ownership of the item by calling releasePlatformDescription() (WebCore::ContextMenu::appendItem): Same. (WebCore::ContextMenu::itemWithAction): This is the new at(). Since we are no longer using notifybypos, we instead need a way to find a menu item by its action. (Its ID.) (WebCore::ContextMenu::setPlatformDescription): No longer use notifybypos
1:33 AM Changeset in webkit [18245] by bdakin
  • 21 edits in trunk

WebCore:

Reviewed by Adam (and partially Geoff).

Primarily, this patch gives WebCore context menus the ability to
enable/disable and set state. It does a few other things along the
way, though. Some of the more noticeable things:

-Re-architects the ContextMenuItem class a bit so that the

ownership model is a bit less confusing. ContextMenuItem is
now *purely* a wrapper for the platformDescription. There
are no other member variables. If you ever need the
platformDescription outside of the MenuItem class, you have
to call releasePlatformDescription(), which transfers
ownership of the platformDescription to the caller.

-Moves fontForSelection() from FrameMac into Editor.cpp.

Turns out I don't need to use this function for my patch
after all, but it doesn't seem like a terrible idea to move
it anyway since we seem to be moving things from FrameMac
into Editor these days anyway.

WebKit:

Reviewed by Adam.

WebKit side of making WebCore context menus support state and
enabled/disabled.

  • WebCoreSupport/WebContextMenuClient.h: contextMenuItemSelected takes a pointer to the parentMenu now since menu items no longer hold onto it.
  • WebCoreSupport/WebContextMenuClient.mm: Same. (WebContextMenuClient::contextMenuItemSelected): Same.
  • WebView/WebHTMLView.m: Must call setAutoenablesItems:NO on our menu. (-[NSArray menuForEvent:]):
  • WebView/WebUIDelegatePrivate.h: No need for if-def.

Dec 15, 2006:

6:50 PM Changeset in webkit [18244] by bdash
  • 3 edits in trunk/WebCore

2006-12-15 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Oliver.

Allow images to load into frames again. Tidy up code a bit and
add some much needed documentation.

  • platform/MimeTypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes): (WebCore::initialiseSupportedNonImageMimeTypes):
  • platform/MimeTypeRegistry.h:
5:50 PM Changeset in webkit [22675] by andersca
  • 2 edits in branches/WindowsMerge/WebCore
  • platform/win/TemporaryLinkStubs.cpp: Remove DocumentLoader::isStopped because it's now in DocumentLoader.cpp.
4:41 PM Changeset in webkit [18243] by andersca
  • 3 edits in trunk/WebCore

Fix build.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::response): (WebCore::DocumentLoader::setResponse): (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::mainDocumentError):
  • loader/DocumentLoader.h:
4:05 PM Changeset in webkit [18242] by andersca
  • 11 edits in trunk

WebCore:

Reviewed by Geoff.

More loader cleanup.

  • loader/DocumentLoader.h: (WebCore::DocumentLoader::isStopping): (WebCore::DocumentLoader::response): (WebCore::DocumentLoader::mainDocumentError): (WebCore::DocumentLoader::setResponse):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::stopLoading): (WebCore::DocumentLoader::receivedData): (WebCore::DocumentLoader::setupForReplaceByMIMEType): (WebCore::DocumentLoader::prepareForLoadStart):
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::setResponse):
  • loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):

WebKit:

Reviewed by Geoff.

Update for WebCore changes.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
  • WebView/WebDataSource.mm: (-[WebDataSource response]):
2:58 PM Changeset in webkit [18241] by andersca
  • 2 edits in trunk/WebCore
  • loader/DocumentLoader.h: Whoops, didn't mean to commit this.
2:57 PM Changeset in webkit [18240] by andersca
  • 6 edits in trunk/WebCore

Reviewed by Darin and Brady (in no particular order).


More loader cleanup.


  • loader/FrameLoader.h:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::cancelledError): (WebCore::FrameLoader::fileDoesNotExistError): (WebCore::FrameLoader::cannotShowMIMEType): (WebCore::FrameLoader::interruptionForPolicyChangeError):
  • loader/mac/MainResourceLoaderMac.mm:
  • loader/mac/NetscapePlugInStreamLoaderMac.mm:
2:24 PM Changeset in webkit [22674] by ggaren
  • 3 edits in branches/WindowsMerge/WebCore

I'm in ur prjct, fxng ur build.


  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp: (ResourceHandle::loadResourceSynchronously):
2:02 PM Changeset in webkit [18239] by ap
  • 2 edits in trunk/WebCore

Try to fix Windows build: add EventTarget.{h,cpp}.

1:49 PM Changeset in webkit [18238] by ap
  • 22 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11610
XMLHttpRequest.onreadystatechange doesn't provide access to the request object

Created a separate EventTarget class, now that EventTargetNode isn't the only kind.

WebCore:

  • WebCore.xcodeproj/project.pbxproj: Added EventTarget.{h,cpp}
  • bindings/js/kjs_dom.cpp: (KJS::toJS): Added an EventTarget variant.
  • bindings/js/kjs_dom.h: Added toJS() for EventTarget; some minor style fixes.
  • bindings/objc/DOM.mm: (+[DOMNode _eventTargetWith:WebCore::]):
  • bindings/scripts/CodeGeneratorObjC.pm: Added an EventTarget->DOMEventTarget converter in DOMNode (WebCoreInternal). It only works for nodes, since we don't have an ObjC binding for XMLHttpRequest. Corrected spelling of internalHeaderContent.
  • dom/Event.cpp: (WebCore::Event::setTarget):
  • dom/Event.h: (WebCore::Event::target): (WebCore::Event::currentTarget): (WebCore::Event::setCurrentTarget): These methods now work with EventTargets instead of Nodes.
  • dom/EventTarget.cpp: Added. (WebCore::EventTarget::~EventTarget): (WebCore::EventTarget::toNode): (WebCore::EventTarget::toXMLHttpRequest):
  • dom/EventTarget.h: Added. (WebCore::EventTarget::ref): (WebCore::EventTarget::deref): Originally, my intention was to share much of the implementation between EventTargetNode and XHR, but now I don't see anything substantial worth sharing.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent): Cast Node to EventTargetNode.
  • dom/EventTargetNode.h: Made EventTarget methods virtual. (WebCore::EventTargetNode::toNode): Added poor man's RTTI to upcast from EventTarget. (WebCore::EventTargetNode::refEventTarget): (WebCore::EventTargetNode::derefEventTarget):
  • dom/MouseEvent.cpp: (WebCore::MouseEvent::toElement): (WebCore::MouseEvent::fromElement):
  • dom/MouseRelatedEvent.cpp: (WebCore::MouseRelatedEvent::receivedTarget):
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler):
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::defaultEventHandler):
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::handleContextMenuEvent):
  • rendering/RenderSlider.cpp: (WebCore::RenderSlider::mouseEventIsInThumb): Cast from EventTarget to Node as appropriate.
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::dispatchEvent): (WebCore::XMLHttpRequest::callReadyStateChangeListener): Set target and currentTarget before dispatching.
  • xml/xmlhttprequest.h: Made EventTarget methods virtual, added a bool tempEvent parameter to match EventTargetNode. (WebCore::XMLHttpRequest::toXMLHttpRequest): Added poor man's RTTI to upcast from EventTarget. (WebCore::XMLHttpRequest::refEventTarget): (WebCore::XMLHttpRequest::derefEventTarget):

LayoutTests:

  • fast/dom/xmlhttprequest-get-expected.txt:
  • http/tests/xmlhttprequest/event-target-expected.txt:
  • http/tests/xmlhttprequest/event-target.html:
1:08 PM Changeset in webkit [18237] by andersca
  • 12 edits in trunk

WebCore:

Reviewed by Darin.

More loader cleanup, use KURL instead of NSURL in a couple of places.

  • loader/DocumentLoader.h:
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/ResourceLoader.h:
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::prepareForLoadStart):
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::willUseArchive):
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::load):

WebKit:

Reviewed by Darin.

Update for WebCore changes.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::willUseArchive):
  • WebView/WebDataSource.mm: (-[WebDataSource _URLForHistory]):
12:40 PM Changeset in webkit [18236] by ap
  • 13 edits
    3 moves
    5 adds
    2 deletes in trunk

2006-12-15 Marvin Decker <​marv.decker@gmail.com>

Reviewed by Darin and Alexey.

Fix the Windows build, move various Client implementations out of
WebCore and into WebKit.

WebCore:

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • bridge/win/ChromeClientWin.h: Removed.
  • bridge/win/ContextMenuClientWin.h: Removed.
  • bridge/win/EditorClientWin.h: Removed.
  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::FrameWin):
  • bridge/win/FrameWin.h:
  • loader/win/FrameLoaderClientWin.cpp: Removed.
  • loader/win/FrameLoaderClientWin.h: Removed.
  • platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::start):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::DocumentLoader::URL): (WebCore::FrameLoader::load): (WebCore::FrameLoader::createFrame): (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::clear): (WebCore::Pasteboard::~Pasteboard): (WebCore::PolicyCheck::call): (WebCore::PopupMenu::PopupMenu): (WebCore::ResourceHandle::loadsBlocked): (WebCore::ResourceLoader::cancel):

WebKit:

  • COM/ChromeClientWin.cpp: Added. (ChromeClientWin::~ChromeClientWin): (ChromeClientWin::chromeDestroyed): (ChromeClientWin::setWindowRect): (ChromeClientWin::windowRect): (ChromeClientWin::pageRect): (ChromeClientWin::scaleFactor): (ChromeClientWin::focus): (ChromeClientWin::unfocus): (ChromeClientWin::createWindow): (ChromeClientWin::createModalDialog): (ChromeClientWin::show): (ChromeClientWin::canRunModal): (ChromeClientWin::runModal): (ChromeClientWin::setToolbarsVisible): (ChromeClientWin::toolbarsVisible): (ChromeClientWin::setStatusbarVisible): (ChromeClientWin::statusbarVisible): (ChromeClientWin::setScrollbarsVisible): (ChromeClientWin::scrollbarsVisible): (ChromeClientWin::setMenubarVisible): (ChromeClientWin::menubarVisible): (ChromeClientWin::setResizable): (ChromeClientWin::addMessageToConsole):
  • COM/ChromeClientWin.h: Added.
  • COM/ContextMenuClientWin.cpp: Added. (ContextMenuClientWin::~ContextMenuClientWin): (ContextMenuClientWin::contextMenuDestroyed): (ContextMenuClientWin::addCustomContextMenuItems): (ContextMenuClientWin::contextMenuItemSelected): (ContextMenuClientWin::copyLinkToClipboard): (ContextMenuClientWin::downloadURL): (ContextMenuClientWin::copyImageToClipboard): (ContextMenuClientWin::lookUpInDictionary): (ContextMenuClientWin::speak): (ContextMenuClientWin::stopSpeaking):
  • COM/ContextMenuClientWin.h: Added.
  • COM/EditorClientWin.cpp: Added. (EditorClientWin::~EditorClientWin): (EditorClientWin::pageDestroyed): (EditorClientWin::shouldDeleteRange): (EditorClientWin::shouldShowDeleteInterface): (EditorClientWin::smartInsertDeleteEnabled): (EditorClientWin::isContinuousSpellCheckingEnabled): (EditorClientWin::toggleContinuousSpellChecking): (EditorClientWin::isGrammarCheckingEnabled): (EditorClientWin::toggleGrammarChecking): (EditorClientWin::spellCheckerDocumentTag): (EditorClientWin::selectWordBeforeMenuEvent): (EditorClientWin::isEditable): (EditorClientWin::shouldBeginEditing): (EditorClientWin::shouldEndEditing): (EditorClientWin::shouldInsertNode): (EditorClientWin::shouldInsertText): (EditorClientWin::shouldApplyStyle): (EditorClientWin::didBeginEditing): (EditorClientWin::respondToChangedContents): (EditorClientWin::didEndEditing): (EditorClientWin::registerCommandForUndo): (EditorClientWin::registerCommandForRedo): (EditorClientWin::clearUndoRedoOperations): (EditorClientWin::canUndo): (EditorClientWin::canRedo): (EditorClientWin::undo): (EditorClientWin::redo):
  • COM/EditorClientWin.h: Added.
  • COM/WebFrame.cpp: (WebFrame::WebFrame): (WebFrame::initWithName):
  • COM/WebFrame.h:
  • COM/WebFrameLoaderClient.cpp: Added. (WebFrameLoaderClient::WebFrameLoaderClient): (WebFrameLoaderClient::~WebFrameLoaderClient): (WebFrameLoaderClient::frameLoaderDestroyed): (WebFrameLoaderClient::hasWebView): (WebFrameLoaderClient::hasFrameView): (WebFrameLoaderClient::hasBackForwardList): (WebFrameLoaderClient::resetBackForwardList): (WebFrameLoaderClient::provisionalItemIsTarget): (WebFrameLoaderClient::loadProvisionalItemFromPageCache): (WebFrameLoaderClient::invalidateCurrentItemPageCache): (WebFrameLoaderClient::privateBrowsingEnabled): (WebFrameLoaderClient::makeDocumentView): (WebFrameLoaderClient::makeRepresentation): (WebFrameLoaderClient::forceLayout): (WebFrameLoaderClient::forceLayoutForNonHTML): (WebFrameLoaderClient::updateHistoryForCommit): (WebFrameLoaderClient::updateHistoryForBackForwardNavigation): (WebFrameLoaderClient::updateHistoryForReload): (WebFrameLoaderClient::updateHistoryForStandardLoad): (WebFrameLoaderClient::updateHistoryForInternalLoad): (WebFrameLoaderClient::updateHistoryAfterClientRedirect): (WebFrameLoaderClient::setCopiesOnScroll): (WebFrameLoaderClient::tokenForLoadErrorReset): (WebFrameLoaderClient::resetAfterLoadError): (WebFrameLoaderClient::doNotResetAfterLoadError): (WebFrameLoaderClient::willCloseDocument): (WebFrameLoaderClient::detachedFromParent1): (WebFrameLoaderClient::detachedFromParent2): (WebFrameLoaderClient::detachedFromParent3): (WebFrameLoaderClient::detachedFromParent4): (WebFrameLoaderClient::loadedFromPageCache): (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidReceiveIcon): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): (WebFrameLoaderClient::dispatchShow): (WebFrameLoaderClient::cancelPolicyCheck): (WebFrameLoaderClient::dispatchWillSubmitForm): (WebFrameLoaderClient::dispatchDidLoadMainResource): (WebFrameLoaderClient::clearLoadingFromPageCache): (WebFrameLoaderClient::isLoadingFromPageCache): (WebFrameLoaderClient::revertToProvisionalState): (WebFrameLoaderClient::clearUnarchivingState): (WebFrameLoaderClient::progressStarted): (WebFrameLoaderClient::progressCompleted): (WebFrameLoaderClient::setMainFrameDocumentReady): (WebFrameLoaderClient::willChangeTitle): (WebFrameLoaderClient::didChangeTitle): (WebFrameLoaderClient::finishedLoading): (WebFrameLoaderClient::finalSetupForReplace): (WebFrameLoaderClient::setDefersLoading): (WebFrameLoaderClient::isArchiveLoadPending): (WebFrameLoaderClient::cancelPendingArchiveLoad): (WebFrameLoaderClient::clearArchivedResources): (WebFrameLoaderClient::canHandleRequest): (WebFrameLoaderClient::canShowMIMEType): (WebFrameLoaderClient::representationExistsForURLScheme): (WebFrameLoaderClient::generatedMIMETypeForURLScheme): (WebFrameLoaderClient::frameLoadCompleted): (WebFrameLoaderClient::restoreScrollPositionAndViewState): (WebFrameLoaderClient::provisionalLoadStarted): (WebFrameLoaderClient::shouldTreatURLAsSameAsCurrent): (WebFrameLoaderClient::addHistoryItemForFragmentScroll): (WebFrameLoaderClient::didFinishLoad): (WebFrameLoaderClient::prepareForDataSourceReplacement): (WebFrameLoaderClient::setTitle): (WebFrameLoaderClient::userAgent):
  • COM/WebFrameLoaderClient.h: Added.
  • COM/WebKitDLL.h:
  • WebKit.vcproj/WebKit.vcproj:

WebKitTools:

  • Spinneret/Spinneret.sln:
12:11 PM Changeset in webkit [18235] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11842
REGRESSION: Using Safari's snippet editor leaves applewebdata: URLs in history


  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::URLForHistory): Don't return appleweburls without an unreachable url.
11:48 AM Changeset in webkit [18234] by andersca
  • 12 edits in trunk

WebCore:

Reviewed by Darin.

Replace more instances of NSError with ResourceError.


Also remove a check for a selector that was added pre-Tiger.


  • WebCore.exp:
  • loader/DocumentLoader.h:
  • loader/FrameLoader.h:
  • loader/ResourceLoader.h:
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::setMainDocumentError): (WebCore::DocumentLoader::mainDocumentError): (WebCore::DocumentLoader::clearErrors): (WebCore::DocumentLoader::mainReceivedError):
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::cancelMainResourceLoad): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::mainReceivedError): (WebCore::FrameLoader::cancelledError): (WebCore::FrameLoader::fileDoesNotExistError): (WebCore::FrameLoader::handleUnimplementablePolicy): (WebCore::FrameLoader::setMainDocumentError): (WebCore::FrameLoader::mainReceivedCompleteError): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::loadedResourceFromMemoryCache): (WebCore::FrameLoader::loadResourceSynchronously):
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::willSendRequest): (WebCore::ResourceLoader::didCancel): (WebCore::ResourceLoader::cancel): (WebCore::ResourceLoader::cancelledError):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didCancel):

WebKit:

Reviewed by Darin.

Include ResourceError.h.


  • Plugins/WebNetscapePluginStream.mm:
  • WebKit.xcodeproj/project.pbxproj:
11:31 AM Changeset in webkit [18233] by rwlbuis
  • 13 edits
    5 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11824
CSSStyleSheet.title property is always null

Set title on the stylesheet just after creating it, for the HTML
elements <link> and <style>.

4:26 AM Changeset in webkit [18232] by zack
  • 3 edits in trunk/WebCore

Fix compilation (from lars)

Dec 14, 2006:

11:50 PM Changeset in webkit [22673] by ggaren
  • 1 edit in branches/WindowsMerge/WebCore/ChangeLog

ChangeLog fixup

11:46 PM Changeset in webkit [22672] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by NOBODY (OOPS!).

WARNING: NO TEST CASES ADDED OR CHANGED

  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::passMousePressEventToSubframe): (WebCore::EventHandler::passMouseMoveEventToSubframe): (WebCore::EventHandler::passMouseReleaseEventToSubframe): (WebCore::EventHandler::passWheelEventToSubframe):
8:10 PM Changeset in webkit [22671] by adele
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Update PopupMenu code to use new PopupMenuClient instead of RenderMenuList.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::PopupMenu): (WebCore::PopupMenu::show): (WebCore::PopupMenu::calculatePositionAndSize): (WebCore::PopupMenu::setFocusedIndex): (WebCore::PopupMenu::focusedIndex): (WebCore::PopupMenu::focusFirst): (WebCore::PopupMenu::focusLast): (WebCore::PopupMenu::down): (WebCore::PopupMenu::up): (WebCore::PopupMenu::paint): (WebCore::PopupWndProc):
8:04 PM Changeset in webkit [18231] by andersca
  • 21 edits in trunk

WebCore:

Reviewed by Maciej.

Use char* pointer + length instead of NSData in a bunch of places.

  • loader/DocumentLoader.h:
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.h:
  • loader/NetscapePlugInStreamLoader.h:
  • loader/ResourceLoader.h: (WebCore::ResourceLoader::willStopBufferingData):
  • loader/SubresourceLoader.h:
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::commitLoad): (WebCore::DocumentLoader::receivedData): (WebCore::DocumentLoader::setupForReplaceByMIMEType):
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::didReceiveData): (WebCore::FrameLoader::receivedData): (WebCore::FrameLoader::committedLoad):
  • loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::addData): (WebCore::MainResourceLoader::didReceiveData):
  • loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::didReceiveData):
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::addData): (WebCore::ResourceLoader::didReceiveData): (WebCore::ResourceLoader::willStopBufferingData):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didReceiveData):
  • platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::willStopBufferingData):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):

WebKit:

Reviewed by Maciej.

Update for WebCore changes.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::committedLoad): (WebFrameLoaderClient::deliverArchivedResources):
  • WebView/WebView.mm: (-[WebView _incrementProgressForIdentifier:length:]):
  • WebView/WebViewInternal.h:
8:02 PM Changeset in webkit [18230] by adele
  • 5 edits in trunk/WebCore

Reviewed by Adam.

Added PopupMenuClient class so the PopupMenu class no longer needs to know
about the RenderMenuList or the DOM.

  • platform/PopupMenu.h: (WebCore::PopupMenuClient::~PopupMenuClient): (WebCore::PopupMenu::create): Made this protected so PopupMenu can be subclassed. (WebCore::PopupMenu::disconnectClient): Renamed from disconnectMenuList. (WebCore::PopupMenu::client): Added.
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::PopupMenu): Created using PopupMenuClient instead of RenderMenuList. (WebCore::PopupMenu::populate): Asks the client for info about the list items instead of looking at the DOM or the renderer. (WebCore::PopupMenu::show): ditto. (WebCore::PopupMenu::hide): ditto.
  • rendering/RenderMenuList.h: Now also inherits from PopupMenuClient. (WebCore::RenderMenuList::shouldPopOver): Added. Tells the popup whether the menu should pop over the client, or under.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::~RenderMenuList): Calls disconnectClient(). (WebCore::RenderMenuList::calcMinMaxWidth): Removed unnecessary (and harmful) call to updateFromElement. updateFromElmeent can add children, and you don't want to do that in the middle of calculating width. (WebCore::RenderMenuList::itemText): Added PopupClient method to provide information about the items in the menu list. (WebCore::RenderMenuList::itemIsEnabled): ditto. (WebCore::RenderMenuList::itemStyle): ditto. (WebCore::RenderMenuList::clientStyle): ditto. (WebCore::RenderMenuList::clientDocument): ditto. (WebCore::RenderMenuList::clientPaddingLeft): ditto. (WebCore::RenderMenuList::clientPaddingRight): ditto. (WebCore::RenderMenuList::listSize): ditto. (WebCore::RenderMenuList::selectedIndex): ditto. (WebCore::RenderMenuList::itemIsSeparator): ditto. (WebCore::RenderMenuList::itemIsLabel): ditto. (WebCore::RenderMenuList::itemIsSelected): ditto. (WebCore::RenderMenuList::setTextFromItem): ditto.
7:43 PM Changeset in webkit [18229] by ggaren
  • 8 edits
    2 adds in trunk

LayoutTests:

Updated these results now that I've rolled out my change to move focus
to the page level:


  • editing/undo/undo-iframe-location-change-expected.txt:
  • fast/forms/focus2-expected.txt:


Added this test for one of the regressions that moving focus to the page
level caused:


  • editing/selection/inactive-selection-expected.txt: Added.
  • editing/selection/inactive-selection.html: Added.

WebCore:

Fixed <rdar://problem/4882713> GMAIL (REGRESSION): Can't apply font style,
foreground or background to selected text


Also <rdar://problem/4883751> REGRESSION: Caret fails to insert itself
automatically in a new note window


I'm rolling out my change to move focus to the page level because it caused
too many unexpected and bizarre regressions. Our code relies on focus
being per-document so that it can make focus changes that are effectively
no-ops, and so that it can conflate focus and selection in some cases (a bad
idea, since they're not the same).


Hopefully we can revisit this, along with hover and active, in the future.

  • dom/Document.cpp: (WebCore::widgetForNode): (WebCore::relinquishesEditingFocus): (WebCore::acceptsEditingFocus): (WebCore::clearSelectionIfNeeded): (WebCore::Document::removedLastRef): (WebCore::Document::detach): (WebCore::Document::focusedNodeDetached): (WebCore::Document::setFocusedNode):
  • dom/Document.h: (WebCore::Document::focusedNode):
  • page/FocusController.cpp:
  • page/FocusController.h:
7:34 PM Changeset in webkit [22670] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

7:27 PM Changeset in webkit [18228] by sfalken
  • 1 copy in tags/Safari-521.32.3b

New tag.

7:14 PM Changeset in webkit [18227] by mjs
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

  • fix failing drag & drop layout tests
  • platform/mac/KURLMac.mm: (WebCore::KURL::getNSURL): Turn empty KURL into empty NSURL, but null KURL into nil.
6:25 PM Changeset in webkit [18226] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/4827549> need NSRange-based selection support exposed.

  • WebView/WebFrame.mm: (-[WebFrame _selectedNSRange]): (-[WebFrame _selectNSRange:]):
  • WebView/WebFramePrivate.h:
6:18 PM Changeset in webkit [22669] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-12-14 Steve Falkenburg <​sfalken@apple.com>

Build fix.

  • platform/win/TemporaryLinkStubs.cpp: (SubresourceLoader::didCancel):
5:30 PM Changeset in webkit [18225] by sfalken
  • 2 edits in trunk/WebCore

2006-12-14 Steve Falkenburg <​sfalken@apple.com>

Build fix.

  • loader/MainResourceLoader.h:
5:24 PM Changeset in webkit [18224] by bdash
  • 3 edits in branches/Safari-2-0-branch/WebKit

2006-12-14 Mark Rowe <​mrowe@apple.com>

Merged fix from TOT to Safari-2-0-branch.

2006-11-14 Alexey Proskuryakov <​ap@webkit.org>

Reviewed by Tim H.

​http://bugs.webkit.org/show_bug.cgi?id=3387
Redundant keydown, keypress, keyup events sent for arrow keys

Added another layer of ugly hacks around AppKit event dispatching.

  1. For arrow keys, keyDown: is invoked after performKeyEquivalent:, so had to store _private->keyDownEvent in both methods, and make it persist after leaving them.
  1. For Esc, AppKit calls performKeyEquivalent: with a fake event of some kind, use [NSApp currentEvent] to check for this to prevent it from being passed to WebCore.

Test: manual-tests/arrow-key-events.html

  • WebView/WebHTMLView.m: (-[NSMutableDictionary dealloc]): (-[NSArray keyDown:]): (-[NSArray keyUp:]): (-[NSArray performKeyEquivalent:]):
  • WebView/WebHTMLViewInternal.h:
4:58 PM Changeset in webkit [22668] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2006-12-14 Steve Falkenburg <​sfalken@apple.com>

B&I build fix. Added JSSVGPODTypeWrapper.h to the vcproj.

  • WebCore.vcproj/WebCore.vcproj:
4:41 PM Changeset in webkit [18223] by andersca
  • 18 edits in trunk

WebCore:

Reviewed by John.

Convert a bunch of NSErrors to ResourceError.


Make the ResourceError accessor functions const.


  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/MainResourceLoader.h:
  • loader/NetscapePlugInStreamLoader.h:
  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.h:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::didFailToLoad): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::interruptionForPolicyChangeError):
  • loader/mac/MainResourceLoaderMac.mm: (WebCore::MainResourceLoader::receivedError): (WebCore::MainResourceLoader::didCancel): (WebCore::MainResourceLoader::interruptionForPolicyChangeError): (WebCore::MainResourceLoader::didFail):
  • loader/mac/NetscapePlugInStreamLoaderMac.mm: (WebCore::NetscapePlugInStreamLoader::didFail): (WebCore::NetscapePlugInStreamLoader::didCancel):
  • loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::didFail): (WebCore::ResourceLoader::didCancel):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel):
  • platform/network/ResourceError.h: (WebCore::ResourceError::domain): (WebCore::ResourceError::errorCode): (WebCore::ResourceError::failingURL): (WebCore::ResourceError::localizedDescription): (WebCore::ResourceError::unpackPlatformErrorIfNeeded):

WebKit:

Reviewed by John.

Update for WebKit changes.


  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::dispatchDidFailProvisionalLoad): (WebFrameLoaderClient::dispatchDidFailLoad): (WebFrameLoaderClient::dispatchUnableToImplementPolicy): (WebFrameLoaderClient::setMainDocumentError): (WebFrameLoaderClient::cancelledError): (WebFrameLoaderClient::cannotShowURLError): (WebFrameLoaderClient::interruptForPolicyChangeError): (WebFrameLoaderClient::cannotShowMIMETypeError): (WebFrameLoaderClient::fileDoesNotExistError): (WebFrameLoaderClient::shouldFallBack):
4:10 PM Changeset in webkit [18222] by staikos
  • 3 edits in trunk

Link, after the last loader changes. Please update this directory with stubs when modifying the loader. (also fixes some Changelog typos)

3:48 PM Changeset in webkit [22667] by adele
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

Build Fix.

  • WebContextMenuClient.h:
3:40 PM Changeset in webkit [22666] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adele.

Build fix.

  • platform/win/TemporaryLinkStubs.cpp: (DocumentLoader::URL): (ResourceHandle::loadResourceSynchronously):
3:30 PM Changeset in webkit [18221] by justing
  • 11 edits
    8 adds in trunk

LayoutTests:

Reviewed by harrison

<rdar://problem/4866671>
CrashTracer: 1 crashes in Mail after deleting a list item at WebCore::DeleteSelectionCommand::doApply()

  • editing/deleting/4866671-expected.checksum: Added.
  • editing/deleting/4866671-expected.png: Added.
  • editing/deleting/4866671-expected.txt: Added.
  • editing/deleting/4866671.html: Added.
  • editing/pasteboard/4866671-expected.checksum: Added.
  • editing/pasteboard/4866671-expected.png: Added.
  • editing/pasteboard/4866671-expected.txt: Added.
  • editing/pasteboard/4866671.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4866671>
CrashTracer: 1 crashes in Mail after deleting a list item at WebCore::DeleteSelectionCommand::doApply()


Don't allow VisiblePositions inside -webkit-user-select:none regions.
Renamed inRenderedContent to isCandidate.

  • dom/Document.cpp: (WebCore::Document::updateSelection):
  • dom/Position.cpp: (WebCore::Position::previousCharacterPosition): (WebCore::Position::nextCharacterPosition): (WebCore::nodeIsUserSelectNone): (WebCore::Position::isCandidate): (WebCore::Position::rendersInDifferentPosition):
  • dom/Position.h:
  • editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
  • editing/VisiblePosition.cpp: (WebCore::VisiblePosition::canonicalPosition):
  • editing/htmlediting.cpp: (WebCore::nextCandidate): (WebCore::nextVisuallyDistinctCandidate): (WebCore::previousCandidate): (WebCore::previousVisuallyDistinctCandidate):
  • editing/visible_units.cpp: (WebCore::previousLinePosition): (WebCore::nextLinePosition): (WebCore::startOfParagraph):
  • page/Frame.cpp: (WebCore::Frame::styleForSelectionStart):
3:16 PM Changeset in webkit [18220] by hyatt
  • 2 edits in trunk/WebCore

Get rid of the containsStart check and just rely on the selectionState
bits. This allows selection gap filling to behave properly in the presence
of inline blocks and inline tables on lines when the selection originates
inside the inline block.

Reviewed by ggaren

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::fillInlineSelectionGaps):
2:13 PM Changeset in webkit [18219] by andersca
  • 6 edits in trunk/WebCore

Reviewed by John.


General loader cleanup, convert NSURLResponse to ResourceResponse in some places.


  • loader/DocumentLoader.h:
  • loader/SubresourceLoader.h:
  • loader/mac/DocumentLoaderMac.mm: (WebCore::DocumentLoader::addResponse):
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::opened):
  • loader/mac/SubresourceLoaderMac.mm: (WebCore::SubresourceLoader::create):
1:04 PM Changeset in webkit [22665] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Fix the build.


  • platform/win/TemporaryLinkStubs.cpp: (FrameLoader::loadResourceSynchronously): (ResourceHandle::loadResourceSynchronously):
12:56 PM Changeset in webkit [22664] by adachan
  • 6 edits in branches/WindowsMerge/WebKitWin

2006-12-14 Ada Chan <​adachan@apple.com>

Reviewed by Steve.

Implemented WebChromeClient::pageRect() to return the bounds of the WebView.
Implemented WebFrame::parentFrame().
Added a temporary implementation of WebDataSource::isLoading().

12:50 PM Changeset in webkit [18218] by andersca
  • 15 edits in trunk/WebCore

Reviewed by Darin.

Add loadResourceSynchronously to ResourceHandle and have FrameLoader use it instead of
calling NSURLConnection directly.

Add an isNull flag to ResourceError so we can convert correctly between nil NSErrors and ResourceErrors.

Get rid of ServeSynchronousRequest and use the loader instead.


  • WebCore.exp:
  • dom/XMLTokenizer.cpp: (WebCore::openFunc):
  • loader/FrameLoader.h:
  • loader/LoaderFunctions.h:
  • loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::canLoad): (WebCore::FrameLoader::loadResourceSynchronously):
  • loader/mac/LoaderFunctionsMac.mm:
  • platform/network/ResourceError.h: (WebCore::ResourceError::ResourceError): (WebCore::ResourceError::isNull):
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceRequest.cpp: (WebCore::ResourceRequest::isConditional):
  • platform/network/ResourceRequest.h:
  • platform/network/mac/ResourceErrorMac.mm: (-[NSError WebCore]):
  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::loadResourceSynchronously):
  • xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc):
  • xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::send):
12:42 PM Changeset in webkit [18217] by zimmermann
  • 6 edits
    1 add in trunk/WebCore

Reviewed by Darin.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=11830

Fix fundamental problems with JS SVG POD types.
(currently: FloatPoint/FloatRect/AffineTransform)

11:30 AM Changeset in webkit [18216] by thatcher
  • 4 edits in trunk

top level:

Reviewed by Brady.

  • Makefile.shared: use $PIPESTATUS[0] and a sub-shell to exit with xcodebuild's exit status

WebKitTools:

Reviewed by Brady.

  • Makefile.shared: use $PIPESTATUS[0] and a sub-shell to exit with xcodebuild's exit status
10:05 AM Changeset in webkit [18215] by ap
  • 2 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11828
Fix a leak of NSURLRequest on each update - RetainPtr retains the object itself.

  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest):
9:32 AM Changeset in webkit [18214] by hausmann
  • 2 edits in trunk/WebKitQt

2006-12-14 Simon Hausmann <​hausmann@kde.org>

Reviewed by Zack.

  • QtLauncher/QtLauncher.pro: Link this little test program with rpath, for convenience. (This is never going to get installed anyway)
8:47 AM Changeset in webkit [18213] by hausmann
  • 2 edits in trunk/WebCore

2006-12-14 Simon Hausmann <​hausmann@kde.org>

Reviewed by Zack Rusin.

  • WebCore.pro: Clean up the xpath grammar generation rule.
6:22 AM Changeset in webkit [18212] by zack
  • 2 edits in trunk/WebCore

Make it link with temporary stubs (from lars, icefox)

3:40 AM Changeset in webkit [18211] by zack
  • 4 edits in trunk/WebCore

Compilation fixes for the Qt port after last nights changes

2:36 AM Changeset in webkit [18210] by rwlbuis
  • 10 edits
    4 adds in trunk

Reviewed by Oliver.

​http://bugs.webkit.org/show_bug.cgi?id=11726
SVG Image do not take into account clip/overflow when hit testing

Take into account the overflowRect when hit-testing <svg> container.

12:50 AM Changeset in webkit [18209] by bdash
  • 2 edits in branches/Safari-2-0-branch/WebKit

2006-12-13 Mark Rowe <​mrowe@apple.com>

Merged fix from TOT to Safari-2-0-branch.

2006-05-14 Mitz Pettel <​opendarwin.org@mitzpettel.com>

Reviewed by Darin.

Manual test: manual-tests/dom-manipulation-on-resize.html

  • WebView/WebHTMLView.m: (-[NSArray layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Relayout if necessary after sending the resize event.
Note: See TracTimeline for information about the timeline view.