Context Navigation

← Previous Period
Next Period →

Timeline

Jan 15, 2007:

11:50 PM Changeset in webkit [18882] by rwlbuis

12 edits
4 adds in trunk

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=12272
SVG picture is clipped (edges not visible)

Expose css dpi constant and use it for svg, making
1in amount to 96 pixels like for html.

11:23 PM Changeset in webkit [18881] by beidson

2 edits in trunk/WebKitSite

Reviewed by Maciej

coding/coding-style.html: Added switch/case indentation rules

10:50 PM Changeset in webkit [22773] by beidson

3 edits
3 adds in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adam

Hook up AuthenticationChallenge to CF network.
Call up through appropriate client methods through to WebFrame (FrameLoaderClient) at
which point my upcoming implementation for the IWebURL<auth> classes will be used

WebCore.vcproj/WebCore.vcproj:
platform/network/cf/AuthenticationCF.cpp: Added. (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::createCF): (WebCore::core):
platform/network/cf/AuthenticationCF.h: Added.
platform/network/cf/ResourceErrorCF.cpp: Added. (WebCore::ResourceError::ResourceError): (WebCore::ResourceError::operator CFStreamError):
platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didReceiveChallenge): (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::receivedCredential): (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential): (WebCore::ResourceHandle::receivedCancellation):

10:39 PM Changeset in webkit [18880] by beidson

6 edits in trunk/WebCore

WebCore:

Reviewed by Adam

CFNet additions

platform/network/AuthenticationChallenge.cpp: (WebCore::operator==):
platform/network/AuthenticationChallenge.h: (WebCore::AuthenticationChallenge::sourceHandle): (WebCore::AuthenticationChallenge::cfURLAuthChallengeRef):
platform/network/ResourceError.h:
platform/network/ResourceHandle.h:
platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):

9:25 PM Changeset in webkit [18879] by eseidel

3 edits
4 adds in trunk

2007-01-15 Eric Seidel <eric@webkit.org>

Reviewed by hyatt.

Don't map attributes in namespaces other than null to CSS properties.

Test: svg/custom/attribute-namespace-check.svg

ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName):

8:46 PM Changeset in webkit [18878] by darin

2 edits in trunk/WebCore

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=11112 add a drop shadow to the hand cursor used for links

Resources/linkCursor.png: Added a drop shadow.

8:43 PM Changeset in webkit [18877] by darin

5 edits
4 adds in trunk

LayoutTests:

test for http://bugs.webkit.org/show_bug.cgi?id=12190 REGRESSION: Placeholder text does not reflect dynamic updates

fast/forms/placeholder-set-attribute-expected.checksum: Added.
fast/forms/placeholder-set-attribute-expected.png: Added.
fast/forms/placeholder-set-attribute-expected.txt: Added.
fast/forms/placeholder-set-attribute.html: Added.

WebCore:

Reviewed by Adam.

fix http://bugs.webkit.org/show_bug.cgi?id=12190 REGRESSION: Placeholder text does not reflect dynamic updates

Test: fast/forms/placeholder-set-attribute.html

html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler): Call onSearch on the element since I removed it from the renderer.

rendering/RenderTextControl.h: Added explicit virtual keywords for overrides of virtual functions. Removed the unneeded onSearch function. Made the inheritance from PopupMenuClient be private, and made the overrides all private. Replaced the showPlaceholderIfNeeded and hidePlaceholderIfNeeded functions with updatePlaceholder.
rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createResultsButtonStyle): Added an assertion. (WebCore::RenderTextControl::updatePlaceholder): Added. Replaces the two functions, showPlaceholderIfNeeded and hidePlaceholderIfNeeded. (WebCore::RenderTextControl::updateFromElement): Added call to updatePlaceholder before updating the value. Also improved the structure of the function and corrected incorrect use of copy and replace. (WebCore::RenderTextControl::updateCancelButtonVisibility): Added an assertion and removed an unneeded local variable. (WebCore::RenderTextControl::subtreeHasChanged): Removed an unneeded null check and virtual function calls. (WebCore::RenderTextControl::forwardEvent): Replaced calls to the old functions with calls to updatePlaceholder. (WebCore::RenderTextControl::selectionChanged): Changed code to dispatch the select event directly -- I plan to remove the onSelect function, which was only called here. (WebCore::RenderTextControl::autosaveName): Removed too-specific cast and local variable. (WebCore::RenderTextControl::addSearchResult): Added assertion and changed variable name for clarity. (WebCore::RenderTextControl::valueChanged): Changed code to check for empty autosave name instead of null for consistency with other call sites that manage the autosave name. Also changed the code that dispatches an event to call onSearch on the input element so we don't need our own function.

8:01 PM Changeset in webkit [18876] by eseidel

4 edits in trunk/WebCore

2007-01-15 Eric Seidel <eric@webkit.org>

Reviewed by hyatt.

Fix SVGStyledElement::parseMappedAttribute to only map SVG-allowed CSS properties
(i.e. width is no longer mapped to CSS for SVG)
Add SVGStyledElement::mapToEntry to allow RenderStyle-sharing
http://bugs.webkit.org/show_bug.cgi?id=12060

dom/MappedAttributeEntry.h: (WebCore::):
ksvg2/svg/SVGStyledElement.cpp: (WebCore::cssPropertyIdForName): new helper (WebCore::mapAttributeToCSSProperty): new helper (WebCore::SVGStyledElement::cssPropertyIdForSVGAttributeName): new helper (WebCore::SVGStyledElement::mapToEntry): added. (WebCore::SVGStyledElement::parseMappedAttribute): use cssPropertyIdForSVGAttributeName
ksvg2/svg/SVGStyledElement.h:

6:31 PM Changeset in webkit [22772] by andersca

2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

Fix: <rdar://problem/4925504> ASSERT when finished running iBench HTML Load Speed

WebFrame.cpp: (WebFrame::cancelledError): Return a pseudo-CFNet cancelled error instead of a null ResourceError.

4:53 PM Changeset in webkit [18875] by justing

6 edits
4 adds in trunk

LayoutTests:

Reviewed by mjs

<rdar://problem/4810960>
Gmail Editor: window.focus() called on keyDown (9640)

editing/input/attributed-substring-from-range-lines.html-disabled:
fast/events/keydown-1-expected.checksum: Added.
fast/events/keydown-1-expected.png: Added.
fast/events/keydown-1-expected.txt: Added.
fast/events/keydown-1.html: Added.

WebKit:

Reviewed by mjs

<rdar://problem/4810960>
Gmail Editor: window.focus() called on keyDown (9640)

The window's keydown event handler was being called
instead of the editable subframe's if there was a key binding
for the key event.

WebView/WebHTMLView.mm: (-[WebHTMLView performKeyEquivalent:]): Don't send the event to WebCore unless this WebHTMLView is the firstResponder.

WebKitTools:

Reviewed by mjs

<rdar://problem/4810960>
Gmail Editor: window.focus() called on keyDown (9640)

DumpRenderTree/EventSendingController.m: Send the keyDown event to the firstResponder, not the event's locationInWindow. A key press's locationInWindow is meaningless and just a dummy coordinate.

4:49 PM Changeset in webkit [18874] by eseidel

472 edits in trunk/WebCore

2007-01-15 Eric Seidel <eric@webkit.org>

Reviewed by bdash.

Update header guards to follow new style guidelines using new clean-header-guards script.

bindings/js/JSHTMLElementWrapperFactory.h:
bindings/js/JSHTMLInputElementBase.h:
bindings/js/JSHTMLOptionElementConstructor.h:
bindings/js/JSSVGElementWrapperFactory.h:
bindings/js/JSSVGPODTypeWrapper.h:
bindings/js/JSXMLHttpRequest.h:
bindings/js/JSXSLTProcessor.h:
bindings/js/kjs_binding.h:
bindings/js/kjs_css.h:
bindings/js/kjs_dom.h:
bindings/js/kjs_domnode.h:
bindings/js/kjs_events.h:
bindings/js/kjs_html.h:
bindings/js/kjs_navigator.h:
bindings/js/kjs_proxy.h:
bindings/js/kjs_traversal.h:
bindings/js/kjs_window.h:
bridge/EditorClient.h:
bridge/History.h:
css/CSSStyleSheet.h:
css/CSSValue.h:
css/CSSValueList.h:
css/DashboardRegion.h:
css/FontFamilyValue.h:
css/FontValue.h:
css/MediaFeatureNames.h:
css/MediaList.h:
css/Pair.h:
css/RectImpl.h:
css/ShadowValue.h:
css/StyleBase.h:
css/StyleList.h:
css/StyleSheet.h:
css/StyleSheetList.h:
css/cssstyleselector.h:
dom/BeforeTextInsertedEvent.h:
dom/CDATASection.h:
dom/CharacterData.h:
dom/ChildNodeList.h:
dom/Comment.h:
dom/DOMImplementation.h:
dom/DocPtr.h:
dom/Document.h:
dom/DocumentFragment.h:
dom/DocumentMarker.h:
dom/DocumentType.h:
dom/EditingText.h:
dom/Entity.h:
dom/EntityReference.h:
dom/EventNames.h:
dom/EventTargetNode.h:
dom/NameNodeList.h:
dom/NamedNodeMap.h:
dom/Node.h:
dom/NodeList.h:
dom/Notation.h:
dom/Position.h:
dom/ProcessingInstruction.h:
dom/Range.h:
dom/StyleElement.h:
dom/Text.h:
editing/AppendNodeCommand.h:
editing/ApplyStyleCommand.h:
editing/BreakBlockquoteCommand.h:
editing/CommandByName.h:
editing/CompositeEditCommand.h:
editing/DeleteButton.h:
editing/DeleteButtonController.h:
editing/DeleteFromTextNodeCommand.h:
editing/DeleteSelectionCommand.h:
editing/InsertIntoTextNodeCommand.h:
editing/InsertLineBreakCommand.h:
editing/InsertNodeBeforeCommand.h:
editing/InsertParagraphSeparatorCommand.h:
editing/InsertTextCommand.h:
editing/JoinTextNodesCommand.h:
editing/MergeIdenticalElementsCommand.h:
editing/ModifySelectionListLevel.h:
editing/MoveSelectionCommand.h:
editing/RemoveCSSPropertyCommand.h:
editing/RemoveNodeAttributeCommand.h:
editing/RemoveNodeCommand.h:
editing/RemoveNodePreservingChildrenCommand.h:
editing/ReplaceSelectionCommand.h:
editing/SetNodeAttributeCommand.h:
editing/SplitElementCommand.h:
editing/SplitTextNodeCommand.h:
editing/SplitTextNodeContainingElementCommand.h:
editing/TextGranularity.h:
editing/TypingCommand.h:
editing/WrapContentsInDummySpanCommand.h:
history/BackForwardList.h:
history/HistoryItem.h:
history/HistoryItemTimer.h:
history/PageCache.h:
html/CanvasGradient.h:
html/CanvasPattern.h:
html/CanvasRenderingContext2D.h:
html/CanvasStyle.h:
html/FormDataList.h:
html/HTMLAnchorElement.h:
html/HTMLAppletElement.h:
html/HTMLAreaElement.h:
html/HTMLBRElement.h:
html/HTMLBaseElement.h:
html/HTMLBaseFontElement.h:
html/HTMLBlockquoteElement.h:
html/HTMLBodyElement.h:
html/HTMLButtonElement.h:
html/HTMLCanvasElement.h:
html/HTMLCollection.h:
html/HTMLDListElement.h:
html/HTMLDirectoryElement.h:
html/HTMLDivElement.h:
html/HTMLElement.h:
html/HTMLElementFactory.h:
html/HTMLEmbedElement.h:
html/HTMLFieldSetElement.h:
html/HTMLFontElement.h:
html/HTMLFormCollection.h:
html/HTMLFormElement.h:
html/HTMLFrameSetElement.h:
html/HTMLGenericFormElement.h:
html/HTMLHRElement.h:
html/HTMLHeadElement.h:
html/HTMLHeadingElement.h:
html/HTMLHtmlElement.h:
html/HTMLImageElement.h:
html/HTMLImageLoader.h:
html/HTMLInputElement.h:
html/HTMLIsIndexElement.h:
html/HTMLKeygenElement.h:
html/HTMLLIElement.h:
html/HTMLLabelElement.h:
html/HTMLLegendElement.h:
html/HTMLLinkElement.h:
html/HTMLMapElement.h:
html/HTMLMarqueeElement.h:
html/HTMLMenuElement.h:
html/HTMLMetaElement.h:
html/HTMLModElement.h:
html/HTMLNameCollection.h:
html/HTMLOListElement.h:
html/HTMLObjectElement.h:
html/HTMLOptGroupElement.h:
html/HTMLOptionElement.h:
html/HTMLOptionsCollection.h:
html/HTMLParagraphElement.h:
html/HTMLParamElement.h:
html/HTMLParser.h:
html/HTMLPlugInElement.h:
html/HTMLPreElement.h:
html/HTMLQuoteElement.h:
html/HTMLScriptElement.h:
html/HTMLSelectElement.h:
html/HTMLStyleElement.h:
html/HTMLTableCaptionElement.h:
html/HTMLTableCellElement.h:
html/HTMLTableColElement.h:
html/HTMLTableElement.h:
html/HTMLTablePartElement.h:
html/HTMLTableRowElement.h:
html/HTMLTableSectionElement.h:
html/HTMLTextAreaElement.h:
html/HTMLTextFieldInnerElement.h:
html/HTMLTitleElement.h:
html/HTMLUListElement.h:
ksvg2/css/SVGRenderStyle.h:
ksvg2/css/SVGRenderStyleDefs.h:
ksvg2/events/JSSVGLazyEventListener.h:
ksvg2/events/SVGZoomEvent.h:
ksvg2/misc/KCanvasRenderingStyle.h:
ksvg2/misc/PointerEventsHitRules.h:
ksvg2/misc/SVGDocumentExtensions.h:
ksvg2/misc/SVGImageLoader.h:
ksvg2/misc/TimeScheduler.h:
ksvg2/svg/GradientAttributes.h:
ksvg2/svg/LinearGradientAttributes.h:
ksvg2/svg/PatternAttributes.h:
ksvg2/svg/RadialGradientAttributes.h:
ksvg2/svg/SVGAElement.h:
ksvg2/svg/SVGAngle.h:
ksvg2/svg/SVGAnimateColorElement.h:
ksvg2/svg/SVGAnimateElement.h:
ksvg2/svg/SVGAnimateMotionElement.h:
ksvg2/svg/SVGAnimateTransformElement.h:
ksvg2/svg/SVGAnimatedPathData.h:
ksvg2/svg/SVGAnimatedPoints.h:
ksvg2/svg/SVGAnimatedTemplate.h:
ksvg2/svg/SVGAnimationElement.h:
ksvg2/svg/SVGCircleElement.h:
ksvg2/svg/SVGClipPathElement.h:
ksvg2/svg/SVGColor.h:
ksvg2/svg/SVGComponentTransferFunctionElement.h:
ksvg2/svg/SVGCursorElement.h:
ksvg2/svg/SVGDOMImplementation.h:
ksvg2/svg/SVGDefsElement.h:
ksvg2/svg/SVGDescElement.h:
ksvg2/svg/SVGDocument.h:
ksvg2/svg/SVGElement.h:
ksvg2/svg/SVGElementInstance.h:
ksvg2/svg/SVGElementInstanceList.h:
ksvg2/svg/SVGEllipseElement.h:
ksvg2/svg/SVGExternalResourcesRequired.h:
ksvg2/svg/SVGFEBlendElement.h:
ksvg2/svg/SVGFEColorMatrixElement.h:
ksvg2/svg/SVGFEComponentTransferElement.h:
ksvg2/svg/SVGFECompositeElement.h:
ksvg2/svg/SVGFEDiffuseLightingElement.h:
ksvg2/svg/SVGFEDisplacementMapElement.h:
ksvg2/svg/SVGFEDistantLightElement.h:
ksvg2/svg/SVGFEFloodElement.h:
ksvg2/svg/SVGFEFuncAElement.h:
ksvg2/svg/SVGFEFuncBElement.h:
ksvg2/svg/SVGFEFuncGElement.h:
ksvg2/svg/SVGFEFuncRElement.h:
ksvg2/svg/SVGFEGaussianBlurElement.h:
ksvg2/svg/SVGFEImageElement.h:
ksvg2/svg/SVGFELightElement.h:
ksvg2/svg/SVGFEMergeElement.h:
ksvg2/svg/SVGFEMergeNodeElement.h:
ksvg2/svg/SVGFEOffsetElement.h:
ksvg2/svg/SVGFEPointLightElement.h:
ksvg2/svg/SVGFESpecularLightingElement.h:
ksvg2/svg/SVGFESpotLightElement.h:
ksvg2/svg/SVGFETileElement.h:
ksvg2/svg/SVGFETurbulenceElement.h:
ksvg2/svg/SVGFilterElement.h:
ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
ksvg2/svg/SVGFitToViewBox.h:
ksvg2/svg/SVGForeignObjectElement.h:
ksvg2/svg/SVGGElement.h:
ksvg2/svg/SVGGradientElement.h:
ksvg2/svg/SVGImageElement.h:
ksvg2/svg/SVGLangSpace.h:
ksvg2/svg/SVGLength.h:
ksvg2/svg/SVGLengthList.h:
ksvg2/svg/SVGLineElement.h:
ksvg2/svg/SVGLinearGradientElement.h:
ksvg2/svg/SVGList.h:
ksvg2/svg/SVGListTraits.h:
ksvg2/svg/SVGLocatable.h:
ksvg2/svg/SVGMarkerElement.h:
ksvg2/svg/SVGMaskElement.h:
ksvg2/svg/SVGMetadataElement.h:
ksvg2/svg/SVGNumberList.h:
ksvg2/svg/SVGPaint.h:
ksvg2/svg/SVGParserUtilities.h:
ksvg2/svg/SVGPathElement.h:
ksvg2/svg/SVGPathSeg.h:
ksvg2/svg/SVGPathSegArc.h:
ksvg2/svg/SVGPathSegClosePath.h:
ksvg2/svg/SVGPathSegCurvetoCubic.h:
ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
ksvg2/svg/SVGPathSegLineto.h:
ksvg2/svg/SVGPathSegLinetoHorizontal.h:
ksvg2/svg/SVGPathSegLinetoVertical.h:
ksvg2/svg/SVGPathSegList.h:
ksvg2/svg/SVGPathSegMoveto.h:
ksvg2/svg/SVGPatternElement.h:
ksvg2/svg/SVGPointList.h:
ksvg2/svg/SVGPolyElement.h:
ksvg2/svg/SVGPolygonElement.h:
ksvg2/svg/SVGPolylineElement.h:
ksvg2/svg/SVGPreserveAspectRatio.h:
ksvg2/svg/SVGRadialGradientElement.h:
ksvg2/svg/SVGRectElement.h:
ksvg2/svg/SVGRenderingIntent.h:
ksvg2/svg/SVGSVGElement.h:
ksvg2/svg/SVGScriptElement.h:
ksvg2/svg/SVGSetElement.h:
ksvg2/svg/SVGStopElement.h:
ksvg2/svg/SVGStringList.h:
ksvg2/svg/SVGStylable.h:
ksvg2/svg/SVGStyleElement.h:
ksvg2/svg/SVGStyledElement.h:
ksvg2/svg/SVGStyledLocatableElement.h:
ksvg2/svg/SVGStyledTransformableElement.h:
ksvg2/svg/SVGSwitchElement.h:
ksvg2/svg/SVGSymbolElement.h:
ksvg2/svg/SVGTRefElement.h:
ksvg2/svg/SVGTSpanElement.h:
ksvg2/svg/SVGTests.h:
ksvg2/svg/SVGTextContentElement.h:
ksvg2/svg/SVGTextElement.h:
ksvg2/svg/SVGTextPositioningElement.h:
ksvg2/svg/SVGTitleElement.h:
ksvg2/svg/SVGTransform.h:
ksvg2/svg/SVGTransformList.h:
ksvg2/svg/SVGTransformable.h:
ksvg2/svg/SVGURIReference.h:
ksvg2/svg/SVGUnitTypes.h:
ksvg2/svg/SVGUseElement.h:
ksvg2/svg/SVGViewElement.h:
ksvg2/svg/SVGZoomAndPan.h:
loader/CachedCSSStyleSheet.h:
loader/CachedImage.h:
loader/CachedXSLStyleSheet.h:
loader/DocumentLoader.h:
loader/Request.h:
loader/SubresourceLoader.h:
loader/icon/IconDataCache.h:
loader/icon/IconDatabase.h:
loader/icon/IconLoader.h:
loader/icon/SQLDatabase.h:
loader/icon/SQLStatement.h:
loader/icon/SQLTransaction.h:
page/Frame.h:
page/FrameLoadRequest.h:
page/FrameTree.h:
page/FrameView.h:
page/PageState.h:
page/Plugin.h:
page/qt/FrameQt.h:
page/qt/FrameQtClient.h:
platform/Arena.h:
platform/ArrayImpl.h:
platform/Cursor.h:
platform/DeprecatedArray.h:
platform/DeprecatedCString.h:
platform/FileChooser.h:
platform/Font.h:
platform/FontCache.h:
platform/FontData.h:
platform/FontDescription.h:
platform/FontFamily.h:
platform/GlyphBuffer.h:
platform/GlyphMap.h:
platform/GlyphWidthMap.h:
platform/Logging.h:
platform/Pasteboard.h:
platform/PlatformString.h:
platform/PlugInInfoStore.h:
platform/PopupMenu.h:
platform/PopupMenuClient.h:
platform/ScrollBar.h:
platform/ScrollView.h:
platform/SearchPopupMenu.h:
platform/Shared.h:
platform/Sound.h:
platform/SystemTime.h:
platform/Timer.h:
platform/Widget.h:
platform/cf/RetainPtr.h:
platform/gdk/ChromeClientGdk.h:
platform/gdk/FontPlatformData.h:
platform/gdk/FrameGdk.h:
platform/gdk/KeyboardCodes.h:
platform/gdk/RenderPopupMenuGdk.h:
platform/gdk/RenderThemeGdk.h:
platform/graphics/BitmapImage.h:
platform/graphics/Color.h:
platform/graphics/FloatPoint.h:
platform/graphics/FloatPoint3D.h:
platform/graphics/FloatRect.h:
platform/graphics/Icon.h:
platform/graphics/Image.h:
platform/graphics/ImageAnimationObserver.h:
platform/graphics/ImageBuffer.h:
platform/graphics/ImageSource.h:
platform/graphics/IntPoint.h:
platform/graphics/IntRect.h:
platform/graphics/IntSize.h:
platform/graphics/IntSizeHash.h:
platform/graphics/PathTraversalState.h:
platform/graphics/Pen.h:
platform/graphics/qt/ImageDecoderQt.h:
platform/graphics/svg/SVGImage.h:
platform/graphics/svg/SVGImageEmptyClients.h:
platform/graphics/svg/SVGPaintServer.h:
platform/graphics/svg/SVGPaintServerGradient.h:
platform/graphics/svg/SVGPaintServerLinearGradient.h:
platform/graphics/svg/SVGPaintServerPattern.h:
platform/graphics/svg/SVGPaintServerRadialGradient.h:
platform/graphics/svg/SVGPaintServerSolid.h:
platform/graphics/svg/SVGResource.h:
platform/graphics/svg/SVGResourceClipper.h:
platform/graphics/svg/SVGResourceFilter.h:
platform/graphics/svg/SVGResourceMarker.h:
platform/graphics/svg/SVGResourceMasker.h:
platform/graphics/svg/cg/CgSupport.h:
platform/graphics/svg/filters/SVGDistantLightSource.h:
platform/graphics/svg/filters/SVGFEBlend.h:
platform/graphics/svg/filters/SVGFEColorMatrix.h:
platform/graphics/svg/filters/SVGFEComponentTransfer.h:
platform/graphics/svg/filters/SVGFEComposite.h:
platform/graphics/svg/filters/SVGFEConvolveMatrix.h:
platform/graphics/svg/filters/SVGFEDiffuseLighting.h:
platform/graphics/svg/filters/SVGFEDisplacementMap.h:
platform/graphics/svg/filters/SVGFEFlood.h:
platform/graphics/svg/filters/SVGFEGaussianBlur.h:
platform/graphics/svg/filters/SVGFEImage.h:
platform/graphics/svg/filters/SVGFEMerge.h:
platform/graphics/svg/filters/SVGFEMorphology.h:
platform/graphics/svg/filters/SVGFEOffset.h:
platform/graphics/svg/filters/SVGFESpecularLighting.h:
platform/graphics/svg/filters/SVGFETile.h:
platform/graphics/svg/filters/SVGFETurbulence.h:
platform/graphics/svg/filters/SVGFilterEffect.h:
platform/graphics/svg/filters/SVGLightSource.h:
platform/graphics/svg/filters/SVGPointLightSource.h:
platform/graphics/svg/filters/SVGSpotLightSource.h:
platform/mac/FontPlatformData.h:
platform/mac/PlatformScrollBar.h:
platform/network/AuthenticationChallenge.h:
platform/network/Credential.h:
platform/network/HTTPHeaderMap.h:
platform/network/ProtectionSpace.h:
platform/network/ResourceError.h:
platform/network/ResourceRequest.h:
platform/network/ResourceResponse.h:
platform/network/cf/FormDataStreamCFNet.h:
platform/network/cf/ResourceRequestCFNet.h:
platform/network/cf/ResourceResponseCFNet.h:
platform/network/gdk/ResourceHandleManager.h:
platform/network/mac/AuthenticationMac.h:
platform/network/mac/FormDataStreamMac.h:
platform/network/qt/ResourceHandleManagerKDE.h:
platform/network/qt/ResourceHandleManagerQt.h:
platform/network/win/ResourceHandleWin.h:
platform/qt/FontPlatformData.h:
platform/qt/KeyboardCodes.h:
platform/qt/PlatformScrollBar.h:
platform/qt/ScrollViewCanvasQt.h:
platform/qt/SharedTimerQt.h:
platform/win/FontPlatformData.h:
platform/win/PlatformScrollBar.h:
rendering/AutoTableLayout.h:
rendering/HitTestRequest.h:
rendering/HitTestResult.h:
rendering/InlineBox.h:
rendering/InlineFlowBox.h:
rendering/Length.h:
rendering/ListMarkerBox.h:
rendering/RenderBox.h:
rendering/RenderMenuList.h:
rendering/RenderPart.h:
rendering/RenderPartObject.h:
rendering/RenderPath.h:
rendering/RenderReplaced.h:
rendering/RenderSVGContainer.h:
rendering/RenderSVGImage.h:
rendering/RenderSVGInline.h:
rendering/RenderSVGInlineText.h:
rendering/RenderSVGTSpan.h:
rendering/RenderSVGText.h:
rendering/RenderStyle.h:
rendering/RenderTableCol.h:
rendering/RenderThemeWin.h:
rendering/bidi.h:
xml/DOMParser.h:
xml/XPathEvaluator.h:
xml/XPathExpression.h:
xml/XPathExpressionNode.h:
xml/XPathFunctions.h:
xml/XPathNSResolver.h:
xml/XPathNamespace.h:
xml/XPathParser.h:
xml/XPathPath.h:
xml/XPathPredicate.h:
xml/XPathResult.h:
xml/XPathStep.h:
xml/XPathUtil.h:
xml/XPathValue.h:
xml/XPathVariableReference.h:
xml/XSLImportRule.h:
xml/XSLStyleSheet.h:
xml/XSLTProcessor.h:
xml/xmlhttprequest.h:

4:47 PM Changeset in webkit [18873] by eseidel

1 edit
1 add in trunk/WebKitTools

2007-01-15 Eric Seidel <eric@webkit.org>

Reviewed by bdash.

Add a script to keep our header guards squeaky clean.

Scripts/clean-header-guards: Added.

4:46 PM Changeset in webkit [18872] by eseidel

2 edits in trunk/WebKitSite

2007-01-15 Eric Seidel <eric@webkit.org>

Reviewed by bdash.

coding/coding-style.html: update to include style for header guards

4:33 PM Changeset in webkit [22771] by andersca

5 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

<rdar://problem/4889203>
Implement WebFrame::canHandleRequest.

WebDataSource.cpp: (WebDataSource::webFrame): Implement webFrame accessor.

WebFrame.cpp: (WebFrame::canHandleRequest):
WebView.cpp: (WebView::canHandleRequest):
WebView.h: Implement canHandleRequest.

3:33 PM Changeset in webkit [22770] by andersca

2 edits in branches/WindowsMerge/WebCore

Build fix.

WebCore.vcproj/WebCore.vcproj: Add ProgressTracker.[cpp|h]

3:22 PM Changeset in webkit [18871] by andersca

2 edits in trunk/WebCore

Build fix.

loader/ProgressTracker.cpp:

2:39 PM Changeset in webkit [22769] by andersca

7 edits
2 adds in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

Loader related improvements.

Interfaces/IWebFrameLoadDelegate.idl: Change method signature to match what we have on Mac more closely.

WebDataSource.cpp: (WebDataSource::pageTitle): Implement.

WebError.cpp: Added.
WebError.h: Added. Add (currently stubbed out) IWebError implementation.

WebFrame.cpp: (WebFrame::dispatchDidCancelClientRedirect): (WebFrame::dispatchWillPerformClientRedirect): (WebFrame::dispatchDidReceiveIcon): (WebFrame::dispatchUnableToImplementPolicy): (WebFrame::dispatchDidFailProvisionalLoad): (WebFrame::dispatchDidFailLoad): Implement these.

WebKit.vcproj/WebKit.vcproj: Add WebError.h and WebError.cpp

2:13 PM Changeset in webkit [18870] by lars

2 edits in trunk/WebCore

Compile and link the ProgressTracker into the Qt build.

2:12 PM Changeset in webkit [22768] by andersca

4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

WebFrame.cpp: (WebFrame::postProgressStartedNotification): (WebFrame::postProgressEstimateChangedNotification): (WebFrame::postProgressFinishedNotification):
WebFrame.h: Post the correct notifications.

WebView.cpp: (WebView::estimatedProgress): Ask the progress tracker for the estimated progress.

2:07 PM Changeset in webkit [18869] by andersca

2 edits in trunk/WebCore

Reviewed by Darin.

loader/ProgressTracker.cpp: Set finalProgressValue to its value explicitly instead of calculating it (which causes a global initializer to be generated).

1:55 PM Changeset in webkit [18868] by andersca

16 edits
2 adds in trunk

WebCore:

Reviewed by Darin and Adam.

Move progress tracking down to WebCore.

WebCore.exp: Add ProgressTracker::estimatedProgress() to be used by WebKit.

WebCore.xcodeproj/project.pbxproj: Add ProgressTracker.[cpp|h]

loader/FrameLoader.cpp: (WebCore::FrameLoader::prepareForLoadStart): (WebCore::FrameLoader::clearProvisionalLoad): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::didReceiveResponse): (WebCore::FrameLoader::didReceiveData): (WebCore::FrameLoader::didFailToLoad): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::didFinishLoad): Call directly to the progress tracker instead of through the frame loader client.

loader/FrameLoaderClient.h: Get rid of the old methods and add new methods for tracking progress.

loader/ProgressTracker.cpp: Added. (WebCore::ProgressItem::ProgressItem): (WebCore::ProgressTracker::ProgressTracker): (WebCore::ProgressTracker::~ProgressTracker): (WebCore::ProgressTracker::estimatedProgress): (WebCore::ProgressTracker::reset): (WebCore::ProgressTracker::progressStarted): (WebCore::ProgressTracker::progressCompleted): (WebCore::ProgressTracker::finalProgressComplete): (WebCore::ProgressTracker::incrementProgress): (WebCore::ProgressTracker::completeProgress): (WebCore::ProgressTracker::createUniqueIdentifier):
loader/ProgressTracker.h: Added. New per page class which tracks progress.

loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willSendRequest):
page/Page.cpp: (WebCore::Page::Page):
page/Page.h: (WebCore::Page::progress): Move createUniqueIdentifier to ProgressTracker, add ProgressTracker object to Page.

platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::willChangeEstimatedProgress): (WebCore::SVGEmptyFrameLoaderClient::didChangeEstimatedProgress): (WebCore::SVGEmptyFrameLoaderClient::postProgressStartedNotification): (WebCore::SVGEmptyFrameLoaderClient::postProgressEstimateChangedNotification): (WebCore::SVGEmptyFrameLoaderClient::postProgressFinishedNotification): Add new methods, get rid of the old ones.

WebKit:

Reviewed by Darin.

Update to match WebCore.

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::willChangeEstimatedProgress): (WebFrameLoaderClient::didChangeEstimatedProgress): (WebFrameLoaderClient::postProgressStartedNotification): (WebFrameLoaderClient::postProgressEstimateChangedNotification): (WebFrameLoaderClient::postProgressFinishedNotification): Post the correct notifications.

WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebViewPrivate dealloc]): Get rid of all progress tracking code.

(-[WebView estimatedProgress]):
Call ProgressTracker::estimatedProgress()

WebKitQt:

Fix build.

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::postProgressStartedNotification): (WebCore::FrameLoaderClientQt::postProgressEstimateChangedNotification): (WebCore::FrameLoaderClientQt::postProgressFinishedNotification):
WebCoreSupport/FrameLoaderClientQt.h:

12:57 PM Changeset in webkit [18867] by aroben

5 edits
2 deletes in trunk

LayoutTests:

Reviewed by Anders.

Fix: http://bugs.webkit.org/show_bug.cgi?id=12288
fast/tokenizer/004 needs new results

fast/tokenizer/004.html: Changed to dump as text, changed tabs to spaces.
fast/tokenizer/004-expected.txt: Updated results.
fast/tokenizer/004-expected.checksum: Removed.
fast/tokenizer/004-expected.png: Removed.

WebCore:

Reviewed by Anders.

Fix comment.

html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript):

12:00 PM Changeset in webkit [22767] by andersca

2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

Interfaces/IWebView.idl: Add progress notifications.

11:39 AM Changeset in webkit [18866] by sullivan

2 edits in trunk/WebCore

platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded): Leopard build fix; don't declare one of the case values twice

11:03 AM S60ConfigureComputer edited by bradley.morrison@nokia.com

Added a quick note re workaround for rare sdk installation problem (diff)

10:40 AM Changeset in webkit [18865] by ap

7 edits
4 moves
12 adds
12 deletes in trunk

2007-01-15 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=8604 rowspan does not work when set through javascript

WebCore:

rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::updateFromElement): Mark the section for grid recalc if row span or column span change.

LayoutTests:

fast/dom/HTMLTableElement/colSpan-expected.checksum: Updated.
fast/dom/HTMLTableElement/colSpan-expected.png: Updated.
fast/dom/HTMLTableElement/colSpan-expected.txt: Updated.
fast/dom/HTMLTableElement/colSpan.html: Removed comment about expected failure.
tables/mozilla/bugs/bug22246-2-expected.checksum: Added.
tables/mozilla/bugs/bug22246-2-expected.png: Added.
tables/mozilla/bugs/bug22246-2-expected.txt: Added.
tables/mozilla/bugs/bug22246-2a-expected.checksum: Added.
tables/mozilla/bugs/bug22246-2a-expected.png: Added.
tables/mozilla/bugs/bug22246-2a-expected.txt: Added.
tables/mozilla/bugs/bug22246-3-expected.checksum: Added.
tables/mozilla/bugs/bug22246-3-expected.png: Added.
tables/mozilla/bugs/bug22246-3-expected.txt: Added.
tables/mozilla/bugs/bug22246-3a-expected.checksum: Added.
tables/mozilla/bugs/bug22246-3a-expected.png: Added.
tables/mozilla/bugs/bug22246-3a-expected.txt: Added.
tables/mozilla_expected_failures/bugs/bug22246-2-expected.checksum: Removed.
tables/mozilla_expected_failures/bugs/bug22246-2-expected.png: Removed.
tables/mozilla_expected_failures/bugs/bug22246-2-expected.txt: Removed.
tables/mozilla_expected_failures/bugs/bug22246-2.html: Moved to mozilla/ since it no longer fails.
tables/mozilla_expected_failures/bugs/bug22246-2a-expected.checksum: Removed.
tables/mozilla_expected_failures/bugs/bug22246-2a-expected.png: Removed.
tables/mozilla_expected_failures/bugs/bug22246-2a-expected.txt: Removed.
tables/mozilla_expected_failures/bugs/bug22246-2a.html: Moved to mozilla/ since it no longer fails.
tables/mozilla_expected_failures/bugs/bug22246-3-expected.checksum: Removed.
tables/mozilla_expected_failures/bugs/bug22246-3-expected.png: Removed.
tables/mozilla_expected_failures/bugs/bug22246-3-expected.txt: Removed.
tables/mozilla_expected_failures/bugs/bug22246-3.html: Moved to mozilla/ since it no longer fails.
tables/mozilla_expected_failures/bugs/bug22246-3a-expected.checksum: Removed.
tables/mozilla_expected_failures/bugs/bug22246-3a-expected.png: Removed.
tables/mozilla_expected_failures/bugs/bug22246-3a-expected.txt: Removed.
tables/mozilla_expected_failures/bugs/bug22246-3a.html: Moved to mozilla/ since it no longer fails.

10:30 AM Changeset in webkit [18864] by aroben

5 edits in trunk

WebCore:

Reviewed by Darin.

Small context menu fixes.

platform/ContextMenu.cpp: (WebCore::ContextMenu::populate): Fix typo. (WebCore::ContextMenu::checkOrEnableIfNeeded): Disabled "No Guesses Found", and added all enum values explicitly.

WebKit:

Reviewed by Darin.

Fix: http://bugs.webkit.org/show_bug.cgi?id=12134
REGRESSION: Assertion failure and crash when right clicking selection
in forms

WebCoreSupport/WebContextMenuClient.mm: (fixMenusFromOldApps): Static helper to fix up menus from applications compiled against Tiger WebKit. (WebContextMenuClient::getCustomMenuFromDefaultItems): Call helper to fix menus.
WebView/WebUIDelegatePrivate.h: Fixed typo.

10:14 AM Changeset in webkit [22766] by andersca

7 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

Call resource load delegate methods.

Interfaces/IWebResourceLoadDelegate.idl: Use unsigned long instead of UINT.

WebBackForwardList.cpp:
WebBackForwardList.h: Get rid of the createInstance method that takes no arguments.

WebFrame.cpp: (WebFrame::assignIdentifierToInitialRequest): (WebFrame::dispatchDidReceiveResponse): (WebFrame::dispatchDidReceiveContentLength): (WebFrame::dispatchDidFinishLoading): (WebFrame::dispatchDidFailLoading): Call the right resource load delegate methods.

WebView.cpp: (WebView::setResourceLoadDelegate): (WebView::resourceLoadDelegate): (WebView::setPolicyDelegate): (WebView::policyDelegate):
WebView.h: Add getters and setters for the resource load delegate and the policy delegate.

10:00 AM Changeset in webkit [18863] by ap

9 edits
6 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=6272
XMLHttpRequest freezes on getting a missing document with overridden Content-Length

http://bugs.webkit.org/show_bug.cgi?id=6212
Investigate disallowing some XMLHttpRequest headers from being set via setRequestHeader.

Tests:

http/tests/xmlhttprequest/connection-error-sync.html
http/tests/xmlhttprequest/set-dangerous-headers.html

bindings/js/kjs_binding.cpp: (KJS::): (KJS::setDOMException): Added support for NETWORK_ERR. Changed the temporary PERMISSION_DENIED error into a special case.

loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously):
loader/FrameLoader.h: Return the error object to the caller. Removed an extra local variable for error, which shadowed the one from enclosing block.

dom/XMLTokenizer.cpp: (WebCore::openFunc):
xml/XSLTProcessor.cpp: (WebCore::docLoaderFunc): Updated to pass an error object (currently ignored).

xml/xmlhttprequest.cpp: (WebCore::canSetRequestHeader): Added. The headers to block include the ones from the current XMLHttpRequest draft plus "Via", which is blocked by Firefox. (WebCore::XMLHttpRequest::send): Raise an exception if a sync request results in an error. (WebCore::XMLHttpRequest::setRequestHeader): Call canSetRequestHeader().
xml/xmlhttprequest.h: (WebCore::): Added NETWORK_ERR and a comment about PERMISSION_DENIED.

9:19 AM Changeset in webkit [18862] by zack

10 edits in trunk/WebCore

Optimizing rendering on the Qt platform. Mainly switch to QPixmap
from client-side QImage. Also clean up nasty hacks in ScrollViewCanvasQt

8:01 AM Changeset in webkit [18861] by lars

9 edits in trunk

Reviewed by Zack

Fix weird crashes when running the layout tests. The
reason was that I used KURL (and thus DeprecatedString)
in a thread. Unfortunately that class is not threadsafe
at all.

DumpRenderTree: Fix a few smaller issues in there, and update
our list of skipped tests.

7:35 AM Changeset in webkit [18860] by eseidel

2 edits in trunk/WebCore

2007-01-15 Eric Seidel <eric@webkit.org>

Reviewed by rwlbuis.

Make isValid check not malloc 3 SVGStringLists for every element.

No test possible, performance fix only.

ksvg2/svg/SVGTests.cpp: (WebCore::SVGTests::isValid):

7:04 AM Changeset in webkit [18859] by rwlbuis

2 edits in trunk/WebCore

Reviewed by Eric.

Remove unused member var.

3:58 AM Changeset in webkit [18858] by rwlbuis

3 edits
4 adds in trunk

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=12069
Hit detection fails under some viewbox constraints

Do not take viewBox into account when hit testing svg container.

2:10 AM Changeset in webkit [18857] by hyatt

2 edits in trunk/WebCore

Fix for 12275, negative margins confuse page breaks.

Reviewed by Eric

rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintChildren):

1:19 AM Changeset in webkit [18856] by eseidel

4 edits
4 adds in trunk

2007-01-15 Eric Seidel <eric@eseidel.com>

Reviewed by mjs.

SVG gradients do not notice stop additions
http://bugs.webkit.org/show_bug.cgi?id=12192

Test: svg/custom/gradient-add-stops.svg

ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::childrenChanged):
ksvg2/svg/SVGGradientElement.h:

Jan 14, 2007:

11:49 PM Changeset in webkit [18855] by hyatt

2 edits in trunk/WebCore

Fix for bug 10356, positioning doesn't work with <svg> elements in XHTML. Change the requiresLayer
check to use the DOM, since the old check would fail if the parent block had no element.

Reviewed by Eric

Added svg/custom/relative-positioning.html (absolute/fixed too)

rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::requiresLayer):

11:05 PM Changeset in webkit [22765] by aliceli1

4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Lou.

Fixed: <rdar://problem/4888908> Find: "Use selection to find" and "Jump to selection" are not implemented

Interfaces/IWebView.idl:
WebView.cpp: (WebView::selectedText): (WebView::centerSelectionInVisibleArea):
WebView.h:

10:52 PM Changeset in webkit [18854] by eseidel

3 edits
4 adds in trunk

2007-01-14 Eric Seidel <eric@webkit.org>

Reviewed by hyatt.

SVG does not correctly handle float: left
http://bugs.webkit.org/show_bug.cgi?id=12210

Test: svg/custom/svg-float-border-padding.xml

rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):

7:33 PM Changeset in webkit [18853] by brmorris

2 edits in S60/trunk/WebCore

2007-01-14 brmorris 3.0 sdk build fix.

BWINS/WebCore_sdkU.DEF:

5:29 PM Changeset in webkit [18852] by hyatt

4 adds in trunk/LayoutTests/fast/replaced

Add layout test for select line breaking.

5:28 PM Changeset in webkit [18851] by hyatt

2 edits in trunk/WebCore

More work to fix 10145, regression where form elements don't break properly. Make sure to really use
the parent of the replaced element's whitespace value everywhere.

Reviewed by olliej

fast/replaced/three-selects-break.html

rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak):

5:08 PM Changeset in webkit [18850] by weinig

33 edits in trunk/WebCore

Reviewed by Darin and then by Mitz.

Patch for http://bugs.webkit.org/show_bug.cgi?id=12228
Cleanup assorted CSS classes

css/CSSBorderImageValue.cpp: (WebCore::CSSBorderImageValue::CSSBorderImageValue): (WebCore::CSSBorderImageValue::cssText):
css/CSSBorderImageValue.h:
css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForLength): (WebCore::valueForBorderStyle): (WebCore::valueForTextAlign): (WebCore::valueForShadow): (WebCore::getPositionOffsetValue): (WebCore::CSSComputedStyleDeclaration::cssText): (WebCore::primitiveValueFromLength): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): (WebCore::CSSComputedStyleDeclaration::getPropertyPriority): (WebCore::CSSComputedStyleDeclaration::removeProperty): (WebCore::CSSComputedStyleDeclaration::setProperty): (WebCore::CSSComputedStyleDeclaration::length): (WebCore::CSSComputedStyleDeclaration::item):
css/CSSComputedStyleDeclaration.h:
css/CSSCursorImageValue.cpp: (WebCore::CSSCursorImageValue::CSSCursorImageValue):
css/CSSCursorImageValue.h:
css/CSSGrammar.y:
css/CSSImageValue.cpp:
css/CSSImageValue.h:
css/CSSInheritedValue.cpp:
css/CSSInheritedValue.h:
css/CSSInitialValue.cpp:
css/CSSInitialValue.h:
css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration): (WebCore::CSSMutableStyleDeclaration::operator=): (WebCore::CSSMutableStyleDeclaration::getPropertyValue): (WebCore::CSSMutableStyleDeclaration::get4Values): (WebCore::CSSMutableStyleDeclaration::getShorthandValue): (WebCore::CSSMutableStyleDeclaration::getPropertyCSSValue): (WebCore::CSSMutableStyleDeclaration::removeProperty): (WebCore::CSSMutableStyleDeclaration::setChanged): (WebCore::CSSMutableStyleDeclaration::getPropertyPriority): (WebCore::CSSMutableStyleDeclaration::getPropertyShorthand): (WebCore::CSSMutableStyleDeclaration::isPropertyImplicit): (WebCore::CSSMutableStyleDeclaration::setProperty): (WebCore::CSSMutableStyleDeclaration::setImageProperty): (WebCore::CSSMutableStyleDeclaration::parseDeclaration): (WebCore::CSSMutableStyleDeclaration::addParsedProperties): (WebCore::CSSMutableStyleDeclaration::setLengthProperty): (WebCore::CSSMutableStyleDeclaration::cssText): (WebCore::CSSMutableStyleDeclaration::merge): (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::setProperty): (WebCore::CSSMutableStyleDeclaration::removeProperty):
css/CSSNamespace.h: (WebCore::CSSNamespace::CSSNamespace):
css/CSSPrimitiveValue.cpp: (WebCore::isCSSTokenizerIdentifier): (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::computeLengthInt): (WebCore::CSSPrimitiveValue::computeLengthIntForLength): (WebCore::CSSPrimitiveValue::computeLengthShort): (WebCore::CSSPrimitiveValue::computeLengthFloat): (WebCore::CSSPrimitiveValue::setFloatValue): (WebCore::scaleFactorForConversion): (WebCore::CSSPrimitiveValue::getFloatValue): (WebCore::CSSPrimitiveValue::setStringValue): (WebCore::CSSPrimitiveValue::getStringValue): (WebCore::CSSPrimitiveValue::parseString): (WebCore::CSSPrimitiveValue::getIdent): (WebCore::CSSPrimitiveValue::cssText):
css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::getCounterValue): (WebCore::CSSPrimitiveValue::getRectValue): (WebCore::CSSPrimitiveValue::getRGBColorValue): (WebCore::CSSPrimitiveValue::getPairValue): (WebCore::CSSPrimitiveValue::getDashboardRegionValue):
css/CSSProperty.cpp: (WebCore::operator==):
css/CSSProperty.h: (WebCore::CSSProperty::operator=):
css/CSSQuirkPrimitiveValue.h: (WebCore::CSSQuirkPrimitiveValue::CSSQuirkPrimitiveValue):
css/CSSRuleList.cpp: (WebCore::CSSRuleList::CSSRuleList): (WebCore::CSSRuleList::deleteRule): (WebCore::CSSRuleList::insertRule):
css/CSSRuleList.h: (WebCore::CSSRuleList::item):
css/CSSSelector.cpp: (WebCore::CSSSelector::print): (WebCore::CSSSelector::specificity): (WebCore::CSSSelector::extractPseudoType): (WebCore::CSSSelector::operator==): (WebCore::CSSSelector::selectorText):
css/CSSSelector.h: (WebCore::CSSSelector::CSSSelector): (WebCore::CSSSelector::~CSSSelector): (WebCore::CSSSelector::append): (WebCore::CSSSelector::next): (WebCore::CSSSelector::pseudoType): (WebCore::CSSSelector::hasTag): (WebCore::CSSSelector::hasAttribute):
css/CSSStyleDeclaration.cpp: (WebCore::propertyID): (WebCore::CSSStyleDeclaration::getPropertyPriority): (WebCore::CSSStyleDeclaration::getPropertyShorthand): (WebCore::CSSStyleDeclaration::isPropertyImplicit): (WebCore::CSSStyleDeclaration::setProperty): (WebCore::CSSStyleDeclaration::isPropertyName): (WebCore::CSSStyleDeclaration::parentRule): (WebCore::CSSStyleDeclaration::diff): (WebCore::CSSStyleDeclaration::copyPropertiesInSet):
css/CSSStyleDeclaration.h:
css/Counter.h: (WebCore::Counter::Counter): (WebCore::Counter::listStyleNumber):
css/csshelper.cpp: (WebCore::parseURL):
css/csshelper.h:
css/cssparser.h: (WebCore::domString): (WebCore::atomicString): (WebCore::CSSParser::operator|):
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::matchRulesForList): (WebCore::CSSStyleSelector::checkSelector): (WebCore::CSSStyleSelector::checkOneSelector): (WebCore::CSSRuleSet::addRule):

4:53 PM Changeset in webkit [18849] by bdash

5 edits in trunk/WebKitTools

2007-01-14 Mark Rowe <mrowe@apple.com>

Reviewed by Adam.

<rdar://problem/4908909> Need to create Leopard nightly build

WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Always use the 10.4 Universal SDK. The disk images don't mount pre-10.4 so we aren't losing anything here.
WebKitLauncher/WebKitNightlyEnabler.m: (poseAsWebKitApp): Simplify CoreFoundation-related hackery by using _CFGetProcessPath instead of walking the mach-o symbol tables. The smaller timeframe where the CFProcessPath environment variable is set allows this to work correctly on Leopard where the old code failed. (enableWebKitNightlyBehaviour):
WebKitLauncher/main.m: (main): Pass executable path as WebKitAppPath rather than CFProcessPath to prevent it being picked up too early by CoreFoundation.
Drosera/launcher.m: (main): Ditto

4:39 PM Changeset in webkit [18848] by ddkilzer

6 edits
2 adds in trunk

LayoutTests:

Reviewed by Adam. Patch by Mitz.

test for http://bugs.webkit.org/show_bug.cgi?id=12264 REGRESSION (r18843): Webkit crashes on 43Folders.com home page

fast/tokenizer/ignore-tags-in-iframe-expected.txt: Added.
fast/tokenizer/ignore-tags-in-iframe.html: Added.

WebCore:

Reviewed by Adam. Patch by Mitz.

fix http://bugs.webkit.org/show_bug.cgi?id=12264 REGRESSION (r18843): Webkit crashes on 43Folders.com home page

Test: fast/tokenizer/ignore-tags-in-iframe.html

html/HTMLParser.cpp: (WebCore::HTMLParser::reset): Removed unused inSelect member variable. (WebCore::HTMLParser::selectCreateErrorCheck): Ditto. (WebCore::HTMLParser::processCloseTag): Ditto.
html/HTMLParser.h: Ditto.
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseTag): Changed not to process <pre>, <listing>, <script>, <style>, <title>, <textarea> and <xmp> if the parser is in skip mode (waiting for a close tag of an element whose contents are not parsed, such as iframe).
html/HTMLTokenizer.h: (WebCore::HTMLTokenizer::State::setInStyle): Removed unused bit. (WebCore::HTMLTokenizer::State::): Ditto.

3:58 PM Changeset in webkit [18847] by brmorris

2 edits in S60/trunk/WebKit

2007-01-14 brmorris <bradley.morrison@nokia.com>

DESC: reverted revision 18809

BrowserCore/Formcontrols/src/FInputlFormattedEditor.cpp

1:45 PM Changeset in webkit [18846] by ddkilzer

2 edits in trunk/WebKit

WebKit:

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=12251 REGRESSION (r18822-r18823): Assertion failure opening document with non-existent resources (dom/xhtml/level2/html/HTMLIFrameElement11.xhtml)

WebView/WebView.mm: (-[WebView _objectForIdentifier:]): Removed assertion. (-[WebView _removeObjectForIdentifier:]): Removed assertion.

12:13 PM Changeset in webkit [22764] by aroben

11 edits
1 copy
3 adds in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Steve.

Fix: <rdar://4831292> Implement WebKitStatistics

Added object counting:

WebDataSource.cpp: (WebDataSource::WebDataSource): (WebDataSource::~WebDataSource):
WebFrame.cpp: (WebFrame::WebFrame): (WebFrame::~WebFrame):
WebHTMLRepresentation.cpp: (WebHTMLRepresentation::WebHTMLRepresentation): (WebHTMLRepresentation::~WebHTMLRepresentation):
WebView.cpp: (WebView::WebView): Initialize m_page member. (WebView::~WebView):

10:46 AM Changeset in webkit [18845] by ap

2 edits in trunk/LayoutTests

Reviewed by Mitz.

fast/multicol/float-multicol.html: Fixed an URL not to point to a remote resource (we already have a local copy).

10:08 AM Changeset in webkit [18844] by ap

12 edits in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12258
fast/tokenizer/002 test broken

WebCore:

loader/FrameLoader.h: Added a flush parameter to write().
loader/FrameLoader.cpp: (WebCore::FrameLoader::write): Ditto. (WebCore::FrameLoader::endIfNotLoading): Instead of poorly duplicating the logic in write(), call it directly.

LayoutTests:

editing/selection/designmode-no-caret-expected.txt:
fast/dom/HTMLHeadElement/textInHead4-expected.txt:
fast/parser/broken-comments-vs-parsing-mode-expected.txt:
fast/parser/tabs-in-scripts-expected.txt:
fast/tokenizer/external-script-document-write-expected.txt:
fast/tokenizer/missing-title-end-tag-1-expected.txt:
tables/mozilla/images/adforce_imgis_com-expected.txt:
tables/mozilla_expected_failures/images/adforce_imgis_com-expected.txt: Updated the results (inconsequential changes only).

2:04 AM Changeset in webkit [18843] by aroben

8 edits
2 adds in trunk

LayoutTests:

Reviewed by Maciej.

editing/deleting/4845371.html: Removed bogus "Javascript" type.
editing/selection/4397952.html: Ditto.
fast/html/script-allowed-types-languages-expected.txt: Added.
fast/html/script-allowed-types-languages.html: Added. Tests type/language whitelisting.

WebCore:

Reviewed by Maciej.

Make sure our whitelisting of the type and language attributes of the
<script> element is enforced in all HTMLTokenizer/HTMLScriptElement
code paths.

All layout tests pass.

html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript): New method to determine whether the script should be executed, given its type and language attributes. (WebCore::HTMLScriptElement::evaluateScript): Check type/language before executing.
html/HTMLScriptElement.h: Added new declarations.
html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::begin): Made scriptSrc a String. (WebCore::HTMLTokenizer::scriptHandler): Check shouldExecuteAsJavaScript before executing. (WebCore::HTMLTokenizer::notifyFinished): Ditto. (WebCore::HTMLTokenizer::parseTag): Moved type/language checking from here to HTMLScriptElement::shouldExecuteAsJavaScript.
html/HTMLTokenizer.h: Made scriptSrc a String, and removed the javascript member.

1:48 AM Changeset in webkit [18842] by hyatt

4 adds in trunk/LayoutTests/fast/replaced

Add a second breaking test for replaced and text mixtures.

1:21 AM Changeset in webkit [18841] by hyatt

4 adds in trunk/LayoutTests/fast/multicol

Add multicol float avoidance test.

1:16 AM Changeset in webkit [18840] by hyatt

2 edits in trunk/WebCore

Make sure floats are avoided if you have non-auto column property values. Fixes the crazy layout
on http://weblogs.mozillazine.org/roc.

Reviewed by mitz

Added fast/multicol/float-avoidance.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::avoidsFloats):

12:25 AM Changeset in webkit [18839] by hyatt

4 adds in trunk/LayoutTests/fast/replaced

Add layout test for replaced breaking.

12:22 AM Changeset in webkit [18838] by hyatt

13 edits in trunk/WebCore

Fix for 10145, regression where line breaks are not being honored between adjacent replaced elements.
When checking for break opportunities where replaced elements are involved, we ignore their white-space
values and use their parents' instead. The assumption/idea behind this change is that because the element
is replaced, its white-space value is irrelevant except as a means of applying style to its interior.

The CSS spec does not cover this situation, so we're implementing this based off what other browsers seem to
do.

Reviewed by aroben

css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
css/CSSValueKeywords.in:
css/cssparser.cpp: (WebCore::CSSParser::parseValue):
css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::clear): (WebCore::EventHandler::handleWheelEvent):
page/EventHandler.h:
rendering/RenderBox.cpp: (WebCore::RenderBox::calcHeight):
rendering/RenderLayer.cpp: (WebCore::Marquee::Marquee): (WebCore::Marquee::start): (WebCore::Marquee::updateMarqueePosition): (WebCore::Marquee::updateMarqueeStyle): (WebCore::Marquee::timerFired):
rendering/RenderLayer.h:
rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::viewCleared):
rendering/RenderStyle.h: (WebCore::):
rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak):

Jan 13, 2007:

11:53 PM Changeset in webkit [18837] by bdash

9 edits in trunk

2007-01-14 Mark Rowe <mrowe@apple.com>

Reviewed by Mitz.

Minor fixes to JavaScript pretty-printing.

JavaScriptCore.exp:
kjs/Parser.cpp: (KJS::Parser::prettyPrint): Return line number and error message if parsing fails.
kjs/Parser.h:
kjs/nodes2string.cpp: (ElementNode::streamTo): Include comma delimiters in array literals. (PropertyNameNode::streamTo): Quote property names in object literals to handle the case when the property name is not a valid identifier.
kjs/testkjs.cpp: (doIt): Print any errors encountered while pretty-printing.

2007-01-14 Mark Rowe <mrowe@apple.com>

Reviewed by Mitz.

Layout tests for fixes to JavaScript pretty-printing.

fast/js/pretty-print-expected.txt:
fast/js/resources/pretty-print.js: Test handling of object literal with non-identifier property name, and of array literals.

1:07 PM Changeset in webkit [18836] by hyatt

2 edits in trunk/WebCore

While optimizing form controls and fixing their clipping, I caused this text zoom regression. The layout
of text is necessary because it needs to recalc minmaxwidth. This is still a really unfortunate
bit of code... since a lot of properties don't apply to text (e.g., borders), we're marking text renderers
as dirty when we don't have to.

Reviewed by mitz

rendering/RenderObject.cpp: (WebCore::RenderObject::setStyle):

12:01 PM Changeset in webkit [18835] by lars

2 edits in trunk/WebCore

Reviewed by Alexey

String::format() was relying on undefined behaviour, which
happened to work on lots of systems (Mac and 32bit Linux at least)
but broke badly on 64bit Linux.

10:48 AM Changeset in webkit [18834] by lars

2 edits in trunk/WebCore

Fix for bug 11924: WebCore would crash on any HTML content
with a non-empty <table> tag in it on a 64-bit machine. The
size_t (64bit) vs int (32bit) cast is now fixed in ensureRows,
and the clients of this function have been updated to check
for a false return code.

Reviewed by Darin

8:33 AM Changeset in webkit [18833] by ap

3 edits
2 adds in trunk

Reviewed by Darin.

http://bugs.webkit.org/show_bug.cgi?id=12165
REGRESSION: text encoding problem at jn.sapo.pt

Test: fast/encoding/script-in-head.html

loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Ignore tags within <script> elements in head, just like we do for <title>.

3:21 AM Changeset in webkit [18832] by lars

2 edits in trunk/WebCore

Reviewed by Maciej

Don't crash when constructing a GraphicsContext with a 0
PlatformGraphicsContext and don't do anything if painting
is disabled.

3:02 AM Changeset in webkit [18831] by lars

3 edits in trunk/WebKitQt

Make the Qt port compile again.

1:49 AM Changeset in webkit [18830] by eseidel

7 edits
4 adds in trunk

2007-01-13 Eric Seidel <eric@eseidel.com>

Reviewed by hyatt.

RichDraw demo does not live-update in Safari
(SVG elements should ignore CSS position)
http://bugs.webkit.org/show_bug.cgi?id=10364

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): ignore position for everything but <svg>
ksvg2/svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::rebuildRenderer): move path generation into layout()
rendering/RenderContainer.cpp: (WebCore::RenderContainer::layout): ASSERT kids marked as having completed layout
rendering/RenderPath.cpp: (WebCore::RenderPath::layout): move path generation into layout()
rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): ASSERT kids marked as having completed layout

12:16 AM Changeset in webkit [18829] by hyatt

1 edit in trunk/WebCore/rendering/RenderBlock.cpp

Fix leak of column vector.

Jan 12, 2007:

11:11 PM Changeset in webkit [18828] by hyatt

4 adds in trunk/LayoutTests/fast/multicol

Add layout test for column rules.

11:08 PM Changeset in webkit [18827] by hyatt

3 edits in trunk/WebCore

Add support for column rules.

Reviewed by bdash

fast/multicol/column-rules.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintColumns):
rendering/RenderStyle.h: (WebCore::RenderStyle::columnRuleIsTransparent):

9:32 PM Changeset in webkit [18826] by hyatt

3 edits in trunk/WebCore

Make multicolumn layout work with floats.

Reviewed by andersca

Added fast/multicol/float-multicol.html

rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::paintColumns): (WebCore::RenderBlock::paintObject):
rendering/RenderBlock.h:

9:31 PM Changeset in webkit [18825] by hyatt

6 adds in trunk/LayoutTests/fast/multicol

New fancy float multicol test (thanks Mozilla!)

8:22 PM Changeset in webkit [18824] by ddkilzer

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Maciej.

test for fast/css/line-height.html REGRESSION (r18816-r18818): Assertion failure in WebCore::Length::Length[in-charge](int, WebCore::LengthType, bool)

fast/css/line-height-expected.checksum: Added.
fast/css/line-height-expected.png: Added.
fast/css/line-height-expected.txt: Added.
fast/css/line-height.html: Added.

WebCore:

Reviewed by Maciej.

fix http://bugs.webkit.org/show_bug.cgi?id=12239 REGRESSION (r18816-r18818): Assertion failure in WebCore::Length::Length[in-charge](int, WebCore::LengthType, bool)

Test: fast/css/line-height.html

rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createInnerTextStyle): Use a float to create a percent Length.

6:15 PM Changeset in webkit [22763] by andersca

3 edits in branches/WindowsMerge/WebKitWin

Build fixes.

WebFrame.cpp: (WebFrame::assignIdentifierToInitialRequest): (WebFrame::dispatchWillSendRequest): (WebFrame::dispatchDidReceiveResponse): (WebFrame::dispatchDidReceiveContentLength): (WebFrame::dispatchDidFinishLoading): (WebFrame::dispatchDidFailLoading): (WebFrame::incrementProgress): (WebFrame::completeProgress): (WebFrame::dispatchDidReceiveAuthenticationChallenge): (WebFrame::dispatchDidCancelAuthenticationChallenge):
WebFrame.h:

5:47 PM Changeset in webkit [18823] by andersca

1 edit in trunk/JavaScriptCore/wtf/HashTraits.h

Forgot to save.

5:44 PM Changeset in webkit [18822] by andersca

16 edits in trunk

JavaScriptCore:

Reviewed by Darin.

wtf/HashTraits.h: Add hash traits for unsigned long and unsigned long long.

WebCore:

Reviewed by Darin.

Use unsigned long for identifiers instead of Objective-C objects.

loader/FrameLoader.cpp: (WebCore::FrameLoader::loadResourceSynchronously): (WebCore::FrameLoader::startLoadingMainResource): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::assignIdentifierToInitialRequest): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::sendRemainingDelegateMessages): (WebCore::FrameLoader::requestFromDelegate): (WebCore::FrameLoader::loadedResourceFromMemoryCache):
loader/FrameLoader.h:
loader/FrameLoaderClient.h:
loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::willSendRequest):
loader/ResourceLoader.h: (WebCore::ResourceLoader::setIdentifier): (WebCore::ResourceLoader::identifier):
page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::createUniqueIdentifier):
page/Page.h:
platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::assignIdentifierToInitialRequest): (WebCore::SVGEmptyFrameLoaderClient::dispatchWillSendRequest): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveResponse): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveContentLength): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishLoading): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFailLoading): (WebCore::SVGEmptyFrameLoaderClient::incrementProgress): (WebCore::SVGEmptyFrameLoaderClient::completeProgress):

WebKit:

Reviewed by Darin.

Add a HashMap between unsigned longs and Objective-C objects and use it for
the resource load delegate.

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebFrameLoaderClient::dispatchIdentifierForInitialRequest): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading): (WebFrameLoaderClient::incrementProgress): (WebFrameLoaderClient::completeProgress):
WebView/WebView.mm: (-[WebViewPrivate init]): (-[WebViewPrivate dealloc]): (-[WebView _addObject:forIdentifier:]): (-[WebView _objectForIdentifier:]): (-[WebView _removeObjectForIdentifier:]):
WebView/WebViewInternal.h:

5:19 PM Changeset in webkit [18821] by bdash

2 edits in trunk/WebCore

2007-01-12 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=12235 REGRESSION (r18815): Marquees do not scroll

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): Apply the '-webkit-marquee' value of 'overflow-x' and 'overflow-y'.

4:45 PM Changeset in webkit [22762] by adachan

6 edits
1 add in branches/WindowsMerge/WebKitWin

2007-01-12 Ada Chan <adachan@apple.com>

Reviewed by Steve.

WebKitWin:

Added IWebBackForwardListPrivate which contains the removeItem method, used in undo/redo of closing tabs.
Fixed a null dereference I ran into in WebFrame::dispatchDidFirstLayout.

Interfaces/IWebBackForwardListPrivate.idl: Added.
WebBackForwardList.cpp: (WebBackForwardList::QueryInterface): (WebBackForwardList::removeItem):
WebBackForwardList.h:
WebFrame.cpp: (WebFrame::dispatchDidFirstLayout):
WebKit.vcproj/Interfaces.vcproj:
WebKit.vcproj/WebKitGUID.vcproj:

3:07 PM Changeset in webkit [18820] by justing

17 edits
4 adds in trunk

LayoutTests:

Reviewed by hyatt

<rdar://problem/4875425>
EBay, GMail, and GoogleDocs RTEs font size popups don't work

Added to test changes:

editing/style/fontsize-1-expected.checksum: Added.
editing/style/fontsize-1-expected.png: Added.
editing/style/fontsize-1-expected.txt: Added.
editing/style/fontsize-1.html: Added.

Removed use of "px" and "pt" values passed to
execCommand("FontSize", ...) (other browsers don't
support them):

editing/input/attributed-substring-from-range-lines.html-disabled:
editing/style/block-style-004-expected.checksum:
editing/style/block-style-004-expected.png:
editing/style/block-style-004-expected.txt:
editing/style/block-style-004.html:
editing/style/block-style-005-expected.checksum:
editing/style/block-style-005-expected.png:
editing/style/block-style-005-expected.txt:
editing/style/block-style-005.html:
editing/style/block-style-006-expected.checksum:
editing/style/block-style-006-expected.png:
editing/style/block-style-006-expected.txt:
editing/style/block-style-006.html:

WebCore:

Reviewed by hyatt

<rdar://problem/4875425>
EBay, GMail, and GoogleDocs RTEs font size popups don't work

Changed execCommand("FontSize", ...) to match the spec
and the behavior of other browsers. It expects a number,
n, which, the spec says can be 1 through 7. Other browsers
perform the font size change by creating a font element
wrapper with size="n". We convert n into one of the absolute
size CSS keywords (x-small, medium, etc.).

editing/JSEditor.cpp: Call cssValueFromFontSizeNumber. If successful, perform the style change.
html/HTMLFontElement.cpp: (WebCore::HTMLFontElement::cssValueFromFontSizeNumber): Added. Moved this code from parsedMappedAttribute so that it could be called from the Editor. (WebCore::HTMLFontElement::parseMappedAttribute): Moved code into cssValueFromFontSizeNumber.
html/HTMLFontElement.h:

2:53 PM Changeset in webkit [18819] by hyatt

18 edits in trunk/WebCore

Fix for bug 11598, implement lightweight control clipping mechanism for
buttons, list boxes, and dropdown lists. Make sure list box respects
scrollLeft/Top/Width/Height as well as clientWidth/Height.

Fix bugs in RenderStyle::diff. CursorData was not being compared properly.
vertical-align had a non-inline display check that was wrong (preventing
dynamic changes to keyword-based vertical-align from working).

Reviewed by mitz

page/EventHandler.cpp: (WebCore::EventHandler::selectClosestWordFromMouseEvent):
rendering/RenderBlock.cpp: (WebCore::RenderBlock::layout): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::determineHorizontalPosition): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::paint): (WebCore::RenderBlock::fillHorizontalSelectionGap): (WebCore::RenderBlock::nodeAtPoint): (WebCore::RenderBlock::layoutColumns):
rendering/RenderBox.cpp: (WebCore::RenderBox::computeAbsoluteRepaintRect):
rendering/RenderBox.h:
rendering/RenderButton.cpp: (WebCore::RenderButton::setStyle): (WebCore::RenderButton::controlClipRect):
rendering/RenderButton.h: (WebCore::RenderButton::hasControlClip):
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox):
rendering/RenderFlow.cpp: (WebCore::RenderFlow::addFocusRingRects):
rendering/RenderListBox.cpp: (WebCore::RenderListBox::itemBoundingBoxRect): (WebCore::RenderListBox::paintObject): (WebCore::RenderListBox::itemHeight): (WebCore::RenderListBox::verticalScrollbarWidth): (WebCore::RenderListBox::scrollWidth): (WebCore::RenderListBox::scrollHeight): (WebCore::RenderListBox::scrollLeft): (WebCore::RenderListBox::setScrollLeft): (WebCore::RenderListBox::scrollTop): (WebCore::RenderListBox::setScrollTop): (WebCore::RenderListBox::controlClipRect):
rendering/RenderListBox.h: (WebCore::RenderListBox::hasControlClip):
rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setStyle): (WebCore::RenderMenuList::controlClipRect):
rendering/RenderMenuList.h: (WebCore::RenderMenuList::hasControlClip):
rendering/RenderObject.cpp: (WebCore::RenderObject::verticalScrollbarWidth): (WebCore::RenderObject::horizontalScrollbarHeight): (WebCore::RenderObject::clientWidth): (WebCore::RenderObject::clientHeight): (WebCore::RenderObject::setStyle):
rendering/RenderObject.h: (WebCore::RenderObject::hasControlClip): (WebCore::RenderObject::controlClipRect): (WebCore::RenderObject::contentWidth): (WebCore::RenderObject::contentHeight):
rendering/RenderStyle.cpp: (WebCore::StyleVisualData::StyleVisualData): (WebCore::cursorDataEqvuialent): (WebCore::StyleInheritedData::operator==): (WebCore::CursorList::operator==): (WebCore::RenderStyle::diff):
rendering/RenderStyle.h: (WebCore::LengthBox::operator!=): (WebCore::StyleVisualData::operator==): (WebCore::CursorData::operator==): (WebCore::CursorData::operator!=): (WebCore::CursorList::operator!=): (WebCore::RenderStyle::setTableLayout):
rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):

2:46 PM Changeset in webkit [18818] by hyatt

1 edit in trunk/WebCore/rendering/RenderTextControl.cpp

Ooops left off paren.

2:43 PM Changeset in webkit [18817] by yongjzha

13 edits in S60/branches/3.1m

Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog (revision 18804)
+++ WebCore/ChangeLog (working copy)
@@ -1,3 +1,24 @@
+2007-01-12 w3liu <wei.liu@nokia.com>
+
+ Reviewed by yongjun.zhang@nokia.com.
+ DESC: [S60] Search, GSM_2006_wk37_V16 Internet: The page displays wrongly when browsing snapshot in Search.
+ http://bugzilla.opendarwin.org/show_bug.cgi?id=12225
+
+ WARNING: NO TEST CASES ADDED OR CHANGED
+
+ * BWINS/WEBCOREU.DEF:
+ * EABI/WebCoreU.DEF:
+ * bridge/WebCoreBridge.cpp:
+ (CWebCoreBridge::CreateDocumentWithEncoding):
+ * bridge/WebCoreBridge.h:
+ * khtml/khtml_part.cpp:
+ (KHTMLPart::write):
+ (KHTMLPart::setEncoding):
+ * khtml/khtmlpart_p.h:
+ * kwq/KWQKHTMLPart.cpp:
+ (KWQKHTMLPart::setEncoding):
+ * kwq/KWQKHTMLPart.h:
+

2:35 PM Changeset in webkit [18816] by hyatt

2 edits in trunk/WebCore

Fix for bug 9934, smaller line heights should not be allowed on
text fields.

Reviewed by darin

rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createInnerTextStyle):

2:26 PM Changeset in webkit [18815] by ddkilzer

6 edits in trunk

LayoutTests:

Reviewed by Hyatt. Patch by Mitz.

test updated for http://bugs.webkit.org/show_bug.cgi?id=12215 Treat 'overflow' and '-webkit-border-radius' as shorthands when parsing and when removing.

fast/css/remove-shorthand-expected.txt:
fast/css/remove-shorthand.html:

WebCore:

Reviewed by Hyatt. Patch by Mitz.

http://bugs.webkit.org/show_bug.cgi?id=12215 Treat 'overflow' and '-webkit-border-radius' as shorthands when parsing and when removing.

Test: fast/css/remove-shorthand.html (updated)

css/CSSMutableStyleDeclaration.cpp: (WebCore::initShorthandMap):
css/cssparser.cpp: (WebCore::CSSParser::parseValue):

1:49 PM Changeset in webkit [18814] by rwlbuis

3 edits
4 adds in trunk

Reviewed by Mitz.

Do not mix up JSSVGPolygonElement and JSSVGPolylineElement.

1:46 PM Changeset in webkit [18813] by kdecker

2 edits in trunk/WebCore

Reviewed by andersca.

Fixed: <rdar://problem/4701326>21.2 ms launch time regression spent in +[WebPluginDatabase installedPlugins]

dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Added a guard clause for text/html which used to be in WebKit before a lot of the loader plumbing was moved to WebCore. Pinging the plug-in database to ask it if it supports a given mime type has the side effect of reading from disk on first call, therefore such a check should be a last resort.

1:23 PM Changeset in webkit [18812] by spadma

10 edits in S60/trunk/WebKit

2007-01-12 spadma <Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Autoform fill and key event handling
http://bugs.webkit.org/show_bug.cgi?id=

BrowserCore/Formcontrols/inc/FControlInputSkin.h:
BrowserCore/Formcontrols/inc/FControlInputWidget.h:
BrowserCore/Formcontrols/inc/FControlSelectWidget.h: (CControlSelectWidget::GetSelectWidgetRect):
BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::HandlePointerEventL): (CFormInputSkin::ActivateL): (CFormInputSkin::UpdatePopupL):
BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::HandlePointerEventL):
BrowserCore/Formcontrols/src/FControlSelectWidget.cpp: (CControlSelectWidget::ConstructL): (CControlSelectWidget::PositionListBox): (CControlSelectWidget::HandlePointerEventL): (CControlSelectWidget::HandleListBoxEventL):
BrowserView/inc/PointerEventHandler.h:
BrowserView/inc/WebKitView.h:
BrowserView/src/PointerEventHandler.cpp: (CPointerEventHandler::HandlePointerEventL):

1:11 PM Changeset in webkit [18811] by ggaren

8 edits in trunk/JavaScriptCore

RS by Brady Eidson.

Rolling back in r18786 with leaks fixed, and these renames slightly reworked:

Because they can return 0:
rootObjectForImp => findRootObject (overloaded for JSObject* and Interpreter*)
rootObjectForInterpreter => findRootObject (ditto)
findReferenceSet => findProtectCountSet

1:10 PM Changeset in webkit [18810] by ddkilzer

3 edits in trunk/WebCore

WebCore:

Reviewed by Darin. Patch by Mitz.

fix http://bugs.webkit.org/show_bug.cgi?id=12223 REGRESSION: Leaks under CSSStyleSelector::applyProperty

No test possible (no change to functionality).

rendering/RenderObject.h: Removed unused forward declaration.
rendering/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData): Delete shadow data.

12:52 PM Changeset in webkit [18809] by spadma

2 edits in S60/trunk/WebKit

2007-01-11 sareen sareen <shyam.sareen@nokia.com>

Reviewed by Sachin Padma.
DESC: Can't change input mode in WAP CSS formatted fields.(TSW ID: TMCN-6S5HZR)
http://bugs.webkit.org/show_bug.cgi?id=12188

BrowserCore/Formcontrols/src/FInputlFormattedEditor.cpp: (CInputFormattedEditor::UpdateEditingParameters):

12:24 PM Changeset in webkit [18808] by yongjzha

2 edits in S60/trunk/WebCore

2007-01-12 sareen <shyam.sareen@yahoo.com>

Reviewed by Yongjun.
DESC: Wrong rendering of danish national characters for UTF8 coded web pages.(TSW ID: TMCN-6UQNXY)
http://bugs.webkit.org/show_bug.cgi?id=12217

WARNING: NO TEST CASES ADDED OR CHANGED

kwq/KWQTextCodec.cpp: (validateUtf8):

12:20 PM Changeset in webkit [18807] by yongjzha

13 edits in S60/trunk

2007-01-12 w3liu <wei.liu@nokia.com>

Reviewed by yongjun.zhang@nokia.com.
DESC: [S60] Search, GSM_2006_wk37_V16 Internet: The page displays wrongly when browsing snapshot in Search.
http://bugs.webkit.org/show_bug.cgi?id=12225

BrowserView/inc/WebKitControl.h: (CWebKitControl::DefaultLocaleCharset):
BrowserView/src/LoadListeners.cpp: (CPageLoadListener::HeadersL):
BrowserView/src/WebKitControl.cpp: (CWebKitControl::ConstructL):

12:06 PM Changeset in webkit [22761] by andersca

11 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin.

WARNING: NO TEST CASES ADDED OR CHANGED

loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::didChangeTitle): Copied here from FrameLoaderMac.mm

platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start): Removed setting referrer and user-agend and added a check for null page.

(WebCore::ResourceHandle::cancel):
Don't call didFail.

platform/win/TemporaryLinkStubs.cpp: (FrameWin::getAppletInstanceForWidget): Use LOG_NOIMPL here.

WebKitWin:

Reviewed by Darin.

Move WebKitWin over to the new WebCore loader. There are still some leftover functions
from FrameWinClient that aren't used and should be removed.

WebDataSource.cpp: (WebDataSource::WebDataSource): (WebDataSource::~WebDataSource): (WebDataSource::createInstance): (WebDataSource::documentLoader): (WebDataSource::overrideEncoding): (WebDataSource::setOverrideEncoding): (WebDataSource::QueryInterface): (WebDataSource::initWithRequest): (WebDataSource::data): (WebDataSource::representation): (WebDataSource::webFrame): (WebDataSource::initialRequest): (WebDataSource::request): (WebDataSource::response): (WebDataSource::textEncodingName): (WebDataSource::isLoading): (WebDataSource::unreachableURL):
WebDataSource.h:
WebFrame.cpp: (WebFrame::WebFramePrivate::m_policyFunction): (WebFrame::WebFrame): (WebFrame::~WebFrame): (WebFrame::QueryInterface): (WebFrame::loadRequest): (WebFrame::loadData): (getWebDataSource): (WebFrame::dataSource): (WebFrame::provisionalDataSource): (WebFrame::stopLoading): (WebFrame::reload): (WebFrame::firstLayoutDone): (WebFrame::loadType): (WebFrame::stopMainResourceLoad): (WebFrame::canProvideDocumentSource): (WebFrame::createFrame): (WebFrame::submitForm): (WebFrame::setTitle): (WebFrame::originalRequestURL): (WebFrame::hasWebView): (WebFrame::hasFrameView): (WebFrame::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrame::dispatchDidReceiveTitle): (WebFrame::dispatchDidFirstLayout): (WebFrame::dispatchShow): (WebFrame::cancelPolicyCheck): (WebFrame::dispatchWillSubmitForm): (WebFrame::finishedLoading): (WebFrame::canHandleRequest): (WebFrame::canShowMIMEType): (WebFrame::representationExistsForURLScheme): (WebFrame::updateGlobalHistoryForStandardLoad): (WebFrame::shouldGoToHistoryItem): (WebFrame::createDocumentLoader): (WebFrame::receivedData): (WebFrame::setUpPolicyListener): (WebFrame::receivedPolicyDecision): (WebFrame::committedLoad): (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchCreatePage): (WebFrame::dispatchDidCancelAuthenticationChallenge):
WebFrame.h:
WebView.cpp: (WebView::WebView): (WebView::~WebView): (WebViewWndProc): (WebView::close): (WebView::frameLoadDelegate): (WebView::backForwardList): (WebView::setMaintainsBackForwardList): (WebView::goBack): (WebView::goForward): (WebView::goToBackForwardItem): (WebView::setCustomTextEncodingName): (WebView::customTextEncodingName): (WebView::canGoBack): (WebView::canGoForward): (WebView::frameLoadDelegatePrivate):
WebView.h:

11:59 AM Changeset in webkit [18806] by andersca

2 edits in trunk/WebCore

Build fix.

WebCore.xcodeproj/project.pbxproj: Remove SubresourceLoaderMac.mm.

11:56 AM Changeset in webkit [18805] by andersca

6 edits
1 delete in trunk/WebCore

Reviewed by Darin and Anders.

Make some more of the loader code platform independent.

loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): (WebCore::FrameLoader::checkLoadCompleteForThisFrame): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::createEmptyDocument): (WebCore::FrameLoader::setTitle): (WebCore::FrameLoader::originalRequestURL): (WebCore::FrameLoader::referrer):
loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::load): (WebCore::SubresourceLoader::create): (WebCore::SubresourceLoader::willSendRequest): (WebCore::SubresourceLoader::didReceiveResponse): (WebCore::SubresourceLoader::didReceiveData): (WebCore::SubresourceLoader::didFinishLoading): (WebCore::SubresourceLoader::didFail): (WebCore::SubresourceLoader::didCancel): (WebCore::SubresourceLoader::stopLoading):
loader/SubresourceLoader.h:
loader/mac/FrameLoaderMac.mm:
loader/mac/SubresourceLoaderMac.mm: Removed.
loader/qt/FrameLoaderQt.cpp:

10:53 AM Changeset in webkit [22760] by andersca

9 edits
2 adds in branches/WindowsMerge/WebKitWin

Reviewed by Geoff.

More loader preparations.

WebContextMenuClient.cpp: (WebContextMenuClient::getCustomMenuFromDefaultItems): (WebContextMenuClient::contextMenuItemSelected): Use ::createInstance to create the element property bags.

WebElementPropertyBag.cpp: (WebElementPropertyBag::WebElementPropertyBag): (WebElementPropertyBag::~WebElementPropertyBag): (WebElementPropertyBag::createInstance): (convertStringToVariant):
WebElementPropertyBag.h: Fix ownership issues so WebElementPropertyBag can one day be a value in another property bag.

WebFramePolicyListener.cpp: Added. (WebFramePolicyListener::WebFramePolicyListener): (WebFramePolicyListener::~WebFramePolicyListener): (WebFramePolicyListener::createInstance): (WebFramePolicyListener::QueryInterface): (WebFramePolicyListener::AddRef): (WebFramePolicyListener::Release): (WebFramePolicyListener::use): (WebFramePolicyListener::download): (WebFramePolicyListener::ignore): (WebFramePolicyListener::continueSubmit): (WebFramePolicyListener::receivedPolicyDecision): (WebFramePolicyListener::invalidate):
WebFramePolicyListener.h: Added. Add policy listener implementation.

WebFrame.cpp: (WebFrame::receivedPolicyDecision):
WebFrame.h: Add stub to be used by the policy listener.

WebView.cpp: (WebView::WebView): (WebView::~WebView): (WebView::paint): (WebView::closeWindow): (WebView::handleMouseEvent): (WebViewWndProc): (WebView::initWithFrame): (WebView::setUIDelegate): (WebView::uiDelegate): (WebView::setFrameLoadDelegate): (WebView::frameLoadDelegate): (WebView::preferences): (WebView::elementAtPoint): (WebView::setFormDelegate): (WebView::formDelegate): (WebView::setFrameLoadDelegatePrivate): (WebView::frameLoadDelegatePrivate):
WebView.h: Cleanup, use COMPtr in a couple of places.

7:05 AM Changeset in webkit [18804] by lars

7 edits in trunk/WebKitTools

Reviewed by Zack

Get DumpRenderTree to work again for the Qt build.

Make run-webkit-tests a little less verbose when testing
Qt, and add an option to run DumpRenderTree inside valgrind
(useful for debugging)

7:00 AM Changeset in webkit [18803] by lars

2 edits in trunk/WebCore

Reviewed by Zack

Valgrind reported uninitialized variable.

platform/network/qt/ResourceHandleManagerQt.cpp: (WebCore::FileLoader::request):

4:40 AM Changeset in webkit [18802] by rwlbuis

2 edits in trunk/WebCore

Reviewed by rwlbuis.

add missing null check in new fixed table layout code

12:47 AM Changeset in webkit [18801] by zack

2 edits in trunk/WebKitTools

Add WEBKIT_FULLBUILD to the qmake relevant build part to force
make clean before make as they fix stale dependencies (for buildbot mainly)

12:39 AM Changeset in webkit [18800] by lars

3 edits in trunk/WebCore

Fix the Qt build after the Authentication changes.

12:11 AM Changeset in webkit [18799] by hyatt

2 edits in trunk/WebCore

Fix for bug 9569. Make sure the selection offset for selection roots excludes border and padding.

Reviewed by Eric

rendering/RenderBlock.cpp: (WebCore::RenderBlock::leftSelectionOffset): (WebCore::RenderBlock::rightSelectionOffset):

Jan 11, 2007:

10:46 PM Changeset in webkit [18798] by hyatt

3 edits in trunk/WebCore

Fix for bug 8705, readonly text fields should not get focus rings. Add a rule to that effect to
html4.css and then also add readonly as a special case for style sharing so that we can retain the
performance boost from sharing styles on inputs.

Reviewed by bdash

css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::canShareStyleWithElement): (WebCore::CSSStyleSelector::checkOneSelector):
css/html4.css:

10:28 PM Changeset in webkit [18797] by hyatt

3 edits in trunk/LayoutTests/fast/overflow

Update overflow layout test results after autoscroll fix.

10:25 PM Changeset in webkit [18796] by hyatt

2 edits in trunk/WebCore

Fix for bug 11595. Autoscrolling of layers didn't really work at all unless the layer was coincidentally
in the root layer's coordinate space. The event point was an absolute position within the document, but
the layer's rect was only local coords. This patch makes sure to use absolute bounds for the layer
when comparing it with the point.

This is covered by the scrollRevealButton test case already in the tree... the results change to be more
correct.

Reviewed by ggaren

rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible):

10:25 PM Changeset in webkit [18795] by ggaren

9 edits in trunk/JavaScriptCore

RS by Brady Eidson.

Rolling out r18786 because it caused leaks.

9:50 PM Changeset in webkit [22759] by sfalken

2 edits in branches/WindowsMerge/WebKitWin

2007-01-11 Steve Falkenburg <sfalken@apple.com>

WebKit.vcproj/WebKit.make:

9:33 PM Changeset in webkit [18794] by beidson

9 edits in trunk/WebCore

Reviewed by Oliver

-Move more HTTP Auth handling towards ResourceHandle, away from ResourceHandleClient
-Make more of ResourceLoader cross-platform

loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::releaseResources): (WebCore::ResourceLoader::didCancel): (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::receivedCancellation):
loader/ResourceLoader.h: (WebCore::ResourceLoader::willStopBufferingData): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::willCacheResponse):
loader/mac/ResourceLoaderMac.mm:
platform/network/ResourceHandle.h:
platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::willStopBufferingData):
platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::didCancelAuthenticationChallenge): (WebCore::ResourceHandle::receivedCredential): (WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential): (WebCore::ResourceHandle::receivedCancellation): (WebCore::ResourceHandle::clearAuthentication): (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):

8:48 PM Changeset in webkit [18793] by hyatt

2 edits in trunk/WebCore

A hit test is returning a null renderer. Make sure to null-check it in the autoscroll code.
This really shouldn't happen, but I'm just going to bullet proof for now given that it's happening
on the front page of yahoo.com!

Reviewed by mark

rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll):

8:37 PM Changeset in webkit [18792] by hyatt

3 edits
5 adds in trunk

LayoutTests:

Force column-width to parse in strict mode so that there is no confusion when it is used in the columns
shorthand (it can be mistaken for column-count otherwise).

Reviewed by Mark

fast/multicol/columns-shorthand-parsing-expected.checksum: Added.
fast/multicol/columns-shorthand-parsing-expected.png: Added.
fast/multicol/columns-shorthand-parsing-expected.txt: Added.
fast/multicol/columns-shorthand-parsing.html: Added.

WebCore:

Force column-width to parse in strict mode so that there is no confusion when it is used in the columns
shorthand (it can be mistaken for column-count otherwise).

Reviewed by Mark

fast/multicol/columns-shorthand-parsing.html

css/cssparser.cpp: (WebCore::CSSParser::parseValue):

8:29 PM Changeset in webkit [18791] by bdash

27 edits in trunk

2007-01-11 Mitz Pettel <mitz@webkit.org>

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=12124 RenderTable::section{Above,Below}() can return the wrong answer for the {footer,header}

rendering/RenderTable.cpp: (WebCore::resetSectionPointerIfNotBefore): Added this function to help with checking if a section being inserted is the going to be the first of its kind. (WebCore::RenderTable::addChild): Changed to maintain the pointers to the header, the footer, the caption and the first table body properly when objects are inserted in the middle. Also changed to make the first caption win over any other captions. This matches Firefox and what already used to happen when a section recalc took place. (WebCore::RenderTable::layout): Changed to use sectionBelow() for iterating over the sections from top to bottom. (WebCore::RenderTable::calcBorderLeft): Changed to really find the section containing the first row. (WebCore::RenderTable::calcBorderRight): Ditto. (WebCore::RenderTable::sectionAbove): Fixed a bug when the last section was skipped if the input was the footer. (WebCore::RenderTable::sectionBelow): Ditto for "first" and "header" respectively.

2007-01-11 Mitz Pettel <mitz@webkit.org>

Reviewed by Hyatt.

updated results for http://bugs.webkit.org/show_bug.cgi?id=12124 RenderTable::section{Above,Below}() can return the wrong answer for the {footer,header}

Collapsed borders changed in the "marvin" tests, as the footer cells now
collapse correctly with the last row of the body. Visual differences not
captured by the pixel results since they occurred below 600px.

The "other" test has changed since in a table with multiple captions,
now the first one wins. No visual difference in this case since both captions
are the same.

tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
tables/mozilla/marvin/backgr_position-table-expected.txt:
tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
tables/mozilla/marvin/backgr_simple-table-expected.txt:
tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
tables/mozilla_expected_failures/other/test4-expected.txt:

8:28 PM Changeset in webkit [18790] by bdash

13 edits in trunk

2007-01-11 Mitz Pettel <mitz@webkit.org>

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=12115 RTL text is jumbled on display

Fixed fixed table layout. Implemented an algorithm that matches the behavior
of Firefox, up to rounding errors.

Fixes three existing table tests.

rendering/FixedTableLayout.cpp: Undid accidental search-and-replace of "width" to "m_width" in the comments. Removed an outdated comment, since WebKit no longer honors table-layout:fixed for variable-width tables. (WebCore::FixedTableLayout::calcWidthArray): Fixed the logic that finds the first row. Changed to divide the width specified for a cell that spans multiple columns between the columns rather than assign its entire width to each column. (WebCore::FixedTableLayout::calcMinMaxWidth): (WebCore::FixedTableLayout::layout): Implemented the behavior observed in Firefox.
rendering/FixedTableLayout.h:

2007-01-11 Mitz Pettel <mitz@webkit.org>

Reviewed by Hyatt.

updated results for http://bugs.webkit.org/show_bug.cgi?id=12115 RTL text is jumbled on display (fixing fixed table layout)

tables/mozilla/bugs/bug157890-expected.checksum:
tables/mozilla/bugs/bug157890-expected.png:
tables/mozilla/bugs/bug157890-expected.txt:
tables/mozilla/bugs/bug44505-expected.checksum:
tables/mozilla/bugs/bug44505-expected.png:
tables/mozilla/bugs/bug44505-expected.txt:
tables/mozilla_expected_failures/bugs/bug7243-expected.checksum:
tables/mozilla_expected_failures/bugs/bug7243-expected.png:
tables/mozilla_expected_failures/bugs/bug7243-expected.txt:

8:25 PM Changeset in webkit [18789] by bdash

2 edits in trunk/WebKitTools

2007-01-11 Mitz Pettel <mitz@webkit.org>

Reviewed by Hyatt.

http://bugs.webkit.org/show_bug.cgi?id=10249 Temporarily disable tests that are causing kernel panics

Changed the ImageDiff tool not to use CoreImage filters.

DumpRenderTree/ImageDiff.m: (main): (createImageFromStdin): (compareImages): (getDifferenceBitmap):

8:24 PM Changeset in webkit [18788] by bdash

6 edits
4 adds in trunk

2007-01-11 Mitz Pettel <mitz@webkit.org>

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=8438 iExploder(#460): Assertion failure in RenderObject::drawBorder()

Test: fast/block/basic/fieldset-stretch-to-legend.html

rendering/RenderBox.cpp: (WebCore::RenderBox::calcWidth): Stretch to the minimum intrinsic width if the object requires it. (WebCore::RenderBox::calcHorizontalMargins): Some style cleanup. (WebCore::RenderBox::calcAbsoluteHorizontal): Stretch to the minimum intrinsic width if the object requires it.
rendering/RenderBox.h: (WebCore::RenderBox::stretchesToMinIntrinsicWidth): Added. Returns false.
rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::calcMinMaxWidth): Overloaded RenderBlock's implementation to ensure that the legend's will fit in the fieldset's minimum intrinsic width. (WebCore::RenderFieldset::findLegend): Made const. (WebCore::RenderFieldset::paintBoxDecorations): (WebCore::RenderFieldset::paintBorderMinusLegend): Fixed the behavior when the legend does overflow the fieldset. This is the part of the fix that prevents the assertion failure. If the legend intersects with a corner of the fieldset's border, that corner will not be painted, even if it is not completely occluded. This edge case can be improved with clipping in the future. Added FIXME to implement border-radius.
rendering/RenderFieldset.h: (WebCore::RenderFieldset::stretchesToMinIntrinsicWidth): Overloaded to return true.

2007-01-11 Mitz Pettel <mitz@webkit.org>

Reviewed by Hyatt.

test for http://bugs.webkit.org/show_bug.cgi?id=8438 iExploder(#460): Assertion failure in RenderObject::drawBorder()

fast/block/basic/fieldset-stretch-to-legend-expected.checksum: Added.
fast/block/basic/fieldset-stretch-to-legend-expected.png: Added.
fast/block/basic/fieldset-stretch-to-legend-expected.txt: Added.
fast/block/basic/fieldset-stretch-to-legend.html: Added.

6:53 PM Changeset in webkit [22758] by andersca

2 edits in branches/WindowsMerge/WebCore

platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::cfURLResponse): Add getter that I forgot to commit.

5:14 PM Changeset in webkit [22757] by sfalken

1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

5:05 PM Changeset in webkit [18787] by sfalken

1 copy in tags/Safari-521.32.11b

New tag.

4:46 PM Changeset in webkit [18786] by ggaren

8 edits in trunk/JavaScriptCore

Reviewed by Anders Carlsson.

Even more cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)

Layout tests pass.

Renames:

ReferencesSet | ProtectCounts => ProtectCountSet (because it's a typename for a set of GC protect counts)
ReferencesByRootMap => RootObjectMap (because RootObjectToProtectCountSetMap would have been confusing)
pv => protectedValues
rootObjectForImp => getRootObject (overloaded for JSObject* and Interpreter*)
rootObjectForInterpreter => getRootObject (ditto)
findReferenceSet => getProtectCountSet
imp => jsObject

(KJS::Bindings::getRootObjectMap): Changed to take advantage of built-in
facility for initializing static variables.

(KJS::Bindings::getProtectCountSet):
(KJS::Bindings::destroyProtectCountSet): Added. Helps encapsulate the fact
that getting a ProtectCountSet entails adding a RootObject to a hash table,
and destroying one entails the reverse.

(KJS::Bindings::getRootObject): Removed spurious NULL check.

(KJS::Bindings::findReferenceSet): Renamed. Changed to use getRootObject()
instead of iterating on its own.

(KJS::Bindings::addNativeReference): Changed to use an early return instead
of indenting the whole function.
(KJS::Bindings::removeNativeReference): Ditto.

3:35 PM Changeset in webkit [22756] by sfalken

4 edits in branches/WindowsMerge/WebKitWin

2007-01-11 Steve Falkenburg <sfalken@apple.com>

Reviewed by Lou.

Implement "Make Text Normal Size".

WebView.cpp: (WebView::canMakeTextStandardSize): Added (WebView::makeTextStandardSize): Added (WebView::toggleContinuousSpellChecking): Added (WebView::toggleSmartInsertDelete): Added

3:14 PM Changeset in webkit [18785] by beidson

2 edits in trunk/WebCore

Reviewed by Build Fix Karma

I broke the release build (debug build passed)

platform/network/mac/AuthenticationMac.mm: (WebCore::core):

3:04 PM Changeset in webkit [22755] by beidson

5 edits in branches/WindowsMerge

Make it build again after my HTTP Auth opensource checkin

2:35 PM Changeset in webkit [18784] by beidson

1 edit in trunk/WebCore/platform/network/mac/AuthenticationMac.mm

Blind build fix attempt

2:20 PM Changeset in webkit [18783] by beidson

23 edits
8 adds in trunk

WebCore:

Reviewed by Anders

Rewrites HTTP Authentication setting up a more platform-independent structure

WebCore.exp:
WebCore.xcodeproj/project.pbxproj:
loader/FrameLoader.cpp: (WebCore::FrameLoader::didReceiveAuthenticationChallenge): (WebCore::FrameLoader::didCancelAuthenticationChallenge):
loader/FrameLoader.h:
loader/FrameLoaderClient.h:
loader/ResourceLoader.cpp: (WebCore::ResourceLoader::ResourceLoader): (WebCore::ResourceLoader::didCancel):
loader/ResourceLoader.h: (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::receivedCredential): (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential): (WebCore::ResourceLoader::receivedCancellation):
loader/mac/FrameLoaderMac.mm:
loader/mac/ResourceLoaderMac.mm: (WebCore::ResourceLoader::didReceiveAuthenticationChallenge): (WebCore::ResourceLoader::didCancelAuthenticationChallenge): (WebCore::ResourceLoader::receivedCredential): (WebCore::ResourceLoader::receivedRequestToContinueWithoutCredential): (WebCore::ResourceLoader::receivedCancellation):
platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebCore::SVGEmptyFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
platform/network/ResourceHandleClient.h: (WebCore::ResourceHandleClient::willSendRequest): (WebCore::ResourceHandleClient::didReceiveAuthenticationChallenge): (WebCore::ResourceHandleClient::didCancelAuthenticationChallenge): (WebCore::ResourceHandleClient::receivedCredential): (WebCore::ResourceHandleClient::receivedRequestToContinueWithoutCredential): (WebCore::ResourceHandleClient::receivedCancellation): (WebCore::ResourceHandleClient::willCacheResponse):
platform/network/ResourceResponse.h: (WebCore::operator!=):
platform/network/URLAuthenticationChallenge.cpp: Added. (WebCore::URLAuthenticationChallenge::URLAuthenticationChallenge): (WebCore::URLAuthenticationChallenge::previousFailureCount): (WebCore::URLAuthenticationChallenge::proposedCredential): (WebCore::URLAuthenticationChallenge::protectionSpace): (WebCore::URLAuthenticationChallenge::failureResponse): (WebCore::URLAuthenticationChallenge::error): (WebCore::URLAuthenticationChallenge::isNull): (WebCore::URLAuthenticationChallenge::nullify): (WebCore::operator==): (WebCore::operator!=):
platform/network/URLAuthenticationChallenge.h: Added. (WebCore::URLAuthenticationChallenge::sender): (WebCore::URLAuthenticationChallenge::nsURLAuthenticationChallenge):
platform/network/URLCredential.cpp: Added. (WebCore::URLCredential::URLCredential): (WebCore::URLCredential::user): (WebCore::URLCredential::password): (WebCore::URLCredential::hasPassword): (WebCore::URLCredential::persistence): (WebCore::operator==):
platform/network/URLCredential.h: Added. (WebCore::): (WebCore::operator!=):
platform/network/URLProtectionSpace.cpp: Added. (WebCore::URLProtectionSpace::URLProtectionSpace): (WebCore::URLProtectionSpace::host): (WebCore::URLProtectionSpace::port): (WebCore::URLProtectionSpace::serverType): (WebCore::URLProtectionSpace::realm): (WebCore::URLProtectionSpace::authenticationScheme): (WebCore::operator==):
platform/network/URLProtectionSpace.h: Added. (WebCore::): (WebCore::operator!=):
platform/network/mac/AuthenticationMac.h: Added.
platform/network/mac/AuthenticationMac.mm: Added. (WebCore::URLAuthenticationChallenge::URLAuthenticationChallenge): (WebCore::mac): (WebCore::core):
platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:didReceiveAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate useCredential:forAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate continueWithoutCredentialForAuthenticationChallenge:]): (-[WebCoreResourceHandleAsDelegate cancelAuthenticationChallenge:]):
platform/network/mac/ResourceResponseMac.mm: (WebCore::operator==):

WebKit:

Reviewed by Anders

Rewrites HTTP Authentication setting up a more platform-independent structure

WebCoreSupport/WebFrameLoaderClient.h:
WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
WebKit.xcodeproj/project.pbxproj:

WebKitQt:

Keep the fancy new FrameLoaderClientQt building with a small api change in WebCore
Yay for the loader on QT!

WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidReceiveAuthenticationChallenge): (WebCore::FrameLoaderClientQt::dispatchDidCancelAuthenticationChallenge):
WebCoreSupport/FrameLoaderClientQt.h:

2:02 PM Changeset in webkit [18782] by ggaren

8 edits in trunk

JavaScriptCore:

Reviewed by Anders Carlsson.

Even more cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)

Layout tests pass.

Renames:

findRootObjectForNativeHandleFunction => createRootObject
FindRootObjectForNativeHandleFunctionPtr => CreateRootObjectFunction

Also removed unnecessary use of "Bindings::" prefix.

JavaScriptCore.exp:
bindings/jni/jni_jsobject.cpp: (JavaJSObject::createNative): (JavaJSObject::convertValueToJObject): (JavaJSObject::convertJObjectToValue):
bindings/runtime_root.cpp: (KJS::Bindings::RootObject::setCreateRootObject):
bindings/runtime_root.h: (KJS::Bindings::RootObject::createRootObject):

WebCore:

Reviewed by Anders Carlsson.

Even more cleanup in preparation for fixing <rdar://problem/4608404>
WebScriptObject's _executionContext lack of ownership policy causes
crashes (e.g., in Dashcode)

Layout tests pass.

Renames:

findRootObjectForNativeHandleFunction => createRootObject
FindRootObjectForNativeHandleFunctionPtr => createRootObjectFunction
rootForView => createRootObject
getInstanceForView => getPluginInstanceForWidget

page/mac/FrameMac.mm: (WebCore::FrameMac::getAppletInstanceForWidget): Put the NSView * in a void* variable named "nativeHandle" to be more explicit about the fact that JavaScript's "nativeHandle" is just an NSView *.

(WebCore::getPluginInstanceForWidget): This function now does the NSView *
fetching that its callers used to do.
(WebCore::FrameMac::getEmbedInstanceForWidget): Updated for rename.
(WebCore::FrameMac::getObjectInstanceForWidget): ditto

page/mac/WebCoreFrameBridge.mm: Killed the WebCoreBridgeInternal category, which was really more of a shmategory. (createRootObject): Removed rootObjectForView, folding it into its only caller, the similarly named rootForView. Renamed the pair to "createRootObject" because that's what they do.

(-[WebCoreFrameBridge init]): Updated for renames

1:52 PM Changeset in webkit [18781] by andersca

1 edit in trunk/WebCore/loader/DocLoader.cpp

Get rid of garbage

1:47 PM Changeset in webkit [18780] by andersca

2 edits in trunk/WebCore

Reviewed by Darin.

Fix crash on platforms that don't use the new loader yet.

loader/DocLoader.cpp: (WebCore::DocLoader::requestResource):

1:45 PM Changeset in webkit [18779] by weinig

3 edits
2 adds in trunk

LayoutTests:

Reviewed by Adam.

test for http://bugs.webkit.org/show_bug.cgi?id=11449 Type-to-select in unopened popups doesn't work with Hebrew

fast/forms/select-type-ahead-non-latin-expected.txt: Added.
fast/forms/select-type-ahead-non-latin.html: Added.

WebCore:

Reviewed by Adam.

fix http://bugs.webkit.org/show_bug.cgi?id=11449 Type-to-select in unopened popups doesn't work with Hebrew

Test: fast/forms/select-type-ahead-non-latin.html

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::defaultEventHandler): Changed locale-specific isprint() condition to a Unicode isPrintableChar().

1:41 PM Changeset in webkit [18778] by justing

3 edits
4 adds in trunk

LayoutTests:

Reviewed by geoff

<rdar://problem/4889140>
GMail Editor: List creation fails in new message

editing/execCommand/insert-list-empty-div-expected.checksum: Added.
editing/execCommand/insert-list-empty-div-expected.png: Added.
editing/execCommand/insert-list-empty-div-expected.txt: Added.
editing/execCommand/insert-list-empty-div.html: Added.

WebCore:

Reviewed by geoff

<rdar://problem/4889140>
GMail Editor: List creation fails in new message

editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Inserting the list into an empty paragraph not held open by a br or a '\n', will invalidate start and end. Insert a placeholder and then recompute start and end.

1:15 PM Changeset in webkit [18777] by lars

2 edits
1 delete in trunk/WebCore

This one is not needed any longer neither.

1:04 PM Changeset in webkit [18776] by lars

2 edits in trunk/WebKitTools

fix compilation of DumpRenderTree. Will hopefully
make the built bot happy :)

12:45 PM Changeset in webkit [18775] by lars

2 edits
1 delete in trunk/WebCore

remove now unused file.

12:33 PM Changeset in webkit [18774] by ddkilzer

3 edits in trunk/WebCore

WebCore:

Reviewed by NOBODY (build fix).

loader/mac/FrameLoaderMac.mm: Removed import of LoaderNSURLRequestExtras.h.
loader/mac/SubresourceLoaderMac.mm: Ditto.

12:03 PM Changeset in webkit [18773] by staikos

2 edits in trunk/WebCore

Fix compile

12:00 PM Changeset in webkit [22754] by andersca

3 edits in branches/WindowsMerge/WebCore

Build fix.

WebCore.vcproj/WebCore.vcproj:
platform/win/TemporaryLinkStubs.cpp: (WebCore::Editor::advanceToNextMisspelling):

11:53 AM Changeset in webkit [18772] by andersca

8 edits in trunk/WebCore

Fix build.

dom/XMLTokenizer.cpp:
loader/CachedCSSStyleSheet.cpp:
loader/CachedImage.cpp:
loader/DocLoader.cpp:
loader/loader.cpp:
xml/XSLTProcessor.cpp:
xml/xmlhttprequest.cpp:

11:30 AM Changeset in webkit [18771] by andersca

8 edits
5 deletes in trunk/WebCore

Reviewed by Adam.

Loader cleanup, get rid of unused code.

WebCore.xcodeproj/project.pbxproj:
loader/CachedResource.h:
loader/DocLoader.cpp: (WebCore::DocLoader::requestResource): (WebCore::DocLoader::checkCacheObjectStatus):
loader/DocLoader.h:
loader/LoaderFunctions.h: Removed.
loader/mac/CachedResourceMac.mm: Removed.
loader/mac/LoaderFunctionsMac.mm: Removed.
loader/mac/LoaderNSURLRequestExtras.h: Removed.
loader/mac/LoaderNSURLRequestExtras.m: Removed.
loader/mac/SubresourceLoaderMac.mm:
page/mac/WebCoreFrameBridge.mm:
platform/network/ResourceHandle.cpp:

10:25 AM Changeset in webkit [18770] by bdakin

1 edit in trunk/WebCore/ChangeLog

Better Changelog.

10:19 AM Changeset in webkit [18769] by bdakin

2 edits in trunk/WebCore

Reviewed by Adam.

Fix for http://bugs.webkit.org/show_bug.cgi?id=12135 REGRESSION:
<input> and <textarea> not focused on right click (4908884 in
Radar)

page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent): Ask if we *have* swallowed the event instead of if we *haven't* when deciding to perform a selection.

8:42 AM Changeset in webkit [18768] by darin

2 edits in trunk/WebCore

Reviewed by Anders.

fix http://bugs.webkit.org/show_bug.cgi?id=12189 REGRESSION(r18614-18640): Crash in WebCore::SharedBuffer::hasPlatformData()

loader/mac/LoaderFunctionsMac.mm: (WebCore::CheckCacheObjectStatus): Added null check.

8:39 AM Changeset in webkit [18767] by darin

2 edits in trunk/WebKit

Reviewed by Mitz.

fix http://bugs.webkit.org/show_bug.cgi?id=12180 REGRESSION: Double-clicking on JS exception in JS log crashes in -[SharedBufferData initWithSharedBuffer:]

WebView/WebDataSource.mm: (-[WebDataSource data]): Added null check.

6:55 AM Changeset in webkit [18766] by darin

2 edits in trunk/WebCore

platform/CharacterNames.h: Oops! horizontalEllipsis != zeroWidthSpace!

4:34 AM Changeset in webkit [18765] by lars

10 edits in trunk

Start using the loader in the Qt port.

4:23 AM Changeset in webkit [18764] by darin

22 edits
6 deletes in trunk

WebCore:

Reviewed by Hyatt.

removed a couple Mac bridging classes; put the code in WebKit instead

WebCore.exp: Updated for new WebKit uses.

WebCore.xcodeproj/project.pbxproj: Removed files.
bridge/mac/WebCoreEncodings.h: Removed.
bridge/mac/WebCoreEncodings.mm: Removed.
bridge/mac/WebMimeTypeRegistryBridge.h: Removed.
bridge/mac/WebMimeTypeRegistryBridge.mm: Removed.
platform/mac/WebNSAttributedStringExtras.h: Removed.
platform/mac/WebNSAttributedStringExtras.mm: Removed.

platform/mac/PasteboardMac.mm: (WebCore::stripAttachmentCharacters): Added. Moved code from WebNSAttributedStringExtras.mm, and fixed a garbage collection problem (a global with a plain old retain rather than HardRetain). (WebCore::Pasteboard::writeSelection): Updated to use stripAttachmentCharacters.

removed some DeprecatedCString use

loader/FrameLoader.cpp: Changed to use String more to eliminate use of DeprecatedCString here in the mailto form support. But maybe we can remove this entirely. Do we really care about mailto forms any more?

platform/Pasteboard.h: Removed unneeded DeprecatedCString declaration.

platform/PlatformString.h: Added replace that takes two strings.
platform/StringImpl.h: Ditto.
platform/StringImpl.cpp: (WebCore::StringImpl::replace): Ditto.

platform/TextStream.h: Remove DeprecatedCString case.
platform/TextStream.cpp: Ditto.

made a few more files use CharacterNames.h

platform/CharacterNames.h: Added some more character names and sorted alphabetically.

bridge/mac/WebCoreStringTruncator.mm: (centerTruncateToBuffer): Use character name from CharacterNames.h. (rightTruncateToBuffer): Ditto. (truncateString): Ditto.
platform/mac/FontMac.mm: (WebCore::addDirectionalOverride): Ditto.
rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto.
rendering/bidi.cpp: (WebCore::RenderBlock::checkLinesForTextOverflow): Ditto.

WebKit:

Reviewed by Hyatt.

moved code from a couple WebCore bridging classes here instead

Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]): Use MimeTypeRegistry instead of WebMimeTypeRegistryBridge.

WebView/WebHTMLRepresentation.mm: (stringArray): Added. Helper to convert a HashSet to an NSArray. (concatenateArrays): Added. Helper to concatenate two NSArray objects. (+[WebHTMLRepresentation supportedMIMETypes]): Use MimeTypeRegistry instead of WebMimeTypeRegistryBridge. Also fix a potential GC problem by using a RetainPtr instead of a [retain] on a global variable. (+[WebHTMLRepresentation supportedNonImageMIMETypes]): Ditto. (+[WebHTMLRepresentation supportedImageMIMETypes]): Ditto.

WebView/WebHTMLView.mm: (-[WebHTMLView _imageExistsAtPaths:]): Use MimeTypeRegistry instead of WebMimeTypeRegistryBridge. (-[WebHTMLView _documentFragmentWithPaths:]): Ditto.

WebView/WebView.mm: (+[WebView _decodeData:]): Moved code here from the old WebCoreEncodings class.

WebKit.xcodeproj/project.pbxproj: Let Xcode have its way with this file. Moved WebRenderNode into the appropriate group.

4:22 AM Changeset in webkit [18763] by hyatt

2 edits in trunk/LayoutTests/fast/overflow

Land reverted layout tests for the two overflow cases. Although the new results were better, there are issues with what I did to achieve them, so for now going back to the (broken) old results.

4:21 AM Changeset in webkit [18762] by hyatt

3 edits in trunk/WebCore

Fix two bugs in positionForCoordinates. (Make it work when you have a margin in between your border and
your first child block.)

Rewrite column rebalancing to have two modes: constrained and unconstrained. In unconstrained mode,
the system will dynamically rebalance as it loses space to breaks and compute a final intrinsic height
for the overall block. In constrained mode, columns flow into the fixed height block, and extra columns
spill out horizontally in the appropriate direction (RTL/LTR).

Make columns work properly with both LTR and RTL overflow blocks.

Initial column test suite coming soon now that the basic layout is right.

Reviewed by darin

rendering/RenderBlock.cpp: (WebCore:::RenderFlow): (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::paintColumns): (WebCore::RenderBlock::lowestPosition): (WebCore::RenderBlock::rightmostPosition): (WebCore::RenderBlock::leftmostPosition): (WebCore::RenderBlock::hitTestColumns): (WebCore::RenderBlock::positionForCoordinates): (WebCore::RenderBlock::availableWidth): (WebCore::RenderBlock::calcColumnWidth): (WebCore::RenderBlock::layoutColumns): (WebCore::RenderBlock::adjustPointToColumnContents):
rendering/RenderBlock.h: (WebCore::RenderBlock::hasColumns):

3:13 AM Changeset in webkit [18761] by hyatt

4 edits in trunk/LayoutTests/svg/custom

Fix SVG test cases.

12:51 AM Changeset in webkit [18760] by rwlbuis

14 edits in trunk

Reviewed by Eric.

http://bugs.webkit.org/show_bug.cgi?id=12201
Fix image dragging issues with http://www.carto.net/papers/svg/gui/scrollbar/index.svg

Fix calculation of absolute transform so that viewport x,y
translation is always done, also when viewBox is set.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed