Timeline



Jan 21, 2007:

10:54 PM Changeset in webkit [22803] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Maciej.

Implemented drawing button states and control sizes.

9:23 PM Changeset in webkit [19024] by ap
  • 54 edits
    3 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=10934
REGRESSION: prototype.js logs error (HTMLFormElement) on webkit builds

Added constructors for most HTML elements; started auto-generating HTMLSelectElement JS binding.

Test: fast/dom/Window/element-constructors-on-window.html

  • DerivedSources.make: Generate JSHTMLSelectElement.
  • WebCore.xcodeproj/project.pbxproj: Added JSHTMLSelectElement{Custom}.
  • bindings/js/JSHTMLElementWrapperFactory.cpp: Create a proper binding for SELECT.
  • bindings/js/kjs_html.cpp: (KJS::): (KJS::JSHTMLElement::classInfo): (KJS::JSHTMLElement::accessors): (KJS::JSHTMLElement::getOwnPropertySlot): (KJS::HTMLElementFunction::callAsFunction): (KJS::JSHTMLElement::put):
  • bindings/js/kjs_html.h: (KJS::JSHTMLElement::): Removed everything related to SELECT. Renamed getHTMLOptionsCollection to toJS for autogenerated code to be happy, and rewrote it using cacheDOMObject.
  • bindings/scripts/CodeGeneratorJS.pm: Added HTMLElement to the list of types that cannot fail conversion.
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLDListElement.idl:
  • html/HTMLDirectoryElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLFontElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLHRElement.idl:
  • html/HTMLHeadElement.idl:
  • html/HTMLHeadingElement.idl:
  • html/HTMLHtmlElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLIsIndexElement.idl:
  • html/HTMLLIElement.idl:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLMenuElement.idl:
  • html/HTMLMetaElement.idl:
  • html/HTMLModElement.idl:
  • html/HTMLOListElement.idl:
  • html/HTMLOptGroupElement.idl:
  • html/HTMLParagraphElement.idl:
  • html/HTMLParamElement.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLQuoteElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLTitleElement.idl:
  • html/HTMLUListElement.idl: Generate constructors.
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::length):
  • html/HTMLSelectElement.h: Make length() return unsigned for auto-generated code to be happy.
  • html/HTMLSelectElement.idl: Adjusted to be usable for JS.
  • bindings/JSHTMLSelectElementCustom.cpp: Added. Implements remove().
  • page/DOMWindow.idl: Added properties for most elements' constructors.
8:54 PM Changeset in webkit [22802] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Maciej.

7:45 PM Changeset in webkit [19023] by bdash
  • 2 edits in trunk/WebCore

2007-01-21 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12357
Bug 12357: Reproducible crash in WebCore::Settings::isJavaScriptEnabled in svg/custom/js-update-bounce.svg under guard-malloc

  • page/Frame.cpp: (WebCore::Frame::~Frame): Access the global object directly rather than via Window::retrieveWindow to prevent our reference to a deleted settings object being used.
6:46 PM Changeset in webkit [19022] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

  • fix <rdar://problem/4930503> REGRESSION: Page changes title when command-clicking on named anchor link (12299)
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): Return if shouldContinue is false. This matches the other similar functions and prevents us from doing extra work in the "ignore" case.
6:16 PM Changeset in webkit [19021] by bdash
  • 2 edits in trunk/WebCore

2007-01-21 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12355
Bug 12355: Reproducible crash in WebCore::parseNumber in svg/custom/js-update-bounce.svg under guard-malloc

  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::parseNumber): Parenthesize to prevent reading past end of buffer.
5:41 PM Changeset in webkit [22801] by adele
  • 2 edits
    2 adds in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adam.

Adding RenderThemeSafari.


5:33 PM Changeset in webkit [19020] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/forms/select-disabled-appearance-expected.checksum: Added.
  • fast/forms/select-disabled-appearance-expected.png: Added.
  • fast/forms/select-disabled-appearance-expected.txt: Added.
  • fast/forms/select-disabled-appearance.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/select-disabled-appearance.html

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::adjustMenuListStyle):
5:17 PM Changeset in webkit [19019] by darin
  • 4 edits in trunk/WebCore
  • fix non-Mac builds
  • CMakeLists.txt: Added JSDocumentCustom.cpp.
  • WebCore.pro: Ditto.
  • WebCoreSources.bkl: Ditto.
5:09 PM Changeset in webkit [19018] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/HTMLImageElement/constructor-mutation-event-dispatch-expected.txt: Added.
  • fast/dom/HTMLImageElement/constructor-mutation-event-dispatch.html: Added.

WebCore:

Reviewed by Darin.


Test: fast/dom/HTMLImageElement/constructor-mutation-event-dispatch.html

  • bindings/js/kjs_html.cpp: (KJS::ImageConstructorImp::construct): Protect the image element before setting its attributes.
4:54 PM Changeset in webkit [22800] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Added JSDocumentCustom.cpp.
4:53 PM Changeset in webkit [19017] by darin
  • 2 edits in trunk/WebKit

Reviewed by Tim H.

  • WebInspector/webInspector/inspector.css: Use row-resize for the splitter cursor instead of move. It's a horizontal splitter resizer.
3:42 PM Changeset in webkit [19016] by weinig
  • 4 edits
    4 deletes in trunk

LayoutTests:

Rolling out patch for ​http://bugs.webkit.org/show_bug.cgi?id=8360.

  • fast/layers/removed-by-scroll-handler-expected.checksum: Removed.
  • fast/layers/removed-by-scroll-handler-expected.png: Removed.
  • fast/layers/removed-by-scroll-handler-expected.txt: Removed.
  • fast/layers/removed-by-scroll-handler.html: Removed.

WebCore:

Rolling out patch for ​http://bugs.webkit.org/show_bug.cgi?id=8360.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::updateScrollInfoAfterLayout): (WebCore::Marquee::start):
  • rendering/RenderLayer.h:
2:07 PM Changeset in webkit [19015] by ddkilzer
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/document-all-select-expected.txt: Added.
  • fast/dom/document-all-select.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/dom/document-all-select.html

  • html/HTMLCollection.cpp: (WebCore::HTMLCollection::checkForNameMatch): (WebCore::HTMLCollection::updateNameCache):
1:03 PM Changeset in webkit [19014] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • manual-tests/onblur-remove.html: Changed the test to not require pressing Enter, since the correct behavior for Enter is to send a blur event.
12:51 PM Changeset in webkit [19013] by weinig
  • 10 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for: <rdar://problem/4928583> Memory usage grows when reloading google.com/ig

  • fast/dom/gc-10-expected.txt: Added.
  • fast/dom/gc-10.html: Added.
  • fast/dom/resources/gc-10-frame.html: Added.

WebCore:

Reviewed by Darin.

Fix for: <rdar://problem/4928583> Memory usage grows when reloading google.com/ig

JSDocuments are now responsible for marking the DOM wrappers associated with them, when they get marked.
This fixes a JS object leak when a DOM wrapper has a reference to a JSDocument that is otherwise not reachable.

Test: fast/dom/gc-10.html

  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDocumentCustom.cpp: Added. (WebCore::JSDocument::mark):
  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::markDOMNodesForDocument): (KJS::ScriptInterpreter::mark):
  • bindings/js/kjs_binding.h:
  • dom/Document.idl:

WebKitTools:

Reviewed by Darin.

Test support for: <rdar://problem/4928583> Memory usage grows when reloading google.com/ig

This adds a getJSObjectCount test-accessible function to allow test scripts to track JSObject usage.

  • DumpRenderTree/GCController.h:
  • DumpRenderTree/GCController.mm: (+[GCController isSelectorExcludedFromWebScript:]): (-[GCController getJSObjectCount]):
12:29 PM Changeset in webkit [19012] by weinig
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/overflow/position-relative-expected.checksum: Added.
  • fast/overflow/position-relative-expected.png: Added.
  • fast/overflow/position-relative-expected.txt: Added.
  • fast/overflow/position-relative.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/overflow/position-relative.html

  • rendering/RenderBox.cpp: (WebCore::RenderBox::lowestPosition): Add the relative position offset only if 'includeSelf' is true. (WebCore::RenderBox::rightmostPosition): Ditto. (WebCore::RenderBox::leftmostPosition): Ditto.
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::lowestPosition): Ditto. (WebCore::RenderFlow::rightmostPosition): Ditto. (WebCore::RenderFlow::leftmostPosition): Ditto.
9:19 AM Changeset in webkit [19011] by weinig
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/HTMLSelectElement/options-collection-detached-expected.txt: Added.
  • fast/dom/HTMLSelectElement/options-collection-detached.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/dom/HTMLSelectElement/options-collection-detached.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setRecalcListItems): Reset the options collection info if the <select> is not in the document. For in-document <select>s this happens anyway as a result of the DOM tree version increasing.
9:05 AM Changeset in webkit [19010] by weinig
  • 7 edits in trunk

LayoutTests:

Reviewed by Darin.

  • fast/forms/file-input-disabled-expected.checksum:
  • fast/forms/file-input-disabled-expected.png:
  • fast/forms/file-input-disabled-expected.txt:

WebCore:

Reviewed by Darin.

Covered by fast/forms/file-input-disabled.html

  • css/html4.css: Changed selectors that had pseudo-classes after the -webkit-file-upload-button pseudo-element to have the pseudo-element at the end. Pseudo-elements must be at the end.
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::createButtonStyle): Changed to not overwrite the button's style with its parent's style. getPseudoStyle() handles inheritance properly.
8:55 AM Changeset in webkit [19009] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Darin.

  • platform/Font.cpp: (WebCore::Font::glyphDataForCharacter):
8:20 AM Changeset in webkit [19008] by darin
  • 3 edits in trunk/WebCore

Reviewed by Adam and Mitz.

Covered by existing test: fast/forms/listbox-selection.html

  • rendering/RenderListBox.h: Added override of layout(), made selectionChanged() no longer an inline. Added private scrollToRevealSelection(), m_scrollToRevealSelectionAfterLayout, and m_inAutoscroll.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::RenderListBox): Initialize new data members. (WebCore::RenderListBox::updateFromElement): Remove scrolling code. (WebCore::RenderListBox::selectionChanged): Moved from header. Calls repaint and then scrollToRevealSelection, but if we need layout, instead schedules scrollToRevealSelection to be done after layout. (WebCore::RenderListBox::layout): Added. After calling base class, calls scrollToRevealSelection if the m_scrollToRevealSelectionAfterLayout is set. (WebCore::RenderListBox::scrollToRevealSelection): Added. Code was originally in updateFromElement. (WebCore::RenderListBox::autoscroll): Set m_inAutoscroll so that the selectionChanged function knows not to scroll. Also removed the repaint() here because updateListBoxSelection() takes care of repainting by calling selectionChanged().
5:07 AM Changeset in webkit [19007] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by NOBODY (no-svg build fix).

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): Changed #if SVG_SUPPORT to #ifdef SVG_SUPPORT.

Jan 20, 2007:

4:44 PM Changeset in webkit [19006] by weinig
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/forms/text-set-value-crash-expected.txt: Added.
  • fast/forms/text-set-value-crash.html: Added.

WebCore:

Reviewed by Maciej.

Test: fast/forms/text-set-value-crash.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setValue): Added a call to Document::updateRendering().
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue): Ditto.
4:35 PM Changeset in webkit [19005] by weinig
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/layers/removed-by-scroll-handler-expected.checksum: Added.
  • fast/layers/removed-by-scroll-handler-expected.png: Added.
  • fast/layers/removed-by-scroll-handler-expected.txt: Added.
  • fast/layers/removed-by-scroll-handler.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/layers/removed-by-scroll-handler.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::dispatchScrollEvent): Added. Called when the timer fires and dispatches the scroll event to the layer's element. (WebCore::RenderLayer::scrollToOffset): Instead of dispatching the scroll event from this function, which is called during layout, schedule a 0-duration timer to dispatch the event after layout. (WebCore::RenderLayer::scrollRectToVisible): (WebCore::RenderLayer::updateScrollInfoAfterLayout): (WebCore::Marquee::start):
  • rendering/RenderLayer.h:
3:45 PM Changeset in webkit [19004] by zimmermann
  • 1 edit
    12 adds in trunk/LayoutTests

Forgot to include the new layout tests in the last commit.

3:40 PM Changeset in webkit [19003] by zimmermann
  • 14 edits in trunk/WebCore

Reviewed by Sam.

Fix JS bindings for SVGAnimated{Boolean, Enumeration, Integer, Number, String}.

Dynamic SVG DOM updates (ie. "someUse.href.baseVal = '#rect'") with these types
didn't work. Existing gradient updating examples relied on calling setAttribute
after a SVG DOM update - that was the only reason it worked, added a new test
only using SVG DOM updates (js-update-stop.svg).

1:52 PM Changeset in webkit [19002] by rwlbuis
  • 5 edits
    1 add in trunk/WebCore

Reviewed by Sam.

​http://bugs.webkit.org/show_bug.cgi?id=12334
Respect <text> boundaries for svg text selecting

Make sure the text selection for svg stays inside
containing blocks.
Added one manual test since html selection does not
seem to work for SVG and selectSubString for SVG
is not implemented yet.

7:03 AM Changeset in webkit [19001] by darin
  • 27 edits
    88 adds in trunk/LayoutTests
  • updated results because my recent check-in made list boxes one pixel taller
  • fast/forms/HTMLOptionElement_label05-expected.checksum:
  • fast/forms/HTMLOptionElement_label05-expected.png:
  • fast/forms/HTMLOptionElement_label05-expected.txt:
  • fast/forms/form-element-geometry-expected.checksum:
  • fast/forms/form-element-geometry-expected.png:
  • fast/forms/form-element-geometry-expected.txt:
  • fast/forms/listbox-clip-expected.checksum:
  • fast/forms/listbox-clip-expected.png:
  • fast/forms/listbox-clip-expected.txt:
  • fast/forms/listbox-width-change-expected.checksum:
  • fast/forms/listbox-width-change-expected.png:
  • fast/forms/listbox-width-change-expected.txt:
  • fast/forms/option-strip-whitespace-expected.checksum:
  • fast/forms/option-strip-whitespace-expected.png:
  • fast/forms/option-strip-whitespace-expected.txt:
  • fast/forms/select-change-popup-to-listbox-expected.checksum:
  • fast/forms/select-change-popup-to-listbox-expected.png:
  • fast/forms/select-change-popup-to-listbox-expected.txt:
  • fast/replaced/replaced-breaking-expected.checksum:
  • fast/replaced/replaced-breaking-expected.png:
  • fast/replaced/replaced-breaking-expected.txt:
  • fast/text/updateNewFont-expected.checksum:
  • fast/text/updateNewFont-expected.png:
  • fast/text/updateNewFont-expected.txt:
  • reset results since the ones I generated before were on Leopard
  • fast/forms/select-list-box-with-height-expected.checksum:
  • fast/forms/select-list-box-with-height-expected.png:
  • generated some missing pixel results
  • http/tests/navigation/anchor-basic-expected.checksum: Added.
  • http/tests/navigation/anchor-basic-expected.png: Added.
  • http/tests/navigation/anchor-frames-expected.checksum: Added.
  • http/tests/navigation/anchor-frames-expected.png: Added.
  • http/tests/navigation/anchor-goback-expected.checksum: Added.
  • http/tests/navigation/anchor-goback-expected.png: Added.
  • http/tests/navigation/anchor-subframeload-expected.checksum: Added.
  • http/tests/navigation/anchor-subframeload-expected.png: Added.
  • http/tests/navigation/error404-basic-expected.checksum: Added.
  • http/tests/navigation/error404-basic-expected.png: Added.
  • http/tests/navigation/error404-frames-expected.checksum: Added.
  • http/tests/navigation/error404-frames-expected.png: Added.
  • http/tests/navigation/error404-goback-expected.checksum: Added.
  • http/tests/navigation/error404-goback-expected.png: Added.
  • http/tests/navigation/error404-subframeload-expected.checksum: Added.
  • http/tests/navigation/error404-subframeload-expected.png: Added.
  • http/tests/navigation/javascriptlink-basic-expected.checksum: Added.
  • http/tests/navigation/javascriptlink-basic-expected.png: Added.
  • http/tests/navigation/javascriptlink-frames-expected.checksum: Added.
  • http/tests/navigation/javascriptlink-frames-expected.png: Added.
  • http/tests/navigation/javascriptlink-goback-expected.checksum: Added.
  • http/tests/navigation/javascriptlink-goback-expected.png: Added.
  • http/tests/navigation/javascriptlink-subframeload-expected.checksum: Added.
  • http/tests/navigation/javascriptlink-subframeload-expected.png: Added.
  • http/tests/navigation/metaredirect-basic-expected.checksum: Added.
  • http/tests/navigation/metaredirect-basic-expected.png: Added.
  • http/tests/navigation/metaredirect-frames-expected.checksum: Added.
  • http/tests/navigation/metaredirect-frames-expected.png: Added.
  • http/tests/navigation/metaredirect-goback-expected.checksum: Added.
  • http/tests/navigation/metaredirect-goback-expected.png: Added.
  • http/tests/navigation/metaredirect-subframeload-expected.checksum: Added.
  • http/tests/navigation/metaredirect-subframeload-expected.png: Added.
  • http/tests/navigation/post-basic-expected.checksum: Added.
  • http/tests/navigation/post-basic-expected.png: Added.
  • http/tests/navigation/post-frames-expected.checksum: Added.
  • http/tests/navigation/post-frames-expected.png: Added.
  • http/tests/navigation/post-goback1-expected.checksum: Added.
  • http/tests/navigation/post-goback1-expected.png: Added.
  • http/tests/navigation/post-goback2-expected.checksum: Added.
  • http/tests/navigation/post-goback2-expected.png: Added.
  • http/tests/navigation/postredirect-basic-expected.checksum: Added.
  • http/tests/navigation/postredirect-basic-expected.png: Added.
  • http/tests/navigation/postredirect-frames-expected.checksum: Added.
  • http/tests/navigation/postredirect-frames-expected.png: Added.
  • http/tests/navigation/postredirect-goback1-expected.checksum: Added.
  • http/tests/navigation/postredirect-goback1-expected.png: Added.
  • http/tests/navigation/postredirect-goback2-expected.checksum: Added.
  • http/tests/navigation/postredirect-goback2-expected.png: Added.
  • http/tests/navigation/redirect302-basic-expected.checksum: Added.
  • http/tests/navigation/redirect302-basic-expected.png: Added.
  • http/tests/navigation/redirect302-frames-expected.checksum: Added.
  • http/tests/navigation/redirect302-frames-expected.png: Added.
  • http/tests/navigation/redirect302-goback-expected.checksum: Added.
  • http/tests/navigation/redirect302-goback-expected.png: Added.
  • http/tests/navigation/redirect302-subframeload-expected.checksum: Added.
  • http/tests/navigation/redirect302-subframeload-expected.png: Added.
  • http/tests/navigation/relativeanchor-basic-expected.checksum: Added.
  • http/tests/navigation/relativeanchor-basic-expected.png: Added.
  • http/tests/navigation/relativeanchor-frames-expected.checksum: Added.
  • http/tests/navigation/relativeanchor-frames-expected.png: Added.
  • http/tests/navigation/relativeanchor-goback-expected.checksum: Added.
  • http/tests/navigation/relativeanchor-goback-expected.png: Added.
  • http/tests/navigation/slowmetaredirect-basic-expected.checksum: Added.
  • http/tests/navigation/slowmetaredirect-basic-expected.png: Added.
  • http/tests/navigation/slowtimerredirect-basic-expected.checksum: Added.
  • http/tests/navigation/slowtimerredirect-basic-expected.png: Added.
  • http/tests/navigation/success200-basic-expected.checksum: Added.
  • http/tests/navigation/success200-basic-expected.png: Added.
  • http/tests/navigation/success200-frames-expected.checksum: Added.
  • http/tests/navigation/success200-frames-expected.png: Added.
  • http/tests/navigation/success200-frames-loadsame-expected.checksum: Added.
  • http/tests/navigation/success200-frames-loadsame-expected.png: Added.
  • http/tests/navigation/success200-goback-expected.checksum: Added.
  • http/tests/navigation/success200-goback-expected.png: Added.
  • http/tests/navigation/success200-loadsame-expected.checksum: Added.
  • http/tests/navigation/success200-loadsame-expected.png: Added.
  • http/tests/navigation/success200-reload-expected.checksum: Added.
  • http/tests/navigation/success200-reload-expected.png: Added.
  • http/tests/navigation/success200-subframeload-expected.checksum: Added.
  • http/tests/navigation/success200-subframeload-expected.png: Added.
  • http/tests/navigation/timerredirect-basic-expected.checksum: Added.
  • http/tests/navigation/timerredirect-basic-expected.png: Added.
  • http/tests/navigation/timerredirect-frames-expected.checksum: Added.
  • http/tests/navigation/timerredirect-frames-expected.png: Added.
  • http/tests/navigation/timerredirect-goback-expected.checksum: Added.
  • http/tests/navigation/timerredirect-goback-expected.png: Added.
  • http/tests/navigation/timerredirect-subframeload-expected.checksum: Added.
  • http/tests/navigation/timerredirect-subframeload-expected.png: Added.
1:14 AM Changeset in webkit [19000] by bdash
  • 2 edits in trunk/WebKitTools

2007-01-20 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

  • BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Track the output of run-javascriptcore-tests, catch single regressions, and don't generate tests results for new tests.
12:45 AM Changeset in webkit [18999] by aroben
  • 2 edits in trunk/WebKitTools

Rubberstamped by Maciej.

  • Scripts/run-webkit-tests: Change the default behavior back to generating results for new tests (this can be disabled with --no-new-test-results)

Jan 19, 2007:

11:07 PM Changeset in webkit [18998] by aroben
  • 1 edit in branches/Safari-2-0-branch/WebKit/ChangeLog

Fixed ChangeLog.

7:21 PM Changeset in webkit [18997] by kdecker
  • 6 edits in branches/Safari-2-0-branch/WebKit

Reviewed by Adam.


Merged r10259 and r15845 from TOT to Safari-2-0-branch.

2006-08-11 Tim Omernick <​timo@apple.com>

Reviewed by Darin.

<​http://bugzilla.opendarwin.org/show_bug.cgi?id=10111> - Menu flickers over Flash content
<rdar://problem/3052546> Plugins don't work with z-index (overlapping elements, etc.)

  • Plugins/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Don't just clip to the dirty region for "transparent" plug-ins -- do it for all plug-ins. This is a generally useful thing to do, as it prevents the plug-in from drawing over parts of the window that have already been drawn and are not expected to be redrawn in the same update.

2005-09-13 Tim Omernick <​tomernick@apple.com>

Reviewed by Justin Garcia, Darin Adler.

  • <rdar://problem/3163393> Safari does not support Windowless mode in Flash
  • Plugins.subproj/WebBaseNetscapePluginView.h:

Added 'isTransparent' instance variable.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]):

When updating a plugin in "windowless" (transparent) mode, clip drawing to the dirty
region of the opaque ancestor. This means that a partially-transparent plugin, which
by definition does not clear its port on redraw, will not overdraw the valid parts
of its port.

(-[WebBaseNetscapePluginView sendEvent:]):

Disabled the "green debug background" for transparent plugins -- since they are not
expected to cover their entire port every redraw, this debug code makes no sense.

(-[WebBaseNetscapePluginView setVariable:value:]):

Implemented -setVariable:value:, which is called from NPN_SetValue() (previously
unimplemented).
Right now we only handle NPPVpluginTransparentBool; if we choose to handle the other
plugin variables, then we may do so here.

  • Plugins.subproj/WebBaseNetscapePluginViewPrivate.h:

Added SPI for -[WebBaseNetscapePluginView setVariable:value].

  • Plugins.subproj/npapi.m: (NPN_SetValue):

Implemented this function so that plugins may set state (such as window mode).


4:40 PM Changeset in webkit [18996] by adele
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/4697438> REGRESSION: select menu lists match the wrong css rule on www.chainreaction.com

  • fast/forms/select-size-expected.checksum: Added.
  • fast/forms/select-size-expected.png: Added.
  • fast/forms/select-size-expected.txt: Added.
  • fast/forms/select-size.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for: <rdar://problem/4697438> REGRESSION: select menu lists match the wrong css rule on www.chainreaction.com

Update the size attribute value for select elements to match the numeric value. This is a special case since this
attribute is used to determine which control to use. We want to make sure that the size attribute is valid when we match
CSS rules.

Test: fast/forms/select-size.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::parseMappedAttribute): If the attribute string value is not the same as its integer value, then update the attribute value to match the integer.
  • dom/Attribute.h: Made setValue and setPrefix public.
4:33 PM Changeset in webkit [22799] by adachan
  • 4 edits
    1 add in branches/WindowsMerge/WebKitWin

2007-01-19 Ada Chan <​adachan@apple.com>

WebKitWin:

Fixed build.

Reviewed by Anders.
Added IWebResourceLoadDelegatePrivate which has one method: didLoadResourceFromMemoryCache.

  • ChangeLog:
  • Interfaces/IWebResourceLoadDelegatePrivate.idl: Added.
  • WebFrame.cpp: (WebFrame::dispatchDidFinishDocumentLoad):
  • WebKit.vcproj/Interfaces.vcproj:
  • WebKit.vcproj/WebKitGUID.vcproj:


4:32 PM Changeset in webkit [18995] by aroben
  • 3 edits in trunk/WebKit

Reviewed by Beth.

Fix <rdar://problem/4942294> REGRESSION: "Spelling and Grammar",
"Font", "Speech", and "Writing Direction" are missing from contextual
menu

  • WebCoreSupport/WebContextMenuClient.mm: (fixMenusForOldClients): Change our new SPI tags to WebMenuItemTagOther because old clients aren't expecting the new tags. (fixMenusFromOldClients): Use each menu item's title to figure out its correct tag again. (WebContextMenuClient::getCustomMenuFromDefaultItems): Call fixMenusForOldClients before calling up to the delegate.
  • WebView/WebUIDelegatePrivate.h: Define WEBMENUITEMTAG_SPI_START so that we can use it in WebContextMenuClient.
4:14 PM Changeset in webkit [22798] by sullivan
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Lou.


Added mechanism for new callbacks, to try to avoid breaking the Windows build.

  • Interfaces/IWebFrameLoadDelegatePrivate.idl:
  • WebFrame.cpp: (WebFrame::dispatchDidFinishDocumentLoad):
  • WebFrame.h:
4:02 PM Changeset in webkit [18994] by sullivan
  • 13 edits in trunk

WebCore:

Reviewed by Darin

  • WebCore part of fix for: <rdar://problem/4451715> REGRESSION: On some sites, have to type a character before username/password autofill kicks in
  • loader/FrameLoaderClient.h: new dispatchDidFinishDocumentLoad call
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedParsing): call dispatchDidFinishDocumentLoad


  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::dispatchDidFinishDocumentLoad): empty implementation for dispatchDidFinishDocumentLoad

WebKit:

Reviewed by Darin

  • WebKit part of fix for: <rdar://problem/4451715> REGRESSION: On some sites, have to type a character before username/password autofill kicks in


Added new webView:didFinishDocumentLoadForFrame: SPI and wired it up

  • WebView/WebViewPrivate.h: declare new delegate method
  • WebCoreSupport/WebFrameLoaderClient.h: declare dispatchDidFinishDocumentLoad()
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchDidFinishDocumentLoad): new method, calls new delegate method
  • DefaultDelegates/WebDefaultFrameLoadDelegate.m: (-[WebDefaultFrameLoadDelegate webView:didFinishDocumentLoadForFrame:]): empty default implementation of new delegate method

WebKitQt:

Added stubs for new callbacks, to try to avoid breaking the Qt port.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::dispatchDidFinishDocumentLoad):
  • WebCoreSupport/FrameLoaderClientQt.h:
3:48 PM Changeset in webkit [18993] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/4760280> REGRESSION: Bottom portion of text hangs off edge of SELECT element at ​http://macreviewzone.com/index.php

  • fast/forms/control-restrict-line-height-expected.checksum: Added.
  • fast/forms/control-restrict-line-height-expected.png: Added.
  • fast/forms/control-restrict-line-height-expected.txt: Added.
  • fast/forms/control-restrict-line-height.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/4760280> REGRESSION: Bottom portion of text hangs off edge of SELECT element at ​http://macreviewzone.com/index.php


Test: fast/forms/control-restrict-line-height.html

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::setFontFromControlSize): Don't honor line-height for controls that have restricted font size.
3:18 PM Changeset in webkit [18992] by andersca
  • 2 edits in trunk/WebKit

Reviewed by John Sullivan.

​http://bugs.webkit.org/show_bug.cgi?id=12308
REGRESSION(r18910): Crash in WebBaseNetscapePluginStream cancelLoadAndDestroyStreamWithError


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): Move code from initWithFrame in here.
3:15 PM Changeset in webkit [18991] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Fix date.

3:15 PM Changeset in webkit [18990] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Fix bug number.

3:12 PM Changeset in webkit [18989] by darin
  • 8 edits
    8 adds in trunk

LayoutTests:

Reviewed by Adele.

  • test for html4.css problem where we had a missing semicolon and thus missed parsing a style rule
  • fast/forms/radio-no-theme-padding-expected.txt: Added.
  • fast/forms/radio-no-theme-padding.html: Added.
  • fast/forms/select-list-box-mouse-focus-expected.txt: Added.
  • fast/forms/select-list-box-mouse-focus.html: Added.

Note: Only the pixel test shows the failure in the old version.

Note: I generated the pixel results on Leopard -- may need to be
regenated on Tiger.

  • fast/forms/select-list-box-with-height-expected.checksum: Added.
  • fast/forms/select-list-box-with-height-expected.png: Added.
  • fast/forms/select-list-box-with-height-expected.txt: Added.
  • fast/forms/select-list-box-with-height.html: Added.

WebCore:

Reviewed by Adele.

  • fix ​http://bugs.webkit.org/show_bug.cgi?id=11999 <rdar://problem/4940442> REGRESSION: Incomplete listing in TVListings window (11999) Fix was to use the actual size of the renderer in the RenderListBox case, instead of always using the size specified by the select element.

Test: fast/forms/select-list-box-with-height.html

Test: fast/forms/select-list-box-mouse-focus.html

  • fix bug where auto-scrolling was not working in list box select elements

No test yet.

  • fix a missing semicolon in the radio/checkbox section of html4.css

Test: fast/forms/radio-no-theme-padding.html

  • fix bug where the scroll bars for select elements were pixel-type scroll bars even though the scrolling is line at a time scrolling

No test.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::selectAll): Removed an explicit call to repaint, since the RenderListBox now does that in selectionChanged. (WebCore::HTMLSelectElement::notifyOptionSelected): Call the new selectionChanged instead of the old setSelectionChanged. (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Added a call to focus. Removed an explicit call to repaint and added a call to the new setMouseDownMayStartAutoscroll function in EventHandler. Removed an explicit call to repaint as above. (WebCore::HTMLSelectElement::updateListBoxSelection): Call the new selectionChanged instead of the old setSelectionChanged.
  • page/EventHandler.h: Added setMouseDownMayStartAutoscroll, needed because the existing code to set that flag won't get triggered when the select element's default event handler handles the event.
  • rendering/RenderListBox.h: Made ScrollbarClient a private base class. Removed setSelectionChanged and m_selectionChanged. Added selectionChanged, which is really just a synonym for repaint for now. Moved valueChanged, the ScrollbarClient function implementations, and itemHeight into the private part of the class. Added numVisibleItems() and listHeight() to the private section. Changed m_vBar to be a RefPtr.
  • rendering/RenderListBox.cpp: Removed unneeded includes. Moved all the constants to the top of the file. (WebCore::RenderListBox::RenderListBox): Removed initialization of m_selectionChanged because it was removed and of m_vBar because it's now a RefPtr which is automaticall initialized. (WebCore::RenderListBox::~RenderListBox): Removed the explicit deref of m_vBar because it's a RefPtr. Added null checking for FrameView. (WebCore::RenderListBox::updateFromElement): Use numItems(). (WebCore::RenderListBox::calcMinMaxWidth): Added null checking for FrameView and used RefPtr for the newly-created scroll bar. (WebCore::RenderListBox::size): Tweaked formatting. Also renamed the misleading minDefaultSize to maxDefaultSize, since it's a maximum. (WebCore::RenderListBox::numVisibleItems): Added. Used in many places where size() was used before. This computes the number of rows we have room for. We don't need a row space after the last row, and this takes that into account. (WebCore::RenderListBox::numItems): Tweaked to remove the local variable. (WebCore::RenderListBox::listHeight): Added. Total height of all the rows and spaces between them. (WebCore::RenderListBox::calcHeight): Changed to call itemHeight for the row height, and to subtract the last row spacing off since we don't need a space after the last row. Changed the scroll bar setup to make it correspond to row numbers, not pixel numbers. (WebCore::RenderListBox::baselinePosition): Moved the comment to the constant declaration at the top of the file. (WebCore::RenderListBox::itemBoundingBoxRect): Simplified by using the itemHeight() function. (WebCore::RenderListBox::paintObject): Changed to use numItems and to use numVisibleItems instead of size. (WebCore::RenderListBox::isPointInScrollbar): Added get() call since m_vBar is now a RefPtr. (WebCore::RenderListBox::listIndexAtOffset): Changed to use numItems(), itemHeight(), and rearranged a min/max combo so it starts with the low, then the value, then the high value for pinning. (WebCore::RenderListBox::autoscroll): Use numVisibleItems() instead of size(). (WebCore::RenderListBox::stopAutoscroll): Removed an unneeded nil check of the element. (WebCore::RenderListBox::scrollToRevealElementAtListIndex): Changed to use numItems() and to use numVisibleItems() instead of size(). Also changed scroll bar code to work more simply now that the scroll bar is row-based. (WebCore::RenderListBox::listIndexIsVisible): Changed to use numVisibleItems() instead of size(). (WebCore::RenderListBox::valueChanged): Simplified since the scrollbar is now row-based. Also removed an unnecessary null check. (WebCore::RenderListBox::itemHeight): Updated for name change from optionsSpacingMiddle to rowSpacing. (WebCore::RenderListBox::scrollHeight): Changed to use listHeight(). (WebCore::RenderListBox::setScrollTop): Simplified, and removed the code that does nothing if the computed list index is visible (which did not make sense for this function and seemed a cut and paste error from the scrollToReveal function). The scrollbar part is simpler now that it's row-based. (WebCore::RenderListBox::windowClipRect): Changed to use document()->view() so we don't have to include RenderView.h.
  • css/html4.css: Added a semicolon I noticed was missing.
2:36 PM Changeset in webkit [22797] by beidson
  • 6 edits in branches/WindowsMerge/WebKitWin

Reviewed by Ada

Much more realistic WebDownload interface that delegates will actually have to implement


  • Interfaces/IWebDownload.idl:

Also updated svn:eol-style on .idls

1:57 PM Changeset in webkit [18988] by bdakin
  • 8 edits
    8 adds
    4 deletes in trunk

WebCore:

Reviewed by Maciej and Darin.

Fix for <rdar://problem/4702420> REGRESSION: Null characters need
to be stripped from text nodes (townhall.com)

This was a regression from the fix for <rdar://problem/3727939>
Safari strips \0 characters from HTML tags making them valid, which
was fixed with r12652. We still need to strip null characters in
text nodes.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::write): No behavior change here, this is just to make Darin happy. (WebCore::HTMLTokenizer::processToken): Call into StringImpl's new createStrippingNull function instead of the normal StringImpl constructor.
  • platform/StringImpl.cpp: (WebCore::StringImpl::createStrippingNull): Strip null.
  • platform/StringImpl.h:

LayoutTests:

Reviewed by Maciej and Darin.

New layout tests and some updates results for the fix for <rdar://
problem/4702420> REGRESSION: Null characters need to be stripped
from text nodes (townhall.com)

  • fast/dom/stripNullFromTextNodes-expected.checksum: Added.
  • fast/dom/stripNullFromTextNodes-expected.png: Added.
  • fast/dom/stripNullFromTextNodes-expected.txt: Added.
  • fast/dom/stripNullFromTextNodes.html: Added.
  • fast/js/null-char-in-string-expected.txt: New results.
  • fast/text/stripNullFromText-expected.checksum: Added.
  • fast/text/stripNullFromText-expected.png: Added.
  • fast/text/stripNullFromText-expected.txt: Added.
  • fast/text/stripNullFromText.html: Added.
  • tables/mozilla/images/adforce_imgis_com-expected.txt: New results.
  • tables/mozilla_expected_failures/images/adforce_imgis_com- expected.checksum: Removed. This is the same test as the one above. The same test was in two places.
  • tables/mozilla_expected_failures/images/adforce_imgis_com- expected.png: Removed.
  • tables/mozilla_expected_failures/images/adforce_imgis_com- expected.txt: Removed.
  • tables/mozilla_expected_failures/images/adforce_imgis_com.html: Removed.
1:16 PM Changeset in webkit [18987] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by NOBODY (no-svg build fix).

  • ksvg2/svg/SVGMPathElement.cpp: Added #ifdef SVG_SUPPORT/#endif guards.
12:47 PM Changeset in webkit [22796] by adachan
  • 10 edits
    2 adds in branches/WindowsMerge

2007-01-18 Ada Chan <​adachan@apple.com>

Reviewed by Steve.


WebKitWin:

<rdar://4601522> Activity Window

  • Added some NSURL equivalent constants in IWebURLResponse.idl and IWebError.idl
  • Added IWebErrorPrivate.idl which contains some private error codes
  • Added IWebHTTPURLResponse interface which extends IWebURLResponse. It has the same API as NSHTTPURLResponse.

WebCoreWin:

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
  • Interfaces/IWebError.idl:
  • Interfaces/IWebErrorPrivate.idl: Added.
  • Interfaces/IWebHTTPURLResponse.idl: Added.
  • Interfaces/IWebResourceLoadDelegate.idl: fixed a typo in parameter name
  • Interfaces/IWebURLResponse.idl: added WebURLResponseUnknownLength
  • WebKit.vcproj/Interfaces.vcproj: for adding IWebErrorPrivate.idl and IWebHTTPURLResponse.idl
  • WebKit.vcproj/WebKitGUID.vcproj: for the new IID_IWebHTTPURLResponse
  • WebURLResponse.cpp: (WebURLResponse::QueryInterface): also returns the new IWebHTTPURLResponse interface (WebURLResponse::allHeaderFields): Added stub for IWebHTTPURLResponse::allHeaderFields. (WebURLResponse::localizedStringForStatusCode): Added stub for IWebHTTPURLResponse::localizedStringforStatusCode (WebURLResponse::statusCode): Implemented IWebHTTPURLResponse::statusCode.
  • WebURLResponse.h:


10:25 AM Changeset in webkit [18986] by andersca
  • 3 edits in trunk/WebKit

Yet another build fix.


  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::setStatusbarText):
10:12 AM Changeset in webkit [22795] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Add SVG files.
9:59 AM Changeset in webkit [18985] by andersca
  • 3 edits in trunk/WebKitQt

Try fixing the QT build.


  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::runJavaScriptAlert): (WebCore::ChromeClientQt::runJavaScriptConfirm): (WebCore::ChromeClientQt::runJavaScriptPrompt): (WebCore::ChromeClientQt::setStatusbarText):
  • WebCoreSupport/ChromeClientQt.h:
9:58 AM Changeset in webkit [22794] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


  • platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenuItem::enabled): Use correct class name.
9:52 AM Changeset in webkit [18984] by andersca
  • 2 edits in trunk/WebCore

Build fix.


  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::setStatusbarText):
9:42 AM Changeset in webkit [22793] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

The obligatory build fix.


  • WebChromeClient.cpp: (WebChromeClient::runJavaScriptPrompt):
9:38 AM Changeset in webkit [22792] by andersca
  • 9 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

Remove some unused FrameWin functions.


  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::~FrameWin):
  • bridge/win/FrameWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::status):

WebKitWin:

Reviewed by Adam.

  • WebChromeClient.cpp: (WebChromeClient::runJavaScriptAlert): (WebChromeClient::runJavaScriptConfirm): (WebChromeClient::runJavaScriptPrompt): (WebChromeClient::setStatusbarText):
  • WebChromeClient.h: Add new ChromeClient methods.


  • WebFrame.cpp: (WebFrame::userAgent): (WebFrame::updateGlobalHistoryForReload):
  • WebFrame.h: Remove unused FrameWinClient functions.
9:28 AM Changeset in webkit [18983] by andersca
  • 15 edits in trunk

WebCore:

Reviewed by Adam.

Move JavaScript alert and status bar functions to the chrome.


  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
  • page/Chrome.cpp: (WebCore::Chrome::runJavaScriptAlert): (WebCore::Chrome::runJavaScriptConfirm): (WebCore::Chrome::runJavaScriptPrompt): (WebCore::Chrome::setStatusBarText):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Frame.cpp: (WebCore::Frame::setJSStatusBarText): (WebCore::Frame::setJSDefaultStatusBarText):
  • page/Frame.h:
  • page/mac/FrameMac.h:
  • page/mac/FrameMac.mm:
  • page/mac/WebCoreFrameBridge.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::runJavaScriptAlert): (WebCore::SVGEmptyChromeClient::runJavaScriptConfirm): (WebCore::SVGEmptyChromeClient::runJavaScriptPrompt): (WebCore::SVGEmptyChromeClient::setStatusBarText):

WebKit:

Reviewed by Adam.

Move functions from the bridge to the chrome client.


  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::runJavaScriptAlert): (WebChromeClient::runJavaScriptConfirm): (WebChromeClient::runJavaScriptPrompt): (WebChromeClient::setStatusBarText):
  • WebCoreSupport/WebFrameBridge.mm:
8:02 AM Changeset in webkit [18982] by zack
  • 2 edits in trunk/WebCore

Fix the build

6:27 AM Changeset in webkit [18981] by eseidel
  • 5 edits in trunk/WebCore

2007-01-19 Eric Seidel <​eric@webkit.org>

Reviewed by rwlbuis.

More cleanup to SVGAnimated* classes.

No tests possible (only code cleanup)

  • ksvg2/svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::applyAnimationToValue):
  • ksvg2/svg/SVGAnimateMotionElement.h:
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseBeginOrEndValue): (WebCore::SVGAnimationElement::parseMappedAttribute): (WebCore::SVGAnimationElement::parseClockValue): (WebCore::SVGAnimationElement::isIndefinite):
  • ksvg2/svg/SVGAnimationElement.h:
6:09 AM Changeset in webkit [18980] by zimmermann
  • 2 edits in trunk/WebCore

Not reviewed.
Remove accidently commited debug output. Shame on me :-)

6:03 AM Changeset in webkit [18979] by zimmermann
  • 44 edits
    31 adds in trunk

Reviewed by Eric.

Rewrite <use> support with a real-shadow tree (as the spec demands), and implement SVGElementInstance.
AFAIK we're the first implementing this SVG feature - after ASV3 (!).

5:42 AM Changeset in webkit [18978] by eseidel
  • 5 edits
    2 adds in trunk/WebCore

2007-01-19 Eric Seidel <​eric@webkit.org>

Reviewed by rwlbuis.

Add support for SVGMPathElement parsing.

No test cases possible (SVGAnimateMotion doesn't work yet)

  • WebCore.xcodeproj/project.pbxproj:
  • ksvg2/svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::animationPath):
  • ksvg2/svg/SVGMPathElement.cpp: Added. (WebCore::SVGMPathElement::SVGMPathElement): (WebCore::SVGMPathElement::~SVGMPathElement): (WebCore::SVGMPathElement::parseMappedAttribute): (WebCore::SVGMPathElement::pathElement):
  • ksvg2/svg/SVGMPathElement.h: Added.
  • ksvg2/svg/SVGNumberList.cpp: (WebCore::SVGNumberList::parse): fix typo in comment
  • ksvg2/svg/svgtags.in: add back mpath
4:59 AM Changeset in webkit [18977] by eseidel
  • 5 edits in trunk/WebCore

2007-01-19 Eric Seidel <​eric@webkit.org>

Reviewed by rwlbuis.

Implement better parsing for keyTimes, keySplines and keyPoints.

Unfortunately none of this code is used much yet, thus isn't very testable.

  • ksvg2/svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::parseMappedAttribute):
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseKeyNumbers): (WebCore::parseKeySplines): (WebCore::SVGAnimationElement::parseMappedAttribute):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGNumberList.cpp: (WebCore::SVGNumberList::parse):
2:09 AM Changeset in webkit [18976] by lars
  • 2 edits in trunk/WebKitTools

Reviewed by Adam Roben.

run-webkit-tests does now not generate new results by default anymore.
You'll have to pass the --new-tests flag to it to force it to do so.

This is required to make it possible to have tests running on multiple
platforms peacefully together.

Jan 18, 2007:

11:01 PM Changeset in webkit [22791] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenu::enabled): Implemented.
10:49 PM Changeset in webkit [18975] by aroben
  • 9 edits in trunk

WebCore:

Reviewed by Beth.

Fix: <rdar://problem/4939672> REGRESSION: With text selected that is
not a link, the "Remove Link" contextual menu item remains active

  • platform/ContextMenuItem.h: Added enabled method.
  • platform/qt/ContextMenuItemQt.cpp: (WebCore::ContextMenuItem::enabled): Implemented.
  • platform/mac/ContextMenuItemMac.mm: (WebCore::ContextMenuItem::enabled): Ditto.
  • platform/mac/ContextMenuMac.mm: (-[WebCoreMenuTarget validateMenuItem:]): Implemented to fulfill the NSMenuValidation protocol.

WebKit:

Reviewed by Beth.

Fix <rdar://problem/4939672> REGRESSION: With text selected that is
not a link, the "Remove Link" contextual menu item remains active

  • WebView/WebHTMLView.mm: (-[WebHTMLView menuForEvent:]): Leave autoenabling of menu items on so that clients can implement validateMenuItem:.
10:28 PM Changeset in webkit [18974] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Adele.

Fix for <rdar://problem/4939558> REGRESSION: "Search in Google",
"Search in Spotlight" and "Look up in Dictionary" are missing
initially from the contextual menu

The bug here is that we select the we were selecting the word after
the context menu event was dispatched and after the context menu
was built up.

  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent): Select the word before dispatching the event. It is safe to remove the check for swallowEvent since WebCore context menus ensure that we always swallow the event anyway.
9:11 PM Changeset in webkit [18973] by bdash
  • 2 edits in trunk/WebCore

2007-01-18 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim H.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=7926
Bug 7926: Crash using -callWebScriptMethod to access offsetTop property

  • bindings/objc/WebScriptObject.mm: (-[WebScriptObject callWebScriptMethod:withArguments:]): Bail out early if function value is an immediate, or if the function object is not callable.
7:34 PM Changeset in webkit [18972] by bdash
  • 2 edits
    1 add in trunk/WebCore

2007-01-18 Sam Weinig <​sam@webkit.org>

Reviewed by Maciej.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=11853
REGRESSION (r17352): Whitespace in <title> is rendered

  • loader/DocumentLoader.cpp: (WebCore::canonicalizedTitle): Changed to also collapse internal whitespace. This required removing an optimization that is no longer possible.
  • manual-tests/title-internal-whitespace.html: Added.
6:27 PM Changeset in webkit [22790] by andersca
  • 7 edits in branches/WindowsMerge/WebKitTools

Reviewed by Adam.

Major cleanups and bugfixes, such as:


Update for changes to the API.
Implement a timer which prevents test from hanging indefinitely.
Fix bugs which would cause the same test result to be dumped twice.


  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (DumpRenderTreeWndProc): Handle timer.


(initialize):
Initialize CoreGraphics so we get fonts.
(runTest):
Add timer.


(initializePreferences):
Turn off Java and Plug-ins.


(main):

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/LayoutTestController.cpp: (waitUntilDoneCallback): (notifyDoneCallback): Fix bug where dump could be called twice.


  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.cpp:
  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/WaitUntilDoneDelegate.h: Fix newlines, update for new API.
5:41 PM Changeset in webkit [22789] by andersca
  • 2 edits
    1 move in branches/WindowsMerge/WebCore

Build fix.


  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/GlyphMapWin.cpp: Removed.
  • platform/win/GlyphPageTreeNodeWin.cpp: Added. (WebCore::GlyphPage::fill):
5:23 PM Changeset in webkit [18971] by bdash
  • 3 edits
    4 adds in trunk

2007-01-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

Test: fast/text/font-initial.html

  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): Give 'font: initial' the Standard generic family. This makes the FontDescription different from that of the initial font of a GraphicsContext, ensuring that the latter will not be used.

2007-01-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Maciej.

  • fast/text/font-initial-expected.checksum: Added.
  • fast/text/font-initial-expected.png: Added.
  • fast/text/font-initial-expected.txt: Added.
  • fast/text/font-initial.html: Added.
5:19 PM Changeset in webkit [18970] by bdash
  • 3 edits in trunk/WebKitSite

2007-01-19 Nicholas Shanks <​contact@nickshanks.com>

Reviewed by Maciej.

Change doctype for webkit.org/blog/ admin interface to HTML 4.01.

  • blog/wp-admin/admin-header.php:
  • blog/wp-login.php:
5:14 PM Changeset in webkit [18969] by bdash
  • 3 edits
    3 adds in trunk

2007-01-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: http/tests/misc/css-accept-any-type.html

  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): Changed the accept header for stylesheets to "text/css,*/*;q=0.1" to match Firefox, accepting CSS served as any type.

2007-01-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • http/tests/misc/css-accept-any-type-expected.txt: Added.
  • http/tests/misc/css-accept-any-type.html: Added.
  • http/tests/misc/resources/stylesheet.php: Added.
5:11 PM Changeset in webkit [18968] by bdash
  • 3 edits
    4 adds in trunk

2007-01-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: editing/selection/display-table-text.html

  • editing/htmlediting.cpp: (WebCore::isTableElement): Changed to return false for text nodes.

2007-01-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • editing/selection/display-table-text-expected.checksum: Added.
  • editing/selection/display-table-text-expected.png: Added.
  • editing/selection/display-table-text-expected.txt: Added.
  • editing/selection/display-table-text.html: Added.
5:10 PM Changeset in webkit [18967] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Adele

<rdar://problem/4917290> -
Null deref in WebFrameLoaderClient::restoreScrollPositionAndViewState()
after regaining network connection

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::restoreScrollPositionAndViewState): Bail early with a null currentItem, preventing a crash in release builds. Leave the ASSERT to help find other cases where this might happen in debug builds.
5:08 PM Changeset in webkit [18966] by bdash
  • 12 edits
    6 moves in trunk/WebCore

2007-01-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

This patch takes character-to-glyph mapping out of FontData and instead makes
each Font keep its own mapping, using a shared set of glyph page fallback trees.

For each page number there is (at most) one tree. A path from the root to a
node in the tree corresponds to a fallback list of FontDatas. The node points to
a page (which may be shared with other nodes) that maps each character in its range
to a glyph in the first FontData in the fallback list that has it, or to 0 if none of
the FontDatas has a glyph for that character. A special kind of node, that can
only occur as a leaf, corresponds to using system fallback fonts after the list
has been exhausted. This prevents system fallback from polluting non-leaf
nodes.

Nodes and pages are initialized lazily and employ "copy on write".

  • CMakeLists.txt:
  • WebCore.pro:
  • WebCore.vcproj/WebCore/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • platform/Font.cpp: (WebCore::WidthIterator::WidthIterator): Removed substituteFontData. (WebCore::WidthIterator::advance): Moved all character-to-glyph mapping logic out of here and replaced it with a call to Font::glyphDataForCharacter(). (WebCore::Font::Font): (WebCore::Font::operator=): (WebCore::Font::glyphDataForCharacter): Added. This method performs the lookup in the page fallback trees, triggering lazy initialization as needed, and caching pointers to the retrieved page tree nodes in the font. (WebCore::Font::update): (WebCore::Font::drawSimpleText): (WebCore::Font::floatWidth): (WebCore::Font::floatWidthForSimpleText): Removed substituteFont argument. (WebCore::Font::offsetForPositionForSimpleText):
  • platform/Font.h:
  • platform/FontData.cpp: (WebCore::FontData::FontData):
  • platform/FontData.h: (WebCore::FontData::missingGlyphData): Added. Returns the "missing glyph" GlyphData for this FontData.
  • platform/GlyphMap.cpp: Removed.
  • platform/GlyphMap.h: Removed.
  • platform/GlyphPageTreeNode.cpp: Renamed GlyphMap.cpp to this. (WebCore::GlyphPageTreeNode::getRoot): Added. Returns the root of the page fallback tree for the given page number. (WebCore::GlyphPageTreeNode::initializePage): Added. Helper method that initializes the page pointer of a node, possibly to a pointer to another node's page or to 0. (WebCore::GlyphPageTreeNode::getChild): Added.
  • platform/GlyphPageTreeNode.h: Renamed GlyphMap.h to this. (WebCore::GlyphPage::glyphDataForCharacter): (WebCore::GlyphPage::setGlyphDataForCharacter): (WebCore::GlyphPage::setGlyphDataForIndex): (WebCore::GlyphPageTreeNode::GlyphPageTreeNode): (WebCore::GlyphPageTreeNode::getRootChild): (WebCore::GlyphPageTreeNode::parent): (WebCore::GlyphPageTreeNode::page): (WebCore::GlyphPageTreeNode::level): (WebCore::GlyphPageTreeNode::isSystemFallback): Added. Returns whether the node corresponds to the system providing fallback fonts, which is done on a character-by-character basis.
  • platform/gdk/GlyphMapGdk.cpp: Removed.
  • platform/gdk/GlyphPageTreeNodeGdk.cpp: Renamed GlyphMapGdk.cpp to this. (WebCore::GlyphPage::fill):
  • platform/mac/FontDataMac.mm: (WebCore::FontData::platformInit):
  • platform/mac/FontMac.mm: (WebCore::Font::Font):
  • platform/mac/GlyphMapMac.cpp: Removed.
  • platform/mac/GlyphPageTreeNodeMac.cpp: Renamed GlypMapMac.cpp to this. (WebCore::GlyphPage::fill): Changed to return false if the font has no glyphs in the page.
  • platform/qt/GlyphMapQt.cpp: Removed.
  • platform/qt/GlyphPageTreeNodeQt.cpp: Renamed GlyphMapQt.cpp to this. (WebCore::GlyphPage::fill):
  • platform/win/GlyphMapWin.cpp: Removed.
  • platform/win/GlyphPageTreeNodeWin.cpp: Renamed GlyphMapWin to this. (WebCore::GlyphPage::fill):
5:03 PM Changeset in webkit [18965] by bdash
  • 2 edits in trunk/WebCore

2007-01-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • page/FrameView.cpp: (WebCore::FrameView::~FrameView): Removed the call to Document::detach(). If this view is the current view, then the Frame should have already detached the document. Added an assertion that this is the case. If this view is not the current view, then it cannot access its document, but the page cache should have detached it already. Similarly, changed to call RenderPart::setWidget() only if this is the current view in the frame. (WebCore::FrameView::adjustViewSize): Added an assertion that this view is the current view in the frame. (WebCore::FrameView::layout): Ditto. (WebCore::FrameView::scheduleRelayout): Ditto. (WebCore::FrameView::scheduleRelayoutOfSubtree): Ditto. (WebCore::FrameView::windowClipRect): Ditto.
5:00 PM Changeset in webkit [18964] by eseidel
  • 2 edits in trunk/WebCore

2007-01-18 Eric Seidel <​eric@webkit.org>

Reviewed by bdash.

No test needed, removed bogus debug-only ASSERT.

  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::paint):
5:00 PM Changeset in webkit [18963] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-01-18 Sanjay Madhav <​sanjay12@gmail.com>

Reviewed by Darin.

Add JavaScriptCore define to help with tracing of when objects are marked.

  • kjs/object.cpp: (KJS::JSObject::mark):
4:54 PM Changeset in webkit [18962] by aliceli1
  • 2 edits in trunk/WebCore

Build Fix

  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeSelection):
4:14 PM Changeset in webkit [22788] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

4:04 PM Changeset in webkit [18961] by sfalken
  • 1 copy in tags/Safari-521.32.13b

New tag.

4:01 PM Changeset in webkit [18960] by aliceli1
  • 4 edits in trunk/WebCore

Reviewed by Mark Rowe.

Fixes the leaks from my last patch, except for the first change below which is a missing delegate call for Mail purposes

  • editing/Editor.cpp: (WebCore::Editor::cut):
  • platform/Pasteboard.h:
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::clear): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):
3:27 PM Changeset in webkit [22787] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.

  • WebView.cpp: (WebView::scrollBackingStore): Only try to scroll the backing store if it actually exists.
2:37 PM Changeset in webkit [18959] by brmorris
  • 3 edits in S60/branches/3.1m/WebKit

2007-01-18 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Phone doesn't recognises http link to a ram file (fix on 3.1m) AKKO-6X4B3D


​http://bugs.webkit.org/show_bug.cgi?id=12316

2:30 PM Changeset in webkit [18958] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

2007-01-17 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: [S60] TSW ID: PNIO-6X4H9N: S60 A3.1 wk50_004: www.lookcyclesusa.com crashes browser
​http://bugs.webkit.org/show_bug.cgi?id=12304

  • khtml/rendering/render_box.cpp: (RenderBox::paintBoxDecorations):
2:20 PM Changeset in webkit [18957] by kdecker
  • 2 edits in trunk/WebKit

Reviewed by John.

<rdar://problem/4939511> WebKit should set the CG clip path for plug-ins that draw using CoreGraphics

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView drawRect:]): Set the CG clip path to the plug-in dirty rect. This allows plug-ins to obtain their dirty rect using functions like CGContextGetClipBoundingBox().
2:07 PM Changeset in webkit [22786] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Brady.

Fix ownership handling of CFRequestRef. A ResourceRequest holds on to its CFRequestRef
and doesn't ref it when returning it. Also, implement willCacheResponse.


  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::willCacheResponse): (WebCore::ResourceHandle::start):
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest):
2:03 PM Changeset in webkit [18956] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

2007-01-18 brmorris

3.0 S60 sdk build fix: avkon.loc not visible on sdk,
flag out its inclusion in Webkit.rss

1:38 PM Changeset in webkit [18955] by sullivan
  • 1 edit in trunk/LayoutTests/ChangeLog

Removed accidentally-duplicated entries.

1:33 PM Changeset in webkit [18954] by brmorris
  • 3 edits in S60

spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Phone doesn't recognises http link to a ram file


​http://bugs.webkit.org/show_bug.cgi?id=12316

1:33 PM Changeset in webkit [18953] by sullivan
  • 1 edit
    9 adds in trunk/LayoutTests

Reviewed by Darin


  • Tests for: <rdar://problem/4912002> REGRESSION: Series of words marked as a single misspelled word <rdar://problem/4462420> REGRESSION: Mail hangs during Replace All if the replacement string contains the search string
  • editing/spelling/spelling-expected.checksum: Added.
  • editing/spelling/spelling-expected.png: Added.
  • editing/spelling/spelling-expected.txt: Added.
  • editing/spelling/spelling.html: Added.
  • editing/execCommand/find-after-replace-expected.checksum: Added.
  • editing/execCommand/find-after-replace-expected.png: Added.
  • editing/execCommand/find-after-replace-expected.txt: Added.
  • editing/execCommand/find-after-replace.html: Added.
1:25 PM Changeset in webkit [18952] by brmorris
  • 2 edits in S60

2007-01-17 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: [S60] TSW ID: PNIO-6X4H9N: S60 A3.1 wk50_004: www.lookcyclesusa.com crashes browser
​http://bugs.webkit.org/show_bug.cgi?id=12304

  • khtml/rendering/render_box.cpp: (RenderBox::paintBoxDecorations):
1:14 PM Changeset in webkit [18951] by hyatt
  • 3 edits in trunk/WebCore

Make sure layer autoscrolling puts the event coordinates into the layer's coordinate space before
calling hitTest on it. Fixes "flashy" selection in textareas.

Reviewed by darin

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll):
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::nodeAtPoint):
1:09 PM Changeset in webkit [18950] by andersca
  • 6 edits
    1 delete in trunk/WebCore

Reviewed by Adam.

Get rid of ResourceLoaderMac.mm and make willCacheResponse platform-independent.


  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::willCacheResponse):
  • loader/ResourceLoader.h:
  • loader/mac/ResourceLoaderMac.mm: Removed.
  • platform/network/ResourceHandleClient.h: (WebCore::): (WebCore::ResourceHandleClient::willCacheResponse): (WebCore::ResourceHandleClient::willStopBufferingData):
  • platform/network/mac/ResourceHandleMac.mm: (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
1:01 PM Changeset in webkit [18949] by brmorris
  • 2 edits in S60/trunk/WebCore

2007-01-17 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC: [S60] TSW ID: PNIO-6X4H9N: S60 A3.1 wk50_004: www.lookcyclesusa.com crashes browser
​http://bugs.webkit.org/show_bug.cgi?id=12304

  • khtml/rendering/render_box.cpp: (RenderBox::paintBoxDecorations):
12:48 PM Changeset in webkit [22785] by andersca
  • 1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

Improve wording.

12:44 PM Changeset in webkit [18948] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by John Sullivan.

  • Scripts/run-webkit-tests: Fix handling of configuration so it does the right thing when no explicit configuration is passed in. The old code assumed that the result of setConfiguration() was the configuration, but it's undefined when no configuration is explicitly passed in. The correct function to use is configuration(), and I also streamlined the code.
12:13 PM Changeset in webkit [18947] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

2007-01-18 brmorris <​bradley.morrison@nokia.com>

Reviewed by Sachin.
DESC: Explicitly include avkon.loc in webkit.rss (AHUN-6X6PW3)

  • data/Webkit.rss:
12:11 PM Changeset in webkit [18946] by yongjzha
  • 2 edits in S60/branches/3.1m/WebCore

Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog (revision 18870)
+++ WebCore/ChangeLog (working copy)
@@ -1,3 +1,15 @@
+2007-01-15 raalexan <​rasvan.alexandrescu@nokia.com>
+
+ Reviewed by Yongjun Zhang.
+ DESC: Crashes in web pages with rss feeds like www.google.com/ig
+ ​http://bugs.webkit.org/show_bug.cgi?id=12289
+
+ WARNING: NO TEST CASES ADDED OR CHANGED
+
+ * khtml/xml/xml_tokenizer.cpp:
+ (khtml::createQStringParser):
+ (khtml::parseQString):

11:57 AM Changeset in webkit [22784] by andersca
  • 7 edits
    2 adds in branches/WindowsMerge/WebKitWin

Reviewed by Lou and Adam.

Dispatch all the right delegate methods.


  • Interfaces/IWebPolicyDelegate.idl: Add some definitions needed.


  • WebActionPropertyBag.cpp: Added. (WebActionPropertyBag::WebActionPropertyBag): (WebActionPropertyBag::~WebActionPropertyBag): (WebActionPropertyBag::createInstance): (WebActionPropertyBag::QueryInterface): (WebActionPropertyBag::AddRef): (WebActionPropertyBag::Release): (isEqual): (findMouseEvent): (WebActionPropertyBag::Read): (WebActionPropertyBag::Write):
  • WebActionPropertyBag.h: Added. New class which wraps a NavigationAction in a property bag.


  • WebFrame.cpp: (WebFrame::dispatchWillSubmitForm): (WebFrame::clearUnarchivingState): (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchDecidePolicyForNavigationAction): (WebFrame::dispatchWillSendRequest): (WebFrame::dispatchDidFailLoading):
  • WebFrame.h: Dispatch correct delegate methods.


  • WebKit.vcproj/WebKit.vcproj: Add WebActionPropertyBag files.


  • WebURLResponse.cpp: (WebURLResponse::createInstance): Return 0 for null responses.
11:54 AM Changeset in webkit [18945] by brmorris
  • 2 edits in S60/trunk/WebKit

2007-01-18 brmorris <​bradley.morrison@nokia.com>

Reviewed by Sachin.
DESC: Explicitly include avkon.loc in webkit.rss

  • data/Webkit.rss:
11:13 AM Changeset in webkit [18944] by mjs
  • 4 edits
    1 add in trunk/WebCore

Reviewed by John.


  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Don't insert extra paragraph separators to avoid nesting blocks in plaintext mode, since that's not an issue under normal circumstances.
  • html/HTMLInputElement.h:
  • manual-tests/drag-move-in-search-field.html: Added.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::subtreeHasChanged): constrain the value; we'd rather truncate it than end up with an illegal value here.
10:47 AM Changeset in webkit [18943] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-01-17 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Secure icon shown in www.blogger.com and stays on afterwards
​http://bugs.webkit.org/show_bug.cgi?id=12303

  • ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::HeadersL):
10:43 AM Changeset in webkit [18942] by spadma
  • 2 edits in S60/trunk/WebKit

2007-01-17 spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Secure icon shown in www.blogger.com and stays on afterwards
​http://bugs.webkit.org/show_bug.cgi?id=12303

  • ResourceLoader/src/HttpLoader.cpp: (CHttpLoader::HeadersL):
9:23 AM Changeset in webkit [22783] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by John Sullivan

  • WebView.cpp: (WebView::searchFor): Build fix.
9:07 AM Changeset in webkit [18941] by hausmann
  • 2 edits in trunk/WebCore

parallel build fix

8:39 AM Changeset in webkit [18940] by darin
  • 6 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin and Mitz.

  • fast/dom/HTMLImageElement/image-lowsrc-getset-expected.txt: Added.
  • fast/dom/HTMLImageElement/image-lowsrc-getset.html: Added.

WebCore:

Reviewed by Darin and Mitz.

<rdar://problem/4931480> REGRESSION: Images do not load in video sections on CNN.com homepage (12305)

Test: fast/dom/HTMLImageElement/image-lowsrc-getset.html

  • html/HTMLAttributeNames.in: Added lowsrc.
  • html/HTMLImageElement.cpp: (WebCore::HTMLImageElement::isURLAttribute): Added lowsrc. (WebCore::HTMLImageElement::lowsrc): Added. (WebCore::HTMLImageElement::setLowsrc): Added.
  • html/HTMLImageElement.h: Added lowsrc and setLowsrc.
  • html/HTMLImageElement.idl: Added lowsrc.
8:32 AM Changeset in webkit [18939] by yongjzha
  • 3 edits in S60/trunk/WebCore

2007-01-14 sareen <​shyam.sareen@nokia.com>

Reviewed by Antti Kovisto.Browser
DESC: Browser - Form/The TC is not displayed, it's a white page displayed
​http://bugzilla.opendarwin.org/show_bug.cgi?id=12269

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::parseTag):
  • khtml/html/htmltokenizer.h:
8:16 AM Changeset in webkit [18938] by yongjzha
  • 3 edits in S60/branches/3.1m/WebCore

Index: WebCore/ChangeLog
===================================================================
--- WebCore/ChangeLog (revision 18858)
+++ WebCore/ChangeLog (working copy)
@@ -1,3 +1,15 @@
+2007-01-15 sareen <​shyam.sareen@nokia.com>
+
+ Reviewed by Antti Kovisto.Browser
+ DESC: Browser - Form/The TC is not displayed, it's a white page displayed
+ ​http://bugzilla.opendarwin.org/show_bug.cgi?id=12269
+
+ WARNING: NO TEST CASES ADDED OR CHANGED
+
+ * khtml/html/htmltokenizer.cpp:
+ (khtml::HTMLTokenizer::parseTag):
+ * khtml/html/htmltokenizer.h:

8:12 AM Changeset in webkit [18937] by yongjzha
  • 3 edits in S60/branches/3.1m/WebCore

2007-01-17 w3liu <​wei.liu@nokia.com>

Reviewed by Yongjun Zhang <​yongjun.zhang@nokia.com>
DESC: [S60] TSW ID: AIYR-6W29Z7, Browser crashes when entered Hindi character in textbox as Search character in Search engine site.
​http://bugs.webkit.org/show_bug.cgi?id=12306

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/khtml_part.cpp: (KHTMLPart::encoding):
  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode): (KWQTextDecoder::checkRealloc):
8:03 AM Changeset in webkit [18936] by yongjzha
  • 2 edits in S60/trunk/WebCore

2007-01-18 sareen <​shyam.sareen@yahoo.com>

Reviewed by Yongjun.
DESC: Wrong rendering of danish national characters for UTF8 coded web pages.(TSW ID: TMCN-6UQNXY)

Additional fix.

​http://bugs.webkit.org/show_bug.cgi?id=12217

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQTextCodec.cpp: (validateUtf8):
7:59 AM Changeset in webkit [18935] by yongjzha
  • 3 edits in S60/trunk/WebCore

2007-01-17 w3liu <​wei.liu@nokia.com>

Reviewed by ​yongjun.zhang@nokia.com.
DESC:
​http://bugs.webkit.org/show_bug.cgi?id=12306

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/khtml_part.cpp: (KHTMLPart::encoding):
  • kwq/KWQTextCodec.cpp: (KWQTextDecoder::fromUnicode): (KWQTextDecoder::checkRealloc):
6:33 AM Changeset in webkit [18934] by yongjzha
  • 2 edits in S60/trunk/WebCore

2007-01-15 raalexan <​rasvan.alexandrescu@nokia.com>

Reviewed by Yongjun Zhang.
DESC: Crashes in web pages with rss feeds like www.google.com/ig
​http://bugs.webkit.org/show_bug.cgi?id=12289

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/xml/xml_tokenizer.cpp: (khtml::createQStringParser): (khtml::parseQString):
5:00 AM Changeset in webkit [18933] by hausmann
  • 5 edits in trunk

fix make clean in the qt build to remove all generated files

2:04 AM Changeset in webkit [18932] by zack
  • 8 edits in trunk/WebKitQt

Implementing some load progress tracking in the Qt port.
Reviewed by Lars.

Jan 17, 2007:

11:57 PM Changeset in webkit [22782] by aliceli1
  • 3 edits in branches/WindowsMerge/WebKitWin

Added stubs to keep the boomer build from failing.

  • WebEditorClient.cpp: (WebEditorClient::didSetSelectionTypesForPasteboard):
  • WebEditorClient.h:
11:47 PM Changeset in webkit [18931] by aliceli1
  • 14 edits in trunk

WebCore:

Reviewed by Harrison.

Fix for <rdar://problem/4894155> REGRESSION: Extra line break is pasted with content into message body after choosing File - Paste

Migration of some editing code from WebHTMView to WebCore::Editor
resulted in not calling pasteboardTypesForSelection, which Mail was
overriding for the special purpose of adding a type to the
pasteboard after WebKit did. This patch adds 2 separate code paths
for Tiger and Leopard. On Tiger we give in and call the WebView's
pasteboardTypesForSelection. On Leopard we call a delegate after
the pasteboard types are set.

  • bridge/EditorClient.h:
  • editing/Editor.h:
  • platform/Pasteboard.h:
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::didSetSelectionTypesForPasteboard): (WebCore::SVGEmptyEditorClient::pasteboardTypesForSelection):
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::Pasteboard): (WebCore::Pasteboard::clear): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):

WebKit:

Reviewed by Harrison.

Fix for <rdar://problem/4894155> REGRESSION: Extra line break is pasted with content into message body after choosing File - Paste

Migration of some editing code from WebHTMView to WebCore::Editor
resulted in not calling pasteboardTypesForSelection, which Mail was
overriding for the special purpose of adding a type to the
pasteboard after WebKit did. This patch adds 2 separate code paths
for Tiger and Leopard. On Tiger we give in and call the WebView's
pasteboardTypesForSelection. On Leopard we call a delegate after
the pasteboard types are set.

  • DefaultDelegates/WebDefaultEditingDelegate.m: (-[WebDefaultEditingDelegate webView:didSetSelectionTypesForPasteboard:]):
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::didSetSelectionTypesForPasteboard): (WebEditorClient::pasteboardTypesForSelection):
  • WebView/WebEditingDelegate.h:

WebKitQt:

Added these stubs to keep the Qt build from failing.

  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::didSetSelectionTypesForPasteboard):
  • WebCoreSupport/EditorClientQt.h:
10:05 PM Changeset in webkit [18930] by bdash
  • 1 copy in tags/Safari-419

New tag.

9:50 PM Changeset in webkit [18929] by bdash
  • 6 edits in branches/Safari-2-0-branch

Adjust installation paths.

8:32 PM Changeset in webkit [18928] by sullivan
  • 15 edits in trunk

WebCore:

Reviewed by Darin

  • WebCore part of fix for <rdar://problem/4462420> REGRESSION: Mail hangs during Replace All if the replacement string contains the search string


  • page/Frame.h:
  • page/Frame.cpp: (WebCore::Frame::findString): new startInSelection parameter -- if true, search starts looking in selection; if false, search starts looking after the selection


  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge searchFor:direction:caseSensitive:wrap:startInSelection:]): new startInSelection parameter, passed through to Frame::findString()
  • editing/JSEditor.cpp: pass false for new findString parameter, to match old behavior

WebKit:

Reviewed by Darin

  • WebKit part of fix for <rdar://problem/4462420> REGRESSION: Mail hangs during Replace All if the replacement string contains the search string
  • Misc/WebKitVersionChecks.h: Added extern "C" so this can be used from .mm files. I don't need this change anymore for this fix, but it's still worth fixing now so it doesn't bite anyone later.
  • WebView/WebDocumentPrivate.h: Invented new private protocol WebDocumentIncrementalSearching, that has one method. The one method is just like the one WebDocumentSearching method, but with an additional parameter. We hope to eliminate this dependence on protocols someday, but adding another one as SPI seems like it won't make anything worse.


  • WebView/WebHTMLView.mm: (-[WebHTMLView searchFor:direction:caseSensitive:wrap:]): now calls through to new method that has one additional parameter, passing NO to match old behavior (-[WebHTMLView searchFor:direction:caseSensitive:wrap:startInSelection:]): pass new parameter to bridge


  • WebView/WebPDFView.h: Declare conformance to WebDocumentIncrementalSearching protocol


  • WebView/WebPDFView.mm: (-[WebPDFView searchFor:direction:caseSensitive:wrap:]): now calls through to new method that has one additional parameter, passing NO to match old behavior (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]): new method, former guts of searchFor:direction:caseSensitive:wrap: but now handles startInSelection parameter


  • WebView/WebViewPrivate.h: Declare new searchFor:direction:caseSensitive:wrap:startInSelection: method, just like existing method but with one additional parameter
  • WebView/WebView.mm: (-[WebView searchFor:direction:caseSensitive:wrap:]): now calls through to new method that has one additional parameter, passing NO to match old behavior (-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]): new method, former guts of searchFor:direction:caseSensitive:wrap: but now handles startInSelection parameter
8:00 PM Changeset in webkit [18927] by beidson
  • 1 edit in trunk/WebKit/Misc/WebDownload.m

Removed an internal change I had I wasn't supposed to commit. *sigh*

7:58 PM Changeset in webkit [18926] by beidson
  • 2 edits in trunk/WebKit

Reviewed by Deth Bakin and Brian Dash

Drop Panther Support (?!?) and change the comment explaining some SPI forward decls

  • Misc/WebDownload.m:
6:32 PM Changeset in webkit [18925] by bdakin
  • 2 edits in trunk/WebCore

Adding comment.

6:30 PM Changeset in webkit [18924] by justing
  • 3 edits
    6 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/4920488>
REGRESSION: A crash occurs at WebCore::Range::processContents () when removing formatting from selected text (that contains a link)

  • editing/execCommand/4920488-expected.checksum: Added.
  • editing/execCommand/4920488-expected.png: Added.
  • editing/execCommand/4920488-expected.txt: Added.
  • editing/execCommand/4920488.html: Added.
  • fast/dom/Range/compareBoundaryPoints-1-expected.txt: Added.
  • fast/dom/Range/compareBoundaryPoints-1.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/4920488>
REGRESSION: A crash occurs at WebCore::Range::processContents () when removing formatting from selected text (that contains a link)

  • dom/Range.cpp: (WebCore::Range::commonAncestorContainer): Return null if the nodes don't have a common ancestor. As a side effect, the public commonAncestorContainer now sets an exception if the Range starts in one document and ends in another, or starts or ends in a tree that's been removed from the document. The spec doesn't cover this and there is no precedent in other browsers for this case because they don't allow invalid Ranges (you can create one with WebCore by removing a node that contains the start/end of a Range). (WebCore::Range::compareBoundaryPoints): If the the two positions are in nodes that have no common ancestor, return null. This doesn't change the behavior of the public compareBoundaryPoints: it already throws an exception if the two positions are in nodes that don't have a common ancestor. This follows the spec.
5:49 PM Changeset in webkit [18923] by sullivan
  • 2 edits in trunk/WebCore

The one word was typed by me, but only after debugging for a long time with Darin.

  • fixed <rdar://problem/4912002> REGRESSION: Series of words marked as a single misspelled word
  • editing/TextIterator.cpp: (WebCore::WordAwareIterator::WordAwareIterator): We were creating a TextIterator with the default kind, but WordAwareIterator is designed to work in concert with CharacterIterator, so they need to use the same kind. CharacterIterator uses kind RUNFINDER, so WordAwareIterator needs to do so also.
5:09 PM Changeset in webkit [18922] by adele
  • 2 edits in trunk/WebCore

Reviewed by Brady.

Fix for <rdar://problem/4900895> REGRESSION: onChange doesn't always fire for popups that have had value changed by JS

No test case since you need to open up the menu to fire onChange.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::setSelectedIndex): Keep track of m_lastOnChangeIndex even when we're not firing onChange. Since the selected index has changed, we still want the m_lastOnChangeIndex to be up to date when we compare it later. This matches our behavior in Safari 2.0.
4:15 PM Changeset in webkit [18921] by adele
  • 2 edits in trunk/WebCore

Reviewed by Darin and John.

  • Fix for <rdar://problem/4816550> REGRESSION: autoscrolling doesn't work after double-click
  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): Set swallowEvent bool instead of returning early for double and triple clicks.
3:31 PM Changeset in webkit [22781] by beidson
  • 9 edits in branches/WindowsMerge

Final hookup of HTTP Auth (from the engine perspective)

3:17 PM Changeset in webkit [18920] by eseidel
  • 4 edits in trunk/LayoutTests

2007-01-17 Eric Seidel <​eric@webkit.org>

Reviewed by Brady.


Update results after SVG container hit testing changes.

  • svg/custom/pointer-events-text-expected.checksum:
  • svg/custom/pointer-events-text-expected.png:
  • svg/custom/pointer-events-text-expected.txt:
3:13 PM Changeset in webkit [18919] by darin
  • 3 edits in trunk/WebCore

Reviewed by Hyatt.

  • rendering/RenderObject.h: Removed unused nextEditable and previousEditable.
  • rendering/RenderObject.cpp: Ditto.
2:50 PM Changeset in webkit [18918] by darin
  • 15 edits in trunk

WebCore:

Reviewed by Maciej.

  • WebCore.exp: Added HitTestResult::imageRect, removed HitTestResult::boundingBox.
  • rendering/HitTestResult.h:
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::imageRect): Added. Returns the content rectangle of the image.
  • rendering/RenderObject.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::absolutePosition): Made const. (WebCore::RenderObject::contentBox): Added. (WebCore::RenderObject::absoluteContentBox): Added.
  • rendering/RenderBox.h:
  • rendering/RenderBox.cpp: (WebCore::RenderBox::absolutePosition): Made const.
  • rendering/RenderTableCell.h:
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::absolutePosition): Made const.
  • rendering/RenderView.h:
  • rendering/RenderView.cpp: (WebCore::RenderView::absolutePosition): Made const.

WebKit:

Reviewed by Maciej.

  • Misc/WebElementDictionary.mm: (-[WebElementDictionary _imageRect]): Call HitTestResult::imageRect, not HitTestResult::boundingBox.
2:15 PM Changeset in webkit [18917] by lars
  • 2 edits in trunk/WebKitTools

Fix my last commit to actually work in all cases.

2:05 PM Changeset in webkit [18916] by adele
  • 2 edits in trunk/LayoutTests

Reviewed by Mitz.

Updating this new layout test so that it actually crashes before the last fix.

  • fast/css/pseudostyle-anonymous-text.html:
1:50 PM Changeset in webkit [18915] by adele
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Beth.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=10139
<rdar://problem/4823028> REGRESSION: Reproducible crash when selecting a popup/button with ::selection pseudostyle

  • fast/css/pseudostyle-anonymous-text-expected.txt: Added.
  • fast/css/pseudostyle-anonymous-text.html: Added.

WebCore:

Reviewed by Beth.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=10139
<rdar://problem/4823028> REGRESSION: Reproducible crash when selecting a popup/button with ::selection pseudostyle

Test: fast/css/pseudostyle-anonymous-text.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::getPseudoStyle): Nil check the node.
1:19 PM Changeset in webkit [18914] by lars
  • 2 edits in trunk/WebKitTools

Reviewed by Maciej

Make sure DumpRenderTree exits when run-webkit-tests
is done.

1:01 PM Changeset in webkit [18913] by adele
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Anders and John.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=11278
<rdar://problem/4826875> REGRESSION: Popup width doesn't change to accommodate dynamic changes to options

  • fast/forms/menulist-width-change-expected.checksum: Added.
  • fast/forms/menulist-width-change-expected.png: Added.
  • fast/forms/menulist-width-change-expected.txt: Added.
  • fast/forms/menulist-width-change.html: Added.

WebCore:

Reviewed by Anders and John.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11278
<rdar://problem/4826875> REGRESSION: Popup width doesn't change to accommodate dynamic changes to options

Test: fast/forms/menulist-width-change.html

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::updateFromElement): When the options change, call setNeedsLayoutAndMinMaxRecalc.
11:34 AM Changeset in webkit [18912] by ap
  • 29 edits in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12268
Give object prototypes their own names

JavaScriptCore:

  • kjs/lookup.h: Append "Prototype" to ClassName in KJS_IMPLEMENT_PROTOTYPE.

WebCore:

  • bindings/scripts/CodeGeneratorJS.pm: Append "Proto" to interface name for the prototype's ClassInfo.
  • bindings/js/JSHTMLInputElementBase.cpp: (WebCore::JSHTMLInputElementBasePrototypeFunction::callAsFunction): (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase):
  • bindings/js/JSHTMLInputElementBase.h:
  • bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp): (KJS::JSXMLHttpRequest::JSXMLHttpRequest): (KJS::JSXMLHttpRequestPrototypeFunction::callAsFunction):
  • bindings/js/JSXMLHttpRequest.h:
  • bindings/js/JSXSLTProcessor.cpp: (KJS::JSXSLTProcessor::JSXSLTProcessor): (KJS::XSLTProcessorPrototypeFunction::callAsFunction): (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp):
  • bindings/js/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::DOMCSSStyleDeclaration): (KJS::DOMCSSStyleDeclarationPrototypeFunction::callAsFunction): (KJS::DOMMediaList::DOMMediaList): (KJS::KJS::DOMMediaListPrototypeFunction::callAsFunction): (KJS::DOMCSSStyleSheet::DOMCSSStyleSheet): (KJS::DOMCSSStyleSheetPrototypeFunction::callAsFunction): (KJS::DOMCSSValue::DOMCSSValue): (KJS::DOMCSSValuePrototypeFunction::callAsFunction):
  • bindings/js/kjs_css.h:
  • bindings/js/kjs_dom.cpp: (KJS::DOMNode::DOMNode): (KJS::DOMNodePrototypeFunction::callAsFunction): (KJS::DOMEventTargetNode::DOMEventTargetNode): (KJS::DOMEventTargetNodePrototypeFunction::callAsFunction): (KJS::DOMNamedNodeMap::DOMNamedNodeMap): (KJS::DOMNamedNodeMapPrototypeFunction::callAsFunction):
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_domnode.h:
  • bindings/js/kjs_events.cpp: (KJS::DOMEvent::DOMEvent): (KJS::DOMEventPrototypeFunction::callAsFunction): (KJS::Clipboard::Clipboard): (KJS::ClipboardPrototypeFunction::callAsFunction):
  • bindings/js/kjs_events.h:
  • bindings/js/kjs_html.cpp: (KJS::JSHTMLDocumentPrototypeFunction::callAsFunction): (KJS::): (KJS::JSHTMLDocument::JSHTMLDocument): (KJS::JSHTMLElementPrototypeFunction::callAsFunction): (KJS::JSHTMLElement::JSHTMLElement): (KJS::JSHTMLCollection::JSHTMLCollection): (KJS::JSHTMLCollectionPrototypeFunction::callAsFunction):
  • bindings/js/kjs_html.h:
  • bindings/js/kjs_navigator.cpp:
  • bindings/js/kjs_traversal.cpp: (KJS::DOMNodeFilter::DOMNodeFilter): (KJS::DOMNodeFilterPrototypeFunction::callAsFunction):
  • bindings/js/kjs_window.cpp: (KJS::Window::clear): Changed Proto to Prototype, and ProtoFunc to PrototypeFunction.

LayoutTests:

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-chain-expected.txt:
  • fast/events/event-view-toString-expected.txt:
  • fast/events/mouseclick-target-and-positioning-expected.txt:
  • fast/tokenizer/external-script-document-write-expected.checksum:
  • fast/tokenizer/external-script-document-write-expected.png:
  • fast/tokenizer/external-script-document-write-expected.txt: Updated the results.
11:04 AM Changeset in webkit [18911] by lars
  • 7 edits in trunk/WebCore

Reviewed by Zack and Darin

Fix the Qt build again after the latest Image changes.
Also make some of the methods implemented in ImageCG
crossplatform.

11:02 AM Changeset in webkit [22780] by beidson
  • 15 edits
    8 adds in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Steve Falkenburg

Next round of plumbing for HTTP Auth, or as I like to call it:
"Implementing platform dependent wrappers for my platform independent

wrappers which wrap platform dependent objects"


*sigh*


Also, not included in this ChangeLog, I changed the eol property to
native on a handful of WebKitWin files who didn't have it set yet


  • Interfaces/IWebURLAuthenticationChallenge.idl: Added some string constants, nuked an unneeded initializer from IWebCredential


  • WebError.cpp: Added QueryInterface for new GUID (WebError::resourceError): Added accessor to WebCore backer
  • WebError.h: Added GUID


  • WebKit.vcproj/WebKit.vcproj:


  • WebURLAuthenticationChallenge.cpp: Added. (WebURLAuthenticationChallenge::WebURLAuthenticationChallenge): (WebURLAuthenticationChallenge::~WebURLAuthenticationChallenge): (WebURLAuthenticationChallenge::createInstance): (WebURLAuthenticationChallenge::QueryInterface): (WebURLAuthenticationChallenge::AddRef): (WebURLAuthenticationChallenge::Release): (WebURLAuthenticationChallenge::initWithProtectionSpace): (WebURLAuthenticationChallenge::initWithAuthenticationChallenge): (WebURLAuthenticationChallenge::error): (WebURLAuthenticationChallenge::failureResponse): (WebURLAuthenticationChallenge::previousFailureCount): (WebURLAuthenticationChallenge::proposedCredential): (WebURLAuthenticationChallenge::protectionSpace): (WebURLAuthenticationChallenge::sender): (WebURLAuthenticationChallenge::authenticationChallenge):
  • WebURLAuthenticationChallenge.h: Added.


  • WebURLAuthenticationChallengeSender.cpp: Added. (WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender): (WebURLAuthenticationChallengeSender::~WebURLAuthenticationChallengeSender): (WebURLAuthenticationChallengeSender::createInstance): (WebURLAuthenticationChallengeSender::QueryInterface): (WebURLAuthenticationChallengeSender::AddRef): (WebURLAuthenticationChallengeSender::Release): (WebURLAuthenticationChallengeSender::cancelAuthenticationChallenge): (WebURLAuthenticationChallengeSender::continueWithoutCredentialForAuthenticationChallenge): (WebURLAuthenticationChallengeSender::useCredential): (WebURLAuthenticationChallengeSender::resourceHandle):
  • WebURLAuthenticationChallengeSender.h: Added.


  • WebURLCredential.cpp: Added. (WebURLCredential::WebURLCredential): (WebURLCredential::~WebURLCredential): (WebURLCredential::createInstance): (WebURLCredential::QueryInterface): (WebURLCredential::AddRef): (WebURLCredential::Release): (WebURLCredential::hasPassword): (WebURLCredential::initWithuser): (WebURLCredential::password): (WebURLCredential::persistence): (WebURLCredential::user): (WebURLCredential::credential):
  • WebURLCredential.h: Added.


  • WebURLProtectionSpace.cpp: Added. (WebURLProtectionSpace::WebURLProtectionSpace): (WebURLProtectionSpace::~WebURLProtectionSpace): (WebURLProtectionSpace::createInstance): (WebURLProtectionSpace::QueryInterface): (WebURLProtectionSpace::AddRef): (WebURLProtectionSpace::Release): (WebURLProtectionSpace::authenticationMethod): (WebURLProtectionSpace::host): (coreScheme): Helper for the init methods (WebURLProtectionSpace::initWithHost): (WebURLProtectionSpace::initWithProxyHost): (WebURLProtectionSpace::isProxy): (WebURLProtectionSpace::port): (WebURLProtectionSpace::protocol): (WebURLProtectionSpace::proxyType): (WebURLProtectionSpace::realm): (WebURLProtectionSpace::receivesCredentialSecurely): (WebURLProtectionSpace::protectionSpace):
  • WebURLProtectionSpace.h: Added.


  • WebURLResponse.cpp: Added QueryInterface for new GUID (WebURLResponse::resourceResponse): Added accessor to WebCore backer
  • WebURLResponse.h: Added GUID
10:45 AM Changeset in webkit [18910] by andersca
  • 5 edits in trunk/WebKit

Reviewed by John Sullivan.


Move all code in WebNetscapePluginEmbeddedView down to WebBaseNetscapePluginView.


  • Plugins/WebBaseNetscapePluginView.h:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:DOMElement:]): (-[WebBaseNetscapePluginView didStart]): (-[WebBaseNetscapePluginView dataSource]): (-[WebBaseNetscapePluginView dealloc]): (-[WebBaseNetscapePluginView pluginView:receivedResponse:]): (-[WebBaseNetscapePluginView pluginView:receivedData:]): (-[WebBaseNetscapePluginView pluginView:receivedError:]): (-[WebBaseNetscapePluginView pluginViewFinishedLoading:]): (-[WebBaseNetscapePluginView _redeliverStream]):
  • Plugins/WebNetscapePluginEmbeddedView.h:
  • Plugins/WebNetscapePluginEmbeddedView.mm:
9:08 AM Changeset in webkit [18909] by darin
  • 2 edits in trunk/WebCore
  • quick attempt to fix the Qt build
  • platform/graphics/qt/ImageQt.cpp: (WebCore::BitmapImage::drawTiled): Remove obsolete parameters from this stub.
7:27 AM Changeset in webkit [18908] by brmorris
  • 1 copy in S60/branches/s60-RnD-07wk03

New branch for s60/trunk release

6:59 AM Changeset in webkit [18907] by eseidel
  • 3 edits
    4 adds in trunk

2007-01-17 Eric Seidel <​eric@webkit.org>

Reviewed by rwlbuis.

Test: svg/custom/inner-svg-hit-test.svg

  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::nodeAtPoint): never allow containers to be hit.
5:18 AM Changeset in webkit [18906] by lars
  • 17 edits in trunk

Reviewed by Zack

Don't call receivedResponse twice for file: URLs.
Never call back into the ResourceHandleClient once
cancel() has been called on the ResourceHandle.

Remove the inheritance from Shared<XxxClient> in the
client classes.

Answer asynchronously to most of the Policy checking methods
in FrameLoaderClientQt to avoid some crashes in the loader.

Small fixes in DumpRenderTree, so we don't by
accident dump twice for the same test.

Exclude one more test as it currently causes DumpRenderTree to
hang forever.

4:21 AM Changeset in webkit [18905] by eseidel
  • 2 edits in trunk/WebCore

2007-01-17 Eric Seidel <​eric@webkit.org>

No review, build fix only.

  • platform/graphics/cg/ImageCG.cpp: correct drawPatternCombined to drawPattern (WebCore::Image::drawPattern): (WebCore::Image::drawTiled):
4:10 AM Changeset in webkit [18904] by eseidel
  • 13 edits in trunk

2007-01-17 Eric Seidel <​eric@webkit.org>

Reviewed by mitz and rwlbuis.


SVGs do not work as background images:
​http://bugs.webkit.org/show_bug.cgi?id=12096

Tests updated:

  • fast/images/svg-as-background.svg: now passes
  • fast/images/svg-as-tiled-background.svg: now passes
  • platform/graphics/BitmapImage.h: (WebCore::BitmapImage::nativeImageForCurrentFrame): (WebCore::BitmapImage::mayFillWithSolidColor): (WebCore::BitmapImage::solidColor):
  • platform/graphics/Image.h: (WebCore::Image::mayFillWithSolidColor): (WebCore::Image::solidColor): (WebCore::Image::nativeImageForCurrentFrame): (WebCore::Image::startAnimation):
  • platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPatternCallback): (WebCore::Image::drawPatternCombined): (WebCore::caculatePatternScale): (WebCore::Image::drawTiled):
  • platform/graphics/cg/PDFDocumentImage.cpp:
  • platform/graphics/cg/PDFDocumentImage.h:
  • platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::nativeImageForCurrentFrame):
  • platform/graphics/svg/SVGImage.h:
2:11 AM Changeset in webkit [18903] by mjs
  • 2 edits in trunk/WebKit

Reviewed by Eric.


<rdar://problem/4887781> Seed: Repro Safari crash in -[WebHTMLRepresentation receivedData:withDataSource:] (music.aol.com)

  • WebView/WebDataSource.mm: (-[WebDataSource _receivedData:]): Protect self against destruction partway through this method.
1:58 AM Changeset in webkit [18902] by rwlbuis
  • 2 edits in trunk/WebCore

Reviewed by Eric

Add proper condition for rx attribute negative check.

1:14 AM Changeset in webkit [18901] by lars
  • 25 edits
    1 delete in trunk

Add a message handler to DumpRenderTree that will
suppress all debug output coming from qDebug() statements.
Like this we can get rid of all the noise coming
from the notImplemented() macro when running the
layout tests. You can get it back by adding -v to
DumpRenderTree's command line.

Changed run-webkit-tests slightly, so we by default
don't fail anymore when our output differs from what
is generated on the Mac. Added a --strict option, so
that we can still see this cases and fix them one by one.

change all notImplemented() macros to use qDebug
instead of fprintf(stder, ...)

12:13 AM Changeset in webkit [18900] by beidson
  • 3 edits in trunk/WebCore

WebCore:

Reviewed by Oliver

A few enhancements to the HTTP Auth architecture

  • platform/network/ProtectionSpace.cpp: (WebCore::ProtectionSpace::isProxy): (WebCore::ProtectionSpace::receivesCredentialSecurely):
  • platform/network/ProtectionSpace.h:
Note: See TracTimeline for information about the timeline view.