Timeline



Jan 26, 2007:

11:53 PM Changeset in webkit [19184] by aroben
  • 1 edit in trunk/WebCore/ChangeLog

Added forgotten Radar reference.

8:50 PM Changeset in webkit [19183] by ggaren
  • 34 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Maciej Stachowiak.


Fixed <rdar://problem/4608404> WebScriptObject's _rootObject lack
of ownership policy causes crashes (e.g., in Dashcode)


The old model for RootObject ownership was either to (1) leak them or (2) assign
them to a single owner -- the WebCore::Frame -- which would destroy them
when it believed that all of its plug-ins had unloaded.


This model was broken because of (1) and also because plug-ins are not the only
RootObject clients. All Bindings clients are RootObjects clients, including
applications, which outlive any particular WebCore::Frame.


The new model for RootObject ownership is to reference-count them, with a
throw-back to the old model: The WebCore::Frame tracks the RootObjects
it creates, and invalidates them when it believes that all of its plug-ins
have unloaded.


We maintain this throw-back to avoid plug-in leaks, particularly from Java.
Java is completely broken when it comes to releasing JavaScript objects.
Comments in our code allege that Java does not always call finalize when
collecting objects. Moreoever, my own testing reveals that, when Java does
notify JavaScript of a finalize, the data it provides is totally bogus.


This setup is far from ideal, but I don't think we can do better without
completely rewriting the bindings code, and possibly part of the Java
plug-in / VM.


Layout tests pass. No additional leaks reported. WebCore/manual-tests/*liveconnect*
and a few LiveConnect demos on the web also run without a hitch.


const RootObject* => RootObject*, since we need to ref/deref


  • bindings/NP_jsobject.cpp: (jsDeallocate): deref our RootObjects. Also unprotect or JSObject, instead of just relying on the RootObject to do it for us when it's invalidated. (_isSafeScript): Check RootObject validity. (_NPN_CreateScriptObject): ditto (_NPN_Invoke): ditto (_NPN_Evaluate): ditto (_NPN_GetProperty): ditto (_NPN_SetProperty): ditto (_NPN_RemoveProperty): ditto (_NPN_HasProperty): ditto (_NPN_HasMethod): ditto (_NPN_SetException): ditto
  • bindings/runtime_root.cpp: Revived bit-rotted LIAR LIAR LIAR comment.


LOOK: Added support for invalidating RootObjects without deleting them,
which is the main goal of this patch.

Moved protect counting into the RootObject class, to emphasize that
the RootObject protects the JSObject, and unprotects it upon being invalidated.

addNativeReference => RootObject::gcProtect
removeNativeReference => RootObject::gcUnprotect
ProtectCountSet::contains => RootObject::gcIsProtected


I know we'll all be sad to see the word "native" go.


  • bindings/runtime_root.h: Added ref-counting support to RootObject, with all the standard accoutrements.
  • bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant): If we can't find a valid RootObject, return void instead of just leaking.
  • bindings/jni/jni_instance.cpp: (JavaInstance::JavaInstance): Don't take a RootObject in our constructor; be like other Instances and require the caller to call setRootObject. This reduces the number of ownership code paths. (JavaInstance::invokeMethod): Check RootObject for validity.
  • bindings/jni/jni_instance.h: Removed private no-arg constructor. Having an arg constructor accomplishes the same thing.
  • bindings/jni/jni_jsobject.cpp: (JavaJSObject::invoke): No need to call findProtectCountSet, because finalize() checks for RootObject validity. (JavaJSObject::JavaJSObject): check RootObject for validity (JavaJSObject::call): ditto (JavaJSObject::eval): ditto (JavaJSObject::getMember): ditto (JavaJSObject::setMember): ditto (JavaJSObject::removeMember): ditto (JavaJSObject::getSlot): ditto (JavaJSObject::setSlot): ditto (JavaJSObject::toString): ditto (JavaJSObject::finalize): ditto (JavaJSObject::createNative): No need to tell the RootObject to protect the global object, since the RootObject already owns the interpreter.
  • bindings/jni/jni_runtime.cpp: (JavaArray::JavaArray): Removed copy construcutor becaue it was unused. Dead code is dangerous code.
  • bindings/objc/objc_runtime.mm: Added WebUndefined protocol. Previous use of WebScriptObject was bogus, because WebUndefined is not a subclass of WebScriptObject. (convertValueToObjcObject): If we can't find a valid RootObject, return nil instead of just leaking.
  • bindings/objc/objc_utility.mm: (KJS::Bindings::convertValueToObjcValue): If we can't find a valid RootObject, return nil instead of just leaking.

LayoutTests:

Reviewed by Maciej Stachowiak.


Added test for <rdar://problem/4608404> WebScriptObject's _rootObject lack
of ownership policy causes crashes (e.g., in Dashcode)


No test for Java or NPP versions of this bug because there's no reliable way to
make Java and NPP objects outlive their RootObjects (although Java objects
sometimes do).

  • plugins/root-object-premature-delete-crash-expected.txt: Added.
  • plugins/root-object-premature-delete-crash.html: Added.

WebCore:

Reviewed by Maciej Stachowiak.


Fixed <rdar://problem/4608404> WebScriptObject's _executionContext lack
of ownership policy causes crashes (e.g., in Dashcode)

Added RootObject ref-counting goodness.

  • page/mac/FrameMac.h:
  • page/mac/FrameMac.mm: (WebCore::FrameMac::cleanupPluginObjects): Invalidate our RootObjects instead of detroying them. Track _bindingRootObject separately from the rest of our RootObjects, since it has its own variable.
  • page/mac/WebCoreFrameBridge.mm: (createRootObject): Use the Frame's new, more encapsulated function to create a RootObject.
  • bindings/objc/WebScriptObject.mm: Nixed rootObject setters, since they were unused and they complicated reference-counting.

WebKitTools:

Reviewed by Maciej Stachowiak.


Added support for test for <rdar://problem/4608404> WebScriptObject's
_rootObject lack of ownership policy causes crashes (e.g., in Dashcode)


  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController storeWebScriptObject:]): (-[LayoutTestController accessStoredWebScriptObject]): (-[LayoutTestController dealloc]):
8:28 PM Changeset in webkit [19182] by ddkilzer
  • 2 edits in trunk/WebKit

WebKit:

Reviewed by Timothy.

Fixes crash drawing avatar on mail.yahoo.com.

  • Plugins/WebBaseNetscapePluginStream.m: Retain the object since destroyStreamWithError: might release the last reference to it.
8:10 PM Changeset in webkit [22858] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-01-26 Steve Falkenburg <​sfalken@apple.com>

B&I build fix

  • WebKit.vcproj/WebKit.vcproj:
7:51 PM Changeset in webkit [19181] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by Eric.

Release build fix.

  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::calculateValueIndexAndPercentagePast): Added static cast to unsigned when calculating flooredValueIndex.
6:38 PM Changeset in webkit [19180] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

bujtas <​zbujtas@gmail.com>

Rs'd & merged to 3.1 branch by Brad

DESC: HTMLScriptElementImpl gets notified twice about 'insert new script' event. MLIO-6X9HKM


​http://bugs.webkit.org/show_bug.cgi?id=12428

fix: prevents double notification.

6:37 PM Changeset in webkit [19179] by brmorris
  • 2 edits in S60/trunk/WebCore

bujtas <​zbujtas@gmail.com>

Rs'd by Brad.
DESC: HTMLScriptElementImpl gets notified twice about 'insert new script' event. MLIO-6X9HKM


​http://bugs.webkit.org/show_bug.cgi?id=12428

fix: prevents double notification.

6:31 PM Changeset in webkit [19178] by aliceli1
  • 4 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Maciej.


Fix for Repeated string concatenation results in OOM crash
​http://bugs.webkit.org/show_bug.cgi?id=11131

  • kjs/operations.cpp: (KJS::add): Throw exception if string addition result is null
  • kjs/ustring.cpp: (KJS::UString::UString): Don't call memcpy when malloc failed

LayoutTests:

Reviewed by Maciej.


Test for "Repeated string concatenation results in OOM crash"
​http://bugs.webkit.org/show_bug.cgi?id=11131

  • fast/js/resources/string-concatenate-outofmemory.js: Added.
  • fast/js/string-concatenate-outofmemory-expected.txt: Added.
  • fast/js/string-concatenate-outofmemory.html: Added.
6:28 PM Changeset in webkit [19177] by brmorris
  • 8 edits in S60/branches/3.1m

bujtas <​zbujtas@gmail.com>

Rs'd by Brad.
DESC: display fallback content in case of unsupported plugin PKAI-6WGSHS
​http://bugs.webkit.org/show_bug.cgi?id=12426

fix: webkit should return null, if the plugin is not supported.

  • bridge/WebCoreBridge.h:
  • kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::createPart): (KWQKHTMLPart::createSoundstart):
6:21 PM Changeset in webkit [19176] by darin
  • 4 edits in trunk/WebCore
  • checked in slightly newer revision of the patch below
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Grouped all the unimplemented values at the bottom. Fixed the ifdef for CSS_PROPWEBKIT_DASHBOARD_REGION so that it compiles on all platforms.
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue): Removed default case and added type so that the compiler warns about missing properties.
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty): Ditto.
6:13 PM Changeset in webkit [19175] by weinig
  • 12 edits in trunk

LayoutTests:

Reviewed by Beth.

  • updated test results for change to computed style
  • editing/pasteboard/paste-table-002-expected.txt: Updated for change to order of style properties.
  • fast/css/computed-style-expected.txt: Updated for change to order of style properties and to add new ones.

WebCore:

Reviewed by Beth.

Covered by fast/css/computed-style.html

  • css/CSSPropertyNames.in: Sorted the file into two separate sections, one for properties without the -webkit- prefix and another for properties with.
  • css/makeprop: Generate a CSSPropertyID enum instead of a set of #defines. Removed unused CSS_PROP_MIN and CSS_PROP_MAX. Renamed CSS_PROP_TOTAL to numCSSProperties and changed it to a const int instead of #define. Added a declaration of getPropertyName in the header. Changed the return type of getPropertyName to const char* and the parameter type to CSSPropertyID.
  • css/CSSComputedStyleDeclaration.cpp: Sort the lists of properties in an easier to maintain order -- properties without a WebKit prefix first. (WebCore::valueForLength): Changed return value to PassRefPtr. (WebCore::valueForMaxLength): Ditto. (WebCore::valueForBorderStyle): Ditto. (WebCore::valueForTextAlign): Ditto. (WebCore::valueForAppearance): Added. (WebCore::valueForMarginCollapse): Added. (WebCore::valueForShadow): Changed return value to PassRefPtr. (WebCore::getPositionOffsetValue): Ditto. (WebCore::currentColorOrValidColor): Ditto. (WebCore::CSSComputedStyleDeclaration::cssText): Added cast since getPropertyName now takes an enum value. (WebCore::primitiveValueFromLength): Changed return value to PassRefPtr. (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Added cast to CSSPropertyID so that gcc will detect missing enums in the switch statement. Simplified the background-size and border-spacing implementations so they don't have local variables. Added lots of cases to the switch statement for unimplemented properties. Implemented the outline-width, box-sizing, -webkit-appearance, -webkit-rtl-ordering, -webkit-user-drag, and -webkit-user-select properties. (WebCore::CSSComputedStyleDeclaration::item): Added cast since getPropertyName now takes an enum value.
  • css/CSSMutableStyleDeclaration.cpp: Removed declaration of getPropertyName. (WebCore::CSSMutableStyleDeclaration::item): Added cast since getPropertyName now takes an enum value.
  • css/CSSProperty.cpp: Removed declaration of getPropertyName. (WebCore::CSSProperty::cssText): Added cast since getPropertyName now takes an enum value and returns a const char*.
  • css/CSSStyleDeclaration.cpp: Removed declaration of getPropertyName. (WebCore::CSSStyleDeclaration::getPropertyShorthand): Added cast since getPropertyName now takes an enum value and returns a const char*.

WebKit:

Reviewed by Beth.

  • WebInspector/webInspector/inspector.js: Updated for new computed style properties.
6:11 PM Changeset in webkit [19174] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Brady.

Fixed <rdar://problem/4838076> CrashTracer: 10 crashes in Mail at com.apple.WebCore: WTF::HashMap<WebCore::String

  • loader/DocLoader.cpp: (WebCore::DocLoader::requestResource): Added nil check around resource from cache.
6:11 PM Changeset in webkit [22857] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Fix frequent failed assertions when painting scroll bars.

6:05 PM Changeset in webkit [19173] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

Build fix.

  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::calculateValueIndexAndPercentagePast): Keep index variables as unsigned until we need to convert to float.
6:04 PM Changeset in webkit [19172] by aliceli1
  • 7 edits
    4 adds in trunk

LayoutTests:

Reviewed by Ada.

Added tests for <rdar://problem/4919097> REGRESSION: Ctrl-Y fails to yank (11076)

  • editing/pasteboard/emacs-ctrl-a-k-y-expected.checksum: Added.
  • editing/pasteboard/emacs-ctrl-a-k-y-expected.png: Added.
  • editing/pasteboard/emacs-ctrl-a-k-y-expected.txt: Added.
  • editing/pasteboard/emacs-ctrl-a-k-y.html: Added. Test for <rdar://problem/4919097>
  • editing/deleting/delete-by-word-001-expected.txt:
  • editing/deleting/delete-by-word-002-expected.txt:
  • editing/deleting/delete-to-end-of-paragraph-expected.txt:
  • editing/pasteboard/emacs-cntl-y-001-expected.txt: The expected results of these tests were affected by the WebCore checkin of the same number. The results are the same, but there were more editing delegates that were called, as expected. I suspect these tests were created during the time that <rdar://problem/4919097> was broken

WebCore:

Reviewed by Ada.

Fixed <rdar://problem/4919097> REGRESSION: Ctrl-Y fails to yank (11076)

  • editing/Editor.cpp: (WebCore::Editor::deleteWithDirection): If there's no selection, locally create a range that is to the end of the granularity unit and pass that to deleteRange().
6:01 PM Changeset in webkit [22856] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Oliver.

Engine side of fix for <rdar://problem/4958371> Boomer leaks WebViews

The problem was that we were calling RevokeDragDrop after our view
window had been destroyed, RevokeDragDrop wouldn't call Release on us.

Fix <rdar://problem/4958382> WebViews leak their HWND if no host window is set

  • WebView.cpp: (WebView::~WebView): Call DestroyWindow if our view window hasn't been destroyed yet. (WebViewWndProc): Added an ASSERT, and added call to revokeDragDrop when handling WM_DESTROY. (WebView::initWithFrame): Call our own registerDragDrop. (WebView::close): Removed call to RevokeDragDrop. At this point our window has been destroyed, so it's too late to do this. (WebView::registerDragDrop): Added. (WebView::revokeDragDrop): Added.
  • WebView.h: Added declarations.
5:55 PM Changeset in webkit [19171] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Qt build fix.

  • page/qt/EventHandlerQt.cpp:
5:44 PM Changeset in webkit [22855] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-01-26 Oliver Hunt <​oliver@apple.com>

Build fix.

  • WebCore.vcproj/WebCore.vcproj:


5:43 PM Changeset in webkit [19170] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

Fix so that we only relayout frameset children on calls to layout.

  • page/FrameView.cpp: (WebCore::FrameView::layout):
5:35 PM Changeset in webkit [19169] by oliver
  • 3 edits in trunk/WebCore

2007-01-26 Oliver Hunt <​oliver@apple.com>

Build Fix

  • ksvg2/svg/ColorDistance.cpp:
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::handleTimerEvent):
4:59 PM Changeset in webkit [19168] by eseidel
  • 20 edits
    14 adds in trunk/WebCore

2007-01-26 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

Add support for calcMode, keyTimes and (nearly) keySplines.
​http://bugs.webkit.org/show_bug.cgi?id=12350
Re-architect much of the animation system to remove huge sections of code.
Added new ColorDistance, SVGTransformDistance to simplify animateColor, animateTransform calculations.
I also added basic <animateMotion> support since it was so easy w/ the new architecture.


Adding manual animation tests until bug 12074 is fixed.

  • WebCore.xcodeproj/project.pbxproj:
  • ksvg2/misc/SVGTimer.cpp: (WebCore::SVGTimer::applyAnimations):
  • ksvg2/svg/ColorDistance.cpp: Added. (WebCore::ColorDistance::ColorDistance): (WebCore::clampColorValue): (WebCore::ColorDistance::scaledDistance): (WebCore::ColorDistance::addColorsAndClamp): (WebCore::ColorDistance::addToColorAndClamp): (WebCore::ColorDistance::isZero): (WebCore::ColorDistance::distance):
  • ksvg2/svg/ColorDistance.h: Added.
  • ksvg2/svg/SVGAnimateColorElement.cpp: (WebCore::SVGAnimateColorElement::SVGAnimateColorElement): (WebCore::SVGAnimateColorElement::updateAnimationBaseValueFromElement): (WebCore::SVGAnimateColorElement::applyAnimatedValueToElement): (WebCore::SVGAnimateColorElement::updateAnimatedValue): (WebCore::SVGAnimateColorElement::calculateFromAndToValues):
  • ksvg2/svg/SVGAnimateColorElement.h: (WebCore::SVGAnimateColorElement::contextElement):
  • ksvg2/svg/SVGAnimateElement.h: (WebCore::SVGAnimateElement::updateAnimatedValue): (WebCore::SVGAnimateElement::calculateFromAndToValues):
  • ksvg2/svg/SVGAnimateMotionElement.cpp: (WebCore::SVGAnimateMotionElement::hasValidTarget): (WebCore::SVGAnimateMotionElement::updateAnimatedValue): (WebCore::parsePoint): (WebCore::SVGAnimateMotionElement::calculateFromAndToValues): (WebCore::SVGAnimateMotionElement::updateAnimationBaseValueFromElement): (WebCore::SVGAnimateMotionElement::applyAnimatedValueToElement):
  • ksvg2/svg/SVGAnimateMotionElement.h:
  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement): (WebCore::SVGAnimateTransformElement::updateAnimatedValue): (WebCore::SVGAnimateTransformElement::updateAnimationBaseValueFromElement): (WebCore::SVGAnimateTransformElement::applyAnimatedValueToElement): (WebCore::SVGAnimateTransformElement::calculateFromAndToValues): (WebCore::SVGAnimateTransformElement::parseTransformValue):
  • ksvg2/svg/SVGAnimateTransformElement.h: (WebCore::SVGAnimateTransformElement::contextElement):
  • ksvg2/svg/SVGAnimationElement.cpp: (WebCore::SVGAnimationElement::parseKeyNumbers): (WebCore::parseValues): (WebCore::parseKeySplines): (WebCore::SVGAnimationElement::parseMappedAttribute): (WebCore::SVGAnimationElement::targetAttributeAnimatedValue): (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue): (WebCore::SVGAnimationElement::detectAnimationMode): (WebCore::adjustPercentagePastForKeySplines): (WebCore::SVGAnimationElement::valueIndexAndPercentagePastForDistance): (WebCore::SVGAnimationElement::calculateTotalDistance): (WebCore::caculateValueIndexForKeyTimes): (WebCore::SVGAnimationElement::isValidAnimation): (WebCore::SVGAnimationElement::calculateValueIndexAndPercentagePast): (WebCore::SVGAnimationElement::updateAnimationBaseValueFromElement): (WebCore::SVGAnimationElement::applyAnimatedValueToElement): (WebCore::SVGAnimationElement::handleTimerEvent): (WebCore::SVGAnimationElement::updateAnimatedValueForElapsedSeconds):
  • ksvg2/svg/SVGAnimationElement.h:
  • ksvg2/svg/SVGParserUtilities.cpp: (WebCore::SVGPolyParser::parsePoints):
  • ksvg2/svg/SVGParserUtilities.h:
  • ksvg2/svg/SVGSetElement.cpp:
  • ksvg2/svg/SVGSetElement.h: (WebCore::SVGSetElement::updateAnimatedValue): (WebCore::SVGSetElement::calculateFromAndToValues):
  • ksvg2/svg/SVGTransform.cpp: (SVGTransform::type): (SVGTransform::translate): (SVGTransform::scale): (SVGTransform::setSkewX): (SVGTransform::setSkewY):
  • ksvg2/svg/SVGTransform.h: (WebCore::operator==): (WebCore::operator!=):
  • ksvg2/svg/SVGTransformDistance.cpp: Added. (WebCore::SVGTransformDistance::SVGTransformDistance): (WebCore::SVGTransformDistance::scaledDistance): (WebCore::SVGTransformDistance::addSVGTransforms): (WebCore::SVGTransformDistance::addSVGTransform): (WebCore::SVGTransformDistance::addToSVGTransform): (WebCore::SVGTransformDistance::isZero): (WebCore::SVGTransformDistance::distance):
  • ksvg2/svg/SVGTransformDistance.h: Added.
  • ksvg2/svg/SVGTransformList.cpp: (SVGTransformList::concatenateForType):
  • ksvg2/svg/SVGTransformList.h:
  • manual-tests/animation/animateColor-by.svg: Added.
  • manual-tests/animation/animateColor-from-by.svg: Added.
  • manual-tests/animation/animateColor-repeat-indefinite.svg: Added.
  • manual-tests/animation/animateColor-to-from.svg: Added.
  • manual-tests/animation/animateColor-to.svg: Added.
  • manual-tests/animation/animateColor-values-simple.svg: Added.
  • manual-tests/animation/animateMotion-to.svg: Added.
  • manual-tests/animation/animateTransform-keyTimes.svg: Added.
  • manual-tests/animation/animateTransform-repeat-once.svg: Added.
4:52 PM Changeset in webkit [19167] by kdecker
  • 4 edits in trunk/WebKit

Reviewed by andersca.

Fixed: <rdar://problem/4946922> WebBaseNetscapePluginView leaks memory
​http://bugs.webkit.org/show_bug.cgi?id=11523

  • Plugins/WebBaseNetscapePluginStream.m:

(-[WebBaseNetscapePluginStream setPlugin:]): Calls -[WebBaseNetscapePluginView disconnectStream:]

  • Plugins/WebBaseNetscapePluginView.h: Added disconnectStream: to header.
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView stop]): Make a copy of the streams collection prior to calling stop all streams. This is necessary because calling stop has the side effect of removing the stream from this same collection. (-[WebBaseNetscapePluginView disconnectStream:]): Added. Removes the stream from the streams collection.
4:16 PM Changeset in webkit [22854] by bdakin
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Darin.

Due to <rdar://problem/4956565> REGRESSION: After scrolling frame,
hovering over link in this frame doesn't change cursor to pointing
hand

lastEventIsMouseUp() is a Mac-only issue. This patch makes it Mac-
only code, so we can remove the temporary link stub for it.

  • platform/win/TemporaryLinkStubs.cpp:
4:03 PM Changeset in webkit [19166] by bdakin
  • 4 edits in trunk/WebCore

Reviewed by Darin.

Fix for <rdar://problem/4956565> REGRESSION: After scrolling frame,
hovering over link in this frame doesn't change cursor to pointing
hand

The mouseMove event was not being propagated correctly after using
the mouse to scroll the frame because m_mousePressed was never
getting set to false.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent): This code does not belong here.
  • page/EventHandler.h: lastEventIsMouseUp() is only ever relevant in EventHandlerMac, so it can just be a static function there.
  • page/mac/EventHandlerMac.mm: (WebCore::lastEventIsMouseUp): Make this static. (WebCore::EventHandler::passMouseDownEventToWidget): Here is where we need to set m_mousePressed to false if lastEventIsMouseUp() is true.
3:58 PM Changeset in webkit [22853] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam.


  • WebKitDLL.cpp: Add WebURLRequest entries to the big array.
3:36 PM Changeset in webkit [22852] by andersca
  • 6 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

<rdar://problem/4923845>
Implement IWebURLRequest.


  • Interfaces/WebKit.idl:
  • WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance):
  • WebKitDLL.cpp: (DllGetClassObject):
  • WebMutableURLRequest.cpp: (WebMutableURLRequest::WebMutableURLRequest): (WebMutableURLRequest::createInstance): (WebMutableURLRequest::createImmutableInstance): (WebMutableURLRequest::QueryInterface):
  • WebMutableURLRequest.h:
2:47 PM Changeset in webkit [19165] by hyatt
  • 4 adds in trunk/LayoutTests/fast/css

Add layout test for orphaned CSS unit coalescing.

2:45 PM Changeset in webkit [19164] by hyatt
  • 4 edits in trunk/WebCore

Fix for style regression caused by strictness checking of the number of properties. This caused code like:
"width: 20 px" to fail, because we interpreted it as two values and rejected it. Our old code allowed 20 to be
used like a pixel value and then ignored the orphaned unit.

This patch actually scans the list of values looking for orphaned units and reattaches them to the numeric
values that they should correspond to. This means rules like "width: 5 em" will now work in quirks mdoe and
the "em" unit type will be honored.

Reviewed by beth

  • WebCore.xcodeproj/project.pbxproj:
  • css/cssparser.cpp: (WebCore::unitFromString): (WebCore::CSSParser::checkForOrphanedUnits): (WebCore::CSSParser::parseValue):
  • css/cssparser.h: (WebCore::ValueList::valueAt): (WebCore::ValueList::deleteValueAt):
2:19 PM Changeset in webkit [19163] by staikos
  • 14 edits in trunk

What's left of my trashed work to add more Qt functionality

2:02 PM Changeset in webkit [19162] by beidson
  • 2 edits in trunk/WebCore

Fixed build that use RetainPtr::adoptCFReference(CFTypeRef)

1:13 PM Changeset in webkit [19161] by lars
  • 3 edits in trunk/WebKitQt

Make it compile again with Qt 4.2 and add the copyright
headers where forgotten in the last submit.

11:51 AM Changeset in webkit [22851] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-01-26 Steve Falkenburg <​sfalken@apple.com>

B&I build fix

  • WebKit.vcproj/WebKit.vcproj:
11:50 AM Changeset in webkit [22850] by andersca
  • 3 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Adam.

Don't pretend that we're an IWebHTTPURLResponse when we're not.


  • WebURLResponse.cpp: (WebURLResponse::QueryInterface): (WebURLResponse::allHeaderFields): (WebURLResponse::localizedStringForStatusCode): (WebURLResponse::statusCode):


  • WebView.cpp: (WebView::canShowMIMEType): Implement this.
11:31 AM Changeset in webkit [19160] by darin
  • 5 edits in trunk/WebCore

Reviewed by Brady.

  • fix <rdar://problem/4956688> move Mac-specific part of icon code into IconMac
  • fix a GC-compatibility problem in the icon code I noticed by code inspection
  • platform/FileChooser.cpp: (WebCore::FileChooser::chooseIcon): Removed Mac-specific path check -- that's in newIconForFile now.
  • platform/graphics/Icon.h: Changed the image to be a RetainPtr. The old code was using -[NSObject retain] which is not good enough for a pointer in a C++ object.
  • platform/graphics/mac/IconMac.mm: (WebCore::Icon::Icon): Got rid of unneeded code to do what RetainPtr does for us. (WebCore::Icon::~Icon): Ditto. (WebCore::Icon::newIconForFile): Added check for non-absolute file names. Updated for use of RetainPtr. Use constructor that takes NSImage. (WebCore::Icon::paint): Add get() calls needed now that we are using a RetainPtr.
  • WebCore.xcodeproj/project.pbxproj: Let Xcode do its thing.
10:10 AM Changeset in webkit [19159] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12385
Assertion failure when loading subresources from "data:" frames

Test: fast/loader/opaque-base-url.html

  • platform/KURL.cpp: (WebCore::KURL::init): Make the URL invalid if it's relative, but has an opaque or empty base.
10:01 AM Changeset in webkit [22849] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

I'm in ur WebDownloadz, null checkin ur pointerz

9:20 AM Changeset in webkit [19158] by darin
  • 4 edits in trunk

LayoutTests:

  • fast/events/objc-event-api-expected.txt: Updated test result now that we no longer invalidate clicks when the mouse moves a bit.

WebCore:

Reviewed by Darin.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): Removed a call to invalidateClick(), since we don't want to cancel a click if the mouse moves.
9:14 AM Changeset in webkit [19157] by darin
  • 2 edits in trunk/WebCore
  • css/MediaQueryEvaluator.cpp: (WebCore::MediaQueryEvaluator::mediaTypeMatchSpecific): Oops, forgot a !.
9:10 AM Changeset in webkit [19156] by darin
  • 5 edits in trunk/WebCore

Patch by Nate Begeman.
Reviewed by Darin and Maciej.

  • css/MediaQueryEvaluator.h: Add mediaTypeMatchSpecific, a function that takes a char* to avoid creating and destroying a String for simple media type queries.
  • css/MediaQueryEvaluator.cpp: (WebCore::MediaQueryEvaluator::mediaTypeMatchSpecific): Added. Besides avoiding the conversion to String, this also doesn't have the special case code to handle "" and "all".
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::matchUARules): Call mediaTypeMatchSpecific here when deciding whether to use the print version of the user agent style sheet.
  • loader/Cache.cpp: (WebCore::Cache::requestResource): Don't convert to a string and back to a KURL when calling createResource. Avoids reparsing the URL string.
8:55 AM Changeset in webkit [19155] by brmorris
  • 3 edits in S60/trunk/WebCore

yongjzha

Reviewed by <​zbujtas@gmail.com>
DESC: PNUN-6XJJLF When use css border property outset, and set border color to blue, the browser
shows black at the bottom edge and right edge.
fix: correct RGB to HSV and HSV to RGB conversion algorithms in KWQColor.cpp

​http://bugs.webkit.org/show_bug.cgi?id=12393

8:53 AM Changeset in webkit [19154] by brmorris
  • 3 edits in S60/branches/3.1m/WebCore

yongjzha

Reviewed by <​zbujtas@gmail.com>
DESC: PNUN-6XJJLF When use css border property outset, and set border color to blue, the browser
shows black at the bottom edge and right edge.
fix: correct RGB to HSV and HSV to RGB conversion algorithms in KWQColor.cpp

​http://bugs.webkit.org/show_bug.cgi?id=12393

8:49 AM Changeset in webkit [19153] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

2007-01-26 Deepa

Reviewed by Sachin.
DESC: Resolve FavIcon issue in cases of websites with the same sub domain name (AKKO-6XJDCQ)
The function ExtractDomainL( ) was changed to include the entire host name
instead of just the last two parts.

8:48 AM Changeset in webkit [19152] by brmorris
  • 2 edits in S60/trunk/WebKit

2007-01-26 Deepa

Reviewed by Sachin.
DESC: Resolve FavIcon issue in cases of websites with the same sub domain name (AKKO-6XJDCQ)
The function ExtractDomainL( ) was changed to include the entire host name
instead of just the last two parts.

5:13 AM Changeset in webkit [19151] by zack
  • 5 edits
    3 adds in trunk

History support on platform Qt. r=lars
We might switch to a model but for now this is ok.

5:01 AM Changeset in webkit [19150] by zack
  • 4 edits
    1 add in trunk/WebCore

introduce platform scrollbars on Qt platform

3:40 AM Changeset in webkit [19149] by bdash
  • 19 edits
    2 adds in trunk

2007-01-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Changed offset{Left,Top} to match Firefox. If the body element is statically
positioned, it is still returned as the offsetParent of elements whose containing
block is the initial containing block (the root), but their offset{Left,Top} are
relative to the root. If the body element is positioned, then offsets are relative
to it. The body's own offset{Left,Top} are always 0.

Test: fast/dom/Element/offsetLeft-offsetTop-body-quirk.html

  • rendering/RenderObject.cpp: (WebCore::RenderObject::offsetLeft): (WebCore::RenderObject::offsetTop):

2007-01-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • editing/execCommand/findString-2.html:
  • editing/pasteboard/4947130.html:
  • editing/pasteboard/drop-text-without-selection.html:
  • editing/selection/anchor-focus1-expected.txt:
  • editing/selection/click-before-and-after-table.html:
  • editing/selection/drag-select-1.html:
  • editing/selection/editable-links-expected.txt:
  • editing/selection/mixed-editability-1.html:
  • editing/selection/paragraph-granularity.html:
  • editing/selection/selection-actions.html:
  • editing/selection/word-granularity.html:
  • fast/dom/Element/offsetLeft-offsetTop-body-quirk-expected.txt: Added.
  • fast/dom/Element/offsetLeft-offsetTop-body-quirk.html: Added.
  • fast/forms/drag-into-textarea.html:
  • fast/forms/listbox-selection-2.html:
  • fast/forms/listbox-selection.html:
  • fast/table/click-near-anonymous-table-expected.txt:
  • fast/table/click-near-anonymous-table.html:
3:35 AM Changeset in webkit [19148] by bdash
  • 6 edits
    4 adds in trunk

2007-01-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Reviewed by Darin and Maciej.

Test: fast/dynamic/staticY.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutPositionedObjects): Avoid marking the object's parents, since they have already been laid out.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStaticY): Added a call to setChildNeedsLayout() to ensure relayout by this box's container (third and fourth cases in the layout test).
  • rendering/RenderBox.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): For positioned objects with static y, also mark the object's parent to ensure that it recomputes the static y value (first case in the layout test).

2007-01-26 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin and Maciej.

Tests three cases that the patch fixes and another one that was fixed in
r8284 but did not have a test.

  • fast/dynamic/staticY-expected.checksum: Added.
  • fast/dynamic/staticY-expected.png: Added.
  • fast/dynamic/staticY-expected.txt: Added.
  • fast/dynamic/staticY.html: Added.
3:16 AM Changeset in webkit [19147] by lars
  • 10 edits
    2 deletes in trunk

Get rid of FrameQtClient. It's unused since we moved over
to the loader.

3:14 AM Changeset in webkit [19146] by zack
  • 2 edits in trunk/WebKitQt

Correctly position child frames within the
toplevel frame (put them on the viewport). r=lars

2:25 AM Changeset in webkit [22848] by aroben
  • 1 edit in branches/WindowsMerge/WebKitWin/ChangeLog

Updated ChangeLog with Radar reference.

1:57 AM Changeset in webkit [19145] by lars
  • 1904 edits
    3 deletes in trunk/LayoutTestResults

Update the test cases after the last change to
DumpRenderTree. Hope this will not be needed again.

1:50 AM Changeset in webkit [19144] by zack
  • 2 edits in trunk/WebCore

fix the compile

1:44 AM Changeset in webkit [19143] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fixed an issue on tivofaq.com where you could never tab forward into
the left frame after tabbing out of the document.

  • page/FocusController.cpp: (WebCore::FocusController::advanceFocus): Clear the focused frame before passing off focus to Chrome so that when we re-enter the document we start at the main frame instead of the last focused frame.
1:27 AM Changeset in webkit [22847] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-01-26 Oliver Hunt <​oliver@apple.com>

Build fix -- adding SVGInlineTextBox.{cpp,h} to project

  • WebCore.vcproj/WebCore.vcproj:
1:22 AM Changeset in webkit [19142] by lars
  • 6 edits in trunk

Reviewed by Zack

WebKitQt:
Make sure we resize the HTML when resizing a
QWebFrame. Also ensure that the render tree
is up to date before dumping it.

DumpRenderTree:
Small hack to ensure that our top level frame actually has the
correct size. Unfortunately this means I'll have to regenerate
all test cases :/

1:20 AM Changeset in webkit [19141] by lars
  • 2 edits in trunk/LayoutTestResults

Minor update, skip two test case that are hanging
forever.

1:03 AM Changeset in webkit [19140] by rwlbuis
  • 8 edits
    2 adds in trunk/WebCore

Reviewed by olliej.

​http://bugs.webkit.org/show_bug.cgi?id=11911
SVG exhibits double-text-selection behavior

Fix selection height of the inline text boxes for svg.

1:00 AM Changeset in webkit [19139] by zack
  • 2 edits in trunk/WebKitQt

Display pages inside a mainwindow instead of a custom qwidget
in the qtlauncher.

12:54 AM Changeset in webkit [19138] by zack
  • 2 edits in trunk/WebCore

Fix drawing of tiled images. r=lars

12:25 AM Changeset in webkit [19137] by zack
  • 9 edits in trunk/WebCore

Fix image loading and implement icon class

Jan 25, 2007:

11:53 PM Changeset in webkit [22846] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-01-25 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej.

Fixed DragDataWin behaviour so that it will provide plain text
for a file dropped on the window.

  • platform/win/DragDataWin.cpp: (WebCore::DragData::asPlainText):
11:32 PM Changeset in webkit [22845] by beidson
  • 5 edits in branches/WindowsMerge/WebKitWin

Make WebDownloads no longer start themselves

11:30 PM Changeset in webkit [19136] by lars
  • 2 edits in trunk/JavaScriptCore

Patch from Jan Kraemer.

Reviewed by Maciej

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12382

Fix crash on architectures with 32 bit ints and
64 bit longs (For example Linux on AMD64)

8:25 PM Changeset in webkit [22844] by beidson
  • 1 edit in branches/WindowsMerge/WebCore/platform/network/cf/FormDataStreamCFNet.cpp

Fix the build for people who aren't me and aren't currently running ToT CF

7:18 PM Changeset in webkit [22843] by beidson
  • 3 edits in branches/WindowsMerge/WebCore

Prepare for upcoming CF/CFNetwork api changes

7:13 PM Changeset in webkit [22842] by adele
  • 3 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adam.

Added support for slider.

4:51 PM Changeset in webkit [22841] by adachan
  • 3 edits in branches/WindowsMerge/WebKitWin

2007-01-25 Ada Chan <​adachan@apple.com>

WebDownload.cpp reviewed by Brady.
WebFrame.cpp reviewed by Anders.

  • WebDownload.cpp: (WebDownload::cancel): added null check
  • WebFrame.cpp: (WebFrame::dispatchDecidePolicyForMIMEType): fixed bug that we treated loading image urls as downloads.
4:35 PM Changeset in webkit [22840] by aroben
  • 6 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Steve and Darin.

3:56 PM Changeset in webkit [22839] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

3:51 PM Changeset in webkit [19135] by kdecker
  • 4 edits in trunk/WebKit

Backed out my last patch because it crashes espn.com. Stay tuned for a newer version..

  • Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setPlugin:]): Removed call to streamIsDead.
  • Plugins/WebBaseNetscapePluginView.h: Removed streamIsDead.
  • Plugins/WebBaseNetscapePluginView.mm: Ditto.
3:46 PM Changeset in webkit [19134] by sfalken
  • 1 copy in tags/Safari-521.32.15b

New tag.

3:05 PM Changeset in webkit [19133] by justing
  • 5 edits in trunk

LayoutTests:

Reviewed by oliver


<​http://bugs.webkit.org/show_bug.cgi?id=12409>
REGRESSION (r19039): Drag caret isn't cleared after a drop

  • editing/pasteboard/4947130-expected.checksum:
  • editing/pasteboard/4947130-expected.png:

WebCore:

Reviewed by oliver


<​http://bugs.webkit.org/show_bug.cgi?id=12409>
REGRESSION (r19039): Drag caret isn't cleared after a drop

No new layout tests because the regression was
caught by current layout tests.

  • page/DragController.cpp: (WebCore::DragController::concludeDrag): Clear the drag caret.
3:01 PM Changeset in webkit [22838] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2007-01-25 Steve Falkenburg <​sfalken@apple.com>

B&I build fix

  • WebCore.vcproj/WebCore.vcproj:
2:46 PM Changeset in webkit [19132] by darin
  • 3 edits in trunk/WebKit

Reviewed by Beth.

  • fix <rdar://problem/4952766> Safari has a top secret color picker that can be used to... uhh... I don't know
  • Panels/English.lproj/WebAuthenticationPanel.nib/info.nib: Let Interface Builder have its way.
  • Panels/English.lproj/WebAuthenticationPanel.nib/objects.nib: Remove the NSColorWell that was in here (for no good reason).
1:30 PM Changeset in webkit [19131] by kdecker
  • 4 edits in trunk/WebKit

Reviewed by andersca.

A few tweaks with of a fix done by Steve Gehrman.

Fixed: <rdar://problem/4946922> WebBaseNetscapePluginView leaks memory

​http://bugs.webkit.org/show_bug.cgi?id=11523

  • Plugins/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setPlugin:]): Calls -[WebBaseNetscapePluginView streamIsDead:]
  • Plugins/WebBaseNetscapePluginView.h: Added streamIsDead to header.
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView streamIsDead:]): Added. Removes the stream from the streams collection.
12:21 PM Changeset in webkit [19130] by ggaren
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Geoffrey Garen.


Added tests for ​http://bugs.webkit.org/show_bug.cgi?id=12342
REGRESSION: destroying a frame from its own script causes various crashes


Thanks to Alexey Proskuryakov for the original versions of these tests.

  • fast/dom/exception-no-frame-inline-script-crash-expected.txt: Added.
  • fast/dom/exception-no-frame-inline-script-crash.html: Added.
  • fast/dom/exception-no-frame-timeout-crash-expected.txt: Added.
  • fast/dom/exception-no-frame-timeout-crash.html: Added.

WebCore:

Reviewed and landed by Geoffrey Garen.

  • bindings/js/kjs_window.cpp: (KJS::ScheduledAction::execute): Use RefPtr for the frame and the interpreter object so they don't get deleted out from underneath us.
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate): Add a check for a page of 0. This was the only call site for the addMessageToConsole function that did not have a check for a page of 0.
11:52 AM Changeset in webkit [19129] by lars
  • 2 edits
    94 adds in trunk/LayoutTestResults

Add the next 100 test cases.

11:27 AM Changeset in webkit [19128] by lars
  • 2 edits
    300 adds in trunk/LayoutTestResults

Add more test cases that pass on the Qt build.

10:42 AM Changeset in webkit [19127] by lars
  • 2 edits
    157 adds in trunk/LayoutTestResults

The tests in dom/svg and dom/xhtml as well as
most of the remaining tests in tables/ pass now as
well, so lets run the test suite over them.

10:13 AM Changeset in webkit [19126] by bdakin
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed and merged by Beth.

Fix for <rdar://problem/4921692> not processing comments inside a
title element leads to XSS (for at least BlogSpot)

This is equivalent to commit 626791 in the KDE tree. Basically, the
patch allows comment parsing in titles to avoid capturing a
<script> tag by accident.

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::parseSpecial): (WebCore::HTMLTokenizer::parseComment):

LayoutTests:

Test for <rdar://problem/4921692> not processing comments inside a
title element leads to XSS (for at least BlogSpot)

  • fast/parser/parseCommentsInTitles-expected.checksum: Added.
  • fast/parser/parseCommentsInTitles-expected.png: Added.
  • fast/parser/parseCommentsInTitles-expected.txt: Added.
  • fast/parser/parseCommentsInTitles.html: Added.
10:12 AM Changeset in webkit [19125] by brmorris
  • 2 edits in S60/trunk/WebCore

bujtas <​zbujtas@gmail.com>

Reviewed by Sachin.
DESC: ISHG-6S8Q5X fix list marker offset problem.
markers get off when the marker image, specified in CSS, is 404.
fix: issue relayout, when the errorImage is set on the marker.

​http://bugs.webkit.org/show_bug.cgi?id=12404


10:12 AM Changeset in webkit [19124] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

bujtas <​zbujtas@gmail.com>

Reviewed by Sachin.
DESC: ISHG-6S8Q5X fix list marker offset problem.
markers get off when the marker image, specified in CSS, is 404.
fix: issue relayout, when the errorImage is set on the marker.

​http://bugs.webkit.org/show_bug.cgi?id=12404

9:41 AM Changeset in webkit [22837] by aroben
  • 6 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders.

Part of <rdar://problem/4855618> HTML-based load failure pages.

  • Interfaces/IWebError.idl: Added failingURL method declaration.
  • WebError.cpp: (WebError::failingURL): Implemented.
  • WebError.h: Updated for interface changes.
  • WebFrame.cpp: (WebFrame::loadHTMLString): New protected helper method called by IWebFrame::loadHTMLString and IWebFrame::loadAlternateHTMLString. (WebFrame::loadAlternateHTMLString): Calls loadHTMLString.
  • WebFrame.h: Added new declaration.
8:09 AM Changeset in webkit [19123] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

spadma

Reviewed by Zalan.
DESC: ResolveEmbedded link not called for plugins (ASAA-6X5DX8)
​http://bugzilla.opendarwin.org/show_bug.cgi?id=12400

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::LoadPluginL):
7:39 AM Changeset in webkit [19122] by darin
  • 2 edits in trunk/WebCore
  • ksvg2/svg/SVGPreserveAspectRatio.cpp: Add a couple of comments.
7:33 AM Changeset in webkit [19121] by darin
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • test for bugs found by code inspection in the SVGPreserveAspectRatio parser
  • svg/dom/preserve-aspect-ratio-parser-expected.txt: Added.
  • svg/dom/preserve-aspect-ratio-parser.html: Added.

WebCore:

Reviewed by Maciej.

  • fix ​http://bugs.webkit.org/show_bug.cgi?id=12365 Reproducible crash in WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio in svg/W3C-SVG-1.1/animate-elem-40-t.svg under guard malloc
  • fix bug where the parser accepts "meet" or "slice" as an entire string
  • fix bug where "slice" is ignored if the old alignment was "none" even if the newly-parsed alignment is something other than "none", and "slice" is not ignored if the old alignment was not "none", but the newly-parsed alignment is "none"
  • optimize to only call notifyAttributeChange if the attribute actually changed

Test: svg/dom/preserve-aspect-ratio-parser-test.html

  • ksvg2/svg/SVGPreserveAspectRatio.cpp: (WebCore::checkString): Added an overload for using char* constants which is much simpler than the old one, and almost as fast. (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio): Fail if there's no more text after "defer". Fail if there's neither "none" nor an x/y specified. Check that there's more text before looking at the "m" and "s" for "meet" and "slice". Merged the failure and success cases. Only call notifyAttributeChange if something changed.

I think all the "optimized" code where we check the first character before
calling checkString isn't really helpful, but I decided to leave it as-is
for now.

6:54 AM Changeset in webkit [19120] by lars
  • 3 edits in trunk/WebCore

Reviewed by Zack

Trivial implementation of getMIMETypeForExtension.
Use the above method in the ResourceHandleManager to set
a mimetype on Resources that don't have one set (which
includes everything loaded from local disk).

Should fix quite a few test cases :)

6:20 AM Changeset in webkit [19119] by sullivan
  • 3 edits in trunk/WebKit

Reviewed by Kevin, Geoff, Brady, and Darin


  • fixed <rdar://problem/4918446> Safari's temp files (PDF's) should be in a sub-folder when calling Preview


  • WebView/WebPDFView.mm: (-[WebPDFView _path]): use _temporaryPDFDirectoryPath method instead of #defines for hardwiring strings; stop bad practice of modifying the const char* returned by fileSystemRepresentation (-[WebPDFView _temporaryPDFDirectoryPath]): new method, lazily creates and returns a secure temporary directory created with NSTemporaryDirectory() and mkdtemp
  • English.lproj/StringsNotToBeLocalized.txt: Updated for these and other recent changes
6:03 AM Changeset in webkit [19118] by lars
  • 2 edits
    808 adds in trunk/LayoutTestResults

Add more test results for the Qt build.

5:06 AM Changeset in webkit [19117] by zack
  • 2 edits in trunk/WebCore

Path from Harald Fernengel to fix compile on platforms
where qreal is not a double.
r=me

4:48 AM Changeset in webkit [19116] by zack
  • 7 edits
    1 add in trunk/WebCore

implement wheel event handling and use eventhandler explictly.
r=lars

3:07 AM BuildingOnWindows edited by ext-daniel.knauth@nokia.com
(diff)
2:54 AM Changeset in webkit [19115] by rwlbuis
  • 3 edits
    4 adds in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12391
SVG containers with viewports should respect overflow when hit testing
Take into account the overflow property when hit testing <svg>.

2:04 AM Changeset in webkit [19114] by lars
  • 2 edits in trunk/WebKitQt

Reviewed by Zack

Emit the loadDone() signal from teh onload event callback
again. This hangs on one or two test cases, but removes
hundreds of failures elsewhere.

2:04 AM Changeset in webkit [19113] by lars
  • 2 edits in trunk/LayoutTestResults

remove dom/html/level2/html from skipped tests.

12:56 AM Changeset in webkit [19112] by lars
  • 611 adds in trunk/LayoutTestResults

Add css1 and css2.1 test results for the Qt build

12:54 AM Changeset in webkit [19111] by lars
  • 4 edits
    1 delete in trunk/WebKitTools

Reviewed by Darin and Zack

Fix ​http://bugs.webkit.org/show_bug.cgi?id=12398


Move the test results for Qt into a directory of it's own
(WebKit/LayoutTestResults/qt). Leave the Mac results where
they are for now and share the text only results between
Mac and Qt.

Add support for a LayoutTestResults/platform/Skipped file
to run-webkit-tests to be able to ignore certain tests

Remove the old tests-skipped.txt from Qts DumpRenderTree
implementation.

12:47 AM Changeset in webkit [22836] by adachan
  • 3 edits in branches/WindowsMerge/WebKitWin

2007-01-25 Ada Chan <​adachan@apple.com>

WebKitWin:

Reviewed by Maciej.


Added init methods instead of doing all the initialization in the constructor.
There was a lifetime issue with passing the WebDownload to delegate calls when
its ref count is still 0.

  • WebDownload.cpp: (WebDownload::init): (WebDownload::createInstance):
  • WebDownload.h:


12:38 AM Changeset in webkit [19110] by aliceli1
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

added test for
<rdar://problem/4808039> REGRESSION: eBay ID check never completes
also known as
​http://bugs.webkit.org/show_bug.cgi?id=11230

  • http/tests/misc/location-replace-crossdomain-expected.txt: Added.
  • http/tests/misc/location-replace-crossdomain.html: Added.
  • http/tests/misc/resources/failure.html: Added.
  • http/tests/misc/resources/success.html: Added.

WebCore:

Reviewed by Maciej.

fixed <rdar://problem/4808039> REGRESSION: eBay ID check never completes
Also known as ​http://bugs.webkit.org/show_bug.cgi?id=11230

  • bindings/js/kjs_window.cpp: It's not necessary to check safeScript when doing a location.replace, .reload, or .assign (KJS::Location::getOwnPropertySlot): (KJS::LocationFunc::callAsFunction):
12:34 AM Changeset in webkit [19109] by aliceli1
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Geoff and Adele

added test for <rdar://problem/4866655> REGRESSION: Copying out of Calculator & CIFIlterWidget is broken on 9A320

  • editing/execCommand/copy-without-selection-expected.txt: Added.
  • editing/execCommand/copy-without-selection.html: Added.

WebCore:

Reviewed by Geoff and Adele.

fixed <rdar://problem/4866655> REGRESSION: Copying out of Calculator & CIFIlterWidget is broken on 9A320

  • editing/Editor.cpp: (WebCore::Editor::canDHTMLCut): (WebCore::Editor::canDHTMLCopy): (WebCore::Editor::tryDHTMLCopy): (WebCore::Editor::tryDHTMLCut): Reverting some mistakes made in r17504: Anything in r17503 that used to call mayDHTML* still calls canDHTML* as it was changed in r17504, where canDHTML* now calls !selectionController::isInPasswordField instead of editor::canCopy Anything else in r17503 that used to call mayCopy now calls (!)selectionController::isInPasswordField.
  • editing/JSEditor.cpp: copy via JS should be enabled as long as selection is not in a password field. a range selection shouldn't be required.

Jan 24, 2007:

11:21 PM Changeset in webkit [22835] by adele
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Brady and Oliver.

Moved keyEvent method from FrameWin to EventHandler and updated
call sites. Now this method is shared with the mac.

  • bridge/win/FrameWin.cpp:
  • bridge/win/FrameWin.h:

WebKitWin:

Reviewed by Brady and Oliver.

Moved keyEvent method from FrameWin to EventHandler and updated
call sites. Now this method is shared with the mac.

  • WebView.cpp: (WebView::keyUp): (WebView::keyDown):
11:12 PM Changeset in webkit [19108] by adele
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Brady and Oliver.

Test for <rdar://problem/4953504> When the keydown event changes focus, the keypress event should go to the new focused node

  • fast/events/keydown-keypress-focus-change-expected.txt: Added.
  • fast/events/keydown-keypress-focus-change.html: Added.

WebCore:

Reviewed by Brady and Oliver.

Fix for <rdar://problem/4953504> When the keydown event changes focus, the keypress event should go to the new focused node

Test: fast/events/keydown-keypress-focus-change.html

  • page/EventHandler.cpp: (WebCore::eventTargetNodeForDocument): Added for convenience. (WebCore::EventHandler::keyEvent): Moved from EventHandlerMac.mm. After dispatching the keyDown event, recheck the target node for the keyPress event in case its changed.
  • page/EventHandler.h:
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::keyEvent): Moved the bulk of this code to EventHandler.cpp.
10:36 PM Changeset in webkit [22834] by beidson
  • 2 edits in branches/WindowsMerge/WebKitWin

Make downloads cancellable

10:07 PM Changeset in webkit [19107] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Oliver.

  • fix crash seen in layout tests
  • DumpRenderTree/EventSendingController.m: (-[EventSendingController dealloc]): Add back the line of code that sets savedMouseEvents to nil. I thought it was a field of the EventSendingController, but it's actually a global.
9:10 PM Changeset in webkit [19106] by oliver
  • 2 edits in trunk/WebKit

2007-01-24 Oliver Hunt <​oliver@apple.com>

Build fix

  • WebView/WebHTMLView.mm: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
8:50 PM Changeset in webkit [22833] by ggaren
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Maciej Stachowiak, Steve Falkenberg, Adam Roben.


Fixed 4946729 -- CFNetwork needs some JS API symbols.


Added hack to compile JSStringRefCF symbols with WebKit, to avoid having to fork
the JavaScriptCore project into the internal repository.

  • WebKit.vcproj/WebKit.def: Export the symbols.
  • WebKit.vcproj/WebKit.vcproj:
8:38 PM Changeset in webkit [19105] by ggaren
  • 4 edits
    1 add in trunk

JavaScriptCore:

Fixed up #include order for style. No review necessary.

  • API/JSStringRef.cpp:

WebCore:

New forwarding header. No review necessary.

  • ForwardingHeaders/kjs/ustring.h: Added.
8:36 PM Changeset in webkit [19104] by oliver
  • 5 edits in trunk

Oliver Hunt <​oliver@apple.com>
WebCore:

Reviewed by Maciej.

Migrating more drag state information to WebCore

  • page/DragController.cpp:
  • page/DragController.h: (WebCore::DragController::dragOperation): (WebCore::DragController::setDraggingImageURL): (WebCore::DragController::draggingImageURL): (WebCore::DragController::setDragOffset): (WebCore::DragController::dragOffset):

WebKit:

Reviewed by Maciej.

Migrating more drag state information to WebCore

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): (-[WebHTMLViewPrivate clear]): (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): (-[WebHTMLView _mayStartDragAtEventLocation:]): (-[WebHTMLView close]): (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): (-[WebHTMLView _delegateDragSourceActionMask]):
  • WebView/WebHTMLViewInternal.h:


8:36 PM Changeset in webkit [19103] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Copy JSStringRefCF, in case anybody wants to use it. (I just added it recently.)
8:34 PM Changeset in webkit [19102] by darin
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Adele.

  • fast/events/autoscroll-expected.checksum: Added.
  • fast/events/autoscroll-expected.png: Added.
  • fast/events/autoscroll-expected.txt: Added.
  • fast/events/autoscroll.html: Added.

WebCore:

Reviewed by Adele.

Test: fast/events/autoscroll.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::autoscroll): Adjust position to be relative to the object's corner for the hit test, but not for the scrollRectToVisible call. The previous version accidentally re-used the version that was adjusted for the hit test.
8:27 PM Changeset in webkit [19101] by darin
  • 3 edits in trunk/WebKitTools

Reviewed by Maciej.

  • changed dragMode to be a property instead of a function
  • DumpRenderTree/EventSendingController.h: Renamed inDragMode to dragMode.
  • DumpRenderTree/EventSendingController.m: (+[EventSendingController isSelectorExcludedFromWebScript:]): Removed setDragMode. (+[EventSendingController isKeyExcludedFromWebScript:]): Added dragMode. (-[EventSendingController init]): Updated for name change. (-[EventSendingController leapForward:]): Ditto. (-[EventSendingController mouseUp]): Ditto. (-[EventSendingController mouseMoveToX:Y:]): Ditto.
8:17 PM Changeset in webkit [19100] by bdakin
  • 12 edits
    4 adds in trunk

WebCore:

Reviewed by Geoff.

Fix for <rdar://problem/4948128> REGRESSION: A crash occurs at
WebCore::Frame::view() after completing a query at mapquest.com
then switching to Bookmarks view

This is just a null-check. If you are in strict mode and ask for
the clientWidth or clientHeight after the document was removed from
it's parent, we no longer have a frameView, so we have to null-
check it. I added null checks for the FrameView in some other
places where it seems like we could potentially run into this
issue.

LayoutTests:

Reviewed by Geoff.

Test for <rdar://problem/4948128> REGRESSION: A crash occurs at
WebCore::Frame::view() after completing a query at mapquest.com
then switching to Bookmarks view

  • fast/dom/clientWidthAfterDocumentIsRemoved-expected.checksum: Added.
  • fast/dom/clientWidthAfterDocumentIsRemoved-expected.png: Added.
  • fast/dom/clientWidthAfterDocumentIsRemoved-expected.txt: Added.
  • fast/dom/clientWidthAfterDocumentIsRemoved.html: Added.
8:12 PM Changeset in webkit [19099] by darin
  • 3 edits in trunk/WebKitTools

Reviewed by Maciej.

  • made the deferral of mouse events until drag completes conditional it's needed for drag testing, and harmful for selection testing
  • DumpRenderTree/EventSendingController.h: Added inDragMode boolean.
  • DumpRenderTree/EventSendingController.m: (+[EventSendingController isSelectorExcludedFromWebScript:]): Added setDragMode:. (+[EventSendingController webScriptNameForSelector:]): Added name for setDragMode, and remove unneeded clearKillRing name. (-[EventSendingController init]): Initialize inDragMode to true. (-[EventSendingController dealloc]): Removed overzealous assertions -- we should not be asserting things that are dependent on the test content! (-[EventSendingController leapForward:]): Only queue events in drag mode. (-[EventSendingController setDragMode:]): Added. (-[EventSendingController mouseDown]): Removed overzealous assertion. (-[EventSendingController mouseUp]): Removed overzealous assertions. Only queue events in drag mode. (-[EventSendingController mouseMoveToX:Y:]): Only queue events in drag mode.
8:04 PM Changeset in webkit [19098] by brmorris
  • 2 edits in S60/trunk/WebKit

spadma

Reviewed by Zalan.
DESC: ResolveEmbedded link not called for plugins
​http://bugzilla.opendarwin.org/show_bug.cgi?id=12400

8:03 PM Changeset in webkit [19097] by mjs
  • 1 edit
    1 delete in trunk/WebCore

Not reviewed, just removing accidentally committed file.

  • removed file that shouldn't be there
  • Image Viewer/Image Viewer.aps: Removed.
8:01 PM Changeset in webkit [19096] by mjs
  • 2 edits in trunk/JavaScriptCore

Not reviewed, trivial property change.


  • JavaScriptCore.vcproj/JavaScriptCore.sln: remove svn:mime-type property which made this binary.
6:31 PM Changeset in webkit [19095] by adele
  • 1 edit in trunk/WebKit/ChangeLog

Updating with correct bug number

6:20 PM Changeset in webkit [19094] by andersca
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Geoff and Adam.

<rdar://problem/4922655>
​http://galeri.milliyet.com.tr/ reproducibly crashes Safari

  • fast/dom/resources/set-frame-src-while-running-script-in-frame.html: Added.
  • fast/dom/set-frame-src-while-running-script-in-frame-expected.txt: Added.
  • fast/dom/set-frame-src-while-running-script-in-frame.html: Added.

WebCore:

Reviewed by Geoff and Adam.

<rdar://problem/4922655>
​http://galeri.milliyet.com.tr/ reproducibly crashes Safari


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestFrame): If the frame already exists, defer the navigation so that we won't end up replacing the document while we're parsing it. This is similar to what setting window.location ends up doing.
6:12 PM Changeset in webkit [22832] by beidson
  • 3 edits in branches/WindowsMerge/WebKitWin

Debug only instrumentation for WebDownload

6:07 PM Changeset in webkit [19093] by adele
  • 3 edits in trunk/WebKit

Reviewed by Darin.

Small improvement to my last checkin to prevent the keyEventWasInterpreted bool from
being overwritten by reentrancy.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:]): Point keyEventWasInterpreted pointer to local variable. (-[WebHTMLView doCommandBySelector:]): (-[WebHTMLView insertText:]):
  • WebView/WebHTMLViewInternal.h: Added BOOL pointer that will point to the local variable on the stack in _interceptEditingKeyEvent
5:38 PM Changeset in webkit [19092] by justing
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by harrison


Adding this layout test for a bug fixed by the changes
in r19088.

  • editing/execCommand/4916402-expected.checksum: Added.
  • editing/execCommand/4916402-expected.png: Added.
  • editing/execCommand/4916402-expected.txt: Added.
  • editing/execCommand/4916402.html: Added.
5:37 PM Changeset in webkit [22831] by sfalken
  • 8 edits in branches/WindowsMerge
5:34 PM Changeset in webkit [19091] by adele
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

Test for <rdar://problem/4943650> REGRESSION: insertion point blink in form field redraws entire web page, making everything slow

  • fast/events/arrow-navigation-expected.txt: Added.
  • fast/events/arrow-navigation.html: Added.

WebKit:

Reviewed by Darin.

  • Fix for <rdar://problem/4943650> REGRESSION: insertion point blink in form field redraws entire web page, making everything slow

Keep track of whether interpretKeyEvents handles the key event based on whether or not we get
called in insertText or doCommandBySelector.

Test: fast/events/arrow-navigation.html

  • WebView/WebHTMLView.mm: (-[WebHTMLView performKeyEquivalent:]): (-[WebHTMLView _interceptEditingKeyEvent:]): (-[WebHTMLView doCommandBySelector:]): (-[WebHTMLView insertText:]):
  • WebView/WebHTMLViewInternal.h:
5:25 PM Changeset in webkit [19090] by bdash
  • 8 edits in trunk

2007-01-25 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

  • Info.plist: Update copyright string.

2007-01-25 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin.

  • Info.plist: Update copyright string.

2007-01-25 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

  • Info.plist: Update copyright string.

2007-01-25 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin.

  • Info.plist: Update copyright string.
5:10 PM Changeset in webkit [19089] by andersca
  • 5 edits in trunk/LayoutTests

Reviewed by Maciej.

Fix tests and update test results.


  • fast/dom/gc-6-expected.txt:
  • fast/dom/gc-6.html:
  • fast/dom/gc-7-expected.txt:
  • fast/dom/gc-7.html:
5:00 PM Changeset in webkit [19088] by justing
  • 16 edits
    10 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4916235>
<rdar://problem/4857269>
<rdar://problem/4916583>
<rdar://problem/4928635>


Fixed and removed FIXME:

  • editing/execCommand/create-list-from-range-selection-expected.checksum:
  • editing/execCommand/create-list-from-range-selection-expected.png:
  • editing/execCommand/create-list-from-range-selection-expected.txt:
  • editing/execCommand/create-list-from-range-selection.html: Added:
  • editing/deleting/4916235-1-expected.txt: Added.
  • editing/deleting/4916235-1.html: Added.
  • editing/execCommand/4916235-expected.txt: Added.
  • editing/execCommand/4916235.html: Added.
  • editing/execCommand/4916583-expected.checksum: Added.
  • editing/execCommand/4916583-expected.png: Added.
  • editing/execCommand/4916583-expected.txt: Added.
  • editing/execCommand/4916583.html: Added.
  • editing/execCommand/4928635-expected.txt: Added.
  • editing/execCommand/4928635.html: Added. Equivalent trees:
  • editing/execCommand/remove-list-item-1-expected.txt:
  • editing/execCommand/remove-list-items-expected.txt:
  • editing/execCommand/switch-list-type-expected.txt: Introduced an extraneous newline because of the poor substitute for VisiblePosition creation in shouldEmitNewlineAfterNode:
  • dom/xhtml/level3/core/nodecomparedocumentposition12-expected.txt:
  • dom/xhtml/level3/core/nodecomparedocumentposition17-expected.txt:
  • dom/xhtml/level3/core/nodeinsertbefore09-expected.txt:

WebCore:

Reviewed by harrison

<rdar://problem/4916235>
eBay Editor: Crash occurs at WebCore::Range::startPosition() after applying ordered list styling to selected text
<rdar://problem/4857269>
REGRESSION: editing/execCommand/create-list-from-range-selection.html no longer works as intended
<rdar://problem/4916583>
eBay Editor: Removing a indent from a list item actually deletes the list item instead
<rdar://problem/4928635>
designMode outdent causes crash (11750)

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::moveParagraphs): Fixed br insertion after the pruning of empty containers left over after the paragraph to move is removed.
  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): There are bugs that leave the wrong number of line breaks after a deletion that expands to include special elements (lists/tables). Added a workaround so that moveParagraphs can avoid these until they are fixed. (WebCore::DeleteSelectionCommand::initializeStartEnd): Ditto. (WebCore::DeleteSelectionCommand::initializePositionData): Ditto.
  • editing/DeleteSelectionCommand.h:
  • editing/TextIterator.cpp: (WebCore::TextIterator::advance): We used to not call exitNode for ancestors of a node where the next node in a pre-order traversal is the ranges's pastEndNode(). This is only correct for ancestors that contain the end of the range. (WebCore::shouldEmitNewlineAfterNode): Added, we should only emit newlines after blocks that have VisiblePositions after them. VisiblePosition creation though is too expensive to do here, what I added here is an OK substitute. (WebCore::shouldEmitNewlineBeforeNode): Added. No special logic yet. (WebCore::TextIterator::handleNonTextNode): Call shouldEmitNewlineBeforeNode. (WebCore::TextIterator::exitNode): Call shouldEmitNewlineAfterNode. (WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode): Call shouldEmitNewlineAfterNode.
4:39 PM Changeset in webkit [22830] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Maciej.

  • WebView.cpp: (WebViewWndProc): Don't send focus/blur events when the previous/newly focused window is a child of ours.
4:22 PM Changeset in webkit [19087] by darin
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Mark Rowe.

  • JavaScriptCore.xcodeproj/project.pbxproj: Changed to /usr/sbin/sysctl so we don't rely on people's paths.

WebCore:

Reviewed by Mark Rowe.

  • WebCore.xcodeproj/project.pbxproj: Changed to /usr/sbin/sysctl so we don't rely on people's paths.

WebKit:

Reviewed by Mark Rowe.

  • WebKit.xcodeproj/project.pbxproj: Changed to /usr/sbin/sysctl so we don't rely on people's paths.
4:16 PM Changeset in webkit [19086] by darin
  • 4 edits in trunk/WebCore

Reviewed by Adele.

  • a couple minor tweaks to recently-changed things
  • dom/Document.h: Use HTMLHeadElement as type for the head function.
  • dom/Document.cpp: (WebCore::Document::head):
  • ksvg2/svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::~SVGElementInstance): Change loop to a for loop and use a local variable for document.
2:45 PM Changeset in webkit [19085] by oliver
  • 1 edit in trunk/WebCore/ChangeLog

Minor edit of previous changelog entry

2:40 PM Changeset in webkit [19084] by oliver
  • 3 edits in trunk/WebCore

2007-01-24 Oliver Hunt <​oliver@apple.com>

Reviewed by Adele.

Fixes DragController to allow a null target Document.
This is encountered in new tabs/windows that have not
loaded any page (including about:blank)

  • page/DragController.cpp: (WebCore::documentAtPoint): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::operationForLoad): (WebCore::DragController::concludeDrag):
  • page/mac/DragControllerMac.mm: (WebCore::DragController::dragOperation):
2:04 PM Changeset in webkit [22829] by adachan
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-01-24 Ada Chan <​adachan@apple.com>

Forgot a null check.

  • WebDownload.cpp: (WebDownload::request):


1:49 PM Changeset in webkit [19083] by brmorris
  • 2 edits in S60/branches/3.1m/S60Tools

2007-01-24 brmorris <​thisisbradley@gmail.com>

Reviewed by me :D

DESC: Merge prepare-ChangeLog.bat from s60/trunk to 3.1m branch

1:43 PM Changeset in webkit [19082] by brmorris
  • 2 edits in S60/trunk/WebKit

spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Browser crashes in tab navigation mode when page load is cancelled
​http://bugzilla.opendarwin.org/show_bug.cgi?id=12397

1:43 PM Changeset in webkit [19081] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

spadma <​Sachin.Padma@nokia.com>

Reviewed by Yongjun.
DESC: Browser crashes in tab navigation mode when page load is cancelled
​http://bugzilla.opendarwin.org/show_bug.cgi?id=12397

1:28 PM Changeset in webkit [19080] by weinig
  • 3 edits in trunk/WebCore

Reviewed by Mitz.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12394
Cleanup RenderBox

No functionality changes, just a good old fashion cleanup,
thus no tests.

  • rendering/RenderBox.cpp: (WebCore::RenderBox::RenderBox): (WebCore::RenderBox::setStyle): (WebCore::RenderBox::destroy): (WebCore::RenderBox::setPos): (WebCore::RenderBox::calcBorderBoxWidth): (WebCore::RenderBox::calcBorderBoxHeight): (WebCore::RenderBox::calcContentBoxWidth): (WebCore::RenderBox::calcContentBoxHeight): (WebCore::RenderBox::nodeAtPoint): (WebCore::RenderBox::paintRootBoxDecorations): (WebCore::RenderBox::paintBoxDecorations): (WebCore::RenderBox::paintBackgrounds): (WebCore::RenderBox::paintBackground): (WebCore::cacluateBackgroundSize): (WebCore::RenderBox::paintBackgroundExtended): (WebCore::RenderBox::getOverflowClipRect): (WebCore::RenderBox::getClipRect): (WebCore::RenderBox::containingBlockWidth): (WebCore::RenderBox::absolutePosition): (WebCore::RenderBox::dirtyLineBoxes): (WebCore::RenderBox::position): (WebCore::RenderBox::getAbsoluteRepaintRect): (WebCore::RenderBox::computeAbsoluteRepaintRect): (WebCore::RenderBox::repaintDuringLayoutIfMoved): (WebCore::RenderBox::relativePositionOffsetX): (WebCore::RenderBox::relativePositionOffsetY): (WebCore::RenderBox::calcWidth): (WebCore::RenderBox::calcWidthUsing): (WebCore::RenderBox::sizesToIntrinsicWidth): (WebCore::RenderBox::calcHorizontalMargins): (WebCore::RenderBox::calcHeight): (WebCore::RenderBox::calcPercentageHeight): (WebCore::RenderBox::calcReplacedWidthUsing): (WebCore::RenderBox::calcReplacedHeightUsing): (WebCore::RenderBox::availableHeightUsing): (WebCore::RenderBox::calcVerticalMargins): (WebCore::RenderBox::containingBlockWidthForPositioned): (WebCore::RenderBox::calcAbsoluteHorizontal): (WebCore::RenderBox::calcAbsoluteHorizontalValues): (WebCore::RenderBox::calcAbsoluteVertical): (WebCore::RenderBox::calcAbsoluteVerticalValues): (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): (WebCore::RenderBox::caretRect):
  • rendering/RenderBox.h: (WebCore::RenderBox::setOverrideSize): (WebCore::RenderBox::width): (WebCore::RenderBox::height): (WebCore::RenderBox::setWidth): (WebCore::RenderBox::setHeight): (WebCore::RenderBox::inlineBoxWrapper): (WebCore::RenderBox::setInlineBoxWrapper): (WebCore::RenderBox::stretchesToViewHeight): (WebCore::RenderBox::setStaticX): (WebCore::RenderBox::setStaticY):
12:11 PM Changeset in webkit [22828] by adachan
  • 7 edits in branches/WindowsMerge/WebKitWin

2007-01-24 Ada Chan <​adachan@apple.com>

Reviewed by Brady.


More hookup of Downloads.


  • Implemented WebDownload::request().
  • Implemented accessors for download delegate in webview.
  • Interfaces/IWebDownload.idl:
  • Interfaces/IWebError.idl:
  • WebDownload.cpp: (WebDownload::WebDownload): (WebDownload::initWithRequest): (WebDownload::request): (WebDownload::willSendRequest):
  • WebDownload.h:
  • WebView.cpp: (WebView::setDownloadDelegate): (WebView::downloadDelegate):
  • WebView.h:
10:54 AM Changeset in webkit [22827] by aroben
  • 3 edits
    1 add in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adele.

Added PlatformScrollBarSafari for Aqua scroll bars.

10:48 AM Changeset in webkit [19079] by darin
  • 2 edits in trunk/WebKit

Reviewed by Adele.

  • fix small regression and GC problems noticed by code inspection
  • WebView/WebHTMLView.mm: Move global declarations to the start of the file. (+[WebHTMLView _excludedElementsForAttributedStringConversion]): Add a CFRetain here for GC compatibility. (+[WebHTMLView _insertablePasteboardTypes]): Ditto. (-[WebHTMLView performKeyEquivalent:]): Fix small logic mistake that prevents super from being called if EventHandler::keyEvent returns false. Reformatted the code a bit and added a local variable for the frame. (-[WebHTMLView _interceptEditingKeyEvent:]): Added some comments. (-[WebHTMLView validAttributesForMarkedText]): Add a CFRetain here for GC compatibility.
10:46 AM Changeset in webkit [19078] by eseidel
  • 19 edits in trunk/WebCore

2007-01-24 Eric Seidel <​eric@webkit.org>

Reviewed by ap.

Converted SVGTransform from being Shared<T> to a POD type.

No functional changes, thus no tests.

  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • ksvg2/misc/SVGTimer.cpp: (WebCore::baseValueTransformList):
  • ksvg2/svg/SVGAnimateTransformElement.cpp: (WebCore::SVGAnimateTransformElement::storeInitialValue): (WebCore::SVGAnimateTransformElement::resetValues): (WebCore::SVGAnimateTransformElement::updateCurrentValue): (WebCore::SVGAnimateTransformElement::handleStartCondition): (WebCore::SVGAnimateTransformElement::applyAnimationToValue): (WebCore::SVGAnimateTransformElement::parseTransformValue):
  • ksvg2/svg/SVGAnimateTransformElement.h:
  • ksvg2/svg/SVGLinearGradientElement.cpp: (WebCore::SVGLinearGradientElement::collectGradientProperties):
  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::collectPatternProperties):
  • ksvg2/svg/SVGRadialGradientElement.cpp: (WebCore::SVGRadialGradientElement::collectGradientProperties):
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::createSVGTransform): (WebCore::SVGSVGElement::createSVGTransformFromMatrix):
  • ksvg2/svg/SVGSVGElement.h:
  • ksvg2/svg/SVGStyledTransformableElement.cpp: (WebCore::SVGStyledTransformableElement::updateLocalTransform):
  • ksvg2/svg/SVGTextElement.cpp: (WebCore::SVGTextElement::updateLocalTransform):
  • ksvg2/svg/SVGTransform.cpp: (SVGTransform::SVGTransform): (SVGTransform::isValid):
  • ksvg2/svg/SVGTransform.h:
  • ksvg2/svg/SVGTransform.idl:
  • ksvg2/svg/SVGTransformList.cpp: (SVGTransformList::SVGTransformList): (SVGTransformList::createSVGTransformFromMatrix): (SVGTransformList::consolidate): (SVGTransformList::concatenate):
  • ksvg2/svg/SVGTransformList.h:
  • ksvg2/svg/SVGTransformable.cpp: (WebCore::SVGTransformable::parseTransformAttribute):
9:12 AM Changeset in webkit [19077] by brmorris
  • 2 edits in S60/trunk/WebCore

bujtas <​zbujtas@gmail.com>

Reviewed by Darin.
DESC: 'index' variable is not declared, change it to 'start'
​http://bugs.webkit.org/show_bug.cgi?id=12378

  • kwq/KWQString.cpp: (QString::mid):
5:09 AM Changeset in webkit [19076] by lars
  • 9 edits in trunk

Reviewed by Zack

WebKitQt:
Implement some bits and pieces required by the loader.
Fixes quite a few crashes and hangs in the lyout tests

DumpRenderTree:
Add a signal handler, always dump immediately if we get an
error during a page load and raise the timeout to 5 seconds
(as we get a lot less such failures now)

3:04 AM Changeset in webkit [19075] by bdash
  • 4 edits in trunk/WebCore

2007-01-24 Mark Rowe <​mrowe@apple.com>

Reviewed by Eric.

Plug another bunch of SVG memory leaks.

  • ksvg2/misc/SVGDocumentExtensions.cpp: (WebCore::SVGDocumentExtensions::~SVGDocumentExtensions): Delete memory we have allocated. (WebCore::SVGDocumentExtensions::removePendingResource): Return an auto_ptr to show that we are transferring ownership.
  • ksvg2/misc/SVGDocumentExtensions.h:
  • ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::insertedIntoDocument): Update for use of auto_ptr.
12:42 AM Changeset in webkit [22826] by beidson
  • 1 edit in branches/WindowsMerge/WebKitWin/DefaultDownloadDelegate.cpp

Build Fix

Jan 23, 2007:

11:43 PM Changeset in webkit [22825] by beidson
  • 16 edits
    6 adds in branches/WindowsMerge

Initial checkin of downloads for boomer

11:05 PM Changeset in webkit [19074] by lars
  • 3 edits in trunk/WebKitQt

Fix compilation again.

10:26 PM Changeset in webkit [22824] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin
10:16 PM Changeset in webkit [19073] by bdash
  • 4 edits in trunk/WebCore

2007-01-23 Mark Rowe <​mrowe@apple.com>

Reviewed by Brady.

Plug thousands of node leaks seen running layout tests.

  • ksvg2/svg/SVGElementInstance.cpp: (WebCore::SVGElementInstance::~SVGElementInstance): Disassociate ourselves from our children so they will be destroyed if we were the only thing referencing them.
  • ksvg2/svg/SVGUseElement.cpp: (WebCore::SVGUseElement::removedFromDocument):
  • ksvg2/svg/SVGUseElement.h:
9:43 PM Changeset in webkit [22823] by aliceli1
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Brady.

Fixed <rdar://4949278> cut/copy/paste not working in subframes

  • WebView.cpp: (WebView::cutEnabled): (WebView::copyEnabled): (WebView::pasteEnabled): (WebView::deleteEnabled): (WebView::editingEnabled): (WebView::deleteSelection): (WebView::copy): (WebView::cut): (WebView::paste): (WebView::copyURL): (WebView::delete_): get the focusedOrMainFrame() instead of mainFrame()
9:33 PM Changeset in webkit [19072] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Brady.

  • editing/Editor.cpp: (WebCore::Editor::appliedEditing): minor change. removing unnecessary call to frame to fetch editor
9:08 PM Changeset in webkit [19071] by aliceli1
  • 2 edits in trunk/JavaScriptCore

release build fix

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Copy APICasts.h
7:44 PM Changeset in webkit [19070] by bdash
  • 5 edits
    6 adds in trunk

2007-01-23 Mark Rowe <​mrowe@apple.com>

Reviewed by Adele.

​http://bugs.webkit.org/show_bug.cgi?id=12375
Bug 12375: REGRESSION(r19038): fast/dom/title-text-property-2.html failing

Fix regression by making setTitle/updateTitle/removeTitle logic match document.title
specification at ​http://whatwg.org/specs/web-apps/current-work/#the-title1.

  • dom/Document.cpp: (WebCore::Document::setTitle): Materialize a title element into the head if one doesn't exist when setting document.title. Also update the contents of the title element when the title is set via document.title. (WebCore::Document::removeTitle): Update the title based on first title element in the head, if one exists. (WebCore::Document::head): Convenience method to retrieve the head element in an HTML document.
  • dom/Document.h:

2007-01-23 Mark Rowe <​mrowe@apple.com>

Reviewed by Adele.

Layout tests for ​http://bugs.webkit.org/show_bug.cgi?id=12375
Bug 12375: REGRESSION(r19038): fast/dom/title-text-property-2.html failing

  • fast/dom/Document/title-property-creates-title-element-expected.txt: Added.
  • fast/dom/Document/title-property-creates-title-element.html: Added.
  • fast/dom/Document/title-property-set-multiple-times-expected.txt: Added.
  • fast/dom/Document/title-property-set-multiple-times.html: Added.
  • fast/dom/title-text-property-2.html: Remove in reverse order to preserve test behaviour when removing title elements.
  • svg/custom/multiple-title-elements.svg: Added.
6:16 PM Changeset in webkit [19069] by adele
  • 3 edits in trunk/WebKit

Reviewed by Adam.

Fixed 2 layout tests that I broke with my last checkin.

  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeyPress): Use the selected frame to get the WebHTMLView.
  • WebView/WebHTMLView.mm: (-[WebHTMLView performKeyEquivalent:]): Added global to keep track of NSEvent used here. (-[WebHTMLView _interceptEditingKeyEvent:]): Check NSEvent against the event used in performKeyEquivalent. We don't want to intercept these events.
5:24 PM Changeset in webkit [19068] by ggaren
  • 2 edits in trunk/JavaScriptCore

build fix

4:17 PM Changeset in webkit [19067] by bdash
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Fix typo.

4:17 PM Changeset in webkit [19066] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-01-24 Mark Rowe <​mrowe@apple.com>

Build fix for DumpRenderTree.

  • JavaScriptCore.xcodeproj/project.pbxproj: Make JSStringRefCF.h public so it's copied into build framework.
3:38 PM Changeset in webkit [19065] by bdakin
  • 7 edits in trunk

WebCore:

Reviewed by Hyatt.

Follow-up to the fix below for 4843226.

  • rendering/RenderLayer.cpp: (WebCore::transparencyClipBox): Has to be recursive or we will miss out on grandchildren!

LayoutTests:

Reviewed by Hyatt.

Updated test for 4843226 to include a grandchild.

  • fast/clip/nestedTransparencyClip-expected.checksum:
  • fast/clip/nestedTransparencyClip-expected.png:
  • fast/clip/nestedTransparencyClip-expected.txt:
  • fast/clip/nestedTransparencyClip.html:
3:37 PM Changeset in webkit [22822] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

3:27 PM Changeset in webkit [19064] by sfalken
  • 1 copy in tags/Safari-521.32.14b

New tag.

3:23 PM Changeset in webkit [19063] by oliver
  • 2 edits in trunk/WebCore

2007-01-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Fixes dropping of files into safari

  • page/DragController.cpp: (WebCore::DragController::performDrag):
3:11 PM Changeset in webkit [22821] by aliceli1
  • 2 edits in branches/WindowsMerge/WebKitWin

Fix for <rdar://49233536> shift-pageup in textareas
This fix is pretty much identical to the shift-backspace
one I just did, so I'm piggybacking on that review.

3:06 PM Changeset in webkit [22820] by andersca
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin.

<rdar://problem/4919754>
Boomer freezes after attempt to play video.


  • plugins/win/PluginStreamWin.cpp: Change WebReasonNone to -2, some plugins return -1 to indicate error.


(WebCore::PluginStreamWin::stop):
Just don't clear the loader, stop loading as well.


(WebCore::PluginStreamWin::startStream):
Destroy the stream if newstream returns an error.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::performRequest): If the call to toString throws an exception, clear it.

WebKitWin:

Reviewed by Darin.

<rdar://problem/4919754>
Boomer freezes after attempt to play video.


  • Interfaces/IWebError.idl: Add error code.


  • WebFrame.cpp: (WebFrame::redirectDataToPlugin): Cancel loading the main resource.


(WebFrame::windowObjectCleared):
Use toRef.

2:47 PM Changeset in webkit [19062] by andersca
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Copy APICasts.h
2:47 PM Changeset in webkit [19061] by justing
  • 1 edit
    4 adds in trunk/LayoutTests

Reviewed by john


<rdar://problem/4947130>
REGRESSION: Items duplicated when moved inside contenteditable element (11766)

  • editing/pasteboard/4947130-expected.checksum: Added.
  • editing/pasteboard/4947130-expected.png: Added.
  • editing/pasteboard/4947130-expected.txt: Added.
  • editing/pasteboard/4947130.html: Added.
2:39 PM Changeset in webkit [22819] by aliceli1
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed Maciej.

fixed <rdar://4923536> pressing shift-backspace inserts a bad character

  • WebView.cpp: added to keyEntries an entry for the commands accounting for modifiers
2:36 PM Changeset in webkit [22818] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2007-01-23 Steve Falkenburg <​sfalken@apple.com>

Fix release build.

  • WebCore.vcproj/WebCore.vcproj:
2:32 PM Changeset in webkit [19060] by beidson
  • 3 edits in trunk/WebCore

Reviewed by Darin

Added a couple of CF things previously missed

2:23 PM Changeset in webkit [19059] by ggaren
  • 7 edits
    2 adds in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.


Fixed <rdar://problem/4885131> Move CFString function declarations from
JSStringRef.h to JSStringRefCF.h


Also removed remaining API FIXMEs and changed them into Radars.

  • API/JSClassRef.cpp: (OpaqueJSClass::OpaqueJSClass): Added Radar numbers for UTF8 conversion.
  • API/JSContextRef.cpp: (JSGlobalContextCreate): Replaced FIXME for NULL JSContextRef with Radar number.
  • API/JSObjectRef.h: Removed FIXME, which is unprofessional in a public header.
  • API/JSStringRef.cpp: Moved CF related implementations to JSStringRefCF.cpp. (JSStringCreateWithUTF8CString): Replaced FIXME with Radar number.
  • API/JSStringRef.h: Moved CF related declarations to JSStringRefCF.h. Added #include of JSStringRefCF.h as a stopgap until clients start #including it as needed by themselves.
  • API/JSStringRefCF.cpp: Added. (JSStringCreateWithCFString): (JSStringCopyCFString): Replaced JSChar cast with UniChar cast, which is more appropriate for a CF call.
  • API/JSStringRefCF.h: Added.
  • JavaScriptCore.xcodeproj/project.pbxproj:
2:11 PM Changeset in webkit [19058] by zimmermann
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

Fix evil genericContext() assertion, which occours sometimes when running DRT.
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12379

1:52 PM Changeset in webkit [19057] by brmorris
  • 2 edits in S60/trunk/WebKit

ssareen <​shyam.sareen@nokia.com>

Reviewed by Sachin/Brad.


DESC: Invalid WAP CSS formats not being ignored ( TSW ID: TMCN-6S5K87)
​http://bugs.webkit.org/show_bug.cgi?id=12230

  • BrowserCore/Formcontrols/src/FControlformathandler.cpp: (CInputFormatHandler::ConstructL):
1:50 PM Changeset in webkit [22817] by adele
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adam.

Added call to paintThemeTextArea.

1:45 PM Changeset in webkit [19056] by bdakin
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/4843226> REGRESSION: Pull down menu appears
clipped at ​http://istweb.apple.com/

  • rendering/RenderLayer.cpp: (WebCore::transparencyClipBox): Always unite with sibling rects.

LayoutTests:

Reviewed by Hyatt.

Test for <rdar://problem/4843226> REGRESSION: Pull down menu
appears clipped at ​http://istweb.apple.com/

  • fast/clip/nestedTransparencyClip-expected.checksum: Added.
  • fast/clip/nestedTransparencyClip-expected.png: Added.
  • fast/clip/nestedTransparencyClip-expected.txt: Added.
  • fast/clip/nestedTransparencyClip.html: Added.
1:10 PM Changeset in webkit [19055] by justing
  • 4 edits
    6 adds in trunk

LayoutTests:

Reviewed by john


<rdar://problem/4920742>
REGRESSION: GMail Editor: Attempting to remove formatting from selection results in a crash at WebCore::Range::checkDeleteEx

WebCore:

Reviewed by john

<rdar://problem/4920742>
REGRESSION: GMail Editor: Attempting to remove formatting from selection results in a crash at WebCore::Range::checkDeleteExtract()

  • dom/Range.cpp: (WebCore::Range::checkDeleteExtract): Return if there is no commonAncestor container or if commonAncestorContainer() throws an exception.
  • editing/Editor.cpp: (WebCore::Editor::removeFormattingAndStyle): Fixed a bug that reversed the order of the selected paragraphs.
12:55 PM Changeset in webkit [19054] by brmorris
  • 3 edits in S60/trunk/WebKit

sareen <​shyam.sareen@nokia.com>

Reviewed by Sachin Padma.
DESC: WAP CSS specific character format causing phone keypad input error ( TSW ID: TMCN-6S5MSE)
​http://bugs.webkit.org/show_bug.cgi?id=12232

12:31 PM Changeset in webkit [19053] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

raalexan

Reviewed by Sachin
DESC: MLIO-6XLCE4 Returning from page overview shows the toolbar
​http://bugs.webkit.org/show_bug.cgi?id=id=12366

  • BrowserView/src/KeyEventHandler.cpp: (CKeyEventHandler::HandleActivateKeysL):
12:21 PM Changeset in webkit [19052] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

w3liu <​wei.liu@nokia.com>

Reviewed by Zalan, landed by Brad.
DESC: [S60] PYAN-6MUSWV: OSS browser can not display Chinese characters correctly with selected web sites
​http://bugzilla.opendarwin.org/show_bug.cgi?id=12371

12:19 PM Changeset in webkit [19051] by brmorris
  • 2 edits in S60/trunk/WebCore

w3liu <​wei.liu@nokia.com>

Reviewed by Zalan, landed by brad.
DESC: [S60] PYAN-6MUSWV: OSS browser can not display Chinese characters correctly with selected web sites

​http://bugs.webkit.org/show_bug.cgi?id=12371

12:04 PM Changeset in webkit [19050] by zimmermann
  • 25 edits
    64 adds in trunk

Reviewed by Sam.

Fix dynamic creation/updates of markers, masks, clipPaths, and several tiny pattern issues.
Added 16 (!) new layout tests covering quite some weird scenerios - Batik & Opera do have problems, we don't.

11:48 AM Changeset in webkit [22816] by adele
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Darin.


Reorganized some event handling code for keyPress events to
prepare for another fix.


  • WebEditorClient.cpp: (WebEditorClient::handleKeyPress): Added.
  • WebEditorClient.h: Removed unnecessary forward declarations.
11:37 AM Changeset in webkit [19049] by adele
  • 21 edits in trunk

WebCore:

Reviewed by Darin.


WebCore part of fix for <rdar://problem/4946753>REGRESSION: Inserting tabs is broken in Mail

In addition to this fix, I also reorganized some event handling code for keyPress events to
prepare for another fix. There's also just a little bit of unrelated cleanup.


  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Move tab focus behavior into new defaultKeyboardEventHandler method.


  • bridge/EditorClient.h: Added handleKeyPress.
  • editing/Editor.cpp: (WebCore::Editor::handleKeyPress): Added. Calls over to the client method. (WebCore::Editor::deleteRange): Removed unnecessary propogateDOMException.
  • editing/Editor.h: Added handleKeyPress. (WebCore::Editor::addToKillRing): Formatting cleanup.
  • editing/mac/EditorMac.mm: Removed unnecessary propogateDOMException.


  • page/EventHandler.cpp: (WebCore::EventHandler::defaultKeyboardEventHandler): Added. Checks the tabKeyCyclesThroughElements setting before advancing focus for tab key events. Calls handleKeyPress.
  • page/EventHandler.h: Added defaultKeyboardEventHandler.


  • page/Page.cpp: (WebCore::Page::Page): Initialize m_tabKeyCyclesThroughElements to true.
  • page/Page.h: Added m_tabKeyCyclesThroughElements. (WebCore::Page::setTabKeyCyclesThroughElements): Added. (WebCore::Page::tabKeyCyclesThroughElements): Added.


  • platform/PlatformKeyboardEvent.h: Added ability to get NSEvent from PlatformKeyboardEvent.
  • platform/mac/KeyEventMac.mm: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Initialize m_macEvent to the NSEvent.


  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyEditorClient::handleKeyPress): Added.

WebKit:

Reviewed by Darin.

WebKit part of fix for <rdar://problem/4946753>REGRESSION: Inserting tabs is broken in Mail


In addition to this fix, I also reorganized some event handling code for keyPress events to
prepare for another fix.

  • WebCoreSupport/WebEditorClient.h: Added handleKeyPress method.
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::handleKeyPress): Added. Code moved from WebHTMLView keyDown method. This is called from the defaultEventHandler so that in the future, we can make the right decision about which selection the keyPress should apply to.
  • WebView/WebHTMLView.mm: (-[WebHTMLView keyDown:]): Moved _interceptEditingKeyEvent call to handleKeyPress. (-[WebHTMLView _interceptEditingKeyEvent:]): Prevents intercepting keys for cmd-modified events. Removed tabCycling checks since this is now handled in WebCore.
  • WebView/WebHTMLViewInternal.h: Made _interceptEditingKeyEvent SPI.
  • WebView/WebView.mm: Use new tabKeyCyclesThroughElements methods on the page. (-[WebViewPrivate init]): ditto. (-[WebView setTabKeyCyclesThroughElements:]): ditto. (-[WebView tabKeyCyclesThroughElements]): ditto. (-[WebView setEditable:]): ditto
10:36 AM Changeset in webkit [19048] by staikos
  • 2 edits in trunk

Temporary measure to make it possible to use the Qt port until the official Qt
API is done

10:24 AM Changeset in webkit [22815] by andersca
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Build fixes.


  • WebCore.vcproj/WebCore.vcproj: Copy plugin and JS headers.


  • loader/win/FrameLoaderWin.cpp: Move functions to WebKitWin.

WebKitWin:

Build fixes.


  • WebFrame.cpp: (WebFrame::createFrame): (WebFrame::createPlugin): (WebFrame::redirectDataToPlugin): (WebFrame::createJavaAppletWidget): (WebFrame::objectContentType): (WebFrame::overrideMediaType): (WebFrame::windowObjectCleared):
  • WebFrame.h: Move functions here from WebFrameLoaderWin in WebCore.
10:18 AM Changeset in webkit [19047] by staikos
  • 2 edits in trunk/WebCore

Compile with a released Qt.

8:35 AM Changeset in webkit [19046] by lars
  • 6 edits in trunk

Reviewed by Zack

Widget and ScrollView do not own the Qt widgets
anymore. Make sure they can handle the case of
a null QWidget and never delete them.

Fix refcounting of FrameViews (they get created with a
refcount of 1) and add a few safety checks to the
FrameLoaderClientQt.

6:35 AM Changeset in webkit [19045] by zack
  • 2 edits in trunk/WebCore

Forgot to add this file to the build (fix the build for real)

5:39 AM Changeset in webkit [19044] by zack
  • 4 edits in trunk/WebKitQt

Adjust the DragClient to latest changes.

2:32 AM Changeset in webkit [19043] by zack
  • 8 edits in trunk

Fix the Qt build

2:28 AM Changeset in webkit [19042] by lars
  • 25 edits
    2 deletes in trunk

Reviewed by Maciej

Make the last remaining pieces of the FrameLoader platform
independent. Move most of the code over to WebFrameLoaderClient.
Some smaller cleanups in the WebFrameBridge, and moved some
platform independent functionality over to the shared code
in WebCore.

Add support for Frames to the Qt build and fix some issues
in the API classes.

1:33 AM Changeset in webkit [22814] by oliver
  • 11 edits
    4 adds in branches/WindowsMerge

2007-01-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.


WebKitWin:

Attaching the DragController logic to the WebView

  • Interfaces/IWebUIDelegate.idl: Fixed a couple of function definitions to use IDataObject instead of IDropSource
  • WebDragClient.cpp: Added. (WebDragClient::WebDragClient): (WebDragClient::actionMaskForDrag): (WebDragClient::willPerformDragDestinationAction):
  • WebDragClient.h: Added. DragClient implementation.
  • WebKit.vcproj/WebKit.vcproj:
  • WebView.cpp: (WebView::WebView): (WebView::initWithFrame): (dragOperationToDragCursor): (keyStateToDragOperation): (WebView::DragEnter): (WebView::DragOver): (WebView::DragLeave): (WebView::Drop): Set up and register WebView as an IDropTarget, and pass off drag events to the DragController
  • WebView.h: Ditto


WebCoreWin:

  • WebCore.vcproj/WebCore.vcproj:
  • page/win/DragControllerWin.cpp: Added. (WebCore::DragController::dragOperation): (WebCore::DragController::isCopyKeyDown): Platform specific implementation
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::ClipboardWin): (WebCore::ClipboardWin::isForDragging):
  • platform/win/ClipboardWin.h: Migrated common Clipboard functionality from ClipboardMac/Win -> Clipboard
  • platform/win/DragDataWin.cpp: Added. (WebCore::DragData::createClipboard): (WebCore::urlWFormat): (WebCore::urlFormat): (WebCore::filenameWFormat): (WebCore::filenameFormat): (WebCore::plainTextFormat): (WebCore::plainTextWFormat): (WebCore::DragData::containsURL): (WebCore::extractURL): (WebCore::DragData::asURL): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::texthtmlFormat): (WebCore::htmlFormat): (WebCore::containsHTML): (WebCore::fragmentFromHTML): (WebCore::containsFilenames): (WebCore::fragmentFromFilenames): (WebCore::DragData::containsColor): (WebCore::DragData::canSmartReplace): (WebCore::DragData::containsCompatibleContent): (WebCore::DragData::asFragment): (WebCore::DragData::asColor): Implementation of DragData accesor methods, and helper functions
  • platform/win/EditorWin.cpp: (WebCore::Editor::newGeneralClipboard): Updated for new ClipboardWin constructor
  • platform/win/PasteboardWin.cpp: (WebCore::fragmentFromCF_HTML): (WebCore::Pasteboard::documentFragment): Pulled out CF_HTML parsing to a seperate function so logic can be shared with DragDataWin


1:15 AM Changeset in webkit [19041] by oliver
  • 2 edits
    2 adds in trunk/WebKitQt

2007-01-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Qt build stubs for Drop logic

  • WebCoreSupport/DragClientQt.cpp: Added. (WebCore::DragClientQt::actionMaskForDrag): (WebCore::DragClientQt::willPerformDragDestinationAction):
  • WebCoreSupport/DragClientQt.h: Added.
  • WebKitPart/WebKitPart.cpp: (WebKitPart::initView):
1:14 AM Changeset in webkit [19040] by oliver
  • 9 edits
    4 adds in trunk/WebKit

2007-01-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Drop logic bindings for WebKit

  • WebCoreSupport/WebDragClient.h: Added.
  • WebCoreSupport/WebDragClient.mm: Added. (WebDragClient::WebDragClient): (WebDragClient::actionMaskForDrag): (WebDragClient::willPerformDragDestinationAction): Standard client impl
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): Updated to use DragController to track drag state


  • WebCoreSupport/WebPasteboardHelper.h: Added. (WebPasteboardHelper::WebPasteboardHelper): A *temporary* Helper class to access NSPasteboard access and manipulation functions present in WebKit
  • WebCoreSupport/WebPasteboardHelper.mm: Added. (WebPasteboardHelper::urlFromPasteboard): (WebPasteboardHelper::plainTextFromPasteboard): (WebPasteboardHelper::fragmentFromPasteboard): (WebPasteboardHelper::insertablePasteboardTypes): See header comment
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebDocumentInternal.h: Remove unnecessary protocol
  • WebView/WebFrameView.mm: (-[WebFrameView _setDocumentView:]): Updating to use DragController to track drag state
  • WebView/WebHTMLView.mm: (-[WebHTMLView _startDraggingImage:at:operation:event:sourceIsDHTML:DHTMLWroteData:]): ditto (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): ditto (-[WebHTMLView draggingSourceOperationMaskForLocal:]): ditto (-[WebHTMLView draggedImage:endedAt:operation:]): ditto (-[WebHTMLView _documentFragmentForPasteboard:]): Helper method to generate DocumentFragment from NSPasteboard without regressing (-[WebHTMLView _canProcessDragWithDraggingInfo:]): Updating to use DragController to track drag state (-[WebHTMLView _isMoveDrag:]): (-[WebHTMLView _isNSColorDrag:]):
  • WebView/WebHTMLViewInternal.h: Removing unnecessary fields and methods
  • WebView/WebView.mm: (-[WebViewPrivate dealloc]): Remove obsolete ASSERT (-[WebView _setInitiatedDrag:]): Now passes directly through to DragController (-[WebView _commonInitializationWithFrameName:groupName:]): (-[WebView _loadingDragOperationForDraggingInfo:]): Removed (-[WebView draggingEntered:]): Updated to use DragController (-[WebView draggingUpdated:]): ditto (-[WebView draggingExited:]): ditto (-[WebView performDragOperation:]): ditto (-[WebView _hitTest:dragTypes:]):
  • WebView/WebViewInternal.h: remove unnecessary method def
1:12 AM Changeset in webkit [19039] by oliver
  • 17 edits
    12 adds in trunk/WebCore

2007-01-23 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Added DragController to handled drag and drop state and control logic.
Currently this only handles logic for Dragging and Dropping, and is
unable to initialise a drag itself.

platform/DragData encapsulate the paltform Drag data (NSDraggingInfo on Mac,
QMimeType in Qt). This provides methods to pull data out the drag data as a String,
a URL, a DocumentFragment (for rich content), or a Colour.

  • WebCore.exp:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Clipboard.cpp: Added. (WebCore::Clipboard::setAccessPolicy): (WebCore::dragOpFromIEOp): (WebCore::IEOpFromDragOp): (WebCore::Clipboard::sourceOperation): (WebCore::Clipboard::destinationOperation): (WebCore::Clipboard::setSourceOperation): (WebCore::Clipboard::setDestinationOperation): (WebCore::Clipboard::setDropEffect): (WebCore::Clipboard::setEffectAllowed): move platform independent functions from ClipboardMac to Clipboard
  • dom/Clipboard.h: (WebCore::Clipboard::Clipboard): (WebCore::Clipboard::dropEffect): (WebCore::Clipboard::effectAllowed): (WebCore::Clipboard::policy): as above -- also removed virtual modifier from now platform independent methods
  • editing/Editor.cpp: (WebCore::Editor::smartInsertDeleteEnabled): (WebCore::Editor::shouldApplyStyle):
  • editing/Editor.h: adding calls through to EditorClient


  • page/DragActions.h: Added. (WebCore::): Replicates a number of NS* enums in the WebCore namespace
  • page/DragClient.h: Added. (WebCore::DragClient::~DragClient): Standard client interface for dragging UIDelegate
  • page/DragController.cpp: Added. (WebCore::createMouseEvent): (WebCore::DragController::DragController): (WebCore::DragController::~DragController): (WebCore::documentFragmentFromDragData): (WebCore::DragController::isMoveDrag): (WebCore::visiblePositionForPoint): (WebCore::DragController::cancelDrag): (WebCore::documentAtPoint): (WebCore::DragController::dragEntered): (WebCore::DragController::dragExited): (WebCore::DragController::dragUpdated): (WebCore::DragController::performDrag): (WebCore::DragController::dragEnteredOrUpdated): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::operationForLoad): (WebCore::DragController::concludeDrag): (WebCore::DragController::canProcessDrag): (WebCore::DragController::tryDHTMLDrag): Class to handle state and logic for dragging and dropping
  • page/DragController.h: Added. (WebCore::DragController::client): (WebCore::DragController::didInitiateDrag): (WebCore::DragController::isHandlingDrag): (WebCore::DragController::dragOperation): (WebCore::DragController::document): (WebCore::DragController::dragInitiator): (WebCore::DragController::dragDestinationAction): (WebCore::DragController::dragSourceAction): (WebCore::DragController::dragEnded): (WebCore::DragController::setIsHandlingDrag): (WebCore::DragController::setDidInitiateDrag): (WebCore::DragController::setDragOperation): (WebCore::DragController::setDragSourceAction): (WebCore::DragController::setDragInitiator): See above
  • page/Page.cpp: (WebCore::Page::Page): Update Page to have DragController
  • page/Page.h: (WebCore::Page::dragController): ditto
  • page/mac/DragControllerMac.mm: Added. (WebCore::DragController::isCopyKeyDown): (WebCore::DragController::dragOperation): Platform specific portions of the DragController
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::dragSourceEndedAt): Convert from NSDragOperation to WebCore::DragOperation
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm: Remove obsolete Drag functions
  • page/qt/DragControllerQt.cpp: Added. (WebCore::DragController::isCopyKeyDown): (WebCore::DragController::dragOperation): Basic stubs to maintain Qt build
  • platform/DragData.cpp: Added. (WebCore::DragData::DragData):
  • platform/DragData.h: Added. (WebCore::DragData::clientPosition): (WebCore::DragData::globalPosition): (WebCore::DragData::platformData): (WebCore::DragData::draggingSourceOperationMask): DragData class to encapsulate platform drag data/event
  • platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::setData): Addition of dummy DragClient
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyDragClient::~SVGEmptyDragClient): (WebCore::SVGEmptyDragClient::willPerformDragDestinationAction): (WebCore::SVGEmptyDragClient::actionMaskForDrag): (WebCore::SVGEmptyDragClient::dragControllerDestroyed): ditto
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::ClipboardMac): (WebCore::ClipboardMac::clearData): (WebCore::ClipboardMac::clearAllData): (WebCore::ClipboardMac::getData): (WebCore::ClipboardMac::setData): (WebCore::ClipboardMac::types): (WebCore::ClipboardMac::setDragImage): Moving platform independent logic to Clipboard, and updating platform specific methods to use appropriate accessors rather than directly manipulating data they no longer own
  • platform/mac/DragDataMac.mm: Added. (WebCore::DragData::DragData): (WebCore::DragData::canSmartReplace): (WebCore::DragData::containsColor): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::asColor): (WebCore::DragData::createClipboard): (WebCore::imageExistsAtPaths): (WebCore::DragData::containsCompatibleContent): (WebCore::DragData::containsURL): (WebCore::DragData::asURL): (WebCore::DragData::asFragment): Mac implementations of DragData methods. A number of these use a Helper class that accesses WebKit functionality. That functionality should be migrated to WebCore in the future.
  • platform/mac/PasteboardHelper.h: Added. (WebCore::PasteboardHelper::~PasteboardHelper): Temporary, and Mac only, helper class to access WebKit functionality from WebCore
  • platform/qt/DragDataQt.cpp: Added. (WebCore::DragData::canSmartReplace): (WebCore::DragData::containsColor): (WebCore::DragData::containsPlainText): (WebCore::DragData::asPlainText): (WebCore::DragData::asColor): (WebCore::DragData::createClipboard): (WebCore::DragData::containsCompatibleContent): (WebCore::DragData::containsURL): (WebCore::DragData::asURL): (WebCore::DragData::asFragment): Basic stubs to maintain Qt build
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::HitTestResult): Correct HitTestResult copy contructor to copy localPoint

Jan 22, 2007:

11:00 PM Changeset in webkit [22813] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adele.

Implemented search field painting, and did some cleanup.

8:00 PM Changeset in webkit [19038] by bdash
  • 2 edits in trunk/WebCore

2007-01-22 Mark Rowe <​mrowe@apple.com>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=11692
Bug 11692: REGRESSION(r17352): Disappearing page title

  • dom/Document.cpp: (WebCore::Document::setTitle): If the title has already been set explicitly via JavaScript, ignore any changes to it due to encountering <title> tags.
6:23 PM Changeset in webkit [22812] by andersca
  • 6 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.


<rdar://problem/4771115>
Windows Media Player plugin crashes.

  • WebCore.vcproj/WebCore.vcproj: Formatting changes.


  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::defaultPluginPaths): Add Windows Media Player path.


  • plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::sendJavaScriptStream):
  • plugins/win/PluginStreamWin.h: New function which sends a JavaScript result stream and handles any errors that the plug-in returns.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setFrameGeometry): Always call NPP_SetWindow, some plugins (like WMP) relies on it.


(WebCore::PluginViewWin::performRequest):
If a plug-in requests a javascript: URL that doesn't evaluate to a string, call toString on it.
The Windows Media Player plugin calls javascript:document.location and expects to get the location back.

5:36 PM Changeset in webkit [19037] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/forms/listbox-selection-2-expected.checksum: Added.
  • fast/forms/listbox-selection-2-expected.png: Added.
  • fast/forms/listbox-selection-2-expected.txt: Added.
  • fast/forms/listbox-selection-2.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/listbox-selection-2.html

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::numVisibleItems): Changed height() to contentHeight() since items are visible only in the content box. (WebCore::RenderListBox::listIndexAtOffset): Adjusted for vertical padding and borders. Changed to return -1 instead of the last item's index if the given offset is below the last item. (WebCore::RenderListBox::autoscroll): Adjusted for vertical padding and borders. (WebCore::RenderListBox::controlClipRect): Changed to return the content box since items should not spill into the padding box. This change is the reason the test generates pixel results.
5:30 PM Changeset in webkit [19036] by justing
  • 15 edits
    11 adds in trunk

LayoutTests:

Reviewed by darin

<rdar://problem/4944770>
editing/pasteboard/4641033 layout test is broken (12328)

The fixes not only make this test pass, but also fix a bug that
was reflected in the results checked in for this test. The caret
was in the wrong position:

  • editing/pasteboard/4641033-expected.checksum:
  • editing/pasteboard/4641033-expected.png:
  • editing/pasteboard/4641033-expected.txt: Added:
  • editing/pasteboard/4944770-1-expected.checksum: Added.
  • editing/pasteboard/4944770-1-expected.png: Added.
  • editing/pasteboard/4944770-1-expected.txt: Added.
  • editing/pasteboard/4944770-1.html: Added.
  • editing/pasteboard/4944770-2-expected.checksum: Added.
  • editing/pasteboard/4944770-2-expected.png: Added.
  • editing/pasteboard/4944770-2-expected.txt: Added.
  • editing/pasteboard/4944770-2.html: Added.
  • editing/pasteboard/4944770-expected.checksum: Added.
  • editing/pasteboard/4944770-expected.png: Added.
  • editing/pasteboard/4944770-expected.txt: Added. Equivalent render trees:
  • editing/execCommand/format-block-from-range-selection-expected.txt:
  • editing/pasteboard/drag-drop-modifies-page-expected.txt: Fixed:
  • editing/pasteboard/nested-blocks-with-text-area-expected.checksum:
  • editing/pasteboard/nested-blocks-with-text-area-expected.png:
  • editing/pasteboard/nested-blocks-with-text-area-expected.txt:
  • editing/pasteboard/nested-blocks-with-text-field-expected.checksum:
  • editing/pasteboard/nested-blocks-with-text-field-expected.png:
  • editing/pasteboard/nested-blocks-with-text-field-expected.txt:

WebCore:

Reviewed by darin


<rdar://problem/4944770>
editing/pasteboard/4641033 layout test is broken (12328)


This layout test failure demonstrates three bugs:
Smart replace shouldn't be turned on, but is because a word
selection granularity from the previous test isn't cleared.
Smart replace shouldn't add any spaces because the paste is performed
in an empty paragraph.
Smart replace spaces are added to the text of options inside
the select element instead of before/after the select element.


This patch fixes the second two problems. During a
ReplaceSelectionCommand, the VisiblePosition for the end of
the inserted content is the last position in the last leaf
inserted. This is a problem when the last leaf is inside a
select element, since VP creation is inconsistent there.
Second, smart spaces were inserted inside the last leaf, not
at the endOfInsertedContent.

  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMergeStart): Renamed m_lastNodeInserted to m_lastLeafInserted. Use the start/endOfInsertedContent getters. (WebCore::ReplaceSelectionCommand::shouldMergeEnd): Ditto. (WebCore::ReplaceSelectionCommand::removeNodePreservingChildren): Ditto. (WebCore::ReplaceSelectionCommand::removeRedundantStyles): Ditto. (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent): Added. Special case for when the last leaf inserted is inside a select element: return the VisiblePosition after the select element. (WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent): Added. (WebCore::ReplaceSelectionCommand::doApply): Did renaming. Used the start/endOfInsertedContent getters. Insert smart replace spaces into the right nodes. (WebCore::ReplaceSelectionCommand::shouldRemoveEndBR): Renaming. (WebCore::ReplaceSelectionCommand::completeHTMLReplacement): Ditto. (WebCore::ReplaceSelectionCommand::updateNodesInserted): Ditto.
  • editing/ReplaceSelectionCommand.h:
4:51 PM Changeset in webkit [22811] by darin
  • 3 edits in branches/WindowsMerge/WebCore
  • WebCore.vcproj/WebCore.vcproj: Added FileChooser.cpp.
  • platform/win/FileChooserWin.cpp: Removed many now-unneeded functions. (WebCore::FileChooser::FileChooser): Updated for changed parameters and members. (WebCore::FileChooser::openFileChooser): Changed to take document parmaeter and find the FrameView from that instead of the upload control. (WebCore::FileChooser::basenameForWidth): Added ignored Font parameter.
4:46 PM Changeset in webkit [22810] by aroben
  • 9 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Anders, Brady, and Steve.

WebKit part of <rdar://problem/4601321> HTTP Authentication Alerts

Made WebURLCredential use a registered CLSID so the app can get instantiate it:

  • Interfaces/IWebURLAuthenticationChallenge.idl: Changed method name.
  • Interfaces/WebKit.idl: Added GUIDs for WebURLCredential.
  • WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance): Added case for WebURLCredential.
  • WebKitDLL.cpp: Added WebURLCredential and WebError (it was omitted from r11821). (DllGetClassObject):
  • WebURLAuthenticationChallenge.cpp: (WebURLAuthenticationChallenge::initWithProtectionSpace): Changed to use CLSID, and return the failing HRESULT. (WebURLAuthenticationChallenge::initWithAuthenticationChallenge): Changed to return the failing HRESULT.
  • WebURLAuthenticationChallengeSender.cpp: (WebURLAuthenticationChallengeSender::useCredential): Ditto.
  • WebURLCredential.cpp: Removed IID definition. (WebURLCredential::QueryInterface): Switched to use CLSID. (WebURLCredential::initWithUser): Updated method name.
  • WebURLCredential.h: Ditto.
4:40 PM Changeset in webkit [19035] by darin
  • 11 edits
    1 add in trunk/WebCore

Reviewed by Adam.

  • made more of the file chooser code cross-platform
  • fixed an Objective-C garbage collection problem in FileChooser
  • tried to remove layering violations where FileChooser in the platform directory knows about the rendering and DOM trees (but wasn't able to do it entirely)
  • platform/FileChooser.cpp: Added. (WebCore::FileChooser::create): Changed parameters. (WebCore::FileChooser::chooseFile): Changed to call chooseIcon function. (WebCore::FileChooser::chooseIcon): Added.
  • platform/FileChooser.h: Added FileChooserClient so this file doesn't have to know about RenderFileUploadControl. Used RetainPtr instead of retain/release so this works properly with Objective-C GC. Replaced disconnectUploadControl with disconnectClient, which has a simple inline implementation. Moved the Document parameter from the constructor to openFileChooser, along with a comment about why it should not be there. Added a filename parameter to the constructor for the initial filename. Added a font parameter to basenameForWidth so we don't depend on having a pointer to the renderer. Removed the uploadControl() and document() functions since no one calls either of them.
  • platform/mac/FileChooserMac.mm: Removed code that is now cross-platform. (-[OpenPanelController beginSheetWithFrame:]): Added frame parameter, instead of storing a document pointer in the FileChooser. (WebCore::FileChooser::FileChooser): Updated for changed parameters. Also added code to choose the icon based on the initial filename. Pass the adopt parameter to the constructor of the RetainPtr. (WebCore::FileChooser::~FileChooser): Removed the release call, since the RetainPtr will take care of it. Added a call to disconnectFileChooser here. There's no need to disconnect at disconnectClient time, and that lets us have one more cross-platform function. (WebCore::FileChooser::openFileChooser): Added document parameter. Added code to get the frame from the document. And added a nil check since there's no ironclad guarantee the document won't have outlived its frame. (WebCore::FileChooser::basenameForWidth): Added font parameter. Use that instead of going at the upload control's style. The caller can handle that now.
  • rendering/RenderFileUploadControl.h: Removed unnecessary includes. Made class inherit privately from FileChooserClient. Changed constructor parameter to HTMLInputElement rather than Node. Made protected members be private instead, and made a couple function members const.
  • rendering/RenderFileUploadControl.cpp: Moved constants to the top of the file, but after the "using namespace" (WebCore::RenderFileUploadControl::RenderFileUploadControl): Updated for changes to the FileChooser::create function and the parameter types. (WebCore::RenderFileUploadControl::~RenderFileUploadControl): Removed unneeded null check -- there's no case where the FileChooser fails to be created. (WebCore::RenderFileUploadControl::click): Pass document to openFileChooser. (WebCore::RenderFileUploadControl::updateFromElement): Tweaked code a bit by using updateFromElement and setValue instead of casting the renderer to a RenderButton and calling setText directly. Put setInputType call here. (WebCore::RenderFileUploadControl::maxFilenameWidth): Made const. Broke long line. (WebCore::RenderFileUploadControl::createButtonStyle): Made const. (WebCore::RenderFileUploadControl::paintObject): Moved buttonShadowHeight constant to the top of the file. Call isEmpty instead of checking width and height of IntRect for 0. Computed font to pass to FileChooser::basenameForWidth. Broke long lines. (WebCore::HTMLFileUploadInnerButtonElement::HTMLFileUploadInnerButtonElement): Moved the setInputType call to the caller; concept here is that this class is as simple as possible, rather than doing as much of the button job as possible.
  • WebCore.xcodeproj/project.pbxproj: Added FileChooser.cpp.
  • WebCore.pro: Ditto.
  • CMakeLists.txt: Ditto.
  • WebCoreSources.bkl: Ditto.
  • platform/gdk/TemporaryLinkStubs.cpp: Updated stubs.
  • platform/qt/FileChooserQt.cpp: Updated stubs.
3:39 PM Changeset in webkit [22809] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-01-22 Steve Falkenburg <​sfalken@apple.com>

Updated strings not to be localized, added native line endings svn flag.

2:51 PM Changeset in webkit [19034] by bdakin
  • 5 edits in trunk/LayoutTests

Reviewed by Darin.

Darin and I looked into these tests that are adding an empty
RenderText, and we think they just need new results. Here they are!

  • editing/execCommand/find-after-replace-expected.txt:
  • fast/css/beforeSelectorOnCodeElement-expected.txt:
  • fast/forms/control-restrict-line-height-expected.txt:
  • fast/forms/select-size-expected.txt:
1:46 PM Changeset in webkit [22808] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/4903230>
Boomer crashes at Flickr website when "View as slideshow" is clicked.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::bindingInstance): Return null if m_plugin is null (which it can be if the plugin failed to load).
1:37 PM Changeset in webkit [19033] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/forms/select-item-background-clip-expected.checksum: Added.
  • fast/forms/select-item-background-clip-expected.png: Added.
  • fast/forms/select-item-background-clip-expected.txt: Added.
  • fast/forms/select-item-background-clip.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/select-item-background-clip.html

  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemBackground): Intersect the item's rect with the list box's clip rect.
1:28 PM Changeset in webkit [19032] by sullivan
  • 2 edits in trunk/WebKit
  • WebView/WebHTMLView.mm: (-[WebHTMLView _lookUpInDictionaryFromMenu:]): Tiger build fix: remove unused variable for return value of dictionaryServiceWindowShow
1:15 PM Changeset in webkit [19031] by darin
  • 2 edits in trunk/WebCore

Reviewed by Beth.

I caused this a few hours ago. Oops!

  • rendering/RenderText.cpp: (WebCore::RenderText::setStyle): Compute whether the font changed before calling RenderObject::setStyle.
1:09 PM Changeset in webkit [19030] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Adam and Darin

  • fixed <rdar://problem/4794320> "Look Up in Dictionary" does nothing in WebKit (need to adopt new API)
  • Misc/WebNSURLExtras.m: (-[NSString _web_isUserVisibleURL]): random typo correction in comment
  • English.lproj/StringsNotToBeLocalized.txt: updated for these changes
  • WebView/WebHTMLView.mm: (coreGraphicsScreenPointForAppKitScreenPoint): new function to convert an AppKit screen point to a CG screen point (-[WebHTMLView _lookUpInDictionaryFromMenu:]): on Leopard now uses new API. There's something of an impedance mismatch between this API and WebKit, but that was true for the SPI we were using in Tiger also. Bug 4945808 covers the ways in which this is not perfect.
1:01 PM Changeset in webkit [22807] by andersca
  • 10 edits in branches/WindowsMerge/WebKitWin

Reviewed by Brady.

  • Interfaces/IWebError.idl: Clean up the IWebError interface.


  • Interfaces/WebKit.idl:
  • WebKitClassFactory.cpp: (WebKitClassFactory::CreateInstance): Make it possible for clients to create WebErrors.


  • WebError.cpp: (WebError::QueryInterface): (WebError::init):
  • WebError.h:
  • WebURLAuthenticationChallenge.cpp: (WebURLAuthenticationChallenge::initWithProtectionSpace): Get rid of IID_WebError and use CLSID_WebError instad.


  • WebView.cpp: (WebView::canHandleRequest): Return true for "about" URLs.


(WebView::canHandleRequest):
Add private COM method.


(WebView::close):
Reset the policy delegate.

12:54 PM Changeset in webkit [19029] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/4912129> REGRESSION: Crash occurs at
WebCore::Frame::eventHandler() after clicking to dismiss a
contextual menu on the page

  • page/EventHandler.cpp: (WebCore::EventHandler::stopAutoscrollTimer): Added nil-check.
10:42 AM Changeset in webkit [22806] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


  • WebCore.vcproj/WebCore.vcproj:
10:10 AM Changeset in webkit [22805] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Moved ifdefs to match Darin's suggestion.

9:39 AM Changeset in webkit [19028] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Mitz.

  • a couple tiny tweaks to make --reset-results work better
  • Scripts/run-webkit-tests: Always generate results when --reset-results is specified. Don't make a separate "new" entry while generating results when --reset-results is specified since new results are the norm in that case.
9:30 AM Changeset in webkit [22804] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Build fix.

9:28 AM Changeset in webkit [19027] by darin
  • 28 edits
    8 adds in trunk

LayoutTests:

Test by Andrew Wellington <​proton@wiretapped.net>.
Reviewed by Darin.


  • fast/css/beforeSelectorOnCodeElement-expected.checksum: Added.
  • fast/css/beforeSelectorOnCodeElement-expected.png: Added.
  • fast/css/beforeSelectorOnCodeElement-expected.txt: Added.
  • fast/css/beforeSelectorOnCodeElement.html: Added.

Test by Mitz.
Reviewed by Darin.

  • test for monospace problem mentioned in the above bug


  • fast/text/monospace-width-cache-expected.checksum: Added.
  • fast/text/monospace-width-cache-expected.png: Added.
  • fast/text/monospace-width-cache-expected.txt: Added.
  • fast/text/monospace-width-cache.html: Added.

WebCore:

Reviewed by Mitz.

Inspired by a much simpler patch by Andrew Wellington <​proton@wiretapped.net>.

Test: fast/css/beforeSelectorOnCodeElement.html

  • fix regression I recently introduced where the monospace cache could be used for text that was not ASCII, if text was changed after the style was set

Test: fast/text/monospace-width-cache.html

  • streamline RenderText.h -- remove unneeded functions, make some needlessly virtual functions non-virtual, remove unneeded header includes, replace use of Font* with Font& for consistency with RenderStyle, use "text" consistently instead of "string"
  • rendering/RenderText.h: Removed unneeded include of "Text.h", declarations of SOFT_HYPHEN, DocumentMarker, InlineBox, Position, String. Got rid of friend declaration for InlineTextBox. Changed constructor to take a PassRefPtr since we do take owership of the passed-in text. Made deleteTextBoxes() private. Removed unneeded data(). Made override of length() private so people will use the faster textLength() instead. Renamed string() to text() so it matches up better with setText(). Same for stringLength(), originalString(), and setInternalString(), which are now textLength(), originalText(), and setTextInternal(). Renamed the old text() function to characters(), since it returns a pointer as StringImpl::characters does. Changed Font* to Font& everywhere. Renamed the internal calcMinMaxWidth() function to calcMinMaxWidthInternal() and made it non-virtual since it's not overriden anywhere. Also made the trimmedMinMaxWidth() function non-virtual. Made containsOnlyWhitespace() private. Removed both font() functions (one was needlessly virtual) and element(). Renamed cacheWidths() to updateMonospaceCharacterWidth() and removed the shouldUseMonospaceCache() function. Renamed allAscii() to isAllASCII() and made it an inline function. Removed the m_allAsciiChecked flag and renamed the m_allAscii flag to m_isAllASCII.
  • rendering/RenderText.cpp: (WebCore::RenderText::RenderText): Removed initialization of m_allAsciiChecked. Initialize m_isAllASCII. Changed all occurrences of m_str->length() and m_str->characters () to use the stringLength() and characters() inline functions instead. (WebCore::RenderText::setStyle): Replaced the unconditional call to cacheWidths with a conditional call to updateMonospaceCharacterWidth. This speeds up the common case where style is changed without changing the font. (WebCore::RenderText::originalText): Changed code to not depend on overridden element() function with casts to a Text node -- this was one of only two call sites. Also renamed. (WebCore::RenderText::positionForCoordinates): Name change. (WebCore::RenderText::caretRect): Ditto. (WebCore::RenderText::updateMonospaceCharacterWidth): Renamed from cacheWidths and incorporate the check that was formerly in a separate shouldUseMonospaceCache function. (WebCore::RenderText::widthFromCache): Changed to take a Font& instead of Font*. Changed to take advantage of the fact that the string is known to be all ASCII in the m_monospaceCharacterWidth code path. (WebCore::RenderText::trimmedMinMaxWidth): Ditto. Also use style()->font() instead of font(false). (WebCore::RenderText::calcMinMaxWidth): Ditto. Also changed to use softHyphen instead of SOFT_HYPHEN. (WebCore::RenderText::containsOnlyWhitespace): More of the same. (WebCore::RenderText::setSelectionState): Ditto. (WebCore::RenderText::setTextWithOffset): Ditto. (WebCore::isInlineFlowOrEmptyText): Ditto. (WebCore::RenderText::setTextInternal): Updated for name changes. Also changed to set the m_isAllASCII flag every time, in the more-efficient way we use elsewhere (or'ing all the characters together), and to call updateMonospaceCharacterWidth if the "all ASCII"-ness of the text changes. (WebCore::RenderText::setText): Updated for name changes. (WebCore::RenderText::width): More like above. (WebCore::RenderText::selectionRect): Ditto. (WebCore::RenderText::caretMaxOffset): Ditto. (WebCore::RenderText::previousOffset): Ditto. (WebCore::RenderText::nextOffset): Ditto.
  • dom/Position.cpp:
  • dom/Range.cpp:
  • editing/CompositeEditCommand.cpp:
  • editing/DeleteSelectionCommand.cpp:
  • editing/VisiblePosition.cpp:
  • html/HTMLElement.cpp: Added now-needed include of "Text.h" which is no longer included by "RenderText.h".
  • editing/SelectionController.cpp: (WebCore::SelectionController::debugRenderer):
  • editing/TextIterator.cpp: (WebCore::TextIterator::handleTextNode): (WebCore::TextIterator::handleTextBox): (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Update for name changes of stringLength(), string(), and originalString() to textLength(), text(), and originalText(), and to always use textLength() instead of length() when we have a RenderText* rather than a RenderObject*.
  • editing/visible_units.cpp: (WebCore::startOfParagraph): Ditto. (WebCore::endOfParagraph): Ditto.
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Ditto. Also removed use of the RenderObject::font() function and replaced it with explicit access to the style. (WebCore::InlineFlowBox::placeBoxesVertically): Ditto.
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::selectionRect): Ditto. (WebCore::InlineTextBox::isLineBreak): Ditto. (WebCore::InlineTextBox::paint): Ditto. (WebCore::InlineTextBox::selectionStartEnd): Ditto. (WebCore::InlineTextBox::paintSelection): Ditto. (WebCore::InlineTextBox::paintMarkedTextBackground): Ditto. (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): Ditto. (WebCore::InlineTextBox::paintTextMatchMarker): Ditto. (WebCore::InlineTextBox::offsetForPosition): Ditto. (WebCore::InlineTextBox::positionForOffset): Ditto.
  • rendering/RenderContainer.cpp: (WebCore::RenderContainer::addChild): Ditto.
  • rendering/RenderCounter.cpp: (WebCore::RenderCounter::originalText): Ditto. (WebCore::RenderCounter::calcMinMaxWidth): Ditto.
  • rendering/RenderCounter.h: Ditto.
  • rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::originalText): Ditto.
  • rendering/RenderTextFragment.h: Ditto.
  • rendering/SVGInlineFlowBox.cpp: (WebCore::placePositionedBoxesHorizontally): Ditto. (WebCore::placeBoxesVerticallyWithAbsBaseline): Ditto.
  • rendering/bidi.cpp: (WebCore::BidiIterator::increment): Ditto. (WebCore::BidiIterator::current): Ditto. (WebCore::BidiIterator::direction): Ditto. (WebCore::addRun): Ditto. (WebCore::checkMidpoints): Ditto. (WebCore::RenderBlock::computeHorizontalPositionsForLine): Ditto. (WebCore::RenderBlock::skipWhitespace): Ditto. (WebCore::RenderBlock::findNextLineBreak): Ditto.
  • rendering/RenderBR.h: Updated signature of width function which now takes a Font& instead of a Font*.
  • rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace): Updated to no longer use the RenderObject::font() function, and added a comment about first-line, which is not handled properly here.
  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::text):
  • rendering/RenderTreeAsText.cpp: (WebCore::writeTextRun): Eliminated use of RenderText::data().
  • rendering/RenderObject.h: Removed RenderObject::font(). This had the bad effect of having everyone pass in a boolean rather than using the cleaner style() and firstLineStyle() functions in cases where there's no a firstLineStyle boolean.
  • rendering/RenderObject.cpp: (WebCore::RenderObject::getVerticalPosition): Replaced use of RenderObject::font() with direct use of the style instead, which is arguably easier to understand anyway. (WebCore::RenderObject::baselinePosition): Ditto.
6:38 AM Changeset in webkit [19026] by weinig
  • 3 edits
    1 move in trunk/WebCore

Reviewed by The Mitz.

Move JSHTMLSelectElementCustom.cpp from bindings to bindings/js
where it belongs.

  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/JSHTMLSelectElementCustom.cpp: Removed.
  • bindings/js/JSHTMLSelectElementCustom.cpp: Added.
2:54 AM Changeset in webkit [19025] by zack
  • 2 edits in trunk/WebCore

Fix Qt build

Note: See TracTimeline for information about the timeline view.