Timeline



Feb 6, 2007:

11:41 PM Changeset in webkit [22909] by aliceli1
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Maciej.

Fix for <rdar://4973323> PageUp/PageDown don't move the caret in textareas

  • WebView.cpp: (WebView::keyDown): added key entry for function to scroll by page and move caret in scrolling editable regions
11:40 PM Changeset in webkit [19463] by aliceli1
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Added editing command functions for scrolling by page and moving the caret

  • editing/Editor.cpp: (WebCore::execMoveUpByPageAndModifyCaret): (WebCore::execMoveDownByPageAndModifyCaret): (WebCore::CommandEntry::):
10:59 PM Changeset in webkit [19462] by ggaren
  • 2 edits in trunk/WebKitTools

Reviewed by Beth Dakin, evil twin to Bethany P. Dakin.


Ignore known leaks in CFRunLoop. Exclude THRD leaks by type so that we can
catch all reports of them, not just those inside pthread_create.


Also, use "
" instead of "\" because we need the actual \ to get into the
regexp string if it's going to do any escaping. (Oops!)

  • Scripts/run-webkit-tests:
10:18 PM Changeset in webkit [19461] by ggaren
  • 2 edits in trunk/WebKitTools

Reviewed by Bethany P. Dakin.


The 's' is optional when the leaks tool reports 'leaks'.


  • Scripts/run-leaks:
9:45 PM Changeset in webkit [19460] by ggaren
  • 3 edits in trunk/WebKitTools

Reviewed by Bethany P. Dakin.


Hooked up run-webkit-tests to the run-leaks script. No change in behavior yet.

  • Scripts/run-webkit-tests: Changed symbol names to valid regular expressions.
8:27 PM Changeset in webkit [19459] by justing
  • 1 add
    1 delete in trunk/LayoutTests/fast/forms

Re-enabling this test. It doesn't seem to be failing for me (or the buildbot) afterall.

7:50 PM Changeset in webkit [19458] by kdecker
  • 3 edits in trunk/WebKit

Fixed: <rdar://problem/4976681> ASSERTION failure on quit @ talkcrunch.com in _NPN_ReleaseObject


Reviewed by Anders.

  • Plugins/WebPluginDatabase.m: (+[WebPluginDatabase sharedDatabase]): Removed NSApplicationWillTerminateNotification observer and thus also removed code that would unload the entire plug-in database when receiving that notification.


The bug here was that this notification callback would happen first before anything else thus unloading
plug-ins and releasing plug-in memory. That was crash prone because the JavaScriptCore collector would at
a later time attempt to release its CInstance references (references that point to plug-in memory)
without knowing WebKit already unloaded the plug-in out from underneath it. The WebPluginDatabase simply
does not have enough context to make this decision.


  • WebView/WebView.mm: Added two statics: applicationIsTerminating, pluginDatabaseClientCount. (+[WebView initialize]): Added NSApplicationWillTerminateNotification observer. (+[WebView _applicationWillTerminate]): Added. (-[WebView _close]): WebKit has both a global plug-in database and a separate, per WebView plug-in database. We need to release both sets of plug-ins because Netscape plug-ins have "destructor functions" that should be called when the browser unloads the plug-in. These functions can do important things, such as closing/deleting files so it is important to ensure that they are properly called when the application terminates.


The new change is that on app shutdown, we unload WebKit's global plug-in database if and only if the last WebView
was closed. To do so otherwise would unload plug-ins out from underneath other WebViews.

7:36 PM Changeset in webkit [19457] by brmorris
  • 2 edits in S60/trunk/WebCore

yaharon, reviewed by zalan. merged to s60/trunk by brad.

DESC: [S60] BrowserNG: Betsson.com crash (MLIO-6XWP2K)
​http://bugs.webkit.org/show_bug.cgi?id=12641

7:33 PM Changeset in webkit [19456] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

yaharon, reviewed by zalan.

DESC: [S60] BrowserNG: Betsson.com crash (MLIO-6XWP2K)
​http://bugs.webkit.org/show_bug.cgi?id=12641

7:19 PM Changeset in webkit [19455] by brmorris
  • 2 edits in S60/trunk/S60Tools

brmorris, reviewed by sasha

DESC: small update to s60tools\prepare-changelog as r19440 accidentally bumped the Perl version :/

  • prepare-ChangeLog.bat:
7:12 PM Changeset in webkit [22908] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

7:12 PM Changeset in webkit [19454] by sfalken
  • 1 copy in tags/Safari-521.34.1b

New tag.

6:57 PM Changeset in webkit [19453] by justing
  • 1 add
    1 delete in trunk/LayoutTests/fast/forms

Disabling this test while I investigate its failure.

6:40 PM Changeset in webkit [19452] by justing
  • 22 edits
    4 adds in trunk

LayoutTests:

Reviewed by john

<rdar://problem/4922367>
WebView selectLine: followed by deleteBackward: deletes TABLE element of following line


Added:

  • editing/deleting/4922367-expected.checksum: Added.
  • editing/deleting/4922367-expected.png: Added.
  • editing/deleting/4922367-expected.txt: Added.
  • editing/deleting/4922367.html: Added.


Fixed:

  • editing/deleting/delete-block-table-expected.txt:
  • editing/deleting/delete-select-all-001-expected.txt:
  • editing/deleting/delete-to-select-table-expected.txt:
  • editing/inserting/insert-paragraph-02-expected.txt:
  • editing/pasteboard/4641033-expected.txt:
  • editing/pasteboard/paste-table-001-expected.txt:
  • editing/pasteboard/select-element-1-expected.txt:
  • editing/selection/3690719-expected.txt:
  • editing/selection/7152-1-expected.txt:
  • editing/selection/7152-2-expected.txt:
  • editing/selection/click-before-and-after-table-expected.txt:
  • editing/selection/replaced-boundaries-3-expected.txt:
  • editing/style/apple-style-editable-mix-expected.txt:
  • editing/unsupported-content/table-delete-001-expected.txt:
  • editing/unsupported-content/table-type-after-expected.txt:
  • editing/unsupported-content/table-type-before-expected.txt:

WebCore:

Reviewed by john

<rdar://problem/4922367>
WebView selectLine: followed by deleteBackward: deletes TABLE element of following line

  • editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::doApply): Don't ASSERT when manipulating non-editable content that is embedded in editable content. We'll do this kind of manipulation when removing redundant style spans after pasting content that has non-editable pieces.
  • editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::doApply): Ditto.
  • editing/htmlediting.cpp: (WebCore::isContentEditable): Added, wrapper for Node::isContentEditable (WebCore::rangeCompliantEquivalent): Although legal, [{table, select, etc.}, {0, numChildren}] don't refer to children of the element, but positions before and after the element. So, rangeCompliantEquivalent is really responsible for converting illegal positions *and* legal positions that have a special meaning internally.
  • editing/htmlediting.h:
5:57 PM Changeset in webkit [19451] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Brady.

  • platform/String.cpp: (WebCore::String::ascii): Fix dumping null Strings.
4:28 PM Changeset in webkit [19450] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Geoff.

Fix <rdar://problem/4979484>


  • css/CSSPrimitiveValue.cpp: (WebCore::isCSSTokenizerIdentifier): Do the range check before calling isalpha or isalnum.
3:55 PM Changeset in webkit [19449] by darin
  • 3 edits in trunk/WebKit

Reviewed by John Sullivan.

  • Misc/WebKitNSStringExtras.m: (canUseFastRenderer): Fix code that mistakenly used the slow renderer for strings that have a direction of "other neutral", which includes the "@" character. (-[NSString _web_drawAtPoint:font:textColor:]): Add code to make the baseline of the text in the status bar right. AppKit's rule for rounding is complicated enough that this is obviously not perfectly correct, but it does make both code paths use the same baseline in all the places this is currently used in AppKit.
3:38 PM Changeset in webkit [19448] by weinig
  • 2 edits in trunk/LayoutTests

Reviewed by Mark.

  • svg/custom/use-elementInstance-event-target-expected.png:
3:35 PM Changeset in webkit [19447] by weinig
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12566
[Drosera] Console history fixups

  • Drosera/console.js: assorted cleanups and fixes
3:31 PM Changeset in webkit [19446] by sfalken
  • 2 edits in trunk/JavaScriptCore

2007-02-06 Steve Falkenburg <​sfalken@apple.com>

Disable testkjs in sln until we figure out mysterious compiler warning.

2:57 PM Changeset in webkit [19445] by ggaren
  • 4 edits in trunk/WebCore

Reviewed by Darin Adler.

Fixed Frame/RenderObject/Node leak report seen while running SVG image tests.
(We'll need this fix if we ever re-enable SVG image.)


The extra reference belonged to the Frame keepAlive timer (so this was
not a "real" leak, in the end). The Page destructor has code to cancel all
Frame keepAlive timers upon the destruction of the last Page, but an SVG
image puts a Page within a Page, making this condition impossible to meet.


The fix here is to have each individual page cancel the keepAlive timers
belonging to its child frames.


  • page/Frame.cpp: Changed the FrameCounter to use WTF logging. (WebCore::): Nixed the lifeSupportSet, since it's no longer used. (WebCore::Frame::cancelKeepAlive): Renamed from "endLifeSupport" to match the name "keepAlive".
  • page/Page.cpp: (WebCore::Page::~Page): Made each page cancel its child keepAlive timers and clear its mainFrame, since we may never reach the condition of having 0 Pages.
2:38 PM Changeset in webkit [19444] by sfalken
  • 2 edits in trunk/JavaScriptCore

2007-02-06 Steve Falkenburg <​sfalken@apple.com>

Build fix by ggaren

  • pcre/pcre_exec.c: (match):
2:36 PM Changeset in webkit [22907] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Rubberstamped by Brady.

Updated for log channel rename.

  • platform/win/GDIObjectCounter.cpp: (WebCore::GDIObjectCounter::~GDIObjectCounter):
2:35 PM Changeset in webkit [19443] by aroben
  • 3 edits in trunk/WebCore

Rubberstamped by Brady.

Revert the log channel constants to their old values for all you pretty
people out there who were using the old ones. I also renamed
LogResources to LogPlatformLeaks to be a bit more specific.

  • platform/Logging.cpp: (WebCore::):
  • platform/Logging.h:
2:28 PM Changeset in webkit [19442] by justing
  • 1 edit in trunk/WebCore/editing/htmlediting.cpp

Backing out some changes I accidently checked in.

2:17 PM Changeset in webkit [19441] by justing
  • 8 edits
    4 adds in trunk

LayoutTests:

Reviewed by john

<rdar://problem/4959067>
Bullets get erased or moved down to another line
<rdar://problem/4912529>
Seed: Bulleted list in Note in Mail.app does not work with Japanese input mode

  • editing/inserting/4959067-expected.checksum: Added.
  • editing/inserting/4959067-expected.png: Added.
  • editing/inserting/4959067-expected.txt: Added.
  • editing/inserting/4959067.html: Added.

WebCore:

Reviewed by john

<rdar://problem/4959067>
Bullets get erased or moved down to another line
<rdar://problem/4912529>
Seed: Bulleted list in Note in Mail.app does not work with Japanese input mode


Do not expand the selection to include fully selected
special elements when insering text over a selection.

  • editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteSelection): Pass expandForSpecialElements through to DeleteSelectionCommand's constructor. (WebCore::CompositeEditCommand::moveParagraphs): Use the convenience function.
  • editing/CompositeEditCommand.h:
  • editing/DeleteSelectionCommand.h:
  • editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input): Do not expand the selection to be deleted for special elements.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Added a FIXME about when we should expand the selection.
2:03 PM Changeset in webkit [19440] by brmorris
  • 16 edits in S60/trunk

brmorris <​bradley.morrison@nokia.com>, rs'd by zalan

DESC: merge from s60/branches/3.1m to s60/trunk of r19429, r19430, r19431, r19432 and r19433

2:01 PM Changeset in webkit [19439] by darin
  • 2 edits in trunk/WebKit

Spotted by Steve F.

  • Misc/WebNSURLExtras.m: (-[NSString _web_mapHostNameWithRange:encode:makeString:]): Fix obvious logic mistake I introduced back in revision 8255. I can't see how to exercise this code path, but I also can't bear to leave this obviously-broken code as-is.
1:55 PM Changeset in webkit [19438] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoff.

  • fix <rdar://problem/4979089> PCRE should avoid setjmp/longjmp even when compiler is not GCC

Added a new code path that's slower and way uglier but doesn't rely on GCC's
computed gotos.

  • pcre/pcre_exec.c: Added a numeric parameter to the RMATCH function. It must be different at every RMATCH call site. Changed the non-GCC NO_RECURSE version of the macro to use a label incorporating the number. Changed the RRETURN macro to use a goto instead of longjmp. (match): Added a different number at each callsite, using a perl script for the first-time task. Going forward it should be easy to maintain by hand. Added a switch statement at the bottom of the function. We'll get compile time errors if we have anything in the switch statement that's never used in an RMATCH, but errors in the other direction are silent except at runtime.
1:26 PM Changeset in webkit [19437] by ggaren
  • 2 edits
    1 move in trunk/LayoutTests

At Darin's request, checked in new (failing) results instead of disabling test.

  • fast/images/svg-as-image-expected.txt:
1:21 PM Changeset in webkit [22906] by andersca
  • 3 edits in branches/WindowsMerge/WebKitTools

Reviewed by Darin and Geoff.

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (initialize): Call OleInitialize.


(runTest):
Use CF for creating the URLs passed in.


(initializePreferences):
Don't autosave the preferences.


(main):

  • DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj: Link with CF.
1:14 PM Changeset in webkit [19436] by ggaren
  • 3 edits
    1 move in trunk

LayoutTests:

Reviewed by Anders Carlsson.


Disabled support for SVG image because it crashes all the time.

  • fast/images/svg-as-image.html: Removed.
  • fast/images/svg-as-image.html-disabled: Moved to here.

WebCore:

Reviewed by Anders Carlsson.


Disabled support for SVG image because it crashes all the time.

  • loader/CachedImage.cpp: (WebCore::CachedImage::createImage):
12:58 PM Changeset in webkit [22905] by adele
  • 4 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adam.

Added support for radio buttons and checkboxes.

12:26 PM Changeset in webkit [19435] by ap
  • 3 edits
    2 adds in trunk

2007-02-06 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/layers/generated-layer-scrollbar-crash.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Changed element()->document() to document() to work with anonymous objects. (WebCore::RenderLayer::updateOverflowStatus): Ditto.
11:42 AM Changeset in webkit [19434] by darin
  • 4 edits
    1 add in trunk/JavaScriptCore

Reviewed by John.

  • fix <rdar://problem/4687840> 9A241: JavaScript RegExp 25-30x slower than on 10.4.7

I used Shark to figure out what to do. The test case is now 15% faster than with
stock Safari. Some other regular expression cases might still be a few % slower
than before, but the >10x slowdown is now completely gone.

1) Fix slowness caused by setjmp/longjmp by using computed goto instead.

Use GCC extensions - locally declared labels, labels as values, and computed goto -
instead of using setjmp/longjmp to implemement non-recursive version of the regular
expression system. We could probably make this even faster if we reduced the use
of malloc a bit too.

2) Fix slowness caused by allocating heapframe objects by allocating the first

16 of them from the stack.

3) Speed up use of malloc and free in PCRE by making it use fastMalloc and fastFree.

4) Speed up the test case by adding a special case to a UString function.

5) Made a small improvement to the innermost hottest loop of match by hoisting

the conversion from int to pcre_uchar out of the loop.

  • JavaScriptCore.xcodeproj/project.pbxproj: Compile FastMallocPCRE.cpp, and don't compile pcre_globals.c.
  • wtf/FastMallocPCRE.cpp: Added. A copy of pcre_globals.c that uses FastMalloc.h. This is better than code that sets the PCRE allocation globals because by doing it this way there's guaranteed to be no problem with order of initialization.
  • kjs/ustring.cpp: (KJS::UString::spliceSubstringsWithSeparators): Add a fast special case when this is called for only one subrange and no seaprators. This was happening a lot in the test case and it seems quite reasonable to optimize this.
  • pcre/pcre_exec.c: Create a copy of the RMATCH and RRETURN macros that use goto instead of setjmp/longjmp. Change code that calls pcre_stack_malloc to first use storage on the stack inside the match function. (match): Move initialization of utf8 up a couple lines to avoid "possibly used uninitialized" warning. Use a local variable so we compare with pcre_uchar instead of with int inside the inner "find a character" loop.
9:17 AM Changeset in webkit [19433] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

w3liu, Reviewed by Yongjun Zhang <​yongjun.zhang@nokia.com>

DESC: Should check meta for charset if meta exists EHSN-6UQ6CM
​http://bugs.webkit.org/show_bug.cgi?id=12225

8:50 AM Changeset in webkit [19432] by brmorris
  • 4 edits in S60/branches/3.1m/WebKit

yaharon, Reviewed by Yongjun.

DESC: [S60] OSS Browser crashes when accessing cnn.com, yahoo.com with Load images & sounds turned off.(SLON-6XY8JM )
​http://bugs.webkit.org/show_bug.cgi?id=12622

8:46 AM Changeset in webkit [19431] by brmorris
  • 4 edits in S60/branches/3.1m

yongjzha, Reviewed by Zalan.

DESC: enable drawing 1px transparent image with EGray256 mask
​http://bugs.webkit.org/show_bug.cgi?id=12621

8:41 AM Changeset in webkit [19430] by brmorris
  • 7 edits in S60/branches/3.1m

vbradley, reviewed by Yongjun.

DESC: Fixed the stack size and pcre stack overflow ALAA-6XSF7U
Limit the number recursions that are allowed in match().
​http://bugs.webkit.org/show_bug.cgi?id=12611

8:34 AM Changeset in webkit [19429] by brmorris
  • 3 edits in S60/branches/3.1m/WebKit

bujtas, reviewed by yongjun.

DESC: closing the window while the page is loading still crashes the browser TMCN-6XRQP2
fix: do not let new transactions get sumbited while cancel is in progress

8:30 AM Changeset in webkit [19428] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

winship, reviewed by yongjun

DESC: MLIO-6XGEMQ BrowserNG: Toolbar positioned out of screen after closing PDA
​http://bugs.webkit.org/show_bug.cgi?id=12544

7:34 AM Changeset in webkit [19427] by eseidel
  • 13 edits in trunk

2007-02-06 Eric Seidel <​eric@webkit.org>

Reviewed by mitz.

WebKit ignores floating point values for stroke-miterlimit
​http://bugs.webkit.org/show_bug.cgi?id=12577

Test: svg/W3C-SVG-1.1/painting-stroke-07-t.svg

  • ksvg2/css/SVGCSSParser.cpp: (WebCore::CSSParser::parseSVGValue):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/css/SVGRenderStyleDefs.h: (WebCore::StyleStrokeData::operator!=):
1:08 AM Changeset in webkit [22904] by aroben
  • 5 edits
    2 adds in branches/WindowsMerge

WebCoreWin:

Reviewed by Ada and Oliver.

Add a GDIObjectCounter class that informs us of GDI leaks.

  • WebCore.vcproj/WebCore.vcproj: Added new files.
  • platform/win/GDIObjectCounter.cpp: Added. (WebCore::GDIObjectCounter::GDIObjectCounter): (WebCore::GDIObjectCounter::init): (WebCore::GDIObjectCounter::~GDIObjectCounter): (WebCore::GDIObjectCounter::currentGDIObjectsInUse):
  • platform/win/GDIObjectCounter.h: Added.

WebKitWin:

Reviewed by Ada and Oliver.


Add some GDI object logging to help catch leaks.

  • WebFrame.cpp: (WebFrame::layoutIfNeeded):
  • WebView.cpp: (WebView::addToDirtyRegion): (WebView::scrollBackingStore): (WebView::updateBackingStore): (WebView::paint): (WebView::paintIntoBackingStore): (WebView::paintIntoWindow):
1:07 AM Changeset in webkit [19426] by aroben
  • 3 edits in trunk/WebCore

Reviewed by Ada and Oliver.

Adding a new LogResources channel for tracking platform resource usage.

  • platform/Logging.cpp: Added new channel, cleaned up constants to be more readable.
  • platform/Logging.h: Declare new channel.

Feb 5, 2007:

11:52 PM Changeset in webkit [22903] by beidson
  • 4 edits in branches/WindowsMerge/WebKitWin

Add config.h to some .cpps

9:43 PM Changeset in webkit [19425] by ap
  • 4 edits
    2 adds in trunk

Reviewed by Geoff.

​http://bugs.webkit.org/show_bug.cgi?id=12619
Non-abbreviated XPaths don't work

Test: fast/xpath/ancestor-axis.html

  • xml/XPathParser.cpp: (WebCore::XPath::Parser::lex): Fix axis name parsing to actually work.
  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodeTestMatches): Fix "*" node test to actually work.
8:10 PM Changeset in webkit [19424] by brmorris
  • 5 edits in S60/trunk/WebKit

bujtas, reviewed by Yongjun.

DESC: PartialImage() can end up in a dialog box which starts up a nested active scheduler JELE-6XSH3P

and since the page still being loaded in the background new image
data could come to the image decoder. that's a fatal re-entry on
the image decoder.

​http://bugs.webkit.org/show_bug.cgi?id=12550

7:55 PM Changeset in webkit [19423] by brmorris
  • 5 edits in S60/branches/3.1m/WebKit

bujtas, reviewed by Yongjun.

DESC: PartialImage() can end up in a dialog box which starts up a nested active scheduler JELE-6XSH3P
​http://bugs.webkit.org/show_bug.cgi?id=12550

7:43 PM Changeset in webkit [19422] by ddkilzer
  • 5 edits in trunk

LayoutTests:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=7266
Webarchive format saves duplicate WebSubresources to .webarchive file

  • webarchive/test-duplicate-resources-expected.txt: Duplicate resources removed.
  • webarchive/test-frameset-expected.txt: Ditto.

WebKit:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=7266
Webarchive format saves duplicate WebSubresources to .webarchive file

Tests: webarchive/test-duplicate-resources.html

webarchive/test-frameset.html

  • WebView/WebArchiver.mm: (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]): Use an NSMutableSet to prevent duplicate subresources from being added to the webarchive.
6:27 PM Changeset in webkit [19421] by bdash
  • 13 edits
    4 deletes in trunk

2007-02-06 Mark Rowe <​mrowe@apple.com>

Roll out incomplete support for font-stretch (r19350) at Dave Hyatt's request.
See ​http://bugs.webkit.org/show_bug.cgi?id=12530#c9 for more info.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue):
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyDeclarations): (WebCore::CSSStyleSelector::applyProperty):
  • platform/FontCache.cpp: (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): (WebCore::FontPlatformDataCacheKey::operator==): (WebCore::computeHash): (WebCore::FontPlatformDataCacheKeyTraits::deletedValue): (WebCore::FontPlatformDataCacheKeyTraits::emptyValue): (WebCore::FontCache::getCachedFontPlatformData):
  • platform/FontDescription.h: (WebCore::FontDescription::FontDescription): (WebCore::FontDescription::weight): (WebCore::FontDescription::setWeight): (WebCore::FontDescription::operator==):
  • platform/mac/FontCacheMac.mm: (WebCore::FontCache::createFontPlatformData):
  • platform/mac/WebFontCache.mm: (acceptableChoice): (betterChoice): (+[WebFontCache fontWithFamily:traits:size:]):

2007-02-06 Mark Rowe <​mrowe@apple.com>

Roll out incomplete support for font-stretch (r19350) at Dave Hyatt's request.
See ​http://bugs.webkit.org/show_bug.cgi?id=12530#c9 for more info.

  • WebInspector/webInspector/inspector.js:
  • WebView/WebHTMLView.mm: (-[WebHTMLView _addToStyle:fontA:fontB:]):

2007-02-06 Mark Rowe <​mrowe@apple.com>

Roll out incomplete support for font-stretch (r19350) at Dave Hyatt's request.
See ​http://bugs.webkit.org/show_bug.cgi?id=12530#c9 for more info.

  • fast/css/computed-style-expected.txt:
  • fast/css/font-stretch-expected.checksum: Removed.
  • fast/css/font-stretch-expected.png: Removed.
  • fast/css/font-stretch-expected.txt: Removed.
  • fast/css/font-stretch.html: Removed.
6:12 PM Changeset in webkit [19420] by adele
  • 4 edits in trunk/WebCore

Reviewed by Darin.

A few small updates to my bidi patch.

  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): Moved the declaration of the CharacterBuffer outside the if statement since we use its data outside that scope.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): ditto.
  • rendering/bidi.cpp: (WebCore::RenderBlock::bidiReorderCharacters): Used a PassRefPtr for the BidiContext.
5:19 PM Changeset in webkit [19419] by justing
  • 3 edits in trunk/LayoutTests/editing/selection

Checked in old results. Fixed.

4:36 PM Changeset in webkit [19418] by adele
  • 4 edits in trunk/WebCore

Reviewed by Adam.

Fix for assertion failure in fast/events/objc-keyboard-event-creation.html

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::selectionStart): Check that the selection offsets are not equal to -1 (which is means the selection has never been set) instead of checking for >= 0. (WebCore::HTMLInputElement::selectionEnd): ditto. (WebCore::HTMLInputElement::setValue): ditto. (WebCore::HTMLInputElement::selection): Return an empty selection if the input is not a text field or if no selection has ever been set in the text field.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::selectionStart): Check that the selection offsets are not equal to -1. (WebCore::HTMLTextAreaElement::selectionEnd): ditto. (WebCore::HTMLTextAreaElement::setValue): ditto. (WebCore::HTMLTextAreaElement::selection): Return an empty selection if no selection has ever been set in the textarea.
  • dom/Position.cpp: Added FIXMEs that we should catch the negative offset earlier. (WebCore::Position::previous): (WebCore::Position::next):
4:20 PM Changeset in webkit [19417] by justing
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4947387>
REGRESSION: Shift Command Left should only select to the beginning of the line

  • editing/selection/4947387-expected.checksum: Added.
  • editing/selection/4947387-expected.png: Added.
  • editing/selection/4947387-expected.txt: Added.
  • editing/selection/4947387.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/4947387>
REGRESSION Shift Command Left should only select to the beginning of the line

  • editing/Editor.cpp: (WebCore::CommandEntry::): Never copy/paste code.
3:41 PM Changeset in webkit [19416] by darin
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by John Sullivan.

  • fast/forms/input-select-on-click-expected.txt: Added.
  • fast/forms/input-select-on-click.html: Added.

WebCore:

Reviewed by John Sullivan.

Test: fast/forms/input-select-on-click.html

  • page/EventHandler.h: Added m_mouseDownWasSingleClickInSelection boolean. Organized other booleans a bit more logically.
  • page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): Rearrange order to match EventHandler.h, add m_mouseDownWasSingleClickInSelection initialization. (WebCore::EventHandler::handleMousePressEventSingleClick): Set m_mouseDownWasSingleClickInSelection to true in the appropriate special case. (WebCore::EventHandler::handleMousePressEvent): Set m_mouseDownWasSingleClickInSelection to false. (WebCore::EventHandler::handleMouseReleaseEvent): Change code to clear selection or set to caret to only fire if m_mouseDownWasSingleClickInSelection was true rather than firing for any m_mouseDownMayStartSelect case.
3:39 PM Changeset in webkit [19415] by staikos
  • 2 edits in trunk/WebCore

Make http cookies work

3:25 PM Changeset in webkit [19414] by adele
  • 7 edits
    8 adds in trunk

LayoutTests:

Reviewed by Mitz and Anders.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=11811
<rdar://problem/4947184> REGRESSION (r11783): Hebrew text in list boxes is reversed

  • fast/text/international/bidi-listbox-expected.checksum: Added.
  • fast/text/international/bidi-listbox-expected.png: Added.
  • fast/text/international/bidi-listbox-expected.txt: Added.
  • fast/text/international/bidi-listbox.html: Added.
  • fast/text/international/bidi-listbox-atsui-expected.checksum: Added.
  • fast/text/international/bidi-listbox-atsui-expected.png: Added.
  • fast/text/international/bidi-listbox-atsui-expected.txt: Added.
  • fast/text/international/bidi-listbox-atsui.html: Added.

WebCore:

Reviewed by Mitz and Anders.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11811
<rdar://problem/4947184> REGRESSION (r11783): Hebrew text in list boxes is reversed

​http://bugs.webkit.org/show_bug.cgi?id=11812
<rdar://problem/4960269> REGRESSION (Native file upload): Hebrew filenames are reversed

Tests:
fast/text/international/bidi-listbox.html
fast/text/international/bidi-listbox-atsui.html

  • rendering/RenderBlock.h: Added static bidiReorderCharacters that will run the bidi algorithm on a character buffer.
  • rendering/bidi.cpp: (WebCore::RenderBlock::bidiReorderCharacters): Added. Creates an anonymous RenderBlock and RenderText to feed into bidiReorderLines. (WebCore::RenderBlock::constructLine): Uses the new convenience methods on BidiRun.
  • rendering/bidi.h: (WebCore::BidiRun::reversed): Added convenience method. (WebCore::BidiRun::dirOverride): ditto.
  • rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): Creates a buffer and calls bidiReorderCharacters to get a correctly ordered character buffer for drawText.
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): ditto.
3:22 PM Changeset in webkit [22902] by adachan
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-02-05 Ada Chan <​adachan@apple.com>

Reviewed by Anders.


<rdar://4945519> Crash when back/forward buttons are clicked several times
Clear loader's previous history item when frame load is completed (got that code from the mac side).

  • WebFrame.cpp: (WebFrame::frameLoadCompleted):
3:19 PM Changeset in webkit [19413] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/repaint/selection-gap-overflow-scroll-expected.checksum: Added.
  • fast/repaint/selection-gap-overflow-scroll-expected.png: Added.
  • fast/repaint/selection-gap-overflow-scroll-expected.txt: Added.
  • fast/repaint/selection-gap-overflow-scroll.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/repaint/selection-gap-overflow-scroll.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::selectionGapRects): Adjust for overflow scroll.
3:07 PM Changeset in webkit [19412] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Adele.

  • fast/forms/search-rtl-expected.checksum: Added.
  • fast/forms/search-rtl-expected.png: Added.
  • fast/forms/search-rtl-expected.txt: Added.
  • fast/forms/search-rtl.html: Added.

WebCore:

Reviewed by Adele.

Test: fast/forms/search-rtl.html

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::createInnerBlockStyle): Always make the inner block LTR so that the results button will be on the left and the cancel button will be on the right. (WebCore::RenderTextControl::createInnerTextStyle): Inherit the direction property directly from the control so that it won't be masked by the inner block's LTR override. (WebCore::RenderTextControl::nodeAtPoint): Removed code that swapped the results and cancel buttons for RTL. (WebCore::RenderTextControl::forwardEvent): Ditto. (WebCore::RenderTextControl::clientPaddingLeft): Ditto. (WebCore::RenderTextControl::clientPaddingRight): Ditto.
2:55 PM Changeset in webkit [19411] by weinig
  • 4 edits
    2 adds in trunk

LayoutTests:

Reviewed by Adele.

  • fast/forms/search-cancel-button-mouseup-expected.txt: Added.
  • fast/forms/search-cancel-button-mouseup.html: Added.

WebCore:

Reviewed by Adele.

Test: fast/forms/search-cancel-button-mouseup.html

Made the cancel button capturing.

  • html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLSearchFieldCancelButtonElement::HTMLSearchFieldCancelButtonElement): (WebCore::HTMLSearchFieldCancelButtonElement::defaultEventHandler):
  • html/HTMLTextFieldInnerElement.h:
1:12 PM Changeset in webkit [19410] by ggaren
  • 1 edit
    1 add in trunk/WebKitTools

Reviewed by Darin Adler.


New script that allows you to ignore leaks by regular expression.

  • Scripts/run-leaks: Added.
1:10 PM Changeset in webkit [19409] by bdakin
  • 2 edits in trunk/WebKit

Reviewed by Adam.

Fix for <rdar://problem/4975161> REGRESSION: With BumperCar 2.1.1,
the contextual menu fails to appear when I ctrl-click on page

  • WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::getCustomMenuFromDefaultItems): If the delegate does not respond to contextMenuItemsForElement, return the default menu instead of nil.
1:08 PM Changeset in webkit [19408] by ggaren
  • 3 edits in trunk/LayoutTests

Reviewed by John Sullivan and Darin Adler.

Focused gc-8.html on the issue it was really trying to test (a crash)
to fix intermittent failures seen on buildbot.


  • fast/dom/gc-8.html: Don't test the value of our custom property, which (legitimately) can be cleared by garbage collection.
  • fast/dom/gc-8-expected.txt:
10:32 AM Changeset in webkit [19407] by ap
  • 4 edits
    1 add in trunk/WebCore

2007-02-05 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

No test possible since Mac OS X only ships with fonts that contain shaping
information.

  • icu/unicode/ushape.h: Added from ​http://www.opensource.apple.com/darwinsource/10.4.8.ppc/ICU-6.2.9/icuSources/common/unicode/
  • platform/FontData.h: (WebCore::FontData::shapesArabic): Added. Returns whether the font contains shaping information for Arabic or not.
  • platform/mac/FontDataMac.mm: (WebCore::FontData::platformInit): (WebCore::FontData::checkShapesArabic): Added. Checks whether the font contains a glyph metamorphosis table. The heuristic is that if a font contains Arabic glyphs and a metamorphosis table, then it includes shaping information for Arabic.
  • platform/mac/FontMac.mm: (WebCore::overrideLayoutOperation): Changed to use the same character buffer passed to ATSUI instead of the original character buffer and to give zero-width spaces zero width. (WebCore::isArabicLamWithAlefLigature): Added. Checks if the character is one of the Arabic presentation forms of Lam with Alef. (WebCore::shapeArabic): Added. This is a wrapper around the ICU Arabic shaping routine that replaces each space following a Lam with Alef ligature resulting from shaping with a zero-width space. (WebCore::ATSULayoutParameters::initialize): Changed to allocate the auxiliary buffer lazily for mirroring and Arabic shaping. Added a call to shapeArabic() when required.
9:24 AM Changeset in webkit [19406] by brmorris
  • 19 edits in S60/trunk

bujtas, merged of r19405 to s60/trunk by mbradley, reviewed by yongjun.

DESC: browser is crashing if it is closed while a page is loading and closing and opening a new window crashes the browser as well TMCN-6XRQP2
fix:

  1. cancel parsing when the document is being closed
  2. flush static image decoder queue. remove images associated with the the view being destroyed


​http://bugs.webkit.org/show_bug.cgi?id=12542

9:07 AM Changeset in webkit [19405] by brmorris
  • 19 edits in S60/branches/3.1m

bujtas <​zbujtas@gmail.com>, reviewed by Yongjun.

DESC: browser is crashing if it is closed while a page is loading and closing and opening a new window crashes the browser as well TMCN-6XRQP2
fix:

  1. change the order of destroying webkit objects.
  2. cancel parsing when the document is being closed
  3. flush static image decoder queue. remove images associated with the the view being destroyed
  4. remove formfill dependency on webkitcontrol. formfill is static object while webkitcontrol is per window.
  5. do not create formfill manager unless browser capabilities say so


​http://bugs.webkit.org/show_bug.cgi?id=12542

9:00 AM Changeset in webkit [19404] by brmorris
  • 3 edits in S60/branches/3.1m/WebKit

raalexan, Reviewed by Yongjun Zhang.

DESC: Enhanced Input feature not working in 3.1 [TSW TMCN-6XYSLY]
​http://bugs.webkit.org/show_bug.cgi?id=12533

8:51 AM Changeset in webkit [22901] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Add new files.
7:18 AM Changeset in webkit [19403] by ddkilzer
  • 1 edit in trunk/WebCore/ChangeLog

Clean up changelog entry. Also testing new svn-co-one-file script.

5:07 AM Changeset in webkit [19402] by eseidel
  • 2 edits in trunk/WebCore

2007-02-05 Eric Seidel <​eric@webkit.org>

No review, build fix only.

  • ksvg2/svg/SVGStyleElement.cpp: add forgotten header.
4:46 AM Changeset in webkit [19401] by eseidel
  • 3 edits in trunk/WebCore

2007-02-05 Eric Seidel <​eric@webkit.org>

Reviewed by bdash.

Fix style name testcase which I broke in my last commit.

  • ksvg2/svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::xmlspace): (WebCore::SVGStyleElement::title): override Element::title() (WebCore::SVGStyleElement::parseMappedAttribute):
  • ksvg2/svg/SVGStyleElement.h:
3:21 AM Changeset in webkit [19400] by eseidel
  • 11 edits
    1 add in trunk/WebCore

2007-02-04 Eric Seidel <​eric@webkit.org>

Reviewed by darin.

Fix hand cursor on link hover for SVG
Fix status text on link hover for SVG
Fix tooltips on link hover for SVG
Fix link dragging for SVG
​http://bugs.webkit.org/show_bug.cgi?id=12575


Test: added manual-tests/svg-links.svg

  • dom/Document.cpp: (WebCore::Document::prepareMouseEvent):
  • dom/Element.cpp: (WebCore::Element::title):
  • dom/Element.h:
  • html/HTMLElement.cpp: (WebCore::HTMLElement::setId): (WebCore::HTMLElement::title): (WebCore::HTMLElement::setTitle): (WebCore::HTMLElement::setLang):
  • html/HTMLElement.h:
  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::title): (WebCore::SVGAElement::parseMappedAttribute): (WebCore::SVGAElement::defaultEventHandler):
  • ksvg2/svg/SVGAElement.h:
  • ksvg2/svg/SVGTitleElement.cpp:
  • ksvg2/svg/SVGTitleElement.h:
  • manual-tests/svg-links.svg: Added.
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::title): (WebCore::HitTestResult::absoluteImageURL): (WebCore::HitTestResult::absoluteLinkURL): (WebCore::HitTestResult::isLiveLink): (WebCore::HitTestResult::titleDisplayString):

Feb 4, 2007:

10:59 PM Changeset in webkit [22900] by adachan
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-02-04 Ada Chan <​adachan@apple.com>

Reviewed by Steve.

WebKitWin:

<rdar://4946475> Private browsing is not working correctly
Implemented FrameLoaderClient::privateBrowsingEnabled().

  • WebFrame.cpp: (WebFrame::privateBrowsingEnabled):


10:06 PM Changeset in webkit [19399] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12602
XPath functions string(), normalize-space() and string-length() don't work
without arguments

Test: fast/xpath/implicit-node-args.html

  • xml/XPathFunctions.cpp: (WebCore::XPath::FunString::doEvaluate): (WebCore::XPath::FunStringLength::doEvaluate): (WebCore::XPath::FunNormalizeSpace::doEvaluate): Don't try to pass RefPtr<Node> to the Value ctor.
9:56 PM Changeset in webkit [19398] by ap
  • 11 edits
    14 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=8791
XPath should support custom node resolvers

WebCore:

  • bindings/js/JSCustomXPathNSResolver.cpp: Added. (WebCore::JSCustomXPathNSResolver::create): (WebCore::JSCustomXPathNSResolver::JSCustomXPathNSResolver): (WebCore::JSCustomXPathNSResolver::~JSCustomXPathNSResolver): (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
  • bindings/js/JSCustomXPathNSResolver.h: Added.
  • bindings/objc/DOMCustomXPathNSResolver.h: Added.
  • bindings/objc/DOMCustomXPathNSResolver.mm: Added. (WebCore::DOMCustomXPathNSResolver::DOMCustomXPathNSResolver): (WebCore::DOMCustomXPathNSResolver::~DOMCustomXPathNSResolver): (WebCore::DOMCustomXPathNSResolver::lookupNamespaceURI): Wrappers for JS/ObjC objects that can be used as resolvers.
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm: Use the above wrappers to support custom resolvers.
  • xml/XPathNSResolver.cpp:
  • xml/XPathNSResolver.h: Turned this class into an abstract one.
  • xml/NativeXPathNSResolver.cpp: Added. (WebCore::NativeXPathNSResolver::NativeXPathNSResolver): (WebCore::NativeXPathNSResolver::~NativeXPathNSResolver): (WebCore::NativeXPathNSResolver::lookupNamespaceURI):
  • xml/NativeXPathNSResolver.h: Added. A XPathNSResolver subclass, doing what XPathNSResolver used to do.
  • xml/XPathEvaluator.cpp: (WebCore::XPathEvaluator::createNSResolver): Create a NativeXPathNSResolver.
  • WebCore.xcodeproj/project.pbxproj: Added new files.

LayoutTests:

  • fast/xpath/nsresolver-bad-object-expected.txt: Added.
  • fast/xpath/nsresolver-bad-object.xhtml: Added.
  • fast/xpath/nsresolver-exception-expected.txt: Added.
  • fast/xpath/nsresolver-exception.xhtml: Added.
  • fast/xpath/nsresolver-function-expected.txt: Added.
  • fast/xpath/nsresolver-function.xhtml: Added.
  • fast/xpath/nsresolver-object-expected.txt: Added.
  • fast/xpath/nsresolver-object.xhtml: Added.
9:55 PM Changeset in webkit [22899] by aliceli1
  • 4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve.

Fix some memory leaks. This fixes WebFrame leak as well.
Can be considered a partial fix for <rdar://4974495> Boomer leaks while running HTML iBench

  • WebActionPropertyBag.cpp: (WebActionPropertyBag::WebActionPropertyBag):
  • WebDataSource.cpp: (WebDataSource::representation):
  • WebURLResponse.cpp: (:m_refCount):
7:52 PM Changeset in webkit [22898] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Steve.

Fix <rdar://problem/4972498> REGRESSION: Crash while closing View Source window

  • WebView.cpp: (WebView::WebView): Initialize new member. (WebViewWndProc): Set flag when we receive WM_DESTROY, and don't handle WM_SIZE if that flag is true. (WebView::mainFrame): Added argument check.
  • WebView.h: (WebView::setIsBeingDestroyed): Added. (WebView::isBeingDestroyed): Added.
6:54 PM Changeset in webkit [19397] by weinig
  • 19 edits in trunk/LayoutTests

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12562
Fix test cases that are now spewing console errors that
they are not testing for

  • fast/events/iframe-object-onload-expected.txt:
  • fast/events/iframe-object-onload.html: Change nil to null.
  • fast/forms/display-none-in-onchange-keyboard-expected.txt:
  • fast/forms/display-none-in-onchange-keyboard.html: Add missing id to div, change its text, and change the resulting text.
  • fast/forms/input-text-click-inside-expected.checksum:
  • fast/forms/input-text-click-inside-expected.png:
  • fast/forms/input-text-click-inside-expected.txt:
  • fast/forms/input-text-click-inside.html: Change moveTo(x,y) to mouseMoveTo(x,y).
  • fast/forms/input-text-click-outside-expected.txt:
  • fast/forms/input-text-click-outside.html: Ditto.
  • fast/js/array-foreach-expected.txt:
  • fast/js/array-foreach.html: Add try-catch blocks to catch exceptions and print them and general cleanup.
  • fast/js/array-some-expected.txt:
  • fast/js/array-some.html: Ditto.
  • fast/table/click-near-anonymous-table-expected.checksum:
  • fast/table/click-near-anonymous-table-expected.png:
  • fast/table/click-near-anonymous-table-expected.txt:
  • fast/table/click-near-anonymous-table.html: Change timeForward(ms) to leapForward(ms) and change the amount of time from 500ms to 1000ms to avoid clicking.
6:38 PM Changeset in webkit [22897] by oliver
  • 2 edits in branches/WindowsMerge/WebCore

2007-02-04 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Removed unimplemented EventHandler::handleMouseUp,
as a platform independent version is available now.

  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::eventActivatedView): Now we use this method, it needs to be implemented
6:37 PM Changeset in webkit [19396] by oliver
  • 6 edits in trunk/WebCore

2007-02-04 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Tidying up EventHandler, and moving more of
EventHandlerMac.mm to EventHandler.cpp

Also added EventHandler::eventLoopHandleMouse[Dragged,Up]
these are basically helper functions to allow correct event
handling on MacOS.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMouseUp): (WebCore::EventHandler::dragSourceMovedTo): (WebCore::EventHandler::dragSourceEndedAt): (WebCore::EventHandler::dispatchDragSrcEvent):

Moved from EventHandlerMac to EventHandler

  • page/EventHandler.h: (WebCore::EventHandler::eventLoopHandleMouseUp): (WebCore::EventHandler::eventLoopHandleMouseDragged): Null implementations of two Mac helper functions
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::eventLoopHandleMouseDragged): (WebCore::EventHandler::handleDrag): Much tidying, reduced nesting, made less dependent on NS types (WebCore::EventHandler::eventLoopHandleMouseDragged): (WebCore::EventHandler::eventLoopHandleMouseUp): Helper functions to let us process events properly on MacOS
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge dragSourceEndedAt:operation:]):
5:08 PM Changeset in webkit [22896] by aroben
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Hyatt.

Fix <rdar://problem/4968183> Cross-window frame targeting doesn't work

  • Interfaces/IWebView.idl: Pass RECT by value.
  • WebView.cpp: (WebView::initWithFrame): Uses the passed-in RECT for the frame, and sets the frame/group names.
  • WebView.h: Updated declaration.
6:15 AM Changeset in webkit [19395] by staikos
  • 3 edits in trunk/WebCore

Various Qt related hacks and cleanups to make forms work better

Feb 3, 2007:

11:56 PM Changeset in webkit [19394] by mjs
  • 1 edit
    1 delete in trunk/WebCore

Rubber stamped by Adam.

  • remove obsolete code that has an annoying space in the directory name
  • WebCore.vcproj/Image Viewer.cpp: Removed.
  • WebCore.vcproj/Image Viewer.h: Removed.
  • WebCore.vcproj/Image Viewer.ico: Removed.
  • WebCore.vcproj/Image Viewer.rc: Removed.
  • WebCore.vcproj/Image Viewer.reg: Removed.
  • WebCore.vcproj/Image Viewer.vcproj: Removed.
  • WebCore.vcproj/Image Viewer/ImageDocument.cpp: Removed.
  • WebCore.vcproj/Image Viewer/ImageDocument.h: Removed.
  • WebCore.vcproj/Image Viewer/ImageMainFrame.cpp: Removed.
  • WebCore.vcproj/Image Viewer/ImageMainFrame.h: Removed.
  • WebCore.vcproj/Image Viewer/ImageView.cpp: Removed.
  • WebCore.vcproj/Image Viewer/ImageView.h: Removed.
  • WebCore.vcproj/Image Viewer/Resource.h: Removed.
  • WebCore.vcproj/Image Viewer/res/ImageViewer.rc2: Removed.
  • WebCore.vcproj/Image Viewer/res/Toolbar.bmp: Removed.
  • WebCore.vcproj/Image Viewer/stdafx.cpp: Removed.
  • WebCore.vcproj/Image Viewer/stdafx.h: Removed.
  • WebCore.vcproj/Image iewerDoc.ico: Removed.
11:37 PM Changeset in webkit [19393] by staikos
  • 2 edits in trunk/JavaScriptCore

fix crash on JS that ends with an identifier

11:34 PM Changeset in webkit [19392] by oliver
  • 2 edits in trunk/WebCore

2007-02-04 Mitz Pettel <​mitz@webkit.org>

Reviewed by Oliver.

  • platform/mac/PlatformMouseEventMac.mm: (WebCore::eventNumberForEvent): Scroll wheel events don't have an event number.
10:50 PM Changeset in webkit [22895] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-02-03 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.


<rdar://problem/4930947> Regression: History is not saved when boomer window is closed.


Fix boolean test causing lost history regression.

  • WebHistoryItem.cpp: (WebHistoryItem::hasURLString): isEmpty returns true if there is NO url, not if there is one.
6:07 PM Changeset in webkit [19391] by ggaren
  • 1 edit
    1 add in trunk/LayoutTests

Landing results that I think Maciej intended to land, to get the buildbot
back to green.

  • fast/forms/disabled-select-change-index-expected.txt: Added.
5:25 PM Changeset in webkit [19390] by zimmermann
  • 12 edits
    4 adds in trunk

Reviewed by Sam.

Add support for xml:space="preserve" for SVG text.
It can be modeled by using white-space="pre" and replace \n by spaces.

Handle xml:space="default" correctly.
Always remove tabs from SVG text - as demanded by spec.

Added test: svg/custom/text-whitespace-handling.svg

12:35 PM Changeset in webkit [19389] by ap
  • 5 edits in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12560
W3C XPath test Text_Nodes.svg fails

Covered by dom/svg/level3/xpath/Text_Nodes.svg

  • xml/XPathStep.cpp: (WebCore::XPath::Step::nodeTestMatches): Only include the first text sibling in text() matches.
12:22 PM Changeset in webkit [19388] by ap
  • 4 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12485
XPath id() function doesn't work as root in paths

Test: fast/xpath/id-path.html

  • xml/XPathPath.cpp: (WebCore::XPath::Path::doEvaluate): Implemented. (WebCore::XPath::LocationPath::evaluate): A new overload that takes an initial NodeVector. (WebCore::XPath::LocationPath::doEvaluate): Moved most of the logic to the new evaluate().
  • xml/XPathPath.h: Added a new evaluate() overload and a using declaration to keep the generic one visible.
12:14 PM Changeset in webkit [19387] by ap
  • 2 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12559
REGRESSION: Crash in checkForHeadCharset() under GuardMalloc

No tests possible.

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Fix end of buffer checks; sprinkle a number of new ones over the function.
7:00 AM Changeset in webkit [19386] by weinig
  • 2 edits in trunk/WebKitTools

Reviewed by Mark.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=12555
Drosera doesn't handle CR ( carriage returns ) well

  • Normalize all the line endings.
  • Drosera/debugger.js:
4:16 AM Changeset in webkit [19385] by ddkilzer
  • 2 edits in trunk/WebCore

WebCore:

Reviewed by NOBODY (no-svg build fix).

  • page/EventHandler.cpp: Include FloatPoint.h.
2:53 AM Changeset in webkit [19384] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=12549
Wrong character encoding at www.ravmilim.co.il

Test: fast/encoding/meta-charset.html

  • loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset): Fix an off by one error.

Feb 2, 2007:

9:54 PM Changeset in webkit [19383] by mjs
  • 3 edits
    1 add in trunk

LayoutTests:

Reviewed by Hyatt & Adele.

  • test case for <rdar://problem/4896972> TV guide listings page doesn't finish loading (11674)
  • fast/forms/disabled-select-change-index.html: Added.

WebCore:

Reviewed by Hyatt & Adele.


  • <rdar://problem/4896972> TV guide listings page doesn't finish loading (11674)


Test case: fast/forms/disabled-select-change-index.html


  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::setSelected): Allow changing selected state of a disabled option.
8:16 PM Changeset in webkit [19382] by bdash
  • 3 edits in tags/Safari-521.34

Versioning.

8:11 PM Changeset in webkit [22894] by aliceli1
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Maciej.

Fixed <rdar://4956286> Find: Deleting all text in the Find banner search field should clear the page's selection

  • Interfaces/IWebView.idl:
  • WebView.cpp: (WebView::clearSelection):
  • WebView.h:

Added a clearSelection function to webview so the findbanner can call it.

8:09 PM Changeset in webkit [19381] by bdash
  • 21 edits in tags/Safari-521.34

Roll out r19327.

7:58 PM Changeset in webkit [19380] by bdash
  • 1 copy in tags/Safari-521.34

New tag.

5:36 PM Changeset in webkit [19379] by zimmermann
  • 2 edits in trunk/WebCore

Build fix, not reviewed.
Blind attempt to fix Qt build.

5:33 PM Changeset in webkit [19378] by zimmermann
  • 14 edits
    16 adds in trunk

Reviewed by Eric & Maciej.

Fix serveral <use> issues:

  • When events are dispatch to a referenced element, the actual event.target

has to be set to the corresponding SVGElementInstance object

  • Node::shadowAncestorNode() should _not_ return the shadowParentNode for SVG elements

This is only needed for the HTML forms concept and breaks event dispatching for SVG shadow tree elements.

  • Add SVGElementInstance as possible EventTarget in bindings/js/kjs_dom.cpp

(Now event.target returns the actual SVGElementInstance object for a shadow tree element)

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12502 (Reproducible crash when browsing SVG map.)
Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=12511 (<use> has event dispatching issues)

Added test: svg/custom/use-event-handler-on-use-element.svg
Added test: svg/custom/use-event-handler-on-referenced-element.svg
Added test: svg/custom/use-elementInstance-event-target.svg
Added test: svg/custom/use-elementInstance-methods.svg

5:06 PM Changeset in webkit [19377] by ggaren
  • 3 edits in trunk/WebKitTools

Reviewed by Darin Adler.

Added some more known leaks to the leaks ignore list.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Why does XCode hate itself so much?
  • Scripts/run-webkit-tests:
4:30 PM Changeset in webkit [22893] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Anders.

Fix a crash when running the PLT.

  • WebView.cpp: (WebView::initWithFrame):

Added assertions to make catching this easier.

4:25 PM Changeset in webkit [19376] by oliver
  • 2 edits in trunk/WebCore

2007-02-02 Oliver Hunt <​oliver@apple.com>

Reviewed by Geoff.

Add guard around accessing [NSEvent eventNumber] to ensure
we don't attempt to access it on on non-mouse related NSEvent.

  • platform/mac/PlatformMouseEventMac.mm: (WebCore::eventNumberForEvent): (WebCore::PlatformMouseEvent::PlatformMouseEvent):
3:53 PM Changeset in webkit [19375] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Anders.

Try to be a little less selfish about DocumentLoader.

Spotted while working on <rdar://problem/4957747>.

  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):

Everyone can open frames in new windows.

3:45 PM Changeset in webkit [19374] by zimmermann
  • 9 edits in trunk/WebCore

Reviewed by Eric.

Move xml:space/xml:lang from svgattrs.in to xmlattrs.in where they actually belong.
Now they are actually recognized by SVGLangSpace::parseMappedAttribute.
Patch implementing xml:space="preserve" coming soon, which acts as test for this stuff.

Always build XMLNames.cpp (not only for SVG) and replace all occourences of
"​http://www.w3.org/XML/1998/namespace" by "XMLNames::xmlNamespaceURI".

3:03 PM Changeset in webkit [19373] by bdakin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

Working on a layout test.

Fix for <rdar://problem/4966100> REGRESSION: Reproducible ASSERT
hit at Walgreens.com

  • page/Frame.cpp: (WebCore::Frame::setView): If we are setting the view to 0 and detaching the document, call unscheduleRealyout() on the old view before setting it to 0.
12:42 PM Changeset in webkit [19372] by brmorris
  • 26 edits in S60/branches/3.1m

yongjzha, Reviewed by zalan.

DESC: backport google.com/ig refreshing memory leak fix in <​http://bugs.webkit.org/show_bug.cgi?id=10773> PPEN-6QYG7L
improve stability under low memory condition.
​http://bugs.webkit.org/show_bug.cgi?id=12541

11:57 AM Changeset in webkit [19371] by ggaren
  • 1 edit in trunk/WebKitTools/DumpRenderTree/DumpRenderTree.m

add const back, too

11:56 AM Changeset in webkit [19370] by ggaren
  • 2 edits in trunk/WebKitTools

Even better build fix than the last.

  • ChangeLog:
  • DumpRenderTree/DumpRenderTree.m: (shouldIgnoreWebCoreNodeLeaks):
11:50 AM Changeset in webkit [19369] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

bujtas, Reviewed by yongjun.

Merge of r19368 to 3.1 by Brad.
DESC: browser crashes on www.tays.fi. when multiple layers are referring to the same background image, the render_object does not do proper deref on the image. MLIO-6XJAXG
fix: loop through the background layers and defer background images
​http://bugs.webkit.org/show_bug.cgi?id=12543

11:47 AM Changeset in webkit [19368] by brmorris
  • 2 edits in S60/trunk/WebCore

bujtas, Reviewed by yongjun.

DESC: browser crashes on www.tays.fi. when multiple layers are referring to the same background image, the render_object does not do proper deref on the image.
fix: loop through the background layers and defer background images
​http://bugs.webkit.org/show_bug.cgi?id=12543

10:57 AM Changeset in webkit [19367] by ggaren
  • 2 edits in trunk/WebKitTools

Fixed build. Added work-around for GCC bug.

  • DumpRenderTree/DumpRenderTree.m: (shouldIgnoreWebCoreNodeLeaks):
10:48 AM Changeset in webkit [22892] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2007-02-02 Steve Falkenburg <​sfalken@apple.com>

Fix build.

  • WebCore.vcproj/WebCore.vcproj:
10:36 AM Changeset in webkit [19366] by ggaren
  • 1 edit in trunk/WebKitTools/DumpRenderTree/DumpRenderTree.m

build fix? i don't think so, but let's see...

10:04 AM Changeset in webkit [22891] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore
9:57 AM Changeset in webkit [19365] by darin
  • 2 edits in trunk/JavaScriptCore

Reviewed by Anders.

  • fix copying and assigning a ListHashSet

No test because the code path with bugs I am fixing is not used yet.

  • wtf/ListHashSet.h: Tweaked ListHashSetNodeAllocator a little bit for clarity. Changed m_allocator to be an OwnPtr instead of doing an explicit delete. Fixed bug in copy constructor where we'd have an uninitialized m_allocator. Fixed bug in assignment operator where it would swap only the hash table, and not the head, tail, and allocator pointers.
9:55 AM Changeset in webkit [19364] by ggaren
  • 12 edits in trunk

JavaScriptCore:

Reviewed by Maciej Stachowiak.


Use WTFLog instead of fprintf for logging KJS::Node leaks.

  • kjs/nodes.cpp: (NodeCounter::~NodeCounter): Changed count to unsigned, updated to match style guidelines.

WebCore:

Reviewed by Maciej Stachowiak.


Added support for selectively ignoring WebCore::Node leaks during layout
tests, so that we can ignore known leaks in other components.

  • WebCore.exp:
  • dom/Node.cpp: (WebCore::Node::isSupported): Moved isSupported up with the rest of the static functions.

(WebCore::): Added an ignoreSet, which collects WebCore::Nodes whose lifetime
we want to ignore. We need to track which nodes to ignore rather than, say,
just suspending the count, because node destruction depends on lots of
different variables, so it would be nearly impossible to know when exactly
to suspend the count and when exactly to resume it.

(WebCore::NodeCounter::~NodeCounter): Changed to use WTFLog instead of fprintf.

(WebCore::Node::startIgnoringLeaks): Do the ignoring.
(WebCore::Node::stopIgnoringLeaks): ditto
(WebCore::Node::Node): ditto
(WebCore::Node::~Node): ditto

  • dom/Node.h: Moved isSupported up with the rest of the static functions.
  • platform/mac/LoggingMac.mm: (WebCore::initializeWithUserDefault): Renamed from "initializeLoggingChannel" because the real goal here is to honor a user default -- WTFLoggingChannels need no run-time initialization. Also replaced "off by default, on if a user default says so" behavior with "only override existing setting if a user default says so" behavior. It seemed like a bug that you would specify a channel's on/off state in its definition, but this function would unconditionally blow that state away. (WebCore::InitializeLoggingChannelsIfNecessary):

WebKit:

Reviewed by Maciej Stachowiak.


Added support for selectively ignoring WebCore::Node leaks during layout
tests, so that we can ignore known leaks in other components.

  • Misc/WebCoreStatistics.h:
  • Misc/WebCoreStatistics.mm: (+[WebCoreStatistics startIgnoringWebCoreNodeLeaks]): (+[WebCoreStatistics stopIgnoringWebCoreNodeLeaks]):

WebKitTools:

Reviewed by Maciej Stachowiak.


Added support for selectively ignoring WebCore::Node leaks during layout
tests, so that we can ignore known leaks in other components.

  • DumpRenderTree/DumpRenderTree.m: (shouldIgnoreWebCoreNodeLeaks): Implements a black list of tests whose WebCore::Node leaks we have to ignore. Does this CFString gobbledy-gook confuse anyone else? (runTest):
8:47 AM Changeset in webkit [19363] by brmorris
  • 2 edits in S60/trunk/WebKit

yaharon, Reviewed by Yongjun.

DESC: [S60] FUTE_32: If web page included a link, which name is e.g. T0000900 user can't open it, cause phone starts calling to number 0000900. (KDIS-6XYCL5)
​http://bugs.webkit.org/show_bug.cgi?id=12534

8:28 AM Changeset in webkit [19362] by eseidel
  • 190 edits
    8 adds in trunk

2007-02-02 Eric Seidel <​eric@webkit.org>

Reviewed by mitz.

Fix gradient stop style resolution to be less of a hack, fixing style invalidation:
​http://bugs.webkit.org/show_bug.cgi?id=12193
and fix stop-color and stop-opacity not to inherit:
​http://bugs.webkit.org/show_bug.cgi?id=12193


Tests:

  • svg/custom/gradient-stops-style-change.svg: added
  • svg/W3C-SVG-1.1/pservers-grad-18-b.svg: updated
  • WebCore.xcodeproj/project.pbxproj:
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
  • ksvg2/css/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::inheritedNotEqual): (WebCore::SVGRenderStyle::inheritFrom):
  • ksvg2/css/SVGRenderStyle.h:
  • ksvg2/svg/SVGDefsElement.cpp: (WebCore::SVGDefsElement::createRenderer):
  • ksvg2/svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::createRenderer): (WebCore::SVGGradientElement::buildStops):
  • ksvg2/svg/SVGGradientElement.h: (WebCore::SVGGradientElement::rendererIsNeeded):
  • ksvg2/svg/SVGStopElement.cpp: (WebCore::SVGStopElement::createRenderer):
  • ksvg2/svg/SVGStopElement.h: (WebCore::SVGStopElement::rendererIsNeeded):
  • rendering/RenderSVGGradientStop.cpp: Added.
  • rendering/RenderSVGGradientStop.h: Added.
  • rendering/RenderSVGHiddenContainer.cpp: Added.
  • rendering/RenderSVGHiddenContainer.h: Added.
  • rendering/RenderSVGContainer.cpp:
  • rendering/RenderSVGContainer.h:
6:41 AM Changeset in webkit [19361] by zack
  • 2 edits in trunk/WebCore

Fix scrolling-on-selection bug by correctly
scrolling to the offset instead of trying to
ensure visibility with margins
r=Lars

6:09 AM Changeset in webkit [19360] by bdash
  • 3 edits in tags/Safari-419.1

Versioning.

6:07 AM Changeset in webkit [19359] by bdash
  • 1 copy in tags/Safari-419.1

New tag.

6:06 AM Changeset in webkit [19358] by bdash
  • 6 edits in branches/Safari-2-0-branch

Update bundle identifiers.

4:27 AM Changeset in webkit [22890] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Turn on Lucida Grande.

3:06 AM Changeset in webkit [22889] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Maciej.

Implemented menulist drawing.

2:26 AM Changeset in webkit [19357] by zack
  • 1 edit in trunk/WebCore/platform/graphics/qt/GraphicsContextQt.cpp

actually set the pen on color setting

2:24 AM Changeset in webkit [19356] by zack
  • 2 edits in trunk/WebCore

Fix drawing of dashed and colored lines. Pen
has to be inherited for stroke to stay consistent.
r=Lars

1:49 AM Changeset in webkit [19355] by zack
  • 2 edits in trunk/WebKitQt

Compilation fix: forward declare d-ptr.

1:35 AM Changeset in webkit [19354] by mjs
  • 2 edits in trunk/JavaScriptCore
  • not reviewed, build fix
  • wtf/ListHashSet.h: (WTF::ListHashSetNodeAllocator::ListHashSetNodeAllocator): ummm, use union correctly
1:14 AM Changeset in webkit [19353] by mjs
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Reviewed by Darin.


  • use a custom allocator for ListHashSet, to fix ~1% perf regression using it for form control
  • wtf/ListHashSet.h: (WTF::ListHashSetNodeAllocator::ListHashSetNodeAllocator): (WTF::ListHashSetNodeAllocator::allocate): (WTF::ListHashSetNodeAllocator::deallocate): (WTF::ListHashSetNode::operator new): (WTF::ListHashSetNode::operator delete): (WTF::ListHashSetNode::destroy): (WTF::ListHashSetTranslator::translate): (WTF::::ListHashSet): (WTF::::~ListHashSet): (WTF::::add): (WTF::::unlinkAndDelete): (WTF::::deleteAllNodes):
1:09 AM Changeset in webkit [19352] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.


  • use a custom allocator for ListHashSet, to fix ~1% per regression using it for form control
  • wtf/ListHashSet.h: (WTF::ListHashSetNodeAllocator::ListHashSetNodeAllocator): (WTF::ListHashSetNodeAllocator::allocate): (WTF::ListHashSetNodeAllocator::deallocate): (WTF::ListHashSetNode::operator new): (WTF::ListHashSetNode::operator delete): (WTF::ListHashSetNode::destroy): (WTF::ListHashSetTranslator::translate): (WTF::::ListHashSet): (WTF::::~ListHashSet): (WTF::::add): (WTF::::unlinkAndDelete): (WTF::::deleteAllNodes):
12:41 AM Changeset in webkit [19351] by zack
  • 3 edits in trunk/WebKitQt

Make the frames white by default and get the
files that WebCore can handle render inside
the frames.
r=Lars

Note: See TracTimeline for information about the timeline view.