Timeline



Feb 16, 2007:

10:33 PM Changeset in webkit [19675] by kjk
  • 4 edits
    1 add in trunk/WebCore

Reviewed by Adam Roben.

Move Path implementation from TemporaryLinkStubs.cpp to
its own file.
Implement setLineCap, setLineJoin and setMiterLimit for
cairo's GraphicsContext.

  • WebCoreSources.bkl:
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit):
  • platform/graphics/cairo/PathCairo.cpp: Added. (WebCore::Path::Path): (WebCore::Path::~Path): (WebCore::Path::contains): (WebCore::Path::translate): (WebCore::Path::boundingRect): (WebCore::Path::operator=): (WebCore::Path::clear): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArcTo): (WebCore::Path::closeSubpath): (WebCore::Path::addArc): (WebCore::Path::addRect): (WebCore::Path::addEllipse): (WebCore::Path::transform): (WebCore::Path::apply):
9:00 PM Changeset in webkit [19674] by staikos
  • 2 edits in trunk/JavaScriptCore

Fix uninitialized variable

8:39 PM Changeset in webkit [19673] by adachan
  • 2 edits in trunk/WebCore

2007-02-16 Ada Chan <​adachan@apple.com>

Reviewed by Adam and Maciej.

Use a RefPtr to store the old hover node.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateHoverActiveState):


5:15 PM Changeset in webkit [19672] by darin
  • 4 edits in trunk/WebCore

Reviewed by Adele.

  • fix <rdar://problem/4990864> ASSERT in FormDelegate.m while dragging text between frames

This symptom is specific to Safari, so no layout test.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply): Only call textWillBeDeletedInTextField if the text field is focused.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::aboutToUnload): Only call textFieldDidEndEditing if the text field is focused. (WebCore::HTMLInputElement::dispatchBlurEvent): Remove unneeded type cast. (WebCore::HTMLInputElement::defaultEventHandler): Only call doTextFieldCommandFromEvent if the text field is focused.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::subtreeHasChanged): Only call textDidChangeInTextArea, textFieldDidBeginEditing, and textDidChangeInTextField if the element is focused.
5:04 PM Changeset in webkit [19671] by hyatt
  • 2 edits in trunk/WebCore/platform

API tweaks to widget and scrollview.

5:04 PM Changeset in webkit [22954] by hyatt
  • 4 edits in branches/WindowsMerge/WebCore

Fix RSS scrollbar.

4:31 PM Changeset in webkit [19670] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher

  • fixed <rdar://problem/4811446> "Check Grammar" checkbox in Spelling+Grammar window doesn't live update with menu change in WebKit
  • WebView/WebView.mm: (-[WebView setGrammarCheckingEnabled:]): Use sekrit AppKit knowledge to tell NSSpellChecker about the change, since there's no API for this yet. Also restructured a little to avoid extra work when the value hasn't changed.
3:59 PM WikiStart edited by Adam Roben
Added login link (diff)
3:58 PM WikiStart edited by Adam Roben
Added registration link (diff)
3:48 PM Changeset in webkit [22953] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Rubberstamped by Anders.

3:21 PM Changeset in webkit [19669] by brmorris
  • 3 edits in S60/trunk/WebKit

wei, reviewed by zalan. reverted and re-merged by mbradley

DESC: Reverts r19963 and re-applies with and updated patch. PNIO-6YFCUT conversion problem w/ google search
​http://bugs.webkit.org/show_bug.cgi?id=12792

3:05 PM Changeset in webkit [19668] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

sareen, Reviewed by yongjun

DESC: Browser crash when exited upon loading JKRL-6Y9HXC
​http://bugs.webkit.org/show_bug.cgi?id=12772

2:29 PM Changeset in webkit [19667] by andersca
  • 4 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/4943985>
REGRESSION: Dragging standalone images to Finder fails to download the image file


Set the data and response on the image resource. Also, since this is platform-independent we don't need to do it in
ImageDocumentMac.mm


  • loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish):
  • loader/mac/ImageDocumentMac.h:
  • loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):
2:02 PM Changeset in webkit [22952] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

ScrollView fixes.

1:56 PM Changeset in webkit [19666] by darin
  • 3 edits in trunk/JavaScriptGlue

Reviewed by Anders.

  • fix <rdar://problem/5000216> JavaScriptGlue framework started turning all CFNumbers into signed 32bit values

Circumstantial evidence seems to indicate that JavaScriptGlue was depending on a bug
in CFNumber where CFNumberIsFloatType was returning true for 64-bit integer values.

  • JSUtils.cpp: (JSObjectKJSValue): Removed the call to CFNumberIsFloatType in the conversion of numeric values, and always use kCFNumberDoubleType, since double is the internal format of numbers in JavaScriptCore. There's no value to having a separate code path for integers. There's also no reason to check the return value from CFNumberGetValue -- if it returns false it still does the best it can to convert to a double, which is what we want.
  • UserObjectImp.cpp: (UserObjectImp::toString): Removed a similar code path that tried to handle integers separate from double. Instead, always use a double. For compatibility, use a format without a decimal point when CFNumberIsFloatType returns false. Also removed a bogus cast to float; the "%f" format string takes a double, not a float, so all the cast did was cut down on precision.
1:54 PM Changeset in webkit [19665] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5004746> Need mechanism to protect against WebKit calls from secondary threads (DOM APIs)

  • platform/mac/LoggingMac.mm: (WebCore::_WebCoreThreadViolationCheck): Change the default to log the violations.
12:52 PM Changeset in webkit [19664] by zbujtas
  • 3 edits in S60/branches/3.1m/WebKit

w3liu, reviewed by zalan

DESC: PNIO-6YFCUT: Strange conversion problem (in get " changed to %2522 instead of %22) with for example google search.
​http://bugs.webkit.org/show_bug.cgi?id=12792

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::LoadUrlL):
  • ResourceLoader/src/UrlRequestInfo.cpp: (CUrlRequestInfo::SetUrlL):
12:13 PM Changeset in webkit [19663] by brmorris
  • 5 edits in S60/trunk

w3liu, reviewed by zalan

DESC: PNIO-6YFCUT: Strange conversion problem (in get " changed to %2522 instead of %22) with for example google search.
​http://bugs.webkit.org/show_bug.cgi?id=12792

12:07 PM Changeset in webkit [22951] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/4993040>
Crash in plugin code watching yahoo news video


Zero out the plugin function struct.


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load):
11:41 AM Changeset in webkit [22950] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fixes.


  • WebDownload.cpp: (WebDownload::init): (WebDownload::initWithRequest):
11:40 AM Changeset in webkit [19662] by adele
  • 10 edits in trunk/WebCore

Reviewed by Mitz.

Fixed: ​http://bugs.webkit.org/show_bug.cgi?id=12768
<rdar://problem/4995250> REGRESSION: Crash occurs at WebCore::RenderLayer::scrollToOffset() when leaving page that has focus in field

No test case added. This crash doesn't occur in DumpRenderTree because the B/F cache is turned off.

  • dom/Node.cpp: (WebCore::Node::willRemove): Check that the document is not in the page cache before
  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance): Added restorePreviousSelection argument, with appropriate default values.
  • dom/Element.h: ditto.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateFocusAppearance): ditto.
  • html/HTMLInputElement.h: ditto.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateFocusAppearance): ditto.
  • html/HTMLTextAreaElement.h: ditto.
  • page/PageState.cpp: (WebCore::PageState::restore): Call updateFocusAppearance on the focused node for this page. Pass true for the restorePreviousSelection argument.
  • rendering/RenderLayer.cpp: Added ASSERTS and nil checks on the RenderView. It shouldn't be null, but if it is, we'll fail silently on release builds. (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::windowClipRect): (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::intersectsDamageRect): (WebCore::RenderLayer::absoluteBoundingBox):
11:16 AM Changeset in webkit [19661] by andersca
  • 2 edits in trunk/JavaScriptCore

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=12788
REGRESSION: Going back one page in history has a noticeable delay


Um...if all elements in two vectors are equal, then I guess we could say that
the two vectors are equal too.


  • wtf/Vector.h: (WTF::):
11:03 AM Changeset in webkit [22949] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Fix build.

Use adoptCF instead of adopt.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start):
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest):
11:00 AM Changeset in webkit [19660] by andersca
  • 6 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4993055> auto_refcount_underflow_error: WebCore::FrameLoader::continueAfterNavigationPolicy () over-releases under GC

Add ::adoptNS and ::adoptCF methods to RetainPtr to indicate what type of reference to adopt.


  • platform/cf/RetainPtr.h: (WebCore::): (WebCore::adoptNSReference): (WebCore::RetainPtr::RetainPtr): (WebCore::::adoptCF): (WebCore::::adoptNS):
  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::FileChooser):
  • platform/network/mac/ResourceErrorMac.mm: (WebCore::ResourceError::operator NSError*):
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest):
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::nsURLResponse):
10:58 AM WebKit Team edited by sullivan@apple.com
(diff)
8:56 AM Known incompatibilities between open-source WebKit and Safari edited by ddkilzer@webkit.org
(diff)
8:56 AM Known incompatibilities between open-source WebKit and Safari edited by ddkilzer@webkit.org
(diff)
8:52 AM Known incompatibilities between open-source WebKit and Safari edited by ddkilzer@webkit.org
(diff)
8:31 AM Changeset in webkit [19659] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

hongzhao, Reviewed by Yongjun.

DESC: Merge of 19656 to 3.1m branch (Browser Security -Redirection of form submission to another site has a wrong softkey on conformation query. ISHG-6Q2ST8)
Fix: Change the confirmation query softkey buttons to Yes|No
​http://bugs.webkit.org/show_bug.cgi?id=12742

8:27 AM Changeset in webkit [19658] by brmorris
  • 2 edits in S60/trunk/WebKit

sareen, Reviewed by <​yongjun.zhang@nokia.com>.

DESC: Browser crash when exited upon loading. JKRL-6Y9HXC
​http://bugs.webkit.org/show_bug.cgi?id=12772

8:24 AM Changeset in webkit [19657] by brmorris
  • 3 edits in S60/trunk/WebKit

raalexan, reviewed by Yongjun

DESC: 3.2:webkit "page not found" problem, which is before TelService be launched (TLUU-6YDPRT)
​http://bugs.webkit.org/show_bug.cgi?id=12771

8:22 AM Changeset in webkit [19656] by brmorris
  • 2 edits in S60/trunk/WebKit

hongzhao, reviewed by Yongjun

DESC: [S60] Browser Security -Redirection of form submission to another site has a wrong softkey on conformation query.ISHG-6Q2ST8
Fix: Change the confirmation query softkey buttons to Yes|No
​http://bugs.webkit.org/show_bug.cgi?id=12742

8:20 AM Changeset in webkit [19655] by brmorris
  • 2 edits in S60/trunk/WebKit

sareen Reviewed by <​yongjun.zhang@nokia.com>.

DESC: Selection list not shown correctly in www.elisa.fi [ TSW ID: HMNN-6XQJMX]
​http://bugs.webkit.org/show_bug.cgi?id=12719

8:18 AM Changeset in webkit [19654] by brmorris
  • 3 edits in S60/trunk/WebKit

raalexan, Reviewed by Yongjun

DESC: When application is launched via hyperlink, the cursor stays as wait cursor (TSW EAJA-6VDH84)
​http://bugs.webkit.org/show_bug.cgi?id=12715

3:35 AM Changeset in webkit [22948] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Oliver.

Implemented square button look.

Feb 15, 2007:

9:19 PM Changeset in webkit [19653] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Lost Objective-C Hippyness (or hippiness)

Oh boy, did I ever botch this one up...

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem): Null check the FrameView
8:44 PM Changeset in webkit [19652] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Adam's complaint

aroben wanted me to do an early return, instead.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem):
8:40 PM Changeset in webkit [19651] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Adele

Forgot to bring the null check with me when I backed this code out of
the FrameLoaderClient

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem): null check the HistoryItem
8:19 PM Changeset in webkit [22947] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-02-15 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.


<rdar://problem/5001181> Crash: autofilling empty page


Return an error from WebFrame::DOMDocument if there's no document

  • WebFrame.cpp: (WebFrame::DOMDocument): null document now maps to E_FAIL
8:13 PM Changeset in webkit [22946] by beidson
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Adam

<rdar://4778394> - Save scroll position in the back/forward list


  • WebFrame.cpp: (WebFrame::restoreViewState): Renamed, as scroll position was pushed to WebCore (WebFrame::saveViewStateToItem): Ditto
  • WebFrame.h:
8:11 PM Changeset in webkit [19650] by beidson
  • 11 edits in trunk

WebCore:

Reviewed by Adam

Save scroll state for back/forward navigation in FrameLoader, not the client

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::saveScrollPositionAndViewStateToItem): Actually save the scroll position here instead of asking the FrameLoaderClient (WebCore::FrameLoader::restoreScrollPositionAndViewState): Ditto
  • loader/FrameLoaderClient.h: Renamed/repurposed 2 methods
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::restoreViewState): Ditto (WebCore::SVGEmptyFrameLoaderClient::saveViewStateToItem): Ditto

WebKit:

Reviewed by Adam

Save scroll state for back/forward navigation in FrameLoader, not the client

  • WebCoreSupport/WebFrameLoaderClient.h: Renamed the save/restore methods
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::saveViewStateToItem): Save viewstate only (WebFrameLoaderClient::restoreViewState): Restore viewstate only

WebKitQt:

Reviewed by Adam

Moved scroll state down into the cross platform FrameLoader -
Blind attempt at keeping Qt building

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::restoreViewState): (WebCore::FrameLoaderClientQt::saveViewStateToItem):
  • WebCoreSupport/FrameLoaderClientQt.h:
8:00 PM Changeset in webkit [19649] by bdash
  • 2 edits in trunk/WebKitTools

2007-02-16 Mark Rowe <​mrowe@apple.com>

Not reviewed.

<rdar://problem/4982312> leaks bot should run in normal mode, rather than quiet mode

  • BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Switch back to default verbosity for output of leaks tests.
6:35 PM Changeset in webkit [19648] by justing
  • 10 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4989774>
REGRESSION: Pasting a image into a plain text message can place image on a new line

Added:

  • editing/pasteboard/4989774-expected.checksum: Added.
  • editing/pasteboard/4989774-expected.png: Added.
  • editing/pasteboard/4989774-expected.txt: Added.
  • editing/pasteboard/4989774.html: Added. Equivalent trees:
  • editing/deleting/delete-3857753-fix-expected.txt:
  • editing/pasteboard/paste-list-001-expected.txt:
  • editing/pasteboard/paste-table-001-expected.txt:
  • editing/pasteboard/paste-text-001-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
  • editing/pasteboard/paste-text-at-tabspan-003-expected.txt:

WebCore:

Reviewed by harrison


<rdar://problem/4989774>
REGRESSION: Pasting a image into a plain text message can place image on a new line

<span><img><span><img></span></span> will appear as two
images on different lines because of a layout/rendering
bug. This patch avoids the bug by producing cleaner
markup so that the paste code can safely remove the style
spans.

  • editing/markup.cpp: (WebCore::createMarkup): Get the default style from the editable root or body instead of the document element. This produces cleaner markup since we don't inline the root's styles.
5:47 PM Changeset in webkit [19647] by kjk
  • 3 edits
    2 copies in trunk/WebCore

Reviewed by Adam Roben.

Add gdk version of ContextMenuClient based on qt version.

  • WebCoreSources.bkl:
  • page/gdk/ContextMenuClientGdk.cpp: Added. (WebCore::ContextMenuClientGdk::contextMenuDestroyed): (WebCore::ContextMenuClientGdk::getCustomMenuFromDefaultItems): (WebCore::ContextMenuClientGdk::contextMenuItemSelected): (WebCore::ContextMenuClientGdk::downloadURL): (WebCore::ContextMenuClientGdk::copyImageToClipboard): (WebCore::ContextMenuClientGdk::searchWithGoogle): (WebCore::ContextMenuClientGdk::lookUpInDictionary): (WebCore::ContextMenuClientGdk::speak): (WebCore::ContextMenuClientGdk::stopSpeaking):
  • page/gdk/ContextMenuClientGdk.h: Added.
  • webcore-base.bkl: curl is needed when building webcore_base files.
5:07 PM Changeset in webkit [22945] by aroben
  • 4 edits in branches/WindowsMerge/WebKitWin

WebKitWin:

Reviewed by Anders.

Fix <rdar://problem/4968731> Printing scales frames to page width
instead of doing a layout at that width

  • Interfaces/IWebFramePrivate.idl: Added setInPrintingMode method.
  • WebFrame.cpp: (WebFrame::WebFrame): Initialize new member. (printerRect): New helper function. (WebFrame::setPrinting): Ported from WebHTMLView. (WebFrame::setInPrintingMode): Implemented. (WebFrame::computePageRects): Changed to store the page rects. (WebFrame::getPrintedPageCount): Added an ASSERT and updated for change to computePageRects. (WebFrame::spoolPages): Use the stored page rects, and set mediaBox's size using the print rect instead of the page rect so we will scale the pages to the full width of the print DC. (WebFrame::forceLayoutWithPageWidthRange): Ported from WebFrameBridge.
  • WebFrame.h: Updated declarations.
3:58 PM Changeset in webkit [22944] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

3:57 PM Changeset in webkit [19646] by sfalken
  • 1 copy in tags/Safari-521.34.5b

New tag.

2:35 PM Changeset in webkit [22943] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Add the default Flash plugin location to the list of plugin paths.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::addFlashPluginPath): (WebCore::PluginDatabaseWin::defaultPluginPaths):
2:13 PM Changeset in webkit [22942] by sfalken
  • 6 edits in branches/WindowsMerge

2007-02-15 Lou Amadio <​lamadio@apple.com>

Reviewed by Steve.

<rdar://problem/4945799> CGText: should use correct mechanism to set font smoothing style


  • WebKit.vcproj/WebKit.vcproj:
  • WebPreferences.cpp: (WebPreferences::setFontSmoothing):
  • WebView.cpp: (WebViewWndProc):

2007-02-15 Lou Amadio <​lamadio@apple.com>

Reviewed by Steve.

<rdar://problem/4945799> CGText: should use correct mechanism to set font smoothing style


  • platform/win/FontWin.cpp: (WebCore::Font::drawGlyphs):

2007-02-15 Lou Amadio <​lamadio@apple.com>

Reviewed by Steve.

<rdar://problem/4945799> CGText: should use correct mechanism to set font smoothing style

2007-02-15 Lou Amadio <​lamadio@apple.com>

Reviewed by Steve.

Added WebKitSystemInterfaceWin

2:10 PM Changeset in webkit [19645] by kdecker
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Fixed: <rdar://problem/4983883> Background of a .mov window should not be white

  • loader/PluginDocument.cpp: (WebCore::PluginTokenizer::createDocumentStructure): Set a background color of gray for full frame plug-ins, which makes it easier on the eyes. It's also the same gray that PDFKit uses, too.
2:05 PM Changeset in webkit [19644] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Darin.

The problem was that selectionRect() was being called on a render tree that
had pending style changes. The changes were committed as a side effect in
the middle of traversing the render tree, and the current object got
deleted as a result. The solution is to update the render tree before
starting to traverse it.

The inspector was affected because it makes style changes in response to
an AppKit notification that's sent right before the windowDidResignKey:
notification, under which WebKit calls selectionRect(). I couldn't recreate
the same conditions (having uncommitted style changes in the tree when the
window becomes inactive) using HTML/JS in Safari, hence the lack of
a regression test to go with this patch.

  • rendering/RenderView.cpp: (WebCore::RenderView::selectionRect): Added call to updateRendering().
1:03 PM Changeset in webkit [19643] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Document::removeMarkers() was using a Vector iterator (which is just a
pointer) and inserting into the Vector at the same time, which made the
iterator invalid as the Vector's data buffer was relocated.


Replaced all instances of Vector<DocumentMarker>::iterator with indices.

  • dom/Document.cpp: (WebCore::Document::addMarker): (WebCore::Document::copyMarkers): (WebCore::Document::removeMarkers): (WebCore::Document::repaintMarkers): (WebCore::Document::shiftMarkers):
12:51 PM Changeset in webkit [22941] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/4987529>
Regression: first clicks don't work at flash-based Nokia.com

  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::handleMouseEvent): Don't set buttons for mouse move. Also, ignore unknown mouse events.
11:00 AM Changeset in webkit [19642] by darin
  • 2 edits in trunk/WebKitSite
  • projects/performance/index.html: Fix i-Bench link.
10:46 AM Changeset in webkit [19641] by weinig
  • 7 edits in trunk

LayoutTests:

Reviewed by Darin.

  • tables/mozilla/bugs/bug45486-expected.checksum:
  • tables/mozilla/bugs/bug45486-expected.png:
  • tables/mozilla/bugs/bug45486-expected.txt:
  • tables/mozilla_expected_failures/core/col_span2-expected.txt:

WebCore:

Reviewed by Darin.

Fixes existing layout tests: tables/mozilla/bugs/bug45486.html

tables/mozilla_expected_failures/core/col_span2.html

  • rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcEffectiveWidth): Fixed a mismatch between which columns count as percentage columns when adding up the total percent and which columns count as percentage columns when converting non-percentage columns to effectively-percentage.
10:21 AM Changeset in webkit [19640] by ggaren
  • 2 edits in trunk/WebKitTools

Reviewed by Beth Dakin.


  • DumpRenderTree/DumpRenderTree.m: Don't ignore NSAttributedString WebCore::Node leaks anymore, either, since r19486 fixed them, too. (shouldIgnoreWebCoreNodeLeaks):
9:47 AM Changeset in webkit [19639] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Don't ignore NSAttributedString leaks any more. Those were fixed by change 19486.
9:29 AM Changeset in webkit [19638] by ggaren
  • 2 edits in trunk/WebKitTools

Reviewed by Beth Dakin.


Ignore another leak, seen recently on the buildbot.

  • Scripts/run-webkit-tests:

Feb 14, 2007:

9:51 PM Changeset in webkit [19637] by bdash
  • 2 edits
    1 add in trunk/WebCore

2007-02-14 Mitz Pettel <​mitz@webkit.org>

Reviewed by Sam Weinig!

  • manual-tests/background-image-change-in-page-cache.html: Added.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::imageChanged): Bail out if the object is not in a view, which can happen if the document is in the page cache and the same cached image used for its background is also being used in another document that is currently in view.
7:17 PM Changeset in webkit [19636] by aroben
  • 10 edits
    1 copy
    1 add in trunk

LayoutTests:

Reviewed by Darin.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=12517
<rdar://problem/4971227> REGRESSION: Tab order incorrect when input
inside frame/iframe gets initial focus (12517)

  • fast/events/frame-programmatic-focus-expected.txt: Added.
  • fast/events/frame-programmatic-focus.html: Added.
  • fast/forms/focus2-expected.txt: Updated results to now-correct behavior.

WebCore:

Reviewed by Darin.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=12517
<rdar://problem/4971227> REGRESSION: Tab order incorrect when input
inside frame/iframe gets initial focus (12517)

Test: fast/events/frame-programmatic-focus.html

  • dom/Element.cpp: (WebCore::Element::focus): Call FocusController::setFocusedNode to set the focus for the whole page.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::focus): Ditto.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::focus): Ditto.
  • page/EventHandler.cpp: (WebCore::EventHandler::handleTextInputEvent): Send the textInput event to the same target that was sent the keypress event before it.
  • page/FocusController.cpp: (WebCore::FocusController::advanceFocus): Added a FIXME. (WebCore::FocusController::setFocusedNode): Added. Sets the focused node for a whole page.
  • page/FocusController.h: Added declaration.
  • platform/cf/RetainPtr.h: Removed unused pointer_cast functions.
5:15 PM Changeset in webkit [19635] by justing
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by adele


<rdar://problem/4976800>
Outdent combines 2 separate strings on 2 different lines

  • editing/execCommand/4976800-expected.txt: Added.
  • editing/execCommand/4976800.html: Added.

WebCore:

Reviewed by adele


<rdar://problem/4976800>
Outdent combines 2 separate strings on 2 different lines

  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph): Add line breaks if removing the indented node causes content before or after it to collapse into the same paragraph as its content.
5:11 PM Changeset in webkit [19634] by justing
  • 2 edits
    8 adds in trunk

Reviewed by adele


<rdar://problem/4960120>
REGRESSION: First Enter key ignored on initial focus of textarea after page load (11967)


We'd insert a newline, but into an empty div. We need two newlines
in that case.

  • editing/InsertLineBreakCommand.cpp: (WebCore::lineBreakExistsAtPosition): Returns true if there is a br or a '\n' in text that preserves newlines at the incoming position. (WebCore::InsertLineBreakCommand::doApply): Fixed to handle the empty block case, the anonymous block case.
4:35 PM Changeset in webkit [19633] by darin
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/forms/select-enter-key-expected.txt: Added.
  • fast/forms/select-enter-key.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/forms/select-enter-key.html

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Add code to submit when someone hits the Enter key.
3:50 PM Changeset in webkit [19632] by andersca
  • 4 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4960112>
​http://bugs.webkit.org/show_bug.cgi?id=12417
REGRESSION: "Are you sure you want to send a form again?" sheet is displayed twice (validator.w3.org)


The problem was that doing a reload would cause the "Cache-Control" HTTP header to be set on the request _after_ the first
navigation policy delegate callback was called. This would break the request equality check that's used to prevent multiple policy
delegate callbacks from getting called for the same request. The solution is to set the header as early as possible.


This patch also fixes some bugs in the ResourceRequest equality operator.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::reload): Set the "Cache-Control" header field on the request here.


  • platform/network/FormData.h: (WebCore::operator==): Short-circuit if the pointers are the same.


  • platform/network/ResourceRequest.cpp: (WebCore::operator==): Check the equality of the objects, not the pointers.
3:42 PM Changeset in webkit [19631] by andersca
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

Add new canCompareWithMemcmp vector trait and use it to determine whether
operator== can use memcmp.


  • wtf/Vector.h: (WTF::): (WTF::VectorTypeOperations::compare): (WTF::operator==):
  • wtf/VectorTraits.h: (WTF::):
3:31 PM Changeset in webkit [19630] by hyatt
  • 3 edits
    1 delete in trunk/WebCore

Move setPlatformData out of FontFallbackListMac.mm and delete the file. The function was completely
cross-platform already.

Reviewed by Ada

  • WebCore.xcodeproj/project.pbxproj:
  • platform/FontFallbackList.cpp: (WebCore::FontFallbackList::setPlatformFont):
2:29 PM Changeset in webkit [19629] by hyatt
  • 4 edits in trunk/WebCore

Make the Font constructor that takes a FontPlatformData cross-platform, since the implementation was already
completely cross-platform.

Reviewed by Ada

  • platform/Font.cpp: (WebCore::Font::Font):
  • platform/Font.h:
  • platform/mac/FontMac.mm:
1:44 PM Changeset in webkit [19628] by antti
  • 2 edits in trunk/WebCore

Reverting ​http://bugs.webkit.org/show_bug.cgi?id=11974, it causes repainting problems in some cases.

  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::avoidsFloats):
12:44 PM Changeset in webkit [19627] by ggaren
  • 5 edits in trunk/LayoutTests

Reviewed by Darin Adler, tweaked and committed by Geoff Garen.


Reverting my fix for find-after-replace.html and committing this one because
its results don't rely on an editing bug and because stomping bugzilla patches
is just plain uncivilized.

  • editing/execCommand/find-after-replace.html: Use the frame's onload handler instead of relying on a timeout. Force a layout to get a correct render tree when dumping. (This requirement may be an editing bug.)
11:02 AM Changeset in webkit [19626] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/forms/textfield-overflow-expected.checksum: Added.
  • fast/forms/textfield-overflow-expected.png: Added.
  • fast/forms/textfield-overflow-expected.txt: Added.
  • fast/forms/textfield-overflow.html: Added.

WebCore:

Reviewed by Maciej.



Set controlClip for non-search text controls.

  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::hasControlClip):
10:01 AM Changeset in webkit [19625] by ap
  • 2 edits in trunk/WebKit

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12643
NPN_Status is using latin-1 encoding for the message instead of UTF-8

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView status:]): Check for possible conversion failure.
9:17 AM Changeset in webkit [19624] by ggaren
  • 2 edits in trunk/WebKitTools

Reviewed by Beth Dakin.


Ignore another leak, seen recently on the buildbot.

  • Scripts/run-webkit-tests:
9:15 AM Changeset in webkit [19623] by brmorris
  • 2 edits in S60/trunk/WebKit

DESC: add widget registry client dll to rom image via webkit.iby
​http://bugs.webkit.org/show_bug.cgi?id=12765

9:13 AM Changeset in webkit [19622] by ggaren
  • 5 edits in trunk/LayoutTests

Reviewed by Beth Dakin.


Blind attempt to make this test more reliable. (It fails intermittently
on the buildbot.)

  • editing/execCommand/find-after-replace-expected.checksum:
  • editing/execCommand/find-after-replace-expected.png:
  • editing/execCommand/find-after-replace-expected.txt:
  • editing/execCommand/find-after-replace.html: Use a load event handler instead of a 100ms timer. There's no guarantee that everything will be done loading in under 100ms (and there's no reason to wait that long all the time, either!).
6:10 AM Changeset in webkit [19621] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/text/break-word-expected.checksum: Added.
  • fast/text/break-word-expected.png: Added.
  • fast/text/break-word-expected.txt: Added.
  • fast/text/break-word.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/text/break-word.html

The wrapW variable used to keep track of the width of the characters scanned
so far by adding up the widths of individual characters. Because of the
rounding hack, the total ended up being bigger than the width of the same characters
when measured together as a single run.

The fix is to use wrapW only as an upper bound, and once it overflows the line's width,
fall back on measuring everything from the beginning of the line as one run.

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Implemented the above fix, including not measuring additional single characters once wrapW overflows the line. Also moved the assignment to breakNBSP out of the loop since it is constant for the entire text object, made breakWords and midWordBreak update only when they might change, and cleaned up a few things.
2:52 AM Changeset in webkit [19620] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.


  • fast/forms/password-placeholder-expected.checksum: Added.
  • fast/forms/password-placeholder-expected.png: Added.
  • fast/forms/password-placeholder-expected.txt: Added.
  • fast/forms/password-placeholder.html: Added.

WebCore:

Reviewed by Hyatt.


Disable textSecurity when placeholder is visible.


  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::updatePlaceholder):

Feb 13, 2007:

10:31 PM Changeset in webkit [22940] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-02-13 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.


Send tab keypresses to IWebFormDelegate::doCommandBySelector.

  • WebEditorClient.cpp: (WebEditorClient::handleKeyPress): Call doTextFieldCommandFromEvent if we get a tab keypress
9:23 PM Changeset in webkit [19619] by ap
  • 3 edits
    2 adds in trunk

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=12763
REGRESSION: button title is displayed incorrectly at quotes.burntelectrons.org

Test: fast/parser/entities-in-attributes.xhtml

  • dom/XMLTokenizer.cpp: (WebCore::getEntityHandler): Set a correct type for the found entity (I'm not really sure if XML_INTERNAL_GENERAL_ENTITY is _the_ correct one, but it fixes the problem).
8:10 PM Changeset in webkit [22939] by beidson
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam

Switch permanently from CFStreamError to CFErrorRef in ResourceHandleCF

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::didFail): (WebCore::ResourceHandle::start):
7:11 PM Changeset in webkit [19618] by weinig
  • 2 edits in trunk/LayoutTests

Reviewed by Mark.

  • fast/dom/Window/window-properties-expected.txt: Update results.
6:05 PM Changeset in webkit [19617] by darin
  • 10 edits in trunk/WebCore

Reviewed by Hyatt.

  • removed some bogus names (Hyatt smacked me since this doesn't fix a P1)
  • dom/EventNames.h: Removed half-implemented khtmlDragdrop and khtmlMove (you could add listeners, but nobody ever sent the events). Renamed the other two khtml-prefixed internal event names to use the webkit prefix.
  • bindings/js/kjs_dom.cpp: (KJS::DOMEventTargetNode::getValueProperty): Removed ondragdrop and onmove. (KJS::DOMEventTargetNode::putValueProperty): Ditto.
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): Ditto. (KJS::Window::put): Ditto.
  • bindings/js/kjs_window.h:
  • dom/BeforeTextInsertedEvent.cpp: (WebCore::BeforeTextInsertedEvent::BeforeTextInsertedEvent): Renamed to webkit.
  • editing/Editor.cpp: (WebCore::dispatchEditableContentChangedEvents): Ditto.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplacementFragment::ReplacementFragment): Ditto.
  • html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLTextFieldInnerTextElement::defaultEventHandler): Ditto.
5:39 PM Changeset in webkit [19616] by darin
  • 2 edits in trunk/WebCore

Rubber stamped by Maciej.

  • dom/EventNames.h: Resort names. Removed unused names.
5:24 PM Changeset in webkit [22938] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

5:23 PM Changeset in webkit [19615] by sfalken
  • 1 copy in tags/Safari-521.34.4b

New tag.

2:57 PM Changeset in webkit [19614] by oliver
  • 2 edits in trunk/WebKit

2007-02-13 Oliver Hunt <​oliver@apple.com>

Reviewed by John.

Modify entry point ASSERTs for dragging functions to allow for the case
where a load has occurred mid-drag. The load may detach the HTMLView
from the WebView so it is no longer possible to check _isTopHTMLView.

The assertion changes match that of revision 14897 which fixed the
more common case ([WebHTMLView draggedImage:endedAt:operation:])

It's also necessary to check for a null Page now prior to accessing
the DragController, which is necessary in all of these methods.

See rdar://problem/4994870


  • WebView/WebHTMLView.mm: (-[WebHTMLView draggingSourceOperationMaskForLocal:]): (-[WebHTMLView draggedImage:movedTo:]): (-[WebHTMLView draggedImage:endedAt:operation:]): (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
2:44 PM Changeset in webkit [22937] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj: Remove SVGDOMImplementation.(cpp|h)
2:19 PM Changeset in webkit [19613] by beidson
  • 2 edits in trunk/JavaScriptCore

Tweaked Vector a bit

1:47 PM Changeset in webkit [19612] by andersca
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Kevin Decker.

<rdar://problem/4990049>
​http://bugs.webkit.org/show_bug.cgi?id=12718
REGRESSION: Segmentation fault when loading abc.go.com (12718)

  • http/tests/misc/redirect-to-about-blank-expected.txt: Added.
  • http/tests/misc/redirect-to-about-blank.html: Added.
  • http/tests/misc/resources/redirect-to-about-blank.php: Added.

WebCore:

Reviewed by Kevin Decker.

<rdar://problem/4990049>
​http://bugs.webkit.org/show_bug.cgi?id=12718
REGRESSION: Segmentation fault when loading abc.go.com (12718)

The problem is that redirecting to about:blank causes the delegate to be released even though the load wasn't finished.
This is usally not a problem since NSURLConnection retains its delegate. However, the proxy delegate does not retain _it's_
delegate. The solution is to make releaseDelegate clear out the proxy delegate's delegate.


  • platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::releaseDelegate): If there's a proxy, nil out its delegate too.
1:28 PM Changeset in webkit [19611] by brmorris
  • 5 edits in S60/branches/3.1m/WebCore

bujtas, reviewed by yongjun

DESC: merging trunk r16319 to s60/3.1m PKAI-6Y2PBN
Fix fieldsets so that they properly expand to enclose overhanging floats
when the fieldset has auto height. This is a nifty undocumented behavior
of the fieldset element. ​http://bugs.webkit.org/show_bug.cgi?id=3898

​http://bugs.webkit.org/show_bug.cgi?id=12748

1:11 PM Changeset in webkit [19610] by ap
  • 1 edit in trunk/LayoutTests/ChangeLog

Correcting ChangeLog entry (thx Mitz!).

1:06 PM Changeset in webkit [19609] by ap
  • 1 edit
    4 deletes in trunk/LayoutTests

Actually removed pixel results that were supposed to be removed three
weeks ago, in r12290.

  • fast/parser/entity-surrogate-pairs-expected.checksum: Removed.
  • fast/parser/entity-surrogate-pairs-expected.png: Removed.
  • fast/parser/head-comment-expected.checksum: Removed.
  • fast/parser/head-comment-expected.png: Removed.
11:31 AM Changeset in webkit [19608] by ap
  • 2 edits in trunk/WebKit

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12643
NPN_Status is using latin-1 encoding for the message instead of UTF-8

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView status:]): Use kCFStringEncodingUTF8.
11:23 AM Changeset in webkit [19607] by beidson
  • 1 edit
    5 adds in trunk/LayoutTests

Reviewed by The Spirit of Layout Test Fixing!

Re-added a directory and some files Darin removed that one of my layout tests
relied on.

  • http/tests/security/resources/green250x50.png: Added.
  • http/tests/security/resources/red200x100.png: Added.
  • http/tests/security/resources/showRefererImage.php: Added.
10:32 AM Changeset in webkit [19606] by darin
  • 4 edits in trunk

JavaScriptCore:

Reviewed by Darin.

  • wtf/Vector.h: fixed comparison operators (WTF::operator==): (WTF::operator!=):

WebCore:

Reviewed by Darin.

  • rendering/RenderStyle.h: Added a != operator for StyleDashboardRegion. The only reason this compiled before was that the comparing two vectors with a != was simply comparing the pointers.
10:16 AM Changeset in webkit [19605] by darin
  • 519 edits
    1 delete in trunk/LayoutTests
  • update test results for Hyatt's focus node enhancement (fix for 12149) 518 of tests had extra "begin editing" delegate callbacks.
  • editing: Updated test results of many tests in this directory.
  • removed tests for rolled-out fix for rdar://problem/4922454
  • http/tests/security/local-JavaScript-from-remote-expected.txt: Removed.
  • http/tests/security/local-JavaScript-from-remote.html: Removed.
  • http/tests/security/local-iFrame-from-remote-expected.txt: Removed.
  • http/tests/security/local-iFrame-from-remote.html: Removed.
  • http/tests/security/local-image-from-remote-expected.txt: Removed.
  • http/tests/security/local-image-from-remote.html: Removed.
  • http/tests/security/resources/compass.jpg: Removed.
  • http/tests/security/resources/green250x50.png: Removed.
  • http/tests/security/resources/localPage.html: Removed.
  • http/tests/security/resources/localScript.js: Removed.
  • http/tests/security/resources/red200x100.png: Removed.
  • http/tests/security/resources/showRefererImage.php: Removed.
10:11 AM Changeset in webkit [19604] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Fix wording of a change log comment.

9:58 AM Changeset in webkit [19603] by darin
  • 2 edits in trunk/WebKitTools
  • Scripts/run-webkit-tests: Fix a bug where --reset-results output would all go in one giant line.
9:52 AM Changeset in webkit [19602] by darin
  • 2 edits in trunk/WebCore
  • roll out fix for <rdar://problem/4874059> REGRESSION: Painter IX:register -
Crash in WebCore
ResourceLoader::willSendRequest()

This fix was causing a crash in at least one layout test.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
5:09 AM Changeset in webkit [19601] by mjs
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/lists/item-not-in-list-line-wrapping-expected.checksum: Added.
  • fast/lists/item-not-in-list-line-wrapping-expected.png: Added.
  • fast/lists/item-not-in-list-line-wrapping-expected.txt: Added.
  • fast/lists/item-not-in-list-line-wrapping.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/lists/item-not-in-list-line-wrapping.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Use the list marker's isInside() instead of looking at its style()->listStylePosition(), since if the list item is not in a list, the marker is inside regardless of the style.
3:02 AM Changeset in webkit [19600] by rwlbuis
  • 13 edits in trunk

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12578
WebKit incorrectly strokes zero-width/height rectangles

Create an empty path when encountering zero-width/height rectangles, similar to circles with zero radius.

2:05 AM Changeset in webkit [19599] by rwlbuis
  • 3 edits
    2 deletes in trunk/WebCore

Reviewed by Maciej.

Remove SVGDOMImplementation from the project.

1:52 AM Changeset in webkit [19598] by mjs
  • 2 edits in trunk/LayoutTests

Reviewed by Maciej.


  • fixed to still be a valid test (wouldn't crash without the relevant fix).
  • fast/text/text-shadow-extreme-value.html:
12:59 AM Changeset in webkit [19597] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Maciej and Adam

Fixes <rdar://problem/4985497> - Crash when opening a new window to "Same Page"

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::loadItem): Null check documentLoader() since if we're a brand new WebView, cloning the history of another view, we have no documentLoader()
12:55 AM Changeset in webkit [19596] by antti
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

-fix REGRESSION: <select disabled size="5"> listbox cannot be scrolled
​http://bugs.webkit.org/show_bug.cgi?id=11852
<rdar://problem/4960129>


Pass mouse press events to scrollbars even if event is swallowed.


No layout test, DumpRenderTree eventSender can't hit scrollbars.

  • page/EventHandler.cpp: (WebCore::EventHandler::handleMousePressEvent):

Feb 12, 2007:

8:49 PM Changeset in webkit [19595] by hyatt
  • 7 edits in trunk/WebCore

Fix for bug 12149 (Radar Bug#4928692), external CSS causes incomplete
text field focus.

Make sure to clear out the focus node in willRemove() rather than in
detach(), since detach/attach caused by style recalc should not affect
the focused node.

Reviewed by aroben

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::willRemove):
  • dom/Document.cpp: (WebCore::Document::focusedNodeRemoved): (WebCore::Document::setFocusedNode):
  • dom/Document.h:
  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance):
  • dom/Node.cpp: (WebCore::Node::willRemove): (WebCore::Node::detach):
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateFocusAppearance):
8:46 PM Changeset in webkit [19594] by bdash
  • 2 edits in trunk/WebKit

2007-02-13 Mark Rowe <​mrowe@apple.com>

Reviewed by Timothy Hatcher.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=12745
Bug 12745: REGRESSION: Webkit will not load a plugin that Safari can load (symbol missing _objc_msgSend_fpret)

Treat libobjc as a sub-library of WebKit in Debug/Release so that plugins and applications linked against an
umbrella framework version of WebKit that expect to find libobjc symbols in WebKit can do so.

  • WebKit.xcodeproj/project.pbxproj:
5:41 PM Changeset in webkit [19593] by bdash
  • 118 edits
    8 deletes in trunk

Rolling out r19588 as it caused a build failure and a hang in layout tests after the obvious build fix was applied.

5:37 PM Changeset in webkit [19592] by bdash
  • 1 edit in tags/Safari-521.34.1/WebKit/Info.plist

Versioning.

5:35 PM Changeset in webkit [19591] by bdash
  • 2 edits in tags/Safari-521.34.1/WebKit

Merge in r19484.

5:35 PM Changeset in webkit [19590] by kmccullo
  • 21 edits
    6 deletes in trunk

LayoutTests:

Reviewed by .

  • reverting change to not cause regressions and performance problems.
  • fast/loader/local-JavaScript-from-local-expected.txt: Removed.
  • fast/loader/local-JavaScript-from-local.html: Removed.
  • fast/loader/local-iFrame-source-from-local-expected.txt: Removed.
  • fast/loader/local-iFrame-source-from-local.html: Removed.
  • fast/loader/local-image-from-local-expected.txt: Removed.
  • fast/loader/local-image-from-local.html: Removed.

WebCore:

Reviewed by .

  • reverting change to not cause regressions and performance problems.
  • bindings/objc/DOM.mm: (-[DOMElement image]): (-[DOMElement _imageTIFFRepresentation]):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::notifyFinished):
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::dispatchLoadEvent):
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::reset): (WebCore::HTMLTokenizer::notifyFinished):
  • ksvg2/misc/SVGImageLoader.cpp: (WebCore::SVGImageLoader::dispatchLoadEvent):
  • loader/Cache.cpp: (WebCore::Cache::requestResource): (WebCore::Cache::remove):
  • loader/CachedImage.h: (WebCore::CachedImage::canRender): (WebCore::CachedImage::isErrorImage):
  • loader/CachedResource.h:
  • loader/CachedScript.h: (WebCore::CachedScript::errorOccurred):
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestResource): (WebCore::DocLoader::setLoadInProgress):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::canLoad):
  • page/EventHandler.cpp: (WebCore::selectCursor):
  • rendering/HitTestResult.cpp: (WebCore::HitTestResult::image):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::setCachedImage): (WebCore::RenderImage::imageChanged): (WebCore::RenderImage::paint): (WebCore::RenderImage::layout): (WebCore::RenderImage::calcAspectRatioWidth): (WebCore::RenderImage::calcAspectRatioHeight):
  • rendering/RenderImage.h: (WebCore::RenderImage::isErrorImage):
  • rendering/RenderListItem.cpp: (WebCore::RenderListItem::setStyle):
  • rendering/RenderListMarker.cpp: (WebCore::RenderListMarker::isImage):

WebKit:

Reviewed by .

  • reverting change to not cause regressions and performance problems.
  • Misc/WebNSAttributedStringExtras.mm: (fileWrapperForElement):
5:23 PM Changeset in webkit [19589] by bdash
  • 1 copy in tags/Safari-521.34.1

New tag.

3:57 PM Changeset in webkit [22936] by adachan
  • 12 edits in branches/WindowsMerge

2007-02-12 Ada Chan <​adachan@apple.com>

WebCoreWin:

Reviewed by Steve.

<rdar://4952715> Events not being passed from WebCore/WebKit up through IWebForm::doCommandBySelector
Frame::doTextFieldCommandFromEvent()'s signature has changed from taking in a PlatformKeyboardEvent
to KeyboardEvent. Match that in FrameWin.

  • bridge/win/FrameWin.cpp: (WebCore::FrameWin::doTextFieldCommandFromEvent):
  • bridge/win/FrameWin.h:


WebKitWin:

Reviewed by Steve.


Also, checked in a fix in WebContextMenuClient that Adam made on my machine, reviewed by me.

<rdar://4952715> Events not being passed from WebCore/WebKit up through IWebForm::doCommandBySelector
Inform form delegate about delete key press.


DOM event fixes:

  • Removed DOMEventTarget class.
  • IDOMEventTarget no longer extends IDOMObject
  • DOMNode now implements IDOMEventTarget
  • DOMEvent::CoCreateInstance creates the correct subclasses of DOMEvents based on the type of event
  • Added IDOMDocumentEvent interface, which DOMDocument implements.
  • Fixed the out parameter in IDOMUIEvent::view to be IDOMWindow


Implemented DOMHTMLDocument::body and DOMHTMLElement::setInnerText.

  • DOMCoreClasses.cpp: (DOMNode::addEventListener): added as DOMNode now needs to implement IDOMEventTarget (DOMNode::removeEventListener): ditto above (DOMNode::dispatchEvent): ditto above (DOMDocument::QueryInterface): DOMDocument now also implements IDOMDocumentEvent (DOMDocument::createEvent): added as DOMDocument implements IDOMDocumentEvent (DOMElement::focus): implemented
  • DOMCoreClasses.h:
  • DOMEventsClasses.cpp: (DOMEvent::DOMEvent): The data member m_event is now a RefPtr, and the WebCore::Event is now passed into the constructor via a PassRefPtr. (DOMEvent::~DOMEvent): No longer need to deref m_event since we are using a RefPtr. (DOMEvent::createInstance): instantiate the correct DOMEvent subclass based on event type. (DOMEvent::QueryInterface): be able to QI IID_DOMEvent, which returns back the DOMEvent type. (DOMUIEvent::view): fixed the API (DOMKeyboardEvent::ctrlKey): call .get() on RefPtr (DOMKeyboardEvent::shiftKey): ditto above (DOMKeyboardEvent::altKey): ditto above (DOMKeyboardEvent::metaKey): ditto above (DOMKeyboardEvent::altGraphKey): ditto above (DOMMouseEvent::ctrlKey): ditto above (DOMMouseEvent::shiftKey): ditto above (DOMMouseEvent::altKey): ditto above (DOMMouseEvent::metaKey): ditto above
  • DOMEventsClasses.h: (DOMEvent::coreEvent): Added an API to get the WebCore::Event out of a DOMEvent. Used in DOMNode::dispatchEvent. (DOMUIEvent::DOMUIEvent): made public so it can be called in DOMEvent::createInstance (DOMKeyboardEvent::DOMKeyboardEvent): ditto above (DOMKeyboardEvent::view): fixed API (DOMMouseEvent::DOMMouseEvent): made public so it can be called in DOMEvent::createInstance (DOMMouseEvent::view): fixed API (DOMMutationEvent::DOMMutationEvent): made public so it can be called in DOMEvent::createInstance (DOMOverflowEvent::DOMOverflowEvent): made public so it can be called in DOMEvent::createInstance (DOMWheelEvent::DOMWheelEvent): made public so it can be called in DOMEvent::createInstance (DOMWheelEvent::view): fixed API
  • DOMHTMLClasses.cpp: (DOMHTMLDocument::body): (DOMHTMLElement::setInnerText):
  • Interfaces/DOMEvents.idl: IDOMEventTarget no longer extends IDOMObject. Added IDOMDocumentEvent.
  • WebContextMenuClient.cpp: (WebContextMenuClient::getCustomMenuFromDefaultItems): check for error from calling contextMenuItemsForElement.
  • WebFrame.cpp: (WebFrame::textWillBeDeletedInTextField): call form delegate callback doCommandBySelector with VK_BACK when deleting text.


3:52 PM Changeset in webkit [19588] by bdash
  • 120 edits
    8 adds in trunk

2007-02-12 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Tests: fast/repaint/float-overflow.html

fast/repaint/float-overflow-right.html

Reflected in existing test results.

Unified floats and overflow for the purposes of painting and hit-testing.
Overhanging and overflowing floats are now factored into a block's overflow
unless their painting has been propagated to an ancestor.

Changed table cells to no longer expand to enclose overflow, thus making
it purely "visual overflow", having no effect on layout in WebCore. It
still determines scrolling dimensions.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Include inline blocks' horizontal overflow in the inline box's dimensions.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Removed the expand to enclose overflows behavior. Added code to add this block's floats (and their overflow) to its overflow rect if it is not in a block formatting context. Otherwise, the inclusion of floats in the overflow is deferred until this block's parent examines its floats and possibly adopts overhanging floats. (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::paint): (WebCore::RenderBlock::floatRect): Changed to return an empty rect if there are no floats or the floats are clipped, instead of returning the border box. (WebCore::RenderBlock::addOverhangingFloats): Any floats of the child that are not to be painted by the parent are added to the child's overflow rect. (WebCore::RenderBlock::addVisualOverflow): Added. Adjusts the overflow bounds to include the given rect. (WebCore::RenderBlock::nodeAtPoint):
  • rendering/RenderBlock.h:
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutHorizontalBox): After placing a normal child, add its floats to its overflow, since painting of floats does not propagate to flexible boxes. (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto.
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::layout):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::absoluteBoundingBox):
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
  • rendering/RenderObject.h: (WebCore::RenderObject::expandsToEncloseOverhangingFloats):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::layout):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout):
  • rendering/RenderTableCell.h: (WebCore::RenderTableCell::expandsToEncloseOverhangingFloats):

2007-02-12 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • css1/formatting_model/inline_elements-expected.checksum:
  • css1/formatting_model/inline_elements-expected.png:
  • css1/formatting_model/inline_elements-expected.txt:
  • css2.1/t0905-c414-flt-00-d-expected.txt:
  • css2.1/t0905-c414-flt-01-d-g-expected.txt:
  • css2.1/t0905-c414-flt-02-c-expected.txt:
  • css2.1/t0905-c414-flt-03-c-expected.txt:
  • css2.1/t0905-c414-flt-04-c-expected.txt:
  • css2.1/t0905-c414-flt-wrap-01-d-g-expected.txt:
  • css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
  • css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
  • css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
  • css2.1/t090501-c414-flt-02-d-g-expected.txt:
  • css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
  • fast/block/float/008-expected.txt:
  • fast/block/float/013-expected.checksum:
  • fast/block/float/013-expected.txt:
  • fast/block/float/029-expected.txt:
  • fast/block/float/031-expected.txt:
  • fast/block/float/float-in-float-painting-expected.txt:
  • fast/block/margin-collapse/059-expected.checksum:
  • fast/block/margin-collapse/059-expected.png:
  • fast/block/margin-collapse/059-expected.txt:
  • fast/block/margin-collapse/062-expected.txt:
  • fast/block/margin-collapse/063-expected.txt:
  • fast/box-shadow/basic-shadows-expected.txt:
  • fast/forms/floating-textfield-relayout-expected.checksum:
  • fast/forms/floating-textfield-relayout-expected.txt:
  • fast/lists/003-expected.txt:
  • fast/media/mq-relative-constraints-08-expected.txt:
  • fast/multicol/float-multicol-expected.txt:
  • fast/repaint/float-overflow-expected.checksum: Added.
  • fast/repaint/float-overflow-expected.png: Added.
  • fast/repaint/float-overflow-expected.txt: Added.
  • fast/repaint/float-overflow-right-expected.checksum: Added.
  • fast/repaint/float-overflow-right-expected.png: Added.
  • fast/repaint/float-overflow-right-expected.txt: Added.
  • fast/repaint/float-overflow-right.html: Added.
  • fast/repaint/float-overflow.html: Added.
  • fast/table/009-expected.checksum:
  • fast/table/009-expected.png:
  • fast/table/009-expected.txt:
  • fast/text/text-shadow-extreme-value.html:
  • fast/text/whitespace/012-expected.txt:
  • tables/mozilla/bugs/bug120364-expected.txt:
  • tables/mozilla/bugs/bug196870-expected.checksum:
  • tables/mozilla/bugs/bug196870-expected.png:
  • tables/mozilla/bugs/bug196870-expected.txt:
  • tables/mozilla/bugs/bug45055-2-expected.txt:
  • tables/mozilla/bugs/bug72359-expected.txt:
  • tables/mozilla/marvin/x_table_align_left-expected.txt:
  • tables/mozilla/marvin/x_table_align_right-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.txt:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.checksum:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.png:
  • tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.txt:
3:36 PM Changeset in webkit [19587] by darin
  • 16 edits
    2 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • update pixel results in cases where overline and line-through were used, because our old code put them 1px too low
  • css1/cascade/cascade_order-expected.checksum: Updated because this has line-through style.
  • css1/cascade/cascade_order-expected.png: Ditto.
  • css1/text_properties/text_decoration-expected.checksum: Updated because this has overline and line-through.
  • css1/text_properties/text_decoration-expected.png: Ditto.
  • css2.1/t1504-c543-txt-decor-00-d-g-expected.checksum: Ditto.
  • css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Ditto.
  • fast/text/stroking-decorations-expected.checksum: Ditto.
  • fast/text/stroking-decorations-expected.png: Ditto.
  • added some missing pixel-test results
  • fast/forms/disabled-select-change-index-expected.checksum: Added.
  • fast/forms/disabled-select-change-index-expected.png: Added.

WebCore:

Reviewed by Hyatt.

  • fix bug where overline and line-through were 1px lower than we intended
  • platform/graphics/GraphicsContext.h: Removed unneeded y offset parameter.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLineForText): Removed bogus y offset and +1.
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawLineForText): Ditto.
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::drawLineForText): Ditto.
  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::paintTextDecorations): Added the "+1" that used to be inside drawLineForText to the underline-drawing code. Changed the other callers of drawLineForText to include the y offset in the y coordinate.
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintDecoration): Ditto. Also renamed _tx and _ty to remove the gratuitious underscores. (WebCore::InlineTextBox::paintMarkedTextUnderline): Made the default thickness be 1px instead of 0 (which ends up being roughly 1px in the CG code path anyway). Fixed the code computing the position to put the underline at the bottom of the line (different from regular underlines which are put 1px under the baseline). The old code used to put the underline 1px further down in the thick case, and 2px further down in the non-thick case. Both of those are bad, because they could be completely clipped out in many cases.
3:35 PM Changeset in webkit [19586] by brmorris
  • 5 edits in S60/trunk/WebCore

zalan, Reviewed by yongjun.

DESC: merging WebKit/trunk r16319 to s60/trunk PKAI-6Y2PBN
Fix fieldsets so that they properly expand to enclose overhanging floats
when the fieldset has auto height. This is a nifty undocumented behavior
of the fieldset element. See ​http://bugs.webkit.org/show_bug.cgi?id=3898

​http://bugs.webkit.org/show_bug.cgi?id=12748

3:31 PM Changeset in webkit [19585] by brmorris
  • 2 edits in S60/branches/3.1m/WebCore

w3liu, Reviewed by Zalan Bujtas <​zbujtas@gmail.com>.

DESC: [S60] Web page teamwork.com not displayed on 3.1 browser AKKO-6XGJZT
Fix: Insert html node if the main document element is not available (document starts

with comment element)

​http://bugs.webkit.org/show_bug.cgi?id=12683

3:24 PM Changeset in webkit [19584] by andersca
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

<rdar://problem/4846962>
Aperture: Aperture 1.5 - DOM exception occurs when exporting a web gallery

  • fast/dom/Document/replace-child-expected.txt: Added.
  • fast/dom/Document/replace-child.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/4846962>
Aperture: Aperture 1.5 - DOM exception occurs when exporting a web gallery

  • dom/ContainerNode.cpp: (WebCore::ContainerNode::replaceChild): Call checkReplaceChild here.


  • dom/Document.cpp: (WebCore::Document::canReplaceChild):
  • dom/Document.h: Add implementation of canReplaceChild that makes sure that doing the replacement won't cause more than one element and document type node to end up in the document.


  • dom/Node.cpp: (WebCore::Node::canReplaceChild): Base implementation of canReplaceChild.


(WebCore::Node::checkReplaceChild):
New function that does what checAddChild does but calls canReplaceChild.

3:01 PM Changeset in webkit [19583] by kdecker
  • 2 edits in trunk/WebCore

Reviewed by Anders.

Fixed: <rdar://problem/4874059> REGRESSION: Painter IX:register - …
ResourceLoader::willSendRequest() What happened here was that a WebDataSource was being dealloced *while* a load for that resource is still in progress.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopAllLoaders): Calling stopAllLoaders cancels loads and informs the frame load delegate accordingly. The delegate however may decide to kick off a new provisional load as the result of the cancel. Therefore a local variable for the provisional and main doucment loader is introduced, and we now only nil out the provisional loader if the local and member provisional variables represent the exact same load. (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): Added the same check here, too.
1:41 PM Changeset in webkit [19582] by lars
  • 8 edits
    2 adds in trunk

Reviewed by Mitz.

Do not create child renderers for table column groups
if the child has not a table column display type.

12:28 PM Changeset in webkit [19581] by antti
  • 2 edits in trunk/WebCore

Reviewed by Mitz

Fix assertion failure in layout test.

  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::parseMappedAttribute):
11:58 AM Changeset in webkit [19580] by kmccullo
  • 3 edits in trunk/WebCore

Reviewed by Brady.

  • Fixing a performance regression caused by r19500. The heart of the matter is that we now call canLoad on every resource request even ones in the cache, to avoid a security issue. So I could not take out the canLoad call, but I but I could try to make it more efficient.
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestResource): (WebCore::DocLoader::setLoadInProgress):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::canLoad):
11:05 AM Changeset in webkit [19579] by darin
  • 29 edits in trunk

WebCore:

Reviewed by Oliver.

This area still needs work because keypress events are being sent for all the
events before they go to the input methods, and it seems that this is not
compatible with what other browsers do and with what sites assume. That's covered
by this bug:

​http://bugs.webkit.org/show_bug.cgi?id=10871
<rdar://problem/4823129> REGRESSION: IME key events different in nightly (10871)

which is still open.

  • bindings/objc/ExceptionHandlers.h: Remove selectRange helper that doesn't really belong here, and also isn't needed since the callers don't want to raise ObjC exceptions.
  • bindings/objc/ExceptionHandlers.mm: Ditto. Also removed unneeded external globals that aren't exported anyway and unneeded includes.
  • bridge/EditorClient.h: Added Mac-specific function, markedTextAbandoned. Long term this might move into platform instead, but it's fine to have it on the client for now as long as it doesn't cause trouble for platforms other than Mac.
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::defaultEventHandler): Since all the event handling code in this function is intended to run on the node itself, not parent nodes, check and do nothing if this event is bubbling up from another node. Added code to call a function on EventHandler for default handling of text input events.
  • dom/KeyboardEvent.h:
  • dom/KeyboardEvent.cpp: (WebCore::findKeyboardEvent): Added. Just like the findUIEventWithKeyState function, but specific to keyboard events.
  • dom/TextEvent.h: Added isLineBreak and isBackTab flags so that we can carry additional information about what a text input event is trying to do, but still go through the DOM event machinery.
  • dom/TextEvent.cpp: Ditto.
  • editing/Editor.h:
  • editing/Editor.cpp: (WebCore::Editor::handleKeyPress): Removed unneeded check of isCaretOrRange, since isContentEditable already checks that. (WebCore::Editor::canEdit): Ditto. (WebCore::Editor::canEditRichly): Ditto. (WebCore::Editor::canPaste): Changed to call canEdit for brevity. (WebCore::Editor::replaceSelectionWithText): Changed to take a const String&. (WebCore::Editor::shouldInsertText): Ditto. (WebCore::hasEditableSelection): Removed unneeded check of isCaretOrRange, since isContentEditable already checks that. (WebCore::Editor::Editor): Initialize the new m_ignoreMarkedTextSelectionChange flag. Moved here from WebHTMLView. (WebCore::Editor::insertText): Moved most of the code from -[WebHTMLView insertText:] here, since this needs to be done in response to a text input event and we don't want to go back over the WebKit side for that. (WebCore::Editor::insertLineBreak): Added. Moved here from -[WebHTMLView insertLineBreak:] for the same reason -- needs to be done in response to text input events. (WebCore::Editor::insertParagraphSeparator): Ditto. (WebCore::Editor::selectMarkedText): Added. Used by insertText. (WebCore::Editor::discardMarkedText): Added. Used by insertText. (WebCore::Editor::unmarkText): Added. Used by insertText.
  • editing/mac/EditorMac.mm: (WebCore::Editor::unmarkText): Added. Used by insertText.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::canHaveSelection): Changed to use isTextField to avoid repeating the switch statement. (WebCore::HTMLInputElement::selectionStart): Ditto. (WebCore::HTMLInputElement::selectionEnd): Ditto. (WebCore::HTMLInputElement::setSelectionStart): Ditto. (WebCore::HTMLInputElement::setSelectionEnd): Ditto. (WebCore::HTMLInputElement::select): Ditto. (WebCore::HTMLInputElement::setSelectionRange): Ditto. (WebCore::HTMLInputElement::createRenderer): Resorted cases alphaebtically. (WebCore::HTMLInputElement::defaultEventHandler): Added code to make hitting return cause the form to be submitted when it comes through as a text input event. This is now the normal case on Macintosh, because enter key presses normally turn into this. In addition, change the other event handling to run only after trying the base defaultEventHandler. That makes the key handling done in EventTargetNode take precedence over the event handling here for editable text fields, which is what we want. This gets rid of the need for the hack where we check inputManagerHasMarkedText and suppress the handling of the enter key.
  • page/EventHandler.h: Removed unneeded includes. Moved EventHandlerDragState down into the private part of the class. Changed sendContextMenuEvent to take a const&. Added new handleTextInputEvent and defaultTextInputEventHandler functions. Made eventLoopHandleMouseUp and eventLoopHandleMouseDragged private. Added private defaultTabEventHandler function.
  • page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent): Changed parameter to be a const&. (WebCore::EventHandler::defaultKeyboardEventHandler): Rearranged things so that the key bindings handling in handleKeyPress comes before special tab event handling. In cases where the tab turns into text to insert, we now handle it in the text input event handler. (WebCore::EventHandler::handleTextInputEvent): Added. Creates and dispatches a text input event. (WebCore::EventHandler::defaultTextInputEventHandler): Added. Inserts text, but has special cases for the tab and newline character cases. (WebCore::EventHandler::defaultTabEventHandler): Added. Shared by the tab-handling code in the keyboard event and text input event handlers.
  • page/mac/EventHandlerMac.mm: Tweak formatting, remove some unused functions.
  • page/FocusController.h: Removed unnneded includes and forwards, and added an overload of advanceFocus that takes a FocusDirection parameter.
  • page/FocusController.cpp: (WebCore::FocusController::advanceFocus): Changed to allow a 0 for the event pointer. Also added a version where the direction is passed explicitly, to be used for cases where we want to tab backward even if the event doesn't have a shift modifier key set.
  • platform/graphics/svg/SVGImageEmptyClients.h: Updated for change to EditorClient. This should really probably just use 0 for the EditorClient.
  • WebCore.exp: Update both for newly used and no-longer-used entry points.
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm: Removed two unused methods.

WebKit:

Reviewed by Oliver.

  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::markedTextAbandoned): Added.
  • WebView/WebHTMLView.mm: (-[WebHTMLView menuForEvent:]): Added explicit constructor needed now that the function takes a const&. (-[WebHTMLView becomeFirstResponder]): Removed fake event code, no longer needed since advanceFocus now works fine with 0 for a DOM event. (-[WebHTMLView _expandSelectionToGranularity:]): Changed to use the normal selection controller function instead of selectRange. (-[WebHTMLView insertTab:]): Changed to call bottleneck that receives the DOM event. (-[WebHTMLView insertBacktab:]): Ditto. (-[WebHTMLView insertNewline:]): Ditto. (-[WebHTMLView insertLineBreak:]): Ditto. (-[WebHTMLView insertParagraphSeparator:]): Ditto. (-[WebHTMLView insertNewlineIgnoringFieldEditor:]): Ditto. (-[WebHTMLView insertTabIgnoringFieldEditor:]): Ditto. (-[WebHTMLView yank:]): Updated to call Editor directly since the insertText code now works via a text input event which is not what we want for paste-like things such as yank. (-[WebHTMLView yankAndSelect:]): Ditto. (-[WebHTMLView selectToMark:]): Changed to use the normal selection controller function instead of selectRange, which also allows us to remove the ObjC exception handling code. (-[WebHTMLView swapWithMark:]): Ditto. (-[WebHTMLView transpose:]): Ditto. (-[WebHTMLView unmarkText]): Since this is one of the calls back from the input manager, added code to set the "event was handled" flag. Moved the actual work into the Editor class in WebCore and just call that from here. (-[WebHTMLView _selectRangeInMarkedText:]): Changed to use the normal selection controller function instead of selectRange. (-[WebHTMLView setMarkedText:selectedRange:]): Since this is one of the calls back from the input manager, added code to set the "event was handled" flag. Also changed the ignoreMarkedTextSelectionChange to use the flag over on the WebCore side, since we moved it there and to call selectMarkedText over on the WebCore side too. (-[WebHTMLView doCommandBySelector:]): Added special cases for newline and tab selectors so that the event is passed along. These selectors are special because they are ones that turn into text input events. (-[WebHTMLView _discardMarkedText]): Moved the body of this function into the Editor class in WebCore and just call that from here. (-[WebHTMLView insertText:]): Added code to send a text input event instead of calling the editor to do text insertion. The insertion is then done in the default handler for the text input event. (-[WebHTMLView _insertNewlineWithEvent:isLineBreak:]): Added. Sends a text input event. (-[WebHTMLView _insertTabWithEvent:isBackTab:]): Ditto. (-[WebHTMLView _updateSelectionForInputManager]): Changed to use the ignoreMarkedTextSelectionChange flag in Editor now that the one here is gone.
  • WebView/WebHTMLViewInternal.h: Remove ignoreMarkedTextSelectionChange field.
  • WebView/WebView.mm: (-[WebView setSelectedDOMRange:affinity:]): Changed to use the normal selection controller function instead of selectRange.
10:07 AM Changeset in webkit [19578] by antti
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin

  • fast/images/imagemap-case-expected.checksum: Added.
  • fast/images/imagemap-case-expected.png: Added.
  • fast/images/imagemap-case-expected.txt: Added.
  • fast/images/imagemap-case.html: Added.

WebCore:

Reviewed by Darin.


Make imagemap names case insensitive in HTML mode

  • dom/Document.cpp: (WebCore::Document::getImageMap):
  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::parseMappedAttribute):
9:15 AM Changeset in webkit [19577] by ggaren
  • 2 edits in trunk/LayoutTests

Updated results for this failing test. It looks like Maciej generated
the original results before he made the test "dump as text."

  • fast/text/text-shadow-extreme-value-expected.txt:
7:28 AM Changeset in webkit [19576] by brmorris
  • 5 edits in S60/trunk/WebKit

bujtas, Reviewed by Yongjun, merged by Brad.

DESC: Merge of r19540 to s60/trunk: Can not open the Browser application ALES-6Y9GG7
fix: delay formmanager construct
​http://bugs.webkit.org/show_bug.cgi?id=12714

6:59 AM Changeset in webkit [19575] by brmorris
  • 3 edits in S60/trunk/WebKit

yaharon, reviewed by yongjun

DESC: [S60] BrowserNG: Passwords stored without notifying the user MLIO-6XXE6N
​http://bugs.webkit.org/show_bug.cgi?id=12712

6:56 AM Changeset in webkit [19574] by brmorris
  • 2 edits in S60/trunk/WebKit

sareen, reviewed by <​yongjun.zhang@nokia.com>.

DESC: Squares are displayed instead of characters for Greek web pages.
​http://bugs.webkit.org/show_bug.cgi?id=11469

3:59 AM Changeset in webkit [19573] by mjs
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Antti.



  • fast/text/text-shadow-extreme-value.html: Added.
  • fast/text/text-shadow-extreme-value-expected.txt: Added.

WebCore:

Reviewed by Antti.


Test: fast/text/text-shadow-extreme-value.html

  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setShadow): Clamp shadow value to 1000px, anything more seems to make CG unhappy.
Note: See TracTimeline for information about the timeline view.