Timeline



Feb 20, 2007:

11:30 PM Changeset in webkit [19768] by aroben
  • 2 edits in trunk/WebCore

Preemptive build fix.

  • platform/mac/FontCacheMac.mm: Remove unused (and non-existent) header.
10:20 PM Changeset in webkit [19767] by bdash
  • 4 edits in tags/Safari-421.35

Versioning.

10:11 PM Changeset in webkit [19766] by bdash
  • 1 copy in tags/Safari-421.35

New tag.

10:04 PM Changeset in webkit [22977] by bdakin
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Maciej.

Some changes needed to match moving writeImage() to the Pasteboard
on the Mac.

  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeURL): Now takes a bool indicating if the url if for an image. (WebCore::Pasteboard::writeImage): This is just a stub for now. I am putting it here instead of on TemporaryLinkStubs because I plan on implementing it very soon.

WebKitWin:

Reviewed by Maciej.

Move copyImage functionality from the ContextMenuClient to the
Pasteboard.

  • WebContextMenuClient.cpp:
  • WebContextMenuClient.h:

M OpenSourceWin/WebKitWin/WebContextMenuClient.cpp
M OpenSourceWin/WebKitWin/ChangeLog
M OpenSourceWin/WebKitWin/WebContextMenuClient.h
M OpenSourceWin/WebCoreWin/platform/win/PasteboardWin.cpp
M OpenSourceWin/WebCoreWin/ChangeLog

10:02 PM Changeset in webkit [19765] by aroben
  • 2 edits in trunk/WebCore

Fix the build the right way.

  • platform/StringTruncator.cpp: (WebCore::truncateString): Keep all widths as floats.
10:00 PM Changeset in webkit [19764] by bdakin
  • 26 edits
    2 adds in trunk

WebCore:

Reviewed by Maciej.

Implement writeImage() on Pasteboard so that the context menus can
call into the editor for the "Copy image" command instead of
calling across the clients.

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/Editor.cpp: (WebCore::Editor::copyImage): Call into the Pasteboard.
  • editing/Editor.h:
  • loader/mac/LoaderNSURLExtras.h: A new NSURL extra needed inside WebCore.
  • loader/mac/LoaderNSURLExtras.m: Made this file Objective-C++ (from Objective-C) since the call into the MIMETypeRegistry will return a Vector. (urlByRemovingComponent): Cast to build as Obj-C++ (urlWithDataRelativeToURL): Same. (vectorContainsString): Helper. (suggestedFilenameWithMIMEType): New function.
  • page/ContextMenuClient.h: Remove copyImageToClipboard()
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Call into the editor instead of the client.
  • page/mac/WebCoreViewFactory.h: New localized String.
  • platform/LocalizedStrings.h: Same.
  • platform/MimeTypeRegistry.h: Expose two additional functions for MIMEType information from WebCore System Interface.
  • platform/Pasteboard.h:
  • platform/SharedBuffer.h: Make platformData() and platformDataSize () public since they are needed to write the image to the pasteboard.
  • platform/mac/LocalizedStringsMac.mm: New localized string. (WebCore::copyImageUnknownFileLabel):
  • platform/mac/MimeTypeRegistryMac.mm: (WebCore::MimeTypeRegistry::getExtensionsForMIMEType): (WebCore::MimeTypeRegistry::getPreferredExtensionForMIMEType):
  • platform/mac/PasteboardMac.mm: (WebCore::writableTypesForImage): (WebCore::Pasteboard::writeURL): Write the correct types if the url is for an image. (WebCore::fileWrapperForImage): (WebCore::Pasteboard::writeFileWrapperAsRTFDAttachment): (WebCore::Pasteboard::writeImage):
  • platform/mac/WebCoreNSStringExtras.h: Added. Some the the NSStringExtras that were in WebKit are now needed by WebCore. To avoid having two copies of these functions, I just moved the implementations to WebCore. The WebKit functions just call into WebCore.
  • platform/mac/WebCoreNSStringExtras.mm: Added. (hasCaseInsensitiveSuffix): (hasCaseInsensitiveSubstring): (filenameByFixingIllegalCharacters):
  • platform/mac/WebCoreSystemInterface.h: wkGetPreferredExtensionForMIMEType and wkGetExtensionsForMIMEType are now needed in WebCore as well as WebKit.
  • platform/mac/WebCoreSystemInterface.mm:

WebKit:

Reviewed by Maciej.

WebKit changes needed to implement writeImage() in WebCore's
Pasteboard class.

  • Misc/WebKitNSStringExtras.m: Call into WebCore for these implementations. (-[NSString _webkit_hasCaseInsensitiveSuffix:]): (-[NSString _webkit_hasCaseInsensitiveSubstring:]): (-[NSString _webkit_filenameByFixingIllegalCharacters]):
  • Misc/WebNSURLExtras.m: Same. (-[NSURL _webkit_suggestedFilenameWithMIMEType:]):
  • WebCoreSupport/WebContextMenuClient.h: Remove copyImageToClipboard()
  • WebCoreSupport/WebContextMenuClient.mm:
  • WebCoreSupport/WebSystemInterface.m: Expose GetExtensionsForMIMEType and GetPreferredExtensionForMIMEType to WebCore. (InitWebCoreSystemInterface):
  • WebCoreSupport/WebViewFactory.mm: New localized string for WebCore. (-[WebViewFactory copyImageUnknownFileLabel]):
9:16 PM Changeset in webkit [19763] by aroben
  • 2 edits in trunk/WebCore

Build fix.

  • platform/StringTruncator.cpp: (WebCore::truncateString): Added explicit casts.
9:06 PM Changeset in webkit [22976] by aroben
  • 8 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin and Anders.

  • WebCore.vcproj/WebCore.vcproj: Added new files.
  • platform/win/FileChooserWin.cpp: (WebCore::FileChooser::openFileChooser): (WebCore::FileChooser::basenameForWidth): Added truncation.
  • platform/win/WebCoreTextRenderer.cpp: (WebCore::WebCoreDrawTextAtPoint): Added bottomAlign and centerTruncate parameters.
  • platform/win/WebCoreTextRenderer.h: Ditto.

WebKitWin:

Reviewed by Darin and Anders.

9:03 PM Changeset in webkit [19762] by aroben
  • 10 edits
    2 moves in trunk

WebCore:

Reviewed by Darin and Anders.

Fix <rdar://problem/4736215> Make WebCoreStringTruncator use WebCore types

  • WebCore.exp: Updated symbols.
  • WebCore.xcodeproj/project.pbxproj: Updated file names.
  • bridge/mac/WebCoreStringTruncator.h: Removed.
  • bridge/mac/WebCoreStringTruncator.mm: Removed.
  • platform/StringTruncator.cpp: Added. Moved from bridge/mac/WebCoreStringTruncator.mm. (WebCore::textBreakAtOrPreceding): Added. (WebCore::boundedTextBreakFollowing): Added. (WebCore::centerTruncateToBuffer): (WebCore::rightTruncateToBuffer): (WebCore::stringWidth): Now takes a const Font& instead of a Font*. (WebCore::truncateString): (WebCore::StringTruncator::centerTruncate): (WebCore::StringTruncator::rightTruncate): (WebCore::StringTruncator::width):
  • platform/StringTruncator.h: Added.
  • platform/TextBreakIterator.h: Added isTextBreak declaration.
  • platform/TextBreakIteratorICU.cpp: (WebCore::isTextBreak): Implemented.
  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::basenameForWidth): Updated for changes to WebCoreStringTruncator.
  • platform/qt/TextBreakIteratorQt.cpp: (WebCore::isTextBreak): Stubbed out.

WebKit:

Reviewed by Darin and Anders.

Update WebKit for WebCore fix for <rdar://problem/4736215> Make
WebCoreStringTruncator use WebCore types.

  • Misc/WebStringTruncator.m: (defaultMenuFont): Moved from WebCoreStringTruncator.mm. (core): Added. (+[WebStringTruncator centerTruncateString:toWidth:]): (+[WebStringTruncator centerTruncateString:toWidth:withFont:]): (+[WebStringTruncator rightTruncateString:toWidth:withFont:]): (+[WebStringTruncator widthOfString:font:]):
  • WebKit.xcodeproj/project.pbxproj: Changed WebStringTruncator to ObjC++.
7:58 PM Changeset in webkit [19761] by justing
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/5006779>
REGRESSION: Paste and Match Style of quoted text onto empty line yields quoted text

  • editing/pasteboard/5006779-expected.checksum: Added.
  • editing/pasteboard/5006779-expected.png: Added.
  • editing/pasteboard/5006779-expected.txt: Added.
  • editing/pasteboard/5006779.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/5006779>
REGRESSION: Paste and Match Style of quoted text onto empty line yields quoted text


We decided to change the copy/paste behavior in both
the Paste and the Paste and Match Style cases.

  • editing/markup.cpp: (WebCore::createMarkup): Don't add mail blockquote wrappers unless the user selected one or more paragraphs.
5:48 PM Changeset in webkit [19760] by thatcher
  • 4 edits in trunk/WebCore

Reviewed by Mark Rowe.

<rdar://problem/4912899> WebCore project ObjC @property cleanup

  • bindings/objc/DOMObject.h: Add the new style @property
  • bindings/objc/PublicDOMInterfaces.h: Update to the new style @property
  • bindings/scripts/CodeGeneratorObjC.pm: Export both new and old style @properties
5:39 PM Changeset in webkit [19759] by thatcher
  • 1 edit in trunk/WebCore/bindings/objc/ExceptionHandlers.mm

Fixes the build!

4:54 PM Changeset in webkit [19758] by thatcher
  • 1 edit in trunk/WebCore/bindings/objc/ExceptionHandlers.mm

Build fix for the no-SVG build.

4:48 PM Changeset in webkit [19757] by thatcher
  • 2 edits in trunk/WebCore/bindings/objc

Better build fix, rolling out part of r19579.

4:40 PM Changeset in webkit [19756] by thatcher
  • 1 edit in trunk/WebCore/bindings/objc/DOM.mm

Build fix.

4:36 PM Changeset in webkit [19755] by ggaren
  • 2 edits in trunk/WebKitTools

Tools tweak. No review necessary.


Made parse-malloc-history executable. (Oops!)


Made parse-malloc-history parse 'leaks' output in addition to 'malloc_history"
output.


Added the ability to merge callstacks by regexp, not just depth, so you
can ask questions like, "How many of these allocations were due to that one
call to ...?"


  • Scripts/parse-malloc-history:
4:12 PM Changeset in webkit [19754] by staikos
  • 2 edits in trunk/WebKitQt

Fix compile

4:07 PM Changeset in webkit [19753] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.

<rdar://problem/5007248> need to export symbols for DOM exception constants

  • WebCore.exp: Adds DOMEventException, DOMException, DOMRangeException, DOMXPathException
3:56 PM Changeset in webkit [19752] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by John.

Fixes the version number returned when using a CFBundleVersion of "420+".

  • WebView/WebView.mm: (-[WebView _userVisibleBundleVersionFromFullVersion:]): Check the length up to the first non-decimal digit, so this works with versions that have "." and "+".
3:38 PM Changeset in webkit [19751] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Kevin Decker


  • fixed <rdar://problem/4989344> REGRESSION: After clicking on page, Find won't find anything if all hits are before the clicked point


This was caused by a mismatch between WebCore's search code's notion of "selection" and
WebView's search code's notion of "selection". WebCore's search code was starting
just before or just after the "selection", which included collapsed, zero-length
selections. WebKit's search code was only considering non-zero-length selections,
and would not search all of the content when there was a zero-length selection.
The fix was to make WebKit ignore the selection. This has a side effect of increasing
the amount of redundantly-searched content in the case where no matches are found. To
compensate for that, I special-cased the most common case of WebViews with a single frame,
to avoid ever searching redundantly in those.

  • WebView/WebView.mm: (-[WebView searchFor:direction:caseSensitive:wrap:startInSelection:]): remove startHasSelection ivar; special-case WebViews with only one frame; clarify the code that leads to redundant searching with comments.
3:26 PM Changeset in webkit [19750] by thatcher
  • 1 edit in trunk/WebKit/WebView/WebHTMLView.mm

Build fix.

3:26 PM Changeset in webkit [19749] by ggaren
  • 2 edits in trunk/WebKitTools
  • Scripts/parse-malloc-history: Added copyright info.
2:57 PM Changeset in webkit [19748] by brmorris
  • 2 edits in S60/trunk/WebKit

yadavall, reviewed by zalan

DESC: Merge of r19731 to s60/trunk: Browser crashes when trying to open rss link HMNN-6YDEAW
​http://bugs.webkit.org/show_bug.cgi?id=12790

2:55 PM Changeset in webkit [22975] by sfalken
  • 1 edit in branches/WindowsMerge/WebKitWin/WebKit.vcproj/VERSION

Bump version for submit

2:53 PM Changeset in webkit [19747] by thatcher
  • 21 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

<rdar://problem/4900579> WebKit -finalize methods are not thread-safe; design change needed

Call WebCoreObjCFinalizeOnMainThread from the initialize method of all the classes
that have a finalizer that needs called on the main thread.

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject initialize]):
  • bridge/mac/WebCoreScriptDebugger.mm: (+[WebCoreScriptDebugger initialize]):
  • platform/mac/SharedBufferMac.mm: (+[SharedBufferData initialize]):
  • platform/mac/WebCoreObjCExtras.c: Added. (WebCoreObjCFinalizeOnMainThread):
  • platform/mac/WebCoreObjCExtras.h: Added.

WebKit:

Reviewed by Darin.

<rdar://problem/4900579> WebKit -finalize methods are not thread-safe; design change needed

Call WebCoreObjCFinalizeOnMainThread from the initialize method of all the classes
that have a finalizer that needs called on the main thread. Assert in finalize that we
are on the main thread.

  • Carbon/CarbonWindowAdapter.m: (+[CarbonWindowAdapter initialize]): (-[CarbonWindowAdapter finalize]):
  • History/WebBackForwardList.mm: (+[WebBackForwardList initialize]): (-[WebBackForwardList finalize]):
  • History/WebHistoryItem.mm: (+[WebHistoryItem initialize]):
  • Misc/WebElementDictionary.mm: (+[WebElementDictionary initialize]): (-[WebElementDictionary finalize]):
  • Plugins/WebBaseNetscapePluginStream.m: (+[WebBaseNetscapePluginStream initialize]): (-[WebBaseNetscapePluginStream finalize]):
  • Plugins/WebBaseNetscapePluginView.mm: (+[WebBaseNetscapePluginView initialize]): (-[WebBaseNetscapePluginView finalize]):
  • Plugins/WebBasePluginPackage.m: (+[WebBasePluginPackage initialize]): (-[WebBasePluginPackage finalize]):
  • Plugins/WebNetscapePluginStream.mm: (-[WebNetscapePluginStream finalize]):
  • WebCoreSupport/WebEditorClient.mm: (+[WebEditCommand initialize]): (-[WebEditCommand finalize]):
  • WebCoreSupport/WebFrameBridge.mm: (+[WebFrameBridge initialize]): (-[WebFrameBridge finalize]):
  • WebCoreSupport/WebFrameLoaderClient.mm: (+[WebFramePolicyListener initialize]): (-[WebFramePolicyListener finalize]):
  • WebView/WebHTMLView.mm: (+[WebHTMLView initialize]): (-[WebHTMLView finalize]):
  • WebView/WebView.mm: (+[WebViewPrivate initialize]): (-[WebViewPrivate finalize]):
2:53 PM Changeset in webkit [19746] by sfalken
  • 1 copy in tags/Safari-521.35.1b

New tag.

2:44 PM Changeset in webkit [19745] by justing
  • 3 edits in trunk/WebKit

Reviewed by darin


<rdar://problem/4838199>
Integrate Mail and WebKit paste operations


Mail overrides paste: because it has different
preferred pasteboard types, but it should use our
fragment creation code.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]): Moved fragment creation code into a new method. (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:]): Moved fragment creation code here.
  • WebView/WebHTMLViewPrivate.h: Exposed _documentFragmentFromPasteboard:forType:inContext: as SPI.
2:32 PM Changeset in webkit [19744] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Tim Hatcher

  • Misc/WebKitNSStringExtras.h:
  • Misc/WebKitNSStringExtras.m: removed _webkit_userVisibleBundleVersionFromFullVersion; we decided to do this without adding SPI for it.
  • WebView/WebView.mm: (-[WebView _userVisibleBundleVersionFromFullVersion:]): new method, moved here from WebKitNSStringExtras, and is now a WebView method rather than an NSString method (-[WebView _computeUserAgent]): updated for method signature change
2:09 PM Changeset in webkit [19743] by ggaren
  • 1 edit
    1 add in trunk/WebKitTools

Reviewed by Darin Adler.


New script to parse the output from malloc_history, so we can determine
what's using memory in WebKit.

  • Scripts/parse-malloc-history: Added.
1:32 PM Changeset in webkit [19742] by ggaren
  • 2 edits in trunk/WebCore

Not not reviewed by Mitz Pettel.

Fixed ​http://bugs.webkit.org/show_bug.cgi?id=12827 | <rdar://problem/5006671>
REGRESSION: -[DOMCSSStyleDeclaration setValue:forKey:] doesn't have an
immediate effect


Let's just pretend this never happened.


I attempted a layout test but I couldn't get the old code to fail because
there's no obvious way to isolate the ObjC bindings in a test that's
controlled by JS.


  • bindings/objc/WebScriptObject.mm: (_didExecute):
1:21 PM Changeset in webkit [19741] by kjk
  • 14 edits
    2 copies in trunk/WebCore

Reviewed by Maciej S.

Gdk build fixes for recent refactorings.

  • Projects/gdk/webcore-gdk.bkl:
  • WebCoreSources.bkl:
  • page/gdk/DragControllerGdk.cpp: (WebCore::DragController::dragOperation): (WebCore::DragController::maxDragImageSize):
  • page/gdk/EventHandlerGdk.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • platform/DragImage.h:
  • platform/gdk/ChromeClientGdk.h:
  • platform/gdk/CursorGdk.cpp: (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::progressCursor): (WebCore::aliasCursor): (WebCore::noneCursor): (WebCore::notAllowedCursor):
  • platform/gdk/EditorClientGdk.cpp: (WebCore::EditorClientGdk::shouldChangeSelectedRange): (WebCore::EditorClientGdk::isEditable): (WebCore::EditorClientGdk::textFieldDidBeginEditing): (WebCore::EditorClientGdk::textFieldDidEndEditing): (WebCore::EditorClientGdk::textDidChangeInTextField): (WebCore::EditorClientGdk::doTextFieldCommandFromEvent): (WebCore::EditorClientGdk::textWillBeDeletedInTextField): (WebCore::EditorClientGdk::textDidChangeInTextArea):
  • platform/gdk/EditorClientGdk.h:
  • platform/gdk/FrameGdk.cpp: (WebCore::Frame::print): (WebCore::Frame::issueTransposeCommand): (WebCore::Frame::respondToChangedSelection): (WebCore::Frame::cleanupPlatformScriptObjects): (WebCore::Frame::isCharacterSmartReplaceExempt): (WebCore::Frame::dragImageForSelection):
  • platform/gdk/FrameGdk.h:
  • platform/gdk/MimeTypeRegistryGdk.cpp: Added.
  • platform/gdk/TemporaryLinkStubs.cpp: (ChromeClientGdk::tabsToLinks): (ChromeClientGdk::windowResizerRect): (ChromeClientGdk::addToDirtyRegion): (ChromeClientGdk::scrollBackingStore): (ChromeClientGdk::updateBackingStore):
  • webcore-base.bkl:
1:13 PM Changeset in webkit [19740] by kjk
  • 2 edits in trunk/WebCore

Reviewed by Darin.

Allow over-writting Product, ProductSub, Vendor and VendorSub
js properties via #define WEBCORE_NAVIGATOR_*

  • bindings/js/kjs_navigator.cpp: (KJS::Navigator::getValueProperty):
12:41 PM Changeset in webkit [19739] by thatcher
  • 4 edits in trunk/WebKit

Reviewed by John.

  • Misc/WebKitNSStringExtras.h: Added _webkit_userVisibleBundleVersionFromFullVersion.
  • Misc/WebKitNSStringExtras.m: (-[NSString _webkit_userVisibleBundleVersionFromFullVersion]): If the version is 4 digits long or longer, then the first digit represents the version of the OS. Our user agent string should not include this first digit, so strip it off and report the rest as the version.
  • WebView/WebView.mm: (-[WebView _computeUserAgent]): Call _webkit_userVisibleBundleVersionFromFullVersion on the CFBundleVersion.
11:33 AM Changeset in webkit [22974] by aliceli1
  • 2 edits in branches/WindowsMerge/WebCore

Build fix

  • WebCore.vcproj/WebCore.vcproj: Added PositionIterator.cpp & h
11:27 AM Changeset in webkit [19738] by kmccullo
  • 1 edit in trunk/WebCore/ChangeLog-2006-12-31
10:56 AM Changeset in webkit [22973] by sfalken
  • 2 edits in branches/WindowsMerge/WebCore

2007-02-20 Steve Falkenburg <​sfalken@apple.com>

B&I build fix

  • WebCore.vcproj/WebCore.vcproj:
10:20 AM Changeset in webkit [22972] by darin
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders.

  • WebFrame.cpp: (WebFrame::redirectDataToPlugin): Update for changes to FrameLoader and DocumentLoader.
10:18 AM Changeset in webkit [19737] by darin
  • 12 edits in trunk

WebCore:

Reviewed by Anders.

  • prepare to fix some "stop loading" bugs by moving state from the FrameLoader class to the DocumentLoader class
  • WebCore.exp: Update since cancelMainResourceLoad is now on the document loader.
  • html/HTMLDocument.h:
  • html/HTMLDocument.cpp: (WebCore::HTMLDocument::HTMLDocument): Removed unused bodyElement and htmlElement data members. (WebCore::HTMLDocument::lastModified): Call getResponseModifiedHeader directly on the document loader.
  • loader/DocumentLoader.h: Moved m_mainResourceLoader, m_subresourceLoaders, and m_plugInStreamLoaders here.
  • loader/DocumentLoader.cpp: (WebCore::cancelAll): Moved here from FrameLoader. (WebCore::setAllDefersLoading): Ditto. (WebCore::DocumentLoader::mainResourceData): Moved the body of FrameLoader's mainResourceData function here. (WebCore::DocumentLoader::stopLoading): Replaced calls to hasMainResourceLoader and cancelMainResourceLoad with code that works directly on m_mainResourceLoader. Call the stop functions moved from FrameLoader here on ourselves. (WebCore::DocumentLoader::setupForReplaceByMIMEType): Ditto. (WebCore::DocumentLoader::setPrimaryLoadComplete): Moved the code to store the main resource data here; it doesn't require separate functions. (WebCore::DocumentLoader::isLoadingInAPISense): Removed call to isLoadingSubresources and instead just check if the m_subresourceLoaders set is empty. (WebCore::DocumentLoader::setDefersLoading): Moved code here from FrameLoader. (WebCore::DocumentLoader::stopLoadingPlugIns): Ditto. (WebCore::DocumentLoader::stopLoadingSubresources): Ditto. (WebCore::DocumentLoader::addSubresourceLoader): Ditto. (WebCore::DocumentLoader::removeSubresourceLoader): Ditto. (WebCore::DocumentLoader::addPlugInStreamLoader): Ditto. (WebCore::DocumentLoader::removePlugInStreamLoader): Ditto. (WebCore::DocumentLoader::isLoadingSubresources): Ditto. (WebCore::DocumentLoader::isLoadingPlugIns): Ditto. (WebCore::DocumentLoader::startLoadingMainResource): Ditto. (WebCore::DocumentLoader::cancelMainResourceLoad): Ditto.
  • loader/FrameLoader.h: Removed stopLoadingPlugIns, stopLoadingSubresources, cancelMainResourceLoad, hasMainResourceLoader, isLoadingSubresources, mainResourceData, releaseMainResourceLoader, lastModified, startLoadingMainResource, isLoadingPlugIns, m_mainResourceLoader, m_subresourceLoaders, m_plugInStreamLoaders, m_responseRefreshHeader, and m_responseModifiedHeader.
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::setDefersLoading): Call setDefersLoading on all the document loaders. (WebCore::FrameLoader::stopLoading): Get rid of code to set m_responseRefreshHeader and m_responseModifiedHeader. (WebCore::FrameLoader::receivedFirstData): Call httpHeaderField on the response here to get the Refresh, instead of storing it in a data member. (WebCore::FrameLoader::addPlugInStreamLoader): Change to just call this on the document loader. (WebCore::FrameLoader::removePlugInStreamLoader): Ditto. (WebCore::FrameLoader::isLoading): Change to call isLoadingSubresources and isLoadingPlugIns on the document loader. (WebCore::FrameLoader::addSubresourceLoader): Change to just call this on the document loader. (WebCore::FrameLoader::removeSubresourceLoader): Ditto. (WebCore::FrameLoader::commitProvisionalLoad): Call stopLoadingSubresources and stopLoadingPlugIns on the document loader. Removed code to set m_responseModifiedHeader. (WebCore::FrameLoader::startLoading): Call isLoadingMainResource and startLoadingMainResource on the document loader.
  • loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish): Call mainResourceData() on the document loader instead of the frame loader.
  • other changes
  • loader/DocLoader.cpp: (WebCore::DocLoader::checkCacheObjectStatus): Fixed indentation.

WebKit:

Reviewed by Anders.

  • Plugins/WebPluginController.mm: (-[WebPluginController pluginView:receivedResponse:]): Call cancelMainResourceLoad on the document loader instead of the frame loader.
9:24 AM Changeset in webkit [19736] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Mitz.

<rdar://problem/5009627> REGRESSION: Repro overrelease of WebView in failed load, seen in DumpRenderTree


  • WebView/WebView.mm: (-[WebView _removeObjectForIdentifier:]): Return early if the identifier can't be found in the map.
9:19 AM Changeset in webkit [19735] by zack
  • 3 edits in trunk/WebCore

Fix focus handling and make the forms
work as expected.
r=Lars

8:00 AM Changeset in webkit [19734] by weinig
  • 8 edits
    2 adds in trunk/WebCore

Reviewed by Darin and then Sam.

No test since there is no change in functionality.

  • CMakeLists.txt:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj: Added PositionIterator.{cpp,h}.
  • WebCoreSources.bkl:
  • dom/Position.cpp: (WebCore::Position::Position): Added converting constructor from PositionIterator. (WebCore::Position::previous): Changed assert() to ASSERT(). (WebCore::Position::next): Ditto. (WebCore::isStreamer): Changed the argument to a PositionIterator. (WebCore::Position::upstream): Changed to use PositionIterator. (WebCore::Position::downstream): Ditto. (WebCore::Position::inRenderedText): Made public. (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight): Changed into a static member function. (WebCore::Position::nodeIsUserSelectNone): Ditto.
  • dom/Position.h:
  • dom/PositionIterator.cpp: Added. A Position iterator with constant-time increment, decrement, and several predicates on the Position it is at. Conversion to/from Position is O(n) in the offset. (WebCore::PositionIterator::increment): (WebCore::PositionIterator::decrement): (WebCore::PositionIterator::atStart): (WebCore::PositionIterator::atEnd): (WebCore::PositionIterator::atStartOfNode): (WebCore::PositionIterator::atEndOfNode): (WebCore::PositionIterator::isCandidate):
  • dom/PositionIterator.h: Added. (WebCore::PositionIterator::PositionIterator): (WebCore::PositionIterator::node): (WebCore::PositionIterator::offsetInLeafNode):
  • editing/htmlediting.cpp: (WebCore::nextCandidate): Changed to use PositionIterator. (WebCore::previousCandidate): Changed to use PositionIterator.
7:43 AM Changeset in webkit [19733] by brmorris
  • 2 edits in S60/trunk/WebCore

hongzhao, reviewed by Zalan

DESC: [S60] - Browser NG, ReTe: Some call links on "cti_attribute.html " page are highlighted incorrectly ESZG-6TU9N9
Fix: Add hover sto a[cti].s
​http://bugs.webkit.org/show_bug.cgi?id=12814

7:39 AM Changeset in webkit [19732] by rwlbuis
  • 30 edits
    2 adds in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=12439
SVG parser complains about points attribute in polygon and polyline element

Return true when the parsed points specification is valid.

7:07 AM Changeset in webkit [19731] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

yadavall, Reviewed by Zalan Bujtas (​zbujtas@gmail.com).

DESC: Browser crashes when trying to open rss link hs.fi/rss HMNN-6YDEAW
​http://bugs.webkit.org/show_bug.cgi?id=12790

6:46 AM Changeset in webkit [19730] by zack
  • 10 edits in trunk

Make editing of forms work plus make sure that non-void methods
always return something.
r=Lars

4:30 AM Changeset in webkit [19729] by zack
  • 2 edits
    1 add in trunk/WebCore

Redo form-theming (aka. make Qt pretty, so very, very pretty)
r=Lars

2:33 AM Changeset in webkit [19728] by ap
  • 2 edits in trunk/WebCore

2007-02-19 Lars Naesbye Christensen <​lars@naesbye.dk>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12815
Two image files not included in project file

  • WebCore.xcodeproj/project.pbxproj: Added crossHairCursor.png and notAllowedCursor.png.
2:11 AM Changeset in webkit [19727] by gdennis
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin Adler.


Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12802
WebKit.framework is built with SVG_SUPPORT for No-SVG build

  • Scripts/build-webkit: Pass the "FEATURE_DEFINES=" option when building WebKit as well.

Feb 19, 2007:

9:35 PM Changeset in webkit [22971] by ggaren
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam Roben.

Fixed some leaks in RenderThemeSafari.


I just merged some of the code I wrote for RenderThemeMac.


9:33 PM Changeset in webkit [19726] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Adam Roben.

Fixed some leaks in RenderThemeMac.


No test case because 'leaks' can't detect these leaks inside DRT, even if
DRT forces the WebView to paint. ('leaks' can detect these leaks inside
Safari. Weird.)


  • rendering/RenderThemeMac.h:
    • Renamed data members to m_*, to match our style guidelines.
    • Renamed *Is* to is, to match our style guidelines.
    • Removed a few unnecessary data members.
    • Made cached values like m_checkbox mutable, since they can change inside functions that don't change the logical state of a RenderTheme object. (The alternative was to make some const functions non-const.)

(WebCore::RenderThemeMac::paintMenuList): Took CFType pointers that just
used to leak and placed them in RetainPtrs.
(WebCore::RenderThemeMac::paintMenuListButtonGradients): ditto

Factored inline implementations of lazy initialization into these accessor
functions, for better encapsulation:


(WebCore::RenderThemeMac::checkbox):
(WebCore::RenderThemeMac::radio):
(WebCore::RenderThemeMac::button):
(WebCore::RenderThemeMac::popupButton):
(WebCore::RenderThemeMac::search):
(WebCore::RenderThemeMac::sliderThumbHorizontal): The inline version of
this initialization used to confuse the retained data member with a local
stack value, causing both a leak and a failure to initialize. Fixed now.
(WebCore::RenderThemeMac::sliderThumbVertical): ditto
(WebCore::RenderThemeMac::resizeCornerImage):

9:19 PM Changeset in webkit [19725] by thatcher
  • 4 edits in trunk/JavaScriptGlue

Reviewed by Geoff.

<rdar://problem/4636301> Deprecate JavaScriptGlue

  • JavaScriptGlue.h: adds DEPRECATED_IN_MAC_OS_X_VERSION_10_5_AND_LATER to everything
  • JavaScriptGlue.xcodeproj/project.pbxproj: use -Wno-deprecated-declarations to keep the project building
  • config.h: define DEPRECATED_IN_MAC_OS_X_VERSION_10_5_AND_LATER as empty on other systems
8:38 PM Changeset in webkit [19724] by bdash
  • 3 edits in tags/Safari-521.35

Versioning.

8:33 PM Changeset in webkit [19723] by bdash
  • 2 edits in tags/Safari-521.35/WebCore

Merge in r19665.

8:31 PM Changeset in webkit [19722] by bdash
  • 10 edits in tags/Safari-521.35/WebCore

Merge in r19662.

8:30 PM Changeset in webkit [19721] by bdash
  • 6 edits in tags/Safari-521.35/WebCore

Merge in r19660.

8:24 PM Changeset in webkit [19720] by bdash
  • 1 copy in tags/Safari-521.35

New tag.

7:01 PM Changeset in webkit [19719] by weinig
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

  • fast/repaint/table-outer-border-expected.checksum: Added.
  • fast/repaint/table-outer-border-expected.png: Added.
  • fast/repaint/table-outer-border-expected.txt: Added.
  • fast/repaint/table-outer-border.html: Added.

WebCore:

Reviewed by Hyatt.

Test: fast/repaint/table-outer-border.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout): Reordered to initialize horizontal overflow after table sections have computed their outer horizontal borders.
6:39 PM Changeset in webkit [19718] by sullivan
  • 2 edits in trunk/WebCore

Reviewed by Darin


  • fixed <rdar://problem/4613701> REGRESSION: A line break in the source HTML of a link becomes visible after drag & drop
  • page/DragController.cpp: (WebCore::DragController::startDrag): Call simplifyWhiteSpace() on the proposed link title to match what's displayed on the web page, instead of using the raw source HTML text.
5:41 PM Changeset in webkit [19717] by hyatt
  • 60 edits
    4 adds in trunk

Fix for Radar 4981605, regression where button grows randomly when a select is
opened. With the new form controls, the WinIE quirk for using line width
ended up being used for them more.

This patch removes the quirk after verifying that Firefox doesn't implement
the quirk at all. usesLineWidth is being renamed to shrinksToAvoidFloats to
make it clear that the new method only applies to block objects that avoid floats
and that have auto width.

Also fixed a regression where whitespace after a floating <select> at the start
of a block got incorrectly rendered. Make sure skipWhitespace always skips
through floating/positioned elements regardless of the whitespace setting (this
way the white-space:pre value on floating <select>s doesn't cause trouble).

Reviewed by darin

fast/block/float/float-avoidance.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::clearFloatsIfNeeded): (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockWidth):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::shrinkToAvoidFloats):
  • rendering/RenderObject.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::skipWhitespace):
5:22 PM Changeset in webkit [19716] by weinig
  • 5 edits
    9 adds in trunk

LayoutTests:

Reviewed by Darin.

  1. Test for background image with relative url, when base url element is present. .html has a base url, which according to the html spec is supposed to be absolute, is actually a relative url. Absolute url would not work with ​file:// scheme.
  2. Test for base element and @import with relative url. ​http://bugs.webkit.org/show_bug.cgi?id=12214


  • fast/css/background-image-with-baseurl-expected.checksum: Added.
  • fast/css/background-image-with-baseurl-expected.png: Added.
  • fast/css/background-image-with-baseurl-expected.txt: Added.
  • fast/css/background-image-with-baseurl.html: Added.
  • fast/css/import_with_baseurl-expected.checksum: Added.
  • fast/css/import_with_baseurl-expected.png: Added.
  • fast/css/import_with_baseurl-expected.txt: Added.
  • fast/css/import_with_baseurl.html: Added.
  • fast/css/resources/background_image.css: Added.

WebCore:

Reviewed by Darin.

Update stylesheet href, when document's baseUrl changes. It needs
update when the stylesheet is constructed before the parser hits the base tag.
​http://bugs.webkit.org/show_bug.cgi?id=12214

  • css/StyleSheet.h: (WebCore::StyleSheet::setHref):
  • dom/Document.cpp: (WebCore::Document::setBaseURL):
  • dom/Document.h:
5:05 PM Changeset in webkit [19715] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Adam.

The FrameLoader's responseMIMEType was not being updated when a page was
brought back from the page cache.


Moved the line that updates the MIME type from commitProvisionalLoad() to
transitionToCommitted().

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted):
4:01 PM Changeset in webkit [19714] by ggaren
  • 2 edits in trunk/WebKitTools

Build fix.


  • Scripts/check-for-global-initializers: Ignore the global counter I added for SubresourceLoaders.
3:36 PM Changeset in webkit [22970] by aroben
  • 5 edits in branches/WindowsMerge/WebKitWin

Reviewed by Darin.

Fix <rdar://problem/5007566> Crash in WebFrame::dataSource on dni.ru

The fix for the bug was to zero out WebFrame's Frame pointer in
WebFrame::frameLoaderDestroyed, and then to null-check or ASSERT
non-null as appropriate. All IWebFrame methods that depend on the Frame
pointer will return E_FAIL if it is null, and everywhere within
WebFrame that wasn't null-checking before will now explicitly ASSERT.

I also changed all uses of d->frame and WebFrame::impl() to use the
core() function for consistency, and so that there is only one code
path for getting from a WebFrame to a Frame.

Additional more specific comments below.

  • WebChromeClient.cpp: (WebChromeClient::scrollBackingStore): (WebChromeClient::updateBackingStore):
  • WebFrame.cpp: (kit): Null-check the frame parameter. (core): Added two overloads of this. (WebFrame::DOMDocument): Added argument checking. (WebFrame::currentForm): (WebFrame::loadRequest): (WebFrame::loadData): (WebFrame::dataSource): Added argument checking, and return E_FAIL if the dataSource is null. (WebFrame::provisionalDataSource): Ditto. (WebFrame::stopLoading): (WebFrame::reload): (WebFrame::parentFrame): (WebFrame::renderTreeAsExternalRepresentation): Added argument checking. (WebFrame::firstLayoutDone): Ditto. (WebFrame::loadType): Ditto. (WebFrame::invalidate): (WebFrame::setTextSizeMultiplier): (WebFrame::inViewSourceMode): Added argument checking, and changed to return an HRESULT. (WebFrame::setInViewSourceMode): Changed to return an HRESULT. (WebFrame::searchForLabelsBeforeElement): Added argument checking. (WebFrame::matchLabelsAgainstElement): Ditto. (WebFrame::frameLoaderDestroyed): Zero out the Frame pointer because the Frame is being destroyed. (WebFrame::createFrame): (WebFrame::loadURLIntoChild): Added some assertions. (WebFrame::dispatchWillSubmitForm): (WebFrame::frameLoadCompleted): (WebFrame::receivedData): (WebFrame::setUpPolicyListener): (WebFrame::receivedPolicyDecision): (WebFrame::dispatchDecidePolicyForMIMEType): (WebFrame::dispatchDecidePolicyForNewWindowAction): (WebFrame::dispatchDecidePolicyForNavigationAction): (WebFrame::dispatchCreatePage): (WebFrame::createPlugin): (WebFrame::redirectDataToPlugin): (WebFrame::createJavaAppletWidget): (WebFrame::windowObjectCleared): (WebFrame::setPrinting): (WebFrame::setInPrintingMode): (WebFrame::computePageRects): (WebFrame::getPrintedPageCount): Zero out the out parameter before proceeding. (WebFrame::spoolPages): (WebFrame::forceLayoutWithPageWidthRange):
  • WebFrame.h:
  • WebView.cpp: (WebView::paint): Silently fail on a null Frame, because this method could be called at any time. (WebView::mouseWheel): Ditto. (WebViewWndProc): Ditto. (WebView::inViewSourceMode): Return whatever WebFrame::setInViewSourceMode returns. (WebView::setInViewSourceMode): Ditto. (WebView::setCustomTextEncodingName): Replaced check for a null FrameLoader with a check for a null Frame, which is equivalent but, as a bonus, won't crash. (WebView::stringByEvaluatingJavaScriptFromString): (WebView::elementAtPoint): Added argument checking. (WebView::selectedText): Ditto. (WebView::centerSelectionInVisibleArea):
3:34 PM Changeset in webkit [22969] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Oliver.

Fix build.

  • page/win/DragControllerWin.cpp: (WebCore::DragController::maxDragImageSize):
3:32 PM Changeset in webkit [19713] by andersca
  • 5 edits in trunk/WebCore

Reviewed by Oliver.

Make DragController::maxDragImageSize a function to get rid of the global initializer.


  • page/DragController.cpp: (WebCore::DragController::doImageDrag):
  • page/DragController.h:
  • page/mac/DragControllerMac.mm: (WebCore::DragController::maxDragImageSize):
  • page/qt/DragControllerQt.cpp: (WebCore::DragController::maxDragImageSize):
3:19 PM Changeset in webkit [22968] by adele
  • 4 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Adam.

Fix for <rdar://problem/5006882> PlatformScrollbarSafari doesn't support small scroll bars

3:19 PM Changeset in webkit [19712] by darin
  • 2 edits in trunk/WebKitTools

Reviewed by Tim Hatcher.

  • Scripts/check-for-global-initializers: Delete the linked executable if the check fails. Without this, you only see the global initializer error once, which makes it very easy to miss them.
3:09 PM Changeset in webkit [19711] by thatcher
  • 3 edits in trunk/WebKit

Reviewed by Darin Adler.

<rdar://problem/4841078> Remove the Mail.app editable link clicking behavior workaround when it is no longer needed

  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebView.mm: (-[WebView setPreferences:]):
2:47 PM Changeset in webkit [22967] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/5008424>
Regression: Crash loading mp3.com


  • platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::ResourceError): Handle null resource errrors.
1:44 PM Changeset in webkit [19710] by darin
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

  • <rdar://problem/5006414> REGRESSION: Crash occurs at WebCore::Frame::loader() when loading AFL Ladder widget
  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::openURL): Add missing null check so this fails without crashing when called on an element that's no longer in a frame.
1:39 PM Changeset in webkit [19709] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Adam.

<rdar://problem/4868242>
​http://bugs.webkit.org/show_bug.cgi?id=12670
REGRESSION: Many 3rd Party Apps crash in WebCore::DocumentLoader::frameLoader() (12670)


Bring back the semantic we had that a web view should be retained for as long as something is loading. Use the identifier
to object hash map for this.

  • WebView/WebView.mm: (-[WebView _addObject:forIdentifier:]): (-[WebView _removeObjectForIdentifier:]):
11:41 AM Changeset in webkit [19708] by thatcher
  • 3 edits in trunk/WebKit

Remove two imports of FrameMac.h, fixes clean Mac builds.

7:43 AM Changeset in webkit [19707] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Mitz.


  • fast/forms/select-accesskey-expected.checksum: Added.
  • fast/forms/select-accesskey-expected.png: Added.
  • fast/forms/select-accesskey-expected.txt: Added.
  • fast/forms/select-accesskey.html: Added.

WebCore:

Reviewed by Mitz.


Focus the select element too in accessKeyAction.

  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::accessKeyAction):
1:20 AM Changeset in webkit [19706] by antti
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.


Avoid double painting caret when it is on a block element.


Layout test for this already went in previous try (it only fails in pixel mode) in r19626.

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintCaret):
12:35 AM Changeset in webkit [22966] by aroben
  • 5 edits in branches/WindowsMerge

WebCoreWin:

Build fix.

  • bridge/win/FrameWin.cpp: (WebCore::computePageRectsForFrame): This is no longer an instance method of Frame.
  • bridge/win/FrameWin.h:

WebKitWin:

Build fix.

  • WebFrame.cpp: (WebFrame::computePageRects):
12:13 AM Changeset in webkit [19705] by lars
  • 3 edits in trunk/WebCore

Added a one line patch from Olliej to create the
clipboard on demand (to stop things from crashing),
and added lots of notImplemented() warnings all
over the place.

Feb 18, 2007:

11:58 PM Changeset in webkit [22965] by mjs
  • 20 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Oliver.

  • Adapt for Lars's patch to clean up Frame
  • bridge/win/FrameWin.cpp: (WebCore::Frame::cleanupPlatformScriptObjects): (WebCore::Frame::createScriptInstanceForWidget): (WebCore::Frame::computePageRects): (WebCore::drawRectIntoContext): (WebCore::imageFromSelection): (WebCore::Frame::isCharacterSmartReplaceExempt):
  • bridge/win/FrameWin.h:
  • page/win/EventHandlerWin.cpp:
  • platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::windowResizerRect): (WebCore::ScrollView::addToDirtyRegion): (WebCore::ScrollView::scrollBackingStore): (WebCore::ScrollView::updateBackingStore):
  • platform/win/TemporaryLinkStubs.cpp: (Frame::print): (Frame::issueTransposeCommand): (WebCore::Frame::respondToChangedSelection):
  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabaseWin::createPluginView):
  • plugins/win/PluginDatabaseWin.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::createNullPluginView): (WebCore::PluginViewWin::PluginViewWin):
  • plugins/win/PluginViewWin.h:

WebKitWin:

Reviewed by Oliver.

  • Adapt for Lars's patch to clean up Frame
  • WebChromeClient.cpp: (WebChromeClient::tabsToLinks): (WebChromeClient::windowResizerRect): (WebChromeClient::addToDirtyRegion): (WebChromeClient::scrollBackingStore): (WebChromeClient::updateBackingStore):
  • WebChromeClient.h:
  • WebEditorClient.cpp: (WebEditorClient::shouldChangeSelectedRange): (WebEditorClient::textFieldDidBeginEditing): (WebEditorClient::textFieldDidEndEditing): (WebEditorClient::textDidChangeInTextField): (WebEditorClient::doTextFieldCommandFromEvent): (WebEditorClient::textWillBeDeletedInTextField): (WebEditorClient::textDidChangeInTextArea):
  • WebEditorClient.h:
  • WebElementPropertyBag.cpp: (WebElementPropertyBag::Read):
  • WebFrame.cpp: (kit): (WebFrame::initWithWebFrameView): (WebFrame::searchForLabelsBeforeElement): (WebFrame::matchLabelsAgainstElement): (WebFrame::createPlugin): (WebFrame::createJavaAppletWidget): (WebFrame::computePageRects): (WebFrame::getPrintedPageCount): (WebFrame::spoolPages):
  • WebFrame.h:
  • WebView.cpp: (WebView::handleEditingKeyboardEvent): (WebView::keyDown): (WebView::generateSelectionImage):
  • WebView.h:
11:58 PM Changeset in webkit [19704] by beidson
  • 3 edits in trunk/WebKit

Reviewed by Oliver

<rdar://problem/4985321> - Can't edit templates for Web Gallery/Web Page Export in Aperture

  • Misc/WebKitVersionChecks.h: Add a #define for this APERTURE quirk
  • WebView/WebView.mm: (-[WebView _shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): If the current app is Aperture and it was linked against Tiger WebKit, always allow selection change
11:57 PM Changeset in webkit [19703] by lars
  • 2 edits in trunk/WebCore

fix compilation.

11:54 PM Changeset in webkit [19702] by mjs
  • 91 edits
    4 adds
    2 deletes in trunk

WebCore:

Reviewed by Maciej.


Additional coding by Maciej, additional review by Oliver.

Get rid of the FrameMac and FrameQt classes. Instead
move all methods into Frame directly, and implement
some platform specific methods in foo/FrameFoo.cpp.

Some general cleanup in Frame:

  • Move some methods out of Frame, to the place where they belong.
  • Unify the different ways of creating the JavaScript wrappers for <object>, <embed> and <applet>
  • Some cleanup of the WebCoreFrameBridge
  • ForwardingHeaders/bindings/NP_jsobject.h: Added.
  • ForwardingHeaders/bindings/npruntime_impl.h: Added.
  • ForwardingHeaders/bindings/runtime_root.h: Added.
  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::shouldInterruptScript):
  • bindings/objc/DOM.mm: (-[DOMNode KJS::Bindings::]):
  • bindings/objc/DOMInternal.mm: (-[WebScriptObject _initializeScriptDOMNodeImp]):
  • bridge/EditorClient.h:
  • bridge/mac/FrameViewMac.mm: (WebCore::FrameView::updateBorder): (WebCore::FrameView::updateDashboardRegions):
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject rendererForView:]):
  • dom/Position.cpp: (WebCore::Position::next):
  • editing/CommandByName.cpp: (WebCore::Frame::execCopy): (WebCore::Frame::execCut): (WebCore::Frame::execPaste):
  • editing/Editor.cpp: (WebCore::Editor::canEdit): (WebCore::Editor::pasteWithPasteboard): (WebCore::Editor::paste): (WebCore::Editor::pasteAsPlainText):
  • editing/Editor.h:
  • editing/JSEditor.cpp:
  • html/HTMLAppletElement.cpp: (WebCore::HTMLAppletElement::getInstance):
  • html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::getInstance):
  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::formData):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::getInstance):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::clear): (WebCore::FrameLoader::detachFromParent):
  • loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):
  • loader/qt/DocumentLoaderQt.cpp:
  • page/Chrome.cpp: (WebCore::Chrome::shouldInterruptJavaScript):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/Frame.cpp: (WebCore::Frame::~Frame): (WebCore::Frame::markedTextRange): (WebCore::Frame::shouldChangeSelection): (WebCore::Frame::shouldDeleteSelection): (WebCore::Frame::isContentEditable): (WebCore::Frame::setSecureKeyboardEntry): (WebCore::Frame::isSecureKeyboardEntry): (WebCore::Frame::bindingRootObject): (WebCore::Frame::createRootObject): (WebCore::Frame::windowScriptNPObject): (WebCore::Frame::cleanupScriptObjects): (WebCore::FramePrivate::FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/FrameView.h:
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::tabsToLinks): (WebCore::EventHandler::tabsToAllControls): (WebCore::EventHandler::focusDocumentView): (WebCore::EventHandler::passMouseDownEventToWidget): (WebCore::EventHandler::handleDrag): (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking): (WebCore::EventHandler::keyboardUIMode):
  • page/mac/FrameMac.h: Removed.
  • page/mac/FrameMac.mm: (WebCore::Frame::setBridge): (WebCore::Frame::bridge): (WebCore::Frame::searchForLabelsAboveCell): (WebCore::Frame::searchForLabelsBeforeElement): (WebCore::Frame::matchLabelsAgainstElement): (WebCore::Frame::focusWindow): (WebCore::Frame::unfocusWindow): (WebCore::Frame::imageFromRect): (WebCore::Frame::selectionImage): (WebCore::Frame::snapshotDragImage): (WebCore::Frame::fontAttributesForSelectionStart): (WebCore::Frame::baseWritingDirectionForSelectionStart): (WebCore::Frame::print): (WebCore::Frame::issuePasteCommand): (WebCore::Frame::issueTransposeCommand): (WebCore::Frame::respondToChangedSelection): (WebCore::Frame::textFieldDidBeginEditing): (WebCore::Frame::textFieldDidEndEditing): (WebCore::Frame::textDidChangeInTextField): (WebCore::Frame::textDidChangeInTextArea): (WebCore::Frame::doTextFieldCommandFromEvent): (WebCore::Frame::textWillBeDeletedInTextField): (WebCore::Frame::setSecureKeyboardEntry): (WebCore::Frame::isSecureKeyboardEntry): (WebCore::Frame::setMarkedTextRange): (WebCore::Frame::dashboardRegionsDictionary): (WebCore::Frame::dashboardRegionsChanged): (WebCore::Frame::willPopupMenu): (WebCore::Frame::isCharacterSmartReplaceExempt): (WebCore::Frame::setNeedsReapplyStyles): (WebCore::Frame::customHighlightLineRect): (WebCore::Frame::paintCustomHighlight): (WebCore::Frame::createScriptInstanceForWidget): (WebCore::Frame::windowScriptObject): (WebCore::Frame::cleanupPlatformScriptObjects):
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm: (createRootObject): (bridge): (-[WebCoreFrameBridge _frame]):
  • page/qt/EventHandlerQt.cpp:
  • page/qt/FrameQt.cpp: (WebCore::Frame::unfocusWindow): (WebCore::Frame::focusWindow): (WebCore::Frame::issueTransposeCommand): (WebCore::Frame::respondToChangedSelection): (WebCore::Frame::print): (WebCore::Frame::createScriptInstanceForWidget): (WebCore::Frame::cleanupPlatformScriptObjects): (WebCore::Frame::isCharacterSmartReplaceExempt):
  • page/qt/FrameQt.h: Removed.
  • platform/MimeTypeRegistry.h:
  • platform/graphics/svg/SVGImage.cpp: (WebCore::SVGImage::setData):
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::shouldInterruptJavaScript): (WebCore::SVGEmptyEditorClient::shouldChangeSelectedRange):
  • platform/mac/ClipboardMac.h:
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::ClipboardMac):
  • platform/mac/FileChooserMac.mm: (-[OpenPanelController beginSheetWithFrame:]):
  • platform/mac/MimeTypeRegistryMac.mm: (WebCore::MimeTypeRegistry::getMIMETypeForPath):
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show):
  • platform/mac/WidgetMac.mm: (WebCore::Widget::setFocus): (WebCore::Widget::setIsSelected):
  • platform/network/mac/ResourceHandleMac.mm:
  • platform/network/qt/ResourceHandleManagerQt.cpp:
  • platform/network/qt/ResourceHandleQt.cpp: (WebCore::ResourceHandle::start):
  • platform/qt/MimeTypeRegistryQt.cpp: (WebCore::MimeTypeRegistry::getMIMETypeForPath):
  • platform/qt/PopupMenuQt.cpp:
  • platform/qt/ScrollViewCanvasQt.cpp:
  • platform/qt/ScrollViewQt.cpp:
  • platform/win/TemporaryLinkStubs.cpp:
  • rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintCustomHighlight):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::paintCustomHighlight):
  • rendering/RootInlineBox.cpp: (WebCore::RootInlineBox::addHighlightOverflow): (WebCore::RootInlineBox::paintCustomHighlight):

WebKit:

Reviewed by Maciej.

Additional coding by Maciej, additional review by Oliver.

Added implementations for the new callbacks in EditorClient
and ChromeClient (basically moved from WebFrameBridge).
Cleaned up some code paths that are not called anymore
and done fully inside WebCore now.

  • DefaultDelegates/WebDefaultContextMenuDelegate.mm:
  • Misc/WebElementDictionary.mm:
  • Misc/WebNSAttributedStringExtras.mm:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView getVariable:value:]):
  • Plugins/WebNetscapePluginEmbeddedView.mm:
  • Plugins/WebNetscapePluginStream.mm:
  • Plugins/WebPluginContainerCheck.mm:
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::shouldInterruptJavaScript):
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebEditorClient.mm: (WebEditorClient::shouldChangeSelectedRange):
  • WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge finishInitializingWithPage:frameName:frameView:ownerElement:]): (-[WebFrameBridge fini]):
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebArchiver.mm:
  • WebView/WebFrame.mm: (core): (kit): (-[WebFrame _updateBackground]):
  • WebView/WebFrameInternal.h:
  • WebView/WebFrameView.mm:
  • WebView/WebHTMLRepresentation.mm:
  • WebView/WebHTMLView.mm: (-[WebHTMLView _updateMouseoverWithEvent:]): (-[WebHTMLView _isEditable]): (-[WebHTMLView validateUserInterfaceItem:]): (-[WebHTMLView maintainsInactiveSelection]): (-[WebHTMLView scrollWheel:]): (-[WebHTMLView acceptsFirstMouse:]): (-[WebHTMLView shouldDelayWindowOrderingForEvent:]): (-[WebHTMLView cut:]): (-[WebHTMLView paste:]): (-[WebHTMLView selectedAttributedString]):
  • WebView/WebScriptDebugDelegate.mm:
  • WebView/WebView.mm: (-[WebView _dashboardRegions]): (-[WebView setProhibitsMainFrameScrolling:]): (-[WebView _setInViewSourceMode:]): (-[WebView _inViewSourceMode]): (-[WebView shouldClose]): (-[WebView setEditable:]):

WebKitQt:

Reviewed by Maciej.

Additional coding by Maciej, additional review by Oliver.

Add stubs for the new methods in ChormeClient and EditorClient,
remove all references to FrameQt.

  • Api/qwebframe.cpp: (QWebFrame::QWebFrame):
  • Api/qwebframe_p.h:
  • Api/qwebpage.cpp:
  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::shouldInterruptJavaScript):
  • WebCoreSupport/ChromeClientQt.h:
  • WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::shouldChangeSelectedRange): (WebCore::EditorClientQt::isEditable):
  • WebCoreSupport/EditorClientQt.h:
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::setFrame): (WebCore::FrameLoaderClientQt::webFrame):
  • WebCoreSupport/FrameLoaderClientQt.h:
11:18 PM Changeset in webkit [19701] by oliver
  • 2 edits in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (Buildfix).

Oops, missed a 'const'

  • platform/qt/ClipboardQt.h:
11:04 PM Changeset in webkit [19700] by oliver
  • 3 edits
    2 adds in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Adding stubbed out implementation of Clipboard for Qt to stop
it crashing whenever someone drags the mouse.

  • WebCore.pro:
  • page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::createDraggingClipboard):
  • platform/qt/ClipboardQt.cpp: Added. (WebCore::ClipboardQt::ClipboardQt): (WebCore::ClipboardQt::clearData): (WebCore::ClipboardQt::clearAllData): (WebCore::ClipboardQt::getData): (WebCore::ClipboardQt::setData): (WebCore::ClipboardQt::types): (WebCore::ClipboardQt::dragLocation): (WebCore::ClipboardQt::dragImage): (WebCore::ClipboardQt::setDragImage): (WebCore::ClipboardQt::dragImageElement): (WebCore::ClipboardQt::setDragImageElement): (WebCore::ClipboardQt::createDragImage): (WebCore::ClipboardQt::declareAndWriteDragImage): (WebCore::ClipboardQt::writeURL): (WebCore::ClipboardQt::writeRange): (WebCore::ClipboardQt::hasData):
  • platform/qt/ClipboardQt.h: Added. (WebCore::ClipboardQt::~ClipboardQt): (WebCore::ClipboardQt::isForDragging):
11:00 PM Changeset in webkit [22964] by adachan
  • 9 edits
    4 adds in branches/WindowsMerge

2007-02-18 Ada Chan <​adachan@apple.com>

WebCoreWin:

Reviewed by Adam.

Move app text controls to use WebView.

  • added a method to let us render text using WebKit.
  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/WebCoreTextRenderer.cpp: Added. (WebCore::WebCoreDrawTextAtPoint):
  • platform/win/WebCoreTextRenderer.h: Added.

WebKitWin:

Reviewed by Adam.


Move app text controls to use webview

10:14 PM WebKit Team edited by oliver@apple.com
I appear to be the DnD guy now (diff)
10:07 PM Changeset in webkit [19699] by oliver
  • 2 edits in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Don't even attempt to do a document based drag if there isn't a document
Fixes rdar://problem/4960109

  • page/DragController.cpp: (WebCore::DragController::tryDocumentDrag):

Null check m_document

(WebCore::DragController::tryDHTMLDrag):

ASSERT(m_document) -- tryDocumentDrag is the only
thing that will ever call us, but lets play it safe


4:42 PM Changeset in webkit [22963] by aroben
  • 4 edits in branches/WindowsMerge/WebCore

Rubberstamped by Hyatt.

Fix <rdar://problem/5006918> All selected text is black, even if it is
some other color when not selected

4:28 PM Changeset in webkit [22962] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Hyatt.

Fix <rdar://problem/5006872> <select> popups need Aqua scroll bars

PopupMenuWin now uses a PlatformScrollbar.

4:26 PM Changeset in webkit [19698] by aroben
  • 2 edits in trunk/WebCore

Reviewed by Hyatt.

A little preparation for <rdar://problem/5006872>.

  • platform/PopupMenu.h:
1:07 PM Changeset in webkit [19697] by ap
  • 4 edits
    2 adds in trunk

Reviewed by Adele.

​http://bugs.webkit.org/show_bug.cgi?id=12807
XPath incorrectly converts NaN to boolean

Test: fast/xpath/nan-to-boolean.html

  • xml/XPathValue.cpp: (WebCore::XPath::Value::toBoolean): Convert NaN to false.
  • xml/XPathFunctions.cpp: (WebCore::XPath::FunSubstringAfter::doEvaluate): Fix substring-after to actually work.
8:15 AM Changeset in webkit [19696] by ap
  • 128 edits
    12 adds in trunk

2007-02-18 Mitz Pettel <​mitz@webkit.org>

Reviewed by Hyatt.

Tests: fast/repaint/float-overflow.html

fast/repaint/float-overflow-right.html
fast/repaint/table-cell-vertical-overflow.html

Reflected in existing test results.

Unified floats and overflow for the purposes of painting and hit-testing.
Overhanging and overflowing floats are now factored into a block's overflow
unless their painting has been propagated to an ancestor.

Changed table cells to no longer expand to enclose overflow, thus making
it purely "visual overflow", having no effect on layout in WebCore. It
still determines scrolling dimensions.

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally): Include inline blocks' horizontal overflow in the inline box's dimensions.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Removed the expand to enclose overflows behavior. Added code to add this block's floats (and their overflow) to its overflow rect if it is not in a block formatting context. Otherwise, the inclusion of floats in the overflow is deferred until this block's parent examines its floats and possibly adopts overhanging floats. (WebCore::RenderBlock::layoutBlockChildren): (WebCore::RenderBlock::paint): (WebCore::RenderBlock::floatRect): Made non-virtual and changed to return an empty rect if there are no floats or the floats are clipped, instead of returning the border box. (WebCore::RenderBlock::addOverhangingFloats): Any floats of the child that are not to be painted by the parent are added to the child's overflow rect. (WebCore::RenderBlock::addVisualOverflow): Added. Adjusts the overflow bounds to include the given rect. (WebCore::RenderBlock::nodeAtPoint):
  • rendering/RenderBlock.h:
  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutBlock): (WebCore::RenderFlexibleBox::layoutHorizontalBox): After placing a normal child, add its floats to its overflow, since painting of floats does not propagate to flexible boxes. (WebCore::RenderFlexibleBox::layoutVerticalBox): Ditto.
  • rendering/RenderForeignObject.cpp: (WebCore::RenderForeignObject::layout):
  • rendering/RenderHTMLCanvas.cpp: (WebCore::RenderHTMLCanvas::layout):
  • rendering/RenderImage.cpp: (WebCore::RenderImage::layout):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::absoluteBoundingBox):
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
  • rendering/RenderObject.h: (WebCore::RenderObject::expandsToEncloseOverhangingFloats):
  • rendering/RenderPath.cpp: (WebCore::RenderPath::layout):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout):
  • rendering/RenderSVGText.cpp: (WebCore::RenderSVGText::layout):
  • rendering/RenderTable.h: Removed the override of overflowHeight() since now tables can have vertical overflow.
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paint): Made sure that overflow is repainted.
  • rendering/RenderTableCell.h: (WebCore::RenderTableCell::expandsToEncloseOverhangingFloats): Removed.
  • rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::RenderTableSection): (WebCore::RenderTableSection::layoutRows): Factor in vertical overflow from cells. (WebCore::RenderTableSection::paint):
  • rendering/RenderTableSection.h: (WebCore::RenderTableSection::overflowHeight): (WebCore::RenderTableSection::overflowTop):
6:23 AM Changeset in webkit [19695] by oliver
  • 2 edits in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (Buildfix).

Build fix for the build fix -- can't call something that isn't a function

  • platform/qt/CursorQt.cpp: (WebCore::notAllowedCursor):
5:48 AM Changeset in webkit [19694] by oliver
  • 3 edits in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (Build fix).

Adding platform/DragImage.cpp and platform/qt/DragImageQt.cpp to the Qt
project files

Stubbed method for WebCore::notAllowedCursor -- not sure what it should return,
have returned blank cursor, possibly needs to return something else

  • WebCore.pro:
  • platform/qt/CursorQt.cpp: (WebCore::notAllowedCursor):
5:07 AM Changeset in webkit [19693] by oliver
  • 3 edits in trunk/WebKitQt

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (Buildfix).

Build fix -- adding DragClientQt method stubs

  • WebCoreSupport/DragClientQt.cpp: (WebCore::DragClientQt::willPerformDragSourceAction): (WebCore::DragClientQt::startDrag): (WebCore::DragClientQt::createDragImageForLink):
  • WebCoreSupport/DragClientQt.h:
4:59 AM Changeset in webkit [19692] by oliver
  • 2 edits in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (Buildfix).

Sigh, obnoxious occasional auto conversion from float to int

  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::createDragImage):


4:48 AM Changeset in webkit [19691] by ap
  • 6 edits
    2 adds in trunk

Reviewed by Hyatt.

​http://bugs.webkit.org/show_bug.cgi?id=12799
REGRESSION: Webpage doesn't load correctly (www.cincinnati.com
redirects to the wrong URL)

Test: http/tests/misc/refresh-meta-with-newline.html

  • platform/network/HTTPParsers.cpp: (WebCore::skipWhiteSpace): (WebCore::parseHTTPRefresh):
  • platform/network/HTTPParsers.h: In HTML, all characters with codes <= 0x20 are whitespace, while in HTTP, only space and tab are such.
  • dom/Document.cpp: (WebCore::Document::processHttpEquiv):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::receivedFirstData): Pass parseHTTPRefresh() a flag telling about the source of data.
4:44 AM Changeset in webkit [19690] by oliver
  • 2 edits in trunk/WebCore

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by NOBODY (Build fix).

Buld fix -- surprisingly RetainPtr doesn't exist on Qt

  • platform/DragImage.h:


4:35 AM Changeset in webkit [22961] by oliver
  • 10 edits
    1 add in branches/WindowsMerge

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

WebCore:

Updated to include stubs for drag and drop methods
Added DragImage[Win].cpp to project file
Now uses platform independent EventHandler::handleDrag

  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/FrameWin.cpp: (WebCore::Frame::dragImageForSelection): Just wrap the platform specific selectionImage method
  • page/win/DragControllerWin.cpp: Defining constants for drag images -- basically copied the Mac definitions
  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::createDraggingClipboard): Basic implementation -- needs to create an IDataObject to be useful but ClipboardWin is basically unimplemented anyway so not yet a problem
  • platform/win/ClipboardWin.cpp: (WebCore::ClipboardWin::createDragImage): (WebCore::ClipboardWin::declareAndWriteDragImage): (WebCore::ClipboardWin::writeURL): (WebCore::ClipboardWin::writeRange): (WebCore::ClipboardWin::hasData): Stubs
  • platform/win/ClipboardWin.h: Updated interface
  • platform/win/DragImageWin.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage): Stubs

WebKit:

Stubs to keep the build going

  • WebDragClient.cpp: (WebDragClient::willPerformDragSourceAction): (WebDragClient::startDrag): (WebDragClient::createDragImageForLink):
  • WebDragClient.h:
4:30 AM Changeset in webkit [19689] by oliver
  • 28 edits
    4 adds in trunk

2007-02-18 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

WebCore:

More drag and drop migration, now the entirety of the
drag initiation logic has been rendered platform independent
This has required a number of new interfaces, and a reasonable
amount of logic migration.

As a side effect, this patch also fixes rdar://problem/4945341

There are some basic Qt stubs that should stop the build from failing,
however the absence of ClipboardQt means any attempt to initiate a drag
may cause a crash.

  • WebCore.exp:

Exporting new symbols

  • WebCore.xcodeproj/project.pbxproj:

New files

  • dom/Clipboard.cpp: (WebCore::Clipboard::canSaveAsWebArchive): Migrated from WebKit
  • dom/Clipboard.h: Added more methods to allow Clipboard to be used as a platform independent container for drag and drop
  • page/DragClient.h: (WebCore::DragClient::declareAndWriteDragImage): This is a mac only helper function, so i've made it have an empty implementation, that way we won't need a PLATFORM(MAC) block in SVGImageEmptyClients
  • page/DragController.cpp: (WebCore::DragController::dragExited): (WebCore::DragController::performDrag): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::tryDHTMLDrag): Using RefPtrs now (WebCore::getCachedImage): (WebCore::getImage): Helper functions (WebCore::dragLocForDHTMLDrag): (WebCore::dragLocForSelectionDrag): (WebCore::DragController::startDrag): (WebCore::DragController::doImageDrag): (WebCore::DragController::doSystemDrag): Logic that generates drag images and clipboard content, and initiates the actual system drag operation
  • page/DragController.h: Method and variable declarations
  • page/EventHandler.cpp: (WebCore::EventHandler::handleDrag): handleDrag is now platform independent (WebCore::EventHandler::handleTextInputEvent):

formatting

  • page/EventHandler.h: (WebCore::EventHandler::eventLoopHandleMouseDragged): Forgot to define this stub function
  • page/Frame.h: Declaring dragImageForSelection to provide drag image for selected content
  • page/mac/DragControllerMac.mm: Defining drag images control vars
  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::createDraggingClipboard): Migrated old clipboard creation to here
  • page/mac/FrameMac.mm: (WebCore::Frame::dragImageForSelection): Wrap FrameMac::selectionImage
  • page/qt/DragControllerQt.cpp: Defining drag images control vars
  • page/qt/EventHandlerQt.cpp: (WebCore::EventHandler::createDraggingClipboard): stub
  • page/qt/FrameQt.cpp: (WebCore::Frame::dragImageForSelection): stub
  • platform/DragImage.cpp: Added. (WebCore::fitDragImageToMaxSize): (WebCore::createDragImageForSelection):

Platform independent processing for drag images

  • platform/DragImage.h: Added.

Declaring typedefs and wrapper functions to abstract the handling
of drag images

  • platform/Pasteboard.h: Declaring extracted writeURL and writeSelection methods
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyDragClient::willPerformDragSourceAction): (WebCore::SVGEmptyDragClient::startDrag): (WebCore::SVGEmptyDragClient::createDragImageForLink): Stubs FTW!
  • platform/mac/ClipboardMac.h: (WebCore::ClipboardMac::pasteboard): Provide accessor for underlying NSPasteboard
  • platform/mac/ClipboardMac.mm: (WebCore::ClipboardMac::hasData): (WebCore::ClipboardMac::writeRange): (WebCore::ClipboardMac::writeURL): (WebCore::ClipboardMac::declareAndWriteDragImage): (WebCore::ClipboardMac::createDragImage):

Implemented new Clipboarid functionality.

(WebCore::ClipboardMac::dragNSImage):

Made this a const method

  • platform/mac/DragImageMac.mm: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage):

Implemented platform specific DragImage functions

  • platform/mac/PasteboardMac.mm: (WebCore::writeSelection): (WebCore::Pasteboard::writeSelection): (WebCore::writeURL): (WebCore::Pasteboard::writeURL):

Extracted member implementations of these functions, so that
Clipboard could also make use of this functionality.
Pasteboard methods now call the new non-member implementations.
Also fixed implementations to respect the list of requested types.

  • platform/qt/DragImageQt.cpp: Added. (WebCore::dragImageSize): (WebCore::deleteDragImage): (WebCore::scaleDragImage): (WebCore::dissolveDragImageToFraction): (WebCore::createDragImageFromImage): (WebCore::createDragImageIconForCachedImage): Stubs

WebKit:

Moving the drag initiation logic to WebCore.
The redundant code in webkit will be moved out in a later patch.

  • WebCoreSupport/WebDragClient.h:
  • WebCoreSupport/WebDragClient.mm: (getTopHTMLView): Helper function (WebDragClient::willPerformDragSourceAction): (WebDragClient::startDrag): (WebDragClient::createDragImageForLink): Implemented new DragClient methods (WebDragClient::declareAndWriteDragImage): Helper function for the Mac to allow new drag and drop code to match behaviour


  • WebView/WebHTMLView.mm: (-[WebHTMLView _dragImageForURL:withLabel:]): (-[WebHTMLView _dragImageForLinkElement:]): Refactoring old _dragImageForLinkElement function so that the link drag image can be created with just a URL and label, rather than requiring the original element (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Removed logic that is no longer necessary (-[WebHTMLView _mouseDownEvent]): The WebDragClient may need the original mouseDownEvent of a drag when initiating a drag
  • WebView/WebHTMLViewInternal.h: Declaring _mouseDownEvent
  • WebView/WebHTMLViewPrivate.h: Declaring _dragImageForURL



12:48 AM Changeset in webkit [19688] by ap
  • 4 edits in trunk/JavaScriptCore

2007-02-18 Kevin Ollivier <​kevino@theolliviers.com>

Reviewed by Adam Roben.

Fix cases where MSVC-specific code was identified as Win32 platform
code. (as it should be compiled for e.g. wx port when using MSVC too)


  • wtf/Assertions.h:
  • wtf/MathExtras.h:
  • wtf/StringExtras.h: changed PLATFORM(WIN) sections to COMPILER(MSVC) as necessary

Feb 17, 2007:

10:28 PM Changeset in webkit [22960] by aroben
  • 2 edits in branches/WindowsMerge/WebCore
  • WebCore.vcproj/WebCore.vcproj: Removed bogus single-file configuration for MimeTypeRegistryWin.cpp.
10:04 PM Changeset in webkit [22959] by sfalken
  • 4 edits in branches/WindowsMerge/WebKitWin

2007-02-17 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Adam.

  • Interfaces/IWebViewPrivate.idl: Added scrollBy, visibleContentRect
  • WebView.cpp: (WebView::scrollOffset): Add null check (WebView::scrollBy): Added so we can scroll a webview easily (matches scroll position getter here) (WebView::visibleContentRect): Added so we can size find overlay appropriately (not including scroll bars)
  • WebView.h: Added scrollBy, visibleContentRect
5:59 PM Changeset in webkit [22958] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

Part of the OpenSource fix to make sure the fill color starts off as transparent. Make sure our CG context
has its state properly in sync with the CGContext.

Reviewed by aroben

  • platform/win/GraphicsContextWin.cpp: (WebCore::GraphicsContext::GraphicsContext):
5:58 PM Changeset in webkit [19687] by hyatt
  • 2 edits in trunk/WebCore

Fix textarea resizers to not fill with black by making sure the fill color starts off as
transparent instead of black.

Reviewed by aroben

  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContextState::GraphicsContextState):
5:52 PM Changeset in webkit [22957] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Build fix.

  • platform/win/CursorWin.cpp: (WebCore::notAllowedCursor):
2:23 PM Changeset in webkit [19686] by aroben
  • 2 edits in trunk

Added missing Radar references to ChangeLogs.

2:21 PM Changeset in webkit [19685] by aroben
  • 3 edits
    4 adds in trunk

2007-02-17 Lars Knoll <​lars@trolltech.com>

LayoutTests:

Reviewed by Adam.

test for ​http://bugs.webkit.org/show_bug.cgi?id=11476
<img> tags nested inside <map> where not showing up

  • fast/images/image-in-map-expected.checksum: Added.
  • fast/images/image-in-map-expected.png: Added.
  • fast/images/image-in-map-expected.txt: Added.
  • fast/images/image-in-map.html: Added.

WebCore:

Reviewed by Adam.

fix ​http://bugs.webkit.org/show_bug.cgi?id=11476
<img> tags nested inside <map> where not showing up

Test: fast/images/image-in-map.html

  • html/HTMLMapElement.cpp: (WebCore::HTMLMapElement::checkDTD):
2:09 PM Changeset in webkit [19684] by weinig
  • 7 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12733
XPath namespace is attached to a wrong step

  • fast/xpath/namespace-vs-predicate-expected.txt: Added.
  • fast/xpath/namespace-vs-predicate.xhtml: Added.

WebCore:

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12733
XPath namespace is attached to a wrong step

  • xml/XPathGrammar.y: NAMETEST is different from other NodeTests in that its resulting type is an expanded name, rather than a string. It is not really possible to store the namespace inside Parser, because it gets used in wrong steps then.
  • xml/XPathParser.cpp: (WebCore::XPath::Parser::expandQName):
  • xml/XPathParser.h: Moved code that expands a QName from XPathGrammar.y. Removed m_currentNamespaceURI.
  • xml/XPathStep.cpp: (WebCore::XPath::Step::Step):
  • xml/XPathStep.h: Added a constructor that takes a namespace.
11:03 AM Changeset in webkit [19683] by adele
  • 3 edits
    3 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/loader/resources/simultaneous-reloads-assert-frame.html: Added.
  • fast/loader/simultaneous-reloads-assert-expected.txt: Added.
  • fast/loader/simultaneous-reloads-assert.html: Added.

WebCore:

Reviewed by Maciej.

Test: fast/loader/simultaneous-reloads-assert.html

  • loader/Cache.cpp: (WebCore::Cache::remove): Replaced the assertion with a check whether the resource is in the cache. The resource could have been removed from the cache as a result of a reload occurring simultaneously in a different document.
10:58 AM Changeset in webkit [19682] by adele
  • 6 edits
    2 adds in trunk/WebCore

Reviewed by Adam.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12711
Prettier and more distinct cursors

  • Resources/crossHairCursor.png: Added.
  • Resources/northEastSouthWestResizeCursor.png:
  • Resources/northWestSouthEastResizeCursor.png:
  • Resources/notAllowedCursor.png: Added.
  • page/EventHandler.cpp: (WebCore::selectCursor):
  • platform/Cursor.h:
  • platform/mac/CursorMac.mm: (WebCore::crossCursor): (WebCore::notAllowedCursor):
10:35 AM Changeset in webkit [19681] by adele
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/events/shadow-boundary-crossing-expected.txt: Added.
  • fast/events/shadow-boundary-crossing.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/events/shadow-boundary-crossing.html

  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchGenericEvent): Changed to use the new eventParentNode() function for constructing the chain of ancestors for capture and bubbling.
  • dom/Node.h: (WebCore::Node::eventParentNode): Added. Returns the node's parent for the purpose of of event capture and bubbling. The base class implementation is to return the parent node.
  • ksvg2/svg/SVGElement.h: (WebCore::SVGElement::eventParentNode): Added. Since in SVG events bubble to and can be captured across the shadow DOM boundary, returns the shadow parent for shadow nodes.
1:58 AM Changeset in webkit [22956] by hyatt
  • 4 edits in branches/WindowsMerge/WebCore

Fix how resizers invalidate so that there aren't glitches in the lower right corner of the window as you switch pages.

1:50 AM Changeset in webkit [19680] by hyatt
  • 2 edits in trunk/WebCore

Improve textarea resizer painting.

1:07 AM Changeset in webkit [19679] by kjk
  • 7 edits in trunk

JavaScriptCore:

Reviewed by Adam Roben.

Fix crashes on ARM due to different struct packing. Based on a patch
by Mike Emmel.

  • kjs/ustring.cpp: compile-time assert to make sure sizeof(UChar) == 2
  • kjs/ustring.h: pack UChar struct to ensure that sizeof(UChar) == 2
  • wtf/Assertions.h: add COMPILE_ASSERT macro for compile-time assertions

WebCore:

Reviewed by Adam Roben.

Fix crashes on ARM due to different struct packing. Based on a patch
from Mike Emmel.

  • platform/DeprecatedString.cpp: compile-time assert to make sure sizeof(DeprecatedChar) == 2
  • platform/DeprecatedString.h: pack DeprecatedChar struct to ensure that sizeof(DeprecatedChar) == 2. Move _internalBuffer in DeprecatedStringData to the end, to avoid crashes on ARM due to different struct packing.
12:27 AM Changeset in webkit [19678] by adele
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Mitz.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11534
<rdar://problem/4946947> REGRESSION: Readonly text fields don't scroll when selecting content

  • fast/forms/input-readonly-autoscroll-expected.checksum: Added.
  • fast/forms/input-readonly-autoscroll-expected.png: Added.
  • fast/forms/input-readonly-autoscroll-expected.txt: Added.
  • fast/forms/input-readonly-autoscroll.html: Added.

WebCore:

Reviewed by Mitz.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=11534
<rdar://problem/4946947> REGRESSION: Readonly text fields don't scroll when selecting content

Test: fast/forms/input-readonly-autoscroll.html

Implemented autoscroll methods for RenderTextControl, so this works on non-editable text controls.

  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::autoscroll):
  • rendering/RenderTextControl.h: (WebCore::RenderTextControl::shouldAutoscroll):
12:21 AM Changeset in webkit [22955] by adele
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Hyatt.

Fix for <rdar://problem/5006194> Caret is not revealed when a newline is entered into a textarea

  • WebView.cpp: (WebView::handleEditingKeyboardEvent): Use shared code in Editor class to insertParagraphSeparator (or insertLineBreak for plain text). This will also reveal the selection properly.
12:14 AM Changeset in webkit [19677] by kjk
  • 7 edits in trunk/WebCore

Reviewed by Adam Roben.

Curl networking improvements inspired by Mike Emmel's patches in
​http://bugs.webkit.org/show_bug.cgi?id=11332.
Fix FrameLoaderClientGdk due to changed FrameLoaderClient API.

  • loader/gdk/FrameLoaderClientGdk.cpp: Massage for changed API. (WebCore::FrameLoaderClientGdk::saveViewStateToItem): (WebCore::FrameLoaderClientGdk::restoreViewState): (WebCore::FrameLoaderClientGdk::generatedMIMETypeForURLScheme): (WebCore::FrameLoaderClientGdk::willUseArchive):
  • loader/gdk/FrameLoaderClientGdk.h: Ditto.
  • platform/network/ResourceHandleInternal.h: Remember url and custom headers for the request lifetime and free them at the end. (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/gdk/ResourceHandleCurl.cpp: Ditto. (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
  • platform/network/gdk/ResourceHandleManager.cpp: url improvements:
  • remove m_useSimple code-path since it wasn't used anywhere
  • don't use hashmap for keeping track of outstanding jobs - curl does it anyway
  • set custom headers from request
  • enable gzip and deflate through Accept-Encoding
  • setup curl to share cookies and DNS cache between requests
  • enable persisting of cookies in a file (if client provides file name for cookies via ResourceHandleManager::setCookieJarFileName()) (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::ResourceHandleManager::setCookieJarFileName): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::removeFromCurl): (WebCore::ResourceHandleManager::setupPUT): (WebCore::ResourceHandleManager::setupPOST): (WebCore::ResourceHandleManager::add): (WebCore::ResourceHandleManager::cancel):
  • platform/network/gdk/ResourceHandleManager.h:
12:09 AM Changeset in webkit [19676] by kjk
  • 3 edits in trunk/WebCore

Reviewed by Adam Roben.

Gdk fixes.

  • page/gdk/EventHandlerGdk.cpp: Comment out chatty message. (WebCore::EventHandler::handleDrag):
  • platform/gdk/EditorClientGdk.cpp: Enable entering text into text field. (WebCore::EditorClientGdk::shouldInsertText):

Feb 16, 2007:

10:33 PM Changeset in webkit [19675] by kjk
  • 4 edits
    1 add in trunk/WebCore

Reviewed by Adam Roben.

Move Path implementation from TemporaryLinkStubs.cpp to
its own file.
Implement setLineCap, setLineJoin and setMiterLimit for
cairo's GraphicsContext.

  • WebCoreSources.bkl:
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setPlatformFillColor): (WebCore::GraphicsContext::setPlatformStrokeColor): (WebCore::GraphicsContext::setLineCap): (WebCore::GraphicsContext::setLineJoin): (WebCore::GraphicsContext::setMiterLimit):
  • platform/graphics/cairo/PathCairo.cpp: Added. (WebCore::Path::Path): (WebCore::Path::~Path): (WebCore::Path::contains): (WebCore::Path::translate): (WebCore::Path::boundingRect): (WebCore::Path::operator=): (WebCore::Path::clear): (WebCore::Path::moveTo): (WebCore::Path::addLineTo): (WebCore::Path::addQuadCurveTo): (WebCore::Path::addBezierCurveTo): (WebCore::Path::addArcTo): (WebCore::Path::closeSubpath): (WebCore::Path::addArc): (WebCore::Path::addRect): (WebCore::Path::addEllipse): (WebCore::Path::transform): (WebCore::Path::apply):
9:00 PM Changeset in webkit [19674] by staikos
  • 2 edits in trunk/JavaScriptCore

Fix uninitialized variable

8:39 PM Changeset in webkit [19673] by adachan
  • 2 edits in trunk/WebCore

2007-02-16 Ada Chan <​adachan@apple.com>

Reviewed by Adam and Maciej.

Use a RefPtr to store the old hover node.

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateHoverActiveState):


5:15 PM Changeset in webkit [19672] by darin
  • 4 edits in trunk/WebCore

Reviewed by Adele.

  • fix <rdar://problem/4990864> ASSERT in FormDelegate.m while dragging text between frames

This symptom is specific to Safari, so no layout test.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::doApply): Only call textWillBeDeletedInTextField if the text field is focused.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::aboutToUnload): Only call textFieldDidEndEditing if the text field is focused. (WebCore::HTMLInputElement::dispatchBlurEvent): Remove unneeded type cast. (WebCore::HTMLInputElement::defaultEventHandler): Only call doTextFieldCommandFromEvent if the text field is focused.
  • rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::subtreeHasChanged): Only call textDidChangeInTextArea, textFieldDidBeginEditing, and textDidChangeInTextField if the element is focused.
5:04 PM Changeset in webkit [19671] by hyatt
  • 2 edits in trunk/WebCore/platform

API tweaks to widget and scrollview.

5:04 PM Changeset in webkit [22954] by hyatt
  • 4 edits in branches/WindowsMerge/WebCore

Fix RSS scrollbar.

4:31 PM Changeset in webkit [19670] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher

  • fixed <rdar://problem/4811446> "Check Grammar" checkbox in Spelling+Grammar window doesn't live update with menu change in WebKit
  • WebView/WebView.mm: (-[WebView setGrammarCheckingEnabled:]): Use sekrit AppKit knowledge to tell NSSpellChecker about the change, since there's no API for this yet. Also restructured a little to avoid extra work when the value hasn't changed.
3:59 PM WikiStart edited by Adam Roben
Added login link (diff)
3:58 PM WikiStart edited by Adam Roben
Added registration link (diff)
3:48 PM Changeset in webkit [22953] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Rubberstamped by Anders.

3:21 PM Changeset in webkit [19669] by brmorris
  • 3 edits in S60/trunk/WebKit

wei, reviewed by zalan. reverted and re-merged by mbradley

DESC: Reverts r19963 and re-applies with and updated patch. PNIO-6YFCUT conversion problem w/ google search
​http://bugs.webkit.org/show_bug.cgi?id=12792

3:05 PM Changeset in webkit [19668] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

sareen, Reviewed by yongjun

DESC: Browser crash when exited upon loading JKRL-6Y9HXC
​http://bugs.webkit.org/show_bug.cgi?id=12772

2:29 PM Changeset in webkit [19667] by andersca
  • 4 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/4943985>
REGRESSION: Dragging standalone images to Finder fails to download the image file


Set the data and response on the image resource. Also, since this is platform-independent we don't need to do it in
ImageDocumentMac.mm


  • loader/ImageDocument.cpp: (WebCore::ImageTokenizer::finish):
  • loader/mac/ImageDocumentMac.h:
  • loader/mac/ImageDocumentMac.mm: (WebCore::finishImageLoad):
2:02 PM Changeset in webkit [22952] by hyatt
  • 2 edits in branches/WindowsMerge/WebCore

ScrollView fixes.

1:56 PM Changeset in webkit [19666] by darin
  • 3 edits in trunk/JavaScriptGlue

Reviewed by Anders.

  • fix <rdar://problem/5000216> JavaScriptGlue framework started turning all CFNumbers into signed 32bit values

Circumstantial evidence seems to indicate that JavaScriptGlue was depending on a bug
in CFNumber where CFNumberIsFloatType was returning true for 64-bit integer values.

  • JSUtils.cpp: (JSObjectKJSValue): Removed the call to CFNumberIsFloatType in the conversion of numeric values, and always use kCFNumberDoubleType, since double is the internal format of numbers in JavaScriptCore. There's no value to having a separate code path for integers. There's also no reason to check the return value from CFNumberGetValue -- if it returns false it still does the best it can to convert to a double, which is what we want.
  • UserObjectImp.cpp: (UserObjectImp::toString): Removed a similar code path that tried to handle integers separate from double. Instead, always use a double. For compatibility, use a format without a decimal point when CFNumberIsFloatType returns false. Also removed a bogus cast to float; the "%f" format string takes a double, not a float, so all the cast did was cut down on precision.
1:54 PM Changeset in webkit [19665] by harrison
  • 2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5004746> Need mechanism to protect against WebKit calls from secondary threads (DOM APIs)

  • platform/mac/LoggingMac.mm: (WebCore::_WebCoreThreadViolationCheck): Change the default to log the violations.
12:52 PM Changeset in webkit [19664] by zbujtas
  • 3 edits in S60/branches/3.1m/WebKit

w3liu, reviewed by zalan

DESC: PNIO-6YFCUT: Strange conversion problem (in get " changed to %2522 instead of %22) with for example google search.
​http://bugs.webkit.org/show_bug.cgi?id=12792

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::LoadUrlL):
  • ResourceLoader/src/UrlRequestInfo.cpp: (CUrlRequestInfo::SetUrlL):
12:13 PM Changeset in webkit [19663] by brmorris
  • 5 edits in S60/trunk

w3liu, reviewed by zalan

DESC: PNIO-6YFCUT: Strange conversion problem (in get " changed to %2522 instead of %22) with for example google search.
​http://bugs.webkit.org/show_bug.cgi?id=12792

12:07 PM Changeset in webkit [22951] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/4993040>
Crash in plugin code watching yahoo news video


Zero out the plugin function struct.


  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::load):
11:41 AM Changeset in webkit [22950] by andersca
  • 2 edits in branches/WindowsMerge/WebKitWin

Build fixes.


  • WebDownload.cpp: (WebDownload::init): (WebDownload::initWithRequest):
11:40 AM Changeset in webkit [19662] by adele
  • 10 edits in trunk/WebCore

Reviewed by Mitz.

Fixed: ​http://bugs.webkit.org/show_bug.cgi?id=12768
<rdar://problem/4995250> REGRESSION: Crash occurs at WebCore::RenderLayer::scrollToOffset() when leaving page that has focus in field

No test case added. This crash doesn't occur in DumpRenderTree because the B/F cache is turned off.

  • dom/Node.cpp: (WebCore::Node::willRemove): Check that the document is not in the page cache before
  • dom/Element.cpp: (WebCore::Element::updateFocusAppearance): Added restorePreviousSelection argument, with appropriate default values.
  • dom/Element.h: ditto.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::updateFocusAppearance): ditto.
  • html/HTMLInputElement.h: ditto.
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::updateFocusAppearance): ditto.
  • html/HTMLTextAreaElement.h: ditto.
  • page/PageState.cpp: (WebCore::PageState::restore): Call updateFocusAppearance on the focused node for this page. Pass true for the restorePreviousSelection argument.
  • rendering/RenderLayer.cpp: Added ASSERTS and nil checks on the RenderView. It shouldn't be null, but if it is, we'll fail silently on release builds. (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::scrollToOffset): (WebCore::RenderLayer::windowClipRect): (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::intersectsDamageRect): (WebCore::RenderLayer::absoluteBoundingBox):
11:16 AM Changeset in webkit [19661] by andersca
  • 2 edits in trunk/JavaScriptCore

Reviewed by Mitz.

​http://bugs.webkit.org/show_bug.cgi?id=12788
REGRESSION: Going back one page in history has a noticeable delay


Um...if all elements in two vectors are equal, then I guess we could say that
the two vectors are equal too.


  • wtf/Vector.h: (WTF::):
11:03 AM Changeset in webkit [22949] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Fix build.

Use adoptCF instead of adopt.

  • platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::ResourceHandle::start):
  • platform/network/cf/ResourceRequestCFNet.cpp: (WebCore::ResourceRequest::doUpdatePlatformRequest):
11:00 AM Changeset in webkit [19660] by andersca
  • 6 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/4993055> auto_refcount_underflow_error: WebCore::FrameLoader::continueAfterNavigationPolicy () over-releases under GC

Add ::adoptNS and ::adoptCF methods to RetainPtr to indicate what type of reference to adopt.


  • platform/cf/RetainPtr.h: (WebCore::): (WebCore::adoptNSReference): (WebCore::RetainPtr::RetainPtr): (WebCore::::adoptCF): (WebCore::::adoptNS):
  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::FileChooser):
  • platform/network/mac/ResourceErrorMac.mm: (WebCore::ResourceError::operator NSError*):
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest):
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::nsURLResponse):
10:58 AM WebKit Team edited by sullivan@apple.com
(diff)
8:56 AM Known incompatibilities between open-source WebKit and Safari edited by ddkilzer@webkit.org
(diff)
8:56 AM Known incompatibilities between open-source WebKit and Safari edited by ddkilzer@webkit.org
(diff)
8:52 AM Known incompatibilities between open-source WebKit and Safari edited by ddkilzer@webkit.org
(diff)
8:31 AM Changeset in webkit [19659] by brmorris
  • 2 edits in S60/branches/3.1m/WebKit

hongzhao, Reviewed by Yongjun.

DESC: Merge of 19656 to 3.1m branch (Browser Security -Redirection of form submission to another site has a wrong softkey on conformation query. ISHG-6Q2ST8)
Fix: Change the confirmation query softkey buttons to Yes|No
​http://bugs.webkit.org/show_bug.cgi?id=12742

8:27 AM Changeset in webkit [19658] by brmorris
  • 2 edits in S60/trunk/WebKit

sareen, Reviewed by <​yongjun.zhang@nokia.com>.

DESC: Browser crash when exited upon loading. JKRL-6Y9HXC
​http://bugs.webkit.org/show_bug.cgi?id=12772

8:24 AM Changeset in webkit [19657] by brmorris
  • 3 edits in S60/trunk/WebKit

raalexan, reviewed by Yongjun

DESC: 3.2:webkit "page not found" problem, which is before TelService be launched (TLUU-6YDPRT)
​http://bugs.webkit.org/show_bug.cgi?id=12771

8:22 AM Changeset in webkit [19656] by brmorris
  • 2 edits in S60/trunk/WebKit

hongzhao, reviewed by Yongjun

DESC: [S60] Browser Security -Redirection of form submission to another site has a wrong softkey on conformation query.ISHG-6Q2ST8
Fix: Change the confirmation query softkey buttons to Yes|No
​http://bugs.webkit.org/show_bug.cgi?id=12742

8:20 AM Changeset in webkit [19655] by brmorris
  • 2 edits in S60/trunk/WebKit

sareen Reviewed by <​yongjun.zhang@nokia.com>.

DESC: Selection list not shown correctly in www.elisa.fi [ TSW ID: HMNN-6XQJMX]
​http://bugs.webkit.org/show_bug.cgi?id=12719

8:18 AM Changeset in webkit [19654] by brmorris
  • 3 edits in S60/trunk/WebKit

raalexan, Reviewed by Yongjun

DESC: When application is launched via hyperlink, the cursor stays as wait cursor (TSW EAJA-6VDH84)
​http://bugs.webkit.org/show_bug.cgi?id=12715

3:35 AM Changeset in webkit [22948] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

WebCoreWin:

Reviewed by Oliver.

Implemented square button look.

Note: See TracTimeline for information about the timeline view.