Timeline



Apr 13, 2007:

6:26 PM Changeset in webkit [20889] by ddkilzer
  • 12 edits
    4 moves
    8 adds in trunk

LayoutTests:

Patch and review by hyatt. Testing and landing by ddkilzer.

<rdar://problem/5078866>
tables don't inherit text-align (in strict mode; they're not supposed to in quirks mode)

Test tables/mozilla_expected_failures/bugs/bug11384s.html progressed after this fix, so
it was moved to tables/mozilla/bugs/bug11384s.html.

  • fast/css/table-text-align-quirk-expected.checksum: Added.
  • fast/css/table-text-align-quirk-expected.png: Added.
  • fast/css/table-text-align-quirk-expected.txt: Added.
  • fast/css/table-text-align-quirk.html: Added.
  • fast/css/table-text-align-strict-expected.checksum: Added.
  • fast/css/table-text-align-strict-expected.png: Added.
  • fast/css/table-text-align-strict-expected.txt: Added.
  • fast/css/table-text-align-strict.html: Added.
  • fast/table/border-collapsing/rtl-border-collapsing.html: Replaced "text-align: -khtml-center" style with "text-align: center" style.
  • tables/mozilla/bugs/bug11384s-expected.checksum: Added.
  • tables/mozilla/bugs/bug11384s-expected.png: Added.
  • tables/mozilla/bugs/bug11384s-expected.txt: Added.
  • tables/mozilla/bugs/bug11384s.html: Added.
  • tables/mozilla_expected_failures/bugs/bug11384s-expected.checksum: Removed.
  • tables/mozilla_expected_failures/bugs/bug11384s-expected.png: Removed.
  • tables/mozilla_expected_failures/bugs/bug11384s-expected.txt: Removed.
  • tables/mozilla_expected_failures/bugs/bug11384s.html: Removed.

WebCore:

Patch and review by hyatt. Testing and landing by ddkilzer.

<rdar://problem/5078866>
tables don't inherit text-align (in strict mode; they're not supposed to in quirks mode)

Test: fast/css/table-text-align-quirk.html

fast/css/table-text-align-strict.html

Previous commit (r20731) removed the wrong property from WebCore/css/html4.css. However,
when the correct property was removed, it caused tables to inherit alignment properties
from tags like <center> and <div align="center">. This is fixed in
WebCore::CSSStyleSelector::adjustRenderStyle() by special-casing tables to reset the
text-align property.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::valueForTextAlign): Renamed KHTML_CENTER, KHTML_LEFT and KHTML_RIGHT to WEBKIT_CENTER, WEBKIT_LEFT and WEBKIT_RIGHT.
  • css/cssparser.cpp: (WebCore::CSSParser::parseValue): Ditto.
  • css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle): Tables should not support -webkit-center, -webkit-left or -webkit-right values for text-align, so reset them back to auto.
  • css/html4.css: Removed "text-align: -webkit-auto;" property from tables selector. It was previously added to css/quirks.css in r20731.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::determineHorizontalPosition): Renamed KHTML_* to WEBKIT_*.
  • rendering/RenderBox.cpp: (WebCore::RenderBox::calcHorizontalMargins): Ditto.
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::caretRect): Ditto.
  • rendering/RenderStyle.h: Ditto. (WebCore::):
  • rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): Ditto.
5:57 PM Changeset in webkit [20888] by oliver
  • 2 edits in trunk/WebKit

2007-04-13 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

Due to rdar://problem/5133910 -- WebArchives should not be constructed
using resource from the cache -- We may try to create a potentially
incorrect WebArchive when dragging an image multiple times.

This patch retains the assertion for invalid behaviour, but adds a
branch to make sure we don't try to do anything with the WebArchive
in release builds.

  • Misc/WebNSPasteboardExtras.mm: (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]):
5:47 PM Changeset in webkit [23281] by aroben
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Tim.

Sync our config.h with the OpenSource version so we can merge ours in
later.

  • config.h: Added #defines from the OpenSource version, moved Windows-specific defines inside #if PLATFORM(WIN[_OS]), and got rid of assert.h
  • platform/win/CursorWin.cpp: (WebCore::Cursor::Cursor): Use ASSERT instead of assert.
5:15 PM Changeset in webkit [23280] by kmccullo
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Continued filtering.
3:45 PM Changeset in webkit [20887] by bdash
  • 1 copy in tags/Safari-4522.5.5/WebKit

New tag (part 2).

3:45 PM Changeset in webkit [20886] by bdash
  • 1 add in tags/Safari-4522.5.5

New tag (part 1).

3:44 PM Changeset in webkit [20885] by bdash
  • 1 edit in branches/Safari-522/WebKit/Configurations/Version.xcconfig

Versioning.

3:42 PM Changeset in webkit [20884] by bdash
  • 2 edits in branches/Safari-522/WebKit

Merge r20869.

2:56 PM Changeset in webkit [23279] by beidson
  • 1 edit in branches/WindowsMerge/LayoutTests/win/Skipped

Updated to reflect new location of the history test which is now http

2:47 PM Changeset in webkit [20883] by beidson
  • 1 edit
    4 adds
    1 delete in trunk/LayoutTests

Reviewed by a sanity check

My layout test *has* to be http, since dumping history in DRT with hard coded file paths
will never match up to expected results across machines.

Lame

  • history/new-window-redirect-history-expected.txt: Removed.
  • history/new-window-redirect-history.html: Removed.
  • history/resources/redirect-1.html: Removed.
  • history/resources/redirect-2.html: Removed.
  • http/tests/navigation/new-window-redirect-history-expected.txt: Added.
  • http/tests/navigation/new-window-redirect-history.html: Added.
  • http/tests/navigation/resources/redirect-1.html: Added.
  • http/tests/navigation/resources/redirect-2.html: Added.
2:45 PM Changeset in webkit [23278] by kmccullo
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Re-enabled the tests that are actual failures.
2:33 PM Changeset in webkit [20882] by thatcher
  • 1 copy in tags/Safari-4522.5.4/WebKit

New tag (part 2).

2:32 PM Changeset in webkit [20881] by thatcher
  • 1 add in tags/Safari-4522.5.4

New tag (part 1).

2:27 PM Changeset in webkit [20880] by thatcher
  • 4 edits in branches/Safari-522

Versioning.

1:48 PM Changeset in webkit [23277] by beidson
  • 1 edit in branches/WindowsMerge/LayoutTests/win/Skipped

Added history/new-window-redirect-history.html to the skipped file pending addition of multiple windows to DRT

1:39 PM Changeset in webkit [23276] by aroben
  • 2 edits
    1 delete in branches/WindowsMerge/WebCore

Rubberstamped by Tim.

Removed the loader/win directory since it only contains empty files.

  • WebCore.vcproj/WebCore.vcproj: Removed empty files.
  • loader/win/FrameLoaderWin.cpp: Removed.
  • loader/win/ResourceLoaderWin.cpp: Removed.
1:34 PM Changeset in webkit [20879] by aroben
  • 2 edits in trunk/WebKitTools

Rubberstamped by Anders.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: #include stdio.h so that snprintf is defined.
1:31 PM Changeset in webkit [23275] by andersca
  • 2 edits in branches/WindowsMerge/WebKitTools

Fix the release build too!

  • DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj:
1:28 PM Changeset in webkit [20878] by beidson
  • 4 edits
    6 adds in trunk

LayoutTests:

Reviewed by Geoose

<rdar://problem/4664154> and ​http://bugs.webkit.org/show_bug.cgi?id=3546

Layout test that covers opening an empty new window, then starting to navigate around in it

  • history/new-window-redirect-history-expected.txt: Added.
  • history/new-window-redirect-history.html: Added.
  • history/resources/redirect-1.html: Added.
  • history/resources/redirect-2.html: Added.

WebCore:

Reviewed by Black Sheep

<rdar://problem/4664154> and ​http://bugs.webkit.org/show_bug.cgi?id=3546

When you click on a link that opens in a new window from within gmail, they first create a new window
with an empty URL, then immediately document.write() into the window to schedule a redirect.

Since the initial page doesn't have a URL associated with it, a history item never gets created. The
reasonable solution? To actually create the history item after the redirect (in updateHistoryForInternalLoad)

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addHistoryForCurrentLocation): Updates global and B/F history with a new history item (WebCore::FrameLoader::updateHistoryForStandardLoad): Call addHistoryForCurrentLocation (WebCore::FrameLoader::updateHistoryForInternalLoad): Call addHistoryForCurrentLocation if there is not already a current history item
  • loader/FrameLoader.h:
1:09 PM Changeset in webkit [20877] by beidson
  • 2 edits in trunk/WebKitTools

Reviewed by Anders

Add the ability to dump the back/forward history of all windows open at the end of a test

  • DumpRenderTree/DumpRenderTree.m: (dumpBackForwardListForWebView): Dump B/F list for the given WebView (dump): Call dumpBackForwardListForWebView for each WebView open after the test
12:54 PM Changeset in webkit [20876] by andersca
  • 4 edits in trunk

LayoutTests:

Reviewed by Brady.

  • plugins/open-and-close-window-with-plugin.html: Manage open windows manually for this test.

WebKitTools:

Reviewed by Brady.

By default, close any windows that have been opened during a test. This can be overridden by
calling setCloseRemainingWindowsWhenComplete(false).


Change the windows set to an array so we can gurantee the enumeration order.


  • DumpRenderTree/DumpRenderTree.m: (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setCloseRemainingWindowsWhenComplete:]): (runTest): (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): (-[DumpRenderTreeWindow dealloc]):
12:14 PM Changeset in webkit [20875] by thatcher
  • 2 edits in branches/Safari-522/WebKit

Merge fix from r20874.

12:13 PM Changeset in webkit [20874] by thatcher
  • 2 edits in trunk/WebKit

Reviewed by Dave Harrison.

<rdar://problem/5132727> Soho Mail build fails because of renamed SPI

  • WebView/WebUIDelegatePrivate.h: define WebMenuItemTagSearchInGoogle as OldWebMenuItemTagSearchWeb
12:12 PM Changeset in webkit [20873] by ggaren
  • 2 edits in trunk/WebKitTools

Build fix.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: (handleCallback): Explicitly cast the void* returned by malloc.
11:42 AM Changeset in webkit [23274] by kmccullo
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Commented out some that may not be actually failing.
10:54 AM Changeset in webkit [23273] by andersca
  • 2 edits in branches/WindowsMerge/WebKitTools

Fix build.


  • DumpRenderTree/DumpRenderTree.vcproj/TestNetscapePlugin/TestNetscapePlugin.vcproj: #define snprintf to be _snprintf and dd two defines to disable warnings for strdup and _snprintf.
10:02 AM Changeset in webkit [20872] by thatcher
  • 2 edits in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector

Share more code between the TreeOutline and TreeElement classes. Remember the expanded state for elements when the tree is rebuilt with the same represented objects. Toggling ignore whitespace correct repopulates the tree again.

9:59 AM Changeset in webkit [20871] by sfalken
  • 2 edits in branches/Safari-522/WebCore

Merged fix from r20847

9:54 AM BuildingQtOnLinux edited by ed@uping.com
Updating dependencies (diff)
5:59 AM Changeset in webkit [20870] by zbujtas
  • 2 edits in S60/trunk/WebCore

anapatil <​anand.1.patil@nokia.com>

Reviewed by ​zbujtas@gmail.com
DESC: Fix for : Browser - extra content seen when browsing www.kartta.ouka.fi

​http://bugs.webkit.org/show_bug.cgi?id=13308
TSW ID : MRAA-6X4FVQ

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/rendering/render_frames.cpp:
12:56 AM Changeset in webkit [20869] by bdash
  • 2 edits in trunk/WebKit

2007-04-13 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver.

<rdar://problem/5130686> Using WebPreferencesPrivate.h requires modifying framework search path

  • WebView/WebPreferencesPrivate.h: Remove unneeded #ifdef.

Apr 12, 2007:

11:38 PM Changeset in webkit [20868] by oliver
  • 2 edits in trunk/WebCore

2007-04-12 Oliver Hunt <​oliver@apple.com>

Reviewed by Adam.

This fixes <rdar://problem/5060766> -- Frameset with
an empty frame crashes due to null document. Debug
builds hit the frame->document() assertion in
EventHandler::prepareMouseEvent

This null check seems necessary now, having run through
all the logic on the path to this crash it appears that
we can't avoid this null check.

  • page/EventHandler.cpp: (WebCore::EventHandler::updateDragAndDrop):
9:32 PM Changeset in webkit [20867] by ggaren
  • 13 edits
    4 adds in trunk

JavaScriptCore:

Reviewed by Darin Adler.

​http://bugs.webkit.org/show_bug.cgi?id=13029
rdar://problem/4994849
Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.
This doesn't actually change JavaScriptCore, but that's where npapi.h is.

  • bindings/npapi.h: Add headers member to NPStream struct. Also increase NP_VERSION_MINOR to 18. Increasing to >= 17 allows plug-ins to safely detect whether to look for NPStream::headers. Increasing from 17 to 18 reflects presence of NPObject enumeration, which was added in a prior patch, and which has been agreed to constitute version 18 by the plugin-futures list. Also add other missing bits of npapi.h to catch up from 14 to 18. This includes features that are not implemented in WebKit, but those are safely stubbed.

LayoutTests:

Reviewed by Darin Adler.

​http://bugs.webkit.org/show_bug.cgi?id=13029
rdar://problem/4994849
Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.

  • http/tests/plugins/npapi-response-headers-expected.txt: Added.
  • http/tests/plugins/npapi-response-headers.html: Added.
  • http/tests/plugins/resources/load-me-1.txt: Added.
  • http/tests/plugins/resources/load-me-2.txt: Added.

WebKit:

Reviewed by Darin Adler.

​http://bugs.webkit.org/show_bug.cgi?id=13029
rdar://problem/4994849
Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.

  • Plugins/WebBaseNetscapePluginStream.h: declarations.
  • Plugins/WebBaseNetscapePluginStream.mm: main implementation. (-[WebBaseNetscapePluginStream dealloc]): cleanup. (-[WebBaseNetscapePluginStream finalize]): cleanup. (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]): Pass headers along. (-[WebBaseNetscapePluginStream startStreamWithResponse:]): Main work is here. Extract headers from NSHTTPURLResponse object into a byte sequence. See comments here about how it would be nice to have low-level access to the HTTP response. (-[WebBaseNetscapePluginStream _destroyStream]): cleanup.
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]): Conform to new startStream params. Not applicable here, pass nil.

WebKitTools:

Reviewed by Darin Adler.

​http://bugs.webkit.org/show_bug.cgi?id=13029
rdar://problem/4994849
Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.
Changes in WebKitTools are only for the NPAPI test plugin.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: main test logic. (pluginInvoke): support null window argument for NPStream creation. (pluginAllocate): initialization. (pluginDeallocate): cleanup. (handleCallback): add second JS callback arg: header dump. (notifyStream): added; hook from NPP_NewStream to record headers.
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: declarations.
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.c: call new header hook. (NPP_NewStream): call new header hook.
9:15 PM Changeset in webkit [23272] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Added a pre-existing radar reference.
9:05 PM Changeset in webkit [23271] by sfalken
  • 4 edits in branches/WindowsMerge/WebKitWin

2007-04-12 Steve Falkenburg <​sfalken@apple.com>

Reviewed by Geoff, Adam.


Changes required for search history content.

  • Interfaces/IWebFramePrivate.idl:
  • WebFrame.cpp: (WebFrame::isFrameSet): Added (WebFrame::string): Added
  • WebFrame.h:
8:47 PM Changeset in webkit [23270] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Filed some more bugs.
6:10 PM Changeset in webkit [20866] by justing
  • 3 edits
    16 adds in trunk

LayoutTests:

Reviewed by darin


<rdar://problem/5131716>
Clicking just before a ToDo doesn't put the caret before the ToDo


  • editing/selection/5131716-1-expected.checksum: Added.
  • editing/selection/5131716-1-expected.png: Added.
  • editing/selection/5131716-1-expected.txt: Added.
  • editing/selection/5131716-1.html: Added.
  • editing/selection/5131716-2-expected.checksum: Added.
  • editing/selection/5131716-2-expected.png: Added.
  • editing/selection/5131716-2-expected.txt: Added.
  • editing/selection/5131716-2.html: Added.
  • editing/selection/5131716-3-expected.checksum: Added.
  • editing/selection/5131716-3-expected.png: Added.
  • editing/selection/5131716-3-expected.txt: Added.
  • editing/selection/5131716-3.html: Added.
  • editing/selection/5131716-4-expected.checksum: Added.
  • editing/selection/5131716-4-expected.png: Added.
  • editing/selection/5131716-4-expected.txt: Added.
  • editing/selection/5131716-4.html: Added.

WebCore:

Reviewed by darin


<rdar://problem/5131716>
Clicking just before a ToDo doesn't put the caret before the ToDo


  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::positionForCoordinates): Consider clicks inside the blocks padding, instead of incorrectly sending them to the position before the block.
5:55 PM Changeset in webkit [23269] by aroben
  • 4 edits
    1 copy
    1 delete in branches/WindowsMerge

WebCoreWin:

Rubberstamped by Steve.

Removed unused file.

  • WebCore.vcproj/WebCore.sln: Removed.

WebKitWin:

Rubberstamped by Steve.

Copied WebKit.sln to WebKit.submit.sln, and added missing projects to
WebKit.sln so that opensource contributors can use it to build a
working WebKit.

  • WebKit.vcproj/WebKit.make: Changed to use WebKit.submit.sln.
  • WebKit.vcproj/WebKit.sln: Added JavaScriptCore, WebCore, DumpRenderTree projects.
  • WebKit.vcproj/WebKit.submit.sln: Added.
5:40 PM Changeset in webkit [23268] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Didn't mean to commit this.

  • WebCore.vcproj/WebCore.vcproj:
5:28 PM Changeset in webkit [23267] by aroben
  • 8 edits
    2 copies in branches/WindowsMerge
1:33 PM Changeset in webkit [23266] by kmccullo
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Continued to organize the list and file bugs for failures that do not have radars.
12:14 PM Changeset in webkit [20865] by brmorris
  • 2 edits in S60/trunk/WebKit

raalexan, reviewed by Yongjun

DESC: removed const from CWmlDispatcher::HeadersL
​http://bugs.webkit.org/show_bug.cgi?id=13206

12:01 PM Changeset in webkit [23265] by kmccullo
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Organized the Skipped. Failed tests are either filed under existing bugs, filed under new bugs, or are grouped by failure but do not have a bug yet.
10:27 AM Changeset in webkit [20864] by brmorris
  • 2 edits in S60/trunk/WebKit

borges, reviewed by spadma

DESC: related to S60 task 15118 for ccb - Fix for Symbian wk14 update related to ContentAccess class
​http://bugs.webkit.org/show_bug.cgi?id=13331

9:56 AM Changeset in webkit [20863] by beidson
  • 3 edits in trunk/WebKit

Build fix for case sensitive file systems

  • Misc/WebNSPasteboardExtras.mm:
  • WebCoreSupport/WebPasteboardHelper.mm:
9:19 AM Changeset in webkit [23264] by sullivan
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders

  • Interfaces/IWebUIDelegate.idl: added new PDF-related context menu items to enum to keep it in sync with WebCore
9:12 AM Changeset in webkit [20862] by sullivan
  • 8 edits
    2 adds in trunk

WebCore:

Reviewed by Anders

  • WebCore part of fix for: <rdar://problem/5128697> REGRESSION: At least one PDF context menu item isn't appearing on Leopard
  • platform/ContextMenuItem.h: (WebCore::): add two PDF-related context menu items to enum to keep it in sync with WebKit
  • platform/ContextMenu.cpp: (WebCore::ContextMenu::checkOrEnableIfNeeded): add the new context menu items to the do-nothing case of a big switch statement

WebKit:

Reviewed by Anders

  • WebKit part of fix for: <rdar://problem/5128697> REGRESSION: At least one PDF context menu item isn't appearing on Leopard
  • Misc/WebNSArrayExtras.h: Added.
  • Misc/WebNSArrayExtras.m: Added. (-[NSMutableArray _webkit_removeUselessMenuItemSeparators]): New file, includes this method to strip leading, trailing, and duplicate separators from arrays of NSMenuItems (copied from Safari)
  • WebView/WebUIDelegatePrivate.h: new MenuItemTag enum values for new PDFKit context menu items
  • WebKit.xcodeproj/project.pbxproj: updated for new files
  • WebView/WebPDFView.mm: (-[WebPDFView _anyPDFTagsFoundInMenu:]): check for new PDFKit context menu items (-[WebPDFView _menuItemsFromPDFKitForEvent:]): associate new PDFKit context menu item selectors with the new tags; skip certain selectors that correspond to menu items that WebKit already includes; remove useless menu item separators when we're done, since we might have removed arbitrarily-placed menu items
8:40 AM Changeset in webkit [20861] by thatcher
  • 2 edits in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector

Make removeChildren not a recursive removeChildren. Also resue root tree elements when building the root, to keep items that are already visible and prevent rebuilding the tree as much.

8:28 AM Changeset in webkit [20860] by hausmann
  • 2 edits in trunk/WebCore

Fixed drawing of justified text in the Qt port.

7:53 AM Changeset in webkit [20859] by yongjzha
  • 3 edits in S60/trunk/WebKit

raalexan, reviewed by Yongjun

DESC: Connection shown as Normal in secure page
​http://bugs.webkit.org/show_bug.cgi?id=13206
TSW ID: HMNN-6ZGH6J

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::CertInfo):
  • BrowserControl/src/WmlDispatcher.cpp: (CWmlDispatcher::HeadersL):

Apr 11, 2007:

11:42 PM Changeset in webkit [20858] by oliver
  • 13 edits in trunk

2007-04-11 Oliver Hunt <​oliver@apple.com>

Reviewed by Maciej.

WebCore:

Adding RetainPtr to the many global obj-c pointers we use in
C/C++ methods. This is necessary to prevent GC from collecting
globals we want to keep around.

We use RetainPtr in obj-c++ and c++ files, and CFRetain/Release in pure
obj-c.

Also made the Pasteboard::m_pasteboard a RetainPtr although it
shouldn't be necessary as the only NSPasteboard instances that
should ever be inserted are the system clipboard and dragging
pasteboard. Neither of which should ever be collected.

  • page/mac/WebCoreFrameBridge.mm: (_getPreSmartSet): (_getPostSmartSet):
  • platform/Pasteboard.h:
  • platform/graphics/mac/ColorMac.mm: (WebCore::nsColor):
  • platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
  • platform/mac/FontDataMac.mm: (WebCore::webFallbackFontFamily):
  • platform/mac/PasteboardMac.mm: (WebCore::writableTypesForURL): (WebCore::writableTypesForImage): (WebCore::Pasteboard::clear): (WebCore::Pasteboard::writeSelection): (WebCore::Pasteboard::writeURL): (WebCore::Pasteboard::writeFileWrapperAsRTFDAttachment): (WebCore::Pasteboard::writeImage): (WebCore::Pasteboard::canSmartReplace): (WebCore::Pasteboard::plainText): (WebCore::Pasteboard::documentFragment):

WebKit:

Adding RetainPtr to the many global obj-c pointers we use in
C/C++ methods. This is necessary to prevent GC from collecting
globals we want to keep around.

We use RetainPtr in obj-c++ and c++ files, and CFRetain/Release in pure
obj-c.

This fixes <rdar://problem/5058731> -- Crash in
WebCore::DragData::containsCompatibleContent due to early release
of types array

9:45 PM Changeset in webkit [20857] by bdash
  • 5 edits
    4 adds in trunk

2007-04-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

Test: fast/forms/menulist-option-wrap.html

  • css/html4.css: Added white-space declaration for select[size="0"] and select[size="1"]. Added border-radius declaration for select.

2007-04-11 Mitz Pettel <​mitz@webkit.org>

Reviewed by Dave Hyatt.

  • fast/forms/menulist-option-wrap-expected.checksum: Added.
  • fast/forms/menulist-option-wrap-expected.png: Added.
  • fast/forms/menulist-option-wrap-expected.txt: Added.
  • fast/forms/menulist-option-wrap.html: Added.
  • fast/forms/select-empty-option-height-expected.checksum:
  • fast/forms/select-empty-option-height-expected.png:
9:28 PM Changeset in webkit [23263] by bdash
  • 3 edits in branches/WindowsMerge/WebKitWin

2007-04-12 Mark Rowe <​mrowe@apple.com>

Not reviewed. Internal counterpart to open-source r20856.

  • WebChromeClient.cpp: (WebChromeClient::createWindow): (WebChromeClient::createModalDialog):
  • WebChromeClient.h:
9:21 PM Changeset in webkit [20856] by bdash
  • 15 edits in trunk

2007-04-11 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Maciej.

Add a Frame pointer to ChromeClient methods:
​http://bugs.webkit.org/show_bug.cgi?id=13127

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow):
  • page/Chrome.cpp: (WebCore::Chrome::createWindow): (WebCore::Chrome::createModalDialog):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/ContextMenuController.cpp: (WebCore::openNewWindow):
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::createWindow): (WebCore::SVGEmptyChromeClient::createModalDialog):

2007-04-11 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Maciej.

Add a Frame pointer to ChromeClient methods:
​http://bugs.webkit.org/show_bug.cgi?id=13127

  • COM/ChromeClientWin.cpp: (ChromeClientWin::createWindow): (ChromeClientWin::createModalDialog):
  • COM/ChromeClientWin.h:
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): (WebChromeClient::createModalDialog):

2007-04-11 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Maciej.

Add a Frame pointer to ChromeClient methods:
​http://bugs.webkit.org/show_bug.cgi?id=13127

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createWindow): (WebCore::ChromeClientQt::createModalDialog):
  • WebCoreSupport/ChromeClientQt.h:
6:38 PM Changeset in webkit [20855] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Ada

<rdar://problem/5080987> - Crash in DocumentLoader::frameLoader() const

This was free nil checking lost during the ObjC -> C++ conversion

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Null check the DocumentLoader
6:25 PM Changeset in webkit [20854] by justing
  • 6 edits
    4 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/5126166>
Deleting selection starting at before ToDo checkbox to end of line, inserts a BR in the subsequent ToDo

  • editing/deleting/5126166-expected.checksum: Added.
  • editing/deleting/5126166-expected.png: Added.
  • editing/deleting/5126166-expected.txt: Added.
  • editing/deleting/5126166.html: Added.

WebCore:

Reviewed by harrison

<rdar://problem/5126166>
Deleting selection starting at before ToDo checkbox to end of line, inserts a BR in the subsequent ToDo


If a selection ends in a table cell, we shouldn't perform
a merge after deleting that selection. We have code in
place to prevent those merges, but it failed here.


It fails because the end of the selection was [tableCell, 0],
(normally not a valid VisiblePosition, but valid here
because the table cell is empty). We prevent the merge
if the node of the position at the end of the selection
has an enclosingTableCell. Even though [tableCell, 0] has
an enclosing table cell, the node tableCell doesn't, so
the check fails.


Fixed this by changing enclosingTableCell to take in
a position, instead of a node. The other enclosing element
getters should be changed in this way as well.

  • editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): Call the new enclosingTableCell.
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMerge): Ditto.
  • editing/htmlediting.cpp: (WebCore::enclosingTableCell): Take in a position instead of a node.
  • editing/htmlediting.h:
5:37 PM Changeset in webkit [23262] by aroben
  • 3 edits
    1 move
    1 add
    1 delete in branches/WindowsMerge

LayoutTestsWin:

Reviewed by Tim.

Moved the Skipped file into win/Skipped in anticipation of the opensource merge.

  • Skipped: Removed.

WebCoreWin:

Reviewed by Tim.

Get rid of FrameViewWin.cpp, since it's empty.

  • WebCore.vcproj/WebCore.vcproj:
  • bridge/win/FrameViewWin.cpp: Removed.
5:33 PM Changeset in webkit [20853] by bdash
  • 1 edit in tags/WebKit-5522.6.1/WebKit/Configurations/Version.xcconfig

Versioning.

5:32 PM Changeset in webkit [20852] by bdash
  • 1 edit in tags/WebKit-5522.6.1/WebKit/Plugins/WebBaseNetscapePluginView.mm

Merge in r20765.

5:30 PM Changeset in webkit [20851] by bdash
  • 1 copy in tags/WebKit-5522.6.1/WebKit

New tag (part 2).

5:29 PM Changeset in webkit [20850] by bdash
  • 1 add in tags/WebKit-5522.6.1

New tag (part 1).

5:11 PM Changeset in webkit [23261] by adachan
  • 2 edits in branches/WindowsMerge/WebKitWin

2007-04-11 Ada Chan <​adachan@apple.com>

Reviewed by Steve.


<rdar://4919560> Implement reopen last window, last session

WebKitWin:

Implemented WebHistoryItem::originalURLString(). Added parameter checks to other methods.

  • WebHistoryItem.cpp: (WebHistoryItem::originalURLString): (WebHistoryItem::URLString): (WebHistoryItem::title): (WebHistoryItem::lastVisitedTimeInterval):
2:30 PM Changeset in webkit [20849] by bdash
  • 3 edits in trunk/WebKitQt

2007-04-12 Mark Rowe <​mrowe@apple.com>

Second part of Qt build fix.

  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::loadedFromCachedPage): (WebCore::FrameLoaderClientQt::setDocumentViewFromCachedPage): (WebCore::FrameLoaderClientQt::saveDocumentViewToCachedPage):
  • WebCoreSupport/FrameLoaderClientQt.h:
1:58 PM Changeset in webkit [20848] by bdash
  • 3 edits
    1 move in trunk/WebCore

2007-04-12 Mark Rowe <​mrowe@apple.com>

Qt build fix.

  • WebCore.pro:
  • editing/qt/EditorQt.cpp: (WebCore::Editor::markBadGrammar):
  • history/qt/CachedPageQt.cpp: Added. (WebCore::CachedPage::close):
  • history/qt/PageCacheQt.cpp: Removed.
11:22 AM Changeset in webkit [20847] by beidson
  • 2 edits in trunk/WebCore

Reviewed by Antti

<rdar://problem/5125648> and ​http://bugs.webkit.org/show_bug.cgi?id=13326

Crash opening a link in a new window from Gmail

Problem here is that the currentHistoryItem in the new window is null. This *shouldn't* be the case,
and is the cause of a very long standing bug -
​http://bugs.webkit.org/show_bug.cgi?id=3546 - Can't go back to first page in new window opened from gmail

For now, adding a null check prevents this crash and restores the original, long standing regression


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::updateHistoryForInternalLoad): NULL check
10:58 AM Changeset in webkit [23260] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Anders.

Update for changes to Pasteboard.

  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):
10:51 AM Changeset in webkit [20846] by aroben
  • 6 edits in trunk/WebCore

Reviewed by Anders.

Made image document copying more cross-platform.

All layout tests pass.

  • editing/Editor.cpp: (WebCore::imageNodeFromImageDocument): Added. (WebCore::Editor::canCopy): Called imageNodeFromImageDocument. (WebCore::Editor::copy): Ditto. (WebCore::Editor::copyImage): Updated for changes to Pasteboard.
  • platform/Pasteboard.h: Made writeImage more general, which allowed getting rid of its second incarnation.
  • platform/gdk/TemporaryLinkStubs.cpp:
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage): Collapsed logic from the two writeImage methods into one. (Pasteboard::writeImage): Updated for Pasteboard changes.
  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeImage): Ditto.
7:31 AM Changeset in webkit [20845] by thatcher
  • 1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

Properly reveal and select the focused node when the tree is updated.

6:54 AM Changeset in webkit [20844] by thatcher
  • 1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

Update the disabled state of the traverse buttons when selection changes.

6:28 AM Changeset in webkit [20843] by thatcher
  • 4 edits in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector

Use the script equality operator in almost all cases. Other various cleanup.

5:59 AM Changeset in webkit [20842] by thatcher
  • 2 edits
    1 add in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector

Move DOM and String prototype additions to utilities.js.

12:50 AM Changeset in webkit [20841] by darin
  • 2 edits in trunk/WebCore
  • css/CSSValueKeywords.in: Fix a comment.
12:28 AM Changeset in webkit [23259] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests
  • Skipped: Consolidated some failures that have the same underlying cause, and removed some tests that were duplicated in this file.
12:16 AM Changeset in webkit [20840] by thatcher
  • 2 edits
    1 add in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector

Factored out the tree outline control into a generic JavaScript class. This fixed a couple of issues with the previous implementation.

Apr 10, 2007:

7:43 PM Changeset in webkit [20839] by justing
  • 5 edits
    14 adds in trunk

LayoutTests:

Reviewed by harrison


<rdar://problem/4932260>
Invalid attributed string for attachment range obtained via AXPreviousWordStartTextMarkerForTextMarker

Forgot to check these in in my previous checkin:

  • editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum: Added.
  • editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added.


Tests for a bug where replaced elements would act
as sentence boundaries:

  • editing/selection/4932260-1-expected.checksum: Added.
  • editing/selection/4932260-1-expected.png: Added.
  • editing/selection/4932260-1-expected.txt: Added.
  • editing/selection/4932260-1.html: Added.


Tests to see that replaced elements do not act as word
boundaries when moving forward through the document:

  • editing/selection/4932260-2-expected.checksum: Added.
  • editing/selection/4932260-2-expected.png: Added.
  • editing/selection/4932260-2-expected.txt: Added.
  • editing/selection/4932260-2.html: Added.


Ditto but tests moving backward:

  • editing/selection/4932260-3-expected.checksum: Added.
  • editing/selection/4932260-3-expected.png: Added.
  • editing/selection/4932260-3-expected.txt: Added.
  • editing/selection/4932260-3.html: Added.


No way to test accessibility APIs atm, and had trouble
making a test for selection creation with double-click
and drag.

WebCore:

Reviewed by harrison


<rdar://problem/4932260>
Invalid attributed string for attachment range obtained via AXPreviousWordStartTextMarkerForTextMarker


By default, text iterators don't emit anything for replaced
elements. Boundary finding code works around this but has
bugs: replaced elements act as sentence boundaries and the
above bug, where previousBoundary moves past the start of a
word if there is a replaced element just before it. This
patch fixes these issues by treating replaced elements as
punctuation for boundary finding.

  • editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): Set m_pastStartNode, the node after (in a reverse pre-order traversal) the last one that should be processed. (WebCore::SimplifiedBackwardsTextIterator::advance): Stop at m_pastStartNode. Iterate over nodes in reverse pre-order (TextIterator traverses in pre-orer). This makes knowing when to emit characters after nodes vs. when to emit characters before nodes easier. Remove the special case for entering a new block, emitting characters after nodes can now be handled generally, in handleNonTextNode(), because of the way we traverse. Set m_handledChildren to false every iteration since we now do traverse in reverse pre-order. (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement): Emit a comma for replaced elements. We only use this kind of iterator for finding boundaries, so we can do this unconditionally. (WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode): Don't use emitNewline, instead specify where the newline should be positioned. A node is handled before its children, so characters emitted here should be positioned after the node, not before it. (WebCore::SimplifiedBackwardsTextIterator::exitNode): Don't use emitNewline, instead specify where the newline should be positioned. (WebCore::CharacterIterator::CharacterIterator): Create a TextIterator that emits content for replaced elements, if requested.
  • editing/TextIterator.h:
  • editing/visible_units.cpp: (WebCore::previousBoundary): Removed replaced element handling code. If the start of the chunk that contained the boundary was in a non-text node, then the boundary is not necessarily in that node. Particularly because it is only the end of the chunk that is guaranteed to be a valid position in those cases. We must iterate backwards by character from the end of the chunk to find the boundary. (WebCore::nextBoundary): Removed replaced element handling code.
6:46 PM Changeset in webkit [23258] by kmccullo
  • 2 edits in branches/WindowsMerge/LayoutTests
  • Skipped: Added last tests to make build bot green.
6:00 PM Changeset in webkit [20838] by sfalken
  • 1 copy in tags/Safari-522.5.6b

New tag.

5:02 PM Changeset in webkit [23257] by beidson
  • 6 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Darin

<rdar://problem/4887095> - PageCache and PageState should be combined

Changed a TemporaryLinkStub and updated the project file

  • WebCore.vcproj/WebCore.vcproj:
  • platform/win/TemporaryLinkStubs.cpp: (CachedPage::close):

WebKitWin:

Reviewed by Darin

<rdar://problem/4887095> - PageCache and PageState should be combined

Basically updated client methods for the new names and signatures

  • WebFrame.cpp: (WebFrame::loadedFromCachedPage): (WebFrame::setDocumentViewFromCachedPage): (WebFrame::saveDocumentViewToCachedPage):
  • WebFrame.h:
4:55 PM Changeset in webkit [20837] by beidson
  • 22 edits
    3 moves
    2 deletes in trunk

WebCore:

Reviewed by Darin

<rdar://problem/4887095> - PageCache and PageState should be combined

These two objects are a relic of when the PageCache was split between WebCore and WebKit
It just makes good sense to combine them now, and the new object is more appropriately
called "CachedPage"

This patch is vast in scope, but simple in depth - anywhere a PageCache or PageState object
was used has been adjusted to use a CachedPage object instead. The most notable change is
that HistoryItem - which always used to have a PageCache object which may or may not have
had a PageState - now may or may not have a CachedPage. This actually simplifies the
HistoryItem code a bit while making the role of CachedPage much more clear.

  • WebCore.exp:
  • WebCore.xcodeproj/project.pbxproj:
  • history/BackForwardList.cpp: (WebCore::BackForwardList::addItem): (WebCore::BackForwardList::setCapacity): (WebCore::BackForwardList::setPageCacheSize): (WebCore::BackForwardList::clearPageCache): (WebCore::BackForwardList::close):
  • history/PageCache.cpp: Removed.
  • history/PageCache.h: Removed.
  • page/PageState.cpp: Removed.
  • page/PageState.h: Removed.
  • history/CachedPage.cpp: Added. (WebCore::CachedPage::create): (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::~CachedPage): (WebCore::CachedPage::restore): (WebCore::CachedPage::clear): (WebCore::CachedPage::setDocumentLoader): (WebCore::CachedPage::documentLoader): (WebCore::CachedPage::setTimeStamp): (WebCore::CachedPage::setTimeStampToNow): (WebCore::CachedPage::timeStamp):
  • history/CachedPage.h: Added. (WebCore::CachedPage::document): (WebCore::CachedPage::mousePressNode): (WebCore::CachedPage::URL):
  • history/HistoryItem.cpp: (WebCore::HistoryItem::HistoryItem): (WebCore::HistoryItem::setCachedPage): (WebCore::HistoryItem::setURL): (WebCore::HistoryItem::alwaysAttemptToUseCachedPage): (WebCore::HistoryItem::setAlwaysAttemptToUseCachedPage): (WebCore::HistoryItem::cachedPage): (WebCore::cachedPagesPendingRelease): (WebCore::HistoryItem::releaseCachedPagesOrReschedule): (WebCore::HistoryItem::releaseAllPendingCachedPages): (WebCore::HistoryItem::scheduleCachedPageForRelease):
  • history/HistoryItem.h:
  • history/mac/HistoryItemMac.mm:
  • history/HistoryItemTimer.cpp: (WebCore::HistoryItemTimer::HistoryItemTimer): (WebCore::HistoryItemTimer::callReleaseCachedPagesOrReschedule):
  • history/HistoryItemTimer.h:
  • history/mac/PageCacheMac.mm: Removed.
  • history/mac/CachedPageMac.mm: Added. (WebCore::CachedPage::close): (WebCore::CachedPage::setDocumentView): (WebCore::CachedPage::documentView):
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::DocumentLoader): (WebCore::DocumentLoader::loadFromCachedPage): (WebCore::DocumentLoader::setLoadingFromCachedPage): (WebCore::DocumentLoader::isLoadingFromCachedPage):
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::provisionalLoadStarted): (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted): (WebCore::FrameLoader::open): (WebCore::FrameLoader::startLoading): (WebCore::FrameLoader::receivedMainResourceError): (WebCore::FrameLoader::opened): (WebCore::FrameLoader::continueLoadAfterNavigationPolicy): (WebCore::FrameLoader::loadProvisionalItemFromCachedPage): (WebCore::FrameLoader::cachePageToHistoryItem): (WebCore::FrameLoader::createHistoryItem): (WebCore::FrameLoader::purgePageCache): (WebCore::FrameLoader::invalidateCurrentItemCachedPage): (WebCore::FrameLoader::loadItem): (WebCore::FrameLoader::updateHistoryForStandardLoad): (WebCore::FrameLoader::updateHistoryForClientRedirect): (WebCore::FrameLoader::updateHistoryForBackForwardNavigation): (WebCore::FrameLoader::updateHistoryForReload): (WebCore::FrameLoader::updateHistoryForInternalLoad): (WebCore::FrameLoader::updateHistoryForCommit):
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • page/mac/WebCoreFrameBridge.h: Got rid of unused WebCorePageCacheStateKey
  • page/mac/WebCoreFrameBridge.mm: Ditto
  • platform/graphics/svg/SVGImage.cpp:
  • platform/graphics/svg/SVGImageEmptyClients.h: Update to reflect the new names (WebCore::SVGEmptyFrameLoaderClient::loadProvisionalItemFromCachedPage): (WebCore::SVGEmptyFrameLoaderClient::invalidateCurrentItemCachedPage): (WebCore::SVGEmptyFrameLoaderClient::loadedFromCachedPage): (WebCore::SVGEmptyFrameLoaderClient::clearLoadingFromCachedPage): (WebCore::SVGEmptyFrameLoaderClient::isLoadingFromCachedPage): (WebCore::SVGEmptyFrameLoaderClient::setDocumentViewFromCachedPage): (WebCore::SVGEmptyFrameLoaderClient::saveDocumentViewToCachedPage):

WebKit:

Reviewed by Darin

<rdar://problem/4887095> - PageCache and PageState should be combined

WebKit side of the change to reflect the new object name of CachedPage and new Client method names

  • History/WebHistoryItem.mm: (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]): (+[WebHistoryItem _releaseAllPendingPageCaches]): (-[WebWindowWatcher windowWillClose:]):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::setDocumentViewFromCachedPage): (WebFrameLoaderClient::loadedFromCachedPage): (WebFrameLoaderClient::saveDocumentViewToCachedPage):
3:40 PM Changeset in webkit [20836] by ggaren
  • 2 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.


Fixed last check-in to print in release builds, too.

  • kjs/collector.cpp: (KJS::getPlatformThreadRegisters):
3:28 PM Changeset in webkit [23256] by kmccullo
  • 2 edits in branches/WindowsMerge/LayoutTests
  • Skipped: Re-enabled some tests that no longer crash and added other failures, for which radars will be filed, so that the build bot will be green, and will be usefull in identifying new breakages. Currently it is not.
3:27 PM Changeset in webkit [20835] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by John Sullivan, Darin Adler.


Fixed <rdar://problem/5121899> JavaScript garbage collection leads to
later crash under Rosetta (should abort or leak instead?)


Log an error message and crash if the kernel reports failure during GC.
We decided to do this instead of just leaking because we don't want people
to get the mistaken impression that running in Rosetta is a supported
configurtion.


The CRASH macro will also hook into CrashReporter, which will tell us if
many (any?) users run into this issue.

  • kjs/collector.cpp: (KJS::getPlatformThreadRegisters):
2:44 PM Changeset in webkit [20834] by antti
  • 3 edits
    4 adds in trunk

LayoutTests:

Reviewed by Hyatt.


Layout test for <rdar://5057686>
Flex box layout example hangs in WebCore::RenderFlexibleBox::allowedChildFlex

  • fast/flexbox/flex-hang-expected.checksum: Added.
  • fast/flexbox/flex-hang-expected.png: Added.
  • fast/flexbox/flex-hang-expected.txt: Added.
  • fast/flexbox/flex-hang.html: Added.

WebCore:

Reviewed by Hyatt.

Fix <rdar://5057686>
Flex box layout example hangs in WebCore::RenderFlexibleBox::allowedChildFlex


Forcibly distribute remaining pixels if the algorithm is not advancing.

  • rendering/RenderFlexibleBox.cpp: (WebCore::RenderFlexibleBox::layoutHorizontalBox): (WebCore::RenderFlexibleBox::layoutVerticalBox):
2:37 PM Changeset in webkit [20833] by bdash
  • 2 edits in trunk/WebCore

2007-04-11 Mark Rowe <​mrowe@apple.com>

Build fix.

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityDescription]):
2:21 PM Changeset in webkit [20832] by sfalken
  • 3 edits in branches/Safari-522/WebCore

Merged fix from r20685

2:19 PM Changeset in webkit [20831] by sfalken
  • 2 edits in branches/Safari-522/WebCore

Merged fix from r20675

2:14 PM Changeset in webkit [20830] by sfalken
  • 7 edits
    3 copies in branches/Safari-522

Merge fix from r20813

2:14 PM Changeset in webkit [20829] by brmorris
  • 2 edits in S60/trunk/WebKit

bradley, reviewed by SuperMario

DESC: remove Rendundant include to save a warning :)


  • BrowserView/src/WebKitControl.cpp:
2:14 PM Changeset in webkit [20828] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-04-10 spadma

Reviewed by Zalan.
DESC: browser fails to properly render the <cr> <lf> special characters when a text file displayed
​http://bugs.webkit.org/show_bug.cgi?id=13324
TSW ID : JKRL-6ZSH8Q

  • ResourceLoader/src/ContentDispatcher.cpp: (CContentDispatcher::ConstructL):
2:11 PM Changeset in webkit [20827] by spadma
  • 2 edits in S60/trunk/WebKit

2007-04-10 spadma

Reviewed by Zalan.
DESC: browser fails to properly render the <cr> <lf> special characters when a text file displayed
​http://bugs.webkit.org/show_bug.cgi?id=13324
TSW ID : JKRL-6ZSH8Q

  • ResourceLoader/src/ContentDispatcher.cpp: (CContentDispatcher::ConstructL):
2:08 PM Changeset in webkit [20826] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

2007-04-10 spadma

Reviewed by Zalan.
DESC: Browser control hangs when accesing a secure (HTTPS) page
​http://bugs.webkit.org/show_bug.cgi?id=13322
TSW ID: EBRE-6ZQFKV

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::ConstructL): (CBrCtl::~CBrCtl):
2:04 PM Changeset in webkit [20825] by spadma
  • 2 edits in S60/trunk/WebKit

2007-04-10 spadma

Reviewed by Zalan.
DESC: Browser control hangs when accesing a secure (HTTPS) page
​http://bugs.webkit.org/show_bug.cgi?id=13322
TSW ID: EBRE-6ZQFKV

  • BrowserControl/src/BrCtl.cpp: (CBrCtl::ConstructL): (CBrCtl::~CBrCtl):
2:00 PM Changeset in webkit [20824] by pyeh
  • 3 edits in trunk/WebCore

<rdar://problem/5122276> Allow focused frame to fire off notification
Improve accessibility support for Mail WebView embedded Notes.

  • bridge/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postNotification):
The focused document with the selection change should fire the selection changed notification, not the top level document

  • bridge/mac/WebCoreAXObject.mm:

(-[WebCoreAXObject accessibilityDescription]):
Allow the name attribute of the html body to be used as the accessibility description

1:26 PM Changeset in webkit [20823] by brmorris
  • 3 edits in S60/trunk/WebKit

bradley, reviewed by nobody (build fix)

DESC: flagged out some includes.


  • BrowserView/src/WebKitControl.cpp:
  • ResourceLoader/src/HttpLoaderAcceptHeader.cpp:


1:12 PM Changeset in webkit [20822] by yongjzha
  • 2 edits in S60/branches/3.1m/WebCore

w3liu, reviewed by <​yongjun.zhang@nokia.com>

DESC: [S60] LXUU-6Z4HBB: GCF-AE-Browsing-S60-SPPR50.31: Fail in GCF test case: 45.15.30 Encoding Priority 1
​http://bugs.webkit.org/show_bug.cgi?id=13321

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/css/cssparser.cpp: (CSSParser::parseSheet):
1:11 PM Changeset in webkit [20821] by yongjzha
  • 2 edits in S60/trunk/WebCore

w3liu, reviewed by <​yongjun.zhang@nokia.com>

DESC: [S60] LXUU-6Z4HBB: GCF-AE-Browsing-S60-SPPR50.31: Fail in GCF test case: 45.15.30 Encoding Priority 1
​http://bugs.webkit.org/show_bug.cgi?id=13321

WARNING: NO TEST CASES ADDED OR CHANGED

  • khtml/css/cssparser.cpp: (CSSParser::parseSheet):
11:19 AM Changeset in webkit [20820] by ggaren
  • 16 edits in trunk

WebCore:

Reviewed by Maciej Stachowiak.


Support for fixing fast/forms/textarea-paste-newline.html.


Changed clients to use new preference specifying whether a Page should
allow pasting through the DOM API, instead of a global flag.

Removed old behavior of always allowing DOM paste in debug builds. In
light of the new preference-based API, that behavior makes no sense anymore.
Instead, developers who want to test paste inside Safari can set the
preference for themselves.

  • WebCore.exp:
  • editing/CommandByName.cpp: Removed crazy hack to keep an identically named but invalid copy of the global "pate allowed" flag in this file. (WebCore::Frame::enabledPaste):
  • editing/JSEditor.cpp: Removed "always allow" behavior for debug builds. (WebCore::JSEditor::queryCommandSupported):
  • editing/JSEditor.h:
  • page/Settings.cpp: (WebCore::Settings::setDOMPasteAllowed):
  • page/Settings.h: (WebCore::Settings::isDOMPasteAllowed):
  • rendering/RenderTreeAsText.cpp: (WebCore::externalRepresentation): Removed crazy hack to allow DOM paste after this function has been called.

WebKit:

Reviewed by Maciej Stachowiak.


Support for fixing fast/forms/textarea-paste-newline.html.


Added SPI for specifying whether a WebView should allow pasting through the
DOM API.

  • ChangeLog:
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.m: (+[WebPreferences standardPreferences]): (-[WebPreferences isDOMPasteAllowed]): (-[WebPreferences setDOMPasteAllowed:]):
  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm: (-[WebView _updateWebCoreSettingsFromPreferences:]):

WebKitTools:

Reviewed by Maciej Stachowiak.


Fixed fast/forms/textarea-paste-newline.html.


This failure was pretty funny. run-webkit-tests kills and respawns
DumpRenderTree once every 1000 runs. Adding a few tests caused
textarea-paste-newline.html to run right at the beginning of DumpRenderTree's
lifetime, before any render tree dumps had occurred. However, WebCore
used a render tree dump as the hook that set a global flag to allow
pasting through the DOM API, so running before any render tree dumps had
occurred caused this test to fail.

  • DumpRenderTree/DumpRenderTree.m: (dumpRenderTree): Explicitly tell WebKit to allow pasting through the DOM API, instead of hoping it will read the tea leaves.
9:36 AM Changeset in webkit [23255] by sullivan
  • 2 edits in branches/WindowsMerge/WebCore
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::Editor::markBadGrammar): Keep build going: added stub for this new method
9:28 AM Changeset in webkit [20819] by sullivan
  • 4 edits in trunk/WebCore

Reviewed by Tim Hatcher

  • fixed <rdar://problem/4859132> Grammar must always be checked in entire-sentence chunks, and shouldn't show markers for current sentence
  • editing/Editor.h: add markBadGrammar, now distinct from markMisspellings
  • editing/mac/EditorMac.mm: (WebCore::Editor::markMisspellingsAfterTypingToPosition): call markMisspellings on one word, and markBadGrammar on entire sentence (WebCore::markMisspellingsOrBadGrammar): new static function, extracted from markMisspellings (WebCore::Editor::markMisspellings): now calls extracted function (WebCore::Editor::markBadGrammar): new method, calls extracted function
  • page/Frame.cpp: (WebCore::Frame::respondToChangedSelection): update grammar markers for entire new and old sentences
2:35 AM Changeset in webkit [23254] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Anders.

Fix <rdar://problem/5119803> Web Inspector has no options menu

  • WebInspector/WebInspector.cpp: (interpreterForFrame): Added. (WebInspector::showOptionsMenu): Implemented. (WebInspector::onCommand): Added. (WebInspector::toggleIgnoreWhitespace): Implemented. (WebInspector::toggleShowUserAgentStyles): Implemented. (WebInspectorWndProc): Added case for WM_COMMAND.
  • WebInspector/WebInspector.h:
2:23 AM Changeset in webkit [23253] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/5056988>
Can not open player on ​http://radioalice.com

Fix scriptStringIfJavaScriptURL to not use the path of the URL. This would ignore any characters past
a '?' character because that would be parsed as the query part of the URL.


  • plugins/win/PluginViewWin.cpp: (WebCore::scriptStringIfJavaScriptURL): Make this be more like the mac, chopping off the first 12 characters ("javascript:") and then decoding the remaining characters.
1:59 AM Changeset in webkit [23252] by andersca
  • 2 edits in branches/WindowsMerge/WebCore
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::PluginViewWin): Initialize m_status.
12:54 AM Changeset in webkit [20818] by mjs
  • 2 edits in branches/js-collector-tweaks/JavaScriptCore

Not reviewed, experimental change.

  • raise ALLOCATIONS_PER_COLLECTION to 4000, for 3.7% iBench speed improvement


Now that the cell size is smaller and the block size is bigger, we can fit 4000 objects in
the two spare cells the collector is willing to keep around, so collect a bit less often.


  • kjs/collector.cpp:
12:52 AM Changeset in webkit [20817] by mjs
  • 4 edits in branches/js-collector-tweaks/JavaScriptCore

Not reviewed, experimental change.


  • move mark and collectOnMainThreadOnly bits into separate bitmaps


This saves 4 bytes per word, allowing shrink of cell size 32,
which leads to a .8% speed improvement on iBench.


This is only feasible because of all the previous changes on the branch.

  • kjs/collector.cpp: (KJS::allocateBlock): Adjust for some renames of constants. (KJS::Collector::markStackObjectsConservatively): Now that cells are 32 bytes (64 bytes on 64-bit) the cell alignment check can be made much more strict, and also obsoletes the need for a % sizeof(CollectorCell) check. Also, we can mask off the low bits of the pointer to have a potential block pointer to look for. (KJS::Collector::collectOnMainThreadOnly): Use bitmap. (KJS::Collector::markMainThreadOnlyObjects): Use bitmap. (KJS::Collector::collect): When sweeping, use bitmaps directly to find mark bits.
  • kjs/collector.h: (KJS::): Move needed constants and type declarations here. (KJS::CollectorBitmap::get): Bit twiddling to get a bitmap value. (KJS::CollectorBitmap::set): Bit twiddling to set a bitmap bit to true. (KJS::CollectorBitmap::clear): Bit twiddling to set a bitmap bit to false. (KJS::CollectorBitmap::clearAll): Clear whole bitmap at one go. (KJS::Collector::cellBlock): New operation, compute the block pointer for a cell by masking off low bits. (KJS::Collector::cellOffset): New operation, compute the cell offset for a cell by masking off high bits and dividing (actually a shift). (KJS::Collector::isCellMarked): Check mark bit in bitmap (KJS::Collector::markCell): Set mark bit in bitmap.
  • kjs/value.h: (KJS::JSCell::JSCell): No more bits. (KJS::JSCell::marked): Let collector handle it. (KJS::JSCell::mark): Let collector handle it.
12:49 AM Changeset in webkit [23251] by andersca
  • 11 edits in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam.

<rdar://problem/5062624>
No prompt to install QT for pages with uninstalled QT plug-in.


Add a status() accessor to PluginViewWin. This can be used by WebKit to find out if the plug-in
loaded successfully or not.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::PluginViewWin): (WebCore::PluginViewWin::init):
  • plugins/win/PluginViewWin.h: (WebCore::): (WebCore::PluginViewWin::status):

WebKitWin:

Reviewed by Adam.

<rdar://problem/5062624>
No prompt to install QT for pages with uninstalled QT plug-in.


  • CFDictionaryPropertyBag.cpp: (CFDictionaryPropertyBag::Read): (CFDictionaryPropertyBag::Write): Use LPCOLESTRToCFStringRef here since the property names aren't BSTRs.


  • Interfaces/IWebError.idl: Add user info keys.


  • MarshallingHelpers.cpp: (MarshallingHelpers::LPCOLESTRToCFStringRef):
  • MarshallingHelpers.h: New function.


  • WebError.cpp: (WebError::WebError): (WebError::createInstance): Take a property bag.


(WebError::userInfo):
Return the property bag.


  • WebFrame.cpp: (WebFrame::createPlugin): If the plug-in wasn't found or failed to load, create a WebError with the right user info and call IWebResourceLoadDelegate::plugInFailedWithError.
12:37 AM Changeset in webkit [20816] by mjs
  • 6 edits in branches/js-collector-tweaks/JavaScriptCore

Not reviewed, experimental change.


  • shrink FunctionImp / DeclaredFunctionImp by 4 bytes, by moving parameter list to function body


I reconciled this with a similar change in KDE kjs by Maks Orlovich <​maksim@kde.org>.

  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::FunctionImp::passInParameters): (KJS::FunctionImp::lengthGetter): (KJS::FunctionImp::getParameterName):
  • kjs/function.h:
  • kjs/function_object.cpp: (FunctionProtoFunc::callAsFunction): (FunctionObjectImp::construct):
  • kjs/nodes.cpp: (FunctionBodyNode::addParam): (FunctionBodyNode::paramString): (FuncDeclNode::addParams): (FuncDeclNode::processFuncDecl): (FuncExprNode::addParams): (FuncExprNode::evaluate):
  • kjs/nodes.h: (KJS::Parameter::Parameter): (KJS::FunctionBodyNode::numParams): (KJS::FunctionBodyNode::paramName): (KJS::FunctionBodyNode::parameters): (KJS::FuncExprNode::FuncExprNode): (KJS::FuncDeclNode::FuncDeclNode):

Apr 9, 2007:

6:36 PM Known incompatibilities between open-source WebKit and Safari edited by bdash@webkit.org
(diff)
6:05 PM Changeset in webkit [20815] by adele
  • 1 edit
    1 add in trunk/WebKitSite
  • blog/wp-content/chrome.jpg: Added.
5:55 PM Changeset in webkit [23250] by beidson
  • 4 edits in branches/WindowsMerge

Build fix for my recent OpenSource checkin

5:06 PM Changeset in webkit [20814] by andersca
  • 4 edits in trunk

WebCore:

Reviewed by John.

  • WebCore.exp: Add ZNK7WebCore11FrameLoader10isCompleteEv.

WebKit:

Reviewed by John.

<rdar://problem/5081860>
REGRESSION: Select All for standalone image has no visible effect but does change state


<rdar://problem/5081840>
REGRESSION: context menu in white space beyond standalone image is different after Select All


Have validateUserInterface emulate the old behavior for full-frame images and plugins, which is:


  • For full-frame plugins, always return false.
  • For images, only return true if the selector is copy: and the image has finished loading.


  • WebView/WebHTMLView.mm: (-[WebHTMLView validateUserInterfaceItem:]):
5:00 PM Changeset in webkit [20813] by beidson
  • 7 edits
    3 adds in trunk

LayoutTests:

Reviewed by Darin

Layout test for the fix for <rdar://4921797> and ​http://bugs.webkit.org/show_bug.cgi?id=12005

  • http/tests/navigation/multiple-back-forward-entries-expected.txt: Added.
  • http/tests/navigation/multiple-back-forward-entries.html: Added.
  • http/tests/navigation/resources/slow-resource.pl: Added.

WebCore:

Reviewed by Darin

Fixes <rdar://4921797> and ​http://bugs.webkit.org/show_bug.cgi?id=12005

The original regression was to claim that more loads were the result of a "user gesture" than really
were. A lot of the ways a frame load could be kicked off didn't properly set up this flag, and it
wasn't properly propagated and respected where it should've been.

This patch cleans much of that up. One loose end is the "treatAsUserGesture" flag which is a stop
gap measure to keep "slow redirects" working to create a new history item. In the future, we need
to cleanup the meaning and use of "userGesture" and "lockHistory." This includes integrating them
in to FrameLoadRequest and being very clear of what their meaning actually is at different stages of
the Frame load process.

  • dom/Document.cpp: (WebCore::Document::processHttpEquiv): Pass only the delay for the redirect
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Pass "lockHistory" false, "userGesture" true
  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): Pass "lockHistory" false, "userGesture" true
  • loader/FrameLoader.cpp: (WebCore::ScheduledRedirection::ScheduledRedirection): Figure "lockHistory" and "userGesture" from the delay here, instead of at 3 other different sites that call this method (WebCore::FrameLoader::changeLocation): Set userGesture correctly (WebCore::FrameLoader::urlSelected): Propagate userGesture down (WebCore::FrameLoader::requestFrame): (WebCore::FrameLoader::receivedFirstData): (WebCore::FrameLoader::scheduleRedirection): Pass only the delay here (WebCore::FrameLoader::redirectionTimerFired): Set userGesture correctly (WebCore::FrameLoader::load): (WebCore::FrameLoader::updateHistoryForInternalLoad): Insteading of asserting we aren't a redirect, handle the case where we *are* a redirect by updating the previous history item
  • loader/FrameLoader.h:
4:31 PM Changeset in webkit [20812] by andersca
  • 2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/5026893>
REGRESSION: "Mail Contents of this Page" for standalone image in Safari results in a broken image in Mail


  • WebView/WebFrame.mm: (-[WebFrame DOMDocument]): We can't check for _isHTMLDocument here since image and plugin documents inherit from HTMLDocument. Instead, check for those two document types explicitly.
3:52 PM Changeset in webkit [20811] by andersca
  • 3 edits in trunk/WebKit

Reviewed by Geoff, Ada and John.

<rdar://problem/4600978> Would like a way to test whether a WebView is displaying a standalone image

  • WebView/WebFrame.mm: (-[WebFrame _isDisplayingStandaloneImage]):
  • WebView/WebFramePrivate.h: Add _isDisplayingStandaloneImage SPI.
3:30 PM Changeset in webkit [23249] by thatcher
  • 2 edits in branches/WindowsMerge/WebKitWin

Merge in r20810.

<rdar://problem/5121757> WebInspector focuses elements on mouse up instead of mouse down

Make selecting a tree node happen on mousedown to match the NSOutlineView behavior.
Also makes selecting rows in the style pane happen on mousedown for consistency.

3:14 PM Changeset in webkit [20810] by thatcher
  • 1 edit in branches/WebInspectorRefresh/WebKit/WebInspector/webInspector/inspector.js

Make selecting a tree node happen on mousedown to match the NSOutlineView behavior. Also makes selecting rows in the style pane happen on mousedown for consistency.

3:11 PM Changeset in webkit [20809] by andersca
  • 1 edit in trunk/LayoutTests/ChangeLog

Add bug number to ChangeLog.

1:07 PM Changeset in webkit [20808] by justing
  • 31 edits in trunk/LayoutTests

Reviewed by ggaren


These were never checked in:

  • editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum: Added.
  • editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added.


New results were never checked in after some selection
gap filling fixes:

  • editing/style/remove-underline-across-paragraph-expected.checksum:
  • editing/style/remove-underline-across-paragraph-expected.png:
  • editing/style/remove-underline-across-paragraph-in-bold-expected.checksum:
  • editing/style/remove-underline-across-paragraph-in-bold-expected.png:
  • editing/style/style-3690704-fix-expected.checksum:
  • editing/style/style-3690704-fix-expected.png:
  • editing/style/table-selection-expected.checksum:
  • editing/style/table-selection-expected.png:
  • editing/undo/4063751-expected.checksum:
  • editing/undo/4063751-expected.png:
  • editing/style/apple-style-editable-mix-expected.checksum:
  • editing/style/apple-style-editable-mix-expected.png:
  • editing/inserting/paragraph-separator-in-table-1-expected.checksum:
  • editing/inserting/paragraph-separator-in-table-1-expected.png:
  • editing/inserting/paragraph-separator-in-table-2-expected.checksum:
  • editing/inserting/paragraph-separator-in-table-2-expected.png:


Checking in incorrect results and adding a FIXME that references the
bug that this test demonstrates:

  • editing/style/smoosh-styles-003-expected.checksum:
  • editing/style/smoosh-styles-003-expected.png:
  • editing/style/smoosh-styles-003-expected.txt:
  • editing/style/smoosh-styles-003.html:


Misspelling marker correctly removed:

  • editing/deleting/delete-to-select-table-expected.checksum:
  • editing/deleting/delete-to-select-table-expected.png:


Horizontal rules and parts of table borders were made very slightly
darker, and these results were never updated:

  • editing/inserting/4278698-expected.checksum:
  • editing/inserting/4278698-expected.png:
  • editing/unsupported-content/table-type-after-expected.checksum:
  • editing/unsupported-content/table-type-after-expected.png:
  • editing/unsupported-content/table-type-before-expected.checksum:
  • editing/unsupported-content/table-type-before-expected.png:
  • editing/deleting/table-cells-expected.checksum:
  • editing/deleting/table-cells-expected.png:
12:51 PM Changeset in webkit [20807] by andersca
  • 2 edits in trunk/LayoutTests

Reviewed by Mitz.

  • plugins/resources/open-and-close-window-with-plugin.html: Try to fix the ASSERT on the build bot by scheduling a timeout that schedules a timeout.
11:48 AM Changeset in webkit [20806] by spadma
  • 5 edits in S60/trunk/WebKit

raalexan, reviewed by <spadma>

DESC: removed the webkit warnings
​http://bugs.webkit.org/show_bug.cgi?id=13143

  • BrowserView/src/PluginContentPlayer.cpp:
  • BrowserView/src/WebKitLoader.cpp:
  • BrowserView/src/WebKitView.cpp:
  • ResourceLoader/CacheSrc/HttpCacheManager.cpp:
11:40 AM Changeset in webkit [23248] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

Fixed copyrights.

  • WebInspector/WebInspector.cpp:
  • WebInspector/WebInspector.h:
11:19 AM Changeset in webkit [20805] by andersca
  • 3 edits
    2 adds in trunk

LayoutTests:

Reviewed by Darin.


<rdar://problem/5120801>
​http://bugs.webkit.org/show_bug.cgi?id=13247
Closing a page during slow cloning causes crash in setJSStatusBarText (13247)


  • fast/dom/Window/setting-properties-on-closed-window-expected.txt: Added.
  • fast/dom/Window/setting-properties-on-closed-window.html: Added.

WebCore:

Reviewed by Darin.

<rdar://problem/5120801>
​http://bugs.webkit.org/show_bug.cgi?id=13247
Closing a page during slow cloning causes crash in setJSStatusBarText (13247)

  • bindings/js/kjs_window.cpp: (KJS::Window::put): Return early if m_frame is null. A closed window only has one property, "closed" so no properties should be settable in that case.
11:13 AM Changeset in webkit [23247] by aroben
  • 3 edits in branches/WindowsMerge/WebKitWin

Reviewed by Oliver.

Fix two Web Inspector bugs:

  • The WebView wasn't focused when the inspector first appeared.
  • Resizing the upper pane did not resize the whole window.
  • WebInspector/WebInspector.cpp: (WebInspector::show): Focus the WebView. (WebInspector::setFrame): Implemented. (WebInspector::webViewFrame): Implemented.
  • WebInspector/WebInspector.h:
10:48 AM Changeset in webkit [20804] by spadma
  • 4 edits in S60/trunk/WebKit

borges, reviewed by <sachin>

DESC: Part of S60 task 15095: Removed exporting of header files RecentUrlStore.h. Moved all keys from BrowserUiInternalCRKeys.h to BrowserUiSDKCRKeys.h
​http://bugs.webkit.org/show_bug.cgi?id=13310

  • BrowserView/src/WebKitControl.cpp:
  • Plugin/src/PluginSkin.cpp:
  • ResourceLoader/src/HttpLoaderAcceptHeader.cpp:
10:27 AM Changeset in webkit [23246] by aroben
  • 2 edits in branches/WindowsMerge/WebKitWin
  • WebInspector/WebInspector.cpp: (WebInspector::WebInspector): Removed two fixed FIXMEs and some commented-out code.
10:19 AM Changeset in webkit [23245] by aroben
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeImage):
7:33 AM Changeset in webkit [20803] by yongjzha
  • 2 edits in S60/branches/3.1m/WebCore

2007-04-05 winship <​steven.winship@nokia.com>

Reviewed by Yongjun <​yongjun.zhang@nokia.com>
DESC: ASAA-6Y2BLC - Crash when opening NT dialog twice

fix: set pointer to null so static data is re-initialized

​http://bugs.webkit.org/show_bug.cgi?id=13288

WARNING: NO TEST CASES ADDED OR CHANGED

  • kwq/KWQTextCodec.cpp: (QTextCodec::PrepareForExit):
4:48 AM Changeset in webkit [20802] by andrew
  • 8 edits
    4 adds in trunk

2007-04-09 Andrew Wellington <​proton@wiretapped.net>

Reviewed by Justin Garcia.


Layout test for ​http://bugs.webkit.org/show_bug.cgi?id=12959
"REGRESSION: Edit -> Copy not enabled on standalone images"

  • editing/pasteboard/copy-standalone-image-expected.checksum: Added.
  • editing/pasteboard/copy-standalone-image-expected.png: Added.
  • editing/pasteboard/copy-standalone-image-expected.txt: Added.
  • editing/pasteboard/copy-standalone-image.html: Added.

2007-04-09 Andrew Wellington <​proton@wiretapped.net>

Reviewed by Justin Garcia.


Fix for ​http://bugs.webkit.org/show_bug.cgi?id=12959
"REGRESSION: Edit -> Copy not enabled on standalone images"

  • dom/Document.h: Add support for determining if a document is an image (WebCore::Document::isImageDocument):
  • editing/Editor.cpp: (WebCore::Editor::canCopy): Image documents are copyable (WebCore::Editor::copy): If copying an image document, call appropriate pasteboard methods
  • loader/ImageDocument.h: (WebCore::ImageDocument::isImageDocument): Override to return true for image documents
  • platform/Pasteboard.h: Add new writeImage function to pasteboard
  • platform/mac/PasteboardMac.mm: (WebCore::Pasteboard::writeImage): Add writeImage implementation that takes Node and URL
  • platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeImage): Stub for Qt implementation of pasteboard
Note: See TracTimeline for information about the timeline view.