Timeline



Jun 1, 2007:

10:57 PM Changeset in webkit [21956] by sfalken
  • 1 copy in tags/Safari-522.8.7b

New tag.

8:30 PM Changeset in webkit [21955] by bdash
  • 1 edit in tags/Safari-5522.8.3/WebCore/Configurations/Version.xcconfig

Versioning.

8:20 PM Changeset in webkit [21954] by bdash
  • 1 copy in tags/Safari-5522.8.3

New tag.

8:12 PM Changeset in webkit [21953] by bdash
  • 2 edits in branches/Safari-5522/WebCore

Merge r21952.

Reviewed by David Harrison.

<rdar://problem/5236843>
CrashTracer: [USER] 3 crashes in Mail at WebCore::Loader::didReceiveResponse(WebCore::SubresourceLoader*, WebCore::ResourceResponse const&)

This is by no means the best solution for handling user style sheets. I've filed <rdar://problem/5244734>
for tracking that.

  • loader/loader.cpp: (WebCore::Loader::didReceiveResponse): If a load starts while the frame is still in the provisional state (this can be the case when loading the user style sheet), committing the load then causes all requests to be removed from the m_requestsLoading map. This means that req might be null here. In that case we just return early.
7:37 PM Changeset in webkit [21952] by andersca
  • 2 edits in trunk/WebCore

Reviewed by David Harrison.

<rdar://problem/5236843>
CrashTracer: [USER] 3 crashes in Mail at WebCore::Loader::didReceiveResponse(WebCore::SubresourceLoader*, WebCore::ResourceResponse const&)

This is by no means the best solution for handling user style sheets. I've filed <rdar://problem/5244734>
for tracking that.


  • loader/loader.cpp: (WebCore::Loader::didReceiveResponse): If a load starts while the frame is still in the provisional state (this can be the case when loading the user style sheet), committing the load then causes all requests to be removed from the m_requestsLoading map. This means that req might be null here. In that case we just return early.
6:58 PM Changeset in webkit [21951] by kevino
  • 3 edits in branches/wx-port-alpha/trunk

Don't require a debug build of wxWidgets to be used with wxWebKit.

4:54 PM Changeset in webkit [21950] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Adele.

  • page/mac/EventHandlerMac.mm: (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking): Instead of calling the event handler methods directly, post the fake event on the application event queue. This ensures that the fake event is handled only after handling of the initiating event has ended, and is seen by ancestor frames' event handlers.
3:27 PM Changeset in webkit [21949] by sfalken
  • 1 copy in tags/Safari-522.8.6b

New tag.

3:10 PM Changeset in webkit [23438] by kmccullo
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Oliver.

  • Uncommenting some functions that should not be commented out. I needed them for the Drosera port.
  • WebKit.vcproj/WebKit_debug.def:
3:07 PM Changeset in webkit [23437] by kmccullo
  • 3 edits in branches/WindowsMerge/WebKitTools

Reviewed by Steve.

3:00 PM Changeset in webkit [21948] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/StringWx.cpp

More robust string conversion, courtesy of Vaclav Slavik.

2:52 PM Changeset in webkit [23436] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

If the value exists but is empty, return an empty String.


  • plugins/win/PluginPackageWin.cpp: (WebCore::getVersionInfo):
2:28 PM Changeset in webkit [21947] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebView.cpp

Add explicit cast (some users reported 'ambiguous call' errors without it).

2:26 PM Changeset in webkit [21946] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/WebCoreSources.bkl

Remove duplicate file entry.

2:23 PM Changeset in webkit [21945] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/page/Frame.h

Remove unused variable.

2:12 PM Changeset in webkit [21944] by eseidel
  • 14 edits in branches/feature-branch

2007-06-01 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

Add support for maskUnits and maskContentUnits
​http://bugs.webkit.org/show_bug.cgi?id=12568


This is covered by the W3C tests (including mask-intro01)

  • ksvg2/svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::SVGMaskElement): (WebCore::SVGMaskElement::parseMappedAttribute): (WebCore::SVGMaskElement::drawMaskerContent): (WebCore::SVGMaskElement::canvasResource): (WebCore::SVGMaskElement::notifyAttributeChange):
  • ksvg2/svg/SVGMaskElement.h:
  • ksvg2/svg/SVGMaskElement.idl:
  • platform/graphics/svg/SVGResourceMasker.cpp: (WebCore::SVGResourceMasker::SVGResourceMasker): (WebCore::SVGResourceMasker::invalidate):
  • platform/graphics/svg/SVGResourceMasker.h:
  • platform/graphics/svg/cg/SVGResourceMaskerCg.mm: (WebCore::SVGResourceMasker::applyMask):
2:05 PM Changeset in webkit [21943] by bdash
  • 2 edits in branches/Safari-5522/WebCore

Merge r21933.

Reviewed by Beth Dakin.

Fixed <rdar://problem/5238177> Continuing after hitting breakpoint doesn't
execute the next step.

No test because the only code affected is the debugger, and none of the
relevant API is exported.

Reverted an accidental change in 21324 that caused originRootObject for
the window object always to be 0. We could probably just remove the debugger's
dependency on originRootObject, but I wanted to be safe.

  • page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject):
2:05 PM Changeset in webkit [21942] by bdash
  • 3 edits in branches/Safari-5522/WebCore

Merge r21905.

Reviewed by Hyatt.

Fix for <rdar://problem/5198882> CrashTracer: [USER] 7 crashes in
Safari at com.apple.WebCore: WebCore::RenderBlock::layoutBlock +
2360

The problem is that we are re-entering layout when we should not.
​http://trac.webkit.org/projects/webkit/changeset/21778 actually
fixed this crash, but we have been inspired to add the same guard
in two other possibly-dangerous places.

  • page/FrameView.cpp: (WebCore::FrameView::layout): Add the guard in two more places.
2:05 PM Changeset in webkit [21941] by bdash
  • 5 edits
    4 adds in branches/Safari-5522

Merge r21902.

LayoutTests:

Reviewed by Dr. Harrison.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=13868
REGRESSION: crash on accessing a new iframe's contentWindow property

  • fast/dom/frame-contentWindow-crash-expected.txt: Added.
  • fast/dom/frame-contentWindow-crash.html: Added.
  • fast/dom/iframe-contentWindow-crash-expected.txt: Added.
  • fast/dom/iframe-contentWindow-crash.html: Added.

WebCore:

Reviewed by Dr. Harrison.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=13868
REGRESSION: crash on accessing a new iframe's contentWindow property

Adds a null check in for the contentWindow property for HTMLIFrameElement
and HTMLFrameElement.

  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
2:04 PM Changeset in webkit [21940] by bdash
  • 2 edits in branches/Safari-5522/WebCore

Merge r21897.

Reviewed by Darin.

<rdar://problem/5200795> REGRESSION (r21057): lineBoxRects doesn't match actual text when wrapping occurs

Use box->end() instead of box->len().

  • rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects):
1:55 PM Changeset in webkit [23435] by sfalken
  • 2 edits in branches/WindowsMerge/WebKitWin

Reviewed by Kevin Decker.


Remove unnecessary user agent spoofs, now that we have the final UA in place.
Added spoof to allow Flash downloads from adobe.com

  • WebView.cpp: (WebView::userAgentForKURL):
12:09 PM Changeset in webkit [23434] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Steve.

Add the default path for the new WMP Firefox plugin.

  • plugins/win/PluginDatabaseWin.cpp: (WebCore::addWindowsMediaPlayerPluginPath):
11:01 AM Changeset in webkit [21939] by andersca
  • 15 edits in branches/Safari-522

Merge r20613 and the subsequent build fix, r20614

5:47 AM Changeset in webkit [21938] by staikos
  • 2 edits in trunk/WebCore

2007-06-01 George Staikos <​staikos@kde.org>

Reviewed by bdash.

Redo the build fix again after it was backed out

  • WebCore.pro: add an include guard around CSSGrammar.h
5:40 AM BuildingOnWindows edited by todd.fisher@revolution.com
(diff)
5:39 AM BuildingOnWindows edited by todd.fisher@revolution.com
(diff)
4:20 AM Changeset in webkit [21937] by eseidel
  • 2 edits
    1 add in branches/feature-branch/WebCore

2007-06-01 Eric Seidel <​eric@webkit.org>

Reviewed by lars.


Cursor does not change to hand over links containing <use>
​http://bugs.webkit.org/show_bug.cgi?id=12630

Test: manual-tests/svg-link-hover-use.svg

  • manual-tests/svg-link-hover-use.svg: Added.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::hitTest): use eventParentNode instead of parentNode
2:59 AM Changeset in webkit [21936] by eseidel
  • 5 edits
    4 adds in branches/feature-branch

2007-06-01 Eric Seidel <​eric@webkit.org>

Reviewed by olliej.

SVG is not correctly respecting scroll during hit testing
​http://bugs.webkit.org/show_bug.cgi?id=13083

Test: svg/custom/scroll-hit-test.svg

  • rendering/RenderPath.cpp: (WebCore::RenderPath::nodeAtPoint):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::nodeAtPoint):
2:34 AM Changeset in webkit [21935] by bdash
  • 2 edits in trunk/WebCore

Roll out r21916 as it did nothing to fix the build.

1:13 AM Changeset in webkit [21934] by eseidel
  • 4 edits
    5 adds in branches/feature-branch

2007-06-01 Eric Seidel <​eric@webkit.org>

Reviewed by hyatt.

Fix for: ​http://bugs.webkit.org/show_bug.cgi?id=12187

Tests: fast/dom/attribute-case-sensitivity.html, fast/dom/attribute-case-sensitivity2.xhtml

  • dom/Element.cpp: (WebCore::shouldIgnoreAttributeCase): check to make sure element is an HTMLElement (WebCore::Element::getAttribute): (WebCore::Element::setAttribute): (WebCore::Element::removeAttribute): (WebCore::Element::getAttributeNode): (WebCore::Element::hasAttribute):
  • dom/NamedAttrMap.cpp: (WebCore::shouldIgnoreAttributeCase): (WebCore::NamedAttrMap::getNamedItem): (WebCore::NamedAttrMap::removeNamedItem):
12:25 AM Changeset in webkit [21933] by ggaren
  • 3 edits in trunk/WebCore

Reviewed by Beth Dakin.

Fixed <rdar://problem/5238177> Continuing after hitting breakpoint doesn't
execute the next step.


No test because the only code affected is the debugger, and none of the
relevant API is exported.


Reverted an accidental change in 21324 that caused originRootObject for
the window object always to be 0. We could probably just remove the debugger's
dependency on originRootObject, but I wanted to be safe.

  • page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject):

May 31, 2007:

10:57 PM Changeset in webkit [21932] by hyatt
  • 8 edits in trunk

WebCore:

Fix for 11768, Flash plugin does not respect clips set via CSS.

Reviewed by olliej

  • bindings/objc/DOM.mm: (-[DOMElement _windowClipRect]):
  • bindings/objc/DOMPrivate.h:
  • page/FrameView.cpp: (WebCore::FrameView::windowClipRect): (WebCore::FrameView::windowClipRectForLayer):
  • platform/ScrollView.h: (WebCore::ScrollView::contentsToWindow): (WebCore::ScrollView::windowToContents):
  • platform/mac/ScrollViewMac.mm: (WebCore::ScrollView::contentsToWindow): (WebCore::ScrollView::windowToContents):

WebKit:

Fix for 11768, Flash plugin does not respect clips set by CSS.

Reviewed by olliej

  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
10:46 PM Changeset in webkit [21931] by weinig
  • 3 edits in trunk/LayoutTests

Reviewed by Adam.

Update test to reflect new correct result.

  • fast/dom/Window/atob-btoa-expected.txt:
  • fast/dom/Window/atob-btoa.html:
10:45 PM Changeset in webkit [21930] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Adam.

Fix build bot.

  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::setCurrentScale):
9:49 PM Changeset in webkit [21929] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/JavaScriptCore/wtf/Assertions.h

Correct fix to deal with variadic macros on MSVC7.

9:34 PM Changeset in webkit [23433] by weinig
  • 2 edits in branches/WindowsMerge/WebCore

Fixed build.

  • WebCore.vcproj/WebCore.vcproj:
8:19 PM Changeset in webkit [21928] by weinig
  • 2 edits in trunk/WebCore

Fix Qt and Gdk builds.

  • WebCore.pro: remove bindings/js/JSHTMLAnchorElementCustom.cpp
8:13 PM Changeset in webkit [21927] by weinig
  • 16 edits
    2 adds
    1 delete in trunk

LayoutTests:

Reviewed by Geoff.

Tests for ​http://bugs.webkit.org/show_bug.cgi?id=10782
Classes should not override JSObject::toString(ExecState *)

  • Adds a new test to test overriding toString and valueOf for multiple objects.
  • Update tests to reflect the correction of the toString architecture.
  • editing/selection/getRangeAt-expected.txt:
  • fast/dom/Window/atob-btoa-expected.txt:
  • fast/js/toString-and-valueOf-override-expected.txt: Added.
  • fast/js/toString-and-valueOf-override.html: Added.

WebCore:

Reviewed by Geoff.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=10782
Classes should not override JSObject::toString(ExecState *)

Remove all overrides of JSObject::toString and JSObject::toPrimitive
which is a bad practice. Instead, if an object, like the
HTMLAnchorElement, needs to override to toString, it should add
a function to the JS object which will be called when needed. This
also allows developers to override toString and valueOf from within JS.

Test: fast/js/toString-and-valueOf-override.html

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLAnchorElementCustom.cpp: Removed.
  • bindings/js/kjs_binding.cpp:
  • bindings/js/kjs_binding.h:
  • bindings/js/kjs_dom.cpp:
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_domnode.h:
  • bindings/js/kjs_window.cpp: (KJS::History::): (KJS::LocationFunc::callAsFunction): (KJS::SelectionFunc::callAsFunction):
  • bindings/js/kjs_window.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::toString):
  • html/HTMLAnchorElement.h:
  • html/HTMLAnchorElement.idl:
7:35 PM Changeset in webkit [21926] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/JavaScriptCore/wtf/Assertions.h

Add a note about variadic macros on MSVC7, and enable any macros which don't use variadic args.

6:52 PM Changeset in webkit [21925] by weinig
  • 9 edits in trunk/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11272
Implement currentScale(), setCurrentScale() and currentTranslate() in SVGSVGElement

Allow zooming and panning, thereby implementing the above methods.

  • ksvg2/svg/SVGDocument.cpp: (WebCore::SVGDocument::zoomEnabled): (WebCore::SVGDocument::startPan): (WebCore::SVGDocument::updatePan):
  • ksvg2/svg/SVGDocument.h:
  • ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::currentScale): (WebCore::SVGSVGElement::setCurrentScale): (WebCore::SVGSVGElement::currentTranslate): (WebCore::SVGSVGElement::setCurrentTranslate):
  • ksvg2/svg/SVGSVGElement.h:
  • page/EventHandler.cpp: (WebCore::EventHandler::EventHandler): (WebCore::EventHandler::handleMousePressEvent): (WebCore::EventHandler::handleMouseMoveEvent): (WebCore::EventHandler::handleMouseReleaseEvent):
  • page/EventHandler.h:
  • page/Frame.cpp: (WebCore::Frame::setZoomFactor):
  • rendering/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::layout): (WebCore::RenderSVGContainer::paint): (WebCore::RenderSVGContainer::absoluteTransform):
  • rendering/RenderSVGContainer.h:
6:35 PM Changeset in webkit [21924] by weinig
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Niko.

Test for fix: ​http://bugs.webkit.org/show_bug.cgi?id=12570

  • svg/custom/prevent-default-expected.checksum: Added.
  • svg/custom/prevent-default-expected.png: Added.
  • svg/custom/prevent-default-expected.txt: Added.
  • svg/custom/prevent-default.svg: Added.

WebCore:

Reviewed by Niko.

Links are activated based on mouse down events instead of click events
​http://bugs.webkit.org/show_bug.cgi?id=12570


Test: svg/custom/prevent-default.svg

  • html/HTMLAnchorElement.cpp: use MiddleButton and RightButton instead of 1 and 2 (WebCore::HTMLAnchorElement::defaultEventHandler):
  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): make it function more like the HTML side
5:21 PM Changeset in webkit [21923] by mjs
  • 1 edit in trunk/LayoutTests/ChangeLog

Reviewed by Hyatt.


  • fix layout test editing/style/table-selection.html
  • editing/style/table-selection-expected.txt: Updated selection delegate output.
5:19 PM Changeset in webkit [21922] by mjs
  • 4 edits in trunk

LayoutTests:

Reviewed by Hyatt.


  • fix layout test editing/style/table-selection.html
  • editing/style/table-selection-expected.txt: Updated selection delegate output.

WebCore:

Reviewed by Hyatt.

  • fix layout test editing/style/table-selection.html


This was broken by the change to keep whitespace text nodes in tables. They safely didn't render,
but the font delta style change command would wrap them in spans, creating extra anonymous table
cells.

  • editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Don't wrap in a span if the text node is not rendered.
4:50 PM Changeset in webkit [21921] by weinig
  • 4 edits
    1 move in trunk

top level:

Reviewed by Eric Seidel.

​http://bugs.webkit.org/show_bug.cgi?id=13941
Rename WebCore/platform/network/gdk to WebCore/platform/network/curl

  • WebKit.pri:

WebCore:

Reviewed by Eric Seidel.

​http://bugs.webkit.org/show_bug.cgi?id=13941
Rename WebCore/platform/network/gdk to WebCore/platform/network/curl

  • WebCore.pro:
1:53 PM Changeset in webkit [21920] by eseidel
  • 4 edits
    4 adds in branches/feature-branch

2007-05-31 Eric Seidel <​eric@webkit.org>

Reviewed by Niko.

Links are activated based on mouse down events instead of click events
​http://bugs.webkit.org/show_bug.cgi?id=12570


Test: svg/custom/prevent-default.svg

  • html/HTMLAnchorElement.cpp: use MiddleButton and RightButton instead of 1 and 2 (WebCore::HTMLAnchorElement::defaultEventHandler):
  • ksvg2/svg/SVGAElement.cpp: (WebCore::SVGAElement::defaultEventHandler): make it function more like the HTML side
1:33 PM Changeset in webkit [21919] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Niko.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=13945
GraphicsContextCairo enhancements necessary for SVG support

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::concatCTM): (WebCore::GraphicsContext::beginPath): (WebCore::GraphicsContext::addPath):
1:20 PM Changeset in webkit [21918] by kevino
  • 43 edits
    4 copies
    17 adds in branches/wx-port-alpha/trunk

Merge with TOT and add files that weren't automatically added during the last merge.

12:49 PM Changeset in webkit [21917] by pyeh
  • 2 edits in trunk/WebCore

<rdar://problem/5221920> AXLink is returning a CFString instead of a CFURL for AXURL

  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeValue:]): Convert the url string to an NSURL before returning as the AXURLAttribute
12:44 PM Changeset in webkit [21916] by staikos
  • 2 edits in trunk/WebCore

2007-05-31 George Staikos <​staikos@kde.org>

Reviewed by Nikolas.

Compile again - Qt build.

  • WebCore.pro: header guard added to CSSGrammar.h
11:32 AM Changeset in webkit [21915] by spadma
  • 2 edits in S60/trunk/WebKit

spadma, reviewed by zalan

DESC: Browser control API, CBrCtlInterface
ContentSize() does not return correct content size. ​http://bugs.webkit.org/show_bug.cgi?id=13954
  • BrowserControl/src/BrCtl.cpp: (CBrCtl::ContentSize):
11:31 AM Changeset in webkit [21914] by spadma
  • 2 edits in S60/branches/3.1m/WebKit

spadma, reviewed by Zalan

DESC: Memory Leak in BrowserNG
​http://bugs.webkit.org/show_bug.cgi?id=13953
TSW ID: AVAO-73NF6X

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::SetPageUrlL):
11:30 AM Changeset in webkit [21913] by spadma
  • 2 edits in S60/trunk/WebKit

spadma, reviewed by Zalan

DESC: Memory Leak in BrowserNG
​http://bugs.webkit.org/show_bug.cgi?id=13953
TSW ID: AVAO-73NF6X

  • BrowserView/src/WebKitLoader.cpp: (CWebKitLoader::SetPageUrlL):
9:52 AM Changeset in webkit [21912] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKitTools/Scripts/build-wxwebkit

Make sure the build completed output only happens when doing a build.

12:04 AM Changeset in webkit [23432] by weinig
  • 2 edits in branches/WindowsMerge/WebCore

Fixed build.

  • WebCore.vcproj/WebCore.vcproj:

May 30, 2007:

10:21 PM Changeset in webkit [21911] by weinig
  • 14 edits in trunk

LayoutTests:

Reviewed by Oliver.

Update results for ​http://bugs.webkit.org/show_bug.cgi?id=13943
Autogenerate the JS bindings for the CSSStyleSheet

  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Oliver.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=13943
Autogenerate the JS bindings for the CSSStyleSheet

  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSStyleSheetCustom.cpp: (WebCore::toJS):
  • bindings/js/kjs_css.cpp:
  • bindings/js/kjs_css.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::addRule): (WebCore::CSSStyleSheet::cssRules):
  • css/CSSStyleSheet.h: (WebCore::CSSStyleSheet::rules): (WebCore::CSSStyleSheet::removeRule):
  • css/CSSStyleSheet.idl:
  • page/DOMWindow.idl:
10:05 PM Changeset in webkit [21910] by weinig
  • 9 edits
    1 add in trunk/WebCore

Reviewed by Oliver.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=13937
Autogenerate the JS bindings for the CSSValue

  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCSSValueCustom.cpp: Added. (WebCore::toJS):
  • bindings/js/kjs_css.cpp:
  • bindings/js/kjs_css.h:
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/CSSValue.h: (WebCore::CSSValue::setCssText):
  • css/CSSValue.idl:
8:36 PM Changeset in webkit [21909] by weinig
  • 7 edits in trunk

LayoutTests:

Reviewed by Oliver the Hun.

Update results for ​http://bugs.webkit.org/show_bug.cgi?id=13944
Generate and add missing JS constructors

  • fast/dom/Window/window-properties-expected.txt:

WebCore:

Reviewed by Oliver the Hun.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=13944
Generate and add missing JS constructors

  • css/CSSRuleList.idl:
  • css/CSSValueList.idl:
  • css/Counter.idl:
  • page/DOMWindow.idl:
8:12 PM BuildingGdk edited by alp@atoker.com
Update Gdk tasks (diff)
6:24 PM BuildingGdk edited by alp@atoker.com
(diff)
5:39 PM Changeset in webkit [21908] by justing
  • 3 edits in trunk/WebCore

Reviewed by Darin.


​http://bugs.webkit.org/show_bug.cgi?id=13915
REGRESSION(r21687): editing/inserting/paragraph-separator-* failing pixel test (misspelling markers)

After r21687, SimplifiedBackwardsTextIterator was no longer
emitting a '\n' as it left the first block of a range ending
at [block, 0]. So, foo<div><br></div> looked like foo to
spell checking (foo wasn't marked as misspelled).

After r21687, SBTI stopped emitting '\n's in the above case
because 1) we stopped incorrectly emitting '\n's for nodes as
we entered them and 2) we were and still are incorrectly calling
code that should only be called when entering nodes as we leave
them and 3) we don't call exitNode(), which is responsible
for emitting the '\n' in the above testcase, when we should.

Before and after r21687, we'd call exitNode() for a node as
we traversed in reverse pre-order from its first descendant
out to its sibling or one of its ancestors' siblings. We
weren't calling it a) after we'd enter a node that could
have children but had none and b) when leaving a container
that contained the end of the range used to create the iterator.

  • editing/TextIterator.cpp: (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator): (WebCore::SimplifiedBackwardsTextIterator::advance): Call exitNode() as we leave a childless container node and a node where the range ended.
  • editing/TextIterator.h: Track the end of the range used to create the SimplifiedBackwardsTextIterator.
5:23 PM Changeset in webkit [21907] by weinig
  • 3 edits in trunk

Update ChangeLogs with correct Bugzilla URLs.

5:16 PM Changeset in webkit [21906] by weinig
  • 8 edits
    1 add in trunk

JavaScriptCore:

Reviewed by Brady.

Enable logging in the Gdk port.
​http://bugs.webkit.org/show_bug.cgi?id=13029

  • wtf/Assertions.cpp:
  • wtf/Assertions.h: Add WTFLogVerbose which also logs the file, line number and function.

WebCore:

Reviewed by Brady.

Enable logging in the Gdk port.
​http://bugs.webkit.org/show_bug.cgi?id=13029

  • WebCore.pro:
  • platform/NotImplemented.h: Changed to use WTFLogVerbose.
  • platform/gdk/LoggingGdk.cpp: Added. (WebCore::InitializeLoggingChannelsIfNecessary):

WebKitTools:

Reviewed by Brady.

Enable logging in the Gdk port.
​http://bugs.webkit.org/show_bug.cgi?id=13029

  • GdkLauncher/main.cpp: (main):
4:03 PM Changeset in webkit [21905] by bdakin
  • 3 edits in trunk/WebCore

Reviewed by Hyatt.

Fix for <rdar://problem/5198882> CrashTracer: [USER] 7 crashes in
Safari at com.apple.WebCore: WebCore::RenderBlock::layoutBlock +
2360

The problem is that we are re-entering layout when we should not.
​http://trac.webkit.org/projects/webkit/changeset/21778 actually
fixed this crash, but we have been inspired to add the same guard
in two other possibly-dangerous places.

  • page/FrameView.cpp: (WebCore::FrameView::layout): Add the guard in two more places.
3:06 PM Changeset in webkit [21904] by justing
  • 5 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5096134> VO gets stuck on Howto.apple.com
​http://bugs.webkit.org/show_bug.cgi?id=8622
VisiblePositions aren't canonicalized in some cases


No new test cases added: can't write automated tests
for VO.

  • editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::outdentParagraph): VisiblePositions must be recomputed after nodes that may have effected their canonicalization are removed.
  • editing/VisiblePosition.cpp: (WebCore::canonicalizeCandidate): Added. (WebCore::VisiblePosition::canonicalPosition): Canonicalize the candidates returned by next/previousCandidate before returning them.
  • editing/VisiblePosition.h: (WebCore::operator==): Remove the workaround for 8622.
  • editing/visible_units.cpp: (WebCore::startOfParagraph): Ditto.
3:02 PM Changeset in webkit [21903] by kevino
  • 230 edits
    3 copies
    1 delete in branches/wx-port-alpha/trunk

Sync with TOT to get the curl, NotImplemented, etc. goodies.

2:36 PM Changeset in webkit [23431] by adachan
  • 2 edits in branches/WindowsMerge/WebCore

2007-05-30 Ada Chan <​adachan@apple.com>

Reviewed by Adam.

Fixed build.

  • platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::itemWritingDirectionIsNatural):


2:08 PM Changeset in webkit [21902] by weinig
  • 5 edits
    4 adds in trunk

LayoutTests:

Reviewed by Dr. Harrison.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=13868
REGRESSION: crash on accessing a new iframe's contentWindow property

  • fast/dom/frame-contentWindow-crash-expected.txt: Added.
  • fast/dom/frame-contentWindow-crash.html: Added.
  • fast/dom/iframe-contentWindow-crash-expected.txt: Added.
  • fast/dom/iframe-contentWindow-crash.html: Added.

WebCore:

Reviewed by Dr. Harrison.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=13868
REGRESSION: crash on accessing a new iframe's contentWindow property

Adds a null check in for the contentWindow property for HTMLIFrameElement
and HTMLFrameElement.

  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
1:56 PM Changeset in webkit [21901] by sfalken
  • 1 copy in tags/Safari-522.8.5b

New tag.

12:16 PM Changeset in webkit [21900] by bdash
  • 9 edits
    4 adds in trunk

2007-05-30 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

Test: fast/forms/select-writing-direction-natural.html

  • platform/PopupMenu.h: Added the static method itemWritingDirectionIsNatural which says whether items in the popup ignore the CSS text-align and direction properties and instead are left-aligned and use natural writing direction.
  • platform/gdk/PopupMenuGdk.cpp: (WebCore::PopupMenu::itemWritingDirectionIsNatural):
  • platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::itemWritingDirectionIsNatural):
  • platform/qt/PopupMenuQt.cpp: (WebCore::PopupMenu::itemWritingDirectionIsNatural):
  • platform/win/TemporaryLinkStubs.cpp: (WebCore::PopupMenu::itemWritingDirectionIsNatural):
  • platform/wx/TemporaryLinkStubs.cpp: (PopupMenu::itemWritingDirectionIsNatural):
  • rendering/RenderMenuList.cpp: (WebCore::textDirectionForParagraph): Added this helper function that uses the Unicode Bidi Algorithm rules P2 and P3 to determine the writing direction of text. (WebCore::RenderMenuList::adjustInnerStyle): Made the alignment and direction adjustment conditional on the popup implementation. (WebCore::RenderMenuList::setText): Added call to adjustInnerStyle() since the style depends on the text when natural writing direction is used.

2007-05-30 Mitz Pettel <​mitz@webkit.org>

Reviewed by Darin.

  • fast/forms/select-writing-direction-natural-expected.checksum: Added.
  • fast/forms/select-writing-direction-natural-expected.png: Added.
  • fast/forms/select-writing-direction-natural-expected.txt: Added.
  • fast/forms/select-writing-direction-natural.html: Added.
11:57 AM Changeset in webkit [21899] by weinig
  • 1 edit in trunk/LayoutTests/ChangeLog

Add radar to ChangeLog.

11:56 AM Changeset in webkit [23430] by adachan
  • 5 edits in branches/WindowsMerge/WebKitWin

2007-05-30 Ada Chan <​adachan@apple.com>

Reviewed by Steve.

Implemented the mechanism to associate a WebPreferences instance with an identifier.

  • WebIconDatabase.cpp: (WebIconDatabase::init): fixed a missing Release on standardPrefs by using COMPtr.
  • WebPreferences.cpp: (WebPreferences::getInstanceForIdentifier): implemented (WebPreferences::setInstance): implemented (WebPreferences::removeReferenceForIdentifier): if the WebPreferences going to be released has only one ref left, remove it from the s_webPreferencesInstances dictionary. (WebPreferences::load): don't need to reread in the default preferences if we have done so. (WebPreferences::initWithIdentifier): update the m_identifier data member with the passed in identifier string, and store the identifier to WebPreferences instance mapping in s_webPreferencesInstances dictionary. (WebPreferences::identifier): implemented
  • WebPreferences.h:
  • WebView.cpp: (WebView::~WebView): removed the call to removeObserver for the WebPreferencesChangedNotification since it's already done in close(). (WebView::close): the call to removeObserver now takes in the WebPreferences instance for the object - this way the WebView is only notified when that particular WebPreferences instance changes. (WebView::initWithFrame): the call to addObserver now takes in the WebPreferences instance for the object - this way the WebView is only notified when that particular WebPreferences instance changes. (WebView::setPreferences): implemented (WebView::onNotify): used COMPtr to fix a missing release


11:45 AM Changeset in webkit [21898] by weinig
  • 2 edits in trunk/LayoutTests

Reviewed by Hyatt.

  • fast/dynamic/containing-block-change.html: Removed whitespace that got turned into text nodes, thereby making lastNode be not what the script expected it to be.
11:30 AM Changeset in webkit [23429] by weinig
  • 2 edits in branches/WindowsMerge/WebCore

Build Fix.

  • WebCore.vcproj/WebCore.vcproj:
11:11 AM Changeset in webkit [21897] by thatcher
  • 2 edits in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5200795> REGRESSION (r21057): lineBoxRects doesn't match actual text when wrapping occurs

Use box->end() instead of box->len().

  • rendering/RenderText.cpp: (WebCore::RenderText::addLineBoxRects):
10:43 AM Changeset in webkit [21896] by weinig
  • 26 edits
    1 add in trunk

LayoutTests:

Reviewed by Darin.

  • fast/dom/Window/window-properties-expected.txt: adds new constructors
  • fast/dom/wrapper-classes-expected.txt: CSSStyleRule now passes!!

WebCore:

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=13919
Autogenerate the JS bindings for the CSSRule and its subclasses

  • subclasses generated are CSSCharsetRule, CSSFontFaceRule, CSSImportRule CSSMediaRule, CSSPageRule and CSSStyleRule.
  • DerivedSources.make:
  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCSSRuleCustom.cpp: Added. (WebCore::toJS):
  • bindings/js/kjs_css.cpp:
  • bindings/js/kjs_css.h:
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/CSSCharsetRule.h: (WebCore::CSSCharsetRule::setEncoding):
  • css/CSSCharsetRule.idl:
  • css/CSSFontFaceRule.idl:
  • css/CSSImportRule.idl:
  • css/CSSMediaRule.idl:
  • css/CSSPageRule.cpp: (WebCore::CSSPageRule::setSelectorText):
  • css/CSSPageRule.h:
  • css/CSSPageRule.idl:
  • css/CSSRule.cpp: (WebCore::CSSRule::setCssText):
  • css/CSSRule.h:
  • css/CSSRule.idl:
  • css/CSSStyleRule.cpp: (WebCore::CSSStyleRule::setSelectorText):
  • css/CSSStyleRule.h:
  • css/CSSStyleRule.idl:
  • page/DOMWindow.idl: add new constructors.
10:21 AM Changeset in webkit [21895] by rwlbuis
  • 9 edits in branches/feature-branch/WebCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=11272
Implement currentScale(), setCurrentScale() and currentTranslate() in SVGSVGElement

Allow zooming and panning, thereby implementing the above methods.

7:40 AM Changeset in webkit [21894] by zbujtas
  • 11 edits in S60/trunk

2007-05-29 bujtas <​zbujtas@gmail.com>

Reviewed by Sachin.
DESC: stop animation on image renderers when browser
is in background
​http://bugs.webkit.org/show_bug.cgi?id=13906

6:28 AM Changeset in webkit [21893] by bdash
  • 5 edits
    2 adds in trunk

2007-05-30 Mark Rowe <​mrowe@apple.com>

Build fixes after r21889. Add missing #includes.

  • ForwardingHeaders/kjs/function.h: Added.
  • bindings/js/kjs_binding.h:
  • bindings/js/kjs_dom.h:
  • bindings/js/kjs_window.h:

2007-05-30 Mark Rowe <​mrowe@apple.com>

Build fixes after r21889.

  • ForwardingHeaders/kjs/function.h: Added.
6:20 AM Changeset in webkit [21892] by zbujtas
  • 11 edits in S60/branches/3.1m

2007-05-29 bujtas <​zbujtas@gmail.com>

Reviewed by Sachin.
DESC: stop animation on image renderers when browser
is in background
​http://bugs.webkit.org/show_bug.cgi?id=13906

6:15 AM Changeset in webkit [21891] by zimmermann
  • 13 edits in branches/feature-branch

Reviewed by Oliver.
Fix regression: gradient on fill of text works again!

5:27 AM Changeset in webkit [21890] by bdash
  • 2 edits in trunk/JavaScriptCore

2007-05-30 Mark Rowe <​mrowe@apple.com>

Mac build fix. Update #include.

  • API/JSCallbackFunction.h:
5:19 AM Changeset in webkit [21889] by bdash
  • 9 edits in trunk/JavaScriptCore

2007-05-30 Luciano Montanaro <​mikelima@cirulla.net>

Reviewed by Maciej.

  • cross-port Harri Porten's commits 636099 and 636108 from KJS: "publish a class anyway public already" and "class is being used from outside for quite some time" in preparation for further syncronizations
  • kjs/context.h:
  • kjs/date_object.cpp:
  • kjs/date_object.h:
  • kjs/function.h: (KJS::): (KJS::InternalFunctionImp::classInfo): (KJS::InternalFunctionImp::functionName):
  • kjs/function_object.h:
  • kjs/internal.h:
  • kjs/lookup.h: (KJS::getStaticPropertySlot): (KJS::getStaticFunctionSlot): (KJS::getStaticValueSlot):
  • kjs/object_object.h:
3:36 AM Changeset in webkit [21888] by oliver
  • 3 edits in trunk/LayoutTests

2007-05-30 Oliver Hunt <​oliver@apple.com>

Reviewed by Mitz.

Remove reference to SVG node from test -- otherwise this test incorrectly appears
to fail in non-SVG builds

  • http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard-expected.txt:
  • http/tests/xmlhttprequest/svg-created-by-xhr-disallowed-in-dashboard.html:
12:27 AM Changeset in webkit [21887] by bdash
  • 2 edits in trunk/WebCore

2007-05-30 Mark Rowe <​mrowe@apple.com>

Gdk build fix. Update WidgetGdk to use NotImplemented.h.

  • platform/gdk/WidgetGdk.cpp: (WebCore::Widget::setEnabled): (WebCore::Widget::isEnabled): (WebCore::Widget::removeFromParent): (WebCore::Widget::paint): (WebCore::Widget::setIsSelected):

May 29, 2007:

11:24 PM Changeset in webkit [21886] by bdash
  • 8 edits in trunk

2007-05-29 Holger Freyther <​zecke@selfish.org>

Reviewed by Anders.

Make ScrollView use a GtkLayout. This class matches QScrollView the most and promises
to ease the implementation of ScrollView::addChild. GtkLayout should be resource friendly
even with huge width and heights of frames.
Make Widget aware of GtkLayout to use the right GdkWindow as drawable. For GtkLayout one must
draw on the bin_window.
Remove the layer violation from FrameGdk.cpp and ScrollView. FrameGdk is no longer responsible to
implement scrolling on keyboard events. ScrollView is no longer required to know that it could be
a FrameView and handles scrolling of Frames magically.

  • platform/ScrollView.h:
  • platform/gdk/FrameGdk.cpp: (WebCore::FrameGdk::keyPress): (WebCore::FrameGdk::handleGdkEvent):
  • platform/gdk/ScrollViewGdk.cpp: (WebCore::ScrollView::ScrollViewPrivate::ScrollViewPrivate): (WebCore::ScrollView::updateContents): (WebCore::ScrollView::visibleWidth): (WebCore::ScrollView::visibleHeight): (WebCore::ScrollView::visibleContentRect): (WebCore::ScrollView::resizeContents): (WebCore::ScrollView::contentsX): (WebCore::ScrollView::contentsY): (WebCore::ScrollView::scrollOffset): (WebCore::ScrollView::scrollBy): (WebCore::ScrollView::setFrameGeometry): (WebCore::ScrollView::updateGeometry): (WebCore::ScrollView::setGtkWidget): (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::windowToContents): (WebCore::ScrollView::contentsToWindow): (WebCore::ScrollView::scrollbarUnderMouse):
  • platform/gdk/TemporaryLinkStubs.cpp: Move Widget methods to WidgetGdk.cpp
  • platform/gdk/WidgetGdk.cpp: (WebCore::Widget::setGtkWidget): (WebCore::Widget::setFrameGeometry): (WebCore::Widget::setEnabled): (WebCore::Widget::isEnabled): (WebCore::Widget::removeFromParent): (WebCore::Widget::paint): (WebCore::Widget::setIsSelected): (WebCore::Widget::invalidate): (WebCore::Widget::invalidateRect):

2007-05-29 Holger Freyther <​zecke@selfish.org>

Reviewed by Anders.

Create a GtkLayout and pass it to the FrameView/ScrollView. Embed the GtkLayout into a GtkScrolledWindow
to provide ScrollBars for the FrameView.

  • GdkLauncher/main.cpp: (registerRenderingAreaEvents): (layout_realize_callback): Only after realization we can access the GtkLayout::bin_window (frameResizeCallback): Inform the ScrollView about its new viewport size, and ask the FrameView to adjust (main):
11:15 PM Changeset in webkit [23428] by weinig
  • 2 edits in branches/WindowsMerge/WebCore

Fix the build.

  • WebCore.vcproj/WebCore.vcproj:
11:12 PM Changeset in webkit [21885] by bdash
  • 5 edits in trunk/WebCore

2007-05-29 Krzysztof Kowalczyk <​kkowalczyk@gmail.com>

Reviewed by Maciej.

Curl (linux/gdk) networking improvements:
a) POST support
b) don't use CURL in a re-entrant way.
c) turn on curl's internal debugging support in a debug build if the DEBUG_CURL environment variable is set.

  • platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
  • platform/network/gdk/ResourceHandleCurl.cpp: (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
  • platform/network/gdk/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::writeCallback): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::setupPOST): (WebCore::ResourceHandleManager::add): (WebCore::ResourceHandleManager::removeScheduledJob): (WebCore::ResourceHandleManager::startScheduledJobs): (WebCore::ResourceHandleManager::startJob): (WebCore::ResourceHandleManager::cancel):
  • platform/network/gdk/ResourceHandleManager.h: (WebCore::ResourceHandleList::ResourceHandleList): (WebCore::ResourceHandleList::next): (WebCore::ResourceHandleList::job): (WebCore::ResourceHandleList::setRemoved): (WebCore::ResourceHandleList::removed):
11:08 PM Changeset in webkit [21884] by weinig
  • 2 edits in trunk/WebCore

Fix the Qt and Gdk builds.

  • WebCore.pro:
10:55 PM Changeset in webkit [21883] by adele
  • 2 edits in trunk/WebCore

Reviewed by Adam.

Fix for <rdar://problem/5109711> REGRESSION: Focus ring artifacts appear around a widget's search field at times (Address Book, Dictionary)

  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSearchField): We only need this hack for drawing the search field focus ring on Tiger. On Leopard, drawWithFrame correctly draws the cell's focus ring.
10:53 PM Changeset in webkit [21882] by bdash
  • 2 edits in trunk/WebCore

2007-05-29 Alp Toker <​alp.toker@collabora.co.uk>

Reviewed by Mitz.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=13899

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::strokeArc): Use cairo_arc_negative() to fix CSS rounded borders. (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): save/restore is redundant. push/pop group does this implicitly.
10:47 PM Changeset in webkit [21881] by weinig
  • 11 edits in trunk

LayoutTests:

Reviewed by Oliver.

Update results for ​http://bugs.webkit.org/show_bug.cgi?id=13912
Autogenerate the JS bindings for the MediaList

  • fast/dom/Window/window-properties-expected.txt: new constructors added.

WebCore:

Reviewed by Oliver.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=13912
Autogenerate the JS bindings for the MediaList

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_css.cpp:
  • bindings/js/kjs_css.h:
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/MediaList.idl:
  • page/DOMWindow.idl: Add constructor.
10:41 PM Changeset in webkit [21880] by bdash
  • 3 edits in trunk/WebCore

2007-05-29 Matt Perry <​mpComplete@gmail.com>

Reviewed by Maciej.

Fixed some rendering issues for <select>s on Windows.

  • rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::adjustMenuListStyle): (WebCore::RenderThemeWin::paintMenuList):
  • rendering/RenderThemeWin.h:
10:32 PM Changeset in webkit [21879] by hyatt
  • 4 edits in trunk/WebCore

Fold the invalidateVerticalPositions crawl into the bidi iteration.
This makes it more correct (since we won't drill into elements that
did not need to be reset) and cuts out an extra walk of all our children.
We're still O(n2) as new content streams in, but this at least cuts
out one separate O(n2) crawl.

Reviewed by olliej

  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h: (WebCore::RenderObject::invalidateVerticalPosition):
  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren):
10:14 PM Changeset in webkit [21878] by bdash
  • 2 edits in tags/Safari-5522.8.2

Versioning.

10:10 PM Changeset in webkit [21877] by bdash
  • 1 copy in tags/Safari-5522.8.2

New tag.

10:08 PM Changeset in webkit [21876] by bdash
  • 31 edits in branches/Safari-5522

Merge r21793.

10:01 PM Changeset in webkit [21875] by bdash
  • 2 edits in branches/Safari-5522/WebKitTools

Merge r21839 to ease building of the branch.

10:00 PM Changeset in webkit [21874] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebView.cpp

MSVC build fix for non-wxGC build mode.

9:45 PM Changeset in webkit [21873] by weinig
  • 11 edits
    1 add in trunk

LayoutTests:

Reviewed by Oliver.

Update results after ​http://bugs.webkit.org/show_bug.cgi?id=13908
Autogenerate the JS bindings for the StyleSheet

  • fast/dom/Window/window-properties-expected.txt: Adds StyleSheet constructor

WebCore:

Reviewed by Oliver.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=13908
Autogenerate the JS bindings for the StyleSheet

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSStyleSheetCustom.cpp: Added. (WebCore::toJS): (WebCore::JSStyleSheet::toBoolean):
  • bindings/js/kjs_css.cpp: (KJS::): (KJS::DOMCSSStyleSheet::DOMCSSStyleSheet): (KJS::DOMCSSStyleSheet::getOwnPropertySlot):
  • bindings/js/kjs_css.h:
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/StyleSheet.idl:
  • page/DOMWindow.idl: Add new constructor.
9:28 PM Changeset in webkit [21872] by kevino
  • 4 edits in branches/wx-port-alpha/trunk

Use the wxGCDC bridge class to make it easier to support the new, modern platform graphics APIs where available, while still supporting the old APIs elsewhere.

8:58 PM Changeset in webkit [21871] by hyatt
  • 2 edits in trunk/WebCore

Make sure <embed> does not allow an end tag.

Reviewed by olliej

  • html/HTMLEmbedElement.h: (WebCore::HTMLEmbedElement::endTagRequirement):
7:46 PM Changeset in webkit [21870] by sfalken
  • 1 copy in tags/Safari-522.8.4b

New tag.

6:31 PM BuildingGdk edited by alp@atoker.com
Remove Bakefile instructions completely (diff)
6:28 PM BuildingGdk edited by alp@atoker.com
Update TODO (diff)
6:21 PM BuildingGdk edited by alp@atoker.com
(diff)
6:17 PM BuildingGdk edited by alp@atoker.com
Update to describe the gdk port qmake4 build (diff)
5:36 PM Changeset in webkit [21869] by adele
  • 7 edits in trunk

LayoutTests:

Reviewed by Brady.

Updated tests for <rdar://problem/5213039> REGRESSION: Wells Fargo registration page returns blank

  • fast/dom/HTMLInputElement/input-hidden-value-expected.txt:
  • fast/dom/HTMLInputElement/input-text-reset-expected.txt:
  • fast/dom/HTMLInputElement/input-text-reset.html:

WebCore:

Reviewed by Brady.

Fix for <rdar://problem/5213039> REGRESSION: Wells Fargo registration page returns blank

Roll out updated fix for 11866 that tried to make reset work for hidden inputs. Since
all browsers update the value attribute when setting the value, it doesn't really make sense to reset.
Its true that IE does support resetting these controls, but in this case, it doesn't really make sense to have
another place to store an alternate version of the value.

  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::reset):
  • html/HTMLInputElement.h:
4:52 PM Changeset in webkit [23427] by sfalken
  • 4 edits in branches/WindowsMerge/WebKitWin

Reviewed by Darin.


Removed setPageCacheSize/pageCacheSize from IWebBackForwardList.

  • Interfaces/IWebBackForwardList.idl: Removed unnecessary methods.
  • WebBackForwardList.cpp: Removed unnecessary methods.
  • WebBackForwardList.h: Removed unnecessary methods.
4:23 PM Changeset in webkit [21868] by darin
  • 5 edits in trunk

LayoutTests:

Reviewed by Anders.

  • updated results since I removed many cases of the innerHTML optimization
  • fast/dom/HTMLElement/set-inner-outer-optimization.html: Updated.

WebCore:

Reviewed by Anders.

  • removed the general case optimization for innerHTML because some sites rely on setting innerHTML to trigger loading plug-ins for example; we could consider bringing it back some day, perhaps with a list of element types to exclude
  • dom/CharacterData.cpp: (WebCore::CharacterData::setData): Do nothing if the old data is identical to the new data.
  • html/HTMLElement.cpp: (WebCore::replaceChildrenWithFragment): Remove childrenAreEqual optimization. (WebCore::replaceChildrenWithText): Remove optimization for cases where the text data is identical to the new data, since CharacterData handles that now. (WebCore::HTMLElement::setOuterHTML): Remove childrenAreEqual optimization.
4:07 PM Changeset in webkit [21867] by weinig
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adam Roben.

Cleanup function and fix to match comparison API.

  • kjs/string_object.cpp: (KJS::substituteBackreferences): (KJS::localeCompare):
3:56 PM Changeset in webkit [23426] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Added another failing test.
3:09 PM Changeset in webkit [21866] by hyatt
  • 1 edit in trunk/WebCore/html/HTMLHeadElement.cpp

Tweak my noscript fix to just always allow it inside the head.

2:49 PM Changeset in webkit [23425] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://4782915> plugin is not in the right place at jumble.com/play.html

Pass the plugin window coordinates for windowed plugins too.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::setNPWindowRect):
2:36 PM Changeset in webkit [21865] by weinig
  • 6 edits in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/forms/box-shadow-override-expected.checksum:
  • fast/forms/box-shadow-override-expected.png:

WebCore:

Reviewed by Maciej.

Covered by fast/forms/box-shadow-override.html

The search button draws a popup arrow depending on whether the
search menu template is set, rather than on the maximum number of recent
search strings.

  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSearchFieldResultsDecoration): Removed the call to -setMaxmiumRecents:. (WebCore::RenderThemeMac::paintSearchFieldResultsButton): Replaced calling -setMaximumRecents: with setting the search menu template. (WebCore::RenderThemeMac::search): Removed initialization of the menu. (WebCore::RenderThemeMac::searchMenuTemplate): Added. Returns an empty NSMenu to be used as the search menu template.
2:32 PM Changeset in webkit [21864] by hyatt
  • 5 edits in trunk/WebCore

Fix for bug 13907, <noscript> should be allowed inside <head> when
scripting is enabled.

Reviewed by aroben

  • html/HTMLHeadElement.cpp: (WebCore::HTMLHeadElement::checkDTD):
  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleError):
  • html/HTMLParserErrorCodes.cpp: (WebCore::htmlParserErrorMessageTemplate):
  • html/HTMLParserErrorCodes.h:
2:00 PM Changeset in webkit [21863] by zimmermann
  • 3 edits in branches/feature-branch/WebCore

Reviewed by Oliver.

Fix "jumpy" selection by correcting the way svgCharacterHitsPosition works.
I basically mixed up the "closest character to position" logic.

1:49 PM Changeset in webkit [23424] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

<rdar://problem/4761543> nike.com doesn't finish loading if Flash plugin is installed
<rdar://problem/5131528> play button on Flash in ESPN front page does not start movie


Make sure to call NPP_SetWindow right after creating the plugin, and not from the main loop. However,
the WMP plugin needs to have the plugin's window coordinates set correctly when calling NPP_SetWindow so add a
quirk for that.


  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::determineQuirks): (WebCore::PluginViewWin::init):
  • plugins/win/PluginViewWin.h: (WebCore::):
1:36 PM Changeset in webkit [23423] by weinig
  • 15 edits
    1 delete in branches/WindowsMerge

WebCoreWin:

Reviewed by Adam Roben.

  • Removes platform/win/NotImplemented.h because we have consolidated the notImplemented() for all platforms in platform/NotImplemented.h
  • Fixes remaining uses of old macro to use the new notImplemented() one.
  • WebCore.vcproj/WebCore.vcproj:
  • page/win/EventHandlerWin.cpp: (WebCore::EventHandler::passWidgetMouseDownEventToWidget):
  • platform/graphics/svg/cg/SVGResourceFilterCg.cpp: (WebCore::SVGResourceFilter::prepareFilter): (WebCore::SVGResourceFilter::applyFilter):
  • platform/graphics/svg/cg/SVGResourceMaskerCg.cpp: (WebCore::SVGResourceMasker::applyMask):
  • platform/win/GraphicsContextWin.cpp: (WebCore::contextForImage):
  • platform/win/NotImplemented.h: Removed.
  • platform/win/SearchPopupMenuWin.cpp: (WebCore::SearchPopupMenu::saveRecentSearches): (WebCore::SearchPopupMenu::loadRecentSearches):
  • platform/win/TemporaryLinkStubs.cpp: (Frame::print): (Frame::issueTransposeCommand): (GraphicsContextPlatformPrivate::clip): (WebCore::FrameView::updateBorder): (Widget::setIsSelected): (ScrollView::inWindow): (WebCore::focusRingColor): (WebCore::setFocusRingColorChangeFunction): (Frame::setNeedsReapplyStyles): (FrameLoader::overrideMediaType): (DocumentLoader::getResponseModifiedHeader): (ResourceHandle::willLoadFromCache): (WebCore::userIdleTime): (CachedPage::close): (WebCore::supportedKeySizes): (WebCore::signedPublicKeyAndChallengeString):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::newStream): (WebCore::PluginViewWin::write): (WebCore::PluginViewWin::setValue):

WebKitWin:

Reviewed by Adam Roben.

  • Removes platform/win/NotImplemented.h because we have consolidated the notImplemented() for all platforms in platform/NotImplemented.h
  • Fixes remaining uses of old macro to use the new notImplemented() one.
  • WebChromeClient.cpp: (WebChromeClient::createModalDialog): (WebChromeClient::canRunModal): (WebChromeClient::runModal): (WebChromeClient::setScrollbarsVisible): (WebChromeClient::scrollbarsVisible): (WebChromeClient::setMenubarVisible): (WebChromeClient::menubarVisible):
  • WebContextMenuClient.cpp: (WebContextMenuClient::lookUpInDictionary): (WebContextMenuClient::speak): (WebContextMenuClient::stopSpeaking):
  • WebDownload.cpp: (WebDownload::canResumeDownloadDecodedWithEncodingMIMEType): (WebDownload::cancelAuthenticationChallenge): (WebDownload::continueWithoutCredentialForAuthenticationChallenge): (WebDownload::useCredential): (WebDownload::didReceiveAuthenticationChallenge):
  • WebEditorClient.cpp: (WebEditorClient::spellCheckerDocumentTag): (WebEditorClient::shouldBeginEditing): (WebEditorClient::shouldEndEditing): (WebEditorClient::didBeginEditing): (WebEditorClient::respondToChangedContents): (WebEditorClient::respondToChangedSelection): (WebEditorClient::didEndEditing): (WebEditorClient::didWriteSelectionToPasteboard): (WebEditorClient::didSetSelectionTypesForPasteboard): (WebEditorClient::shouldDeleteRange): (WebEditorClient::shouldInsertNode): (WebEditorClient::shouldInsertText): (WebEditorClient::shouldApplyStyle): (WebEditorClient::shouldChangeTypingStyle): (WebEditorClient::webViewDidChangeTypingStyle): (WebEditorClient::webViewDidChangeSelection): (WebEditorClient::shouldShowDeleteInterface): (WebEditorClient::shouldChangeSelectedRange):
  • WebFrame.cpp: (WebFrame::makeRepresentation): (WebFrame::forceLayout): (WebFrame::forceLayoutForNonHTML): (WebFrame::setCopiesOnScroll): (WebFrame::detachedFromParent1): (WebFrame::detachedFromParent2): (WebFrame::detachedFromParent3): (WebFrame::detachedFromParent4): (WebFrame::loadedFromCachedPage): (WebFrame::dispatchDidLoadMainResource): (WebFrame::revertToProvisionalState): (WebFrame::clearUnarchivingState): (WebFrame::setMainFrameDocumentReady): (WebFrame::willChangeTitle): (WebFrame::didChangeTitle): (WebFrame::finalSetupForReplace): (WebFrame::setDefersLoading): (WebFrame::isArchiveLoadPending): (WebFrame::cancelPendingArchiveLoad): (WebFrame::clearArchivedResources): (WebFrame::canShowMIMEType): (WebFrame::representationExistsForURLScheme): (WebFrame::generatedMIMETypeForURLScheme): (WebFrame::restoreViewState): (WebFrame::provisionalLoadStarted): (WebFrame::shouldTreatURLAsSameAsCurrent): (WebFrame::addHistoryItemForFragmentScroll): (WebFrame::didFinishLoad): (WebFrame::prepareForDataSourceReplacement): (WebFrame::setDocumentViewFromCachedPage): (WebFrame::shouldGoToHistoryItem): (WebFrame::saveViewStateToItem): (WebFrame::saveDocumentViewToCachedPage): (WebFrame::canCachePage): (WebFrame::setMainDocumentError): (WebFrame::cannotShowURLError): (WebFrame::cannotShowMIMETypeError): (WebFrame::fileDoesNotExistError): (WebFrame::willUseArchive): (WebFrame::dispatchDidLoadResourceFromMemoryCache): (WebFrame::startDownload): (WebFrame::overrideMediaType): (WebFrame::addInspector): (WebFrame::removeInspector):
1:33 PM Changeset in webkit [21862] by weinig
  • 5 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/frames/removal-before-attach-crash-expected.txt: Added.
  • fast/frames/removal-before-attach-crash.html: Added.

WebCore:

Reviewed by Maciej.

Test: fast/frames/removal-before-attach-crash.html

Delayed the queueing of the post-attach callback until attach().

  • html/HTMLFrameElementBase.cpp: (WebCore::HTMLFrameElementBase::HTMLFrameElementBase): (WebCore::HTMLFrameElementBase::parseMappedAttribute): Replaced call to the HTMLElement implementation with a call to the HTMLFrameOwnerElement implementation, as the latter is the parent class. (WebCore::HTMLFrameElementBase::insertedIntoDocument): Instead of queueing the post-attach callback here, just set a flag telling us to do so at the beginning of attach(). (WebCore::HTMLFrameElementBase::removedFromDocument): Reset the above flag. (WebCore::HTMLFrameElementBase::attach): If this is the first attach() after being inserted into the document, queue a post-attach callback to load the frame. (WebCore::HTMLFrameElementBase::willRemove): Changed to call up to the correct parent class. (WebCore::HTMLFrameElementBase::setFocus): Ditto.
  • html/HTMLFrameElementBase.h:
  • html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::mapToEntry): Replaced call to the HTMLElement implementation with a call to the HTMLFrameOwnerElement implementation, as the latter is the parent class. (WebCore::HTMLPlugInElement::parseMappedAttribute): Ditto. (WebCore::HTMLPlugInElement::checkDTD): Ditto. (WebCore::HTMLPlugInElement::detach): Ditto.
12:39 PM Changeset in webkit [21861] by darin
  • 14 edits
    2 adds in trunk

LayoutTests:

Reviewed by Maciej.

  • fast/dom/HTMLElement/set-inner-outer-optimization-expected.txt: Added.
  • fast/dom/HTMLElement/set-inner-outer-optimization.html: Added.
  • editing/execCommand/copy-without-selection.html: Added missing preventDefault calls to prevent this from being a double-paste test.
  • fast/css/first-letter-detach-expected.checksum: Updated.
  • fast/css/first-letter-detach-expected.png: Updated.
  • fast/css/first-letter-detach-expected.txt: Updated.
  • fast/css/first-letter-detach.html: Updated to test three different ways of setting the text of the first-letter element; setInnerHTML and two other ways.
  • fast/events/updateLayoutForHitTest-expected.txt: Updated result that changed slightly due to setInnerHTML improvement.
  • fast/forms/textarea-setinnerhtml-expected.txt: Ditto.

WebCore:

Reviewed by Maciej.

  • fix first-letter when the text of the affected text node is changed

Optimize setInnerHTML, setOuterHTML, and setInnerText so they don't change the DOM at all
if they don't need to.

Test: fast/dom/HTMLElement/set-inner-outer-optimization.html
Test: fast/css/first-letter-detach.html

  • html/HTMLElement.cpp: (WebCore::equal): Added. Helper function that compares two Text nodes or two NamedAttrMap attribute maps. (WebCore::shallowEqual): Added. Helper function that compares two Element nodes or two arbitrary nodes. (WebCore::childrenAreEqual): Added. Helper functions that compare children of nodes. (WebCore::hasOneChild): Added. Helper function. (WebCore::hasOneTextChild): Added. Helper function. (WebCore::replaceChildrenWithFragment): Added. Helper function used by setInnerHTML and setInnerText. Optimizes the cases where all the nodes are the same, where both the current and the new content are single text nodes, and where the current content is a single node that can be replaced with replaceChild. (WebCore::replaceChildrenWithText): Added. Helper function used by setInnerText. Optimizes the case where the current content is a single text node or a single node that can be replaced with replaceChild. (WebCore::HTMLElement::setInnerHTML): Changed to call replaceChildrenWithFragment. (WebCore::HTMLElement::setOuterHTML): Added special case to optimize when the new content exactly matches the current node. (WebCore::HTMLElement::setInnerText): Changed to call replaceChildrenWithText in a few cases instead of doing removeChildren/appendChild. Changed code that was using DeprecatedString to instead use String. Changed general case to use a document fragment and replaceChildrenWithFragment.
  • dom/CharacterData.cpp: (WebCore::CharacterData::dispatchModifiedEvent): Fixed bug where we would not dispatch the DOMSubtreeModified event unless someone was registered for the DOMCharacterDataModified event. Caused trouble in the test.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter): Set first-letter after the setStyle call so calls to setTextInternal inside setStyle don't clear it.
  • rendering/RenderText.h: Made setTextInternal virtual so that RenderTextFragment can do appropriate work when the text changes.
  • rendering/RenderTextFragment.h: Added an override of setTextInternal. Removed the firstLetter parameter to the constructor and made it a separate setter. Also changed m_generatedContentStr to m_contentString to match the getter function.
  • rendering/RenderTextFragment.cpp: (WebCore::RenderTextFragment::RenderTextFragment): Removed firstLetter parameter. (WebCore::RenderTextFragment::setTextInternal): When the text changes, destroy the first-letter node and reset the fragment values so that RenderBlock::updateFirstLetter, which will run during layout, will create a new first-letter child. Otherwise we end up with the first letter of the old text.
11:53 AM Changeset in webkit [21860] by weinig
  • 2 edits in trunk/WebCore

Fix Qt build.

  • platform/NotImplemented.h:
11:46 AM Changeset in webkit [23422] by aroben
  • 2 edits in branches/WindowsMerge/LayoutTests
  • win/Skipped: Removed some fixed tests, and added some failing ones.
11:41 AM Changeset in webkit [21859] by ddkilzer
  • 2 edits in trunk/WebKitTools

2007-05-29 David Kilzer <​ddkilzer@webkit.org>

Reviewed by Darin.

  • Scripts/run-pageloadtest: Grab $testName from the command-line if it is present, otherwise default to "svg". Added dummy check to make sure $testName.pltsuite exists.
11:37 AM Changeset in webkit [21858] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

Consolidate platform dependent notImplemented() macros
into one platform independent macro that uses WTFLog.

  • platform/NotImplemented.h:
11:30 AM Changeset in webkit [21857] by ddkilzer
  • 3 edits in trunk/WebKitTools

2007-05-29 David Kilzer <​ddkilzer@webkit.org>

Reviewed by Darin.

This patch also fixes an instance of the "broken pipe" warning that happened when
a directory contained modified files that were not part of an applied or unapplied
patch.

  • Scripts/svn-apply: (svnStatus($)): If we're trying to get status on a directory (instead of a file), make sure we actually get the directory's status (if it has one), not the first file's status reported within the directory. Fix "broken pipe" warnings by reading all of the output from the SVN filehandle before closing it.
  • Scripts/svn-unapply: (svnStatus($)): Ditto.
10:41 AM Changeset in webkit [21856] by darin
  • 11 edits in trunk/WebCore

Reviewed by Sam.

  • a clean-up pass on form-related aspects of the recent JSHTMLElement patch
  • bindings/js/JSHTMLElementCustom.cpp: (WebCore::JSHTMLElement::pushEventHandlerScope): Replace the call to formForEventHandlerScope() with a call to the new form() function. And removed the now-uneeded code to search for a form ancestor.
  • html/HTMLElement.h: Added a general-purpose form() function. The intent is to return the form ancestor if any, but return the associated form for a form control, which isn't always an ancestor of the control. To keep form() efficient for form controls, it's an inline that calls a virtual, allowing a derived class to override it with an inline. This replaces formForEventHandlerScope(). Also added findFormAncestor() to use here and to replace the multiple loops found elsewhere to search for the nearest form ancestor.
  • html/HTMLElement.cpp: (WebCore::HTMLElement::findFormAncestor): Added. (WebCore::HTMLElement::virtualForm): Added. Calls findFormAncestor().
  • html/HTMLGenericFormElement.h: Suggested name change to HTMLFormControlElement. Removed the confusing getForm() function, which is superceded by findFormAncestor. Removed the unused onSelect() function. Removed the override of formForEventHandlerScope(), replacing it with an override of virtualForm().
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::HTMLGenericFormElement): Use findFormAncestor instead of getForm. (WebCore::HTMLGenericFormElement::insertedIntoTree): Ditto. (WebCore::HTMLGenericFormElement::virtualForm): Added.
  • html/HTMLLabelElement.h: Removed now-unneeded form() and formForEventHandlerScope() functions, since base class behavior is now good enough. Renamed formElement() to correspondingControl(), since that's the terminology used elsewhere in the code, and the old name was unnecessarily confusing.
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::correspondingControl): Renamed. Removed unnecessary special case for empty ID, since getElementById already returns 0 for that case. (WebCore::HTMLLabelElement::setActive): Updated for name change. (WebCore::HTMLLabelElement::setHovered): Ditto. (WebCore::HTMLLabelElement::defaultEventHandler): Ditto. (WebCore::HTMLLabelElement::focus): Ditto. (WebCore::HTMLLabelElement::accessKeyAction): Ditto.
  • html/HTMLObjectElement.h: Removed now-unneeded form() and formForEventHandlerScope() functions, since base class behavior is now good enough. Also removed forward declaration of KJS::Bindings::Instance -- since the type is the return value of a function from the base class, it's guaranteed to be declared in the base class header.
  • html/HTMLObjectElement.cpp: Ditto.
  • bridge/mac/WebCoreAXObject.mm: (labelForElement): Updated for name change.
9:01 AM Changeset in webkit [23421] by andersca
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.


8:36 AM Changeset in webkit [23420] by andersca
  • 3 edits in branches/WindowsMerge/WebCore

Reviewed by Adam.

Port code from open source changeset 21808, fixing
​http://bugs.webkit.org/show_bug.cgi?id=13871


8:30 AM Changeset in webkit [23419] by adachan
  • 2 edits in branches/WindowsMerge/WebCore

2007-05-29 Ada Chan <​adachan@apple.com>

Build fix.

  • Added "$(ProjectDir)..\platform\win" to include paths
  • Added WebCore\bindings\js\JSCSSStyleDeclarationCustom.cpp to project
  • WebCore.vcproj/WebCore.vcproj:
7:26 AM Changeset in webkit [21855] by zack
  • 2 edits in trunk/WebCore

Making the convenience method notImplemented convenient
for the Qt port.

Reviewed by George and Niko

May 28, 2007:

9:49 PM Changeset in webkit [21854] by weinig
  • 9 edits
    1 add in trunk/WebCore

Reviewed by Geoff.

  • WebCore.pro:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCSSStyleDeclarationCustom.cpp: Added. (WebCore::cssPropertyName): (WebCore::isCSSPropertyName): (WebCore::JSCSSStyleDeclaration::canGetItemsForName): (WebCore::JSCSSStyleDeclaration::nameGetter): (WebCore::JSCSSStyleDeclaration::customPut):
  • bindings/js/kjs_binding.h:
  • bindings/js/kjs_css.cpp:
  • bindings/js/kjs_css.h:
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • css/CSSStyleDeclaration.idl:
9:22 PM Changeset in webkit [21853] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebKit/wx/WebKitSupport/EditorClientWx.cpp

Navigation and special keys still send EVT_CHAR events, so make sure we don't call insertText for common navigation keys.

6:24 PM Changeset in webkit [21852] by kevino
  • 2 edits in branches/wx-port-alpha/trunk/WebCore/platform/graphics

Workaround for the issue that there's no wx API for saving/restoring the clip region for the older wxDC APIs.

6:06 PM Changeset in webkit [21851] by kevino
  • 4 edits in branches/wx-port-alpha/trunk

Only call insertText on wxEVT_CHAR events, this fixes problems with all-uppercase text on Win/Linux, and also, use execCommand("InsertLineBreak") instead of the insertLineBreak() function so that the return key will always be properly handled.

1:48 PM Changeset in webkit [21850] by ddkilzer
  • 2 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Darin.

Switched method used to find list of changed files from "diff" to "status". This
makes added and replaced files with history appear in the changed file list for svn.
Added check for "+" in output from the svn status command to detect file history, and
handle it in the generateFileList(\@\@\%) and in statusDescription($$) subroutines.

  • Scripts/prepare-ChangeLog: (diffCommand(@)): Switched argument from hash ref to array to match statusCommand(@). (statusCommand(@)): Switched argument from array ref to array. Necessary to use the output of "keys $paths" without creating a temporary array variable. (findOriginalFileFromSvn($)): Added. Based on findSourceFileAndRevision($) subroutine in svn-create-patch. (generateFileList(\@\@\%)): Added. Extracted from main body of script. Runs status command using command-line arguments instead of list of changed files from the diff command. Changed svn regex to only accept file statuses that we know how to handle. Identify original file when an added/replaced status with history is present. (statusDescription($$)): Handled added/replaced statuses with history. Added fall-through return statement.
1:45 PM Changeset in webkit [21849] by kevino
  • 2 edits in branches/wx-port-alpha/trunk

Make using wxGraphicsContext an option in the build script, rather than hardcoding it.

1:36 PM Changeset in webkit [23418] by weinig
  • 2 edits in branches/WindowsMerge/WebCore

Build fix.

  • WebCore.vcproj/WebCore.vcproj:
1:18 PM Changeset in webkit [21848] by weinig
  • 4 edits
    12 adds in trunk/WebKitTools

Reviewed by Mark Rowe.

Add scripts and data to generate a coverage data for WebKit.

  • CodeCoverage/README: Added.
  • CodeCoverage/amber.png: Added.
  • CodeCoverage/cov.py: Added.
  • CodeCoverage/emerald.png: Added.
  • CodeCoverage/gcov.css: Added.
  • CodeCoverage/glass.png: Added.
  • CodeCoverage/regenerate-coverage-display: Added.
  • CodeCoverage/ruby.png: Added.
  • CodeCoverage/run-generate-coverage-data: Added.
  • CodeCoverage/snow.png: Added.
  • Scripts/build-webkit: Add --coverage by Niko
  • Scripts/check-for-global-initializers: Skip the check on coverage builds
  • Scripts/generate-coverage-data: Added.
  • Scripts/run-javascriptcore-tests: Add --coverage by Niko
1:15 PM Changeset in webkit [21847] by weinig
  • 4 edits
    4 adds in trunk

LayoutTests:

Reviewed by Darin.

  • fast/forms/select-display-none-style-resolve-expected.checksum: Added.
  • fast/forms/select-display-none-style-resolve-expected.png: Added.
  • fast/forms/select-display-none-style-resolve-expected.txt: Added.
  • fast/forms/select-display-none-style-resolve.html: Added.

WebCore:

Reviewed by Darin.

Test: fast/forms/select-display-none-style-resolve.html

  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::attach): Do not compute style if the parent does not have style.
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::attach): Ditto.
1:12 PM Changeset in webkit [21846] by bdash
  • 1 edit in tags/Safari-5522.8.1/WebKit/Configurations/Version.xcconfig

Versioning.

1:10 PM Changeset in webkit [21845] by bdash
  • 1 copy in tags/Safari-5522.8.1

New tag.

1:08 PM Changeset in webkit [21844] by bdash
  • 6 edits in branches/Safari-5522/WebKit

Merge r21840.

12:55 PM Changeset in webkit [21843] by weinig
  • 2 edits in trunk/WebCore

Fix Gdk and Qt builds.

  • WebCore.pro:
12:38 PM Changeset in webkit [21842] by weinig
  • 78 edits
    1 add in trunk

LayoutTests:

Reviewed by Darin.

Update tests for ​http://bugs.webkit.org/show_bug.cgi?id=13894
Remove the legacy class KJS::JSHTMLElement

  • Corrects prototype chain for all HTMLElement subclasses which now only have one HTMLElement prototype and not two.
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/prototype-chain-expected.txt:

WebCore:

Reviewed by Darin.

Patch for ​http://bugs.webkit.org/show_bug.cgi?id=13894
Remove the legacy class KJS::JSHTMLElement

  • Now that all of the subclasses of JSHTMLElement are autogenerated and no longer rely on the legacy parent, we can remove it and update all the HTML idl files to reflect so.
  • Also adds JSHTMLBlockquoteElement's JS constructor which was mistakingly missing.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSHTMLAnchorElementCustom.cpp: (WebCore::JSHTMLAnchorElement::toString):
  • bindings/js/JSHTMLElementCustom.cpp: Added. (WebCore::JSHTMLElement::pushEventHandlerScope):
  • bindings/js/JSHTMLElementWrapperFactory.cpp: (WebCore::createJSHTMLWrapper):
  • bindings/js/JSHTMLInputElementBase.cpp: (WebCore::): (WebCore::JSHTMLInputElementBase::JSHTMLInputElementBase): (WebCore::JSHTMLInputElementBase::getOwnPropertySlot): (WebCore::JSHTMLInputElementBase::put):
  • bindings/js/JSHTMLInputElementBase.h:
  • bindings/js/JSHTMLSelectElementCustom.cpp:
  • bindings/js/kjs_html.cpp: (KJS::runtimeObjectCustomGetOwnPropertySlot):
  • bindings/js/kjs_html.h:
  • bindings/scripts/CodeGeneratorJS.pm:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLAreaElement.idl:
  • html/HTMLBRElement.idl:
  • html/HTMLBaseElement.idl:
  • html/HTMLBaseFontElement.idl:
  • html/HTMLBlockquoteElement.idl:
  • html/HTMLBodyElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLDListElement.idl:
  • html/HTMLDirectoryElement.idl:
  • html/HTMLDivElement.idl:
  • html/HTMLElement.cpp: (WebCore::HTMLElement::formForEventHandlerScope):
  • html/HTMLElement.h:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLFontElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLFrameSetElement.idl:
  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::formForEventHandlerScope):
  • html/HTMLGenericFormElement.h:
  • html/HTMLHRElement.idl:
  • html/HTMLHeadElement.idl:
  • html/HTMLHeadingElement.idl:
  • html/HTMLHtmlElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLImageElement.idl:
  • html/HTMLIsIndexElement.idl:
  • html/HTMLLIElement.idl:
  • html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::form): (WebCore::HTMLLabelElement::formForEventHandlerScope):
  • html/HTMLLabelElement.h:
  • html/HTMLLabelElement.idl:
  • html/HTMLLegendElement.idl:
  • html/HTMLLinkElement.idl:
  • html/HTMLMapElement.idl:
  • html/HTMLMarqueeElement.idl:
  • html/HTMLMenuElement.idl:
  • html/HTMLMetaElement.idl:
  • html/HTMLModElement.idl:
  • html/HTMLOListElement.idl:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::formForEventHandlerScope):
  • html/HTMLObjectElement.h:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptGroupElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLParagraphElement.idl:
  • html/HTMLParamElement.idl:
  • html/HTMLPreElement.idl:
  • html/HTMLQuoteElement.idl:
  • html/HTMLScriptElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLStyleElement.idl:
  • html/HTMLTableCaptionElement.idl:
  • html/HTMLTableCellElement.idl:
  • html/HTMLTableColElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLTitleElement.idl:
  • html/HTMLUListElement.idl:
  • page/DOMWindow.idl:
12:37 PM Changeset in webkit [21841] by ggaren
  • 2 edits in trunk/JavaScriptCore

Slight clarification to an exception message.

  • API/JSCallbackObject.cpp: (KJS::JSCallbackObject::put):
12:29 PM Changeset in webkit [21840] by bdash
  • 6 edits in trunk/WebKit

2007-05-29 Mark Rowe <​mrowe@apple.com>

Reviewed by Geoff.

64-bit build fix. Ensure that use of WebNSUInteger in headers is matched by WebNSUInteger in implementations.

  • DefaultDelegates/WebScriptDebugServer.h:
  • DefaultDelegates/WebScriptDebugServer.m: (-[WebScriptDebugServer webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]): (-[WebScriptDebugServer webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
  • DefaultDelegates/WebScriptDebugServerPrivate.h:
  • History/WebBackForwardList.mm: (-[WebBackForwardList setPageCacheSize:]): (-[WebBackForwardList pageCacheSize]):
  • WebView/WebView.mm: (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
11:47 AM Changeset in webkit [21839] by bdash
  • 2 edits in trunk/WebKitTools

2007-05-29 Mark Rowe <​mrowe@apple.com>

Build fix after r21745.

  • Scripts/check-for-global-initializers: Skip CachedPage.o as it now has a global initializer in debug builds.
10:55 AM Changeset in webkit [21838] by kevino
  • 1 edit in branches/wx-port-alpha/trunk/WebCore/platform/wx/RenderThemeWx.cpp

Use wxAutoBufferedPaintDC with theme controls too.

8:13 AM Changeset in webkit [21837] by bdash
  • 1 copy in branches/Safari-5522

New branch.

6:53 AM Changeset in webkit [21836] by zack
  • 7 edits
    2 adds in trunk

Implementing public settings Api for the Qt port.

Adds value based QWebSettings object which is settable on
a QWebPage. Done after discussions with Lars and Simon.

r=andersca,simon

6:15 AM Changeset in webkit [21835] by ddkilzer
  • 2 edits
    15 moves in trunk

LayoutTestResults:

Reviewed by NOBODY (newly passing tests).

​http://bugs.webkit.org/show_bug.cgi?id=13793
RULES=groups overridden by border, colgroup=span not honored by border collapsing

Moved three now-passing tests from tables/mozilla_expected_failures to tables/mozilla.

  • qt/tables/mozilla/marvin/colgroup_width_pct-expected.txt: Copied from qt/tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.txt.
  • qt/tables/mozilla/marvin/colgroup_width_px-expected.txt: Copied from qt/tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.txt.
  • qt/tables/mozilla/marvin/x_colgroup_width_pct-expected.txt: Copied from qt/tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.txt.
  • qt/tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.txt: Removed.
  • qt/tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.txt: Removed.
  • qt/tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.txt: Removed.

LayoutTests:

Reviewed by NOBODY (newly passing tests).

​http://bugs.webkit.org/show_bug.cgi?id=13793
RULES=groups overridden by border, colgroup=span not honored by border collapsing

Moved three now-passing tests from tables/mozilla_expected_failures to tables/mozilla.

  • tables/mozilla/marvin/colgroup_width_pct-expected.checksum: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.checksum.
  • tables/mozilla/marvin/colgroup_width_pct-expected.png: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.png.
  • tables/mozilla/marvin/colgroup_width_pct-expected.txt: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.txt.
  • tables/mozilla/marvin/colgroup_width_pct.html: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_pct.html.
  • tables/mozilla/marvin/colgroup_width_px-expected.checksum: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.checksum.
  • tables/mozilla/marvin/colgroup_width_px-expected.png: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.png.
  • tables/mozilla/marvin/colgroup_width_px-expected.txt: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.txt.
  • tables/mozilla/marvin/colgroup_width_px.html: Copied from tables/mozilla_expected_failures/marvin/colgroup_width_px.html.
  • tables/mozilla/marvin/x_colgroup_width_pct-expected.checksum: Copied from tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.checksum.
  • tables/mozilla/marvin/x_colgroup_width_pct-expected.png: Copied from tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.png.
  • tables/mozilla/marvin/x_colgroup_width_pct-expected.txt: Copied from tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.txt.
  • tables/mozilla/marvin/x_colgroup_width_pct.xml: Copied from tables/mozilla_expected_failures/marvin/x_colgroup_width_pct.xml.
  • tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.checksum: Removed.
  • tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.png: Removed.
  • tables/mozilla_expected_failures/marvin/colgroup_width_pct-expected.txt: Removed.
  • tables/mozilla_expected_failures/marvin/colgroup_width_pct.html: Removed.
  • tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.checksum: Removed.
  • tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.png: Removed.
  • tables/mozilla_expected_failures/marvin/colgroup_width_px-expected.txt: Removed.
  • tables/mozilla_expected_failures/marvin/colgroup_width_px.html: Removed.
  • tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.checksum: Removed.
  • tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.png: Removed.
  • tables/mozilla_expected_failures/marvin/x_colgroup_width_pct-expected.txt: Removed.
  • tables/mozilla_expected_failures/marvin/x_colgroup_width_pct.xml: Removed.
Note: See TracTimeline for information about the timeline view.