Context Navigation

← Previous Period
Next Period →

Timeline

Jun 27, 2007:

11:53 PM Changeset in webkit [23846] by kmccullo

4 edits
3 adds in trunk

JavaScriptCore:

Reviewed by Darin.

<rdar://problem/5271937> REGRESSION: Apparent WebKit JavaScript memory smasher when submitting comment to iWeb site (crashes in kjs_pcre_compile2)
Correctly evaluate the return value of _pcre_ucp_findchar.

pcre/pcre_compile.c: (compile_branch):
pcre/pcre_exec.c: (match):

LayoutTests:

Reviewed by Darin.

<rdar://problem/5271937> REGRESSION: Apparent WebKit JavaScript memory smasher when submitting comment to iWeb site (crashes in kjs_pcre_compile2)
Correctly evaluate the return value of _pcre_ucp_findchar.

fast/js/regexp-unicode-overflow-expected.txt: Added.
fast/js/regexp-unicode-overflow.html: Added.
fast/js/resources/regexp-unicode-overflow.js: Added.

11:18 PM Changeset in webkit [23845] by bdash

2 edits in trunk/WebCore

2007-06-20 Matt Perry <mpComplete@gmail.com>

Reviewed by Adam.

Fix http://bugs.webkit.org/show_bug.cgi?id=14251: onchange handler for select controls doesn't fire when changing via keyboard

html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Got rid of a call to saveLastSelection in the "Enter" key handler for select controls that was preventing onchange from firing.

11:01 PM Changeset in webkit [23844] by weinig

1 edit in trunk/WebCore/page/DOMSelection.cpp

Yet another build fix :(

10:32 PM Changeset in webkit [23843] by weinig

3 edits in trunk/WebCore

Fix Gdk, Qt, and Win32 builds.

WebCore.pro:
WebCore.vcproj/WebCore.vcproj:

10:25 PM Changeset in webkit [23842] by weinig

12 edits
3 adds in trunk

LayoutTests:

Reviewed by Geoff.

Update tests for http://bugs.webkit.org/show_bug.cgi?id=14319
Move the Selection object out of the JS bindings

fast/dom/Window/window-properties-expected.txt:
fast/js/toString-and-valueOf-override-expected.txt:
http/tests/security/cross-frame-access-expected.txt:

WebCore:

Reviewed by Geoff.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14319
Move the Selection object out of the JS bindings

Renames JS Object Selection to DOMSelection to avoid a name conflict.

DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::Window::mark): (KJS::Window::clearHelperObjectProperties): (KJS::WindowFunc::callAsFunction): (KJS::Window::disconnectFrame):
bindings/js/kjs_window.h: (KJS::Window::):
page/DOMSelection.cpp: Added. (WebCore::DOMSelection::DOMSelection): (WebCore::DOMSelection::frame): (WebCore::DOMSelection::disconnectFrame): (WebCore::DOMSelection::anchorNode): (WebCore::DOMSelection::baseNode): (WebCore::DOMSelection::anchorOffset): (WebCore::DOMSelection::baseOffset): (WebCore::DOMSelection::focusNode): (WebCore::DOMSelection::extentNode): (WebCore::DOMSelection::focusOffset): (WebCore::DOMSelection::extentOffset): (WebCore::DOMSelection::isCollapsed): (WebCore::DOMSelection::type): (WebCore::DOMSelection::rangeCount): (WebCore::DOMSelection::collapse): (WebCore::DOMSelection::collapseToEnd): (WebCore::DOMSelection::collapseToStart): (WebCore::DOMSelection::empty): (WebCore::DOMSelection::setBaseAndExtent): (WebCore::DOMSelection::setPosition): (WebCore::DOMSelection::modify): (WebCore::DOMSelection::getRangeAt): (WebCore::DOMSelection::removeAllRanges): (WebCore::DOMSelection::addRange): (WebCore::DOMSelection::toString):
page/DOMSelection.h: Added.
page/DOMSelection.idl: Added.
page/DOMWindow.cpp: (WebCore::DOMWindow::disconnectFrame): (WebCore::DOMWindow::getSelection):
page/DOMWindow.h:
page/DOMWindow.idl:

8:34 PM Changeset in webkit [23841] by weinig

5 edits in trunk/WebCore

Reviewed by Maciej.

2nd patch for http://bugs.webkit.org/show_bug.cgi?id=14111
Autogenerate Event JS binding

Cleanup kjs_events

bindings/js/kjs_events.cpp: (WebCore::JSAbstractEventListener::JSAbstractEventListener): (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSAbstractEventListener::isHTMLEventListener): (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener): (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener): (WebCore::JSUnprotectedEventListener::listenerObj): (WebCore::JSUnprotectedEventListener::windowObj): (WebCore::JSUnprotectedEventListener::clearWindowObj): (WebCore::JSUnprotectedEventListener::mark): (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::~JSEventListener): (WebCore::JSEventListener::listenerObj): (WebCore::JSEventListener::windowObj): (WebCore::JSEventListener::clearWindowObj): (WebCore::JSLazyEventListener::JSLazyEventListener): (WebCore::JSLazyEventListener::listenerObj): (WebCore::JSLazyEventListener::parseCode): (WebCore::getNodeEventListener): (WebCore::JSClipboard::JSClipboard): (WebCore::JSClipboard::getValueProperty): (WebCore::JSClipboard::putValueProperty): (WebCore::JSClipboardPrototypeFunction::callAsFunction): (WebCore::toJS): (WebCore::toClipboard):
bindings/js/kjs_events.h: (WebCore::JSClipboard::classInfo): (WebCore::JSClipboard::impl):
bindings/js/kjs_window.h:
ksvg2/events/JSSVGLazyEventListener.h:

8:19 PM Changeset in webkit [23840] by weinig

7 edits
8 adds in trunk

LayoutTests:

Reviewed by Adam Roben.

Tests for http://bugs.webkit.org/show_bug.cgi?id=12045
Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
<rdar://problem/5286670>

fast/forms/thumbslider-crash-expected.checksum: Added.
fast/forms/thumbslider-crash-expected.png: Added.
fast/forms/thumbslider-crash-expected.txt: Added.
fast/forms/thumbslider-crash.html: Added.
fast/forms/thumbslider-no-parent-slider-expected.checksum: Added.
fast/forms/thumbslider-no-parent-slider-expected.png: Added.
fast/forms/thumbslider-no-parent-slider-expected.txt: Added.
fast/forms/thumbslider-no-parent-slider.html: Added.

WebCore:

Reviewed by Adam Roben.

Patch for http://bugs.webkit.org/show_bug.cgi?id=12045
Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
<rdar://problem/5286670>

Test: fast/forms/thumbslider-no-parent-slider.html
Test: fast/forms/thumbslider-crash.html

rendering/RenderObject.h: (WebCore::RenderObject::isSlider):
rendering/RenderSlider.h: (WebCore::RenderSlider::isSlider):
rendering/RenderTheme.cpp: (WebCore::RenderTheme::paint): Only paint thumbslider if the parent renderer is a RenderSlider.
rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintSliderThumb):
rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::paintSliderThumb):

6:50 PM Changeset in webkit [23839] by staikos

1 edit in trunk/WebKitQt/QtLauncher/main.cpp

Missed this file as part of #23832

6:36 PM Changeset in webkit [23838] by staikos

2 edits in trunk/WebCore

Make Qt builds link when XSLT is disabled

5:23 PM Changeset in webkit [23837] by sfalken

2 edits in trunk/WebCore

Turn on static code analysis (Windows only).

Affects only folks that have Visual Studio Team Suite installed,
or who have replaced their compiler with the version shipping in the
Vista SDK.

Reviewed by Oliver.

WebCore.vcproj/WebCore.vcproj:

5:04 PM Changeset in webkit [23836] by staikos

2 edits in trunk/WebCore

Remove files that no longer exist (were commented out)

4:14 PM Changeset in webkit [23835] by staikos

5 edits in trunk/WebCore

revert IDL change until the code generator is fixed

4:08 PM Changeset in webkit [23834] by justing

10 edits
4 adds in trunk

LayoutTests:

Reviewed by John.

<rdar://problem/5247341> REGRESSION: Pasting sometimes loses trailing newline

Demonstrates the bug:

editing/pasteboard/5247341-expected.checksum: Added.
editing/pasteboard/5247341-expected.png: Added.
editing/pasteboard/5247341-expected.txt: Added.
editing/pasteboard/5247341.html: Added.

The changes in this patch exposed three bugs (5296964, 5296977, and 5299425).
Added FIXMES for them. Also removed tabs in them:

editing/pasteboard/paste-table-003-expected.checksum:
editing/pasteboard/paste-table-003-expected.png:
editing/pasteboard/paste-table-003-expected.txt:
editing/pasteboard/paste-table-003.html:
fast/forms/textarea-paste-newline.html:

Equivalent trees:

editing/pasteboard/paste-text-016-expected.txt:
editing/pasteboard/paste-text-017-expected.txt:

WebCore:

Reviewed by John.

<rdar://problem/5247341> REGRESSION: Pasting sometimes leaves out trailing newline

Pasting with a trailing interchange newline doesn't work when pasting
into an empty line. Code that handles removing brs at the insertion
position tries to also handle trailing interchange newlines by re-using
those brs and fails. Removed that code and handle all interchange
newlines with code later in doApply().

editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::doApply): Don't try to re-use the endBR when there's a trailing interchange newline.

3:21 PM Changeset in webkit [23833] by staikos

5 edits in trunk/WebCore

Use the proper macros so that it builds with !SVG and !XPATH

3:06 PM Changeset in webkit [23832] by staikos

6 edits in trunk/WebKitQt

Fix compilation with various Qt configurations

3:05 PM Changeset in webkit [23831] by sfalken

1 edit in trunk/WebKit/win/ChangeLog

Fix ChangeLog.

3:01 PM Changeset in webkit [23830] by sfalken

3 edits
1 add in trunk/WebKit/win

Turn on static code analysis.

Reviewed by Oliver.

Effects only folks that have Visual Studio Team Suite installed,
or who have replaced their compiler with the version shipping in the
Vista SDK.

CodeAnalysisConfig.h: Added.
WebKit.vcproj/WebKit.vcproj:
WebLocalizableStrings.cpp: (createWebKitBundle):

2:55 PM Changeset in webkit [23829] by sfalken

3 edits in trunk/WebKit/win

Prefast: Remove variable redefinitions in inner scopes.

Reviewed by Ada.

WebDownload.cpp: (WebDownload::didFinish):
WebNotificationCenter.cpp: (WebNotificationCenter::postNotificationInternal): (WebNotificationCenter::removeObserver):

2:28 PM Changeset in webkit [23828] by sfalken

2 edits in trunk/WebKit/win

Remove SEH block from around history plist read, since the underlying bug has been fixed.

Reviewed by Darin.

WebHistory.cpp: (createHistoryListFromStream):

2:27 PM Changeset in webkit [23827] by andersca

4 edits in trunk/WebCore

Reviewed by Oliver.

<rdar://problem/5253950>
When Shockwave plugin has been loaded, exiting crashes Safari

Add a "load count" for plugin packages. When the load count is zero, unload the plugin.

plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackageWin::PluginPackageWin): (WebCore::PluginPackageWin::load): (WebCore::PluginPackageWin::unload): (WebCore::PluginPackageWin::unloadWithoutShutdown):
plugins/win/PluginPackageWin.h:

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::~PluginViewWin): Make sure to unload the plugin package and clear any references to plugin script objects.

1:45 PM Changeset in webkit [23826] by staikos

2 edits in trunk/WebCore

We were compiling purely out of luck, but if qmake sets up the build order
slightly differently it fails. This forces a dependency to generate HTMLNames.h
in time.

1:13 PM Changeset in webkit [23825] by staikos

2 edits in trunk/WebKitQt

Patch from Eli Fidler to compile when QT_NO_IMAGE_TEXT is defined.

1:06 PM Changeset in webkit [23824] by staikos

2 edits in trunk/WebKitQt

Patch from Eli Fidler to remove QT3_SUPPORT dependency in ICO handler.

1:04 PM Changeset in webkit [23823] by justing

3 edits
8 adds in trunk

LayoutTests:

Reviewed by John.

<rdar://problem/4580583> Breaking blockquoted list should not automatically renumber the second list

Splits a quoted list w/o splitting a list item:

editing/execCommand/4580583-1-expected.checksum: Added.
editing/execCommand/4580583-1-expected.png: Added.
editing/execCommand/4580583-1-expected.txt: Added.
editing/execCommand/4580583-1.html: Added.

Split a quoted list item:

editing/execCommand/4580583-2-expected.checksum: Added.
editing/execCommand/4580583-2-expected.png: Added.
editing/execCommand/4580583-2-expected.txt: Added.
editing/execCommand/4580583-2.html: Added.

WebCore:

Reviewed by John.

<rdar://problem/4580583> Breaking blockquoted list should not automatically renumber the second list

When a quoted numbered list is broken in half, it's cloned
to make the second list. That second list needs its start attribute
set so that the numbers of the list items in it will be preserved.

editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): Set the start attribute of a cloned list to be the original number of the first list item in it.

10:28 AM Changeset in webkit [23822] by sfalken

2 edits in trunk/WebKit/win

Prefast: Fix misplaced parenthesis.

Reviewed by Darin.

WebView.cpp: (core):

10:21 AM Changeset in webkit [23821] by ap

2 edits in trunk/WebCore

Reviewed by Geoff.

http://bugs.webkit.org/show_bug.cgi?id=14413
GIF animation throttling is different from MSIE

platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::frameDurationAtIndex): Change the cut-off value to 50ms to match MSIE.

10:15 AM Changeset in webkit [23820] by sullivan

3 edits in trunk/WebKit

Reviewed by Darin

WebKit support for displaying multiple text matches in PDF views (<rdar://problem/4601967>)

WebView/WebPDFView.h: new ivars textMatches and lastScrollPosition; now conforms to WebMultipleTextMatches protocol

WebView/WebPDFView.mm: (-[WebPDFView dealloc]): release textMatches (-[WebPDFView viewDidMoveToWindow]): start observing bounds changes in the PDF document's enclosing clip view, so we can notice when scrolling takes place (-[WebPDFView viewWillMoveToWindow:]): stop observing bounds changes in the PDF document's enclosing clip view (-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]): most of the code here has been moved into the new method _nextMatchFor::::, which this now calls (-[WebPDFView setMarkedTextMatchesAreHighlighted:]): implementation of WebMultipleTextMatches protocol method, does nothing useful here because we don't support inline highlighting of matches in PDF documents (-[WebPDFView markedTextMatchesAreHighlighted]): implementation of WebMultipleTextMatches protocol method (-[WebPDFView markAllMatchesForText:caseSensitive:limit:]): implementation of WebMultipleTextMatches protocol method; calls _nextMatchFor:::: in a loop until entire document is searched or limit is hit; records results by saving PDFSelections in textMatches ivar (-[WebPDFView unmarkAllTextMatches]): implementation of WebMultipleTextMatches protocol method; clears saved textMatches (-[WebPDFView rectsForTextMatches]): implementation of WebMultipleTextMatches protocol method; converts saved PDFSelections into NSValue objects that represent NSRects (-[WebPDFView _clipViewForPDFDocumentView]): new helper method to find the clip view whose bounds determine the current scroll position (-[WebPDFView _nextMatchFor:direction:caseSensitive:wrap:fromSelection:startInSelection:]): new helper method, extracted from searchFor::::: (-[WebPDFView _PDFDocumentViewMightHaveScrolled:]): new notification callback; tells webView's delegate when document has scrolled (-[WebPDFView _setTextMatches:]): new helper method, stores value in ivar

10:13 AM Changeset in webkit [23819] by sfalken

2 edits in trunk/WebKit/win

Prefast: Add null check prior to writing into allocated BSTR.

Reviewed by Darin.

MarshallingHelpers.cpp: (MarshallingHelpers::CFStringRefToBSTR):

9:53 AM Changeset in webkit [23818] by sfalken

2 edits in trunk/WebKit/win

Prefast: Add error handling for SysAllocStringLen where the string length is determined by website content.

Reviewed by Sam, Darin.

Allocation failure will result in a null dereference in this case,
so it isn't exploitable.

DefaultDownloadDelegate.cpp: (DefaultDownloadDelegate::decideDestinationWithSuggestedFilename):

9:47 AM Changeset in webkit [23817] by ap

1 add in trunk/LayoutTests/fast/dom/resources/1251.html

Forgot to commit this file with r23815.

9:43 AM Changeset in webkit [23816] by weinig

29 edits in trunk

JavaScriptCore:

Reviewed by Darin.

First pass at fixing implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Add 'f' suffix where necessary.

kjs/testkjs.cpp: (StopWatch::getElapsedMS):

WebCore:

Reviewed by Darin.

First pass at fixing implicit 64-32 bit conversion errors.
<rdar://problem/5292262>

Add 'f' suffix where necessary.

bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
css/csshelper.h:
css/cssstyleselector.cpp: (WebCore::): (WebCore::CSSStyleSelector::largerFontSize): (WebCore::CSSStyleSelector::smallerFontSize):
html/CanvasGradient.cpp: (WebCore::CanvasGradient::addColorStop):
html/CanvasPattern.cpp: (WebCore::CanvasPattern::createPattern):
ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
ksvg2/css/SVGRenderStyle.h:
ksvg2/events/SVGZoomEvent.cpp: (WebCore::SVGZoomEvent::SVGZoomEvent):
ksvg2/svg/SVGLength.cpp: (WebCore::SVGLength::SVGLength): (WebCore::SVGLength::value): (WebCore::SVGLength::setValue): (WebCore::SVGLength::valueAsPercentage): (WebCore::SVGLength::PercentageOfViewport):
ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::pixelUnitToMillimeterX): (WebCore::SVGSVGElement::pixelUnitToMillimeterY): (WebCore::SVGSVGElement::getScreenCTM):
ksvg2/svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::getComputedTextLength): (WebCore::SVGTextContentElement::getSubStringLength): (WebCore::SVGTextContentElement::getRotationOfChar):
ksvg2/svg/SVGTransformDistance.cpp: (WebCore::SVGTransformDistance::SVGTransformDistance): (WebCore::SVGTransformDistance::distance):
page/InspectorController.cpp: (WebCore::InspectorResource::InspectorResource):
platform/graphics/FloatPoint3D.cpp: (WebCore::FloatPoint3D::normalize):
platform/graphics/Path.cpp: (WebCore::pathLengthApplierFunction): (WebCore::Path::createRoundedRectangle):
platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc):
platform/graphics/cg/ImageCG.cpp: (WebCore::FrameData::clear):
platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::frameDurationAtIndex):
platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::setCurrentPage):
platform/graphics/svg/SVGPaintServerPattern.cpp: (WebCore::SVGPaintServerPattern::externalRepresentation):
platform/graphics/svg/SVGPaintServerRadialGradient.cpp: (WebCore::SVGPaintServerRadialGradient::SVGPaintServerRadialGradient):
platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::cgGradientCallback): (WebCore::CGShadingRefForRadialGradient): (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
platform/mac/FontDataMac.mm: (WebCore::webFallbackFontFamily):
platform/mac/PopupMenuMac.mm: (WebCore::PopupMenu::show):
rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::placeBoxesHorizontally):
rendering/RenderSlider.cpp: (WebCore::RenderSlider::setValueForPosition): (WebCore::RenderSlider::setPositionFromValue):

9:36 AM Changeset in webkit [23815] by ap

5 edits
2 adds in trunk

Reviewed by Geoff.

http://bugs.webkit.org/show_bug.cgi?id=14288
XMLHttpRequest doesn't use a correct content type for file:// URLs

Test: fast/dom/xmlhttprequest-html-response-encoding.html

xml/xmlhttprequest.cpp: (WebCore::XMLHttpRequest::responseMIMEType): Use MIME type provided by the network layer, since it provides it even for non-HTTP responses.

8:00 AM Changeset in webkit [23814] by zbujtas

5 edits in S60/trunk/WebKit

rathnasa, reviewed by <zbujtas@gmail.com>

DESC: Widget Menu API needs refinement
http://bugs.webkit.org/show_bug.cgi?id=14389

6:27 AM BuildingQtOnLinux edited by treat@kde.org

(diff)

6:27 AM BuildingQtOnLinux edited by treat@kde.org

add heading (diff)

6:21 AM BuildingQtOnLinux edited by treat@kde.org

Don't focus on one or two distros and update minimum version of Qt. (diff)

1:19 AM Changeset in webkit [23813] by oliver

3 edits in trunk/WebKit

Reviewed by Maciej.

Hopefully fix remainder of the IME issues on Mac.
We now assume that the IME silently consumes any event given
to it during text composition, and only override this assumption
if the NSTextInput or NSResponder callbacks are made.

This prevents us from treating those events that the IME has
consumed internally (eg. candidate window navigation) as unhandled
events that should be bubbled.

This fixes:

<rdar://problem/5107538> Major problems handling key press event with non-english Input Methods
<rdar://problem/4196249> REGRESSION: Mail: Inputting space (U+0020) with IM deletes subsequent line breaks on Mail.app
<rdar://problem/5015544> REGRESSION: Reverse conversion keyboard command does not work in Safari.
<rdar://problem/5045121> REGRESSION: Inline is confirmed after press left/right arrow keys, happens in Mail but not in TextEdit.
<rdar://problem/5076807> REGRESSION: Can't undo conversion of inline text (by hitting ESC)
<rdar://problem/5085781> REGRESSION: Active input area lost "selected" highlight
<rdar://problem/5094200> space key pressed to close the associated words candidate window gets inserted as text
<rdar://problem/5228294> Candidate item for character matrix is sometimes skipped

WebKit.xcodeproj/project.pbxproj:
WebView/WebHTMLView.mm: (-[WebHTMLView launchKeyEvent:]): (-[WebHTMLView keyDown:]): (-[WebHTMLView keyUp:]): (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): (-[WebHTMLView unmarkText]): (-[WebHTMLView setMarkedText:selectedRange:]): (-[WebHTMLView doCommandBySelector:]): (-[WebHTMLView insertText:]):

Jun 26, 2007:

10:45 PM Changeset in webkit [23812] by bdash

2 edits in trunk/WebCore

2007-06-26 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Sam Weinig.

http://bugs.webkit.org/show_bug.cgi?id=14061
Implement more of FrameLoaderClientGdk

Make FrameLoaderClientGdk work properly when the MIME type is set.

loader/gdk/FrameLoaderClientGdk.cpp: (WebCore::FrameLoaderClientGdk::objectContentType): (WebCore::FrameLoaderClientGdk::canShowMIMEType):

10:44 PM Changeset in webkit [23811] by bdash

6 edits in trunk/WebCore

2007-06-26 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=14058
Gdk font backend cleanup

platform/FontData.h: Remove obsolete function.
platform/gdk/FontDataGdk.cpp: (WebCore::FontData::containsCharacters): Lock/unlock only once. (WebCore::FontData::platformWidthForGlyph): Remove needless cast.
platform/gdk/FontPlatformData.h: Remove obsolete function.
platform/gdk/FontPlatformDataGdk.cpp: (WebCore::FontPlatformData::FontPlatformData): Pass the actual size, not the pixel size. (WebCore::FontPlatformData::~FontPlatformData): Free m_fontMatrix.
platform/gdk/GlyphPageTreeNodeGdk.cpp: (WebCore::GlyphPage::fill): Lock/unlock only once.

10:33 PM Changeset in webkit [23810] by bdash

5 edits
2 moves
6 adds
6 deletes in trunk

2007-06-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=14406 <colgroup>'s borders are ignored when it has <col> children

Covered by existing tests.

rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::collapsedLeftBorder): (WebCore::RenderTableCell::collapsedRightBorder): (WebCore::RenderTableCell::collapsedTopBorder): (WebCore::RenderTableCell::collapsedBottomBorder):

2007-06-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Hyatt.

updated results for http://bugs.webkit.org/show_bug.cgi?id=14406 <colgroup>'s borders are ignored when it has <col> children

tables/mozilla/core/table_rules-expected.checksum: Added.
tables/mozilla/core/table_rules-expected.png: Added.
tables/mozilla/core/table_rules-expected.txt: Added.
tables/mozilla/core/table_rules.html: Copied from LayoutTests/tables/mozilla_expected_failures/core/table_rules.html.
tables/mozilla/marvin/x_table_rules_groups-expected.checksum: Added.
tables/mozilla/marvin/x_table_rules_groups-expected.png: Added.
tables/mozilla/marvin/x_table_rules_groups-expected.txt: Added.
tables/mozilla/marvin/x_table_rules_groups.xml: Copied from LayoutTests/tables/mozilla_expected_failures/marvin/x_table_rules_groups.xml.
tables/mozilla_expected_failures/core/table_rules-expected.checksum: Removed.
tables/mozilla_expected_failures/core/table_rules-expected.png: Removed.
tables/mozilla_expected_failures/core/table_rules-expected.txt: Removed.
tables/mozilla_expected_failures/core/table_rules.html: Removed.
tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.checksum: Removed.
tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.png: Removed.
tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.txt: Removed.
tables/mozilla_expected_failures/marvin/x_table_rules_groups.xml: Removed.

9:46 PM Changeset in webkit [23809] by bdash

4 edits
5 adds in trunk

2007-06-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Oliver.

fix http://bugs.webkit.org/show_bug.cgi?id=14329 REGRESSION: TEXTAREA - cannot drag-and-drop text at en.wikipedia.org/

Test: fast/repaint/text-selection-rect-in-overflow-2.html

rendering/RenderObject.cpp: (WebCore::RenderObject::computeAbsoluteRepaintRect): Added code to account for overflow scroll and columns.
rendering/RenderText.cpp: (WebCore::RenderText::selectionRect): Adjust for columns only in the non-clipped case, since RenderObject::absolutePosition() does not.

2007-06-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Oliver.

repaint test for http://bugs.webkit.org/show_bug.cgi?id=14329 REGRESSION: TEXTAREA - cannot drag-and-drop text at en.wikipedia.org/

fast/repaint/resources/text-selection-rect-in-overflow-frame.html: Added.
fast/repaint/text-selection-rect-in-overflow-2-expected.checksum: Added.
fast/repaint/text-selection-rect-in-overflow-2-expected.png: Added.
fast/repaint/text-selection-rect-in-overflow-2-expected.txt: Added.
fast/repaint/text-selection-rect-in-overflow-2.html: Added.

9:43 PM Changeset in webkit [23808] by bdash

2 edits in trunk/WebCore

2007-06-26 Mitz Pettel <mitz@webkit.org>

Reviewed by Sam.

http://bugs.webkit.org/show_bug.cgi?id=14415 Remove the unused method RenderObject::setTable()

rendering/RenderObject.h:

9:07 PM Changeset in webkit [23807] by aroben

1 edit in trunk/WebCore/config.h

Touching config.h to force WebCore to rebuild after r23806

8:16 PM Changeset in webkit [23806] by bdash

5 edits
6 adds
2 deletes in trunk/WebCore

2007-06-26 MorganL <morganl.webkit@yahoo.com>

Reviewed by Maciej.

Implement http://bugs.webkit.org/show_bug.cgi?id=14225
Bug 14225: Make it possible to define platform-specific ResourceRequest without #ifdefs

This change moves the bulk of ResourceRequest into a base class named
ResourceRequestBase with all platform-specific bits pushed into
ResourceRequest. This allows ports to easily add new members to a
ResourceRequest without having to #ifdef the code that is shared
between ports.

WebCore.exp:
WebCore.pro:
WebCore.vcproj/WebCore.vcproj:
WebCore.xcodeproj/project.pbxproj:
platform/network/ResourceRequest.cpp: Removed.
platform/network/ResourceRequest.h: Removed.
platform/network/ResourceRequestBase.cpp: Added. (WebCore::ResourceRequestBase::asResourceRequest): (WebCore::ResourceRequestBase::isEmpty): (WebCore::ResourceRequestBase::isNull): (WebCore::ResourceRequestBase::url): (WebCore::ResourceRequestBase::setURL): (WebCore::ResourceRequestBase::cachePolicy): (WebCore::ResourceRequestBase::setCachePolicy): (WebCore::ResourceRequestBase::timeoutInterval): (WebCore::ResourceRequestBase::setTimeoutInterval): (WebCore::ResourceRequestBase::mainDocumentURL): (WebCore::ResourceRequestBase::setMainDocumentURL): (WebCore::ResourceRequestBase::httpMethod): (WebCore::ResourceRequestBase::setHTTPMethod): (WebCore::ResourceRequestBase::httpHeaderFields): (WebCore::ResourceRequestBase::httpHeaderField): (WebCore::ResourceRequestBase::setHTTPHeaderField): (WebCore::ResourceRequestBase::httpBody): (WebCore::ResourceRequestBase::setHTTPBody): (WebCore::ResourceRequestBase::allowHTTPCookies): (WebCore::ResourceRequestBase::setAllowHTTPCookies): (WebCore::ResourceRequestBase::addHTTPHeaderField): (WebCore::ResourceRequestBase::addHTTPHeaderFields): (WebCore::operator==): (WebCore::ResourceRequestBase::isConditional): (WebCore::ResourceRequestBase::updatePlatformRequest): (WebCore::ResourceRequestBase::updateResourceRequest):
platform/network/ResourceRequestBase.h: Added. (WebCore::): (WebCore::ResourceRequestBase::httpContentType): (WebCore::ResourceRequestBase::setHTTPContentType): (WebCore::ResourceRequestBase::httpReferrer): (WebCore::ResourceRequestBase::setHTTPReferrer): (WebCore::ResourceRequestBase::clearHTTPReferrer): (WebCore::ResourceRequestBase::httpUserAgent): (WebCore::ResourceRequestBase::setHTTPUserAgent): (WebCore::ResourceRequestBase::httpAccept): (WebCore::ResourceRequestBase::setHTTPAccept): (WebCore::ResourceRequestBase::ResourceRequestBase): (WebCore::operator!=):
platform/network/cf/ResourceRequest.h: Added. (WebCore::ResourceRequest::ResourceRequest):
platform/network/curl/ResourceRequest.h: Added. (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest):
platform/network/mac/ResourceRequest.h: Added. (WebCore::ResourceRequest::ResourceRequest):
platform/network/qt/ResourceRequest.h: Added. (WebCore::ResourceRequest::ResourceRequest): (WebCore::ResourceRequest::doUpdatePlatformRequest): (WebCore::ResourceRequest::doUpdateResourceRequest):

8:13 PM Changeset in webkit [23805] by bdash

2 edits in trunk/WebKit

2007-06-26 Jim Correia <jim.correia@pobox.com>

Reviewed by Darin.

Fix http://bugs.webkit.org/show_bug.cgi?id=14411
Bug 14411: WebNetscapePluginPackage overagressively sets CurApRefNum, which affects shipping versions of BBEdit.
<rdar://problem/5297268>

Plugins/WebNetscapePluginPackage.m: (+[WebNetscapePluginPackage initialize]): Force the Resource Manager to lazy initialize, and only set CurApRefNum to the system file if CurApRefNum is still -1 after that forced lazy initialization.

7:13 PM Changeset in webkit [23804] by aroben

1 edit in trunk/WebCore/ChangeLog

Add ChangeLog entries from the Windows merge.

Reviewed by Maciej.

ChangeLog:

6:44 PM Changeset in webkit [23803] by weinig

7 edits
2 adds in trunk

LayoutTests:

Reviewed by Maciej.

Make sure not to enumerate the toString() function.
<rdar://problem/5297118>

fast/dom/Window/window-appendages-cleared-expected.txt:
fast/dom/Window/window-properties-expected.txt:
fast/js/toString-dontEnum-expected.txt: Added.
fast/js/toString-dontEnum.html: Added.

WebCore:

Reviewed by Maciej.

Make sure not to enumerate the toString() function.
<rdar://problem/5297118>

bindings/js/kjs_window.cpp:
bindings/scripts/CodeGeneratorJS.pm: Add support for [DontEnum].
html/HTMLAnchorElement.idl:

4:26 PM Changeset in webkit [23802] by ggaren

2 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.

Fixed <rdar://problem/5296627> JSGarbageCollect headerdoc suggests that
using JavaScriptCore requires leaking memory

API/JSBase.h: Changed documentation to explain that you can pass NULL to JSGarbageCollect.

4:07 PM Changeset in webkit [23801] by andersca

2 edits in trunk/WebCore

Reviewed by Mitz, landed by Anders.

http://bugs.webkit.org/show_bug.cgi?id=14421
Implement GraphicsContext::clearRect()

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::clearRect):

4:05 PM Changeset in webkit [23800] by andersca

2 edits in trunk/WebCore

Reviewed and landed by Anders.

http://bugs.webkit.org/show_bug.cgi?id=14416
Content does not render fully in some cases

Fix mismatched calls to cairo_save/restore due to an early method return.

platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLine):

2:31 PM Changeset in webkit [23799] by tristan

3 edits in trunk/WebCore

Reviewed by John Sullivan.

Added two accessor functions for <rdar://problem/4119138>

bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isEdited]): (-[DOMHTMLTextAreaElement _isEdited]): Added an accessor to the isEdited value of a DOM node's render object

bindings/objc/DOMPrivate.h: Added header definitions for _isEdited

1:17 PM Changeset in webkit [23798] by spadma

2 edits in S60/trunk/WebCore

spadma, reviewed by zalan

DESC: Fix build bustage

kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::activateNodeAtPoint):

1:07 PM Changeset in webkit [23797] by weinig

2 edits in trunk/WebCore

Fix Win32 build.

WebCore.vcproj/WebCore.vcproj:

1:05 PM Changeset in webkit [23796] by weinig

2 edits in trunk/WebCore

Fix Qt and Gdk builds.

WebCore.pro:

12:55 PM Changeset in webkit [23795] by weinig

15 edits
1 add in trunk

LayoutTests:

Reviewed by Geoff.

Update tests for http://bugs.webkit.org/show_bug.cgi?id=14111
Autogenerate Event JS binding

fast/dom/prototype-chain-expected.txt: DOMEventPrototype is no longer in the prototype chain.
fast/dom/xmlhttprequest-get-expected.txt:

WebCore:

Reviewed by Geoff.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14111
Autogenerate Event JS binding

Moves the dataTransfer method into MouseEvent where it should be.

WebCore.xcodeproj/project.pbxproj:
bindings/js/JSEventCustom.cpp: Added. (WebCore::JSEvent::clipboardData): (WebCore::toJS):
bindings/js/JSEventTargetNode.cpp:
bindings/js/JSXMLHttpRequest.cpp:
bindings/js/kjs_events.cpp:
bindings/js/kjs_events.h:
bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
bindings/scripts/CodeGeneratorJS.pm:
dom/Event.h: (WebCore::Event::returnValue): (WebCore::Event::setReturnValue): (WebCore::Event::clipboardData):
dom/Event.idl:
dom/MouseEvent.h: (WebCore::MouseEvent::dataTransfer):
dom/MouseEvent.idl:

7:47 AM Changeset in webkit [23794] by spadma

6 edits in S60/trunk/WebKit

winship, reviewed by <reviewer>

DESC: SYAI-73ARXK - Widget UI must not have scrollbars, always ON status pane & fullscreen mode
http://bugs.webkit.org/show_bug.cgi?id=14384

BrowserControl/inc/BrCtlDefs.h: (TBrCtlDefs::):
BrowserControl/inc/BrCtlInterface.h:
BrowserView/inc/WidgetExtension.h:
BrowserView/src/WebKitControl.cpp: (CWebKitControl::ForegroundEvent):
BrowserView/src/WidgetExtension.cpp: (CWidgetExtension::SetRightSoftKeyLabel): (CWidgetExtension::HideSoftkeys): (CWidgetExtension::ShowSoftkeys): (CWidgetExtension::SetDisplayLandscape): (CWidgetExtension::SetDisplayPortrait):

7:44 AM Changeset in webkit [23793] by spadma

3 edits in S60/trunk/WebKit

2007-06-25 Vikram Malaiya, reviewed by Sachin

DESC: YDAI-73QAL9 - Cursor is invisible on second created browser control.
http://bugs.webkit.org/show_bug.cgi?id=14285

BrowserView/inc/WebKitCursor.h:
BrowserView/src/WebKitCursor.cpp: (CWebKitCursor::CWebKitCursor): (CWebKitCursor::ConstructL): (CWebKitCursor::SetCurrentView): (CWebKitCursor::ConstructSprite): (CWebKitCursor::CursorUpdate):

7:41 AM Changeset in webkit [23792] by spadma

2 edits in S60/trunk/WebCore

spadma, reviewed by zalan

DESC: [S60] Pointer event in a blank browser window causes crash
http://bugs.webkit.org/show_bug.cgi?id=14387
TSW ID : YDAI-73V998

WARNING: NO TEST CASES ADDED OR CHANGED

kwq/KWQKHTMLPart.cpp: (KWQKHTMLPart::activateNodeAtPoint):

7:40 AM Changeset in webkit [23791] by staikos

1 add in trunk/WebCore/loader/icon/IconDatabaseNone.cpp

Missed checking in this file when checking in icon database patch from Adam Treat. Unused on all platforms presently.

5:51 AM Web Inspector edited by timothy@apple.com

(diff)

5:28 AM Changeset in webkit [23790] by thatcher

2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Follow up fix for: Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
http://bugs.webkit.org/show_bug.cgi?id=14385

Correctly remember the "Show implicit properties" setting as you switch nodes.

page/inspector/ResourcePanel.js:

1:55 AM Changeset in webkit [23789] by rwlbuis

4 edits
1 move
3 adds
3 deletes in branches/feature-branch

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=9976
Fix negative width issue in Hixie's test

Refuse to render zero or negative width/height.

12:47 AM Changeset in webkit [23788] by rwlbuis

14 edits
8 adds in branches/feature-branch

Reviewed by Maciej.

http://bugs.webkit.org/show_bug.cgi?id=12062
WebCore does not handle CSS-specified fill fallback correctly

Implement fallback for fill and stroke.

Jun 25, 2007:

11:52 PM Changeset in webkit [23787] by justing

8 edits
2 adds in trunk

LayoutTests:

Reviewed by John.

<rdar://problem/5290534> Crash RenderTextControl::calcHeight() after deleting text in a search field

Demonstrates the bug:

editing/deleting/5290534-expected.txt: Added.
editing/deleting/5290534.html: Added.

Fixed a bug (an extra br was inserted) and removed a FIXME:

editing/deleting/4845371-expected.checksum:
editing/deleting/4845371-expected.png:
editing/deleting/4845371-expected.txt:
editing/deleting/4845371.html:

Removed an unrendered br that was being incorrectly inserted:

editing/deleting/5126166-expected.txt:

WebCore:

Reviewed by John.

<rdar://problem/5290534> Crash at RenderTextControl::calcHeight() after deleting text in a search field

Editing removed a node that was part of a search field's internal
structure that should not be removed.

editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): If the selection to delete ends at [container, x], where x is the number of children in container, don't remove container. Special case code elsewhere in this function will remove it if necessary.

11:34 PM Changeset in webkit [23786] by weinig

4 edits
3 adds in trunk

LayoutTests:

Reviewed by Maciej.

Test for http://bugs.webkit.org/show_bug.cgi?id=11315
Mutating document.constructor.prototype mutates Object.prototype

fast/js/constructor-expected.txt: Added.
fast/js/constructor.html: Added.
fast/js/resources/constructor.js: Added.

WebCore:

Reviewed by Maciej.

Patch for http://bugs.webkit.org/show_bug.cgi?id=11315
Mutating document.constructor.prototype mutates Object.prototype

Test: fast/js/constructor.html

bindings/scripts/CodeGeneratorJS.pm: add constructor attribute to classes with constructors. It is an non-enumeratable, non-deletable, readonly attribute.

10:23 PM Changeset in webkit [23785] by staikos

2 edits in trunk/WebCore

Repair the OS X build.

10:12 PM Changeset in webkit [23784] by aroben

1 edit
1 delete in trunk

Really remove LayoutTestResults.

LayoutTestResults: Removed.

10:00 PM Changeset in webkit [23783] by aroben

3 edits
297 copies
2455 moves
105 adds
297 deletes in trunk

Fix Bug 14405: LayoutTestResults/qt should be in LayoutTests/qt

Top Level:

Fix Bug 14405: LayoutTestResults/qt should be in LayoutTests/qt
http://bugs.webkit.org/show_bug.cgi?id=14405

Reviewed by Anders.

LayoutTestResults: Removed.

WebKitTools:

Fix Bug 14405: LayoutTestResults/qt should be in LayoutTests/qt
http://bugs.webkit.org/show_bug.cgi?id=14405

Reviewed by Anders.

Scripts/run-webkit-tests:

9:56 PM Changeset in webkit [23782] by staikos

5 edits in trunk

Patch from Adam Treat to make the SQLite icon database optional.

9:38 PM Changeset in webkit [23781] by aroben

2 edits in trunk/WebKitTools

Enable running the regression tests on Windows.

These changes were developed alongside the Windows WebKit port and
have been well tested.

Rubberstamped by Sam.

Scripts/run-webkit-tests:

9:18 PM Changeset in webkit [23780] by weinig

6 edits in trunk/WebCore

Reviewed by Adam Roben.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14369
HTML syntax highlighting colors and DOM tree colors should be the same

css/view-source.css:
page/inspector/ResourcePanel.js:
page/inspector/inspector.css:
page/inspector/inspector.js:
page/inspector/utilities.js:

8:18 PM Changeset in webkit [23779] by aroben

2 edits in trunk/WebCore

Fix Bug 14402: Main resource of http://www.apple.com/safari/ is called "www.apple.com" instead of "safari"

The solution was to make KURL::lastPathComponent ignore trailing
slashes, which is what -[NSURL lastPathComponent] does, too.

Reviewed by Oliver.

platform/KURL.cpp:

(WebCore::KURL::lastPathComponent):

8:09 PM Changeset in webkit [23778] by aroben

2 edits in trunk/WebKitTools

Fix Bug 14403: prepare-ChangeLog --git-commit doesn't support --diff
http://bugs.webkit.org/show_bug.cgi?id=14403

Reviewed by Mark Rowe.

Scripts/prepare-ChangeLog: Don't spew to stdout, use stderr instead.

(sub createPatchCommand): Generate a correct diff in the $gitCommit
case.

5:56 PM Changeset in webkit [23777] by kdecker

2 edits in trunk/WebKit

Reviewed by Darin.

<rdar://problem/5294036> -[WebView customTextEncodingName] API may return empty string instead of nil

WebView/WebView.mm: (-[WebView _mainFrameOverrideEncoding]): Addded the nsStringNilIfEmpty() inline to the data being returned because our API says "The custom text encoding name or nil if no custom text encoding name has been set." I also verified the standing Tiger WebKit behavior for this method and it does indeed return nil if a custom encoding wasn't set.

5:51 PM Changeset in webkit [23776] by weinig

2 edits in trunk/WebCore

Reviewed by Adam Roben.

Patch for http://bugs.webkit.org/show_bug.cgi?id=14257
Web Inspector lists favicon.ico as "other" instead of "image"

page/InspectorController.cpp: (WebCore::InspectorResource::type):

5:43 PM Changeset in webkit [23775] by aroben

2 edits
13 adds in trunk/WebKitTools

Land pdevenv and supporting scripts/programs

pdevenv is a script that will open an instance of Visual Studio that
can compile multiple files in parallel, similar to make -jN. It uses
the following scripts/programs to accomplish this:

CLWrapper: Compiles to vcbin/cl.exe. Calls Scripts/parallelcl.

parallelcl: Actually performs the parallel compilation by forking
multiple instances of the Microsoft-supplied cl.exe.

MIDLWrapper: Compiles to vcbin/midl.exe. Calls through to the
Microsoft-supplied midl.exe. This avoids having to invoke perl for
every invocation of midl.exe, which would be quite slow.

Rubberstamped by Sam.

CLWrapper/CLWrapper.cpp: Added.

(wmain):

CLWrapper/CLWrapper.sln: Added.
CLWrapper/CLWrapper.vcproj: Added.
MIDLWrapper/MIDLWrapper.cpp: Added.

(wmain):

MIDLWrapper/MIDLWrapper.sln: Added.
MIDLWrapper/MIDLWrapper.vcproj: Added.
Scripts/parallelcl: Added.
Scripts/pdevenv: Added.
vcbin/cl.exe: Added.
vcbin/midl.exe: Added.

5:30 PM Changeset in webkit [23774] by sullivan

6 edits in trunk/WebKit

Reviewed by Darin

WebKit part of <rdar://problem/5293820>, needed to support multiple matches in PDFs

WebView/WebDocumentInternal.h: Added WebMultipleTextMatches protocol, containing five methods that were formerly implemented in WebHTMLView
WebView/WebHTMLViewPrivate.h: Removed declarations for the methods that are now in WebMultipleTextMatches protocol

WebView/WebHTMLView.mm: (-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]): moved this method into the WebDocumentInternalProtocols portion of the file (-[WebHTMLView setMarkedTextMatchesAreHighlighted:]): ditto (-[WebHTMLView markedTextMatchesAreHighlighted]): ditto (-[WebHTMLView unmarkAllTextMatches]): ditto (-[WebHTMLView rectsForTextMatches]): ditto

WebView/WebView.mm: (-[WebView canMarkAllTextMatches]): new method, returns YES only if the documentView of every frame implements WebMultipleTextMatches (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): check for WebMultipleTextMatches protocol instead of checking for WebHTMLView class (-[WebView unmarkAllTextMatches]): ditto (-[WebView rectsForTextMatches]): ditto

WebView/WebViewPrivate.h: declared new method canMarkAllTextMatches

5:07 PM Changeset in webkit [23773] by adele

3 edits
4 adds in trunk

LayoutTests:

Reviewed by Hyatt.

Test for: <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
http://bugs.webkit.org/show_bug.cgi?id=14297

fast/overflow/hidden-scrollbar-resize-expected.checksum: Added.
fast/overflow/hidden-scrollbar-resize-expected.png: Added.
fast/overflow/hidden-scrollbar-resize-expected.txt: Added.
fast/overflow/hidden-scrollbar-resize.html: Added.

WebCore:

Reviewed by Hyatt.

Fix for <rdar://problem/5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
http://bugs.webkit.org/show_bug.cgi?id=14297

Test: fast/overflow/hidden-scrollbar-resize.html

rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer): Updated our shouldPaint check to consider visibility.

3:59 PM Changeset in webkit [23772] by oliver

2 edits
1 add in trunk/WebCore

Reviewed by Darin.

<rdar://problem/5293444> REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info

Fixing logic error in DragController

manual-tests/drop-text-acquires-style.html: Added.
page/DragController.cpp: (WebCore::documentFragmentFromDragData):

2:36 PM Changeset in webkit [23771] by weinig

2 edits in trunk/WebCore

Reviewed by Adam Roben.

Annotate prototypes by adding "Prototype" subtitle.

page/inspector/ResourcePanel.js:

2:29 PM Changeset in webkit [23770] by thatcher

1 edit in trunk/WebCore/WebCore.xcodeproj/project.pbxproj

Build fix.

11:20 AM Changeset in webkit [23769] by staikos

10 edits in trunk

Some work on adding HTTP proxy and SSL errors to WebKitQt, as well as preparing
for upcoming patches to do authentication.

10:48 AM Changeset in webkit [23768] by sullivan

2 edits in trunk/WebKit

Reviewed by Darin

Fixed <rdar://problem/5292259> Find on Page doesn't work (throws exception) on page that includes PDF in a subframe

WebView/WebView.mm: (-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]): We were testing whether the view was an HTMLView, but then running code that assumed it was an HTMLView outside of that test. That's a bad idea.

9:04 AM Changeset in webkit [23767] by aroben

2 edits in trunk/WebCore

Reviewed by Adam Roben.

http://bugs.webkit.org/show_bug.cgi?id=14386
Gdk build fix

WebCore.pro: Fix gtk/gdk typo.

8:44 AM Changeset in webkit [23766] by zbujtas

3 edits in S60/trunk/WebCore

2007-06-22 hongzhao <hong.a.zhao@nokia.com>

Reviewed by Zalan (zbujtas@gmail.com).
DESC: Bug 14214: [S60] Dropdown not opened if it has size defined in 3.1m.
http://bugs.webkit.org/show_bug.cgi?id=14214

8:41 AM Changeset in webkit [23765] by zbujtas

3 edits in S60/branches/3.1m/WebCore

2007-06-22 hongzhao <hong.a.zhao@nokia.com>

Reviewed by Zalan (zbujtas@gmail.com).
DESC: Bug 14214: [S60] Dropdown not opened if it has size defined in 3.1m.
http://bugs.webkit.org/show_bug.cgi?id=14214

7:51 AM Changeset in webkit [23764] by thatcher

5 edits in trunk/WebCore

Reviewed by Anders.

Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
http://bugs.webkit.org/show_bug.cgi?id=14385

Add a toggle to show implict computed properties.

page/inspector/ResourcePanel.js:
page/inspector/inspector.css:
page/inspector/inspector.js:

5:57 AM Changeset in webkit [23763] by bdash

4 edits
62 deletes in trunk

2007-06-25 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Mark.

http://bugs.webkit.org/show_bug.cgi?id=13975
Use system-provided libjpeg and libpng

WebKit.pri: Link against external libjpeg and libpng.

2007-06-25 Alp Toker <alp.toker@collabora.co.uk>

Reviewed by Mark.

http://bugs.webkit.org/show_bug.cgi?id=13975
Use system-provided libjpeg and libpng

WebCore.pro: Remove bundled libjpeg and libpng sources.
platform/image-decoders/jpeg: Remove sources.
platform/image-decoders/png: Remove sources.

3:31 AM Changeset in webkit [23762] by bdash

24 edits
4 adds in trunk

2007-06-25 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=14202 Table caption renders too narrow sometimes

Test: fast/table/caption-relayout.html

rendering/RenderTable.cpp: (WebCore::RenderTable::layout): Mark the caption for layout if the table width changed.

2007-06-25 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

test and updated results for http://bugs.webkit.org/show_bug.cgi?id=14202 Table caption renders too narrow sometimes

fast/table/caption-relayout-expected.checksum: Added.
fast/table/caption-relayout-expected.png: Added.
fast/table/caption-relayout-expected.txt: Added.
fast/table/caption-relayout.html: Added.
tables/mozilla/marvin/x_caption_class-expected.checksum:
tables/mozilla/marvin/x_caption_class-expected.png:
tables/mozilla/marvin/x_caption_class-expected.txt:
tables/mozilla/marvin/x_caption_id-expected.checksum:
tables/mozilla/marvin/x_caption_id-expected.png:
tables/mozilla/marvin/x_caption_id-expected.txt:
tables/mozilla/marvin/x_caption_style-expected.checksum:
tables/mozilla/marvin/x_caption_style-expected.png:
tables/mozilla/marvin/x_caption_style-expected.txt:
tables/mozilla_expected_failures/bugs/bug29058-2-expected.checksum:
tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
tables/mozilla_expected_failures/bugs/bug3166-5-expected.checksum:
tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
tables/mozilla_expected_failures/bugs/bug3166-5-expected.txt:
tables/mozilla_expected_failures/bugs/bug3166-6-expected.checksum:
tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
tables/mozilla_expected_failures/bugs/bug3166-6-expected.txt:
tables/mozilla_expected_failures/bugs/bug3166-9-expected.checksum:
tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
tables/mozilla_expected_failures/bugs/bug3166-9-expected.txt:

3:29 AM Changeset in webkit [23761] by bdash

3 edits
4 adds in trunk

2007-06-25 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=14245 Underline painted under <br>, not repainted properly

Test: fast/inline/br-text-decoration.html

platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::drawLineForText): Added an early return if the line width is zero. Also changed the line stroke to a rect fill, so that lines with length shorter than their thickness paint correctly.

2007-06-25 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

pixel test for http://bugs.webkit.org/show_bug.cgi?id=14245 Underline painted under <br>, not repainted properly

fast/inline/br-text-decoration-expected.checksum: Added.
fast/inline/br-text-decoration-expected.png: Added.
fast/inline/br-text-decoration-expected.txt: Added.
fast/inline/br-text-decoration.html: Added.

3:27 AM Changeset in webkit [23760] by bdash

5 edits in trunk/LayoutTests

2007-06-25 Matt Perry <mpComplete@gmail.com>

Reviewed by Sam Weinig.

Modify test to wait until the second frame loads, and update its expected output to match.

fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.checksum:
fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.png:
fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.txt:
fast/dom/HTMLDocument/frameless-location-bugzilla10837.html:

3:23 AM Changeset in webkit [23759] by bdash

6 edits
2 moves
6 adds
6 deletes in trunk

2007-06-25 Mitz Pettel <mitz@webkit.org>

Reviewed by Maciej.

fix http://bugs.webkit.org/show_bug.cgi?id=14341 rules="none" ignored in certain cases

Covered by existing tests.

html/HTMLTableElement.cpp: (WebCore::HTMLTableElement::getSharedCellDecl):

2007-06-25 Mitz Pettel <mitz@webkit.org>

Reviewed by Maciej.

updated results for http://bugs.webkit.org/show_bug.cgi?id=14341 rules="none" ignored in certain cases

tables/mozilla/marvin/table_rules_none-expected.checksum: Added.
tables/mozilla/marvin/table_rules_none-expected.png: Added.
tables/mozilla/marvin/table_rules_none-expected.txt: Added.
tables/mozilla/marvin/table_rules_none.html: Copied from LayoutTests/tables/mozilla_expected_failures/marvin/table_rules_none.html.
tables/mozilla/marvin/x_table_rules_none-expected.checksum: Added.
tables/mozilla/marvin/x_table_rules_none-expected.png: Added.
tables/mozilla/marvin/x_table_rules_none-expected.txt: Added.
tables/mozilla/marvin/x_table_rules_none.xml: Copied from LayoutTests/tables/mozilla_expected_failures/marvin/x_table_rules_none.xml.
tables/mozilla_expected_failures/core/table_rules-expected.checksum:
tables/mozilla_expected_failures/core/table_rules-expected.png:
tables/mozilla_expected_failures/core/table_rules-expected.txt:
tables/mozilla_expected_failures/marvin/table_rules_none-expected.checksum: Removed.
tables/mozilla_expected_failures/marvin/table_rules_none-expected.png: Removed.
tables/mozilla_expected_failures/marvin/table_rules_none-expected.txt: Removed.
tables/mozilla_expected_failures/marvin/table_rules_none.html: Removed.
tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.checksum: Removed.
tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.png: Removed.
tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.txt: Removed.
tables/mozilla_expected_failures/marvin/x_table_rules_none.xml: Removed.

12:10 AM Changeset in webkit [23758] by weinig