Timeline
Jul 26, 2007:
- 10:27 PM Changeset in webkit [24669] by
-
- 1 edit in trunk/WebKit/ChangeLog
Added radar.
- 9:54 PM Changeset in webkit [24668] by
-
- 4 edits in trunk/WebKit
Reviewed by Oliver.
http://bugs.webkit.org/show_bug.cgi?id=14733
Add a logging channel for text input
- Misc/WebKitLogging.h:
- Misc/WebKitLogging.m: (WebKitInitializeLoggingChannelsIfNecessary):
- WebView/WebHTMLView.mm: (-[WebHTMLView validAttributesForMarkedText]): (-[WebHTMLView textStorage]): (-[WebHTMLView characterIndexForPoint:]): (-[WebHTMLView firstRectForCharacterRange:]): (-[WebHTMLView selectedRange]): (-[WebHTMLView markedRange]): (-[WebHTMLView attributedSubstringFromRange:]): (-[WebHTMLView hasMarkedText]): (-[WebHTMLView unmarkText]): (-[WebHTMLView setMarkedText:selectedRange:]): (-[WebHTMLView doCommandBySelector:]): (-[WebHTMLView insertText:]):
- 9:18 PM Changeset in webkit [24667] by
-
- 2 edits in trunk/LayoutTests
- http/tests/security/cross-frame-access-put-expected.txt: Checked in corrected results that match the checked-in test.
- 6:58 PM Changeset in webkit [24666] by
-
- 14 edits in trunk/WebKit
- fix Tiger build
- Misc/WebTypesInternal.h: For use inside the library, use NSInteger and NSUInteger, just like on Leopard. WebNSInteger and WebNSUInteger are still present, but they are used in public and private headers only.
- Carbon/CarbonWindowAdapter.m:
- Carbon/CarbonWindowFrame.m:
- DefaultDelegates/WebScriptDebugServer.m:
- History/WebBackForwardList.mm:
- Misc/WebDownload.m:
- Misc/WebSearchableTextView.m:
- Plugins/WebBaseNetscapePluginView.mm:
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebView/WebHTMLView.mm:
- WebView/WebPDFView.mm:
- WebView/WebView.mm:
- WebView/WebViewInternal.h: Update all implementation files and internal headers to use NSInteger and NSUInteger rather than WebNSInteger and WebNSUInteger.
- 6:12 PM Changeset in webkit [24665] by
-
- 3 edits in trunk/WebKit
Reviewed by Kevin Decker
- fixed <rdar://problem/5362989> Searching a pdf in some modes shows hilights for all instances of the word, even those not on the current page
It turns out that there were three different issues here, all contributing to incorrect display
of multiple matches for PDF pages in certain display modes. (1) in non-continuous display modes,
we weren't updating the match rects when the displayed page is changed with page up/down (e.g.);
(2) the mechanism to update the match rects on scrolling was busted except for the first scroll
away from 0,0; (3) the PDFKit API returns selection bounds for non-displayed pages in non-continuous
modes just as if they were the displayed pages. This patch fixes all three issues.
- WebView/WebPDFView.h: made ivar name even longer
- WebView/WebPDFView.mm: (-[WebPDFView setPDFDocument:]): updated for ivar name change (-[WebPDFView viewDidMoveToWindow]): observe page-change notifications as well as the others; this is necessary because in the non-continuous modes the view can be completely updated without any scrolling involved (problem 1) (-[WebPDFView viewWillMoveToWindow:]): stop observing page-change notifications (-[WebPDFView rectsForTextMatches]): skip any pages that aren't visible; this avoids treating matches on non-displayed non-continous modes as if they were on the displayed page (problem 3) (-[WebPDFView _PDFDocumentViewMightHaveScrolled:]): after checking whether scroll position has changed since we last checked it, remember the new one (d'oh!) (problem 2)
(-[WebPDFView _scaleOrDisplayModeOrPageChanged:]):
renamed to include page changes
(-[WebPDFView _visiblePDFPages]):
new method, returns the set of pages that are at least partly visible
- 5:51 PM Changeset in webkit [24664] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Anders Carlsson.
<rdar://problem/5350019> REGRESSION: Pages on milliyet.com are added to Back list when visited, causing Back button to just reload
- http/tests/navigation/lockedhistory-iframe-expected.txt: Added.
- http/tests/navigation/lockedhistory-iframe.html: Added.
- 5:46 PM Changeset in webkit [24663] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders Carlsson.
<rdar://problem/5350019> REGRESSION: Pages on milliyet.com are added to Back list when visited, causing Back button to just reload
- loader/FrameLoader.cpp: (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): If the policy action is FrameLoadTypeRedirectLockHistory, don't add the frame load url to the history.
- 5:26 PM Changeset in webkit [24662] by
-
- 1 edit in trunk/WebCore/rendering/RenderInline.cpp
- 5:14 PM Changeset in webkit [24661] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoff.
Add a FIXME about caching pages with plug-ins that have outstanding NPObjects.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::canCachePage):
- 5:12 PM Changeset in webkit [24660] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Sam.
- Updated results as they are affecte by my previous checkin.
- http/tests/security/cross-frame-access-put-expected.txt:
- http/tests/security/resources/cross-frame-iframe-for-put-test.html:
- 5:02 PM Changeset in webkit [24659] by
-
- 2 edits in trunk/WebCore
FIx for <rdar://problem/5289721> CrashTracer: [REGRESSION] 2658 crashes in Safari at com.apple.WebCore: WebCore::RenderInline::height const + 16
Adding a null check for now and an assert. We don't know how/why this
bug happens, but hopefully the assert will help people to reproduce.
Reviewed by kevin
- rendering/RenderInline.cpp: (WebCore::RenderInline::height):
- 4:52 PM Changeset in webkit [24658] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver.
<rdar://problem/5362783>
In Mail, a crash occurs at WTF::fastMalloc() when attempting to create a new HTML message from http://nytimes.com/
If the cache is disabled and there is already a resource with the given URL, return it instead of creating a new one.
- loader/DocLoader.cpp: (WebCore::DocLoader::requestResource):
- 4:15 PM Changeset in webkit [24657] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoff.
Build fix.
- platform/network/cf/ResourceRequest.h:
- 3:47 PM Changeset in webkit [24656] by
-
- 2 edits in trunk/LayoutTests
Reviewed by.
- Fixed bot breakage.
- fast/dom/Window/window-resize.html:
- 3:40 PM Changeset in webkit [24655] by
-
- 2 edits in trunk/WebCore
Reviewed by John Sullivan.
<rdar://problem/5349389>
Some frame load delegate methods not called when loading a page from the BF cache
These calls were moved to FrameLoader::begin, which is never called for pages loaded
from the BF cache. This happened in revision 24490.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted): Call delegate methods if the load is from the BF cache.
- 2:59 PM Changeset in webkit [24654] by
-
- 7 edits2 adds in trunk
LayoutTests:
Reviewed by Darin, Geoff and Sam.
- <rdar://problem/5150461> Resizing the window larger than the screen causes no resize.
- Tests to ensure we resize/move the window out of bounds correctly.
- fast/dom/Window/window-resize-expected.txt: Added.
- fast/dom/Window/window-resize.html: Added.
- mac/leopard/Skipped:
WebCore:
Reviewed by Darin, Geoff and Sam.
- <rdar://problem/5150461> Resizing the window larger than the screen causes no resize.
- We now better match the behavior of other browsers.
- bindings/js/kjs_window.cpp: (KJS::constrainToVisible): (KJS::WindowFunc::callAsFunction):
WebKitTools:
Reviewed by Darin, Geoff, Sam.
- <rdar://problem/5150461> Resizing the window larger than the screen causes no resize.
- Added delegate methods to intercept and fake the frame location so methods like resizeTo and moveTo can change the window location without actually making the window appear on-screen.
- DumpRenderTree/UIDelegate.h:
- DumpRenderTree/UIDelegate.m: (-[UIDelegate webView:setFrame:]): (-[UIDelegate webViewFrame:]):
- 2:43 PM Changeset in webkit [24653] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Brady.
- Added leopard-specific results for <rdar://problem/5228256> REGRESSION(Leopard): layout test failures: security/block-test
- mac/leopard/security: Added.
- mac/leopard/security/block-test-expected.txt: Added.
- 2:35 PM Changeset in webkit [24652] by
-
- 5 edits in trunk/WebCore
Reviewed by Adele Peterson.
<rdar://problem/5359921> WebCore should maintain a dirty flag for confirmation on unsaved changes
- bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isUserEdited]): (-[DOMHTMLTextAreaElement _isUserEdited]): Renamed _isEdited to _isUserEdited since the functionality is now different
- bindings/objc/DOMPrivate.h: Renamed _isEdited to _isUserEdited.
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): Defaulted m_userEdited to false
(WebCore::RenderTextControl::updateFromElement):
Set m_userEdited to false, since the change wasn't triggered first by an edit
(WebCore::RenderTextControl::subtreeHasChanged):
Set m_userEdited to true, since it has been touched by the user
- rendering/RenderTextControl.h: (WebCore::RenderTextControl::isUserEdited): (WebCore::RenderTextControl::setUserEdited): Added two new methods to set/return the userEdited boolean value.
- 2:21 PM Changeset in webkit [24651] by
-
- 4 edits in trunk/WebCore
Reviewed by Beth Dakin.
Fixed NULL-dereference crash seen on buildbot.
No bug filed because this is a part of <rdar://problem/5241167>.
- history/PageCache.h: (WebCore::PageCache::get): NULL-check HistoryItems passed to get() and remove(), to match the old semantics of HashMap. For clarity, ASSERT that add() is not called with NULL arguments.
- 2:18 PM Changeset in webkit [24650] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Adam.
- Lars wanted this check for Qt but it breaks platform specific layout tests.
- Scripts/run-webkit-tests:
- 12:51 PM Changeset in webkit [24649] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver Hunt.
<rdar://problem/5361106> Crash in user style sheet when loading webpage
Null check m_frame.
- dom/Document.cpp: (WebCore::Document::stylesheetLoaded):
- 12:48 PM Changeset in webkit [24648] by
-
- 15 edits in S60/trunk/WebKit
condon, reviewed by ligman
DESC: Fix codescanner warnings
http://bugs.webkit.org/show_bug.cgi?id=14748
- BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::ActivateL):
- BrowserCore/Renderers/src/ImageRenderer.cpp: (CImageRenderer::~CImageRenderer):
- BrowserCore/Renderers/src/TextRenderer.cpp: (CTextRenderer::~CTextRenderer):
- BrowserView/src/FormDataLoginStore.cpp: (CFormDataLoginStore::ClearData):
- BrowserView/src/LoadListeners.cpp: (CWmlResourceLoadListener::SetUrlL):
- BrowserView/src/PageView.cpp: (CPageView::~CPageView):
- ChangeLog:
- Plugin/src/PluginSkin.cpp: (CPluginSkin::~CPluginSkin):
- Plugin/src/PluginWin.cpp: (CPluginWin::CreateStreamL):
- ResourceLoader/CacheSrc/HttpCacheEntry.cpp: (CHttpCacheEntry::~CHttpCacheEntry):
- ResourceLoader/inc/FileTransaction.h:
- ResourceLoader/src/BufferTransaction.cpp: (CBufferTransaction::HandleResolveComplete):
- ResourceLoader/src/FileTransaction.cpp: (CFileTransaction::DoSubmitL): (CFileTransaction::ParseFileNameL): (CFileTransaction::ContentTypeLC):
- ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::MHFRunL):
- ResourceLoader/src/UrlResponseHeaderInfo.cpp: (CUrlResponseHeaderInfo::SetResponseHeadersL):
- 10:36 AM Changeset in webkit [24647] by
-
- 2 edits in trunk/WebCore
Used `svn merge -r24646:24645' to revert project changes I accidentally
checked in.
- WebCore.xcodeproj/project.pbxproj:
- 10:26 AM Changeset in webkit [24646] by
-
- 5 edits in trunk/WebCore
Reviewed by Darin Adler.
Fixed <rdar://problem/5241167> REGRESSION: PLT 1% slower due to r21793
(global page cache cap)
I just measured a .1%-.2% regression in PLT average, but a .4% win in
PLT fastest run, so I think this regression is licked.
Surprisingly, the combination of wtf data structures I originally used
for PageCache turned out to be too slow, so I reworked PageCache to use
a hand-crafted linked list for LRU tracking (instead of ListHashSet),
to store its CachedPages in the HistoryItems to which they corresponded
(instead of using a HashMap), and to ref/deref HistoryItems manually
(instead of using RefPtr, which would ref once for every reference in
the linked list).
- history/HistoryItem.h: Added data members for PageCache data. Made PageCache a friend so it could access them. Ideally (from an encapsulation perspective), we would store this data an independent structure, but that's just too slow.
- history/PageCache.cpp: Added a hand-crafted linked list for LRU tracking. (WebCore::PageCache::PageCache): (WebCore::PageCache::add): Adopt the HistoryItem's ref when it's added. (WebCore::PageCache::remove): deref() the Historyitem when it's removed. (WebCore::PageCache::prune): (WebCore::PageCache::addToLRUList): (WebCore::PageCache::removeFromLRUList):
- history/PageCache.h: (WebCore::PageCache::get): Inlined just in case.
- 10:19 AM Changeset in webkit [24645] by
-
- 1 edit3 moves in trunk/LayoutTests
Reviewed by John Sullivan.
Stop the test from dumping load callbacks as they differ on Tiger and Leopard.
This is done by removing the call to dumpResourceLoadCallbacks and moving the test away
from the "loading" directory.
- http/tests/loading/cached-scripts-expected.txt: Removed.
- http/tests/loading/cached-scripts.html: Removed.
- http/tests/loading/resources/cached-scripts-subframe.html: Removed.
- http/tests/misc/cached-scripts-expected.txt: Copied from http/tests/loading/cached-scripts-expected.txt.
- http/tests/misc/cached-scripts.html: Copied from http/tests/loading/cached-scripts.html.
- http/tests/misc/resources/cached-scripts-subframe.html: Copied from http/tests/loading/resources/cached-scripts-subframe.html.
- 9:21 AM Changeset in webkit [24644] by
-
- 2 edits in trunk/WebCore
Launch the context menu in the right place.
- 8:00 AM Changeset in webkit [24643] by
-
- 3 edits in trunk/WebKitQt
Patch from Qing Zhao that adds a signal for history notification.
- 7:47 AM Changeset in webkit [24642] by
-
- 2 edits in trunk
Use QMAKE_LIBDIR instead of QMAKE_LFLAGS to specify the library search path for QtWebKit, as the former is portable and correctly transformed to /LIBPATH: with msvc for example.
- 6:26 AM BuildingQtOnWindows edited by
- (diff)
- 6:24 AM BuildingQtOnWindows edited by
- (diff)
- 6:06 AM BuildingQtOnWindows edited by
- (diff)
- 5:59 AM BuildingQtOnWindows edited by
- (diff)
- 5:55 AM BuildingQtOnWindows created by
- 5:51 AM QtWebKit edited by
- (diff)
- 2:41 AM Applications using WebKit edited by
- (diff)
- 2:36 AM Changeset in webkit [24641] by
-
- 3 edits in trunk
Ensure QtLauncher and DumpRenderTree are linked against the uninstalled QtWebKit library by making sure $$OUTPUT_DIR/lib appears before $QTDIR/lib in the library search path and rpath.
- 12:39 AM Changeset in webkit [24640] by
-
- 4 edits4 adds in branches/feature-branch
Reviewed by Nikolas.
http://bugs.webkit.org/show_bug.cgi?id=14312
Removing an attribute has no effect on SVG
Update the transform matrix also when transform attribute is empty.
- 12:11 AM Changeset in webkit [24639] by
-
- 2 edits in trunk/WebKitSite
- grammar fix pointed out by Mitz.
- projects/goals.html:
Jul 25, 2007:
- 11:44 PM Changeset in webkit [24638] by
-
- 2 edits1 add in trunk/WebKitSite
Rubber stamped by Adam.
Added WebKit Project Goals.
- nav.inc: added a nav link.
- projects/goals.html: Added.
- 9:32 PM WikiStart edited by
- (diff)
- 6:50 PM Changeset in webkit [24637] by
-
- 5 edits in trunk
Reviewed by Mark.
- follow-up to previous change
- kjs/ustring.cpp: (KJS::UString::operator=): Make sure to reset the length when replacing the buffer contents for a single-owned string.
WebCore:
Reviewed by Mark.
- follow-up to previous change to avoid assertion failures in debug
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseText): hold JSLock when needed (WebCore::XMLHttpRequest::open): ditto (WebCore::XMLHttpRequest::didFinishLoading): ditto (WebCore::XMLHttpRequest::didReceiveData): ditto
- xml/XMLHttpRequest.h:
- 5:08 PM Changeset in webkit [24636] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Darin.
<rdar://problem/5327912>
iDisk: Web iDisk & main iDisk appear blank
- http/tests/loading/cached-scripts-expected.txt: Added.
- http/tests/loading/cached-scripts.html: Added.
- http/tests/loading/resources: Added.
- http/tests/loading/resources/cached-scripts-subframe.html: Added.
WebCore:
Reviewed by Darin.
<rdar://problem/5327912>
iDisk: Web iDisk & main iDisk appear blank
Prepend any remaining text that scripts might have written.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
- 3:45 PM Changeset in webkit [24635] by
-
- 3 edits in branches/feature-branch/WebCore
Reviewed by Oliver.
Unify absoluteRects() of RenderSVGTSpan & RenderSVGTextPath.
The RenderSVGTextPath one was still using the old, wrong concept.
- 3:15 PM Changeset in webkit [24634] by
-
- 8 edits6 adds in trunk
LayoutTests:
Reviewed by .
- mac/leopard/Skipped: Removing some tests that were removed earlier, but checked back in accidentally. Not sure how they got back into my file though.
WebCore:
Reviewed by Tim, Darin, Oliver.
- <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
- Check for file:// urls when clicking links, not block all schemes that are treated as local.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::load):
WebKitTools:
Reviewed by Tim, Darin, Oliver.
- <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
- Change DRT to be able to intercept the requst to load so it can check if a scheme was allowed or not.
- ChangeLog:
- DumpRenderTree/DumpRenderTree.m: (createWebView): (dumpRenderTree): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setCustomPolicyDelegate:]):
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/FrameLoadDelegate.h:
- DumpRenderTree/PolicyDelegate.h: Added.
- DumpRenderTree/PolicyDelegate.m: Added. (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
- DumpRenderTree/ResourceLoadDelegate.h:
- 2:50 PM Changeset in webkit [24633] by
-
- 21 edits7 adds in trunk
Reviewed by Darin.
- JavaScriptCore part of fix for <rdar://problem/5300291> Optimize GC to reclaim big, temporary objects (like XMLHttpRequest.responseXML) quickly
Also, as a side effect of optimizations included in this patch:
- 7% speedup on JavaScript iBench
- 4% speedup on "Celtic Kane" JS benchmark
The basic idea is explained in a big comment in collector.cpp. When unusually
large objecs are allocated, we push the next GC closer on the assumption that
most objects are short-lived.
I also did the following two optimizations in the course of tuning
this not to be a performance regression:
1) Change UString::Rep to hold a self-pointer as the baseString in
the unshared case, instead of a null pointer; this removes a
number of null checks in hot code because many places already
wanted to use the rep itself or the baseString as appropriate.
2) Avoid creating duplicate StringImpls when creating a
StringInstance (the object wrapper for a JS string) or calling
their methods. Since a temporary wrapper object is made every time
a string method is called, this resulted in two useless extra
StringImpls being allocated for no reason whenever a String method
was invoked on a string value. Now we bypass those.
- kjs/collector.cpp: (KJS::): (KJS::Collector::recordExtraCost): Basics of the extra cost mechanism. (KJS::Collector::allocate): ditto (KJS::Collector::collect): ditto
- kjs/collector.h: (KJS::Collector::reportExtraMemoryCost): ditto
- kjs/array_object.cpp: (ArrayInstance::ArrayInstance): record extra cost
- kjs/internal.cpp: (KJS::StringImp::toObject): don't create a whole new StringImpl just to be the internal value of a StringInstance! StringImpls are immutable so there's no point tot his.
- kjs/internal.h: (KJS::StringImp::StringImp): report extra cost
- kjs/string_object.cpp: (KJS::StringInstance::StringInstance): new version that takes a StringImp (KJS::StringProtoFunc::callAsFunction): don't create a whole new StringImpl just to convert self to string! we already have one in the internal value
- kjs/string_object.h: report extra cost
- kjs/ustring.cpp: All changes to handle baseString being self instead of null in the unshared case. (KJS::): (KJS::UString::Rep::create): (KJS::UString::Rep::destroy): (KJS::UString::usedCapacity): (KJS::UString::usedPreCapacity): (KJS::UString::expandCapacity): (KJS::UString::expandPreCapacity): (KJS::UString::UString): (KJS::UString::append): (KJS::UString::operator=): (KJS::UString::copyForWriting):
- kjs/ustring.h: (KJS::UString::Rep::baseIsSelf): new method, now that baseString is self instead of null in the unshared case we can't just null check. (KJS::UString::Rep::data): adjusted as mentioned above (KJS::UString::cost): new method to compute the cost for a UString, for use by StringImpl.
- kjs/value.cpp: (KJS::jsString): style fixups. (KJS::jsOwnedString): new method, use this for strings allocated from UStrings held by the parse tree. Tracking their cost as part of string cost is pointless, because garbage collecting them will not actually free the relevant string buffer.
- kjs/value.h: prototyped jsOwnedString.
- kjs/nodes.cpp: (StringNode::evaluate): use jsOwnedString as appropriate (RegExpNode::evaluate): ditto (PropertyNameNode::evaluate): ditto (ForInNode::execute): ditto
- JavaScriptCore.exp: Exported some new symbols.
WebCore:
Reviewed by Darin.
- fixed <rdar://problem/5300291> Optimize GC to reclaim big, temporary objects (like XMLHttpRequest.responseXML) quickly
With this plus related JavaScriptCore changes, a number of XMLHttpRequest situations that
result in huge data sets are addressed, including a single huge responseXML on an XMR done
repeatedly, or accessing responseText repeatedly during loading of a single large XHR.
In addition to the GC changes in JavaScriptCore, I changed responseText to be stored as a
KJS::UString instead of a WebCore::String so that the JavaScript responseText value can
share the buffer (indeed multiple intermediate responseTexts can share its buffer).
First of all, here's some manual test cases that will each blow out the process VM without this fix,
but will settle into decent steady state with.
- manual-tests/memory: Added.
- manual-tests/memory/MessageUidsAlreadyDownloaded2: Added.
- manual-tests/memory/string-growth.html: Added.
- manual-tests/memory/xhr-multiple-requests-responseText.html: Added.
- manual-tests/memory/xhr-multiple-requests-responseXML.html: Added.
- manual-tests/memory/xhr-multiple-requests.html: Added.
- manual-tests/memory/xhr-repeated-string-access.xml: Added.
And here's the actual code changes:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDocumentCustom.cpp: (WebCore::toJS): Record extra cost if the document is frameless (counting the nodes doesn't make a measurable performance difference here in any case I could find)
- bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::getValueProperty): Adjust for the fact that ressponseText is now stored as a UString.
- bindings/js/kjs_binding.cpp: (KJS::jsOwnedStringOrNull): New helper.
- bindings/js/kjs_binding.h:
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseText): It's a UString! (WebCore::XMLHttpRequest::getResponseXML): handle the fact that m_responseText is a UString. (WebCore::XMLHttpRequest::XMLHttpRequest): ditto. (WebCore::XMLHttpRequest::abort): call dropProtection (WebCore::XMLHttpRequest::didFinishLoading): call dropProtection (WebCore::XMLHttpRequest::dropProtection): after removing our GC protection, report extra cost of this XHR's responseText buffer.
- xml/XMLHttpRequest.h:
- 2:41 PM Changeset in webkit [24632] by
-
- 5 edits in trunk/WebCore
Reviewed by Brady.
<rdar://problem/4796657> table deletion outline does not always follow the table size as editing occurs inside
Change the outline element to position itself automaticlly using the top, left, bottom and right CSS properties.
This made the container element redundant, so it has been removed. Now the outline element and the delete button
both get appended to the target element and positioned based on that container element. This removes the need
to update the width and height when the target contents changed.
- editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::show): Change the style properties and remove the container element. (WebCore::DeleteButtonController::hide): Remove the button and outline from the target element.
- editing/DeleteButtonController.h: Removed updateOutlineStyle, respondToChangedContents and m_containerElement.
- editing/Editor.cpp: (WebCore::Editor::respondToChangedContents): Remove the call to DeleteButtonController respondToChangedContents.
- 2:35 PM Changeset in webkit [24631] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/5344471>
CrashTracer: [USER] 1 crash in Mail at WebCore::PluginTokenizer::writeRawData(char const*, int)
Make sure to layout so we'll have a renderer. Also null-check the renderer for extra safety.
- loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData):
- 1:54 PM Changeset in webkit [24630] by
-
- 4 edits in trunk/WebKit/win
2007-07-25 Ada Chan <adachan@apple.com>
Reviewed by Adam and Steve.
Implemented some DOM methods and other fixes for <rdar://problem/5311601>.
- DOMCoreClasses.cpp: (DOMNode::ownerDocument): implemented (DOMDocument::getComputedStyle): get the DOMElement via QueryInterface (DOMElement::QueryInterface):
- DOMHTMLClasses.cpp: (DOMHTMLDocument::body): fixed leak (DOMHTMLFormElement::action): implemented (DOMHTMLFormElement::method): ditto (DOMHTMLInputElement::form): ditto (DOMHTMLTextAreaElement::form): ditto
- Interfaces/DOMHTML.idl: IDOMHTMLInputElement should inherit from IDOMHTMLElement
- 1:12 PM Changeset in webkit [24629] by
-
- 2 edits in trunk/WebKitTools
Fix build for some reported systems.
- 1:02 PM BuildingGdk edited by
- (diff)
- 12:14 PM Changeset in webkit [24628] by
-
- 4 edits in branches/feature-branch/WebCore
Reviewed by Sam.
Let <textPath> be recognized within the ObjC bindings.
Forgot to add that months ago.
- 12:07 PM Changeset in webkit [24627] by
-
- 2 edits in trunk/LayoutTests
Reviewed by .
- mac/leopard/Skipped: Removing some tests that were removed earlier, but checked back in accidentally. Not sure how they got back into my file though.
- 12:01 PM Changeset in webkit [24626] by
-
- 1 edit in trunk/LayoutTests/mac/leopard/Skipped
- 11:48 AM Changeset in webkit [24625] by
-
- 2 edits in trunk/LayoutTests
Reviewed by .
- mac/leopard/Skipped: Adding to skip list to avoid false failure
- 9:54 AM Changeset in webkit [24624] by
-
- 6 edits in trunk/WebCore
Reviewed by Maciej, Darin.
Add ResourceHandle::setClient to resolve some messiness with handle
releasing. Clear the client when ResourceLoader is going to release
the handle to prevent crashes in the case where somebody still holds a
reference (this doesn't seem to currently happen in practice). Add
NULL-checking for ResourceHandle implementations using the client.
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::releaseResources):
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::fireBlockedFailure): (WebCore::ResourceHandle::setClient):
- platform/network/ResourceHandle.h:
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::willCacheResponse): (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::receivedCancellation):
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::didCancelAuthenticationChallenge): (WebCore::ResourceHandle::receivedCancellation): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
- 8:52 AM Changeset in webkit [24623] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=11756 <rdar://problem/5286420>
Fix a typo error to really compare the present domain to the domain of the parent of the targeted frame.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::canTarget):
- 8:50 AM Changeset in webkit [24622] by
-
- 2 edits in trunk/LayoutTests
Reviewed by .
- Reverted
- win/Skipped:
- 8:49 AM Changeset in webkit [24621] by
-
- 4 edits4 adds in trunk
LayoutTests:
Reviewed by Darin.
- test for http://bugs.webkit.org/show_bug.cgi?id=14758 REGRESSION: Repeated text after line break on facebook.com
- fast/text/reset-emptyRun-expected.checksum: Added.
- fast/text/reset-emptyRun-expected.png: Added.
- fast/text/reset-emptyRun-expected.txt: Added.
- fast/text/reset-emptyRun.html: Added.
WebCore:
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=14758 REGRESSION: Repeated text after line break on facebook.com
Test: fast/text/reset-emptyRun.html
- platform/BidiResolver.h: (WebCore::::deleteRuns): Re-add a line that was removed for no reason at all during refactoring in r24485.
- rendering/bidi.cpp: (WebCore::BidiState::deleteRuns): Ditto.
- 8:44 AM Changeset in webkit [24620] by
-
- 2 edits in trunk/LayoutTests
Reviewed by .
- Forgot to checking the changes to the skipped list so the win bot doesn't fail.
- win/Skipped:
- 2:57 AM Changeset in webkit [24619] by
-
- 8 edits6 deletes in trunk
Roll out r24618 as it broke 600+ layout tests.
- 2:08 AM Changeset in webkit [24618] by
-
- 8 edits6 adds in trunk
LayoutTests:
Reviewed by Oliver.
- <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
- Tests that feed:// urls can still be followed when clicked.
- http/tests/security/feed-urls-from-remote-expected.txt: Added.
- http/tests/security/feed-urls-from-remote.html: Added.
- http/tests/security/resources/feed.html: Added.
- http/tests/security/resources/feed.xml: Added.
- win/Skipped:
WebCore:
Reviewed by Oliver.
- <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
- Check for file:// urls when clicking links, not block all schemes that are treated as local.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::load):
WebKitTools:
Reviewed by Oliver.
- <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
- Change DRT to be able to intercept the requst to load so it can check if a scheme was allowed or not.
- ChangeLog:
- DumpRenderTree/DumpRenderTree.m: (createWebView): (dumpRenderTree): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setCustomPolicyDelegate:]):
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/FrameLoadDelegate.h:
- DumpRenderTree/PolicyDelegate.h: Added.
- DumpRenderTree/PolicyDelegate.m: Added. (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
- DumpRenderTree/ResourceLoadDelegate.h:
Jul 24, 2007:
- 10:38 PM Changeset in webkit [24617] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Adam Roben
<rdar://problem/5313504> - Some Back/Forward tests fail on Leopard
- mac/leopard/Skipped: Remove from the skipped list as they work now
- 9:37 PM Changeset in webkit [24616] by
-
- 13 edits in trunk
WebCore:
Reviewed by Adam and Justin.
<rdar://problem/5141779> WebView editableDOMRangeForPoint: & moveDragCaretToPoint: returns last position in DOMText range
Remove bridge implementation for editableDOMRangeForPoint: and moveDragCaretToPoint:.
Now use cross-platform code Editor::rangeForPoint and DragController::placeDragCaret instead.
This required lifting local code from DragController.cpp into the shared methods
Frame::visiblePositionForPoint and Frame::documentAtPoint.
- WebCore.exp:
- editing/Editor.cpp: (WebCore::Editor::rangeForPoint):
- editing/Editor.h:
- page/DragController.cpp: (WebCore::DragController::dragEnded): (WebCore::DragController::performDrag): (WebCore::DragController::dragEnteredOrUpdated): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::operationForLoad): (WebCore::setSelectionToDragCaret): (WebCore::DragController::concludeDrag): (WebCore::DragController::placeDragCaret):
- page/DragController.h:
- page/Frame.cpp: (WebCore::Frame::visiblePositionForPoint): (WebCore::Frame::documentAtPoint):
- page/Frame.h:
- page/mac/WebCoreFrameBridge.h:
- page/mac/WebCoreFrameBridge.mm:
WebKit:
Reviewed by Adam and Justin.
<rdar://problem/5141779> WebView editableDOMRangeForPoint: & moveDragCaretToPoint: returns last position in DOMText range
editableDOMRangeForPoint:, moveDragCaretToPoint:, and removeDragCaret now call directly into
WebCore without relying on bridge look up through the now removed _bridgeAtPoint:.
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebView.mm: (-[WebView moveDragCaretToPoint:]): (-[WebView removeDragCaret]): (-[WebView editableDOMRangeForPoint:]):
- 6:22 PM Changeset in webkit [24615] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Adam Roben.
Remove unused .strip files.
- WebCore.xcodeproj/project.pbxproj:
- 6:21 PM Changeset in webkit [24614] by
-
- 1 copy in tags/Safari-522.14.3b
New tag.
- 6:20 PM Changeset in webkit [24613] by
-
- 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION
Bump version for submit
- 6:20 PM Changeset in webkit [24612] by
-
- 2 edits in trunk/LayoutTests
Adding to the Leopard skip list to avoid a test that hangs due to a CFNetwork bug.
- mac/leopard/Skipped:
- 6:10 PM Changeset in webkit [24611] by
-
- 1 copy in tags/Safari-522.15.5b
New tag.
- 6:04 PM Changeset in webkit [24610] by
-
- 1 edit in trunk/LayoutTests/mac/leopard/Skipped
Updating skipped list
- 5:53 PM Changeset in webkit [24609] by
-
- 3 edits in trunk/LayoutTests
Updating test to put JS code in the onload handler helps to avoid intermittent failures.
<rdar://problem/5313531> REGRESSION(Leopard): editing/pasteboard/copy-in-password-field.html sometimes fails
- editing/pasteboard/copy-in-password-field-expected.txt:
- editing/pasteboard/copy-in-password-field.html:
- 5:02 PM Changeset in webkit [24608] by
-
- 3 edits2 adds in trunk
LayoutTests:
Reviewed by Hyatt.
Test for <rdar://problem/5308492> Computed width for elements with box-sizing: border-box is not equal to the width set in the CSS
- fast/css/getComputedStyle-border-box-expected.txt: Added.
- fast/css/getComputedStyle-border-box.html: Added.
WebCore:
Reviewed by Hyatt.
Fix for <rdar://problem/5308492> Computed width for elements with box-sizing: border-box is not equal to the width set in the CSS
Test: fast/css/getComputedStyle-border-box.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): For the width and height properties, when you get the value from the renderer, use the renderer's box sizing value to determine the size.
- 4:36 PM Changeset in webkit [24607] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Decker.
<rdar://problem/5355781>
REGRESSION: reproducible crash in CoreFoundation!CFRunLoopFinished on Flash pages
Null check the loader.
- plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::start):
- 4:31 PM Changeset in webkit [24606] by
-
- 2 edits in trunk/WebKit
Reviewed by Anders.
<rdar://problem/4699455> REGRESSION (Safari 2->Safari 3): Adobe Reader 7.0.8 plug-in doesn't work
- Plugins/WebNetscapePluginEmbeddedView.h: Added a #define that renames this class to "WebNetscapePluginDocumentView" This is necessary because the Adobe 7.x Acrobat plug-in has a hard coded check for a view named "WebNetscapePluginDocumentView" and will not function correctly if it doesn't find a view in the hierarchy without the old class name.
- 3:59 PM Changeset in webkit [24605] by
-
- 12 edits105 adds in branches/feature-branch
Reviewed by Oliver.
Fix all known bugs regarding to SVG text selection, when embedded in XHTML.
Also fix inspecting <text> elements when embedded in XHTML. (WebInspector)
- 3:23 PM Changeset in webkit [24604] by
-
- 103 edits4 adds in trunk
LayoutTests:
Reviewed by Hyatt and Adam.
Added and updated tests for <rdar://problem/5130590> REGRESSION: style="width:1px" on <select> element no longer hides the element
The metrics have changed for the anonymous block inside popup buttons.
- fast/forms/menulist-narrow-width-expected.checksum: Added.
- fast/forms/menulist-narrow-width-expected.png: Added.
- fast/forms/menulist-narrow-width-expected.txt: Added.
- fast/forms/menulist-narrow-width.html: Added.
- editing/pasteboard/4641033-expected.txt:
- editing/pasteboard/4944770-1-expected.txt:
- editing/pasteboard/4944770-2-expected.txt:
- editing/pasteboard/select-element-1-expected.txt:
- editing/selection/caret-before-select-expected.txt:
- editing/selection/replaced-boundaries-3-expected.txt:
- editing/selection/select-box-expected.txt:
- editing/selection/select-element-paragraph-boundary-expected.txt:
- fast/block/float/float-avoidance-expected.txt:
- fast/block/margin-collapse/103-expected.txt:
- fast/forms/001-expected.checksum:
- fast/forms/001-expected.png:
- fast/forms/001-expected.txt:
- fast/forms/003-expected.txt:
- fast/forms/004-expected.txt:
- fast/forms/HTMLOptionElement_label01-expected.txt:
- fast/forms/HTMLOptionElement_label02-expected.txt:
- fast/forms/HTMLOptionElement_label03-expected.txt:
- fast/forms/HTMLOptionElement_label04-expected.txt:
- fast/forms/HTMLOptionElement_label06-expected.txt:
- fast/forms/HTMLOptionElement_label07-expected.txt:
- fast/forms/control-restrict-line-height-expected.txt:
- fast/forms/disabled-select-change-index-expected.txt:
- fast/forms/form-element-geometry-expected.txt:
- fast/forms/menulist-separator-painting-expected.txt:
- fast/forms/menulist-width-change-expected.txt:
- fast/forms/option-script-expected.txt:
- fast/forms/option-strip-whitespace-expected.txt:
- fast/forms/option-text-clip-expected.txt:
- fast/forms/select-accesskey-expected.txt:
- fast/forms/select-align-expected.txt:
- fast/forms/select-baseline-expected.txt:
- fast/forms/select-change-listbox-to-popup-expected.txt:
- fast/forms/select-disabled-appearance-expected.txt:
- fast/forms/select-initial-position-expected.txt:
- fast/forms/select-selected-expected.txt:
- fast/forms/select-size-expected.txt:
- fast/forms/select-style-expected.txt:
- fast/forms/select-visual-hebrew-expected.txt:
- fast/forms/select-writing-direction-natural-expected.txt:
- fast/forms/stuff-on-my-optgroup-expected.txt:
- fast/html/keygen-expected.txt:
- fast/invalid/014-expected.txt:
- fast/invalid/residual-style-expected.txt:
- fast/parser/document-write-option-expected.txt:
- fast/replaced/replaced-breaking-expected.txt:
- fast/replaced/replaced-breaking-mixture-expected.txt:
- fast/replaced/three-selects-break-expected.txt:
- fast/replaced/width100percent-expected.txt:
- fast/text/international/bidi-menulist-expected.txt:
- http/tests/navigation/anchor-basic-expected.txt:
- http/tests/navigation/anchor-frames-expected.txt:
- http/tests/navigation/anchor-goback-expected.txt:
- http/tests/navigation/anchor-subframeload-expected.txt:
- http/tests/navigation/javascriptlink-basic-expected.txt:
- http/tests/navigation/javascriptlink-frames-expected.txt:
- http/tests/navigation/javascriptlink-goback-expected.txt:
- http/tests/navigation/javascriptlink-subframeload-expected.txt:
- http/tests/navigation/metaredirect-basic-expected.txt:
- http/tests/navigation/metaredirect-frames-expected.txt:
- http/tests/navigation/metaredirect-goback-expected.txt:
- http/tests/navigation/metaredirect-subframeload-expected.txt:
- http/tests/navigation/post-goback2-expected.txt:
- http/tests/navigation/postredirect-goback2-expected.txt:
- http/tests/navigation/redirect302-basic-expected.txt:
- http/tests/navigation/redirect302-frames-expected.txt:
- http/tests/navigation/redirect302-goback-expected.txt:
- http/tests/navigation/redirect302-subframeload-expected.txt:
- http/tests/navigation/relativeanchor-basic-expected.txt:
- http/tests/navigation/relativeanchor-frames-expected.txt:
- http/tests/navigation/relativeanchor-goback-expected.txt:
- http/tests/navigation/slowmetaredirect-basic-expected.txt:
- http/tests/navigation/slowtimerredirect-basic-expected.txt:
- http/tests/navigation/success200-basic-expected.txt:
- http/tests/navigation/success200-frames-expected.txt:
- http/tests/navigation/success200-frames-loadsame-expected.txt:
- http/tests/navigation/success200-goback-expected.txt:
- http/tests/navigation/success200-loadsame-expected.txt:
- http/tests/navigation/success200-reload-expected.txt:
- http/tests/navigation/success200-subframeload-expected.txt:
- http/tests/navigation/timerredirect-basic-expected.txt:
- http/tests/navigation/timerredirect-frames-expected.txt:
- http/tests/navigation/timerredirect-goback-expected.txt:
- http/tests/navigation/timerredirect-subframeload-expected.txt:
- tables/mozilla/bugs/bug1188-expected.txt:
- tables/mozilla/bugs/bug18359-expected.txt:
- tables/mozilla/bugs/bug2479-3-expected.txt:
- tables/mozilla/bugs/bug2479-4-expected.txt:
- tables/mozilla/bugs/bug29326-expected.txt:
- tables/mozilla/bugs/bug33855-expected.txt:
- tables/mozilla/bugs/bug4382-expected.txt:
- tables/mozilla/bugs/bug96334-expected.txt:
- tables/mozilla/core/margins-expected.txt:
- tables/mozilla/dom/tableDom-expected.txt:
- tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
WebCore:
Reviewed by Hyatt and Adam.
Fix for <rdar://problem/5130590> REGRESSION: style="width:1px" on <select> element no longer hides the element
Removed hack that forced large padding on popup buttons. Now we put that padding in the inner block, so that
the specified width will be honored.
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle): Set the padding on the inner block based on the metrics provided by the theme. (WebCore::RenderMenuList::controlClipRect): Clip to the intersection of the inner content box and the outer content box. This will leave room for the arrows which sit in the inner box padding, and if the inner box ever spills out of the outer box, that will get clipped too. (WebCore::RenderMenuList::calcPrefWidths): Add in the inner box's padding and border to the pref widths.
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuList): Only inflate the rect for the shadow if the rect is big enough to fit the whole control. Also, on Leopard, the NSCell will draw outside of a small rect, so add a clip for that case. (WebCore::RenderThemeMac::paintMenuListButton): Restrict font scale to make sure the arrows will actually fit in the bounds vertically. Don't draw the arrows if they won't fit horizontally. Reset padding. Since WinIE doesn't honor padding for popups, its not critical to support padding at this time. (WebCore::RenderThemeMac::adjustMenuListStyle): Don't set the padding here. Instead, we're going to set the padding on the inner block of the select. (WebCore::RenderThemeMac::adjustMenuListButtonStyle): ditto. (WebCore::RenderThemeMac::popupInternalPaddingLeft): Added. Provides internal padding values for RenderMenuList. (WebCore::RenderThemeMac::popupInternalPaddingRight): ditto. (WebCore::RenderThemeMac::popupInternalPaddingTop): ditto. (WebCore::RenderThemeMac::popupInternalPaddingBottom): ditto.
- rendering/RenderThemeMac.h:
- rendering/RenderThemeSafari.cpp: The same changes that were made to RenderThemeMac were made here, with variations for the arrow differences. This code should be refactored and shared, but now did not seem like the right time to do that refactoring. (WebCore::RenderThemeSafari::paintMenuList): (WebCore::RenderThemeSafari::paintMenuListButton): (WebCore::RenderThemeSafari::adjustMenuListStyle): (WebCore::RenderThemeSafari::popupInternalPaddingLeft): (WebCore::RenderThemeSafari::popupInternalPaddingRight): (WebCore::RenderThemeSafari::popupInternalPaddingTop): (WebCore::RenderThemeSafari::popupInternalPaddingBottom): (WebCore::RenderThemeSafari::adjustMenuListButtonStyle):
- rendering/RenderThemeSafari.h:
- rendering/RenderTheme.h: Added to provide internal padding values for RenderMenuList. (WebCore::RenderTheme::popupInternalPaddingLeft): (WebCore::RenderTheme::popupInternalPaddingRight): (WebCore::RenderTheme::popupInternalPaddingTop): (WebCore::RenderTheme::popupInternalPaddingBottom):
- 1:58 PM Changeset in webkit [24603] by
-
- 4 edits2 adds2 deletes in trunk/WebCore
replace the makeprop and makevalues shell scripts by equivalent perl versions. This is required to remove the last shell dependency when building QtWebKit on Windows.
- 1:43 PM Changeset in webkit [24602] by
-
- 2 edits in trunk/WebKit/win
Removed touch of WebKit.rc to prevent rebuilds of the rc file.
The autoversion info can get slightly out of date now, but this isn't a huge problem relative to the rebuilds.
Rubber-stamped by Adam.
- WebKit.vcproj/WebKit.vcproj:
- 1:05 PM Changeset in webkit [24601] by
-
- 1 copy in tags/Safari-522.15.4b
New tag.
- 12:49 PM Changeset in webkit [24600] by
-
- 3 edits in trunk/WebKitQt
These are no longer necessary or used.
- 12:03 PM Changeset in webkit [24599] by
-
- 3 edits8 adds in trunk
LayoutTests:
Reviewed by Darin.
Tests for http://bugs.webkit.org/show_bug.cgi?id=14714 REGRESSION:
ASSERTION FAILED: i < size() in Vector.h:401 on negative -webkit-
column-width
- and - http://bugs.webkit.org/show_bug.cgi?id=14718 REGRESSION: ASSERTION FAILED: i < size() in Vector.h:401 on zero -webkit-column-count
- fast/multicol/negativeColumnWidth-expected.checksum: Added.
- fast/multicol/negativeColumnWidth-expected.png: Added.
- fast/multicol/negativeColumnWidth-expected.txt: Added.
- fast/multicol/negativeColumnWidth.html: Added.
- fast/multicol/zeroColumnCount-expected.checksum: Added.
- fast/multicol/zeroColumnCount-expected.png: Added.
- fast/multicol/zeroColumnCount-expected.txt: Added.
- fast/multicol/zeroColumnCount.html: Added.
WebCore:
Reviewed by Darin.
Fix for http://bugs.webkit.org/show_bug.cgi?id=14714 REGRESSION:
ASSERTION FAILED: i < size() in Vector.h:401 on negative -webkit-
column-width
- and - http://bugs.webkit.org/show_bug.cgi?id=14718 REGRESSION: ASSERTION FAILED: i < size() in Vector.h:401 on zero -webkit-column-count
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcColumnWidth): Make 1 the minimum value for column-width and column-count. Since the spec does not address what to do with negative values for these properties, we are patching the rendering code instead of the parser.
- 11:49 AM Changeset in webkit [24598] by
-
- 2 edits in S60/branches/3.1m/WebCore
2007-07-20 vmalaiya, <vikram.malaiya@nokia.com>
Reviewed by Yongjun
DESC: JPKN-6Z38E5 - Browser crashes and problems with memory low note.
Fix - Remove Nokia specific changes so that the name chache is updated before
an attempt to retrieve information from it.
- khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::namedItems):
- 11:47 AM Changeset in webkit [24597] by
-
- 2 edits in S60/trunk/WebCore
2007-07-20 vmalaiya, <vikram.malaiya@nokia.com>
Reviewed by Yongjun
DESC: JPKN-6Z38E5 - Browser crashes and problems with memory low note.
Fix - Remove Nokia specific changes so that the name chache is updated before
an attempt to retrieve information from it.
- khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::namedItems):
- 11:44 AM Changeset in webkit [24596] by
-
- 2 edits in trunk/WebCore
Reviewed by Steve.
<rdar://problem/5355403>
REGRESSION: 303A2 does not display pdf files with AdobeReader 8.1
Close the file before handing off the file name to the plug-in.
- plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::destroyStream):
- 11:29 AM Changeset in webkit [24595] by
-
- 3 edits in trunk/WebCore
2007-07-24 Alp Toker <alp.toker@collabora.co.uk>
Reviewed by Adam.
http://bugs.webkit.org/show_bug.cgi?id=14711
RenderThemeGdk's buttons are state-agnostic (pressed, hovered)
Remove unnecessary label from widget instances.
Render check and radio widgets correctly.
Determine the widget state and render it appropriately.
- platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::determineState): (WebCore::RenderThemeGdk::paintCheckbox): (WebCore::RenderThemeGdk::paintRadio): (WebCore::RenderThemeGdk::paintButton): (WebCore::RenderThemeGdk::gtkButton): (WebCore::RenderThemeGdk::gtkCheckbox): (WebCore::RenderThemeGdk::gtkRadioButton):
- platform/gdk/RenderThemeGdk.h:
- 9:55 AM Applications using WebKit edited by
- Including PageOutline (diff)
- 7:52 AM Changeset in webkit [24594] by
-
- 1 copy in tags/JavaScriptCore-419.2.1/JavaScriptCore
New tag (part 2).
- 7:51 AM Changeset in webkit [24593] by
-
- 1 add in tags/JavaScriptCore-419.2.1
New tag (part 1).
- 7:51 AM Changeset in webkit [24592] by
-
- 1 copy in tags/JavaScriptCore-418.6.1/JavaScriptCore
New tag (part 2).
- 7:50 AM Changeset in webkit [24591] by
-
- 1 add in tags/JavaScriptCore-418.6.1
New tag (part 1).
- 7:48 AM Changeset in webkit [24590] by
-
- 2 edits in branches/Safari-2.0-dashboard/JavaScriptCore
Versioning.
- 7:47 AM Changeset in webkit [24589] by
-
- 2 edits in branches/Safari-2.0-dashboard/JavaScriptCore
2007-07-25 Mark Rowe <mrowe@apple.com>
Build fix for GCC 3.3.
- pcre/pcre_compile.c: Remove unused variables.
- 7:44 AM Changeset in webkit [24588] by
-
- 2 edits in branches/Safari-2.0-system/JavaScriptCore
Versioning.
- 7:44 AM Changeset in webkit [24587] by
-
- 2 edits in branches/Safari-2.0-system/JavaScriptCore
2007-07-25 Mark Rowe <mrowe@apple.com>
Build fix for GCC 3.3.
- pcre/pcre_compile.c: Remove unused variables.
- 5:56 AM Changeset in webkit [24586] by
-
- 82 edits in trunk/WebCore/page/inspector/Images
Set the correct svn:mime-type on WebCore/page/inspector/Images/*.png
- 5:21 AM Changeset in webkit [24585] by
-
- 5 edits in trunk
2007-07-24 Mark Rowe <mrowe@apple.com>
Reviewed by Antti.
<rdar://problem/5356666> NSMenuItem's seen leaking on buildbot
- platform/mac/ContextMenuItemMac.mm: (WebCore::ContextMenuItem::releasePlatformDescription): Transfer ownership from the RetainPtr's CF-based retain count to the Foundation retain count so that callers of releasePlatformDescription can use -[NSObject release] to dispose of it in a manner that won't leak under Obj-C GC.
- platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::appendItem): Release platformItem as we were transferred its ownership by releasePlatformDescription. (WebCore::ContextMenu::insertItem): ditto.
2007-07-24 Mark Rowe <mrowe@apple.com>
Reviewed by Antti.
<rdar://problem/5356666> NSMenuItem's seen leaking on buildbot
- WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::contextMenuItemSelected): Release platformItem as we were transferred its ownership by releasePlatformDescription.
- 4:47 AM Changeset in webkit [24584] by
-
- 2 edits in trunk/WebCore
Roll out r24583, it needs further consideration.
- 4:42 AM BuildingOnLinux edited by
- (diff)
- 4:40 AM Changeset in webkit [24583] by
-
- 2 edits in trunk/WebCore
2007-07-24 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver.
<rdar://problem/5356666> NSMenuItem's seen leaking on buildbot
- platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::appendItem): Release the platformItem after we take ownership of it from the ContextMenuItem.
- 3:38 AM BuildingOnLinux edited by
- (diff)
- 3:36 AM BuildingOnLinux created by
- 3:23 AM WikiStart edited by
- (diff)
- 2:55 AM Changeset in webkit [24582] by
-
- 34 edits6 adds2 deletes in trunk
2007-07-24 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=14684 Hebrew text in Safari chrome is reversed (LTR instead of RTL)
Test: fast/text/drawBidiText.html
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- manual-tests/chrome-bidi-text.html: Added.
- manual-tests/resources/chrome-bidi-text-window.html: Added.
- platform/BidiReorderCharacters.cpp: Removed.
- platform/BidiReorderCharacters.h: Removed.
- platform/BidiResolver.h: (WebCore::BidiCharacterRun::start): Added accessor method. (WebCore::BidiCharacterRun::stop): Ditto. (WebCore::BidiCharacterRun::level): Ditto. (WebCore::BidiCharacterRun::next): Ditto. (WebCore::::appendRun): Added default implementation.
- platform/TextStyle.h: (WebCore::TextStyle::setDirectionalOverride): Added accessor method.
- platform/graphics/GraphicsContext.cpp: (WebCore::TextRunIterator::TextRunIterator): Added. A BidiResolver- compliant iterator over the characters in a TextRun. (WebCore::TextRunIterator::offset): (WebCore::TextRunIterator::increment): (WebCore::TextRunIterator::atEnd): (WebCore::TextRunIterator::current): (WebCore::TextRunIterator::direction): (WebCore::TextRunIterator::operator==): (WebCore::TextRunIterator::operator!=): (WebCore::GraphicsContext::drawBidiText): Added. Applies the Unicode Bidi Algorithm to the text and draws the resulting unidirectional runs in the right order and with the right directionality.
- platform/graphics/GraphicsContext.h:
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint): Replaced the use of a character buffer and BidiReorderCharacters with calling to drawBidiText(). Removed special handling of '-webkit-rtl-ordering:visual' because that CSS property is an implementation detail of WebCore's visual Hebrew support, and the UA stylesheet sets it to 'logical' for this form control. Authors can specify the ordering using the 'direction' and 'unicode-bidi' properties.
- platform/win/WebCoreTextRenderer.cpp: (WebCore::isOneLeftToRightRun): Added. Checks if the text consists of a single left-to-right run, in which case it requires no bidi processing. (WebCore::doDrawTextAtPoint): Changed to call drawBidiText if the text is not entirely left-to-right.
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): Replaced the use of a character buffer in BidiReorderCharacters with calling to drawBidiText(). Removed special handling of '-webkit-rtl-ordering:visual' for the same reason stated above.
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): Ditto. Also changed the run-rounding modes used when drawing to match those used when measuring.
2007-07-24 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- test, updated tests and updated results for http://bugs.webkit.org/show_bug.cgi?id=14684 Hebrew text in Safari chrome is reversed (LTR instead of RTL)
- fast/forms/HTMLOptionElement_label05-expected.checksum:
- fast/forms/HTMLOptionElement_label05-expected.png:
- fast/forms/listbox-deselect-scroll-expected.checksum:
- fast/forms/listbox-deselect-scroll-expected.png:
- fast/forms/listbox-width-change-expected.checksum:
- fast/forms/listbox-width-change-expected.png:
- fast/forms/option-strip-whitespace-expected.checksum:
- fast/forms/option-strip-whitespace-expected.png:
- fast/forms/select-change-popup-to-listbox-expected.checksum:
- fast/forms/select-change-popup-to-listbox-expected.png:
- fast/forms/select-initial-position-expected.checksum:
- fast/forms/select-initial-position-expected.png:
- fast/text/drawBidiText-expected.checksum: Added.
- fast/text/drawBidiText-expected.png: Added.
- fast/text/drawBidiText-expected.txt: Added.
- fast/text/drawBidiText.html: Added.
- fast/text/international/bidi-listbox-atsui-expected.checksum:
- fast/text/international/bidi-listbox-atsui-expected.png:
- fast/text/international/bidi-listbox-atsui-expected.txt:
- fast/text/international/bidi-listbox-atsui.html: Removed the visual ordering cases.
- fast/text/international/bidi-listbox-expected.checksum:
- fast/text/international/bidi-listbox-expected.png:
- fast/text/international/bidi-listbox-expected.txt:
- fast/text/international/bidi-listbox.html: Removed the visual ordering cases because the patch removed special handling of visual ordering.
- 2:29 AM Changeset in webkit [24581] by
-
- 1 copy in tags/JavaScriptCore-4522.10.1/JavaScriptCore
New tag (part 2).
- 2:29 AM Changeset in webkit [24580] by
-
- 1 add in tags/JavaScriptCore-4522.10.1
New tag (part 1).
- 2:28 AM Changeset in webkit [24579] by
-
- 1 edit in branches/Safari-522/JavaScriptCore/Configurations/Version.xcconfig
Versioning.
- 2:28 AM Changeset in webkit [24578] by
-
- 6 edits in branches/Safari-522/JavaScriptCore
2007-07-24 Mark Rowe <mrowe@apple.com>
Merge r24453.
2007-07-19 Darin Adler <Darin Adler>
Reviewed by Geoff.
- fix <rdar://problem/5345440> PCRE computes wrong length for expressions with quantifiers on named recursion or subexpressions
It's challenging to implement proper preflighting for compiling these advanced features.
But we don't want them in the JavaScript engine anyway.
Turned off the following features of PCRE (some of these are simply parsed and not implemented):
\C \E \G \L \N \P \Q \U \X \Z
\e \l \p \u \z
[::] .. [==]
(?#) (?<=) (?<!) (?>)
(?C) (?P) (?R)
(?0) (and 1-9)
(?imsxUX)
Added the following:
\u \v
Because of \v, the js1_2/regexp/special_characters.js test now passes.
To be conservative, I left some features that JavaScript doesn't want, such as
\012 and \x{2013}, in place. We can revisit these later; they're not directly-enough
related to avoiding the incorrect preflighting.
I also didn't try to remove unused opcodes and remove code from the execution engine.
That could save code size and speed things up a bit, but it would require more changes.
- kjs/regexp.h:
- kjs/regexp.cpp: (KJS::RegExp::RegExp): Remove the sanitizePattern workaround for lack of \u support, since the PCRE code now has \u support.
- pcre/pcre-config.h: Set JAVASCRIPT to 1.
- pcre/pcre_internal.h: Added ESC_v.
- pcre/pcre_compile.c: Added a different escape table for when JAVASCRIPT is set that omits all the escapes we don't want interpreted and includes '\v'. (check_escape): Put !JAVASCRIPT around the code for '\l', '\L', '\N', '\u', and '\U', and added code to handle '\u2013' inside JAVASCRIPT. (compile_branch): Put !JAVASCRIPT if around all the code implementing the features we don't want. (pcre_compile2): Ditto.
- tests/mozilla/expected.html: Updated since js1_2/regexp/special_characters.js now passes.
- 2:28 AM Changeset in webkit [24577] by
-
- 2 edits in branches/Safari-522/JavaScriptCore
2007-07-24 Mark Rowe <mrowe@apple.com>
Merge r24430.
2007-07-18 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
- fix <rdar://problem/5345432> PCRE computes length wrong for expressions such as "[]"
Test: fast/js/regexp-charclass-crash.html
- pcre/pcre_compile.c: (pcre_compile2): Fix the preflight code that calls check_posix_syntax to match the actual regular expression compilation code; before it was missing the check of the first character.
- 2:15 AM Changeset in webkit [24576] by
-
- 1 copy in tags/JavaScriptCore-312.3.3/JavaScriptCore
New tag (part 2).
- 2:14 AM Changeset in webkit [24575] by
-
- 1 add in tags/JavaScriptCore-312.3.3
New tag (part 1).
- 2:13 AM Changeset in webkit [24574] by
-
- 1 edit in branches/Safari-1-3-branch/JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj
Versioning.
- 2:13 AM Changeset in webkit [24573] by
-
- 2 edits in branches/Safari-1-3-branch/JavaScriptCore
Merge fix for <rdar://problems/5355025&5355062>.
- 2:07 AM Changeset in webkit [24572] by
-
- 1 copy in tags/JavaScriptCore-419.2/JavaScriptCore
New tag (part 2).
- 2:07 AM Changeset in webkit [24571] by
-
- 1 add in tags/JavaScriptCore-419.2
New tag (part 1).
- 2:07 AM Changeset in webkit [24570] by
-
- 1 edit in branches/Safari-2.0-dashboard/JavaScriptCore/Info.plist
Versioning.
- 2:07 AM Changeset in webkit [24569] by
-
- 2 edits in branches/Safari-2.0-dashboard/JavaScriptCore
Merge fix for <rdar://problems/5354999&5355019&5355050&5355057>.
- 2:01 AM Changeset in webkit [24568] by
-
- 1 copy in tags/JavaScriptCore-418.6/JavaScriptCore
New tag (part 2).
- 2:01 AM Changeset in webkit [24567] by
-
- 1 add in tags/JavaScriptCore-418.6
New tag (part 1).
- 2:00 AM Changeset in webkit [24566] by
-
- 1 edit in branches/Safari-2.0-system/JavaScriptCore/Info.plist
Versioning.
- 2:00 AM Changeset in webkit [24565] by
-
- 2 edits in branches/Safari-2.0-system/JavaScriptCore
Merge fix for <rdar://problems/5354999&5355019&5355050&5355057>.
Jul 23, 2007:
- 11:54 PM Changeset in webkit [24564] by
-
- 2 edits in trunk/WebCore
Reviewed by Steve.
Windows build fix, remove superfluous !
- page/EventHandler.cpp: (WebCore::EventHandler::keyEvent):
- 11:31 PM Changeset in webkit [24563] by
-
- 2 edits in trunk/WebKit/win
Fixes to versioning script.
Reviewed by Ada.
- WebKit.vcproj/auto-version.sh:
- 9:11 PM Changeset in webkit [24562] by
-
- 7 edits in trunk
Implement IWebHistoryItem::[set]AlternateTitle
WebCore:
Add an assignment operator for BString that takes a BSTR
Reviewed by Geoff and Oliver.
- platform/win/BString.cpp: (WebCore::BString::operator=):
- platform/win/BString.h:
WebKit/win:
Implement IWebHistoryItem::[set]AlternateTitle
The argument types were reversed for these two methods, so I fixed that as
well.
Reviewed by Geoff and Oliver.
- Interfaces/IWebHistoryItem.idl:
- WebHistoryItem.cpp: (WebHistoryItem::setAlternateTitle): Implemented. (WebHistoryItem::alternateTitle): Implemented.
- WebHistoryItem.h:
- 8:59 PM Changeset in webkit [24561] by
-
- 3 edits8 adds in trunk
LayoutTests:
Reviewed by Geoff.
<rdar://problem/5354455> Word selection when right-clicking can be confusing (14728)
- editing/selection/5354455-1-expected.checksum: Added.
- editing/selection/5354455-1-expected.png: Added.
- editing/selection/5354455-1-expected.txt: Added.
- editing/selection/5354455-1.html: Added.
- editing/selection/5354455-2-expected.checksum: Added.
- editing/selection/5354455-2-expected.png: Added.
- editing/selection/5354455-2-expected.txt: Added.
- editing/selection/5354455-2.html: Added.
WebCore:
Reviewed by Geoff.
<rdar://problem/5354455> Word selection when right-clicking can be confusing (14728)
- page/EventHandler.cpp: (WebCore::EventHandler::sendContextMenuEvent): In non-editable content, only do word selection over text. In editable content, we will continue to select images, line breaks and other elements on right-clicks, to match TextEdit. For now, in editable content, we'll live with the cases where positionForPoint creates selections that aren't underneath the mouse. These aren't regressions because we've always done word selection on right clicks in editable content.
- 8:09 PM Changeset in webkit [24560] by
-
- 3 edits2 adds in trunk
LayoutTests:
Reviewed by Oliver.
<rdar://problem/5335354>
REGRESSION(r21359-r21368): Can't edit inside RTEF editable region
- fast/dom/Document/open-with-pending-load-expected.txt: Added.
- fast/dom/Document/open-with-pending-load.html: Added.
WebCore:
Reviewed by Oliver.
<rdar://problem/5335354>
REGRESSION(r21359-r21368): Can't edit inside RTEF editable region
If Document::open is called and there's a pending load that has not yet started,
that load should be cancelled.
- dom/Document.cpp: (WebCore::Document::open):
- 8:01 PM Changeset in webkit [24559] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Geoff.
<rdar://problem/5121461> REGRESSION: Unable to load JigZone puzzle
- bindings/jni/jni_jsobject.cpp: (JavaJSObject::createNative):
Call RootObject::gcProtect on the global object, thereby putting it in the
"protect count" set which is used for checking if a native handle is valid.
- 7:36 PM RunWebKitTestsDesign edited by
- (diff)
- 6:22 PM Changeset in webkit [24558] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Mark.
Remove http/tests/multipart/invalid-image-data.html which no longer fails on Leopard.
- mac/leopard/Skipped:
- 6:00 PM Changeset in webkit [24557] by
-
- 6 edits in trunk/LayoutTests
<rdar://problem/5228167> REGRESSION: editing/execCommand/5119244.html failing on Leopard
Removed another use of the ⎷ entity. See below.
- editing/execCommand/5119244-expected.checksum:
- editing/execCommand/5119244-expected.png:
- editing/execCommand/5119244-expected.txt:
- editing/execCommand/5119244.html:
- mac/leopard/Skipped:
- 5:46 PM Changeset in webkit [24556] by
-
- 6 edits in trunk/LayoutTests
Reviewed by Oliver.
<rdar://problem/5228164> REGRESSION: editing/deleting/5144139-2.html fails on Leopard
Removed the use of the ⎷ entity, which is available on
Leopard but not Tiger. Perhaps because it is not available in Ahem
but is available in some fallback font that ships with Leopard but not Tiger.
It's OK to remove because its use wasn't necessary to test the fix for 5144139.
- editing/deleting/5144139-2-expected.checksum:
- editing/deleting/5144139-2-expected.png:
- editing/deleting/5144139-2-expected.txt:
- editing/deleting/5144139-2.html:
- mac/leopard/Skipped:
- 5:44 PM Changeset in webkit [24555] by
-
- 4 edits in tags/Safari-5522.12.1
Versioning.
- 5:44 PM Changeset in webkit [24554] by
-
- 4 edits in tags/Safari-5522.12.1
Merge r24545.
Build fix, newer Leopard builds expect GCC_ENABLE_OBJC_GC to have a value of 'supported'.
- 5:39 PM Changeset in webkit [24553] by
-
- 5 edits in trunk/WebKit/win
2007-07-23 Ada Chan <adachan@apple.com>
Reviewed by Steve.
Added a new text drawing method that allows caller to override the font smoothing level.
- WebKit.vcproj/WebKit.def:
- WebKit.vcproj/WebKit_debug.def:
- WebKitGraphics.cpp: (WebDrawText):
- WebKitGraphics.h:
- 5:37 PM Changeset in webkit [24552] by
-
- 4 edits in trunk/WebKitLibraries
2007-07-23 Ada Chan <adachan@apple.com>
Reviewed by Steve.
Update WebKitSystemInterface.{h,lib}.
- win/include/WebKitSystemInterface/WebKitSystemInterface.h:
- win/lib/WebKitSystemInterface.lib:
- win/lib/WebKitSystemInterface_debug.lib:
- 5:33 PM Changeset in webkit [24551] by
-
- 1 copy in tags/Safari-5522.12.1
New tag.
- 5:04 PM Changeset in webkit [24550] by
-
- 5 edits in trunk/WebCore
Reviewed by Hyatt.
<rdar://problem/5242145> REGRESSION: Clicking on symbol in documentation often doesn't scroll to symbol
A renderer for the anchor wasn't always available at the time parsing finished. So we need
to bail out of gotoAnchor if stylesheets are pending and remember to call gotoAnchor later
once all of the pending stylesheets load.
- dom/Document.cpp: (WebCore::Document::Document): Initialize m_gotoAnchorNeededAfterStylesheetsLoad to false. (WebCore::Document::stylesheetLoaded): If we have no more pending stylesheets, call gotoAnchor if needed.
- dom/Document.h: (WebCore::Document::gotoAnchorNeededAfterStylesheetsLoad): New method. (WebCore::Document::setGotoAnchorNeededAfterStylesheetsLoad): Ditto.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::gotoAnchor): Bail early if the document still has pending stylesheets.
- loader/FrameLoader.h: Make gotoAnchor() public.
- 4:16 PM Changeset in webkit [24549] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin
- fixed <rdar://problem/5327887> Printing Mail note (or Safari page) with misspelled word prints red underline
- rendering/InlineTextBox.cpp: (WebCore::InlineTextBox::paintSpellingOrGrammarMarker): When printing, bail out without doing any work. Also moved a couple of lines down below another early bailout since they were pointless above it.
- 3:17 PM Changeset in webkit [24548] by
-
- 1 copy in tags/Safari-522.15.3b
New tag.
- 2:58 PM Changeset in webkit [24547] by
-
- 2 edits in trunk/WebKitTools
Fix qt DRT to suppress js popup alerts and log instead.
- 2:35 PM Changeset in webkit [24546] by
-
- 2 edits in trunk/JavaScriptCore
- pcre/pcre_compile.c: Roll back a tiny accidental change in the unused !JAVASCRIPT side of an #ifdef. This has no effect when using PCRE in JAVASCRIPT mode as we do, but seems worth rolling back.
- 2:29 PM Changeset in webkit [24545] by
-
- 4 edits in trunk
Build fix, newer Leopard builds expect GCC_ENABLE_OBJC_GC to have a value of 'supported'.
- 2:19 PM Changeset in webkit [24544] by
-
- 6 edits in branches/Safari-522-2/JavaScriptCore
Merged fix from r24453.
- 2:15 PM Changeset in webkit [24543] by
-
- 3 edits2 copies in branches/Safari-522-2
Merged fix from r24430.
- 2:06 PM TestFormUpload created by
- 2:06 PM WebKit Team edited by
- (diff)
- 2:03 PM Changeset in webkit [24542] by
-
- 8 edits3 adds in trunk
LayoutTests:
Reviewed by Darin.
Added initial pseudo-hangul IM, and tests for behaviour of hangul (<rdar://problem/5352152>)
Updated keydown-keypress-preventDefault to be correct, and to have an demonstrate that keys have been inserted.
Updated kotoeri test to perform more validation and check against updated behaviour
- editing/input/mac/hangul-enter-confirms-and-sends-keypress-expected.txt: Added.
- editing/input/mac/hangul-enter-confirms-and-sends-keypress.html: Added.
- editing/input/mac/hangul.js: Added.
- editing/input/mac/kotoeri-enter-to-confirm-and-newline.html:
- fast/events/keydown-keypress-preventDefault-expected.txt:
- fast/events/keydown-keypress-preventDefault.html:
WebCore:
Reviewed by Darin.
<rdar://problem/5353577> WebKit key event behaviour needs to better match other browsers keyevent behaviour
<rdar://problem/5352152> REGRESSION (24399-24479): Pressing Enter in a search field at apple.com no longer starts a search with Korean IM
<rdar://problem/5352649> WebKit should send keyDown event on autorepeat keyDowns
http://bugs.webkit.org/show_bug.cgi?id=14690
Perform Input Method call first so that our behaviour is determined by whether or not
the input method has actually handle the event, rather than by making guesses based
on the existences of marked text. This fixes issues with IMs that have side effects
even on events they do not handle.
Refactored the code in order to improve clarity given the hoisting required by performing
the IM call earlier.
- page/EventHandler.cpp: (WebCore::EventHandler::keyEvent):
WebKit:
Reviewed by Darin.
We have to be able to support insertText: followed by doCommandBySelector: in
order to support the 2- and 3-Set Korean and RuSwitcher IMs at least.
- WebView/WebHTMLView.mm: (-[WebHTMLView insertText:]):
- 1:27 PM Changeset in webkit [24541] by
-
- 9 edits3 adds in trunk
LayoutTests:
Reviewed by Darin.
<rdar://problem/5045711>
http://bugs.webkit.org/show_bug.cgi?id=12938
Google calendar settings page crashes
- fast/dom/destroy-selected-radio-button-crash-expected.txt: Added.
- fast/dom/destroy-selected-radio-button-crash.html: Added.
WebCore:
Reviewed by Darin.
<rdar://problem/5045711>
http://bugs.webkit.org/show_bug.cgi?id=12938
Google calendar settings page crashes
Move handling of checked radio buttons to a new class, HTMLFormElement::CheckedRadioButtons.
Each <form> element has an instance of this class. For radio buttons without a containing
form, the document has an instance of HTMLFormElement::CheckedRadioButtons where the
state of those radio buttons will be stored.
be stored.
This also fixes another bug where removing a checked radio button that does not have a
containing form would not remove the radio button from the checked radio buttons map,
which could lead to a crash due to a dangling pointer.
- dom/Document.cpp: (WebCore::Document::~Document):
- dom/Document.h: (WebCore::Document::checkedRadioButtons):
- html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::registerFormElement): (WebCore::HTMLFormElement::removeFormElement): (WebCore::HTMLFormElement::CheckedRadioButtons::didCheckButton): (WebCore::HTMLFormElement::CheckedRadioButtons::checkedButtonForGroup): (WebCore::HTMLFormElement::CheckedRadioButtons::removeButtonIfChecked):
- html/HTMLFormElement.h: (WebCore::HTMLFormElement::checkedRadioButtons):
- html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::insertedIntoTree):
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): (WebCore::checkedRadioButtons): (WebCore::HTMLInputElement::isKeyboardFocusable): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::setChecked): (WebCore::HTMLInputElement::preDispatchEventHandler): (WebCore::HTMLInputElement::willMoveToNewOwnerDocument):
- manual-tests/remove-form-node-with-radio-buttons-crash.html: Added.
- 1:23 PM Changeset in webkit [24540] by
-
- 3 edits in trunk/WebKit
Reverting change 24535 now that a solution has been found that doesn't
involve exposing an interface unnecessarily.
- WebView/WebHTMLView.mm:
- WebView/WebHTMLViewPrivate.h:
- 11:51 AM Changeset in webkit [24539] by
-
- 4 adds in trunk/LayoutTests/fast/inline
Add layout test for continuation hang.
- 11:50 AM Changeset in webkit [24538] by
-
- 3 edits in trunk/WebCore
Fix for 5350587, hang in iExploder text 8101. The code that painted outlines for continuations was buggy
in that it assumed the chain was always inline-block-inline, but this is only true for the innermost chained
continuation. To make this more robust, we always just use the inline's containing block's containing block,
which should be guaranteed to enclose all renderers in the continuation chain. In addition, there is now a
null check (to guarantee no more hangs) and an assert (to check if we hit this situation again where the block
used to paint does not properly enclose the continuation chain).
Reviewed by beth
fast/inline/outline-continuation.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::paintContinuationOutlines):
- rendering/InlineFlowBox.cpp: (WebCore::RenderInline::paint):
- 11:16 AM Changeset in webkit [24537] by
-
- 16 edits1 move21 adds in trunk
2007-07-22 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Adam.
Add WebKit/gtk/Api and WebCoreSupport API to the INCLUDEPATH to allow GdkLauncher to be
build against it.
- WebKit.pri:
WebCore:
2007-07-22 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Adam.
WARNING: NO TEST CASES ADDED OR CHANGED
Add the WebKit/Gtk API to the buildsystem, ask qmake to create a
pkg-config file and install headers and libraries.
Start to emit signals from FrameLoaderClientGdk, hide the kit Frame
inside the the FrameLoaderClientGdk.
Move ChromeClientGdk to WebKit/gtk/WebCoreSupport
- WebCore.pro:
- loader/gdk/FrameLoaderClientGdk.cpp:
- loader/gdk/FrameLoaderClientGdk.h:
- platform/gdk/ChromeClientGdk.h: Removed.
- platform/gdk/FrameGdk.cpp: Remove code not belonging here
- platform/gdk/FrameGdk.h:
- platform/gdk/ScrollViewGdk.cpp: The gdkDrawable won't exist at that time and it is fine
- platform/gdk/TemporaryLinkStubs.cpp: Removed ChromeClientGdk stubs
WebKit:
2007-07-22 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Adam.
Add the first API and partial implementation of the WebKit/Gtk port as
of http://bugs.webkit.org/show_bug.cgi?id=14678.
The delegates of WebView will be modeled as signals. Delegates like the
WebPolicyDelegate will be implemented as signals with default handlers.
Start moving files to WebKit/gtk/WebCoreSupport.
- gtk: Added.
- gtk/Api: Added.
- gtk/Api/headers.pri: Added.
- gtk/Api/webkitgtk-marshal.list: Added.
- gtk/Api/webkitgtkdefines.h: Added.
- gtk/Api/webkitgtkframe.cpp: Added.
- gtk/Api/webkitgtkframe.h: Added.
- gtk/Api/webkitgtkframedata.cpp: Added.
- gtk/Api/webkitgtkframedata.h: Added.
- gtk/Api/webkitgtkglobal.cpp: Added.
- gtk/Api/webkitgtkglobal.h: Added.
- gtk/Api/webkitgtknetworkrequest.cpp: Added.
- gtk/Api/webkitgtknetworkrequest.h: Added.
- gtk/Api/webkitgtkpage.cpp: Added.
- gtk/Api/webkitgtkpage.h: Added.
- gtk/Api/webkitgtkprivate.cpp: Added.
- gtk/Api/webkitgtkprivate.h: Added.
- gtk/Api/webkitgtksettings.cpp: Added.
- gtk/Api/webkitgtksettings.h: Added.
- gtk/WebCoreSupport: Added.
- gtk/WebCoreSupport/ChromeClientGdk.cpp: Added. (WebCore::ChromeClientGdk::ChromeClientGdk): (WebCore::ChromeClientGdk::chromeDestroyed): (WebCore::ChromeClientGdk::windowRect): (WebCore::ChromeClientGdk::setWindowRect): (WebCore::ChromeClientGdk::pageRect): (WebCore::ChromeClientGdk::scaleFactor): (WebCore::ChromeClientGdk::focus): (WebCore::ChromeClientGdk::unfocus): (WebCore::ChromeClientGdk::createWindow): (WebCore::ChromeClientGdk::createModalDialog): (WebCore::ChromeClientGdk::show): (WebCore::ChromeClientGdk::canRunModal): (WebCore::ChromeClientGdk::runModal): (WebCore::ChromeClientGdk::setToolbarsVisible): (WebCore::ChromeClientGdk::toolbarsVisible): (WebCore::ChromeClientGdk::setStatusbarVisible): (WebCore::ChromeClientGdk::statusbarVisible): (WebCore::ChromeClientGdk::setScrollbarsVisible): (WebCore::ChromeClientGdk::scrollbarsVisible): (WebCore::ChromeClientGdk::setMenubarVisible): (WebCore::ChromeClientGdk::menubarVisible): (WebCore::ChromeClientGdk::setResizable): (WebCore::ChromeClientGdk::closeWindowSoon): (WebCore::ChromeClientGdk::canTakeFocus): (WebCore::ChromeClientGdk::takeFocus): (WebCore::ChromeClientGdk::canRunBeforeUnloadConfirmPanel): (WebCore::ChromeClientGdk::runBeforeUnloadConfirmPanel): (WebCore::ChromeClientGdk::addMessageToConsole): (WebCore::ChromeClientGdk::runJavaScriptAlert): (WebCore::ChromeClientGdk::runJavaScriptConfirm): (WebCore::ChromeClientGdk::runJavaScriptPrompt): (WebCore::ChromeClientGdk::setStatusbarText): (WebCore::ChromeClientGdk::shouldInterruptJavaScript): (WebCore::ChromeClientGdk::tabsToLinks): (WebCore::ChromeClientGdk::windowResizerRect): (WebCore::ChromeClientGdk::addToDirtyRegion): (WebCore::ChromeClientGdk::scrollBackingStore): (WebCore::ChromeClientGdk::updateBackingStore): (WebCore::ChromeClientGdk::mouseDidMoveOverElement): (WebCore::ChromeClientGdk::setToolTip): (WebCore::ChromeClientGdk::print):
- gtk/WebCoreSupport/ChromeClientGdk.h: Added.
WebKitTools:
2007-07-22 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Adam.
Make the GdkLauncher use the new WebKit/Gtk API. Change webkitdirs.pm to
honor --qmakearg for the Gdk/Gtk build as well.
- GdkLauncher/main.cpp: Switch to the new API
- Scripts/webkitdirs.pm: Allow to specify --qmakearg, e.g. to control the WEBKIT_{INC,LIB}_DIR
- 10:16 AM Changeset in webkit [24536] by
-
- 5 edits in trunk/WebKit/win
Implement IDOMElement::setAttribute
This method was mistakenly called "setResult" in DOMCore.idl, so I
fixed that as well.
Needed for <rdar://problem/5314906>.
Reviewed by Ada.
- DOMCoreClasses.cpp: (DOMElement::setAttribute): Implemented/renamed.
- DOMCoreClasses.h: Renamed setResult => setAttribute.
- DOMHTMLClasses.h: Ditto.
- Interfaces/DOMCore.idl: Ditto.
- 9:37 AM Changeset in webkit [24535] by
-
- 3 edits in trunk/WebKit
Reviewed by Oliver Hunt.
Expose [WebHTMLView hasMarkedText] to
fix <rdar://problem/4830074> autocomplete breaks Japanese typing
- WebView/WebHTMLView.mm:
- WebView/WebHTMLViewPrivate.h:
- 3:26 AM Changeset in webkit [24534] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Oliver.
- fix remaining problems with Window shadowing
- kjs/nodes.cpp: (VarDeclNode::evaluate): Tweak the special case a little.
- 1:48 AM Changeset in webkit [24533] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Oliver.
- fix Window shadowing regressions caused by the previous commit.
- kjs/nodes.cpp: (VarDeclNode::evaluate): Handle the case of global scope specially.
- 12:10 AM Changeset in webkit [24532] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Darin.
-fixed <rdar://problem/5353293> REGRESSION (r24287): 1% i-Bench JS slowdown from JavaScript compatibility fix (14719)
http://bugs.webkit.org/show_bug.cgi?id=14719
My fix for this actually resulted in JS iBench being 1% faster than before the regression
and the Celtic Kane benchmark being 5% faster than before the regression.
- kjs/nodes.cpp: (VarDeclNode::handleSlowCase): factored out the slow code path to be out of line. (VarDeclNode::evaluate): I did a couple of things: (1) Don't check if the variable is already declared by looking for the property in the variable object, that code path was dead code. (2) Special-case the common case where the top of the scope and the variable object are the same; in that case the variable must always be in the variable object. (3) Don't return a jsString() of the variable name, nothing uses the return value from this node types evaluate method.
- kjs/nodes.h:
Jul 22, 2007:
- 11:53 PM RunWebKitTestsDesign edited by
- (diff)
- 10:45 PM Changeset in webkit [24531] by
-
- 5 edits in trunk/WebCore
Reviewed by Adam.
<rdar://problem/5353174> REGRESSION: 1% JavaScript performance regression fro Window refactoring (14717)
http://bugs.webkit.org/show_bug.cgi?id=14717
- bindings/js/kjs_window.cpp:
- bindings/js/kjs_window.h: (KJS::Window::impl): inlined
- page/DOMWindow.cpp:
- page/DOMWindow.h: (WebCore::DOMWindow::frame): inlined
- 10:42 PM Changeset in webkit [24530] by
-
- 2 edits in trunk/LayoutTests
Fix typo.
- fast/dom/Window/window-function-name-getter-precedence.html:
- 10:30 PM Changeset in webkit [24529] by
-
- 2 edits in trunk/WebCore
- platform/ContextMenu.cpp: Added missing include.
- 10:28 PM Changeset in webkit [24528] by
-
- 3 edits2 adds in trunk
LayoutTests:
Reviewed by Darin.
Test for http://bugs.webkit.org/show_bug.cgi?id=14682
REGRESSION(24285-24399): alerts do not appear at W3C RTL test page
- fast/dom/Window/window-function-name-getter-precedence-expected.txt: Added.
- fast/dom/Window/window-function-name-getter-precedence.html: Added.
WebCore:
Reviewed by Darin.
Fix for http://bugs.webkit.org/show_bug.cgi?id=14682
REGRESSION(24285-24399): alerts do not appear at W3C RTL test page
Test: fast/dom/Window/window-function-name-getter-precedence.html
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): Make sure to return functions before the custom name getter.
- 10:25 PM Changeset in webkit [24527] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam.
- fix <rdar://problem/5353263> ContextMenuItem and ContextMenu objects leaking (seen on buildbot)
- platform/ContextMenu.cpp: (WebCore::separatorItem): Return an auto_ptr instead of a raw pointer, since this function creates an object that's the caller's responsibility to delete. (WebCore::createAndAppendFontSubMenu): Create the context menu on the stack, not the heap, since setSubMenu does not take ownership, and hence the objects were leaking. (WebCore::createAndAppendSpellingAndGrammarSubMenu): Ditto. (WebCore::createAndAppendSpellingSubMenu): Ditto. (WebCore::createAndAppendSpeechSubMenu): Ditto. (WebCore::createAndAppendWritingDirectionSubMenu): Ditto.
- 10:00 PM Changeset in webkit [24526] by
-
- 2 edits6 adds in trunk/WebKitSite
Reviewed by Adam Roben.
Add information on getting a useful crash log on Mac and Windows.
- nav.inc:
- quality/crashlogs.html: Added.
- quality/mac_reportbox.jpg: Added.
- quality/mac_viewtrace.jpg: Added.
- quality/win_installwatson.jpg: Added.
- quality/win_watsongui.jpg: Added.
- quality/win_watsoninstalled.jpg: Added.
- 9:38 PM Changeset in webkit [24525] by
-
- 2 edits in trunk/WebKitTools
- DumpRenderTree/TextInputController.m: (-[TextInputController interpretKeyEvents:withSender:]): Fix a leak by releasing the array used here.
- 7:59 PM RunWebKitTestsDesign edited by
- (diff)
- 7:59 PM RunWebKitTestsDesign edited by
- (diff)
- 7:53 PM RunWebKitTestsDesign edited by
- (diff)
- 7:53 PM RunWebKitTestsDesign edited by
- (diff)
- 7:51 PM RunWebKitTestsDesign edited by
- (diff)
- 3:47 PM Changeset in webkit [24524] by
-
- 4 edits in trunk
Reviewed by Kevin Decker.
- fix <rdar://problem/5126394> REGRESSION: Crash after clicking back button in test application (13250) http://bugs.webkit.org/show_bug.cgi?id=13250
- bindings/objc/objc_utility.mm: (KJS::Bindings::convertObjcValueToValue): If the object returns 0 for _imp, convert that to "undefined", since callers can't cope with a JSValue of 0.
WebCore:
Reviewed by Kevin Decker.
- fix <rdar://problem/5126394> REGRESSION: Crash after clicking back button in test application (13250) http://bugs.webkit.org/show_bug.cgi?id=13250
- bindings/objc/WebScriptObject.mm: (_didExecute): Removed unnecessary check for isValid() since the _rootObject method already takes care of that check. (-[WebScriptObject _imp]): Made this return 0 if there is not a valid rootObject. (-[WebScriptObject _isSafeScript]): Made this always return false if there is not a valid rootObject, eliminating the need to check _rootObject for nil if the code is checking _isSafeScript. (-[WebScriptObject callWebScriptMethod:withArguments:]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. Removed awkward conversion of name from NSString * to KJS::Identifier and did it using WebCore::String instead -- makes it clear that there's no arbitrary JavaScript execution after _isSafeScript and before _imp, so we don't need to null-check the _imp pointer. Added a second check of _isSafeScript after calling get to get the function object, since arbitrary changes could occur in there, including navigation to a new frame. This also takes care of null checking the second call to _imp. (-[WebScriptObject evaluateWebScript:]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. Removed awkward conversion of script from NSString * to KJS::Identifier and did it using WebCore::String instead -- makes it clear that there's no arbitrary JavaScript execution after _isSafeScript and before _imp, so we don't need to null-check the _imp pointer. (-[WebScriptObject setValue:forKey:]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. Removed awkward conversion of key from NSString * to KJS::Identifier and did it using WebCore::String instead -- makes it clear that there's no arbitrary JavaScript execution after _isSafeScript and before _imp, so we don't need to null-check the _imp pointer. (-[WebScriptObject valueForKey:]): Ditto. (-[WebScriptObject removeWebScriptKey:]): Ditto. (-[WebScriptObject stringRepresentation]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. Removed unnecessary local variable and const_cast from the call to the _imp method. (-[WebScriptObject webScriptValueAtIndex:]): Removed check of _rootObject, since it's immediately followed by a check of _isSafeScript. (-[WebScriptObject setWebScriptValueAtIndex:value:]): Ditto. (-[WebScriptObject JSObject]): Ditto.
- 3:24 PM Changeset in webkit [24523] by
-
- 2 edits1 add in trunk/WebKitTools
WebKitTools:
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=14713 Script to update iExploder cssproperties.in file based on CSSPropertyNames.in
Added script to update WebKitTools/iExploder/htdocs/cssproperties.in based on the contents
of WebCore/css/CSSPropertyNames.in. Also updated cssproperties.in.
- Scripts/update-iexploder-cssproperties: Added.
- iExploder/htdocs/cssproperties.in: Updated by running update-iexploder-cssproperties script. Added new CSS3 property section and Moved box-sizing property to it.
- 2:10 PM Changeset in webkit [24522] by
-
- 4 edits1 move in trunk/LayoutTests
LayoutTests:
Reviewed by Sam.
Moving input method tests to editing/input/mac
- editing/input/mac: Copied from fast/events/inputmethods.
- fast/events/inputmethods: Removed.
- fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline-expected.txt: Removed.
- fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline.html: Removed.
- fast/events/inputmethods/kotoeri.js: Removed.
- fast/events/inputmethods/logger.js: Removed.
- win/Skipped:
qt:
Reviewed by Sam.
Add Mac input methods to qt skip list
- Skipped:
- 1:32 PM Changeset in webkit [24521] by
-
- 1 edit in trunk/WebCore/ChangeLog
Updated reviewers.
- 1:31 PM Changeset in webkit [24520] by
-
- 3 edits in trunk/WebCore
Reviewed by Anders.
- speculative fix for <rdar://problem/5337500> CrashTracer: [USER] 4 crashes in Mail at WebCore::HTMLImageElement::isURLAttribute(WebCore::Attribute*) const
- editing/markup.cpp: Added AttributeChange class. (WebCore::completeURLs): Changed function so that all the URL completion is done in a separate pass after finding all the URL attributes. This is safer, since actually applying an attribute change could have any arbitrary effect on the document; it's tricky to iterate a document while it's being modified and we don't have the checks here that would be needed to make that work in pathological cases.
- 1:02 PM Changeset in webkit [24519] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Adam.
Add the input methods tests to the windows skip list
until we work to how to make them platform agnostic
- win/Skipped:
- 12:51 PM Changeset in webkit [24518] by
-
- 1 edit in trunk/WebCore/ChangeLog
Update Bugzilla bug number in Radar bug title based on feedback from Mitz.
- 12:46 PM Changeset in webkit [24517] by
-
- 5 edits5 adds in trunk
LayoutTests:
Reviewed by Darin.
Initial input method test case, this tests the behaviour of the
enter key in our "kotoeri" engine.
- fast/events/inputmethods: Added.
- fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline-expected.txt: Added.
- fast/events/inputmethods/kotoeri-enter-to-confirm-and-newline.html: Added.
- fast/events/inputmethods/kotoeri.js: Added.
- fast/events/inputmethods/logger.js: Added.
WebKitTools:
Reviewed by Darin.
Add preliminary support for testing Input Method/WebKit behaviour and interaction
in DRT. This provides the NSTextInput API which is most of what should be necessary
to mimic the event sequences Input Methods trigger.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/TextInputController.h:
- DumpRenderTree/TextInputController.m: (-[WebHTMLView interpretKeyEvents:]): (+[TextInputController isSelectorExcludedFromWebScript:]): (+[TextInputController webScriptNameForSelector:]): (-[TextInputController initWithWebView:]): (-[TextInputController dealloc]): (-[TextInputController textInput]): (-[TextInputController setInputMethodHandler:]): (-[TextInputController interpretKeyEvents:withSender:]):
- 12:43 PM Changeset in webkit [24516] by
-
- 2 edits in trunk/WebCore
Reviewed by Adam.
- fix <rdar://problem/5350604> REGRESSION: Crash in inspector controller code after clicking back button in test application (13250)
- page/InspectorController.cpp: (WebCore::InspectorController::addScriptResource): Replace an assertion that was firing with some code that at least doesn't immediately crash.
- 12:08 PM Changeset in webkit [24515] by
-
- 2 edits in trunk/WebKit
- StringsNotToBeLocalized.txt: Updated for recent changes.
- 11:43 AM Changeset in webkit [24514] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders.
- improve the fix for <rdar://problem/5298816> Crash redirecting message, in -[SharedBufferData initWithSharedBuffer:]; fixes a crash seen on the buildbot
- loader/DocLoader.cpp: (WebCore::DocLoader::~DocLoader): Call setDocLoader(0) on all the resources so they don't try to use a stale DocLoader pointer later.
