Timeline
Jul 28, 2007:
- 7:34 PM Changeset in webkit [24761] by
-
- 3 edits1 copy3 moves1 delete in trunk/LayoutTests
Reviewed by Mark Rowe.
- Rename test for clarity and consistency.
- Move resource from ssl/resources to security/resources as it is only being used by the security tests.
- http/tests/security/cross-frame-access-port-domain-expected.txt: Removed.
- http/tests/security/cross-frame-access-port-domain.html: Removed.
- http/tests/security/cross-frame-access-port-explicit-domain-expected.txt: Copied from http/tests/security/cross-frame-access-port-domain-expected.txt.
- http/tests/security/cross-frame-access-port-explicit-domain.html: Copied from http/tests/security/cross-frame-access-port-domain.html.
- http/tests/security/cross-frame-access-protocol-expected.txt:
- http/tests/security/cross-frame-access-protocol.html:
- http/tests/security/resources/cross-frame-iframe-for-port-domain-test.html: Removed.
- http/tests/security/resources/cross-frame-iframe-for-port-explicit-domain-test.html: Copied from http/tests/security/resources/cross-frame-iframe-for-port-domain-test.html.
- http/tests/security/resources/cross-frame-iframe-for-protocol-test.html: Copied from http/tests/ssl/resources/cross-frame-access-protocol-iframe.html.
- http/tests/ssl/resources: Removed.
- http/tests/ssl/resources/cross-frame-access-protocol-iframe.html: Removed.
- 7:15 PM Changeset in webkit [24760] by
-
- 8 edits3 adds in trunk/LayoutTests
Reviewed by Oliver Hunt.
- Factor access testing code used in protocol and port tests to cross-frame-access.js.
- Add cross-frame-iframe-for-protocol-explicit-domain-test.html which is parallel test to cross-frame-iframe-for-port-domain-test.html but for different protocols.
- http/tests/security/cross-frame-access-port-domain-expected.txt:
- http/tests/security/cross-frame-access-port-domain.html:
- http/tests/security/cross-frame-access-port.html:
- http/tests/security/cross-frame-access-protocol-explicit-domain-expected.txt: Added.
- http/tests/security/cross-frame-access-protocol-explicit-domain.html: Added.
- http/tests/security/cross-frame-access-protocol.html:
- http/tests/security/resources/cross-frame-access.js:
- http/tests/security/resources/cross-frame-iframe-for-port-domain-test.html:
- http/tests/security/resources/cross-frame-iframe-for-port-test.html:
- http/tests/security/resources/cross-frame-iframe-for-protocol-explicit-domain-test.html: Added.
- 7:02 PM Changeset in webkit [24759] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix up reviewer name typo in ChangeLog
- 6:30 PM Changeset in webkit [24758] by
-
- 3 edits in trunk/WebCore
2007-07-29 Alp Toker <alp.toker@collabora.co.uk>
Reviewed by Brian Dash.
http://bugs.webkit.org/show_bug.cgi?id=14711 (revisited)
RenderThemeGdk's buttons are state-agnostic (pressed, hovered)
Generalize shadow state into a function.
use a GtkHBox to work around a theme bug (thanks to Nigel Tao).
- platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::determineShadow): (WebCore::RenderThemeGdk::paintCheckbox): (WebCore::RenderThemeGdk::paintRadio): (WebCore::RenderThemeGdk::paintButton): (WebCore::RenderThemeGdk::gtkWindowContainer):
- platform/gdk/RenderThemeGdk.h:
- 6:18 PM Changeset in webkit [24757] by
-
- 2 edits4 adds in trunk/LayoutTests
2007-07-28 Mark Rowe <mrowe@apple.com>
Reviewed by Darin and John.
<rdar://problem/5229705> Thai characters render differently between leopard and tiger
Add Leopard-specific test results for tests containing Thai characters.
- mac/leopard/Skipped:
- mac/leopard/fast/text: Added.
- mac/leopard/fast/text/atsui-multiple-renderers-expected.txt: Added.
- mac/leopard/fast/text/international: Added.
- mac/leopard/fast/text/international/thai-line-breaks-expected.txt: Added.
- 6:15 PM Changeset in webkit [24756] by
-
- 2 edits8 adds in trunk/LayoutTests
2007-07-29 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver.
<rdar://problem/5228270> SVG test failures due to different metrics for scaled text blocks
Add Leopard-specific results for three SVG tests.
- mac/leopard/Skipped:
- mac/leopard/svg: Added.
- mac/leopard/svg/hixie: Added.
- mac/leopard/svg/hixie/text: Added.
- mac/leopard/svg/hixie/text/003-expected.txt: Added.
- mac/leopard/svg/hixie/text/003a-expected.txt: Added.
- mac/leopard/svg/hixie/viewbox: Added.
- mac/leopard/svg/hixie/viewbox/preserveAspectRatio: Added.
- mac/leopard/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Added.
- 10:37 AM Changeset in webkit [24755] by
-
- 1 edit in tags/Safari-5522.12.2/WebCore/Configurations/Version.xcconfig
Versioning.
- 10:37 AM Changeset in webkit [24754] by
-
- 2 edits in tags/Safari-5522.12.2/WebCore
Merge r24658.
Reviewed by Oliver.
<rdar://problem/5362783>
In Mail, a crash occurs at WTF::fastMalloc() when attempting to create a new HTML message from http://nytimes.com/
If the cache is disabled and there is already a resource with the given URL, return it instead of creating a new one.
- loader/DocLoader.cpp: (WebCore::DocLoader::requestResource):
- 10:37 AM Changeset in webkit [24753] by
-
- 2 edits in tags/Safari-5522.12.2/WebCore
Merge r24514.
Reviewed by Anders.
- improve the fix for <rdar://problem/5298816> Crash redirecting message, in -[SharedBufferData initWithSharedBuffer:]; fixes a crash seen on the buildbot
- loader/DocLoader.cpp: (WebCore::DocLoader::~DocLoader): Call setDocLoader(0) on all the resources so they don't try to use a stale DocLoader pointer later.
- 10:36 AM Changeset in webkit [24752] by
-
- 2 edits in tags/Safari-5522.12.2/WebCore
Merge r24500.
Reviewed by Darin.
If the style sheet requested is a user style sheet, don't store it in the DocLoader's resource map;
user style sheets can outlive their doc loaders.
- loader/DocLoader.cpp: (WebCore::DocLoader::requestCSSStyleSheet):
- 10:36 AM Changeset in webkit [24751] by
-
- 5 edits in tags/Safari-5522.12.2/WebCore
Merge r24492.
Reviewed by Darin.
<rdar://problem/5298816> Crash redirecting message, in -[SharedBufferData initWithSharedBuffer:]
Have cached resources keep track of what DocLoader they belong to. This is so that they can remove themselves
from the DocLoader's resource map when they're destroyed when the cache is disabled.
- html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement):
- loader/Cache.cpp: (WebCore::Cache::requestResource):
- loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::~CachedResource):
- loader/CachedResource.h: (WebCore::CachedResource::setDocLoader):
- 10:20 AM Changeset in webkit [24750] by
-
- 1 copy in tags/Safari-5522.12.2
New tag.
- 7:22 AM BuildingGdk edited by
- link to BuildingOnLinux (diff)
- 7:20 AM BuildingOnLinux edited by
- Ubuntu package requirements (diff)
Jul 27, 2007:
- 5:54 PM Changeset in webkit [24749] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
Temporary fix for Windows to prevent crashing on all frame pages. Darin
is working on a more permanent fix.
- loader/FrameLoader.cpp:
- 4:57 PM Changeset in webkit [24748] by
-
- 2 edits in trunk/WebCore
Fix crash when using QtWebKit canvas support.
- 4:37 PM Changeset in webkit [24747] by
-
- 2 edits in trunk/WebKitTools
WebKitTools:
Reviewed by Geoff and Darin.
Use a subroutine for validating the --skipped switch.
- Scripts/run-webkit-tests:
- 2:58 PM ApolloWebKit created by
- Initial instructions on building Apollo WebKit.
- 2:56 PM WikiStart edited by
- Added link to Apollo WebKit page. (diff)
- 2:49 PM Changeset in webkit [24746] by
-
- 5 edits6 adds in trunk/LayoutTests
Reviewed by Geoff Garen.
- Test that cross frame access to a window on a different port is denied.
- Adds test for out behavior of the above if document.domain is explicitly set to the same domain for both frames. We currently fail this test and a radar has been filed.
- Clean up cross-frame-access-protocol.html to work in FireFox as well.
- http/conf/apache2-httpd.conf: Listen on port 8080 now as well
- http/conf/cygwin-httpd.conf: Listen on port 8080 now as well
- http/conf/httpd.conf: Listen on port 8080 now as well
- http/tests/security/cross-frame-access-port-domain-expected.txt: Added.
- http/tests/security/cross-frame-access-port-domain.html: Added.
- http/tests/security/cross-frame-access-port-expected.txt: Added.
- http/tests/security/cross-frame-access-port.html: Added.
- http/tests/security/cross-frame-access-protocol.html:
- http/tests/security/resources/cross-frame-iframe-for-port-domain-test.html: Added.
- http/tests/security/resources/cross-frame-iframe-for-port-test.html: Added.
- 1:40 PM Changeset in webkit [24745] by
-
- 3 edits in trunk/WebKit
- fix build
- WebKitPrefix.h: Removed the USING_WEBCORE_XXX definitions.
- WebView/WebHTMLView.mm: (-[WebHTMLView delete:]): Fixed this to use WebCore again; I accidentally revived a dead code path that didn't work in the last patch! (-[WebHTMLView deleteToMark:]): Ditto. (-[WebHTMLView copy:]): Removed the unused side of the ifdef. (-[WebHTMLView cut:]): Ditto. (-[WebHTMLView paste:]): Ditto.
- 1:27 PM Changeset in webkit [24744] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Sam.
- Scripts/run-webkit-tests: Remove exception for leaks bug that has been fixed on Leopard.
- 1:00 PM Changeset in webkit [24743] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Adam Roben.
Don't display the expected and resulting values for screenTop and screenY
as they depend on the physical screen size.
- http/tests/security/cross-frame-access-put-expected.txt:
- http/tests/security/resources/cross-frame-iframe-for-put-test.html:
- 12:13 PM Changeset in webkit [24742] by
-
- 3 edits in trunk/WebKit
Reviewed by Tim Hatcher and Oliver Hunt.
- fix <rdar://problem/5355815> webView:doCommandBySelector: isn't getting called for copy:
Added code so that webView:doCommandBySelector: is called for every command.
- WebView/WebHTMLView.mm: Made 44 of the commands use the WEBCORE_COMMAND macro instead of being handwritten. For all the others, added invocation of COMMAND_PROLOGUE macro at the start of the command. (-[WebHTMLView callDelegateDoCommandBySelectorIfNeeded:]): Added. (-[WebHTMLView callWebCoreCommand:]): Added. (-[WebHTMLView delete:]): Removed unused code path -- easy to bring back some day, but we don't need it compiled in. (-[WebHTMLView deleteBackwardByDecomposingPreviousCharacter:]): Changed so this doesn't call deleteBackward: any more so we don't call the delegate two times. (-[WebHTMLView deleteToMark:]): Changed so this doesn't call delete: any more so we don't call the delegate two times. (-[WebHTMLView selectToMark:]): Changed so this doesn't call setMark: any more so we don't call the delegate two times. (-[WebHTMLView doCommandBySelector:]): Added code to set the private variable selectorForDoCommandBySelector. This allows callDelegateDoCommandBySelectorIfNeeded to detect that we've already called the delegate and avoids calling it twice.
- WebView/WebHTMLViewInternal.h: Added the selectorForDoCommandBySelector field.
- 12:09 PM Changeset in webkit [24741] by
-
- 2 edits in trunk/WebCore
- rendering/RenderLayer.cpp: Rolled out accidentally-checked-in code.
- 12:07 PM Changeset in webkit [24740] by
-
- 5 edits2 adds in trunk
LayoutTests:
Reviewed by John Sullivan.
- fix <rdar://problem/5261393> In Mail the plain text alternatives to messages with attachments show weird little OBJ thingies
- fast/text/zero-width-characters-expected.txt: Added.
- fast/text/zero-width-characters.html: Added.
WebCore:
Reviewed by John Sullivan.
- fix <rdar://problem/5261393> In Mail the plain text alternatives to messages with attachments show weird little OBJ thingies
The "weird little thingies" are U+FFFC characters. It's good to render them as zero-width, the way we do
with control characters -- helps Mail and doesn't hurt web browsing.
Test: fast/text/zero-width-characters.html
- platform/CharacterNames.h: Add names for leftToRightMark, rightToLeftMark, and objectReplacementCharacter.
- platform/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage): Give objectReplacementCharacter zero width in the same way we do it for the various other characters.
- 11:33 AM Changeset in webkit [24739] by
-
- 2 edits in trunk/WebKit/win
Reviewed by Adam.
Add FIXME comment.
- Interfaces/DOMHTML.idl:
- 11:08 AM RunWebKitTestsDesign edited by
- Added a description of how multiple Skipped files should be treated (diff)
- 10:27 AM Changeset in webkit [24738] by
-
- 4 edits in trunk/WebKit/win
2007-07-27 Ada Chan <adachan@apple.com>
Reviewed by Adam.
Added methods to track user edited text fields now that
<rdar://problem/5359921> has been fixed.
- DOMHTMLClasses.cpp: (DOMHTMLInputElement::QueryInterface): (DOMHTMLInputElement::isUserEdited): (DOMHTMLTextAreaElement::QueryInterface): (DOMHTMLTextAreaElement::isUserEdited):
- DOMHTMLClasses.h:
- Interfaces/DOMPrivate.idl:
- 7:31 AM Changeset in webkit [24737] by
-
- 6 edits in S60/trunk/WebKit
vbradley, reviewed by Sachin
DESC: AYNN-74AF84 : Username field not filled automatically
http://bugs.webkit.org/show_bug.cgi?id=14612
- BrowserCore/Formcontrols/inc/FControlSelectListBox.h:
- BrowserCore/Formcontrols/src/FControlInputSkin.cpp:
- BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::OfferKeyEventL):
- BrowserCore/Formcontrols/src/FControlSelectListBox.cpp: (CControlSelectListBox::UpdateContentL): (CControlSelectListBox::DrawListBox):
- BrowserCore/Formcontrols/src/FControlSelectWidget.cpp: (CControlSelectWidget::ConstructL): (CControlSelectWidget::FilterContentL): (CControlSelectWidget::OfferKeyEventL):
- 6:59 AM Changeset in webkit [24736] by
-
- 6 edits in S60/trunk
yadavall, reviewed by <Zalan>
DESC: Fixes for widget menu API
http://bugs.webkit.org/show_bug.cgi?id=14763
- 6:58 AM Changeset in webkit [24735] by
-
- 2 edits in trunk/WebCore
Enable XSLT support for the gtk port.
- 6:58 AM Changeset in webkit [24734] by
-
- 2 edits in trunk/WebCore
Premature end after finishing parsing is a fatal error.
- 6:58 AM Changeset in webkit [24733] by
-
- 2 edits in trunk/LayoutTests/qt
add xlst related tests to Skipped list.
- 6:58 AM Changeset in webkit [24732] by
-
- 2 edits in trunk/WebCore
Simplify conversions that go from a QStringRef to a WebCore::String to not use a temporary QString.
- 6:57 AM Changeset in webkit [24731] by
-
- 2 edits in trunk/WebCore
Fix entity handling in the main document content (attributes still broken)
- 6:57 AM Changeset in webkit [24730] by
-
- 4 edits in trunk/WebCore
Correctly convert a null QString into a null WebCore::String. Add a String(const QStringRef&) constructor so that we can avoid converting QStringRef via QString to WebCore::String.
- 6:57 AM Changeset in webkit [24729] by
-
- 2 edits in trunk/WebCore
Parse version and encoding of the xml document.
- 6:56 AM Changeset in webkit [24728] by
-
- 2 edits in trunk/WebCore
Correctly or semi-correctly parse the public and system id.
Patch from Lars.
- 6:56 AM Changeset in webkit [24727] by
-
- 2 edits in trunk/WebCore
Fix uri parsing for attributes.
- 6:56 AM Changeset in webkit [24726] by
-
- 2 edits in trunk/WebCore
Fixing qualified name parsing - from Lars.
- 6:56 AM Changeset in webkit [24725] by
-
- 3 edits in trunk/WebCore
Parse dtd's
- 6:55 AM Changeset in webkit [24724] by
-
- 3 edits in trunk/WebCore
Implement error handling.
Add our copyrights
- 6:55 AM Changeset in webkit [24723] by
-
- 3 edits in trunk/WebCore
Making the stylesheets work (plus everything else basically)
- 6:55 AM Changeset in webkit [24722] by
-
- 4 edits in trunk/WebCore
Remove the libxml dependency when not compiling with XSLT.
Just ifdefing, displaying xml doesn't work.
- 5:26 AM Changeset in webkit [24721] by
-
- 6 edits in trunk
WebKitQt:
2007-07-27 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Mark.
Don't create an app bundle on OSX to keep WebKitTools/Scripts/run-launcher working.
- QtLauncher/QtLauncher.pro:
WebKitTools:
2007-07-27 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Mark.
Correct the path of GdkLauncher and make checkFrameworks work on OSX
when building the Qt or Gtk+ port.
- GdkLauncher/GdkLauncher.pro: Don't create an app bundle on OSX
- Scripts/run-launcher:
- Scripts/webkitdirs.pm: Don't add WebKit if we build the Qt or Gtk+ port.
- 5:26 AM Changeset in webkit [24720] by
-
- 2 edits in trunk/WebCore
Work around bug in the moc when used as preprocessor for generating the bindings. -DFOO=1 is needed instead of -DFOO to make the <hash>if FOO conditional match.
- 4:59 AM Changeset in webkit [24719] by
-
- 2 edits in trunk/WebCore
2007-07-27 Patrick Hanna <phanna@email.unc.edu>
Reviewed by Darin Adler.
Change PluginBase::refresh to be static and update PluginsFunc::callAsFunction accordingly. Now we no longer
allocate an instance of a JSObject subclass on the stack which could lead to a crash during garbage collection.
- bindings/js/kjs_navigator.cpp: (KJS::PluginsFunc::callAsFunction):
- 1:34 AM Changeset in webkit [24718] by
-
- 2 edits in trunk/JavaScriptCore
Always define JSChar to be unsigned short for the Qt builds, to ensure compatibility with UChar.
- 1:34 AM Changeset in webkit [24717] by
-
- 4 edits in trunk/WebCore
Fix snprintf hack for the Qt/Windows build with mingw-gcc. MingW has snprintf, so we don't need this helper function.
- 1:34 AM Changeset in webkit [24716] by
-
- 2 edits in trunk/WebCore
Make the DocTypeStrings.cpp generation work with MingW. Cleaned it up to be a regular extra compiler at the same time.
- 1:34 AM Changeset in webkit [24715] by
-
- 2 edits in trunk/JavaScriptCore
Fix compilation with Qt on Windows with MingW: Implemented currentThreadStackBase() for this platform.
- 1:33 AM Changeset in webkit [24714] by
-
- 2 edits in trunk/JavaScriptCore
Fix compilation with Qt on Windows with MingW: The MingW headers do not provide a prototype for a reentrant version of localtime. But since we don't use multiple threads for the Qt build we can use the plain localtime() function.
- 1:33 AM Changeset in webkit [24713] by
-
- 2 edits in trunk/WebCore
MingW build fixes: Do the "OBJECTS_TRAILING_SLASH" trick not only for win32-msvc but for all win32 mkspecs. Added LIB/INCLUDE hack from Qt to make us pick up 3rdparty libraries such as libxml from these environment variables.
- 1:33 AM Changeset in webkit [24712] by
-
- 2 edits in trunk/WebKitTools
Fix build-webkit for the Qt build on Windows with msvc/nmake by trying to detect the Qt mkspec and using "nmake" instead of "make" as build command.
- 1:33 AM Changeset in webkit [24711] by
-
- 4 edits1 add in trunk
Use $(MOVE) instead of mv to eliminated the shell dependency and replaced the long shell line to call bison and modify the css grammar file with a few lines of portable perl code.
- 1:33 AM Changeset in webkit [24710] by
-
- 3 edits in trunk/JavaScriptCore
Implemented currentTime() in the interpreter by using QDateTime, so that we don't need timeGetTime() on Windows and therefore also don't need to link against Winmm.dll.
- 1:32 AM Changeset in webkit [24709] by
-
- 2 edits in trunk
Exclude DumpRenderTree from the Qt build on Windows for now.
- 1:32 AM Changeset in webkit [24708] by
-
- 2 edits in trunk/WebKitTools
For detecting the SVG support for the Qt build don't do the nm hack. Just always claim SVG support is enabled because that's what it is. The nm hack doesn't work on Windows anyway.
- 1:32 AM Changeset in webkit [24707] by
-
- 2 edits in trunk/WebCore
On make install on Windows copy the dll into the bin dir.
- 1:32 AM Changeset in webkit [24706] by
-
- 2 edits in trunk/WebCore
Link in libxml and libxslt on Windows.
- 1:32 AM Changeset in webkit [24705] by
-
- 5 edits in trunk
Temporarily disable the ICO support for the Qt build on Windows.
- 1:32 AM Changeset in webkit [24704] by
-
- 2 edits in trunk/WebCore
Fix evaluation with ActiveState Perl 5.6. Somehow it tried to treat nameEntries as array.
- 1:31 AM Changeset in webkit [24703] by
-
- 3 edits in trunk/WebCore
Fix compilation with MSVC in the Qt build (missing header files).
- 1:31 AM Changeset in webkit [24702] by
-
- 2 edits in trunk/WebCore
Disable the favicon database on Windows for now, to eliminate the sqlite dependency.
- 1:31 AM Changeset in webkit [24701] by
-
- 3 edits in trunk/WebCore
Added custom preprocessor support to make_names.pl and use the moc for it in the Qt build.
- 1:31 AM Changeset in webkit [24700] by
-
- 2 edits in trunk/WebCore
Disable the batch mode for nmake to work around the clash of Node.c and Node.cpp both mapping to Node.obj
- 1:30 AM Changeset in webkit [24699] by
-
- 2 edits in trunk/WebCore
Fix compilation under Windows (removed sys/time.h dependency, use Qt instead).
- 1:30 AM Changeset in webkit [24698] by
-
- 2 edits in trunk/WebCore
Fix compilation on Windows.
- 1:30 AM Changeset in webkit [24697] by
-
- 2 edits in trunk/WebCore
Fix generation of ColorData.c on Windows.
- 1:30 AM Changeset in webkit [24696] by
-
- 2 edits in trunk/WebCore
Fix compilation under Qt/Windows.
- 1:30 AM Changeset in webkit [24695] by
-
- 2 edits in trunk/WebCore
Changed extendedAttributes to be a variable instead of a hash directly. Required to work with ActiveState perl.
- 1:29 AM Changeset in webkit [24694] by
-
- 2 edits in trunk/JavaScriptCore
Replace the use of snprintf with QByteArray to compile under msvc 2005 express.
- 1:29 AM Changeset in webkit [24693] by
-
- 2 edits in trunk/JavaScriptCore
Don't use pthread.h unless thread support is enabled.
- 1:29 AM Changeset in webkit [24692] by
-
- 2 edits in trunk/JavaScriptCore
Removed TCSystemMalloc from the Qt build, it's not necessary it seems.
- 1:29 AM Changeset in webkit [24691] by
-
- 2 edits in trunk/WebCore
Fix header guard generation for CSSGrammar.h under Windows
- 1:29 AM Changeset in webkit [24690] by
-
- 2 edits in trunk/WebCore
Fix build with moc as preprocessor. Don't rely the preprocessor preserving whitespace at the beginning of lines.
- 1:28 AM Changeset in webkit [24689] by
-
- 2 edits in trunk/JavaScriptCore
Added os-win32 to the include search path for the Qt windows build in order to provide the fake stdint.h header file.
- 1:28 AM Changeset in webkit [24688] by
-
- 3 edits in trunk/WebCore
Make make-css-file-arrays.pl work on Windows by not calling /usr/bin/gcc as preprocessor for the Qt build.
- 1:28 AM Changeset in webkit [24687] by
-
- 2 edits in trunk/WebCore
More gperf commandline fixes for Windows.
- 1:28 AM Changeset in webkit [24686] by
-
- 2 edits in trunk/WebCore
More quoting fixes for perl under Windows.
- 1:28 AM Changeset in webkit [24685] by
-
- 2 edits in trunk/WebCore
Fix command quoting under Windows
- 1:27 AM Changeset in webkit [24684] by
-
- 3 edits in trunk/WebCore
Fix cssmakeprops and cssmakevalue scripts to work on Windows without cygwin perl. Avoid inplace substitutions and direct invocation of /bin/sh. Also call gperf with arguments that GnuWin32's gperf understands.
- 1:27 AM Changeset in webkit [24683] by
-
- 2 edits in trunk/WebCore
Beautiful hacks to make more of the extra compiler magic work under Windows outside of cygwin.
- 1:27 AM Changeset in webkit [24682] by
-
- 3 edits in trunk/WebCore
Correctly propagate the custom preprocessor option through the idl parser and the codegenerator.
- 1:27 AM Changeset in webkit [24681] by
-
- 2 edits in trunk/WebCore
When constructing the absolute path when searching for IDL files in the list of search paths don't prepend a slash if $SOURCEROOT as environment variable is not set. In the Qt build we pass absolute search paths already and we don't set SOURCEROOT. Under Unix that gives a double slash for the directory which works fine, under Windows we get /c:\webkit\foo which of course does not work.
- 1:27 AM Changeset in webkit [24680] by
-
- 2 edits in trunk/WebCore
Relax the regular expression that tries to find constant declarations in the IDL source to not require leading whitespace. This makes it work with preprocessors that happen to eliminate leading whitespace.
- 1:26 AM Changeset in webkit [24679] by
-
- 2 edits in trunk/WebCore
Try to use the moc as preprocessor for the IDL bindings generator
- 1:26 AM Changeset in webkit [24678] by
-
- 3 edits in trunk/WebCore
Make it possible to specify the preprocessor the bindings generator uses instead of hardcoding /usr/bin/gcc (which is of course no option on Windows). Also try to use a more portable and Windows friendly way of opening the reading pipe to the preprocessor.
- 1:26 AM Changeset in webkit [24677] by
-
- 2 edits in trunk/WebCore
Don't use stdout redirection for make_names.pl as it doesn't work under Windows perl (outside cygwin).
- 1:26 AM Changeset in webkit [24676] by
-
- 2 edits in trunk/WebCore
Fix DocTypeStrings.cpp generation to work on Windows with cmd.exe
- 12:43 AM Changeset in webkit [24675] by
-
- 2 edits in trunk/WebCore
Work around aliasing bugs in WebCore by compiling with -fno-strict-aliasing for gcc builds for now.
- 12:28 AM Changeset in webkit [24674] by
-
- 2 edits in trunk/WebCore
Use -Wreturn-type only when compiling with g++
- 12:28 AM Changeset in webkit [24673] by
-
- 2 edits in trunk/WebCore
Don't use pkg-config on Windows for the Qt build
- 12:22 AM Changeset in webkit [24672] by
-
- 2 edits in trunk/WebKit/win
Fix Bug 14773: REGRESSION (r24630): ASSERT_NOT_REACHED in DOMHTMLInputElement::name on Windows
http://bugs.webkit.org/show_bug.cgi?id=14773
Reviewed by Steve.
- Interfaces/DOMHTML.idl: Change IDOMHTMLInputElement back to inheriting from IDOMElement. Safari 3 Beta uses this interface, so we can't change its vtable.
- 12:14 AM Changeset in webkit [24671] by
-
- 2 edits in trunk/WebCore
Fix compilation with MSVC.
- 12:11 AM Changeset in webkit [24670] by
-
- 5 edits in trunk/WebKitQt
Fix compilation with MSVC.
Jul 26, 2007:
- 10:27 PM Changeset in webkit [24669] by
-
- 1 edit in trunk/WebKit/ChangeLog
Added radar.
- 9:54 PM Changeset in webkit [24668] by
-
- 4 edits in trunk/WebKit
Reviewed by Oliver.
http://bugs.webkit.org/show_bug.cgi?id=14733
Add a logging channel for text input
- Misc/WebKitLogging.h:
- Misc/WebKitLogging.m: (WebKitInitializeLoggingChannelsIfNecessary):
- WebView/WebHTMLView.mm: (-[WebHTMLView validAttributesForMarkedText]): (-[WebHTMLView textStorage]): (-[WebHTMLView characterIndexForPoint:]): (-[WebHTMLView firstRectForCharacterRange:]): (-[WebHTMLView selectedRange]): (-[WebHTMLView markedRange]): (-[WebHTMLView attributedSubstringFromRange:]): (-[WebHTMLView hasMarkedText]): (-[WebHTMLView unmarkText]): (-[WebHTMLView setMarkedText:selectedRange:]): (-[WebHTMLView doCommandBySelector:]): (-[WebHTMLView insertText:]):
- 9:18 PM Changeset in webkit [24667] by
-
- 2 edits in trunk/LayoutTests
- http/tests/security/cross-frame-access-put-expected.txt: Checked in corrected results that match the checked-in test.
- 6:58 PM Changeset in webkit [24666] by
-
- 14 edits in trunk/WebKit
- fix Tiger build
- Misc/WebTypesInternal.h: For use inside the library, use NSInteger and NSUInteger, just like on Leopard. WebNSInteger and WebNSUInteger are still present, but they are used in public and private headers only.
- Carbon/CarbonWindowAdapter.m:
- Carbon/CarbonWindowFrame.m:
- DefaultDelegates/WebScriptDebugServer.m:
- History/WebBackForwardList.mm:
- Misc/WebDownload.m:
- Misc/WebSearchableTextView.m:
- Plugins/WebBaseNetscapePluginView.mm:
- WebCoreSupport/WebFrameLoaderClient.mm:
- WebView/WebHTMLView.mm:
- WebView/WebPDFView.mm:
- WebView/WebView.mm:
- WebView/WebViewInternal.h: Update all implementation files and internal headers to use NSInteger and NSUInteger rather than WebNSInteger and WebNSUInteger.
- 6:12 PM Changeset in webkit [24665] by
-
- 3 edits in trunk/WebKit
Reviewed by Kevin Decker
- fixed <rdar://problem/5362989> Searching a pdf in some modes shows hilights for all instances of the word, even those not on the current page
It turns out that there were three different issues here, all contributing to incorrect display
of multiple matches for PDF pages in certain display modes. (1) in non-continuous display modes,
we weren't updating the match rects when the displayed page is changed with page up/down (e.g.);
(2) the mechanism to update the match rects on scrolling was busted except for the first scroll
away from 0,0; (3) the PDFKit API returns selection bounds for non-displayed pages in non-continuous
modes just as if they were the displayed pages. This patch fixes all three issues.
- WebView/WebPDFView.h: made ivar name even longer
- WebView/WebPDFView.mm: (-[WebPDFView setPDFDocument:]): updated for ivar name change (-[WebPDFView viewDidMoveToWindow]): observe page-change notifications as well as the others; this is necessary because in the non-continuous modes the view can be completely updated without any scrolling involved (problem 1) (-[WebPDFView viewWillMoveToWindow:]): stop observing page-change notifications (-[WebPDFView rectsForTextMatches]): skip any pages that aren't visible; this avoids treating matches on non-displayed non-continous modes as if they were on the displayed page (problem 3) (-[WebPDFView _PDFDocumentViewMightHaveScrolled:]): after checking whether scroll position has changed since we last checked it, remember the new one (d'oh!) (problem 2)
(-[WebPDFView _scaleOrDisplayModeOrPageChanged:]):
renamed to include page changes
(-[WebPDFView _visiblePDFPages]):
new method, returns the set of pages that are at least partly visible
- 5:51 PM Changeset in webkit [24664] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Anders Carlsson.
<rdar://problem/5350019> REGRESSION: Pages on milliyet.com are added to Back list when visited, causing Back button to just reload
- http/tests/navigation/lockedhistory-iframe-expected.txt: Added.
- http/tests/navigation/lockedhistory-iframe.html: Added.
- 5:46 PM Changeset in webkit [24663] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders Carlsson.
<rdar://problem/5350019> REGRESSION: Pages on milliyet.com are added to Back list when visited, causing Back button to just reload
- loader/FrameLoader.cpp: (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): If the policy action is FrameLoadTypeRedirectLockHistory, don't add the frame load url to the history.
- 5:26 PM Changeset in webkit [24662] by
-
- 1 edit in trunk/WebCore/rendering/RenderInline.cpp
- 5:14 PM Changeset in webkit [24661] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoff.
Add a FIXME about caching pages with plug-ins that have outstanding NPObjects.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::canCachePage):
- 5:12 PM Changeset in webkit [24660] by
-
- 3 edits in trunk/LayoutTests
Reviewed by Sam.
- Updated results as they are affecte by my previous checkin.
- http/tests/security/cross-frame-access-put-expected.txt:
- http/tests/security/resources/cross-frame-iframe-for-put-test.html:
- 5:02 PM Changeset in webkit [24659] by
-
- 2 edits in trunk/WebCore
FIx for <rdar://problem/5289721> CrashTracer: [REGRESSION] 2658 crashes in Safari at com.apple.WebCore: WebCore::RenderInline::height const + 16
Adding a null check for now and an assert. We don't know how/why this
bug happens, but hopefully the assert will help people to reproduce.
Reviewed by kevin
- rendering/RenderInline.cpp: (WebCore::RenderInline::height):
- 4:52 PM Changeset in webkit [24658] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver.
<rdar://problem/5362783>
In Mail, a crash occurs at WTF::fastMalloc() when attempting to create a new HTML message from http://nytimes.com/
If the cache is disabled and there is already a resource with the given URL, return it instead of creating a new one.
- loader/DocLoader.cpp: (WebCore::DocLoader::requestResource):
- 4:15 PM Changeset in webkit [24657] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoff.
Build fix.
- platform/network/cf/ResourceRequest.h:
- 3:47 PM Changeset in webkit [24656] by
-
- 2 edits in trunk/LayoutTests
Reviewed by.
- Fixed bot breakage.
- fast/dom/Window/window-resize.html:
- 3:40 PM Changeset in webkit [24655] by
-
- 2 edits in trunk/WebCore
Reviewed by John Sullivan.
<rdar://problem/5349389>
Some frame load delegate methods not called when loading a page from the BF cache
These calls were moved to FrameLoader::begin, which is never called for pages loaded
from the BF cache. This happened in revision 24490.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted): Call delegate methods if the load is from the BF cache.
- 2:59 PM Changeset in webkit [24654] by
-
- 7 edits2 adds in trunk
LayoutTests:
Reviewed by Darin, Geoff and Sam.
- <rdar://problem/5150461> Resizing the window larger than the screen causes no resize.
- Tests to ensure we resize/move the window out of bounds correctly.
- fast/dom/Window/window-resize-expected.txt: Added.
- fast/dom/Window/window-resize.html: Added.
- mac/leopard/Skipped:
WebCore:
Reviewed by Darin, Geoff and Sam.
- <rdar://problem/5150461> Resizing the window larger than the screen causes no resize.
- We now better match the behavior of other browsers.
- bindings/js/kjs_window.cpp: (KJS::constrainToVisible): (KJS::WindowFunc::callAsFunction):
WebKitTools:
Reviewed by Darin, Geoff, Sam.
- <rdar://problem/5150461> Resizing the window larger than the screen causes no resize.
- Added delegate methods to intercept and fake the frame location so methods like resizeTo and moveTo can change the window location without actually making the window appear on-screen.
- DumpRenderTree/UIDelegate.h:
- DumpRenderTree/UIDelegate.m: (-[UIDelegate webView:setFrame:]): (-[UIDelegate webViewFrame:]):
- 2:43 PM Changeset in webkit [24653] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Brady.
- Added leopard-specific results for <rdar://problem/5228256> REGRESSION(Leopard): layout test failures: security/block-test
- mac/leopard/security: Added.
- mac/leopard/security/block-test-expected.txt: Added.
- 2:35 PM Changeset in webkit [24652] by
-
- 5 edits in trunk/WebCore
Reviewed by Adele Peterson.
<rdar://problem/5359921> WebCore should maintain a dirty flag for confirmation on unsaved changes
- bindings/objc/DOMHTML.mm: (-[DOMHTMLInputElement _isUserEdited]): (-[DOMHTMLTextAreaElement _isUserEdited]): Renamed _isEdited to _isUserEdited since the functionality is now different
- bindings/objc/DOMPrivate.h: Renamed _isEdited to _isUserEdited.
- rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): Defaulted m_userEdited to false
(WebCore::RenderTextControl::updateFromElement):
Set m_userEdited to false, since the change wasn't triggered first by an edit
(WebCore::RenderTextControl::subtreeHasChanged):
Set m_userEdited to true, since it has been touched by the user
- rendering/RenderTextControl.h: (WebCore::RenderTextControl::isUserEdited): (WebCore::RenderTextControl::setUserEdited): Added two new methods to set/return the userEdited boolean value.
- 2:21 PM Changeset in webkit [24651] by
-
- 4 edits in trunk/WebCore
Reviewed by Beth Dakin.
Fixed NULL-dereference crash seen on buildbot.
No bug filed because this is a part of <rdar://problem/5241167>.
- history/PageCache.h: (WebCore::PageCache::get): NULL-check HistoryItems passed to get() and remove(), to match the old semantics of HashMap. For clarity, ASSERT that add() is not called with NULL arguments.
- 2:18 PM Changeset in webkit [24650] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Adam.
- Lars wanted this check for Qt but it breaks platform specific layout tests.
- Scripts/run-webkit-tests:
- 12:51 PM Changeset in webkit [24649] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver Hunt.
<rdar://problem/5361106> Crash in user style sheet when loading webpage
Null check m_frame.
- dom/Document.cpp: (WebCore::Document::stylesheetLoaded):
- 12:48 PM Changeset in webkit [24648] by
-
- 15 edits in S60/trunk/WebKit
condon, reviewed by ligman
DESC: Fix codescanner warnings
http://bugs.webkit.org/show_bug.cgi?id=14748
- BrowserCore/Formcontrols/src/FControlInputSkin.cpp: (CFormInputSkin::ActivateL):
- BrowserCore/Renderers/src/ImageRenderer.cpp: (CImageRenderer::~CImageRenderer):
- BrowserCore/Renderers/src/TextRenderer.cpp: (CTextRenderer::~CTextRenderer):
- BrowserView/src/FormDataLoginStore.cpp: (CFormDataLoginStore::ClearData):
- BrowserView/src/LoadListeners.cpp: (CWmlResourceLoadListener::SetUrlL):
- BrowserView/src/PageView.cpp: (CPageView::~CPageView):
- ChangeLog:
- Plugin/src/PluginSkin.cpp: (CPluginSkin::~CPluginSkin):
- Plugin/src/PluginWin.cpp: (CPluginWin::CreateStreamL):
- ResourceLoader/CacheSrc/HttpCacheEntry.cpp: (CHttpCacheEntry::~CHttpCacheEntry):
- ResourceLoader/inc/FileTransaction.h:
- ResourceLoader/src/BufferTransaction.cpp: (CBufferTransaction::HandleResolveComplete):
- ResourceLoader/src/FileTransaction.cpp: (CFileTransaction::DoSubmitL): (CFileTransaction::ParseFileNameL): (CFileTransaction::ContentTypeLC):
- ResourceLoader/src/HttpTransaction.cpp: (CHttpTransaction::MHFRunL):
- ResourceLoader/src/UrlResponseHeaderInfo.cpp: (CUrlResponseHeaderInfo::SetResponseHeadersL):
- 10:36 AM Changeset in webkit [24647] by
-
- 2 edits in trunk/WebCore
Used `svn merge -r24646:24645' to revert project changes I accidentally
checked in.
- WebCore.xcodeproj/project.pbxproj:
- 10:26 AM Changeset in webkit [24646] by
-
- 5 edits in trunk/WebCore
Reviewed by Darin Adler.
Fixed <rdar://problem/5241167> REGRESSION: PLT 1% slower due to r21793
(global page cache cap)
I just measured a .1%-.2% regression in PLT average, but a .4% win in
PLT fastest run, so I think this regression is licked.
Surprisingly, the combination of wtf data structures I originally used
for PageCache turned out to be too slow, so I reworked PageCache to use
a hand-crafted linked list for LRU tracking (instead of ListHashSet),
to store its CachedPages in the HistoryItems to which they corresponded
(instead of using a HashMap), and to ref/deref HistoryItems manually
(instead of using RefPtr, which would ref once for every reference in
the linked list).
- history/HistoryItem.h: Added data members for PageCache data. Made PageCache a friend so it could access them. Ideally (from an encapsulation perspective), we would store this data an independent structure, but that's just too slow.
- history/PageCache.cpp: Added a hand-crafted linked list for LRU tracking. (WebCore::PageCache::PageCache): (WebCore::PageCache::add): Adopt the HistoryItem's ref when it's added. (WebCore::PageCache::remove): deref() the Historyitem when it's removed. (WebCore::PageCache::prune): (WebCore::PageCache::addToLRUList): (WebCore::PageCache::removeFromLRUList):
- history/PageCache.h: (WebCore::PageCache::get): Inlined just in case.
- 10:19 AM Changeset in webkit [24645] by
-
- 1 edit3 moves in trunk/LayoutTests
Reviewed by John Sullivan.
Stop the test from dumping load callbacks as they differ on Tiger and Leopard.
This is done by removing the call to dumpResourceLoadCallbacks and moving the test away
from the "loading" directory.
- http/tests/loading/cached-scripts-expected.txt: Removed.
- http/tests/loading/cached-scripts.html: Removed.
- http/tests/loading/resources/cached-scripts-subframe.html: Removed.
- http/tests/misc/cached-scripts-expected.txt: Copied from http/tests/loading/cached-scripts-expected.txt.
- http/tests/misc/cached-scripts.html: Copied from http/tests/loading/cached-scripts.html.
- http/tests/misc/resources/cached-scripts-subframe.html: Copied from http/tests/loading/resources/cached-scripts-subframe.html.
- 9:21 AM Changeset in webkit [24644] by
-
- 2 edits in trunk/WebCore
Launch the context menu in the right place.
- 8:00 AM Changeset in webkit [24643] by
-
- 3 edits in trunk/WebKitQt
Patch from Qing Zhao that adds a signal for history notification.
- 7:47 AM Changeset in webkit [24642] by
-
- 2 edits in trunk
Use QMAKE_LIBDIR instead of QMAKE_LFLAGS to specify the library search path for QtWebKit, as the former is portable and correctly transformed to /LIBPATH: with msvc for example.
- 6:26 AM BuildingQtOnWindows edited by
- (diff)
- 6:24 AM BuildingQtOnWindows edited by
- (diff)
- 6:06 AM BuildingQtOnWindows edited by
- (diff)
- 5:59 AM BuildingQtOnWindows edited by
- (diff)
- 5:55 AM BuildingQtOnWindows created by
- 5:51 AM QtWebKit edited by
- (diff)
- 2:41 AM Applications using WebKit edited by
- (diff)
- 2:36 AM Changeset in webkit [24641] by
-
- 3 edits in trunk
Ensure QtLauncher and DumpRenderTree are linked against the uninstalled QtWebKit library by making sure $$OUTPUT_DIR/lib appears before $QTDIR/lib in the library search path and rpath.
- 12:39 AM Changeset in webkit [24640] by
-
- 4 edits4 adds in branches/feature-branch
Reviewed by Nikolas.
http://bugs.webkit.org/show_bug.cgi?id=14312
Removing an attribute has no effect on SVG
Update the transform matrix also when transform attribute is empty.
- 12:11 AM Changeset in webkit [24639] by
-
- 2 edits in trunk/WebKitSite
- grammar fix pointed out by Mitz.
- projects/goals.html:
Jul 25, 2007:
- 11:44 PM Changeset in webkit [24638] by
-
- 2 edits1 add in trunk/WebKitSite
Rubber stamped by Adam.
Added WebKit Project Goals.
- nav.inc: added a nav link.
- projects/goals.html: Added.
- 9:32 PM WikiStart edited by
- (diff)
- 6:50 PM Changeset in webkit [24637] by
-
- 5 edits in trunk
Reviewed by Mark.
- follow-up to previous change
- kjs/ustring.cpp: (KJS::UString::operator=): Make sure to reset the length when replacing the buffer contents for a single-owned string.
WebCore:
Reviewed by Mark.
- follow-up to previous change to avoid assertion failures in debug
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseText): hold JSLock when needed (WebCore::XMLHttpRequest::open): ditto (WebCore::XMLHttpRequest::didFinishLoading): ditto (WebCore::XMLHttpRequest::didReceiveData): ditto
- xml/XMLHttpRequest.h:
- 5:08 PM Changeset in webkit [24636] by
-
- 3 edits4 adds in trunk
LayoutTests:
Reviewed by Darin.
<rdar://problem/5327912>
iDisk: Web iDisk & main iDisk appear blank
- http/tests/loading/cached-scripts-expected.txt: Added.
- http/tests/loading/cached-scripts.html: Added.
- http/tests/loading/resources: Added.
- http/tests/loading/resources/cached-scripts-subframe.html: Added.
WebCore:
Reviewed by Darin.
<rdar://problem/5327912>
iDisk: Web iDisk & main iDisk appear blank
Prepend any remaining text that scripts might have written.
- html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptExecution):
- 3:45 PM Changeset in webkit [24635] by
-
- 3 edits in branches/feature-branch/WebCore
Reviewed by Oliver.
Unify absoluteRects() of RenderSVGTSpan & RenderSVGTextPath.
The RenderSVGTextPath one was still using the old, wrong concept.
- 3:15 PM Changeset in webkit [24634] by
-
- 8 edits6 adds in trunk
LayoutTests:
Reviewed by .
- mac/leopard/Skipped: Removing some tests that were removed earlier, but checked back in accidentally. Not sure how they got back into my file though.
WebCore:
Reviewed by Tim, Darin, Oliver.
- <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
- Check for file:// urls when clicking links, not block all schemes that are treated as local.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::load):
WebKitTools:
Reviewed by Tim, Darin, Oliver.
- <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
- Change DRT to be able to intercept the requst to load so it can check if a scheme was allowed or not.
- ChangeLog:
- DumpRenderTree/DumpRenderTree.m: (createWebView): (dumpRenderTree): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setCustomPolicyDelegate:]):
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/FrameLoadDelegate.h:
- DumpRenderTree/PolicyDelegate.h: Added.
- DumpRenderTree/PolicyDelegate.m: Added. (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
- DumpRenderTree/ResourceLoadDelegate.h:
- 2:50 PM Changeset in webkit [24633] by
-
- 21 edits7 adds in trunk
Reviewed by Darin.
- JavaScriptCore part of fix for <rdar://problem/5300291> Optimize GC to reclaim big, temporary objects (like XMLHttpRequest.responseXML) quickly
Also, as a side effect of optimizations included in this patch:
- 7% speedup on JavaScript iBench
- 4% speedup on "Celtic Kane" JS benchmark
The basic idea is explained in a big comment in collector.cpp. When unusually
large objecs are allocated, we push the next GC closer on the assumption that
most objects are short-lived.
I also did the following two optimizations in the course of tuning
this not to be a performance regression:
1) Change UString::Rep to hold a self-pointer as the baseString in
the unshared case, instead of a null pointer; this removes a
number of null checks in hot code because many places already
wanted to use the rep itself or the baseString as appropriate.
2) Avoid creating duplicate StringImpls when creating a
StringInstance (the object wrapper for a JS string) or calling
their methods. Since a temporary wrapper object is made every time
a string method is called, this resulted in two useless extra
StringImpls being allocated for no reason whenever a String method
was invoked on a string value. Now we bypass those.
- kjs/collector.cpp: (KJS::): (KJS::Collector::recordExtraCost): Basics of the extra cost mechanism. (KJS::Collector::allocate): ditto (KJS::Collector::collect): ditto
- kjs/collector.h: (KJS::Collector::reportExtraMemoryCost): ditto
- kjs/array_object.cpp: (ArrayInstance::ArrayInstance): record extra cost
- kjs/internal.cpp: (KJS::StringImp::toObject): don't create a whole new StringImpl just to be the internal value of a StringInstance! StringImpls are immutable so there's no point tot his.
- kjs/internal.h: (KJS::StringImp::StringImp): report extra cost
- kjs/string_object.cpp: (KJS::StringInstance::StringInstance): new version that takes a StringImp (KJS::StringProtoFunc::callAsFunction): don't create a whole new StringImpl just to convert self to string! we already have one in the internal value
- kjs/string_object.h: report extra cost
- kjs/ustring.cpp: All changes to handle baseString being self instead of null in the unshared case. (KJS::): (KJS::UString::Rep::create): (KJS::UString::Rep::destroy): (KJS::UString::usedCapacity): (KJS::UString::usedPreCapacity): (KJS::UString::expandCapacity): (KJS::UString::expandPreCapacity): (KJS::UString::UString): (KJS::UString::append): (KJS::UString::operator=): (KJS::UString::copyForWriting):
- kjs/ustring.h: (KJS::UString::Rep::baseIsSelf): new method, now that baseString is self instead of null in the unshared case we can't just null check. (KJS::UString::Rep::data): adjusted as mentioned above (KJS::UString::cost): new method to compute the cost for a UString, for use by StringImpl.
- kjs/value.cpp: (KJS::jsString): style fixups. (KJS::jsOwnedString): new method, use this for strings allocated from UStrings held by the parse tree. Tracking their cost as part of string cost is pointless, because garbage collecting them will not actually free the relevant string buffer.
- kjs/value.h: prototyped jsOwnedString.
- kjs/nodes.cpp: (StringNode::evaluate): use jsOwnedString as appropriate (RegExpNode::evaluate): ditto (PropertyNameNode::evaluate): ditto (ForInNode::execute): ditto
- JavaScriptCore.exp: Exported some new symbols.
WebCore:
Reviewed by Darin.
- fixed <rdar://problem/5300291> Optimize GC to reclaim big, temporary objects (like XMLHttpRequest.responseXML) quickly
With this plus related JavaScriptCore changes, a number of XMLHttpRequest situations that
result in huge data sets are addressed, including a single huge responseXML on an XMR done
repeatedly, or accessing responseText repeatedly during loading of a single large XHR.
In addition to the GC changes in JavaScriptCore, I changed responseText to be stored as a
KJS::UString instead of a WebCore::String so that the JavaScript responseText value can
share the buffer (indeed multiple intermediate responseTexts can share its buffer).
First of all, here's some manual test cases that will each blow out the process VM without this fix,
but will settle into decent steady state with.
- manual-tests/memory: Added.
- manual-tests/memory/MessageUidsAlreadyDownloaded2: Added.
- manual-tests/memory/string-growth.html: Added.
- manual-tests/memory/xhr-multiple-requests-responseText.html: Added.
- manual-tests/memory/xhr-multiple-requests-responseXML.html: Added.
- manual-tests/memory/xhr-multiple-requests.html: Added.
- manual-tests/memory/xhr-repeated-string-access.xml: Added.
And here's the actual code changes:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDocumentCustom.cpp: (WebCore::toJS): Record extra cost if the document is frameless (counting the nodes doesn't make a measurable performance difference here in any case I could find)
- bindings/js/JSXMLHttpRequest.cpp: (KJS::JSXMLHttpRequest::getValueProperty): Adjust for the fact that ressponseText is now stored as a UString.
- bindings/js/kjs_binding.cpp: (KJS::jsOwnedStringOrNull): New helper.
- bindings/js/kjs_binding.h:
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getResponseText): It's a UString! (WebCore::XMLHttpRequest::getResponseXML): handle the fact that m_responseText is a UString. (WebCore::XMLHttpRequest::XMLHttpRequest): ditto. (WebCore::XMLHttpRequest::abort): call dropProtection (WebCore::XMLHttpRequest::didFinishLoading): call dropProtection (WebCore::XMLHttpRequest::dropProtection): after removing our GC protection, report extra cost of this XHR's responseText buffer.
- xml/XMLHttpRequest.h:
- 2:41 PM Changeset in webkit [24632] by
-
- 5 edits in trunk/WebCore
Reviewed by Brady.
<rdar://problem/4796657> table deletion outline does not always follow the table size as editing occurs inside
Change the outline element to position itself automaticlly using the top, left, bottom and right CSS properties.
This made the container element redundant, so it has been removed. Now the outline element and the delete button
both get appended to the target element and positioned based on that container element. This removes the need
to update the width and height when the target contents changed.
- editing/DeleteButtonController.cpp: (WebCore::DeleteButtonController::show): Change the style properties and remove the container element. (WebCore::DeleteButtonController::hide): Remove the button and outline from the target element.
- editing/DeleteButtonController.h: Removed updateOutlineStyle, respondToChangedContents and m_containerElement.
- editing/Editor.cpp: (WebCore::Editor::respondToChangedContents): Remove the call to DeleteButtonController respondToChangedContents.
- 2:35 PM Changeset in webkit [24631] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
<rdar://problem/5344471>
CrashTracer: [USER] 1 crash in Mail at WebCore::PluginTokenizer::writeRawData(char const*, int)
Make sure to layout so we'll have a renderer. Also null-check the renderer for extra safety.
- loader/PluginDocument.cpp: (WebCore::PluginTokenizer::writeRawData):
- 1:54 PM Changeset in webkit [24630] by
-
- 4 edits in trunk/WebKit/win
2007-07-25 Ada Chan <adachan@apple.com>
Reviewed by Adam and Steve.
Implemented some DOM methods and other fixes for <rdar://problem/5311601>.
- DOMCoreClasses.cpp: (DOMNode::ownerDocument): implemented (DOMDocument::getComputedStyle): get the DOMElement via QueryInterface (DOMElement::QueryInterface):
- DOMHTMLClasses.cpp: (DOMHTMLDocument::body): fixed leak (DOMHTMLFormElement::action): implemented (DOMHTMLFormElement::method): ditto (DOMHTMLInputElement::form): ditto (DOMHTMLTextAreaElement::form): ditto
- Interfaces/DOMHTML.idl: IDOMHTMLInputElement should inherit from IDOMHTMLElement
- 1:12 PM Changeset in webkit [24629] by
-
- 2 edits in trunk/WebKitTools
Fix build for some reported systems.
- 1:02 PM BuildingGdk edited by
- (diff)
- 12:14 PM Changeset in webkit [24628] by
-
- 4 edits in branches/feature-branch/WebCore
Reviewed by Sam.
Let <textPath> be recognized within the ObjC bindings.
Forgot to add that months ago.
- 12:07 PM Changeset in webkit [24627] by
-
- 2 edits in trunk/LayoutTests
Reviewed by .
- mac/leopard/Skipped: Removing some tests that were removed earlier, but checked back in accidentally. Not sure how they got back into my file though.
- 12:01 PM Changeset in webkit [24626] by
-
- 1 edit in trunk/LayoutTests/mac/leopard/Skipped
- 11:48 AM Changeset in webkit [24625] by
-
- 2 edits in trunk/LayoutTests
Reviewed by .
- mac/leopard/Skipped: Adding to skip list to avoid false failure
- 9:54 AM Changeset in webkit [24624] by
-
- 6 edits in trunk/WebCore
Reviewed by Maciej, Darin.
Add ResourceHandle::setClient to resolve some messiness with handle
releasing. Clear the client when ResourceLoader is going to release
the handle to prevent crashes in the case where somebody still holds a
reference (this doesn't seem to currently happen in practice). Add
NULL-checking for ResourceHandle implementations using the client.
- loader/ResourceLoader.cpp: (WebCore::ResourceLoader::releaseResources):
- platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::fireBlockedFailure): (WebCore::ResourceHandle::setClient):
- platform/network/ResourceHandle.h:
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): (WebCore::didReceiveResponse): (WebCore::didReceiveData): (WebCore::didFinishLoading): (WebCore::didFail): (WebCore::willCacheResponse): (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::receivedCancellation):
- platform/network/mac/ResourceHandleMac.mm: (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): (WebCore::ResourceHandle::didCancelAuthenticationChallenge): (WebCore::ResourceHandle::receivedCancellation): (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]): (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]): (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]): (-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]): (-[WebCoreResourceHandleAsDelegate connection:didFailWithError:]): (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
- 8:52 AM Changeset in webkit [24623] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=11756 <rdar://problem/5286420>
Fix a typo error to really compare the present domain to the domain of the parent of the targeted frame.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::canTarget):
- 8:50 AM Changeset in webkit [24622] by
-
- 2 edits in trunk/LayoutTests
Reviewed by .
- Reverted
- win/Skipped:
- 8:49 AM Changeset in webkit [24621] by
-
- 4 edits4 adds in trunk
LayoutTests:
Reviewed by Darin.
- test for http://bugs.webkit.org/show_bug.cgi?id=14758 REGRESSION: Repeated text after line break on facebook.com
- fast/text/reset-emptyRun-expected.checksum: Added.
- fast/text/reset-emptyRun-expected.png: Added.
- fast/text/reset-emptyRun-expected.txt: Added.
- fast/text/reset-emptyRun.html: Added.
WebCore:
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=14758 REGRESSION: Repeated text after line break on facebook.com
Test: fast/text/reset-emptyRun.html
- platform/BidiResolver.h: (WebCore::::deleteRuns): Re-add a line that was removed for no reason at all during refactoring in r24485.
- rendering/bidi.cpp: (WebCore::BidiState::deleteRuns): Ditto.
- 8:44 AM Changeset in webkit [24620] by
-
- 2 edits in trunk/LayoutTests
Reviewed by .
- Forgot to checking the changes to the skipped list so the win bot doesn't fail.
- win/Skipped:
- 2:57 AM Changeset in webkit [24619] by
-
- 8 edits6 deletes in trunk
Roll out r24618 as it broke 600+ layout tests.
- 2:08 AM Changeset in webkit [24618] by
-
- 8 edits6 adds in trunk
LayoutTests:
Reviewed by Oliver.
- <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
- Tests that feed:// urls can still be followed when clicked.
- http/tests/security/feed-urls-from-remote-expected.txt: Added.
- http/tests/security/feed-urls-from-remote.html: Added.
- http/tests/security/resources/feed.html: Added.
- http/tests/security/resources/feed.xml: Added.
- win/Skipped:
WebCore:
Reviewed by Oliver.
- <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
- Check for file:// urls when clicking links, not block all schemes that are treated as local.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::load):
WebKitTools:
Reviewed by Oliver.
- <rdar://problem/5329440> REGRESSION: Clicking links with the feed:// protocol in Safari 3 does nothing
- Change DRT to be able to intercept the requst to load so it can check if a scheme was allowed or not.
- ChangeLog:
- DumpRenderTree/DumpRenderTree.m: (createWebView): (dumpRenderTree): (+[LayoutTestController isSelectorExcludedFromWebScript:]): (+[LayoutTestController webScriptNameForSelector:]): (-[LayoutTestController setCustomPolicyDelegate:]):
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/FrameLoadDelegate.h:
- DumpRenderTree/PolicyDelegate.h: Added.
- DumpRenderTree/PolicyDelegate.m: Added. (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
- DumpRenderTree/ResourceLoadDelegate.h:
Jul 24, 2007:
- 10:38 PM Changeset in webkit [24617] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Adam Roben
<rdar://problem/5313504> - Some Back/Forward tests fail on Leopard
- mac/leopard/Skipped: Remove from the skipped list as they work now
- 9:37 PM Changeset in webkit [24616] by
-
- 13 edits in trunk
WebCore:
Reviewed by Adam and Justin.
<rdar://problem/5141779> WebView editableDOMRangeForPoint: & moveDragCaretToPoint: returns last position in DOMText range
Remove bridge implementation for editableDOMRangeForPoint: and moveDragCaretToPoint:.
Now use cross-platform code Editor::rangeForPoint and DragController::placeDragCaret instead.
This required lifting local code from DragController.cpp into the shared methods
Frame::visiblePositionForPoint and Frame::documentAtPoint.
- WebCore.exp:
- editing/Editor.cpp: (WebCore::Editor::rangeForPoint):
- editing/Editor.h:
- page/DragController.cpp: (WebCore::DragController::dragEnded): (WebCore::DragController::performDrag): (WebCore::DragController::dragEnteredOrUpdated): (WebCore::DragController::tryDocumentDrag): (WebCore::DragController::operationForLoad): (WebCore::setSelectionToDragCaret): (WebCore::DragController::concludeDrag): (WebCore::DragController::placeDragCaret):
- page/DragController.h:
- page/Frame.cpp: (WebCore::Frame::visiblePositionForPoint): (WebCore::Frame::documentAtPoint):
- page/Frame.h:
- page/mac/WebCoreFrameBridge.h:
- page/mac/WebCoreFrameBridge.mm:
WebKit:
Reviewed by Adam and Justin.
<rdar://problem/5141779> WebView editableDOMRangeForPoint: & moveDragCaretToPoint: returns last position in DOMText range
editableDOMRangeForPoint:, moveDragCaretToPoint:, and removeDragCaret now call directly into
WebCore without relying on bridge look up through the now removed _bridgeAtPoint:.
- WebKit.xcodeproj/project.pbxproj:
- WebView/WebView.mm: (-[WebView moveDragCaretToPoint:]): (-[WebView removeDragCaret]): (-[WebView editableDOMRangeForPoint:]):
- 6:22 PM Changeset in webkit [24615] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by Adam Roben.
Remove unused .strip files.
- WebCore.xcodeproj/project.pbxproj:
- 6:21 PM Changeset in webkit [24614] by
-
- 1 copy in tags/Safari-522.14.3b
New tag.
- 6:20 PM Changeset in webkit [24613] by
-
- 1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION
Bump version for submit
- 6:20 PM Changeset in webkit [24612] by
-
- 2 edits in trunk/LayoutTests
Adding to the Leopard skip list to avoid a test that hangs due to a CFNetwork bug.
- mac/leopard/Skipped:
- 6:10 PM Changeset in webkit [24611] by
-
- 1 copy in tags/Safari-522.15.5b
New tag.
- 6:04 PM Changeset in webkit [24610] by
-
- 1 edit in trunk/LayoutTests/mac/leopard/Skipped
Updating skipped list
- 5:53 PM Changeset in webkit [24609] by
-
- 3 edits in trunk/LayoutTests
Updating test to put JS code in the onload handler helps to avoid intermittent failures.
<rdar://problem/5313531> REGRESSION(Leopard): editing/pasteboard/copy-in-password-field.html sometimes fails
- editing/pasteboard/copy-in-password-field-expected.txt:
- editing/pasteboard/copy-in-password-field.html:
- 5:02 PM Changeset in webkit [24608] by
-
- 3 edits2 adds in trunk
LayoutTests:
Reviewed by Hyatt.
Test for <rdar://problem/5308492> Computed width for elements with box-sizing: border-box is not equal to the width set in the CSS
- fast/css/getComputedStyle-border-box-expected.txt: Added.
- fast/css/getComputedStyle-border-box.html: Added.
WebCore:
Reviewed by Hyatt.
Fix for <rdar://problem/5308492> Computed width for elements with box-sizing: border-box is not equal to the width set in the CSS
Test: fast/css/getComputedStyle-border-box.html
- css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): For the width and height properties, when you get the value from the renderer, use the renderer's box sizing value to determine the size.
- 4:36 PM Changeset in webkit [24607] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Decker.
<rdar://problem/5355781>
REGRESSION: reproducible crash in CoreFoundation!CFRunLoopFinished on Flash pages
Null check the loader.
- plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::start):
- 4:31 PM Changeset in webkit [24606] by
-
- 2 edits in trunk/WebKit
Reviewed by Anders.
<rdar://problem/4699455> REGRESSION (Safari 2->Safari 3): Adobe Reader 7.0.8 plug-in doesn't work
- Plugins/WebNetscapePluginEmbeddedView.h: Added a #define that renames this class to "WebNetscapePluginDocumentView" This is necessary because the Adobe 7.x Acrobat plug-in has a hard coded check for a view named "WebNetscapePluginDocumentView" and will not function correctly if it doesn't find a view in the hierarchy without the old class name.
- 3:59 PM Changeset in webkit [24605] by
-
- 12 edits105 adds in branches/feature-branch
Reviewed by Oliver.
Fix all known bugs regarding to SVG text selection, when embedded in XHTML.
Also fix inspecting <text> elements when embedded in XHTML. (WebInspector)
- 3:23 PM Changeset in webkit [24604] by
-
- 103 edits4 adds in trunk
LayoutTests:
Reviewed by Hyatt and Adam.
Added and updated tests for <rdar://problem/5130590> REGRESSION: style="width:1px" on <select> element no longer hides the element
The metrics have changed for the anonymous block inside popup buttons.
- fast/forms/menulist-narrow-width-expected.checksum: Added.
- fast/forms/menulist-narrow-width-expected.png: Added.
- fast/forms/menulist-narrow-width-expected.txt: Added.
- fast/forms/menulist-narrow-width.html: Added.
- editing/pasteboard/4641033-expected.txt:
- editing/pasteboard/4944770-1-expected.txt:
- editing/pasteboard/4944770-2-expected.txt:
- editing/pasteboard/select-element-1-expected.txt:
- editing/selection/caret-before-select-expected.txt:
- editing/selection/replaced-boundaries-3-expected.txt:
- editing/selection/select-box-expected.txt:
- editing/selection/select-element-paragraph-boundary-expected.txt:
- fast/block/float/float-avoidance-expected.txt:
- fast/block/margin-collapse/103-expected.txt:
- fast/forms/001-expected.checksum:
- fast/forms/001-expected.png:
- fast/forms/001-expected.txt:
- fast/forms/003-expected.txt:
- fast/forms/004-expected.txt:
- fast/forms/HTMLOptionElement_label01-expected.txt:
- fast/forms/HTMLOptionElement_label02-expected.txt:
- fast/forms/HTMLOptionElement_label03-expected.txt:
- fast/forms/HTMLOptionElement_label04-expected.txt:
- fast/forms/HTMLOptionElement_label06-expected.txt:
- fast/forms/HTMLOptionElement_label07-expected.txt:
- fast/forms/control-restrict-line-height-expected.txt:
- fast/forms/disabled-select-change-index-expected.txt:
- fast/forms/form-element-geometry-expected.txt:
- fast/forms/menulist-separator-painting-expected.txt:
- fast/forms/menulist-width-change-expected.txt:
- fast/forms/option-script-expected.txt:
- fast/forms/option-strip-whitespace-expected.txt:
- fast/forms/option-text-clip-expected.txt:
- fast/forms/select-accesskey-expected.txt:
- fast/forms/select-align-expected.txt:
- fast/forms/select-baseline-expected.txt:
- fast/forms/select-change-listbox-to-popup-expected.txt:
- fast/forms/select-disabled-appearance-expected.txt:
- fast/forms/select-initial-position-expected.txt:
- fast/forms/select-selected-expected.txt:
- fast/forms/select-size-expected.txt:
- fast/forms/select-style-expected.txt:
- fast/forms/select-visual-hebrew-expected.txt:
- fast/forms/select-writing-direction-natural-expected.txt:
- fast/forms/stuff-on-my-optgroup-expected.txt:
- fast/html/keygen-expected.txt:
- fast/invalid/014-expected.txt:
- fast/invalid/residual-style-expected.txt:
- fast/parser/document-write-option-expected.txt:
- fast/replaced/replaced-breaking-expected.txt:
- fast/replaced/replaced-breaking-mixture-expected.txt:
- fast/replaced/three-selects-break-expected.txt:
- fast/replaced/width100percent-expected.txt:
- fast/text/international/bidi-menulist-expected.txt:
- http/tests/navigation/anchor-basic-expected.txt:
- http/tests/navigation/anchor-frames-expected.txt:
- http/tests/navigation/anchor-goback-expected.txt:
- http/tests/navigation/anchor-subframeload-expected.txt:
- http/tests/navigation/javascriptlink-basic-expected.txt:
- http/tests/navigation/javascriptlink-frames-expected.txt:
- http/tests/navigation/javascriptlink-goback-expected.txt:
- http/tests/navigation/javascriptlink-subframeload-expected.txt:
- http/tests/navigation/metaredirect-basic-expected.txt:
- http/tests/navigation/metaredirect-frames-expected.txt:
- http/tests/navigation/metaredirect-goback-expected.txt:
- http/tests/navigation/metaredirect-subframeload-expected.txt:
- http/tests/navigation/post-goback2-expected.txt:
- http/tests/navigation/postredirect-goback2-expected.txt:
- http/tests/navigation/redirect302-basic-expected.txt:
- http/tests/navigation/redirect302-frames-expected.txt:
- http/tests/navigation/redirect302-goback-expected.txt:
- http/tests/navigation/redirect302-subframeload-expected.txt:
- http/tests/navigation/relativeanchor-basic-expected.txt:
- http/tests/navigation/relativeanchor-frames-expected.txt:
- http/tests/navigation/relativeanchor-goback-expected.txt:
- http/tests/navigation/slowmetaredirect-basic-expected.txt:
- http/tests/navigation/slowtimerredirect-basic-expected.txt:
- http/tests/navigation/success200-basic-expected.txt:
- http/tests/navigation/success200-frames-expected.txt:
- http/tests/navigation/success200-frames-loadsame-expected.txt:
- http/tests/navigation/success200-goback-expected.txt:
- http/tests/navigation/success200-loadsame-expected.txt:
- http/tests/navigation/success200-reload-expected.txt:
- http/tests/navigation/success200-subframeload-expected.txt:
- http/tests/navigation/timerredirect-basic-expected.txt:
- http/tests/navigation/timerredirect-frames-expected.txt:
- http/tests/navigation/timerredirect-goback-expected.txt:
- http/tests/navigation/timerredirect-subframeload-expected.txt:
- tables/mozilla/bugs/bug1188-expected.txt:
- tables/mozilla/bugs/bug18359-expected.txt:
- tables/mozilla/bugs/bug2479-3-expected.txt:
- tables/mozilla/bugs/bug2479-4-expected.txt:
- tables/mozilla/bugs/bug29326-expected.txt:
- tables/mozilla/bugs/bug33855-expected.txt:
- tables/mozilla/bugs/bug4382-expected.txt:
- tables/mozilla/bugs/bug96334-expected.txt:
- tables/mozilla/core/margins-expected.txt:
- tables/mozilla/dom/tableDom-expected.txt:
- tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
WebCore:
Reviewed by Hyatt and Adam.
Fix for <rdar://problem/5130590> REGRESSION: style="width:1px" on <select> element no longer hides the element
Removed hack that forced large padding on popup buttons. Now we put that padding in the inner block, so that
the specified width will be honored.
- rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::adjustInnerStyle): Set the padding on the inner block based on the metrics provided by the theme. (WebCore::RenderMenuList::controlClipRect): Clip to the intersection of the inner content box and the outer content box. This will leave room for the arrows which sit in the inner box padding, and if the inner box ever spills out of the outer box, that will get clipped too. (WebCore::RenderMenuList::calcPrefWidths): Add in the inner box's padding and border to the pref widths.
- rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuList): Only inflate the rect for the shadow if the rect is big enough to fit the whole control. Also, on Leopard, the NSCell will draw outside of a small rect, so add a clip for that case. (WebCore::RenderThemeMac::paintMenuListButton): Restrict font scale to make sure the arrows will actually fit in the bounds vertically. Don't draw the arrows if they won't fit horizontally. Reset padding. Since WinIE doesn't honor padding for popups, its not critical to support padding at this time. (WebCore::RenderThemeMac::adjustMenuListStyle): Don't set the padding here. Instead, we're going to set the padding on the inner block of the select. (WebCore::RenderThemeMac::adjustMenuListButtonStyle): ditto. (WebCore::RenderThemeMac::popupInternalPaddingLeft): Added. Provides internal padding values for RenderMenuList. (WebCore::RenderThemeMac::popupInternalPaddingRight): ditto. (WebCore::RenderThemeMac::popupInternalPaddingTop): ditto. (WebCore::RenderThemeMac::popupInternalPaddingBottom): ditto.
- rendering/RenderThemeMac.h:
- rendering/RenderThemeSafari.cpp: The same changes that were made to RenderThemeMac were made here, with variations for the arrow differences. This code should be refactored and shared, but now did not seem like the right time to do that refactoring. (WebCore::RenderThemeSafari::paintMenuList): (WebCore::RenderThemeSafari::paintMenuListButton): (WebCore::RenderThemeSafari::adjustMenuListStyle): (WebCore::RenderThemeSafari::popupInternalPaddingLeft): (WebCore::RenderThemeSafari::popupInternalPaddingRight): (WebCore::RenderThemeSafari::popupInternalPaddingTop): (WebCore::RenderThemeSafari::popupInternalPaddingBottom): (WebCore::RenderThemeSafari::adjustMenuListButtonStyle):
- rendering/RenderThemeSafari.h:
- rendering/RenderTheme.h: Added to provide internal padding values for RenderMenuList. (WebCore::RenderTheme::popupInternalPaddingLeft): (WebCore::RenderTheme::popupInternalPaddingRight): (WebCore::RenderTheme::popupInternalPaddingTop): (WebCore::RenderTheme::popupInternalPaddingBottom):
- 1:58 PM Changeset in webkit [24603] by
-
- 4 edits2 adds2 deletes in trunk/WebCore
replace the makeprop and makevalues shell scripts by equivalent perl versions. This is required to remove the last shell dependency when building QtWebKit on Windows.
- 1:43 PM Changeset in webkit [24602] by
-
- 2 edits in trunk/WebKit/win
Removed touch of WebKit.rc to prevent rebuilds of the rc file.
The autoversion info can get slightly out of date now, but this isn't a huge problem relative to the rebuilds.
Rubber-stamped by Adam.
- WebKit.vcproj/WebKit.vcproj:
- 1:05 PM Changeset in webkit [24601] by
-
- 1 copy in tags/Safari-522.15.4b
New tag.
- 12:49 PM Changeset in webkit [24600] by
-
- 3 edits in trunk/WebKitQt
These are no longer necessary or used.
- 12:03 PM Changeset in webkit [24599] by
-
- 3 edits8 adds in trunk
LayoutTests:
Reviewed by Darin.
Tests for http://bugs.webkit.org/show_bug.cgi?id=14714 REGRESSION:
ASSERTION FAILED: i < size() in Vector.h:401 on negative -webkit-
column-width
- and - http://bugs.webkit.org/show_bug.cgi?id=14718 REGRESSION: ASSERTION FAILED: i < size() in Vector.h:401 on zero -webkit-column-count
- fast/multicol/negativeColumnWidth-expected.checksum: Added.
- fast/multicol/negativeColumnWidth-expected.png: Added.
- fast/multicol/negativeColumnWidth-expected.txt: Added.
- fast/multicol/negativeColumnWidth.html: Added.
- fast/multicol/zeroColumnCount-expected.checksum: Added.
- fast/multicol/zeroColumnCount-expected.png: Added.
- fast/multicol/zeroColumnCount-expected.txt: Added.
- fast/multicol/zeroColumnCount.html: Added.
WebCore:
Reviewed by Darin.
Fix for http://bugs.webkit.org/show_bug.cgi?id=14714 REGRESSION:
ASSERTION FAILED: i < size() in Vector.h:401 on negative -webkit-
column-width
- and - http://bugs.webkit.org/show_bug.cgi?id=14718 REGRESSION: ASSERTION FAILED: i < size() in Vector.h:401 on zero -webkit-column-count
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcColumnWidth): Make 1 the minimum value for column-width and column-count. Since the spec does not address what to do with negative values for these properties, we are patching the rendering code instead of the parser.
- 11:49 AM Changeset in webkit [24598] by
-
- 2 edits in S60/branches/3.1m/WebCore
2007-07-20 vmalaiya, <vikram.malaiya@nokia.com>
Reviewed by Yongjun
DESC: JPKN-6Z38E5 - Browser crashes and problems with memory low note.
Fix - Remove Nokia specific changes so that the name chache is updated before
an attempt to retrieve information from it.
- khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::namedItems):
- 11:47 AM Changeset in webkit [24597] by
-
- 2 edits in S60/trunk/WebCore
2007-07-20 vmalaiya, <vikram.malaiya@nokia.com>
Reviewed by Yongjun
DESC: JPKN-6Z38E5 - Browser crashes and problems with memory low note.
Fix - Remove Nokia specific changes so that the name chache is updated before
an attempt to retrieve information from it.
- khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::namedItems):
- 11:44 AM Changeset in webkit [24596] by
-
- 2 edits in trunk/WebCore
Reviewed by Steve.
<rdar://problem/5355403>
REGRESSION: 303A2 does not display pdf files with AdobeReader 8.1
Close the file before handing off the file name to the plug-in.
- plugins/win/PluginStreamWin.cpp: (WebCore::PluginStreamWin::destroyStream):
- 11:29 AM Changeset in webkit [24595] by
-
- 3 edits in trunk/WebCore
2007-07-24 Alp Toker <alp.toker@collabora.co.uk>
Reviewed by Adam.
http://bugs.webkit.org/show_bug.cgi?id=14711
RenderThemeGdk's buttons are state-agnostic (pressed, hovered)
Remove unnecessary label from widget instances.
Render check and radio widgets correctly.
Determine the widget state and render it appropriately.
- platform/gdk/RenderThemeGdk.cpp: (WebCore::RenderThemeGdk::determineState): (WebCore::RenderThemeGdk::paintCheckbox): (WebCore::RenderThemeGdk::paintRadio): (WebCore::RenderThemeGdk::paintButton): (WebCore::RenderThemeGdk::gtkButton): (WebCore::RenderThemeGdk::gtkCheckbox): (WebCore::RenderThemeGdk::gtkRadioButton):
- platform/gdk/RenderThemeGdk.h:
- 9:55 AM Applications using WebKit edited by
- Including PageOutline (diff)
- 7:52 AM Changeset in webkit [24594] by
-
- 1 copy in tags/JavaScriptCore-419.2.1/JavaScriptCore
New tag (part 2).
- 7:51 AM Changeset in webkit [24593] by
-
- 1 add in tags/JavaScriptCore-419.2.1
New tag (part 1).
- 7:51 AM Changeset in webkit [24592] by
-
- 1 copy in tags/JavaScriptCore-418.6.1/JavaScriptCore
New tag (part 2).
- 7:50 AM Changeset in webkit [24591] by
-
- 1 add in tags/JavaScriptCore-418.6.1
New tag (part 1).
- 7:48 AM Changeset in webkit [24590] by
-
- 2 edits in branches/Safari-2.0-dashboard/JavaScriptCore
Versioning.
- 7:47 AM Changeset in webkit [24589] by
-
- 2 edits in branches/Safari-2.0-dashboard/JavaScriptCore
2007-07-25 Mark Rowe <mrowe@apple.com>
Build fix for GCC 3.3.
- pcre/pcre_compile.c: Remove unused variables.
- 7:44 AM Changeset in webkit [24588] by
-
- 2 edits in branches/Safari-2.0-system/JavaScriptCore
Versioning.
- 7:44 AM Changeset in webkit [24587] by
-
- 2 edits in branches/Safari-2.0-system/JavaScriptCore
2007-07-25 Mark Rowe <mrowe@apple.com>
Build fix for GCC 3.3.
- pcre/pcre_compile.c: Remove unused variables.
- 5:56 AM Changeset in webkit [24586] by
-
- 82 edits in trunk/WebCore/page/inspector/Images
Set the correct svn:mime-type on WebCore/page/inspector/Images/*.png
- 5:21 AM Changeset in webkit [24585] by
-
- 5 edits in trunk
2007-07-24 Mark Rowe <mrowe@apple.com>
Reviewed by Antti.
<rdar://problem/5356666> NSMenuItem's seen leaking on buildbot
- platform/mac/ContextMenuItemMac.mm: (WebCore::ContextMenuItem::releasePlatformDescription): Transfer ownership from the RetainPtr's CF-based retain count to the Foundation retain count so that callers of releasePlatformDescription can use -[NSObject release] to dispose of it in a manner that won't leak under Obj-C GC.
- platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::appendItem): Release platformItem as we were transferred its ownership by releasePlatformDescription. (WebCore::ContextMenu::insertItem): ditto.
2007-07-24 Mark Rowe <mrowe@apple.com>
Reviewed by Antti.
<rdar://problem/5356666> NSMenuItem's seen leaking on buildbot
- WebCoreSupport/WebContextMenuClient.mm: (WebContextMenuClient::contextMenuItemSelected): Release platformItem as we were transferred its ownership by releasePlatformDescription.
- 4:47 AM Changeset in webkit [24584] by
-
- 2 edits in trunk/WebCore
Roll out r24583, it needs further consideration.
- 4:42 AM BuildingOnLinux edited by
- (diff)
- 4:40 AM Changeset in webkit [24583] by
-
- 2 edits in trunk/WebCore
2007-07-24 Mark Rowe <mrowe@apple.com>
Reviewed by Oliver.
<rdar://problem/5356666> NSMenuItem's seen leaking on buildbot
- platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::appendItem): Release the platformItem after we take ownership of it from the ContextMenuItem.
- 3:38 AM BuildingOnLinux edited by
- (diff)
- 3:36 AM BuildingOnLinux created by
- 3:23 AM WikiStart edited by
- (diff)
- 2:55 AM Changeset in webkit [24582] by
-
- 34 edits6 adds2 deletes in trunk
2007-07-24 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=14684 Hebrew text in Safari chrome is reversed (LTR instead of RTL)
Test: fast/text/drawBidiText.html
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- manual-tests/chrome-bidi-text.html: Added.
- manual-tests/resources/chrome-bidi-text-window.html: Added.
- platform/BidiReorderCharacters.cpp: Removed.
- platform/BidiReorderCharacters.h: Removed.
- platform/BidiResolver.h: (WebCore::BidiCharacterRun::start): Added accessor method. (WebCore::BidiCharacterRun::stop): Ditto. (WebCore::BidiCharacterRun::level): Ditto. (WebCore::BidiCharacterRun::next): Ditto. (WebCore::::appendRun): Added default implementation.
- platform/TextStyle.h: (WebCore::TextStyle::setDirectionalOverride): Added accessor method.
- platform/graphics/GraphicsContext.cpp: (WebCore::TextRunIterator::TextRunIterator): Added. A BidiResolver- compliant iterator over the characters in a TextRun. (WebCore::TextRunIterator::offset): (WebCore::TextRunIterator::increment): (WebCore::TextRunIterator::atEnd): (WebCore::TextRunIterator::current): (WebCore::TextRunIterator::direction): (WebCore::TextRunIterator::operator==): (WebCore::TextRunIterator::operator!=): (WebCore::GraphicsContext::drawBidiText): Added. Applies the Unicode Bidi Algorithm to the text and draws the resulting unidirectional runs in the right order and with the right directionality.
- platform/graphics/GraphicsContext.h:
- platform/win/PopupMenuWin.cpp: (WebCore::PopupMenu::paint): Replaced the use of a character buffer and BidiReorderCharacters with calling to drawBidiText(). Removed special handling of '-webkit-rtl-ordering:visual' because that CSS property is an implementation detail of WebCore's visual Hebrew support, and the UA stylesheet sets it to 'logical' for this form control. Authors can specify the ordering using the 'direction' and 'unicode-bidi' properties.
- platform/win/WebCoreTextRenderer.cpp: (WebCore::isOneLeftToRightRun): Added. Checks if the text consists of a single left-to-right run, in which case it requires no bidi processing. (WebCore::doDrawTextAtPoint): Changed to call drawBidiText if the text is not entirely left-to-right.
- rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::paintObject): Replaced the use of a character buffer in BidiReorderCharacters with calling to drawBidiText(). Removed special handling of '-webkit-rtl-ordering:visual' for the same reason stated above.
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::paintItemForeground): Ditto. Also changed the run-rounding modes used when drawing to match those used when measuring.
2007-07-24 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- test, updated tests and updated results for http://bugs.webkit.org/show_bug.cgi?id=14684 Hebrew text in Safari chrome is reversed (LTR instead of RTL)
- fast/forms/HTMLOptionElement_label05-expected.checksum:
- fast/forms/HTMLOptionElement_label05-expected.png:
- fast/forms/listbox-deselect-scroll-expected.checksum:
- fast/forms/listbox-deselect-scroll-expected.png:
- fast/forms/listbox-width-change-expected.checksum:
- fast/forms/listbox-width-change-expected.png:
- fast/forms/option-strip-whitespace-expected.checksum:
- fast/forms/option-strip-whitespace-expected.png:
- fast/forms/select-change-popup-to-listbox-expected.checksum:
- fast/forms/select-change-popup-to-listbox-expected.png:
- fast/forms/select-initial-position-expected.checksum:
- fast/forms/select-initial-position-expected.png:
- fast/text/drawBidiText-expected.checksum: Added.
- fast/text/drawBidiText-expected.png: Added.
- fast/text/drawBidiText-expected.txt: Added.
- fast/text/drawBidiText.html: Added.
- fast/text/international/bidi-listbox-atsui-expected.checksum:
- fast/text/international/bidi-listbox-atsui-expected.png:
- fast/text/international/bidi-listbox-atsui-expected.txt:
- fast/text/international/bidi-listbox-atsui.html: Removed the visual ordering cases.
- fast/text/international/bidi-listbox-expected.checksum:
- fast/text/international/bidi-listbox-expected.png:
- fast/text/international/bidi-listbox-expected.txt:
- fast/text/international/bidi-listbox.html: Removed the visual ordering cases because the patch removed special handling of visual ordering.
- 2:29 AM Changeset in webkit [24581] by
-
- 1 copy in tags/JavaScriptCore-4522.10.1/JavaScriptCore
New tag (part 2).
- 2:29 AM Changeset in webkit [24580] by
-
- 1 add in tags/JavaScriptCore-4522.10.1
New tag (part 1).
- 2:28 AM Changeset in webkit [24579] by
-
- 1 edit in branches/Safari-522/JavaScriptCore/Configurations/Version.xcconfig
Versioning.
- 2:28 AM Changeset in webkit [24578] by
-
- 6 edits in branches/Safari-522/JavaScriptCore
2007-07-24 Mark Rowe <mrowe@apple.com>
Merge r24453.
2007-07-19 Darin Adler <Darin Adler>
Reviewed by Geoff.
- fix <rdar://problem/5345440> PCRE computes wrong length for expressions with quantifiers on named recursion or subexpressions
It's challenging to implement proper preflighting for compiling these advanced features.
But we don't want them in the JavaScript engine anyway.
Turned off the following features of PCRE (some of these are simply parsed and not implemented):
\C \E \G \L \N \P \Q \U \X \Z
\e \l \p \u \z
[::] .. [==]
(?#) (?<=) (?<!) (?>)
(?C) (?P) (?R)
(?0) (and 1-9)
(?imsxUX)
Added the following:
\u \v
Because of \v, the js1_2/regexp/special_characters.js test now passes.
To be conservative, I left some features that JavaScript doesn't want, such as
\012 and \x{2013}, in place. We can revisit these later; they're not directly-enough
related to avoiding the incorrect preflighting.
I also didn't try to remove unused opcodes and remove code from the execution engine.
That could save code size and speed things up a bit, but it would require more changes.
- kjs/regexp.h:
- kjs/regexp.cpp: (KJS::RegExp::RegExp): Remove the sanitizePattern workaround for lack of \u support, since the PCRE code now has \u support.
- pcre/pcre-config.h: Set JAVASCRIPT to 1.
- pcre/pcre_internal.h: Added ESC_v.
- pcre/pcre_compile.c: Added a different escape table for when JAVASCRIPT is set that omits all the escapes we don't want interpreted and includes '\v'. (check_escape): Put !JAVASCRIPT around the code for '\l', '\L', '\N', '\u', and '\U', and added code to handle '\u2013' inside JAVASCRIPT. (compile_branch): Put !JAVASCRIPT if around all the code implementing the features we don't want. (pcre_compile2): Ditto.
- tests/mozilla/expected.html: Updated since js1_2/regexp/special_characters.js now passes.
- 2:28 AM Changeset in webkit [24577] by
-
- 2 edits in branches/Safari-522/JavaScriptCore
2007-07-24 Mark Rowe <mrowe@apple.com>
Merge r24430.
2007-07-18 Darin Adler <Darin Adler>
Reviewed by Oliver Hunt.
- fix <rdar://problem/5345432> PCRE computes length wrong for expressions such as "[]"
Test: fast/js/regexp-charclass-crash.html
- pcre/pcre_compile.c: (pcre_compile2): Fix the preflight code that calls check_posix_syntax to match the actual regular expression compilation code; before it was missing the check of the first character.
- 2:15 AM Changeset in webkit [24576] by
-
- 1 copy in tags/JavaScriptCore-312.3.3/JavaScriptCore
New tag (part 2).
- 2:14 AM Changeset in webkit [24575] by
-
- 1 add in tags/JavaScriptCore-312.3.3
New tag (part 1).
- 2:13 AM Changeset in webkit [24574] by
-
- 1 edit in branches/Safari-1-3-branch/JavaScriptCore/JavaScriptCore.pbproj/project.pbxproj
Versioning.
- 2:13 AM Changeset in webkit [24573] by
-
- 2 edits in branches/Safari-1-3-branch/JavaScriptCore
Merge fix for <rdar://problems/5355025&5355062>.
- 2:07 AM Changeset in webkit [24572] by
-
- 1 copy in tags/JavaScriptCore-419.2/JavaScriptCore
New tag (part 2).
- 2:07 AM Changeset in webkit [24571] by
-
- 1 add in tags/JavaScriptCore-419.2
New tag (part 1).
- 2:07 AM Changeset in webkit [24570] by
-
- 1 edit in branches/Safari-2.0-dashboard/JavaScriptCore/Info.plist
Versioning.
- 2:07 AM Changeset in webkit [24569] by
-
- 2 edits in branches/Safari-2.0-dashboard/JavaScriptCore
Merge fix for <rdar://problems/5354999&5355019&5355050&5355057>.
- 2:01 AM Changeset in webkit [24568] by
-
- 1 copy in tags/JavaScriptCore-418.6/JavaScriptCore
New tag (part 2).
- 2:01 AM Changeset in webkit [24567] by
-
- 1 add in tags/JavaScriptCore-418.6
New tag (part 1).
- 2:00 AM Changeset in webkit [24566] by
-
- 1 edit in branches/Safari-2.0-system/JavaScriptCore/Info.plist
Versioning.
- 2:00 AM Changeset in webkit [24565] by
-
- 2 edits in branches/Safari-2.0-system/JavaScriptCore
Merge fix for <rdar://problems/5354999&5355019&5355050&5355057>.
