Context Navigation

← Previous Period
Next Period →

Timeline

Aug 23, 2007:

5:41 PM Changeset in webkit [25212] by thatcher

4 edits in trunk/WebKit

Reviewed by Dave Hyatt.

<rdar://problem/5410937> HIWebView in SimpleCarbonWeb doesn't seem to be getting adequate invalidation when window is resized

The Carbon HIWebView was relying on layout happening when displayIfNeededInRect: was called on the WebView.
This would happen on Tiger because _recursiveDisplayRectIfNeededIgnoringOpacity: would always do a layout if needed.
Doing a layout in _recursiveDisplayRectIfNeededIgnoringOpacity was removed in Leopard in favor of viewWillDraw, and
the fact that adding new dirty rects inside _recursiveDisplayRectIfNeededIgnoringOpacity on Leopard will not
cause a drawRect in the same display loop.

So any client on Leopard calling displayIfNeeded* on the WebView would get a layout and any new dirty rects. So
_web_layoutIfNeededRecursive needs to be called on the main frame's WebHTMLView to make sure we layout and
display anything that is really needed.

WebView/WebHTMLView.mm: (-[WebHTMLView _layoutIfNeeded]): (-[WebHTMLView _web_layoutIfNeededRecursive]):
WebView/WebHTMLViewInternal.h:
WebView/WebView.mm: (-[WebView displayIfNeeded]): Call _web_layoutIfNeededRecursive on the main WebHTMLView. (-[WebView displayIfNeededIgnoringOpacity]): Ditto. (-[WebView displayIfNeededInRect:]): Ditto. (-[WebView displayIfNeededInRectIgnoringOpacity:]): Ditto.

4:31 PM Changeset in webkit [25211] by kmccullo

2 edits in trunk/LayoutTests

Reviewed by .

window-resize.html now passes.

platform/win/Skipped:

3:41 PM Changeset in webkit [25210] by sfalken

1 copy in tags/Safari-523.1.2b

New tag.

3:41 PM Changeset in webkit [25209] by sfalken

1 edit in trunk/WebKit/win/WebKit.vcproj/VERSION

Bump version for submit

2:25 PM Changeset in webkit [25208] by weinig

14 edits in trunk

Make life on Windows a little better by adding generated VS files to svn:ignore list

1:18 PM Changeset in webkit [25207] by andersca

3 edits in trunk/WebCore

Reviewed by Steve.

If necessary, re-set the window proc after each call to NPP_SetWindow. This is to ensure that
our window proc is always run even if a plug-in subclasses the window and replaces the window proc.

Also, make sure that the default window proc is of type ASCII so we can eliminate the

plugins/win/PluginViewWin.cpp: (WebCore::registerPluginView): (WebCore::PluginViewWndProc): (WebCore::PluginViewWin::setNPWindowRect): (WebCore::PluginViewWin::stop): (WebCore::PluginViewWin::determineQuirks): (WebCore::PluginViewWin::PluginViewWin): (WebCore::PluginViewWin::init):
plugins/win/PluginViewWin.h: (WebCore::): (WebCore::PluginViewWin::pluginWndProc):

1:13 PM Changeset in webkit [25206] by ddkilzer

6 edits
5 adds in trunk

WebCore:

Updated old ChangeLog entry with bug title and test information.

WebKitTools:

Reviewed by Darin and Adam.

DumpRenderTree changes to allow testing for http://bugs.webkit.org/show_bug.cgi?id=11756 REGRESSION: link targeting a frame in another window does not work <rdar://problem/5286420>

Use a frame group name for all WebViews created by DumpRenderTree to
allow testing of cross-page frame lookup.

DumpRenderTree/DumpRenderTree.m: (createWebView): Pass group name to -[WebView initWithFrame:frameName:groupName:].
DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (main): Pass group name to WebView::initWithFrame(RECT, BSTR, BSTR).

LayoutTests:

Reviewed by Adam.

test for http://bugs.webkit.org/show_bug.cgi?id=11756 REGRESSION: link targeting a frame in another window does not work <rdar://problem/5286420>

http/tests/navigation/resources/target-frame-from-window-end.html: Added.
http/tests/navigation/resources/target-frame-from-window-popup.html: Added.
http/tests/navigation/resources/target-frame-from-window-start.html: Added.
http/tests/navigation/target-frame-from-window-expected.txt: Added.
http/tests/navigation/target-frame-from-window.html: Added.
platform/win/Skipped: Added http/tests/navigation/target-frame-from-window.html to skip list.

12:14 PM Changeset in webkit [25205] by zbujtas

2 edits in S60/trunk/WebCore

2007-08-23 w3liu <wei.liu@nokia.com>

Reviewed by <sriram.yadavalli@nokia.com>.
DESC: JKRL-769F2J: browser does not properly support the noscript tag correctly (extra fix to handle js disable)
http://bugs.webkit.org/show_bug.cgi?id=15049

12:09 PM Changeset in webkit [25204] by zbujtas

2 edits in S60/branches/3.1m/WebCore

2007-08-23 w3liu <wei.liu@nokia.com>

Reviewed by <sriram.yadavalli@nokia.com>.
DESC: JKRL-769F2J: browser does not properly support the noscript tag correctly (extra fix to handle js disable)
http://bugs.webkit.org/show_bug.cgi?id=15049

11:11 AM Changeset in webkit [25203] by justing

3 edits
5 adds in trunk

WebCore:

Reviewed by Adele.

<rdar://problem/5156801> REGRESSION: Crash at DeleteSelectionCommand::doApply() when deleting table content

editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::handleGeneralDelete): Use a RefPtr for node. If the node to be removed contains the selection, and if the next node to be removed (nextNode) is inside the deletion UI, removing node will remove nextNode from the document. nextNode is a RefPtr, but node isn't and when nextNode falls out of scope the node that node points to will be destroyed and we'll end up using a stale pointer. Long term we should probably just disable the deletion UI before editing operations because the undo of the removal of node in the situation described above relies on the presence of the deletion UI, but it isn't present because its added and removed in a non-undoable way.

LayoutTests:

Reviewed by Adele.

<rdar://problem/5156801> REGRESSION: Crash at DeleteSelectionCommand::doApply() when deleting table content

editing/deleting/5156801-2.html: Added.
platform/mac/editing/deleting: Added.
platform/mac/editing/deleting/5156801-2-expected.checksum: Added.
platform/mac/editing/deleting/5156801-2-expected.png: Added.
platform/mac/editing/deleting/5156801-2-expected.txt: Added.

10:20 AM Changeset in webkit [25202] by ddkilzer

3 edits in trunk/WebKitTools

WebKitTools:

Reviewed by Adam.

Quote the $sslCertificate path in case it contains a space.

Scripts/run-webkit-httpd:
Scripts/run-webkit-tests:

9:47 AM Changeset in webkit [25201] by spadma

2 edits in S60/branches/3.1m/WebKit

2007-08-22 rathnasa <sornalatha.rathnasamy@nokia.com>

Reviewed by Sachin.
DESC: TSW ID: SJUN-73XBVC. Text appears overlapped with document.write in onload
http://bugs.webkit.org/show_bug.cgi?id=14915

BrowserView/src/WebKitView.cpp: (CWebKitView::SyncRepaint):

9:46 AM Changeset in webkit [25200] by spadma

2 edits in S60/trunk/WebKit

rathnasa, reviewed by spadma

DESC: TSW ID: SJUN-73XBVC. Text appears overlapped with document.write in onload
http://bugs.webkit.org/show_bug.cgi?id=14915

BrowserView/src/WebKitView.cpp: (CWebKitView::SyncRepaint):

5:37 AM Changeset in webkit [25199] by zbujtas

4 edits in S60/trunk/WebCore

2007-08-22 w3liu <wei.liu@nokia.com>

Reviewed by <sriram.yadavalli@nokia.com>
DESC: JKRL-769F2J: browser does not properly support the noscript tag correctly

5:34 AM Changeset in webkit [25198] by zbujtas

4 edits in S60/branches/3.1m/WebCore

2007-08-22 w3liu <wei.liu@nokia.com>

Reviewed by <sriram.yadavalli@nokia.com>
DESC: JKRL-769F2J: browser does not properly support the noscript tag correctly

12:44 AM Changeset in webkit [25197] by andrew

4 edits
1 add in trunk/WebCore

2007-08-23 Mitz Pettel <mitz@webkit.org>

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=14899 !d->m_view->needsLayout() in Frame::paint() (Causes assert)

WebKit copies the width and height attributes of an <embed> to its
nearest <object> ancestor. This used to be done in updateWidget(), but
that could lead to the document being dirty right after layout and
before painting. The patch moves the copying of the attributes to when
the <embed> is inserted into the document or its attributes change.

html/HTMLEmbedElement.cpp: (WebCore::HTMLEmbedElement::insertedIntoDocument): (WebCore::HTMLEmbedElement::attributeChanged):
html/HTMLEmbedElement.h:
manual-tests/bugzilla-14899.html: Added.
rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget):

Aug 22, 2007:

10:02 PM Changeset in webkit [25196] by oliver

2 edits in trunk/WebKitTools

Reviewed by John and Adam.

WebDataSource::response can legitimately have a null response, so we
must check that case.

DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.cpp: (dump):

5:31 PM Changeset in webkit [25195] by honeycutt

4 edits in trunk/WebKit/win

2007-08-22 Jon Honeycutt <jhoneycutt@apple.com>

Reviewed by Adam.

Refactoring of <radr://problem/5220598> Dragging URL out and back
inserts a second copy of the URL

Interfaces/IWebViewPrivate.idl: Added setCustomDropTarget and removeCustomDropTarget
WebView.cpp: (WebView::WebView): Initialize m_hasCustomDropTarget (WebView::setCustomDropTarget): Revoke any existing drop target and set the incoming drop target. (WebView::removeCustomDropTarget): Revoke any existing drop target and set the default drop target.
WebView.h:

5:22 PM Changeset in webkit [25194] by andersca

2 edits in trunk/WebCore

Reviewed by Darin and Oliver.

<rdar://problem/5422410>
http://bugs.webkit.org/show_bug.cgi?id=15019
REGRESSION (r25124-r25140): New posts and hot topics won't show at mobile01.com

Remove the call to checkCallImplicitClose(). Calling it in loadPlugin is bad for two reasons:

It could cause onload to be dispatched even when the page has subresources that are still loading, such as images.

Now that loadPlugin is called during layout, it could cause onload to be dispatched during layout, which can execute javascript and do pretty much anything while the render tree is in an inconsistent state.

loader/FrameLoader.cpp: (WebCore::FrameLoader::loadPlugin):

4:56 PM Changeset in webkit [25193] by andersca

2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5430584>
http://bugs.webkit.org/show_bug.cgi?id=15053
WebKit does not check Windows Registry HKEY_CURRENT_USER for NPAPI plugin locations

plugins/win/PluginDatabaseWin.cpp: (WebCore::addPluginsFromRegistry): (WebCore::PluginDatabaseWin::getPluginsInPaths):

2:56 PM Changeset in webkit [25192] by justing

3 edits
5 adds in trunk

WebCore:

Reviewed by Adam.

<rdar://problem/5418891> CrashTracer: [USER] 1 crash in Mail at -[WebViewEditor webView:shouldInsertText:replacingDOMRange:givenAction:]

editing/BreakBlockquoteCommand.cpp: (WebCore::BreakBlockquoteCommand::doApply): We're reusing the topBlockquote variable. Null it out first. If there is no new topBlockquote and we don't null it out first, we'll assume that there was a new one and crash.

LayoutTests:

Reviewed by Adam.

<rdar://problem/5418891> CrashTracer: [USER] 1 crash in Mail at -[WebViewEditor webView:shouldInsertText:replacingDOMRange:givenAction:]

editing/inserting/5418891.html: Added.
platform/mac/editing/inserting: Added.
platform/mac/editing/inserting/5418891-expected.checksum: Added.
platform/mac/editing/inserting/5418891-expected.png: Added.
platform/mac/editing/inserting/5418891-expected.txt: Added.

2:23 PM Changeset in webkit [25191] by thatcher

12 edits in trunk/WebKit

Rolling out r25102 for <rdar://problem/5410937> until
<rdar://problem/5429920> is resolved.

Carbon/CarbonUtils.m: (WebInitForCarbon): (PoolCleaner):
Carbon/CarbonWindowAdapter.h:
Carbon/CarbonWindowAdapter.m:
Carbon/CarbonWindowContentView.h:
Carbon/CarbonWindowContentView.m:
Carbon/CarbonWindowFrame.h:
Carbon/CarbonWindowFrame.m:
Carbon/HIViewAdapter.h:
Carbon/HIViewAdapter.m:
Carbon/HIWebView.h:
Carbon/HIWebView.m:

1:38 PM Changeset in webkit [25190] by zbujtas

2 edits in S60/branches/3.1m/WebCore

malaiya, reviewed by <zbujtas@gmail.com>

DESC: TSW Id: ESMS-766JBW - Browser goes back in history when leaving input field
http://bugs.webkit.org/show_bug.cgi?id=15050

1:36 PM Changeset in webkit [25189] by zbujtas

2 edits in S60/trunk/WebCore

malaiya, reviewed by <zbujtas@gmail.com>

DESC: TSW Id: ESMS-766JBW - Browser goes back in history when leaving input field
http://bugs.webkit.org/show_bug.cgi?id=15050

1:10 PM Changeset in webkit [25188] by kmccullo

5 edits in trunk

LayoutTests:

Reviewed by Adele.

rdar:5423067 Reapplying the change but only when the text area is in focus.

fast/forms/cursor-position-expected.txt:
fast/forms/cursor-position.html:

WebCore:

Reviewed by Adele.

rdar:5423067 Reapplyingthe change but only when the text area is in focus.

html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue):

12:58 PM Changeset in webkit [25187] by hyatt

2 edits in trunk/WebCore

Fix for <rdar://problem/5249757> Painting of JPGs in WebKit is too slow.

Use a new Leopard API for fast tiling of images. We only use this API
when the whole image is being tiled and when the current CGImageRef to tile
has a size that matches the size of the whole image.

We can optimize border-image in the future by adding a cache of the 9
sub-images.

Reviewed by darin

platform/graphics/cg/ImageCG.cpp: (WebCore::Image::drawPattern):

11:12 AM Changeset in webkit [25186] by kmccullo

5 edits in trunk

LayoutTests:

Rolling back since I neeed to update some layouttests this change broke.

fast/forms/cursor-position-expected.txt:
fast/forms/cursor-position.html:

WebCore:

Rolling back since I need to update some layouttests this change breaks.

html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue):

10:43 AM Changeset in webkit [25185] by kmccullo

5 edits in trunk

LayoutTests:

Reviewed by Geof, Adam, Hyatt, Maciej and Oliver.

In order to match the behavior of the other major browsers, selection is moved to the end of the text value when a change occurs to the contents of a text area instead of remembering the location of the selection.
<rdar://problem/5423067> gmail is super annoying when trying to add a new name to the TO, CC or BCC fields

fast/forms/cursor-position-expected.txt:
fast/forms/cursor-position.html:

WebCore:

Reviewed by Geof, Adam, Hyatt, Maciej and Oliver.

In order to match the behavior of the other major browsers, selection is moved to the end of the text value when a change occurs to the contents of a text area instead of remembering the location of the selection.
<rdar://problem/5423067> gmail is super annoying when trying to add a new name to the TO, CC or BCC fields

html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::setValue):

10:40 AM Changeset in webkit [25184] by kmccullo

2 edits in trunk/WebKitTools

Reviewed by Geof.

Changing the usage to be more clear.

Scripts/run-testkjs:

Aug 21, 2007:

11:33 PM Changeset in webkit [25183] by rwlbuis

10 edits in branches/feature-branch

Reviewed by Sam.

http://bugs.webkit.org/show_bug.cgi?id=12059
SVG colors have two separate parsing paths (one CSS and one SVGColor::setRGBColor)

Reuse the css parser as much as possible in setRGBColor.

6:35 PM Changeset in webkit [25182] by aroben

2 edits in trunk/LayoutTests

platform/win/Skipped: Added a couple more failures.

4:40 PM Changeset in webkit [25181] by aroben

2 edits in trunk/LayoutTests

platform/win/Skipped: Added some more failing tests.

3:32 PM Changeset in webkit [25180] by adachan

2 edits in trunk/WebKit/win

Fix <rdar://problem/5416630> Accelerator to open link in window in background opens window in foreground instead
Placing tooltip window at the topmost in z-order brought windows that were opened in the
background to the front. Use HWND_TOP instead.

Reviewed by Adam.

WebView.cpp: (WebView::initializeToolTipWindow):

3:08 PM Changeset in webkit [25179] by aroben

3 edits in trunk/WebCore

Build fix for Mac

Keep FrameView::layoutIfNeededRecursive Windows- and Gtk-only for now
(sadly). This will have to wait until we merge ScrollView and FrameView.

Reviewed by NOBODY.

page/FrameView.cpp:
page/FrameView.h:

2:49 PM Changeset in webkit [25178] by aroben

2 edits in trunk/WebCore

Fix an ASSERT when using Find in Page

Reviewed by Darin.

No test possible.

bridge/win/FrameWin.cpp: (WebCore::imageFromSelection): Make sure to update layout before painting so we don't hit an ASSERT in painting code (Frame::selectionImage in FrameMac.mm does this as well).

2:49 PM Changeset in webkit [25177] by aroben

7 edits in trunk

Switch Windows to using FrameView::layoutIfNeededRecursive

WebCore:

Made FrameView::layoutIfNeededRecursive available to all platforms

Currently it's only used on Gtk+ and Windows.

Reviewed by Darin.

page/FrameView.cpp: Removed #ifdef.
page/FrameView.h: Ditto.

WebKit/win:

Switch Windows to using FrameView::layoutIfNeededRecursive

Reviewed by Darin.

WebFrame.cpp: Removed layoutIfNeededRecursive.
WebFrame.h: Ditto.
WebView.cpp: (WebView::updateBackingStore): Call FrameView::layoutIfNeededRecursive.

2:44 PM Changeset in webkit [25176] by zimmermann

2 edits in branches/feature-branch/WebCore

Reviewed by Oliver.

Allow to pass a filename to dumpOutputImage via debugger.
Make it only available in debug builds and remove the runtime define: DEBUG_OUTPUT_IMAGE.

2:28 PM Changeset in webkit [25175] by zimmermann

195 edits in branches/feature-branch

Reviewed by Oliver.

Large SVG filter rework. Bring it back in a useable state.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=5527 (Filters need subregion support)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=5579 (WebKit+SVG renders full-filters-example incorrectly)
Fixes: http://bugs.webkit.org/show_bug.cgi?id=5976 (filterUnits="userSpaceOnUse" is broken (breaking feTile test case))
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12064 (Need function for manual style-resolution for things like gradient stops)

filters-blend-01-b.svg & filters-example-01-b.svg & filters-displace-01-b.svg & filters-diffuse-01-f.svg are fixed now.

In detail:

flood-color & flood-opacity have been incorrectly resolved on the <feBlend> parent element!
sizing of filter region was truncated in some cases, as the bbox was used to resolve the needed filter region instead of the filter rect
add subregion support to all filter primitives (primitiveUnits & filterUnits handled in all cases)
WKDisplacmentMap.cikernel incorrectly flipped the y-axis.
Correctly specify default values for all filter primitives in ksvg2/svg!
Initialize all variables of the SVGFE* classes in platform/graphics/svg/filters.
Fix 'flood-color' initial value (was set to the _stop_ color initial value)

-> both initial values were pointing to 'black' though, so it was no visible problem.

Parse 'lighting-color' css property, no more hacking in SVGFEDiffuseLighting.

-> Correct it's initial from black to white value fixes SVG lighting filters!

Add diffuseConstant support to feDiffuseLighting filter.
Centralize manual style resolution (needed for stop-color, flood-color & flood-opacity, lighting-color)

12:12 PM Changeset in webkit [25174] by adele

2 edits in trunk/WebCore

Build fix for release build.

rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout):

11:01 AM Changeset in webkit [25173] by spadma

2 edits in S60/trunk/WebKit

2007-08-02 vmalaiya, <vikram.malaiya@nokia.com>

Reviewed by Sachin
DESC: ZBUS-744GX5 - No key events for text input
http://bugs.webkit.org/show_bug.cgi?id=13877

BrowserCore/Formcontrols/src/FControlInputWidget.cpp: (CControlInputWidget::OfferKeyEventL):

10:59 AM Changeset in webkit [25172] by spadma

3 edits in S60/trunk/WebKit

yadavall, reviewed by <sachin>

DESC: Fast display mode must be turned OFF for widgets
http://bugs.webkit.org/show_bug.cgi?id=14966

BrowserView/src/WebKitControl.cpp: (CWebKitControl::CreateWidgetExtensionL):
BrowserView/src/webkitbridge.cpp: (CWebKitBridge::CreateChildFrameNamed):

10:57 AM Changeset in webkit [25171] by adele

3 edits
5 adds in trunk

WebCore:

Reviewed by Darin.

fix http://bugs.webkit.org/show_bug.cgi?id=15010 <rdar://problem/5423956> REGRESSION (r25000-r25065): Table rendering broken by a recent nightly

Test: fast/table/max-width-integer-overflow.html

Avoid integer overflows when dealing with maximum widths by
1) using floating point arithmetic when summing or multiplying column max widths
2) capping max widths at INT_MAX / 2

rendering/AutoTableLayout.cpp: (WebCore::AutoTableLayout::calcPrefWidths): (WebCore::AutoTableLayout::calcEffectiveWidth): (WebCore::AutoTableLayout::layout):

LayoutTests:

Reviewed by Darin.

test for http://bugs.webkit.org/show_bug.cgi?id=15010 <rdar://problem/5423956> REGRESSION (r25000-r25065): Table rendering broken by a recent nightly

fast/table/max-width-integer-overflow.html: Added.
platform/mac/fast/table: Added.
platform/mac/fast/table/max-width-integer-overflow-expected.checksum: Added.
platform/mac/fast/table/max-width-integer-overflow-expected.png: Added.
platform/mac/fast/table/max-width-integer-overflow-expected.txt: Added.

9:28 AM Changeset in webkit [25170] by sullivan

1 edit in trunk/WebCore/ChangeLog

Removed stray conflict marker.

7:32 AM Changeset in webkit [25169] by sullivan

17 edits
1 add in trunk

WebCore:

Reviewed by Adam Roben

WebCore part of fix for:
<rdar://problem/5417777> WebKit focus ring color no longer matches system focus rings

Adele wrote the first version of this patch. No test cases added because I made sure the
layout tests are unaffected. Two additional bug fixes were made in passing, but neither
of them had any effect on any known real-world case, and both were too difficult to write
test cases for to be worthwhile.

WebCore.exp: added symbols for these new functions so WebKit can call them

WebCore.xcodeproj/project.pbxproj: updated for new file

platform/graphics/mac/ColorMac.h: Added. New file to hold the increasing amount of Mac-specific color stuff.

platform/graphics/Color.h: removed #if PLATFORM(MAC) code, which is now in ColorMac.h

platform/graphics/mac/ColorMac.mm: (WebCore::makeRGBAFromNSColor): new static function to convert an NSColor object to an RGBA32 struct (WebCore::colorFromNSColor): new public function to convert an NSColor object to a WebCore-style Color object (WebCore::focusRingColor): Uses (cached) systemFocusRingColor instead of hardwired values, unless usesTestModeFocusRingColor is true, in which case it uses the old hardwired color (WebCore::usesTestModeFocusRingColor): returns value of global var (WebCore::setUsesTestModeFocusRingColor): sets value of global var (+[WebCoreControlTintObserver controlTintDidChange]): Uses [NSColor keyboardFocusIndicatorColor] to set systemFocusRingColor; don't compile if COLORMATCH_EVERYTHING is set since we don't know what it would take to satisfy this state.

bindings/objc/DOMRGBColor.mm: now includes ColorMac.h to account for moved declarations
bridge/mac/WebCoreAXObject.mm: ditto

page/mac/FrameMac.mm: (WebCore::convertAttributesToUnderlines): now uses new colorFromNSColor. The old code was swapping G & B, but it didn't matter in practice because this function is only used to convert the color of an input manager's marked text underline, which is always black

page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setBaseBackgroundColor:]): now uses new colorFromNSColor. The old code was swapping G & B, but it didn't matter in practice because this function is only called with a grayscale color perhaps containing an alpha value

rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations): just updated a comment

WebKit:

Reviewed by Adam Roben

WebKit part of fix for:
<rdar://problem/5417777> WebKit focus ring color no longer matches system focus rings

Misc/WebNSAttributedStringExtras.mm: now includes <WebCore/ColorMac.h> to account for moved declaration
WebView/WebFrame.mm: ditto

WebView/WebViewPrivate.h:
WebView/WebView.mm: (+[WebView _setUsesTestModeFocusRingColor:]): new SPI, calls through to new WebCore function. This is used by DumpRenderTree to make sure the focus ring color is always the same when performing layout tests, regardless of OS X version. (+[WebView _usesTestModeFocusRingColor]): new SPI, calls through to new WebCore function

WebKitTools:

Reviewed by Adam Roben

DumpRenderTree/DumpRenderTree.m: (runTest): call new +[WebView _setUsesTestModeFocusRingColor:YES] so we get the same focus ring colors in layout tests on Tiger and Leopard

Aug 20, 2007:

6:37 PM Changeset in webkit [25168] by pewtermoose

3 edits
6 adds in trunk

WebCore:

2007-08-20 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

fix http://bugs.webkit.org/show_bug.cgi?id=15023 REGRESSION (r21113-r21143): JavaScript tooltip rendering bug

Test: fast/repaint/layer-visibility.html

rendering/RenderLayer.cpp: (WebCore::RenderLayer::setHasVisibleContent): Cache the layer's rects when it changes to visible.

LayoutTests:

2007-08-20 Mitz Pettel <mitz@webkit.org>

Reviewed by Dave Hyatt.

repaint test for http://bugs.webkit.org/show_bug.cgi?id=15023 REGRESSION (r21113-r21143): JavaScript tooltip rendering bug

fast/repaint/layer-visibility.html: Added.
platform/mac/fast: Added.
platform/mac/fast/repaint: Added.
platform/mac/fast/repaint/layer-visibility-expected.checksum: Added.
platform/mac/fast/repaint/layer-visibility-expected.png: Added.
platform/mac/fast/repaint/layer-visibility-expected.txt: Added.

5:14 PM Changeset in webkit [25167] by aroben

2 edits in trunk/WebKitSite

Remove any mention of drwtsn32.log, as it is almost never useful for tracking down crashes

Reviewed by Oliver.

quality/crashlogs.html:

5:08 PM Changeset in webkit [25166] by kdecker

2 edits in trunk/WebCore

Reviewed by Anders.

Fixed: <rdar://problem/5325262> REGRESSION (Tiger-Leopard): PictureTalk plug-in doesn't work

The problem was that this particular plug-in handles "text/ptf", but WebCore wasn't giving the plug-in a chance to load
any type with "text/"

dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocument): Allow plug-ins to once again use "text/" MIME types, but only if the MIME type is not "text/plain". Disallowing plug-ins to use text/plain prevents plug-ins from hijacking a fundamental type that the browser is expected to handle, and also serves as an optimization to prevent loading the plug-in database in the common case.

4:46 PM Changeset in webkit [25165] by aroben

2 edits in trunk/LayoutTests

Removed a now-working test from the Windows Skipped file

platform/win/Skipped:

4:36 PM Changeset in webkit [25164] by aroben

2 edits in trunk/WebKitTools

Put LayoutTests after all other ChangeLogs in commit logs

We use "~" to sort LayoutTests after all the other ChangeLogs because
"~" is the last ASCII character (other than "DEL").

Reviewed by Sam.

Scripts/commit-log-editor:

4:18 PM Changeset in webkit [25163] by aroben

2 edits in trunk/WebKitTools

Detect that DRT crashed even if a crash dialog is running

On Windows, when DRT crashes a crash dialog commonly appears. The DRT
process is still running at this point, so run-webkit-tests wouldn't
detect that DRT had crashed. We now record the crash in our SIGPIPE
handler so that we know if DRT crashed even if the crash dialog is up.

Reviewed by Sam.

Scripts/run-webkit-tests: (sub catch_pipe): Set the crashed bit. (sub openDumpTool): Reset the crashed bit. (sub dumpToolDidCrash): Check the crashed bit.

4:04 PM Changeset in webkit [25162] by aroben

3 edits
4 adds in trunk

Remove workarounds for <rdar://problem/5386894> now that it's been fixed

WebCore:

Remove workarounds for <rdar://problem/5386894> now that it's been fixed

Reviewed by Darin.

Tests: fast/loader/local-svg-parsed-as-svg.svg

fast/loader/local-xhtml-parsed-as-xhtml.xhtml

platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::doUpdateResourceResponse): Removed hackish workaround.

LayoutTests:

Tests to ensure that local .xhtml and .svg files end up being parsed as XHTML and SVG, respectively

Reviewed by Darin.

fast/loader/local-svg-parsed-as-svg-expected.txt: Added.
fast/loader/local-svg-parsed-as-svg.svg: Added.
fast/loader/local-xhtml-parsed-as-xhtml-expected.txt: Added.
fast/loader/local-xhtml-parsed-as-xhtml.xhtml: Added.

3:05 PM Changeset in webkit [25161] by kmccullo

3 edits
2 adds in trunk

JavaScriptCore:

Reviewed by Geoff and Adam.

Changing stack depth to 500 (from 100 on mac and win) to help out some apps specifically gmail. <rdar://problem/3590522> JavaScript call stack limit of 99 is too small for some applications; needs to be closer to 500 (4045)

kjs/object.cpp:

LayoutTests:

Reviewed by Geoff and Adam.

Changing stack depth toi 500 (from 100 in mac and win) to help out some apps specifically gmail. <rdar://problem/3590522> JavaScript call stack limit of 99 is too small for some applications; needs to be closer to 500 (4045).

fast/js/deep-recursion-test-expected.txt: Added.
fast/js/deep-recursion-test.html: Added.

2:41 PM Changeset in webkit [25160] by aroben

2 edits in trunk/WebKitTools

Fix Bug 15026: prepare-ChangeLog should list new tests in WebCore/ChangeLog

http://bugs.webkit.org/show_bug.cgi?id=15026

Reviewed by NOBODY (OOPS!).

Scripts/prepare-ChangeLog: (sub isModifiedStatus): Split out from isModifiedOrAddedStatus. (sub isAddedStatus): Ditto. (sub testListForChangeLog): Added.

1:32 PM Changeset in webkit [25159] by andersca

2 edits in trunk/WebCore

Reviewed by Adam.

<rdar://problem/5412988>
Crash when visiting http://www.rockonflash.com/blog/?p=58

plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::updateWindow): Just return if the plugin view hasn't been inserted in the hierarchy yet.

11:10 AM Changeset in webkit [25158] by antti

2 edits in trunk/WebKit

Reviewed by John.

Fix <rdar://problem/5378390>
Crash at Range::startContainer() when creating multiple ToDos on the same line

Null check range.

No layout test, this only happens with ObjC API.

WebView/WebHTMLView.mm: (-[WebHTMLView _expandSelectionToGranularity:]):

6:30 AM Changeset in webkit [25157] by zecke

2 edits in trunk/WebCore

2007-08-20 Holger Hans Peter Freyther <zecke@selfish.org>

Reviewed by Zack.

Do not define svg as ImageMIMEType if we can use ksvg2.

platform/MIMETypeRegistry.cpp: (WebCore::initialiseSupportedImageMIMETypes):

12:11 AM Changeset in webkit [25156] by mjs

2 edits in trunk/WebKit

Not reviewed, fix for crash on launch bug in last patch.

WebView/WebHTMLView.mm: (-[WebHTMLView setDataSource:]): Remove an assertion, fix code to work right in the face of that condition.

12:04 AM Changeset in webkit [25155] by rwlbuis

3 edits
4 adds in branches/feature-branch

Reviewed by Nikolas.

http://bugs.webkit.org/show_bug.cgi?id=14924
rotated rect with pattern draws incorrectly

Use the bounding box before transformation.

12:01 AM Changeset in webkit [25154] by mjs

6 edits in trunk/LayoutTests

Not reviewed - test case fixes.

fix some test cases where expected results were altered by the last change (I reviewed all the new results.)

fast/events/focusingUnloadedFrame-expected.txt:
http/tests/loading/simple-subframe-expected.txt:
tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt:
tables/mozilla_expected_failures/bugs/bug137388-2-expected.txt:
webarchive/loading/test-loading-archive-expected.txt:

Aug 19, 2007:

5:04 PM Changeset in webkit [25153] by aroben

2 edits in trunk/WebCore

Gtk+ build fix.

platform/gdk/TemporaryLinkStubs.cpp: Removed const.

3:07 PM Changeset in webkit [25152] by aroben

7 edits in trunk/WebCore

Fix <rdar://5395835> REGRESSION (r24527): Context menu for edit fields is missing "Font & Writing Direction"

The problem was that ContextMenuItem::setSubMenu was just copying the
HMENU from the ContextMenu passed in on Windows, but that HMENU was
later getting destroyed when the ContextMenu went out of scope.

I added a new ContextMenu::releasePlatformDescription method that is
used in setSubMenu instead. I think an ultimately better design would
be for setSubMenu to take ownership of the ContextMenu that's passed in
(as should insertItem and appendItem), but I decided to be conservative
and just make the changes needed to fix the bug.

Reviewed by Darin.

No test possible.

platform/ContextMenu.h: Added releasePlatformDescription.
platform/gdk/TemporaryLinkStubs.cpp: Added stub implementation.
platform/mac/ContextMenuMac.mm: (WebCore::ContextMenu::releasePlatformDescription): Implemented, though it's never called on this platform.
platform/qt/ContextMenuQt.cpp: (WebCore::ContextMenu::releasePlatformDescription): Ditto.
platform/win/ContextMenuItemWin.cpp: (WebCore::ContextMenuItem::setSubMenu): Call releasePlatformDescription since we need to take ownership of the HMENU.
platform/win/ContextMenuWin.cpp: (WebCore::ContextMenu::releasePlatformDescription): Implemented.

2:40 PM Changeset in webkit [25151] by mjs

11 edits in trunk

LayoutTests:

Reviewed by Darin.

update for fix to <rdar://problem/5198272> REGRESSION: PLT 1.5% slower due to r21367 (change to start frames with empty documents)

No longer expect windowScriptObject delegate method in frames that never
use script.

http/tests/loading/bad-scheme-subframe-expected.txt:
http/tests/loading/bad-server-subframe-expected.txt:
http/tests/loading/empty-subframe-expected.txt:
http/tests/loading/slow-parsing-subframe-expected.txt:

WebCore:

Reviewed by Darin.

fixed <rdar://problem/5198272> REGRESSION: PLT 1.5% slower due to r21367 (change to start frames with empty documents)

There were three main cuases of extra time due to creating the initial empty document:

1) Creating an extra WebHTMLView and swapping it for a new one for each frame created.
2) Parsing the minimal markup for the initial document's contents.
3) Clearing the Window object an extra time and dispatching the corresponding delegate method.

The WebCore part of the fixes addresses 2 and 3.

loader/FrameLoader.cpp: (WebCore::FrameLoader::init): Don't parse "<html><body>" for the initial empty document; it turns out not to be needed. (WebCore::FrameLoader::dispatchWindowObjectAvailable): Don't dispatch the delegate if we haven't created a ScriptInterpreter yet.
bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::initScriptIfNeeded): Dispatch the window object delegate when we first create the interpreter, since that is now done lazily.
loader/FrameLoader.h: (WebCore::FrameLoader::committingFirstRealLoad): Helper for WebKit to know when to reuse a WebHTMLView.

WebKit:

Reviewed by Darin.

fixed <rdar://problem/5198272> REGRESSION: PLT 1.5% slower due to r21367 (change to start frames with empty documents)

There were three main cuases of extra time due to creating the initial empty document:

1) Creating an extra WebHTMLView and swapping it for a new one for each frame created.
2) Parsing the minimal markup for the initial document's contents.
3) Clearing the Window object an extra time and dispatching the corresponding delegate method.

The WebKit part of the fixes addresses 1.

WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::makeDocumentView): When switching from the initial empty document to the first real document, reuse the WebHTMLView.

It might actually be a significant performance improvement to always
reuse the WebHTMLView, but that is a much riskier change and not
needed to fix the regression right now.

11:26 AM Changeset in webkit [25150] by pewtermoose

3 edits
2 adds in trunk

LayoutTests:

2007-08-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Adam Roben.

test for http://bugs.webkit.org/show_bug.cgi?id=15008 ASSERTION FAILED: !firstLineBox() == !lastLineBox() setting content on image

fast/images/text-content-crash-2-expected.txt: Added.
fast/images/text-content-crash-2.html: Added.

WebCore:

2007-08-19 Mitz Pettel <mitz@webkit.org>

Reviewed by Adam Roben.

fix http://bugs.webkit.org/show_bug.cgi?id=15008 ASSERTION FAILED: !firstLineBox() == !lastLineBox() setting content on image

Test: fast/images/text-content-crash-2.html

html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::setImage): Added a check that the renderer is an image. (WebCore::HTMLImageLoader::updateFromElement): Ditto. (WebCore::HTMLImageLoader::notifyFinished): Ditto.

10:10 AM Changeset in webkit [25149] by staikos