Timeline



Oct 21, 2007:

11:26 PM Changeset in webkit [26864] by bdash
  • 8 edits in trunk

2007-10-21 Mark Rowe <​mrowe@apple.com>

Reviewed by Alp.

​http://bugs.webkit.org/show_bug.cgi?id=15575
Bug 15575: [GTK] Implement threading using GThread

  • wtf/Platform.h: Do not enable pthreads for Gtk.

2007-10-21 Mark Rowe <​mrowe@apple.com>

Reviewed by Alp.

​http://bugs.webkit.org/show_bug.cgi?id=15575
Bug 15575: [GTK] Implement threading using GThread

  • WebCore.pro: Remove ThreadingPthreads.cpp from the Gtk build and link against libgthreads.
  • loader/icon/IconDatabase.cpp: Initialize threading before the mutex is created to be compatible with gthreads. (WebCore::iconDatabase): (WebCore::IconDatabase::open):
  • platform/Threading.h:
  • platform/gtk/ThreadingGtk.cpp: Threading implementation in terms of GThread, based heavily on the pthreads implementation. (WebCore::initializeThreading): (WebCore::threadMapMutex): (WebCore::threadMap): (WebCore::establishIdentifierForThread): (WebCore::threadForIdentifier): (WebCore::clearThreadForIdentifier): (WebCore::createThread): (WebCore::waitForThreadCompletion): (WebCore::detachThread): (WebCore::Mutex::Mutex): (WebCore::Mutex::~Mutex): (WebCore::Mutex::lock): (WebCore::Mutex::tryLock): (WebCore::Mutex::unlock): (WebCore::ThreadCondition::ThreadCondition): (WebCore::ThreadCondition::~ThreadCondition): (WebCore::ThreadCondition::wait): (WebCore::ThreadCondition::signal): (WebCore::ThreadCondition::broadcast):
  • storage/Database.cpp: (WebCore::Database::Database): Initialize threading when Database is used so that it will be initialized even if the icon database is compiled out
11:08 PM Changeset in webkit [26863] by eseidel
  • 2 edits in trunk/SunSpider

2007-10-21 Eric Seidel <​eric@webkit.org>

Reviewed by mjs.

  • sunspider: make --shark only sample from testkjs
10:44 PM Changeset in webkit [26862] by bdash
  • 5 edits in trunk

2007-10-21 Mark Rowe <​mrowe@apple.com>

Reviewed by Mitz.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=15603
Bug 15603: Regression(r26847): Crash when sorting an empty array from JavaScript

  • kjs/array_object.cpp: (KJS::freeStorage): Reinstate null-check that was removed in r26847.

2007-10-21 Mark Rowe <​mrowe@apple.com>

Reviewed by Mitz.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=15603
Bug 15603: Regression(r26847): Crash when sorting an empty array from JavaScript

  • fast/js/kde/Array-expected.txt:
  • fast/js/kde/resources/Array.js: Update to cover sorting an empty array.
8:57 PM Changeset in webkit [26861] by sfalken
  • 1 copy in tags/Safari-523.12.6b

New tag.

8:57 PM Changeset in webkit [26860] by sfalken
  • 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

8:16 PM Changeset in webkit [26859] by bdash
  • 2 edits in trunk/WebKitTools

2007-10-21 Mark Rowe <​mrowe@apple.com>

Reviewed by Eric.

Fix run-javascriptcore-tests for Gtk.

  • Scripts/build-testkjs: testkjs is built by build-webkit for Gtk.
8:13 PM Changeset in webkit [26858] by mjs
  • 2 edits
    3 adds in trunk/SunSpider

Rubber stamped by Eric.


  • added crypto tests (already balanced)
  • tests/LIST:
  • tests/crypto-aes.js: Added.
  • tests/crypto-md5.js: Added.
  • tests/crypto-sha1.js: Added.
7:26 PM Changeset in webkit [26857] by bdash
  • 2 edits in trunk/WebCore

2007-10-21 Mark Rowe <​mrowe@apple.com>

Build fix.

  • ksvg2/css/SVGCSSStyleSelector.cpp: Use fabsf when dealing with a float to prevent the implicit conversion warning.
7:09 PM BuildBot edited by bdash@webkit.org
(diff)
7:06 PM BuildBot edited by bdash@webkit.org
(diff)
7:05 PM Changeset in webkit [26856] by alp
  • 2 edits in trunk/WebCore

2007-10-21 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Implement spelling and grammar mistake underlining with Pango/Cairo.

This change does not add any actual support for spelling or grammar
checking to any port.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
4:16 PM Changeset in webkit [26855] by mjs
  • 7 edits in trunk/SunSpider

Reviewed by Adam.


  • rebalance new tests


Scaled the new tests so they take 400-600ms on a reasonably normal user setup:


Internet Explorer 7, Window XP, Dell Latitude D810 with a 2.13GHz Pentium M

This balances them with the existing tests.

  • tests/access-binary-trees.js:
  • tests/access-nsieve.js:
  • tests/bitops-nsieve-bits.js:
  • tests/math-partial-sums.js:
  • tests/math-spectral-norm.js:
  • tests/string-fasta.js:
3:44 PM Changeset in webkit [26854] by alp
  • 5 edits in trunk/WebCore

2007-10-21 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Cairo canvas fixes:

Fix a refcounting issue leading to leaks and crashes on canvas
content.

Delegate memory management of canvas images to Cairo.

Mark unhandled conditions with notImplemented() instead of silently
ignoring them.

  • html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::drawImage):
  • html/CanvasStyle.cpp: (WebCore::CanvasStyle::applyStrokeColor):
  • html/CanvasStyle.h:
  • html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::HTMLCanvasElement): (WebCore::HTMLCanvasElement::~HTMLCanvasElement): (WebCore::HTMLCanvasElement::reset): (WebCore::HTMLCanvasElement::paint): (WebCore::HTMLCanvasElement::createDrawingContext): (WebCore::HTMLCanvasElement::createPlatformImage):
2:17 PM Changeset in webkit [26853] by zimmermann
  • 3 edits in trunk/LayoutTests

Not reviewed.
Forgot to land the new computed style results in fast/css - after the addition of glyph-orientation-*.

1:35 PM Changeset in webkit [26852] by zimmermann
  • 10 edits
    2 adds in trunk

Reviewed by Eric.

Handle glyph-orientation-vertical / glyph-orientation-horizontal SVG CSS properties.

The SVG layouting code itself doesn't handle these properties yet,
it's just about recognizing them in the SVG CSS engine.

11:40 AM Changeset in webkit [26851] by ddkilzer
  • 2 edits in trunk/WebKitSite

WebKitSite:

Reviewed by Darin.

There was a race condition when creating the WebKitStickyNotes table for the
first time in which the loaded() function (renamed to loadNotes()) could be
called before the table was created. Prevent this by only calling loadNotes()
in an executeSql() callback after we know the table exists, or after we know
the table has been created.

  • misc/DatabaseExample.html: Renamed loaded() function to loadNotes(). Created a new loaded() function.
11:37 AM Changeset in webkit [26850] by darin
  • 3 edits in trunk/JavaScriptCore
  • fix Windows build
  • kjs/array_instance.h: Removed unused ExecState parameter.
  • kjs/array_object.cpp: (KJS::ArrayInstance::put): Ditto. (KJS::ArrayInstance::setLength): Ditto.
11:36 AM Changeset in webkit [26849] by alp
  • 2 edits in trunk/WebCore

2007-10-21 Christian Dywan <​christian@twotoasts.de>

Reviewed by Alp.

​http://bugs.webkit.org/show_bug.cgi?id=15589
Use glib's path separator on gtk

  • platform/gtk/FileSystemGtk.cpp: (WebCore::pathByAppendingComponent):
9:53 AM Changeset in webkit [26848] by darin
  • 2 edits in trunk/JavaScriptCore
  • kjs/array_object.cpp: (KJS::ArrayInstance::put): Add missing assignment that was causing regression test crash.
8:12 AM Changeset in webkit [26847] by darin
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.


Speeds up SunSpider by 10%.

  • kjs/array_object.cpp: (allocateStorage): Leave room for an additional pointer. (reallocateStorage): Ditto. (freeStorage): Ditto. (ArrayInstance::~ArrayInstance): Delete the overflow map if present. (ArrayInstance::getItem): Read values from the overflow map if present. Removed the check of length, since it slows down the common case. (ArrayInstance::getOwnPropertySlot): Ditto. Also removed the fallback to the property map. (ArrayInstance::put): Write values into the overflow map as needed. Also create overflow map when needed. (ArrayInstance::deleteProperty): Remove values from the overflow map as appropriate. (ArrayInstance::getPropertyNames): Add a name for each identifier in the property map. This is extremely inefficient. (ArrayInstance::setLength): Remove any values in the overflow map that are past the new length, as we formerly did with the property map. (ArrayInstance::mark): Mark any values in the overflow map. (compareByStringForQSort): Removed unneeded undefined case, since compactForSorting guarantees we will have no undefined values. (compareWithCompareFunctionForQSort): Ditto. (ArrayInstance::compactForSorting): Copy all the values out of the overflow map and destroy it.
  • kjs/property_map.h: Removed now-unused getSparseArrayPropertyNames.
  • kjs/property_map.cpp: Ditto.
12:10 AM Changeset in webkit [26846] by mitz
  • 6 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

Test: fast/text/word-space.html

  • rendering/RenderBlock.cpp: (WebCore::stripTrailingSpace): Added word-spacing to the width of the space being stripped out.
  • rendering/RenderText.cpp: (WebCore::RenderText::trimmedPrefWidths): Changed handling of leading space. Since Font::width includes leading space width but not leading word spacing, this method needs to either remove the width of a space character or add word spacing, depending on stripFrontSpaces. (WebCore::RenderText::calcPrefWidths): Corrected the check for adding trailing word spacing so that it would work in the case where the last space is ignored.
  • rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine): Changed to actually add word spacing to the total width.

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/text/word-space.html: Added.
  • platform/mac/fast/css/word-space-extra-expected.txt: Updated result.
  • platform/mac/fast/text/word-space-expected.checksum: Added.
  • platform/mac/fast/text/word-space-expected.png: Added.
  • platform/mac/fast/text/word-space-expected.txt: Added.

Oct 20, 2007:

11:48 PM Changeset in webkit [26845] by hyatt
  • 4 adds in trunk/LayoutTests/platform/mac/fast/transforms

Add new transforms directory along with an initial layout test.

11:44 PM Changeset in webkit [26844] by hyatt
  • 2 adds in trunk/LayoutTests/fast/transforms

Add new transforms directory along with an initial layout test.

11:39 PM Changeset in webkit [26843] by hyatt
  • 9 edits in trunk/WebCore

Land support for the transform CSS property. Basic painting now works properly. There are many open issues
that will have to be covered by individual bugs.

Reviewed by olliej

  • css/CSSParser.cpp: (WebCore::CSSParser::validUnit): (WebCore::CSSParser::parseTransform):
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::RenderLayer): (WebCore::RenderLayer::~RenderLayer): (WebCore::RenderLayer::updateLayerPositions): (WebCore::RenderLayer::updateTransform): (WebCore::transparencyClipBox): (WebCore::RenderLayer::beginTransparencyLayers): (WebCore::RenderLayer::paintLayer): (WebCore::RenderLayer::calculateClipRects): (WebCore::RenderLayer::calculateRects): (WebCore::RenderLayer::childrenClipRect): (WebCore::RenderLayer::selfClipRect): (WebCore::RenderLayer::intersectsDamageRect): (WebCore::RenderLayer::boundingBox):
  • rendering/RenderLayer.h:
  • rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::container):
  • rendering/RenderStyle.cpp: (WebCore::RenderStyle::applyTransform):
  • rendering/RenderStyle.h: (WebCore::TransformOperation::isScaleOperation): (WebCore::TransformOperation::isRotateOperation): (WebCore::TransformOperation::isSkewOperation): (WebCore::TransformOperation::isTranslateOperation): (WebCore::TransformOperation::isMatrixOperation): (WebCore::ScaleTransformOperation::isScaleOperation): (WebCore::RotateTransformOperation::isRotateOperation): (WebCore::SkewTransformOperation::isSkewOperation): (WebCore::TranslateTransformOperation::isTranslateOperation): (WebCore::MatrixTransformOperation::isMatrixOperation):
  • rendering/RenderTableRow.h: (WebCore::RenderTableRow::requiresLayer):
  • rendering/RenderTreeAsText.cpp: (WebCore::writeLayers):
11:36 PM Changeset in webkit [26842] by thatcher
  • 6 edits in trunk/WebCore

Reviewed by Adam.

Add basic @font-face to the Web Inspector.

  • page/InspectorController.cpp: (WebCore::InspectorResource::type): Check for CachedResource::FontResource.
  • page/inspector/Resource.js: Add support for Font types and font preview in the icon.
  • page/inspector/ResourcePanel.js: Show a font preview for font resources.
  • page/inspector/inspector.css: Style for the font preview and font icon.
  • page/inspector/inspector.js: Add font mime types.
10:19 PM Changeset in webkit [26841] by weinig
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Fixes:

  • page/inspector/inspector.js: Change the constraint logic to only enforce a 100px min-width and window.innerWidth - 100 max-width for the sidebar. The change also makes the viewbuttons move with the sidebar.
9:00 PM Changeset in webkit [26840] by mitz
  • 7 edits
    4 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

Test: fast/table/insert-before-anonymous-ancestors.html

  • rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Rolled out r11579. I think whatever that change was supposed to accomplish has since been done in other places in the code.

LayoutTests:

Reviewed by Dave Hyatt.

  • fast/table/form-in-table-before-misnested-text-crash-css-expected.txt:
  • fast/table/form-in-table-before-misnested-text-crash-expected.txt:
  • fast/table/insert-before-anonymous-ancestors.html: Added.
  • fast/table/section-in-table-before-misnested-text-crash-css-expected.txt:
  • fast/table/section-in-table-before-misnested-text-crash-expected.txt:
  • platform/mac/fast/table/insert-before-anonymous-ancestors-expected.checksum: Added.
  • platform/mac/fast/table/insert-before-anonymous-ancestors-expected.png: Added.
  • platform/mac/fast/table/insert-before-anonymous-ancestors-expected.txt: Added.
8:06 PM Changeset in webkit [26839] by eseidel
  • 2 edits in trunk/WebKitTools

2007-10-20 Eric Seidel <​eric@webkit.org>

Reviewed by aroben.

  • Scripts/find-extra-includes: fix path matching regex to not match ".patch"
7:43 PM Changeset in webkit [26838] by eseidel
  • 8 edits
    1 add in trunk

2007-10-20 Eric Seidel <​eric@webkit.org>

Reviewed by darin.


Add improved argument handling to run-sunspider, including
--runs=<number>, --shell=<path>, --tests=<pattern>, --shark, and --help
Also re-factor code into subroutines

  • Scripts/build-dumprendertree: removed bogus comments
  • Scripts/build-testkjs: Added.
  • Scripts/run-javascriptcore-tests: use build-testkjs
  • Scripts/run-sunspider: improved argument handling, abstraction
  • Scripts/run-webkit-tests: improved abstraction
7:41 PM Changeset in webkit [26837] by bdash
  • 2 edits in trunk/WebCore

2007-10-20 Mark Rowe <​mrowe@apple.com>

Reviewed by Dave Hyatt.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=15584
Bug 15584: REGRESSION(r26696): GtkLauncher segfaults on WebCore::WidthIterator::advance

  • platform/Font.cpp: (WebCore::Font::glyphDataForCharacter): If the fallback page exists but does not have a glyph for the character, fall back to the missing glyph data rather than returning an invalid GlyphData.
4:01 PM Changeset in webkit [26836] by mjs
  • 3 edits
    6 adds in trunk/SunSpider

Reviewed by Mark.

  • Add more new tests, mostly from the computer language shootout. Not normalized yet.


  • TODO:
  • tests/LIST:
  • tests/access-binary-trees.js: Added.
  • tests/access-nsieve.js: Added.
  • tests/bitops-nsieve-bits.js: Added.
  • tests/math-partial-sums.js: Added.
  • tests/math-spectral-norm.js: Added.
  • tests/string-fasta.js: Added.
3:54 PM Changeset in webkit [26835] by bdash
  • 2 edits in trunk/WebCore

2007-10-20 Jasper Bryant-Greene <​m@ni.ac.nz>

Reviewed by Maciej.

Changed the hard-coded scroll delta in WheelEventGtk from 120 to 0.25,
as suggested by George Wright in #15108 (which this patch will
resolve).

This gives a more sane scrolling behaviour, rather than the
jumping to the end or start of the document as occurred previously.

  • platform/gtk/WheelEventGtk.cpp: (WebCore::PlatformWheelEvent::PlatformWheelEvent):
3:43 PM Changeset in webkit [26834] by mjs
  • 1 edit in trunk/SunSpider/ChangeLog

Fix reviewer in ChangeLog.

3:42 PM Changeset in webkit [26833] by mjs
  • 9 edits in trunk/SunSpider

Reviewed by Eric.

  • TODO: Updated to note areas that are now well-covered.


  • Change the tests and the driver to avoid leaving large object graphs hanging around, since that throws off the subsequent tests.


  • resources/sunspider-standalone-driver.js:
  • tests/3d-cube.js:
  • tests/3d-morph.js:
  • tests/3d-raytrace.js:
  • tests/bitops-bitwise-and.js:
  • tests/string-base64.js:
  • tests/string-tagcloud.js:
3:38 PM Changeset in webkit [26832] by darin
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

  • kjs/completion.h: Replace the Identifier with an Identifier*.
  • kjs/nodes.cpp: (ForInNode::execute): Update for change to Completion constructor. (ContinueNode::execute): Ditto. (BreakNode::execute): Ditto.
3:10 PM Changeset in webkit [26831] by alp
  • 4 edits
    1 move
    2 adds in trunk/WebCore

2007-10-20 Alp Toker <​alp@atoker.com>

Reviewed by Eric.

Support text boundary detection.
Move TextBoundariesWin.cpp to platform/ since it's portable and useful.
Split out and implement some TemporaryLinkStubs.

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/TextBoundariesICU.cpp: Copied from WebCore/platform/win/TextBoundariesWin.cpp.
  • platform/gtk/Language.cpp: Added. (WebCore::defaultLanguage):
  • platform/gtk/TemporaryLinkStubs.cpp:
  • platform/gtk/TextBreakIteratorInternalICUGtk.cpp: Added. (WebCore::currentTextBreakLocaleID):
  • platform/win/TextBoundariesWin.cpp: Removed.
2:00 PM Changeset in webkit [26830] by bdash
  • 2 edits in trunk/WebCore

2007-10-20 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

Workaround for ​http://bugs.webkit.org/show_bug.cgi?id=15574
Bug 15574: Web Inspector doesn't work with the new Database feature

The executeSql callback is executed in the security domain of the web page that owns the database,
while the inspector's window object is in the callback functions scope chain. This is leading to a
security violation when the callback attempts to access "document". We can work around this by
ensuring that "document" can be found in the scope chain before the window object.

  • page/inspector/DatabasePanel.js:
11:57 AM Changeset in webkit [26829] by pewtermoose
  • 2 edits in trunk/WebKitTools

Windows build fix

11:25 AM Changeset in webkit [26828] by bdash
  • 2 edits
    2 adds
    2 deletes in trunk/WebKitSite

2007-10-20 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Adam.

Convert TIFFs to PNGs so that the demo page is fully-functional in the Gtk port.

  • misc/DatabaseExample.html:
  • misc/deleteButton.png: Added.
  • misc/deleteButton.tiff: Removed.
  • misc/deleteButtonPressed.png: Added.
  • misc/deleteButtonPressed.tiff: Removed.
10:30 AM Changeset in webkit [26827] by darin
  • 2 edits in trunk/WebCore

Reviewed by Maciej.

This includes one other fix as well. Both were from a day where I did some
profiling to find hot spots when running the page load test.

  • platform/StringImpl.cpp: (WebCore::StringImpl::computeHash): Compute the hash without calling strlen. Also change the argument names to not confusingly use m_ prefixes. (WebCore::StringImpl::createStrippingNull): Added a faster case for strings that don't have null.
10:29 AM Changeset in webkit [26826] by darin
  • 5 edits in trunk

WebKitTools:

Reviewed by Tim Hatcher.

  • DumpRenderTree/mac/EventSendingController.mm: (-[EventSendingController keyDown:withModifiers:]): Added named key "rightArrow". Later we could have a whole table of these. Also tweaked modifiers code a little.
  • DumpRenderTree/win/EventSender.cpp: (keyDownCallback): Ditto.

LayoutTests:

Reviewed by Tim Hatcher.

  • fast/events/arrow-navigation.html: Use "rightArrow" instead.
10:26 AM Changeset in webkit [26825] by darin
  • 3 edits in trunk/WebKitTools

Reviewed by Eric.

  • DumpRenderTree/WorkQueue.cpp: (WorkQueue::queue): Delete the item if it's not put on the queue, since the caller has no way of knowing that. Would be better to have the parameter type be auto_ptr to express the fact that we take ownership.
  • unrelated change
  • Drosera/mac/main.m: Add missing include.
6:54 AM Changeset in webkit [26824] by bdash
  • 7 edits in trunk

2007-10-20 Mark Rowe <​mrowe@apple.com>

Reviewed by Alp.

Gtk changes needed to enable HTML 5 client-side database storage.

JavaScriptCore:

  • wtf/Platform.h: Have Gtk use pthreads for now.

WebCore:

  • WebCore.pro: Have Gtk use ThreadingPthreads.cpp.
  • platform/pthreads/ThreadingPthreads.cpp: Include errno so that EDEADLK and EBUSY are available.

WebKit/gtk:

  • Api/webkitgtkglobal.cpp: Set a default database path based on the user data directory. This should become configurable by client applications in the future.
6:01 AM Changeset in webkit [26823] by bdash
  • 3 edits
    1 add in trunk/WebCore

2007-10-20 Mark Rowe <​mrowe@apple.com>

Reviewed by Alp.

Implement callOnMainThread for Gtk+ via a one-shot zero-delay timer that will be dispatched
from the main event loop.

  • WebCore.pro:
  • platform/gtk/TemporaryLinkStubs.cpp:
  • platform/gtk/ThreadingGtk.cpp: Added. (WebCore::callFunctionOnMainThread): (WebCore::callOnMainThread):
6:00 AM Changeset in webkit [26822] by bdash
  • 2 edits in trunk/WebKit/gtk

2007-10-20 Mark Rowe <​mrowe@apple.com>

Reviewed by Eric.

Don't allow control characters to be inserted into editable regions.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeypress):
5:55 AM Changeset in webkit [26821] by zimmermann
  • 13 edits in trunk

Reviewed by Eric.

Fix non-functional display="inline" / display="none" for SVG text.

Fixes: svg/W3C-SVG-1.1/animate-elem-39-t.svg (display="inline" support)
Fixes: svg/batik/text/textProperties2.svg (display="inline/none" support)
Fixes: svg/carto.net/tabgroup.svg (display="none" support, stray content before layouting)

4:17 AM Changeset in webkit [26820] by bdash
  • 2 edits
    1 add in trunk/WebCore

2007-10-20 Mark Rowe <​mrowe@apple.com>

Reviewed by Alp.

Replace #ifdef'd code with the appropriate use of a forwarding header.

  • ForwardingHeaders/kjs/array_instance.h: Added.
  • bindings/js/JSDatabaseCustom.cpp:
3:37 AM Changeset in webkit [26819] by zimmermann
  • 21 edits in trunk

Reviewed by Oliver.

Add support for 'kerning' property in SVG text layout code.
Support all textLength/lengthAdjust modes on normal text & textPaths.

Support letter & word spacing on textPath.
Fix text selection when any spacing (letter/word/kerning) is involved.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=15571
Fixes: svg/batik/text/textOnPathSpaces.svg (spacing)

svg/batik/text/textLayout.svg (kerning support)
svg/text/text-spacing-01-b.svg (text selection)

3:37 AM Changeset in webkit [26818] by aroben
  • 1 edit in trunk/WebKitSite/misc/DatabaseExample.html

Fix typo

3:30 AM Changeset in webkit [26817] by aroben
  • 2 edits
    2 adds in trunk/WebKitSite

Make the notes sticky!

Reviewed by Mark.

  • misc/DatabaseExample.html:
  • misc/deleteButton.tiff: Added.
  • misc/deleteButtonPressed.tiff: Added.
3:20 AM Changeset in webkit [26816] by bdash
  • 10 edits in trunk/WebCore

2007-10-20 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewd by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15563
Fix conflict with X11 Window type in WebCore

  • WebCore/bindings/js/JSDocumentCustom.cpp:
  • WebCore/bindings/js/JSHTMLDocumentCustom.cpp:
  • WebCore/bindings/js/JSHTMLFrameSetElementCustom.cpp:
  • WebCore/bindings/js/kjs_dom.cpp:
  • WebCore/bindings/js/kjs_events.cpp:
  • WebCore/bindings/js/kjs_proxy.cpp:
  • WebCore/history/CachedPage.cpp:
  • WebCore/page/Chrome.cpp:
  • WebCore/page/Frame.cpp:
2:45 AM Changeset in webkit [26815] by hausmann
  • 2 edits in trunk/WebCore

Fix the Qt build.

1:51 AM Changeset in webkit [26814] by mjs
  • 10 edits in trunk/SunSpider

Reviewed by Nikolas.


  • Rebalance test complexity.


Scaled all the tests so they take 400-600ms on a reasonably normal user setup:


Internet Explorer 7, Window XP, Dell Latitude D810 with a 2.13GHz Pentium M

However, for some tests, IE7 was a huge outlier compared to other
major browsers. For those tests, I used Firefox 2.0.0.8 on the
same OS and hardware as a normalization basis.


  • tests/3d-morph.js:
  • tests/3d-raytrace.js:
  • tests/bitops-3bit-bits-in-byte.js:
  • tests/bitops-bits-in-byte.js:
  • tests/bitops-bitwise-and.js:
  • tests/math-cordic.js:
  • tests/string-base64.js:
  • tests/string-tagcloud.js:
  • tests/string-unpack-code.js:
1:11 AM Changeset in webkit [26813] by mjs
  • 2 edits in trunk/SunSpider

Reviewed by Oliver.


  • Fix the browser-hosted driver to be compatible with Safari 2
  • hosted/sunspider-driver.html:
1:05 AM Changeset in webkit [26812] by mjs
  • 2 edits in trunk/SunSpider

Rubber stamped by Hyatt.


  • Add BSD license notice to cordic test, the original author said to do so.
  • tests/math-cordic.js:
12:11 AM Changeset in webkit [26811] by ggaren
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej Stachowiak.

Fixed ​http://bugs.webkit.org/show_bug.cgi?id=15570
Store gathered declaration nodes in the function body node.


This means that you only have to gather the declaration nodes the first
time the function executes. Performance gain of 2.10% on SunSpider,
0.90% on command-line JS iBench.

  • kjs/nodes.cpp: Split declaration stack initialization code off into initializeDeclarationStacks(). (FunctionBodyNode::FunctionBodyNode): (FunctionBodyNode::initializeDeclarationStacks): (FunctionBodyNode::processDeclarations):
  • kjs/nodes.h: Changed DeclarationStacks structure to hold references, since the actual Vectors are now stored either on the stack or in the function body node.

Oct 19, 2007:

10:37 PM Changeset in webkit [26810] by alp
  • 10 edits in trunk

2007-10-19 Alp Toker <​alp@atoker.com>

Reviewed by Oliver.

GTK+ build fix enabling the new local database storage feature.
There is also a prospective Qt build fix.

10:20 PM Changeset in webkit [26809] by ggaren
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Added Bugzilla link to ChangeLog

10:18 PM Changeset in webkit [26808] by ggaren
  • 6 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.


To improve encapsulation, moved processDeclarations call into
FunctionBodyNode::execute. Also marked processDeclarations
ALWAYS_INLINE, since it has only 1 caller now. This is a .71% speedup
on command-line JS iBench.

  • kjs/function.cpp: (KJS::FunctionImp::callAsFunction): (KJS::GlobalFuncImp::callAsFunction):
  • kjs/function.h:
  • kjs/interpreter.cpp: (KJS::Interpreter::evaluate):
  • kjs/nodes.cpp: (FunctionBodyNode::execute):
  • kjs/nodes.h:
9:39 PM JavaScript performance improvement ideas edited by mjs@apple.com
(diff)
9:35 PM JavaScript performance improvement ideas edited by mjs@apple.com
(diff)
9:10 PM Changeset in webkit [26807] by aroben
  • 2 edits in branches/Safari-3-branch/WebKitTools

Merge r26766

9:08 PM Changeset in webkit [26806] by andrew
  • 2 edits in trunk/WebCore

Reviewed by Brady Eidson.

Mac build fix.

  • WebCore.xcodeproj/project.pbxproj:
8:09 PM Changeset in webkit [26805] by oliver
  • 2 edits in trunk/LayoutTests

Updating window properties to include new features from HTML5 database support

RS=Mark

  • fast/dom/Window/window-properties-expected.txt:
7:20 PM Changeset in webkit [26804] by thatcher
  • 2 edits in trunk/WebKitSite

Reviewed by Mark Rowe.

Fix a couple of exceptions for first time users.

  • misc/DatabaseExample.html:
6:48 PM Changeset in webkit [26803] by alp
  • 3 edits in trunk/WebCore

2007-10-19 Alp Toker <​alp@atoker.com>

Reviewed by Oliver.

Use platform colors for text selection.
Update the cache when the GTK style is changed.

  • platform/gtk/RenderThemeGtk.cpp: (WebCore::RenderThemeGtk::platformActiveSelectionBackgroundColor): (WebCore::RenderThemeGtk::platformInactiveSelectionBackgroundColor): (WebCore::RenderThemeGtk::platformActiveSelectionForegroundColor): (WebCore::RenderThemeGtk::platformInactiveSelectionForegroundColor): (WebCore::RenderThemeGtk::gtkStyleSet): (WebCore::RenderThemeGtk::gtkEntry):
  • platform/gtk/RenderThemeGtk.h:
6:18 PM Changeset in webkit [26802] by adele
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Beth.

Fix for: <rdar://problem/5518461> REGRESSION (2.0.4-3): Popup arrows are missing in small popups at homedepot.com

Test: fast/forms/menulist-no-overflow.html

  • rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::setStyle): Don't allow overflow on menu lists.

LayoutTests:

Reviewed by Beth.

Test for <rdar://problem/5518461> REGRESSION (2.0.4-3): Popup arrows are missing in small popups at homedepot.com

  • fast/forms/menulist-no-overflow.html: Added.
  • platform/mac/fast/forms/menulist-no-overflow-expected.checksum: Added.
  • platform/mac/fast/forms/menulist-no-overflow-expected.png: Added.
  • platform/mac/fast/forms/menulist-no-overflow-expected.txt: Added.
6:06 PM Changeset in webkit [26801] by andersca
  • 3 edits
    6 moves in trunk/WebCore

Reviewed by Brady.

Move some SQL-related classes to platform/sql.


  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/icon/SQLDatabase.cpp: Removed.
  • loader/icon/SQLDatabase.h: Removed.
  • loader/icon/SQLStatement.cpp: Removed.
  • loader/icon/SQLStatement.h: Removed.
  • loader/icon/SQLTransaction.cpp: Removed.
  • loader/icon/SQLTransaction.h: Removed.
  • platform/sql/SQLDatabase.cpp: Copied from loader/icon/SQLDatabase.cpp.
  • platform/sql/SQLDatabase.h: Copied from loader/icon/SQLDatabase.h.
  • platform/sql/SQLStatement.cpp: Copied from loader/icon/SQLStatement.cpp.
  • platform/sql/SQLStatement.h: Copied from loader/icon/SQLStatement.h.
  • platform/sql/SQLTransaction.cpp: Copied from loader/icon/SQLTransaction.cpp.
  • platform/sql/SQLTransaction.h: Copied from loader/icon/SQLTransaction.h.
5:49 PM Changeset in webkit [26800] by andersca
  • 2 edits in trunk/WebKitSite

Reviewed by Brady.


Make example actually work.


  • misc/DatabaseExample.html:
5:45 PM Changeset in webkit [26799] by andersca
  • 6 edits in trunk

WebCore:

Reviewed by Adam.

Update to match the latest version of the spec. Now, executeSQL takes an array
of SQL parameters instead of them being passed as arguments.


  • bindings/js/JSDatabaseCustom.cpp: (WebCore::JSDatabase::executeSql):
  • page/inspector/DatabasePanel.js:
  • storage/Database.idl:

WebKitSite:

Reviewed by Adam.

Update example.


  • misc/DatabaseExample.html:
5:38 PM Changeset in webkit [26798] by kmccullo
  • 2 edits in trunk/WebKitTools

Reviewed by Adam.

  • This change should be identical but for some reason was not working on my machine.
  • Scripts/prepare-ChangeLog:
5:22 PM Changeset in webkit [26797] by beidson
  • 6 edits in trunk

WebCore:

Reviewed by Tim

Tiger's SQLite doesn't support CREATE TABLE IF NOT EXISTS :(

  • storage/Database.cpp: (WebCore::Database::performOpenAndVerify):
  • storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::DatabaseTracker):

WebKitSite:

Reviewed by Tim

Tiger's SQLite doesn't support CREATE TABLE IF NOT EXISTS :(

  • misc/DatabaseExample.html:
4:57 PM Changeset in webkit [26796] by andersca
  • 2 edits in trunk/WebCore

Release build fix.


  • WebCore.vcproj/WebCore.vcproj:
4:42 PM Changeset in webkit [26795] by sfalken
  • 1 copy in tags/Safari-523.12.5b

New tag.

4:42 PM Changeset in webkit [26794] by sfalken
  • 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

4:37 PM Changeset in webkit [26793] by beidson
  • 2 edits in trunk/WebCore

Remove stray printfs

  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::~Document):
4:36 PM Changeset in webkit [26792] by andersca
  • 2 edits in trunk/WebCore

Reviewed by Brady.

Apparently the Win32 pthreads impl we use does not allow unlocking a mutex that has not
already been locked, so lock the mutex first.


  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::databaseThread):
4:34 PM Changeset in webkit [26791] by beidson
  • 2 edits in trunk/WebCore

Better build fix

  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::authorizerFunction): Definite works by 3.3.13
4:25 PM Changeset in webkit [26790] by beidson
  • 2 edits in trunk/WebCore

Build fix

  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::authorizerFunction): I don't know *when* these constants were added to SQLite, but I know they were by 3.4.0
3:55 PM Changeset in webkit [26789] by sfalken
  • 1 copy in tags/Safari-523.12.4b

New tag.

3:55 PM Changeset in webkit [26788] by sfalken
  • 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

3:50 PM Changeset in webkit [26787] by beidson
  • 48 edits
    24 copies
    34 adds in trunk

JavaScriptCore:

2007-10-19 Brady Eidson <​beidson@apple.com>

Reviewed by Sam

Queue -> Deque! and small style tweaks

  • JavaScriptCore.vcproj/WTF/WTF.vcproj:
  • JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
  • wtf/Deque.h: Added. (WTF::DequeNode::DequeNode): (WTF::Deque::Deque): (WTF::Deque::~Deque): (WTF::Deque::size): (WTF::Deque::isEmpty): (WTF::Deque::append): (WTF::Deque::prepend): (WTF::Deque::first): (WTF::Deque::last): (WTF::Deque::removeFirst): (WTF::Deque::clear):
  • wtf/Queue.h: Removed.

2007-10-19 Brady Eidson <​beidson@apple.com>

Reviewed by Oliver

Added a simple LinkedList based Queue to wtf
We can make a better, more sophisticated an efficient one later, but have
needed one for some time, now!

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • wtf/Queue.h: Added. (WTF::QueueNode::QueueNode): (WTF::Queue::Queue): (WTF::Queue::~Queue): (WTF::Queue::size): (WTF::Queue::isEmpty): (WTF::Queue::append): (WTF::Queue::prepend): (WTF::Queue::first): (WTF::Queue::last): (WTF::Queue::removeFirst): (WTF::Queue::clear):

WebCore:
2007-10-19 Brady Eidson <​beidson@apple.com>

Reviewed by Anders

Windows specific changes, as well as renaming Queue -> Deque

  • ForwardingHeaders/wtf/Deque.h: Added.
  • ForwardingHeaders/wtf/Queue.h: Removed.
  • platform/win/FileSystemWin.cpp: (WebCore::fileSize): (WebCore::fileExists): (WebCore::deleteFile): (WebCore::pathByAppendingComponent): (WebCore::fileSystemRepresentation): (WebCore::makeAllDirectories): (WebCore::homeDirectoryPath):
  • storage/Database.h:
  • storage/DatabaseThread.cpp: (WebCore::DatabaseThread::documentGoingAway): (WebCore::DatabaseThread::databaseGoingAway): (WebCore::DatabaseThread::dispatchNextTaskIdentifier): (WebCore::DatabaseThread::scheduleTask): (WebCore::DatabaseThread::scheduleImmediateTask):
  • storage/DatabaseThread.h:

2007-10-19 Brady Eidson <​beidson@apple.com>

Reviewed by Tim and Anders

Preliminary support for HTML5 local database storage (​http://www.whatwg.org/specs/web-apps/current-work/)

The specification is still in flux but the fundamentals are pretty solid and we can start using and testing
this implementation even while filing bugs to track changes in the spec as it becomes more final

There are some implementation details in this patch that seem unused or useless, but they remain in place
while the spec is in flux and might go one way or another.

  • platform/Logging.cpp: Add StorageAPI logging channel
  • platform/Logging.h:
  • storage/Database.cpp: Added. (WebCore::Database::databaseInfoTableName): (WebCore::databaseVersionKey): (WebCore::Database::openDatabase): C++ version of the window.openDatabase() javascript API (WebCore::Database::Database): (WebCore::Database::~Database): (WebCore::Database::openAndVerifyVersion): (WebCore::retrieveTextResultFromDatabase): (WebCore::Database::getVersionFromDatabase): (WebCore::setTextValueInDatabase): (WebCore::Database::setVersionInDatabase): (WebCore::Database::databaseThreadGoingAway): May be removed in the future (WebCore::Database::disableAuthorizer): For internal (WebInspector) use to get around the authorizer's restrictions (WebCore::Database::enableAuthorizer): (WebCore::Database::guidForOriginAndName): Candidate for refactoring and/or moving to the database tracker. The GUID for each database identifier is currently for tracking the database version, but might be rescoped in the future (WebCore::Database::resetAuthorizer): (WebCore::Database::performPolicyChecks): Currently, the only post-executeSql policy check planned is the origin size usage (WebCore::Database::scheduleDatabaseCallback): (WebCore::Database::performOpenAndVerify): (WebCore::Database::performChangeVersion): (WebCore::Database::performExecuteSql): (WebCore::Database::performCloseTransaction): (WebCore::Database::performGetTableNames): (WebCore::Database::version): C++ version of the javascript API (WebCore::Database::changeVersion): Ditto (WebCore::Database::executeSql): Ditto (WebCore::Database::closeTransaction): Ditto (WebCore::Database::tableNames): For internal (WebInspector) use (WebCore::Database::deliverAllPendingCallbacks): (WebCore::Database::deliverPendingCallbacks):
  • storage/Database.h: Added. (WebCore::Database::databaseDebugName): For debug logging purposes
  • storage/Database.idl: Added.
  • storage/DatabaseAuthorizer.cpp: Added. The DatabaseAuthorizer is used to both prevent the script from doing "illegal" things in sql as well as tracking when effects certain sql statements might have (such as increasing the size of the database) (WebCore::DatabaseAuthorizer::DatabaseAuthorizer): (WebCore::DatabaseAuthorizer::reset): (WebCore::DatabaseAuthorizer::createTable): (WebCore::DatabaseAuthorizer::createTempTable): (WebCore::DatabaseAuthorizer::dropTable): (WebCore::DatabaseAuthorizer::dropTempTable): (WebCore::DatabaseAuthorizer::allowAlterTable): (WebCore::DatabaseAuthorizer::createIndex): (WebCore::DatabaseAuthorizer::createTempIndex): (WebCore::DatabaseAuthorizer::dropIndex): (WebCore::DatabaseAuthorizer::dropTempIndex): (WebCore::DatabaseAuthorizer::createTrigger): (WebCore::DatabaseAuthorizer::createTempTrigger): (WebCore::DatabaseAuthorizer::dropTrigger): (WebCore::DatabaseAuthorizer::dropTempTrigger): (WebCore::DatabaseAuthorizer::createVTable): (WebCore::DatabaseAuthorizer::dropVTable): (WebCore::DatabaseAuthorizer::allowDelete): (WebCore::DatabaseAuthorizer::allowInsert): (WebCore::DatabaseAuthorizer::allowUpdate): (WebCore::DatabaseAuthorizer::allowRead): (WebCore::DatabaseAuthorizer::allowAnalyze): (WebCore::DatabaseAuthorizer::allowPragma): (WebCore::DatabaseAuthorizer::allowAttach): (WebCore::DatabaseAuthorizer::allowDetach): (WebCore::DatabaseAuthorizer::allowFunction): (WebCore::DatabaseAuthorizer::disable): (WebCore::DatabaseAuthorizer::enable): (WebCore::DatabaseAuthorizer::denyBasedOnTableName): Don't allow access to the WebKit meta info table as it should be invisible to scripts
  • storage/DatabaseAuthorizer.h: Added. (WebCore::DatabaseAuthorizer::lastActionWasInsert): (WebCore::DatabaseAuthorizer::lastActionIncreasedSize):
  • storage/DatabaseCallback.cpp: Added. Generic item to queue up for callbacks on the main thread for database activities that take place on a secondary thread (WebCore::DatabaseChangeVersionCallback::DatabaseChangeVersionCallback): (WebCore::DatabaseChangeVersionCallback::performCallback): (WebCore::DatabaseExecuteSqlCallback::DatabaseExecuteSqlCallback): (WebCore::DatabaseExecuteSqlCallback::performCallback):
  • storage/DatabaseCallback.h: Added. (WebCore::DatabaseCallback::~DatabaseCallback): (WebCore::DatabaseChangeVersionCallback::~DatabaseChangeVersionCallback): (WebCore::DatabaseExecuteSqlCallback::~DatabaseExecuteSqlCallback):
  • storage/DatabaseTask.h: Added. Generic work-item to be queued up on the background database thread (WebCore::DatabaseTask::isComplete): (WebCore::DatabaseOpenTask::exceptionCode): (WebCore::DatabaseOpenTask::openSuccessful): (WebCore::DatabaseTableNamesTask::tableNames):
  • storage/DatabaseTask.cpp: Added. (WebCore::DatabaseTask::DatabaseTask): (WebCore::DatabaseTask::~DatabaseTask): (WebCore::DatabaseTask::performTask): (WebCore::DatabaseTask::lockForSynchronousScheduling): Used when the main thread needs this task accomplished synchronously (WebCore::DatabaseTask::waitForSynchronousCompletion):

(WebCore::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::DatabaseOpenTask::doPerformTask):

(WebCore::DatabaseExecuteSqlTask::DatabaseExecuteSqlTask):
(WebCore::DatabaseExecuteSqlTask::doPerformTask):

(WebCore::DatabaseChangeVersionTask::DatabaseChangeVersionTask):
(WebCore::DatabaseChangeVersionTask::doPerformTask):

(WebCore::DatabaseTableNamesTask::DatabaseTableNamesTask):
(WebCore::DatabaseTableNamesTask::doPerformTask):

  • storage/DatabaseThread.cpp: Added. The current design is that each Document will have its own DatabaseThread. This makes scripts on each individual document more response at the cost of adding more threads and potentially creating concurrency issues when the same database is open twice from two different documents (WebCore::DatabaseThread::DatabaseThread): (WebCore::DatabaseThread::~DatabaseThread): (WebCore::DatabaseThread::start): (WebCore::DatabaseThread::documentGoingAway): Called to shut the thread down when the document is destroyed (WebCore::DatabaseThread::databaseGoingAway): Remove all pending tasks for this database (WebCore::DatabaseThread::databaseThreadStart): (WebCore::DatabaseThread::databaseThread): (WebCore::DatabaseThread::dispatchNextTaskIdentifier): (WebCore::DatabaseThread::scheduleTask): (WebCore::DatabaseThread::scheduleImmediateTask): Schedule a task that gets to "cut to the front of the line" when the main thread requires a task be performed synchronously (WebCore::DatabaseThread::wakeWorkThread):
  • storage/DatabaseThread.h: Added.
  • storage/DatabaseTracker.cpp: Added. The DatabaseTracker is the master management of all databases. It will keep track of the filename for a given unique database, keep track of the total disk usage per-origin, and policys per database/origin (WebCore::DatabaseTracker::setDatabasePath): (WebCore::DatabaseTracker::databasePath): (WebCore::DatabaseTracker::tracker): (WebCore::DatabaseTracker::DatabaseTracker): (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::populateOrigins): (WebCore::DatabaseTracker::origins): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::addDatabase): (WebCore::DatabaseTracker::deleteAllDatabases): (WebCore::DatabaseTracker::deleteAllDatabasesForOrigin):
  • storage/DatabaseTracker.h: Added.
  • storage/SQLCallback.h: Added. C++ version of the javascript executeSql() callback (WebCore::SQLCallback::~SQLCallback):
  • storage/SQLCallback.idl: Added.
  • storage/SQLResultSet.cpp: Added. C++ version of the javascript SQLResultSet object (WebCore::SQLResultSet::SQLResultSet): (WebCore::SQLResultSet::insertId): (WebCore::SQLResultSet::rowsAffected): (WebCore::SQLResultSet::errorCode): (WebCore::SQLResultSet::error): (WebCore::SQLResultSet::rows): (WebCore::SQLResultSet::setInsertId): (WebCore::SQLResultSet::setRowsAffected): (WebCore::SQLResultSet::setErrorCode): (WebCore::SQLResultSet::setErrorMessage):
  • storage/SQLResultSet.h: Added.
  • storage/SQLResultSet.idl: Added.
  • storage/SQLResultSetRowList.cpp: Added. C++ version of the javascript SQLResultSetRowList object (WebCore::SQLResultSetRowList::length):
  • storage/SQLResultSetRowList.h: Added. (WebCore::SQLResultSetRowList::columnNames): (WebCore::SQLResultSetRowList::values): (WebCore::SQLResultSetRowList::addColumn): (WebCore::SQLResultSetRowList::addResult):
  • storage/SQLResultSetRowList.idl: Added.
  • storage/VersionChangeCallback.h: Added. C++ version of the javascript changeVersion() callback (WebCore::VersionChangeCallback::~VersionChangeCallback):
  • storage/VersionChangeCallback.idl: Added.

2007-10-19 Brady Eidson <​beidson@apple.com>

Reviewed by Oliver + Same

Forwarding header for the new wtf/Queue.h

  • ForwardingHeaders/wtf/Queue.h: Added.

2007-10-19 Anders Carlsson <​beidson@apple.com>

Reviewed by Sam Weinig

Most of the Javascript binding support for the Storage API

  • bindings/js/JSCustomSQLCallback.cpp: Added. (WebCore::JSCustomSQLCallback::JSCustomSQLCallback): (WebCore::JSCustomSQLCallback::handleEvent):
  • bindings/js/JSCustomSQLCallback.h: Added. Add JSCustomSQLCallback which is an SQLCallback implementation that dispatches handleEvent to a JS function or a JS object with a handleEvent function.
  • bindings/js/JSCustomVersionChangeCallback.cpp: Added. (WebCore::JSCustomVersionChangeCallback::JSCustomVersionChangeCallback): (WebCore::JSCustomVersionChangeCallback::handleEvent):
  • bindings/js/JSCustomVersionChangeCallback.h: Added. Add JSCustomSQLCallback which is an SQLCallback implementation that dispatches handleEvent to a JS function or a JS object with a handleEvent function.
  • bindings/js/JSDatabaseCustom.cpp: Added. (WebCore::JSDatabase::executeSql): Custom implementation of executeSql that takes an array of parameters.

(WebCore::JSDatabase::changeVersion):

Custom implementation of changeVersion.

  • bindings/js/JSSQLResultSetRowListCustom.cpp: Added. (WebCore::JSSQLResultSetRowList::item): Custom method that returns a JS object that corresponds to a given row in the database.
  • bindings/scripts/CodeGeneratorJS.pm:
  • page/DOMWindow.cpp: (WebCore::DOMWindow::openDatabase):
  • page/DOMWindow.h:
  • page/DOMWindow.idl: Add openDatabase implementation.

2007-10-19 Brady Eidson <​beidson@apple.com>

Reviewed by Oliver

Added tons of utility to the FileSystem abstractions, including moving
some stuff over from IconDatabase

  • platform/FileSystem.h:
  • platform/cf/FileSystemCF.cpp: Added. (WebCore::fileSystemRepresentation):
  • platform/mac/FileSystemMac.mm:
  • platform/posix/FileSystemPOSIX.cpp: Added. (WebCore::fileExists): (WebCore::deleteFile): (WebCore::fileSize): (WebCore::pathByAppendingComponent): (WebCore::makeAllDirectories):

2007-10-19 Timothy Hatcher <​timothy@apple.com>

Reviewed by Adam Roben

Preliminary Web Inspector support for the Storage API
(This patch does not include the support artwork)

  • page/InspectorController.cpp: (WebCore::InspectorDatabaseResource::InspectorDatabaseResource): (WebCore::InspectorDatabaseResource::setScriptObject): (WebCore::databaseTableNames): Return the table names for a Database object. (WebCore::InspectorController::setWindowVisible): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::populateScriptResources): (WebCore::InspectorController::addDatabaseScriptResource): Add the script object for the database. (WebCore::InspectorController::removeDatabaseScriptResource): Remove the script object for the database. (WebCore::InspectorController::clearDatabaseScriptResources): Remove all the database resources. (WebCore::InspectorController::didCommitLoad): Call clearDatabaseScriptResources(). (WebCore::InspectorController::didOpenDatabase): Make a new InspectorDatabaseResource and add it to m_databaseResources.
  • page/InspectorController.h:
  • page/inspector/Database.js: Added.
  • page/inspector/DatabasePanel.js: Added.
  • page/inspector/ResourceCategory.js: Make resource categories assume less about the resource.
  • page/inspector/inspector.css: Add styles for the database panel.
  • page/inspector/inspector.html: Include DatabasePanel.js
  • page/inspector/inspector.js: Support for adding and removing Database resources.

2007-10-19 Brady Eidson <​beidson@apple.com>

Reviewed by Tim Hatcher

Added support for Chrome prompts required by the Storage API

  • page/Chrome.cpp: (WebCore::Chrome::runDatabaseSizeLimitPrompt):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • platform/graphics/svg/SVGImageEmptyClients.h:

2007-10-19 Brady Eidson <​beidson@apple.com>

Contributions and Review by Anders

Various SQLite tweaks in preparation for the storage API

  • loader/icon/SQLDatabase.cpp: (WebCore::SQLDatabase::~SQLDatabase): (WebCore::SQLDatabase::authorizerFunction): Static callback from sqlite for authorizer functions (WebCore::SQLDatabase::setAuthorizer): (WebCore::SQLDatabase::lock): (WebCore::SQLDatabase::unlock):
  • loader/icon/SQLDatabase.h:
  • loader/icon/SQLStatement.cpp: (WebCore::SQLStatement::prepare): Switch to prepare16_v2 (WebCore::SQLStatement::bindDouble): Added (WebCore::SQLStatement::bindValue): Bind a wrapped SQLValue object (described later) (WebCore::SQLStatement::bindParameterCount): Accessor to the sqlite3 API for validating statements
  • loader/icon/SQLStatement.h: (WebCore::SQLStatement::isPrepared):
  • platform/sql/SQLAuthorizer.cpp: Added. Fully virtual interface to implement your own SQLite authorizer
  • platform/sql/SQLAuthorizer.h: Added. (WebCore::SQLAuthorizer::~SQLAuthorizer): (WebCore::SQLAuthorizer::createTable): (WebCore::SQLAuthorizer::createTempTable): (WebCore::SQLAuthorizer::dropTable): (WebCore::SQLAuthorizer::dropTempTable): (WebCore::SQLAuthorizer::allowAlterTable): (WebCore::SQLAuthorizer::createIndex): (WebCore::SQLAuthorizer::createTempIndex): (WebCore::SQLAuthorizer::dropIndex): (WebCore::SQLAuthorizer::dropTempIndex): (WebCore::SQLAuthorizer::createTrigger): (WebCore::SQLAuthorizer::createTempTrigger): (WebCore::SQLAuthorizer::dropTrigger): (WebCore::SQLAuthorizer::dropTempTrigger): (WebCore::SQLAuthorizer::createView): (WebCore::SQLAuthorizer::createTempView): (WebCore::SQLAuthorizer::dropView): (WebCore::SQLAuthorizer::dropTempView): (WebCore::SQLAuthorizer::createVTable): (WebCore::SQLAuthorizer::dropVTable): (WebCore::SQLAuthorizer::allowDelete): (WebCore::SQLAuthorizer::allowInsert): (WebCore::SQLAuthorizer::allowUpdate): (WebCore::SQLAuthorizer::allowTransaction): (WebCore::SQLAuthorizer::allowSelect): (WebCore::SQLAuthorizer::allowRead): (WebCore::SQLAuthorizer::allowAttach): (WebCore::SQLAuthorizer::allowDetach): (WebCore::SQLAuthorizer::allowReindex): (WebCore::SQLAuthorizer::allowAnalyze): (WebCore::SQLAuthorizer::allowFunction):
  • platform/sql/SQLValue.cpp: Added. Contains a value for a SQLite database that can be one of a few types. For now, just a String or a double (WebCore::SQLValue::SQLValue): (WebCore::SQLValue::string): (WebCore::SQLValue::number):
  • platform/sql/SQLValue.h: Added. (WebCore::SQLValue::): (WebCore::SQLValue::SQLValue): (WebCore::SQLValue::type):

2007-10-19 Brady Eidson <​beidson@apple.com>

Reviewed by Maciej

Changed IconDatabase over to use new FileSystem apis

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::open):

WebKit:

Reviewed by Tim Hatcher

Added support for Chrome prompts required by the Storage API
Added support API for future managing of databases from the WebKit client
Added preference and initialization for the databases path

  • Misc/WebDatabaseManager.h: Added. WebDatabaseManager is how a WebKit application can list and remove the current available databases
  • Misc/WebDatabaseManager.mm: Added. (+[WebDatabaseManager origins]): (+[WebDatabaseManager databasesWithOrigin:]): (+[WebDatabaseManager deleteAllDatabases]): (+[WebDatabaseManager deleteAllDatabasesWithOrigin:]): (+[WebDatabaseManager deleteDatabaseWithOrigin:named:]): (WebKitSetWebDatabasesPathIfNecessary): Setup the database path
  • Misc/WebDatabaseManagerPrivate.h: Added.
  • WebCoreSupport/WebChromeClient.h: Support for calling the delegate to run the prompt for an origin exceeding its size limit
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::runDatabaseSizeLimitPrompt):
  • WebKit.xcodeproj/project.pbxproj:
  • WebView/WebUIDelegate.h:
  • WebView/WebView.mm: (-[WebView _commonInitializationWithFrameName:groupName:]): Setup the database path
  • WebView/WebViewInternal.h:

WebKitSite:

Reviewed by Tim Hatcher

Sample database API usage

  • misc/DatabaseExample.html: Added.

WebKit/win:

Reviewed by Anders

Keep windows building with new Chrome additions

  • WebChromeClient.cpp:
  • WebChromeClient.h:
3:21 PM Changeset in webkit [26786] by kmccullo
  • 7 edits in trunk/WebKitTools

Reviewed by Oliver and Tim.

  • Made use of RetainPtr to avoid retain and release issues and moved the log function to DebuggerDocumentPlatform, which seems to be a more logical place for it to live.
  • Also moved knownServers from the ServerConnection to DebuggerApplication to match the Windows code and because it makes sense that a connection knows its own server but not all of them.
  • Drosera/mac/DebuggerClient.h: Moved the log function to DebuggerDocumentPlatform.
  • Drosera/mac/DebuggerClient.mm: Ditto. Also do not release the server Because it's owned by an own Ptr in DebuggerDocument. Also moved the call for the server name up from the ServerConnection class. (-[DebuggerClient dealloc]): (-[DebuggerClient webView:didReceiveTitle:forFrame:]): Moved the call for the server name up from the ServerConnection.
  • Drosera/mac/DebuggerDocumentPlatform.mm: Made the server an OwnPtr. (DebuggerDocument::platformPause): (DebuggerDocument::platformResume): (DebuggerDocument::platformStepInto): (DebuggerDocument::platformEvaluateScript): (DebuggerDocument::getPlatformCurrentFunctionStack): (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed): (DebuggerDocument::platformLog): Log directly from here. No need to call DebuggerClient.
  • Drosera/mac/ServerConnection.h: Removed the knownServers function. The way I see it, a ServerConnection should only know about its connection and the group of all possible servers should be kept by the application.
  • Drosera/mac/ServerConnection.mm: Removed knownServer but added currentServerName, it makes sense that the connection should know that name. (-[ServerConnection currentServerName]):
3:00 PM Changeset in webkit [26785] by hyatt
  • 2 edits in trunk/WebCore

Fix for ebay parser crash.

Reviewed by Beth

fast/invalid/table-residual-style-crash.html added as a test

  • html/HTMLParser.cpp: (WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
2:58 PM Changeset in webkit [26784] by hyatt
  • 4 adds in trunk/LayoutTests

Add new layout test for parser crash.

2:25 PM Changeset in webkit [26783] by zimmermann
  • 2 edits in trunk/JavaScriptCore

Reviewed by Anders.
Try to fix Qt/Win build slave, by including windows.h also on Qt/Win.

2:17 PM Changeset in webkit [26782] by weinig
  • 3 edits in trunk/WebCore

Fix Windows, Qt and GTK builds.

  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
2:03 PM Changeset in webkit [26781] by zimmermann
  • 59 edits in trunk/LayoutTests

Rubberstamped by Oliver.

Land tiger baseline matching my MBP, as discussed with Oliver.
Mostly differences regarding the size of "(" / ")" characters.

1:53 PM Changeset in webkit [26780] by weinig
  • 21 edits
    2 adds in trunk

WebCore:

Reviewed by Darin.

Encapsulate the same origin check into the new SecurityOrigin class.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):
  • dom/Document.cpp: (WebCore::Document::Document): (WebCore::Document::defaultEventHandler):
  • dom/Document.h: (WebCore::Document::securityOrigin):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): (WebCore::FrameLoader::setOpener):
  • loader/FrameLoader.h:
  • platform/SecurityOrigin.cpp: Added. (WebCore::SecurityOrigin::SecurityOrigin): (WebCore::SecurityOrigin::clear): (WebCore::SecurityOrigin::isEmpty): (WebCore::SecurityOrigin::setForFrame): (WebCore::SecurityOrigin::setDomainFromDOM): (WebCore::SecurityOrigin::allowsAccessFrom): (WebCore::SecurityOrigin::isSecureTransitionTo):
  • platform/SecurityOrigin.h: Added.

LayoutTests:

Reviewed by Darin.

Update results after changing the warning message in isSafeScript to print the frame URL
rather than the security domain URL. This now also prints the warning when using data:
URLs because we no longer return early.

  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-2-level-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-data-url-sub-frame-to-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-from-javascript-url-window-open-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-from-data-url-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-2-level-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-window-open-expected.txt:
  • http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/javascriptURL/xss-DENIED-from-javascipt-url-in-foreign-domain-window-open-expected.txt:
  • http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-subframe-expected.txt:
  • http/tests/security/javascriptURL/xss-DENIED-to-javascipt-url-in-foreign-domain-window-open-expected.txt:
1:04 PM Changeset in webkit [26779] by kmccullo
  • 9 edits
    3 adds
    2 deletes in trunk/WebKitTools

Reviewed by Adam.

  • Integrated changes from mac drosera. Recently I've encapsulated out the server connection object from the rest of Drosera because it is very platform dependent right now and RPC is not implemented on windows. This functionality, of communicating with the WebKit server is the next area I will be focusing on in Windows.
  • Other changes and cleanup were made to organize the code and add notes on which parts still need work. Also some mac code is added and commented out, to act as pseudocode for the logic of those parts.
  • Drosera/DebuggerDocument.h: Make the ServerConnection live in a smart pointer.
  • Drosera/config.h: Added whitespace.
  • Drosera/win/DebuggerApplication.cpp: Removed. The functionality of these files got moved into Drosera.h/cpp
  • Drosera/win/DebuggerApplication.h: Removed.
  • Drosera/win/DebuggerClient.cpp: Lots of cleanup and restructuring happened here to better match the logic flow of the same code on the mac side and to use the new ServerConnection class. (DebuggerClient::DebuggerClient): Constructor that takes a server name. (DebuggerClient::initWithServerName): Initializer that will set up the class to use a ServerConnection object. This was necessary so I could create a DebuggerClient without having to initilaize it at construction. (DebuggerClient::QueryInterface): Moved from Drosera.cpp, the Client will be the UIDelegate and FrameLoadDelegate. (DebuggerClient::AddRef): For IUnknown. (DebuggerClient::Release): For IUnknown. (DebuggerClient::didFinishLoadForFrame): Part of the FrameLoadDelegate this still needs to set the global context of the server, but IWebFrame does not have an accessor for the global context yet. (DebuggerClient::windowScriptObjectAvailable): Part of FrameLoadDelegate this is a pass through for the same function in the document. (DebuggerClient::didReceiveTitle): Unimplemented part of FrameLoadDelegate this would change the title of the window. (DebuggerClient::createWebViewWithRequest): Part of the FrameLoadDelegate. This is about new windows via Window.open() and how their delegates are set. (DebuggerClient::runJavaScriptAlertPanelWithMessage): Part of the UIDelegate. Just a debug function for printing messages.
  • Drosera/win/DebuggerClient.h: Moved functionality from Drosera.h because the Client should be the UIDelegate and FrameLoadDelegate to match the delegates on mac. (DebuggerClient::webViewLoaded): Added accessor method.
  • Drosera/win/DebuggerDocumentPlatform.cpp: Added. I had apperently forgotten to add this file before. This is where the platform dependent versions of the Documents functions live. Most of these are unimplemented because some piece of functionality does not exist on Windows yet. (DebuggerDocument::platformPause): (DebuggerDocument::platformResume): (DebuggerDocument::platformStepInto): (DebuggerDocument::platformEvaluateScript): (DebuggerDocument::getPlatformCurrentFunctionStack): (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed): (DebuggerDocument::platformLog):
  • Drosera/win/Drosera.cpp: Removed UIDelegate and FrameLoadDelegate responsibilities becaue they belong in the Client. Also I laid the groundwork for attaching Drosera to a WebKit process (attachWndProc): Now if a server is selected the Client becomes it's delegate. (Drosera::Drosera): Added the construction of the Client and dictionary of server names. (Drosera::initUI): This is no longer the delegates, the Client is. (Drosera::webViewLoaded): Now asks the Client instead of holding local state. (Drosera::applicationDidFinishLaunching): Placeholder for needed notification registration when it's possible to implement. (Drosera::serverLoaded): Ditto (Drosera::serverUnloaded): Ditto (Drosera::attach): Attach Drosera to the WebKit server.
  • Drosera/win/Drosera.h: Ditto for Drosera.cpp comment. (Drosera::getInst): (Drosera::setInst): (Drosera::knownServers):
  • Drosera/win/Drosera.vcproj/Drosera.vcproj: Removed DebuggerApplication and added the ServerConnection.
  • Drosera/win/DroseraPrefix.h: Added an ifndef check.
  • Drosera/win/ServerConnection.cpp: Added. This is the interesting part Most of the functions are completely unimlemented because they cannot connect with the WebKit server, because one does not exist on Windows yet. (ServerConnection::initWithServerName): (ServerConnection::~ServerConnection): (ServerConnection::setGlobalContext): (ServerConnection::pause): (ServerConnection::resume): (ServerConnection::stepInto): (ServerConnection::switchToServerNamed): (ServerConnection::applicationTerminating): (ServerConnection::serverConnectionDidDie): (ServerConnection::currentFrame):
  • Drosera/win/ServerConnection.h: Added. Ditto. (ServerConnection::ServerConnection):
11:12 AM Changeset in webkit [26778] by aliceli1
  • 1 edit in trunk/WebKitTools/ChangeLog

Reviewed by Darin.

Fix for these broken layout tests on Windows:


fast/forms/focus-selection-input.html
fast/forms/focus-selection-textarea.html
fast/forms/select-accesskey.html


  • DumpRenderTree/win/EventSender.cpp: (keyDownCallback): correct the VK code for alt key.
11:05 AM Changeset in webkit [26777] by aliceli1
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

  • DumpRenderTree/win/EventSender.cpp: (keyDownCallback): correct the VK code for alt key.
10:51 AM Changeset in webkit [26776] by sullivan
  • 2 edits in trunk/WebKit

Reviewed by Tim Hatcher


  • fixed <rdar://problem/5540325> REGRESSION (2.0.4-3): History menu looks odd after clearing history
  • History/WebHistory.mm: (-[WebHistoryPrivate removeAllItems]): This was fallout from r25275. We need to clear the orderedLastVisitedDays cache here, in addition to the other places where it's cleared.
10:33 AM Changeset in webkit [26775] by mitz
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Sam Weinig.

removing a commented-out test and a test that no longer fails

  • platform/mac-leopard/Skipped:
10:14 AM Changeset in webkit [26774] by ddkilzer
  • 2 edits
    1 copy in trunk/LayoutTests

LayoutTests:

Reviewed by Darin.

Provide the functionality of js-test-post.js in a function named isSuccessfullyParsed().

  • fast/encoding/char-encoding.html: Updated to use js-test-post-function.js instead of local hack.
  • fast/js/resources/js-test-post-function.js: Copied from LayoutTests/fast/js/resources/js-test-post.js. Modified to create isSuccessfullyParsed() function.
8:13 AM Changeset in webkit [26773] by hausmann
  • 4 edits in trunk

Fix the Qt/Windows build: Added missing FontSelector.h include and re-order moc inclusion.

7:46 AM Changeset in webkit [26772] by hausmann
  • 2 edits in trunk/WebCore

Qt/Windows build fix: Threading.h uses int32_t but doesn't include stdint.h.

7:14 AM Changeset in webkit [26771] by hausmann
  • 2 edits in trunk/JavaScriptCore

Fix compilation on Windows when wchar_t is a typedef instead of a native type (triggered by -Zc:wchar_t-).
Don't provide the wchar_t overloads then as they conflict with the unsigned short ones.

4:28 AM Changeset in webkit [26770] by hausmann
  • 2 edits in trunk/JavaScriptCore

Another build fix for the windows/qt build: Apply the same fix as in revision 26686 also to kjs/config.h to disable the disallowctype feature.

4:12 AM Changeset in webkit [26769] by hausmann
  • 3 edits in trunk/WebKit/qt

Fix the windows/qt build by including config.h first to fix wtf/MathExtras.h inclusion.

3:38 AM Changeset in webkit [26768] by hausmann
  • 2 edits in trunk/WebCore

Fix the qt/windows build.

1:58 AM Changeset in webkit [26767] by eseidel
  • 2 edits in trunk/WebKitTools

2007-10-19 Eric Seidel <​eric@webkit.org>

Reviewed by Mark Rowe.


Make the GtkLauncher code slightly more readable.

  • GtkLauncher/main.cpp: (setupMainMenu): Added. (setupMainWindowUI): Added. (main):
1:01 AM Changeset in webkit [26766] by mjs
  • 2 edits in trunk/WebKitTools

Rubber stamped by Adam.


  • don't delay-load WebKit in DumpRenderTree.
  • DumpRenderTree/win/DumpRenderTree.vcproj:
12:44 AM Manual Testing created by oliver@apple.com
Random manual tests

Oct 18, 2007:

10:10 PM Changeset in webkit [26765] by sfalken
  • 1 copy in tags/Safari-523.12.3b

New tag.

10:10 PM Changeset in webkit [26764] by sfalken
  • 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

10:09 PM Changeset in webkit [26763] by sfalken
  • 2 edits in branches/Safari-3-branch/JavaScriptCore

Merged fix from r26760.

7:45 PM Changeset in webkit [26762] by mitz
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Mark Rowe.

removing tests that no longer fail

  • platform/mac-leopard/Skipped:
7:19 PM Changeset in webkit [26761] by justing
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Kevin McCullough.

<rdar://problem/5483526>
GoogleDocs: A hang occurs when applying list styling to a selection containing a table and line breaks

  • editing/TextIterator.cpp: (WebCore::TextIterator::exitNode): For selection preservation, we must emit a character between every VisiblePosition. We weren't emitting a space after some tables, because we won't try to emit a space if shouldEmitNewlineAFterNode is true, even if no newline was emitted.

LayoutTests:

Reviewed by Kevin McCullough.


<rdar://problem/5483526>
GoogleDocs: A hang occurs when applying list styling to a selection containing a table and line breaks


Demonstrates fix for the hang:

  • editing/execCommand/5483526-expected.txt: Added.
  • editing/execCommand/5483526.html: Added.


Fixed selection endpoint (problems with selection painting prevent this
from being reflected in the pixel test results):

  • platform/mac/editing/execCommand/5432254-2-expected.txt:
7:14 PM Changeset in webkit [26760] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adam.


  • use declspec(thread) for fast thread-local storage on Windows


  • 2.2% speedup on sunspider (on Windows)
  • 7% speedup on the string section
  • 6% speedup on JS iBench


  • fixed <rdar://problem/5473084> PLT on Windows got 2.5% slower between r25406 and r25422
  • fixed at least some of <rdar://5527965? i-Bench JS was 14% slower in 310A11 than 310A10



  • wtf/FastMalloc.cpp: (WTF::getThreadHeap): (WTF::setThreadHeap): (WTF::TCMalloc_ThreadCache::GetCache): (WTF::TCMalloc_ThreadCache::GetCacheIfPresent): (WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):
5:49 PM Changeset in webkit [26759] by mitz
  • 2 edits in trunk/WebKit

Tiger build fix.

  • WebView/WebDataSource.mm: (-[WebDataSource _MIMETypeOfResponse:]):
5:33 PM Changeset in webkit [26758] by mitz
  • 13 edits in trunk

WebCore:

Reviewed by Adam Roben.

  • fix <rdar://problem/5313523> REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::doUpdateResourceResponse): Work around <rdar://problem/5321972> by testing for the case of a response with a MIME type of application/octet-stream and a Content-Type header starting with text/plain and setting the MIME type to text/plain in that case.

WebKit:

Reviewed by Adam Roben.

  • fix <rdar://problem/5313523> REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::makeDocumentView): Changed to use _responseMIMEType.
  • WebView/WebDataSource.mm: (-[WebDataSource _MIMETypeOfResponse:]): Added. Works around <rdar://problem/5321972> by testing for the case of an NSHTTPURLResponse with a MIMEType of application/octet-stream and a Content-Type header starting with text/plain and returning text/plain as the MIME type in that case. (-[WebDataSource _responseMIMEType]): Added. Used to get the correct response MIME type. (-[WebDataSource _isDocumentHTML]): Changed to use _responseMIMEType. (-[WebDataSource _makeRepresentation]): Ditto. (-[WebDataSource mainResource]): Ditto. (-[WebDataSource subresources]): Changed to use _MIMETypeOfResponse and pass the MIME type explicitly. (-[WebDataSource subresourceForURL:]): Ditto.
  • WebView/WebDataSourcePrivate.h:
  • WebView/WebFrameView.mm: (-[WebFrameView _makeDocumentViewForDataSource:]): Changed to use _responseMIMEType.
  • WebView/WebResource.mm: (-[WebResource _initWithData:URL:response:MIMEType:]): Changed this method to take a MIME type instead of extracting it from the response, so that WebDataSource could pass the correct MIME type.
  • WebView/WebResourcePrivate.h:

WebKitTools:

Reviewed by Adam Roben.

  • fix <rdar://problem/5313523> REGRESSION(Leopard): http/tests/incremental/slow-utf8-text.pl fails on Leopard
  • DumpRenderTree/mac/DumpRenderTree.mm: (dump): Changed to use _responseMIMEType.

LayoutTests:

Reviewed by Adam Roben.

  • removing fixed test
  • platform/mac-leopard/Skipped:
4:11 PM Changeset in webkit [26757] by bdash
  • 2 edits in trunk/WebCore

2007-10-18 Mark Rowe <​mrowe@apple.com>

Fix the no-SVG build.

  • css/CSSPrimitiveValueMappings.h: Move the CSSPrimitiveValue implementations for LineCap, LineJoin and WindRule inside #if ENABLE(SVG).
2:59 PM Changeset in webkit [26756] by darin
  • 5 edits in trunk/WebCore

Reviewed by Anders.

  • some small tweaks to the threading implementation

I had trouble building on Windows. Either the problem went away by itself
or one of these changes fixed it.

  • platform/Threading.h: Eliminated the use of friend, and shared a single declaration for the initializeThreading function.
  • platform/pthreads/ThreadingPthreads.cpp: (WebCore::ThreadCondition::wait): Call impl() here.
  • platform/win/ThreadingWin.cpp: Got rid of two globals here with static constructors. Also added a typedef for the type of the function queue. (WebCore::functionQueueMutex): Added function. (WebCore::functionQueue): Ditto. (WebCore::callFunctionsOnMainThread): Use functions instead of using the globals directly. (WebCore::callOnMainThread): Ditto.
  • css/CSSParser.cpp: Had to touch this file to make things build.
2:35 PM Changeset in webkit [26755] by aroben
  • 2 edits in trunk/WebKit/win

Fix <rdar://5547784> ProgIDMacros.h should explicitly use wide strings

Reviewed by Adele.

  • ProgIDMacros.h: Always use wide strings instead of relying on the TEXT macro.
1:43 PM Changeset in webkit [26754] by sfalken
  • 1 copy in tags/Safari-523.12.2b

New tag.

1:43 PM Changeset in webkit [26753] by sfalken
  • 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

1:29 PM Changeset in webkit [26752] by aroben
  • 3 edits
    1 add in branches/Safari-3-branch/WebCore

Merge r26751

1:26 PM Changeset in webkit [26751] by aroben
  • 3 edits
    1 add in trunk/WebCore

Fix <rdar://5547462> Need to copy Inspector resources in Production builds

I also added an excludes file for the xcopy command to avoid copying
.svn folders.

Reviewed by Geoff.

  • WebCore.vcproj/WebCore.make: Make sure we copy the Inspector resources.
  • WebCore.vcproj/WebCore.vcproj: Pass /exclude:xcopy.excludes to xcopy.
  • WebCore.vcproj/xcopy.excludes: Added.
10:00 AM Changeset in webkit [26750] by darin
  • 4 edits in trunk

WebCore:

Reviewed by Sam.

  • page/DOMWindow.idl: Add ConvertUndefinedOrNullToNullString back for defaultValue.

LayoutTests:

Reviewed by Sam.

  • fast/dom/Window/alert-undefined-expected.txt: Back to expecting empty string for default value.
9:44 AM Changeset in webkit [26749] by zimmermann
  • 2 edits in trunk/WebCore

Build fix. Not reviewed.
Hopefully fix win build by including wtf/MathExtras.h.

9:27 AM Changeset in webkit [26748] by sfalken
  • 1 copy in tags/Safari-523.12.1b

New tag.

9:27 AM Changeset in webkit [26747] by sfalken
  • 1 edit in branches/Safari-3-branch/WebKit/win/WebKit.vcproj/VERSION

Bump versions for submit

9:21 AM Changeset in webkit [26746] by mitz
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Nikolas Zimmermann.

Test: fast/text/word-break-soft-hyphen.html

  • rendering/RenderText.cpp: (WebCore::RenderText::calcPrefWidths): Changed to treat soft hyphens as word boundaries. This fixes the bug and is consistent with the fact that run rounding does occur at soft hyphens.

LayoutTests:

Reviewed by Nikolas Zimmermann.

  • fast/text/word-break-soft-hyphen.html: Added.
  • platform/mac/fast/text/word-break-soft-hyphen-expected.checksum: Added.
  • platform/mac/fast/text/word-break-soft-hyphen-expected.png: Added.
  • platform/mac/fast/text/word-break-soft-hyphen-expected.txt: Added.
8:19 AM Changeset in webkit [26745] by zimmermann
  • 10 edits in trunk

Reviewed by Anders.

Fix last layout test failure seen on buildbot "trunk-mac-ppc-release".
Problem: "svg/custom/mask-excessive-malloc.svg -> crashed"

Clamp any ImageBuffer allocation within SVG to the RenderView's visibleSize
to avoid excessive mallocs (in the testcase above 1000000x1000000)

2:57 AM Changeset in webkit [26744] by ap
  • 2 edits in trunk/WebCore

Windows build fix.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): Add braces around cases that have local variables now.
1:57 AM Changeset in webkit [26743] by ap
  • 2 edits in trunk/WebCore

Release build fix.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
1:39 AM Changeset in webkit [26742] by ap
  • 8 edits
    1 add in trunk/WebCore

Reviewed by Darin.

Split most of CSSPrimitiveValue enum mapping out of CSSComputedStyleDeclaration::getPropertyCSSValue()
and CSSStyleSelector::applyProperty() (and their SVG counterparts). This should make the code more readable.

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSComputedStyleDeclaration.cpp: (WebCore::getPositionOffsetValue): (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::init):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
  • css/CSSPrimitiveValueMappings.h: Added. (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): (WebCore::CSSPrimitiveValue::operator EBorderStyle): (WebCore::CSSPrimitiveValue::operator CompositeOperator): (WebCore::CSSPrimitiveValue::operator EAppearance): (WebCore::CSSPrimitiveValue::operator EBackgroundBox): (WebCore::CSSPrimitiveValue::operator EBackgroundRepeat): (WebCore::CSSPrimitiveValue::operator EBoxAlignment): (WebCore::CSSPrimitiveValue::operator EBoxDirection): (WebCore::CSSPrimitiveValue::operator EBoxLines): (WebCore::CSSPrimitiveValue::operator EBoxOrient): (WebCore::CSSPrimitiveValue::operator ECaptionSide): (WebCore::CSSPrimitiveValue::operator EClear): (WebCore::CSSPrimitiveValue::operator ECursor): (WebCore::CSSPrimitiveValue::operator EDisplay): (WebCore::CSSPrimitiveValue::operator EEmptyCell): (WebCore::CSSPrimitiveValue::operator EFloat): (WebCore::CSSPrimitiveValue::operator EKHTMLLineBreak): (WebCore::CSSPrimitiveValue::operator EListStylePosition): (WebCore::CSSPrimitiveValue::operator EListStyleType): (WebCore::CSSPrimitiveValue::operator EMarginCollapse): (WebCore::CSSPrimitiveValue::operator EMarqueeBehavior): (WebCore::CSSPrimitiveValue::operator EMarqueeDirection): (WebCore::CSSPrimitiveValue::operator EMatchNearestMailBlockquoteColor): (WebCore::CSSPrimitiveValue::operator ENBSPMode): (WebCore::CSSPrimitiveValue::operator EOverflow): (WebCore::CSSPrimitiveValue::operator EPageBreak): (WebCore::CSSPrimitiveValue::operator EPosition): (WebCore::CSSPrimitiveValue::operator EResize): (WebCore::CSSPrimitiveValue::operator ETableLayout): (WebCore::CSSPrimitiveValue::operator ETextAlign): (WebCore::CSSPrimitiveValue::operator ETextSecurity): (WebCore::CSSPrimitiveValue::operator ETextTransform): (WebCore::CSSPrimitiveValue::operator EUnicodeBidi): (WebCore::CSSPrimitiveValue::operator EUserDrag): (WebCore::CSSPrimitiveValue::operator EUserModify): (WebCore::CSSPrimitiveValue::operator EUserSelect): (WebCore::CSSPrimitiveValue::operator EVisibility): (WebCore::CSSPrimitiveValue::operator EWhiteSpace): (WebCore::CSSPrimitiveValue::operator EWordBreak): (WebCore::CSSPrimitiveValue::operator EWordWrap): (WebCore::CSSPrimitiveValue::operator LineCap): (WebCore::CSSPrimitiveValue::operator LineJoin): (WebCore::CSSPrimitiveValue::operator TextDirection): (WebCore::CSSPrimitiveValue::operator WindRule): (WebCore::CSSPrimitiveValue::operator EAlignmentBaseline): (WebCore::CSSPrimitiveValue::operator EColorInterpolation): (WebCore::CSSPrimitiveValue::operator EColorRendering): (WebCore::CSSPrimitiveValue::operator EDominantBaseline): (WebCore::CSSPrimitiveValue::operator EImageRendering): (WebCore::CSSPrimitiveValue::operator EPointerEvents): (WebCore::CSSPrimitiveValue::operator EShapeRendering): (WebCore::CSSPrimitiveValue::operator ETextAnchor): (WebCore::CSSPrimitiveValue::operator ETextRendering): (WebCore::CSSPrimitiveValue::operator EWritingMode):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkSelector): (WebCore::CSSStyleSelector::checkOneSelector): (WebCore::CSSRuleSet::addRulesFromSheet): (WebCore::convertToLength): (WebCore::CSSStyleSelector::applyDeclarations): (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::mapBackgroundAttachment): (WebCore::CSSStyleSelector::mapBackgroundClip): (WebCore::CSSStyleSelector::mapBackgroundComposite): (WebCore::CSSStyleSelector::mapBackgroundOrigin): (WebCore::CSSStyleSelector::mapBackgroundRepeat): (WebCore::CSSStyleSelector::mapBackgroundXPosition): (WebCore::CSSStyleSelector::mapBackgroundYPosition):
  • ksvg2/css/SVGCSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
  • ksvg2/css/SVGCSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applySVGProperty):
1:01 AM Changeset in webkit [26741] by mjs
  • 3 edits in trunk/SunSpider

Reviewed by Eric.


  • Support Windows and Windows browsers.
  • hosted/sunspider-results.html: Display results correctly in IE.
  • sunspider: tweaks to work on Windows, and with spaces in the path.
12:30 AM Changeset in webkit [26740] by eseidel
  • 6 edits
    2 adds in trunk

2007-10-18 Eric Seidel <​eric@webkit.org>

Reviewed by Maciej.

Fix crashers in SVGViewSpec::parseViewSpec
​http://bugs.webkit.org/show_bug.cgi?id=15504

Test is blocked by bug 15503, landed as:

  • svg/dom/viewspec-parser.html-disabled
  • bindings/scripts/CodeGeneratorObjC.pm: support classes where all parents are interfaces
  • ksvg2/svg/SVGViewSpec.cpp: (WebCore::SVGViewSpec::parseViewSpec):
  • ksvg2/svg/SVGViewSpec.idl: Added.
12:27 AM Changeset in webkit [26739] by mjs
  • 2 edits in trunk/SunSpider

Rubber stamped by Oliver.

  • tests/string-tagcloud.js: Remove stray print()
12:17 AM Changeset in webkit [26738] by mjs
  • 2 edits
    3 adds in trunk/SunSpider

Reviewed by Oliver.


Add some string test cases.

  • tests/string-base64.js: Added. Does base64 encoding and decoding.
  • tests/string-tagcloud.js: Added. Parses a JSON string and generates tagcloud HTML markup based on the data.
  • tests/string-unpack-code.js: Added. Unpack compressed versions of four of the most popular JavaScript libraries.
  • tests/LIST: Added the new tests.

Oct 17, 2007:

10:50 PM Changeset in webkit [26737] by aroben
  • 3 edits in branches/Safari-3-branch/WebKitTools

Merge r26733

9:03 PM Changeset in webkit [26736] by sfalken
  • 1 copy in tags/Safari-523.12b

New tag.

9:03 PM Changeset in webkit [26735] by sfalken
  • 2 edits in branches/Safari-3-branch/WebKit/win

Bump versions for submit

8:56 PM Changeset in webkit [26734] by aroben
  • 2 edits in trunk/WebKitTools

Make it possible to have Windows-specific tests and results

When searching for tests to run and the Skipped file, we will only
look in platform/win and the cross-platform directory. When looking
for expected results, we will look in platform/win, then
platform/mac-leopard, then platform/mac, then finally the
cross-platform directory.

Reviewed by Sam.

  • Scripts/run-webkit-tests: (sub expectedDirectoryForTest): Search in mac-leopard and mac before searching in the cross-platform directory. (sub buildPlatformHierarchy): Removed some unneeded calls to dirname/basename.
8:53 PM Changeset in webkit [26733] by aroben
  • 3 edits in trunk/WebKitTools

Add back the call to register WebKit that we had before WebKitInitializer existed

This is needed to ensure that the right WebKit is used when
instantiating COM objects.

Reviewed by Oliver.

  • DumpRenderTree/win/debug_internal.vsprops: Define DEBUG_WEBKIT_HAS_SUFFIX.
  • DumpRenderTree/win/DumpRenderTree.cpp: (initialize):
8:28 PM Changeset in webkit [26732] by darin
  • 4 edits
    1 add in trunk

WebCore:

Reviewed by Darin, Adam, and Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=12988
First element (in document order) is not returned when other duplicate ID-ed elements were created first

Reset the element id cache when an id is added and there is a duplicate for that id.

  • dom/Document.cpp: (WebCore::Document::addElementById):

LayoutTests:

Reviewed by Darin, Adam, and Maciej.

Testcase for:
​http://bugs.webkit.org/show_bug.cgi?id=12988
First element (in document order) is not returned when other duplicate ID-ed elements were created first

  • fast/dom/duplicate-ids-document-order.html: Added.
8:20 PM Changeset in webkit [26731] by aroben
  • 2 edits in branches/Safari-3-branch/WebKitTools

Merge r26730

8:17 PM Changeset in webkit [26730] by aroben
  • 2 edits in trunk/WebKitTools

Import File::Basename in webkitdirs since we use it

Reviewed by NOBODY.

  • Scripts/webkitdirs.pm:
6:07 PM Changeset in webkit [26729] by kmccullo
  • 2 edits in trunk/WebKitTools
  • Updated the tiger leaks list to make the internal bots green.
  • Scripts/run-webkit-tests:
5:18 PM Changeset in webkit [26728] by aroben
  • 2 edits in branches/Safari-3-branch/WebKitTools

Merge r26727

5:15 PM Changeset in webkit [26727] by aroben
  • 2 edits in trunk/WebKitTools

Build fix for VC++ Express

Reviewed by NOBODY.

  • FindSafari/FindSafari.vcproj: Explicitly link against advapi32.lib and ole32.lib.
5:10 PM Changeset in webkit [26726] by aroben
  • 2 edits in trunk/WebCore

Fix an ASSERT on launch on Windows

Fix dictated to me by Brady.

  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::syncThreadMainLoop): Make sure we hold m_syncLock before going into the loop.
4:51 PM Changeset in webkit [26725] by bdash
  • 2 edits in trunk/WebCore

2007-10-17 Mark Rowe <​mrowe@apple.com>

Mac build fix.

  • Configurations/WebCore.xcconfig: Make it possible to include CoreGraphics header files.
4:39 PM Changeset in webkit [26724] by aroben
  • 2 edits in trunk/WebKit/win

Fix for clean builds needed after r26683

Reviewed by NOBODY.

  • WebView.cpp: Remove #include of non-existant file.
4:10 PM Changeset in webkit [26723] by aroben
  • 3 edits in trunk/WebCore

Windows build fix

Reviewed by NOBODY.

  • platform/graphics/AffineTransform.h: Don't #include ApplicationServices.h.
  • platform/graphics/cg/GraphicsContextCG.cpp: Add an #include that's needed now that we're not #including ApplicationServices.h.
3:57 PM Changeset in webkit [26722] by bdash
  • 3 edits
    1 add in trunk/WebCore

2007-10-17 Mark Rowe <​mrowe@apple.com>

Gtk build fix. Move non-pthread stubs from Threading.h to ThreadingNone.cpp to prevent
multiple-definition link errors.

  • WebCore.pro:
  • platform/Threading.h:
  • platform/ThreadingNone.cpp: Added. (WebCore::createThread): (WebCore::waitForThreadCompletion): (WebCore::detachThread): (WebCore::Mutex::Mutex): (WebCore::Mutex::~Mutex): (WebCore::Mutex::lock): (WebCore::Mutex::tryLock): (WebCore::Mutex::unlock): (WebCore::ThreadCondition::ThreadCondition):
3:37 PM Changeset in webkit [26721] by aliceli1
  • 4 edits in trunk/LayoutTests

Rubber-stamped by Adele.

Correct uses of initKeyboardEvent for tests that test accesskey.
Accesskey modifier is ctrl for mac and alt for other platforms.

  • fast/events/access-key-self-destruct.html:
  • fast/forms/access-key.html:
  • fast/forms/legend-access-key.html:
2:25 PM Changeset in webkit [26720] by darin
  • 3 edits
    3 adds in trunk

JavaScriptCore:

Reviewed by Mark Rowe.

Test: fast/js/regexp-non-character.html

  • pcre/pcre_compile.c: (check_escape): Take out the checks for valid characters in the \u sequences -- not needed and actively harmful.

LayoutTests:

Reviewed by Mark Rowe.

  • fast/js/regexp-non-character-expected.txt: Added.
  • fast/js/regexp-non-character.html: Added.
  • fast/js/resources/regexp-non-character.js: Added.
2:24 PM Changeset in webkit [26719] by tristan
  • 6 edits in branches/Safari-2.0-dashboard/WebCore

Fixed merge of r24938 and r24946 by initializing the security policy URL
in the right place. Tests from Aaron Sigel now pass.


<rdar://problem/5471815> [WebKitForDashboard clone] data: URLs can gain access to frames in foreign domains

  • khtml/ecma/kjs_window.cpp: (Window::isSafeScript):
  • khtml/khtml_part.cpp: (KHTMLPart::begin): (KHTMLPart::URL): (KHTMLPart::setOpener):
  • khtml/khtml_part.h:
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::DocumentImpl): (DocumentImpl::initSecurityPolicyURL):
  • khtml/xml/dom_docimpl.h: (DOM::DocumentImpl::securityPolicyURL):
2:15 PM Changeset in webkit [26718] by darin
  • 1 edit in trunk/JavaScriptCore/ChangeLog

Remove stray change marker.

2:13 PM Changeset in webkit [26717] by darin
  • 1 edit in trunk/WebCore/ChangeLog

Remove stray merge marker.

2:05 PM Changeset in webkit [26716] by andersca
  • 10 edits
    2 adds in trunk

JavaScriptCore:

Reviewed by Oliver.

  • wtf/Platform.h: #define USE_PTHREADS on Mac.

WebCore:

Reviewed by Oliver.

  • WebCore.xcodeproj/project.pbxproj:
  • WebCore.vcproj/WebCore.vcproj:


  • config.h: #define USE_PTHREADS on Windows.


  • loader/icon/IconDatabase.cpp: (WebCore::IconDatabase::getOrCreateIconRecord): (WebCore::IconDatabase::getOrCreatePageURLRecord): Update for mutex changes.


  • platform/Threading.h: (WebCore::): (WebCore::ThreadSafeShared::ThreadSafeShared): (WebCore::ThreadSafeShared::ref): (WebCore::ThreadSafeShared::deref): (WebCore::ThreadSafeShared::hasOneRef): (WebCore::ThreadSafeShared::refCount): (WebCore::ThreadSafeShared::isThreadSafe): Add a new Shared base class that uses a mutex to manage its refcount.


(WebCore::createThread):
(WebCore::waitForThreadCompletion):
(WebCore::detachThread):
New functions for thread creation.


(WebCore::Mutex::Mutex):
(WebCore::Mutex::~Mutex):
(WebCore::Mutex::lock):
(WebCore::Mutex::tryLock):
(WebCore::Mutex::unlock):
Move the definitions to ThreadingPthreads.cpp


(WebCore::ThreadCondition::ThreadCondition):
(WebCore::ThreadCondition::~ThreadCondition):
(WebCore::ThreadCondition::wait):
(WebCore::ThreadCondition::signal):
(WebCore::ThreadCondition::broadcast):
Move the definitions to ThreadingPthreads.cpp


  • platform/pthreads: Added.
  • platform/pthreads/ThreadingPthreads.cpp: Added. Add pthread specific implementation of the thread creation functions, Mutex and ThreadCondition.

win:

Update for locking primitive changes.

  • WebIconDatabase.cpp: (WebIconDatabase::scheduleNotificationDelivery):
2:01 PM Changeset in webkit [26715] by ggaren
  • 8 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.


Merged DeclaredFunctionImp into FunctionImp (the base class) because
the distinction between the two was unused.


Removed codeType() from FunctionImp because FunctionImp and its
subclasses all returned FunctionCode, so it was unused, practically
speaking.


Removed a different codeType() from GlobalFuncImp because it was unused.
(Perhaps it was vestigial from a time when GlobalFuncImp used to
inherit from FunctionImp.)

  • bindings/runtime_method.cpp:
  • bindings/runtime_method.h:
  • kjs/function.cpp: (KJS::): (KJS::FunctionImp::FunctionImp): (KJS::FunctionImp::callAsFunction): (KJS::FunctionImp::construct): (KJS::FunctionImp::execute): (KJS::FunctionImp::processVarDecls):
  • kjs/function.h: (KJS::FunctionImp::implementsConstruct): (KJS::FunctionImp::scope):
  • kjs/function_object.cpp: (FunctionProtoFunc::callAsFunction): (FunctionObjectImp::construct):
  • kjs/nodes.cpp: (FuncDeclNode::processFuncDecl): (FuncExprNode::evaluate):
1:29 PM Changeset in webkit [26714] by aroben
  • 2 edits
    1 add in branches/Safari-3-branch/WebKitTools

Merge r26708

1:29 PM Changeset in webkit [26713] by aroben
  • 13 edits
    6 deletes in branches/Safari-3-branch

Merge r26707

1:29 PM Changeset in webkit [26712] by aroben
  • 4 edits
    3 adds in branches/Safari-3-branch

Merge r26706

1:28 PM Changeset in webkit [26711] by aroben
  • 18 edits in branches/Safari-3-branch

Merge r26684

1:28 PM Changeset in webkit [26710] by hyatt
  • 9 edits in trunk/WebCore

Add support for creating a layer when a transform is in effect. Add support to RenderStyle for
handing back a computed AffineTransform.

Reviewed by Mitz Pettel

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::adjustRenderStyle):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::requiresLayer): (WebCore::RenderObject::setStyle):
  • rendering/RenderObject.h: (WebCore::RenderObject::hasTransform): (WebCore::RenderObject::setHasTransform):
  • rendering/RenderStyle.cpp: (WebCore::RenderStyle::applyTransform):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::hasTransform):
  • rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::requiresLayer):
  • rendering/RenderTableRow.h: (WebCore::RenderTableRow::requiresLayer):
1:24 PM Changeset in webkit [26709] by darin
  • 2 edits in trunk/WebKit

Reviewed by Mark Rowe.

  • fix <rdar://problem/5183775> Uninitialized memory in -[WebDynamicScrollBarsView updateScrollers]
  • WebView/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): Change code path so it doesn't dispatch a method that returns an NSSize passing a nil object. It's safe to do that for functions that return integers or pointers, but not structures.
1:12 PM Changeset in webkit [26708] by aroben
  • 2 edits
    1 add in trunk/WebKitTools

Add a new nightly launcher script for Windows

This new script is for versions of Safari that don't delay-load
WebKit. I had to make FindSafari be able to print out the nightly
launcher script on stdout because Windows shell scripts can't capture
the output from a command into an environment variable.

Reviewed by Steve.

  • FindSafari/FindSafari.cpp: (_tmain): Added /printSafariLauncher option.
  • Scripts/run-webkit-nightly.cmd: Added.
1:12 PM Changeset in webkit [26707] by aroben
  • 13 edits
    6 deletes in trunk

Stop delay-loading WebKit in DRT and teskjs

JavaScriptCore:

Make testkjs not delay-load WebKit

Soon, delay-loading WebKit will be impossible (because we will be
using declspec(thread) for thread-local storage). This change
prepares testkjs for the future.

Reviewed by Sam.

  • JavaScriptCore.vcproj/JavaScriptCore.sln: Removed WebKitInitializer, added FindSafari.
  • JavaScriptCore.vcproj/testkjs/testkjs.vcproj: Don't link against WebKitInitializer, don't delay-load WebKit.
  • kjs/testkjs.cpp: Don't use WebKitInitializer.

WebKitTools:

Replace WebKitInitializer with FindSafari

We now rely on setting the PATH environment variable to tell Windows
where to find WebKit and its dependencies (similar to
DYLD_FRAMEWORK_PATH on Mac).

This change also make DumpRenderTree no longer delay-load WebKit.

Reviewed by Sam.

  • DumpRenderTree/DumpRenderTree.sln: Removed WebKitInitializer, added FindSafari.
  • DumpRenderTree/win/DumpRenderTree.cpp: Don't use WebKitInitializer.
  • DumpRenderTree/win/DumpRenderTree.vcproj: Don't link against WebKitInitializer, don't delay-load WebKit.
  • Scripts/run-javascriptcore-tests: Call setPathForRunningWebKitApp.
  • Scripts/run-webkit-tests: Ditto.
  • Scripts/webkitdirs.pm: (sub setPathForRunningWebKitApp): Added.
  • WebKitInitializer/WebKitInitializer.cpp: Removed.
  • WebKitInitializer/WebKitInitializer.h: Removed.
  • WebKitInitializer/WebKitInitializer.vcproj: Removed.
  • WebKitInitializer/debug.vsprops: Removed.
  • WebKitInitializer/debug_internal.vsprops: Removed.
  • WebKitInitializer/release.vsprops: Removed.

WebKit/win:

Remove WebKitInitializer

Reviewed by Sam.

  • WebKit.vcproj/WebKit.sln:
1:11 PM Changeset in webkit [26706] by aroben
  • 4 edits
    3 adds in trunk

Fix Bug 15532: run-safari fails if Safari is installed in a non-default location

WebKitTools:

Fix Bug 15532: run-safari fails if Safari is installed in a non-default location

​http://bugs.webkit.org/show_bug.cgi?id=15532

FindSafari simply prints the location of an installed Safari.exe on
stdout.

Reviewed by Darin.

  • FindSafari/FindSafari.cpp: Copied from WebKitTools/WebKitInitializer/WebKitInitializer.cpp. (getStringValue): (getWebViewCLSID): (getInstalledWebKitDirectory): (_tmain):
  • FindSafari/FindSafari.vcproj: Added.
  • Scripts/webkitdirs.pm: (sub installedSafariPath): Added. Calls FindSafari on Windows.

WebKit/win:

Add FindSafari

Reviewed by Darin.

  • WebKit.vcproj/WebKit.sln:
12:47 PM Changeset in webkit [26705] by hyatt
  • 8 edits in trunk/WebCore

Add support for mapping of the transform CSS property into RenderStyles. Everything is now ready for the front
end to use.

Reviewed by Mitz Pettel

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty):
  • css/CSSTransformValue.h: (WebCore::CSSTransformValue::type): (WebCore::CSSTransformValue::values):
  • platform/graphics/AffineTransform.cpp: (WebCore::AffineTransform::skew):
  • platform/graphics/AffineTransform.h:
  • rendering/RenderStyle.cpp: (WebCore::StyleTransformData::StyleTransformData): (WebCore::StyleTransformData::operator==): (WebCore::StyleTransformData::transformDataEquivalent):
  • rendering/RenderStyle.h: (WebCore::TransformOperation::~TransformOperation): (WebCore::TransformOperation::operator!=): (WebCore::TransformOperation::isScaleOperation): (WebCore::TransformOperation::isRotateOperation): (WebCore::TransformOperation::isSkewOperation): (WebCore::TransformOperation::isTranslateOperation): (WebCore::TransformOperation::isMatrixOperation): (WebCore::ScaleTransformOperation::ScaleTransformOperation): (WebCore::ScaleTransformOperation::isScaleOperation): (WebCore::ScaleTransformOperation::operator==): (WebCore::ScaleTransformOperation::apply): (WebCore::RotateTransformOperation::RotateTransformOperation): (WebCore::RotateTransformOperation::isRotateOperation): (WebCore::RotateTransformOperation::operator==): (WebCore::RotateTransformOperation::apply): (WebCore::SkewTransformOperation::SkewTransformOperation): (WebCore::SkewTransformOperation::isSkewOperation): (WebCore::SkewTransformOperation::operator==): (WebCore::SkewTransformOperation::apply): (WebCore::TranslateTransformOperation::TranslateTransformOperation): (WebCore::TranslateTransformOperation::isTranslateOperation): (WebCore::TranslateTransformOperation::operator==): (WebCore::TranslateTransformOperation::apply): (WebCore::MatrixTransformOperation::MatrixTransformOperation): (WebCore::MatrixTransformOperation::isMatrixOperation): (WebCore::MatrixTransformOperation::operator==): (WebCore::MatrixTransformOperation::apply): (WebCore::StyleTransformData::operator!=): (WebCore::RenderStyle::transform): (WebCore::RenderStyle::setTransform): (WebCore::RenderStyle::initialTransform):
12:30 PM Changeset in webkit [26704] by aroben
  • 6 edits in trunk

Windows build fix part 2.

JavaScriptCore:

Windows build fix part 2.

Fix was by Darin, reviewed by Anders and Adam.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Add FastMallocPCRE.cpp to the project, and let Visual Studio have its way with the post-build step.
  • pcre/pcre.h: Don't DLL export the entry points just because this is Win32 -- this is an internal copy of PCRE and should be private.
  • pcre/pcre_compile.c: Fix an uninitialized variable warning -- there's no real problem but it's better to quiet the compiler by tweaking the code slightly than turn off the warning entirely.

WebCore:

  • page/Frame.cpp: I had to touch this file when fixing the Windows build. Checking it in in case it helps others, too.
11:33 AM Changeset in webkit [26703] by eseidel
  • 2 edits in trunk/WebCore

2007-10-17 Eric Seidel <​eric@webkit.org>

Reviewed by Mark Rowe.


Remove a couple more uses of svg_dynamic_cast.

No functional changes, no tests.

  • ksvg2/svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::buildPattern):
11:05 AM Changeset in webkit [26702] by bdash
  • 2 edits in trunk/WebCore

2007-10-17 Mark Rowe <​mrowe@apple.com>

Reviewed by Eric and Geoff.

<rdar://problem/5453743> Repro ASSERT in CachedResource::setEncodedSize() loading image in background tab
​http://bugs.webkit.org/show_bug.cgi?id=15191

  • loader/DocLoader.cpp: (WebCore::DocLoader::setAutoLoadImages): Don't start a load if the CachedImage is already loading.
10:54 AM Changeset in webkit [26701] by aroben
  • 3 edits in trunk/JavaScriptCore

Windows build fix.

Reviewed by Anders.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Disable some mismatched signed/unsigned comparison warnings.
  • pcre/pcre_exec.c: (match): #if-out some labels that don't seem to exist.
10:51 AM Changeset in webkit [26700] by justing
  • 5 edits
    4 adds in trunk

WebCore:

Reviewed by Harrison.


<rdar://problem/5481523>
GoogleDocs: Safari hangs when indenting a particular table twice


Fixed by fixing problems with the selection preservation done by IndentOutdentCommand.
It is now more difficult to create selections that cause hangs. Those are covered by:
<rdar://problem/5543472>

  • editing/IndentOutdentCommand.cpp: (WebCore::indexForVisiblePosition): Compute indices from the first VisiblePosition in the document, instead of the first Position. Use rangeCompliantEquivalents when creating the Range that we pass to rangeLength. Tell TextIterator::rangeLength that we're doing selection preservation, so that it will emit characters between all VisiblePositions. (WebCore::IndentOutdentCommand::indentRegion): Fixed a bug where the range and location passed to rangeFromLocationAndLength were reversed. Tell rangeFromLocationAndLength that we're doing doing selection preservation, as above.
  • editing/TextIterator.cpp: (WebCore::CharacterIterator::CharacterIterator): (WebCore::TextIterator::rangeLength): Rename emitSpacesForReplacedElements to forSelectionPreservation, to match the name of the boolean inside TextIterator and to match its meaning after r25522. (WebCore::TextIterator::rangeFromLocationAndLength): Ditto.

LayoutTests:

Reviewed by Harrison.

<rdar://problem/5481523>
GoogleDocs: Safari hangs when indenting a particular table twice

  • editing/execCommand/5481523.html: Added.
  • platform/mac/editing/execCommand/5481523-expected.checksum: Added.
  • platform/mac/editing/execCommand/5481523-expected.png: Added.
  • platform/mac/editing/execCommand/5481523-expected.txt: Added.
12:45 AM Changeset in webkit [26699] by bdash
  • 3 edits in trunk/JavaScriptCore

2007-10-17 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

  • JavaScriptCore.pri: Add FastMallocPCRE.cpp.
  • pcre/pcre_get. #if out two functions that depend on pcre_get_stringnumber, which is currently unavailable for UTF-16.
12:12 AM Changeset in webkit [26698] by mjs
  • 4 edits
    3 adds in trunk/SunSpider

Reviewed by Anders.

  • TODO: Updated with info on how to do the stats properly.
  • hosted/sunspider-driver.html: Reduce timeout from 500 to 200 to avoid overly slowing down the benchmark.

Added some 3D-related test cases.


  • tests/3d-cube.js: Added.
  • tests/3d-morph.js: Added.
  • tests/3d-raytrace.js: Added.
  • tests/LIST:
Note: See TracTimeline for information about the timeline view.