Timeline



Nov 6, 2007:

11:23 PM Changeset in webkit [27503] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Eric.


  • only collect when the heap is full, unless we have lots of extra cost garbage


1.1% SunSpider speedup.


This shouldn't hit memory use much since the extra space in those
blocks hangs around either way.

  • kjs/collector.cpp: (KJS::Collector::heapAllocate): (KJS::Collector::collect): Fix logic error that reversed the sense of collect's return value.
11:00 PM Changeset in webkit [27502] by aroben
  • 1 edit
    1 move in trunk/LayoutTests

Move a Mac-specific test to platform/mac

  • editing/pasteboard/5583362.html: Removed.
  • platform/mac/editing/pasteboard/5583362.html: Added.
10:03 PM Changeset in webkit [27501] by oliver
  • 3 edits in trunk/JavaScriptCore

Avoid unnecessarily boxing the result from post inc/decrement for 0.3% gain in sunspider

Reviewed by Maciej

We now convert the common 'for (...; ...; <var>++) ...' to the semantically identical
'for (...; ...; ++<var>) ...'.

9:44 PM JavaScript performance improvement ideas edited by eric@webkit.org
(diff)
9:41 PM Changeset in webkit [27500] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2007-11-06 Eric Seidel <​eric@webkit.org>

  • Scripts/build-testkjs: build fix... too many $$
9:31 PM Changeset in webkit [27499] by bdakin
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by Sam.

<rdar://problem/5575812> REGRESSION:When using absolute positioning
with overflow:auto div, WebKit seems to add an additional 15px

  • rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockWidthForPositioned): We need to subtract off the vertical scrollbar width too.

LayoutTests:

Reviewed by Sam.

New test for <rdar://problem/5575812> REGRESSION:When using
absolute positioning with overflow:auto div, WebKit seems to add an
additional 15px

  • fast/overflow/overflow-auto-position-absolute.html: Added.
  • platform/mac/fast/overflow/overflow-auto-position-absolute-expected.checksum: Added.
  • platform/mac/fast/overflow/overflow-auto-position-absolute-expected.png: Added.
  • platform/mac/fast/overflow/overflow-auto-position-absolute-expected.txt: Added.


Test with changed results. The measurements in the rtl example now
more closely mirror the ltr example.

  • platform/mac/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
9:29 PM Changeset in webkit [27498] by aroben
  • 5 edits in trunk/WebKit/win

Change WebLocalizableStrings to take UTF-8 C strings

This matches the way things work on the Mac, and will allow source
files containing localizable strings to be shared between Mac and
Windows. The old functions have not been removed for compatibility
reasons, but are now just wrappers around the new UTF-8 functions.

Reviewed by Ada.

  • WebKit.vcproj/WebKit.def: Added new functions.
  • WebKit.vcproj/WebKit_debug.def: Ditto.
  • WebLocalizableStrings.cpp: (copyLocalizedStringFromBundle): Changed to take a WebCore::String representing the key. (localizedString): Refactored from WebLocalizedString. Takes a WebCore::String representing the key. (localizedLPCTSTR): Ditto for WebLocalizedLPCTSTR. (WebLocalizedStringUTF8): Added. Takes a UTF-8 C string as the key. (WebLocalizedLPCTSTRUTF8): Ditto. (WebLocalizedString): Changed to call localizedString. (WebLocalizedLPCTSTR): Changed to call localizedLPCTSTR.
  • WebLocalizableStrings.h: Changed macros to use the new UTF-8 functions.
9:24 PM Changeset in webkit [27497] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

2007-11-06 Eric Seidel <​eric@webkit.org>

Reviewed by Mark Rowe.

  • Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
9:00 PM JavaScript performance improvement ideas edited by eric@webkit.org
(diff)
7:01 PM Changeset in webkit [27496] by mrowe@apple.com
  • 2 edits
    24 moves
    1 add in trunk/WebKit

Move Mac files from WebKit into WebKit/mac.

5:13 PM Changeset in webkit [27495] by justing
  • 3 edits
    5 adds in trunk

WebCore:

Reviewed by Dan Bernstein.


<rdar://problem/5583387> ASSERTION FAILED: !refChild->hasTagName(bodyTag) when pasting newline in plain text into rich text Mail
<rdar://problem/5583362> REGRESSION (5523.10.3-TOT): Newlines stripped when pasting plain text in Mail

  • editing/markup.cpp: (WebCore::createFragmentFromText): Put paragraphs of text into clones of the block that encloses the input context, unless that block is the body, which shouldn't be cloned. In that case, use regular divs, as we did before r27369.

LayoutTests:

Reviewed by Dan Bernstein.

<rdar://problem/5583387> ASSERTION FAILED: !refChild->hasTagName(bodyTag) when pasting newline in plain text into rich text Mail
<rdar://problem/5583362> REGRESSION (5523.10.3-TOT): Newlines stripped when pasting plain text in Mail

  • editing/pasteboard/5583362.html: Added.
  • editing/resources/plaintext-pasteboard-data.dat: Added.
  • platform/mac/editing/pasteboard/5583362-expected.checksum: Added.
  • platform/mac/editing/pasteboard/5583362-expected.png: Added.
  • platform/mac/editing/pasteboard/5583362-expected.txt: Added.
5:03 PM Changeset in webkit [27494] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-11-06 Eric Seidel <​eric@webkit.org>

Reviewed by darin.

This fixes a regressed layout test for string + object


SunSpider claims this was an overall 0.3% speedup, although some individual tests were slower.

  • kjs/nodes.cpp: (KJS::add): remove erroneous "fast path" for string + *
4:17 PM JavaScript performance improvement ideas edited by Darin Adler
(diff)
4:12 PM JavaScript performance improvement ideas edited by eric@webkit.org
(diff)
4:11 PM JavaScript performance improvement ideas edited by eric@webkit.org
(diff)
4:06 PM Changeset in webkit [27493] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

Reviewed by Eric Seidel.


Added toJSNumber, a fast path for converting a JSValue to a JS number,
and deployed it in postfix expressions. In the fast case this
eliminates a call to jsNumber.


0.4% speedup on SunSpider.

  • ChangeLog:
  • kjs/nodes.cpp: (KJS::PostIncResolveNode::evaluate): (KJS::PostIncLocalVarNode::evaluate): (KJS::PostDecResolveNode::evaluate): (KJS::PostDecLocalVarNode::evaluate): (KJS::PostIncBracketNode::evaluate): (KJS::PostDecBracketNode::evaluate): (KJS::PostIncDotNode::evaluate): (KJS::PostDecDotNode::evaluate): (KJS::UnaryPlusNode::evaluate):
  • kjs/value.h: (KJS::JSValue::toJSNumber):
4:04 PM Changeset in webkit [27492] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-11-06 Christian Dywan <​christian@twotoasts.de>

Reviewed by Darin.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=15828
Bug 15828: WebKit GTK include and lib directory is installed in qt4-named directory

  • WebCore.pro: Use sane default install paths for the gtk port.
4:02 PM Changeset in webkit [27491] by mrowe@apple.com
  • 2 edits in trunk/WebKit/gtk

2007-11-06 Rodney Dawes <​dobey@wayofthemonkey.com>

Fix ​http://bugs.webkit.org/attachment.cgi?id=17043&action=view
Bug 15766: [GTK] WebKit sometimes spews binary data as text/plain into iframes

FrameLoaderClient::objectContentType needs to check with the MIMETypeRegistry
to determine whether the given MIME type is displayable as an image or non-image.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (FrameLoaderClient::objectContentType): Change logic to match that in the Windows and Mac ports.
3:19 PM Changeset in webkit [27490] by antti
  • 2 edits in trunk/LayoutTests

Correct test results.

  • platform/mac/fast/layers/layer-visibility-expected.txt:
3:00 PM Changeset in webkit [27489] by antti
  • 5 edits in trunk/LayoutTests

Reviewed by Hyatt.


Update test to cover
<rdar://problem/5521068>
Visibility not propagated correctly for children of a layer with z-index


The fix for this was (accidentally) already checked in with r27277,
with retroactive r=hyatt.

  • fast/layers/layer-visibility.html:
  • platform/mac/fast/layers/layer-visibility-expected.checksum:
  • platform/mac/fast/layers/layer-visibility-expected.png:
  • platform/mac/fast/layers/layer-visibility-expected.txt:
2:28 PM Changeset in webkit [27488] by justing
  • 4 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.


<rdar://problem/5576619>
REGRESSION: Caret disappears after deleting the last character in inline hole (15714)

  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteSelection): Like the other TypingCommands, including both of the other deletion commands, call typingAddedToOpenCommand(), which takes the command's endingSelection and sets it as selection.

LayoutTests:

Reviewed by Darin Adler.


<rdar://problem/5576619> REGRESSION: Caret disappears after deleting the last character in inline hole (15714)

  • platform/mac/editing/input/5576619-expected.checksum: Added.
  • platform/mac/editing/input/5576619-expected.png: Added.
  • platform/mac/editing/input/5576619-expected.txt: Added.
  • platform/mac/editing/input/5576619.html: Added.
  • platform/mac/editing/input/text-input-controller-expected.txt:
1:37 PM Changeset in webkit [27487] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

Reviewed by Maciej.

There was a mistake in the algorithm used to find an empty slot in the property
map entries vector; when we were putting in a new property value and not overwriting
an existing deleted sentinel, we would enlarge the entries vector, but would not
overwrite the stale data that's in the new part. It was easy to pin this down by
turning on property map consistency checks -- I never would have landed with this
bug if I had run the regression tests once with consistency checks on!

  • kjs/property_map.cpp: (KJS::PropertyMap::put): Changed logic for the case where foundDeletedElement is false to always use the item at the end of the entries vector. Also allowed me to merge with the logic for the "no deleted sentinels at all" case.
1:03 PM Changeset in webkit [27486] by mitz@apple.com
  • 4 edits
    6 adds in trunk

WebCore:

Reviewed by Antti Koivisto and Dave Hyatt.

  • fix <rdar://problem/5582961> Incorrect layout and floating object list corruption when CSS decreases a block's height

Test: fast/block/float/overhanging-after-height-decrease.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): If after calculating the height it turns out that there are overhanging floats that were not overhanging before, rescan children with overhanging floats and add them. (WebCore::RenderBlock::layoutBlockChildren): Added a parameter that returns the lowest float bottom of any of the children. (WebCore::RenderBlock::addOverhangingFloats): Changed to return the lowest float bottom.
  • rendering/RenderBlock.h:

LayoutTests:

Reviewed by Antti Koivisto and Dave Hyatt.

  • test for <rdar://problem/5582961> Incorrect layout and floating object list corruption when CSS decreases a block's height
  • fast/block/float/overhanging-after-height-decrease.html: Added.
  • platform/mac-leopard/fast/block: Added.
  • platform/mac-leopard/fast/block/float: Added.
  • platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-expected.checksum: Added.
  • platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-expected.png: Added.
  • platform/mac/fast/block/float/overhanging-after-height-decrease-expected.txt: Added.
11:53 AM Changeset in webkit [27485] by adele
  • 8 edits
    4 adds in trunk

WebCore:

Reviewed by Darin.

Switched all uses of HTMLImageLoader to use OwnPtrs.

  • html/HTMLInputElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::init): (WebCore::HTMLInputElement::~HTMLInputElement): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::attach):
  • html/HTMLObjectElement.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::~HTMLObjectElement): (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::attach):
  • html/HTMLVideoElement.h:
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::HTMLVideoElement): (WebCore::HTMLVideoElement::attach): (WebCore::HTMLVideoElement::detach): (WebCore::HTMLVideoElement::parseMappedAttribute):

LayoutTests:

Reviewed by Darin.

Added test for poster attribute.

  • media/content/abe.png: Added.
  • media/content/greenbox.png: Added.
  • media/video-poster-expected.txt: Added.
  • media/video-poster.html: Added.
11:49 AM Changeset in webkit [27484] by oliver
  • 2 edits in trunk/JavaScriptCore

Fix previous patch to use a 3 bit shift, a 16 bit shift causes a regression in sunspider.

RS=Darin

11:34 AM Changeset in webkit [27483] by oliver
  • 2 edits in trunk/JavaScriptCore

Replace boolean comparisons in AddNode with mask comparisons for a 0.2% improvement in sunspider.

Reviewed by Darin

10:56 AM Changeset in webkit [27482] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-11-06 Eric Seidel <​eric@webkit.org>

Reviewed by darin.


SunSpider claims this is a 1.1% speedup.

  • kjs/nodes.cpp: (KJS::throwOutOfMemoryError): Added, non inline. (KJS::addSlowCase): renamed from add(), non inline. (KJS::add): add fast path for String + String, Number + Number and String + *
10:43 AM Changeset in webkit [27481] by Darin Adler
  • 4 edits in trunk/WebKit/win

Reviewed by Adam and Steve.

  • added hooks needed to implement showModalDialog on Windows
  • Interfaces/IWebUIDelegate.idl: Added canRunModal, createModalDialog, and runModal functions to the end of IWebUIDelegate3.
  • WebChromeClient.h: Added uiDelegate and uiDelegate2 helper functions, so it's easier to write client functions.
  • WebChromeClient.cpp: (WebChromeClient::createWindow): Implemented dialog case. Calls IWebUIDelegate3. (WebChromeClient::canRunModal): Implemented. Calls IWebUIDelegate3. (WebChromeClient::runModal): Ditto. (WebChromeClient::uiDelegate): Added. (WebChromeClient::uiDelegate2): Added. (WebChromeClient::uiDelegate3): Added.
10:11 AM Changeset in webkit [27480] by antti
  • 5 edits
    6 adds in trunk

WebCore:

Reviewed by Darin.


Trigger media load on on src attribute changes as specified in new HTML5 draft.

Tests: media/video-src-change.html

media/video-src-remove.html
media/video-src-set.html

  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged):
  • html/HTMLMediaElement.h:

LayoutTests:

Reviewed by Darin.


Tests for media src attribute changes.

  • media/video-src-change-expected.txt: Added.
  • media/video-src-change.html: Added.
  • media/video-src-remove-expected.txt: Added.
  • media/video-src-remove.html: Added.
  • media/video-src-set-expected.txt: Added.
  • media/video-src-set.html: Added.
  • media/video-test.js:
10:10 AM Changeset in webkit [27479] by ap
  • 2 edits in trunk/WebKit/win

Rubber-stamped by Adam Roben.

Windows build fix.

  • WebFrame.cpp: (WebFrame::string): plainText() returns a String now.
9:48 AM Changeset in webkit [27478] by mitz@apple.com
  • 3 edits
    5 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/repaint/make-children-non-inline.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::makeChildrenNonInline): Repaint the block. This is needed because the inline children may be repositioned as they move into new anonymous blocks, but those blocks have no knowledge of where their children used to be, so they cannot invalidate those areas.

LayoutTests:

Reviewed by Darin Adler.

  • fast/repaint/make-children-non-inline.html: Added.
  • platform/mac/fast/repaint/make-children-non-inline-expected.txt: Added.
  • platform/mac-leopard/fast/repaint: Added.
  • platform/mac-leopard/fast/repaint/make-children-non-inline-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/make-children-non-inline-expected.png: Added.
8:07 AM Changeset in webkit [27477] by ap
  • 10 edits in trunk

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15847
Some editing cleanup

No change in functionality.

WebCore:

  • editing/TextIterator.cpp: (WebCore::plainText):
  • editing/TextIterator.h: Made WebCore::plainText() return String instead of DeprecatedString.
  • bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject textUnderElement]): (-[WebCoreAXObject value]): (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]): (-[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]): (-[WebCoreAXObject doAXPreviousSentenceStartTextMarkerForTextMarker:]): Updated for the above change. There is no need to explicitly convert to NSString now.
  • editing/EditCommand.cpp: (WebCore::EditCommand::EditCommand): m_startingSelection and m_endingSelection are actually initialized in constructor body, so the work done in initializer list was wasted.

(WebCore::EditCommand::apply): Moved some stars.
(WebCore::EditCommand::unapply): Ditto.
(WebCore::EditCommand::reapply): Ditto.
(WebCore::EditCommand::setStartingSelection): The loop exit condition was evaluated twice,
removed one of the checks.

  • editing/SelectionController.cpp: (WebCore::SelectionController::toString): plainText() result type now matches what we need here.
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm: Removed unused -[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:] and -[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:].

WebKit:

  • WebView/WebHTMLView.mm: (-[WebHTMLView deleteToEndOfLine:]): (-[WebHTMLView deleteToEndOfParagraph:]): WebCore had a duplicate of the same logic already. We are passing a boundary value to a function that expects granularity, this may need to be straightened out in the future.
1:08 AM Changeset in webkit [27476] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-11-06 Eric Seidel <​eric@webkit.org>

Reviewed by mjs.


Avoid more UString creation.


SunSpider claims this is a 0.4% speedup.

  • kjs/regexp_object.cpp: (KJS::RegExpObjectImp::construct): use UString::find(UChar)

Nov 5, 2007:

11:47 PM Changeset in webkit [27475] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-11-05 Mark Rowe <​mrowe@apple.com>

Mac build fix.

  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::writeHelper):
11:30 PM Changeset in webkit [27474] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-11-05 Mark Rowe <​mrowe@apple.com>

Mac build fix.

  • kjs/array_object.cpp: (KJS::ArrayProtoFunc::callAsFunction):
11:20 PM Changeset in webkit [27473] by aroben
  • 3 edits in trunk/WebCore

Don't crash if SafariTheme can't be loaded

PlatformScrollBarSafari and RenderThemeSafari were not checking
whether SafariTheme was successfully loaded. All other uses of
SafariTheme already check this.

Reviewed by Steve.

  • platform/win/PlatformScrollBarSafari.cpp: (WebCore::PlatformScrollbar::paintButton): (WebCore::PlatformScrollbar::paintTrack): (WebCore::PlatformScrollbar::paintThumb):
  • rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::isControlStyled): (WebCore::RenderThemeSafari::paintCheckbox): (WebCore::RenderThemeSafari::paintRadio): (WebCore::RenderThemeSafari::paintButton): (WebCore::RenderThemeSafari::paintTextField): (WebCore::RenderThemeSafari::paintCapsLockIndicator): (WebCore::RenderThemeSafari::paintTextArea): (WebCore::RenderThemeSafari::paintMenuList): (WebCore::RenderThemeSafari::paintSliderThumb): (WebCore::RenderThemeSafari::paintSearchField): (WebCore::RenderThemeSafari::paintSearchFieldCancelButton): (WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration): (WebCore::RenderThemeSafari::paintSearchFieldResultsButton):
11:20 PM Changeset in webkit [27472] by aroben
  • 2 edits in trunk/JavaScriptCore

Windows build fix

  • kjs/list.h:
11:09 PM Changeset in webkit [27471] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-11-05 Mark Rowe <​mrowe@apple.com>

Build fix. Add missing #include.

  • kjs/operations.cpp:
10:48 PM Changeset in webkit [27470] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-11-05 Eric Seidel <​eric@webkit.org>

Reviewed by mjs.


Remove another call to toString(exec)


SunSpider claims this is a 0.5% speedup.

  • kjs/operations.cpp: (KJS::equal): remove another toString
10:39 PM Changeset in webkit [27469] by kevino
  • 1 edit
    6 adds in trunk/WebCore

Adding the rest of wx port's graphics impl.

Rubber-stamped by Maciej Stachowiak.

10:24 PM Changeset in webkit [27468] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-11-05 Eric Seidel <​eric@webkit.org>

  • kjs/operations.cpp: (KJS::equal): correct broken change.
10:17 PM Changeset in webkit [27467] by eseidel
  • 2 edits in trunk/JavaScriptCore

2007-11-05 Eric Seidel <​eric@webkit.org>

Reviewed by mjs.

Remove one more call to toString(exec).


SunSpider claims this is a 0.7% speedup.

  • kjs/operations.cpp: (KJS::equal): remove a call to toString()
9:52 PM Changeset in webkit [27466] by kevino
  • 11 edits
    4 adds in trunk/WebCore

wx port bug fixes and new files to get platform/wx building on trunk.

Rubber-stamped by Maciej Stachowiak.

9:43 PM Changeset in webkit [27465] by adele
  • 12 edits in trunk/WebCore

Reviewed by Maciej.

Fix for <rdar://problem/5579999> Add poster attribute for video element

  • html/HTMLAttributeNames.in: Added poster attribute.
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement): Calls imageSourceAttributeName instead of having special cases for the different kinds of elements.
  • dom/Element.cpp: (WebCore::Element::imageSourceAttributeName): Added.
  • dom/Element.h:
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::imageSourceAttributeName): Added.
  • html/HTMLObjectElement.h:
  • html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::movieNetworkStateChanged): Calls updatePosterImage when the network state is empty and when the first frame has been loaded.
  • html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::rendererIsNeeded): Made this inline. HTMLVideoElement now also implements this.
  • html/HTMLVideoElement.idl: Added case for poster attribute.
  • html/HTMLVideoElement.h: Added image loader and flag to keep track of whether or not the poster image should be shown.
  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::HTMLVideoElement): Initialize m_imageLoader and m_shouldShowPosterImage. (WebCore::HTMLVideoElement::rendererIsNeeded): Calls HTMLElement::rendererIsNeeded since HTMLMediaElements have renderer by default. (WebCore::HTMLVideoElement::createRenderer): Create a RenderImage or RenderVideo depending on whether or not the poster image should be shown. (WebCore::HTMLVideoElement::attach): Set up image loader and RenderImage if necessary. (WebCore::HTMLVideoElement::detach): Delete image loader if its no longer needed. (WebCore::HTMLVideoElement::parseMappedAttribute): Added case to process poster attribute. (WebCore::HTMLVideoElement::poster): Added getter for poster attribute. (WebCore::HTMLVideoElement::setPoster): Added setter for poster attribute. (WebCore::HTMLVideoElement::isURLAttribute): Added. (WebCore::HTMLVideoElement::imageSourceAttributeName): Added. (WebCore::HTMLVideoElement::updatePosterImage): Added. Updates m_shouldShowPosterImage and if its changed, detaches and attaches so the renderer is correct.
9:39 PM JavaScript performance improvement ideas edited by mjs@apple.com
(diff)
9:25 PM Changeset in webkit [27464] by aroben
  • 5 edits in trunk

Fix <rdar://5563572> SVG image support is turned off

WebCore:

Fix <rdar://5563572> SVG image support is turned off

Turned on SVG images for all platforms.

Reviewed by Eric.

  • WebCore.vcproj/WebCore.vcproj: Added SVGImage.{cpp,h}
  • loader/CachedImage.cpp: (WebCore::CachedImage::createImage): Removed platform checks for SVGImage.

LayoutTests:

Remove a now-passing test from the Windows Skipped file

Reviewed by Eric.

  • platform/win/Skipped:
8:55 PM Changeset in webkit [27463] by eseidel
  • 2 edits in trunk/WebCore

Fix spelling errors in ChangeLogs, no review

8:43 PM Changeset in webkit [27462] by antti
  • 2 edits in trunk/WebCore

Reviewed by Darin.

QTMovieView can generate callbacks during paint. This can lead to crashes.


Delay callbacks so they get handled after painting is completed. No test case,
I don't know how to reliably reproduce this.

  • platform/graphics/mac/MoviePrivateQTKit.mm: (WebCore::MoviePrivate::MoviePrivate): (WebCore::MoviePrivate::~MoviePrivate): (WebCore::MoviePrivate::paint): (-[WebCoreMovieObserver initWithCallback:WebCore::]): (-[WebCoreMovieObserver disconnect]): (-[WebCoreMovieObserver loadStateChanged:]): (-[WebCoreMovieObserver rateChanged:]): (-[WebCoreMovieObserver sizeChanged:]): (-[WebCoreMovieObserver timeChanged:]): (-[WebCoreMovieObserver volumeChanged:]): (-[WebCoreMovieObserver didEnd:]): (-[WebCoreMovieObserver setDelayCallbacks:]):
8:12 PM Changeset in webkit [27461] by antti
  • 4 edits in trunk/WebCore

Reviewed by Adam.

Add some missing WebCore* prefixes to ObjC classes

  • platform/mac/FileChooserMac.mm: (WebCore::FileChooser::FileChooser):
  • platform/mac/SharedBufferMac.mm: (WebCore::SharedBuffer::createNSData): (WebCore::SharedBuffer::createCFData):
  • platform/mac/SharedTimerMac.cpp: (WebCore::setSharedTimerFireTime):
6:53 PM Changeset in webkit [27460] by alp
  • 3 edits in trunk/WebKit/gtk

2007-11-05 Christian Dywan <​christian@twotoasts.de>

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=15409
FrameLoaderClientGtk hardcodes data, including platform to Linux i686

Compute a proper user agent string.

Patch includes fixes by Alp.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::agentPlatform): (WebKit::agentOS): (WebKit::composeUserAgent): (WebKit::FrameLoaderClient::userAgent):
  • WebCoreSupport/FrameLoaderClientGtk.h:
6:10 PM Changeset in webkit [27459] by adachan
  • 6 edits in trunk

<rdar://problem/5579772> Regression: AltGr does not work
Testing whether alt-key is down is not the right test for system key event.
Added a m_isSystemKey flag in PlatformKeyboardEvent to keep track of whether
this is a system key event, check that flag instead in handleEditingKeyboardEvent().

Reviewed by Oliver.


4:35 PM Changeset in webkit [27458] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-11-05 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

  • pcre/pcre.pri:
4:02 PM Changeset in webkit [27457] by adachan
  • 2 edits in trunk/WebKit/win

Build fix.

Reviewed by Tristan.

  • WebChromeClient.h:
3:56 PM Changeset in webkit [27456] by antti
  • 3 edits in trunk/WebKitLibraries

Reviewed by Sam.


Update WKQTMovieViewSetDrawSynchronously.

  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
3:21 PM Changeset in webkit [27455] by sullivan@apple.com
  • 2 edits in trunk/WebKit
  • WebView/WebView.mm: (-[WebView _searchWithSpotlightFromMenu:]):

Teeny style tweak to test svn access on other machine

3:12 PM Changeset in webkit [27454] by sullivan@apple.com
  • 2 edits in trunk/WebKit
  • WebView/WebView.mm: (-[WebView computedStyleForElement:pseudoElement:]):


Teeny style tweak to test svn access

3:05 PM Changeset in webkit [27453] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-11-05 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

  • kjs/list.cpp:
2:43 PM Changeset in webkit [27452] by tristan
  • 23 edits in trunk

qt:

Reviewed by Darin Adler.

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createWindow):
  • WebCoreSupport/ChromeClientQt.h: Revised to use new WebCore ChromeClient createWindow API.

WebCore:

Reviewed by Darin Adler.

  • WebCore.xcodeproj/project.pbxproj: Set WindowFeatures.h as a Private header.


  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): Revised to use a single createWindow function instead of two createWindow functions and one createModalDialog function. The logic for this is now addressed in WebKit in an effort to make this easier to follow.


  • page/Chrome.cpp: (WebCore::Chrome::createWindow):
  • page/Chrome.h:
  • page/ChromeClient.h:
  • page/ContextMenuController.cpp: (WebCore::openNewWindow):
  • platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::createWindow): Revised to take new additional windowFeatures parameter.

WebKit:

Reviewed by Darin Adler.

  • DefaultDelegates/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:createWebViewWithRequest:windowFeatures:]): Forward the UI delegate to call webView:createWebViewWithRequest: if this method doesn't exist.


  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchCreatePage):
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadPluginRequest:]):
  • WebView/WebView.mm: (-[WebView _openNewWindowWithRequest:]): Revised to use new webView:createWebViewWithRequest:windowFeatures: callback.


  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): Added a new createWindow that accepts 3 parameters, so we can pass up windowFeatures to the chrome. Removed createModalDialog to use new createWindow function.


  • WebView/WebUIDelegatePrivate.h: Added new webView:createWebViewWithRequest:windowFeatures: method.

win:

Reviewed by Darin Adler.


Part of the WebKit/WebCore API changes for
<rdar://problem/5368188>

  • WebChromeClient.cpp: (WebChromeClient::createWindow): Removed usage of createModalDialog and revised to use new createWindow ChromeClient API.
2:02 PM Changeset in webkit [27451] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Touched a file to test my new HTTP access.

  • kjs/scope_chain.cpp:
1:56 PM Changeset in webkit [27450] by ggaren
  • 1 edit
    1 add in trunk/JavaScriptGlue

Build fix.

  • ForwardingHeaders/kjs/value.h: Added.
1:35 PM Changeset in webkit [27449] by alp
  • 2 edits in trunk/JavaScriptCore

2007-11-05 Alp Toker <​alp@atoker.com>

Unreviewed build fix for qmake-based ports.

Someone with a better understanding of qmake still needs to sort out
the INCLUDEPATH/DEPENDPATH mess.

1:27 PM Changeset in webkit [27448] by ggaren
  • 15 edits
    1 add in trunk

JavaScriptCore:

Reviewed by Darin Adler.


​http://bugs.webkit.org/show_bug.cgi?id=15835

Switched List implementation from a custom heap allocator to an inline
Vector, for a disappointing .5% SunSpider speedup.


Also renamed List::slice to List::getSlice because "get" is the
conventional prefix for functions returning a value through an out
parameter.

  • kjs/array_object.cpp: (KJS::ArrayProtoFunc::callAsFunction): Removed some redundant function calls and memory accesses.
  • kjs/bool_object.cpp: (BooleanObjectImp::construct): Removed questionable use of iterator.
  • kjs/list.cpp:
  • kjs/list.h: New List class, implemented in terms of Vector. Two interesting differences:
    1. The inline capacity is 8, not 5. Many of the Lists constructed during a SunSpider run are larger than 5; almost none are larger than 8.
  1. The growth factor is 4, not 2. Since we can guarantee that Lists aren't long-lived, we can grow them more aggressively, to avoid excessive copying.
  • kjs/regexp_object.cpp: (RegExpObjectImp::construct): Removed redundant function calls.
  • kjs/string_object.cpp: (KJS::StringObjectImp::construct): Removed questionable use of iterator.
  • wtf/Vector.h: (WTF::::uncheckedAppend): Added a fast, unchecked version of append.

WebCore:

Reviewed by Darin Adler.


​http://bugs.webkit.org/show_bug.cgi?id=15835

Small adaptations to new KJS::List class.

  • bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): (KJS::ScheduledAction::ScheduledAction):

WebKit:

Reviewed by Darin Adler.


​http://bugs.webkit.org/show_bug.cgi?id=15835

Small adaptations to new KJS::List class.

  • ForwardingHeaders/kjs/value.h: Added.
1:09 PM Changeset in webkit [27447] by mrowe@apple.com
  • 3 edits in trunk/JavaScriptCore

2007-11-05 Mark Rowe <​mrowe@apple.com>

Reviewed by Alp Toker.

Add DEPENDPATH to JavaScriptCore and pcre to help qmake with dependencies.

10:57 AM Changeset in webkit [27446] by aroben
  • 3 edits in trunk/WebKitTools

Add support on Windows for WEBKIT_TESTFONTS

This environment variable lets you specify where the fonts to be used
by DumpRenderTree reside. The Qt port is already using this, so I'm
just following their lead.

Reviewed by Darin.

  • DumpRenderTree/win/DumpRenderTree.cpp: (exePath): Refactored code out of initialize(). (fontsPath): Returns either $WEBKIT_TESTFONTS or DumpRenderTree.resources. (initialize): Use the new fontsPath function. (main): Use the new exePath function.
  • Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment variable to DRT, like Qt does.
10:57 AM Changeset in webkit [27445] by aroben
  • 4 edits in trunk/WebKit/win

Add IWebCache::disabled

This matches the Mac WebCache class.

Reviewed by Sam.

  • Interfaces/IWebCache.idl:
  • WebCache.cpp: (WebCache::disabled):
  • WebCache.h:
10:57 AM Changeset in webkit [27444] by aroben
  • 9 edits
    3 adds in trunk

Add IWebInspector and a way to get one from a WebView

WebCore:

Allow passing a base class pointer to COMPtr::copyRefTo

Reviewed by Sam.

  • platform/win/COMPtr.h:

WebKit/win:

Add IWebInspector and a way to get one from a WebView

This API matches the Mac one added in r27266.

Reviewed by Sam.

  • Interfaces/IWebInspector.idl: Added.
  • Interfaces/IWebViewPrivate.idl: Added a new inspector method to match Mac.
  • WebInspector.cpp: Added. (WebInspector::createInstance): (WebInspector::WebInspector): (WebInspector::~WebInspector): (WebInspector::webViewClosed): (WebInspector::QueryInterface): (WebInspector::AddRef): (WebInspector::Release): (WebInspector::show): (WebInspector::showConsole): (WebInspector::showTimeline): (WebInspector::close): (WebInspector::attach): (WebInspector::detach):
  • WebInspector.h: Added.
  • WebKit.vcproj/Interfaces.vcproj: Added IWebInspector.idl.
  • WebKit.vcproj/WebKit.vcproj: Added WebInspector.{cpp,h}.
  • WebKit.vcproj/WebKitGUID.vcproj: Added IWebInspector_i.c.
  • WebView.cpp: (WebView::close): Notify the WebInspector that we're closing. (WebView::inspector): Added.
  • WebView.h:
10:56 AM Changeset in webkit [27443] by aroben
  • 2 edits in trunk/WebKit/win

Cache strings that come directly from WebLocalizedString

Reviewed by Steve.

  • WebLocalizableStrings.cpp: (copyLocalizedStringFromBundle): This used to be WebLocalizedString, but is now just a static helper function. (findCachedStringInMap): Added static helper. (findCachedString): Refactored and cleaned up code from WebLocalizedLPCTSTR. (cacheString): Ditto. (WebLocalizedString): Rewrote to use the new helper functions. (WebLocalizedLPCTSTR): Changed to use the new helper functions.
10:55 AM Changeset in webkit [27442] by aroben
  • 2 edits in trunk/WebKit/win

Only override the default user agent string if we're actually given a custom one

Reviewed by Sam.

  • WebView.cpp: (WebView::setCustomUserAgent):
10:52 AM Changeset in webkit [27441] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Oliver Hunt.

  • fix ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) when a class attribute is all-whitespace

Test: fast/dom/class-all-whitespace.html

  • dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute): Check if there is any non-whitespace character in the class attribute.

LayoutTests:

Reviewed by Oliver Hunt.

  • test that an all-whitespace class attribute does not cause an assertion failure
  • fast/dom/class-all-whitespace-expected.txt: Added.
  • fast/dom/class-all-whitespace.html: Added.
10:23 AM Changeset in webkit [27440] by beidson@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Sam

Add transaction blocking to the DatabaseAuthorizer in preparation for the new version
of the sql storage API

  • storage/DatabaseAuthorizer.cpp: (WebCore::DatabaseAuthorizer::allowTransaction):
  • storage/DatabaseAuthorizer.h:
8:34 AM Changeset in webkit [27439] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2007-11-05 Mark Rowe <​mrowe@apple.com>

Reviewed by Alp Toker.

Have getMIMETypeForExtension return a null string when no MIME type is known
for the extension rather than returning "text/plain". This prevents plugin data
being dumped into object elements when plugins are disabled.

  • platform/gtk/MIMETypeRegistryGtk.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
7:01 AM Changeset in webkit [27438] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

2007-11-05 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Alp Toker.

Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.

  • GtkLauncher/main.cpp: (goToURLBarText): (main):
6:39 AM Changeset in webkit [27437] by mrowe@apple.com
  • 3 edits in trunk/WebKit/gtk

2007-11-05 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Alp Toker.

Remove unused m_firstData member from FrameLoaderClientGtk.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:
  • WebCoreSupport/FrameLoaderClientGtk.h:
6:39 AM Changeset in webkit [27436] by mrowe@apple.com
  • 2 edits in trunk/WebKit/gtk

2007-11-05 Mark Rowe <​mrowe@apple.com>

Reviewed by Alp Toker.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=15842
Bug 15842: [Gtk] about:blank doesn't work

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::finishedLoading): Set the encoding on the frame loader to get work done that is normally done when the first bit of data is received, even in the case of a document with no data (like about:blank).
6:30 AM Changeset in webkit [27435] by ap
  • 2 edits in trunk/LayoutTests

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15841
fast/dom/Document/early-document-access.html crashes under GuardMalloc

  • fast/dom/Document/early-document-access.html: Don't check for open() timeout; wait for popup window to close as long as it takes.

Nov 4, 2007:

10:38 PM Changeset in webkit [27434] by ddkilzer
  • 2 edits in trunk/WebKitTools

bisect-builds doesn't work with nightly build r19992 or newer on Leopard
<​http://bugs.webkit.org/show_bug.cgi?id=15830>

Reviewed by Timothy.

Restrict the range of nightly builds used by the bisect-builds script
based on the version of Safari and the version of Mac OS X being used.

Mac OS X 10.4: Safari 2.0: r11976 or newer
Mac OS X 10.4: Safari 3.0: r19992 or newer

Mac OS X 10.5: Safari 2.0: r19594 or newer
Mac OS X 10.5: Safari 3.0: r25124 or newer

  • Scripts/bisect-builds: (findMacOSXVersion): Added. (makeNightlyList): Added argument to provide version of Mac OS X. Restrict range of nightly builds based on Safari and Mac OS X versions.
5:37 PM Changeset in webkit [27433] by weinig@apple.com
  • 4 edits in trunk/WebCore

Rubber-stamped by Adam Roben.

Rename SecurityOrigin::allowsAccessFrom to SecurityOrigin::canAccess to
clear up ambiguity.

  • bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):
  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canAccess):
  • platform/SecurityOrigin.h:
4:20 PM Changeset in webkit [27432] by timothy@apple.com
  • 1 edit
    29 adds in trunk/WebKitSite

Land the HTML Editing Toolbar demo from WWDC 2007.

  • demos: Added.
  • demos/editingToolbar: Added.
  • demos/editingToolbar/FancyToolbar.css: Added.
  • demos/editingToolbar/FancyToolbar.js: Added.
  • demos/editingToolbar/FancyToolbarImages: Added.
  • demos/editingToolbar/FancyToolbarImages/button.png: Added.
  • demos/editingToolbar/FancyToolbarImages/buttonLeft.png: Added.
  • demos/editingToolbar/FancyToolbarImages/buttonMiddle.png: Added.
  • demos/editingToolbar/FancyToolbarImages/buttonPressed.png: Added.
  • demos/editingToolbar/FancyToolbarImages/buttonPressedLeft.png: Added.
  • demos/editingToolbar/FancyToolbarImages/buttonPressedMiddle.png: Added.
  • demos/editingToolbar/FancyToolbarImages/buttonPressedRight.png: Added.
  • demos/editingToolbar/FancyToolbarImages/buttonRight.png: Added.
  • demos/editingToolbar/FancyToolbarImages/camera.png: Added.
  • demos/editingToolbar/FancyToolbarImages/link.png: Added.
  • demos/editingToolbar/FancyToolbarImages/textAlign.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutline.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottom.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomLeft.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomRight.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineLeft.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineRight.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineTop.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopLeft.png: Added.
  • demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopRight.png: Added.
  • demos/editingToolbar/content.html: Added.
  • demos/editingToolbar/images: Added.
  • demos/editingToolbar/images/safari.png: Added.
  • demos/editingToolbar/index.html: Added.
4:09 PM Changeset in webkit [27431] by timothy@apple.com
  • 7 edits
    3 adds in trunk/WebCore

Reviewed by Adam.

Bug 15834: There are many subtle bugs in the Styles pane of the Web Inspector
​http://bugs.webkit.org/show_bug.cgi?id=15834

  • Broke up DocumentPanel and added three SidebarPane sub-classes.
  • Fixed many Style pane bugs, including:
    • Poor handling of duplicate properties in the same rule. Some of this can't be fixed since we can't only get the "winning" value for duplicate properties. So we should only show one entry per unique property name.
    • Computed style does not show font shorthand sub-properties if 'font' was used.
    • Property priority was broken, the wrong properties were crossed out.
    • The 'border' shorthand shows null for the shorthand value.
    • Shorthands didn't show their priority (e.g. !important).
    • HSL and HTML hex colors didn't have preview swatch blocks.
    • Code refactoring, making it easier to reuse for console.log later.
  • page/inspector/DocumentPanel.js: Move sidebar pane code to three seperate classes in new files.
  • page/inspector/MetricsSidebarPane.js: Added.
  • page/inspector/Panel.js: Remove an InspectorController.log() call.
  • page/inspector/PropertiesSection.js: Add the section to the TreeOutline. So TreeElements can access properties on their section.
  • page/inspector/PropertiesSidebarPane.js: Added.
  • page/inspector/SidebarPane.js: Remove the explicit asignment of the onexpand and oncollapse to null. These were hiding prototypes.
  • page/inspector/StylesSidebarPane.js: Added.
  • page/inspector/inspector.html: Include the new script files.
  • page/inspector/treeoutline.js: If a null representedObject is passed in just use a empty object.
2:36 PM Changeset in webkit [27430] by kmccullo
  • 9 edits in trunk/WebKitTools

Reviewed by Maciej.

  • This patch involves several changes, all of them were noticed that they were needed by the work being done in WebKit to get Drosera and WebKit working together on Windows.
  • The changes are: 1) Added a debugger console for output messages. 2) Drosera now listens for the WebKit server (before, the server would have to be running before Drosera was started.) 3) Fixed a bug where the WebView started out as 0x0 pixels. 4) Fixed a bug when there is no scope. 5) Added the HTML, JS, and CSS to the project file to make them easy to find. 6) Made the ServerConnection functions virtual.
  • Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens for the WebKit server. (DebuggerClient::DebuggerClient): (DebuggerClient::~DebuggerClient): (DebuggerClient::didFinishLoadForFrame): (DebuggerClient::serverConnected): (DebuggerClient::attemptToCreateServerConnection):
  • Drosera/win/DebuggerClient.h: Ditto.
  • Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no scope. (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed):
  • Drosera/win/Drosera.cpp: (_tWinMain): Added a console in debug for output messages. (Drosera::Drosera): Listen for server. (Drosera::initUI): The server now Initializes COM. (Drosera::serverConnected): Part of the listening for the server. (Drosera::attemptToCreateServerConnection): Ditto.
  • Drosera/win/Drosera.h: New interface for listening for the server.
  • Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS files to the VS project.
  • Drosera/win/ServerConnection.cpp: Part of listening for the server connection. (ServerConnection::ServerConnection): (ServerConnection::attemptToCreateServerConnection):
  • Drosera/win/ServerConnection.h: Ditto and virtualized the Interface methods. (ServerConnection::serverConnected):
2:30 PM Changeset in webkit [27429] by weinig
  • 1 edit in trunk/WebKitTools/FindSafari

Add svn:ignore for vcproj temp files under FindSafari.

12:27 PM Changeset in webkit [27428] by ap
  • 4 edits in trunk/WebKitTools

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=15832
fast/dom/gc-10.html crashes when run alone

Check for !done before using objects that can be already deallocated.

  • DumpRenderTree/mac/EditingDelegate.mm: (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]): (-[EditingDelegate webView:shouldEndEditingInDOMRange:]): (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldDeleteDOMRange:]): (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]): (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]): (-[EditingDelegate webViewDidBeginEditing:]): (-[EditingDelegate webViewDidChange:]): (-[EditingDelegate webViewDidEndEditing:]): (-[EditingDelegate webViewDidChangeTypingStyle:]): (-[EditingDelegate webViewDidChangeSelection:]):
  • DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): (-[FrameLoadDelegate webView:didCommitLoadForFrame:]): (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]): (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]): (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]): (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]): (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]): (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]): (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]): (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]): (-[FrameLoadDelegate webView:willCloseFrame:]): (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]): (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
  • DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]): (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
8:46 AM Changeset in webkit [27427] by ddkilzer
  • 2 edits in trunk/WebCore

Fix build when spaces appear in the WebKit source path.

Reviewed by Mark Rowe.

  • bindings/scripts/IDLParser.pm: Use safer open() method which lists arguments individually and prevents the need to work around spaces in the path.
8:13 AM Changeset in webkit [27426] by ddkilzer
  • 2 edits in trunk/WebKitSite

CIA has changed its hostname from cia.navi.cx to cia.vc
<​http://bugs.webkit.org/show_bug.cgi?id=15829>

Reviewed by Mitz.

  • contact.html: Updated links to CIA.
7:03 AM Changeset in webkit [27425] by alp
  • 2 edits in trunk/WebCore

2007-11-04 Alp Toker <​alp@atoker.com>

Reviewed by Alexey Proskuryakov.

Fix a crash when no clipboard text is available

  • platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::plainText):
1:48 AM Changeset in webkit [27424] by mrowe@apple.com
  • 2 edits in trunk/WebKitTools

2007-11-04 Mark Rowe <​mrowe@apple.com>

Build fix. Don't use Carbon.h as the prefix header as it triggers
warnings that would otherwise be suppressed due to it being a system header.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1:58 AM Changeset in webkit [27423] by Darin Adler
  • 3 edits in trunk/SunSpider
  • hosted/sunspider.html: Tweaked formatting a bit.
1:28 AM Changeset in webkit [27422] by Darin Adler
  • 4 edits in trunk/JavaScriptCore

Reviewed by Maciej.

SunSpider says it's 2.6% faster overall, 32.5% in the regular expression tests.

  • pcre/pcre_internal.h: Added OP_ASCII_CHAR and OP_ASCII_LETTER_NC.
  • pcre/pcre_compile.c: (find_fixedlength): Added cases for OP_ASCII_CHAR and OP_ASCII_LETTER_NC. Also added OP_NOT since there was no reason it should not be in here. (could_be_empty_branch): Ditto. (compile_branch): Streamlined all the single-character cases; there was a bit of duplicate code. Added cases for OP_ASCII_CHAR and OP_ASCII_LETTER_NC as needed. But in particular, compile to those opcodes when the single character match is ASCII. (find_firstassertedchar): Added cases for OP_ASCII_CHAR and OP_ASCII_LETTER_NC.
  • pcre/pcre_exec.c: (match): Removed the "min", "minimize", and "op" fields from the matchframe, after I discovered that none of them needed to be saved and restored across recursive match calls. Also eliminated the ignored result field from the matchframe, since I discovered that rrc ("recursive result code") was already the exact same thing. Moved the handling of opcodes higher than OP_BRA into the default statement of the switch instead of doing them before the switch. This removes a branch from each iteration of the opcode interpreter, just as removal of "op" removed at least one store from each iteration. Last, but not least, add the OP_ASCII_CHAR and OP_ASCII_LETTER_NC functions. Neither can ever match a surrogate pair and the letter case can be handled efficiently.
12:54 AM Changeset in webkit [27421] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • pcre/pcre_exec.c: (match): Try to fix the Windows build by removing unreachable code.

Nov 3, 2007:

11:18 PM Changeset in webkit [27420] by Darin Adler
  • 7 edits
    4 deletes in trunk/JavaScriptCore
  • fix non-Mac builds; remove some more unused PCRE stuff
  • pcre/pcre_compile.c: (compile_branch): Removed branch chain and some unused ESC values. (compile_regex): Ditto. (jsRegExpCompile): Ditto.
  • pcre/pcre_exec.c: (match): Removed unused branch targets. Don't use macros any more. (jsRegExpExecute): More of the same.
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Update for removed files.
  • JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
  • pcre/pcre.pri: Ditto.
  • pcre/MERGING: Removed.
  • pcre/pcre_fullinfo.c: Removed.
  • pcre/pcre_get.c: Removed.
  • pcre/pcre_internal.h:
  • pcre/ucp.h: Removed.
10:22 PM Changeset in webkit [27419] by Darin Adler
  • 24 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

A first step toward removing the PCRE features we don't use.
This gives a 0.8% speedup on SunSpider, and a 6.5% speedup on
the SunSpider regular expression test.

Replaced the public interface with one that doesn't use the
name PCRE. Removed code we don't need for JavaScript and various
configurations we don't use. This is in preparation for still
more changes in the future. We'll probably switch to C++ and
make some even more significant changes to the regexp engine
to get some additional speed.

There's probably additional unused stuff that I haven't
deleted yet.

This does mean that our PCRE is now a fork, but I think that's
not really a big deal.

  • JavaScriptCore.exp: Remove the 5 old entry points and add the 3 new entry points for WebCore's direct use of the regular expression engine.
  • kjs/config.h: Remove the USE(PCRE16) define. I decided to flip its sense and now there's a USE(POSIX_REGEX) instead, which should probably not be set by anyone. Maybe later we'll just get rid of it altogether.
  • kjs/regexp.h:
  • kjs/regexp.cpp: (KJS::RegExp::RegExp): Switch to new jsRegExp function names and defines. Cut down on the number of functions used. (KJS::RegExp::~RegExp): Ditto. (KJS::RegExp::match): Ditto.
  • pcre/dftables.c: (main): Get rid of ctype_letter and ctype_meta, which are unused.
  • pcre/pcre-config.h: Get rid of EBCIDIC, PCRE_DATA_SCOPE, const, size_t, HAVE_STRERROR, HAVE_MEMMOVE, HAVE_BCOPY, NEWLINE, POSIX_MALLOC_THRESHOLD, NO_RECURSE, SUPPORT_UCP, SUPPORT_UTF8, and JAVASCRIPT. These are all no longer configurable in our copy of the library.
  • pcre/pcre.h: Remove the macro-based kjs prefix hack, the PCRE version macros, PCRE_UTF16, the code to set up PCRE_DATA_SCOPE, the include of <stdlib.h>, and most of the constants and functions defined in this header. Changed the naming scheme to use a JSRegExp prefix rather than a pcre prefix. In the future, we'll probably change this to be a C++ header.
  • pcre/pcre_compile.c: Removed all unused code branches, including many whole functions and various byte codes. Kept changes outside of removal to a minimum. (check_escape): (first_significant_code): (find_fixedlength): (find_recurse): (could_be_empty_branch): (compile_branch): (compile_regex): (is_anchored): (is_startline): (find_firstassertedchar): (jsRegExpCompile): Renamed from pcre_compile2 and changed the parameters around a bit. (jsRegExpFree): Added.
  • pcre/pcre_exec.c: Removed many unused opcodes and variables. Also started tearing down the NO_RECURSE mechanism since it's now the default. In some cases there were things in the explicit frame that could be turned into plain old local variables and other small like optimizations. (pchars): (match_ref): (match): Changed parameters quite a bit since it's now not used recursively. (jsRegExpExecute): Renamed from pcre_exec.
  • pcre/pcre_internal.h: Get rid of PCRE_DEFINITION, PCRE_SPTR, PCRE_IMS, PCRE_ICHANGED, PCRE_NOPARTIAL, PCRE_STUDY_MAPPED, PUBLIC_OPTIONS, PUBLIC_EXEC_OPTIONS, PUBLIC_DFA_EXEC_OPTIONS, PUBLIC_STUDY_OPTIONS, MAGIC_NUMBER, 16 of the opcodes, _pcre_utt, _pcre_utt_size, _pcre_try_flipped, _pcre_ucp_findprop, and _pcre_valid_utf8. Also moved pcre_malloc and pcre_free here.
  • pcre/pcre_maketables.c: Changed to only compile in dftables. Also got rid of many of the tables that we don't use.
  • pcre/pcre_tables.c: Removed the unused Unicode property tables.
  • pcre/pcre_ucp_searchfuncs.c: Removed everything except for _pcre_ucp_othercase.
  • pcre/pcre_xclass.c: (_pcre_xclass): Removed uneeded support for classes based on Unicode properties.
  • wtf/FastMallocPCRE.cpp: Removed unused bits. It would be good to eliminate this completely, but we need the regular expression code to be C++ first.
  • pcre/pcre_fullinfo.c:
  • pcre/pcre_get.c:
  • pcre/ucp.h: Files that are no longer needed. I didn't remove them with this check-in, because I didn't want to modify all the project files.

WebCore:

Reviewed by Maciej.

  • page/Frame.cpp: (WebCore::Frame::matchLabelsAgainstElement):
  • page/mac/FrameMac.mm: (WebCore::Frame::matchLabelsAgainstElement): Remove use of ":digit:?" syntax. This hasn't worked for some time. Use "\d" instead.
  • platform/RegularExpression.h: Remove the unused cap function. We can add it back later if we find we need it.
  • platform/RegularExpression.cpp: (WebCore::RegularExpression::Private::compile): Update for JavaScriptCore regular expression entry point changes. (WebCore::RegularExpression::Private::~Private): Ditto. (WebCore::RegularExpression::match): Remove the code to set PCRE_NOTBOL. This means that regular expressions with metacharactesr like in them won't work any more with non-whole-string searches, but we don't use any regular expressions like that.
10:15 PM Changeset in webkit [27418] by kevino
  • 2 edits in trunk/WebCore

Update the link stubs to match the current build, and fix coding style issues.

Reviewed by Mark Rowe.

9:17 PM Changeset in webkit [27417] by weinig@apple.com
  • 2 edits in trunk/JavaScriptGlue

Build-fix.

  • UserObjectImp.cpp:
8:37 PM Changeset in webkit [27416] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Sam.


  • remove NaN check from JSImmediate::fromDouble for 0.5% SunSpider speedup

It turns out that doing this check costs more than it saves.


  • kjs/JSImmediate.h: (KJS::JSImmediate::fromDouble):
7:21 PM Changeset in webkit [27415] by kevino
  • 1 edit
    3 adds in trunk/WebCore

wx <-> WebKit conversions for IntPoint, IntRect and FloatRect

Reviewed by Mark Rowe.

7:05 PM Changeset in webkit [27414] by kevino
  • 1 edit
    3 adds in trunk/WebCore

wx <-> WebKit data type conversions for Pen and Color.

Reviewed by Darin Adler.

6:08 PM Changeset in webkit [27413] by weinig@apple.com
  • 31 edits in trunk

JavaScriptCore:

Reviewed by Oliver.

Remove dummy variable from ClassInfo reducing the size of the struct by 1 word.
The variable had been kept around for binary compatibility, but since nothing
else is there is no point in continuing to keep it around.

  • API/JSCallbackConstructor.cpp: (KJS::):
  • API/JSCallbackFunction.cpp: (KJS::):
  • API/JSCallbackObject.cpp: (KJS::):
  • bindings/objc/objc_runtime.mm:
  • bindings/runtime_array.cpp:
  • bindings/runtime_object.cpp:
  • kjs/array_instance.cpp: (KJS::):
  • kjs/array_object.cpp: (KJS::):
  • kjs/bool_object.cpp:
  • kjs/date_object.cpp: (KJS::):
  • kjs/error_object.cpp:
  • kjs/function.cpp: (KJS::):
  • kjs/internal.cpp: (KJS::):
  • kjs/lookup.h:
  • kjs/math_object.cpp:
  • kjs/number_object.cpp:
  • kjs/object.h:
  • kjs/regexp_object.cpp:
  • kjs/string_object.cpp: (KJS::):

WebCore:

Reviewed by Oliver.

Remove dummy variable from ClassInfo reducing the size of the struct by 1 word.
The variable had been kept around for binary compatibility, but since nothing
else is there is no point in continuing to keep it around.

  • bindings/js/JSDOMExceptionConstructor.cpp: (WebCore::):
  • bindings/js/JSHTMLInputElementBase.cpp: (WebCore::):
  • bindings/js/JSNamedNodesCollection.cpp: (WebCore::):
  • bindings/js/JSXMLHttpRequest.cpp: (KJS::):
  • bindings/js/JSXSLTProcessor.cpp: (KJS::):
  • bindings/js/kjs_css.cpp: (WebCore::):
  • bindings/js/kjs_events.cpp: (WebCore::):
  • bindings/js/kjs_navigator.cpp: (KJS::):
  • bindings/js/kjs_window.cpp: (KJS::):
  • bindings/scripts/CodeGeneratorJS.pm:
4:52 PM Changeset in webkit [27412] by kmccullo
  • 2 edits in trunk/JavaScriptCore
  • Updated testkjs results to make the build bots green until we can fix the tests that are failing. The new failures are in DST.
  • tests/mozilla/expected.html:
3:58 PM Changeset in webkit [27411] by mjs
  • 6 edits
    1 add in trunk/SunSpider

Reviewed by Darin.

  • Add compare mode and a description of the benchmark to the hosted version.
  • hosted/sunspider-results.html: Add compare mode - you can just paste in another results URL.
  • hosted/sunspider.html: Added intro text.
  • make-hosted: Copy new file.
  • resources/sunspider-compare-results.js: Made more reusable by putting the implementation in a function.
  • resources/sunspider-standalone-compare.js: Added. Calls the function in the way standalone mode expects.
  • sunspider-compare-results: Use sunspider-standalone-compare.js.
2:13 PM Changeset in webkit [27410] by mjs
  • 2 edits in trunk/JavaScriptCore

Reviewed by Adam.


  • don't print the var twice for ForInNodes with a var declaration
  • kjs/nodes2string.cpp: (KJS::ForInNode::streamTo):
1:54 PM Changeset in webkit [27409] by mjs
  • 2 edits in trunk/WebKitTools

Rubber stamped by Adam.


  • Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
9:44 AM Changeset in webkit [27408] by Darin Adler
  • 2 edits in trunk/JavaScriptCore
  • pcre/pcre_compile.c: (check_escape): Windows build fix. Get rid of C-incompatible declaration.
9:42 AM Changeset in webkit [27407] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2007-11-03 Mark Rowe <​mrowe@apple.com>

Gtk build fix.

  • kjs/nodes.cpp: Add missing include.
9:40 AM Changeset in webkit [27406] by Darin Adler
  • 8 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

These changes cause us to match the JavaScript specification and pass the
fast/js/kde/encode_decode_uri.html test.

  • kjs/function.cpp: (KJS::encode): Call the UTF-8 string conversion in its new strict mode, throwing an exception if there are malformed UTF-16 surrogate pairs in the text.
  • kjs/ustring.h: Added a strict version of the UTF-8 string conversion.
  • kjs/ustring.cpp: (KJS::decodeUTF8Sequence): Removed code to disallow U+FFFE and U+FFFF; while those might be illegal in some sense, they aren't supposed to get any special handling in the place where this function is currently used. (KJS::UString::UTF8String): Added the strictness.

LayoutTests:

Reviewed by Maciej.

  • fast/js/kde/resources/encode_decode_uri.js: Rewrote the test to cover edges better, and use the should functions in a way that makes failures easier to understand.
  • fast/js/kde/encode_decode_uri-expected.txt: Updated.
9:28 AM Changeset in webkit [27405] by Darin Adler
  • 9 edits in trunk/JavaScriptCore

Reviewed by Maciej.

Two or three fixes get 7 more of the Mozilla tests passing.
This gets us down from 61 failing tests to 54.

  • kjs/interpreter.h: (KJS::Interpreter::builtinRegExp): Made this inline and gave it a more specific type. Some day we should probably do that for all of these -- might even get a bit of a speed boost from it.
  • kjs/interpreter.cpp: Removed Interpreter::builtinRegExp now that it's inline in the header.
  • kjs/regexp_object.h:
  • kjs/regexp_object.cpp: (KJS::RegExpProtoFunc::callAsFunction): Moved test and exec out of the switch statement into the RegExpImp object, so they can be shared with RegExpImp::callAsFunction. (KJS::RegExpImp::match): Added. Common code used by both test and exec. (KJS::RegExpImp::test): Added. (KJS::RegExpImp::exec): Added. (KJS::RegExpImp::implementsCall): Added. (KJS::RegExpImp::callAsFunction): Added. (KJS::RegExpObjectImpPrivate::RegExpObjectImpPrivate): Initialize lastInput to null rather than empty string -- we take advantage of the difference in RegExpImp::match. (KJS::RegExpObjectImp::input): Added. No reason to go through hash tables just to get at a field like this.
  • pcre/pcre_compile.c: (check_escape): Changed the \u handling to match the JavaScript specification. If there are not 4 hex digits after the \u, then it's processed as if it wasn't an escape sequence at all.
  • pcre/pcre_internal.h: Added IS_NEWLINE, with the appropriate definition for JavaScript (4 specific Unicode values).
  • pcre/pcre_exec.c: (match): Changed all call sites to use IS_NEWLINE. (pcre_exec): Ditto.
  • tests/mozilla/expected.html: Updated to expect 7 more successful tests.
8:52 AM Changeset in webkit [27404] by alp
  • 2 edits in trunk/WebKit/gtk

Reviewed by Mark Rowe.

Restore correct double and triple click behaviour

We ended up ignoring GDK_2BUTTON_PRESS and GDK_3BUTTON_PRESS after
recent refactoring.

8:26 AM Changeset in webkit [27403] by kevino
  • 8 edits in trunk/WebCore

Build fixes to get wx impls. building on trunk.

Reviewed by Mark Rowe.

8:10 AM Changeset in webkit [27402] by ddkilzer
  • 14 edits in trunk

JavaScriptCore:

Sort files(...); sections of Xcode project files.

Rubber-stamped by Darin.

JavaScriptGlue:

Sort files(...); sections of Xcode project files.

Rubber-stamped by Darin.

  • JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

Sort files(...); sections of Xcode project files.

Rubber-stamped by Darin.

  • WebCore.xcodeproj/project.pbxproj:
  • manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj:

WebKit:

Sort files(...); sections of Xcode project files.

Rubber-stamped by Darin.

  • WebKit.xcodeproj/project.pbxproj:

WebKitTools:

Sort files(...); sections of Xcode project files.

Rubber-stamped by Darin.

  • DrawTest/DrawTest.xcodeproj/project.pbxproj:
  • Drosera/mac/Drosera.xcodeproj/project.pbxproj:
  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
7:57 AM Changeset in webkit [27401] by kevino
  • 4 edits in trunk/WebCore

Coding style fixes for platform/wx files.

Reviewed by Mark Rowe.

7:33 AM Changeset in webkit [27400] by alp
  • 3 edits in trunk/WebCore

Reviewed by Mark Rowe.

Implement platform scrollbar static width/height getters

7:33 AM Changeset in webkit [27399] by alp
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Cast function pointers to gpointer.

7:33 AM Changeset in webkit [27398] by alp
  • 4 edits
    2 adds in trunk/WebCore

Reviewed by Adam Roben.

RenderThemeGtk implementation based on Mozilla's GTK+ style code

There is still work needed to complete this feature.

7:33 AM Changeset in webkit [27397] by alp
  • 2 edits in trunk/WebCore

Reviewed by Mark Rowe.

Do not allow scrollbars to handle wheel events

We bubble the wheel event up so the parent can handle it instead.

7:32 AM Changeset in webkit [27396] by alp
  • 7 edits in trunk

Reviewed by Mark Rowe.

Frame scrolling and invalidation fixes

Make upward scroll events have a positive delta to match other ports.

Fix the invalidation rect offset for frames so that scrolling works properly.

Avoid allocating negative sizes to widgets to avoid GTK+ warnings.

Allow tabbing to all widgets and links.

Fix event returns, improving the focus situation and correcting scroll wheel
behavior.

6:35 AM Changeset in webkit [27395] by ddkilzer
  • 27 edits in trunk

WebCore:

LGPL'ed files contain incorrect FSF address
<​http://bugs.webkit.org/show_bug.cgi?id=14885>

Reviewed by NOBODY (follow-up fix).

  • bindings/js/JSSVGTransformListCustom.cpp:
  • ksvg2/svg/SVGException.idl:
  • ksvg2/svg/SVGTextPathElement.cpp:
  • ksvg2/svg/SVGTextPathElement.h:
  • ksvg2/svg/SVGViewSpec.cpp:
  • ksvg2/svg/SVGViewSpec.h:
  • platform/mac/FontCustomPlatformData.cpp:
  • platform/mac/FontCustomPlatformData.h:
  • platform/mac/FontPlatformDataMac.mm:
  • platform/win/FontCustomPlatformData.cpp:
  • platform/win/FontCustomPlatformData.h:
  • rendering/RenderSVGRoot.cpp:
  • rendering/RenderSVGRoot.h:
  • rendering/RenderSVGTextPath.cpp:
  • rendering/RenderSVGTextPath.h:
  • rendering/RenderSVGTransformableContainer.h:
  • rendering/RenderSVGViewportContainer.cpp:
  • rendering/RenderSVGViewportContainer.h:
  • rendering/SVGCharacterLayoutInfo.cpp:
  • rendering/SVGCharacterLayoutInfo.h:
  • rendering/SVGRenderSupport.cpp:
  • rendering/SVGRenderSupport.h:

WebKitSite:

LGPL'ed files contain incorrect FSF address
<​http://bugs.webkit.org/show_bug.cgi?id=14885>

Reviewed by NOBODY (follow-up fix).

  • blog/wp-includes/class-snoopy.php:
  • blog/wp-includes/gettext.php:
  • blog/wp-includes/streams.php:
3:09 AM Changeset in webkit [27394] by mjs
  • 5 edits in trunk/JavaScriptCore

Reviewed by Oliver.


  • remove VarDeclListNode and simplify VarDeclNode evaluation for 0.4% SunSpider speedup
  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::VarDeclNode::optimizeVariableAccess): (KJS::VarDeclNode::getDeclarations): (KJS::VarDeclNode::handleSlowCase): (KJS::VarDeclNode::evaluateSingle): (KJS::VarDeclNode::evaluate): (KJS::VarStatementNode::execute):
  • kjs/nodes.h: (KJS::VarDeclNode::): (KJS::VarStatementNode::):
  • kjs/nodes2string.cpp: (KJS::VarDeclNode::streamTo):
1:36 AM Changeset in webkit [27393] by ap
  • 3 edits in trunk/JavaScriptCore

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15800
REGRESSION (r27303): RegExp leaks

  • kjs/regexp_object.h: (KJS::RegExpImp::setRegExp): (KJS::RegExpImp::regExp): (KJS::RegExpImp::classInfo):
  • kjs/regexp_object.cpp: (RegExpImp::RegExpImp): (RegExpImp::~RegExpImp): Renamed reg member variable to m_regExp, changed it to use OwnPtr.
12:27 AM Changeset in webkit [27392] by mrowe@apple.com
  • 4 edits in trunk

Versioning.

Nov 2, 2007:

11:58 PM Changeset in webkit [27391] by ddkilzer
  • 1 edit
    1 add in trunk/WebKitTools

Script to sort "files(...);" sections in Xcode project.pbxproj files.

Rubber-stamped by Darin.

  • Scripts/sort-Xcode-project-file: Added.
9:17 PM Changeset in webkit [27390] by antti
  • 5 edits
    2 adds in trunk

WebCore:

Reviewed by Adam.


Add video width/height DOM and content attributes from latest HTML5 draft.

Test: media/video-width-height.html

  • html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::parseMappedAttribute): (WebCore::HTMLVideoElement::width): (WebCore::HTMLVideoElement::setWidth): (WebCore::HTMLVideoElement::height): (WebCore::HTMLVideoElement::setHeight):
  • html/HTMLVideoElement.h:
  • html/HTMLVideoElement.idl:

LayoutTests:

Reviewed by Adam.


Test for video width/height DOM and content attributes.

  • media/video-width-height-expected.txt: Added.
  • media/video-width-height.html: Added.
8:24 PM Changeset in webkit [27389] by mjs
  • 4 edits in trunk/JavaScriptCore

Reviewed by Oliver.


  • add SourceElements as a typedef for Vector<RefPtr<StatementNode> >.
  • kjs/grammar.y:
  • kjs/nodes.cpp: (KJS::statementListPushFIFO): (KJS::statementListGetDeclarations): (KJS::statementListInitializeDeclarationStacks): (KJS::statementListInitializeVariableAccessStack): (KJS::statementListExecute): (KJS::BlockNode::BlockNode): (KJS::FunctionBodyNode::FunctionBodyNode): (KJS::ProgramNode::ProgramNode):
  • kjs/nodes.h: (KJS::CaseClauseNode::):
5:48 PM Changeset in webkit [27388] by Darin Adler
  • 3 edits in trunk/WebCore

Reviewed by Maciej.

  • DerivedSources.make: Remove a few explicit filenames from some rules by using make variables a little more.
  • WebCore.LP64.exp: Fix typo, grammar.
5:46 PM Changeset in webkit [27387] by Darin Adler
  • 3 edits in trunk/JavaScriptCore

Reviewed by Maciej.

The property map now has an array of indices and a separate array of
property map entries. This slightly slows down lookup because of a second
memory acess, but makes property maps smaller and faster to iterate in
functions like mark().

SunSpider says this is 1.2% faster, although it makes the bitwise-end test
more than 10% slower. To fix that we'll need to optimize global variable lookup.

  • kjs/property_map.cpp: (KJS::PropertyMapEntry::PropertyMapEntry): (KJS::PropertyMapHashTable::entries): (KJS::PropertyMapHashTable::allocationSize): (KJS::SavedProperties::SavedProperties): (KJS::SavedProperties::~SavedProperties): (KJS::PropertyMap::checkConsistency): (KJS::PropertyMap::~PropertyMap): (KJS::PropertyMap::clear): (KJS::PropertyMap::get): (KJS::PropertyMap::getLocation): (KJS::PropertyMap::put): (KJS::PropertyMap::insert): (KJS::PropertyMap::createTable): (KJS::PropertyMap::rehash): (KJS::PropertyMap::remove): (KJS::PropertyMap::mark): (KJS::comparePropertyMapEntryIndices): (KJS::PropertyMap::containsGettersOrSetters): (KJS::PropertyMap::getEnumerablePropertyNames): (KJS::PropertyMap::save): (KJS::PropertyMap::restore):
  • kjs/property_map.h:
5:39 PM Changeset in webkit [27386] by antti
  • 4 edits in trunk/WebKitLibraries

Reviewed by Darin.


Update to add WKQTMovieViewSetDrawSynchronously

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
5:30 PM Changeset in webkit [27385] by Darin Adler
  • 10 edits in trunk

JavaScriptCore:

Reviewed by Maciej.

  • wtf/HashMap.h: Added take function. Simplistic implementation for now, but still does only one hash table lookup.
  • kjs/array_instance.cpp: (KJS::ArrayInstance::put): Use take rather than a find followed by a remove.

WebCore:

Reviewed by Maciej.

  • use the new HashMap::take function where appropriate
  • bindings/js/kjs_binding.cpp: (KJS::addWrapper): Made an inline rather than a macro; inlines good, macros bad. (KJS::removeWrapper): Ditto. (KJS::removeWrappers): Ditto. (KJS::ScriptInterpreter::putDOMObject): Use the inline instead of the macro. (KJS::ScriptInterpreter::forgetDOMObject): Ditto. This involves using take instead of remove -- in theory ever so slightly less efficient, but I think it's fine. (KJS::ScriptInterpreter::forgetDOMNodeForDocument): Ditto. (KJS::ScriptInterpreter::putDOMNodeForDocument): Use the inline instead of the macro. (KJS::ScriptInterpreter::forgetAllDOMNodesForDocument): Use take instead of find/remove. (KJS::ScriptInterpreter::updateDOMNodeDocument): Use the inlines instead of the macros.
  • bindings/js/kjs_window.cpp: (KJS::Window::clearTimeout): Use take instead of find/remove.
  • bridge/mac/AXObjectCacheMac.mm: (WebCore::AXObjectCache::remove): Ditto.
  • page/AnimationController.cpp: (WebCore::AnimationControllerPrivate::clear): Ditto.
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::~RenderBlock): Ditto. (WebCore::RenderBlock::setDesiredColumnCountAndWidth): Ditto.
  • rendering/RootInlineBox.cpp: Ditto.(WebCore::RootInlineBox::detachEllipsisBox): Ditto.
5:23 PM Changeset in webkit [27384] by antti
  • 7 edits in trunk

WebCore:

Reviewed by Darin.

Enable video composition.

  • WebCore.base.exp:
  • platform/graphics/mac/MoviePrivateQTKit.mm: (WebCore::MoviePrivate::createQTMovieView):
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

WebKit:

Reviewed by Darin.


Add method to enable video composition.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
5:20 PM Changeset in webkit [27383] by Darin Adler
  • 4 edits in trunk

SunSpider:

  • sunspider: Changed "--base" to "--set-baseline".

WebKitTools:

  • Scripts/run-sunspider: Changed "--base" to "--set-baseline".
5:15 PM Changeset in webkit [27382] by Darin Adler
  • 6 edits in trunk

SunSpider:

Reviewed by Maciej.

  • sunspider: Added a "--base" option that records the current test as a baseline. Moved the code to find the newest .mshark file into a function (since I needed to use it in the other script and I prefer to copy/paste a function).
  • sunspider-compare-results: Added logic to compare the baseline with the last run when you don't pass any parameters.

WebKitTools:

Reviewed by Maciej.

  • Scripts/run-sunspider: Pass the "--base" option through.
  • Scripts/sunspider-compare-results: Don't check the number of parameters; let the real script do that. Default configuration to Release to match run-sunspider so we don't end up building Debug just to compare results.
4:16 PM Changeset in webkit [27381] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin.

Fix compiler warning "warning: suggest parentheses around && within
"

​http://bugs.webkit.org/show_bug.cgi?id=15764

  • kjs/value.h: (KJS::JSValue::isNumber): Add parentheses.
4:13 PM Changeset in webkit [27380] by Darin Adler
  • 5 edits
    2 adds in trunk

WebCore:

Reviewed by Mitz.

Test: fast/forms/remove-radio-button-assert.html

  • html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::removeFromForm): Added protected function to be used by derived classes that need to do the same sort of removal from form that's automatically done by the base class in certain circumstances.
  • html/HTMLGenericFormElement.h: Added removeFromForm.
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): Call removeFromForm here so the element is removed before we destroy the HTMLInputElement part of this object. By the time we get to the base class's destructor it's too late. The problem is specific to radio buttons so we don't have to worry about other classes derived from HTMLGenericFormElement.

LayoutTests:

Reviewed by Mitz.

  • fast/forms/remove-radio-button-assert-expected.txt: Added.
  • fast/forms/remove-radio-button-assert.html: Added.
4:11 PM Changeset in webkit [27379] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Mitz.

  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::isLoadingMultipartContent): Instead of asserting the frame loader is non-0, return false if it is 0.
4:08 PM Changeset in webkit [27378] by Darin Adler
  • 10 edits in trunk

WebCore:

Reviewed by Mitz.

  • fix <rdar://problem/5530185> WebKit does not show <object> fallback content when both URL and MIME type is omitted

Already covered by existing tests (that had incorrect results).

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::requestObject): Return false to indicate failure when both URL and MIME type are empty. The old code would not attempt a load, but it would indicate success.
  • rendering/RenderPartObject.cpp: (WebCore::RenderPartObject::updateWidget): Remove non-helpful early exit for the case where there is no URL and no type. Returning early prevents the fallback code from running.

WebKit:

Reviewed by Mitz.

  • fix problem I ran into while doing some testing on Mac for <rdar://problem/5530185> WebKit does not show <object> fallback content when both URL and MIME type is omitted

I don't know how to reproduce this failure in DumpRenderTree, so there is no
regression test.

  • Plugins/WebNullPluginView.h: Removed some unneeded declarations, including the didSendError local variable. Instead we just set the error to nil once we've sent it.
  • Plugins/WebNullPluginView.mm: (-[WebNullPluginView initWithFrame:error:DOMElement:]): Refactored so that the null plug-in image code is separate from the rest of the function and so that the whole thing is not inside an if statement. Also don't hold a reference to the DOM element if there is no error to report. (-[WebNullPluginView reportFailure]): Added. Does the actual delegate callback. Happens back at the top level of the run loop so it doesn't fire deep inside layout. Also wrote this so that it is guaranteed not to reenter and so that it can handle the case where the delegate destroys the world (including this object). NOTE: This is not a real, general solution to the problem of plug-ins that do work inside layout. We will need a more general fix that works for other plug-ins, and we'll track that with a separate bug report. (-[WebNullPluginView viewDidMoveToWindow]): Removed most of the code; changed so it just does a performSelector:afterDelay:0.

LayoutTests:

Reviewed by Mitz.

  • update tests affected by fix for <rdar://problem/5530185> WebKit does not show <object> fallback content when both URL and MIME type is omitted
  • dom/html/level2/html/AppletsCollection-expected.txt: The text "Nothing here!" renders now.
  • fast/dom/HTMLDocument/object-by-name-unknown-child-element-expected.txt: Some blank space renders now.
  • platform/mac/fast/invalid/residual-style-expected.txt: A font element renders now.
2:51 PM Changeset in webkit [27377] by alp
  • 5 edits in trunk/WebCore

Reviewed by Darin.

Include Cairo headers properly

7:07 AM Changeset in webkit [27376] by mrowe@apple.com
  • 2 edits in trunk/WebKit

2007-11-02 Mark Rowe <​mrowe@apple.com>

Reviewed by Darin Adler.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=15780
Bug 15780: WebFrameLoaderClient: WebActionElementKey wrong if view is scrolled

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::actionDictionary): Retrieve the mouse event coordinates in the page coordinate system rather than the client area coordinate system.
Note: See TracTimeline for information about the timeline view.