Timeline
Nov 7, 2007:
- 11:58 PM Changeset in webkit [27589] by
-
- 5 edits in trunk/JavaScriptCore
2007-11-07 Eric Seidel <eric@webkit.org>
Reviewed by Darin and Oliver.
Add evaluateToNumber parallel evaluation tree to speed up number operations.
Make ImmediateNumberNode a subclass of NumberNode.
Share evaluate logic between evaluate and evaluateToNumber using inline functions
There is still a lot of improvement to be made here.
SunSpider claims this is a 1.0% speedup overall (nbody 7.9%), base64 slowing 2.0%
Given the huge win that this prepares us for with simple type inferencing I see the small
regression in base64 being worth the substantial overall improvement.
- kjs/grammar.y:
- kjs/nodes.cpp: (KJS::Node::evaluateToNumber): (KJS::NumberNode::evaluate): (KJS::NumberNode::evaluateToNumber): (KJS::StringNode::evaluateToNumber): (KJS::LocalVarAccessNode::inlineEvaluate): (KJS::LocalVarAccessNode::evaluate): (KJS::LocalVarAccessNode::evaluateToNumber): (KJS::BracketAccessorNode::inlineEvaluate): (KJS::BracketAccessorNode::evaluate): (KJS::BracketAccessorNode::evaluateToNumber): (KJS::NegateNode::evaluate): (KJS::NegateNode::evaluateToNumber): (KJS::MultNode::inlineEvaluateToNumber): (KJS::MultNode::evaluate): (KJS::MultNode::evaluateToNumber): (KJS::DivNode::inlineEvaluateToNumber): (KJS::DivNode::evaluate): (KJS::DivNode::evaluateToNumber): (KJS::ModNode::inlineEvaluateToNumber): (KJS::ModNode::evaluate): (KJS::ModNode::evaluateToNumber): (KJS::throwOutOfMemoryErrorToNumber): (KJS::addSlowCaseToNumber): (KJS::add): (KJS::addToNumber): (KJS::AddNode::evaluateToNumber): (KJS::SubNode::inlineEvaluateToNumber): (KJS::SubNode::evaluate): (KJS::SubNode::evaluateToNumber): (KJS::valueForReadModifyAssignment): (KJS::ReadModifyLocalVarNode::evaluate): (KJS::ReadModifyResolveNode::evaluate): (KJS::ReadModifyDotNode::evaluate): (KJS::ReadModifyBracketNode::evaluate):
- kjs/nodes.h: (KJS::Node::): (KJS::NumberNode::): (KJS::ImmediateNumberNode::): (KJS::AddNode::precedence):
- kjs/nodes2string.cpp: (KJS::NumberNode::streamTo):
- 11:40 PM Changeset in webkit [27588] by
-
- 3 edits in trunk/WebKit/win
Added IWebDocumentText available via QI from WebFrame.
Reviewed by Sam.
- WebFrame.cpp: (WebFrame::QueryInterface): Added IID_IWebDocumentText. (WebFrame::supportsTextEncoding): Stubbed out. (WebFrame::selectedString): Implemented. (WebFrame::selectAll): Stubbed out. (WebFrame::deselectAll): Stubbed out.
- WebFrame.h:
- 10:13 PM Changeset in webkit [27587] by
-
- 2 edits in trunk/WebCore
Reviewed by Ollie.
Ensure video renderer has correct size if video has already been loaded
when it is constructed.
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::RenderVideo):
- 8:24 PM Changeset in webkit [27586] by
-
- 2 edits in trunk/WebCore
Reviewed by Ollie.
Ensure video is visible when it should be.
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::updateMovie):
- 5:54 PM Changeset in webkit [27585] by
-
- 4 edits1 add in trunk/WebCore
Reviewed by Darin Adler.
- fix <rdar://problem/5523503> Safari crashes clicking scroll bar in FaceBook 'Trips'
Layers and listboxes are two kinds of ScrollBarClient that can be
removed while the scrollbar is tracking the mouse. The scrollbar is not
destroyed until later, and meanwhile it can try to call the client,
which results in a crash.
- manual-tests/stale-scrollbar-client-crash.html: Added.
- platform/ScrollBar.h: (WebCore::Scrollbar::setClient): Added.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::destroyScrollbar): Call Scrollbar::setClient().
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::~RenderListBox): Ditto.
- 5:45 PM Changeset in webkit [27584] by
-
- 3 edits in trunk/WebKitTools
Reviewed by Darin Adler.
- add an option to run-webkit-tests to ignore pixel test failures where all pixels differ by no more than a specified threshold
- DumpRenderTree/mac/ImageDiff.m: (main): (compareImages): (computePercentageDifferent):
- Scripts/run-webkit-tests:
- 3:45 PM Changeset in webkit [27583] by
-
- 4 edits in trunk
Fix <rdar://5569268> Crash when opening any FTP site in second tab/window
WebCore:
Fix <rdar://5569268> Crash when opening any FTP site in second tab/window
Reviewed by Sam.
No test possible.
- platform/win/SharedBufferWin.cpp: (WebCore::SharedBuffer::createWithContentsOfFile): Bail if we get an empty path, because _wfopen_s will crash if we pass it a null pointer.
WebKit/win:
Fix <rdar://5569268> Crash when opening any FTP site in second tab/window
Reviewed by Sam.
- WebView.cpp: (WebView::initWithFrame): Set the ftpDirectoryTemplatePath for every Page, not just the first one.
- 3:09 PM Changeset in webkit [27582] by
-
- 1 edit1 add in trunk/WebKit
2007-11-07 Mark Rowe <mrowe@apple.com>
Reviewed by Kevin Decker.
Fix 64-bit Mac build.
- WebKit.xcodeproj/project.pbxproj: Change paths specified relative to SRCROOT to be relative to PROJECT_DIR. PROJECT_DIR takes into account the projectDirPath setting of the project, which in this instance includes the necessary "mac" subdirectory.
- 1:54 PM Changeset in webkit [27581] by
-
- 3 edits7 adds in trunk
WebCore:
WebKit confuses width/height for Media Queries device-aspect-ratio evaluation
<http://bugs.webkit.org/show_bug.cgi?id=14893>
<rdar://problem/5380295>
Reviewed by Darin.
Tests: fast/css/device-aspect-ratio.html
fast/css/max-device-aspect-ratio.html
fast/css/min-device-aspect-ratio.html
- css/MediaQueryEvaluator.cpp: (WebCore::parseAspectRatio): Renamed method parameters from a/b to h/v. (WebCore::device_aspect_ratioMediaFeatureEval): Renamed local variables from a/b to h/v. Switched first two arguments of the call to cmpvalue() to fix the bug.
LayoutTests:
WebKit confuses width/height for Media Queries device-aspect-ratio evaluation
<http://bugs.webkit.org/show_bug.cgi?id=14893>
<rdar://problem/5380295>
Reviewed by Darin.
Each of the following tests creates a <link> element and dynamically sets its
media query based on the aspect ratio (width/height) of the current screen.
When the <link> element is attached to the <head> node, the test expects the
stylesheet to be loaded for the test to pass.
- fast/css/device-aspect-ratio-expected.txt: Added.
- fast/css/device-aspect-ratio.html: Added.
This test sets the device-aspect-ratio to the current size of the screen.
NOTE: This test passed before the fix.
- fast/css/max-device-aspect-ratio-expected.txt: Added.
- fast/css/max-device-aspect-ratio.html: Added.
This test sets the max-device-aspect ratio to 100/1 for landscape monitors or
1/1 for portrait (or square) monitors.
NOTE: This test failed before the fix.
- fast/css/min-device-aspect-ratio-expected.txt: Added.
- fast/css/min-device-aspect-ratio.html: Added.
This test sets the min-device-aspect ratio to 1/1 for landscape monitors or
1/100 for portrait (or square) monitors.
NOTE: This test failed before the fix.
- fast/css/resources/device-aspect-ratio.css: Added.
- 1:44 PM Changeset in webkit [27580] by
-
- 2 edits in trunk/WebCore
Roll out r27578 as it is not necessary.
- 12:59 PM Changeset in webkit [27579] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=15887 REGRESSION (r27576): Crash in RenderStyle::affectedByHoverRules clicking link on Digg
Test: fast/css/display-none-inline-style-change-crash.html
- dom/Element.cpp: (WebCore::Element::recalcStyle): Fixed the crash by null-checking the current style and removed other checks that are not strictly necessary.
LayoutTests:
Reviewed by Dave Hyatt.
- test for http://bugs.webkit.org/show_bug.cgi?id=15887 REGRESSION (r27576): Crash in RenderStyle::affectedByHoverRules clicking link on Digg
- fast/css/display-none-inline-style-change-crash-expected.txt: Added.
- fast/css/display-none-inline-style-change-crash.html: Added.
- 12:11 PM Changeset in webkit [27578] by
-
- 2 edits in trunk/WebCore
Reviewed by Kevin Decker.
Build fix for Leopard. Cast a size() as int to unsigned for proper
comparison.
- bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::writeHelper): Casted an int to unsigned for an unsigned to unsigned comparison.
- 11:31 AM Changeset in webkit [27577] by
-
- 2 edits in trunk/WebCore
Rubberstamped by Sam
Remove FrameLoaderClient methods from SVG that were pruned awhile ago
- platform/graphics/svg/SVGImageEmptyClients.h:
- 10:52 AM Changeset in webkit [27576] by
-
- 5 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix a bug where CSS rules with :hover in the ancestor chain stopped working after changing the inline style declaration of the ancestor
Test: fast/css/affected-by-hover-after-style-change.html
- dom/Element.cpp: (WebCore::Element::recalcStyle): If we are not forcing style recalculation for all descendants, preserve any "affected by {hover|active|drag} bits that we may have acquired from them. Also renamed _style to currentStyle.
WebKitSite:
Reviewed by Darin Adler.
- removed a workaround for the bug fixed in the WebCore part of this patch
- misc/DatabaseExample.html:
LayoutTests:
Reviewed by Darin Adler.
- test that CSS rules with :hover in the ancestor chain continue to work after changing the inline style declaration of the ancestor
- fast/css/affected-by-hover-after-style-change.html: Added.
- platform/mac/fast/css/affected-by-hover-after-style-change-expected.checksum: Added.
- platform/mac/fast/css/affected-by-hover-after-style-change-expected.png: Added.
- platform/mac/fast/css/affected-by-hover-after-style-change-expected.txt: Added.
- 9:56 AM Changeset in webkit [27575] by
-
- 10 edits in trunk/WebCore
Reviewed by Adam.
Bug 11920: Web Inspector should have Firebug-like CSS editing
http://bugs.webkit.org/show_bug.cgi?id=11920
- css/CSSComputedStyleDeclaration.h: (WebCore::CSSComputedStyleDeclaration::isPropertyImplicit): Return false. I'm not sure why this was true, but computed style has no concept of implicit. So false makes more sense and makes the code simpler in the inspector. This function was added for the inspector, so this isn't a compatibility change.
- page/inspector/PropertiesSection.js: Add a getter/setter to reset populated status.
- page/inspector/StylesSidebarPane.js: Some refactoring along with the main support for style editing.
- page/inspector/inspector.css: Style changes for propery editing and focus correctness.
- page/inspector/inspector.js: Look for a handleKeyEvent function of the focus element before trying to call a function based on the element's id. Call focused and blurred on the focused element when currentFocusElement is changed. Use the new listItemElement getter instead of the private property.
- page/inspector/treeoutline.js: No longer expand on double click if ondblclick is implemented. Shrink the toggle zone to 10px to better match the size of the arrow. Add an onattach call to allow generation of the title using the DOM element. Add listItemElement and childrenListElement getters.
- page/inspector/utilities.js: Add new helper prototype methods on CSSStyleDeclaration.
- page/inspector/DocumentPanel.js: Use the new listItemElement getter instead of the private property. Also expand the DOM node on double click now that the TreeOutline dosen't do it.
- page/inspector/Resource.js: Use the new listItemElement and childrenListElement getters instead of the private properties.
- 9:54 AM Changeset in webkit [27574] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-07 Mark Rowe <mrowe@apple.com>
Reviewed by Eric.
Fix up initialization after being mangled in r27572, and remove the
ternary expression as extraCost will always be zero for the numeric
heap.
- kjs/collector.cpp: (KJS::Collector::heapAllocate):
- 9:54 AM Changeset in webkit [27573] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-07 Mark Rowe <mrowe@apple.com>
Gtk build fix.
- kjs/regexp_object.cpp:
- 9:52 AM JavaScript performance improvement ideas edited by
- (diff)
- 9:32 AM Changeset in webkit [27572] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Beth Dakin.
Eliminated a bogus (though compiled-out) branch in the collector.
- kjs/collector.cpp: (KJS::Collector::heapAllocate):
- 9:18 AM Changeset in webkit [27571] by
-
- 9 edits in trunk
Reviewed by Darin Adler.
Fixed part of http://bugs.webkit.org/show_bug.cgi?id=15861
15% of string-validate-input.js is spent compiling the same regular expression.
Put RegExpImp properties into a static hashtable to avoid a slew of
PropertyMap churn when creating a RegExpImp.
Factored important bits of regular expression implementation out of
RegExpImp (the JS object) and into RegExp (the PCRE wrapper class),
making RegExp a ref-counted class. (This will help later.)
Removed PCRE_POSIX support because I didn't quite know how to test it
and keep it working with these changes.
1.1% SunSpider speedup. 5.8% speedup on string-validate-input.js.
- kjs/regexp.h: A few interface changes:
- Renamed "subpatterns()" => "numSubpatterns()"
- Made flag enumeration private and replaced it with public getters for specific flags.
- Made RegExp ref-counted so RegExps can be shared by RegExpImps.
- Made RegExp take a string of flags instead of an int, eliminating duplicated flag parsing code elsewhere.
- kjs/regexp_object.cpp: (KJS::RegExpProtoFunc::callAsFunction): For RegExp.compile:
- Fixed a bug where compile(undefined) would throw an exception.
- Removed some now-redundant code.
- Used RegExp sharing to eliminate an allocation and a bunch of PropertyMap thrash. (Not a big win since compile is a deprecated function. I mainly did this to test the plubming.)
LayoutTests:
Reviewed by Darin Adler.
Beefed up the RegExp.compile testcase to cover a mistake in the
original check-in and a mistake I made while developing my new patch.
- fast/js/resources/regexp-compile.js:
- 8:36 AM Changeset in webkit [27570] by
-
- 2 edits in trunk/JavaScriptCore
JavaScriptCore.pri expects OBJECTS_DIR to be set, so set it in
testkjs.pro, too, where it's included from.
- 8:14 AM Changeset in webkit [27569] by
-
- 2 edits in trunk/WebCore
Coding style fix.
- 7:52 AM Changeset in webkit [27568] by
-
- 2 edits in trunk/WebCore
For safety provide a default constructor for WindowFeatures().
ContextMenuController.cpp: createNewWindow as well as QWebPage need to
create a default initialized WindowFeatures object on the fly.
- 7:35 AM Changeset in webkit [27567] by
-
- 2 edits in trunk/WebKit/qt
Fix the Qt build.
- 6:45 AM Changeset in webkit [27566] by
-
- 5 edits in trunk
Fix "nmake clean" for the Qt/Windows build by replacing tmp/ with a variable that ends with the correct type of slash/backslash depending on the choice of compiler/make tool.
- 6:32 AM Changeset in webkit [27565] by
-
- 7 edits in trunk
Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.
- 6:32 AM Changeset in webkit [27564] by
-
- 3 edits in trunk/WebKit/qt
Changed QWebPageHistory::goToItem to take a value instead of a pointer.
- 6:32 AM Changeset in webkit [27563] by
-
- 2 edits in trunk/WebKit/qt
Removed unimplemented QWebHistoryItem::children() function
- 6:32 AM Changeset in webkit [27562] by
-
- 2 edits in trunk/WebKit/qt
Changed the getter functions in QWebSettings to transparently resolve against the default settings.
- 6:31 AM Changeset in webkit [27561] by
-
- 3 edits in trunk/WebKit/qt
Added explicit functions for resetting the font sizes and font families.
- 6:31 AM Changeset in webkit [27560] by
-
- 3 edits in trunk/WebKit/qt
Combined the font sizes accessors/setters under one setter/getter with an enum.
- 6:31 AM Changeset in webkit [27559] by
-
- 4 edits in trunk/WebKit/qt
Renamed QWebPage::userAgentStringForUrl(url) to QWebPage::userAgentFor(url);
- 6:31 AM Changeset in webkit [27558] by
-
- 3 edits in trunk/WebKit/qt
Renamed QWebPage::webActionTriggered to QWebPage::triggerAction
- 6:31 AM Changeset in webkit [27557] by
-
- 4 edits in trunk/WebKit/qt
Changed the virtual QWebPage::setWindowGeometry to be a geometryChangeRequest signal instead.
- 6:31 AM Changeset in webkit [27556] by
-
- 4 edits in trunk/WebKit/qt
Renamed QWebPage::webAction() to QWebPage::action()
- 6:31 AM Changeset in webkit [27555] by
-
- 3 edits in trunk/WebKit/qt
Removed a bunch of slots/functions that are now available through the new actions API.
- 6:31 AM Changeset in webkit [27554] by
-
- 2 edits in trunk/WebKit/qt
Added some more comments to the API after another round of API review with Lars.
- 6:31 AM Changeset in webkit [27553] by
-
- 5 edits in trunk/WebKit/qt
Moved QWebFrame::selectedText() to QWebPage::selectedText().
The currently selected text is a property of the page as a whole.
- 6:31 AM Changeset in webkit [27552] by
-
- 3 edits in trunk/WebKit/qt
Implemented support for settings propagation.
If an individual setting is not set in a page's QWebSettings then it is inherited from the default settings.
- 6:31 AM Changeset in webkit [27551] by
-
- 9 edits in trunk
Reworked the QWebSettings API.
QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().
- 6:30 AM Changeset in webkit [27550] by
-
- 5 edits in trunk
Made the QWebSettings::webGraphic functions static. The implementation was using QWebSettings::global() anyway.
- 6:30 AM Changeset in webkit [27549] by
-
- 4 edits in trunk
Moved the WebCore::Image specific function loadResourcePixmap from qwebsettings.cpp to ImageQt.cpp and made it static.
- 6:30 AM Changeset in webkit [27548] by
-
- 3 edits in trunk/WebKit/qt
Changed the icondatabase accessor to be a static function because it doesn't change the QWebSettings object.
- 6:30 AM Changeset in webkit [27547] by
-
- 2 edits in trunk/WebKit/qt
Changed the webAction() accessor to not be a slot but just a public function.
- 6:30 AM Changeset in webkit [27546] by
-
- 2 edits in trunk/WebKit/qt
Implemented createWindow() in QtLauncher.
- 6:30 AM Changeset in webkit [27545] by
-
- 2 edits in trunk/WebKit/qt
Implemented opening links in new windows
- 6:30 AM Changeset in webkit [27544] by
-
- 3 edits in trunk/WebKit/qt
Added and implemented the "OpenLink" action.
- 6:30 AM Changeset in webkit [27543] by
-
- 2 edits in trunk/WebKit/qt
Adjust the state of the reload action correctly.
- 6:30 AM Changeset in webkit [27542] by
-
- 3 edits in trunk/WebKit/qt
Initialize the undo/redo actions from QUndoStack. That automatically takes care of enabling/disabling them as well as the activation/trigger.
- 6:30 AM Changeset in webkit [27541] by
-
- 2 edits in trunk/WebKit/qt
Added undo/redo toolbar buttons, moved the location line edit into a separate toolbar.
- 6:30 AM Changeset in webkit [27540] by
-
- 4 edits in trunk/WebKit/qt
Update the editor actions when the selection changes.
- 6:29 AM Changeset in webkit [27539] by
-
- 2 edits in trunk/WebKit/qt
Added cut/copy/paste actions to the toolbar of QtLauncher
- 6:29 AM Changeset in webkit [27538] by
-
- 4 edits in trunk/WebKit/qt
Started working on keeping the state of the navigation actions up-to-date.
- 6:29 AM Changeset in webkit [27537] by
-
- 2 edits in trunk/WebKit/qt
Use the navigational web actions in the toolbar
- 6:29 AM Changeset in webkit [27536] by
-
- 4 edits in trunk/WebKit/qt
Store a bunch of QActions in QWebPagePrivate, corresponding to QWebPage::WebAction.
Added QWebPageContext to hold context sensitive information (for example used by the context menu).
- 6:29 AM Changeset in webkit [27535] by
-
- 3 edits in trunk/WebKit/qt
Moved the editing actions implemented in keyPressEvent into webActionTriggered.
- 6:29 AM Changeset in webkit [27534] by
-
- 3 edits in trunk/WebKit/qt
Introduced a central virtual void webActionTriggered(WebAction action) method that is called from various
convenience methods such as cut()/copy()/paste().
- 6:29 AM Changeset in webkit [27533] by
-
- 9 edits in trunk
Restructure the context menu classes for the Qt port. ContextMenu and ContextMenuItem don't store
QActions/QMenus anymore but just store the action type, tag, title and optionally submenu as created
in ContextMenu::populate().
For the actual Qt context menu we traverse this structure after sendContextMenuEvent and create a QMenu
out of it. That menu is currently not functional anymore though.
- 6:29 AM Changeset in webkit [27532] by
-
- 5 edits in trunk
Changed ContextMenu::setPlatformDescription for the Qt port to not show the qmenu right away
but instead just behave as a normal setter that takes ownership of the platform menu description (the qmenu).
Instead now QWebPage::contextMenuEvent() retrieves the QMenu after calling sendContextMenuEvent and calls exec()
on it.
- 6:29 AM Changeset in webkit [27531] by
-
- 6 edits in trunk
Changed to PlatformMouseEvent constructor to allow construction from a QContextMenuEvent.
Call sendContextMenuEvent on the event handler from a QWidget::contextMenuEvent re-implementation instead of in mousePressEvent.
- 6:28 AM Changeset in webkit [27530] by
-
- 4 edits in trunk/WebKit/qt
Turned onLoadProgressChanged into a real private slot.
- 6:28 AM Changeset in webkit [27529] by
-
- 8 edits in trunk
Make QWebHistory an explicitly shared object, returned as a pointer by QWebPage::history().
- 6:23 AM Changeset in webkit [27528] by
-
- 2 edits in trunk/WebKit/qt
comments on API changes that we'd like to do.
- 6:21 AM Changeset in webkit [27527] by
-
- 7 edits in trunk
Add a QWebPage::frameCreated() signal and fix DRT
The removal of createFrame in QWebPage broke the re-implementation
in DumpRenderTree. Instead emit a frameCreated() signal and
connect to it in DumpRenderTree.
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 6:19 AM Changeset in webkit [27526] by
-
- 4 edits in trunk/WebKit/qt
Remove QWebPage::createFrame()
now that QWebFrame doesn't have virtual methods anymore, there
is no need for a createFrame() factory method in QWebpage.
- 6:17 AM Changeset in webkit [27525] by
-
- 8 edits in trunk
Moved all the event handlers from QWebFrame into QWebPage.
This cleans up the public API and allows us to remove the
HackWebFrame hack in DumpRenderTree.
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 6:01 AM Changeset in webkit [27524] by
-
- 5 edits1 add in trunk
don't put nbsp's into the plan text paste
Fix both ClipboardQt and PasteboardQt to replace
nbsp's with spaces before putting the text onto the
native clipboard. This is consistent with Mac and Win
and fixes at least editing/pasteboard/4076267-3.html
- 6:01 AM Changeset in webkit [27523] by
-
- 1 edit110 adds in trunk/LayoutTests/platform/qt
Add now passing tests
The fix of umemcasecmp in UnicodeQt4.h fixed quite a lot
of test falures. Add these to our regression tests.
- 6:01 AM Changeset in webkit [27522] by
-
- 32 edits in trunk/LayoutTests
update test results after the last commit.
- 6:01 AM Changeset in webkit [27521] by
-
- 2 edits in trunk/JavaScriptCore
fix umemcasecmp
Pretty embarrassing bug. Has the potential to fix quite a few test failures.
- 6:00 AM Changeset in webkit [27520] by
-
- 2 edits in trunk/LayoutTests
Update the list of skipped tests.
Three more tests are passing.
- 5:45 AM Changeset in webkit [27519] by
-
- 2 edits in trunk/WebCore
Implement Pasteboard::writeImage()
- Pasteboard is now fully implemented. Copying of Images into the Clipboard is now supported.
- As with URLs we only copy into the Clipboard (and not additionally to the Selection)
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 5:45 AM Changeset in webkit [27518] by
-
- 2 edits in trunk/WebCore
Apple CodingStyle fixes
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 5:45 AM Changeset in webkit [27517] by
-
- 2 edits in trunk/WebCore
Implement Pasteboard::writeURL()
- The URL currently gets written as text/plain and text/uri-list. The win and mac port have some more types which we currently do not support. When supporting them we can use the 'titleString' as well.
- As with writeSelection we only copy into the Clipboard. We could consider copying into the Selection as well.
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 5:45 AM Changeset in webkit [27516] by
-
- 2 edits in trunk/WebCore
Kill whitespace
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 5:45 AM Changeset in webkit [27515] by
-
- 2 edits in trunk/WebKit/qt
Use correct UserAgent string.
- Only have one User Agent String and this place is QWebPage
- QWebPage::open -> QWebNetworkRequest -> QWebPage::open -> ResourceRequest -> FrameLoader::load -> QWebNetworkRequest
- ResourceRequest is != 0 when getting called from WebCore, we will only do requests when coming from WebCore and then we can use the User-Agent set with the help of the FrameLoaderClient
- We might want to change QWebNetworkRequest a bit
Signed-off-by: Lars Knoll <lars@trolltech.com>
- 5:18 AM Changeset in webkit [27514] by
-
- 2 edits in trunk/WebKitTools
Implemented the two Javascript prompt callbacks in qt/DumpRenderTree
to prevent the default implementation from popping up messageboxes.
- 4:47 AM Changeset in webkit [27513] by
-
- 2 edits131 adds in trunk/LayoutTests
add more passing test cases.
- 4:47 AM Changeset in webkit [27512] by
-
- 3 edits in trunk/WebCore
Use the correct function calls to convert a selection to
HTML or plain text.
- 4:47 AM Changeset in webkit [27511] by
-
- 2 edits in trunk/WebKit/qt
remove two notImplemented() warnings, as I believe we don't
have to implement these methods. Add some (commented out)
debug code in one place.
- 4:44 AM Changeset in webkit [27510] by
-
- 2 edits in trunk
Add WebKit/qt/Api to the dependency path when building QtLauncher and DumpRenderTree.
That means that changes to the public API of the Qt port also trigger a rebuild of the tools.
- 4:33 AM Changeset in webkit [27509] by
-
- 2 edits in trunk/WebCore
Some more clipboard fixes.
We have to set things immediately on the QClipBoard if the
Clipboard object is not for dragging.
This is due to the fact that the Clipboard object might be
rather long lived if accessed through javascript (it'll only
get deleted by JS garbage collection). We have to transfer
the data over to the QClipboard before that to make things work.
Fixes editing/execCommand/copy-without-selection.html
- 2:32 AM Changeset in webkit [27508] by
-
- 2 edits in trunk/WebCore
Fix compilation on Windows with non-cygwin perl.
- 2:14 AM Changeset in webkit [27507] by
-
- 1 edit in trunk/WebKit/mac/ChangeLog
Remove conflict marker.
- 1:53 AM Changeset in webkit [27506] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Corrected ChangeLog grammar.
- 1:52 AM Changeset in webkit [27505] by
-
- 1 edit1 move1 add in trunk/LayoutTests
Finished moving editing/pasteboard/5583362.html to platform/mac (this test was crashing in ObjC test plugin,
because it couldn't find its resources.
- editing/resources/plaintext-pasteboard-data.dat: Removed.
- platform/mac/editing/resources: Added.
- platform/mac/editing/resources/plaintext-pasteboard-data.dat: Copied from editing/resources/plaintext-pasteboard-data.dat.
- 12:11 AM Changeset in webkit [27504] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Brady Eidson.
- fix http://bugs.webkit.org/show_bug.cgi?id=15877 REGRESSION: r27486 caused a layout regression at my bank's website
Test: fast/block/float/overhanging-after-height-decrease-offsets.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):
LayoutTests:
Reviewed by Brady Eidson.
- test for http://bugs.webkit.org/show_bug.cgi?id=15877 REGRESSION: r27486 caused a layout regression at my bank's website
- fast/block/float/overhanging-after-height-decrease-offsets.html: Added.
- platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-offsets-expected.checksum: Added.
- platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-offsets-expected.png: Added.
- platform/mac/fast/block/float/overhanging-after-height-decrease-offsets-expected.txt: Added.
Nov 6, 2007:
- 11:23 PM Changeset in webkit [27503] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Eric.
- only collect when the heap is full, unless we have lots of extra cost garbage
1.1% SunSpider speedup.
This shouldn't hit memory use much since the extra space in those
blocks hangs around either way.
- kjs/collector.cpp: (KJS::Collector::heapAllocate): (KJS::Collector::collect): Fix logic error that reversed the sense of collect's return value.
- 11:00 PM Changeset in webkit [27502] by
-
- 1 edit1 move in trunk/LayoutTests
Move a Mac-specific test to platform/mac
- editing/pasteboard/5583362.html: Removed.
- platform/mac/editing/pasteboard/5583362.html: Added.
- 10:03 PM Changeset in webkit [27501] by
-
- 3 edits in trunk/JavaScriptCore
Avoid unnecessarily boxing the result from post inc/decrement for 0.3% gain in sunspider
Reviewed by Maciej
We now convert the common 'for (...; ...; <var>++) ...' to the semantically identical
'for (...; ...; ++<var>) ...'.
- 9:44 PM JavaScript performance improvement ideas edited by
- (diff)
- 9:41 PM Changeset in webkit [27500] by
-
- 2 edits in trunk/WebKitTools
2007-11-06 Eric Seidel <eric@webkit.org>
- Scripts/build-testkjs: build fix... too many $$
- 9:31 PM Changeset in webkit [27499] by
-
- 4 edits4 adds in trunk
WebCore:
Reviewed by Sam.
<rdar://problem/5575812> REGRESSION:When using absolute positioning
with overflow:auto div, WebKit seems to add an additional 15px
- rendering/RenderBox.cpp: (WebCore::RenderBox::containingBlockWidthForPositioned): We need to subtract off the vertical scrollbar width too.
LayoutTests:
Reviewed by Sam.
New test for <rdar://problem/5575812> REGRESSION:When using
absolute positioning with overflow:auto div, WebKit seems to add an
additional 15px
- fast/overflow/overflow-auto-position-absolute.html: Added.
- platform/mac/fast/overflow/overflow-auto-position-absolute-expected.checksum: Added.
- platform/mac/fast/overflow/overflow-auto-position-absolute-expected.png: Added.
- platform/mac/fast/overflow/overflow-auto-position-absolute-expected.txt: Added.
Test with changed results. The measurements in the rtl example now
more closely mirror the ltr example.
- platform/mac/fast/overflow/unreachable-overflow-rtl-bug-expected.txt:
- 9:29 PM Changeset in webkit [27498] by
-
- 5 edits in trunk/WebKit/win
Change WebLocalizableStrings to take UTF-8 C strings
This matches the way things work on the Mac, and will allow source
files containing localizable strings to be shared between Mac and
Windows. The old functions have not been removed for compatibility
reasons, but are now just wrappers around the new UTF-8 functions.
Reviewed by Ada.
- WebKit.vcproj/WebKit.def: Added new functions.
- WebKit.vcproj/WebKit_debug.def: Ditto.
- WebLocalizableStrings.cpp: (copyLocalizedStringFromBundle): Changed to take a WebCore::String representing the key. (localizedString): Refactored from WebLocalizedString. Takes a WebCore::String representing the key. (localizedLPCTSTR): Ditto for WebLocalizedLPCTSTR. (WebLocalizedStringUTF8): Added. Takes a UTF-8 C string as the key. (WebLocalizedLPCTSTRUTF8): Ditto. (WebLocalizedString): Changed to call localizedString. (WebLocalizedLPCTSTR): Changed to call localizedLPCTSTR.
- WebLocalizableStrings.h: Changed macros to use the new UTF-8 functions.
- 9:24 PM Changeset in webkit [27497] by
-
- 2 edits in trunk/WebKitTools
2007-11-06 Eric Seidel <eric@webkit.org>
Reviewed by Mark Rowe.
- Scripts/build-testkjs: return xcodebuild's exit status, instead of grep's
- 9:00 PM JavaScript performance improvement ideas edited by
- (diff)
- 7:01 PM Changeset in webkit [27496] by
-
- 2 edits24 moves1 add in trunk/WebKit
Move Mac files from WebKit into WebKit/mac.
- 5:13 PM Changeset in webkit [27495] by
-
- 3 edits5 adds in trunk
WebCore:
Reviewed by Dan Bernstein.
<rdar://problem/5583387> ASSERTION FAILED: !refChild->hasTagName(bodyTag) when pasting newline in plain text into rich text Mail
<rdar://problem/5583362> REGRESSION (5523.10.3-TOT): Newlines stripped when pasting plain text in Mail
- editing/markup.cpp: (WebCore::createFragmentFromText): Put paragraphs of text into clones of the block that encloses the input context, unless that block is the body, which shouldn't be cloned. In that case, use regular divs, as we did before r27369.
LayoutTests:
Reviewed by Dan Bernstein.
<rdar://problem/5583387> ASSERTION FAILED: !refChild->hasTagName(bodyTag) when pasting newline in plain text into rich text Mail
<rdar://problem/5583362> REGRESSION (5523.10.3-TOT): Newlines stripped when pasting plain text in Mail
- editing/pasteboard/5583362.html: Added.
- editing/resources/plaintext-pasteboard-data.dat: Added.
- platform/mac/editing/pasteboard/5583362-expected.checksum: Added.
- platform/mac/editing/pasteboard/5583362-expected.png: Added.
- platform/mac/editing/pasteboard/5583362-expected.txt: Added.
- 5:03 PM Changeset in webkit [27494] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-06 Eric Seidel <eric@webkit.org>
Reviewed by darin.
This fixes a regressed layout test for string + object
SunSpider claims this was an overall 0.3% speedup, although some individual tests were slower.
- kjs/nodes.cpp: (KJS::add): remove erroneous "fast path" for string + *
- 4:17 PM JavaScript performance improvement ideas edited by
- (diff)
- 4:12 PM JavaScript performance improvement ideas edited by
- (diff)
- 4:11 PM JavaScript performance improvement ideas edited by
- (diff)
- 4:06 PM Changeset in webkit [27493] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Eric Seidel.
Added toJSNumber, a fast path for converting a JSValue to a JS number,
and deployed it in postfix expressions. In the fast case this
eliminates a call to jsNumber.
0.4% speedup on SunSpider.
- ChangeLog:
- kjs/nodes.cpp: (KJS::PostIncResolveNode::evaluate): (KJS::PostIncLocalVarNode::evaluate): (KJS::PostDecResolveNode::evaluate): (KJS::PostDecLocalVarNode::evaluate): (KJS::PostIncBracketNode::evaluate): (KJS::PostDecBracketNode::evaluate): (KJS::PostIncDotNode::evaluate): (KJS::PostDecDotNode::evaluate): (KJS::UnaryPlusNode::evaluate):
- kjs/value.h: (KJS::JSValue::toJSNumber):
- 4:04 PM Changeset in webkit [27492] by
-
- 2 edits in trunk/WebCore
2007-11-06 Christian Dywan <christian@twotoasts.de>
Reviewed by Darin.
Fix http://bugs.webkit.org/show_bug.cgi?id=15828
Bug 15828: WebKit GTK include and lib directory is installed in qt4-named directory
- WebCore.pro: Use sane default install paths for the gtk port.
- 4:02 PM Changeset in webkit [27491] by
-
- 2 edits in trunk/WebKit/gtk
2007-11-06 Rodney Dawes <dobey@wayofthemonkey.com>
Fix http://bugs.webkit.org/attachment.cgi?id=17043&action=view
Bug 15766: [GTK] WebKit sometimes spews binary data as text/plain into iframes
FrameLoaderClient::objectContentType needs to check with the MIMETypeRegistry
to determine whether the given MIME type is displayable as an image or non-image.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (FrameLoaderClient::objectContentType): Change logic to match that in the Windows and Mac ports.
- 3:19 PM Changeset in webkit [27490] by
-
- 2 edits in trunk/LayoutTests
Correct test results.
- platform/mac/fast/layers/layer-visibility-expected.txt:
- 3:00 PM Changeset in webkit [27489] by
-
- 5 edits in trunk/LayoutTests
Reviewed by Hyatt.
Update test to cover
<rdar://problem/5521068>
Visibility not propagated correctly for children of a layer with z-index
The fix for this was (accidentally) already checked in with r27277,
with retroactive r=hyatt.
- fast/layers/layer-visibility.html:
- platform/mac/fast/layers/layer-visibility-expected.checksum:
- platform/mac/fast/layers/layer-visibility-expected.png:
- platform/mac/fast/layers/layer-visibility-expected.txt:
- 2:28 PM Changeset in webkit [27488] by
-
- 4 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
<rdar://problem/5576619>
REGRESSION: Caret disappears after deleting the last character in inline hole (15714)
- editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteSelection): Like the other TypingCommands, including both of the other deletion commands, call typingAddedToOpenCommand(), which takes the command's endingSelection and sets it as selection.
LayoutTests:
Reviewed by Darin Adler.
<rdar://problem/5576619> REGRESSION: Caret disappears after deleting the last character in inline hole (15714)
- platform/mac/editing/input/5576619-expected.checksum: Added.
- platform/mac/editing/input/5576619-expected.png: Added.
- platform/mac/editing/input/5576619-expected.txt: Added.
- platform/mac/editing/input/5576619.html: Added.
- platform/mac/editing/input/text-input-controller-expected.txt:
- 1:37 PM Changeset in webkit [27487] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15846 REGRESSION (r27387): Memory corruption when running fast/js/kde/delete.html
There was a mistake in the algorithm used to find an empty slot in the property
map entries vector; when we were putting in a new property value and not overwriting
an existing deleted sentinel, we would enlarge the entries vector, but would not
overwrite the stale data that's in the new part. It was easy to pin this down by
turning on property map consistency checks -- I never would have landed with this
bug if I had run the regression tests once with consistency checks on!
- kjs/property_map.cpp: (KJS::PropertyMap::put): Changed logic for the case where foundDeletedElement is false to always use the item at the end of the entries vector. Also allowed me to merge with the logic for the "no deleted sentinels at all" case.
- 1:03 PM Changeset in webkit [27486] by
-
- 4 edits6 adds in trunk
WebCore:
Reviewed by Antti Koivisto and Dave Hyatt.
- fix <rdar://problem/5582961> Incorrect layout and floating object list corruption when CSS decreases a block's height
Test: fast/block/float/overhanging-after-height-decrease.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): If after calculating the height it turns out that there are overhanging floats that were not overhanging before, rescan children with overhanging floats and add them. (WebCore::RenderBlock::layoutBlockChildren): Added a parameter that returns the lowest float bottom of any of the children. (WebCore::RenderBlock::addOverhangingFloats): Changed to return the lowest float bottom.
- rendering/RenderBlock.h:
LayoutTests:
Reviewed by Antti Koivisto and Dave Hyatt.
- test for <rdar://problem/5582961> Incorrect layout and floating object list corruption when CSS decreases a block's height
- fast/block/float/overhanging-after-height-decrease.html: Added.
- platform/mac-leopard/fast/block: Added.
- platform/mac-leopard/fast/block/float: Added.
- platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-expected.checksum: Added.
- platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-expected.png: Added.
- platform/mac/fast/block/float/overhanging-after-height-decrease-expected.txt: Added.
- 11:53 AM Changeset in webkit [27485] by
-
- 8 edits4 adds in trunk
WebCore:
Reviewed by Darin.
Switched all uses of HTMLImageLoader to use OwnPtrs.
- html/HTMLInputElement.h:
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::init): (WebCore::HTMLInputElement::~HTMLInputElement): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::attach):
- html/HTMLObjectElement.h:
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::HTMLObjectElement): (WebCore::HTMLObjectElement::~HTMLObjectElement): (WebCore::HTMLObjectElement::parseMappedAttribute): (WebCore::HTMLObjectElement::attach):
- html/HTMLVideoElement.h:
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::HTMLVideoElement): (WebCore::HTMLVideoElement::attach): (WebCore::HTMLVideoElement::detach): (WebCore::HTMLVideoElement::parseMappedAttribute):
LayoutTests:
Reviewed by Darin.
Added test for poster attribute.
- media/content/abe.png: Added.
- media/content/greenbox.png: Added.
- media/video-poster-expected.txt: Added.
- media/video-poster.html: Added.
- 11:49 AM Changeset in webkit [27484] by
-
- 2 edits in trunk/JavaScriptCore
Fix previous patch to use a 3 bit shift, a 16 bit shift causes a regression in sunspider.
RS=Darin
- 11:34 AM Changeset in webkit [27483] by
-
- 2 edits in trunk/JavaScriptCore
Replace boolean comparisons in AddNode with mask comparisons for a 0.2% improvement in sunspider.
Reviewed by Darin
- 10:56 AM Changeset in webkit [27482] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-06 Eric Seidel <eric@webkit.org>
Reviewed by darin.
SunSpider claims this is a 1.1% speedup.
- kjs/nodes.cpp: (KJS::throwOutOfMemoryError): Added, non inline. (KJS::addSlowCase): renamed from add(), non inline. (KJS::add): add fast path for String + String, Number + Number and String + *
- 10:43 AM Changeset in webkit [27481] by
-
- 4 edits in trunk/WebKit/win
Reviewed by Adam and Steve.
- added hooks needed to implement showModalDialog on Windows
- Interfaces/IWebUIDelegate.idl: Added canRunModal, createModalDialog, and runModal functions to the end of IWebUIDelegate3.
- WebChromeClient.h: Added uiDelegate and uiDelegate2 helper functions, so it's easier to write client functions.
- WebChromeClient.cpp: (WebChromeClient::createWindow): Implemented dialog case. Calls IWebUIDelegate3. (WebChromeClient::canRunModal): Implemented. Calls IWebUIDelegate3. (WebChromeClient::runModal): Ditto. (WebChromeClient::uiDelegate): Added. (WebChromeClient::uiDelegate2): Added. (WebChromeClient::uiDelegate3): Added.
- 10:11 AM Changeset in webkit [27480] by
-
- 5 edits6 adds in trunk
WebCore:
Reviewed by Darin.
Trigger media load on on src attribute changes as specified in new HTML5 draft.
Tests: media/video-src-change.html
media/video-src-remove.html
media/video-src-set.html
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attributeChanged):
- html/HTMLMediaElement.h:
LayoutTests:
Reviewed by Darin.
Tests for media src attribute changes.
- media/video-src-change-expected.txt: Added.
- media/video-src-change.html: Added.
- media/video-src-remove-expected.txt: Added.
- media/video-src-remove.html: Added.
- media/video-src-set-expected.txt: Added.
- media/video-src-set.html: Added.
- media/video-test.js:
- 10:10 AM Changeset in webkit [27479] by
-
- 2 edits in trunk/WebKit/win
Rubber-stamped by Adam Roben.
Windows build fix.
- WebFrame.cpp: (WebFrame::string): plainText() returns a String now.
- 9:48 AM Changeset in webkit [27478] by
-
- 3 edits5 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=15838 Incomplete repaint toggling "How you know this person" on Facebook
Test: fast/repaint/make-children-non-inline.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::makeChildrenNonInline): Repaint the block. This is needed because the inline children may be repositioned as they move into new anonymous blocks, but those blocks have no knowledge of where their children used to be, so they cannot invalidate those areas.
LayoutTests:
Reviewed by Darin Adler.
- repaint test for http://bugs.webkit.org/show_bug.cgi?id=15838 Incomplete repaint toggling "How you know this person" on Facebook
- fast/repaint/make-children-non-inline.html: Added.
- platform/mac/fast/repaint/make-children-non-inline-expected.txt: Added.
- platform/mac-leopard/fast/repaint: Added.
- platform/mac-leopard/fast/repaint/make-children-non-inline-expected.checksum: Added.
- platform/mac-leopard/fast/repaint/make-children-non-inline-expected.png: Added.
- 8:07 AM Changeset in webkit [27477] by
-
- 10 edits in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15847
Some editing cleanup
No change in functionality.
WebCore:
- editing/TextIterator.cpp: (WebCore::plainText):
- editing/TextIterator.h: Made WebCore::plainText() return String instead of DeprecatedString.
- bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject textUnderElement]): (-[WebCoreAXObject value]): (-[WebCoreAXObject doAXBoundsForTextMarkerRange:]): (-[WebCoreAXObject doAXNextSentenceEndTextMarkerForTextMarker:]): (-[WebCoreAXObject doAXPreviousSentenceStartTextMarkerForTextMarker:]): Updated for the above change. There is no need to explicitly convert to NSString now.
- editing/EditCommand.cpp: (WebCore::EditCommand::EditCommand): m_startingSelection and m_endingSelection are actually initialized in constructor body, so the work done in initializer list was wasted.
(WebCore::EditCommand::apply): Moved some stars.
(WebCore::EditCommand::unapply): Ditto.
(WebCore::EditCommand::reapply): Ditto.
(WebCore::EditCommand::setStartingSelection): The loop exit condition was evaluated twice,
removed one of the checks.
- editing/SelectionController.cpp: (WebCore::SelectionController::toString): plainText() result type now matches what we need here.
- page/mac/WebCoreFrameBridge.h:
- page/mac/WebCoreFrameBridge.mm: Removed unused -[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:granularity:] and -[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:granularity:].
WebKit:
- WebView/WebHTMLView.mm: (-[WebHTMLView deleteToEndOfLine:]): (-[WebHTMLView deleteToEndOfParagraph:]): WebCore had a duplicate of the same logic already. We are passing a boundary value to a function that expects granularity, this may need to be straightened out in the future.
- 1:08 AM Changeset in webkit [27476] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-06 Eric Seidel <eric@webkit.org>
Reviewed by mjs.
Avoid more UString creation.
SunSpider claims this is a 0.4% speedup.
- kjs/regexp_object.cpp: (KJS::RegExpObjectImp::construct): use UString::find(UChar)
Nov 5, 2007:
- 11:47 PM Changeset in webkit [27475] by
-
- 2 edits in trunk/WebCore
2007-11-05 Mark Rowe <mrowe@apple.com>
Mac build fix.
- bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::writeHelper):
- 11:30 PM Changeset in webkit [27474] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-05 Mark Rowe <mrowe@apple.com>
Mac build fix.
- kjs/array_object.cpp: (KJS::ArrayProtoFunc::callAsFunction):
- 11:20 PM Changeset in webkit [27473] by
-
- 3 edits in trunk/WebCore
Don't crash if SafariTheme can't be loaded
PlatformScrollBarSafari and RenderThemeSafari were not checking
whether SafariTheme was successfully loaded. All other uses of
SafariTheme already check this.
Reviewed by Steve.
- platform/win/PlatformScrollBarSafari.cpp: (WebCore::PlatformScrollbar::paintButton): (WebCore::PlatformScrollbar::paintTrack): (WebCore::PlatformScrollbar::paintThumb):
- rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::isControlStyled): (WebCore::RenderThemeSafari::paintCheckbox): (WebCore::RenderThemeSafari::paintRadio): (WebCore::RenderThemeSafari::paintButton): (WebCore::RenderThemeSafari::paintTextField): (WebCore::RenderThemeSafari::paintCapsLockIndicator): (WebCore::RenderThemeSafari::paintTextArea): (WebCore::RenderThemeSafari::paintMenuList): (WebCore::RenderThemeSafari::paintSliderThumb): (WebCore::RenderThemeSafari::paintSearchField): (WebCore::RenderThemeSafari::paintSearchFieldCancelButton): (WebCore::RenderThemeSafari::paintSearchFieldResultsDecoration): (WebCore::RenderThemeSafari::paintSearchFieldResultsButton):
- 11:20 PM Changeset in webkit [27472] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix
- kjs/list.h:
- 11:09 PM Changeset in webkit [27471] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-05 Mark Rowe <mrowe@apple.com>
Build fix. Add missing #include.
- kjs/operations.cpp:
- 10:48 PM Changeset in webkit [27470] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-05 Eric Seidel <eric@webkit.org>
Reviewed by mjs.
Remove another call to toString(exec)
SunSpider claims this is a 0.5% speedup.
- kjs/operations.cpp: (KJS::equal): remove another toString
- 10:39 PM Changeset in webkit [27469] by
-
- 1 edit6 adds in trunk/WebCore
Adding the rest of wx port's graphics impl.
Rubber-stamped by Maciej Stachowiak.
- 10:24 PM Changeset in webkit [27468] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-05 Eric Seidel <eric@webkit.org>
- kjs/operations.cpp: (KJS::equal): correct broken change.
- 10:17 PM Changeset in webkit [27467] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-05 Eric Seidel <eric@webkit.org>
Reviewed by mjs.
Remove one more call to toString(exec).
SunSpider claims this is a 0.7% speedup.
- kjs/operations.cpp: (KJS::equal): remove a call to toString()
- 9:52 PM Changeset in webkit [27466] by
-
- 11 edits4 adds in trunk/WebCore
wx port bug fixes and new files to get platform/wx building on trunk.
Rubber-stamped by Maciej Stachowiak.
- 9:43 PM Changeset in webkit [27465] by
-
- 12 edits in trunk/WebCore
Reviewed by Maciej.
Fix for <rdar://problem/5579999> Add poster attribute for video element
- html/HTMLAttributeNames.in: Added poster attribute.
- html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement): Calls imageSourceAttributeName instead of having special cases for the different kinds of elements.
- dom/Element.cpp: (WebCore::Element::imageSourceAttributeName): Added.
- dom/Element.h:
- html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::imageSourceAttributeName): Added.
- html/HTMLObjectElement.h:
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::movieNetworkStateChanged): Calls updatePosterImage when the network state is empty and when the first frame has been loaded.
- html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::rendererIsNeeded): Made this inline. HTMLVideoElement now also implements this.
- html/HTMLVideoElement.idl: Added case for poster attribute.
- html/HTMLVideoElement.h: Added image loader and flag to keep track of whether or not the poster image should be shown.
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::HTMLVideoElement): Initialize m_imageLoader and m_shouldShowPosterImage. (WebCore::HTMLVideoElement::rendererIsNeeded): Calls HTMLElement::rendererIsNeeded since HTMLMediaElements have renderer by default. (WebCore::HTMLVideoElement::createRenderer): Create a RenderImage or RenderVideo depending on whether or not the poster image should be shown. (WebCore::HTMLVideoElement::attach): Set up image loader and RenderImage if necessary. (WebCore::HTMLVideoElement::detach): Delete image loader if its no longer needed. (WebCore::HTMLVideoElement::parseMappedAttribute): Added case to process poster attribute. (WebCore::HTMLVideoElement::poster): Added getter for poster attribute. (WebCore::HTMLVideoElement::setPoster): Added setter for poster attribute. (WebCore::HTMLVideoElement::isURLAttribute): Added. (WebCore::HTMLVideoElement::imageSourceAttributeName): Added. (WebCore::HTMLVideoElement::updatePosterImage): Added. Updates m_shouldShowPosterImage and if its changed, detaches and attaches so the renderer is correct.
- 9:39 PM JavaScript performance improvement ideas edited by
- (diff)
- 9:25 PM Changeset in webkit [27464] by
-
- 5 edits in trunk
Fix <rdar://5563572> SVG image support is turned off
WebCore:
Fix <rdar://5563572> SVG image support is turned off
Turned on SVG images for all platforms.
Reviewed by Eric.
- WebCore.vcproj/WebCore.vcproj: Added SVGImage.{cpp,h}
- loader/CachedImage.cpp: (WebCore::CachedImage::createImage): Removed platform checks for SVGImage.
LayoutTests:
Remove a now-passing test from the Windows Skipped file
Reviewed by Eric.
- platform/win/Skipped:
- 8:55 PM Changeset in webkit [27463] by
-
- 2 edits in trunk/WebCore
Fix spelling errors in ChangeLogs, no review
- 8:43 PM Changeset in webkit [27462] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
QTMovieView can generate callbacks during paint. This can lead to crashes.
Delay callbacks so they get handled after painting is completed. No test case,
I don't know how to reliably reproduce this.
- platform/graphics/mac/MoviePrivateQTKit.mm: (WebCore::MoviePrivate::MoviePrivate): (WebCore::MoviePrivate::~MoviePrivate): (WebCore::MoviePrivate::paint): (-[WebCoreMovieObserver initWithCallback:WebCore::]): (-[WebCoreMovieObserver disconnect]): (-[WebCoreMovieObserver loadStateChanged:]): (-[WebCoreMovieObserver rateChanged:]): (-[WebCoreMovieObserver sizeChanged:]): (-[WebCoreMovieObserver timeChanged:]): (-[WebCoreMovieObserver volumeChanged:]): (-[WebCoreMovieObserver didEnd:]): (-[WebCoreMovieObserver setDelayCallbacks:]):
- 8:12 PM Changeset in webkit [27461] by
-
- 4 edits in trunk/WebCore
Reviewed by Adam.
Add some missing WebCore* prefixes to ObjC classes
- platform/mac/FileChooserMac.mm: (WebCore::FileChooser::FileChooser):
- platform/mac/SharedBufferMac.mm: (WebCore::SharedBuffer::createNSData): (WebCore::SharedBuffer::createCFData):
- platform/mac/SharedTimerMac.cpp: (WebCore::setSharedTimerFireTime):
- 6:53 PM Changeset in webkit [27460] by
-
- 3 edits in trunk/WebKit/gtk
2007-11-05 Christian Dywan <christian@twotoasts.de>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=15409
FrameLoaderClientGtk hardcodes data, including platform to Linux i686
Compute a proper user agent string.
Patch includes fixes by Alp.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::agentPlatform): (WebKit::agentOS): (WebKit::composeUserAgent): (WebKit::FrameLoaderClient::userAgent):
- WebCoreSupport/FrameLoaderClientGtk.h:
- 6:10 PM Changeset in webkit [27459] by
-
- 6 edits in trunk
<rdar://problem/5579772> Regression: AltGr does not work
Testing whether alt-key is down is not the right test for system key event.
Added a m_isSystemKey flag in PlatformKeyboardEvent to keep track of whether
this is a system key event, check that flag instead in handleEditingKeyboardEvent().
Reviewed by Oliver.
- 4:35 PM Changeset in webkit [27458] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-05 Mark Rowe <mrowe@apple.com>
Gtk build fix.
- pcre/pcre.pri:
- 4:02 PM Changeset in webkit [27457] by
-
- 2 edits in trunk/WebKit/win
Build fix.
Reviewed by Tristan.
- WebChromeClient.h:
- 3:56 PM Changeset in webkit [27456] by
-
- 3 edits in trunk/WebKitLibraries
Reviewed by Sam.
Update WKQTMovieViewSetDrawSynchronously.
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
- 3:21 PM Changeset in webkit [27455] by
-
- 2 edits in trunk/WebKit
- WebView/WebView.mm: (-[WebView _searchWithSpotlightFromMenu:]):
Teeny style tweak to test svn access on other machine
- 3:12 PM Changeset in webkit [27454] by
-
- 2 edits in trunk/WebKit
- WebView/WebView.mm: (-[WebView computedStyleForElement:pseudoElement:]):
Teeny style tweak to test svn access
- 3:05 PM Changeset in webkit [27453] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-05 Mark Rowe <mrowe@apple.com>
Gtk build fix.
- kjs/list.cpp:
- 2:43 PM Changeset in webkit [27452] by
-
- 23 edits in trunk
qt:
Reviewed by Darin Adler.
- WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::createWindow):
- WebCoreSupport/ChromeClientQt.h: Revised to use new WebCore ChromeClient createWindow API.
WebCore:
Reviewed by Darin Adler.
- WebCore.xcodeproj/project.pbxproj: Set WindowFeatures.h as a Private header.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): Revised to use a single createWindow function instead of two createWindow functions and one createModalDialog function. The logic for this is now addressed in WebKit in an effort to make this easier to follow.
- page/Chrome.cpp: (WebCore::Chrome::createWindow):
- page/Chrome.h:
- page/ChromeClient.h:
- page/ContextMenuController.cpp: (WebCore::openNewWindow):
- platform/graphics/svg/SVGImageEmptyClients.h: (WebCore::SVGEmptyChromeClient::createWindow): Revised to take new additional windowFeatures parameter.
WebKit:
Reviewed by Darin Adler.
- DefaultDelegates/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:createWebViewWithRequest:windowFeatures:]): Forward the UI delegate to call webView:createWebViewWithRequest: if this method doesn't exist.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchCreatePage):
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadPluginRequest:]):
- WebView/WebView.mm: (-[WebView _openNewWindowWithRequest:]): Revised to use new webView:createWebViewWithRequest:windowFeatures: callback.
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::createWindow): Added a new createWindow that accepts 3 parameters, so we can pass up windowFeatures to the chrome. Removed createModalDialog to use new createWindow function.
- WebView/WebUIDelegatePrivate.h: Added new webView:createWebViewWithRequest:windowFeatures: method.
win:
Reviewed by Darin Adler.
Part of the WebKit/WebCore API changes for
<rdar://problem/5368188>
- WebChromeClient.cpp: (WebChromeClient::createWindow): Removed usage of createModalDialog and revised to use new createWindow ChromeClient API.
- 2:02 PM Changeset in webkit [27451] by
-
- 2 edits in trunk/JavaScriptCore
Touched a file to test my new HTTP access.
- kjs/scope_chain.cpp:
- 1:56 PM Changeset in webkit [27450] by
-
- 1 edit1 add in trunk/JavaScriptGlue
Build fix.
- ForwardingHeaders/kjs/value.h: Added.
- 1:35 PM Changeset in webkit [27449] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-05 Alp Toker <alp@atoker.com>
Unreviewed build fix for qmake-based ports.
Someone with a better understanding of qmake still needs to sort out
the INCLUDEPATH/DEPENDPATH mess.
- JavaScriptCore.pri:
- 1:27 PM Changeset in webkit [27448] by
-
- 15 edits1 add in trunk
Reviewed by Darin Adler.
Switched List implementation from a custom heap allocator to an inline
Vector, for a disappointing .5% SunSpider speedup.
Also renamed List::slice to List::getSlice because "get" is the
conventional prefix for functions returning a value through an out
parameter.
- kjs/array_object.cpp: (KJS::ArrayProtoFunc::callAsFunction): Removed some redundant function calls and memory accesses.
- kjs/bool_object.cpp: (BooleanObjectImp::construct): Removed questionable use of iterator.
- kjs/list.cpp:
- kjs/list.h: New List class, implemented in terms of Vector. Two
interesting differences:
- The inline capacity is 8, not 5. Many of the Lists constructed during a SunSpider run are larger than 5; almost none are larger than 8.
- The growth factor is 4, not 2. Since we can guarantee that Lists aren't long-lived, we can grow them more aggressively, to avoid excessive copying.
- kjs/regexp_object.cpp: (RegExpObjectImp::construct): Removed redundant function calls.
- kjs/string_object.cpp: (KJS::StringObjectImp::construct): Removed questionable use of iterator.
- wtf/Vector.h: (WTF::::uncheckedAppend): Added a fast, unchecked version of append.
WebCore:
Reviewed by Darin Adler.
Small adaptations to new KJS::List class.
- bindings/js/kjs_window.cpp: (KJS::WindowFunc::callAsFunction): (KJS::ScheduledAction::ScheduledAction):
WebKit:
Reviewed by Darin Adler.
Small adaptations to new KJS::List class.
- ForwardingHeaders/kjs/value.h: Added.
- 1:09 PM Changeset in webkit [27447] by
-
- 3 edits in trunk/JavaScriptCore
2007-11-05 Mark Rowe <mrowe@apple.com>
Reviewed by Alp Toker.
Add DEPENDPATH to JavaScriptCore and pcre to help qmake with dependencies.
- JavaScriptCore.pri:
- pcre/pcre.pri:
- 10:57 AM Changeset in webkit [27446] by
-
- 3 edits in trunk/WebKitTools
Add support on Windows for WEBKIT_TESTFONTS
This environment variable lets you specify where the fonts to be used
by DumpRenderTree reside. The Qt port is already using this, so I'm
just following their lead.
Reviewed by Darin.
- DumpRenderTree/win/DumpRenderTree.cpp: (exePath): Refactored code out of initialize(). (fontsPath): Returns either $WEBKIT_TESTFONTS or DumpRenderTree.resources. (initialize): Use the new fontsPath function. (main): Use the new exePath function.
- Scripts/run-webkit-tests: Propagate the WEBKIT_TESTFONTS environment variable to DRT, like Qt does.
- 10:57 AM Changeset in webkit [27445] by
-
- 4 edits in trunk/WebKit/win
Add IWebCache::disabled
This matches the Mac WebCache class.
Reviewed by Sam.
- Interfaces/IWebCache.idl:
- WebCache.cpp: (WebCache::disabled):
- WebCache.h:
- 10:57 AM Changeset in webkit [27444] by
-
- 9 edits3 adds in trunk
Add IWebInspector and a way to get one from a WebView
WebCore:
Allow passing a base class pointer to COMPtr::copyRefTo
Reviewed by Sam.
- platform/win/COMPtr.h:
WebKit/win:
Add IWebInspector and a way to get one from a WebView
This API matches the Mac one added in r27266.
Reviewed by Sam.
- Interfaces/IWebInspector.idl: Added.
- Interfaces/IWebViewPrivate.idl: Added a new inspector method to match Mac.
- WebInspector.cpp: Added. (WebInspector::createInstance): (WebInspector::WebInspector): (WebInspector::~WebInspector): (WebInspector::webViewClosed): (WebInspector::QueryInterface): (WebInspector::AddRef): (WebInspector::Release): (WebInspector::show): (WebInspector::showConsole): (WebInspector::showTimeline): (WebInspector::close): (WebInspector::attach): (WebInspector::detach):
- WebInspector.h: Added.
- WebKit.vcproj/Interfaces.vcproj: Added IWebInspector.idl.
- WebKit.vcproj/WebKit.vcproj: Added WebInspector.{cpp,h}.
- WebKit.vcproj/WebKitGUID.vcproj: Added IWebInspector_i.c.
- WebView.cpp: (WebView::close): Notify the WebInspector that we're closing. (WebView::inspector): Added.
- WebView.h:
- 10:56 AM Changeset in webkit [27443] by
-
- 2 edits in trunk/WebKit/win
Cache strings that come directly from WebLocalizedString
Reviewed by Steve.
- WebLocalizableStrings.cpp: (copyLocalizedStringFromBundle): This used to be WebLocalizedString, but is now just a static helper function. (findCachedStringInMap): Added static helper. (findCachedString): Refactored and cleaned up code from WebLocalizedLPCTSTR. (cacheString): Ditto. (WebLocalizedString): Rewrote to use the new helper functions. (WebLocalizedLPCTSTR): Changed to use the new helper functions.
- 10:55 AM Changeset in webkit [27442] by
-
- 2 edits in trunk/WebKit/win
Only override the default user agent string if we're actually given a custom one
Reviewed by Sam.
- WebView.cpp: (WebView::setCustomUserAgent):
- 10:52 AM Changeset in webkit [27441] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Oliver Hunt.
- fix ASSERTION FAILED: !HashTranslator::equal(KeyTraits::emptyValue(), key) when a class attribute is all-whitespace
Test: fast/dom/class-all-whitespace.html
- dom/StyledElement.cpp: (WebCore::StyledElement::parseMappedAttribute): Check if there is any non-whitespace character in the class attribute.
LayoutTests:
Reviewed by Oliver Hunt.
- test that an all-whitespace class attribute does not cause an assertion failure
- fast/dom/class-all-whitespace-expected.txt: Added.
- fast/dom/class-all-whitespace.html: Added.
- 10:23 AM Changeset in webkit [27440] by
-
- 3 edits in trunk/WebCore
Reviewed by Sam
Add transaction blocking to the DatabaseAuthorizer in preparation for the new version
of the sql storage API
- storage/DatabaseAuthorizer.cpp: (WebCore::DatabaseAuthorizer::allowTransaction):
- storage/DatabaseAuthorizer.h:
- 8:34 AM Changeset in webkit [27439] by
-
- 2 edits in trunk/WebCore
2007-11-05 Mark Rowe <mrowe@apple.com>
Reviewed by Alp Toker.
Have getMIMETypeForExtension return a null string when no MIME type is known
for the extension rather than returning "text/plain". This prevents plugin data
being dumped into object elements when plugins are disabled.
- platform/gtk/MIMETypeRegistryGtk.cpp: (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
- 7:01 AM Changeset in webkit [27438] by
-
- 2 edits in trunk/WebKitTools
2007-11-05 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Alp Toker.
Remove buggy "autocomplete" from GtkLauncher as it causes more problems than it solves.
- GtkLauncher/main.cpp: (goToURLBarText): (main):
- 6:39 AM Changeset in webkit [27437] by
-
- 3 edits in trunk/WebKit/gtk
2007-11-05 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Alp Toker.
Remove unused m_firstData member from FrameLoaderClientGtk.
- WebCoreSupport/FrameLoaderClientGtk.cpp:
- WebCoreSupport/FrameLoaderClientGtk.h:
- 6:39 AM Changeset in webkit [27436] by
-
- 2 edits in trunk/WebKit/gtk
2007-11-05 Mark Rowe <mrowe@apple.com>
Reviewed by Alp Toker.
Fix http://bugs.webkit.org/show_bug.cgi?id=15842
Bug 15842: [Gtk] about:blank doesn't work
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::finishedLoading): Set the encoding on the frame loader to get work done that is normally done when the first bit of data is received, even in the case of a document with no data (like about:blank).
- 6:30 AM Changeset in webkit [27435] by
-
- 2 edits in trunk/LayoutTests
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15841
fast/dom/Document/early-document-access.html crashes under GuardMalloc
- fast/dom/Document/early-document-access.html: Don't check for open() timeout; wait for popup window to close as long as it takes.
Nov 4, 2007:
- 10:38 PM Changeset in webkit [27434] by
-
- 2 edits in trunk/WebKitTools
bisect-builds doesn't work with nightly build r19992 or newer on Leopard
<http://bugs.webkit.org/show_bug.cgi?id=15830>
Reviewed by Timothy.
Restrict the range of nightly builds used by the bisect-builds script
based on the version of Safari and the version of Mac OS X being used.
Mac OS X 10.4: Safari 2.0: r11976 or newer
Mac OS X 10.4: Safari 3.0: r19992 or newer
Mac OS X 10.5: Safari 2.0: r19594 or newer
Mac OS X 10.5: Safari 3.0: r25124 or newer
- Scripts/bisect-builds: (findMacOSXVersion): Added. (makeNightlyList): Added argument to provide version of Mac OS X. Restrict range of nightly builds based on Safari and Mac OS X versions.
- 5:37 PM Changeset in webkit [27433] by
-
- 4 edits in trunk/WebCore
Rubber-stamped by Adam Roben.
Rename SecurityOrigin::allowsAccessFrom to SecurityOrigin::canAccess to
clear up ambiguity.
- bindings/js/kjs_window.cpp: (KJS::Window::isSafeScript):
- platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canAccess):
- platform/SecurityOrigin.h:
- 4:20 PM Changeset in webkit [27432] by
-
- 1 edit29 adds in trunk/WebKitSite
Land the HTML Editing Toolbar demo from WWDC 2007.
- demos: Added.
- demos/editingToolbar: Added.
- demos/editingToolbar/FancyToolbar.css: Added.
- demos/editingToolbar/FancyToolbar.js: Added.
- demos/editingToolbar/FancyToolbarImages: Added.
- demos/editingToolbar/FancyToolbarImages/button.png: Added.
- demos/editingToolbar/FancyToolbarImages/buttonLeft.png: Added.
- demos/editingToolbar/FancyToolbarImages/buttonMiddle.png: Added.
- demos/editingToolbar/FancyToolbarImages/buttonPressed.png: Added.
- demos/editingToolbar/FancyToolbarImages/buttonPressedLeft.png: Added.
- demos/editingToolbar/FancyToolbarImages/buttonPressedMiddle.png: Added.
- demos/editingToolbar/FancyToolbarImages/buttonPressedRight.png: Added.
- demos/editingToolbar/FancyToolbarImages/buttonRight.png: Added.
- demos/editingToolbar/FancyToolbarImages/camera.png: Added.
- demos/editingToolbar/FancyToolbarImages/link.png: Added.
- demos/editingToolbar/FancyToolbarImages/textAlign.png: Added.
- demos/editingToolbar/FancyToolbarImages/toolbarOutline.png: Added.
- demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottom.png: Added.
- demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomLeft.png: Added.
- demos/editingToolbar/FancyToolbarImages/toolbarOutlineBottomRight.png: Added.
- demos/editingToolbar/FancyToolbarImages/toolbarOutlineLeft.png: Added.
- demos/editingToolbar/FancyToolbarImages/toolbarOutlineRight.png: Added.
- demos/editingToolbar/FancyToolbarImages/toolbarOutlineTop.png: Added.
- demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopLeft.png: Added.
- demos/editingToolbar/FancyToolbarImages/toolbarOutlineTopRight.png: Added.
- demos/editingToolbar/content.html: Added.
- demos/editingToolbar/images: Added.
- demos/editingToolbar/images/safari.png: Added.
- demos/editingToolbar/index.html: Added.
- 4:09 PM Changeset in webkit [27431] by
-
- 7 edits3 adds in trunk/WebCore
Reviewed by Adam.
Bug 15834: There are many subtle bugs in the Styles pane of the Web Inspector
http://bugs.webkit.org/show_bug.cgi?id=15834
- Broke up DocumentPanel and added three SidebarPane sub-classes.
- Fixed many Style pane bugs, including:
- Poor handling of duplicate properties in the same rule. Some of this can't be fixed since we can't only get the "winning" value for duplicate properties. So we should only show one entry per unique property name.
- Computed style does not show font shorthand sub-properties if 'font' was used.
- Property priority was broken, the wrong properties were crossed out.
- The 'border' shorthand shows null for the shorthand value.
- Shorthands didn't show their priority (e.g. !important).
- HSL and HTML hex colors didn't have preview swatch blocks.
- Code refactoring, making it easier to reuse for console.log later.
- page/inspector/DocumentPanel.js: Move sidebar pane code to three seperate classes in new files.
- page/inspector/MetricsSidebarPane.js: Added.
- page/inspector/Panel.js: Remove an InspectorController.log() call.
- page/inspector/PropertiesSection.js: Add the section to the TreeOutline. So TreeElements can access properties on their section.
- page/inspector/PropertiesSidebarPane.js: Added.
- page/inspector/SidebarPane.js: Remove the explicit asignment of the onexpand and oncollapse to null. These were hiding prototypes.
- page/inspector/StylesSidebarPane.js: Added.
- page/inspector/inspector.html: Include the new script files.
- page/inspector/treeoutline.js: If a null representedObject is passed in just use a empty object.
- 2:36 PM Changeset in webkit [27430] by
-
- 9 edits in trunk/WebKitTools
Reviewed by Maciej.
- This patch involves several changes, all of them were noticed that they were needed by the work being done in WebKit to get Drosera and WebKit working together on Windows.
- The changes are: 1) Added a debugger console for output messages. 2) Drosera now listens for the WebKit server (before, the server would have to be running before Drosera was started.) 3) Fixed a bug where the WebView started out as 0x0 pixels. 4) Fixed a bug when there is no scope. 5) Added the HTML, JS, and CSS to the project file to make them easy to find. 6) Made the ServerConnection functions virtual.
- Drosera/win/DebuggerClient.cpp: This is part of how Drosera listens for the WebKit server. (DebuggerClient::DebuggerClient): (DebuggerClient::~DebuggerClient): (DebuggerClient::didFinishLoadForFrame): (DebuggerClient::serverConnected): (DebuggerClient::attemptToCreateServerConnection):
- Drosera/win/DebuggerClient.h: Ditto.
- Drosera/win/DebuggerDocumentPlatform.cpp: Fixed a bug when there is no scope. (DebuggerDocument::getPlatformLocalScopeVariableNamesForCallFrame): (DebuggerDocument::platformValueForScopeVariableNamed):
- Drosera/win/Drosera.cpp: (_tWinMain): Added a console in debug for output messages. (Drosera::Drosera): Listen for server. (Drosera::initUI): The server now Initializes COM. (Drosera::serverConnected): Part of the listening for the server. (Drosera::attemptToCreateServerConnection): Ditto.
- Drosera/win/Drosera.h: New interface for listening for the server.
- Drosera/win/Drosera.vcproj/Drosera.vcproj: Added HTML, JS, and CSS files to the VS project.
- Drosera/win/ServerConnection.cpp: Part of listening for the server connection. (ServerConnection::ServerConnection): (ServerConnection::attemptToCreateServerConnection):
- Drosera/win/ServerConnection.h: Ditto and virtualized the Interface methods. (ServerConnection::serverConnected):
- 2:30 PM Changeset in webkit [27429] by
-
- 1 edit in trunk/WebKitTools/FindSafari
Add svn:ignore for vcproj temp files under FindSafari.
- 12:27 PM Changeset in webkit [27428] by
-
- 4 edits in trunk/WebKitTools
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=15832
fast/dom/gc-10.html crashes when run alone
Check for !done before using objects that can be already deallocated.
- DumpRenderTree/mac/EditingDelegate.mm: (-[EditingDelegate webView:shouldBeginEditingInDOMRange:]): (-[EditingDelegate webView:shouldEndEditingInDOMRange:]): (-[EditingDelegate webView:shouldInsertNode:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldInsertText:replacingDOMRange:givenAction:]): (-[EditingDelegate webView:shouldDeleteDOMRange:]): (-[EditingDelegate webView:shouldChangeSelectedDOMRange:toDOMRange:affinity:stillSelecting:]): (-[EditingDelegate webView:shouldApplyStyle:toElementsInDOMRange:]): (-[EditingDelegate webView:shouldChangeTypingStyle:toStyle:]): (-[EditingDelegate webViewDidBeginEditing:]): (-[EditingDelegate webViewDidChange:]): (-[EditingDelegate webViewDidEndEditing:]): (-[EditingDelegate webViewDidChangeTypingStyle:]): (-[EditingDelegate webViewDidChangeSelection:]):
- DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): (-[FrameLoadDelegate webView:didCommitLoadForFrame:]): (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): (-[FrameLoadDelegate webView:didFailLoadWithError:forFrame:]): (-[FrameLoadDelegate webView:windowScriptObjectAvailable:]): (-[FrameLoadDelegate webView:didClearWindowObject:forFrame:]): (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]): (-[FrameLoadDelegate webView:didReceiveServerRedirectForProvisionalLoadForFrame:]): (-[FrameLoadDelegate webView:didReceiveIcon:forFrame:]): (-[FrameLoadDelegate webView:didChangeLocationWithinPageForFrame:]): (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]): (-[FrameLoadDelegate webView:didCancelClientRedirectForFrame:]): (-[FrameLoadDelegate webView:willCloseFrame:]): (-[FrameLoadDelegate webView:didFinishDocumentLoadForFrame:]): (-[FrameLoadDelegate webView:didHandleOnloadEventsForFrame:]):
- DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:didReceiveResponse:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]): (-[ResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]): (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
- 8:46 AM Changeset in webkit [27427] by
-
- 2 edits in trunk/WebCore
Fix build when spaces appear in the WebKit source path.
Reviewed by Mark Rowe.
- bindings/scripts/IDLParser.pm: Use safer open() method which lists arguments individually and prevents the need to work around spaces in the path.
- 8:13 AM Changeset in webkit [27426] by
-
- 2 edits in trunk/WebKitSite
CIA has changed its hostname from cia.navi.cx to cia.vc
<http://bugs.webkit.org/show_bug.cgi?id=15829>
Reviewed by Mitz.
- contact.html: Updated links to CIA.
- 7:03 AM Changeset in webkit [27425] by
-
- 2 edits in trunk/WebCore
2007-11-04 Alp Toker <alp@atoker.com>
Reviewed by Alexey Proskuryakov.
Fix a crash when no clipboard text is available
- platform/gtk/PasteboardGtk.cpp: (WebCore::Pasteboard::plainText):
- 1:48 AM Changeset in webkit [27424] by
-
- 2 edits in trunk/WebKitTools
2007-11-04 Mark Rowe <mrowe@apple.com>
Build fix. Don't use Carbon.h as the prefix header as it triggers
warnings that would otherwise be suppressed due to it being a system header.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
Nov 4, 2007:
- 1:58 AM Changeset in webkit [27423] by
-
- 3 edits in trunk/SunSpider
- hosted/sunspider.html: Tweaked formatting a bit.
- 1:28 AM Changeset in webkit [27422] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15826 optimize opcode loop and case insensitive ASCII compares for a 30% speedup
SunSpider says it's 2.6% faster overall, 32.5% in the regular expression tests.
- pcre/pcre_internal.h: Added OP_ASCII_CHAR and OP_ASCII_LETTER_NC.
- pcre/pcre_compile.c: (find_fixedlength): Added cases for OP_ASCII_CHAR and OP_ASCII_LETTER_NC. Also added OP_NOT since there was no reason it should not be in here. (could_be_empty_branch): Ditto. (compile_branch): Streamlined all the single-character cases; there was a bit of duplicate code. Added cases for OP_ASCII_CHAR and OP_ASCII_LETTER_NC as needed. But in particular, compile to those opcodes when the single character match is ASCII. (find_firstassertedchar): Added cases for OP_ASCII_CHAR and OP_ASCII_LETTER_NC.
- pcre/pcre_exec.c: (match): Removed the "min", "minimize", and "op" fields from the matchframe, after I discovered that none of them needed to be saved and restored across recursive match calls. Also eliminated the ignored result field from the matchframe, since I discovered that rrc ("recursive result code") was already the exact same thing. Moved the handling of opcodes higher than OP_BRA into the default statement of the switch instead of doing them before the switch. This removes a branch from each iteration of the opcode interpreter, just as removal of "op" removed at least one store from each iteration. Last, but not least, add the OP_ASCII_CHAR and OP_ASCII_LETTER_NC functions. Neither can ever match a surrogate pair and the letter case can be handled efficiently.
- 12:54 AM Changeset in webkit [27421] by
-
- 2 edits in trunk/JavaScriptCore
- pcre/pcre_exec.c: (match): Try to fix the Windows build by removing unreachable code.
Nov 3, 2007:
- 11:18 PM Changeset in webkit [27420] by
-
- 7 edits4 deletes in trunk/JavaScriptCore
- fix non-Mac builds; remove some more unused PCRE stuff
- pcre/pcre_compile.c: (compile_branch): Removed branch chain and some unused ESC values. (compile_regex): Ditto. (jsRegExpCompile): Ditto.
- pcre/pcre_exec.c: (match): Removed unused branch targets. Don't use macros any more. (jsRegExpExecute): More of the same.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Update for removed files.
- JavaScriptCore.xcodeproj/project.pbxproj: Ditto.
- pcre/pcre.pri: Ditto.
- pcre/MERGING: Removed.
- pcre/pcre_fullinfo.c: Removed.
- pcre/pcre_get.c: Removed.
- pcre/pcre_internal.h:
- pcre/ucp.h: Removed.
- 10:22 PM Changeset in webkit [27419] by
-
- 24 edits in trunk
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15821 remove unused PCRE features for speed
A first step toward removing the PCRE features we don't use.
This gives a 0.8% speedup on SunSpider, and a 6.5% speedup on
the SunSpider regular expression test.
Replaced the public interface with one that doesn't use the
name PCRE. Removed code we don't need for JavaScript and various
configurations we don't use. This is in preparation for still
more changes in the future. We'll probably switch to C++ and
make some even more significant changes to the regexp engine
to get some additional speed.
There's probably additional unused stuff that I haven't
deleted yet.
This does mean that our PCRE is now a fork, but I think that's
not really a big deal.
- JavaScriptCore.exp: Remove the 5 old entry points and add the 3 new entry points for WebCore's direct use of the regular expression engine.
- kjs/config.h: Remove the USE(PCRE16) define. I decided to flip its sense and now there's a USE(POSIX_REGEX) instead, which should probably not be set by anyone. Maybe later we'll just get rid of it altogether.
- kjs/regexp.h:
- kjs/regexp.cpp: (KJS::RegExp::RegExp): Switch to new jsRegExp function names and defines. Cut down on the number of functions used. (KJS::RegExp::~RegExp): Ditto. (KJS::RegExp::match): Ditto.
- pcre/dftables.c: (main): Get rid of ctype_letter and ctype_meta, which are unused.
- pcre/pcre-config.h: Get rid of EBCIDIC, PCRE_DATA_SCOPE, const, size_t, HAVE_STRERROR, HAVE_MEMMOVE, HAVE_BCOPY, NEWLINE, POSIX_MALLOC_THRESHOLD, NO_RECURSE, SUPPORT_UCP, SUPPORT_UTF8, and JAVASCRIPT. These are all no longer configurable in our copy of the library.
- pcre/pcre.h: Remove the macro-based kjs prefix hack, the PCRE version macros, PCRE_UTF16, the code to set up PCRE_DATA_SCOPE, the include of <stdlib.h>, and most of the constants and functions defined in this header. Changed the naming scheme to use a JSRegExp prefix rather than a pcre prefix. In the future, we'll probably change this to be a C++ header.
- pcre/pcre_compile.c: Removed all unused code branches, including many whole functions and various byte codes. Kept changes outside of removal to a minimum. (check_escape): (first_significant_code): (find_fixedlength): (find_recurse): (could_be_empty_branch): (compile_branch): (compile_regex): (is_anchored): (is_startline): (find_firstassertedchar): (jsRegExpCompile): Renamed from pcre_compile2 and changed the parameters around a bit. (jsRegExpFree): Added.
- pcre/pcre_exec.c: Removed many unused opcodes and variables. Also started tearing down the NO_RECURSE mechanism since it's now the default. In some cases there were things in the explicit frame that could be turned into plain old local variables and other small like optimizations. (pchars): (match_ref): (match): Changed parameters quite a bit since it's now not used recursively. (jsRegExpExecute): Renamed from pcre_exec.
- pcre/pcre_internal.h: Get rid of PCRE_DEFINITION, PCRE_SPTR, PCRE_IMS, PCRE_ICHANGED, PCRE_NOPARTIAL, PCRE_STUDY_MAPPED, PUBLIC_OPTIONS, PUBLIC_EXEC_OPTIONS, PUBLIC_DFA_EXEC_OPTIONS, PUBLIC_STUDY_OPTIONS, MAGIC_NUMBER, 16 of the opcodes, _pcre_utt, _pcre_utt_size, _pcre_try_flipped, _pcre_ucp_findprop, and _pcre_valid_utf8. Also moved pcre_malloc and pcre_free here.
- pcre/pcre_maketables.c: Changed to only compile in dftables. Also got rid of many of the tables that we don't use.
- pcre/pcre_tables.c: Removed the unused Unicode property tables.
- pcre/pcre_ucp_searchfuncs.c: Removed everything except for _pcre_ucp_othercase.
- pcre/pcre_xclass.c: (_pcre_xclass): Removed uneeded support for classes based on Unicode properties.
- wtf/FastMallocPCRE.cpp: Removed unused bits. It would be good to eliminate this completely, but we need the regular expression code to be C++ first.
- pcre/pcre_fullinfo.c:
- pcre/pcre_get.c:
- pcre/ucp.h: Files that are no longer needed. I didn't remove them with this check-in, because I didn't want to modify all the project files.
WebCore:
Reviewed by Maciej.
- WebCore part of http://bugs.webkit.org/show_bug.cgi?id=15821 remove unused PCRE features for speed
- page/Frame.cpp: (WebCore::Frame::matchLabelsAgainstElement):
- page/mac/FrameMac.mm: (WebCore::Frame::matchLabelsAgainstElement): Remove use of ":digit:" syntax. This hasn't worked for some time. Use "\d" instead.
- platform/RegularExpression.h: Remove the unused cap function. We can add it back later if we find we need it.
- platform/RegularExpression.cpp: (WebCore::RegularExpression::Private::compile): Update for JavaScriptCore regular expression entry point changes. (WebCore::RegularExpression::Private::~Private): Ditto. (WebCore::RegularExpression::match): Remove the code to set PCRE_NOTBOL. This means that regular expressions with metacharactesr like in them won't work any more with non-whole-string searches, but we don't use any regular expressions like that.
- 10:15 PM Changeset in webkit [27418] by
-
- 2 edits in trunk/WebCore
Update the link stubs to match the current build, and fix coding style issues.
Reviewed by Mark Rowe.
- 9:17 PM Changeset in webkit [27417] by
-
- 2 edits in trunk/JavaScriptGlue
Build-fix.
- UserObjectImp.cpp:
- 8:37 PM Changeset in webkit [27416] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Sam.
- remove NaN check from JSImmediate::fromDouble for 0.5% SunSpider speedup
It turns out that doing this check costs more than it saves.
- kjs/JSImmediate.h: (KJS::JSImmediate::fromDouble):
- 7:21 PM Changeset in webkit [27415] by
-
- 1 edit3 adds in trunk/WebCore
wx <-> WebKit conversions for IntPoint, IntRect and FloatRect
Reviewed by Mark Rowe.
- 7:05 PM Changeset in webkit [27414] by
-
- 1 edit3 adds in trunk/WebCore
wx <-> WebKit data type conversions for Pen and Color.
Reviewed by Darin Adler.
- 6:08 PM Changeset in webkit [27413] by
-
- 31 edits in trunk
Reviewed by Oliver.
Remove dummy variable from ClassInfo reducing the size of the struct by 1 word.
The variable had been kept around for binary compatibility, but since nothing
else is there is no point in continuing to keep it around.
- API/JSCallbackConstructor.cpp: (KJS::):
- API/JSCallbackFunction.cpp: (KJS::):
- API/JSCallbackObject.cpp: (KJS::):
- bindings/objc/objc_runtime.mm:
- bindings/runtime_array.cpp:
- bindings/runtime_object.cpp:
- kjs/array_instance.cpp: (KJS::):
- kjs/array_object.cpp: (KJS::):
- kjs/bool_object.cpp:
- kjs/date_object.cpp: (KJS::):
- kjs/error_object.cpp:
- kjs/function.cpp: (KJS::):
- kjs/internal.cpp: (KJS::):
- kjs/lookup.h:
- kjs/math_object.cpp:
- kjs/number_object.cpp:
- kjs/object.h:
- kjs/regexp_object.cpp:
- kjs/string_object.cpp: (KJS::):
WebCore:
Reviewed by Oliver.
Remove dummy variable from ClassInfo reducing the size of the struct by 1 word.
The variable had been kept around for binary compatibility, but since nothing
else is there is no point in continuing to keep it around.
- bindings/js/JSDOMExceptionConstructor.cpp: (WebCore::):
- bindings/js/JSHTMLInputElementBase.cpp: (WebCore::):
- bindings/js/JSNamedNodesCollection.cpp: (WebCore::):
- bindings/js/JSXMLHttpRequest.cpp: (KJS::):
- bindings/js/JSXSLTProcessor.cpp: (KJS::):
- bindings/js/kjs_css.cpp: (WebCore::):
- bindings/js/kjs_events.cpp: (WebCore::):
- bindings/js/kjs_navigator.cpp: (KJS::):
- bindings/js/kjs_window.cpp: (KJS::):
- bindings/scripts/CodeGeneratorJS.pm:
- 4:52 PM Changeset in webkit [27412] by
-
- 2 edits in trunk/JavaScriptCore
- Updated testkjs results to make the build bots green until we can fix the tests that are failing. The new failures are in DST.
- tests/mozilla/expected.html:
- 3:58 PM Changeset in webkit [27411] by
-
- 6 edits1 add in trunk/SunSpider
Reviewed by Darin.
- Add compare mode and a description of the benchmark to the hosted version.
- hosted/sunspider-results.html: Add compare mode - you can just paste in another results URL.
- hosted/sunspider.html: Added intro text.
- make-hosted: Copy new file.
- resources/sunspider-compare-results.js: Made more reusable by putting the implementation in a function.
- resources/sunspider-standalone-compare.js: Added. Calls the function in the way standalone mode expects.
- sunspider-compare-results: Use sunspider-standalone-compare.js.
- 2:13 PM Changeset in webkit [27410] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Adam.
- don't print the var twice for ForInNodes with a var declaration
- kjs/nodes2string.cpp: (KJS::ForInNode::streamTo):
- 1:54 PM Changeset in webkit [27409] by
-
- 2 edits in trunk/WebKitTools
Rubber stamped by Adam.
- Turn off deprecated function warnings for TestNetscapePlugin because Carbon.h triggers them
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- 9:44 AM Changeset in webkit [27408] by
-
- 2 edits in trunk/JavaScriptCore
- pcre/pcre_compile.c: (check_escape): Windows build fix. Get rid of C-incompatible declaration.
- 9:42 AM Changeset in webkit [27407] by
-
- 2 edits in trunk/JavaScriptCore
2007-11-03 Mark Rowe <mrowe@apple.com>
Gtk build fix.
- kjs/nodes.cpp: Add missing include.
- 9:40 AM Changeset in webkit [27406] by
-
- 8 edits in trunk
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=15814 <rdar://problem/5536644> fast/js/kde/encode_decode_uri.html fails
These changes cause us to match the JavaScript specification and pass the
fast/js/kde/encode_decode_uri.html test.
- kjs/function.cpp: (KJS::encode): Call the UTF-8 string conversion in its new strict mode, throwing an exception if there are malformed UTF-16 surrogate pairs in the text.
- kjs/ustring.h: Added a strict version of the UTF-8 string conversion.
- kjs/ustring.cpp: (KJS::decodeUTF8Sequence): Removed code to disallow U+FFFE and U+FFFF; while those might be illegal in some sense, they aren't supposed to get any special handling in the place where this function is currently used. (KJS::UString::UTF8String): Added the strictness.
LayoutTests:
Reviewed by Maciej.
- updates for http://bugs.webkit.org/show_bug.cgi?id=15814 <rdar://problem/5536644> fast/js/kde/encode_decode_uri.html fails
- fast/js/kde/resources/encode_decode_uri.js: Rewrote the test to cover edges better, and use the should functions in a way that makes failures easier to understand.
- fast/js/kde/encode_decode_uri-expected.txt: Updated.
- 9:28 AM Changeset in webkit [27405] by
-
- 9 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=15812 some JavaScript tests (from the Mozilla test suite) are failing
Two or three fixes get 7 more of the Mozilla tests passing.
This gets us down from 61 failing tests to 54.
- kjs/interpreter.h: (KJS::Interpreter::builtinRegExp): Made this inline and gave it a more specific type. Some day we should probably do that for all of these -- might even get a bit of a speed boost from it.
- kjs/interpreter.cpp: Removed Interpreter::builtinRegExp now that it's inline in the header.
- kjs/regexp_object.h:
- kjs/regexp_object.cpp: (KJS::RegExpProtoFunc::callAsFunction): Moved test and exec out of the switch statement into the RegExpImp object, so they can be shared with RegExpImp::callAsFunction. (KJS::RegExpImp::match): Added. Common code used by both test and exec. (KJS::RegExpImp::test): Added. (KJS::RegExpImp::exec): Added. (KJS::RegExpImp::implementsCall): Added. (KJS::RegExpImp::callAsFunction): Added. (KJS::RegExpObjectImpPrivate::RegExpObjectImpPrivate): Initialize lastInput to null rather than empty string -- we take advantage of the difference in RegExpImp::match. (KJS::RegExpObjectImp::input): Added. No reason to go through hash tables just to get at a field like this.
- pcre/pcre_compile.c: (check_escape): Changed the \u handling to match the JavaScript specification. If there are not 4 hex digits after the \u, then it's processed as if it wasn't an escape sequence at all.
- pcre/pcre_internal.h: Added IS_NEWLINE, with the appropriate definition for JavaScript (4 specific Unicode values).
- pcre/pcre_exec.c: (match): Changed all call sites to use IS_NEWLINE. (pcre_exec): Ditto.
- tests/mozilla/expected.html: Updated to expect 7 more successful tests.
- 8:52 AM Changeset in webkit [27404] by
-
- 2 edits in trunk/WebKit/gtk
Reviewed by Mark Rowe.
Restore correct double and triple click behaviour
We ended up ignoring GDK_2BUTTON_PRESS and GDK_3BUTTON_PRESS after
recent refactoring.
- 8:26 AM Changeset in webkit [27403] by
-
- 8 edits in trunk/WebCore
Build fixes to get wx impls. building on trunk.
Reviewed by Mark Rowe.
- 8:10 AM Changeset in webkit [27402] by
-
- 14 edits in trunk
Sort files(...); sections of Xcode project files.
Rubber-stamped by Darin.
- JavaScriptCore.xcodeproj/project.pbxproj:
JavaScriptGlue:
Sort files(...); sections of Xcode project files.
Rubber-stamped by Darin.
- JavaScriptGlue.xcodeproj/project.pbxproj:
WebCore:
Sort files(...); sections of Xcode project files.
Rubber-stamped by Darin.
- WebCore.xcodeproj/project.pbxproj:
- manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj/project.pbxproj:
WebKit:
Sort files(...); sections of Xcode project files.
Rubber-stamped by Darin.
- WebKit.xcodeproj/project.pbxproj:
WebKitTools:
Sort files(...); sections of Xcode project files.
Rubber-stamped by Darin.
- DrawTest/DrawTest.xcodeproj/project.pbxproj:
- Drosera/mac/Drosera.xcodeproj/project.pbxproj:
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
- 7:57 AM Changeset in webkit [27401] by
-
- 4 edits in trunk/WebCore
Coding style fixes for platform/wx files.
Reviewed by Mark Rowe.
- 7:33 AM Changeset in webkit [27400] by
-
- 3 edits in trunk/WebCore
Reviewed by Mark Rowe.
Implement platform scrollbar static width/height getters
- 7:33 AM Changeset in webkit [27399] by
-
- 2 edits in trunk/WebCore
Reviewed by Mark Rowe.
Cast function pointers to gpointer.
- 7:33 AM Changeset in webkit [27398] by
-
- 4 edits2 adds in trunk/WebCore
Reviewed by Adam Roben.
RenderThemeGtk implementation based on Mozilla's GTK+ style code
There is still work needed to complete this feature.
- 7:33 AM Changeset in webkit [27397] by
-
- 2 edits in trunk/WebCore
Reviewed by Mark Rowe.
Do not allow scrollbars to handle wheel events
We bubble the wheel event up so the parent can handle it instead.
- 7:32 AM Changeset in webkit [27396] by
-
- 7 edits in trunk
Reviewed by Mark Rowe.
Frame scrolling and invalidation fixes
Make upward scroll events have a positive delta to match other ports.
Fix the invalidation rect offset for frames so that scrolling works properly.
Avoid allocating negative sizes to widgets to avoid GTK+ warnings.
Allow tabbing to all widgets and links.
Fix event returns, improving the focus situation and correcting scroll wheel
behavior.
- 6:35 AM Changeset in webkit [27395] by
-
- 27 edits in trunk
WebCore:
LGPL'ed files contain incorrect FSF address
<http://bugs.webkit.org/show_bug.cgi?id=14885>
Reviewed by NOBODY (follow-up fix).
- bindings/js/JSSVGTransformListCustom.cpp:
- ksvg2/svg/SVGException.idl:
- ksvg2/svg/SVGTextPathElement.cpp:
- ksvg2/svg/SVGTextPathElement.h:
- ksvg2/svg/SVGViewSpec.cpp:
- ksvg2/svg/SVGViewSpec.h:
- platform/mac/FontCustomPlatformData.cpp:
- platform/mac/FontCustomPlatformData.h:
- platform/mac/FontPlatformDataMac.mm:
- platform/win/FontCustomPlatformData.cpp:
- platform/win/FontCustomPlatformData.h:
- rendering/RenderSVGRoot.cpp:
- rendering/RenderSVGRoot.h:
- rendering/RenderSVGTextPath.cpp:
- rendering/RenderSVGTextPath.h:
- rendering/RenderSVGTransformableContainer.h:
- rendering/RenderSVGViewportContainer.cpp:
- rendering/RenderSVGViewportContainer.h:
- rendering/SVGCharacterLayoutInfo.cpp:
- rendering/SVGCharacterLayoutInfo.h:
- rendering/SVGRenderSupport.cpp:
- rendering/SVGRenderSupport.h:
WebKitSite:
LGPL'ed files contain incorrect FSF address
<http://bugs.webkit.org/show_bug.cgi?id=14885>
Reviewed by NOBODY (follow-up fix).
- blog/wp-includes/class-snoopy.php:
- blog/wp-includes/gettext.php:
- blog/wp-includes/streams.php:
- 3:09 AM Changeset in webkit [27394] by
-
- 5 edits in trunk/JavaScriptCore
Reviewed by Oliver.
- remove VarDeclListNode and simplify VarDeclNode evaluation for 0.4% SunSpider speedup
- kjs/grammar.y:
- kjs/nodes.cpp: (KJS::VarDeclNode::optimizeVariableAccess): (KJS::VarDeclNode::getDeclarations): (KJS::VarDeclNode::handleSlowCase): (KJS::VarDeclNode::evaluateSingle): (KJS::VarDeclNode::evaluate): (KJS::VarStatementNode::execute):
- kjs/nodes.h: (KJS::VarDeclNode::): (KJS::VarStatementNode::):
- kjs/nodes2string.cpp: (KJS::VarDeclNode::streamTo):
- 1:36 AM Changeset in webkit [27393] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15800
REGRESSION (r27303): RegExp leaks
- kjs/regexp_object.h: (KJS::RegExpImp::setRegExp): (KJS::RegExpImp::regExp): (KJS::RegExpImp::classInfo):
- kjs/regexp_object.cpp: (RegExpImp::RegExpImp): (RegExpImp::~RegExpImp): Renamed reg member variable to m_regExp, changed it to use OwnPtr.
- 12:27 AM Changeset in webkit [27392] by
-
- 4 edits in trunk
Versioning.
