Timeline
Dec 10, 2007:
- 11:43 PM Changeset in webkit [28611] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Oliver Hunt.
<rdar://problem/5482023> GoogleDocs: After FormatBlock in an empty document, certain functions are disabled
We were trying to insert a block of the requested type before the body element.
- editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply): Removed unnecessary ()s in the if condition.
Removed " !upstreamStart.node()->isDescendantOf(root)" from the if condition, since a) upstreamStart will never be outside the root editable element, since in that case
there would be no block inside the editable root to Format, and b) if upstreamStart.node()
*is* the root, then refNode is the root, and we shouldn't insert before the root, we should insert
at [root, 0].
Added comments to explain the use of upstream() in the second if-clause.
Added an early return for case where there is nothing selected, in that case, there is nothing
to move.
LayoutTests:
Reviewed by Oliver Hunt.
<rdar://problem/5482023> GoogleDocs: After performing FormatBlock in an empty document, certain functions are disabled
- editing/execCommand/5482023.html: Added.
- platform/mac/editing/execCommand/5482023-expected.checksum: Added.
- platform/mac/editing/execCommand/5482023-expected.png: Added.
- platform/mac/editing/execCommand/5482023-expected.txt: Added.
- 11:24 PM Changeset in webkit [28610] by
-
- 7 edits in trunk/WebCore
Reviewed and partially fixed by Tim Hatcher.
Remaining part of fix for <rdar://problem/5633400>
Transformed <video> is not clipped correctly until a repaint is forced
Replace the implementation of a QTKit method to avoid repaints from the NSView system associated with the QTMovie
from clobbering the WebCore repaints.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::mediaPlayerRepaint): Added.
- html/HTMLMediaElement.h:
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::repaint): Added.
- platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerRepaint): Added.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (method_setImplementation): Added for Tiger.
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): Call detachQTMovieView, which now does more cleanup.
(WebCore::MediaPlayerPrivate::cancelLoad): ditto.
(WebCore::MediaPlayerPrivate::setVisible): ditto.
(WebCore::MediaPlayerPrivate::detachQTMovieView): Clear the delegate as well as m_qtMovieView pointer.
(WebCore::MediaPlayerPrivate::repaint): Added. Triggers a repaint on the video renderer.
(-[WebCoreMovieObserver repaint]): ditto.
(WebCore::mainThreadSetNeedsDisplay): Added.
Does a WebCore repaint instead of going through the view repaint system for QTMovieView.
(WebCore::MediaPlayerPrivate::createQTMovieView): Replace the implementation of _mainThreadSetNeedsDisplay.
- 10:08 PM Changeset in webkit [28609] by
-
- 3 edits3 adds in trunk
Reviewed by Sam Weinig.
- fix http://bugs.webkit.org/show_bug.cgi?id=16379 REGRESSION(r28525): Failures in http/tests/xmlhttprequest/response-encoding.html and fast/dom/xmlhttprequest-html-response-encoding.html and <rdar://problem/5640230> REGRESSION (306A4-ToT): Access violation in PCRE function find_firstassertedchar
Test: fast/js/regexp-find-first-asserted.html
- pcre/pcre_compile.cpp: (compileBracket): Take out unnecessary initialization of out parameters. (branchFindFirstAssertedCharacter): Added. Broke out the half of the function that handles a branch. (bracketFindFirstAssertedCharacter): Renamed from find_firstassertedchar. Also removed the options parameter -- the caller can handle the options. (jsRegExpCompile): Changed call site to call the appropriate bracket or branch version of the find_firstassertedchar function. Also put the REQ_IGNORE_CASE code here instead of passing in the options.
LayoutTests:
Reviewed by Sam Weinig.
- test for http://bugs.webkit.org/show_bug.cgi?id=16379 REGRESSION(r28525): Failures in http/tests/xmlhttprequest/response-encoding.html and fast/dom/xmlhttprequest-html-response-encoding.html and <rdar://problem/5640230> REGRESSION (306A4-ToT): Access violation in PCRE function find_firstassertedchar
- fast/js/regexp-find-first-asserted-expected.txt: Added.
- fast/js/regexp-find-first-asserted.html: Added.
- fast/js/resources/regexp-find-first-asserted.js: Added.
- 9:47 PM Changeset in webkit [28608] by
-
- 13 edits in trunk
Reviewed by Sam Weinig.
Split this:
FunctionBodyNode
|
ProgramNode
into this:
ScopeNode
| | |
FunctionBodyNode ProgramNode EvalNode
in preparation for specializing each class more while optimizing global
variable access.
Also removed some cruft from the FunctionBodyNode interface to simplify
things.
SunSpider says this patch is a .8% speedup, which seems reasonable,
since it eliminates a few branches and adds KJS_FAST_CALL in a few
places.
Layout tests and JS tests pass. Also, this baby builds on Windows! (Qt
mileage may vary...)
WebCore:
Reviewed by Sam Weinig.
Updated for rename in JavaScriptCore.
- bridge/mac/WebCoreScriptDebugger.mm: (-[WebCoreScriptCallFrame scopeChain]): (-[WebCoreScriptCallFrame functionName]): (-[WebCoreScriptCallFrame evaluateWebScript:]):
WebKit/win:
Reviewed by Sam Weinig.
Updated for rename in JavaScriptCore.
- WebScriptCallFrame.cpp: (WebScriptCallFrame::functionName): (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
- 8:55 PM Changeset in webkit [28607] by
-
- 1 edit in trunk/WebCore/ChangeLog
Add bug reference.
- 8:50 PM Changeset in webkit [28606] by
-
- 2 edits in trunk/WebCore
Use KJS::Window not the ambiguous Window
Reviewed by ddkilzer.
- bindings/js/kjs_dom.cpp (checkNodeSecurity):
- 7:09 PM Changeset in webkit [28605] by
-
- 2 edits in trunk/JavaScriptCore
RS by Mark Rowe.
Mac build fix: added some exported symbols, now that Parser::parse is
defined in the header.
- JavaScriptCore.exp:
- 6:37 PM Changeset in webkit [28604] by
-
- 4 edits in trunk/JavaScriptCore
Build fix.
Template methods need to be in the header.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- kjs/Parser.cpp:
- kjs/Parser.h: (KJS::Parser::parse):
- 6:26 PM Changeset in webkit [28603] by
-
- 2 edits in trunk/WebKitTools
Rubberstamped by Sam Weinig
Update DRT Mac to reflect the new UI Delegate methods I just checked into WebKit/mac
- DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:frame:quotaForSecurityOrigin:toCreateDatabase:withEstimatedSize:]): (-[UIDelegate webView:frame:quotaForSecurityOrigin:fromProposedQuota:database:]):
- 5:54 PM Changeset in webkit [28602] by
-
- 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.11/WebKit
Tag for WebKit for Mac OS X Update 10.4.11 (WebKit-4523.12)
- 5:54 PM Changeset in webkit [28601] by
-
- 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.11/WebCore
Tag for WebCore for Mac OS X Update 10.4.11 (WebCore-4523.12)
- 5:54 PM Changeset in webkit [28600] by
-
- 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.11/JavaScriptGlue
Tag for JavaScriptGlue for Mac OS X Update 10.4.11 (JavaScriptGlue-4523.12)
- 5:53 PM Changeset in webkit [28599] by
-
- 1 copy in releases/Apple/Tiger/Mac OS X Update 10.4.11/JavaScriptCore
Tag for JavaScriptCore for Mac OS X Update 10.4.11 (JavaScriptCore-4523.12)
- 5:49 PM Changeset in webkit [28598] by
-
- 1 add in releases/Apple/Tiger/Mac OS X Update 10.4.11
New release tag.
- 5:22 PM Changeset in webkit [28597] by
-
- 5 edits in trunk/WebKit/mac
Reviewed by John Sullivan
Fix for <rdar://problem/5640080> - Database UI delegate calls need to specify WebFrame
This is because a common UI case is to want to know the originating URL of a Database
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::requestQuotaIncreaseForNewDatabase): (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
- WebView/WebUIDelegatePrivate.h:
- WebView/WebView.mm: (CallDelegateReturningUnsignedLongLong): (CallUIDelegateReturningUnsignedLongLong):
- WebView/WebViewInternal.h:
- 5:09 PM Changeset in webkit [28596] by
-
- 8 edits in trunk/LayoutTests
Reviewed by Adele.
The load events could fire before the event listener was registered making these tests fail occasionally.
No changes to test results.
- media/video-source-media.html:
- media/video-source-type.html:
- media/video-source.html:
- media/video-src-remove.html:
- media/video-src-source.html:
- media/video-src.html:
- media/video-test.js:
- 4:35 PM Changeset in webkit [28595] by
-
- 8 edits in trunk/JavaScriptCore
Reviewed by Sam Weinig.
Merged different implementations of Parser::parse into a single,
templatized implementation, in preparation for adding yet another
implementation for "eval" code.
JS and layout tests pass.
- 4:03 PM Changeset in webkit [28594] by
-
- 2 edits in trunk/WebCore
Fix non-mac builds.
- page/WindowFeatures.cpp: #include <wtf/MathExtras.h> for isnan.
- 3:51 PM Changeset in webkit [28593] by
-
- 2 edits in trunk/WebCore
2007-09-05 Marvin Decker <marv.decker@gmail.com>
Reviewed by Darin.
Fix a divide by 0 in the progress tracker.
http://bugs.webkit.org/show_bug.cgi?id=15055
- loader/ProgressTracker.cpp: (WebCore::ProgressTracker::incrementProgress):
- 3:32 PM Changeset in webkit [28592] by
-
- 6 edits1 move1 add in trunk/WebCore
Reviewed by Darin.
More cleanup of kjs_window.
- Move WindowFeatures from bridge/ to page/
- Move functions related to WindowFeatures (boolFeature, floatFeature, setWindowFeature, parseWindowFeatures) into the class.
- Fix up whitespace.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/kjs_window.cpp: (KJS::DOMWindowTimer::~DOMWindowTimer): (KJS::createWindow): (KJS::showModalDialog): (KJS::Window::getOwnPropertySlot): (KJS::Window::allowsAccessFrom): (KJS::Window::shouldInterruptScript): (KJS::WindowProtoFuncAToB::callAsFunction): (KJS::WindowProtoFuncOpen::callAsFunction): (KJS::Window::setReturnValueSlot): (KJS::ScheduledAction::execute): (KJS::Window::timerFired): (KJS::Location::Location): (KJS::Location::getValueProperty): (KJS::Location::getOwnPropertySlot): (KJS::Location::put): (KJS::LocationProtoFuncReplace::callAsFunction): Use better variable names. (KJS::LocationProtoFuncAssign::callAsFunction): Ditto. (KJS::LocationProtoFuncToString::callAsFunction): Remove extraneous calls to allowsAccessFrom, cleanup the function a little. (KJS::PausedTimeouts::~PausedTimeouts):
- bridge/WindowFeatures.h: Removed.
- page/WindowFeatures.cpp: Added. (WebCore::isSeparator): (WebCore::WindowFeatures::WindowFeatures): (WebCore::WindowFeatures::setWindowFeature): (WebCore::WindowFeatures::boolFeature): (WebCore::WindowFeatures::floatFeature):
- page/WindowFeatures.h: Copied from WebCore/bridge/WindowFeatures.h. (WebCore::WindowFeatures::WindowFeatures):
- 3:06 PM Changeset in webkit [28591] by
-
- 8 edits in trunk
Reviewed by Mark Rowe
<rdar://problem/5639463> Bundle versions on Tiger should be 4523.x not 523.x
- Configurations/Version.xcconfig: Some Tiger versions of Xcode don't set MAC_OS_X_VERSION_MAJOR, so assume Tiger and use a 4 for the SYSTEM_VERSION_PREFIX.
JavaScriptGlue:
Reviewed by Mark Rowe.
<rdar://problem/5639463> Bundle versions on Tiger should be 4523.x not 523.x
- Configurations/Version.xcconfig: Some Tiger versions of Xcode don't set MAC_OS_X_VERSION_MAJOR, so assume Tiger and use a 4 for the SYSTEM_VERSION_PREFIX.
WebCore:
Reviewed by Mark Rowe.
<rdar://problem/5639463> Bundle versions on Tiger should be 4523.x not 523.x
- Configurations/Version.xcconfig: Some Tiger versions of Xcode don't set MAC_OS_X_VERSION_MAJOR, so assume Tiger and use a 4 for the SYSTEM_VERSION_PREFIX.
WebKit/mac:
Reviewed by Mark Rowe.
<rdar://problem/5639463> Bundle versions on Tiger should be 4523.x not 523.x
- Configurations/Version.xcconfig: Some Tiger versions of Xcode don't set MAC_OS_X_VERSION_MAJOR, so assume Tiger and use a 4 for the SYSTEM_VERSION_PREFIX.
- 3:02 PM Changeset in webkit [28590] by
-
- 2 edits in trunk/LayoutTests
Check in correct results
- svg/custom/resource-client-removal-expected.txt:
- 12:39 PM Changeset in webkit [28589] by
-
- 2 edits in trunk/WebCore
2007-12-10 Alp Toker <alp@atoker.com>
Reviewed by Niko.
Cairo implementation of GraphicsContext::setUseAntialiasing().
- platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setUseAntialiasing):
- 12:14 PM Changeset in webkit [28588] by
-
- 8 edits4 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16182
SVG should disable antialiasing for shape-rendering="crispEdges"
Turn off anti-aliasing of shapes when shape-rendering="crispEdges".
- 12:03 PM Changeset in webkit [28587] by
-
- 3 edits4 adds in trunk
Reviewed by Niko.
http://bugs.webkit.org/show_bug.cgi?id=16163
SVG crash in Node::setChanged() on Debug builds only (trashed parent)
Fix the crash by properly unregistering as client from SVGResource
when deleting a styled svg node.
- 11:38 AM Changeset in webkit [28586] by
-
- 2 edits in trunk/WebCore
Rubberstamped by John
- storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::canEstablishDatabase): If the UI Delegate returns *exactly* the estimated size for the new quota, we should allow the database to be created
- 10:47 AM Changeset in webkit [28585] by
-
- 2 edits2 adds in trunk
Reviewed by Darin.
Fixed: <rdar://problem/4290098> Right-mouse click on element doesn't call onmousedown handler
- WebView/WebHTMLView.mm: (-[WebHTMLView menuForEvent:]): Match behavior of other browsers by sending an onmousedown event for right clicks.
- 9:51 AM Changeset in webkit [28584] by
-
- 6 edits5 adds in trunk
Bug 9683: Implement select.options.remove() method
WebCore:
Bug 9683: Implement select.options.remove() method
<http://bugs.webkit.org/show_bug.cgi?id=9683>
Reviewed by Maciej.
Implement select.options.remove() by calling select.remove()
with the same arguments. This is what MSIE 7 does, although its
select.remove() method differs from WebKit's by throwing an
exception when called with no arguments or with a negative
integer argument. Note that the DOM Level 1 documentation
specifies that select.remove() does not throw an exception.
Tests: fast/js/select-options-remove-gc.html
fast/js/select-options-remove.html
- bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::remove): Added.
- html/HTMLOptionsCollection.cpp: (WebCore::HTMLOptionsCollection::remove): Added.
- html/HTMLOptionsCollection.h:
- html/HTMLOptionsCollection.idl:
LayoutTests:
Bug 9683: Implement select.options.remove() method
<http://bugs.webkit.org/show_bug.cgi?id=9683>
Reviewed by Maciej.
- fast/js/resources/select-options-remove.js: Added.
- fast/js/select-options-remove-expected.txt: Added.
- fast/js/select-options-remove-gc-expected.txt: Added.
- fast/js/select-options-remove-gc.html: Added.
- fast/js/select-options-remove.html: Added.
- 9:16 AM Changeset in webkit [28583] by
-
- 2 edits in trunk/WebKit/win
Fix <rdar://5624866> CFStringRef UI_STRING should use a cache and follow the CF "Get" model (current uses leak)
Added a new class, LocalizedString, that wraps a CFStringRef and a
WebCore::String. We store one LocalizedString for each key string.
Reviewed by Steve.
- WebLocalizableStrings.cpp: Changed our two HashMaps to map from WebCore::String to LocalizedString*. (LocalizedString::LocalizedString): (LocalizedString::operator CFStringRef): (LocalizedString::operator LPCTSTR): Code moved here from localizedLPCTSTR. (findCachedString): Changed to return a LocalizedString*. (cacheString): Changed to take a LocalizedString*. (localizedString): Changed to return a const LocalizedString&. We first try to find a cached LocalizedString. If there isn't one, we create a new one and cache it. (WebLocalizedLPCTSTRUTF8): Changed to call localizedString. (WebLocalizedLPCTSTR): Ditto.
- 9:15 AM Changeset in webkit [28582] by
-
- 4 edits in trunk/WebKit/win
Make WebLocalizableStrings work a little more like the Mac version
Reviewed by Steve.
- WebKit.vcproj/WebKit.def: Deprecated SetWebLocalizedStringMainBundle.
- WebKit.vcproj/WebKit_debug.def: Ditto.
- WebLocalizableStrings.cpp: (createWebKitBundle): Changed to only create the bundle once. (cfBundleForStringsBundle): Added. Code was factored out of copyLocalizedStringFromBundle. We now use the CFBundleGetMainBundle to get the main bundle and WebLocalizableStringsBundle's identifier to fetch the framework's bundle. (copyLocalizedStringFromBundle): Changed to call cfBundleForStringsBundle. (cacheString): Cleaned up logic a bit with an early return. (SetWebLocalizedStringMainBundle): Moved down with the other deprecated functions and made into a no-op.
- 5:38 AM Changeset in webkit [28581] by
-
- 2 edits in trunk/JavaScriptCore
Tiger build fix.
- 5:15 AM Changeset in webkit [28580] by
-
- 2 edits in trunk/JavaScriptCore
2007-12-10 Darin Adler <Darin Adler>
Reviewed by Mark Rowe.
- fix http://bugs.webkit.org/show_bug.cgi?id=16375 REGRESSION: Safari crashes on quit
Probably a debug-only issue.
- kjs/Parser.cpp: (KJS::parser): Create the parser and never destroy it by using a pointer instead of a global object.
- 4:58 AM QtWebKitTodo edited by
- (diff)
- 4:40 AM QtWebKitContrib edited by
- (diff)
- 2:46 AM QtWebKitTodo edited by
- (diff)
- 2:46 AM QtWebKitTodo edited by
- (diff)
- 2:43 AM QtWebKitTodo edited by
- (diff)
- 12:55 AM Changeset in webkit [28579] by
-
- 2 edits in trunk/LayoutTests
Removed fast/events/objc-keyboard-event-creation.html from skipped list, as this test has
been moved to platform/mac long ago.
- platform/win/Skipped:
Dec 9, 2007:
- 10:22 PM Changeset in webkit [28578] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Sam Weinig.
- fix http://bugs.webkit.org/show_bug.cgi?id=16369 REGRESSION (r28525): regular expression tests failing due to bad firstByte optimization
- pcre/pcre_compile.cpp: Changed some names to use interCaps intead of under_scores. (branchIsAnchored): Broke is_anchored into two separate functions; this one works on a branch and the other on an anchor. The old function would only work on a bracket. Also removed unneeded parameters; the anchored check does not require the bracket map or the options any more because we have a reduced set of features. (bracketIsAnchored): Ditto. (branchNeedsLineStart): Broke canApplyFirstCharOptimization into two functions and gave both a better name. This is the function that was returning the wrong value. The failure was beacuse the old function would only work on a bracket. (bracketNeedsLineStart): Ditto. (jsRegExpCompile): Changed to call the appropriate branch or bracket flavor of the functions based on whether we compiled an outer bracket. Also removed inaccurate comments and unneeded parameters.
- other small changes
- pcre/pcre.h: Renumbered error codes, in a logical order. First, normal failure, then the recursion limit, then running out of memory, and finally an unexpected internal error.
- pcre/pcre_exec.cpp: Fixed indentation. (jsRegExpExecute): Corrected an inaccurate comment.
- 8:05 PM Changeset in webkit [28577] by
-
- 7 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=16370 REGRESSION (r28540): source URL and line number no longer set for outer function/programs
Test: fast/js/exception-linenums-in-html-1.html
Test: fast/js/exception-linenums-in-html-2.html
Test: fast/js/exception-linenums.html
By the time the ProgramNode was constructed, the source URL was empty.
- kjs/Parser.cpp: (KJS::Parser::parseProgram): Added code to set and clear m_sourceURL, which is now handled here instead of in the lexer; it needs to still be set when we create the program node. Call setLoc to set the first and last line number. (KJS::Parser::parseFunctionBody): Ditto, but for the body. (KJS::Parser::parse): Removed the sourceURL argument.
- kjs/Parser.h: Added sourceURL(), m_sourceURL, and m_lastLine. Added a lastLine parameter to didFinishParsing, since the bison grammar knows the last line number and we otherwise do not know it. Removed the sourceURL parameter from parse, since that's now handled at a higher level.
- kjs/grammar.y: Pass the last line number to didFinishParsing.
- kjs/lexer.cpp: (KJS::Lexer::setCode): Removed the sourceURL argument and the code to set m_sourceURL. (KJS::Lexer::clear): Ditto.
- kjs/lexer.h: More of the same.
- kjs/nodes.cpp: (KJS::FunctionBodyNode::FunctionBodyNode): Get the source URL from the parser rather than from the lexer. Removed unneeded call to setLoc, since the line numbers already both default to -1.
- 7:33 PM Changeset in webkit [28576] by
-
- 2 edits in trunk/WebCore
Rubber stamped by Mark Rowe.
- WebCore.xcodeproj/project.pbxproj: Add missing DerivedSources files.
- 5:12 PM Changeset in webkit [28575] by
-
- 4 edits in trunk
Need to read the spec properly.
Reviewed by Niko
Correction, 'z' and 'Z' are the only commands that cannot have an extended
list of arguments.
- 4:44 PM Changeset in webkit [28574] by
-
- 5 edits in trunk
Prevent unlimited iteration in the case of invalid path data.
Reviewed by Niko.
The only path commands that can leave numbers trailing the command processing
are 'm' and 'M', in which trailing numbers are parsed as arguments to an
implicit lineto command. In any case we should just terminate as an invalid
path.
- 1:52 PM Changeset in webkit [28573] by
-
- 3 edits in trunk/WebCore
2007-12-09 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=15825
[GTK] curl - slow dns causing hangs.
Create a vector of jobs, to satisfy requests in the right order.
Set a limit to the number of simultaneous connections.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::maxRunningJobs): added (WebCore::ResourceHandleManager::ResourceHandleManager): (WebCore::ResourceHandleManager::removeFromCurl): (WebCore::ResourceHandleManager::startScheduledJobs):
- platform/network/curl/ResourceHandleManager.h: (WebCore::ResourceHandleList): removed (WebCore::ResourceHandleManager::m_runningJobs): added (WebCore::ResourceHandleManager::m_resourceHandleListHead): removed (WebCore::ResourceHandleManager::m_resourceHandleList): added
- 10:49 AM UsingGitWithWebKit edited by
- (diff)
Dec 8, 2007:
- 11:56 PM Changeset in webkit [28572] by
-
- 3 edits in trunk/WebCore
Reviewed by Oliver.
Cleanup kjs_window.h/cpp.
- bindings/js/kjs_window.cpp: (KJS::WindowPrivate::WindowPrivate): (KJS::DOMWindowTimer::DOMWindowTimer): (KJS::Window::Window): (KJS::Window::retrieveWindow): (KJS::Window::retrieveActive): (KJS::Window::retrieve): (KJS::Window::location): (KJS::Window::mark): (KJS::allowPopUp): (KJS::parseModalDialogFeatures): (KJS::floatFeature): (KJS::canShowModalDialog): (KJS::canShowModalDialogNow): (KJS::showModalDialog): (KJS::Window::getValueProperty): (KJS::Window::getOwnPropertySlot): (KJS::Window::globalExec): (KJS::Window::setListener): (KJS::Window::getListener): (KJS::Window::findOrCreateJSEventListener): (KJS::Window::findOrCreateJSUnprotectedEventListener): (KJS::Window::clearHelperObjectProperties): (KJS::Window::setCurrentEvent): (KJS::WindowProtoFuncAToB::callAsFunction): (KJS::WindowProtoFuncBToA::callAsFunction): (KJS::WindowProtoFuncOpen::callAsFunction): (KJS::WindowProtoFuncSetTimeout::callAsFunction): (KJS::WindowProtoFuncClearTimeout::callAsFunction): (KJS::WindowProtoFuncSetInterval::callAsFunction): (KJS::WindowProtoFuncAddEventListener::callAsFunction): (KJS::WindowProtoFuncRemoveEventListener::callAsFunction): (KJS::WindowProtoFuncShowModalDialog::callAsFunction): (KJS::WindowProtoFuncNotImplemented::callAsFunction):
- bindings/js/kjs_window.h: (KJS::PausedTimeouts::PausedTimeouts): (KJS::PausedTimeouts::takeTimeouts): (KJS::ScheduledAction::ScheduledAction):
- 11:48 PM Changeset in webkit [28571] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Adam Roben.
- fast/dom/Window/window-resize-and-move-arguments.html: Make the window small enough that this test won't fail on systems with lower resolutions.
- 4:47 PM Changeset in webkit [28570] by
-
- 10 edits4 adds in trunk
WebCore:
Reviewed by Mitz.
Move window scrolling, moving and resizing methods from KJS::Window
to WebCore::DOMWindow so that there bindings can be autogenerated.
Tests: fast/dom/Window/window-resize-and-move-arguments.html
fast/dom/Window/window-scroll-arguments.html
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/kjs_window.cpp: (KJS::Window::getValueProperty): Remove extraneous allowsAccessFrom check. (KJS::WindowProtoFuncOpen::callAsFunction): (KJS::WindowProtoFuncNotImplemented::callAsFunction): Remove extraneous allowsAccessFrom check.
- bindings/js/kjs_window.h:
- bindings/scripts/CodeGeneratorJS.pm: Add new extended attribute to ensure that the no less than the declared number of attributes is allowed.
- page/DOMWindow.cpp: (WebCore::DOMWindow::adjustWindowRect): Moved from kjs_window. (WebCore::DOMWindow::scrollBy): (WebCore::DOMWindow::scrollTo): (WebCore::DOMWindow::moveBy): (WebCore::DOMWindow::moveTo): (WebCore::DOMWindow::resizeBy): (WebCore::DOMWindow::resizeTo):
- page/DOMWindow.h: (WebCore::DOMWindow::scroll):
- page/DOMWindow.idl:
LayoutTests:
Reviewed by Sam W.
Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
Fixes <rdar://problem/5620249> Must disable SVG animation
<rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
These layout test changes are caused by some of the experimental
features no longer being enabled by default.
- fast/dom/Window/window-properties-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
- platform/mac/svg/custom/empty-merge-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
- platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
- platform/mac/svg/custom/feDisplacementMap-01-expected.txt:
- platform/mac/svg/custom/filter-source-alpha-expected.txt:
- platform/mac/svg/custom/image-with-transform-clip-filter-expected.txt:
- platform/mac/svg/custom/invalid-css-expected.txt:
- platform/mac/svg/custom/non-opaque-filters-expected.txt:
- platform/mac/svg/custom/text-filter-expected.txt:
- platform/mac/svg/custom/visibility-override-filter-expected.txt:
- svg/batik/filters/filterRegions-expected.txt:
- svg/batik/text/textEffect-expected.txt:
- svg/batik/text/textEffect3-expected.txt:
- svg/batik/text/textFeatures-expected.txt:
- svg/batik/text/textProperties-expected.txt:
- svg/custom/js-svg-constructors-expected.txt:
- svg/dom/font-face-elements-expected.txt:
- svg/webarchive/svg-feimage-subresources-expected.txt:
- 4:32 PM Changeset in webkit [28569] by
-
- 3 edits in trunk/WebCore
2007-12-08 Kevin Ollivier <kevino@theolliviers.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=14651
[CURL] didReceiveResponse() only called for HTTP loads
http://bugs.webkit.org/show_bug.cgi?id=14583
[GDK] file:// relative CSS include URLs handled incorrectly
Make sure CURL sets the ResourceResponse URL and calls
didReceiveResponse for local files too.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::writeCallback):
- 4:27 PM Changeset in webkit [28568] by
-
- 241 edits2 adds in trunk
Split the ENABLE_SVG_EXPERIMENTAL_FEATURES flag into separate flags.
Reviewed by Sam W.
Fixes <rdar://problem/5620249> Must disable SVG animation
<rdar://problem/5612772> Disable SVG filters on Mac to match Windows behavior
In order to allow finer grained control over the set of SVG features
this patch splits ENABLE_SVG_EXPERIMENTAL_FEATURES into the following
distinct flags:
ENABLE_SVG_ANIMATION
ENABLE_SVG_FILTERS
ENABLE_SVG_FONTS
ENABLE_SVG_AS_IMAGE
ENABLE_SVG_USE
by default only ENABLE_SVG_AS_IMAGE and ENABLE_SVG_USE are set.
- 4:19 PM BuildingGtk edited by
- apt-get typo (diff)
- 3:45 PM Changeset in webkit [28567] by
-
- 4 edits6 adds in trunk
WebCore:
Reviewed by Adele Peterson.
- fix two bugs in parsing of stylesheets in <style> elements created by
the parser:
- each such stylesheet is parsed twice, once when the text node is added and again when the </style> tag is reached
- re-inserting such a <style> element into the document fails to re-parse and apply its stylesheet.
Test for bug #2: fast/dom/HTMLStyleElement/insert-parser-generated.html
- html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::finishedParsing):
- svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::finishedParsing):
LayoutTests:
Reviewed by Adele Peterson.
- test that re-inserting a parser-generated <style> element applies its sylesheet.
- fast/dom/HTMLStyleElement: Added.
- fast/dom/HTMLStyleElement/insert-parser-generated.html: Added.
- platform/mac/fast/dom/HTMLStyleElement: Added.
- platform/mac/fast/dom/HTMLStyleElement/insert-parser-generated-expected.checksum: Added.
- platform/mac/fast/dom/HTMLStyleElement/insert-parser-generated-expected.png: Added.
- platform/mac/fast/dom/HTMLStyleElement/insert-parser-generated-expected.txt: Added.
- 1:02 PM Changeset in webkit [28566] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Fix ChangeLog
- 10:03 AM Changeset in webkit [28565] by
-
- 10 edits in trunk
Reviewed by Darin.
- Rename isSafeScript to allowsAccess.
- bindings/NP_jsobject.cpp: (_isSafeScript):
- kjs/JSGlobalObject.h: (KJS::JSGlobalObject::allowsAccessFrom): Reverse caller/argument of allowsAccessFrom to match the new call.
WebCore:
Reviewed by Darin.
- Removes the faulty isSafeScript implementation that was only used for plugins.
- Renames isSafeScript to allowsAccessFrom.
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot): (WebCore::JSDOMWindow::customPut):
- bindings/js/kjs_dom.cpp: (WebCore::checkNodeSecurity):
- bindings/js/kjs_window.cpp: (KJS::createWindow): (KJS::Window::getValueProperty): (KJS::Window::namedItemGetter): (KJS::Window::getOwnPropertySlot): (KJS::Window::put): (KJS::Window::allowsAccessFrom): (KJS::Window::setListener): (KJS::Window::getListener): (KJS::WindowProtoFuncOpen::callAsFunction): (KJS::WindowProtoFuncSetTimeout::callAsFunction): (KJS::WindowProtoFuncClearTimeout::callAsFunction): (KJS::WindowProtoFuncSetInterval::callAsFunction): (KJS::WindowProtoFuncAddEventListener::callAsFunction): (KJS::WindowProtoFuncRemoveEventListener::callAsFunction): (KJS::WindowProtoFuncNotImplemented::callAsFunction): (KJS::Location::getOwnPropertySlot): (KJS::Location::put): (KJS::LocationProtoFuncReplace::callAsFunction): (KJS::LocationProtoFuncReload::callAsFunction): (KJS::LocationProtoFuncAssign::callAsFunction): (KJS::LocationProtoFuncToString::callAsFunction):
- bindings/js/kjs_window.h: (KJS::Window::allowsAccessFrom):
- bindings/objc/WebScriptObject.mm: (-[WebScriptObject _isSafeScript]): Reverse caller/argument of allowsAccessFrom to match the new call.
- bindings/scripts/CodeGeneratorJS.pm:
- 6:39 AM Changeset in webkit [28564] by
-
- 5 edits in trunk/WebKit/gtk
2007-12-08 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16346
[GTK] Some webview parts must use the focused frame.
Also update some old code.
- WebView/webkitprivate.cpp: (getFrameFromView): removed
- WebView/webkitprivate.h: (getFrameFromView): removed
- WebView/webkitwebview.cpp: (webkit_web_view_expose_event): (webkit_web_view_key_press_event): use focused frame (webkit_web_view_key_release_event): use focused frame (webkit_web_view_button_press_event): (webkit_web_view_button_release_event): (webkit_web_view_motion_event): (webkit_web_view_scroll_event): (webkit_web_view_size_allocate): (webkit_web_view_set_scroll_adjustments): (webkit_web_view_execute_script): (webkit_web_view_stop_loading): (webkit_web_view_load_string): (webkit_web_view_reload): (webkit_web_view_open): (webkit_web_view_can_go_forward): (webkit_web_view_can_go_backward): (webkit_web_view_go_forward): (webkit_web_view_go_backward):
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeypress): fix for page up and page down keys for editable contents
- 4:27 AM Changeset in webkit [28563] by
-
- 4 edits4 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15464
SVGLengthList allows bad values
Be more strict with svg lengths without a unit identifier.
Test: svg/custom/invalid-lengthlist.svg
- 4:11 AM Changeset in webkit [28562] by
-
- 2 edits in trunk/WebCore
Mac Tiger build fix.
Use the wtf prefix when including MathExtras.h.
- 3:35 AM Changeset in webkit [28561] by
-
- 1 edit in trunk/WebCore/ChangeLog
Remove 'Reviewed by' from build fix ChangeLog entry
- 3:32 AM Changeset in webkit [28560] by
-
- 2 edits in trunk/WebCore
2007-12-08 Alp Toker <alp@atoker.com>
Reviewed by Alp Toker.
GTK+ build fix (for ENABLE_VIDEO builds):
Include MathExtras.h to get isfinite().
- rendering/RenderMedia.cpp:
- 12:53 AM Changeset in webkit [28559] by
-
- 12 edits in trunk/WebCore
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15528
svg_dynamic_cast should be removed
Replace svg_dynamic_cast with a combination of
isSVGElement and static_cast.
Dec 7, 2007:
- 10:49 PM Changeset in webkit [28558] by
-
- 3 edits5 adds in trunk
WebCore:
Reviewed by Adele.
Partial fix for <rdar://problem/5633400>
Transformed <video>, <img>, <embed> are not clipped correctly until a repaint is forced
Fix video painting when transform is applied.
Test: media/video-transformed.html
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::paint):
LayoutTests:
Reviewed by Adele.
Test video painting when transform is applied.
- media/video-paint-test.js: Added.
- media/video-transformed.html: Added.
- platform/mac/media/video-transformed-expected.checksum: Added.
- platform/mac/media/video-transformed-expected.png: Added.
- platform/mac/media/video-transformed-expected.txt: Added.
- 9:44 PM Changeset in webkit [28557] by
-
- 4 edits in trunk
WebKit/win:
Fix version parsing.
Rubber-stamped by Oliver.
- WebKit.vcproj/auto-version.sh:
WebKitTools:
Fix version parsing.
Rubber-stamped by Oliver.
- Drosera/win/Drosera.vcproj/auto-version.sh:
- 8:26 PM Changeset in webkit [28556] by
-
- 3 edits4 adds in trunk/WebKitTools
Build modifications for Drosera.
Reviewed by Adam.
- Drosera/DroseraWin.make: Added.
- Drosera/win/Drosera.vcproj/Drosera.rc:
- Drosera/win/Drosera.vcproj/Drosera.vcproj:
- Drosera/win/Drosera.vcproj/PRODUCTVERSION: Added.
- Drosera/win/Drosera.vcproj/VERSION: Added.
- Drosera/win/Drosera.vcproj/auto-version.sh: Added.
- 5:48 PM Changeset in webkit [28555] by
-
- 3 edits5 adds in trunk
WebCore:
Reviewed by Sam Weinig.
- fix http://bugs.webkit.org/show_bug.cgi?id=16348 @font-face does not affect the default style
Test: fast/css/font-face-default-font.html
- dom/Document.cpp: (WebCore::Document::recalcStyle): Pass our font selector to Font::update() if we already have one.
LayoutTests:
Reviewed by Sam Weinig.
- test for http://bugs.webkit.org/show_bug.cgi?id=16348 @font-face does not affect the default style
- fast/css/font-face-default-font.html: Added.
- platform/mac-leopard/fast/css: Added.
- platform/mac-leopard/fast/css/font-face-default-font-expected.checksum: Added.
- platform/mac-leopard/fast/css/font-face-default-font-expected.png: Added.
- platform/mac/fast/css/font-face-default-font-expected.txt: Added.
- 5:37 PM Changeset in webkit [28554] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Kevin Decker and Tim Hatcher.
- speculative fix for <rdar://problem/5400159> CrashTracer: [USER] 726 crashes in Safari at com.apple.WebKit: -[WebHTMLView(WebPrivate) _updateMouseoverWithFakeEvent] + 389
- WebView/WebHTMLView.mm: (-[WebHTMLView _frameOrBoundsChanged]): Only schedule the mouseover timer if we are in a window and not closed. That's because viewDidMoveToWindow and close are the entry points for cancelling. (-[WebHTMLView close]): Add code to cancel both timers. Needed for the case where the entire window goes away, and the view is never removed from the window. (-[WebHTMLView viewDidMoveToWindow]): Don't do work if the view is closed.
- 5:06 PM Changeset in webkit [28553] by
-
- 3 edits in trunk/WebKit/win
Fix build.
- WebKit.vcproj/WebKit.vcproj:
- WebScriptCallFrame.cpp:
- 5:00 PM Changeset in webkit [28552] by
-
- 2 edits in trunk/WebKit/win
Fix build.
- WebHistory.cpp: (_WebCoreHistoryProvider::containsURL):
- 4:59 PM Changeset in webkit [28551] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Sam Weinig.
Refactored variable access optimization: Removed the assumption that
the FunctionBodyNode holds the symbol table.
- 4:56 PM Changeset in webkit [28550] by
-
- 2 edits in trunk/WebKit/qt
- try to fix build
- Api/qwebhistoryinterface.cpp: (WebCore::historyContains): There's a WebCore function here in WebKit! Needs to be updated, since WebCore changed, but this should not be here.
- 4:39 PM Changeset in webkit [28549] by
-
- 2 edits in trunk/JavaScriptCore
Build fix: added #include.
- kjs/nodes.cpp:
- 4:35 PM Changeset in webkit [28548] by
-
- 2 edits in trunk/JavaScriptCore
Build fix: added #include.
- kjs/interpreter.cpp:
- 4:30 PM Changeset in webkit [28547] by
-
- 2 edits in trunk/JavaScriptCore
Build fix: added #include.
- kjs/grammar.y:
- 4:24 PM Changeset in webkit [28546] by
-
- 2 edits in trunk/JavaScriptCore
Build fix: added #include.
- kjs/function_object.cpp:
- 4:23 PM Changeset in webkit [28545] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Sam Weinig.
Fixed crash seen running layout tests.
Reverted a change I made earlier today. Added a comment to try to
discourage myself from making this mistake a third time.
- kjs/function.cpp: (KJS::ActivationImp::mark):
- kjs/function.h: (KJS::ActivationImp::ActivationImpData::ActivationImpData):
- 4:22 PM Changeset in webkit [28544] by
-
- 2 edits in trunk/WebCore
- fix Windows build
- bridge/win/GlobalHistoryWin.cpp: (WebCore::historyContains): Missed a rename.
- 4:05 PM Changeset in webkit [28543] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders and Darin
When a statement bumps up against the quota and the UI Delegate grants more space, we need to
actually set the new maximum size on the SQLiteDatabase (in addition to storing the new max quota
in the DatabaseTracker, which was already done)
- storage/SQLTransaction.cpp: (WebCore::SQLTransaction::runStatements): If a statement is being retried, set the maximum size on the SQLiteDatabase to the new maximum size
- 4:02 PM Changeset in webkit [28542] by
-
- 2 edits in trunk/WebCore
- fix Tiger build
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: Tiger didn't even have QTKIT_VERSION_MAX_ALLOWED, so add logic to work without that.
- 4:02 PM Changeset in webkit [28541] by
-
- 1 edit1 add in trunk/WebKitSite
Reviewed by Darin's rubberstamp
When developing the Database feature and dealing with UI Delegate issues, it is important to have
live examples on the web to help reproduce certain situations.
This file is a dumping ground for such examples, and starts out with one function - the ability to add
arbitrary amounts of data to a database to test the quota-related mechanisms of the UI
- misc/DatabaseTester.html: Added.
- 4:01 PM Changeset in webkit [28540] by
-
- 7 edits in trunk/JavaScriptCore
Reviewed by Sam Weinig.
Refactored parsing of global code: Removed the assumption that
ProgramNode inherits from FunctionBodyNode from the parser.
- kjs/Parser.cpp: (KJS::Parser::parseProgram): (KJS::Parser::parseFunctionBody): (KJS::Parser::parse):
- kjs/Parser.h: (KJS::Parser::didFinishParsing):
- kjs/function.cpp:
- kjs/grammar.y:
- kjs/nodes.h:
- 3:53 PM Changeset in webkit [28539] by
-
- 2 edits in trunk/WebCore
- fix 64-bit build, hopefully without breaking Tiger build
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates): Don't use Movies.h constants that are nonexistent in 64-bit. Define the new QTMovie.h constants, though, when using an older QTKit.
- 3:22 PM Changeset in webkit [28538] by
-
- 2 edits in trunk/WebKit/win
Tried to fix build by suppressing warning.
- WebScriptCallFrame.cpp:
- 3:00 PM Changeset in webkit [28537] by
-
- 3 edits in trunk/WebCore
Reviewed by Anders
Fix <rdar://problem/5636115> - Prompted for quota increase to create database when it already existed
- storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::canEstablishDatabase): Check hasEntryForDatabase before doing any prompting (WebCore::DatabaseTracker::hasEntryForDatabase): Check and see if this database already exists
- storage/DatabaseTracker.h:
- 2:58 PM Changeset in webkit [28536] by
-
- 15 edits in trunk
WebCore:
Reviewed by Mitz.
- http://bugs.webkit.org/show_bug.cgi?id=15981 speed up visited-link code a bit
- bridge/GlobalHistory.h: Change historyContains to take a character pointer plus length instead of requiring a DeprecatedString.
- bridge/mac/GlobalHistoryMac.mm: (WebCore::historyContains): Updated for above change. Also removes pointless "fast Latin-1" case that was never used.
- bridge/win/GlobalHistoryWin.cpp: (WebCore::historyContains): Ditto.
- platform/gtk/TemporaryLinkStubs.cpp: (WebCore::historyContains): Ditto.
- platform/wx/TemporaryLinkStubs.cpp: (WebCore::historyContains): Ditto.
- css/CSSStyleSelector.cpp: (WebCore::findHash): Added. Helper for cleanpath. (WebCore::findSlashDotDotSlash): Ditto. (WebCore::findSlashSlash): Ditto. (WebCore::findSlashDotSlash): Ditto. (WebCore::cleanpath): Changed to use fast helper functions instead of slower general-purpose DeprecatedString find function. (WebCore::containsColonSlashSlash): Added. Helper for checkPseudoState. (WebCore::checkPseudoState): Got rid of reference count churn by using an AtomicString* instead of an AtomicString for the attribute value. Changed to use fast helper function instead of slower DeprecatedString::contains function, and also made the fast case not bother allocating a DeprecatedConstString.
- unrelated tiny cleanup
- platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp: (WebCore::releaseCachedStops): Use static_cast instead of reinterpret_cast. (WebCore::cgGradientCallback): Ditto.
WebKit/mac:
Reviewed by Mitz.
- http://bugs.webkit.org/show_bug.cgi?id=15981 speed up visited-link code a bit
- History/WebHistory.mm: Removed unused Latin-1 code path. (-[_WebCoreHistoryProvider containsURL:length:]): Updated for method name change.
WebKit/win:
Reviewed by Mitz.
- http://bugs.webkit.org/show_bug.cgi?id=15981 speed up visited-link code a bit
- WebHistory.cpp: Removed unused Latin-1 code path. (_WebCoreHistoryProvider::containsItem): Updated for function name change.
- 2:45 PM Changeset in webkit [28535] by
-
- 2 edits in trunk/WebCore
Fix build on Tiger (Mark Rowe told me how).
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: Include <objc/objc-runtime.h>, which existed back on Tiger, rather than <objc/runtime.h>, which did not.
- 2:45 PM Changeset in webkit [28534] by
-
- 2 edits in trunk/JavaScriptCore
Build fix: added JSVariableObject.cpp to the .pri file.
- JavaScriptCore.pri:
- 2:37 PM Changeset in webkit [28533] by
-
- 2 edits in trunk/JavaScriptCore
Build fix: added #include.
- kjs/function.cpp:
- 2:33 PM Changeset in webkit [28532] by
-
- 2 edits in trunk/WebCore
Build fix: rolling out last build fix to change #include path.
WARNING: NO TEST CASES ADDED OR CHANGED
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- 2:30 PM Changeset in webkit [28531] by
-
- 15 edits in trunk
Re-named our B&I flag from BUILDBOT to PRODUCTION.
Reviewed by Sam Weinig.
- JavaScriptCore.vcproj/JavaScriptCore.make:
- JavaScriptCore.vcproj/testkjs/testkjs.vcproj:
WebCore:
Re-named our B&I flag from BUILDBOT to PRODUCTION.
Reviewed by Sam Weinig.
- WebCore.vcproj/WebCore.make:
WebKit/win:
Re-named our B&I flag from BUILDBOT to PRODUCTION.
Fix our tiny versioning.
Bump our product version.
Use just the major version in the fallback VERSION files.
Pick up the version numbers from the production builder.
Reviewed by Sam Weinig.
- Interfaces/WebKit.idl:
- WebKit.vcproj/Interfaces.vcproj:
- WebKit.vcproj/PRODUCTVERSION:
- WebKit.vcproj/VERSION:
- WebKit.vcproj/WebKit.make:
- WebKit.vcproj/WebKit.rc:
- WebKit.vcproj/WebKit.vcproj:
- WebKit.vcproj/auto-version.sh:
- WebKitDLL.cpp: (DllUnregisterServer):
- 2:26 PM Changeset in webkit [28530] by
-
- 2 edits in trunk/WebCore
Build fix: corrected #include path.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
- 2:23 PM Changeset in webkit [28529] by
-
- 2 edits in trunk/JavaScriptCore
Build fix: removed stray name qualification.
- kjs/function.h: (KJS::ActivationImp::ActivationImp):
- 2:14 PM Changeset in webkit [28528] by
-
- 2 edits in trunk/JavaScriptCore
Build fix: moved functions with qualified names outside of class
declaration.
- kjs/JSVariableObject.h: (KJS::JSVariableObject::symbolTableGet): (KJS::JSVariableObject::symbolTablePut):
- 2:05 PM Changeset in webkit [28527] by
-
- 17 edits4 adds in trunk
Reviewed by Sam Weinig.
Next step in refactoring JSGlobalObject: Added JSVariableObject class,
and factored symbol-table-related code into it. (JSGlobalObject doesn't
use the symbol table code yet, though.)
Layout and JS tests, and testapi, pass. SunSpider reports no regression.
WebCore:
Reviewed by Sam Weinig.
Added some namespace qualifications and a forwarding header, now that
KJS::Node is sometimes #included in WebCore by JavaScriptCore headers.
- ForwardingHeaders/wtf/ListRefPtr.h: Added.
- bindings/js/JSXSLTProcessor.cpp: (KJS::JSXSLTProcessorPrototypeFunctionTransformToFragment::callAsFunction):
- bindings/js/kjs_binding.cpp: (KJS::ScriptInterpreter::getDOMNodeForDocument): (KJS::ScriptInterpreter::forgetDOMNodeForDocument): (KJS::ScriptInterpreter::putDOMNodeForDocument): (KJS::ScriptInterpreter::markDOMNodesForDocument): (KJS::ScriptInterpreter::updateDOMNodeDocument):
WebKit/mac:
Reviewed by Sam Weinig.
Added a forwarding header, since we now #include nodes.h through some
JavaScriptCore headers.
- ForwardingHeaders/wtf/ListRefPtr.h: Added.
- 12:21 PM Changeset in webkit [28526] by
-
- 7 edits1 add in trunk
Add SoftLinking.h for Windows and use it in a few places
WebCore:
Add SoftLinking.h for Windows and use it in a few places
Reviewed by Oliver.
- WebCore.vcproj/WebCore.vcproj: Added new file to project.
- platform/win/PlatformScrollBarSafari.cpp: Use SoftLinking.h. (WebCore::PlatformScrollbar::PlatformScrollbar): Removed manual soft-linking calls. (WebCore::PlatformScrollbar::paintButton): Check for the presence of the SafariTheme library now that we can't check for the presence of paintThemePart directly. (WebCore::PlatformScrollbar::paintTrack): Ditto. (WebCore::PlatformScrollbar::paintThumb): Ditto.
- platform/win/SoftLinking.h: Copied from WebCore/platform/mac/SoftLinking.h.
- rendering/RenderThemeSafari.cpp: Same basic changes as to PlatformScrollBarSafari.cpp. (WebCore::RenderThemeSafari::RenderThemeSafari): (WebCore::RenderThemeSafari::isControlStyled): (WebCore::RenderThemeSafari::paintCapsLockIndicator):
- rendering/RenderThemeSafari.h: Removed m_themeDLL member.
WebKit/win:
Use SoftLinking.h in WebKitClassFactory.
Reviewed by Oliver.
- WebKitClassFactory.cpp: (WebKitClassFactory::WebKitClassFactory): We don't have to worry about not finding STInitialize anymore now that a version of SafariTheme containing this function has shipped.
- 11:59 AM Changeset in webkit [28525] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Geoff.
- fix http://bugs.webkit.org/show_bug.cgi?id=16185 jsRegExpCompile should not add implicit non-capturing bracket
While this does not make SunSpider faster, it will make many regular
expressions a bit faster.
- pcre/pcre_compile.cpp: Moved CompileData struct in here from the header since it's private to this file. (compile_branch): Updated for function name change. (compile_bracket): Renamed from compile_regex, since, for one thing, this does not compile an entire regular expression. (calculateCompiledPatternLengthAndFlags): Removed unused item_count local variable. Renamed CompileData to cd instead of compile_block to be consistent with other functions. Added code to set the needOuterBracket flag if there's at least one "|" at the outer level. (jsRegExpCompile): Renamed CompileData to cd instead of compile_block to be consistent with other functions. Removed unneeded "size" field from the compiled regular expression. If no outer bracket is needed, then use compile_branch to compile the regular expression.
- pcre/pcre_internal.h: Removed the CompileData struct, which is now private to pcre_compile.cpp. Removed the size member from JSRegExp.
- 11:44 AM Changeset in webkit [28524] by
-
- 8 edits2 adds in trunk
WebCore:
Reviewed by Adele.
- fix <rdar://problem/5608795> CrashTracer: 481 crashes in Safari at WebCore::HTMLSelectElement::saveState const + 152
Test: fast/forms/select-set-inner.html
- dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Added a return value, as with other calls that change children, so we can optimize for the case where it does nothing. (WebCore::ContainerNode::cloneChildNodes): Changed parameter type to ContainerNode.
- dom/ContainerNode.h: See above.
- html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::removeChildren): Override removeChildren and call recalcSelectOptions in that case. (WebCore::HTMLOptGroupElement::childrenChanged): Override childrenChanged instead of addChild, for consistency with HTMLSelectElement; no need to override both. (WebCore::HTMLOptGroupElement::groupLabelText): Made const.
- html/HTMLOptGroupElement.h: See above.
- html/HTMLSelectElement.cpp: Don't override addChild any more, because we already override childrenChanged, and addChild calls that. (WebCore::HTMLSelectElement::removeChildren): Override removeChildren and call recalcSelectOptions in that case. (WebCore::HTMLSelectElement::recalcListItems): Tightened up the code a little bit by using a for loop and traverseNextSibling. Also added some new comments and removed some obsolete ones. (WebCore::HTMLSelectElement::checkListItems): Added. Debug-only check to make sure we don't have a stale list items vector.
- html/HTMLSelectElement.h: Changed listItems() to invoke checkListItems(). This will help us catch cases where we have too few calls to setRecalcListItems.
LayoutTests:
Reviewed by Adele.
- test for <rdar://problem/5608795> CrashTracer: 481 crashes in Safari at WebCore::HTMLSelectElement::saveState const + 152
- fast/forms/select-set-inner-expected.txt: Added.
- fast/forms/select-set-inner.html: Added.
- 11:24 AM Changeset in webkit [28523] by
-
- 17 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
- WebCore part of fixing <rdar://problem/5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges
Test: fast/repaint/focus-ring.html
- editing/SelectionController.cpp: (WebCore::SelectionController::caretRepaintRect): Changed to return just the caret rect without any padding. (WebCore::SelectionController::recomputeCaretRect): Changed to repaint just the caret rect without any padding.
- platform/graphics/GraphicsContext.h: Removed setFocusRingClip() and clearFocusRingClip().
- platform/graphics/cairo/GraphicsContextCairo.cpp: Ditto.
- platform/graphics/cg/GraphicsContextCG.cpp: Ditto.
- platform/graphics/cg/GraphicsContextPlatformPrivate.h: Removed m_focusRingClip member.
- platform/graphics/mac/GraphicsContextMac.mm: (WebCore::GraphicsContext::drawFocusRing): Changed to call wkDrawFocusRing() once without setting up additional clip. On Leopard, wkDrawFocusRing() respects the context clip now. On Tiger, a transparency layer is used to apply clipping to the focus ring.
- platform/graphics/qt/GraphicsContextQt.cpp: Removed focus ring clip methods and member.
- platform/graphics/wx/GraphicsContextWx.cpp: Ditto.
- platform/mac/WebCoreSystemInterface.h: Removed the clipRect argument to wkDrawFocusRing().
- platform/mac/WebCoreSystemInterface.mm: Ditto.
- rendering/RenderLayer.cpp: (WebCore::setClip): Removed call to set the focus ring clip. (WebCore::restoreClip): Removed call to reset the focus ring clip.
WebKitLibraries:
Reviewed by Darin Adler.
- updated system interface for fixing <rdar://problem/5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceLeopard.a:
- libWebKitSystemInterfaceTiger.a:
LayoutTests:
Reviewed by Darin Adler.
- repaint test for <rdar://problem/5499918> REGRESSION: insertion point in input field with custom border cuts holes in focus ring interior edges
- fast/repaint/focus-ring.html: Added.
- platform/mac/fast/repaint/focus-ring-expected.checksum: Added.
- platform/mac/fast/repaint/focus-ring-expected.png: Added.
- platform/mac/fast/repaint/focus-ring-expected.txt: Added.
- 11:09 AM Changeset in webkit [28522] by
-
- 2 edits in trunk/WebKitSite
Reviewed by Adam Roben
- misc/DatabaseExample.html: Changed to differentiate failure between running with an unsupported browser or some other error that prevented the database from opening. In the future we can use ExceptionCodes returned from openDatabase(), but a good list of those don't exist yet
- 10:44 AM Changeset in webkit [28521] by
-
- 11 edits in trunk/WebCore
Reviewed by Antti Koivisto and Kevin Decker.
- fix <rdar://problem/5601586> QtKit should be dynamically loaded upon need, not linked at startup
Also did a lot of small tweaks to MediaPlayerPrivateQTKit.
- WebCore.xcodeproj/project.pbxproj: Don't link to QTKit.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h: Omit unneeded includes and declarations. Made a lot more functions const. Made a few more members private and a couple inline.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: Added soft linking machinery for all the things we currently use in QTKit. It's a little more awkward for classes and other data objects than it is for functions, but still relatively straightforward, with no changes needed to the client code. Added using namespace directives. Made a cuePointTimerInterval constant and put it at the top of the file. Use 0 consistently instead of sometimes 0 and sometimes 0.0f. (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): Removed unneeded initialization of RetainPtr members to nil. (WebCore::MediaPlayerPrivate::createQTMovie): Use adoptNS instead of autorelease. (WebCore::MediaPlayerPrivate::createQTMovieView): Ditto. Also use -[NSColor clearColor]. (WebCore::MediaPlayerPrivate::createQTTime): Remove an unneeded type cast that had no effect. Changed to use long instead of int because that's the type for a QTTime time scale anyway. (WebCore::MediaPlayerPrivate::duration): Use a static_cast instead of a C-style cast. (WebCore::MediaPlayerPrivate::currentTime): Ditto. Also merged into a single expression. (WebCore::MediaPlayerPrivate::cuePointTimerFired): Added code to make a copy of the cue points set to avoid a potential problem with a set being modified as we iterate it. (WebCore::MediaPlayerPrivate::bytesLoaded): Removed unneeded null check of m_qtMovie. (WebCore::MediaPlayerPrivate::updateStates): Instead of comments explaining the numeric values, used the constants from the headers directly. (WebCore::MediaPlayerPrivate::getSupportedTypes): Instead of (QTMovieFileTypeOptions)0, pass the named constant with value 0, QTIncludeCommonTypes. Skipped the intermediate type of NSString to remove one cast. Replaced C-style cast with reinterpret_cast (arguably no better). Used RetainPtr instead of explicit CFRelease calls.
- platform/mac/SoftLinking.h: Added macros to do soft linking for classes and for pointers. It's not quite as automatic as the soft linking we can do for functions, since these define functions to get the values, so you need to define macros to make what look like variable accesses turn into function calls. See MediaPlayerPrivateQTKit for the details.
- html/HTMLMediaElement.h:
- html/TimeRanges.h:
- html/VoidCallback.h:
- platform/graphics/MediaPlayer.h: Use angle brackets for wtf includes. Omit unneeded includes.
- 10:43 AM Changeset in webkit [28520] by
-
- 3 edits in trunk/WebKit/win
<rdar://problem/5556378> Implemented database related UI delegate methods (prompts for new/enlarged databases)
Reviewed by Darin.
- Interfaces/IWebUIDelegatePrivate.idl:
- WebChromeClient.cpp: (WebChromeClient::requestQuotaIncreaseForNewDatabase): (WebChromeClient::requestQuotaIncreaseForDatabaseOperation):
- 10:26 AM Changeset in webkit [28519] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=16334 <rdar://problem/5634923> REGRESSION (r28299): Homepage of any DotMac Web Gallery won't load completely
Test: fast/dynamic/subtree-no-common-root-static-y.html
- rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout): Changed the call to setChildNeedsLayout() to not mark containing blocks and added a separate call to markContainingBlocksForLayout() that will not schedule a layout if we are already in the middle of scheduleRelayoutOfSubtree().
LayoutTests:
Reviewed by Darin Adler.
- test for http://bugs.webkit.org/show_bug.cgi?id=16334 <rdar://problem/5634923> REGRESSION (r28299): Homepage of any DotMac Web Gallery won't load completely
- fast/dynamic/subtree-no-common-root-static-y.html: Added.
- platform/mac/fast/dynamic/subtree-no-common-root-static-y-expected.checksum: Added.
- platform/mac/fast/dynamic/subtree-no-common-root-static-y-expected.png: Added.
- platform/mac/fast/dynamic/subtree-no-common-root-static-y-expected.txt: Added.
- 9:24 AM Changeset in webkit [28518] by
-
- 3 edits in trunk/WebKit/wx
Fix wxWebKit page leaks.
Reviewed by Darin Adler.
- 9:18 AM Changeset in webkit [28517] by
-
- 2 edits in trunk/JavaScriptCore
MSVC7 build fix due to a compiler bug with placement new and/or templates and casting.
Reviewed by Darin Adler.
- 4:26 AM HackingGtk edited by
- Movie -> MediaPlayer in SVN link (diff)
- 3:47 AM Changeset in webkit [28516] by
-
- 2 edits in trunk/WebKit/gtk
2007-12-07 Luca Bruno <lethalman88@gmail.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16333
[GTK] Key bindings must work with focused frames.
There are still more cases where getFrameFromView() is mis-used that
need to be fixed, but this is a good start.
- WebView/webkitwebview.cpp: (webkit_web_view_real_select_all): (webkit_web_view_real_cut_clipboard): (webkit_web_view_real_copy_clipboard): (webkit_web_view_real_paste_clipboard):
- 2:17 AM Changeset in webkit [28515] by
-
- 3 edits2 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16325
<rdar://problem/5632997> REGRESSION: www.xerox.ru doesn't work
Test: http/tests/misc/empty-cookie.html
- platform/mac/CookieJar.mm: (WebCore::setCookies): Don't store empty cookies. (WebCore::cookies): Filter out empty cookies if we have them, as they could have been set with an earlier version of Leopard!
Dec 6, 2007:
- 11:27 PM Changeset in webkit [28514] by
-
- 2 edits in trunk/WebCore
Fixed the if statement (ERROR_SUCCESS is 0 and we were actually
returning true when there's an error).
Reviewed by Steve.
- platform/win/FileSystemWin.cpp: (WebCore::makeAllDirectories):
- 11:02 PM Changeset in webkit [28513] by
-
- 1 edit10 adds in trunk/LayoutTests
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16091
JSCRE needs to import the PCRE test suite
We can use two files from PCRE test suite, as others either test for features not supported
in JS, or use internal debugging facilities of PCRE.
The files are checked in almost unmodified, I have only converted them to UTF-8 and removed two
huge test cases that were completely incompatible with JSC, and were polluting the output.
Many of the failures in results are just legitimate differences in behavior or possibly
problems with the test runner, but some may be genuine bugs and even regressions in JSC.
- fast/regex: Added.
- fast/regex/pcre-test-runner.js: Added.
- fast/regex/test1-expected.txt: Added.
- fast/regex/test1.html: Added.
- fast/regex/test4-expected.txt: Added.
- fast/regex/test4.html: Added.
- fast/regex/testinput1: Added.
- fast/regex/testinput4: Added.
- fast/regex/testoutput1: Added.
- fast/regex/testoutput4: Added.
- 10:17 PM Changeset in webkit [28512] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Oliver's rubber stamp
Let's go ahead and call the correct UI Delegate method, shall we?
- WebCoreSupport/WebChromeClient.mm: (WebChromeClient::requestQuotaIncreaseForDatabaseOperation): Call the correct UI delegate
- 9:33 PM Changeset in webkit [28511] by
-
- 3 edits in trunk/WebKit/wx
Linux build fix - ensure that webcore is linked before jscore so that the linker will know which symbols it needs to link in. Also fix MSVC project file name typo for sample app.
- 7:59 PM Changeset in webkit [28510] by
-
- 2 edits in trunk/WebCore
- fix broken regression test
- bindings/js/kjs_binding.cpp: (KJS::setDOMException): Oops, this was just supposed to be PERMISSION_DENIED.
- 7:18 PM Changeset in webkit [28509] by
-
- 9 edits1 copy in trunk/WebCore
Reviewed by Sam Weinig.
- fix http://bugs.webkit.org/show_bug.cgi?id=16332 ObjC DOM exception object descriptions should include the exception name
- WebCore.pro: Added ExceptionCode.cpp.
- WebCore.vcproj/WebCore.vcproj: Added ExceptionCode.cpp.
- WebCore.xcodeproj/project.pbxproj: Added ExceptionCode.cpp.
- WebCoreSources.bkl: Added ExceptionCode.cpp.
- bindings/js/kjs_binding.cpp: (KJS::setDOMException): Moved the code to decompose an ExceptionCode into ExceptionCode.h/cpp -- getExceptionCodeDescription. Also removed the many unneeded includes that were here. Had to keep one special case here, for SECURITY_ERR.
- bindings/objc/ExceptionHandlers.mm: (WebCore::raiseDOMException): Changed to use the new getExceptionCodeDescription function so that this shares the exception name information that was previously only available to JavaScript.
- dom/ExceptionCode.cpp: Copied from bindings/js/kjs_binding.cpp. (WebCore::getExceptionCodeDescription): Added some assertions, and made the function handle exception names in a slightly more robust way that is not subject to integer overflow. (Not a real world issue since we should never receive a bad exception code.)
- dom/ExceptionCode.h: Added the ExceptionCodeDescription struct and the getExceptionCodeDescription function.
- svg/SVGException.h: Added a missing #include and got rid of some comments. Some of the comments were mildly helpful, but others were incorrect. This now matches the other exception-related headers such as RangeException.h.
- 6:49 PM Changeset in webkit [28508] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin
Fixed a glaring bug that would prevent a statement from getting run a second time
- storage/SQLStatement.cpp: (WebCore::SQLStatement::execute): Clear failure due to quota *before* we check the error and return early (WebCore::SQLStatement::clearFailureDueToQuota): Only clear the error if it was a quota error
- 6:10 PM Changeset in webkit [28507] by
-
- 4 edits in trunk/WebCore
Reviewed by Oliver Hunt.
Use keydown instead of keypress so keyIdentifier can be used.
- page/inspector/ConsolePanel.js: Use keydown instead of keypress.
- page/inspector/DatabasePanel.js: Ditto.
- page/inspector/inspector.js: Ditto. Plus call removeEventListener before deleting windowLoaded.
- 6:05 PM Changeset in webkit [28506] by
-
- 2 edits in trunk/WebCore
Rename FontsTable.plist to FontsList.plist
Rubberstamped by Hyatt.
- platform/graphics/win/FontDatabase.cpp:
- 6:00 PM Changeset in webkit [28505] by
-
- 4 edits in trunk/WebKit/win
Fixed <rdar://5540000> onbeforeunload doesn't fire when closing window/tab
Reviewed by Darin.
- Interfaces/IWebViewPrivate.idl:
- WebView.cpp: (WebView::shouldClose):
- WebView.h:
- 5:51 PM Changeset in webkit [28504] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin
Tweaked a comment and a few assertions from my last checkin
- storage/SQLStatement.cpp: (WebCore::SQLStatement::execute): (WebCore::SQLStatement::clearFailureDueToQuota): (WebCore::SQLStatement::lastExecutionFailedDueToQuota):
- 5:04 PM Changeset in webkit [28503] by
-
- 4 edits in trunk/WebKit
Fix <rdar://5615283> Crash in WebFrame::receivedPolicyDecision
WebKit/mac:
Remove some assertions we know can fire and replace them with a FIXME
Reviewed by Anders.
- WebCoreSupport/WebFrameLoaderClient.mm:
WebKit/win:
Fix <rdar://5615283> Crash in WebFrame::receivedPolicyDecision
It's possible for a second policy listener to be created while we're
waiting for a decision on the first policy listener. In this case we
would crash when the first policy listener had a decision made. Mac
WebKit already handles this by invalidating any existing policy
listener when creating a new one.
A test case is coming in a future commit.
Reviewed by Anders.
- WebFrame.cpp: (WebFrame::setUpPolicyListener): Copy the Mac behavior of invalidating any existing policy listener, and remove some assertions that we know can fire.
- 4:50 PM Changeset in webkit [28502] by
-
- 9 edits in trunk/WebCore
Reviewed by Darin
Finished hooking up UI Delegate for databases - Database operations will now enforce a size quota and
will ask the UI Delegate for more space when that quota is met
- platform/sql/SQLiteDatabase.cpp: Add the new SQLResultFull constant
- platform/sql/SQLiteDatabase.h: Ditto
- storage/Database.cpp: (WebCore::Database::securityOriginData): Added this accessor, copying for thread safety (WebCore::Database::stringIdentifier): Ditto
- storage/Database.h:
- storage/SQLStatement.cpp: (WebCore::SQLStatement::SQLStatement): (WebCore::SQLStatement::execute): Change to return an enum that represents 3 states - success, error, and quota. If the result is quota, this statement expects that it might be run again, presumably after the user increases the quota (WebCore::SQLStatement::setFailureDueToQuota): Setup a quota failure, including a flag and the error (WebCore::SQLStatement::clearFailureDueToQuota): Clear a quota failure, for when the statement is rerun (WebCore::SQLStatement::lastExecutionFailedDueToQuota):
- storage/SQLStatement.h:
- storage/SQLTransaction.cpp: (WebCore::SQLTransaction::SQLTransaction): (WebCore::SQLTransaction::performPendingCallback): Added an acceptable callback pointer (WebCore::SQLTransaction::openTransactionAndPreflight): Setup the quota in the database that will remain for this transaction. Note that in this patch, the quota being set is wrong - it makes sense to fix that in a follow up patch (WebCore::SQLTransaction::runStatements): Modified to add the ability to re-run a statement based on the UI delegate decision and whether the current statement was already run (WebCore::SQLTransaction::runCurrentStatement): Added another result condition - the Quota result - and handle it (WebCore::SQLTransaction::handleCurrentStatementError): Statements can now error-out from two places, so the code that handles a statement error was moved here (WebCore::SQLTransaction::deliverQuotaIncreaseCallback): Added - Consult the UI delegate for more quota, then reschedule the current statement on the database thread
- storage/SQLTransaction.h:
- 3:32 PM Changeset in webkit [28501] by
-
- 2 edits in trunk/WebKit/mac
Change the ASSERT added for the previous fix. The ASSERT was firing for 10.5.0.
Only assert if the major version is zero, since zero is handled in the other cases.
- WebView/WebView.mm: (callGestalt): Remove the ASSERT. (createMacOSXVersionString): ASSERT that major is not zero.
- 3:31 PM Changeset in webkit [28500] by
-
- 2 edits in trunk/WebCore
<rdar://problem/5614257> Crash in timer / hashtable code due to uncaught exception
Don't use callback-based timers, since these cause Windows to eat Windows crashes
in code the timers call.
Windows appears to be defending against "shatter" attacks partially by setting
up a structured exception block while dispatching callback-based WM_TIMERs.
I verified this by adding a divide by zero into some timer callback code.
In the case where the timer was dispatched via a callback, the divide by zero
exception was silently handled and ignored, with execution continuing after
our call to DispatchMessage. When processed via the WNDPROC, no SEH
block was established by Windows, and our divide by zero generated a real
crash (which is what we wanted).
Windows handling our crashes for us led us to leave the timer data structures
in an invalid state so the next time a timer was set, we'd crash accessing an
invalid HashMap of timer data.
Reviewed by Hyatt.
- platform/win/SharedTimerWin.cpp: (WebCore::TimerWindowWndProc): (WebCore::setSharedTimerFireTime):
- 2:36 PM Changeset in webkit [28499] by
-
- 2 edits in trunk/WebKit/mac
Reviewed by Tim Hatcher.
- fix <rdar://problem/5513394> No way to detect Tiger vs Leopard from Safari's user agent string
- WebView/WebView.mm: (callGestalt): Added. (createMacOSXVersionString): Added. (-[WebView _userAgentWithApplicationName:andWebKitVersion:]): Added Mac OS X version string, right after the string "Mac OS X", but with underscores instead of dots to avoid the dreaded "4." problem (old libraries that think a "4." anywhere in the user agent means Netscape 4). (-[WebView _userAgentForURL:]): Fixed incorrect bug numbers.
- 2:11 PM Changeset in webkit [28498] by
-
- 9 edits in trunk
Fix <rdar://5108390> Feed title is too low in blue banner
WebCore:
Fix <rdar://5108390> Feed title is too low in blue banner
Way back in r23069 we started applying the same font ascent hack that
Mac WebKit applies to Helvetica, Times, and Courier. We did this so
that those fonts would match the Mac metrics when we run the
regression tests. However, this hack was applying to Arial on Windows
when a site would specify the Helvetica font face because Windows will
alias the font names. Instead of removing the hack entirely, we
turn it off by default but provide some SPI so that DumpRenderTree can
turn it on.
Reviewed by Hyatt.
All tests pass.
- platform/graphics/FontData.h: Add a new static method to turn on the hack on Windows only.
- platform/graphics/win/FontDataWin.cpp: (WebCore::FontData::setShouldApplyMacAscentHack): Added. (WebCore::FontData::platformInit): Only perform the hack if shouldApplyMacAscentHack is true.
WebKit/win:
Add SPI so that DumpRenderTree can turn on the Mac font ascent hack
Reviewed by Hyatt.
- Interfaces/IWebViewPrivate.idl: Added new method declaration.
- WebView.cpp: (WebView::setShouldApplyMacFontAscentHack): Added. Just calls down to FontData.
- WebView.h:
WebKitTools:
Explicitly turn on the Mac font ascent hack on Windows
This keeps our font metrics matching those from Mac.
Reviewed by Hyatt.
- DumpRenderTree/win/DumpRenderTree.cpp: (main):
- 1:25 PM Changeset in webkit [28497] by
-
- 3 edits in trunk/LayoutTests
- updated render tree results for r28483
- svg/batik/text/textEffect2-expected.txt:
- svg/batik/text/textProperties-expected.txt:
- 1:19 PM Changeset in webkit [28496] by
-
- 3 edits3 adds in trunk
WebCore:
Reviewed by Sam Weinig.
Fixed http://bugs.webkit.org/show_bug.cgi?id=16328
REGRESSION (r28470): Crash expanding a GMail conversation
- page/Frame.cpp: (WebCore::Frame::scriptProxy): Only return 0 if JS seems disabled *and* we haven't created the proxy yet. If we've created the proxy already, a script may be in the midst of execution, even though we've lost our settings object. During execution, scripts assume they have free access to the proxy.
LayoutTests:
Reviewed by Sam Weinig.
Test for http://bugs.webkit.org/show_bug.cgi?id=16328
REGRESSION (r28470): Crash expanding a GMail conversation
- fast/frames/location-put-after-removal.html: Added.
- fast/frames/resources/location-put-after-removal-frame.html: Added.
- fast/frames/resources/location-put-after-removal-frame-expected.txt: Updated.
- 1:17 PM Changeset in webkit [28495] by
-
- 1 edit1 copy in trunk/WebKitTools
Rename main.c to main.cpp here too.
- DumpRenderTree/win/TestNetscapePlugin/main.cpp: Copied from DumpRenderTree/win/TestNetscapePlugin/main.c.
- 1:10 PM Changeset in webkit [28494] by
-
- 2 edits in trunk/WebKitTools
Rubber stamped by Geoff.
- Scripts/do-webcore-rename: Don't rename kjs_css twice.
- 1:00 PM Changeset in webkit [28493] by
-
- 2 edits in trunk/WebKitTools
- Scripts/do-webcore-rename: Some more renaming plans.
- 12:37 PM Changeset in webkit [28492] by
-
- 2 edits in trunk/WebKitTools
Remove implementation of testGetIntIdentifier that was accidentally
removed somehow (possibly when I made PluginObject be a cpp file).
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginInvoke):
- 12:24 PM Changeset in webkit [28491] by
-
- 5 edits in trunk
Reviewed by Eric Seidel.
- fix http://bugs.webkit.org/show_bug.cgi?id=16321 new RegExp("[\u0097]{4,6}", "gmy") crashes in DEBUG builds <rdar://problem/5632992>
Test: fast/js/regexp-oveflow.html
- pcre/pcre_compile.cpp: (calculateCompiledPatternLengthAndFlags): In the case where a single character character class is optimized to not use a character class at all, the preflight code was not setting the lastitemlength variable.
LayoutTests:
Reviewed by Eric Seidel.
- fix http://bugs.webkit.org/show_bug.cgi?id=16321 new RegExp("[\u0097]{4,6}", "gmy") crashes in DEBUG builds <rdar://problem/5632992>
- fast/js/regexp-overflow-expected.txt: Updated.
- fast/js/resources/regexp-overflow.js: Added test.
- 12:11 PM Changeset in webkit [28490] by
-
- 5 edits in trunk/WebKit/gtk
2007-12-06 Xan Lopez <xan@gnome.org>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16329
[GTK] Two small cleanups
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::createWindow): (WebKit::ChromeClient::addMessageToConsole): (WebKit::ChromeClient::runJavaScriptAlert): (WebKit::ChromeClient::runJavaScriptConfirm): (WebKit::ChromeClient::runJavaScriptPrompt): (WebKit::ChromeClient::setStatusbarText): (WebKit::ChromeClient::mouseDidMoveOverElement): (WebKit::ChromeClient::setToolTip):
- WebCoreSupport/ChromeClientGtk.h:
- WebView/webkitprivate.cpp: (WebKit::kit): s/m_webPage/m_webView/
- WebView/webkitwebview.cpp: Chain up to the parent class to activate bindings instead of doing it explicitely.
- 12:02 PM Changeset in webkit [28489] by
-
- 4 edits4 adds in trunk
WebCore:
Reviewed by Oliver.
Fix for <rdar://problem/5631356> Toggling display property on video causes controls to get lost
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::attach): Call updateFromElement.
- html/HTMLMediaElement.h:
LayoutTests:
Reviewed by Oliver.
Fix <rdar://problem/5631356> Toggling display property on video causes controls to get lost
- media/video-display-toggle.html: Added.
- platform/mac/media/video-display-toggle-expected.checksum: Added.
- platform/mac/media/video-display-toggle-expected.png: Added.
- platform/mac/media/video-display-toggle-expected.txt: Added.
- 11:33 AM Changeset in webkit [28488] by
-
- 2 edits in trunk/WebKit/win
Build fix.
Reviewed by Geoff.
- WebScriptCallFrame.cpp: (WebScriptCallFrame::valueByEvaluatingJavaScriptFromString):
- 10:46 AM Changeset in webkit [28487] by
-
- 12 edits6 moves in trunk/WebCore
Reviewed by Oliver.
Rename
Movie -> MediaPlayer
MoviePrivate -> MediaPlayerPrivate
Movie is QuickTime terminology and clashes with its C API.
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): (WebCore::HTMLMediaElement::~HTMLMediaElement): (WebCore::HTMLMediaElement::initAndDispatchProgressEvent): (WebCore::HTMLMediaElement::bufferingRate): (WebCore::HTMLMediaElement::load): (WebCore::HTMLMediaElement::mediaPlayerNetworkStateChanged): (WebCore::HTMLMediaElement::mediaPlayerReadyStateChanged): (WebCore::HTMLMediaElement::setReadyState): (WebCore::HTMLMediaElement::progressEventTimerFired): (WebCore::HTMLMediaElement::seek): (WebCore::HTMLMediaElement::currentTime): (WebCore::HTMLMediaElement::duration): (WebCore::HTMLMediaElement::playbackRate): (WebCore::HTMLMediaElement::setPlaybackRate): (WebCore::HTMLMediaElement::play): (WebCore::HTMLMediaElement::pause): (WebCore::HTMLMediaElement::setVolume): (WebCore::HTMLMediaElement::setMuted): (WebCore::HTMLMediaElement::pickMedia): (WebCore::HTMLMediaElement::checkIfSeekNeeded): (WebCore::HTMLMediaElement::mediaPlayerVolumeChanged): (WebCore::HTMLMediaElement::mediaPlayerTimeChanged): (WebCore::HTMLMediaElement::mediaPlayerCuePointReached): (WebCore::HTMLMediaElement::addCuePoint): (WebCore::HTMLMediaElement::buffered): (WebCore::HTMLMediaElement::seekable): (WebCore::HTMLMediaElement::effectiveStart): (WebCore::HTMLMediaElement::effectiveEnd): (WebCore::HTMLMediaElement::effectiveLoopStart): (WebCore::HTMLMediaElement::effectiveLoopEnd): (WebCore::HTMLMediaElement::updateMediaPlayer): (WebCore::HTMLMediaElement::willSaveToCache):
- html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::player):
- html/HTMLVideoElement.cpp: (WebCore::HTMLVideoElement::videoWidth): (WebCore::HTMLVideoElement::videoHeight):
- platform/MIMETypeRegistry.cpp: (WebCore::initialiseSupportedMediaMIMETypes): (WebCore::MIMETypeRegistry::isSupportedMediaMIMEType): (WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes):
- platform/MIMETypeRegistry.h:
- platform/graphics/MediaPlayer.cpp: Copied from WebCore/platform/graphics/Movie.cpp. (WebCore::MediaPlayer::MediaPlayer): (WebCore::MediaPlayer::~MediaPlayer): (WebCore::MediaPlayer::load): (WebCore::MediaPlayer::cancelLoad): (WebCore::MediaPlayer::play): (WebCore::MediaPlayer::pause): (WebCore::MediaPlayer::duration): (WebCore::MediaPlayer::currentTime): (WebCore::MediaPlayer::seek): (WebCore::MediaPlayer::paused): (WebCore::MediaPlayer::seeking): (WebCore::MediaPlayer::naturalSize): (WebCore::MediaPlayer::hasVideo): (WebCore::MediaPlayer::networkState): (WebCore::MediaPlayer::readyState): (WebCore::MediaPlayer::volume): (WebCore::MediaPlayer::setVolume): (WebCore::MediaPlayer::rate): (WebCore::MediaPlayer::setRate): (WebCore::MediaPlayer::muted): (WebCore::MediaPlayer::setMuted): (WebCore::MediaPlayer::dataRate): (WebCore::MediaPlayer::setEndTime): (WebCore::MediaPlayer::addCuePoint): (WebCore::MediaPlayer::removeCuePoint): (WebCore::MediaPlayer::clearCuePoints): (WebCore::MediaPlayer::maxTimeBuffered): (WebCore::MediaPlayer::maxTimeSeekable): (WebCore::MediaPlayer::bytesLoaded): (WebCore::MediaPlayer::totalBytesKnown): (WebCore::MediaPlayer::totalBytes): (WebCore::MediaPlayer::setRect): (WebCore::MediaPlayer::visible): (WebCore::MediaPlayer::setVisible): (WebCore::MediaPlayer::paint): (WebCore::MediaPlayer::getSupportedTypes): (WebCore::MediaPlayer::networkStateChanged): (WebCore::MediaPlayer::readyStateChanged): (WebCore::MediaPlayer::volumeChanged): (WebCore::MediaPlayer::timeChanged): (WebCore::MediaPlayer::cuePointReached):
- platform/graphics/MediaPlayer.h: Copied from WebCore/platform/graphics/Movie.h. (WebCore::MediaPlayerClient::~MediaPlayerClient): (WebCore::MediaPlayerClient::mediaPlayerNetworkStateChanged): (WebCore::MediaPlayerClient::mediaPlayerReadyStateChanged): (WebCore::MediaPlayerClient::mediaPlayerVolumeChanged): (WebCore::MediaPlayerClient::mediaPlayerTimeChanged): (WebCore::MediaPlayerClient::mediaPlayerCuePointReached):
- platform/graphics/Movie.cpp: Removed.
- platform/graphics/Movie.h: Removed.
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: Copied from WebCore/platform/graphics/gtk/MoviePrivateGStreamer.cpp. (WebCore::mediaPlayerPrivateErrorCallback): (WebCore::mediaPlayerPrivateEOSCallback): (WebCore::mediaPlayerPrivateStateCallback): (WebCore::mediaPlayerPrivateBufferingCallback): (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::play): (WebCore::MediaPlayerPrivate::pause): (WebCore::MediaPlayerPrivate::duration): (WebCore::MediaPlayerPrivate::currentTime): (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::setEndTime): (WebCore::MediaPlayerPrivate::addCuePoint): (WebCore::MediaPlayerPrivate::removeCuePoint): (WebCore::MediaPlayerPrivate::clearCuePoints): (WebCore::MediaPlayerPrivate::startCuePointTimerIfNeeded): (WebCore::MediaPlayerPrivate::cancelSeek): (WebCore::MediaPlayerPrivate::cuePointTimerFired): (WebCore::MediaPlayerPrivate::paused): (WebCore::MediaPlayerPrivate::seeking): (WebCore::MediaPlayerPrivate::naturalSize): (WebCore::MediaPlayerPrivate::hasVideo): (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::setMuted): (WebCore::MediaPlayerPrivate::setRate): (WebCore::MediaPlayerPrivate::dataRate): (WebCore::MediaPlayerPrivate::networkState): (WebCore::MediaPlayerPrivate::readyState): (WebCore::MediaPlayerPrivate::maxTimeBuffered): (WebCore::MediaPlayerPrivate::maxTimeSeekable): (WebCore::MediaPlayerPrivate::maxTimeLoaded): (WebCore::MediaPlayerPrivate::bytesLoaded): (WebCore::MediaPlayerPrivate::totalBytesKnown): (WebCore::MediaPlayerPrivate::totalBytes): (WebCore::MediaPlayerPrivate::cancelLoad): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::loadStateChanged): (WebCore::MediaPlayerPrivate::rateChanged): (WebCore::MediaPlayerPrivate::sizeChanged): (WebCore::MediaPlayerPrivate::timeChanged): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::didEnd): (WebCore::MediaPlayerPrivate::loadingFailed): (WebCore::MediaPlayerPrivate::setRect): (WebCore::MediaPlayerPrivate::setVisible): (WebCore::MediaPlayerPrivate::paint): (WebCore::MediaPlayerPrivate::getSupportedTypes): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h: Copied from WebCore/platform/graphics/gtk/MoviePrivateGStreamer.h.
- platform/graphics/gtk/MoviePrivateGStreamer.cpp: Removed.
- platform/graphics/gtk/MoviePrivateGStreamer.h: Removed.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h: Copied from WebCore/platform/graphics/mac/MoviePrivateQTKit.h.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: Copied from WebCore/platform/graphics/mac/MoviePrivateQTKit.mm. (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::createQTMovie): (WebCore::MediaPlayerPrivate::createQTMovieView): (WebCore::MediaPlayerPrivate::createQTTime): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::play): (WebCore::MediaPlayerPrivate::pause): (WebCore::MediaPlayerPrivate::duration): (WebCore::MediaPlayerPrivate::currentTime): (WebCore::MediaPlayerPrivate::seek): (WebCore::MediaPlayerPrivate::doSeek): (WebCore::MediaPlayerPrivate::cancelSeek): (WebCore::MediaPlayerPrivate::seekTimerFired): (WebCore::MediaPlayerPrivate::setEndTime): (WebCore::MediaPlayerPrivate::addCuePoint): (WebCore::MediaPlayerPrivate::removeCuePoint): (WebCore::MediaPlayerPrivate::clearCuePoints): (WebCore::MediaPlayerPrivate::startCuePointTimerIfNeeded): (WebCore::MediaPlayerPrivate::cuePointTimerFired): (WebCore::MediaPlayerPrivate::paused): (WebCore::MediaPlayerPrivate::seeking): (WebCore::MediaPlayerPrivate::naturalSize): (WebCore::MediaPlayerPrivate::hasVideo): (WebCore::MediaPlayerPrivate::setVolume): (WebCore::MediaPlayerPrivate::setMuted): (WebCore::MediaPlayerPrivate::setRate): (WebCore::MediaPlayerPrivate::dataRate): (WebCore::MediaPlayerPrivate::networkState): (WebCore::MediaPlayerPrivate::readyState): (WebCore::MediaPlayerPrivate::maxTimeBuffered): (WebCore::MediaPlayerPrivate::maxTimeSeekable): (WebCore::MediaPlayerPrivate::maxTimeLoaded): (WebCore::MediaPlayerPrivate::bytesLoaded): (WebCore::MediaPlayerPrivate::totalBytesKnown): (WebCore::MediaPlayerPrivate::totalBytes): (WebCore::MediaPlayerPrivate::cancelLoad): (WebCore::MediaPlayerPrivate::updateStates): (WebCore::MediaPlayerPrivate::loadStateChanged): (WebCore::MediaPlayerPrivate::rateChanged): (WebCore::MediaPlayerPrivate::sizeChanged): (WebCore::MediaPlayerPrivate::timeChanged): (WebCore::MediaPlayerPrivate::volumeChanged): (WebCore::MediaPlayerPrivate::didEnd): (WebCore::MediaPlayerPrivate::setRect): (WebCore::MediaPlayerPrivate::setVisible): (WebCore::MediaPlayerPrivate::paint): (WebCore::MediaPlayerPrivate::getSupportedTypes): (-[WebCoreMovieObserver initWithCallback:WebCore::]):
- platform/graphics/mac/MoviePrivateQTKit.h: Removed.
- platform/graphics/mac/MoviePrivateQTKit.mm: Removed.
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::player):
- rendering/RenderMedia.h:
- rendering/RenderVideo.cpp: (WebCore::RenderVideo::RenderVideo): (WebCore::RenderVideo::~RenderVideo): (WebCore::RenderVideo::videoSizeChanged): (WebCore::RenderVideo::paintReplaced): (WebCore::RenderVideo::layout): (WebCore::RenderVideo::updateFromElement): (WebCore::RenderVideo::updatePlayer):
- rendering/RenderVideo.h:
- 10:26 AM HackingGtk edited by
- Add a link to the GStreamer video backend code (diff)
- 10:01 AM Changeset in webkit [28486] by
-
- 2 edits in trunk/WebCore
Build fix: access global object directly.
- plugins/win/PluginViewWin.cpp: (WebCore::PluginViewWin::bindingInstance):
- 4:20 AM Changeset in webkit [28485] by
-
- 2 edits in trunk/WebCore
Fix bug spotted by GCC 4.2. Remove extraneous semicolon that completely changed the meaning of allowPopUp.
Reviewed by Eric.
- 1:26 AM Changeset in webkit [28484] by
-
- 16 edits in trunk
2007-12-06 Holger Hans Peter Freyther <holger.freyther@trolltech.com>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=16173
Licensing change
Change license from BSD to LGPL.
