Timeline
Dec 16, 2007:
- 11:19 PM Changeset in webkit [28798] by
-
- 10 edits2 copies in trunk/WebCore
Reviewed by Mitz.
Fix for http://bugs.webkit.org/show_bug.cgi?id=16466
Move the JS Location object to its own file
- Move Location into its own file and rename it JSLocation.
- DerivedSources.make:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSDocumentCustom.cpp:
- bindings/js/JSLocation.cpp: Copied from WebCore/bindings/js/kjs_window.cpp. (WebCore::): (WebCore::JSLocation::JSLocation): (WebCore::JSLocation::getValueProperty): (WebCore::JSLocation::getOwnPropertySlot): (WebCore::JSLocation::put): (WebCore::JSLocationProtoFuncReplace::callAsFunction): (WebCore::JSLocationProtoFuncReload::callAsFunction): (WebCore::JSLocationProtoFuncAssign::callAsFunction): (WebCore::JSLocationProtoFuncToString::callAsFunction):
- bindings/js/JSLocation.h: Copied from WebCore/bindings/js/kjs_window.h. (WebCore::JSLocation::): (WebCore::JSLocation::frame): (WebCore::JSLocation::classInfo):
- bindings/js/kjs_window.cpp: (KJS::Window::location):
- bindings/js/kjs_window.h:
- history/CachedPage.cpp:
- 10:26 PM Changeset in webkit [28797] by
-
- 2 edits in trunk/WebCore
Reviewed by Sam Weinig.
- make 'cursor: copy' and 'cursor: none' work.
Already covered by manual-tests/cursor.html
- rendering/RenderStyle.h: Increase the _cursor_style field to 6 bits, needed for the 33rd and 34th cursor values.
- 10:01 PM Changeset in webkit [28796] by
-
- 2 edits in trunk/JavaScriptCore
Speculative build fix for non-Mac platforms.
- 10:00 PM Changeset in webkit [28795] by
-
- 10 edits2 copies1 move1 delete in trunk
Refactor Mac plugin stream code to use the shared NetscapePlugInStreamLoader implementation.
Reviewed by Maciej Stachowiak.
- 8:50 PM Changeset in webkit [28794] by
-
- 9 edits2 copies in trunk/WebCore
Reviewed by Maciej.
Yet more of http://bugs.webkit.org/show_bug.cgi?id=16385
Cleanup kjs_window
- Move ScheduledAction into its own file and put it in the WebCore namespace.
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/PausedTimeouts.cpp:
- bindings/js/PausedTimeouts.h:
- bindings/js/ScheduledAction.cpp: Copied from bindings/js/kjs_window.cpp. (WebCore::ScheduledAction::ScheduledAction): (WebCore::ScheduledAction::execute):
- bindings/js/ScheduledAction.h: Copied from bindings/js/kjs_window.h. (WebCore::ScheduledAction::ScheduledAction):
- bindings/js/kjs_window.cpp: (KJS::DOMWindowTimer::DOMWindowTimer): (KJS::DOMWindowTimer::action): (KJS::DOMWindowTimer::takeAction): (KJS::Window::installTimeout): (KJS::Window::timerFired):
- bindings/js/kjs_window.h:
- 8:19 PM Changeset in webkit [28793] by
-
- 10 edits in trunk/JavaScriptCore
Reviewed by Maciej.
- http://bugs.webkit.org/show_bug.cgi?id=16438
- removed some more unused code
- changed quite a few more names to WebKit-style
- moved more things out of pcre_internal.h
- changed some indentation to WebKit-style
- improved design of the functions for reading and writing 2-byte values from the opcode stream (in pcre_internal.h)
- pcre/dftables.cpp: (main): Added the kjs prefix a normal way in lieu of using macros.
- pcre/pcre_compile.cpp: Moved some definitions here from pcre_internal.h. (errorText): Name changes, fewer typedefs. (checkEscape): Ditto. Changed uppercase conversion to use toASCIIUpper. (isCountedRepeat): Name change. (readRepeatCounts): Name change. (firstSignificantOpcode): Got rid of the use of OP_lengths, which is very lightly used here. Hard-coded the length of OP_BRANUMBER. (firstSignificantOpcodeSkippingAssertions): Ditto. Also changed to use the advanceToEndOfBracket function. (getOthercaseRange): Name changes. (encodeUTF8): Ditto. (compileBranch): Name changes. Removed unused after_manual_callout and the code to handle it. Removed code to handle OP_ONCE since we never emit this opcode. Changed to use advanceToEndOfBracket in more places. (compileBracket): Name changes. (branchIsAnchored): Removed code to handle OP_ONCE since we never emit this opcode. (bracketIsAnchored): Name changes. (branchNeedsLineStart): More fo the same. (bracketNeedsLineStart): Ditto. (branchFindFirstAssertedCharacter): Removed OP_ONCE code. (bracketFindFirstAssertedCharacter): More of the same. (calculateCompiledPatternLengthAndFlags): Ditto. (returnError): Name changes. (jsRegExpCompile): Ditto.
- pcre/pcre_exec.cpp: Moved some definitions here from pcre_internal.h. (matchRef): Updated names. Improved macros to use the do { } while(0) idiom so they expand to single statements rather than to blocks or multiple statements. And refeactored the recursive match macros. (MatchStack::pushNewFrame): Name changes. (getUTF8CharAndIncrementLength): Name changes. (match): Name changes. Removed the ONCE opcode. (jsRegExpExecute): Name changes.
- pcre/pcre_internal.h: Removed quite a few unneeded includes. Rewrote quite a few comments. Removed the macros that add kjs prefixes to the functions with external linkage; instead renamed the functions. Removed the unneeded typedefs pcre_uint16, pcre_uint32, and uschar. Removed the dead and not-all-working code for LINK_SIZE values other than 2, although we aim to keep the abstraction working. Removed the OP_LENGTHS macro. (put2ByteValue): Replaces put2ByteOpcodeValueAtOffset. (get2ByteValue): Replaces get2ByteOpcodeValueAtOffset. (put2ByteValueAndAdvance): Replaces put2ByteOpcodeValueAtOffsetAndAdvance. (putLinkValueAllowZero): Replaces putOpcodeValueAtOffset; doesn't do the addition, since a comma is really no better than a plus sign. Added an assertion to catch out of range values and changed the parameter type to int rather than unsigned. (getLinkValueAllowZero): Replaces getOpcodeValueAtOffset. (putLinkValue): New function that most former callers of the putOpcodeValueAtOffset function can use; asserts the value that is being stored is non-zero and then calls putLinkValueAllowZero. (getLinkValue): Ditto. (putLinkValueAndAdvance): Replaces putOpcodeValueAtOffsetAndAdvance. No caller was using an offset, which makes sense given the advancing behavior. (putLinkValueAllowZeroAndAdvance): Ditto. (isBracketOpcode): Added. For use in an assertion. (advanceToEndOfBracket): Renamed from moveOpcodePtrPastAnyAlternateBranches, and removed comments about how it's not well designed. This function takes a pointer to the beginning of a bracket and advances to the end of the bracket.
- pcre/pcre_tables.cpp: Updated names.
- pcre/pcre_ucp_searchfuncs.cpp: (kjs_pcre_ucp_othercase): Ditto.
- pcre/pcre_xclass.cpp: (getUTF8CharAndAdvancePointer): Ditto. (kjs_pcre_xclass): Ditto.
- pcre/ucpinternal.h: Ditto.
- wtf/ASCIICType.h: (WTF::isASCIIAlpha): Added an int overload, like the one we already have for isASCIIDigit. (WTF::isASCIIAlphanumeric): Ditto. (WTF::isASCIIHexDigit): Ditto. (WTF::isASCIILower): Ditto. (WTF::isASCIISpace): Ditto. (WTF::toASCIILower): Ditto. (WTF::toASCIIUpper): Ditto.
- 8:08 PM Changeset in webkit [28792] by
-
- 4 edits2 adds in trunk/WebCore
2007-12-16 Alp Toker <alp@atoker.com>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=16356
[GTK] Integrate GStreamer video with the graphics backend
Integrate the GStreamer media backend with the Cairo graphics backend.
There are still some issues: Data is copied more often than necessary,
and repaint() is not called, causing transformed video not to update
sometimes.
- WebCore.pro:
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::currentTime): (WebCore::MediaPlayerPrivate::setEndTime): (WebCore::MediaPlayerPrivate::seeking): (WebCore::MediaPlayerPrivate::naturalSize): (WebCore::MediaPlayerPrivate::setMuted): (WebCore::MediaPlayerPrivate::setRect): (WebCore::MediaPlayerPrivate::setVisible): (WebCore::MediaPlayerPrivate::repaint): (WebCore::MediaPlayerPrivate::paint): (WebCore::MediaPlayerPrivate::createGSTPlayBin):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- platform/graphics/gtk/VideoSinkGStreamer.cpp: Added. (webkit_video_sink_base_init): (webkit_video_sink_init): (webkit_video_sink_idle_func): (webkit_video_sink_render): (webkit_video_sink_set_caps): (webkit_video_sink_dispose): (webkit_video_sink_finalize): (webkit_video_sink_set_property): (webkit_video_sink_get_property): (webkit_video_sink_stop): (webkit_video_sink_class_init): (webkit_video_sink_new): (webkit_video_sink_set_surface): (plugin_init):
- platform/graphics/gtk/VideoSinkGStreamer.h: Added.
- 6:09 PM Changeset in webkit [28791] by
-
- 2 edits in trunk/WebCore
2007-12-16 Mark Rowe <mrowe@apple.com>
Mac build fix.
- WebCore.xcodeproj/project.pbxproj: Remove NetscapePlugInStreamLoader.cpp from the WebCore target. Mac currently has its own implementation in NetscapePlugInStreamLoaderMac.mm which conflicts with the new shared implementation.
- 5:50 PM Changeset in webkit [28790] by
-
- 3 edits1 delete in trunk/WebCore
2007-12-16 Rodney Dawes <dobey@wayofthemonkey.com>
Reviewed by Maciej Stachowiak.
http://bugs.webkit.org/show_bug.cgi?id=16389
Bug 16389: Common Implementation of NetscapePlugInStreamLoader
- WebCore.vcproj/WebCore.vcproj: Remove NetscapePlugInStreamLoaderWin.cpp.
- loader/NetscapePlugInStreamLoader.cpp: Copy method implementations from NetscapePlugInStreamLoaderWin.cpp.
- loader/win/NetscapePlugInStreamLoaderWin.cpp: Removed.
- 5:35 PM Changeset in webkit [28789] by
-
- 2 edits in trunk/WebKitTools
2007-12-16 Dimitri Glazkov <dimitri@glazkov.com>
Reviewed by Adam Roben.
Remove the double-quotes around the PATH variable value, in order to make it work in Windows shell.
- FindSafari/FindSafari.cpp: (_tmain):
- 5:33 PM Changeset in webkit [28788] by
-
- 2 edits in trunk/WebKitTools
2007-12-16 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=16315
FindSafari needs a path-only option.
- FindSafari/FindSafari.cpp: (_tmain):
- 5:31 PM Changeset in webkit [28787] by
-
- 2 edits in trunk/LayoutTests
- fast/js/regexp-overflow-expected.txt: Updated. I accidentally checked in an out-of-date file last time.
- 5:28 PM Changeset in webkit [28786] by
-
- 1 edit in trunk/WebCore/ChangeLog
Reviewed by Darin Adler.
Fix http://bugs.webkit.org/show_bug.cgi?id=16433.
Bug 16433: LOW_BANDWIDTH_DISPLAY build is broken
- dom/Document.cpp: (WebCore::Document::Document):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::addLowBandwidthDisplayRequest): (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
- 5:26 PM Changeset in webkit [28785] by
-
- 5 edits in trunk
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=16459 REGRESSION: assertion failure with regexp with \B in a case-ignoring character range <rdar://problem/5646361>
The problem was that \B was not handled properly in character classes.
Test: fast/js/regexp-overflow.html
- pcre/pcre_compile.cpp: (check_escape): Added handling of ESC_b and ESC_B in character classes here. Allows us to get rid of the handling of \b in character classes from all the call sites that handle it separately and to handle \B properly as well. (compileBranch): Remove the ESC_b handling, since it's not needed any more. (calculateCompiledPatternLengthAndFlags): Ditto.
LayoutTests:
Reviewed by Maciej.
- test for http://bugs.webkit.org/show_bug.cgi?id=16459 REGRESSION: assertion failure with regexp with \B in a case-ignoring character range <rdar://problem/5646361>
- fast/js/regexp-overflow-expected.txt: Updated.
- fast/js/resources/regexp-overflow.js: Added test cases.
- 5:26 PM Changeset in webkit [28784] by
-
- 3 edits in trunk/WebCore
2007-12-16 Grace Kloba <klobag@gmail.com>
Reviewed by Darin Adler.
Fix http://bugs.webkit.org/show_bug.cgi?id=16433.
Bug 16433: LOW_BANDWIDTH_DISPLAY build is broken
- dom/Document.cpp: (WebCore::Document::Document):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::addLowBandwidthDisplayRequest): (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
- 5:20 PM Changeset in webkit [28783] by
-
- 2 edits2 adds in trunk/WebKitSite
2007-12-16 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Maciej Stachowiak.
- building/debug.html: Update to expand the win32 debugging instructions.
- 5:14 PM Changeset in webkit [28782] by
-
- 2 edits in trunk/JavaScriptCore
Fix http://bugs.webkit.org/show_bug.cgi?id=16448 ([GTK] Celtic Kane JavaScript performance on Array test is slow relative to Mac).
Reviewed by Maciej Stachowiak.
- kjs/array_instance.cpp:
(KJS::compareByStringPairForQSort):
(KJS::ArrayInstance::sort): Convert JSValue's to strings once up front and then sort the
results. This avoids calling toString twice per comparison, but requires a temporary buffer
so we only use this approach in cases where the array being sorted is not too large.
- 4:24 PM Changeset in webkit [28781] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Darin.
More of http://bugs.webkit.org/show_bug.cgi?id=16385
Cleanup kjs_window
- Move PausedTimeouts into its own file and put it in the WebCore namespace.
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/PausedTimeouts.cpp: Copied from bindings/js/kjs_window.cpp.
- bindings/js/PausedTimeouts.h: Copied from bindings/js/kjs_window.h.
- bindings/js/kjs_window.cpp: (KJS::Window::pauseTimeouts):
- bindings/js/kjs_window.h:
- history/CachedPage.cpp:
- history/CachedPage.h:
- page/Chrome.cpp:
LayoutTests:
Reviewed by Maciej.
- tests for the argument handling of the executeSql function
- storage/execute-sql-args-expected.txt: Added.
- storage/execute-sql-args.html: Added.
- 4:17 PM Changeset in webkit [28780] by
-
- 2 edits3 copies2 adds in trunk/LayoutTests
- try to get the system color test passing on the buildbot
I fear this test may be vulnerable to slight platform differences.
- platform/mac-tiger/fast: Added.
- platform/mac-tiger/fast/css: Added.
- platform/mac-tiger/fast/css/css2-system-color-expected.checksum: Copied from platform/mac/fast/css/css2-system-color-expected.checksum.
- platform/mac-tiger/fast/css/css2-system-color-expected.png: Copied from platform/mac/fast/css/css2-system-color-expected.png.
- platform/mac-tiger/fast/css/css2-system-color-expected.txt: Copied from platform/mac/fast/css/css2-system-color-expected.txt. Then updated to match what the buildbot says.
- platform/mac/fast/css/css2-system-color-expected.txt: Updated to match results I'm getting locally on my Leopard machine.
- 3:59 PM Changeset in webkit [28779] by
-
- 10 edits2 copies in trunk/WebCore
Reviewed by Darin.
More of http://bugs.webkit.org/show_bug.cgi?id=16385
Cleanup kjs_window
- Move PausedTimeouts into its own file and put it in the WebCore namespace.
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/PausedTimeouts.cpp: Copied from bindings/js/kjs_window.cpp.
- bindings/js/PausedTimeouts.h: Copied from bindings/js/kjs_window.h.
- bindings/js/kjs_window.cpp: (KJS::Window::pauseTimeouts):
- bindings/js/kjs_window.h:
- history/CachedPage.cpp:
- history/CachedPage.h:
- page/Chrome.cpp:
- 3:08 PM Changeset in webkit [28778] by
-
- 4 edits10 adds in trunk
WebCore:
Reviewed by Geoff.
Make relative-size SVGs work in border-image.
- rendering/RenderBox.cpp: (WebCore::RenderBox::calculateBackgroundSize):
- rendering/RenderObject.cpp: (WebCore::RenderObject::paintBorderImage):
LayoutTests:
Reviewed by Geoff.
Tests for SVG as border-image.
- fast/borders/resources/green-fixed-size-rect.svg: Added.
- fast/borders/resources/green-relative-size-rect.svg: Added.
- fast/borders/svg-as-border-image-2.html: Added.
- fast/borders/svg-as-border-image.html: Added.
- platform/mac/fast/borders/svg-as-border-image-2-expected.checksum: Added.
- platform/mac/fast/borders/svg-as-border-image-2-expected.png: Added.
- platform/mac/fast/borders/svg-as-border-image-2-expected.txt: Added.
- platform/mac/fast/borders/svg-as-border-image-expected.checksum: Added.
- platform/mac/fast/borders/svg-as-border-image-expected.png: Added.
- platform/mac/fast/borders/svg-as-border-image-expected.txt: Added.
- 2:53 PM Changeset in webkit [28777] by
-
- 6 edits1 copy in trunk/JavaScriptCore
Reviewed by Darin Adler and Maciej Stachowiak.
More refactoring to support global variable optimization.
Changed SymbolTable to use RefPtr<UString::Rep> as its key instead of
UString::Rep*. With globals, the symbol table can outlast the
declaration node for any given symbol, so the symbol table needs to ref
its symbol names.
In support, specialized HashMaps with RefPtr keys to allow lookup
via raw pointer, avoiding refcount churn.
SunSpider reports a .6% speedup (prolly just noise).
- JavaScriptCore.vcproj/WTF/WTF.vcproj: Added new file: wtf/RefPtrHashMap.h
- JavaScriptCore.xcodeproj/project.pbxproj: ditto
- kjs/JSVariableObject.cpp: (KJS::JSVariableObject::getPropertyNames): Symbol table keys are RefPtrs now.
- kjs/SymbolTable.h: Modified key traits to match RefPtr. Added a static Rep* for null, which helps compute the deletedValue() trait.
- wtf/HashMap.h: #include the RefPtr specialization so everyone can use it.
- wtf/RefPtrHashMap.h: Copied from wtf/HashMap.h. Added overloaded versions of find(), contains(), get(), set(), add(), remove(), and take() that take raw pointers as keys.
- 12:43 PM QtWebKitTodo edited by
- (diff)
- 12:14 PM Changeset in webkit [28776] by
-
- 2 edits in trunk/WebCore
- fix Tiger build (my fault it was broken)
- rendering/RenderThemeMac.mm: Define NSUInteger if on Tiger.
- 11:26 AM Changeset in webkit [28775] by
-
- 10 edits4 adds in trunk
WebCore:
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=6129
Incomplete implementation of CSS 2.1 system colors
Test: fast/css/css2-system-color.html
Based on original patch by Rob Buis.
System colors are retrieved from NSColor as appropriate. If the color is a pattern color
(and therefore NSColor won't let us retrieve a color from it) we draw a 1x1 image of the
color and sample that to get a solid color.
- css/CSSStyleSelector.cpp: (WebCore::): (WebCore::colorForCSSValue):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::systemColor):
- rendering/RenderTheme.h:
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm: (WebCore::getSystemColor): (WebCore::RenderThemeMac::platformColorsDidChange): (WebCore::RenderThemeMac::systemColor):
LayoutTests:
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=6129
Incomplete implementation of CSS 2.1 system colors
Add layout test for this bug and update tests for new system-derived colors
- fast/css/css2-system-color.html: Added.
- platform/mac/fast/css/css2-system-color-expected.checksum: Added.
- platform/mac/fast/css/css2-system-color-expected.png: Added.
- platform/mac/fast/css/css2-system-color-expected.txt: Added.
- platform/mac/fast/css/css2-system-fonts-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug103533-expected.txt:
- 10:40 AM Changeset in webkit [28774] by
-
- 4 edits5 adds in trunk
WebCore:
Reviewed by Darin Adler.
- fix http://bugs.webkit.org/show_bug.cgi?id=16426 Divs with overflow:auto: scrollbars not correctly updated when contents change
Test: fast/overflow/scrollbar-position-update.html
- platform/mac/PlatformScrollBarMac.mm: (WebCore::PlatformScrollbar::updateThumbProportion): Update the NSScroller's value for the new proportions.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout): Removed unnecessary repaint(). Scrollbars repaint themselves as needed.
LayoutTests:
Reviewed by Darin Adler.
- test for http://bugs.webkit.org/show_bug.cgi?id=16426 Divs with overflow:auto: scrollbars not correctly updated when contents change
- fast/overflow/scrollbar-position-update.html: Added.
- platform/mac-leopard/fast/overflow: Added.
- platform/mac-leopard/fast/overflow/scrollbar-position-update-expected.checksum: Added.
- platform/mac-leopard/fast/overflow/scrollbar-position-update-expected.png: Added.
- platform/mac/fast/overflow/scrollbar-position-update-expected.txt: Added.
- 10:13 AM Changeset in webkit [28773] by
-
- 2 edits in trunk/WebKit/wx
- try to fix the build
- WebView.cpp: (wxWebView::OnKeyEvents): Add a WebCore prefix.
- 9:37 AM Changeset in webkit [28772] by
-
- 6 edits in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=14140
<rdar://problem/5270958> REGRESSION: Complex system KeyBindings don't work properly
WebCore:
- dom/KeyboardEvent.h: (WebCore::KeypressCommand::KeypressCommand): (WebCore::KeyboardEvent::keypressCommands): Change stored command class to preserve complete information about commands.
- editing/EditorCommand.cpp: (WebCore::CommandEntry::): Mark InsertText as a text insertion command, which it is. Previously, we couldn't do it because WebKit didn't really treat insertText: as a command.
- page/EventHandler.cpp: (WebCore::EventHandler::keyEvent): Copy commands saved while interpreting a keydown event into keypress, to avoid losing state when running interpretKeyEvents: again.
WebKit:
- WebView/WebHTMLView.mm: (-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]): Made command replaying work when handling keypress, too. (-[WebHTMLView doCommandBySelector:]): Adapted for the new way to store commands in events. (-[WebHTMLView insertText:]): Append a command, not replace the whole existing vector. Also, restore the state for additional commands to be saved correctly.
- 9:31 AM Changeset in webkit [28771] by
-
- 3 edits in trunk/JavaScriptCore
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16162
Problems with float parsing on Linux (locale-dependent parsing was used).
- kjs/dtoa.cpp: Removed USE_LOCALE to reduce future confusion.
- kjs/lexer.cpp: (KJS::Lexer::lex): Parse with kjs_strtod, not the system one.
- 9:23 AM QtWebKitTodo edited by
- (diff)
- 8:16 AM Changeset in webkit [28770] by
-
- 9 edits in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16462
REGRESSION: access keys broken on Windows
- 5:20 AM Changeset in webkit [28769] by
-
- 2 edits in trunk/WebCore
2007-12-16 Xan Lopez <xan@gnome.org>
Reviewed by Alexey Proskuryakov.
http://bugs.webkit.org/show_bug.cgi?id=16454
[GTK] Text input doesn't work consistently on PPC
- platform/gtk/KeyEventGtk.cpp: (WebCore::singleCharacterString):
UChar is 2 bytes (UTF-16), so transform accordingly from
gunichar (UCS-4). Fixes keyboard input on big endian systems.
Dec 15, 2007:
- 10:57 PM Changeset in webkit [28768] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Mark Rowe.
Fix urlSuitableForTestResult to correctly identify wstring::npos as
the case when wstring.find doesn't find anything.
- DumpRenderTree/win/DumpRenderTree.cpp: (urlSuitableForTestResult):
- 6:00 PM Changeset in webkit [28767] by
-
- 3 edits in trunk/WebCore
Reviewed by Mark Rowe.
- better build fix for the problem affecting GTK and some other platforms "this time for sure"
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSEventTargetBase.cpp: Move the include of the .lut.h file here.
- bindings/js/JSEventTargetBase.h: Instead of including the .lut.h file in the header, which won't work, declare the tables that are in the .lut.h file in the header.
- 5:54 PM Changeset in webkit [28766] by
-
- 3 edits in trunk/WebCore
Fixed the Wx port's FontPlatformData for use in HashTable.
- 5:33 PM Changeset in webkit [28765] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
- fix <rdar://problem/5636090> Text in Georgia, Armenian, Inuktitut, Cree, or Cherokee (KA, HY, IU, CR, CHR) draws as all missing glyphs
- platform/graphics/win/FontCacheWin.cpp: (WebCore::metaFileEnumProc): Added. Called during metafile record enumeration and extracts the font from the create font record. (WebCore::FontCache::getFontDataForCharacters): If font linking fails, let Uniscribe draw the characters and see what font it chooses.
- 5:31 PM Changeset in webkit [28764] by
-
- 2 edits in trunk/WebCore
- WebCore.pro: Roll my last change out. Was wrong and didn't fix the build.
- 5:30 PM Changeset in webkit [28763] by
-
- 285 edits1 move in trunk/LayoutTests
Disabled the smallFonts.svg test, which has been failing for weeks. I heard that Niko
is going to fix this soon. He should rename it back at that time.
Removed the svn:executable flag from many .svg, .png, and .css files that had it set
for no good reason.
- svg/batik/text/smallFonts.svg: Removed.
- svg/batik/text/smallFonts.svg-disabled: Copied from svg/batik/text/smallFonts.svg.
- 5:11 PM Changeset in webkit [28762] by
-
- 2 edits in trunk/WebCore
Another try at a GTK build fix.
- WebCore.pro: Add JSEventTargetBase.cpp to LUT_TABLE_FILES instead of LUT_FILES.
- 4:07 PM Changeset in webkit [28761] by
-
- 3 edits in trunk/WebCore
Force windows to regenerate COM DOM bindings.
- WebCore.vcproj/build-generated-files.sh: Add license.
- bindings/scripts/CodeGeneratorCOM.pm: Use shared WK_ucfirst.
- 3:32 PM Changeset in webkit [28760] by
-
- 3 edits in trunk/WebCore
Fix Windows and wx builds.
- WebCore.vcproj/WebCore.vcproj:
- WebCoreSources.bkl:
- 3:31 PM Changeset in webkit [28759] by
-
- 2 edits in trunk/WebCore
Gtk build fix. Add JSEventTargetBase.cpp to SOURCES.
- 3:24 PM Changeset in webkit [28758] by
-
- 2 edits in trunk/WebCore
Fix wx build.
- WebCoreSources.bkl:
- 3:23 PM Changeset in webkit [28757] by
-
- 2 edits in trunk/WebCore
Not reviewed. Build fix for Qt/Gtk.
- 2:48 PM Changeset in webkit [28756] by
-
- 10 edits2 adds in trunk/WebCore
Reviewed by Eric.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=16445 (Refactor EventTargetNode & JSEventTargetNode for an upcoming SVG patch)
Split up JSEventTargetNode in JSEventTargetNode & JSEventTargetBase - where most functionality has been moved down
in the base class. Applied the same refactorization to EventTargetNode.
This makes it possible for the upcoming patch implementing the EventTarget interface for SVGElementInstance
to share as much code as possible with the EventTargetNode classes.
- 12:03 PM Changeset in webkit [28755] by
-
- 6 edits5 adds in trunk
2007-12-15 Eric Seidel <eric@webkit.org>
Reviewed by Oliver.
Width of SVG elements not applied to container elements
http://bugs.webkit.org/show_bug.cgi?id=16305
Added calcPrefWidths for RenderSVGRoot (copied from RenderReplaced)
This is caused by poor factoring in the render tree. RenderContainer probably should be a template.
svg/css/css-box-min-width.html
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::calcPrefWidths): Added.
- rendering/RenderSVGRoot.h:
- css/SVGCSSStyleSelector::applySVGProperty: fixed ASSERT in debug builds
- 6:46 AM Changeset in webkit [28754] by
-
- 2 edits in trunk/WebCore
Fix comment after isSafeScript() was renamed to allowsAccessFrom().
- bindings/js/kjs_window.cpp: (KJS::createWindow):
- 6:13 AM Changeset in webkit [28753] by
-
- 2 edits in trunk/WebKitTools
2007-12-15 Alp Toker <alp@atoker.com>
GTK+ DRT build fix for GLib < 2.14.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::setWaitToDump):
- 5:40 AM Changeset in webkit [28752] by
-
- 2 edits in trunk/LayoutTests
2007-12-15 Alp Toker <alp@atoker.com>
http://bugs.webkit.org/show_bug.cgi?id=16449
cairo_arc() functions hang or crash when passed inf as radius or start/end angle
Fixed in r28751. Remove these tests from the skip list:
fast/canvas/arc-crash.html
fast/canvas/canvas-with-incorrect-args.html
- platform/gtk/Skipped:
- 5:12 AM Changeset in webkit [28751] by
-
- 2 edits in trunk/WebCore
2007-12-15 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=16449
cairo_arc() functions hang or crash when passed inf as radius or start/end angle
Add checks. This matches a similar workaround for a CG bug in the CG
graphics backend: <rdar://problem/5189233>
Fixes:
fast/canvas/arc-crash.html
fast/canvas/canvas-with-incorrect-args.html
- platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::addArc):
- 4:39 AM Changeset in webkit [28750] by
-
- 4 edits in trunk/WebKitTools
Add a watchdog timer to Gtk DumpRenderTree, and implement alert/prompt/confirm.
This prevents many layout tests from hanging while waiting on user responses to dialogs.
Reviewed by Alp Toker.
- 4:39 AM Changeset in webkit [28749] by
-
- 1 edit2 adds in trunk/LayoutTests
Add a skeleton Gtk skipped list containing only tests that hang run-webkit-tests.
- 3:00 AM Changeset in webkit [28748] by
-
- 6 edits in trunk/WebKitTools
Flesh out DumpRenderTree for Gtk. After these changes, the majority of the tests in fast/js pass.
Reviewed by Alp Toker.
- 1:30 AM Changeset in webkit [28747] by
-
- 1 edit in trunk/WebCore/ChangeLog
Correct a mistake in ChangeLog.
- 1:07 AM Changeset in webkit [28746] by
-
- 3 edits2 adds in trunk
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=16436
Alt+Space works incorrectly
Test: platform/win/fast/events/alt-space-scroll.html
- WebView.cpp: (WebView::keyDown): (WebView::keyPress): We do not handle WM_SYSCHAR events.
- 1:03 AM Changeset in webkit [28745] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16078
Google Maps zooming via the scroll wheel (almost) always zooms IN only.
- dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent): Ensure that delta is never rounded down to zero - we are getting values less than 1 from many mice on OS X, and Google Maps code assumes scrolling down if event.wheelDelta is zero.
Dec 14, 2007:
- 10:24 PM Changeset in webkit [28744] by
-
- 2 edits in trunk/JavaScriptCore
2007-12-14 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
Enable the AllInOneFile.cpp optimization for the GTK+ port.
- JavaScriptCore.pri:
- 8:35 PM Changeset in webkit [28743] by
-
- 2 edits in trunk/JavaScriptCore
Remove commented out fprintf's that were for debugging purposes only.
- 8:31 PM Changeset in webkit [28742] by
-
- 2 edits in trunk/JavaScriptCore
Don't use the MADV_DONTNEED code path for now as it has no effect on Mac OS X and is currently untested on other platforms.
Reviewed by Maciej Stachowiak.
- wtf/TCSystemAlloc.cpp:
(TCMalloc_SystemRelease): Return after releasing memory rather than potentially falling
through into another mechanism if multiple are supported.
- 8:21 PM Changeset in webkit [28741] by
-
- 2 edits in trunk/JavaScriptCore
2007-12-14 Alp Toker <alp@atoker.com>
Build fix for GTK+/Qt and ports that don't use AllInOneFile.cpp.
Include UnusedParam.h.
- 7:53 PM Changeset in webkit [28740] by
-
- 2 edits in trunk/JavaScriptCore
Fix build on windows
Reviewd by Stephanie
- wtf/FastMalloc.cpp:
(WTF::TCMalloc_PageHeap::IncrementalScavenge):
- 7:26 PM Changeset in webkit [28739] by
-
- 2 edits in trunk/WebCore
- Windows build fix
- WebCore.vcproj/WebCore.vcproj:
- 7:02 PM Changeset in webkit [28738] by
-
- 2 edits in trunk/WebKit/win
- yet another build fix
- DOMHTMLClasses.cpp: (DOMHTMLDocument::URL):
- 7:00 PM Changeset in webkit [28737] by
-
- 2 edits in trunk/WebKit/gtk
2007-12-14 Alp Toker <alp@atoker.com>
Fix inconsistent indentation in the license header. Maciej was right!
- WebCoreSupport/FrameLoaderClientGtk.cpp:
- 6:51 PM Changeset in webkit [28736] by
-
- 2 edits in trunk/WebCore
2007-12-14 Alp Toker <alp@atoker.com>
GTK+/Qt build fix. Track added files in r28722.
- WebCore.pro:
- 6:16 PM Changeset in webkit [28735] by
-
- 2 edits in trunk/WebKit/mac
<rdar://problem/5647272> Remove user agent string hack for flickr.com
Reviewed by Darin.
- WebView/WebView.mm: (-[WebView _userAgentForURL:]): Removed hack.
- 6:15 PM Changeset in webkit [28734] by
-
- 2 edits in trunk/WebKit/mac
<rdar://problem/5647261> Remove user agent string hack for yahoo.com
Reviewed by Darin.
- WebView/WebView.mm: (-[WebView _userAgentForURL:]): Removed hack.
- 6:09 PM Changeset in webkit [28733] by
-
- 2 edits in trunk/JavaScriptCore
- try again to fix the Windows build
- wtf/TCSystemAlloc.cpp: (TCMalloc_SystemRelease):
- 6:00 PM Changeset in webkit [28732] by
-
- 2 edits in trunk/JavaScriptCore
- try to fix the Windows build
- wtf/TCSystemAlloc.cpp: (TCMalloc_SystemRelease):
- 5:35 PM Changeset in webkit [28731] by
-
- 2 edits in trunk/WebKit/win
- build fix
- WebIconDatabase.h:
- 5:19 PM Changeset in webkit [28730] by
-
- 1 edit in trunk/WebCore/ChangeLog
Fix ChangeLog
- 5:17 PM Changeset in webkit [28729] by
-
- 2 edits in trunk/WebCore
Reviewed by Geoff.
Speed up getElementByClassName.
- This makes getElementByClassName take 33% faster on the stress test linked to at http://bugs.webkit.org/show_bug.cgi?id=15760.
- platform/text/StringImpl.cpp: (WebCore::StringImpl::foldCase): Optimize the case when all the characters are ASCII.
- 5:03 PM Changeset in webkit [28728] by
-
- 21 edits in trunk
2007-12-14 Alp Toker <alp@atoker.com>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=16432
[GTK] Update license headers
Consent has been given by the authors of these files to change license
to the LGPL as outlined in the bug report.
- 4:25 PM Changeset in webkit [28727] by
-
- 3 edits in trunk/JavaScriptCore
Add logic for TCMalloc to release memory to the system
Reviewed by Maciej and Oliver.
Add final changes to make TCMalloc release memory to the system.
This results in a 0.4% regression against ToT, but this is offset
against the gains made by the original TCMalloc r38 merge - in fact
we retain around 0.3-0.4% progression overall.
- 3:42 PM Changeset in webkit [28726] by
-
- 3 edits in trunk/WebCore
Reviewed by Adele.
- fix http://bugs.webkit.org/show_bug.cgi?id=16442 navigation policy delegate gets called twice for each load
- loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::willSendRequest): Removed call to checkNavigationPolicy. That's handled by FrameLoader.
- loader/MainResourceLoader.h: Removed callContinueAfterNavigationPolicy and continueAfterNavigationPolicy.
- 3:41 PM Changeset in webkit [28725] by
-
- 3 edits in trunk/WebKit/win
Reviewed by Adele.
- http://bugs.webkit.org/show_bug.cgi?id=16443 implement some missing Windows WebKit functions
- DOMHTMLClasses.cpp: (DOMHTMLDocument::URL): Implemented.
- WebActionPropertyBag.cpp: (WebActionPropertyBag::Read): Fixed the WebActionElementKey case.
- 3:06 PM Changeset in webkit [28724] by
-
- 1 edit1 move in trunk/LayoutTests
- share the results of this test between Tiger and Leopard
- platform/mac-leopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Removed.
- platform/mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt.
- 2:06 PM Changeset in webkit [28723] by
-
- 6 edits3 adds in trunk
WebCore:
Reviewed by Brady.
Make document.open count as committing a document load, so that -[WebFrame dataSource:] won't
return nil in that case.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::didExplicitOpen):
WebKitTools:
Reviewed by Brady.
Assert that a web frame that's loading a resource always has either a data source or
a provisional data source.
- DumpRenderTree/mac/ResourceLoadDelegate.mm: (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
LayoutTests:
Reviewed by Brady.
Add test that calls window.open and then immediately writes into the document
of the newly opened window.
- http/tests/misc/resources/compass.jpg: Added.
- http/tests/misc/window-open-then-write-expected.txt: Added.
- http/tests/misc/window-open-then-write.html: Added.
- platform/win/Skipped:
- 1:48 PM Changeset in webkit [28722] by
-
- 17 edits1 move45 adds in trunk
WebCore:
Reviewed by Mitz.
- fix http://bugs.webkit.org/show_bug.cgi?id=14955 Implement getElementsByClassName.
This patch also renames AtomicStringList to ClassNames to better reflect its actual use,
and takes advantage of admitting that it's class-specific to encapsulate class attribute
parsing so it can be shared. It also changes the class to use a Vector, rather than a linked
list to store the class names.
Tests: fast/dom/getElementsByClassName/001.html
fast/dom/getElementsByClassName/002.html
fast/dom/getElementsByClassName/003.html
fast/dom/getElementsByClassName/004.html
fast/dom/getElementsByClassName/005.html
fast/dom/getElementsByClassName/006.html
fast/dom/getElementsByClassName/007.html
fast/dom/getElementsByClassName/008.html
fast/dom/getElementsByClassName/009.html
fast/dom/getElementsByClassName/010.xml
fast/dom/getElementsByClassName/011.xml
fast/dom/getElementsByClassName/012.html
fast/dom/getElementsByClassName/013.html
fast/dom/getElementsByClassName/014.html
fast/dom/getElementsByClassName/array/001.html
fast/dom/getElementsByClassName/array/002.html
fast/dom/getElementsByClassName/array/003.html
fast/dom/getElementsByClassName/array/004.html
fast/dom/getElementsByClassName/dumpNodeList.html
- WebCore.xcodeproj/project.pbxproj:
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::matchRules): (WebCore::CSSStyleSelector::checkOneSelector):
- dom/AtomicStringList.h: Removed.
- dom/ClassNames.cpp: Added. (WebCore::ClassNames::contains): (WebCore::ClassNames::parseClassAttribute):
- dom/ClassNames.h: Copied from WebCore/dom/AtomicStringList.h. (WebCore::ClassNames::ClassNames): (WebCore::ClassNames::size): (WebCore::ClassNames::clear): (WebCore::ClassNames::operator[]): (WebCore::isClassWhitespace):
- dom/ClassNodeList.cpp: Added. (WebCore::ClassNodeList::ClassNodeList): (WebCore::ClassNodeList::length): (WebCore::ClassNodeList::item): (WebCore::ClassNodeList::nodeMatches):
- dom/ClassNodeList.h: Added.
- dom/Document.cpp: (WebCore::Document::getElementsByName): (WebCore::Document::getElementsByClassName):
- dom/Document.h:
- dom/Document.idl:
- dom/Element.cpp: (WebCore::Element::getClassNames): (WebCore::Element::getElementsByClassName):
- dom/Element.h:
- dom/Element.idl:
- dom/NameNodeList.cpp: (WebCore::NameNodeList::NameNodeList): (WebCore::NameNodeList::item): (WebCore::NameNodeList::nodeMatches):
- dom/NameNodeList.h:
- dom/NamedMappedAttrMap.cpp: (WebCore::NamedMappedAttrMap::clearAttributes): (WebCore::NamedMappedAttrMap::parseClassAttribute):
- dom/NamedMappedAttrMap.h: (WebCore::NamedMappedAttrMap::getClassNames):
- dom/StyledElement.cpp: (WebCore::StyledElement::getClassNames):
- dom/StyledElement.h:
LayoutTests:
Reviewed by Mitz.
- test for http://bugs.webkit.org/show_bug.cgi?id=14955 Implement getElementsByClassName
Tests added from http://tc.labs.opera.com/apis/getElementsByClassName/
- fast/dom/Window/window-properties-expected.txt:
- fast/dom/getElementsByClassName: Added.
- fast/dom/getElementsByClassName/001-expected.txt: Added.
- fast/dom/getElementsByClassName/001.html: Added.
- fast/dom/getElementsByClassName/002-expected.txt: Added.
- fast/dom/getElementsByClassName/002.html: Added.
- fast/dom/getElementsByClassName/003-expected.txt: Added.
- fast/dom/getElementsByClassName/003.html: Added.
- fast/dom/getElementsByClassName/004-expected.txt: Added.
- fast/dom/getElementsByClassName/004.html: Added.
- fast/dom/getElementsByClassName/005-expected.txt: Added.
- fast/dom/getElementsByClassName/005.html: Added.
- fast/dom/getElementsByClassName/006-expected.txt: Added.
- fast/dom/getElementsByClassName/006.html: Added.
- fast/dom/getElementsByClassName/007-expected.txt: Added.
- fast/dom/getElementsByClassName/007.html: Added.
- fast/dom/getElementsByClassName/008-expected.txt: Added.
- fast/dom/getElementsByClassName/008.html: Added.
- fast/dom/getElementsByClassName/009-expected.txt: Added.
- fast/dom/getElementsByClassName/009.html: Added.
- fast/dom/getElementsByClassName/010-expected.txt: Added.
- fast/dom/getElementsByClassName/010.xml: Added.
- fast/dom/getElementsByClassName/011-expected.txt: Added.
- fast/dom/getElementsByClassName/011.xml: Added.
- fast/dom/getElementsByClassName/012-expected.txt: Added.
- fast/dom/getElementsByClassName/012.html: Added.
- fast/dom/getElementsByClassName/013-expected.txt: Added.
- fast/dom/getElementsByClassName/013.html: Added.
- fast/dom/getElementsByClassName/014-expected.txt: Added.
- fast/dom/getElementsByClassName/014.html: Added.
- fast/dom/getElementsByClassName/array: Added.
- fast/dom/getElementsByClassName/array/001-expected.txt: Added.
- fast/dom/getElementsByClassName/array/001.html: Added.
- fast/dom/getElementsByClassName/array/002-expected.txt: Added.
- fast/dom/getElementsByClassName/array/002.html: Added.
- fast/dom/getElementsByClassName/array/003-expected.txt: Added.
- fast/dom/getElementsByClassName/array/003.html: Added.
- fast/dom/getElementsByClassName/array/004-expected.txt: Added.
- fast/dom/getElementsByClassName/array/004.html: Added.
- fast/dom/getElementsByClassName/dumpNodeList-expected.txt: Added.
- fast/dom/getElementsByClassName/dumpNodeList.html: Added.
- fast/dom/getElementsByClassName/resources: Added.
- fast/dom/getElementsByClassName/resources/common.js: Added.
- 12:50 PM Changeset in webkit [28721] by
-
- 6 edits in trunk
Reviewed by Sam.
- removed unnecessary includes of "Vector.h"
- wtf/HashMap.h: (WTF::copyKeysToVector): Make the type of the vector be a template parameter. This allows copying keys into a vector of a base class or one with an inline capacity. (WTF::copyValuesToVector): Ditto.
- wtf/HashSet.h: (WTF::copyToVector): Ditto.
WebCore:
Reviewed by Sam.
- fix http://bugs.webkit.org/show_bug.cgi?id=16351 FontFallbackList.h doesn't include wtf/PassRefPtr.h
- platform/graphics/FontFallbackList.h: Added include of <wtf/Forward.h>
- platform/graphics/GlyphPageTreeNode.h: Removed an unneeded include.
- 12:42 PM Changeset in webkit [28720] by
-
- 3 edits in trunk/WebKitTools
- fix mistake causing nearly all tests to fail on Windows
- DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::webViewAddMessageToConsole): Need to compare the result of find with npos, not 0. Also pass URL in to URL function rather than passing the entire message.
- DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:addMessageToConsole:]): Pass path only to path function rather than passing the entire message.
- 12:34 PM Changeset in webkit [28719] by
-
- 2 edits in trunk/WebKitTools
- fix Tiger build
- DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:addMessageToConsole:]): Re-implement this without using any new-to-Leopard methods.
- 12:25 PM Changeset in webkit [28718] by
-
- 4 edits in trunk
WebKit/mac:
Reviewed by Brady.
- fix http://bugs.webkit.org/show_bug.cgi?id=16296 <rdar://problem/5635641> -[WebFrameLoadDelegate didReceiveIcon:forFrame:] never called
- WebView/WebView.mm: (-[WebView setFrameLoadDelegate:]): Call [WebIconDatabase sharedIconDatabase] if the a didReceiveIcon method is present.
WebKitTools:
- DumpRenderTree/mac/FrameLoadDelegate.mm: Don't implement didReceiveIcon delegate method since it now triggers unwanted icon loading. We only had it because we implemented "all" delegate methods here.
- 12:03 PM Changeset in webkit [28717] by
-
- 38 edits in trunk
WebCore:
Reviewed by Alexey.
- http://bugs.webkit.org/show_bug.cgi?id=16420 change regression tests to use document.execCommand instead of textInputController.doCommand
Add a few more operations to document.execCommand.
Finished up the transition to the new Editor::Command, including removing
the Editor::execCommand function.
- WebCore.base.exp: Added Editor::Command::isSupported.
- editing/Editor.h: Removed execCommand.
- editing/EditorCommand.cpp: (WebCore::expandSelectionToGranularity): Added. (WebCore::verticalScrollDistance): Added; replaces canScroll. (WebCore::executeDeleteBackward): Added. Moved code here from WebHTMLView. (WebCore::executeDeleteBackwardByDecomposingPreviousCharacter): Ditto. (WebCore::executeDeleteForward): Ditto. (WebCore::executeDeleteToBeginningOfLine): Ditto. (WebCore::executeDeleteToBeginningOfParagraph): Ditto. (WebCore::executeDeleteToEndOfLine): Ditto. (WebCore::executeDeleteToEndOfParagraph): Ditto. (WebCore::executeMovePageDown): Renamed this command to be consistent with all the other Move commands. They all modify the caret. Reimplemented to match the Mac OS X version by removing the explicit scrolling, and letting it be done automatically by code that makes the caret visible. In some cases the old code would scroll twice which was harmless but unnecessary. (WebCore::executeMovePageDownAndModifySelection): Added. Moved code here from WebHTMLView. (WebCore::executeMovePageUp): See MovePageDown above. (WebCore::executeMovePageUpAndModifySelection): Added. Moved code here from WebHTMLView. (WebCore::executeSelectLine): Ditto. (WebCore::executeSelectParagraph): Ditto. (WebCore::executeSelectSentence): Ditto. (WebCore::executeSelectWord): Ditto. (WebCore::executeSwapWithMark): Some small tweaks.
- page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected): Changed to use Editor::command() instead of Editor::execCommand(). This code could be changed to use Editor::Command quite a bit more, but I didn't do that this time.
- Removed some obsolete unused code.
- page/mac/EventHandlerMac.mm: (WebCore::EventHandler::passMouseDownEventToWidget): Removed the special case code for NSTextView. This was left over from when we used NSTextField and NSTextView for form elements and is no longer used at all.
- page/mac/WebCoreFrameBridge.h: Removed 20 unused methods that were still on one side of the bridge or another. We really need to find a time to tear down the rest of the bridge, but that's not this patch.
- page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge addData:]): Changed to get at the _shouldCreateRenderers field directly instead of using a method. (-[WebCoreFrameBridge rangeByAlteringCurrentSelection:SelectionController::direction:SelectionController::granularity:]): Took out obsolete comment about matching enums (we use a single enum now and have for some time). (-[WebCoreFrameBridge selectionGranularity]): Ditto.
WebKit:
- StringsNotToBeLocalized.txt: Updated.
WebKit/gtk:
Reviewed by Alexey.
- WebCoreSupport/EditorClientGtk.cpp: (WebKit::EditorClient::handleKeyboardEvent): Changed to use Editor::command instead of Editor::execCommand.
- WebView/webkitwebview.cpp: Ditto.
WebKit/mac:
Reviewed by Alexey.
- Changed a few more editing operations to use WebCore instead of WebKit.
- Removed some obsolete unused code.
- WebCoreSupport/WebFrameBridge.h: Moved declarations of methods that are both defined and used on the WebKit side to here. These no longer belong on the bridge and should be moved to the WebFrame class (or elsewhere).
- WebCoreSupport/WebFrameBridge.mm: Removed some unused methods.
- WebView/WebFrameView.mm: (+[WebFrameView _viewTypesAllowImageTypeOmission:]): Fix typo in comment.
- WebView/WebHTMLView.mm: (-[WebHTMLViewPrivate dealloc]): Removed unused firstResponderTextViewAtMouseDownTime. (-[WebHTMLViewPrivate clear]): Ditto. (-[WebHTMLView _setMouseDownEvent:]): Ditto. (commandNameForSelector): Added special cases for pageDown:, pageDownAndModifySelection:, pageUp:, and pageUpAndModifySelection:, since those names probably aren't specific enough to be used in WebCore (what AppKit calls scrollPageDown: vs. pageDown: needs to be disambiguated with the word "Move"). Added deleteBackward:, deleteBackwardByDecomposingPreviousCharacter:, deleteForward:, deleteToBeginningOfLine:, deleteToBeginningOfParagraph:, deleteToEndOfLine:, deleteToEndOfParagraph:, pageDown:, pageDownAndModifySelection:, pageUp:, pageUpAndModifySelection:, selectLine:, selectParagraph:, selectSentence:, and selectWord: to the list of commands that are forwarded to WebCore. (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): Eliminated the long list of operations that we forward to WebCore. Instead, look up any command that WebCore can handle, after any that we handle specially in WebHTMLView. Also fixed a bug where an item that's not a menu item with changeBaseWritingDirection:NSWritingDirectionNatural would end up enabled instead of disabled and streamlined the logic for toggleGrammarChecking:. (-[WebHTMLView mouseDown:]): Removed unused firstResponderTextViewAtMouseDownTime. (-[WebHTMLView becomeFirstResponder]): Removed unused willBecomeFirstResponderForNodeFocus. (-[WebHTMLView resignFirstResponder]): Ditto. (-[WebHTMLView checkSpelling:]): Took unneeded extra initialization of NSSpellChecker.
- WebView/WebHTMLViewInternal.h: Removed unused willBecomeFirstResponderForNodeFocus, firstResponderTextViewAtMouseDownTime, _textViewWasFirstResponderAtMouseDownTime: and _willMakeFirstResponderForNodeFocus.
WebKit/qt:
Reviewed by Alexey.
- Api/qwebpage.cpp: (QWebPage::triggerAction): Removed some use of Editor member functions we plan to eventually eliminate. Switch from Editor::execCommand to Editor::command.
- WebCoreSupport/EditorClientQt.cpp: (WebCore::EditorClientQt::handleKeyboardEvent): Ditto. Also updated name from MoveUpByPageAndModifyCaret to MovePageUp and from MoveDownByPageAndModifyCaret to MovePageDown.
WebKit/win:
Reviewed by Alexey.
- WebView.cpp: (WebView::execCommand): Switched from Editor::execCommand to Editor:command. Updated name from MoveUpByPageAndModifyCaret to MovePageUp and from MoveDownByPageAndModifyCaret to MovePageDown. (WebView::copy): Switched from Editor::execCommand to Editor:command. (WebView::cut): Ditto. (WebView::paste): Ditto. (WebView::delete_): Ditto.
WebKit/wx:
Reviewed by Alexey.
- WebKitSupport/EditorClientWx.cpp: (WebCore::EditorClientWx::handleKeyboardEvent): Switched from Editor::execCommand to Edtor::command.
LayoutTests:
Reviewed by Alexey.
- http://bugs.webkit.org/show_bug.cgi?id=16420 change regression tests to use document.execCommand instead of textInputController.doCommand
To avoid changing results at this time, I didn't correct the many tests that now have
misleading "this test cannot be run manually" text or references to "NSResponder" or
uneeded instructions for running the test manually. We can do that on a later pass.
- editing/deleting/5300379.html: Use execCommand instead of doCommand.
- editing/deleting/delete-to-end-of-paragraph.html: Ditto.
- editing/deleting/smart-delete-003.html: Ditto.
- editing/deleting/smart-delete-004.html: Ditto.
- editing/execCommand/nsresponder-indent.html: Ditto.
- editing/execCommand/nsresponder-outdent.html: Ditto.
- editing/selection/4947387.html: Ditto.
- editing/selection/5195166-1.html: Ditto.
- editing/selection/5195166-2.html: Ditto.
- editing/selection/select-line.html: Ditto.
- editing/selection/selection-actions.html: Ditto.
- 11:55 AM Changeset in webkit [28716] by
-
- 8 edits6 adds in trunk
WebCore:
Reviewed by Darin Adler.
<rdar://problem/5575101> GoogleDocs: Hang in SplitElementCommand::doApply when outdenting a list item in a particular list
- editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::splitTreeToNode): Moved here.
- editing/CompositeEditCommand.h:
- editing/IndentOutdentCommand.cpp: Moved splitTreeToNode.
- editing/IndentOutdentCommand.h: Ditto, and removed unimplemented splitTreeTo.
- editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): Split ancestors of listChildNode between it and listNode, if they exists, so that moving listChildNode doesn't put it out of order. Added a test case to cover each change.
- editing/SplitElementCommand.cpp: (WebCore::SplitElementCommand::doApply): Added an ASSERT to catch code that tries to split a container at a bogus child, and an early return to avoid a hang in that case.
LayoutTests:
Reviewed by Darin Adler.
<rdar://problem/5575101> Hang in SplitElementCommand::doApply when outdenting a list item in a particular list
- editing/execCommand/5575101-1-expected.txt: Added.
- editing/execCommand/5575101-1.html: Added.
- editing/execCommand/5575101-2-expected.txt: Added.
- editing/execCommand/5575101-2.html: Added.
- editing/execCommand/5575101-3-expected.txt: Added.
- editing/execCommand/5575101-3.html: Added.
- 11:47 AM Changeset in webkit [28715] by
-
- 11 edits3 adds in trunk
Reviewed by Darin and Geoff.
<rdar://problem/5619295>
REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
Get rid of unnecessary and incorrect security checks for plug-ins accessing JavaScript objects.
The way this used to work was that each NPObject that wrapped a JSObject would have a root object
corresponding to the frame object (used for managing the lifecycle) and an origin root object (used for
doing security checks).
This would prevent a plug-in from accessing a frame's window object if it's security origin was different
(some parts of the window, such as the location object, can be accessed from frames with different security
origins, and those checks are being done in WebCore).
Also, if a plug-in were to access a window object of a frame that later went away, it could lead to that
Window JSObject being garbage collected and the NPObject pointing to freed memory.
How this works now is that there is no origin root object anymore, and all NPObject wrappers that are created
for a plug-in will have the root object of the containing frame of that plug-in.
- bindings/NP_jsobject.cpp: (jsDeallocate): Don't free the origin root object.
(_NPN_CreateScriptObject):
Remove the origin root object parameter.
(_NPN_InvokeDefault):
(_NPN_Invoke):
(_NPN_Evaluate):
(_NPN_GetProperty):
(_NPN_SetProperty):
(_NPN_RemoveProperty):
(_NPN_HasProperty):
(_NPN_HasMethod):
(_NPN_Enumerate):
Get rid of all security checks.
- bindings/NP_jsobject.h: Remove originRootObject from the JavaScriptObject struct.
- bindings/c/c_utility.cpp: (KJS::Bindings::convertValueToNPVariant): Always use the root object from the ExecState.
WebCore:
Reviewed by Darin and Geoff.
<rdar://problem/5619295>
REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
_NPN_CreateScriptObject doesn't take an origin root object anymore.
- html/HTMLPlugInElement.cpp: (WebCore::HTMLPlugInElement::createNPObject):
- page/Frame.cpp: (WebCore::Frame::windowScriptNPObject):
WebKitTools:
Reviewed by Darin and Geoff.
<rdar://problem/5619295>
REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
Add property getting methods to the plug-in.
- DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: (pluginInvoke):
LayoutTests:
Reviewed by Darin and Geoff.
<rdar://problem/5619295>
REGRESSION: 303-304: Embedded YouTube video fails to render- JS errors (16150) (Flash 9)
Add cross frame plug/in test where a plug/in inside an iframe tries to access properties of the
top-level frame.
- http/tests/plugins/cross-frame-object-access-expected.txt: Added.
- http/tests/plugins/cross-frame-object-access.html: Added.
- http/tests/plugins/resources/cross-frame-object-access.html: Added.
- 11:37 AM Changeset in webkit [28714] by
-
- 2 edits in trunk/WebCore
Reviewed by Darin Adler.
- fix <rdar://problem/5643663> text-shadow and box-shadow offsets 1px smaller than specified which is the root cause of: http://bugs.webkit.org/show_bug.cgi?id=12943 box-shadow: small values don't affect shadow position http://bugs.webkit.org/show_bug.cgi?id=14736 Safari implementation of text-shadow off by 1px
- platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setShadow): Slightly increase the magnitude of the offsets passed to CGContextSetShadow* to ensure that the end result after truncation is the desired integer offsets.
- 10:34 AM Changeset in webkit [28713] by
-
- 2 edits1 add in trunk/LayoutTests
Move layout test to mac skipped list until mac frt bug fixed.
Reviewed by Adam.
Fix test output, and move test to mac skipped list until
<rdar://problem/5647952> fast/events/mouseout-on-window.html
is fixed.
- 10:19 AM Changeset in webkit [28712] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Darin.
- Layout test fix for mac. When dumped to the console local file paths now only show the name of the resource not the whole path. This is to make the results machine and OS independent.
- DumpRenderTree/mac/UIDelegate.mm: (-[UIDelegate webView:addMessageToConsole:]):
Dec 13, 2007:
- 10:56 PM Changeset in webkit [28711] by
-
- 2 edits in trunk/WebCore
2007-12-13 Alp Toker <alp@atoker.com>
curl backend build fix for breakage introduced in r28709.
- platform/network/ResourceHandleInternal.h: (WebCore::ResourceHandleInternal::ResourceHandleInternal):
- 9:32 PM Changeset in webkit [28710] by
-
- 4 edits12 adds in trunk
WebCore:
Reviewed by Oliver Hunt.
<rdar://problem/5607069> In Mail, a crash occurs at WebCore::AppendNodeCommand() after dragging image into a <FORM> element
- editing/InsertLineBreakCommand.cpp: (WebCore::InsertLineBreakCommand::shouldUseBreakElement): Equip this function to handle editing positions, like [input, 0];
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply): Pass enclosingBlock a node peeled off of a non-editing position, to fix a bug where the enclosing block of [input, 0] was the input element itself. Insert a <br> when a <form> element is the enclosing block instead of splitting/cloning or nesting a <div>.
LayoutTests:
Reviewed by Oliver Hunt.
<rdar://problem/5607069> In Mail, a crash occurs at WebCore::AppendNodeCommand() after dragging image into a <FORM> element
- editing/inserting/5607069-1-expected.checksum: Added.
- editing/inserting/5607069-1-expected.png: Added.
- editing/inserting/5607069-1-expected.txt: Added.
- editing/inserting/5607069-1.html: Added.
- editing/inserting/5607069-2.html: Added.
- editing/inserting/5607069-3.html: Added.
- platform/mac/editing/inserting/5607069-2-expected.checksum: Added.
- platform/mac/editing/inserting/5607069-2-expected.png: Added.
- platform/mac/editing/inserting/5607069-2-expected.txt: Added.
- platform/mac/editing/inserting/5607069-3-expected.checksum: Added.
- platform/mac/editing/inserting/5607069-3-expected.png: Added.
- platform/mac/editing/inserting/5607069-3-expected.txt: Added.
- 7:37 PM Changeset in webkit [28709] by
-
- 2 edits in trunk/WebCore
2007-12-13 Alp Toker <alp@atoker.com>
Reviewed by Oliver Hunt.
http://bugs.webkit.org/show_bug.cgi?id=16365
[cURL] Acid2 test segmentation fault
This patch makes the Acid2 test pass.
Defer the cleanup of cancelled jobs and halt further transfer as early
as possible.
Bug found by and initial patch provided by Luca Bruno.
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::writeCallback): (WebCore::headerCallback): (WebCore::ResourceHandleManager::downloadTimerCallback): (WebCore::ResourceHandleManager::cancel):
- 7:32 PM Changeset in webkit [28708] by
-
- 4 edits in trunk/WebCore
Reviewed by Mark Rowe.
Fix typos and rename InspectorController::moveByUnrestricted to InspectorController::moveWindowBy.
- page/InspectorController.cpp: (WebCore::moveByUnrestricted): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::moveWindowBy):
- page/InspectorController.h:
- page/inspector/inspector.js:
- 7:20 PM UsingGitWithWebKit edited by
- (diff)
- 7:19 PM UsingGitWithWebKit edited by
- (diff)
- 7:16 PM UsingGitWithWebKit edited by
- (diff)
- 6:58 PM UsingGitWithWebKit edited by
- (diff)
- 6:40 PM UsingGitWithWebKit edited by
- (diff)
- 6:30 PM UsingGitWithWebKit edited by
- (diff)
- 6:25 PM Changeset in webkit [28707] by
-
- 7 edits2 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix <rdar://problem/5642426> explicit cubic-bezier curves all treated as "default" for transition-timing-function
Test: fast/css/transition-timing-function.html
- css/CSSStyleSelector.cpp: Changed the HANDLE_MULTILAYER_VALUE macro to not reject non-primitive non-list values, and instead made sure that the mapping functions rejected them if necessary. This allows non-primitive timing functions to be mapped. (WebCore::CSSStyleSelector::mapBackgroundAttachment): (WebCore::CSSStyleSelector::mapBackgroundClip): (WebCore::CSSStyleSelector::mapBackgroundComposite): (WebCore::CSSStyleSelector::mapBackgroundOrigin): (WebCore::CSSStyleSelector::mapBackgroundImage): (WebCore::CSSStyleSelector::mapBackgroundRepeat): (WebCore::CSSStyleSelector::mapBackgroundXPosition): (WebCore::CSSStyleSelector::mapBackgroundYPosition): (WebCore::CSSStyleSelector::mapTransitionDuration): (WebCore::CSSStyleSelector::mapTransitionRepeatCount): (WebCore::CSSStyleSelector::mapTransitionTimingFunction): (WebCore::CSSStyleSelector::mapTransitionProperty):
- css/CSSTimingFunctionValue.cpp: (WebCore::CSSTimingFunctionValue::cssText): Implemented for use in the regression test.
- css/CSSTimingFunctionValue.h: (WebCore::CSSTimingFunctionValue::isTransitionTimingFunctionValue): Added. Returns true.
- css/CSSValue.h: (WebCore::CSSValue::isTransitionTimingFunctionValue): Added. Returns false.
LayoutTests:
Reviewed by Dave Hyatt.
- test for <rdar://problem/5642426> explicit cubic-bezier curves all treated as "default" for transition-timing-function
- fast/css/transition-timing-function-expected.txt: Added.
- fast/css/transition-timing-function.html: Added.
- 6:14 PM Changeset in webkit [28706] by
-
- 5 edits in trunk/SunSpider
Reviewed by Oliver.
- Add some explanatory test and a dumb logo to SunSpider web hosted version
- hosted/sunspider-driver.html:
- hosted/sunspider-results.html:
- hosted/sunspider.css:
- hosted/sunspider.html:
- 6:07 PM Changeset in webkit [28705] by
-
- 12 edits2 adds5 deletes in trunk
WebKitTools:
Reviewed by Adam.
- Layout tests fix. We need a way to remove machine-dependent information from paths in layout test results. The UIDelegate now does this.
- DumpRenderTree/DumpRenderTree.h:
- DumpRenderTree/win/DumpRenderTree.cpp: (urlSuitableForTestResult):
- DumpRenderTree/win/DumpRenderTreeWin.h:
- DumpRenderTree/win/ResourceLoadDelegate.cpp:
- DumpRenderTree/win/UIDelegate.cpp: (UIDelegate::webViewAddMessageToConsole):
LayoutTests:
Reviewed by Adam.
- Layout tests fix. Removed machine dependant results and generated new results without machine specific information.
- fast/dom/frame-loading-via-document-write-expected.txt: Added.
- http/tests/security/frame-loading-via-document-write-expected.txt: Added.
- http/tests/security/local-CSS-from-remote-expected.txt:
- http/tests/security/local-JavaScript-from-remote-expected.txt:
- http/tests/security/local-iFrame-from-remote-expected.txt:
- http/tests/security/local-image-from-remote-expected.txt:
- platform/mac/fast/dom/frame-loading-via-document-write-expected.checksum: Removed.
- platform/mac/fast/dom/frame-loading-via-document-write-expected.png: Removed.
- platform/mac/fast/dom/frame-loading-via-document-write-expected.txt: Removed.
- platform/mac/http/tests/security: Removed.
- platform/mac/http/tests/security/frame-loading-via-document-write-expected.checksum: Removed.
- platform/mac/http/tests/security/frame-loading-via-document-write-expected.png: Removed.
- platform/mac/http/tests/security/frame-loading-via-document-write-expected.txt: Removed.
- platform/win/Skipped:
- platform/win/http: Removed.
- platform/win/http/tests: Removed.
- platform/win/http/tests/security: Removed.
- platform/win/http/tests/security/frame-loading-via-document-write-expected.txt: Removed.
- 5:23 PM Changeset in webkit [28704] by
-
- 10 edits2 adds in trunk
WebCore:
Move source file generation into its own vcproj to fix build dependencies.
Reviewed by Adam.
- WebCore.vcproj/WebCore.make:
- WebCore.vcproj/WebCore.sln:
- WebCore.vcproj/WebCore.submit.sln:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcproj/WebCoreGenerated.vcproj: Added.
WebKit/win:
Move source file generation into its own vcproj to fix build dependencies.
Reviewed by Adam.
- WebKit.vcproj/Interfaces.vcproj:
- WebKit.vcproj/InterfacesGenerated.vcproj: Added.
- WebKit.vcproj/WebKit.sln:
- WebKit.vcproj/WebKit.submit.sln:
- WebKit.vcproj/build-generated-files.sh:
- 5:22 PM Changeset in webkit [28703] by
-
- 1 edit in trunk/WebCore/editing/ApplyStyleCommand.cpp
Fix the build.
- 5:12 PM Changeset in webkit [28702] by
-
- 2 edits in trunk/WebCore
Reviewed by Oliver Hunt.
<rdar://problem/4145786> Undoing a color change of text in a compose window always changes it back to black
Some of the operations performed in removeHTMLFontStyle were non-undoable.
I'm having trouble writing a layout test for this because I can't get DRT to
perform editing operations in separate Undo steps without adding unacceptably long
wait times between operations. I filed:
<rdar://problem/5646779> Can't get DRT to perform editing operations in separate Undo steps
- editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::removeHTMLFontStyle):
- 5:10 PM Changeset in webkit [28701] by
-
- 4 edits in trunk/WebCore
Reviewed by Anders.
Fix for http://bugs.webkit.org/show_bug.cgi?id=16352
Toolbar dragged inspector cannot be moved beyond screen edges
- page/InspectorController.cpp: (WebCore::moveByUnrestricted): (WebCore::InspectorController::windowScriptObjectAvailable): (WebCore::InspectorController::moveByUnrestricted):
- page/InspectorController.h:
- page/inspector/inspector.js:
- 5:07 PM Changeset in webkit [28700] by
-
- 6 edits in trunk
Fix <rdar://5517707> Crash on wptv.wp.pl when "make bigger" button is clicked
WebCore:
Fix <rdar://5517707> Crash on wptv.wp.pl when "make bigger" button is clicked
Windows Media Player has a modal message loop that will deliver
messages to us at inappropriate times and we will crash if we handle
them when they are delivered. In PluginViewWin, we add a quirk for
Media Player to set a flag whenever we give the plugin a chance to
execute code, and in SharedTimerWin we check if the plugin is
executing code and repost messages if so.
Reviewed by Anders.
- platform/win/SharedTimerWin.cpp: (WebCore::TimerWindowWndProc): Repost messages if we're calling a plugin.
- plugins/win/PluginViewWin.cpp: Surround all calls to the plugin with setCallingPlugin(true/false). (WebCore::PluginViewWin::updateWindow): (WebCore::PluginViewWin::dispatchNPEvent): (WebCore::PluginViewWin::setNPWindowRect): (WebCore::PluginViewWin::start): (WebCore::PluginViewWin::stop): (WebCore::PluginViewWin::performRequest): (WebCore::PluginViewWin::bindingInstance): (WebCore::PluginViewWin::determineQuirks): (WebCore::PluginViewWin::setCallingPlugin): Added. (WebCore::PluginViewWin::isCallingPlugin): Added.
- plugins/win/PluginViewWin.h: Added a new quirk.
WebKit/win:
Fix <rdar://5517707> Crash on wptv.wp.pl when "make bigger" button is clicked
Reviewed by Anders.
- WebView.cpp: (WebViewWndProc): Repost paint messages and ignore all other messages when we're calling a plugin.
- 4:56 PM Changeset in webkit [28699] by
-
- 2 edits in trunk/WebKitTools
2007-12-13 Alp Toker <alp@atoker.com>
Build fix for DRT breakage introduced in r28690.
- DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::pathToLocalResource):
- 4:32 PM Changeset in webkit [28698] by
-
- 2 edits in trunk/WebCore
2007-12-13 Alp Toker <alp@atoker.com>
Add a missing DEPENDPATH. Fixes non-clean builds following networking
header changes.
- WebCore.pro:
- 3:48 PM Changeset in webkit [28697] by
-
- 6 edits2 adds in trunk
Move source file generation into its own vcproj to fix build dependencies.
Reviewed by Adam.
- JavaScriptCore.vcproj/JavaScriptCore.sln:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Added.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Added.
- JavaScriptCore.vcproj/JavaScriptCoreSubmit.sln:
WebKit/win:
Fix project dependencies based on JavaScriptCore change.
- WebKit.vcproj/WebKit.sln:
- 2:59 PM Changeset in webkit [28696] by
-
- 2 edits in trunk/WebCore
Reviewed by Anders Carlsson.
- fix regression in fast/text/international/bidi-override on Tiger
- platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage): Add bidi overrides here too. I forgot to add them when I added them to treatAsZeroWidthSpace in an earlier patch.
- 2:17 PM Changeset in webkit [28695] by
-
- 3 edits2 adds in trunk
Reviewed by Adele.
http://bugs.webkit.org/show_bug.cgi?id=16421
REGRESSION(r28669): Page scrolls down when you hit space key in text area
Test: fast/events/space-scroll-event.html
- WebView.cpp: (WebView::keyDown): (WebView::keyPress): Moved space handliing to keyPress() to fix this bug and to match IE. Scrolling via arrow keys is correctly handled in keyDown().
- 1:32 PM Changeset in webkit [28694] by
-
- 14 edits4 adds in trunk
WebCore:
Reviewed by Darin Adler.
<rdar://problem/5601583> GMail Editor: Copied link doesn't paste as a link, just colored text
The code that checks the selected Range to see if it's inside an anchor
checks ancestors of the Range's commonAncestor() but not the
commonAncestor() itself, and so we'd fail to add markup for the enclosing
anchor to the pasteboard.
Some enclosing element getters check the node passed to the getter and some
don't. There were a few places where we incorrectly assumed that enclosing
element getters check the node passed to the getter, but this is the only
case that I'm able to write a test case for at the moment.
In this patch I've:
Changed enclosingNodeWithType and enclosingNodeWithTag to take in positions,
like the newer enclosing element getters. This is important because we must
soon add code to the getters so that they understand that some editing positions
inside nodes don't actually refer to positions inside those nodes but positions
before and after them. Like [table, 0].
Changed enclosingNodeWithType and enclosingNodeWithTag to check nodes starting with
n where [n, o] is the position passed to the getter, instead of starting the the parent
of n. This makes all but a few of the enclosing element getters behave consistently.
Changed enclosingNodeWithType and enclosingNodeWithTag to not return non-editable
nodes if the input position was editable. This fixes a bug that that the above change
exposed.
Changed enclosingTableCell to simply call enclosingNodeWithType. We should do
this for the rest of the getters, or simply remove them in favor of enclosingNodeWithType
unless doing so would affect readability, like it would in the case of enclosingTableCell.
Ditto for enclosingBlock.
- editing/AppendNodeCommand.cpp: (WebCore::AppendNodeCommand::doApply):
- editing/DeleteButtonController.cpp: (WebCore::enclosingDeletableElement):
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::initializePositionData): (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor):
- editing/Editor.cpp: (WebCore::Editor::selectionUnorderedListState): (WebCore::Editor::selectionOrderedListState):
- editing/IndentOutdentCommand.cpp: (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): (WebCore::IndentOutdentCommand::outdentParagraph):
- editing/InsertNodeBeforeCommand.cpp: (WebCore::InsertNodeBeforeCommand::doApply):
- editing/InsertParagraphSeparatorCommand.cpp: (WebCore::InsertParagraphSeparatorCommand::doApply):
- editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::shouldMerge): (WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds): (WebCore::ReplaceSelectionCommand::positionAtEndOfInsertedContent):
- editing/TextIterator.cpp:
- editing/htmlediting.cpp: (WebCore::enclosingBlock): (WebCore::enclosingNodeWithTag): (WebCore::enclosingNodeOfType): (WebCore::enclosingTableCell): (WebCore::isTableCell):
- editing/htmlediting.h:
- editing/markup.cpp: (WebCore::appendStartMarkup): (WebCore::createMarkup):
LayoutTests:
Reviewed by Darin Adler.
<rdar://problem/5601583> GMail Editor: Copied link doesn't paste as a link, just colored text
- editing/pasteboard/5601583-1.html: Added.
- platform/mac/editing/pasteboard/5601583-1-expected.checksum: Added.
- platform/mac/editing/pasteboard/5601583-1-expected.png: Added.
- platform/mac/editing/pasteboard/5601583-1-expected.txt: Added.
- 12:40 PM Changeset in webkit [28693] by
-
- 13 edits in trunk
Reviewed by Darin.
Turn on keyboard event processing quirks for feed views and old applications on Mac OS X.
- 11:38 AM Changeset in webkit [28692] by
-
- 2 edits in trunk/JavaScriptCore
2007-12-13 Alp Toker <alp@atoker.com>
http://bugs.webkit.org/show_bug.cgi?id=16406
[Gtk] JavaScriptCore needs -lpthread
Build fix for Debian and any other platforms that don't implicitly
link to pthread.
Link to pthread on non-Windows platforms until this dependency is
removed from JSC.
- 11:36 AM Changeset in webkit [28691] by
-
- 2 edits in trunk/WebCore
- build fix
- platform/network/cf/ResourceErrorCF.cpp:
- 11:07 AM Changeset in webkit [28690] by
-
- 27 edits4 adds in trunk
WebKitTools:
Reviewed by Alice and Sam.
- <rdar://5621435> Need a way to specify local resources (being loaded from HTTP tests) on Windows.
- Implemented pathToLocalResource which exposes the functionality of converting a given unix path to the correct location on Windows.
- DumpRenderTree/LayoutTestController.cpp: (pathToLocalResourceCallback): (LayoutTestController::staticFunctions):
- DumpRenderTree/LayoutTestController.h:
- DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::pathToLocalResource):
- DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::pathToLocalResource):
LayoutTests:
Reviewed by Alice and Sam.
- <rdar://5621435> Need a way to specify local resources (being loaded from HTTP tests) on Windows.
- Updated the following tests to use the new layoutTestController function, pathToLocalResource to get a Windows viable path (when on Windows) to the local resources they are attempting to access.
- Also clarified and updated some results.
- fast/dom/frame-loading-via-document-write.html:
- fast/loader/local-CSS-from-local-expected.txt:
- fast/loader/local-CSS-from-local.html:
- fast/loader/local-JavaScript-from-local-expected.txt:
- fast/loader/local-JavaScript-from-local.html:
- fast/loader/local-iFrame-source-from-local-expected.txt:
- fast/loader/local-iFrame-source-from-local.html:
- fast/loader/local-image-from-local-expected.txt:
- fast/loader/local-image-from-local.html:
- http/tests/security/frame-loading-via-document-write.html:
- http/tests/security/local-CSS-from-remote-expected.txt:
- http/tests/security/local-CSS-from-remote.html:
- http/tests/security/local-JavaScript-from-remote-expected.txt:
- http/tests/security/local-JavaScript-from-remote.html:
- http/tests/security/local-iFrame-from-remote-expected.txt:
- http/tests/security/local-iFrame-from-remote.html:
- http/tests/security/local-image-from-remote-expected.txt:
- http/tests/security/local-image-from-remote.html:
- http/tests/security/local-user-CSS-from-remote.html:
- platform/mac/fast/dom/frame-loading-via-document-write-expected.txt:
- platform/win/Skipped:
- platform/win/http: Added.
- platform/win/http/tests: Added.
- platform/win/http/tests/security: Added.
- platform/win/http/tests/security/frame-loading-via-document-write-expected.txt: Added.
- 10:55 AM Changeset in webkit [28689] by
-
- 2 edits in trunk/WebCore
Reviewed by Tim Hatcher.
Fix <rdar://problem/5605674>
Make <video> display WebKit context menu instead of the QTKit one.
It doesn't really matter where the QTMovieView is.
- ChangeLog:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::createQTMovieView): (WebCore::MediaPlayerPrivate::setRect):
- 10:45 AM Changeset in webkit [28688] by
-
- 5 edits4 adds in trunk
WebCore:
Reviewed by Adam Roben.
- ensure that Unicode bidi control characters are rendered as zero width spaces
Test: fast/text/international/bidi-control-chars-treated-as-ZWS.html
- platform/graphics/Font.h: (WebCore::Font::treatAsZeroWidthSpace):
- platform/graphics/GlyphPageTreeNode.cpp: (WebCore::GlyphPageTreeNode::initializePage):
- platform/text/CharacterNames.h:
LayoutTests:
Reviewed by Adam Roben.
- test that Unicode bidi control characters are rendered as zero width spaces
- fast/text/international/bidi-control-chars-treated-as-ZWS.html: Added.
- platform/mac-leopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum: Added.
- platform/mac-leopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png: Added.
- platform/mac-leopard/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Added.
- 5:51 AM QtWebKitTodo edited by
- (diff)
- 5:50 AM QtWebKitTodo edited by
- (diff)
- 5:50 AM Changeset in webkit [28687] by
-
- 2 edits in tags/Safari-5523.15
Versioning.
- 5:50 AM Changeset in webkit [28686] by
-
- 3 edits in tags/Safari-5523.15/WebCore
Merge r28304.
- 5:49 AM Changeset in webkit [28685] by
-
- 2 edits in tags/Safari-5523.15/WebKit
Merge r28362.
- 5:48 AM Changeset in webkit [28684] by
-
- 2 edits in tags/Safari-5523.15/WebCore
Merge r27379.
- 5:47 AM Changeset in webkit [28683] by
-
- 2 edits in tags/Safari-5523.15/WebCore
Merge r28066.
- 5:46 AM Changeset in webkit [28682] by
-
- 2 edits in tags/Safari-5523.15/WebCore
Merge r28064.
- 5:45 AM Changeset in webkit [28681] by
-
- 4 edits in tags/Safari-5523.15/WebKit
Merge r28081.
- 5:44 AM Changeset in webkit [28680] by
-
- 3 edits2 adds in tags/Safari-5523.15
Merge r27796.
- 4:09 AM Changeset in webkit [28679] by
-
- 1 copy in tags/Safari-5523.15
New tag.
- 1:50 AM Changeset in webkit [28678] by
-
- 5 edits1 add in trunk/SunSpider
Reviewed by Oliver.
- Make the web-hosted version of SunSpider look a little bit less drab.
- hosted/sunspider-driver.html:
- hosted/sunspider-results.html:
- hosted/sunspider.css: Added.
- hosted/sunspider.html:
- resources/TEMPLATE.html:
- 1:18 AM Changeset in webkit [28677] by
-
- 1 copy in tags/Safari-525.3b
New tag.
- 12:24 AM Changeset in webkit [28676] by
-
- 2 edits in trunk/WebCore
Build fix
- platform/wx/TemporaryLinkStubs.cpp:
Dec 12, 2007:
- 11:55 PM Changeset in webkit [28675] by
-
- 2 edits in trunk/WebCore
Build fix
- platform/gtk/TemporaryLinkStubs.cpp:
- 11:51 PM Changeset in webkit [28674] by
-
- 2 edits1 delete in trunk/WebCore
Build fix
- WebCore.pro:
- history/qt/CachedPageQt.cpp: Removed. Whole purpose for this method being platform-specific has been removed
- 11:28 PM Changeset in webkit [28673] by
-
- 2 edits in trunk/WebCore
Build fix
- platform/win/TemporaryLinkStubs.cpp:
- 11:17 PM Changeset in webkit [28672] by
-
- 27 edits3 adds1 delete in trunk
WebCore:
Reviewed by Sam Weinig
Fix for <rdar://problem/4886844> and lay groundwork for <rdar://problem/4516170> (Back/Forward Cache on Windows)
All back/forward list and page cache related items used to be in WebKit.
When they were pushed into WebCore, some sloppy compromises were made to keep the Back/Forward cache working on Mac.
Namely, a WebCore::HistoryItem had to know how to keep a WebDocumentView alive. We accomplished this via some #ifdefs
in CachedPage and having the Mac-only CachedPageMac.mm
To get rid of that nastiness and pave the way for adding Back/Forward cache on other platforms, this patch adds the
concept of "CachedPagePlatformData" which can contain anything the platform API wants.
I also took the opportunity to do other cleanup and renaming client methods to better fit their new purposes.
- WebCore.base.exp:
- WebCore.xcodeproj/project.pbxproj:
- history/CachedPage.cpp: (WebCore::CachedPage::~CachedPage): Combined "close()" and "clear()" to just "clear()" - call it from here. (WebCore::CachedPage::clear): Call clear() on the CachedPagePlatformData if it exists. Also delete the CachedPagePlatformData. (WebCore::CachedPage::setCachedPagePlatformData): (WebCore::CachedPage::cachedPagePlatformData):
- history/CachedPage.h:
- history/CachedPagePlatformData.h: Added. (WebCore::CachedPagePlatformData::~CachedPagePlatformData): Virtual d'tor. (WebCore::CachedPagePlatformData::clear): Virtual method for platforms that need to do cleanup at the same time as CachedPage::clear().
- history/PageCache.cpp: (WebCore::PageCache::releaseAutoreleasedPagesNow): Call "clear()" instead of "close()"
- history/mac/CachedPageMac.mm: Removed. Functionality replaced with CachedPagePlatformData.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::transitionToCommitted): Call the new client methods. Make some work previously done by WebKitMac cross platform (setting the cached DocumentLoader to the Frame). (WebCore::FrameLoader::cachePageForHistoryItem): Renamed the client methods
- loader/FrameLoaderClient.h: The very Mac-centric "makeDocumentView", "setDocumentViewFromCachedPage", and "saveDocumentViewToCachedPage" become "transitionToCommittedForNewPage", "transitionToCommittedFromCachedPage", and "savePlatformDataToCachedPage" accordingly
- svg/graphics/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::savePlatformDataToCachedPage): (WebCore::SVGEmptyFrameLoaderClient::transitionToCommittedFromCachedPage): (WebCore::SVGEmptyFrameLoaderClient::transitionToCommittedForNewPage):
WebKit:
Reviewed by Sam Weinig
Fix for <rdar://problem/4886844> and lay groundwork for <rdar://problem/4516170> (Back/Forward Cache on Windows)
- WebKit.xcodeproj/project.pbxproj: Added a new file
WebKit/gtk:
Reviewed by Sam Weinig
As part of doing some CachedPage and client cleanup, keep GTK building
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::savePlatformDataToCachedPage): (WebKit::FrameLoaderClient::transitionToCommittedFromCachedPage): (WebKit::FrameLoaderClient::transitionToCommittedForNewPage):
- WebCoreSupport/FrameLoaderClientGtk.h:
WebKit/mac:
Reviewed by Sam Weinig
Fix for <rdar://problem/4886844> and lay groundwork for <rdar://problem/4516170> (Back/Forward Cache on Windows)
- WebCoreSupport/WebCachedPagePlatformData.h: Added. (WebCachedPagePlatformData::WebCachedPagePlatformData): Constructor takes a WebDocumentView for later restoration (WebCachedPagePlatformData::clear): (WebCachedPagePlatformData::webDocumentView):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::savePlatformDataToCachedPage): (WebFrameLoaderClient::transitionToCommittedFromCachedPage): Don't set the DocumentLoader to the Frame here, because that is now done in WebCore. (WebFrameLoaderClient::transitionToCommittedForNewPage):
WebKit/qt:
Reviewed by Sam Weinig
As part of doing some CachedPage and client cleanup, keep Qt building
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::savePlatformDataToCachedPage): (WebCore::FrameLoaderClientQt::transitionToCommittedFromCachedPage): (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
- WebCoreSupport/FrameLoaderClientQt.h:
WebKit/win:
Reviewed by Sam Weinig
Fix for <rdar://problem/4886844> and lay groundwork for <rdar://problem/4516170> (Back/Forward Cache on Windows)
Even though this new code isn't exercised yet because the page cache is still turned off for Windows, local testing
has indicated it works well.
- WebCachedPagePlatformData.h: Added. (WebCachedPagePlatformData::WebCachedPagePlatformData): Constructor takes an IWebDataSource and the object retains it (WebCachedPagePlatformData::clear): (WebCachedPagePlatformData::webDataSource):
- WebFrame.cpp: (WebFrame::savePlatformDataToCachedPage): (WebFrame::transitionToCommittedFromCachedPage): (WebFrame::transitionToCommittedForNewPage):
- WebFrame.h:
- WebKit.vcproj/WebKit.vcproj:
WebKit/wx:
Reviewed by Sam Weinig
As part of doing some CachedPage and client cleanup, keep Wx building
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::savePlatformDataToCachedPage): (WebCore::FrameLoaderClientWx::transitionToCommittedFromCachedPage): (WebCore::FrameLoaderClientWx::transitionToCommittedForNewPage):
- WebKitSupport/FrameLoaderClientWx.h:
- 11:04 PM Changeset in webkit [28671] by
-
- 5 edits2 moves in trunk
WebCore:
Reviewed by Oliver Hunt.
- fix <rdar://problem/5074620> text with font:initial; fails to appear (causes fast/text/font-initial.html to fail)
- css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): When the font property is set to 'initial', set the font size to its initial value, 'medium', and the font family to the standard family.
LayoutTests:
Reviewed by Oliver Hunt.
- updated results and skipped tests file for <rdar://problem/5074620> text with font:initial; fails to appear (causes fast/text/font-initial.html to fail)
- platform/mac-leopard/fast/text/font-initial-expected.checksum: Copied from LayoutTests/platform/mac/fast/text/font-initial-expected.checksum.
- platform/mac-leopard/fast/text/font-initial-expected.png: Copied from LayoutTests/platform/mac/fast/text/font-initial-expected.png.
- platform/mac/fast/text/font-initial-expected.checksum: Removed.
- platform/mac/fast/text/font-initial-expected.png: Removed.
- platform/mac/fast/text/font-initial-expected.txt:
- platform/win/Skipped:
- 10:56 PM Changeset in webkit [28670] by
-
- 3 edits6 adds in trunk
WebCore:
Reviewed by Darin Adler.
<rdar://problem/5433862> Mail crashes at WebCore::highestAncestor() when deleting a particular selection
- editing/DeleteSelectionCommand.cpp: (WebCore::DeleteSelectionCommand::removePreviouslySelectedEmptyTableRows): Don't remove the table row that contained the end of the selection if it is where we are about to place the ending selection. Don't remove all empty rows after the row that contained the start of the selection, they might come after the row that contained the end of the selection.
LayoutTests:
Reviewed by Darin Adler.
<rdar://problem/5433862> Mail crashes at WebCore::highestAncestor() when deleting a particular selection
- editing/deleting/5433862-1-expected.txt: Added.
- editing/deleting/5433862-1.html: Added.
- editing/deleting/5433862-2.html: Added.
- platform/mac/editing/deleting/5433862-2-expected.checksum: Added.
- platform/mac/editing/deleting/5433862-2-expected.txt: Added.
- 9:33 PM Changeset in webkit [28669] by
-
- 2 edits in trunk/SunSpider
Reviewed by Sam.
- Change sunspider-compare-results output from showing "% faster" values to "x as fast" values.
A sample of what new-style results would look like:
TEST COMPARISON FROM TO DETAILS
...
TOTAL : 1.41x as fast 6613.6ms +/- 0.1% 4703.0ms +/- 0.1% significant
...
3bit-bits-in-byte: *1.36x as slow* 88.8ms +/- 0.6% 121.1ms +/- 0.6% significant
- resources/sunspider-compare-results.js:
- 5:47 PM Changeset in webkit [28668] by
-
- 4 edits in trunk/WebCore
Reviewed by Anders Carlsson.
Add button to clear the Web Inspector's console.
- English.lproj/InspectorLocalizedStrings.js:
- page/inspector/ConsolePanel.js:
- page/inspector/inspector.css:
- 4:44 PM Changeset in webkit [28667] by
-
- 4 edits in trunk/WebCore
Reviewed by Adam and Jon.
<rdar://problem/5349282>
popup blocking is not applied to plugins on Windows.
Implement popup blocking. If the plug-in supports the new
NPN_PushPopupsEnabledState/NPN_PopPopupsEnabledState API we just use that
to determine if a plug-in request can open new windows.
If a plug-in does not support the new API, we assume that a plug-in can open new windows
in response to either mouse click or key press events.
- plugins/win/PluginViewWin.cpp: (WebCore::PluginRequestWin::PluginRequestWin): (WebCore::PluginRequestWin::shouldAllowPopups): Add new shouldAllowPopups member.
(WebCore::PluginViewWin::popPopupsStateTimerFired):
Reset the popup state.
(WebCore::isWindowsMessageUserGesture):
New function that given a windows message id returns whether it's a user gesture or not.
(WebCore::PluginViewWin::wndProc):
Allow popups if the window message is a user gesture.
(WebCore::PluginViewWin::dispatchNPEvent):
New method that dispatches an NPEvent, turning on popups if necessary.
(WebCore::PluginViewWin::paint):
(WebCore::PluginViewWin::handleKeyboardEvent):
(WebCore::PluginViewWin::handleMouseEvent):
Call dispatchNPEvent().
(WebCore::PluginViewWin::performRequest):
(WebCore::PluginViewWin::load):
Add calls to shouldAllowPopups().
(WebCore::PluginViewWin::pushPopupsEnabledState):
(WebCore::PluginViewWin::popPopupsEnabledState):
New methods that maintain the popup state stack.
(WebCore::PluginViewWin::arePopupsAllowed):
New method that returns whether popups are allowed.
(WebCore::PluginViewWin::PluginViewWin):
- plugins/win/PluginViewWin.h: Add new instance variables.
- plugins/win/npapi.cpp: (NPN_PushPopupsEnabledState): (NPN_PopPopupsEnabledState): Implement these.
- 4:23 PM Changeset in webkit [28666] by
-
- 4 edits2 adds in trunk
WebCore:
Reviewed by John Sullivan.
- fix a bug in debug builds only where selecting an earlier item in a popup selects the first item
Test: fast/forms/menulist-selection-reset.html
- html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::recalcListItems): Added an argument that tells that function whether it should update the selected state of option elements. (WebCore::HTMLSelectElement::checkListItems): Changed to pass false as the above argument.
- html/HTMLSelectElement.h:
LayoutTests:
Reviewed by John Sullivan.
- test for a bug in debug builds only where selecting an earlier item in a popup selects the first item
- fast/forms/menulist-selection-reset-expected.txt: Added.
- fast/forms/menulist-selection-reset.html: Added.
- 4:02 PM Changeset in webkit [28665] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
OOPS!
- 3:56 PM Changeset in webkit [28664] by
-
- 10 edits in trunk/WebCore
Reviewed by Geoff.
Fix for <rdar://problem/5643054> Remove cue point implementation for media elements
When the specification for cue ranges is more final, we will implement those.
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::~HTMLMediaElement): (WebCore::HTMLMediaElement::load):
- html/HTMLMediaElement.h:
- html/HTMLMediaElement.idl:
- platform/graphics/MediaPlayer.cpp:
- platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::mediaPlayerTimeChanged):
- platform/graphics/mac/MediaPlayerPrivateQTKit.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::load): (WebCore::MediaPlayerPrivate::play): (WebCore::MediaPlayerPrivate::pause): (WebCore::MediaPlayerPrivate::setEndTime): (WebCore::MediaPlayerPrivate::startEndPointTimerIfNeeded): (WebCore::MediaPlayerPrivate::endPointTimerFired): (WebCore::MediaPlayerPrivate::timeChanged): (WebCore::MediaPlayerPrivate::didEnd):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivate::MediaPlayerPrivate): (WebCore::MediaPlayerPrivate::startEndPointTimerIfNeeded): (WebCore::MediaPlayerPrivate::endPointTimerFired):
- platform/graphics/gtk/MediaPlayerPrivateGStreamer.h:
- 3:35 PM Changeset in webkit [28663] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Nico.
Updated pixel results from my recent SVG change.
- svg/custom/inline-svg-in-xhtml-expected.checksum: Added.
- svg/custom/inline-svg-in-xhtml-expected.png: Added.
- 2:37 PM Changeset in webkit [28662] by
-
- 2 edits in trunk/WebCore
2007-12-12 MorganL <morganl.webkit@yahoo.com> -- http://bugs.webkit.org/show_bug.cgi?id=16408
Reviewed by Maciej.
When navigating back/forward to a http:// link, we should prefer to
load from cache if possible.
- loader/FrameLoader.cpp:
- 2:15 PM Changeset in webkit [28661] by
-
- 8 edits2 adds in trunk
WebCore:
Reviewed by Sam.
<rdar://problem/5132003>
dumpResourceLoadCallbacks is not implemented in DRT on Windows.
- platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::unpackPlatformError): Handle kCFErrorDomainWinSock.
- platform/network/cf/ResourceHandleCFNet.cpp: (WebCore::willSendRequest): Ignore willSendRequest calls where the redirect response is null, like we do in the Mac version.
WebKitTools:
Reviewed by Sam.
<rdar://problem/5132003>
dumpResourceLoadCallbacks is not implemented in DRT on Windows.
- DumpRenderTree/win/DumpRenderTree.cpp: (main): Set the resource load delegate.
- DumpRenderTree/win/DumpRenderTree.vcproj:
- DumpRenderTree/win/ResourceLoadDelegate.cpp: Added.
- DumpRenderTree/win/ResourceLoadDelegate.h: Added.
LayoutTests:
Reviewed by Sam.
<rdar://problem/5132003>
dumpResourceLoadCallbacks is not implemented in DRT on Windows.
Remove now passing tests.
- platform/win/Skipped:
- 2:14 PM Changeset in webkit [28660] by
-
- 2 edits in trunk/WebCore
<rdar://problem/5643785> Fix iBench regression caused by mis-placed nested timer check.
Reviewed by Anders.
- platform/win/SharedTimerWin.cpp: (WebCore::TimerWindowWndProc): Don't set high-resolution timer flag inside non-high-resolution timer proc.
- 1:46 PM Changeset in webkit [28659] by
-
- 2 edits in trunk/WebKit/win
Build fix.
- WebKit.vcproj/WebKit.make: Copy only what we need out of obj/bin.
- 1:24 PM Changeset in webkit [28658] by
-
- 4 edits in trunk/WebCore
Reviewed by Oliver.
Fix for <rdar://problem/5643770> REGRESSION: Free-standing SVGs
with width and height 100% clip to 300 x 150
Though it was correct in an earlier iteration of my patch, it is
not sufficient in the final, committed version to ask if the
relativeWidthValue() or relativeHeightValue() is greater than 0
just to determine if one has been set, for, they are now
initialized to 300 and 150 respectively! This patch instead adds a
bool to keep track of whether a container size has been set, and
only used the relative value if it has.
- rendering/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::calcViewport):
- svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::SVGSVGElement):
- svg/SVGSVGElement.h: (WebCore::SVGSVGElement::setContainerSize): (WebCore::SVGSVGElement::hasSetContainerSize):
- 11:26 AM Changeset in webkit [28657] by
-
- 2 edits in trunk/WebCore
Reviewed by Steve Falkenburg
<rdar://problem/5012636> - WebURLProtectionSpace::realm returns the hostname rather than the authentication realm
- platform/network/ProtectionSpace.cpp: (WebCore::ProtectionSpace::ProtectionSpace): Assign the realm to m_realm, instead of the host
- 9:57 AM Changeset in webkit [28656] by
-
- 4 edits in trunk
Reviewed by Adam Roben.
Fix conversion from double to LPARAM in dispatchMessage().
- DumpRenderTree/win/EventSender.cpp: (dispatchMessageCallback):
- 9:34 AM Changeset in webkit [28655] by
-
- 2 edits in trunk/WebCore
2007-12-12 Alp Toker <alp@atoker.com>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=16388
[GTK] Widget::setCursor() gets called frequently
Cache the current cursor to avoid calling gdk_window_set_cursor() when
there's no change in cursor.
- platform/gtk/WidgetGtk.cpp: (WebCore::Widget::Widget): (WebCore::Widget::cursor): (WebCore::Widget::setCursor):
- 9:27 AM Changeset in webkit [28654] by
-
- 3 edits in trunk/WebCore
2007-12-12 Rodney Dawes <dobey@wayofthemonkey.com>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=16342
Build Warning and Error fixes in WebCore GTK+
Use C-style casts for casting function pointers to gpointer
Use static_cast<int> to cast a float to int to fix a warning
- platform/gtk/PlatformScrollBarGtk.cpp: (PlatformScrollbar::PlatformScrollbar): (PlatformScrollbar::~PlatformScrollbar): (PlatformScrollbar::gtkValueChanged):
- platform/gtk/ThreadingGtk.cpp: (callFunctionOnMainThread): (callOnMainThread):
- 8:59 AM Changeset in webkit [28653] by
-
- 4 edits in trunk
WebCore:
Reviewed by Darin Adler.
- better fix for a crash when pressing a key that is not associated with a command
- editing/EditorCommand.cpp: (WebCore::Editor::command): Return the empty command if the command name is empty.
WebKit/win:
Reviewed by Darin Adler.
- revert my earlier crash fix after making WebCore return the empty editor command for the empty command name.
- WebView.cpp: (WebView::handleEditingKeyboardEvent):
- 8:57 AM Changeset in webkit [28652] by
-
- 3 edits2 adds in trunk
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=16410
Implement isKeypadEvent() on Windows
Test: platform/win/fast/events/keyLocation-numpad.html
- platform/win/KeyEventWin.cpp: (WebCore::isKeypadEvent): Added. (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Also fixed a mistake with autorepeat.
- 8:27 AM Changeset in webkit [28651] by
-
- 2 edits in trunk
2007-12-12 Alp Toker <alp@atoker.com>
Reviewed by Mark Rowe.
http://bugs.webkit.org/show_bug.cgi?id=16302
[GTK] Compiler flags for optimization
Use the compiler flags -fno-exceptions -fno-rtti.
This patch does not add all the flags discussed in the bug report,
only these two.
- WebKit.pri:
- 8:25 AM Changeset in webkit [28650] by
-
- 1 edit in trunk/LayoutTests/platform/win/fast/events/alt-numpad.html
Remove an incorrect svn:executable property.
- 8:24 AM Changeset in webkit [28649] by
-
- 4 edits in trunk/WebKit
Remove abuse of projectDirPath from WebKit.xcodeproj to fix Production builds.
Reviewed by Dave Kilzer.
- 8:14 AM Changeset in webkit [28648] by
-
- 4 edits in trunk/WebKit/gtk
2007-12-12 Alp Toker <alp@atoker.com>
Reviewed by Holger Freyther.
http://bugs.webkit.org/show_bug.cgi?id=15576
[GTK] Printing support
Add printing support.
The API will be kept internal for the time being, but printing can now
be triggered by Web pages or the JSC API using JavaScript.
The print spooler and pagination code is fairly abstract and could be
shared by other ports including Win and Qt once complete. It doesn't
have header/footer support yet.
- WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::print):
- WebView/webkitprivate.h:
- WebView/webkitwebframe.cpp: (PrintContext::begin_print): (PrintContext::draw_page): (PrintContext::end_print): (PrintContext::webkit_web_frame_print):
- 3:33 AM Changeset in webkit [28647] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Oliver.
http://bugs.webkit.org/show_bug.cgi?id=15248
Can not enter accented characters using alt-numeric keypad
- platform/win/fast/events/alt-numpad-expected.txt: Added.
- platform/win/fast/events/alt-numpad.html: Added.
- 2:57 AM Changeset in webkit [28646] by
-
- 6 edits2 adds in trunk
<rdar://problem/5071781> window.mouseout events are not sent to window when mouse moves out of window
Reviewed by Maciej.
Hook up the windows mouse tracking logic to allow us to detect the mouse leaving the window.
- 12:41 AM Changeset in webkit [28645] by
-
- 4 edits in trunk/WebKit
WebKit/gtk:
Build fix.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::didChangeTitle):
WebKit/qt:
Build fix.
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::userAgent):
- 12:40 AM Changeset in webkit [28644] by
-
- 2 edits in trunk/WebCore
Fix Mac release build.
- WebCore.base.exp:
- 12:13 AM Changeset in webkit [28643] by
-
- 17 edits in trunk
WebCore:
Build fix for Qt, Gtk, and Wx.
- css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
- loader/win/FrameLoaderWin.cpp: (WebCore::FrameLoader::urlSelected):
- platform/network/curl/ResourceHandleManager.cpp: (WebCore::parseDataUrl): (WebCore::ResourceHandleManager::startJob):
- platform/network/win/CookieJarWin.cpp: (WebCore::setCookies): (WebCore::cookies):
- platform/network/win/ResourceHandleWin.cpp: (WebCore::ResourceHandle::start):
- platform/qt/PasteboardQt.cpp: (WebCore::Pasteboard::writeURL):
WebKit/gtk:
Build fix.
- WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction):
WebKit/qt:
Build fix.
- Api/qwebnetworkinterface.cpp: (QWebNetworkRequestPrivate::init):
- Api/qwebpage.cpp: (QWebPage::url): (QWebPageContext::QWebPageContext):
- Api/qwebpagehistory.cpp: (QWebHistoryItem::originalUrl): (QWebHistoryItem::currentUrl):
- WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::cannotShowURLError): (WebCore::FrameLoaderClientQt::interruptForPolicyChangeError): (WebCore::FrameLoaderClientQt::cannotShowMIMETypeError): (WebCore::FrameLoaderClientQt::fileDoesNotExistError): (WebCore::FrameLoaderClientQt::dispatchWillSendRequest): (WebCore::FrameLoaderClientQt::dispatchDidReceiveResponse): (WebCore::FrameLoaderClientQt::createPlugin):
WebKit/wx:
Build fix.
- WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::createWindow):
- WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::dispatchDidStartProvisionalLoad): (WebCore::FrameLoaderClientWx::dispatchDidCommitLoad): (WebCore::FrameLoaderClientWx::dispatchDidFinishDocumentLoad): (WebCore::FrameLoaderClientWx::postProgressFinishedNotification): (WebCore::FrameLoaderClientWx::didChangeTitle): (WebCore::FrameLoaderClientWx::dispatchDecidePolicyForNavigationAction):
- 12:07 AM Changeset in webkit [28642] by
-
- 2 edits in trunk/WebKit/win
Reviewed by Alexey Proskuryakov.
- fix a crash when pressing a key that is not associated with a command
- WebView.cpp: (WebView::handleEditingKeyboardEvent): Check if the result of interpretKeyEvent() is empty.
- 12:00 AM Changeset in webkit [28641] by
-
- 6 edits in trunk
WebCore:
Reviewed by Maciej Stachowiak.
- allow non-integer font sizes on Windows for small caps
- platform/graphics/win/FontDataWin.cpp: (WebCore::FontData::smallCapsFontData):
- platform/graphics/win/FontPlatformData.h: (WebCore::FontPlatformData::size): (WebCore::FontPlatformData::setSize):
- platform/graphics/win/FontPlatformDataWin.cpp: (WebCore::FontPlatformData::FontPlatformData):
LayoutTests:
Reviewed by Maciej Stachowiak.
- removed now-passing tests
- platform/win/Skipped:
