Timeline



Feb 26, 2008:

11:49 PM Changeset in webkit [30618] by mrowe@apple.com
  • 4 edits in branches/Safari-3-1-branch/WebCore

Merge r30617.

10:14 PM Changeset in webkit [30617] by Antti Koivisto
  • 4 edits in trunk/WebCore

Reviewed by Darin.

Fix <rdar://problem/5761326>
REGRESSION: 1.5% -2% Sunspider regression from r30009 (ebay photo upload hang)


Generate better code with VS:

  • Use ALWAYS_INLINE macro to guarantee versions of allowsAccessFrom() are reduced to single functions
  • Refactor error reporting so that there is no need to construct/destruct Strings in common cases
  • Add a separate version of the function for cases where error messages are not wanted
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customGetOwnPropertySlot):
  • bindings/js/kjs_window.cpp: (KJS::Window::allowsAccessFrom): (KJS::Window::allowsAccessFromNoErrorMessage): (KJS::Window::allowsAccessFromPrivate): (KJS::Window::crossDomainAccessErrorMessage):
  • bindings/js/kjs_window.h:
10:03 PM Google Summer of Code 2008 edited by alp@atoker.com
Add cairo SVG and ATK accessibility tasks (diff)
8:14 PM Changeset in webkit [30616] by weinig@apple.com
  • 8 edits
    5 deletes in trunk/WebCore

Reviewed by Dave Hyatt.

  • remove DeprecatedCString, DeprecatedArray, and ArrayImpl.
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • platform/ArrayImpl.cpp: Removed.
  • platform/ArrayImpl.h: Removed.
  • platform/DeprecatedArray.h: Removed.
  • platform/DeprecatedCString.cpp: Removed.
  • platform/DeprecatedCString.h: Removed.
  • platform/text/CString.cpp: (WebCore::CString::length):
  • platform/text/CString.h:
7:12 PM Changeset in webkit [30615] by hyatt@apple.com
  • 7 edits in trunk/WebCore

Cleanup of childrenChanged in preparation for fixing the HTML5 spec slowdown.

Reviewed by Sam Weinig

  • dom/Attr.cpp: (WebCore::Attr::childrenChanged):
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::removeChildren): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::addChild): (WebCore::ContainerNode::childrenChanged):
  • dom/ContainerNode.h:
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent):
  • dom/EventTargetNode.h:
  • dom/NamedAttrMap.cpp: (WebCore::NamedAttrMap::addAttribute): (WebCore::NamedAttrMap::removeAttribute):
5:56 PM Changeset in webkit [30614] by kevino@webkit.org
  • 2 edits in trunk/WebKitTools

Improvements to the wx build script.

​http://bugs.webkit.org/show_bug.cgi?id=17492

5:43 PM Changeset in webkit [30613] by Darin Adler
  • 5 edits in trunk/WebCore

Reviewed by Sam.

  • remove use of DeprecatedCString from Windows pasteboard code
  • platform/win/ClipboardUtilitiesWin.cpp: (WebCore::createGlobalData): Added an overload for Vector<char>. Streamlined the logic a bit. (WebCore::append): Added. Helper functions for appending to a Vector<char>. (WebCore::markupToCF_HTML): Rewrote to use Vector<char> instead of DeprecatedCString. Also simplified the logic a bit and used macros to handle the integer width. (WebCore::urlToMarkup): Use Vector<UChar> instead of String. (WebCore::replaceNewlinesWithWindowsStyleNewlines): Tweaked.
  • platform/win/ClipboardUtilitiesWin.h: Update type of return value from markupToCF_HTML. Did a bit of streamlining too.
  • platform/win/ClipboardWin.cpp: (WebCore::writeURL): Update for above changes. (WebCore::ClipboardWin::declareAndWriteDragImage): Ditto. (WebCore::ClipboardWin::writeRange): Ditto.
  • platform/win/PasteboardWin.cpp: (WebCore::Pasteboard::writeSelection): Ditto. (WebCore::Pasteboard::writeURL): Ditto.
4:51 PM Changeset in webkit [30612] by Adam Roben
  • 5 edits in trunk/WebKit/win

Move ResourceLoadDelegate methods to WebFrameLoaderClient

Changed all methods to use early returns where possible and COMPtr's
AdoptCOM/Query constructors.

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::assignIdentifierToInitialRequest): (WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge): (WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): (WebFrameLoaderClient::dispatchWillSendRequest): (WebFrameLoaderClient::dispatchDidReceiveResponse): (WebFrameLoaderClient::dispatchDidReceiveContentLength): (WebFrameLoaderClient::dispatchDidFinishLoading): (WebFrameLoaderClient::dispatchDidFailLoading):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
4:50 PM Changeset in webkit [30611] by Adam Roben
  • 5 edits in trunk/WebKit/win

Move two more methods to WebFrameLoaderClient

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (kit): (WebFrameLoaderClient::dispatchCreatePage): Changed nested ifs to early returns, and changed to use the COMPtr Query constructor. (WebFrameLoaderClient::dispatchDidLoadMainResource): Added an early return, and changed to use getWebDataSource.
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
4:50 PM Changeset in webkit [30610] by Adam Roben
  • 3 edits in trunk/WebKit/win

Get rid of IID_WebFrame

Reviewed by Anders.

  • WebFrame.cpp: Removed IID_WebFrame definition. (WebFrame::QueryInterface): Use uuidof(WebFrame) instead of IID_WebFrame. (WebFrame::isDescendantOfFrame): Use COMPtr's Query constructor instead of a manual QueryInterface.
  • WebFrame.h: Removed IID_WebFrame declaration, gave WebFrame a DECLSPEC_UUID.
4:49 PM Changeset in webkit [30609] by Adam Roben
  • 5 edits in trunk/WebKit/win

Move WebHistory-related methods to WebFrameLoaderClient

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory): (WebFrameLoaderClient::shouldGoToHistoryItem): (WebFrameLoaderClient::setTitle): Changed some nested ifs into early returns. (WebFrameLoaderClient::webHistory): Changed to return a COMPtr to make the reference management foolproof.
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
4:48 PM Changeset in webkit [30608] by Adam Roben
  • 5 edits in trunk/WebKit/win

Move cache-related methods to WebFrameLoaderClient

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (getWebDataSource): Moved to the top of the file. (WebFrameLoaderClient::savePlatformDataToCachedPage): (WebFrameLoaderClient::transitionToCommittedForNewPage): (WebFrameLoaderClient::canCachePage):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
4:46 PM Changeset in webkit [30607] by timothy@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Adam Roben.

<rdar://problem/5712777> REGRESSION: Arrow up/down in inspector
source list does not scroll when item at edge is reached (16572)

Use scrollIntoViewIfNeeded() instead of the hand-rolled scrollToElement
we were using in utilities.js.

  • page/inspector/DocumentPanel.js: Use scrollIntoViewIfNeeded instead of scrollToElement.
  • page/inspector/Resource.js: Ditto.
  • page/inspector/inspector.js: Ditto.
  • page/inspector/SourcePanel.js: Use scrollIntoViewIfNeeded instead of scrollIntoView, so the source line is centered in the view if needed.
  • page/inspector/utilities.js: Removed scrollToElement().
3:47 PM Changeset in webkit [30606] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

Add a skipped storage test for now

  • platform/win/Skipped: Added storage/multiple-transactions.html
3:17 PM Changeset in webkit [30605] by hyatt@apple.com
  • 6 adds in trunk/LayoutTests/platform/mac/fast/inline
3:17 PM Changeset in webkit [30604] by hyatt@apple.com
  • 2 adds in trunk/LayoutTests/fast/inline
3:17 PM Changeset in webkit [30603] by hyatt@apple.com
  • 6 edits in trunk/WebCore

Reviewed by Dan

​http://bugs.webkit.org/show_bug.cgi?id=17485

Refine our behavior for empty inlines so that they work more correctly with margins/borders/padding.
Fixes a regression on huffingtonpost.com.

New tests added to fast/inline

  • rendering/InlineFlowBox.cpp: (WebCore::InlineFlowBox::computeLogicalBoxHeights): (WebCore::InlineFlowBox::placeBoxesVertically): (WebCore::InlineFlowBox::shrinkBoxesWithNoTextChildren):
  • rendering/RenderFlow.cpp: (WebCore::RenderFlow::calcMargins):
  • rendering/RenderFlow.h:
  • rendering/RenderObject.h: (WebCore::RenderObject::hasHorizontalBordersPaddingOrMargin): (WebCore::RenderObject::hasHorizontalBordersOrPadding):
  • rendering/bidi.cpp: (WebCore::getBorderPaddingMargin): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::inlineFlowRequiresLineBox):
2:00 PM Changeset in webkit [30602] by Adam Roben
  • 29 edits in branches/Safari-3-1-branch/LayoutTests

Roll out r29650, since r29649 was rolled out in r30483

r29650 updated some test results which changed after r29649 landed.
Now that r29649 has been rolled out of this branch, we need to roll
r29650 out as well to keep the tests passing.

Reviewed by Anders and Mark.

  • platform/mac/fast/inline/001-expected.checksum:
  • platform/mac/fast/inline/001-expected.png:
  • platform/mac/fast/inline/002-expected.checksum:
  • platform/mac/fast/inline/002-expected.png:
  • platform/mac/fast/inline/br-text-decoration-expected.checksum:
  • platform/mac/fast/inline/br-text-decoration-expected.png:
  • platform/mac/fast/inline/continuation-outlines-expected.checksum:
  • platform/mac/fast/inline/continuation-outlines-expected.png:
  • platform/mac/fast/inline/continuation-outlines-with-layers-expected.checksum:
  • platform/mac/fast/inline/continuation-outlines-with-layers-expected.png:
  • platform/mac/fast/inline/dirtyLinesForInline-expected.checksum:
  • platform/mac/fast/inline/dirtyLinesForInline-expected.png:
  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.checksum:
  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.png:
  • platform/mac/fast/inline/drawStyledEmptyInlines-expected.txt:
  • platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.checksum:
  • platform/mac/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
  • platform/mac/fast/inline/emptyInlinesWithinLists-expected.checksum:
  • platform/mac/fast/inline/emptyInlinesWithinLists-expected.png:
  • platform/mac/fast/inline/emptyInlinesWithinLists-expected.txt:
  • platform/mac/fast/inline/inline-borders-with-bidi-override-expected.checksum:
  • platform/mac/fast/inline/inline-borders-with-bidi-override-expected.png:
  • platform/mac/fast/inline/outline-continuations-expected.checksum:
  • platform/mac/fast/inline/outline-continuations-expected.png:
  • platform/mac/fast/inline/positionedLifetime-expected.checksum:
  • platform/mac/fast/inline/positionedLifetime-expected.png:
  • platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.checksum:
  • platform/mac/fast/inline/styledEmptyInlinesWithBRs-expected.png:
1:59 PM Changeset in webkit [30601] by Adam Roben
  • 1 edit
    1 add in branches/Safari-3-1-branch/LayoutTests

Merge r30320.

1:59 PM Changeset in webkit [30600] by Adam Roben
  • 21 edits in branches/Safari-3-1-branch/LayoutTests

Merge r30212.

1:59 PM Changeset in webkit [30599] by Adam Roben
  • 2 edits in branches/Safari-3-1-branch/LayoutTests

Update results for a test that is sensitive to ENABLE_CROSS_DOCUMENT_MESSAGING

Reviewed by Anders.

  • fast/dom/Window/window-function-name-getter-precedence-expected.txt:
1:58 PM Changeset in webkit [30598] by Adam Roben
  • 2 edits in branches/Safari-3-1-branch/LayoutTests

Enable two fixed tests

Reviewed by Anders.

  • platform/win/Skipped:
1:54 PM Changeset in webkit [30597] by timothy@apple.com
  • 6 edits in trunk

.:

Reviewed by Darin Adler.

Add "64" and "64u" make rules to allow easy building of 64-bit versions.

make 64: will build Intel-only 64-bit.
make 64u: will build 4-way universal for PPC and Intel.

  • Makefile:
  • Makefile.shared:

WebKitTools:

Reviewed by Darin Adler.

  • Scripts/build-webkit: Add --universal and --64-bit flags to make building 64-bit architectures easy. Combine the two flags to build 4-way universal.
  • Makefile: Add "64" and "64u" make rules. Fix the universal rule to return non-zero when the build failes.
1:22 PM Changeset in webkit [30596] by weinig@apple.com
  • 2 edits in trunk/WebCore

Fix Windows build.

  • platform/text/PlatformString.h: (WebCore::reverseFind):
12:57 PM Google Summer of Code 2008 edited by david.bolter@utoronto.ca
(diff)
12:43 PM Google Summer of Code 2008 edited by david.bolter@utoronto.ca
(diff)
11:01 AM Changeset in webkit [30595] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: fast/dynamic/subtree-table-cell-height.html

  • rendering/RenderObject.cpp: (WebCore::objectIsRelayoutBoundary): Exclude table cells, since their height depends on their contents even if the CSS height property is fixed.

LayoutTests:

Reviewed by Darin Adler.

  • fast/dynamic/subtree-table-cell-height.html: Added.
  • platform/mac/fast/dynamic/subtree-table-cell-height-expected.checksum: Added.
  • platform/mac/fast/dynamic/subtree-table-cell-height-expected.png: Added.
  • platform/mac/fast/dynamic/subtree-table-cell-height-expected.txt: Added.
10:26 AM Changeset in webkit [30594] by jess@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Darin.

  • Scripts/gdb-safari: Set WEBKIT_UNSET_DYLD_FRAMEWORK_PATH in gdb's environment, so that Safari inherits it when launched. Preexisting code in WebKit checks this environment variable, and if set, unsets DYLD_FRAMEWORK_PATH, so that applications launched by Safari continue to use the standard system WebKit.
9:06 AM Changeset in webkit [30593] by weinig@apple.com
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Dan Bernstein.

  • Add a variant of remove that takes a position and a length.
  • wtf/Vector.h: (WTF::Vector::remove):

WebCore:

Reviewed by Dan Bernstein.

Make the cleanPath function in CSSStyleSelector more efficient by using
a Vector<UChar>.

  • css/CSSStyleSelector.cpp: (WebCore::cleanPath): Make this function work on a Vector<UChar> instead of a String. Also remove unnecessary reverseFind call that could be acomplished with two compares. (WebCore::checkPseudoState): Remove reserveCapacity calls now that we are using a stack buffer.
  • platform/text/PlatformString.h: (WebCore::find): Make this find generic enough that it can be used for String::find. (WebCore::reverseFind): Implement reverseFind so that it can be used for with a UChar* and length.
  • platform/text/StringImpl.cpp: (WebCore::StringImpl::find): Use implementation in PlatformString.cpp (WebCore::StringImpl::reverseFind): Ditto,
7:24 AM Google Summer of Code 2008 edited by Adam Roben
Added ideas from the SummerOfCodeIdeas page (diff)
2:15 AM Changeset in webkit [30592] by ap@webkit.org
  • 4 edits
    2 adds in trunk

Reviewed by Darin. Tweaked and landed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=17411
Ideographic comma and full stop should be treated as line-breakable characters

Test: fast/text/line-breaks-after-ideographic-comma-or-full-stop.html

  • platform/text/CharacterNames.h: Added ideographicComma and ideographicFullStop.
  • rendering/break_lines.cpp: (WebCore::shouldBreakAfter): Added a workaround for an issue in Unicode 5.0 that is causing this.
12:56 AM Changeset in webkit [30591] by eric@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by eseidel. Landed by eseidel

Fix improperly initialized m_isUpToDate member variable.
Fixs 50+ layout tests when run on Tiger.
​http://bugs.webkit.org/show_bug.cgi?id=17549

  • platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/mac/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):

Feb 25, 2008:

11:30 PM Google Summer of Code 2008 edited by eric@webkit.org
(diff)
11:05 PM Google Summer of Code 2008 created by eric@webkit.org
10:47 PM Changeset in webkit [30590] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Sam Weinig.

Test: fast/text/apply-start-width-after-skipped-text.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Improved the logic for when to figure in the padding, border and margin before a text node when the line begins inside a text node.

LayoutTests:

Reviewed by Sam Weinig.

  • fast/text/apply-start-width-after-skipped-text.html: Added.
  • platform/mac/fast/text/apply-start-width-after-skipped-text-expected.checksum: Added.
  • platform/mac/fast/text/apply-start-width-after-skipped-text-expected.png: Added.
  • platform/mac/fast/text/apply-start-width-after-skipped-text-expected.txt: Added.
10:47 PM WikiStart edited by eric@webkit.org
(diff)
10:20 PM Changeset in webkit [30589] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Windows build fix for wx port.

9:00 PM Changeset in webkit [30588] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-02-25 Mark Rowe <​mrowe@apple.com>

Windows build fix.

  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformCompare): Implement platformCompare for ResourceResponseCFNet.cpp.
8:25 PM Changeset in webkit [30587] by Beth Dakin
  • 4 edits
    2 adds in trunk

WebCore:

Reviewed by Geoff.

Fixed for <rdar://problem/5760530> REGRESSION: Assertion failure in
Document::removePendingSheet() from r30438

r30438 added a call to CachedResource::error() from inside
Loader::didReceiveData() if a CSS file 4xxs. There was an
assumption in the loader, though, that either error() would be
called, or didFinishLoading() would be called, so some work is
duplicated in each. Now that we are calling an error() on files
that will also make it to didFinishLoading() (since they succeeded
in the network layer), we need to make sure we do not duplicate the
work. CachedCSSStyleSheet::error() calls checkNotify, which ends up
decrementing the document's pending style sheet counter.
checkNotify() was still getting called, though, through the normal
didFinishLoading code path, and the counter was being decremented
twice. Bad!

  • loader/loader.cpp: (WebCore::Loader::didFinishLoading): (WebCore::Loader::didReceiveData):

LayoutTests:

Reviewed by Geoff.

Test for <rdar://problem/5760530> REGRESSION: Assertion failure in
Document::removePendingSheet() from r30438

  • http/tests/misc/missing-style-sheet-expected.txt: Added.
  • http/tests/misc/missing-style-sheet.html: Added.
8:01 PM Changeset in webkit [30586] by mrowe@apple.com
  • 5 edits in trunk/WebCore

Fix the Gtk, wx and Qt builds.

6:22 PM Changeset in webkit [30585] by mrowe@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

Fix bug number in ChangeLog.

6:21 PM Changeset in webkit [30584] by mrowe@apple.com
  • 20 edits
    4 moves
    8 adds in trunk/WebCore

2008-02-25 MorganL <​morganl.webkit@yahoo.com>

Reviewed by Darin Adler.

Eliminate some #ifdefs from headers in platform/network.
​http://bugs.webkit.org/show_bug.cgi?id=11786

  • WebCore.base.exp:
  • WebCore.order:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/XMLTokenizer.cpp:
  • loader/ResourceLoader.h:
  • platform/network/AuthenticationChallenge.cpp: Removed.
  • platform/network/AuthenticationChallenge.h: Removed.
  • platform/network/AuthenticationChallengeBase.cpp: Copied from platform/network/AuthenticationChallenge.cpp. (WebCore::AuthenticationChallengeBase::AuthenticationChallengeBase): (WebCore::AuthenticationChallengeBase::previousFailureCount): (WebCore::AuthenticationChallengeBase::proposedCredential): (WebCore::AuthenticationChallengeBase::protectionSpace): (WebCore::AuthenticationChallengeBase::failureResponse): (WebCore::AuthenticationChallengeBase::error): (WebCore::AuthenticationChallengeBase::isNull): (WebCore::AuthenticationChallengeBase::nullify): (WebCore::AuthenticationChallengeBase::compare):
  • platform/network/AuthenticationChallengeBase.h: Copied from platform/network/AuthenticationChallenge.h. (WebCore::AuthenticationChallengeBase::platformCompare): (WebCore::operator==): (WebCore::operator!=):
  • platform/network/ResourceError.cpp: Removed.
  • platform/network/ResourceError.h: Removed.
  • platform/network/ResourceErrorBase.cpp: Copied from platform/network/ResourceError.cpp. (WebCore::ResourceErrorBase::lazyInit): (WebCore::ResourceErrorBase::compare):
  • platform/network/ResourceErrorBase.h: Copied from platform/network/ResourceError.h. (WebCore::ResourceErrorBase::isNull): (WebCore::ResourceErrorBase::domain): (WebCore::ResourceErrorBase::errorCode): (WebCore::ResourceErrorBase::failingURL): (WebCore::ResourceErrorBase::localizedDescription): (WebCore::ResourceErrorBase::ResourceErrorBase): (WebCore::ResourceErrorBase::platformLazyInit): (WebCore::ResourceErrorBase::platformCompare): (WebCore::operator==):
  • platform/network/ResourceResponseBase.cpp: (WebCore::ResourceResponseBase::isHTTP): (WebCore::ResourceResponseBase::url): (WebCore::ResourceResponseBase::setUrl): (WebCore::ResourceResponseBase::mimeType): (WebCore::ResourceResponseBase::setMimeType): (WebCore::ResourceResponseBase::expectedContentLength): (WebCore::ResourceResponseBase::setExpectedContentLength): (WebCore::ResourceResponseBase::textEncodingName): (WebCore::ResourceResponseBase::setTextEncodingName): (WebCore::ResourceResponseBase::suggestedFilename): (WebCore::ResourceResponseBase::setSuggestedFilename): (WebCore::ResourceResponseBase::httpStatusCode): (WebCore::ResourceResponseBase::setHTTPStatusCode): (WebCore::ResourceResponseBase::httpStatusText): (WebCore::ResourceResponseBase::setHTTPStatusText): (WebCore::ResourceResponseBase::httpHeaderField): (WebCore::ResourceResponseBase::setHTTPHeaderField): (WebCore::ResourceResponseBase::httpHeaderFields): (WebCore::ResourceResponseBase::isAttachment): (WebCore::ResourceResponseBase::setExpirationDate): (WebCore::ResourceResponseBase::expirationDate): (WebCore::ResourceResponseBase::setLastModifiedDate): (WebCore::ResourceResponseBase::lastModifiedDate): (WebCore::ResourceResponseBase::lazyInit): (WebCore::ResourceResponseBase::compare):
  • platform/network/ResourceResponseBase.h: (WebCore::ResourceResponseBase::ResourceResponseBase): (WebCore::ResourceResponseBase::platformLazyInit): (WebCore::ResourceResponseBase::platformCompare): (WebCore::operator==):
  • platform/network/cf/AuthenticationCF.cpp: (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::AuthenticationChallenge::platformCompare):
  • platform/network/cf/AuthenticationChallenge.h: Added. (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::AuthenticationChallenge::sourceHandle): (WebCore::AuthenticationChallenge::cfURLAuthChallengeRef):
  • platform/network/cf/ResourceError.h: Added. (WebCore::ResourceError::ResourceError):
  • platform/network/cf/ResourceErrorCF.cpp: (WebCore::ResourceError::ResourceError): (WebCore::ResourceError::platformLazyInit): (WebCore::ResourceError::platformCompare): (WebCore::ResourceError::operator CFStreamError):
  • platform/network/cf/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/cf/ResourceResponseCFNet.cpp: (WebCore::ResourceResponse::platformLazyInit):
  • platform/network/curl/AuthenticationChallenge.h: Added. (WebCore::AuthenticationChallenge::AuthenticationChallenge):
  • platform/network/curl/ResourceError.h: Added. (WebCore::ResourceError::ResourceError):
  • platform/network/curl/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/mac/AuthenticationChallenge.h: Added. (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::AuthenticationChallenge::sender): (WebCore::AuthenticationChallenge::nsURLAuthenticationChallenge):
  • platform/network/mac/AuthenticationMac.mm: (WebCore::AuthenticationChallenge::AuthenticationChallenge): (WebCore::AuthenticationChallenge::platformCompare):
  • platform/network/mac/ResourceError.h: Added. (WebCore::ResourceError::ResourceError):
  • platform/network/mac/ResourceErrorMac.mm: (WebCore::ResourceError::platformLazyInit): (WebCore::ResourceError::platformCompare):
  • platform/network/mac/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • platform/network/mac/ResourceResponseMac.mm: (WebCore::ResourceResponse::platformLazyInit): (WebCore::ResourceResponse::platformCompare):
  • platform/network/qt/AuthenticationChallenge.h: Added. (WebCore::AuthenticationChallenge::AuthenticationChallenge):
  • platform/network/qt/ResourceError.h: Added. (WebCore::ResourceError::ResourceError):
  • platform/network/qt/ResourceResponse.h: (WebCore::ResourceResponse::ResourceResponse):
  • xml/XSLTProcessor.cpp:
5:06 PM Changeset in webkit [30583] by Adam Roben
  • 2 edits in trunk/WebKitTools

Fix run-webkit-tests after r30394

  • Scripts/webkitdirs.pm: Never append _debug to FindSafari's executable name.
5:05 PM Changeset in webkit [30582] by Adam Roben
  • 5 edits in trunk/WebKit/win

Move plugin-related methods to WebFrameLoaderClient

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::WebFrameLoaderClient): (WebFrameLoaderClient::setMainDocumentError): (WebFrameLoaderClient::committedLoad): Added some early returns. (WebFrameLoaderClient::receivedData): (WebFrameLoaderClient::finishedLoading): Ditto. (getWebDataSource): (WebFrameLoaderClient::createPlugin):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp: (WebFrame::WebFramePrivate::WebFramePrivate):
  • WebFrame.h:
5:05 PM Changeset in webkit [30581] by Adam Roben
  • 5 edits in trunk/WebKit/win

Move createFrame to WebFrameLoaderClient

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::createFrame): (WebFrameLoaderClient::loadURLIntoChild):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
5:04 PM Changeset in webkit [30580] by Adam Roben
  • 5 edits in trunk/WebKit/win

Move progress-related methods to WebFrameLoaderClient

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::postProgressStartedNotification): (WebFrameLoaderClient::postProgressEstimateChangedNotification): (WebFrameLoaderClient::postProgressFinishedNotification):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
5:01 PM Changeset in webkit [30579] by Adam Roben
  • 3 edits in trunk/WebKit/win

Remove WebFrame::detachedFromParent1

This method was removed from FrameLoaderClient in r19042, but was
never removed from WebFrame.

Reviewed by Anders.

  • WebFrame.cpp:
  • WebFrame.h:
4:52 PM BuildingCairoOnWindows edited by bfulgham@macports.org
(diff)
4:28 PM Changeset in webkit [30578] by beidson@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

Reviewed by T3h Mitz Pettel (Dan Bernstein)

Layout test for already fixed bug <rdar://problem/5729445>

  • storage/multiple-transactions-expected.txt: Added.
  • storage/multiple-transactions.html: Added.
2:57 PM Changeset in webkit [30577] by andersca@apple.com
  • 7 edits in trunk/WebCore

Reviewed by Darin.

Move remaining render style objects over to start with a refcount of 1 and get
rid of DeprecatedDataRef.


  • rendering/DataRef.h: (WebCore::DataRef::operator*): (WebCore::DataRef::operator->):
  • rendering/RenderStyle.h:
  • rendering/SVGRenderStyle.cpp: (WebCore::SVGRenderStyle::SVGRenderStyle):
  • rendering/SVGRenderStyle.h: (WebCore::SVGRenderStyle::create): (WebCore::SVGRenderStyle::copy):
  • rendering/SVGRenderStyleDefs.cpp: (StyleFillData::StyleFillData): (StyleStrokeData::StyleStrokeData): (StyleStopData::StyleStopData): (StyleTextData::StyleTextData): (StyleClipData::StyleClipData): (StyleMaskData::StyleMaskData): (StyleMarkerData::StyleMarkerData): (StyleMiscData::StyleMiscData):
  • rendering/SVGRenderStyleDefs.h: (WebCore::StyleFillData::create): (WebCore::StyleFillData::copy): (WebCore::StyleStrokeData::create): (WebCore::StyleStrokeData::copy): (WebCore::StyleStopData::create): (WebCore::StyleStopData::copy): (WebCore::StyleTextData::create): (WebCore::StyleTextData::copy): (WebCore::StyleClipData::create): (WebCore::StyleClipData::copy): (WebCore::StyleMaskData::create): (WebCore::StyleMaskData::copy): (WebCore::StyleMarkerData::create): (WebCore::StyleMarkerData::copy): (WebCore::StyleMiscData::create): (WebCore::StyleMiscData::copy):
2:44 PM Changeset in webkit [30576] by mrowe@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-02-25 Mark Mentovai <​mark@moxienet.com>

Reviewed by Mark Rowe.

Enable CollectorHeapIntrospector to build by itself, as well as in an AllInOneFile build.
​http://bugs.webkit.org/show_bug.cgi?id=17538

  • kjs/CollectorHeapIntrospector.cpp: Provide "using" declaration for WTF::RemoteMemoryReader.
  • kjs/collector.h: Move CollectorHeap declaration here...
  • kjs/collector.cpp: ... from here.
2:03 PM Changeset in webkit [30575] by mitz@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • remove file-static BidiRun variables from bidi.cpp
  • platform/text/BidiResolver.h: (WebCore::BidiResolver::): Initialize m_logicallyLastRun. (WebCore::BidiResolver::logicallyLastRun): Added. (WebCore::BidiResolver::runCount): Made unsigned. (WebCore::::reverseRuns): Changed ints to unsigned. (WebCore::::createBidiRunsForLine): Made this function set m_logicallyLastRun.
  • rendering/RenderBlock.h:
  • rendering/bidi.cpp: (WebCore::BidiState::addRun): Removed setting of sLogicallyLastBidiRun. (WebCore::RenderBlock::constructLine): Removed unused start parameter and added run count and first and last run parameters. Replaced end parameter with lastLine boolean and endObject pointer. (WebCore::RenderBlock::computeHorizontalPositionsForLine): Added first and logically last run parameters. (WebCore::RenderBlock::computeVerticalPositionsForLine): Added firstRun parameter. (WebCore::RenderBlock::bidiReorderLine): Removed setting of static variables. (WebCore::RenderBlock::layoutInlineChildren): Changed to use BidiState accessors instead of file statics.
1:58 PM Changeset in webkit [30574] by mrowe@apple.com
  • 16 edits
    1 copy
    1 delete in trunk/WebCore

2008-02-25 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Jon Honeycutt.

​http://bugs.webkit.org/show_bug.cgi?id=16924
Bug 16924: Shared PluginDatabase, PluginPackage, and PlugInInfoStore implementations

Add PluginInfoStore.cpp and new PluginDatabase.cpp to GTK+ and Qt ports.
Remove old PlugInInfoStoreQt.cpp as it is obsoleted by shared code.
Add PluginInfoStore, PluginDatabase, and PluginStream files to Wx build.
Add new PluginDatabase.cpp to Windows build.
Add temporary stubs for new PluginDatabase and PluginPackage.
shared classes to GTK+, Qt, and Wx ports.
Copy PluginDatabaseWin.cpp to PluginDatabase.cpp to preserve history.
Remove shared code from PluginDatabaseWin.cpp.
Remove Windows-specific code from PluginDatabase.cpp.
Use PlatformModule and PlatformFileTime instead of HMODULE and FILETIME.

Remove extraneous PluginPackage
from hash() class method prototype. Subsume storeFileVersion into PluginPackage::fetchInfo. Add cross-platform PlatformModuleVersion type definition. Use PlatformModuleVersion to store the module version. Rename m_fileVersion[ML]S to m_moduleVersion. Change compareFileVersion to use PlatformModuleVersion as the argument. Move PluginView::determineQuirks and m_quirks to PluginPackage. Updated determineQuirks for the PlatformModuleVersion.
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCoreSources.bkl:
  • webcore-base.bkl:
  • WebCore.vcproj/WebCore.vcproj:
  • Platform/FileSystem.h:
  • platform/qt/PlugInInfoStoreQt.cpp:
  • platform/gtk/TemporaryLinkStubs.cpp:
  • platform/qt/TemporaryLinkStubs.cpp:
  • platform/wx/TemporaryLinkStubs.cpp:
  • plugins/PluginDatabase.cpp:
  • plugins/PluginDatabase.h:
  • plugins/win/PluginDatabaseWin.cpp:
  • plugins/PluginPackage.h:
  • plugins/win/PluginPackageWin.cpp:
  • plugins/PluginView.h:
  • plugins/win/PluginViewWin.cpp:
1:51 PM Changeset in webkit [30573] by andersca@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin.

Make more style objects start out with a refcount of 1.


  • rendering/RenderStyle.cpp: (WebCore::StyleSurroundData::StyleSurroundData): (WebCore::StyleBoxData::StyleBoxData): (WebCore::StyleVisualData::StyleVisualData): (WebCore::StyleBackgroundData::StyleBackgroundData): (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareInheritedData::StyleRareInheritedData): (WebCore::StyleInheritedData::StyleInheritedData):
  • rendering/RenderStyle.h: (WebCore::StyleSurroundData::create): (WebCore::StyleSurroundData::copy): (WebCore::StyleBoxData::create): (WebCore::StyleBoxData::copy): (WebCore::StyleVisualData::create): (WebCore::StyleVisualData::copy): (WebCore::StyleBackgroundData::create): (WebCore::StyleBackgroundData::copy): (WebCore::StyleBackgroundData::~StyleBackgroundData): (WebCore::StyleRareNonInheritedData::create): (WebCore::StyleRareNonInheritedData::copy): (WebCore::StyleRareInheritedData::create): (WebCore::StyleRareInheritedData::copy): (WebCore::StyleInheritedData::create): (WebCore::StyleInheritedData::copy):
12:00 PM Changeset in webkit [30572] by andersca@apple.com
  • 5 edits in trunk/WebCore

Reviewed by Darin.

Make some of the refcounted style objects start out with a refcount of 1.

  • rendering/DataRef.h: Make a DeprecatedDataRef class which is just a copy of the old DataRef class. Change DataRef to use ::create() and ::copy() instead of the constructors. Change DataRef's pointer to be a RefPtr instead.
  • rendering/RenderStyle.cpp: (WebCore::StyleMarqueeData::StyleMarqueeData): (WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData): (WebCore::StyleMultiColData::StyleMultiColData): (WebCore::StyleTransformData::StyleTransformData): Start with a RefCount of 1.


  • rendering/RenderStyle.h:
  • rendering/SVGRenderStyle.h: Add ::create() and ::copy() methods. Make not yet converted classes use DeprecatedDataRef.
9:33 AM Changeset in webkit [30571] by Darin Adler
  • 3 edits
    3 adds in trunk

WebCore:

Reviewed by Anders.
Based on a patch by Tim Steele <​timsteele41@gmail.com>.

Test: fast/loader/meta-refresh-anchor-click.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load): When load type is FrameLoadTypeRedirectWithLockedHistory, always do a real load. This makes sure that meta refresh loads are treated as real loads rather than anchor scrolls. Also tweaked formatting a bit. (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy): This function is an alternate way to complete a load, so it needs to start the redirection timer if redirection has already been scheduled.

LayoutTests:

Reviewed by Anders.

  • fast/loader/meta-refresh-anchor-click-expected.txt: Added.
  • fast/loader/meta-refresh-anchor-click.html: Added.
  • fast/loader/resources/meta-refresh-subframe.html: Added.
9:11 AM Changeset in webkit [30570] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • avoid counting spaces in non-justified text
  • rendering/bidi.cpp: Removed file-static numSpaces. (WebCore::BidiState::addRun): Removed space counting. (WebCore::RenderBlock::computeHorizontalPositionsForLine): Added space counting, conditional on the block having the text-align: justify property value. (WebCore::RenderBlock::bidiReorderLine): Removed initialization of numSpaces.
9:10 AM Changeset in webkit [30569] by Darin Adler
  • 2 edits in trunk/WebCore

Requested by Steve.

  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::createFrameAtIndex): Put the string into a global variable (because CFSTR is inefficient on Windows).
9:06 AM Changeset in webkit [30568] by Darin Adler
  • 6 edits in trunk

JavaScriptCore:

Reviewed by Adam.

WebCore:

Reviewed by Adam.

  • WebCore.base.exp: Export blankURL, and sort the file.

WebKit/mac:

Reviewed by Adam.

  • WebView/WebArchiver.mm: (+[WebArchiver archiveSelectionInFrame:]): Use blankURL.
  • WebView/WebFrame.mm: (-[WebFrame _loadData:MIMEType:textEncodingName:baseURL:unreachableURL:]): Avoid the variable name URL to avoid clashing with the renamed KURL in the future. Also use blankURL. (-[WebFrame loadData:MIMEType:textEncodingName:baseURL:]): Ditto. (-[WebFrame _loadHTMLString:baseURL:unreachableURL:]): Ditto. (-[WebFrame loadHTMLString:baseURL:]): Ditto. (-[WebFrame loadAlternateHTMLString:baseURL:forUnreachableURL:]): Ditto.
8:53 AM Changeset in webkit [30567] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

MSVC build fix

  • kjs/testkjs.cpp: (functionQuit): Don't add a return statement after exit(0) for MSVC.
8:52 AM Changeset in webkit [30566] by Adam Roben
  • 5 edits in trunk/WebKit/win

Move many dispatch methods to WebFrameLoaderClient

Reviewed by Sam.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::dispatchDidHandleOnloadEvents): (WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad): (WebFrameLoaderClient::dispatchDidCancelClientRedirect): (WebFrameLoaderClient::dispatchWillPerformClientRedirect): (WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): (WebFrameLoaderClient::dispatchWillClose): (WebFrameLoaderClient::dispatchDidReceiveIcon): (WebFrameLoaderClient::dispatchDidStartProvisionalLoad): (WebFrameLoaderClient::dispatchDidReceiveTitle): (WebFrameLoaderClient::dispatchDidCommitLoad): (WebFrameLoaderClient::dispatchDidFinishDocumentLoad): (WebFrameLoaderClient::dispatchDidFinishLoad): (WebFrameLoaderClient::dispatchDidFirstLayout): (WebFrameLoaderClient::dispatchShow):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
8:52 AM Changeset in webkit [30565] by Adam Roben
  • 5 edits in trunk/WebKit/win

Move two more methods to WebFrameLoaderClient

Reviewed by Sam.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::hasFrameView): (WebFrame::forceLayout):
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:
  • WebFrame.h:
5:16 AM Changeset in webkit [30564] by Simon Hausmann
  • 16 edits in trunk/WebCore

Fix compilation with gcc 4.3, added stdio.h and unistd.h inclusions.

5:14 AM Changeset in webkit [30563] by mrowe@apple.com
  • 3 edits
    4 adds in trunk

2008-02-25 Johnny Ding <​johnnyding.webkit@gmail.com>

Reviewed by Darin Adler.

In HTMLTokenizer::write, the code checks 'pendingScripts.isEmpty()' to decide
whether to save prependingSrc or not. However, in HTMLTokenizer::scriptHandler
and HTMLTokenizer::scriptExecution, the code checks testBit:LoadingExtScript
to decide whether to save prependingSrc or not. The later behavior is not right
because, in scriptHandler and scriptExecution, even the pendingScripts queue is
empty, the testBit:LoadingExtScript might be TRUE.

Test: fast/tokenizer/nested-multiple-scripts.html

  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::scriptHandler): check pendingScripts.isEmpty() instead of checking state.loadingExtScript(). (WebCore::HTMLTokenizer::scriptExecution): check pendingScripts.isEmpty() instead of checking state.loadingExtScript().

2008-02-25 Johnny Ding <​johnnyding.webkit@gmail.com>

Reviewed by Darin Adler.

  • fast/tokenizer/nested-multiple-scripts-expected.txt: Added.
  • fast/tokenizer/nested-multiple-scripts.html: Added.
  • fast/tokenizer/resources/external-script-1.js: Added.
  • fast/tokenizer/resources/external-script-2.js: Added.

Feb 24, 2008:

11:44 PM Changeset in webkit [30562] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: Make some updates based on a trial run of the renaming script.
11:17 PM Changeset in webkit [30561] by Darin Adler
  • 2 edits in trunk/WebKitTools
  • Scripts/do-webcore-rename: More renaming plans.
11:11 PM Changeset in webkit [30560] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=17529
Add support for reading from stdin from testkjs

  • kjs/testkjs.cpp: (GlobalObject::GlobalObject): Add readline function to global object. (functionReadline): Added. Reads characters from stdin until a '\n' or EOF is encountered. The input is returned as a String to the caller.
11:09 PM Changeset in webkit [30559] by Darin Adler
  • 2 edits in trunk/WebCore
  • dom/Document.h: Removed stray duplicate declaration of RegisteredEventListenerList.
10:52 PM Changeset in webkit [30558] by Darin Adler
  • 2 edits in trunk/WebCore
  • dom/Range.cpp: (WebCore::Range::surroundContents): Removed incorrect comment. I added it a while ago, and I was just mixed up.
10:48 PM Changeset in webkit [30557] by Darin Adler
  • 2 edits in trunk/WebCore
  • quick follow-up to that last check-in
  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::createFrameAtIndex): Use CFEqual instead of WebCore::String's == for speed.
10:36 PM Changeset in webkit [30556] by Darin Adler
  • 3 edits
    6 adds in trunk

WebCore:

Reviewed by Darin.

Bug 8749: XBM rendered incorrectly as black on white

xbm images are now created and rendered using black on a
transparent background (same behavior as in Firefox)

Test: platform/mac/fast/canvas/canvas-draw-xbm-image.html

  • platform/graphics/cg/ImageSourceCG.cpp: (WebCore::ImageSource::createFrameAtIndex):

LayoutTests:

Reviewed by Darin.


  • platform/mac/fast/canvas/canvas-draw-xbm-image-expected.checksum: Added.
  • platform/mac/fast/canvas/canvas-draw-xbm-image-expected.png: Added.
  • platform/mac/fast/canvas/canvas-draw-xbm-image-expected.txt: Added.
  • platform/mac/fast/canvas/canvas-draw-xbm-image.html: Added.
  • platform/mac/fast/canvas/resources: Added.
  • platform/mac/fast/canvas/resources/smile.xbm: Added.
9:29 PM Changeset in webkit [30555] by weinig@apple.com
  • 4 edits in trunk/JavaScriptCore

Reviewed by Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=17528
Give testkjs a bath

  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj: Make the testkjs.cpp use 4 space indentation.
  • kjs/testkjs.cpp: (StopWatch::getElapsedMS): (GlobalObject::className): (GlobalObject::GlobalObject): Rename GlobalImp to GlobalObject and setup the global functions in the GlobalObject's constructor. Also, use static functions for the implementation so we can use the standard PrototypeFunction class and remove TestFunctionImp. (functionPrint): Move print() functionality here. (functionDebug): Move debug() functionality here. (functionGC): Move gc() functionality here. (functionVersion): Move version() functionality here. (functionRun): Move run() functionality here. (functionLoad): Move load() functionality here. (functionQuit): Move quit() functionality here. (prettyPrintScript): Fix indentation. (runWithScripts): Since all the functionality of createGlobalObject is now in the GlobalObject constructor, just call new here. (parseArguments): Fix indentation. (kjsmain): Ditto (fillBufferWithContentsOfFile): Ditto.
7:08 PM Changeset in webkit [30554] by mitz@apple.com
  • 3 edits
    3 adds in trunk

WebCore:

Reviewed by Darin Adler.

Test: http/tests/misc/object-image-error.html

  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::attach): Added an early return in case updateFromElement() has changed the object to use fallback content.

LayoutTests:

Reviewed by Darin Adler.

  • http/tests/misc/object-image-error-expected.txt: Added.
  • http/tests/misc/object-image-error.html: Added.
  • http/tests/misc/resources/404image.php: Added.
5:34 PM Changeset in webkit [30553] by weinig@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Oliver Hunt and Mark Rowe.

​http://bugs.webkit.org/show_bug.cgi?id=17505
Add support for getting command line arguments in testkjs

  • This slightly changes the behavior of parsing arguments by requiring a '-f' before all files.
  • kjs/testkjs.cpp: (createGlobalObject): Add a global property called 'arguments' which contains an array with the parsed arguments as strings. (runWithScripts): Pass in the arguments vector so that it can be passed to the global object. (parseArguments): Change parsing rules to require a '-f' before any script file. After all '-f' and '-p' arguments have been parsed, the remaining are added to the arguments vector and exposed to the script. If there is a chance of ambiguity (the user wants to pass the string '-f' to the script), the string '--' can be used separate the options from the pass through arguments. (kjsmain):
2:50 PM Changeset in webkit [30552] by mitz@apple.com
  • 1 edit
    651 moves
    651 deletes in trunk/LayoutTests

Rubber-stamped by Oliver Hunt.

  • replace expected results in platform/mac-tiger and platform/mac-leopard which were identical with a single copy in platform/mac
10:48 AM Changeset in webkit [30551] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix float positioning when a float that does not fit on the line is followed by a float that does

Test: fast/block/float/narrow-after-wide.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::findNextLineBreak): Changed to not position any more floats on the line once a float that does not fit is encountered. That float should be pushed to the next line, and so should all floats that follow, regardless of whether they can fit on the current line.

LayoutTests:

Reviewed by Darin Adler.

  • test float positioning when a float that does not fit on the line is followed by a float that does
  • fast/block/float/narrow-after-wide.html: Added.
  • platform/mac/fast/block/float/narrow-after-wide-expected.checksum: Added.
  • platform/mac/fast/block/float/narrow-after-wide-expected.png: Added.
  • platform/mac/fast/block/float/narrow-after-wide-expected.txt: Added.
10:44 AM Changeset in webkit [30550] by mitz@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Darin Adler.

  • wtf/Deque.h: (WTF::::expandCapacityIfNeeded): Fixed the case where m_start and m_end are both zero but the buffer capacity is non-zero. (WTF::::prepend): Added validity checks.
12:30 AM Changeset in webkit [30549] by Darin Adler
  • 21 edits
    3 adds in trunk

WebCore:

Reviewed by Sam.

Disentangle global history updating from the back/forward history.
There are many cases where we don't want to create a new back/forward
item, but we do still want to add to the global history (used for visited
link coloring) in those cases.

Test: fast/history/subframe-is-visited.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::updateGlobalHistory): Renamed from addHistoryForCurrentLocation and removed the back/forward handling. (WebCore::FrameLoader::updateHistoryForStandardLoad): Streamlined logic a bit. Replaced call to addHistoryForCurrentLocation with a call to addBackForwardItemClippedAtTarget. Added an unconditional call to updateGlobalHistory. (WebCore::FrameLoader::updateHistoryForClientRedirect): Added a FIXME; why doesn't this function update global history? (WebCore::FrameLoader::updateHistoryForBackForwardNavigation): Ditto. (WebCore::FrameLoader::updateHistoryForReload): Replaced the direct call the client with a call to the new updateGlobalHistory function. (WebCore::FrameLoader::updateHistoryForRedirectWithLockedHistory): Did the same changes as for updateHistoryForStandardLoad.
  • loader/FrameLoader.h: More of the same.
  • loader/FrameLoaderClient.h: Removed updateGlobalHistoryForReload and renamed updateGlobalHistoryForStandardLoad to updateGlobalHistory.
  • svg/graphics/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::updateGlobalHistory): Updated to match the above.

WebKit/gtk:

Reviewed by Sam.

  • remove separate client calls for "standard" and "reload' history
  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::updateGlobalHistory):
  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

Reviewed by Sam.

  • remove separate client calls for "standard" and "reload' history
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::updateGlobalHistory):

WebKit/qt:

Reviewed by Sam.

  • remove separate client calls for "standard" and "reload' history
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::updateGlobalHistory):
  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

Reviewed by Sam.

  • remove separate client calls for "standard" and "reload' history
  • WebFrame.cpp: (WebFrame::updateGlobalHistory):
  • WebFrame.h:

WebKit/wx:

Reviewed by Sam.

  • remove separate client calls for "standard" and "reload' history
  • WebKitSupport/FrameLoaderClientWx.cpp: (WebCore::FrameLoaderClientWx::updateGlobalHistory):
  • WebKitSupport/FrameLoaderClientWx.h:

LayoutTests:

Reviewed by Sam.

  • fast/history/resources/subframe.html: Added.
  • fast/history/subframe-is-visited-expected.txt: Added.
  • fast/history/subframe-is-visited.html: Added.
12:09 AM Changeset in webkit [30548] by Darin Adler
  • 2 edits in trunk/WebKit/qt
  • another try at fixing the build
  • Api/qwebframe.cpp: (QWebFrame::load): Replace new FormData with FormData::create.

Feb 23, 2008:

11:55 PM Changeset in webkit [30547] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::submit): Restore the old logic, with its unpleasant trip through String do to the replace operation. It's inefficient, but there's no real reason to worry about the efficiency of mailto forms, since that feature is nearly obsolete.
11:36 PM Changeset in webkit [30546] by Darin Adler
  • 3 edits in trunk/WebCore

Reviewed by Sam.

  • replace SegmentedString's use of DeprecatedValueList with Deque

Testing indicates this is a slight speed-up for page loading.

  • platform/text/SegmentedString.cpp: (WebCore::SegmentedString::length): Update to use Deque. (WebCore::SegmentedString::setExcludeLineNumbers): Ditto. (WebCore::SegmentedString::append): Ditto. (WebCore::SegmentedString::prepend): Ditto. (WebCore::SegmentedString::advanceSubstring): Ditto. (WebCore::SegmentedString::toString): Ditto.
  • platform/text/SegmentedString.h: Tweak formatting. Don't bother making an entire class private with a single friend. Change m_sbstrings from a DeprecatedValueList to a Deque.
11:26 PM Changeset in webkit [30545] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Anders.

  • loader/TextResourceDecoder.cpp: (WebCore::findTextEncoding): Fix off-by-one in code that null-terminates the C string here.
11:10 PM Changeset in webkit [30544] by pewtermoose@webkit.org
  • 3 edits in trunk/WebCore

Not reviewed, build fix.

  • platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::httpBodyFromRequest):
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::handlePost):
11:07 PM Changeset in webkit [30543] by mitz@apple.com
  • 3 edits in trunk/WebCore
  • fix a typo
  • platform/graphics/win/GlyphPageTreeNodeCGWin.cpp: (WebCore::GlyphPage::fill):
  • platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp: (WebCore::GlyphPage::fill):
11:07 PM Changeset in webkit [30542] by pewtermoose@webkit.org
  • 6 edits in trunk

2008-02-23 Jan Michael Alonzo <​jmalonzo@unpluggable.com>
.:

Rubber stamped by Darin.

Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
whitespaces introduced in the previous commit.

  • GNUmakefile.am:

JavaScriptCore:

Rubber stamped by Darin.

Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
whitespaces introduced in the previous commit.

  • GNUmakefile.am:

WebKitTools:

Rubber stamped by Darin.

Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
whitespaces introduced in the previous commit.

  • GNUmakefile.am:
10:59 PM Changeset in webkit [30541] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Anders Carlsson.

  • fix GlyphPage::fill() logic for partial page fills
  • platform/graphics/win/GlyphPageTreeNodeCGWin.cpp: (WebCore::GlyphPage::fill): Changed the test for non-BMP characters to work correctly when the length parameter is less than a full page size. Also updated the comment.
  • platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp: (WebCore::GlyphPage::fill): Ditto.
9:42 PM Changeset in webkit [30540] by Darin Adler
  • 7 edits in trunk

.:

Rubber-stamped by Darin.

  • GNUmakefile.am: Add both GLOBALDEPS and WEBKITDEPS instead of DEPENDENCIES.
  • configure.ac: Break dependent modules into GLOBALDEPS and WEBKITDEPS.

JavaScriptCore:

  • GNUmakefile.am: Add GLOBALDEPS for testkjs and minidom.

WebKitTools:

Rubber-stamped by Darin.

  • GNUmakefile.am: Add both GLOBALDEPS and WEBKITDEPS instead of DEPENDENCIES.
9:38 PM Changeset in webkit [30539] by kevino@webkit.org
  • 5 edits
    4 adds in trunk

Move text drawing into wxcode, as we need platform-dependent APIs for drawing non-kerned text, which wx doesn't yet have.

​http://bugs.webkit.org/show_bug.cgi?id=17396

9:19 PM Changeset in webkit [30538] by Darin Adler
  • 3 edits in trunk/JavaScriptCore

Reviewed by Anders.

  • wtf/Deque.h: Wrote an all-new version of this class that uses a circular buffer. Growth policy is identical to vector. Added iterators.
  • wtf/Vector.h: Made two small refinements while using this to implement Deque: Made VectorBufferBase derive from Noncopyable, which would have saved me some debugging time if it had been there. Renamed Impl and m_impl to Buffer and m_buffer.
9:13 PM Changeset in webkit [30537] by Darin Adler
  • 2 edits in trunk/WebCore

Pointed out by Mitz.

  • loader/TextResourceDecoder.cpp: (WebCore::find): Fix a "==" that was supposed to be ">". (WebCore::findIgnoringCase): Ditto.
9:12 PM Changeset in webkit [30536] by Darin Adler
  • 2 edits in trunk/WebCore

Reviewed by Sam.

  • html/HTMLFormElement.cpp: (WebCore::appendEncodedString): Fix buffer overrun in the code I just landed.
9:04 PM Changeset in webkit [30535] by Darin Adler
  • 7 edits in trunk/WebCore

Reviewed by Sam.

  • remove all but 1 remaining use of DeprecatedCString
  • change FormData to start refcount at 1
  • html/HTMLFormElement.cpp: (WebCore::appendString): Added. Helpers for Vector<char>. (WebCore::appendEncodedString): Renamed from encodeCString and changed to append to an existing Vector<char> to cut down a bit on memory allocation. (WebCore::HTMLFormElement::formData): Replace the DeprecatedCString called enc_string with a Vector<char> called encodedData. Change to use the new FormData::create function. (WebCore::HTMLFormElement::submit): Same thing, for the mailto form code.
  • loader/TextResourceDecoder.cpp: (WebCore::find): Added. Helper for searching in char* with length. (WebCore::findIgnoringCase): Ditto. (WebCore::findTextEncoding): Added. Helper for looking up a text encoding when we have a char* with length rather than a null-terminated char*. (WebCore::findXMLEncoding): Changed to use char* and length rather than DeprecatedCString. Also fixed some things that would be one-character buffer overruns in a string that's not null-terminated. (WebCore::TextResourceDecoder::checkForCSSCharset): Change to use findTextEncoding rather than constructing a CString to pass to the TextEncodingconstructor. (WebCore::TextResourceDecoder::checkForHeadCharset): Ditto.
  • platform/network/FormData.cpp: (WebCore::FormData::FormData): Changed to start refcount at 1. (WebCore::FormData::create): Added. (WebCore::FormData::copy): Call adoptRef since refcount starts at 1.
  • platform/network/FormData.h: Made constructor private. Added create functions.
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdateResourceRequest): Call FormData::create.
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): Ditto.
9:01 PM Changeset in webkit [30534] by Darin Adler
  • 57 edits in trunk

JavaScriptCore:

Reviewed by Anders.

  • API/JSCallbackObject.h: Removed attribute arguments.
  • API/JSCallbackObjectFunctions.h: (KJS::JSCallbackObject<Base>::put): Ditto.
  • API/JSObjectRef.cpp: (JSObjectSetProperty): Use initializeVariable or putDirect when necessary to set attribute values.
  • JavaScriptCore.exp: Updated.
  • bindings/objc/objc_runtime.h: Removed attribute arguments.
  • bindings/objc/objc_runtime.mm: (ObjcFallbackObjectImp::put): Ditto.
  • bindings/runtime_array.cpp: (RuntimeArray::put): Ditto.
  • bindings/runtime_array.h: Ditto.
  • bindings/runtime_object.cpp: (RuntimeObjectImp::put): Ditto.
  • bindings/runtime_object.h: Ditto. Also removed canPut which was only called from one place in WebCore that can use hasProperty instead.
  • kjs/Activation.h: Removed attribute argument from put and added the new initializeVariable function that's used to put variables in variable objects. Also made isActivationObject a const member.
  • kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::put): Removed attribute argument. (KJS::JSGlobalObject::initializeVariable): Added. Used to give variables their initial values, which can include the read-only property. (KJS::JSGlobalObject::reset): Removed obsolete comments about flags. Removed Internal flag, which is no longer needed.
  • kjs/JSGlobalObject.h: More of the same.
  • kjs/JSVariableObject.h: Added pure virtual initializeVariable function. (KJS::JSVariableObject::symbolTablePut): Removed checkReadOnly flag; we always check read-only. (KJS::JSVariableObject::symbolTableInitializeVariable): Added.
  • kjs/array_instance.cpp: (KJS::ArrayInstance::put): Removed attribute argument.
  • kjs/array_instance.h: Ditto.
  • kjs/function.cpp: (KJS::FunctionImp::put): Ditto. (KJS::Arguments::put): Ditto. (KJS::ActivationImp::put): Ditto. (KJS::ActivationImp::initializeVariable): Added.
  • kjs/function.h: Removed attribute arguments.
  • kjs/function_object.cpp: (KJS::FunctionObjectImp::construct): Removed Internal flag.
  • kjs/lookup.h: (KJS::lookupPut): Removed attributes argument. Also changed to use putDirect instead of calling JSObject::put. (KJS::cacheGlobalObject): Ditto.
  • kjs/nodes.cpp: (KJS::ConstDeclNode::handleSlowCase): Call initializeVariable to initialize the constant. (KJS::ConstDeclNode::evaluateSingle): Ditto. (KJS::TryNode::execute): Use putDirect to set up the new object. (KJS::FunctionBodyNode::processDeclarations): Removed Internal. (KJS::ProgramNode::processDeclarations): Ditto. (KJS::EvalNode::processDeclarations): Call initializeVariable to initialize the variables and functions. (KJS::FuncDeclNode::makeFunction): Removed Internal. (KJS::FuncExprNode::evaluate): Ditto.
  • kjs/object.cpp: Removed canPut, which was only being used in one code path, not the normal high speed one. (KJS::JSObject::put): Removed attribute argument. Moved the logic from canPut here, in the one code ath that was still using it.
  • kjs/object.h: Removed Internal attribute, ad canPut function. Removed the attributes argument to the put function. Made isActivationObject const.
  • kjs/regexp_object.cpp: (KJS::RegExpImp::put): Removed attributes argument. (KJS::RegExpImp::putValueProperty): Ditto. (KJS::RegExpObjectImp::put): Ditto. (KJS::RegExpObjectImp::putValueProperty): Ditto.
  • kjs/regexp_object.h: Ditto.
  • kjs/string_object.cpp: (KJS::StringInstance::put): Removed attributes argument.
  • kjs/string_object.h: Ditto.

WebCore:

Reviewed by Anders.

  • bindings/js/JSCSSStyleDeclarationCustom.cpp: (WebCore::JSCSSStyleDeclaration::customPut): Remove attributes argument.
  • bindings/js/JSCanvasPixelArrayCustom.cpp: (WebCore::JSCanvasPixelArray::indexGetter): Use early exit idiom. (WebCore::JSCanvasPixelArray::indexSetter): Moved length check into the CanvasPixelArray object, for consistency with the getter. Removed attributes argument.
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::customPut): Removed special case for variable initialization, which is not needed since that does use put any more. Removed attributes argument.
  • bindings/js/JSEventTargetBase.h: (WebCore::JSEventTargetBase::putValueProperty): Removed attributes argument. (WebCore::JSEventTargetBase::put): Ditto. (WebCore::JSEventTargetPrototype::self): Removed Internal flag.
  • bindings/js/JSEventTargetNode.cpp: (WebCore::JSEventTargetNode::put): Removed attributes argument. (WebCore::JSEventTargetNode::putValueProperty): Ditto.
  • bindings/js/JSEventTargetNode.h: Ditto.
  • bindings/js/JSHTMLAppletElementCustom.cpp: (WebCore::JSHTMLAppletElement::customPut): Ditto.
  • bindings/js/JSHTMLEmbedElementCustom.cpp: (WebCore::JSHTMLEmbedElement::customPut): Ditto.
  • bindings/js/JSHTMLInputElementBase.cpp: (WebCore::JSHTMLInputElementBase::put): Ditto. (WebCore::JSHTMLInputElementBase::putValueProperty): Ditto.
  • bindings/js/JSHTMLInputElementBase.h: Ditto.
  • bindings/js/JSHTMLObjectElementCustom.cpp: (WebCore::JSHTMLObjectElement::customPut): Ditto.
  • bindings/js/JSHTMLOptionsCollectionCustom.cpp: (WebCore::JSHTMLOptionsCollection::indexSetter): Ditto.
  • bindings/js/JSHTMLSelectElementCustom.cpp: (WebCore::JSHTMLSelectElement::indexSetter): Ditto.
  • bindings/js/JSHistoryCustom.cpp: (WebCore::JSHistory::customPut): Ditto.
  • bindings/js/JSLocation.cpp: (WebCore::JSLocation::put): Ditto.
  • bindings/js/JSLocation.h: Ditto.
  • bindings/js/JSXMLHttpRequest.cpp: (WebCore::JSXMLHttpRequest::put): Ditto. (WebCore::JSXMLHttpRequest::putValueProperty): Ditto.
  • bindings/js/JSXMLHttpRequest.h: Ditto.
  • bindings/js/kjs_dom.cpp: (WebCore::getRuntimeObject): Changed return type to JSObject*.
  • bindings/js/kjs_dom.h: Ditto.
  • bindings/js/kjs_events.cpp: (WebCore::JSClipboard::put): Removed attributes argument. (WebCore::JSClipboard::putValueProperty): Ditto.
  • bindings/js/kjs_events.h: Ditto.
  • bindings/js/kjs_html.cpp: (WebCore::runtimeObjectGetter): Updated for change to getRuntimeObject to return a JSObject. Used early exit idiom. (WebCore::runtimeObjectPropertyGetter): Ditto. (WebCore::runtimeObjectCustomGetOwnPropertySlot): Ditto. (WebCore::runtimeObjectCustomPut): Use hasProperty to check for properties that we should put with the property syntax instead of canPut. (WebCore::runtimeObjectImplementsCall): Ditto. (WebCore::runtimeObjectCallAsFunction): Ditto.
  • bindings/js/kjs_html.h: Removed attributes argument to runtimeObjectCustomPut.
  • bindings/js/kjs_window.cpp: (KJS::Window::put): Removed attributes argument.
  • bindings/js/kjs_window.h: Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Removed attributes argument from put, putValueProperty, customPut, and indexSetter.
  • html/CanvasPixelArray.h: (WebCore::CanvasPixelArray::set): Added index checking here, as in the get function. Before, the checking was done in the JavaScript bindings for set.
8:15 PM Changeset in webkit [30533] by pewtermoose@webkit.org
  • 7 edits in trunk/WebCore

2008-02-23 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Adam and Darin.

​http://bugs.webkit.org/show_bug.cgi?id=17442
Correct the Windows Cairo implementation of GraphicsContext so
that Windows 'WorldTransform' is kept in sync with the Cairo
transormations.

Also corrects an uninitialized variable in the Cairo Windows
image drag handler.

WARNING: NO TEST CASES ADDED OR CHANGED

  • platform/graphics/cairo/GraphicsContextCairo.cpp: Modify methods to call GraphicsContextPlatformPrivate calls, just as is done for the CoreGraphics version. These calls are nop's for everything but Windows. (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::concatCTM): Re-enable for Windows (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale):
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  • platform/graphics/win/GraphicsContextCGWin.cpp: Move common code for handling WorldTransform calls to parent class.
  • platform/graphics/win/GraphicsContextCairoWin.cpp: Add common code for handling WorldTransform calls. (WebCore::GraphicsContextPlatformPrivate::concatCTM): Change implementation so that it only handles WorldTransform. The Cairo update is done in GraphicsContextCairo.cpp
  • platform/graphics/win/GraphicsContextWin.cpp: Call platform-private methods to keep WorldTransform in sync. (WebCore::GraphicsContextPlatformPrivate::save): (WebCore::GraphicsContextPlatformPrivate::restore): (WebCore::GraphicsContextPlatformPrivate::clip): (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate):
  • platform/win/DragImageCairoWin.cpp: (WebCore::createDragImageFromImage): Correct uninitialized value
8:10 PM Changeset in webkit [30532] by pewtermoose@webkit.org
  • 3 edits in trunk/WebKit/win

2008-02-23 Brent Fulgham <​bfulgham@gmail.com>

Not reviewed, build fix.

  • WebIconDatabase.cpp:
  • WebIconDatabase.h:
8:05 PM Changeset in webkit [30531] by pewtermoose@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-02-23 Jan Michael Alonzo <​jmalonzo@unpluggable.com>

Not reviewed, Gtk build fix.

  • kjs/testkjs.pro:
8:00 PM Changeset in webkit [30530] by mitz@apple.com
  • 5 edits
    5 adds in trunk

WebCore:

Reviewed by Dave Hyatt.

  • make non-autowrapping text clear floats

Test: fast/text/whitespace/nowrap-clear-float.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::nextFloatBottomBelow): Renamed nearestFloat() to this and changed to avoid comparing bottom to 0 in each iteration. (WebCore::RenderBlock::getClearDelta): Updated comment for the rename.
  • rendering/RenderBlock.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::fitBelowFloats): Added. Factored out of findNextLineBreak() and simplified. (WebCore::RenderBlock::findNextLineBreak): Changed to call fitBelowFloats(). Fixed the bug by trying to fit below floats in the case of non-wrapping text. Removed some redundancy.

LayoutTests:

Reviewed by Dave Hyatt.

  • test that non-autowrapping text clear floats
  • fast/text/whitespace/nowrap-clear-float.html: Added.
  • platform/mac-leopard/fast/text/whitespace: Added.
  • platform/mac-leopard/fast/text/whitespace/nowrap-clear-float-expected.checksum: Added.
  • platform/mac-leopard/fast/text/whitespace/nowrap-clear-float-expected.png: Added.
  • platform/mac/fast/text/whitespace/nowrap-clear-float-expected.txt: Added.
5:35 PM Changeset in webkit [30529] by weinig@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Oliver Hunt.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=17504
Speed up DOM lists array subscription syntax by using the fast
getOwnPropertySlot and set paths

  • 6x speed improvement on Oliver's ImageData put test.
  • bindings/scripts/CodeGeneratorJS.pm: Add fast path for getOwnPropertySlot and put when an indexGetter or indexSetter is used. We can not use the fast path if an overridingNameGetter is used as there would be no way to override.
5:33 PM Changeset in webkit [30528] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix after JSImageData.cpp was added.

1:52 PM Changeset in webkit [30527] by ap@webkit.org
  • 4 edits
    1 delete in trunk

Windows build fix - move ThreadCondition implementation from WebCore to WTF.

1:04 PM BuildingGtk edited by lethalman88@gmail.com
(diff)
12:49 PM Changeset in webkit [30526] by ap@webkit.org
  • 6 edits in trunk

Build fix.

JavaScriptCore:

Touch some files, hoping that Windows build bot will create JSC headers.

  • kjs/AllInOneFile.cpp:
  • kjs/array_instance.cpp:
  • wtf/HashTable.cpp:

WebKit/gtk:

  • webkit/webkitprivate.cpp: (webkit_init): Renamed initializeThreading to initializeThreadingAndMainThread.
12:29 PM Changeset in webkit [30525] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Qt/Wx build fix - this file was still in a wrong namespace, too.

  • wtf/ThreadingNone.cpp:
12:21 PM Changeset in webkit [30524] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

More build fixing - fix mismatched braces.

12:10 PM Changeset in webkit [30523] by ap@webkit.org
  • 3 edits in trunk/JavaScriptCore

Wx and Gtk build fixes.

  • JavaScriptCore.pri: Don't try to compile ThreadingPthreads.
  • wtf/ThreadingGtk.cpp: Use a correct namespace.
11:50 AM Changeset in webkit [30522] by ap@webkit.org
  • 37 edits
    4 copies
    9 moves
    5 adds
    2 deletes in trunk

2008-02-23 Alexey Proskuryakov <​ap@webkit.org>

Reviewed by Darin.

Move basic threading support from WebCore to WTF.

10:54 AM Changeset in webkit [30521] by ddkilzer@apple.com
  • 1 edit in trunk/WebCore/bindings/js/JSCSSStyleDeclarationCustom.cpp

Fix typo in comment.

9:08 AM Changeset in webkit [30520] by ddkilzer@apple.com
  • 14 edits
    1 add in trunk

WebCore:

Please clarify licensing for some files
<​http://bugs.webkit.org/show_bug.cgi?id=14970>

Reviewed by Darin.

  • bindings/objc/WebScriptObject.h: Added Apple BSD-style license.
  • bindings/objc/WebScriptObjectPrivate.h: Ditto.
  • platform/text/mac/ShapeArabic.c: Added ICU license from WebCore/icu/LICENSE.

WebKit/mac:

Please clarify licensing for some files
<​http://bugs.webkit.org/show_bug.cgi?id=14970>

Reviewed by Darin.

  • Plugins/WebNetscapeDeprecatedFunctions.c: Updated copyright statement and added Apple BSD-style license.
  • Plugins/WebNetscapeDeprecatedFunctions.h: Ditto.

WebKitTools:

Please clarify licensing for some files
<​http://bugs.webkit.org/show_bug.cgi?id=14970>

Reviewed by Darin.

  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp: Added copyright statement. Replaced license with newer Apple BSD-style license.
  • DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: Ditto.
  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.cpp: Ditto.
  • DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h: Ditto.
  • DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: Ditto.
  • DumpRenderTree/win/TestNetscapePlugin/main.c: Ditto.
  • mangleme/LICENSE: Added (LGPL).
12:09 AM Changeset in webkit [30519] by mitz@apple.com
  • 2 edits in trunk/LayoutTests
  • undo an accidental change to a test's expected results from r30431.
  • fast/js/date-DST-time-cusps-expected.txt:
12:03 AM Changeset in webkit [30518] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Sam Weinig and Anders Carlsson.

  • updated results for <rdar://problem/5714333> Add document.getSelection()
  • fast/dom/Window/window-properties-expected.txt:

Feb 22, 2008:

11:52 PM Changeset in webkit [30517] by ap@webkit.org
  • 8 edits in trunk/LayoutTests

Reviewed by Darin.

A few tweaks to PCRE-based regex test suite.

  • fast/regex/pcre-test-runner.js: Added support for global regexes. Emulate PCRE test runner more precisely by trimming trailing whitespace from some lines.
  • fast/regex/test1-expected.txt:
  • fast/regex/test4-expected.txt:
  • fast/regex/testinput1:
  • fast/regex/testinput4:
  • fast/regex/testoutput1:
  • fast/regex/testoutput4: Updated to PCRE 7.6.
11:46 PM Changeset in webkit [30516] by mitz@apple.com
  • 30 edits in trunk/LayoutTests
  • update Tiger expected results following r30431
  • platform/mac-tiger/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • platform/mac-tiger/svg/custom/foreignObject-crash-on-hover-expected.txt:
  • platform/mac-tiger/svg/custom/text-dom-01-f-expected.txt:
  • platform/mac-tiger/svg/custom/text-hit-test-expected.txt:
  • platform/mac-tiger/svg/text/text-align-01-b-expected.txt:
  • platform/mac-tiger/svg/text/text-align-02-b-expected.txt:
  • platform/mac-tiger/svg/text/text-align-03-b-expected.txt:
  • platform/mac-tiger/svg/text/text-align-04-b-expected.txt:
  • platform/mac-tiger/svg/text/text-align-05-b-expected.txt:
  • platform/mac-tiger/svg/text/text-align-06-b-expected.txt:
  • platform/mac-tiger/svg/text/text-altglyph-01-b-expected.txt:
  • platform/mac-tiger/svg/text/text-deco-01-b-expected.txt:
  • platform/mac-tiger/svg/text/text-fonts-01-t-expected.txt:
  • platform/mac-tiger/svg/text/text-fonts-02-t-expected.txt:
  • platform/mac-tiger/svg/text/text-path-01-b-expected.txt:
  • platform/mac-tiger/svg/text/text-spacing-01-b-expected.txt:
  • platform/mac-tiger/svg/text/text-text-01-b-expected.txt:
  • platform/mac-tiger/svg/text/text-text-03-b-expected.txt:
  • platform/mac-tiger/svg/text/text-text-04-t-expected.txt:
  • platform/mac-tiger/svg/text/text-text-05-t-expected.txt:
  • platform/mac-tiger/svg/text/text-text-06-t-expected.txt:
  • platform/mac-tiger/svg/text/text-text-07-t-expected.txt:
  • platform/mac-tiger/svg/text/text-text-08-b-expected.txt:
  • platform/mac-tiger/svg/text/text-tref-01-b-expected.txt:
  • platform/mac-tiger/svg/text/text-tselect-01-b-expected.txt:
  • platform/mac-tiger/svg/text/text-tselect-02-f-expected.txt:
  • platform/mac-tiger/svg/text/text-tspan-01-b-expected.txt:
  • platform/mac-tiger/svg/text/text-ws-01-t-expected.txt:
  • platform/mac-tiger/svg/text/text-ws-02-t-expected.txt:
9:14 PM Changeset in webkit [30515] by justin.garcia@apple.com
  • 5 edits
    2 adds in trunk

WebCore:

Reviewed by Anders Carlsson.

<rdar://problem/5714333> Add document.getSelection()


Add a synonym for window.getSelection() that FF supports. There were requests in
this bugs dupes to also support the IE only document.selection, but IE's Selection
object is too different than ours currently for that to be safe (specifically, we
don't support enough of IE's TextRange methods on our DOM Range object yet). I
filed <rdar://problem/5761233> to cover that.

  • dom/Document.cpp: (WebCore::Document::getSelection): Added.
  • dom/Document.h:
  • dom/Document.idl: Ditto. JS only since this is about web compatibility.

LayoutTests:

Reviewed by Anders.


<rdar://problem/5714333> Add document.getSelection()

  • editing/selection/5714333-expected.txt: Added.
  • editing/selection/5714333.html: Added.
9:09 PM Changeset in webkit [30514] by oliver@apple.com
  • 2 edits in trunk/WebCore

WX build fixes

8:18 PM Changeset in webkit [30513] by mrowe@apple.com
  • 7 edits in trunk/WebCore

Roll out r30500 as it breaks non-Windows use of Cairo.

7:31 PM Changeset in webkit [30512] by oliver@apple.com
  • 4 edits in trunk/WebCore

Once more with the cairo/qt/wx build fixing

7:09 PM Changeset in webkit [30511] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Windows build fix. Add missing include of DeprecatedCString.h and sort existing includes.

7:03 PM Changeset in webkit [30510] by mrowe@apple.com
  • 3 edits in trunk/WebCore

Speculative Windows build fix. Add missing include of DeprecatedCString.h and sort existing includes.

6:15 PM Changeset in webkit [30509] by oliver@apple.com
  • 2 edits in trunk/WebCore

Build fix for windows, wx and qt

6:04 PM Changeset in webkit [30508] by oliver@apple.com
  • 2 edits in trunk/WebCore

Reviewed by NOBODY (build fix).

Unbreak windows vcproj

  • WebCore.vcproj/WebCore.vcproj:
5:27 PM Changeset in webkit [30507] by weinig@apple.com
  • 2 edits in trunk/WebKit/qt

Fix Qt build.

  • Api/qwebhistoryinterface.cpp:
5:16 PM Changeset in webkit [30506] by oliver@apple.com
  • 19 edits
    12 adds in trunk

Bug 17486: Support HTML5 Canvas.getImageData API
Support Canvas.getImageData and Canvas.createImageData

Reviewed by Sam W.

This patch adds support for all the pixel reading portions
of the HTML5 Canvas spec. There are two new types ImageData
and CanvasPixelArray which are used to provide the HTML5
ImageData object, and the required semantics for assignment
to the ImageData data array.

We only implement the CG version of ImageBuffer::getImageData,
but the logic is null safe, so this will not introduce any
crashes into other platforms, unfortunately it will result in
JS Object detection "lying" on non-CG platforms.

5:14 PM Changeset in webkit [30505] by mrowe@apple.com
  • 4 edits in tags/Safari-5525.11.1

Versioning.

5:14 PM Changeset in webkit [30504] by mrowe@apple.com
  • 2 edits in tags/Safari-5525.11.1/WebCore

Merge r30502.

5:07 PM Changeset in webkit [30503] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.11.1

New tag.

5:06 PM Changeset in webkit [30502] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

2008-02-22 Mark Rowe <​mrowe@apple.com>

Build fix.

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send): Qualify references to symbols in the KJS namespace.
4:55 PM Changeset in webkit [30501] by weinig@apple.com
  • 32 edits
    4 deletes in trunk

WebCore:

Rubber-stamped by Adam Roben.

Rid the project of the Devil known as DeprecatedString!

  • GNUmakefile.am:
  • WebCore.base.exp:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • dom/Node.h:
  • html/HTMLFormElement.cpp:
  • platform/DeprecatedString.cpp: Removed.
  • platform/DeprecatedString.h: Removed.
  • platform/graphics/qt/IconQt.cpp:
  • platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp:
  • platform/gtk/CookieJarGtk.cpp:
  • platform/gtk/CursorGtk.cpp:
  • platform/gtk/KeyEventGtk.cpp:
  • platform/mac/DeprecatedStringMac.mm: Removed.
  • platform/network/qt/ResourceHandleQt.cpp:
  • platform/network/win/CookieJarWin.cpp: (WebCore::cookies):
  • platform/qt/ClipboardQt.cpp:
  • platform/qt/CookieJarQt.cpp:
  • platform/qt/CursorQt.cpp:
  • platform/symbian/DeprecatedStringSymbian.cpp: Removed.
  • platform/text/AtomicString.cpp:
  • platform/text/AtomicString.h:
  • platform/text/PlatformString.h:
  • platform/text/String.cpp:
  • platform/text/StringImpl.cpp:
  • platform/text/qt/StringQt.cpp: (WebCore::String::String):
  • platform/text/wx/StringWx.cpp:
  • platform/win/BString.cpp:
  • platform/win/BString.h:
  • platform/win/PasteboardWin.cpp:

WebKit/qt:

Rubber-stamped by Adam Roben.

Rid the project of the Devil known as DeprecatedString!

  • Api/qwebhistory.cpp:
  • Api/qwebhistoryinterface.cpp:
4:23 PM Changeset in webkit [30500] by pewtermoose@webkit.org
  • 7 edits in trunk/WebCore

2008-02-22 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Adam Roben.

​http://bugs.webkit.org/show_bug.cgi?id=17442
Correct the Windows Cairo implementation of GraphicsContext so
that Windows 'WorldTransform' is kept in sync with the Cairo
transformations.

Also corrects an uninitialized variable in the Cairo Windows
image drag handler.

  • platform/graphics/cairo/GraphicsContextCairo.cpp: Modify methods to call GraphicsContextPlatformPrivate calls, just as is done for the CoreGraphics version. These calls are nop's for everything but Windows. (WebCore::GraphicsContext::savePlatformState): (WebCore::GraphicsContext::restorePlatformState): (WebCore::GraphicsContext::clip): (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): (WebCore::GraphicsContext::translate): (WebCore::GraphicsContext::concatCTM): Re-enable for Windows (WebCore::GraphicsContext::beginTransparencyLayer): (WebCore::GraphicsContext::endTransparencyLayer): (WebCore::GraphicsContext::rotate): (WebCore::GraphicsContext::scale):
  • platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
  • platform/graphics/win/GraphicsContextCGWin.cpp: Move common code for handling WorldTransform calls to parent class.
  • platform/graphics/win/GraphicsContextCairoWin.cpp: Add common code for handling WorldTransform calls. (WebCore::GraphicsContextPlatformPrivate::concatCTM): Change implementation so that it only handles WorldTransform. The Cairo update is done in GraphicsContextCairo.cpp
  • platform/graphics/win/GraphicsContextWin.cpp: Call platform-private methods to keep WorldTransform in sync. (WebCore::GraphicsContextPlatformPrivate::save): (WebCore::GraphicsContextPlatformPrivate::restore): (WebCore::GraphicsContextPlatformPrivate::clip): (WebCore::GraphicsContextPlatformPrivate::scale): (WebCore::GraphicsContextPlatformPrivate::rotate): (WebCore::GraphicsContextPlatformPrivate::translate):
  • platform/win/DragImageCairoWin.cpp: (WebCore::createDragImageFromImage): Correct uninitialized value
4:16 PM Changeset in webkit [30499] by weinig@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Geoff Garen.

  • Remove use of DeprecatedString in CSSStyleSelector.
  • css/CSSStyleSelector.cpp: (WebCore::findHash): Removed. Use find instead. (WebCore::findSlashDotDotSlash): Changed to take a UChar* and a length. (WebCore::findSlashSlash): Ditto. (WebCore::findSlashDotSlash): Ditto. (WebCore::containsColonSlashSlash): Ditto. (WebCore::cleanPath): Change to operate on a String. (WebCore::checkPseudoState): Changed to use a Vector as a buffer.
3:51 PM Changeset in webkit [30498] by mrowe@apple.com
  • 4 edits in branches/Safari-3-1-branch

Versioning.

3:50 PM Changeset in webkit [30497] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.11

New tag.

3:49 PM Changeset in webkit [30496] by mrowe@apple.com
  • 4 edits in branches/Safari-3-1-branch

Versioning.

3:39 PM Changeset in webkit [30495] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30493.

3:39 PM Changeset in webkit [30494] by mrowe@apple.com
  • 5 edits
    2 deletes in branches/Safari-3-1-branch

Merge r30492.

3:16 PM Changeset in webkit [30493] by ggaren@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Sam Weinig.


Fixed <rdar://problem/5057509> Repro leak of JSXMLHttpRequest and
associated objects @ www.viamichelin.it, which was probably an underlying
cause of <rdar://problem/5744037> Gmail out of memory (17455)


If SubresourceLoader::create returned NULL, we would ref() / gcProtect()
the XMLHttpRequest but think we hadn't, therefore never
calling deref() / gcUnprotect().


This could happen at gmail.com, since gmail.com attempts to send
XMLHttpRequests from unload handlers in order to gather usage statistics.
(According to comments in the code, SubresourceLoader::create returns
NULL when called from an unload handler.)

The solution is to ref() / gcProtect() only if SubresourceLoader::create
doesn't return NULL. This make sense, since we only need to protect the
request as long as it has an outstanding network transaction.


  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::XMLHttpRequest): (WebCore::XMLHttpRequest::send):
3:16 PM Changeset in webkit [30492] by ggaren@apple.com
  • 5 edits
    2 deletes in trunk

JavaScriptCore:

Reviewed by Sam Weinig.


Partial fix for <rdar://problem/5744037> Gmail out of memory (17455)


I'm removing KJS_MEM_LIMIT for the following reasons:


  • We have a few reports of KJS_MEM_LIMIT breaking important web applications, like GMail and Google Reader. (For example, if you simply open 12 GMail tabs, tab #12 will hit the limit.)
  • Firefox has no discernable JS object count limit, so any limit, even a large one, is a potential compatibility problem.


  • KJS_MEM_LIMIT does not protect against malicious memory allocation, since there are many ways to maliciously allocate memory without increasing the JS object count.


  • KJS_MEM_LIMIT is already mostly broken, since it only aborts the script that breaches the limit, not any subsequent scripts.


  • We've never gotten bug reports about websites that would have benefited from an unbroken KJS_MEM_LIMIT. The initial check-in of KJS_MEM_LIMIT (KJS revision 80061) doesn't mention a website that needed it.


  • Any website that brings you anywhere close to crashing due to the number of live JS objects will almost certainly put up the "slow script" dialog at least 20 times beforehand.
  • kjs/collector.cpp: (KJS::Collector::collect):
  • kjs/collector.h:
  • kjs/nodes.cpp: (KJS::TryNode::execute):

LayoutTests:

Reviewed by Sam Weinig.


Removing the test for KJS_MEM_LIMIT, since I removed KJS_MEM_LIMIT.

  • fast/js/out-of-memory-expected.txt: Removed.
  • fast/js/out-of-memory.html: Removed.
3:02 PM Changeset in webkit [30491] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30489.

3:00 PM BuildingCairoOnWindows edited by bfulgham@macports.org
(diff)
2:30 PM Changeset in webkit [30490] by weinig@apple.com
  • 7 edits in trunk/WebCore

Reviewed, tweaked and landed by Sam.

  • Make RegularExpression operate on Strings instead of DeprecatedStrings.
  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::isXMLMIMEType): Use string instead of DeprecatedString to build up the RegularExpression.
  • page/Frame.cpp: (WebCore::createRegExpForLabels): Use String instead of DeprecatedString. (WebCore::Frame::searchForLabelsAboveCell): Ditto. (WebCore::Frame::searchForLabelsBeforeElement): Ditto. (WebCore::Frame::matchLabelsAgainstElement): Ditto.
  • page/Frame.h:
  • page/mac/FrameMac.mm: (WebCore::regExpForLabels): Ditto. (WebCore::Frame::searchForNSLabelsAboveCell): Ditto. (WebCore::Frame::searchForLabelsBeforeElement): Ditto. (WebCore::Frame::matchLabelsAgainstElement): Ditto.
  • platform/text/RegularExpression.cpp: (WebCore::RegularExpression::Private::Private): (WebCore::RegularExpression::Private::compile): (WebCore::RegularExpression::RegularExpression): (WebCore::RegularExpression::operator=): (WebCore::RegularExpression::pattern): (WebCore::RegularExpression::match): (WebCore::RegularExpression::search): (WebCore::RegularExpression::searchRev): (WebCore::replace): Added.
  • platform/text/RegularExpression.h: Change functions to take Strings as input instead of DeprecatedStrings and reduce the complexity of the class by removing unneeded globbing support.
2:15 PM Changeset in webkit [30489] by jhoneycutt@apple.com
  • 2 edits in trunk/WebCore

2008-02-22 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Anders.

<rdar://problem/5760360> REGRESSION(r30376): Crash loading plugin page
during stress test (after only 5 min) - null dereference

Full-frame plug-ins create PluginStream objects without loaders, as the
PluginView receives the loading callbacks. We were trying to call
setDefersLoading on these null pointers.

  • plugins/PluginStream.cpp: (WebCore::PluginStream::startStream): Add null check. (WebCore::PluginStream::destroyStream): Same. (WebCore::PluginStream::deliverData): Same.
2:07 PM BuildingCairoOnWindows edited by bfulgham@macports.org
(diff)
1:39 PM Changeset in webkit [30488] by weinig@apple.com
  • 3 edits in trunk/WebCore

Reviewed and tweaked by Jon Honeycutt. Reviewed and landed by Sam.

  • Remove uses of DeprecatedString in Windows plugin code.
  • plugins/win/PluginPackageWin.cpp: (WebCore::getVersionInfo): Cleanup formatting. (WebCore::PluginPackage::freeLibraryTimerFired): Remove un-needed variable name. (WebCore::PluginPackage::storeFileVersion): Move casts. (WebCore::PluginPackage::fetchInfo): Use OwnArrayPtr and switch to more efficient use of Vectors. (WebCore::PluginPackage::load): Fix whitespace. (WebCore::PluginPackage::hash): Make the hashCodes const
  • plugins/win/PluginViewWin.cpp: (WebCore::makeURL): Use String instead of DeprecatedString. (WebCore::parseRFC822HeaderFields): Ditto. (WebCore::PluginView::handlePost): Ditto. (WebCore::PluginView::status): Ditto.
1:29 PM Changeset in webkit [30487] by timothy@apple.com
  • 32 edits in branches/Safari-3-1-branch

Merge r30472.

1:16 PM Changeset in webkit [30486] by weinig@apple.com
  • 3 edits in trunk/WebCore

Reviewed, tweaked and landed by Sam.

  • Don't use DeprecatedString in HTMLTokenizer.
  • html/HTMLTokenizer.cpp: (WebCore::HTMLTokenizer::finish):
  • platform/text/PlatformString.h: (WebCore::find):
12:58 PM Changeset in webkit [30485] by Adam Roben
  • 5 edits in trunk/WebKit/win

Move hasWebView to WebFrameLoaderClient

I added an m_webFrame member to WebFrameLoaderClient. This is slightly
strange because WebFrame inherits from WebFrameLoaderClient, but this
member will be needed once we remove the inheritance, so we might as
well prepare for that now.

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::WebFrameLoaderClient): Changed to take a WebFrame* parameter. (WebFrameLoaderClient::hasWebView): Moved here from WebFrame.cpp.
  • WebCoreSupport/WebFrameLoaderClient.h: Added an m_webFrame parameter.
  • WebFrame.cpp: Removed hasWebView. (WebFrame::WebFrame): Updated for WebFrameLoaderClient constructor change.
  • WebFrame.h:
12:57 PM BuildingCairoOnWindows edited by bfulgham@macports.org
(diff)
12:21 PM Changeset in webkit [30484] by timothy@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebKitTools

Merge r30480.

12:16 PM Changeset in webkit [30483] by timothy@apple.com
  • 5 edits
    4 deletes in branches/Safari-3-1-branch

Roll out r29649.

12:05 PM Changeset in webkit [30482] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Adam.

<rdar://problem/5748781>
​https://bugs.webkit.org/show_bug.cgi?id=17413
REGRESSION: Latest Nightly doesn't load Java plugin w/Safari 3.1b


Copy the Java plug-in over to the new location.


  • FindSafari/FindSafari.cpp: (_tmain):
11:53 AM Changeset in webkit [30481] by Adam Roben
  • 4 edits
    2 adds in trunk/WebKit/win

Start to move FrameLoaderClient methods off WebFrame onto a separate class

WebFrame now inherits from a new WebFrameLoaderClient class, which
will gradually assume all FrameLoaderClient responsibilities. Once
that process is complete, WebFrame will no longer inherit from
WebFrameLoaderClient.

In this first patch, I've only moved createDocumentLoader up to the
WebFrameLoaderClient class.

Reviewed by Anders.

  • WebCoreSupport/WebFrameLoaderClient.cpp: Added. (WebFrameLoaderClient::WebFrameLoaderClient): (WebFrameLoaderClient::~WebFrameLoaderClient): (WebFrameLoaderClient::createDocumentLoader): Moved here from WebFrame.cpp.
  • WebCoreSupport/WebFrameLoaderClient.h: Added.
  • WebFrame.cpp: Removed createDocumentLoader implementation.
  • WebFrame.h: Changed to inherit from WebFrameLoaderClient.
  • WebKit.vcproj/WebKit.vcproj: Added new files to the project.
11:51 AM Changeset in webkit [30480] by andersca@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Adam.

<rdar://problem/5747325> REGRESSION: HTTP layout tests hang


  • DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Init the URL request with the correct timeout.
11:07 AM Changeset in webkit [30479] by Adam Roben
  • 3 edits
    2 adds in trunk/WebKit/win

Move FormValuesPropertyBag into its own files

Reviewed by Sam.

  • WebCoreSupport/FormValuesPropertyBag.cpp: Added. (FormValuesPropertyBag::QueryInterface): (FormValuesPropertyBag::AddRef): (FormValuesPropertyBag::Release): (FormValuesPropertyBag::Read): (FormValuesPropertyBag::Write): (FormValuesPropertyBag::CountProperties): (FormValuesPropertyBag::GetPropertyInfo): (FormValuesPropertyBag::LoadObject):
  • WebCoreSupport/FormValuesPropertyBag.h: Added. (FormValuesPropertyBag::FormValuesPropertyBag):
  • WebFrame.cpp: Deleted FormValuesPropertyBag code.
  • WebKit.vcproj/WebKit.vcproj: Added new files to the project.
11:07 AM Changeset in webkit [30478] by Adam Roben
  • 3 edits in trunk/WebKit/win

Remove some unused WebFrame methods

FrameWinClient was deleted back in r22965, but these methods were
never deleted.

Reviewed by Sam.

  • WebFrame.cpp:
  • WebFrame.h: Made one createFrame overload protected, since it's only called internally by WebFrame.
11:06 AM Changeset in webkit [30477] by Adam Roben
  • 2 edits
    10 moves
    1 add in trunk/WebKit/win

Move Client implementations into a WebCoreSupport directory

Reviewed by Anders.

  • WebKit.vcproj/WebKit.vcproj: Updated file paths, and added WebCoreSupport directory to the include path.
  • WebCoreSupport/WebChromeClient.cpp: Renamed from WebKit/win/WebChromeClient.cpp.
  • WebCoreSupport/WebChromeClient.h: Renamed from WebKit/win/WebChromeClient.h.
  • WebCoreSupport/WebContextMenuClient.cpp: Renamed from WebKit/win/WebContextMenuClient.cpp.
  • WebCoreSupport/WebContextMenuClient.h: Renamed from WebKit/win/WebContextMenuClient.h.
  • WebCoreSupport/WebDragClient.cpp: Renamed from WebKit/win/WebDragClient.cpp.
  • WebCoreSupport/WebDragClient.h: Renamed from WebKit/win/WebDragClient.h.
  • WebCoreSupport/WebEditorClient.cpp: Renamed from WebKit/win/WebEditorClient.cpp.
  • WebCoreSupport/WebEditorClient.h: Renamed from WebKit/win/WebEditorClient.h.
  • WebCoreSupport/WebInspectorClient.cpp: Renamed from WebKit/win/WebInspectorClient.cpp.
  • WebCoreSupport/WebInspectorClient.h: Renamed from WebKit/win/WebInspectorClient.h.
10:32 AM Changeset in webkit [30476] by sullivan@apple.com
  • 4 edits in trunk/WebKit/mac

Reviewed by Adam Roben


Reverted the changed from yesterday to add pasteAndMatchStyle:, as the existing
pasteAsPlainText: has the same behavior.

  • WebView/WebHTMLView.mm: (-[WebHTMLView _pasteWithPasteboard:allowPlainText:]): (-[WebHTMLView readSelectionFromPasteboard:]): (-[WebHTMLView validateUserInterfaceItemWithoutDelegate:]): (-[WebHTMLView pasteAsRichText:]): (-[WebHTMLView paste:]):
  • WebView/WebView.mm:
  • WebView/WebViewPrivate.h:
2:27 AM Changeset in webkit [30475] by oliver@apple.com
  • 5 edits in trunk

<rdar://problem/5759327> REGRESSION: while(NaN) acts like while(true)

Reviewed by Alexey P.

Fix yet another case where we incorrectly relied on implicit double
to bool coercion.

Note: See TracTimeline for information about the timeline view.