⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 28, 2008:

11:54 PM Changeset in webkit [30657] by mrowe@apple.com
  • 4 edits in trunk/WebKitLibraries

2008-02-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Dan Bernstein.

Remove two unused functions from WebKitSystemInterface.

  • WebKitSystemInterface.h: Remove WKPreferRGB32Key and WKGetDefaultGlyphForChar as they are unused. Also remove a duplicate declaration of WKSecondsSinceLastInputEvent.
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
10:19 PM Changeset in webkit [30656] by mrowe@apple.com
  • 11 edits
    1 add in trunk

2008-02-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Dave Hyatt.

Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.

  • DerivedSources.make: Add Tiger-only symbols to the export file when running on Tiger.
  • WebCore.Tiger.exp: Added. Move Tiger-only symbol here from WebCore.base.exp.
  • WebCore.base.exp:
  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformInit): Use Leopard APIs when building on Leopard.
  • platform/mac/WebCoreSystemInterface.h: Don't declare wkGetFontMetrics on Leopard as it is unused.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.

2008-02-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Dave Hyatt.

Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.

  • WebKitSystemInterface.h: Only declare WKGetFontMetrics on Tiger.
  • libWebKitSystemInterfaceLeopard.a: Update for removal of WKGetFontMetrics.

2008-02-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Dave Hyatt.

Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Only initialize wkGetFontMetrics on Tiger.
4:50 PM Changeset in webkit [30655] by mrowe@apple.com
  • 3 edits in branches/Safari-3-1-branch/LayoutTests

Disable http/tests/security/cross-frame-access-location-put.html as postMessage support is disabled on the branch.

3:20 PM Google Summer of Code 2008 edited by Nikolas Zimmermann
(diff)
3:11 PM Changeset in webkit [30654] by pewtermoose@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Bug 16535: Stylesheets loaded with @import are not editable
​http://bugs.webkit.org/show_bug.cgi?id=16535
<rdar://problem/5712899>

Sheets loaded using @import were incorrectly being flagged as non-editable
user agent sheets because their parent sheet doesn't have an ownerNode. We now
check to make sure sheets also don't have a href before restricting their editability.

  • page/inspector/StylesSidebarPane.js:
2:52 PM Changeset in webkit [30653] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

2008-02-28 Dave Hyatt <​hyatt@apple.com>

Reviewed by Darin Adler.

Fix <rdar://problem/5771994> REGRESSION: Loading HTML5 spec is 5x slower on TOT than in 3.0.4.

Disable dynamic updating of the + selector when the DOM changes, since it hurt performance on the HTML5 spec.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkSelector):
2:24 PM Changeset in webkit [30652] by mrowe@apple.com
  • 3 edits
    4 deletes in branches/Safari-3-1-branch

Roll r29976, r29977 and r29978 out of Safari-3-1-branch.

2:16 PM Changeset in webkit [30651] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoffrey Garen.

TOTAL : 1.005x as fast 2867.6ms +/- 0.4% 2853.2ms +/- 0.3% significant

  • kjs/nodes.cpp: Tell the compiler that exceptions are unexpected (for the sake of branch prediction and code organization).
12:46 PM Changeset in webkit [30650] by pewtermoose@webkit.org
  • 9 edits
    1 copy in trunk/WebCore

2008-02-28 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Adam Roben.

Copy PluginPackageWin.cpp to shared PluginPackage.cpp.
Add PluginPackage.cpp to build configurations.
Remove PluginPackage destructor from TemporaryLinkStubs.cpp.
Use cross-platform pathGetFilename method.
Remove platform-specific code from shared PluginPackage implementation.
Remove shared code from PluginPackageWin.cpp.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCoreSources.bkl:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/gtk/TemporaryLinkStubs.cpp:
  • platform/qt/TemporaryLinkStubs.cpp:
  • platform/wx/TemporaryLinkStubs.cpp:
  • plugins/PluginPackage.cpp:
  • plugins/win/PluginPackageWin.cpp:
12:42 PM Changeset in webkit [30649] by justin.garcia@apple.com
  • 32 edits
    8 adds
    6 deletes in trunk

WebCore:

Reviewed by Darin Adler.

<rdar://problem/4930986> REGRESSION: Paste As Quotation pastes black text instead of blue


Add a second style span at copy time to hold document default styles. This helps us
differentiate between those and user applied styles at paste time, where we'll want
to let Mail's Paste As Quotation blockquote override document default styles, but
not others.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Changed the unit type used for -webkit-text-stroke-width from CSS_NUMBER to CSS_PX, to match other properties that are thick | medium | thin | <length>. Before, there was a mismatch between the unit type of -webkit-text-stroke-width property values in a CSSComputedStyleDeclaration for an element and that element's inlineStyleDecl(), causing identical values to always appear different to diff().
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::handlePasteAsQuotationNode): Fixed. Don't just change the class to an empty string, completely remove it, it's no longer needed. (WebCore::handleStyleSpansBeforeInsertion): Moved the optimization from doApply here. (WebCore::ReplaceSelectionCommand::handleStyleSpans): Added, replaces removeRedundantStyles. We aren't (yet) removing all redundant styles, just those on style spans, so I removed the unused code and renamed the function. There won't be more than two style spans that we need to consider, the one with the source document's default styles and styles on the commonAncestor of the copied Range, so don't look for more than two. Let elements that wrap the incoming fragment override the source document's styles. (WebCore::ReplaceSelectionCommand::doApply): Moved code to handleStyleSpansBeforeInsertion and call the renamed handleStyleSpans.
  • editing/ReplaceSelectionCommand.h:
  • editing/markup.cpp: (WebCore::removeDefaultStyles): Added. Don't add document defaults to the style span that holds user applied styles, since they'll be added to their own style span. (WebCore::createMarkup): Add a second style span that holds just the document defaults. This lets us differentiate between those and user applied styles at paste time. Mail blockquotes are just another type of special element, moved their handling there. This also lets paste code make assumptions about the position of the two style spans (they are *always* parent-child).

LayoutTests:

Reviewed by Darin Adler.


<rdar://problem/4930986> REGRESSION: Paste As Quotation pastes black text instead of blue

Demonstrates the bug:

  • editing/pasteboard/4930986-1-expected.txt: Added.
  • editing/pasteboard/4930986-1.html: Added.
  • editing/pasteboard/4930986-2-expected.txt: Added.
  • editing/pasteboard/4930986-2.html: Added.


Demonstrates a problem with the first version of the patch:

  • editing/pasteboard/4930986-3-expected.txt: Added.
  • editing/pasteboard/4930986-3.html: Added.


Visual problem fixed. An anonymous renderer changed position, DOM remains unchanged:

  • editing/execCommand/5144139-1.html:
  • platform/mac/editing/execCommand/5144139-1-expected.checksum:
  • platform/mac/editing/execCommand/5144139-1-expected.png:
  • platform/mac/editing/execCommand/5144139-1-expected.txt:

Removed unnecessary style spans, visual result unchanged:

  • platform/mac/editing/pasteboard/merge-end-blockquote-expected.checksum:
  • platform/mac/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/mac/editing/pasteboard/merge-end-blockquote-expected.txt:
  • platform/mac/editing/style/font-family-with-space-expected.checksum:
  • platform/mac/editing/style/font-family-with-space-expected.png:
  • platform/mac/editing/style/font-family-with-space-expected.txt:


A style span isn't removed because at paste time because we don't anticipate
encountering styles on style spans that are non-inheritable, because we don't
create style spans like that at copy time. Turned this into a text only
test. Test remains visually unchanged:

  • editing/pasteboard/5245519-expected.txt: Added.
  • editing/pasteboard/5245519.html:
  • platform/mac/editing/pasteboard/5245519-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/5245519-expected.png: Removed.
  • platform/mac/editing/pasteboard/5245519-expected.txt: Removed.

Added an extra empty anonymous renderer, DOM and visual result remain unchanged:

  • platform/mac/editing/execCommand/create-list-with-hr-expected.checksum:
  • platform/mac/editing/execCommand/create-list-with-hr-expected.png:
  • platform/mac/editing/execCommand/create-list-with-hr-expected.txt:
  • platform/mac/editing/pasteboard/paste-list-001-expected.checksum:
  • platform/mac/editing/pasteboard/paste-list-001-expected.png:
  • platform/mac/editing/pasteboard/paste-list-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-table-001-expected.checksum:
  • platform/mac/editing/pasteboard/paste-table-001-expected.png:
  • platform/mac/editing/pasteboard/paste-table-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-003-expected.checksum:
  • platform/mac/editing/pasteboard/paste-text-003-expected.png:
  • platform/mac/editing/pasteboard/paste-text-003-expected.txt:


Reflects changes to CSSComputedStyleDeclaration::getPropertyCSSValue:

  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:


We don't remove styles from style spans that are overridden by all of their
children, even though they are unnecessary. We've never done this, but now
that there can be two style spans at paste time we are more likely to have
a style span left over because of this problem. Mentioned this in the test
case and turned this into a text only test:

  • editing/pasteboard/4840662.html:
  • editing/pasteboard/4840662-expected.txt: Added.
  • platform/mac/editing/pasteboard/4840662-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/4840662-expected.png: Removed.
  • platform/mac/editing/pasteboard/4840662-expected.txt: Removed.
12:24 PM Changeset in webkit [30648] by pewtermoose@webkit.org
  • 3 edits in trunk/WebCore

2008-02-28 Brent Fulgham <​bfulgham@gmail.com>

​http://bugs.webkit.org/show_bug.cgi?id=17576
Modify RenderThemeWin to use SOFT_LINK

Reviewed by Adam Roben.

  • rendering/RenderThemeWin.h: Remove unneeded library handle
  • rendering/RenderThemeWin.cpp: Change to use SOFT_LINK rather than hand-coded load library calls.
10:19 AM Changeset in webkit [30647] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • page/mac/FrameMac.mm: (WebCore::Frame::matchLabelsAgainstElement): Added an early return in case the element name is empty.
1:26 AM Changeset in webkit [30646] by justin.garcia@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dan Bernstein


Small editing speed up.


  • dom/Position.cpp: (WebCore::Position::upstream): Don't check for a change in editability if the current node hasn't changed. (WebCore::Position::downstream): Ditto.
12:21 AM Changeset in webkit [30645] by alp@webkit.org
  • 2 edits in trunk

2008-02-28 Alp Toker <​alp@atoker.com>

Fix a configure script typo spotted by Kalle Vahlman.

  • configure.ac:

Feb 27, 2008:

9:38 PM Changeset in webkit [30644] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by John Sullivan.

  • fix <rdar://problem/5607547> Single letter surrounded by soft hyphens can disappear

Test: fast/text/soft-hyphen-2.html

  • rendering/bidi.cpp: (WebCore::chopMidpointsAt): Changed to iterate midpoints backwards, so that if there are two midpoints at the given position, only the last one will be chopped off.

LayoutTests:

Reviewed by John Sullivan.

  • test for <rdar://problem/5607547> Single letter surrounded by soft hyphens can disappear
  • fast/text/soft-hyphen-2.html: Added.
  • platform/mac/fast/text/soft-hyphen-2-expected.checksum: Added.
  • platform/mac/fast/text/soft-hyphen-2-expected.png: Added.
  • platform/mac/fast/text/soft-hyphen-2-expected.txt: Added.
6:52 PM Changeset in webkit [30643] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

Updated resource used in the layout test I landed yesterday.
Due to a difference between Foundation on Tiger vs Leopard, the resource generated on
Leopard caused different results on Leopard and Tiger.
Regenerating the resource on Tiger, however, agrees with Leopard.

  • webarchive/loading/resources/cache-expired-subresource.webarchive:
6:23 PM Changeset in webkit [30642] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • make centered text in right-to-left blocks spill over to the left

Test: fast/text/align-center-rtl-spill.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::computeHorizontalPositionsForLine):

LayoutTests:

Reviewed by Darin Adler.

  • test that centered text in right-to-left blocks spills over to the left
  • fast/text/align-center-rtl-spill.html: Added.
  • platform/mac/fast/text/align-center-rtl-spill-expected.checksum: Added.
  • platform/mac/fast/text/align-center-rtl-spill-expected.png: Added.
  • platform/mac/fast/text/align-center-rtl-spill-expected.txt: Added.
5:40 PM Changeset in webkit [30641] by beidson@apple.com
  • 2 edits in trunk/WebKitLibraries

Tiger build fix

  • libWebKitSystemInterfaceTiger.a:
5:06 PM Changeset in webkit [30640] by mitz@apple.com
  • 4 edits in trunk/WebCore

Reviewed by Darin Adler.

  • more bidi.cpp cleanup
  • platform/text/BidiResolver.h: (WebCore::BidiCharacterRun::destroy): Added. Overridden by BidiRun . (WebCore::BidiResolver<Iterator, Run>::addRun): Moved BidiState::addRun() here. (WebCore::BidiResolver<Iterator, Run>::appendRun): Changed to use addRun(). (WebCore::BidiResolver<Iterator, Run>::deleteRuns): Changed to use destroy(), avoiding the need to specialize this method in BidiState.
  • rendering/bidi.cpp: (WebCore::BidiRun::destroy): Removed the RenderArena parameter. (WebCore::BidiState::deleteRuns): Removed now-unnecessary specialization. (WebCore::BidiState::addRun): Removed now-unnecessary specialization. (WebCore::RenderBlock::createLineBoxes): (WebCore::RenderBlock::constructLine): (WebCore::RenderBlock::computeHorizontalPositionsForLine): Added a FIXME. (WebCore::RenderBlock::computeVerticalPositionsForLine): (WebCore::buildCompactRuns): (WebCore::RenderBlock::layoutInlineChildren): (WebCore::RenderBlock::determineStartPosition): (WebCore::RenderBlock::determineEndPosition): (WebCore::RenderBlock::matchedEndLine): (WebCore::skipNonBreakingSpace): (WebCore::RenderBlock::skipWhitespace): (WebCore::shouldSkipWhitespaceAfterStartObject):
  • rendering/bidi.h: (WebCore::BidiRun): Added m_ prefixes to several member variables.
4:52 PM Changeset in webkit [30639] by mrowe@apple.com
  • 4 edits in branches/Safari-3-1-branch

Versioning.

4:51 PM Changeset in webkit [30638] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.12

New tag.

4:42 PM Changeset in webkit [30637] by beidson@apple.com
  • 4 edits in trunk/WebKitLibraries

Reviewed by Mark Rowe

Removed some unused methods:
WKGetNSURLResponseCalculatedExpiration
WKGetNSURLResponseMustRevalidate

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
4:32 PM Changeset in webkit [30636] by mrowe@apple.com
  • 8 edits in branches/Safari-3-1-branch

Merge r30634.

4:20 PM Changeset in webkit [30635] by eric@webkit.org
  • 6891 edits in trunk/LayoutTests

Rubber-stamped by Adam.

Fix svn:eol-style on all LayoutTest results
I simply ran:
cd LayoutTests
find . -name "*-expected.txt" | xargs svn ps svn:eol-style native

3:59 PM Changeset in webkit [30634] by weinig@apple.com
  • 8 edits in trunk

WebCore:

Reviewed by Darin.

Fix for <rdar://problem/5768769>

  • Don't allow cross-origin calls using window.functionName.call(otherFrame) syntax.
  • bindings/js/JSLocation.cpp: (WebCore::jsLocationProtoFuncToString): Do same-origin check.
  • bindings/js/kjs_window.cpp: (KJS::windowProtoFuncAToB): Ditto. (KJS::windowProtoFuncBToA): Ditto. (KJS::windowProtoFuncOpen): Ditto. (KJS::windowProtoFuncClearTimeout): Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Ditto.

LayoutTests:

Reviewed by Darin.

Updates tests for <rdar://problem/5768769>

  • http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-call.html:
3:13 PM Changeset in webkit [30633] by hyatt@apple.com
  • 56 edits in trunk/WebCore

More cleanup in preparation for fixing the HTML5 spec performance regression.

Reviewed by Sam Weinig

  • dom/Attr.cpp: (WebCore::Attr::childrenChanged):
  • dom/Attr.h:
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::insertBefore): (WebCore::ContainerNode::replaceChild): (WebCore::ContainerNode::removeChild): (WebCore::ContainerNode::removeChildren): (WebCore::ContainerNode::appendChild): (WebCore::ContainerNode::addChild): (WebCore::ContainerNode::childrenChanged):
  • dom/ContainerNode.h:
  • dom/Document.cpp: (WebCore::Document::childrenChanged):
  • dom/Document.h:
  • dom/Element.cpp: (WebCore::Element::childrenChanged):
  • dom/Element.h:
  • dom/Node.h: (WebCore::Node::childrenChanged):
  • html/HTMLObjectElement.cpp: (WebCore::HTMLObjectElement::childrenChanged):
  • html/HTMLObjectElement.h:
  • html/HTMLOptGroupElement.cpp: (WebCore::HTMLOptGroupElement::childrenChanged):
  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.cpp: (WebCore::HTMLOptionElement::childrenChanged):
  • html/HTMLOptionElement.h:
  • html/HTMLScriptElement.cpp: (WebCore::HTMLScriptElement::childrenChanged):
  • html/HTMLScriptElement.h:
  • html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::childrenChanged):
  • html/HTMLSelectElement.h:
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::childrenChanged):
  • html/HTMLStyleElement.h:
  • html/HTMLTextAreaElement.cpp: (WebCore::HTMLTextAreaElement::childrenChanged):
  • html/HTMLTextAreaElement.h:
  • html/HTMLTitleElement.cpp: (WebCore::HTMLTitleElement::childrenChanged):
  • html/HTMLTitleElement.h:
  • svg/SVGClipPathElement.cpp: (WebCore::SVGClipPathElement::childrenChanged):
  • svg/SVGClipPathElement.h:
  • svg/SVGDefinitionSrcElement.cpp: (WebCore::SVGDefinitionSrcElement::childrenChanged):
  • svg/SVGDefinitionSrcElement.h:
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::childrenChanged):
  • svg/SVGFontFaceElement.h:
  • svg/SVGFontFaceFormatElement.cpp: (WebCore::SVGFontFaceFormatElement::childrenChanged):
  • svg/SVGFontFaceFormatElement.h:
  • svg/SVGFontFaceSrcElement.cpp: (WebCore::SVGFontFaceSrcElement::childrenChanged):
  • svg/SVGFontFaceSrcElement.h:
  • svg/SVGFontFaceUriElement.cpp: (WebCore::SVGFontFaceUriElement::childrenChanged):
  • svg/SVGFontFaceUriElement.h:
  • svg/SVGGElement.cpp: (WebCore::SVGGElement::childrenChanged):
  • svg/SVGGElement.h:
  • svg/SVGGradientElement.cpp: (WebCore::SVGGradientElement::childrenChanged):
  • svg/SVGGradientElement.h:
  • svg/SVGMarkerElement.cpp: (WebCore::SVGMarkerElement::childrenChanged):
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.cpp: (WebCore::SVGMaskElement::childrenChanged):
  • svg/SVGMaskElement.h:
  • svg/SVGPatternElement.cpp: (WebCore::SVGPatternElement::childrenChanged):
  • svg/SVGPatternElement.h:
  • svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::childrenChanged):
  • svg/SVGStyleElement.h:
  • svg/SVGStyledElement.cpp: (WebCore::SVGStyledElement::childrenChanged):
  • svg/SVGStyledElement.h:
  • svg/SVGTitleElement.cpp: (WebCore::SVGTitleElement::childrenChanged):
  • svg/SVGTitleElement.h:
  • svg/SVGUseElement.cpp: (WebCore::SVGUseElement::childrenChanged):
  • svg/SVGUseElement.h:
3:09 PM Changeset in webkit [30632] by beidson@apple.com
  • 5 edits
    3 adds in trunk

WebKit/mac:

Reviewed by Mark Rowe (code) and Darin (concept)

Much better fix for <rdar://problem/4930688> (see r19549)
Original fix for <rdar://problem/3947312> (and 14 dupes)


Let me tell you a story:
A long time ago, in a cvs repository far, far away, loader code was almost all up in WebKit.
WebArchive code was intertwined with that code in bizarre and complex ways.
During the months long loader re-factoring where we pushed much loader code down into WebCore,
many portions of the WebKit loader were thinned out until they ceased to exist. Others remained
with a sole purpose.

One such section of code whose lineage traces back from WebFrameLoaderClient to WebFrameLoader
to WebLoader was originally rooted in the method [WebLoader loadRequest:]. This method was the
single entry point for almost all loading (network or web archives)

This method would check various headers and other fields on the NSURLRequest and NSURLResponse
to make decisions about the load. If the cache control fields were expired or other conditions
in the headers were met, the load would be forced to go out to the network.

As the loader was moved and tweaked repeatedly, most of this code was pruned or re-factored.
At some point, all that remained was the special cases for loading WebArchives.


Somewhere in the r16,000s, this remaining responsibility was noticed and related methods we renamed
to be WebArchive specific, further cementing the assumed design.

Problem is, the design was bad. A WebArchive is meant to be a static snapshot of a WebPage at a
specific point in time. Referring to the request to see if the resource should be reloaded seems
nonsensical, as does referring to the response headers to see if the resource is "expired". In the
context of loading a WebArchive, available data should *always* be loaded from the WebArchive, at least
during the initial load!

After discovering the secret to reproducing all of these bugs is both emptying our your Foundation
cache and disconnecting your network, it was easy to reproduce the 16 individually reported cases
that were all symptoms of this bug, and easy to verify that they are fixed with this patch.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::willUseArchive): Do not call either form of "canUseArchivedResource()" that inspect the request or response objects - We are loading from a WebArchive, and we should never make the decision to go out to the network when we actually have the resource available.
  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Remove two methods that are no longer used anywhere in WebKit

LayoutTests:

Reviewed by Mark Rowe

Test for better fix for <rdar://problem/4930688> (see r19549) and
original fix for <rdar://problem/3947312> (and 14 dupes)


Crafting custom WebArchives for layout tests is a pain and something that should
be resolved if we decide to pursue a new format.

Using a custom php script to act as a stand in for an image resource, I set its
cache-control header to expire immediately. Without the fix for the above bugs,
the resource will be "expired" and an attempt to fetch it from the network will
go out and fail. This failure will manifest with different ResourceLoadDelegate
information, as well as different dimensions in the render tree - the missing
image icon versus the archived image.

With the fix in place, the response will be ignored and the image will be pulled
from the WebArchive.

  • webarchive/loading/cache-expired-subresource-expected.txt: Added.
  • webarchive/loading/cache-expired-subresource.html: Added.
  • webarchive/loading/resources/cache-expired-subresource.webarchive: Added.
3:07 PM Changeset in webkit [30631] by pewtermoose@webkit.org
  • 5 edits
    2 adds in trunk/WebKit

WebKit/mac:

Reviewed by Adam Roben.

Bug 14348: Messing up the inspector by dragging an URL into it
​http://bugs.webkit.org/show_bug.cgi?id=14348
<rdar://problem/5283620> and <rdar://problem/5712808>

  • WebCoreSupport/WebInspectorClient.mm: (-[WebInspectorWindowController init]): Remove duplicate preference setting. (-[WebInspectorWindowController webView:dragDestinationActionMaskForDraggingInfo:]):

WebKit/win:

Reviewed by Adam Roben.

Bug 14348: Messing up the inspector by dragging an URL into it
​http://bugs.webkit.org/show_bug.cgi?id=14348
<rdar://problem/5283620> and <rdar://problem/5712808>

Add a new class to handle the Inspector's delegate calls.

  • WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::createPage):
  • WebCoreSupport/WebInspectorDelegate.cpp: Added. (:m_refCount): (WebInspectorDelegate::createInstance): (WebInspectorDelegate::AddRef): (WebInspectorDelegate::Release): (WebInspectorDelegate::dragDestinationActionMaskForDraggingInfo):
  • WebCoreSupport/WebInspectorDelegate.h: Added. (WebInspectorDelegate::QueryInterface): (WebInspectorDelegate::createWebViewWithRequest): (WebInspectorDelegate::webViewShow): (WebInspectorDelegate::webViewClose): (WebInspectorDelegate::webViewFocus): (WebInspectorDelegate::webViewUnfocus): (WebInspectorDelegate::webViewFirstResponder): (WebInspectorDelegate::makeFirstResponder): (WebInspectorDelegate::setStatusText): (WebInspectorDelegate::webViewStatusText): (WebInspectorDelegate::webViewAreToolbarsVisible): (WebInspectorDelegate::setToolbarsVisible): (WebInspectorDelegate::webViewIsStatusBarVisible): (WebInspectorDelegate::setStatusBarVisible): (WebInspectorDelegate::webViewIsResizable): (WebInspectorDelegate::setResizable): (WebInspectorDelegate::setFrame): (WebInspectorDelegate::webViewFrame): (WebInspectorDelegate::setContentRect): (WebInspectorDelegate::webViewContentRect): (WebInspectorDelegate::runJavaScriptAlertPanelWithMessage): (WebInspectorDelegate::runJavaScriptConfirmPanelWithMessage): (WebInspectorDelegate::runJavaScriptTextInputPanelWithPrompt): (WebInspectorDelegate::runBeforeUnloadConfirmPanelWithMessage): (WebInspectorDelegate::runOpenPanelForFileButtonWithResultListener): (WebInspectorDelegate::mouseDidMoveOverElement): (WebInspectorDelegate::contextMenuItemsForElement): (WebInspectorDelegate::validateUserInterfaceItem): (WebInspectorDelegate::shouldPerformAction): (WebInspectorDelegate::willPerformDragDestinationAction): (WebInspectorDelegate::dragSourceActionMaskForPoint): (WebInspectorDelegate::willPerformDragSourceAction): (WebInspectorDelegate::contextMenuItemSelected): (WebInspectorDelegate::hasCustomMenuImplementation): (WebInspectorDelegate::trackCustomPopupMenu): (WebInspectorDelegate::measureCustomMenuItem): (WebInspectorDelegate::drawCustomMenuItem): (WebInspectorDelegate::addCustomMenuDrawingData): (WebInspectorDelegate::cleanUpCustomMenuDrawingData): (WebInspectorDelegate::canTakeFocus): (WebInspectorDelegate::takeFocus): (WebInspectorDelegate::registerUndoWithTarget): (WebInspectorDelegate::removeAllActionsWithTarget): (WebInspectorDelegate::setActionTitle): (WebInspectorDelegate::undo): (WebInspectorDelegate::redo): (WebInspectorDelegate::canUndo): (WebInspectorDelegate::canRedo):
  • WebKit.vcproj/WebKit.vcproj:
2:33 PM Changeset in webkit [30630] by mrowe@apple.com
  • 4 copies
    1 add in releases/Apple/Leopard/Mac OS X Update 10.5.2

Release tags for Mac OS X 10.5.2.

2:30 PM Changeset in webkit [30629] by mrowe@apple.com
  • 4 copies
    1 add in releases/Apple/Leopard/Mac OS X Update 10.5.1

Release tags for Mac OS X 10.5.1 (unchanged from Mac OS X 10.5).

2:20 PM Google Summer of Code 2008 edited by eric@webkit.org
(diff)
2:19 PM Google Summer of Code 2008 edited by eric@webkit.org
(diff)
10:06 AM Changeset in webkit [30628] by kmccullough@apple.com
  • 1 edit
    3 adds in trunk/LayoutTests

Landing test that was forgotten in the original patch (r30087).

Test for: ​http://bugs.webkit.org/show_bug.cgi?id=17191
HTML5: Client-side database queries should return values of type number

  • storage/sql-data-types-expected.txt: Added.
  • storage/sql-data-types.html: Added.
  • storage/sql-data-types.js: Added.
9:52 AM Changeset in webkit [30627] by ap@webkit.org
  • 1 edit in trunk/LayoutTests/ChangeLog

Add bug number to ChangeLog.

9:46 AM Changeset in webkit [30626] by ap@webkit.org
  • 3 edits
    2 adds in trunk

2008-02-27 Julien Chaffraix <​julien.chaffraix@gmail.com>

Reviewed by Alexey.

​http://bugs.webkit.org/show_bug.cgi?id=17481
Several consecutive calls to XMLHttpRequest::open should dispatch only one readyState event

Test: http/tests/xmlhttprequest/xmlhttprequest-multiple-open.html

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::open):
9:13 AM Changeset in webkit [30625] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig.

​http://bugs.webkit.org/show_bug.cgi?id=17030
Small buffer overflow within initialization

  • kjs/date_object.cpp: (KJS::DateObjectFuncImp::callAsFunction): (KJS::parseDate): Remove unnecessary and incorrect memset() calls - GregorianDateTime can initialize itself.
8:50 AM Changeset in webkit [30624] by ap@webkit.org
  • 2 edits in trunk/WebCore

2008-02-27 Sriram Neelakandan <​sriram.neelakandan@gmail.com>

Reviewed, tweaked and landed by ap.

​http://bugs.webkit.org/show_bug.cgi?id=17487
HTMLInput mysteriously fails to work if ICU dat file is missing

  • platform/text/TextBreakIteratorICU.cpp: (WebCore::setUpIterator): Assert that the iterator has been opened.
8:38 AM Changeset in webkit [30623] by Adam Roben
  • 2 edits in trunk/WebKit/gtk

Attempt to fix the GTK+ build

  • webkit/webkitwebframe.cpp:
8:34 AM Changeset in webkit [30622] by Adam Roben
  • 1 edit in trunk/WebCore/ChangeLog

Fix revision number in ChangeLog

8:16 AM Changeset in webkit [30621] by Adam Roben
  • 2 edits in trunk/WebCore

Windows build fix after r30613

  • platform/win/ClipboardWin.cpp:
7:12 AM Changeset in webkit [30620] by Nikolas Zimmermann
  • 2 edits in trunk/WebCore

Reviewed by Simon.

Small style cleanup, and obvious fix: SVGGElement reacted on
'clipPathUnits' changes, which is a funny copy&paste error.

4:38 AM Changeset in webkit [30619] by Nikolas Zimmermann
  • 4 edits in trunk/WebCore

Reviewed by Simon.

Cleanup coding style. Still on my way to fix dynamic updates of all SVG elements.
Currently at SVGF*. SVGDefs/DescElement don't need any dyn update fixes but cleanups.

Note: See TracTimeline for information about the timeline view.