Timeline



Mar 3, 2008:

11:48 PM Changeset in webkit [30735] by weinig@apple.com
  • 20 edits
    2 adds in trunk

WebCore:

Reviewed by Mark Rowe.

Move JSClipboard into its own file.

  • DerivedSources.make:
  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSAttrCustom.cpp:
  • bindings/js/JSClipboardCustom.cpp: Added. (WebCore::JSClipboard::types): (WebCore::JSClipboard::clearData): (WebCore::JSClipboard::getData): (WebCore::JSClipboard::setData): (WebCore::JSClipboard::setDragImage):
  • bindings/js/JSElementCustom.cpp:
  • bindings/js/JSEventCustom.cpp:
  • bindings/js/JSHTMLFrameElementCustom.cpp:
  • bindings/js/JSHTMLIFrameElementCustom.cpp:
  • bindings/js/kjs_events.cpp:
  • bindings/js/kjs_events.h:
  • bindings/js/kjs_window.cpp:
  • bindings/scripts/CodeGeneratorJS.pm:
  • dom/Clipboard.cpp: (WebCore::Clipboard::setDropEffect): (WebCore::Clipboard::setEffectAllowed):
  • dom/Clipboard.idl: Added.

LayoutTests:

Reviewed by Mark Rowe.

Update test results.

  • fast/dom/Window/window-properties-expected.txt:
11:01 PM BuildingGtk edited by Thijs Triemstra
adding mac osx section (diff)
10:25 PM WebDevelopers edited by Thijs Triemstra
(diff)
10:20 PM WebDevelopers edited by Thijs Triemstra
update wikipedia link (diff)
10:20 PM Changeset in webkit [30734] by weinig@apple.com
  • 2 edits in trunk/WebKit/gtk

GTK+ build fix.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::windowObjectCleared):
9:33 PM Changeset in webkit [30733] by weinig@apple.com
  • 2 edits in trunk/WebKit/win

Windows build fix.

  • WebFrame.cpp: (WebFrame::windowObjectCleared):
9:05 PM Changeset in webkit [30732] by weinig@apple.com
  • 3 edits in trunk/WebCore

Windows build-fix.

  • page/Chrome.cpp:
  • plugins/win/PluginViewWin.cpp:
8:12 PM WebKitFeatures edited by webkit@mattlilek.com
Make the plugin section less confusing (diff)
8:10 PM ApolloWebKit edited by Thijs Triemstra
adding info about air (diff)
8:07 PM WikiStart edited by Thijs Triemstra
renaming adobe's 'apollo' to newer 'air' (diff)
8:06 PM WikiStart edited by Thijs Triemstra
referencing new page (diff)
8:05 PM WebKitFeatures edited by Thijs Triemstra
linking plugins (diff)
8:04 PM WebKitFeatures created by Thijs Triemstra
initial page
7:48 PM New features in WebKit since Safari 2.0 edited by Thijs Triemstra
adding header (diff)
7:08 PM Changeset in webkit [30731] by weinig@apple.com
  • 35 edits in trunk/WebCore

Reviewed by Darin Adler.

Cleanup and plumbing in preparation for the great Window split.

  • Rename KJS::Window to WebCore::JSDOMWindowBase.
  • Remove KJS::Window::retrieve() and KJS::Window::retrieveWindow() and replace with the new toJSDOMWindow().
  • Remove KJS::Window::retrieveActive() and replace with explicit call to exec->dynamicGlobalObject() and toJSDOMWindow().
  • bindings/js/JSCustomVoidCallback.cpp: (WebCore::toVoidCallback):.
  • bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::create):
  • bindings/js/JSDatabaseCustom.cpp: (WebCore::JSDatabase::changeVersion): (WebCore::JSDatabase::transaction):
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::location): (WebCore::toJS):
  • bindings/js/JSEventTargetBase.cpp: (WebCore::jsEventTargetAddEventListener): (WebCore::jsEventTargetRemoveEventListener):
  • bindings/js/JSEventTargetNode.cpp: (WebCore::JSEventTargetNode::setListener):
  • bindings/js/JSHTMLDocumentCustom.cpp: (WebCore::JSHTMLDocument::nameGetter): (WebCore::JSHTMLDocument::open):
  • bindings/js/JSHTMLFrameSetElementCustom.cpp: (WebCore::JSHTMLFrameSetElement::nameGetter):
  • bindings/js/JSLocation.cpp: (WebCore::JSLocation::put): (WebCore::jsLocationProtoFuncReplace): (WebCore::jsLocationProtoFuncReload): (WebCore::jsLocationProtoFuncAssign):
  • bindings/js/JSLocation.h:
  • bindings/js/JSSQLTransactionCustom.cpp: (WebCore::JSSQLTransaction::executeSql):
  • bindings/js/JSSVGLazyEventListener.cpp: (WebCore::JSSVGLazyEventListener::JSSVGLazyEventListener): (WebCore::JSSVGLazyEventListener::eventParameterName):
  • bindings/js/JSSVGLazyEventListener.h:
  • bindings/js/JSXMLHttpRequest.cpp: (WebCore::JSXMLHttpRequest::putValueProperty): (WebCore::jsXMLHttpRequestPrototypeFunctionOpen): (WebCore::jsXMLHttpRequestPrototypeFunctionAddEventListener): (WebCore::jsXMLHttpRequestPrototypeFunctionRemoveEventListener):
  • bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::execute):
  • bindings/js/ScheduledAction.h:
  • bindings/js/kjs_binding.cpp: (WebCore::allowsAccessFromFrame): (WebCore::printErrorMessageForFrame):
  • bindings/js/kjs_events.cpp: (WebCore::JSAbstractEventListener::handleEvent): (WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener): (WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener): (WebCore::JSUnprotectedEventListener::windowObj): (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::~JSEventListener): (WebCore::JSEventListener::windowObj): (WebCore::JSLazyEventListener::JSLazyEventListener): (WebCore::JSLazyEventListener::parseCode):
  • bindings/js/kjs_events.h:
  • bindings/js/kjs_navigator.cpp: (WebCore::MimeType::getValueProperty):
  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate): (WebCore::KJSProxy::createHTMLEventHandler): (WebCore::KJSProxy::createSVGEventHandler):
  • bindings/js/kjs_window.cpp: (WebCore::JSDOMWindowBasePrivate::JSDOMWindowBasePrivate): (WebCore::DOMWindowTimer::DOMWindowTimer): (WebCore::DOMWindowTimer::action): (WebCore::DOMWindowTimer::takeAction): (WebCore::): (WebCore::JSDOMWindowBase::JSDOMWindowBase): (WebCore::JSDOMWindowBase::~JSDOMWindowBase): (WebCore::JSDOMWindowBase::location): (WebCore::JSDOMWindowBase::mark): (WebCore::allowPopUp): (WebCore::createWindow): (WebCore::showModalDialog): (WebCore::JSDOMWindowBase::getValueProperty): (WebCore::JSDOMWindowBase::childFrameGetter): (WebCore::JSDOMWindowBase::indexGetter): (WebCore::JSDOMWindowBase::namedItemGetter): (WebCore::JSDOMWindowBase::getOwnPropertySlot): (WebCore::JSDOMWindowBase::put): (WebCore::JSDOMWindowBase::allowsAccessFrom): (WebCore::JSDOMWindowBase::allowsAccessFromNoErrorMessage): (WebCore::JSDOMWindowBase::allowsAccessFromPrivate): (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): (WebCore::JSDOMWindowBase::printErrorMessage): (WebCore::JSDOMWindowBase::globalExec): (WebCore::JSDOMWindowBase::shouldInterruptScript): (WebCore::JSDOMWindowBase::setListener): (WebCore::JSDOMWindowBase::getListener): (WebCore::JSDOMWindowBase::findJSEventListener): (WebCore::JSDOMWindowBase::findOrCreateJSEventListener): (WebCore::JSDOMWindowBase::findJSUnprotectedEventListener): (WebCore::JSDOMWindowBase::findOrCreateJSUnprotectedEventListener): (WebCore::JSDOMWindowBase::clearHelperObjectProperties): (WebCore::JSDOMWindowBase::clear): (WebCore::JSDOMWindowBase::setCurrentEvent): (WebCore::JSDOMWindowBase::currentEvent): (WebCore::windowProtoFuncAToB): (WebCore::windowProtoFuncBToA): (WebCore::windowProtoFuncOpen): (WebCore::windowProtoFuncSetTimeout): (WebCore::windowProtoFuncClearTimeout): (WebCore::windowProtoFuncSetInterval): (WebCore::windowProtoFuncAddEventListener): (WebCore::windowProtoFuncRemoveEventListener): (WebCore::windowProtoFuncShowModalDialog): (WebCore::windowProtoFuncNotImplemented): (WebCore::JSDOMWindowBase::setReturnValueSlot): (WebCore::JSDOMWindowBase::clearAllTimeouts): (WebCore::JSDOMWindowBase::installTimeout): (WebCore::JSDOMWindowBase::pauseTimeouts): (WebCore::JSDOMWindowBase::resumeTimeouts): (WebCore::JSDOMWindowBase::clearTimeout): (WebCore::JSDOMWindowBase::timerFired): (WebCore::JSDOMWindowBase::disconnectFrame): (WebCore::JSDOMWindowBase::jsEventListeners): (WebCore::JSDOMWindowBase::jsHTMLEventListeners): (WebCore::JSDOMWindowBase::jsUnprotectedEventListeners): (WebCore::JSDOMWindowBase::jsUnprotectedHTMLEventListeners): (WebCore::toJS): (WebCore::toJSDOMWindow): (WebCore::toJSDOMWindow):
  • bindings/js/kjs_window.h: (WebCore::JSDOMWindowBase::impl): (WebCore::JSDOMWindowBase::classInfo): (WebCore::JSDOMWindowBase::):
  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
  • bindings/scripts/CodeGeneratorJS.pm:
  • history/CachedPage.cpp: (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::restore):
  • page/Chrome.cpp: (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer): (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
  • page/DOMWindow.idl:
  • page/Frame.cpp: (WebCore::Frame::~Frame): (WebCore::Frame::windowScriptNPObject): (WebCore::Frame::pageDestroyed):
  • page/InspectorController.cpp: (WebCore::inspectedWindow):
  • page/mac/FrameMac.mm: (WebCore::Frame::windowScriptObject):
  • page/mac/WebCoreFrameBridge.mm: (updateRenderingForBindings):
  • platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canAccess):
5:16 PM Changeset in webkit [30730] by mrowe@apple.com
  • 2 edits in tags/Safari-5525.11.1/JavaScriptGlue

Merge r30677.

5:03 PM Changeset in webkit [30729] by mrowe@apple.com
  • 4 edits in branches/Safari-3-1-branch

Versioning.

5:02 PM Changeset in webkit [30728] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.13

New tag.

4:43 PM Changeset in webkit [30727] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30716.

4:24 PM Changeset in webkit [30726] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Make ForInNode check for the timeout interrupt

Reviewed by Anders

3:08 PM Changeset in webkit [30725] by kevino@webkit.org
  • 5 edits in trunk

wx build fixes after recent Frame-related changes.

2:59 PM Changeset in webkit [30724] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • make :first-letter apply to the first letter in normal flow, skipping floats and positioned objects

Test: fast/css/first-letter-skip-out-of-flow.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):

LayoutTests:

Reviewed by Darin Adler.

  • test that :first-letter applies to the first letter in normal flow, skipping floats and positioned objects
  • fast/css/first-letter-skip-out-of-flow.html: Added.
  • platform/mac-leopard/fast/css/first-letter-skip-out-of-flow-expected.checksum: Added.
  • platform/mac-leopard/fast/css/first-letter-skip-out-of-flow-expected.png: Added.
  • platform/mac/fast/css/first-letter-skip-out-of-flow-expected.txt: Added.
2:58 PM Changeset in webkit [30723] by adachan@apple.com
  • 2 edits in trunk/WebCore

Fix build.

  • plugins/win/PluginViewWin.cpp:
2:51 PM Google Summer of Code 2008 edited by eric@webkit.org
(diff)
2:43 PM Changeset in webkit [30722] by mrowe@apple.com
  • 4 edits
    2 adds in trunk

2008-03-03 Mark Rowe <​mrowe@apple.com>

Reviewed by Dan Bernstein.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=17313
Bug 17313: querySelectorAll() causing crashes when called via dojo.query() wrapper

Node::querySelector and SelectorNodeList were not sufficiently initializing the CSSStyleSelector
before using it to resolve styles, which lead to it having a stale m_style member in some situations.
This stale m_style member resulted in a wild store that would write over whatever object now resided
at the location m_style pointed to.

Test: fast/dom/SelectorAPI/bug-17313.html

  • dom/Node.cpp: (WebCore::Node::querySelector): Call initForStyleResolve to further initialize the CSSStyleSelector.
  • dom/SelectorNodeList.cpp: (WebCore::SelectorNodeList::SelectorNodeList): Ditto.

2008-03-03 Mark Rowe <​mrowe@apple.com>

Reviewed by Dan Bernstein.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=17313
Bug 17313: querySelectorAll() causing crashes when called via dojo.query() wrapper

  • fast/dom/SelectorAPI/bug-17313-expected.txt: Added.
  • fast/dom/SelectorAPI/bug-17313.html: Added.
2:06 PM Changeset in webkit [30721] by alp@webkit.org
  • 2 edits in trunk

2008-03-03 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=17644
Build GTK on Mac OS X using native ICU library

Use Apple native ICU libraries when building GTK
webkit on Mac OS.

  • configure.ac:
1:53 PM Changeset in webkit [30720] by andersca@apple.com
  • 18 edits in trunk/WebCore

Reviewed by Darin and Sam.

Include fixes, in preparation of using the headers in WebCore/bridge.


  • bindings/js/kjs_binding.h:
  • bindings/js/kjs_dom.cpp:
  • bindings/objc/DOMInternal.mm:
  • bindings/objc/DOMUtility.mm:
  • bindings/objc/WebScriptObject.mm:
  • bindings/objc/WebScriptObjectPrivate.h:
  • bridge/objc/objc_class.h:
  • bridge/objc/objc_instance.h:
  • bridge/objc/objc_runtime.h:
  • bridge/objc/objc_utility.h:
  • bridge/runtime.h:
  • bridge/runtime_object.h:
  • bridge/runtime_root.h:
  • html/HTMLAppletElement.cpp:
  • html/HTMLAppletElement.h:
  • html/HTMLEmbedElement.cpp:
  • html/HTMLEmbedElement.h:
  • html/HTMLObjectElement.cpp:
  • html/HTMLPlugInElement.cpp:
  • html/HTMLPlugInElement.h:
  • page/mac/FrameMac.mm:
  • page/mac/WebCoreFrameBridge.h:
  • page/mac/WebCoreFrameBridge.mm:
  • page/mac/WebCoreScriptDebugger.mm:
1:18 PM Changeset in webkit [30719] by hyatt@apple.com
  • 8 edits in trunk

WebCore:

Full page zoom plumbing. Add a notion of whether or not a zoom is text only or a full zoom to the
Frame. setTextSizeMultiplier does a text only zoom.

Reviewed by Tim H.

  • page/Frame.cpp: (WebCore::Frame::zoomFactor): (WebCore::Frame::isZoomFactorTextOnly): (WebCore::Frame::setZoomFactor): (WebCore::FramePrivate::FramePrivate):
  • page/Frame.h:
  • page/FramePrivate.h:
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge setTextSizeMultiplier:]):
  • svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::setCurrentScale):

WebKit/win:

Full page zoom work. Make setting of a zoom factor take a boolean saying whether it is a text only
or full page zoom.

Reviewed by Tim H.

  • WebFrame.cpp: (WebFrame::setTextSizeMultiplier):
12:03 PM Changeset in webkit [30718] by alp@webkit.org
  • 2 edits in trunk/WebKit/gtk

2008-03-03 Alp Toker <​alp@atoker.com>

Fix the GTK+ build following breakage introduced in r30712.

  • WebCoreSupport/EditorClientGtk.cpp: (WebKit::imContextCommitted):
11:58 AM Changeset in webkit [30717] by jhoneycutt@apple.com
  • 5 edits in branches/Safari-3-1-branch/WebCore

2008-03-03 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin, Anders.

Merge 30698 to Safari-3-1-branch.

  • plugins/PluginDatabase.h: Added isPreferredPluginPath(), preferredPluginCompare() qsort comparator.
  • plugins/PluginPackage.h: Added bool m_allowsMultipleInstances. (WebCore::PluginPackage::allowsMultipleInstances): Added; returns true if plug-in can have multiple instances, false otherwise.
  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabase::preferredPluginCompare): qsort comparator function, calls PluginPackage::compare(). (WebCore::PluginDatabase::pluginForMIMEType): Builds a list of plug-ins for a MIME type, sorts them, and returns the first item. (WebCore::PluginDatabase::MIMETypeForExtension): Builds a list of plug-ins that handle this extension, sorts them, and returns the MIME type the first plug-in in the list associates with this extension. (WebCore::PluginDatabase::isPreferredPluginPath): Returns true if the passed path is the "preferred" plug-in path.
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::PluginPackage): Set m_allowsMultipleInstances to true. (WebCore::PluginPackage::fetchInfo): If this is the VLC plug-in, set m_allowsMultipleInstances to false. (WebCore::PluginPackage::compare): Compare two plug-ins, first checking whether a plug-in has an issue that should push it to the back, then whether it's in a preferred directory that should move it to the front, then by filename, version, and parent directory. (WebCore::PluginPackage::load): If this plug-in doesn't allow multiple instances, and the package has been loaded, return false.
11:51 AM Changeset in webkit [30716] by hyatt@apple.com
  • 2 edits in trunk/WebCore

Fix for <rdar://problem/5776161> REGRESSION: Google Docs Spreadsheet crash

This is also ​http://bugs.webkit.org/show_bug.cgi?id=17543, fixed table layout corrupts heap.

Make sure not to access position -1 of the size 0 vectors.

Reviewed by ggaren

  • rendering/FixedTableLayout.cpp: (WebCore::FixedTableLayout::layout):
11:45 AM Changeset in webkit [30715] by ddkilzer@apple.com
  • 3 edits
    6 adds in trunk

WebCore:

Dynamically inserting CSS rule with @media query fails with DOM Exception 12
<​http://bugs.webkit.org/show_bug.cgi?id=15986>

Reviewed by Darin.

Allow any valid rule (@font-face, @import, @media, @page or style) to be
parsed when using CSSStyleSheet.insertRule(). Previously only import and
style rules were allowed. Note that @page rules always throw an exception
because they're not implemented yet, so no test case was added for them.

Tests: fast/css/insertRule-font-face.html

fast/css/insertRule-media.html

  • css/CSSGrammar.y: Extracted 'valid_rule' out of 'rule'. Renamed 'ruleset_or_import' to 'valid_rule_or_import' and changed its definition.

LayoutTests:

Dynamically inserting CSS rule with @media query fails with DOM Exception 12
<​http://bugs.webkit.org/show_bug.cgi?id=15986>

Reviewed by Darin.

  • fast/css/insertRule-font-face.html: Added.
  • fast/css/insertRule-media.html: Added.
  • fast/css/resources/insertRule-font-face.js: Added.
  • fast/css/resources/insertRule-media.js: Added.
11:43 AM Changeset in webkit [30714] by andersca@apple.com
  • 1 edit
    31 copies in trunk/WebCore

Reviewed by Sam.

Copy JSC bindings directory over to WebCore/bridge.

10:56 AM Changeset in webkit [30713] by mitz@apple.com
  • 3 edits in trunk/WebCore

Reviewed by Darin Adler.

  • remove CSSMutableStyleDeclaration::setChanged()'s change type parameter
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::setChanged): Removed the change type parameter and made this function determine the correct change type based on whether this is an inline style declaration. (WebCore::CSSMutableStyleDeclaration::setProperty):
  • css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::clear): Removed this unused method. (WebCore::CSSMutableStyleDeclaration::setChanged): Made private.
10:44 AM Changeset in webkit [30712] by Darin Adler
  • 26 edits in trunk

WebCore:

Reviewed by Adam.

  • some "cleanup" on the path to removing WebCoreFrameBridge
  • WebCore.base.exp: Exported some stuff we either already use or I am about to use in an upcoming patch.
  • WebCore.xcodeproj/project.pbxproj: Made FileChooser.h private rather than project, for future use in WebKit.
  • bindings/objc/WebScriptObject.mm: Removed some dead code.
  • dom/ContainerNode.cpp: Added a now-needed or soon-to-be-needed include.
  • editing/Editor.cpp: Ditto.
  • editing/Editor.h: Removed many unneeded declarations and includes. Removed the unused userVisibleString function.
  • editing/EditorCommand.cpp: (WebCore::executeYank): Added parameter for triggeringEvent, which no longer has a default value. (WebCore::executeYankAndSelect): Ditto.
  • editing/mac/EditorMac.mm: Removed userVisibleString.
  • page/mac/EventHandlerMac.mm: (WebCore::isKeyboardOptionTab): Tweaked formattin.
  • page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge dragSourceMovedTo:]): Get window from -[NSView window] rather than from the bridge. There's no special value in the bridge's window method and we can use NSView directly. (-[WebCoreFrameBridge dragSourceEndedAt:operation:]): Ditto.
  • platform/graphics/mac/ImageMac.mm: (WebCore::Image::loadPlatformResource): Use a new WebCoreBundleFinder class to find the bundle rather than using WebCoreFrameBridge.
  • platform/mac/ClipboardMac.mm: Added a now-needed or soon-to-be-needed include.
  • platform/mac/PasteboardMac.mm: Ditto.
  • rendering/RenderObject.h: (WebCore::DashboardRegionValue::operator==): Fixed mistake where this wasn't comparing the clip rectangle. (WebCore::DashboardRegionValue::operator!=): Added. Needed by my future work.

WebKit/mac:

Reviewed by Adam.

  • some "cleanup" on the path to removing WebCoreFrameBridge
  • Storage/WebDatabaseManager.mm: Tweak includes.
  • Storage/WebDatabaseTrackerClient.mm: Ditto.
  • Storage/WebSecurityOrigin.mm: Ditto.
  • Storage/WebSecurityOriginInternal.h: Ditto.
  • WebView/WebFrame.mm: (core): Changed to get rid of the requirement that WebKitEditableLinkBehavior exactly match WebCore::EditableLinkBehavior.
  • WebView/WebFrameInternal.h: Removed unused kit function.
  • WebView/WebHTMLView.mm: Moved WebHTMLViewPrivate class in here.
  • WebView/WebHTMLViewInternal.h: Moved WebHTMLVewPrivate class out of here.
  • WebView/WebHTMLViewPrivate.h: Tweaked formatting and removed some unneeded declarations.
  • WebView/WebPreferencesPrivate.h: Removed a no-longer-needed comment.
1:34 AM Changeset in webkit [30711] by oliver@apple.com
  • 5 edits in trunk

Bug 17620: getImageData lies
​http://bugs.webkit.org/show_bug.cgi?id=17620

Reviewed by Mark Rowe

Correct logic to actually iterate over the source row

12:17 AM Changeset in webkit [30710] by oliver@apple.com
  • 4 edits in trunk

Correct incorrect assertion

Reviewed by Mark Rowe

Mar 2, 2008:

9:34 PM Changeset in webkit [30709] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-03-02 Alp Toker <​alp@atoker.com>

Another fix for non-database builds after changes in r30331.

Conditionalize a stopDatabases() call.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::stopLoading):
9:29 PM Changeset in webkit [30708] by kevino@webkit.org
  • 3 edits in trunk/WebCore

Reviewed by Alp Toker.

Scrolling fixes. Implement page scrolling, initialize mouse wheel event variables, and remove duplicate event binding for TOP scrolling event.

​http://bugs.webkit.org/show_bug.cgi?id=17643

9:10 PM Changeset in webkit [30707] by alp@webkit.org
  • 6 edits in trunk

2008-03-02 Brent Fulgham <​bfulgham@gmail.com>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=17415
GTK Build (using autotools) on Mac OS (DarwinPorts) Fails

Add -lstdc++ to link flags for minidom program. This corrects
a build error for the GTK+ on Mac OS.

Add ICU_CPPFLAGS earlier in include path for WebCore
so that we find $(icu_cppflags)/unicode/utf8.h, rather than
the wtf/unicode/UTF8.h on case-insensitive file systems.

Remove some needless LIBS.

9:02 PM Changeset in webkit [30706] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-03-02 Alp Toker <​alp@atoker.com>

Fix building without database support after changes in r30331.

  • dom/Document.cpp:
7:16 PM Changeset in webkit [30705] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix for Windows after PageWin.cpp move.

6:23 PM ApplicationsGtk edited by alp@atoker.com
Add perl Bindings to the list (diff)
6:02 PM Changeset in webkit [30704] by kevino@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Dave Hyatt.

Gracefully handle a CSS rule containing an invalid value.
(Fixes ​http://bugs.webkit.org/show_bug.cgi?id=16898)

2:58 PM Changeset in webkit [30703] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-03-02 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Improve the Cairo Path::isEmpty() function

Use cairo_has_current_point() where available.

  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::isEmpty):
11:51 AM Changeset in webkit [30702] by alp@webkit.org
  • 6 edits in trunk

2008-03-02 Alp Toker <​alp@atoker.com>

Reviewed by Mark Rowe.

Split the WebKit GTK+ build out of the WebCore build and change the
shared object name to match the package name.

  • GNUmakefile.am:

Mar 1, 2008:

11:08 PM Changeset in webkit [30701] by mrowe@apple.com
  • 12 edits in trunk

Update Xcode configuration to support building debug and release from the mysterious future.

Reviewed by Tim Hatcher.

10:55 PM Changeset in webkit [30700] by oliver@apple.com
  • 11 edits
    3 adds in trunk

Bug 16954: Support putImageData

Reviewed by Sam Weinig.

Implement support for HTML5's putImageData for the CG port. All other ports
are currently just using stubs for the final blit.

6:13 PM Changeset in webkit [30699] by kevino@webkit.org
  • 1 edit in trunk/WebCore/css/CSSPropertyNames.in

Typo fix.

6:02 PM Changeset in webkit [30698] by jhoneycutt@apple.com
  • 10 edits in trunk/WebCore

2008-03-01 Jon Honeycutt <​jhoneycutt@apple.com>

Reviewed by Darin.

<rdar://problem/5772987> Crashing viewing page with two VLC plug-in
instances

The VLC Netscape plug-in crashes if more than one instance is created.

Added a quirk that disallows a plug-in from having more than one
instance and set this for the VLC plug-in.

In addition, we now sort plug-ins that handle the same MIME
type to choose the most appropriate one. This sorting first sorts by
whether a plug-in has an issue that should put it at the end of the
list, then whether it appears in a "preferred" plug-in directory.

  • plugins/PluginQuirkSet.h: Added PluginQuirkDontAllowMultipleInstances.
  • plugins/PluginDatabase.cpp: (WebCore::PluginDatabase::preferredPluginCompare): Comparator for sorting plug-ins; calls PluginPackage::compare(). (WebCore::PluginDatabase::pluginForMIMEType): Add all of the plug-ins that handle this MIME type to a list, sort the list, and return the first item. (WebCore::PluginDatabase::MIMETypeForExtension): Add all of the plug-ins that handle this extension to a list, sort the list, and return the MIME type used by the plug-in at the beginning of the list.
  • plugins/PluginDatabase.h:
  • plugins/PluginPackage.h: (WebCore::PluginPackage::version): Added; returns the module version.
  • plugins/win/PluginDatabaseWin.cpp: (WebCore::PluginDatabase::isPreferredPluginPath): Made static; removed const.
  • plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::compare): Sorts plug-ins with known issues to the end, then plug-ins in preferred directories to the beginning, then alphabetically by file name, numerically by version, and alphabetically by parent directory. (WebCore::PluginPackage::determineQuirks): Set the "don't allow multiple instances" quirk for VLC. (WebCore::PluginPackage::load): Return false if the plug-in library has already been loaded and the "don't allow multiple instances" quirk is set.
  • platform/gtk/TemporaryLinkStubs.cpp: (PluginPackage::compare): Added stub. (PluginDatabase::IsPreferredPluginPath): Update the GTK stub.
  • platform/qt/TemporaryLinkStubs.cpp: (PluginPackage::compare): Added stub. (PluginDatabase::IsPreferredPluginPath): Update the Qt stub.
  • platform/wx/TemporaryLinkStubs.cpp: (PluginPackage::compare): Added stub. (PluginDatabase::IsPreferredPluginPath): Update the wx stub.
1:55 PM Changeset in webkit [30697] by weinig@apple.com
  • 2 edits in trunk/WebCore

Rubber-stamped by Mark Rowe.

Remove reference to the now non-existent bridge directory.

  • WebCore.xcodeproj/project.pbxproj:
12:19 PM Changeset in webkit [30696] by weinig@apple.com
  • 4 edits in trunk

WebCore:

Reviewed by Darin Adler.

Search the entire prototype chain when doing early prototype lookup in
the Window's getOwnPropertySlot method.

Makes fast/dom/Window/window-function-name-getter-precedence.html pass all tests.

  • bindings/js/kjs_window.cpp: (KJS::Window::getOwnPropertySlot):

LayoutTests:

Reviewed by Darin Adler.

Update test result.

  • fast/dom/Window/window-function-name-getter-precedence-expected.txt:
5:46 AM Changeset in webkit [30695] by Nikolas Zimmermann
  • 5 edits
    40 adds in trunk

Reviewed by Oliver.

Fixes: ​http://bugs.webkit.org/show_bug.cgi?id=17568 (SVGForeignObjectElement can't react to width/height SVG DOM changes)

As the bug title says, fix all dynamic update problems that occour with SVGForeignObjectElement.

Tests: svg/dynamic-updates/SVGForeignObjectElement-dom-height-attr.html

svg/dynamic-updates/SVGForeignObjectElement-dom-width-attr.html
svg/dynamic-updates/SVGForeignObjectElement-dom-x-attr.html
svg/dynamic-updates/SVGForeignObjectElement-dom-y-attr.html
svg/dynamic-updates/SVGForeignObjectElement-svgdom-height-prop.html
svg/dynamic-updates/SVGForeignObjectElement-svgdom-width-prop.html
svg/dynamic-updates/SVGForeignObjectElement-svgdom-x-prop.html
svg/dynamic-updates/SVGForeignObjectElement-svgdom-y-prop.html

Feb 29, 2008:

7:57 PM Google Summer of Code 2008 edited by jasper@unix.geek.nz
(diff)
6:20 PM Changeset in webkit [30694] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30692.

6:20 PM Changeset in webkit [30693] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

Merge r30689.

6:15 PM Changeset in webkit [30692] by beidson@apple.com
  • 2 edits in trunk/WebCore

Reviewed by build-fix karma

Bonehead mistake. Revert function to previous version for all non-Windows+CFNetwork platforms

  • platform/network/ProtectionSpace.cpp: (WebCore::ProtectionSpace::receivesCredentialSecurely): Make my previous change conditionally
6:01 PM Changeset in webkit [30691] by mrowe@apple.com
  • 2 edits in trunk/WebKitLibraries

Update Tiger version of WebKitSystemInterface to match r30690.

5:56 PM Changeset in webkit [30690] by adele@apple.com
  • 2 edits in trunk/WebKitLibraries

Reviewed by Mark.

Auto-generate image arrays.

  • libWebKitSystemInterfaceLeopard.a:
5:50 PM Changeset in webkit [30689] by beidson@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin


<rdar://problem/5771227> - Incorrect password handling text in credential sheet

  • platform/network/ProtectionSpace.cpp: (WebCore::ProtectionSpace::receivesCredentialSecurely): Call functional CFNetwork method to get "secureness" of the auth challenge instead of figuring it out ourselves
5:35 PM Changeset in webkit [30688] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Rubber-stamped by Sam Weinig.

  • update test results following r30649
  • svg/css/getComputedStyle-basic-expected.txt:
4:29 PM Changeset in webkit [30687] by pewtermoose@webkit.org
  • 3 edits
    1 copy in trunk

2008-02-29 Brent Fulgham <​bfulgham@gmail.com>
JavaScriptCore:

​http://bugs.webkit.org/show_bug.cgi?id=17483
Implement scrollbars on Windows (Cairo)

Reviewed by Adam Roben.

  • wtf/Platform.h:

WebCore:

​http://bugs.webkit.org/show_bug.cgi?id=17483
Implement scrollbars on Windows (Cairo)

Reviewed by Adam Roben.

  • platform/win/PlatfromScrollBarWin.cpp: Duplicate implementation from PlatformScrollBarWinSafari.cpp, then modify to use the native Windows theme engine. Use SOFT_LINK. Use platform 'GetSystemMetrics' call to decide size of scrollbars and buttons.
4:19 PM Changeset in webkit [30686] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/JavaScriptGlue

Merge r30677.

4:14 PM Changeset in webkit [30685] by Adam Roben
  • 1 edit
    1 delete in trunk/WebKit/win

Delete an unused file

Rubberstamped by Brady.

  • Interfaces/IWebScriptScope.idl: Removed.
4:14 PM Changeset in webkit [30684] by Adam Roben
  • 4 edits in trunk/WebKit/win

Change WebPreferences to be backed by CFPreferences

Reviewed by Ada, Geoff, Steve, and Darin.

  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp: (WebPreferences::sharedStandardPreferences): Changed to call setAutoSaves(TRUE) before calling load(). This ensures that the preferences being migrated to CFPreferences are saved to disk. (WebPreferences::valueForKey): Changed to return a RetainPtr to ensure that the refcount is managed properly. Now attempts to retrieve a value from CFPreferences before falling back to the default settings. (WebPreferences::setValueForKey): Now saves the value in CFPreferences if m_autoSaves is true. (WebPreferences::stringValueForKey): Updated for valueForKey changes. (WebPreferences::integerValueForKey): DItto. (WebPreferences::boolValueForKey): Ditto. (WebPreferences::floatValueForKey): Ditto. (WebPreferences::save): Now simply calls CFPreferencesAppSynchronize. (WebPreferences::load): Always initializes m_privatePrefs to an empty CFMutableDictionary. (WebPreferences::migrateWebKitPreferencesToCFPreferences): Migrates preferences from our old custom plist to CFPreferences and then deletes our custom plist, if the migration has never occurred before. (WebPreferences::copyWebKitPreferencesToCFPreferences): Copies preferences to CFPreferences. If we've never migrated the default settings from Safari 3 Beta before, we omit them from this copying procedure.
  • WebPreferences.h:
4:13 PM Changeset in webkit [30683] by Adam Roben
  • 2 edits in trunk/WebKit/win

Refactor value <-> CFNumber conversions into some helper functions

Reviewed by Jon.

  • WebPreferences.cpp: (preferencesPath): Changed to return a const String&. (numberValueForPreferencesValue): Converts a value from preferences to a native numeric type. (cfNumber): Converts a native numeric value to a CFNumberRef. (booleanValueForPreferencesValue): Converts a value from preferences to a native boolean. (WebPreferences::integerValueForKey): Changed to call numberValueForPreferencesValue. (WebPreferences::floatValueForKey): Ditto. (WebPreferences::boolValueForKey): Changed to call booleanValueForPreferencesValue. (WebPreferences::setIntegerValue): Changed to call cfNumber. (WebPreferences::setLongLongValue): Ditto.
4:13 PM Changeset in webkit [30682] by Adam Roben
  • 3 edits in trunk/WebKit/win

Add WebPreferences::setValueForKey

This is just a small refactoring of some duplicated logic into a
shared method.

Reviewed by Sam.

  • WebPreferences.cpp: (WebPreferences::setValueForKey): Added. (WebPreferences::setStringValue): Call setValueForKey. (WebPreferences::setIntegerValue): Ditto. (WebPreferences::setBoolValue): Ditto. (WebPreferences::setLongLongValue): Ditto.
  • WebPreferences.h:
4:13 PM Changeset in webkit [30681] by Adam Roben
  • 3 edits in trunk/WebKit/win

Remove WebPreferences' static members

s_defaultSettings is now a file-level static, and
s_standardPreferences has been removed completely (it wasn't being
used).

Reviewed by Sam.

  • WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::valueForKey): (WebPreferences::migrateDefaultSettingsFromSafari3Beta): (WebPreferences::removeValuesMatchingDefaultSettings):
  • WebPreferences.h:
4:09 PM Changeset in webkit [30680] by Adam Roben
  • 2 edits
    2 copies in trunk/WebCore

Windows build fix

  • WebCore.vcproj/WebCore.vcproj: Remove bridge/* from the include path and the post-build event, and add page/win to each. Also let VS have its way with the order of the files.
  • page/win/PageWin.cpp: Copied from bridge/win/PageWin.cpp in r30673
  • page/win/GlobalHistoryWin.cpp: Copied from bridge/win/GlobalHistoryWin.cpp in r30673
3:48 PM Changeset in webkit [30679] by Adam Roben
  • 4 edits in trunk/JavaScriptCore

Remove unused DebuggerImp::abort and DebuggerImp::aborted

Reviewed by Tim and Sam.

  • kjs/function_object.cpp: (KJS::FunctionObjectImp::construct):
  • kjs/internal.h: (KJS::DebuggerImp::DebuggerImp):
  • kjs/nodes.cpp: (KJS::Node::handleException): (KJS::FunctionBodyNodeWithDebuggerHooks::execute):
3:45 PM Changeset in webkit [30678] by andersca@apple.com
  • 2 edits in trunk/WebCore

Build fix.

  • WebCore.xcodeproj/project.pbxproj:
3:08 PM Changeset in webkit [30677] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptGlue

Reviewed by David Harrison.


Fixed <rdar://problem/5765063> TOT REGRESSION: Software Update crash in
KJS::Collector::collect() (missing JSLock)

  • JSValueWrapper.cpp: (unprotectGlobalObject): Added missing JSLock.
2:47 PM Changeset in webkit [30676] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-02-29 Mark Rowe <​mrowe@apple.com>

Reviewed by Tim Hatcher.

64-bit build fix.

  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::pathFromFont): Provide stub implementation of pathFromFont for 64-bit as FMGetATSFontRefFromFont is not available.
2:27 PM Changeset in webkit [30675] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Build fix. Only declare pathFromFont in debug builds as it is unused in release builds.

2:19 PM Changeset in webkit [30674] by andersca@apple.com
  • 3 edits
    7 copies
    1 delete in trunk/WebCore

Reviewed by Adam.


Copy the remaining files in bridge/ over to page/

  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bridge: Removed.
  • bridge/AXObjectCache.h: Removed.
  • bridge/EditorClient.h: Removed.
  • bridge/GlobalHistory.h: Removed.
  • bridge/win: Removed.
  • bridge/win/FrameCGWin.cpp: Removed.
  • bridge/win/FrameCairoWin.cpp: Removed.
  • bridge/win/FrameWin.cpp: Removed.
  • bridge/win/FrameWin.h: Removed.
  • bridge/win/GlobalHistoryWin.cpp: Removed.
  • bridge/win/PageWin.cpp: Removed.
  • page/AXObjectCache.h: Copied from bridge/AXObjectCache.h.
  • page/EditorClient.h: Copied from bridge/EditorClient.h.
  • page/GlobalHistory.h: Copied from bridge/GlobalHistory.h.
  • page/win/FrameCGWin.cpp: Copied from bridge/win/FrameCGWin.cpp.
  • page/win/FrameCairoWin.cpp: Copied from bridge/win/FrameCairoWin.cpp.
  • page/win/FrameWin.cpp: Copied from bridge/win/FrameWin.cpp.
  • page/win/FrameWin.h: Copied from bridge/win/FrameWin.h.
2:10 PM Changeset in webkit [30673] by mrowe@apple.com
  • 5 edits
    2 adds in trunk

2008-02-29 Robert Blaut <​webkit@blaut.biz>

Reviewed by Darin Adler.

Test: fast/html/link-rel-stylesheet.html

  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::process):

2008-02-29 Robert Blaut <​webkit@blaut.biz>

Reviewed by Darin Adler.

  • fast/html/link-rel-stylesheet.html: Added.
  • fast/media/mq-simple-query-02.html:
  • fast/media/mq-width-absolute-02.html:
  • platform/mac/fast/html/link-rel-stylesheet-expected.txt: Added.
2:06 PM Changeset in webkit [30672] by mrowe@apple.com
  • 11 edits in trunk

2008-02-29 Mark Rowe <​mrowe@apple.com>

Reviewed by Anders Carlsson.

Replace use of WKPathFromFont with implementation in terms of public API.

  • WebCore.base.exp: Remove unused symbol.
  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::initFontData): (WebCore::pathFromFont): Implement pathFromFont in terms of public API. (WebCore::SimpleFontData::platformInit):
  • platform/mac/WebCoreSystemInterface.h: Remove unused symbol.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.

2008-02-29 Mark Rowe <​mrowe@apple.com>

Reviewed by Anders Carlsson.

Replace use of WKPathFromFont with implementation in terms of public API.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Remove unused symbol.

2008-02-29 Mark Rowe <​mrowe@apple.com>

Reviewed by Anders Carlsson.

Replace use of WKPathFromFont with implementation in terms of public API.

  • WebKitSystemInterface.h: Remove unused symbol.
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
1:56 PM Changeset in webkit [30671] by andersca@apple.com
  • 2 edits
    6 copies
    1 delete in trunk/WebCore

Reviewed by Adam.

Move a bunch of files from bridge/mac to page/mac.


  • WebCore.xcodeproj/project.pbxproj:
  • bridge/mac: Removed.
  • bridge/mac/AXObjectCacheMac.mm: Removed.
  • bridge/mac/GlobalHistoryMac.mm: Removed.
  • bridge/mac/WebCoreAXObject.h: Removed.
  • bridge/mac/WebCoreAXObject.mm: Removed.
  • bridge/mac/WebCoreScriptDebugger.h: Removed.
  • bridge/mac/WebCoreScriptDebugger.mm: Removed.
  • page/mac/AXObjectCacheMac.mm: Copied from bridge/mac/AXObjectCacheMac.mm.
  • page/mac/GlobalHistoryMac.mm: Copied from bridge/mac/GlobalHistoryMac.mm.
  • page/mac/WebCoreAXObject.h: Copied from bridge/mac/WebCoreAXObject.h.
  • page/mac/WebCoreAXObject.mm: Copied from bridge/mac/WebCoreAXObject.mm.
  • page/mac/WebCoreScriptDebugger.h: Copied from bridge/mac/WebCoreScriptDebugger.h.
  • page/mac/WebCoreScriptDebugger.mm: Copied from bridge/mac/WebCoreScriptDebugger.mm.
1:14 PM Changeset in webkit [30670] by hyatt@apple.com
  • 4 edits in trunk/WebCore

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=17559, media query tests crashing under
guard malloc. Pass along the style selector so it can be accessed, since it has not yet
been assigned into the document's member variable.

Reviewed by aroben

  • css/CSSStyleSelector.cpp: (WebCore::CSSRuleSet::addRulesFromSheet):
  • css/MediaQueryEvaluator.cpp: (WebCore::MediaQueryEvaluator::eval):
  • css/MediaQueryEvaluator.h:
12:55 PM Changeset in webkit [30669] by sfalken@apple.com
  • 3 edits in trunk/WebKit/win

Don't free the VARIANT passed into Write, since it is an input parameter owned by the caller.
Found via code inspection.


Reviewed by Adam.

  • WebActionPropertyBag.cpp: (WebActionPropertyBag::Write):
  • WebElementPropertyBag.cpp: (WebElementPropertyBag::Write):
11:11 AM Changeset in webkit [30668] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools
Pass the correct configuration switch (--DebugRelease) to build-testkjs.

Reviewed by Dan.

Originally broken in r26838.

  • Scripts/run-javascriptcore-tests: Push configuration switch onto @xcodeArgs not local, unused @args variable.
10:58 AM Changeset in webkit [30667] by hyatt@apple.com
  • 5 edits in trunk/WebCore

<rdar://problem/5755916> REGRESSION: Loading HTML5 spec is 5x slower on TOT than in 3.0.4

Improve the performance of dynamic sibling and CSS3 selectors so that there is no slowdown any more.
Be more precise in terms of what nodes we mark dirty.

Reviewed by Beth

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkSelector):
  • dom/Element.cpp: (WebCore::Element::recalcStyle): (WebCore::checkForSiblingStyleChanges): (WebCore::Element::childrenChanged): (WebCore::Element::finishParsingChildren):
  • rendering/RenderStyle.cpp: (WebCore::RenderStyle::RenderStyle):
  • rendering/RenderStyle.h: (WebCore::RenderStyle::childrenAffectedByPositionalRules): (WebCore::RenderStyle::childrenAffectedByDirectAdjacentRules): (WebCore::RenderStyle::setChildrenAffectedByDirectAdjacentRules):
10:22 AM Changeset in webkit [30666] by ddkilzer@apple.com
  • 2 edits in trunk/WebKitTools

Bug 15754: webarchive layout tests fail when WebKit directory path contains symlinks

<​http://bugs.webkit.org/show_bug.cgi?id=15754>

Reviewed by Geoff and Darin.

We were using -[NSFileManager currentDirectoryPath] to get the current working directory,
then removing that path from all ​file:/// URLs in the WebArchive output so these tests
would pass no matter where they were run.

The problem was that -[NSFileManager currentDirectoryPath] resolves symlinks in the
current working directory, but the WebArchive does not. This left the current working
directory in all ​file:/// URLs in the test output, and thus all tests failed, for any
developer that used symlinks to get to their WebKit source directory.

The fix is to look backwards for "/LayoutTests/" in the URL we're passed, and simply
remove the current working directory path (no matter what it is) after "​file://" but
before "/LayoutTests/".

  • DumpRenderTree/mac/DumpRenderTree.mm: (normalizeWebResourceURL): Removed unused oldURLBase argument. We now replace the current working directory as described above. (convertWebResourceResponseToDictionary): Remove unused oldURLBase argument. Update calls to normalizeWebResourceURL(). (serializeWebArchiveToXML): Removed now unused cwdURL variable. Update calls to normalizeWebResourceURL() and convertWebResourceResponseToDictionary().
9:58 AM Changeset in webkit [30665] by ap@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by Darin.

<rdar://problem/5766352> REGRESSION (r27151): XMLHttpRequest.abort() resets response status

Test: http/tests/xmlhttprequest/status-after-abort.html

  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::getStatus): (WebCore::XMLHttpRequest::getStatusText): Changed to match Firefox more closely (IE just raises an exception in most of those cases).
9:28 AM Changeset in webkit [30664] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Darin Adler.

  • fix a bug where explicit embedding past the end of a line could affect text that line

Test: fast/text/embed-at-end-of-pre-wrap-line.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::skipWhitespace): Removed calls to setAdjustEmbedding(). (WebCore::RenderBlock::findNextLineBreak): Added calls to setAdjustEmbedding() around skipWhitespace() only where needed.

LayoutTests:

Reviewed by Darin Adler.

  • test for a bug where explicit embedding past the end of a line could affect text that line
  • fast/text/embed-at-end-of-pre-wrap-line.html: Added.
  • platform/mac-leopard/fast/text/embed-at-end-of-pre-wrap-line-expected.checksum: Added.
  • platform/mac-leopard/fast/text/embed-at-end-of-pre-wrap-line-expected.png: Added.
  • platform/mac/fast/text/embed-at-end-of-pre-wrap-line-expected.txt: Added.
3:32 AM Changeset in webkit [30663] by mrowe@apple.com
  • 5 edits in branches/Safari-3-1-branch

Merge r30475.

3:26 AM Changeset in webkit [30662] by mrowe@apple.com
  • 7 edits in trunk

2008-02-29 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver Hunt.

Fix spelling of "request" in name of WKNSURLProtocolClassForRequest.

  • Misc/WebNSURLExtras.mm: (-[NSURL _webkit_canonicalize]):
  • WebKit.order:

2008-02-29 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver Hunt.

Fix spelling of "request" in name of WKNSURLProtocolClassForRequest.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
3:25 AM Changeset in webkit [30661] by mrowe@apple.com
  • 11 edits in trunk

2008-02-29 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver Hunt.

Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.

  • platform/mac/WebCoreSystemInterface.h: Don't declare WKSupportsMultipartXMixedReplace on Leopard.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::doUpdatePlatformRequest): Don't call WKSupportsMultipartXMixedReplace on Leopard.
  • WebCore.Tiger.exp: Move Tiger-only symbol here.
  • WebCore.base.exp:

2008-02-29 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver Hunt.

Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLeopard.a:

2008-02-29 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver Hunt.

Don't use WKSupportsMultipartXMixedReplace on Leopard as multipart/x-mixed-replace is always handled by NSURLRequest.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface):
3:25 AM Changeset in webkit [30660] by mrowe@apple.com
  • 10 edits in trunk/WebKit/mac

2008-02-29 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver Hunt.

Remove obsolete code that had been left intact to support users running WebKit with older versions of Safari.

  • Misc/WebNSViewExtras.m: Remove _web_superviewOfClass:stoppingAtClass:.
  • Misc/WebNSWindowExtras.m: Remove _webkit_displayThrottledWindows.
  • Misc/WebSearchableTextView.m: Remove selectionImageForcingWhiteText:.
  • WebCoreSupport/WebImageRendererFactory.m: Update comment to mention the last version of Safari that requires this class.
  • WebInspector/WebInspector.mm: Remove sharedWebInspector and update comments to mention the last version of Safari that calls other obsolete methods.
  • WebView/WebDocumentPrivate.h: Remove selectionImageForcingWhiteText:.
  • WebView/WebHTMLView.mm: Ditto.
  • WebView/WebPDFView.mm: Ditto.
  • WebView/WebView.mm: Update comment to mentoin the last version of Safari that requires the obsolete method.
1:23 AM Changeset in webkit [30659] by mrowe@apple.com
  • 13 edits in trunk

2008-02-29 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Eric Seidel.

Remove unneeded includes of WebCoreSystemInterface.h.

  • loader/mac/LoaderNSURLExtras.m:
  • page/mac/FrameMac.mm:
  • page/mac/WebCoreFrameBridge.mm:
  • platform/MIMETypeRegistry.cpp:
  • platform/graphics/mac/ImageMac.mm:
  • platform/mac/PasteboardMac.mm:

2008-02-29 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Eric Seidel.

Remove unneeded includes of WebKitSystemInterface.h.

  • History/WebHistoryItem.mm:
  • Misc/WebNSViewExtras.m:
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebDataSource.mm:
  • WebView/WebPDFView.mm:
1:05 AM Changeset in webkit [30658] by mrowe@apple.com
  • 12 edits in trunk

2008-02-29 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver Hunt and Oliver Hunt.

<rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.

  • platform/mac/SystemTimeMac.cpp: Replace use of WKSecondsSinceLastInputEvent with CGEventSourceSecondsSinceLastEventType.
  • platform/mac/WebCoreSystemInterface.h: Remove unused symbol.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.
  • WebCore.base.exp: Ditto.

2008-02-29 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver Hunt and Oliver Hunt.

<rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Remove unused symbol.
  • WebKit.order: Ditto.

2008-02-29 Mark Rowe <​mrowe@apple.com>

Reviewed by Oliver Hunt and Oliver Hunt.

<rdar://problem/4753845> WebKit should use CGEventSourceSecondsSinceLastEventType in place of WKSecondsSinceLastInputEvent SPI.

  • WebKitSystemInterface.h: Remove unused symbol.
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:

Feb 28, 2008:

11:54 PM Changeset in webkit [30657] by mrowe@apple.com
  • 4 edits in trunk/WebKitLibraries

2008-02-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Dan Bernstein.

Remove two unused functions from WebKitSystemInterface.

  • WebKitSystemInterface.h: Remove WKPreferRGB32Key and WKGetDefaultGlyphForChar as they are unused. Also remove a duplicate declaration of WKSecondsSinceLastInputEvent.
  • libWebKitSystemInterfaceLeopard.a:
  • libWebKitSystemInterfaceTiger.a:
10:19 PM Changeset in webkit [30656] by mrowe@apple.com
  • 11 edits
    1 add in trunk

2008-02-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Dave Hyatt.

Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.

  • DerivedSources.make: Add Tiger-only symbols to the export file when running on Tiger.
  • WebCore.Tiger.exp: Added. Move Tiger-only symbol here from WebCore.base.exp.
  • WebCore.base.exp:
  • platform/graphics/mac/SimpleFontDataMac.mm: (WebCore::SimpleFontData::platformInit): Use Leopard APIs when building on Leopard.
  • platform/mac/WebCoreSystemInterface.h: Don't declare wkGetFontMetrics on Leopard as it is unused.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.

2008-02-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Dave Hyatt.

Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.

  • WebKitSystemInterface.h: Only declare WKGetFontMetrics on Tiger.
  • libWebKitSystemInterfaceLeopard.a: Update for removal of WKGetFontMetrics.

2008-02-28 Mark Rowe <​mrowe@apple.com>

Reviewed by Dave Hyatt.

Make use of new CGFont APIs on Leopard rather than making a WebKitSystemInterface call.

  • WebCoreSupport/WebSystemInterface.m: (InitWebCoreSystemInterface): Only initialize wkGetFontMetrics on Tiger.
4:50 PM Changeset in webkit [30655] by mrowe@apple.com
  • 3 edits in branches/Safari-3-1-branch/LayoutTests

Disable http/tests/security/cross-frame-access-location-put.html as postMessage support is disabled on the branch.

3:20 PM Google Summer of Code 2008 edited by Nikolas Zimmermann
(diff)
3:11 PM Changeset in webkit [30654] by pewtermoose@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Tim Hatcher.

Bug 16535: Stylesheets loaded with @import are not editable
​http://bugs.webkit.org/show_bug.cgi?id=16535
<rdar://problem/5712899>

Sheets loaded using @import were incorrectly being flagged as non-editable
user agent sheets because their parent sheet doesn't have an ownerNode. We now
check to make sure sheets also don't have a href before restricting their editability.

  • page/inspector/StylesSidebarPane.js:
2:52 PM Changeset in webkit [30653] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebCore

2008-02-28 Dave Hyatt <​hyatt@apple.com>

Reviewed by Darin Adler.

Fix <rdar://problem/5771994> REGRESSION: Loading HTML5 spec is 5x slower on TOT than in 3.0.4.

Disable dynamic updating of the + selector when the DOM changes, since it hurt performance on the HTML5 spec.

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkSelector):
2:24 PM Changeset in webkit [30652] by mrowe@apple.com
  • 3 edits
    4 deletes in branches/Safari-3-1-branch

Roll r29976, r29977 and r29978 out of Safari-3-1-branch.

2:16 PM Changeset in webkit [30651] by ggaren@apple.com
  • 2 edits in trunk/JavaScriptCore

Reviewed by Geoffrey Garen.

TOTAL : 1.005x as fast 2867.6ms +/- 0.4% 2853.2ms +/- 0.3% significant

  • kjs/nodes.cpp: Tell the compiler that exceptions are unexpected (for the sake of branch prediction and code organization).
12:46 PM Changeset in webkit [30650] by pewtermoose@webkit.org
  • 9 edits
    1 copy in trunk/WebCore

2008-02-28 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Adam Roben.

Copy PluginPackageWin.cpp to shared PluginPackage.cpp.
Add PluginPackage.cpp to build configurations.
Remove PluginPackage destructor from TemporaryLinkStubs.cpp.
Use cross-platform pathGetFilename method.
Remove platform-specific code from shared PluginPackage implementation.
Remove shared code from PluginPackageWin.cpp.

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCoreSources.bkl:
  • WebCore.vcproj/WebCore.vcproj:
  • platform/gtk/TemporaryLinkStubs.cpp:
  • platform/qt/TemporaryLinkStubs.cpp:
  • platform/wx/TemporaryLinkStubs.cpp:
  • plugins/PluginPackage.cpp:
  • plugins/win/PluginPackageWin.cpp:
12:42 PM Changeset in webkit [30649] by justin.garcia@apple.com
  • 32 edits
    8 adds
    6 deletes in trunk

WebCore:

Reviewed by Darin Adler.

<rdar://problem/4930986> REGRESSION: Paste As Quotation pastes black text instead of blue


Add a second style span at copy time to hold document default styles. This helps us
differentiate between those and user applied styles at paste time, where we'll want
to let Mail's Paste As Quotation blockquote override document default styles, but
not others.

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Changed the unit type used for -webkit-text-stroke-width from CSS_NUMBER to CSS_PX, to match other properties that are thick | medium | thin | <length>. Before, there was a mismatch between the unit type of -webkit-text-stroke-width property values in a CSSComputedStyleDeclaration for an element and that element's inlineStyleDecl(), causing identical values to always appear different to diff().
  • editing/ReplaceSelectionCommand.cpp: (WebCore::ReplaceSelectionCommand::handlePasteAsQuotationNode): Fixed. Don't just change the class to an empty string, completely remove it, it's no longer needed. (WebCore::handleStyleSpansBeforeInsertion): Moved the optimization from doApply here. (WebCore::ReplaceSelectionCommand::handleStyleSpans): Added, replaces removeRedundantStyles. We aren't (yet) removing all redundant styles, just those on style spans, so I removed the unused code and renamed the function. There won't be more than two style spans that we need to consider, the one with the source document's default styles and styles on the commonAncestor of the copied Range, so don't look for more than two. Let elements that wrap the incoming fragment override the source document's styles. (WebCore::ReplaceSelectionCommand::doApply): Moved code to handleStyleSpansBeforeInsertion and call the renamed handleStyleSpans.
  • editing/ReplaceSelectionCommand.h:
  • editing/markup.cpp: (WebCore::removeDefaultStyles): Added. Don't add document defaults to the style span that holds user applied styles, since they'll be added to their own style span. (WebCore::createMarkup): Add a second style span that holds just the document defaults. This lets us differentiate between those and user applied styles at paste time. Mail blockquotes are just another type of special element, moved their handling there. This also lets paste code make assumptions about the position of the two style spans (they are *always* parent-child).

LayoutTests:

Reviewed by Darin Adler.


<rdar://problem/4930986> REGRESSION: Paste As Quotation pastes black text instead of blue

Demonstrates the bug:

  • editing/pasteboard/4930986-1-expected.txt: Added.
  • editing/pasteboard/4930986-1.html: Added.
  • editing/pasteboard/4930986-2-expected.txt: Added.
  • editing/pasteboard/4930986-2.html: Added.


Demonstrates a problem with the first version of the patch:

  • editing/pasteboard/4930986-3-expected.txt: Added.
  • editing/pasteboard/4930986-3.html: Added.


Visual problem fixed. An anonymous renderer changed position, DOM remains unchanged:

  • editing/execCommand/5144139-1.html:
  • platform/mac/editing/execCommand/5144139-1-expected.checksum:
  • platform/mac/editing/execCommand/5144139-1-expected.png:
  • platform/mac/editing/execCommand/5144139-1-expected.txt:

Removed unnecessary style spans, visual result unchanged:

  • platform/mac/editing/pasteboard/merge-end-blockquote-expected.checksum:
  • platform/mac/editing/pasteboard/merge-end-blockquote-expected.png:
  • platform/mac/editing/pasteboard/merge-end-blockquote-expected.txt:
  • platform/mac/editing/style/font-family-with-space-expected.checksum:
  • platform/mac/editing/style/font-family-with-space-expected.png:
  • platform/mac/editing/style/font-family-with-space-expected.txt:


A style span isn't removed because at paste time because we don't anticipate
encountering styles on style spans that are non-inheritable, because we don't
create style spans like that at copy time. Turned this into a text only
test. Test remains visually unchanged:

  • editing/pasteboard/5245519-expected.txt: Added.
  • editing/pasteboard/5245519.html:
  • platform/mac/editing/pasteboard/5245519-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/5245519-expected.png: Removed.
  • platform/mac/editing/pasteboard/5245519-expected.txt: Removed.

Added an extra empty anonymous renderer, DOM and visual result remain unchanged:

  • platform/mac/editing/execCommand/create-list-with-hr-expected.checksum:
  • platform/mac/editing/execCommand/create-list-with-hr-expected.png:
  • platform/mac/editing/execCommand/create-list-with-hr-expected.txt:
  • platform/mac/editing/pasteboard/paste-list-001-expected.checksum:
  • platform/mac/editing/pasteboard/paste-list-001-expected.png:
  • platform/mac/editing/pasteboard/paste-list-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-table-001-expected.checksum:
  • platform/mac/editing/pasteboard/paste-table-001-expected.png:
  • platform/mac/editing/pasteboard/paste-table-001-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-003-expected.checksum:
  • platform/mac/editing/pasteboard/paste-text-003-expected.png:
  • platform/mac/editing/pasteboard/paste-text-003-expected.txt:


Reflects changes to CSSComputedStyleDeclaration::getPropertyCSSValue:

  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:


We don't remove styles from style spans that are overridden by all of their
children, even though they are unnecessary. We've never done this, but now
that there can be two style spans at paste time we are more likely to have
a style span left over because of this problem. Mentioned this in the test
case and turned this into a text only test:

  • editing/pasteboard/4840662.html:
  • editing/pasteboard/4840662-expected.txt: Added.
  • platform/mac/editing/pasteboard/4840662-expected.checksum: Removed.
  • platform/mac/editing/pasteboard/4840662-expected.png: Removed.
  • platform/mac/editing/pasteboard/4840662-expected.txt: Removed.
12:24 PM Changeset in webkit [30648] by pewtermoose@webkit.org
  • 3 edits in trunk/WebCore

2008-02-28 Brent Fulgham <​bfulgham@gmail.com>

​http://bugs.webkit.org/show_bug.cgi?id=17576
Modify RenderThemeWin to use SOFT_LINK

Reviewed by Adam Roben.

  • rendering/RenderThemeWin.h: Remove unneeded library handle
  • rendering/RenderThemeWin.cpp: Change to use SOFT_LINK rather than hand-coded load library calls.
10:19 AM Changeset in webkit [30647] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • page/mac/FrameMac.mm: (WebCore::Frame::matchLabelsAgainstElement): Added an early return in case the element name is empty.
1:26 AM Changeset in webkit [30646] by justin.garcia@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dan Bernstein


Small editing speed up.


  • dom/Position.cpp: (WebCore::Position::upstream): Don't check for a change in editability if the current node hasn't changed. (WebCore::Position::downstream): Ditto.
12:21 AM Changeset in webkit [30645] by alp@webkit.org
  • 2 edits in trunk

2008-02-28 Alp Toker <​alp@atoker.com>

Fix a configure script typo spotted by Kalle Vahlman.

  • configure.ac:
Note: See TracTimeline for information about the timeline view.