Timeline



Mar 25, 2008:

11:46 PM Changeset in webkit [31309] by Beth Dakin
  • 10 edits
    5 adds in trunk

WebCore:

2008-03-25 Beth Dakin <Beth Dakin>

Reviewed by Oliver.

Fix for <rdar://problem/5811826> CSSValueList::item() does not
range-check index

Check bounds before accessing the item to avoid a crash.
itemWithoutBoundsCheck() is still inlined and not bounds-checked to
avoid slowing down our internal callers of item().

  • css/CSSValueList.cpp: (WebCore::CSSValueList::item):
  • css/CSSValueList.h: (WebCore::CSSValueList::itemWithoutBoundsCheck):

Call itemWithoutBoundsCheck() to avoid slowing down these internal
callers.

  • css/CSSFontSelector.cpp: (WebCore::CSSFontSelector::addFontFaceRule):
  • css/CSSMutableStyleDeclaration.cpp: (WebCore::CSSMutableStyleDeclaration::getLayeredShorthandValue):
  • css/CSSStyleSelector.cpp: (WebCore::applyCounterList): (WebCore::CSSStyleSelector::applyProperty):
  • css/MediaQueryEvaluator.cpp: (WebCore::parseAspectRatio):
  • svg/SVGFontFaceElement.cpp: (WebCore::SVGFontFaceElement::rebuildFontFace):
  • svg/graphics/SVGPaintServer.cpp: (WebCore::dashArrayFromRenderingStyle):

LayoutTests:

2008-03-25 Beth Dakin <Beth Dakin>

Reviewed by Oliver.

Test for <rdar://problem/5811826> CSSValueList::item() does not
range-check index

  • fast/css/resources/bikes.bmp: Added.
  • fast/css/value-list-out-of-bounds-crash.html: Added.
  • platform/mac/fast/css/value-list-out-of-bounds-crash-expected.checksum: Added.
  • platform/mac/fast/css/value-list-out-of-bounds-crash-expected.png: Added.
  • platform/mac/fast/css/value-list-out-of-bounds-crash-expected.txt: Added.
9:24 PM Changeset in webkit [31308] by Adam Roben
  • 2 edits in trunk/WebKitTools

Windows build fix

  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Add $(WebKitLibrariesDir)\include to the include path so we can find stdint.h there.
8:41 PM Changeset in webkit [31307] by Antti Koivisto
  • 2 edits in trunk/WebCore

2008-03-25 Antti Koivisto <Antti Koivisto>

Reviewed by Oliver.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=18082
REGRESSION (r31287): GMail does not work if user stylesheet is set


Oops, my cache refactoring patch was missing these rather essential lines for
user stylesheets. They would get reloaded repeatedly.

  • loader/Cache.cpp: (WebCore::Cache::requestUserCSSStyleSheet):
8:38 PM squirrelfish edited by ggaren@apple.com
(diff)
8:11 PM squirrelfish edited by ggaren@apple.com
(diff)
7:14 PM Changeset in webkit [31306] by Adam Roben
  • 2 edits in trunk/WebKit/win

Attempted build fix

  • WebKit.vcproj/WebKit.sln: Make testapi build after most other projects.
7:09 PM squirrelfish edited by ggaren@apple.com
(diff)
6:35 PM Changeset in webkit [31305] by pewtermoose@webkit.org
  • 1 edit in trunk/WebCore/ChangeLog

Correct ChangeLog.

6:32 PM Changeset in webkit [31304] by pewtermoose@webkit.org
  • 2 edits in trunk/WebCore

2008-03-25 Matt Lilek <​webkit@mattlilek.com>

Rubber stamped by Adam

Roll out r30300 since it causes assertion failures on page load.
See ​http://bugs.webkit.org/show_bug.cgi?id=18093

  • page/InspectorController.cpp: (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
6:07 PM Changeset in webkit [31303] by Darin Adler
  • 6 edits
    3 adds in trunk

WebCore:

2008-03-25 Darin Adler <Darin Adler>

Reviewed by Anders.

Test: traversal/acid3-test-2.html

  • bindings/js/JSNodeIteratorCustom.cpp: (WebCore::JSNodeIterator::nextNode): Update since result is PassRefPtr. (WebCore::JSNodeIterator::previousNode): Ditto.
  • dom/NodeIterator.cpp: (WebCore::NodeIterator::nextNode): Changed result to PassRefPtr. Added code to track both the current candidate (which needs to move along to the next node if current node is deleted) and the current provisional result (passed to acceptNode, and needs to be returned even if it's deleted). (WebCore::NodeIterator::previousNode): Ditto. (WebCore::NodeIterator::nodeWillBeRemoved): Call updateForNodeRemoval for m_candidateNode as well as m_referenceNode.
  • dom/NodeIterator.h: Use PassRefPtr for return values.

LayoutTests:

2008-03-25 Darin Adler <Darin Adler>

Reviewed by Anders.

  • traversal/acid3-test-2-expected.txt: Added.
  • traversal/acid3-test-2.html: Added.
  • traversal/resources/acid3-test-2.js: Added.
  • traversal/resources/exception-forwarding.js: Removed bogus extra line of code.
5:29 PM Changeset in webkit [31302] by beidson@apple.com
  • 5 edits in trunk/WebCore

2008-03-25 Brady Eidson <​beidson@apple.com>

Reviewed by Anders

Add the ability to transform a CString into a SharedBuffer to avoid copying data
This is valuable to avoid copying a block of data for an upcoming patch

  • platform/SharedBuffer.cpp: (WebCore::SharedBuffer::adoptVector):
  • platform/SharedBuffer.h:
  • platform/text/CString.cpp: (WebCore::CString::releaseBuffer):
  • platform/text/CString.h: (WebCore::CStringBuffer::releaseBuffer):
4:46 PM Changeset in webkit [31301] by beidson@apple.com
  • 2 edits in trunk/WebCore

2008-03-25 Brady Eidson <​beidson@apple.com>

Attempt to fix .bkl build systems after recent archive additions

  • webcore-base.bkl:
4:43 PM Changeset in webkit [31300] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-03-25 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Adam.

  • Cleaned up the needless use of RefPtrs, which we may someday no longer use for InspectorResources.
  • page/InspectorController.cpp: (WebCore::InspectorController::didFinishLoading): (WebCore::InspectorController::didFailLoading):
4:40 PM Changeset in webkit [31299] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-03-25 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Adam.

  • Added a null check
  • xml/XMLHttpRequest.cpp: Null check (WebCore::XMLHttpRequest::send):
4:32 PM Changeset in webkit [31298] by kmccullough@apple.com
  • 5 edits in trunk/WebCore

2008-03-25 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Tim.

-<rdar://problem/5712804> XMLHttpRequests do not show response contents, preview images (14313)
-<rdar://problem/5712931> XMLHttpRequests should be shown separately and grouped (14315)
-<rdar://problem/5732836> XMLHttpRequest: Inspector should show network activity/XHR in Console (17233)

  • XMLHttpRequestResources now identify themselves to the inspector which caches the data related to the request since no one else caches it. However this is just the plumbing and the Inspector's UI has not been changed to show XHR resources yet.
  • page/InspectorController.cpp: Add ability to set XHR data on an InspectorResource. (WebCore::XMLHttpRequestResource::XMLHttpRequestResource): (WebCore::XMLHttpRequestResource::data): (WebCore::XMLHttpRequestResource::encoding): (WebCore::InspectorResource::): Add new type. (WebCore::InspectorResource::~InspectorResource): No longer virtual since we are not using inheritance. (WebCore::InspectorResource::type): Ditto. (WebCore::InspectorResource::setXMLHttpRequestResource): (WebCore::InspectorResource::isXHR): (WebCore::InspectorResource::xmlHttpRequestData): (WebCore::InspectorResource::xmlHttpRequestEncoding): (WebCore::InspectorResource::InspectorResource): (WebCore::addSourceToFrame): (WebCore::InspectorController::resourceRetrievedByXMLHttpRequest):
  • page/InspectorController.h: Add accessor for setting the XHR data.
  • page/inspector/Resource.js: Keep the XHR resource types in sync with the Inspector Controller.
  • xml/XMLHttpRequest.cpp: Give the InspectorController the XHR information to cache. (WebCore::XMLHttpRequest::send):
4:23 PM Changeset in webkit [31297] by Adam Roben
  • 4 edits
    3 adds in trunk

Fix Bug 18077: Integrate testapi.c into the Windows build

JavaScriptCore:

Fix Bug 18077: Integrate testapi.c into the Windows build

<​http://bugs.webkit.org/show_bug.cgi?id=18077>

Reviewed by Steve Falkenburg.

WebCore:

Add an UnusedParam.h forwarding header for use by testapi

Reviewed by Steve Falkenburg.

  • ForwardingHeaders/wtf/UnusedParam.h: Added.

WebKit/win:

Fix Bug 18077: Integrate testapi.c into the Windows build

<​http://bugs.webkit.org/show_bug.cgi?id=18077>

Reviewed by Steve Falkenburg.

  • WebKit.vcproj/WebKit.sln: Added testapi.vcproj to the solution.
4:23 PM Changeset in webkit [31296] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Make testapi.c compile under MSVC

Currently you must compile testapi.c as C++ code since MSVC does not
support many C features that GCC does.

Reviewed by Steve Falkenburg.

  • API/testapi.c: (nan): Added an implementation of this for MSVC. (assertEqualsAsUTF8String): Use malloc instead of dynamically-sized stack arrays. (assertEqualsAsCharactersPtr): Ditto. (print_callAsFunction): Ditto. (main): Ditto, and explicitly cast from UniChar* to JSChar*.
4:23 PM Changeset in webkit [31295] by Adam Roben
  • 3 edits in trunk/JavaScriptCore

Stop using JavaScriptCore's custom stdbool.h and stdint.h on Windows

We can't remove the os-win32 directory yet because other ports (at
least wx) are still relying on it.

Reviewed by Steve Falkenburg.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
    • Made all the include paths match the one for the Debug configuration (these got out of sync in r30797)
    • Removed os-win32 from the include path
    • Removed os-win32 from the directories we copy to $WebKitOutputDir.
    • Removed stdint.h from the project
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Delete the files that we may have previously copied from the os-win32 directory.
4:00 PM Changeset in webkit [31294] by beidson@apple.com
  • 3 edits in trunk/WebKit/mac

2008-03-25 Brady Eidson <​beidson@apple.com>

Reviewed by Beth Dakin

Remove entirely unused internal method

  • WebView/WebArchiver.h:
  • WebView/WebArchiver.mm:
3:37 PM Changeset in webkit [31293] by beidson@apple.com
  • 7 edits in trunk

WebCore:

2008-03-25 Brady Eidson <​beidson@apple.com>

Reviewed by Adam Roben

<rdar://problem/5819308> - View Source is empty when view webarchives

  • WebCore.base.exp:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setParsedArchiveData): (WebCore::DocumentLoader::parsedArchiveData):
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument): Set the archive's MainResource data as the parsedArchiveData in the DocumentLoader

WebKit/mac:

2008-03-25 Brady Eidson <​beidson@apple.com>

Reviewed by Adam Roben

<rdar://problem/5819308> - View Source is empty when view webarchives

  • WebCore.base.exp:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setParsedArchiveData): (WebCore::DocumentLoader::parsedArchiveData):
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::finishedLoadingDocument): Set the archive's MainResource data as the parsedArchiveData in the DocumentLoader
3:17 PM Changeset in webkit [31292] by mitz@apple.com
  • 2 edits in trunk/WebKit/mac

Reviewed by Darin Adler.

  • WebView/WebHTMLView.mm: (-[WebHTMLView layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]): Added null check.
2:57 PM Changeset in webkit [31291] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

2008-03-25 Brady Eidson <​beidson@apple.com>

Reviewed by Jon Honeycutt's rubberstamp

Fix a leak with the new WebArchive setup

  • WebView/WebArchive.mm: (-[WebArchivePrivate setCoreArchive:]): Deref() the old WebArchive
2:28 PM Changeset in webkit [31290] by eric@webkit.org
  • 2 edits in trunk/WebCore

Reviewed by Oliver.

Speculative crash fix for Acid3 crasher.
I couldn't figure out how to make a test case for this?
Suggestions welcome.

  • css/CSSFontSelector.cpp: null check document->renderer()
1:29 PM Changeset in webkit [31289] by ap@webkit.org
  • 2 edits in trunk/JavaScriptCore

Windows build fix.

  • kjs/dtoa.cpp: Include stdint.h.
12:43 PM Changeset in webkit [31288] by ap@webkit.org
  • 3 edits in trunk/JavaScriptCore

Rubber-stamped by Darin.

Cleanup dtoa.cpp style.

  • kjs/dtoa.cpp: (Bigint::Balloc): (Bigint::Bfree): (Bigint::multadd): (Bigint::s2b): (Bigint::hi0bits): (Bigint::lo0bits): (Bigint::i2b): (Bigint::mult): (Bigint::pow5mult): (Bigint::lshift): (Bigint::cmp): (Bigint::diff): (Bigint::ulp): (Bigint::b2d): (Bigint::d2b): (Bigint::ratio): (Bigint::): (Bigint::match): (Bigint::hexnan): (Bigint::kjs_strtod): (Bigint::quorem): (Bigint::rv_alloc): (Bigint::nrv_alloc): (Bigint::kjs_freedtoa): (Bigint::kjs_dtoa):
  • kjs/dtoa.h:
12:21 PM Changeset in webkit [31287] by Antti Koivisto
  • 21 edits in trunk/WebCore

2008-03-25 Antti Koivisto <Antti Koivisto>

Reviewed by Geoff Garen.

Some memory cache cleanups:

  • Separate CachedResource loading from construction, initiate load using a separate load() method.
  • Add special case function to Cache for loading user stylesheets. This allows removal of a bunch of parameters from several methods and CachedResource constructors.
  • Construct CachedResources with m_inCache set to false which is quite a bit more logical as they are not yet in the cache at that point.
  • Pass encoding around as const String& instead of const String*.
  • css/CSSImageValue.cpp: (WebCore::CSSImageValue::image):
  • html/HTMLImageLoader.cpp: (WebCore::HTMLImageLoader::updateFromElement):
  • loader/Cache.cpp: (WebCore::createResource): (WebCore::Cache::requestResource): (WebCore::Cache::requestUserCSSStyleSheet): (WebCore::Cache::remove):
  • loader/Cache.h:
  • loader/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
  • loader/CachedCSSStyleSheet.h:
  • loader/CachedFont.cpp: (WebCore::CachedFont::CachedFont): (WebCore::CachedFont::load): (WebCore::CachedFont::ref):
  • loader/CachedFont.h:
  • loader/CachedImage.cpp: (WebCore::CachedImage::CachedImage): (WebCore::CachedImage::load):
  • loader/CachedImage.h:
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource): (WebCore::CachedResource::~CachedResource): (WebCore::CachedResource::load):
  • loader/CachedResource.h: (WebCore::CachedResource::load):
  • loader/CachedScript.cpp: (WebCore::CachedScript::CachedScript):
  • loader/CachedScript.h:
  • loader/CachedXBLDocument.cpp: (WebCore::CachedXBLDocument::CachedXBLDocument):
  • loader/CachedXBLDocument.h:
  • loader/CachedXSLStyleSheet.cpp: (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
  • loader/CachedXSLStyleSheet.h:
  • loader/DocLoader.cpp: (WebCore::DocLoader::requestImage): (WebCore::DocLoader::requestFont): (WebCore::DocLoader::requestCSSStyleSheet): (WebCore::DocLoader::requestUserCSSStyleSheet): (WebCore::DocLoader::requestScript): (WebCore::DocLoader::requestXSLStyleSheet): (WebCore::DocLoader::requestXBLDocument): (WebCore::DocLoader::requestResource): (WebCore::DocLoader::preload):
  • loader/DocLoader.h:
12:12 PM Changeset in webkit [31286] by Darin Adler
  • 7 edits in trunk/WebCore

2008-03-25 Darin Adler <Darin Adler>

Reviewed by Anders.

  • avoid converting UString to String and then later to AtomicString

1% speedup on Acid3 test 26

This is inefficient for the case where there's already an AtomicString.
By first creating and destroying a String we waste time.

  • bindings/scripts/CodeGeneratorJS.pm: Use const UString& for string arguments rather than using String; this uses the object as it's produced from toString rather than creating a new temporary object that might not be of the right type. The type conversion happens at the callsite instead. Also eliminate the ability to use the type AtomicString from IDL.
  • dom/KeyboardEvent.idl: AtomicString -> DOMString.
  • dom/MouseEvent.idl: Ditto.
  • dom/MutationEvent.idl: Ditto.
  • dom/UIEvent.idl: Ditto.
  • svg/SVGStyleElement.idl: Ditto.
11:05 AM Changeset in webkit [31285] by beidson@apple.com
  • 2 edits in trunk/WebCore

2008-03-25 Brady Eidson <​beidson@apple.com>

Build fix for non-CoreFoundation platforms

  • loader/archive/ArchiveFactory.cpp:
11:00 AM Changeset in webkit [31284] by beidson@apple.com
  • 3 edits in trunk/WebKit/mac

2008-03-25 Brady Eidson <​beidson@apple.com>

Reviewed by Darin

Removed the concept of "pending archive resources" and the "archive resources delivery timer"
from WebFrameLoaderClient, as those concepts have been pushed into WebCore

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::WebFrameLoaderClient):
10:44 AM Changeset in webkit [31283] by beidson@apple.com
  • 18 edits in trunk

WebCore:

2008-03-25 Brady Eidson <​beidson@apple.com>

Reviewed by Darin

Remove newly obsolete FrameLoaderClient methods

  • loader/FrameLoaderClient.h:
  • svg/graphics/SVGImageEmptyClients.h: (WebCore::SVGEmptyFrameLoaderClient::setMainDocumentError): (WebCore::SVGEmptyFrameLoaderClient::finishedLoading):

WebKit/gtk:

2008-03-25 Brady Eidson <​beidson@apple.com>

Reviewed by Darin

Remove newly obsolete FrameLoaderClient methods

  • WebCoreSupport/FrameLoaderClientGtk.cpp:
  • WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

2008-03-25 Brady Eidson <​beidson@apple.com>

Reviewed by Darin

Remove newly obsolete FrameLoaderClient methods

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

WebKit/qt:

2008-03-25 Brady Eidson <​beidson@apple.com>

Reviewed by Darin

Remove newly obsolete FrameLoaderClient methods

  • WebCoreSupport/FrameLoaderClientQt.cpp:
  • WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

2008-03-25 Brady Eidson <​beidson@apple.com>

Reviewed by Darin

Remove newly obsolete FrameLoaderClient methods

  • WebFrame.cpp:
  • WebFrame.h:

WebKit/wx:

2008-03-25 Brady Eidson <​beidson@apple.com>

Reviewed by Darin

Remove newly obsolete FrameLoaderClient methods

  • WebKitSupport/FrameLoaderClientWx.cpp:
  • WebKitSupport/FrameLoaderClientWx.h:
10:41 AM Maintenance and architecture list edited by Darin Adler
Remove mention of bridge since it's gone now! (diff)
10:29 AM Changeset in webkit [31282] by beidson@apple.com
  • 2 edits in trunk/WebKit/mac

2008-03-25 Brady Eidson <​beidson@apple.com>

Release build fix

  • WebView/WebArchive.mm: (-[WebArchive subresources]): (-[WebArchive subframeArchives]):
10:11 AM Changeset in webkit [31281] by beidson@apple.com
  • 31 edits
    2 adds
    2 deletes in trunk

WebCore:

2008-03-25 Brady Eidson <​beidson@apple.com>

Reviewed by Darin

<rdar://problem/4516169> - Support WebArchives on Windows
And pave the way for many future WebArchive bug fixes and enhancements

This patch accomplishes two main goals:
1 - Consolidates much of the spread out WebKitMac archive code into one place in WebCore. This allows for cleaner refactoring

in the future as well as adding more archive formats with ease.

2 - Hooks up WebArchive support on Windows. Safari-style .webarchive files are nothing more than property lists readable by

CoreFoundation. While there are still some outstanding issues, including an NSKeyedArchiver chunk of data for the
ResourceResponse for each resource, this patch manually parses through the property list on CoreFoundation platforms and
gets many archives loading on Windows

My goal for this first cut was zero behavior change. As such, I went for a direct port of the WebKitMac code. There will be
opportunities for redesign and refactoring as followups.

  • WebCore.base.exp:
  • loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setupForReplaceByMIMEType): Ported from WebKitMac, WebDataSource (WebCore::DocumentLoader::addAllArchiveResources): (WebCore::DocumentLoader::addArchiveResource): (WebCore::DocumentLoader::archiveResourceForURL): (WebCore::DocumentLoader::popArchiveForSubframe): (WebCore::DocumentLoader::clearArchiveResources):
  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp: Moved WebFrameLoaderClient and WebFrame code down into their more appropriate FrameLoader home (WebCore::FrameLoader::FrameLoader): (WebCore::FrameLoader::setDefersLoading): (WebCore::FrameLoader::deliverArchivedResourcesAfterDelay): (WebCore::FrameLoader::archiveResourceDeliveryTimerFired): (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::loadArchive): (WebCore::FrameLoader::scheduleArchiveLoad): (WebCore::FrameLoader::stopAllLoaders): (WebCore::FrameLoader::cancelPendingArchiveLoad): (WebCore::FrameLoader::isArchiveLoadPending): (WebCore::FrameLoader::finishedLoadingDocument):
  • loader/FrameLoader.h:
  • loader/ResourceLoader.cpp: (WebCore::ResourceLoader::load):
  • loader/archive/Archive.h: Generic "Archive of web resources" class that is only useful when subclassed.

Contains a MainResource, subresources, and Archives for subframes

(WebCore::Archive::mainResource):
(WebCore::Archive::subresources):
(WebCore::Archive::subframeArchives):
(WebCore::Archive::setMainResource):
(WebCore::Archive::addSubresource):
(WebCore::Archive::addSubframeArchive):

  • loader/archive/ArchiveFactory.cpp: A class that will take raw archive data and the MIMEtype, and create the

appropriate Archive class for it. Additionally it handles registering the known MIMEtypes for all known archive formats

(WebCore::archiveFactoryCreate):
(WebCore::archiveMIMETypes):
(WebCore::ArchiveFactory::isArchiveMimeType):
(WebCore::ArchiveFactory::create):
(WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):

  • loader/archive/ArchiveFactory.h:
  • loader/archive/ArchiveResource.cpp: Analog to "WebResource" in WebKitMac. Contains the data and other important

attributes of an archived resource

(WebCore::ArchiveResource::create):
(WebCore::ArchiveResource::ArchiveResource):
(WebCore::ArchiveResource::response):

  • loader/archive/ArchiveResource.h: (WebCore::ArchiveResource::data): (WebCore::ArchiveResource::url): (WebCore::ArchiveResource::mimeType): (WebCore::ArchiveResource::textEncoding): (WebCore::ArchiveResource::frameName): (WebCore::ArchiveResource::ignoreWhenUnarchiving): (WebCore::ArchiveResource::shouldIgnoreWhenUnarchiving):
  • loader/archive/ArchiveResourceCollection.cpp: Analog of "WebUnarchivingState" in WebKitMac. Contains a hash of

all the resources for every frame in an archive, and contains the archives for each subframe needed to load a multi-frame archive

(WebCore::ArchiveResourceCollection::ArchiveResourceCollection):
(WebCore::ArchiveResourceCollection::addAllResources):
(WebCore::ArchiveResourceCollection::addResource):
(WebCore::ArchiveResourceCollection::archiveResourceForURL):
(WebCore::ArchiveResourceCollection::popSubframeArchive):

  • loader/archive/ArchiveResourceCollection.h:
  • loader/archive/cf/LegacyWebArchive.cpp: Subclass of Archive specifically for Webkit's Objective-C based ".webarchive" format.

Mostly a collection of static methods involved in parsing and serializing a WebKit-style .webarchive. Is mostly supported
for any CF platform.

(WebCore::createPropertyListRepresentationFromResource):
(WebCore::createPropertyListRep):
(WebCore::createResourceResponseFromPropertyListData):
(WebCore::createResource):
(WebCore::LegacyWebArchive::create):
(WebCore::LegacyWebArchive::LegacyWebArchive):
(WebCore::LegacyWebArchive::init):
(WebCore::LegacyWebArchive::extract):
(WebCore::LegacyWebArchive::rawDataRepresentation):
(WebCore::createResourceResponseFromMacArchivedData):
(WebCore::propertyListDataFromResourceResponse):

  • loader/archive/cf/LegacyWebArchive.h:
  • loader/archive/cf/LegacyWebArchiveMac.mm: (WebCore::createResourceResponseFromMacArchivedData): (WebCore::propertyListDataFromResourceResponse):
  • platform/network/mac/ResourceRequest.h:
  • platform/network/mac/ResourceRequestMac.mm: (WebCore::ResourceRequest::applyWebArchiveHackForMail): Tweak the resource request for Mac clients when loading WebArchives

WebKit:

2008-03-25 Brady Eidson <​beidson@apple.com>

Reviewed by Darin

<rdar://problem/4516169> - Support WebArchives on Windows

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-03-25 Brady Eidson <​beidson@apple.com>

Reviewed by Darin

<rdar://problem/4516169> - Support WebArchives on Windows
And paves the way for many future WebArchive bug fixes and enhancements

This change moves most of the real workhorse code about WebArchives into WebCore. It maintains
1-to-1 relationships between a few objects in WebCore and WebKit. Such as:

  • WebArchive <-> LegacyWebArchive
  • WebResource <-> ArchiveResource
  • WebUnarchivingState <-> ArchiveResourceCollection


The other biggest changes involve many FrameLoaderClient methods that existed soley for WebArchives
and now exist in WebCore

  • WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::clearUnarchivingState): Emptied - to be removed in a followup patch (WebFrameLoaderClient::finalSetupForReplace): (WebFrameLoaderClient::setDefersLoading): (WebFrameLoaderClient::willUseArchive): (WebFrameLoaderClient::isArchiveLoadPending): (WebFrameLoaderClient::cancelPendingArchiveLoad): (WebFrameLoaderClient::clearArchivedResources): (WebFrameLoaderClient::createFrame):
  • WebView/WebArchive.mm: (+[WebArchivePrivate initialize]): (-[WebArchivePrivate init]): (-[WebArchivePrivate initWithCoreArchive:]): (-[WebArchivePrivate coreArchive]): (-[WebArchivePrivate setCoreArchive:]): (-[WebArchivePrivate dealloc]): (-[WebArchivePrivate finalize]): (-[WebArchive init]): (-[WebArchive initWithMainResource:subresources:subframeArchives:]): (-[WebArchive initWithData:]): (-[WebArchive initWithCoder:]): (-[WebArchive encodeWithCoder:]): (-[WebArchive mainResource]): (-[WebArchive subresources]): (-[WebArchive subframeArchives]): (-[WebArchive data]): (-[WebArchive _initWithCoreLegacyWebArchive:WebCore::]): (-[WebArchive WebCore::]):
  • WebView/WebArchiveInternal.h: Added.
  • WebView/WebDataSource.mm: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _addSubframeArchives:]): (-[WebDataSource _documentFragmentWithArchive:]): (-[WebDataSource subresourceForURL:]): (-[WebDataSource addSubresource:]):
  • WebView/WebDataSourceInternal.h:
  • WebView/WebFrame.mm: (-[WebFrame loadArchive:]):
  • WebView/WebFrameInternal.h:
  • WebView/WebHTMLRepresentation.mm: (-[WebHTMLRepresentation finishedLoadingWithDataSource:]):
  • WebView/WebResource.mm: (+[WebResourcePrivate initialize]): (-[WebResourcePrivate init]): (-[WebResourcePrivate initWithCoreResource:]): (-[WebResourcePrivate dealloc]): (-[WebResourcePrivate finalize]): (-[WebResource initWithCoder:]): (-[WebResource encodeWithCoder:]): (-[WebResource data]): (-[WebResource URL]): (-[WebResource MIMEType]): (-[WebResource textEncodingName]): (-[WebResource frameName]): (-[WebResource _initWithCoreResource:WebCore::]): (-[WebResource WebCore::]): (-[WebResource _ignoreWhenUnarchiving]): (-[WebResource _initWithData:URL:MIMEType:textEncodingName:frameName:response:copyData:]): (-[WebResource _fileWrapperRepresentation]): (-[WebResource _response]): (-[WebResource _stringValue]):
  • WebView/WebResourceInternal.h: Added.
  • WebView/WebResourcePrivate.h:
  • WebView/WebUnarchivingState.h: Removed.
  • WebView/WebUnarchivingState.m: Removed.
9:09 AM Changeset in webkit [31280] by Darin Adler
  • 2 edits in trunk/WebKit/win

2008-03-25 Darin Adler <Darin Adler>

Suggested by Adam.

  • Interfaces/WebKit.idl: Touch this file to make the Interface project rebuild.
7:33 AM QtWebKitTodo edited by Simon Hausmann
(diff)
12:33 AM Changeset in webkit [31279] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-03-25 David Hyatt <​hyatt@apple.com>

Cut and paste error in the zoom code. A width() should have been a height(). Regression tests caught this.

  • page/DOMWindow.cpp: (WebCore::DOMWindow::innerHeight):

Mar 24, 2008:

11:57 PM squirrelfish edited by oliver@apple.com
(diff)
11:56 PM Changeset in webkit [31278] by eric@webkit.org
  • 2 edits in trunk/WebKitTools

Reviewed by Mark.

Clean up SVG features message to be less confusing.

  • Scripts/build-webkit:
11:21 PM squirrelfish edited by cwzwarich@uwaterloo.ca
(diff)
11:20 PM squirrelfish edited by cwzwarich@uwaterloo.ca
(diff)
10:48 PM Changeset in webkit [31277] by ggaren@apple.com
  • 3 edits in branches/squirrelfish/JavaScriptCore

2008-03-24 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Oliver Hunt.


Fixed recent 25% regression on simple for loop test. GCC seems to be
very finicky about the code that gets inlined into
Machine::privateExecute.

Everything in this patch is simply the result of experiment.


The resolve and resolve_base opcodes do not seem to have gotten slower
from this change.

  • VM/Machine.cpp: (KJS::resolve): (KJS::resolveBase): (KJS::Machine::privateExecute):
  • kjs/nodes.h:
10:05 PM Changeset in webkit [31276] by oliver@apple.com
  • 5 edits in branches/squirrelfish/JavaScriptCore

Bug 18059: squirrelfish needs to compile on platforms without computed goto
<​http://bugs.webkit.org/show_bug.cgi?id=18059>

Reviewed by Geoff Garen

"Standard" macro style support for conditionalising the use of computed goto.

10:02 PM Changeset in webkit [31275] by Darin Adler
  • 2 edits in trunk/WebCore

2008-03-24 Darin Adler <Darin Adler>

  • try to fix broken Wx build
  • platform/wx/TemporaryLinkStubs.cpp: (GraphicsContext::setPlatformShadow): (GraphicsContext::clearPlatformShadow):
9:35 PM Changeset in webkit [31274] by oliver@apple.com
  • 3 edits
    1 move in trunk

Bug 18030: REGRESSION(r31236): Space bar fails to scroll down page
<​http://bugs.webkit.org/show_bug.cgi?id=18030>

Reviewed by Mark Rowe

Rollout keyDown changes from r31236 -- fix for keyDown behaviour is
tracked by Bug 18057: keyDown incorrectly propagates up the frame tree
<​http://bugs.webkit.org/show_bug.cgi?id=18057>

9:30 PM Changeset in webkit [31273] by Darin Adler
  • 5 edits in trunk/WebCore

2008-03-24 Darin Adler <Darin Adler>

Reviewed by Sam.

  • use AtomicString more consistently for attribute values

1% speedup on Acid3 test 26

  • dom/Element.cpp: (WebCore::Element::setAttribute): Changed value argument to AtomicString. Also fixed call to lower() to only be done if the name isn't already lowercase. Also took out one unneeded condition in a cascade of if statements. (WebCore::Element::createAttribute): Ditto. (WebCore::Element::setAttributeNS): Ditto.
  • dom/Element.h: Ditto.
  • dom/StyledElement.cpp: (WebCore::StyledElement::createAttribute): Ditto.
  • dom/StyledElement.h: Ditto.
9:28 PM Changeset in webkit [31272] by Darin Adler
  • 3 edits in trunk/WebCore

2008-03-24 Darin Adler <Darin Adler>

Reviewed by Sam.

  • get rid of extra level of function call in toJS functions for Node

0.6% speedup on Acid3 test 26

  • bindings/js/JSNodeCustom.cpp: (WebCore::toJS): Take a raw pointer, not a PassRefPtr, like other toJS functions.
  • bindings/scripts/CodeGeneratorJS.pm: Add an inlined toJS for EventTargetNode* to avoid ambiguity that otherwise exists between the toJS for EventTarget* and for Node*.
8:43 PM Changeset in webkit [31271] by weinig@apple.com
  • 5 edits in trunk/WebKitTools

2008-03-24 Sam Weinig <​sam@webkit.org>

Reviewed by Dave Hyatt.

Add EventSender.zoomPageIn/zoomPageOut support to DRT.

  • DumpRenderTree/mac/DumpRenderTree.mm: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (-[EventSendingController zoomPageIn]): (-[EventSendingController zoomPageOut]):
  • DumpRenderTree/win/DumpRenderTree.cpp: (resetWebViewToConsistentStateBeforeTesting):
  • DumpRenderTree/win/EventSender.cpp: (textZoomInCallback): (textZoomOutCallback): (zoomPageInCallback): (zoomPageOutCallback):
8:39 PM Changeset in webkit [31270] by Darin Adler
  • 2 edits in trunk/JavaScriptCore

2008-03-24 Darin Adler <Darin Adler>

Reviewed by Sam.

  • convert a JavaScript immediate number to a string more efficiently

2% speedup of Acid3 test 26

  • kjs/JSImmediate.cpp: (KJS::JSImmediate::toString): Take advantage of the fact that all immediate numbers are integers, and use the faster UString function for formatting integers instead of the slower one that works for floating point. I think this is a leftover from when immediate numbers were floating point.
8:26 PM Changeset in webkit [31269] by Darin Adler
  • 2 edits in trunk/WebCore

2008-03-24 Darin Adler <Darin Adler>

Reviewed by Hyatt.

  • add fast path to isValidName that does not use advanced Unicode functions

2% speedup on Acid3 test 26

  • dom/Document.cpp: (WebCore::isValidNameNonASCII): Added. Contains the old isValidName function. (WebCore::isValidNameASCII): Added. Contains a simpler function that returns true for most valid names that are also all ASCII. (WebCore::Document::isValidName): Changed to call both of the above functions. The common case is that isValidNameASCII returns true so isValidNameNonASCII is never called.
7:39 PM Changeset in webkit [31268] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2008-03-24 David Hyatt <​hyatt@apple.com>

Fix for bug 18052, window properties need to respect zoom factor.

Reviewed by Beth

  • page/DOMWindow.cpp: (WebCore::DOMWindow::innerHeight): (WebCore::DOMWindow::innerWidth): (WebCore::DOMWindow::scrollX): (WebCore::DOMWindow::scrollY): (WebCore::DOMWindow::scrollTo):
  • page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): (WebCore::FrameView::layout): (WebCore::FrameView::performPostLayoutTasks):
7:26 PM Changeset in webkit [31267] by weinig@apple.com
  • 6 edits in trunk

JavaScriptCore:

2008-03-23 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=18048
The "thisObject" parameter to JSEvaluateScript is not used properly

Making passing a thisObject to JSEvaluateScript actually set the thisObject of the created
ExecState.

  • API/testapi.c: (main): Add tests for setting the thisObject when calling JSEvaluateScript.
  • kjs/ExecState.cpp: (KJS::ExecState::ExecState): Assign the thisObject to m_thisValue and remove the comment.

WebCore:

2008-03-24 Sam Weinig <​sam@webkit.org>

Reviewed by Darin Adler.

Fix ​http://bugs.webkit.org/show_bug.cgi?id=18048
The "thisObject" parameter to JSEvaluateScript is not used properly

  • bindings/js/kjs_proxy.cpp: (WebCore::KJSProxy::evaluate): No need to pass a thisObject since we want the global object to be used.
  • bridge/jni/jni_jsobject.mm: (JavaJSObject::eval): To avoid any change to this function, don't pass a thisObject to keep the same behavior.
6:19 PM Changeset in webkit [31266] by beidson@apple.com
  • 3 edits in trunk/LayoutTests

2008-03-24 Brady Eidson <​beidson@apple.com>

Made new layout test files executable, as needed for the tests to not fail!

  • http/tests/navigation/resources/reload-subframe-content.pl: Added.
  • http/tests/navigation/resources/reload-subframe.pl: Added.
6:10 PM squirrelfish edited by cwzwarich@uwaterloo.ca
(diff)
5:49 PM Changeset in webkit [31265] by ggaren@apple.com
  • 2 edits in branches/squirrelfish/JavaScriptCore

2008-03-24 Geoffrey Garen <​ggaren@apple.com>

Moved my notes from nodes.h to the wiki.

  • kjs/nodes.h:
5:48 PM squirrelfish edited by ggaren@apple.com
(diff)
5:44 PM squirrelfish edited by oliver@apple.com
(diff)
5:44 PM WikiStart edited by ggaren@apple.com
(diff)
5:43 PM squirrelfish edited by ggaren@apple.com
(diff)
5:41 PM squirrelfish created by ggaren@apple.com
initial rough cut of tasks and ideas
5:37 PM Changeset in webkit [31264] by beidson@apple.com
  • 3 edits
    8 adds in trunk

WebKit/mac:

2008-03-24 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej, landed by Brady

Bug 3580: iFrames Appear to be Cached
<​http://bugs.webkit.org/show_bug.cgi?id=3580>

Bug 15486: REGRESSION: Reload causes WebKit to *forget* fragment URLs
<​http://bugs.webkit.org/show_bug.cgi?id=15486>

Bug 15554: Reload causes <object> to use old data
<​http://bugs.webkit.org/show_bug.cgi?id=15554>

If a page is reloaded, a child frame's URL can not be taken from a history item.

  • WebView/WebFrame.mm: (-[WebFrame _loadURL:referrer:intoChild:]):

LayoutTests:

2008-03-24 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Reviewed by Maciej, landed by Brady

Tests for the following bugs:

Bug 3580: iFrames Appear to be Cached
<​http://bugs.webkit.org/show_bug.cgi?id=3580>

Bug 15486: REGRESSION: Reload causes WebKit to *forget* fragment URLs
<​http://bugs.webkit.org/show_bug.cgi?id=15486>

Bug 15554: Reload causes <object> to use old data
<​http://bugs.webkit.org/show_bug.cgi?id=15554>

  • http/tests/navigation/reload-subframe-frame-expected.txt: Added.
  • http/tests/navigation/reload-subframe-frame.html: Added.
  • http/tests/navigation/reload-subframe-iframe-expected.txt: Added.
  • http/tests/navigation/reload-subframe-iframe.html: Added.
  • http/tests/navigation/reload-subframe-object-expected.txt: Added.
  • http/tests/navigation/reload-subframe-object.html: Added.
  • http/tests/navigation/resources/reload-subframe-content.pl: Added.
  • http/tests/navigation/resources/reload-subframe.pl: Added.
5:16 PM Changeset in webkit [31263] by ggaren@apple.com
  • 9 edits
    17 adds in branches/squirrelfish/JavaScriptCore

2008-03-24 Geoffrey Garen <​ggaren@apple.com>

Reviewed by NOBODY.


SquirrelFish lives.


Initial check-in of the code I've been carrying around. Lots of stuff
doesn't work. Plus a bunch of empty files.

5:10 PM Changeset in webkit [31262] by mrowe@apple.com
  • 1 copy in branches/squirrelfish

New branch.

5:09 PM Changeset in webkit [31261] by mrowe@apple.com
  • 1 delete in branches/squirrelfish
4:19 PM Changeset in webkit [31260] by Darin Adler
  • 8 edits in trunk/WebKit/mac

2008-03-24 Darin Adler <Darin Adler>

Reviewed by Beth.

  • fix <rdar://problem/5817067> -[WebDataSource unreachableURL] invokes KURL's copy constructor
  • History/WebHistoryItem.mm: (-[WebHistoryItem URL]): Use a reference to avoid making a copy.
  • WebView/WebDataSource.mm: (-[WebDataSource _URL]): Ditto. (-[WebDataSource unreachableURL]): Ditto.
  • WebView/WebHTMLView.mm: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]): Ditto.
  • DefaultDelegates/WebDefaultContextMenuDelegate.mm:
  • History/WebHistory.mm:
  • Misc/WebElementDictionary.mm:
  • Misc/WebNSAttributedStringExtras.mm: Remove unneeded imports of KURL.h.
4:15 PM Changeset in webkit [31259] by ggaren@apple.com
  • 1 move in branches/squirrelfish

No, I am not kidding.

3:59 PM Changeset in webkit [31258] by beidson@apple.com
  • 9 edits
    1 move
    12 adds in trunk

WebCore:

2008-03-24 Brady Eidson <​beidson@apple.com>

Reviewed by Darin's rubberstamp

Land a load of empty files for upcoming work to make sure I'm not breaking any platform's build

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • loader/archive: Added.
  • loader/archive/Archive.h: Added.
  • loader/archive/ArchiveFactory.cpp: Added.
  • loader/archive/ArchiveFactory.h: Added.
  • loader/archive/ArchiveResource.cpp: Added.
  • loader/archive/ArchiveResource.h: Added.
  • loader/archive/ArchiveResourceCollection.cpp: Added.
  • loader/archive/ArchiveResourceCollection.h: Added.
  • loader/archive/cf: Added.
  • loader/archive/cf/LegacyWebArchive.cpp: Added.
  • loader/archive/cf/LegacyWebArchive.h: Added.
  • loader/archive/cf/LegacyWebArchiveMac.mm: Added.

WebKit:

2008-03-24 Brady Eidson <​beidson@apple.com>

Reviewed by Darin's rubberstamp

Rename a .m to .mm

  • WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

2008-03-24 Brady Eidson <​beidson@apple.com>

Reviewed by Darin's rubberstamp

Rename this file for upcoming work.

  • WebView/WebArchive.m: Removed.
  • WebView/WebArchive.mm: Copied from WebKit/mac/WebView/WebArchive.m.
3:51 PM Changeset in webkit [31257] by hyatt@apple.com
  • 5 edits in trunk/WebCore

2008-03-24 David Hyatt <​hyatt@apple.com>

Fix for bug 18009. Make sure the IE offset/client/scroll* extensions respect full page zoom.

Reviewed by Beth

  • dom/Element.cpp: (WebCore::localZoomForRenderer): (WebCore::adjustForLocalZoom): (WebCore::adjustForAbsoluteZoom): (WebCore::Element::offsetLeft): (WebCore::Element::offsetTop): (WebCore::Element::offsetWidth): (WebCore::Element::offsetHeight): (WebCore::Element::clientLeft): (WebCore::Element::clientTop): (WebCore::Element::clientWidth): (WebCore::Element::clientHeight): (WebCore::Element::scrollLeft): (WebCore::Element::scrollTop): (WebCore::Element::setScrollLeft): (WebCore::Element::setScrollTop): (WebCore::Element::scrollWidth): (WebCore::Element::scrollHeight):
  • rendering/RenderBox.cpp: (WebCore::RenderBox::setStyle):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::offsetParent):
  • rendering/RenderObject.h:
2:59 PM Changeset in webkit [31256] by mrowe@apple.com
  • 4 edits in branches/Safari-3-1-branch

Versioning.

2:57 PM Changeset in webkit [31255] by mrowe@apple.com
  • 1 copy in tags/Safari-5525.16

New tag.

2:53 PM Changeset in webkit [31254] by mitz@apple.com
  • 2 edits in trunk/WebKitTools

Reviewed by Mark Rowe.

  • update bisect-builds for Safari 3.1
  • Scripts/bisect-builds: Added Safari 3.1 and the corresponding minimal revision, r29711.
2:51 PM Changeset in webkit [31253] by mrowe@apple.com
  • 2 edits in branches/Safari-3-1-branch/WebKit/mac

Merge r31236.

2:51 PM Changeset in webkit [31252] by mrowe@apple.com
  • 16 edits
    6 adds in branches/Safari-3-1-branch

Merge r31144.

2:19 PM Google Summer of Code 2008 edited by eric@webkit.org
(diff)
2:17 PM Google Summer of Code 2008 edited by eric@webkit.org
(diff)
1:43 PM Changeset in webkit [31251] by beidson@apple.com
  • 4 edits in trunk/WebCore

2008-03-24 Brady Eidson <​beidson@apple.com>

Reviewed by Darin

Some style cleanup and add a logging channel for upcoming work

  • platform/Logging.cpp:
  • platform/Logging.h:
  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypes): (WebCore::initializeSupportedNonImageMimeTypes):
1:31 PM Changeset in webkit [31250] by mitz@apple.com
  • 6 edits
    4 adds in trunk

WebCore:

Reviewed by Sam Weinig.

  • fix <rdar://problem/5812292> CrashTracer: [REGRESSION] 60 crashes in Safari at com.apple.WebCore: WebCore::RenderObject::repaintRectangle + 47

Test: fast/repaint/renderer-destruction-by-invalidateSelection-crash.html

  • page/FrameView.cpp: (WebCore::FrameViewPrivate::reset): Removed repaintRects code. (WebCore::FrameView::layout): Ditto. (WebCore::FrameView::addRepaintInfo): Removed.
  • page/FrameView.h: Removed addRepaintInfo().
  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): Changed to call repaintRectangle instead of FrameView::addRepaintInfo().
  • rendering/RenderTable.cpp: (WebCore::RenderTable::layout): Ditto.

LayoutTests:

Reviewed by Sam Weinig.

  • test for <rdar://problem/5812292> CrashTracer: [REGRESSION] 60 crashes in Safari at com.apple.WebCore: WebCore::RenderObject::repaintRectangle + 47
  • fast/repaint/renderer-destruction-by-invalidateSelection-crash.html: Added.
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.checksum: Added.
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Added.
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt: Added.
12:26 PM Changeset in webkit [31249] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-03-24 Alp Toker <​alp@atoker.com>

GTK+/soup http backend build fix for breakage introduced in r31141.
Fix suggested by Xan.

  • platform/network/ResourceHandle.h:
12:15 PM Changeset in webkit [31248] by ggaren@apple.com
  • 1 copy in branches/registercode/JavaScriptCore

Imported r31247 of JavaScriptCore from trunk.

12:07 PM Changeset in webkit [31247] by ggaren@apple.com
  • 1 add in branches/registercode

Created registercode branch.

10:55 AM Changeset in webkit [31246] by mitz@apple.com
  • 9 edits in trunk/WebCore

Reviewed by Sam Weinig.

  • fix <rdar://problem/5792582> CSS opacity does not work with GDI text
  • fix <rdar://problem/5792619> non-opaque CSS colors do not work with GDI text (RGBA, HSLA)
  • fix <rdar://problem/5792624> GDI text can't be stroked/filled independently
  • make text-shadow work with GDI text
  • make -webkit-background-clip: text work with GDI text
  • platform/graphics/GraphicsContext.cpp: (WebCore::GraphicsContext::setShadow): Made this a shared method that updates the state and calls the platform-specific method. (WebCore::GraphicsContext::clearShadow): Ditto. (WebCore::GraphicsContext::getShadow): Added.
  • platform/graphics/GraphicsContext.h: (WebCore::GraphicsContext::WindowsBitmap): Added this class that represents a bitmap with a Windows device context that GDI can draw into.
  • platform/graphics/GraphicsContextPrivate.h: (WebCore::GraphicsContextState::GraphicsContextState): Added the shadow parameters to the graphics state.
  • platform/graphics/cairo/GraphicsContextCairo.cpp: (WebCore::GraphicsContext::setPlatformShadow): Renamed the platform- specific implementation to this. (WebCore::GraphicsContext::clearPlatformShadow): Renamed the platform- specific implementation to this.
  • platform/graphics/cg/GraphicsContextCG.cpp: (WebCore::GraphicsContext::setPlatformShadow): Renamed the platform- specific implementation to this. (WebCore::GraphicsContext::clearPlatformShadow): Renamed the platform- specific implementation to this.
  • platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContext::setPlatformShadow): Renamed the platform- specific implementation to this. (WebCore::GraphicsContext::clearPlatformShadow): Renamed the platform- specific implementation to this.
  • platform/graphics/win/FontCGWin.cpp: (WebCore::toCGFloat): Added. Converts a Windows FIXED. (WebCore::createPathForGlyph): Added. Retrieves a glyph's hinted outline from GDI and creates a CGPath containing it. (WebCore::Font::drawGlyphs): Added two code paths in the GDI case. The existing code path, which uses GDI to draw text directly to the graphics context, is used for opaque-colored, non-transformed, non-stroked, non-shadowed text in a GDI-backed graphics context that is not in a transparency layer. An additional code path is used for non-stroked text in all other cases. It uses GDI to draw black text into an all-white Windows bitmap, then uses the green channel as a mask to create a bitmap with the desired fill color and alpha. The bitmap is then drawn into the graphics context, at which time transparency layers, transforms and shadows are handled properly. A third code path is used for stroked text. It constructs a path from hinted glyph outlines retrieved from GDI and strokes (and optionally fills) it.
  • platform/graphics/win/GraphicsContextCGWin.cpp: (WebCore::GraphicsContext::getWindowsContext): Added a mayCreateBitmap parameter. When false, prevents this method from creating a Windows device context if the graphics context does not already have one. (WebCore::GraphicsContext::releaseWindowsContext): Added a mayCreateBitmap parameter to match getWindowsContext(). (WebCore::GraphicsContext::WindowsBitmap::WindowsBitmap): (WebCore::GraphicsContext::WindowsBitmap::~WindowsBitmap): (WebCore::GraphicsContext::createWindowsBitmap): Added. (WebCore::GraphicsContext::drawWindowsBitmap): Added. Draws the bitmap as a non-alpha-premultiplied image.
10:45 AM Changeset in webkit [31245] by kmccullough@apple.com
  • 1 edit in trunk/WebCore/ChangeLog

2008-03-24 Kevin McCullough <​kmccullough@apple.com>

  • Fixed Changelog
10:16 AM Changeset in webkit [31244] by alp@webkit.org
  • 2 edits in trunk/WebCore

2008-03-24 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Alp Toker.

​http://bugs.webkit.org/show_bug.cgi?id=17845
[GTK] combo box menu displayed in the wrong position

  • platform/gtk/PopupMenuGtk.cpp: (WebCore::PopupMenu::show): Change the popup menu vertical position so that the active item is over the combo box. (WebCore::PopupMenu::menuPositionFunction): use the "push in" style like native GTK+ combo boxes to handle menus that don't fit in the screen.
5:00 AM Changeset in webkit [31243] by Adam Roben
  • 2 edits in trunk/WebCore
  • WebCore.vcproj/WebCore.vcproj: Add files from WebCore/page/inspector to the project.
1:15 AM Changeset in webkit [31242] by ap@webkit.org
  • 4 edits in trunk

Build fix.

  • WebCore/WebCore.xcodeproj/project.pbxproj: Added DOMSVGAltGlyphElement.h and DOMSVGAltGlyphElementInternal.h to Copy Generated Headers phase.
  • WebKit/MigrateHeaders.make: Added DOMSVGAltGlyphElement.h and DOMSVGAltGlyphElementInternal.h.
12:24 AM Changeset in webkit [31241] by eric@webkit.org
  • 2 edits in trunk/WebCore

Build fix, no review.

Fix project paths to be group relative instead of project relative

  • WebCore.xcodeproj/project.pbxproj:

Mar 23, 2008:

10:36 PM Changeset in webkit [31240] by mjs@apple.com
  • 18 edits
    6 adds in trunk

WebCore:

2008-03-23 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Eric.

  • svg/SVGAltGlyphElement.cpp: Added. Implementation for new element. (WebCore::SVGAltGlyphElement::SVGAltGlyphElement): (WebCore::SVGAltGlyphElement::~SVGAltGlyphElement): (WebCore::SVGAltGlyphElement::setGlyphRef): (WebCore::SVGAltGlyphElement::glyphRef): (WebCore::SVGAltGlyphElement::setFormat): (WebCore::SVGAltGlyphElement::format): (WebCore::SVGAltGlyphElement::childShouldCreateRenderer): (WebCore::SVGAltGlyphElement::createRenderer): For now, this just renders as a tspan, which is right for everything besides the alternate glyph substitution itself.
  • svg/SVGAltGlyphElement.h: Added. Header for new element. (WebCore::SVGAltGlyphElement::contextElement):
  • svg/SVGAltGlyphElement.idl: Added. Interface for new element.
  • svg/SVGTSpanElement.cpp: (WebCore::SVGTSpanElement::childShouldCreateRenderer): Allow altGlyph to render here.
  • svg/SVGTextElement.cpp: (WebCore::SVGTextElement::childShouldCreateRenderer): ditto
  • svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::childShouldCreateRenderer): ditto
  • svg/svgtags.in: Add altGlyph
  • DerivedSources.make: Add new files
  • GNUmakefile.am: ditto
  • WebCore.SVG.exp: Add new ObjC DOM class
  • WebCore.pro: Add new files
  • WebCore.vcproj/WebCore.vcproj: ditto
  • WebCore.xcodeproj/project.pbxproj: ditto
  • bindings/js/JSSVGElementWrapperFactory.cpp: Handle altGlyph
  • bindings/objc/DOM.mm: (WebCore::createElementClassMap): ditto
  • bindings/objc/DOMInternal.h: Include altGlyph header
  • bindings/objc/DOMSVG.h: Include altGlyph header

LayoutTests:

2008-03-23 Maciej Stachowiak <​mjs@apple.com>

Reviewed by Eric.

  • platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • platform/mac/svg/text/text-altglyph-01-b-expected.txt:
  • svg/dom/altGlyph-dom-expected.txt: Added.
  • svg/dom/altGlyph-dom.xhtml: Added.
  • svg/dom/resources/altGlyph-dom.js: Added.
6:21 PM Changeset in webkit [31239] by Antti Koivisto
  • 1 edit
    1 add in trunk/WebKitSite

2008-03-23 Antti Koivisto <Antti Koivisto>

  • blog-files/wsj-vs.png: Added.
2:08 PM Changeset in webkit [31238] by eric@webkit.org
  • 3 edits
    2 adds in trunk

Reviewed by eseidel. Landed by eseidel.

Bug 17685: [~=] attribute selector failing to match empty string
<​http://bugs.webkit.org/show_bug.cgi?id=17685>

Test: fast/css/attribute-selector-empty-value.html

  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::checkOneSelector):
2:03 PM Changeset in webkit [31237] by eric@webkit.org
  • 2 edits in trunk/WebKitSite

Reviewed by Sam.

Make our SVG status document slightly less inaccurate.

  • projects/svg/status.xml:
3:48 AM Changeset in webkit [31236] by oliver@apple.com
  • 3 edits
    2 adds in trunk

Bug 17670: Key events may improperly propagate from iframe to parent frame
Bug 16381: REGRESSION: Shift, command, option, ctrl keys in Gmail Rich Text changes focus

Reviewed by Maciej

Prevent the Cocoa event system from propagating key events to the parent WebHTMLView,
as that results in us dispatching the key events for each frame going up the frame
tree.

Mar 22, 2008:

3:21 PM Changeset in webkit [31235] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-03-22 Marco Barisione <​marco.barisione@collabora.co.uk>

Reviewed by Darin Adler.

​http://bugs.webkit.org/show_bug.cgi?id=16339
Frame scrollbar positions are not updated on page scroll

Widget::geometryChanged() was called instead of
ScrollViewScrollbar::geometryChanged() because of a missing const.

  • platform/gtk/ScrollViewGtk.cpp: (WebCore::ScrollViewScrollbar::geometryChanged): add the missing const.
3:01 PM Changeset in webkit [31234] by mrowe@apple.com
  • 6 edits in trunk/WebCore

2008-03-22 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Mark Rowe.

Bug 17974: REGRESSION: npfunctions.h should not import npruntime_internal.h
<​http://bugs.webkit.org/show_bug.cgi?id=17974>
<rdar://problem/5782310>

Include npapi.h and npruntime.h directly in npfunctions.h.
Add npfunctions.h and npapi.h to npruntime_internal.h.
Replace includes of npfunctions.h with npruntime_internal.h.

  • bridge/npruntime_internal.h:
  • plugins/PluginPackage.h:
  • plugins/PluginStream.h:
  • plugins/npapi.cpp:
  • plugins/npfunctions.h:
2:04 PM Changeset in webkit [31233] by mrowe@apple.com
  • 4 edits in trunk

Fix the Qt build.

3:31 AM Changeset in webkit [31232] by eric@webkit.org
  • 3 edits in trunk

Update a (passing) result I missed in my last checkin. No review.

  • dom/xhtml/level3/core/documentgetdoctype01-expected.txt:
2:50 AM Changeset in webkit [31231] by eric@webkit.org
  • 10 edits
    6 adds in trunk

Reviewed by mjs.

Unify handling of NAMESPACE_ERR and fix Acid3 test 25
​http://bugs.webkit.org/show_bug.cgi?id=16693

Test: fast/dom/DOMImplementation/createDocumentType-err.html

  • dom/DOMImplementation.cpp: (WebCore::DOMImplementation::createDocumentType): (WebCore::DOMImplementation::createDocument):
  • dom/DOMImplementation.idl:
  • dom/Document.cpp: (WebCore::Document::hasPrefixNamespaceMismatch): (WebCore::Document::createElementNS): (WebCore::Document::parseQualifiedName): (WebCore::Document::createAttributeNS):
  • dom/Document.h:
  • dom/Element.cpp: (WebCore::Element::setAttributeNS):
  • editing/FormatBlockCommand.cpp: (WebCore::FormatBlockCommand::doApply):
2:49 AM Changeset in webkit [31230] by eric@webkit.org
  • 5 edits
    7 adds in trunk

Reviewed by mjs.

Fix createElementNS to throw exceptions for invalid qualified names
Fixes Acid3 sub-test 23
​http://bugs.webkit.org/show_bug.cgi?id=16833

Tests: fast/dom/Document/createAttributeNS-namespace-err.html

fast/dom/Document/createElementNS-namespace-err.html

  • dom/Document.cpp: (WebCore::Document::createElement): (WebCore::hasNamespaceError): (WebCore::Document::createElementNS): (WebCore::Document::createAttributeNS):
  • dom/Document.idl:
2:14 AM Changeset in webkit [31229] by eric@webkit.org
  • 3 edits in trunk/JavaScriptCore

Reviewed by Sam Weinig. Landed by eseidel.


Make testkjs flush stdout after printing.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/testkjs.cpp: (functionPrint):
12:14 AM Changeset in webkit [31228] by oliver@apple.com
  • 3 edits
    2 adds in trunk

2008-03-21 Cameron Zwarich <​cwzwarich@uwaterloo.ca>

Bug 13693: REGRESSION (r13615): Acid2 Test Eyes render improperly after a page refresh
<​http://bugs.webkit.org/show_bug.cgi?id=13693>

Reviewed by Oliver Hunt

Do not create bogus history items for unloaded <object> elements, because they
cause fallback content to be ignored on reload.

Mar 21, 2008:

11:57 PM Changeset in webkit [31227] by mitz@apple.com
  • 3 edits
    2 adds in trunk

WebCore:

Reviewed by Oliver Hunt.

Test: fast/css-generated-content/empty-content-with-float-crash.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Added a null check for the case where the block contains no in-flow elements but still lays out as a line flow, which can happen as a result of empty generated content.

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/css-generated-content/empty-content-with-float-crash-expected.txt: Added.
  • fast/css-generated-content/empty-content-with-float-crash.html: Added.
9:59 PM Changeset in webkit [31226] by oliver@apple.com
  • 3 edits in trunk/JavaScriptCore

Optimise lookup of Math, undefined, NaN and Infinity

Reviewed by Maciej

Added a method to JSVariableObject to allow us to inject DontDelete properties
into the symbol table and localStorage. This results in a 0.4% progression in
SunSpider, with a 8% gain in math-partial-sums.

7:36 PM Changeset in webkit [31225] by oliver@apple.com
  • 8 edits in trunk

Global properties that use LocalStorage are not correctly listed as enumerable.

Reviewed by Geoff Garen

The problem was caused by JSObject::getPropertyAttributes not being aware
of the JSVariableObject SymbolTable. The fix is to make getPropertyAttributes
virtual and override in JSVariableObject. This does not produce any performance
regression.

5:39 PM Changeset in webkit [31224] by weinig@apple.com
  • 5 edits
    2 adds in trunk

WebCore:

2008-03-21 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Fix <rdar://problem/5788451>
toDataURL not implemented for Windows (need mapping of MIME type to UTI)

Hard code support for just PNG's on windows, the minimum the spec requires.

  • platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypesForEncoding):
  • platform/graphics/cg/ImageBufferCG.cpp: (WebCore::utiFromMIMEType): (WebCore::ImageBuffer::toDataURL):

LayoutTests:

2008-03-21 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Enable tests for <rdar://problem/5788451>
toDataURL not implemented for Windows (need mapping of MIME type to UTI)

  • platform/win/Skipped:
  • platform/win/fast/canvas: Added.
  • platform/win/fast/canvas/toDataURL-supportedTypes-expected.txt: Added.
4:58 PM Changeset in webkit [31223] by pewtermoose@webkit.org
  • 4 edits in trunk/WebCore

2008-03-21 Matt Lilek <​webkit@mattlilek.com>

Not reviewed, Mac build fix.

  • bindings/objc/WebScriptObject.mm: (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
  • bridge/jni/jni_utility.cpp: (KJS::Bindings::convertValueToJValue):
  • bridge/objc/objc_runtime.mm: (ObjcFallbackObjectImp::callAsFunction):
4:31 PM Changeset in webkit [31222] by Antti Koivisto
  • 1 edit
    2 adds in trunk/WebKitSite

2008-03-21 Antti Koivisto <Antti Koivisto>

Add some images for a blog post.

  • blog-files/wsj-nopreload.png: Added.
  • blog-files/wsj-preload.png: Added.
4:30 PM Changeset in webkit [31221] by Adam Roben
  • 2 edits in trunk/WebCore

Attempt to fix the Mac build

  • bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper):
3:09 PM Changeset in webkit [31220] by Adam Roben
  • 35 edits in trunk/WebCore

Rename static info members to s_info

This avoids conflicts with custom "info" methods, such as the one that
will soon be added to Console.

Reviewed by Ada Chan and Sam Weinig.

3:00 PM Changeset in webkit [31219] by hyatt@apple.com
  • 3 edits in trunk/WebCore

2008-03-21 David Hyatt <​hyatt@apple.com>

<rdar://problem/5808863> Zooming should not let non-zero border width become zero

Make sure zoomed values that begin >= 1 are not allowed to fall below 1.

Reviewed by adele

  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::computeLengthDouble):
  • loader/CachedImage.cpp: (WebCore::CachedImage::imageSize): (WebCore::CachedImage::imageRect):
2:05 PM Changeset in webkit [31218] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-03-21 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Sam.

-<rdar://problem/5712804> XMLHttpRequests do not show response contents, preview images (14313)
-<rdar://problem/5712931> XMLHttpRequests should be shown separately and grouped (14315)
-<rdar://problem/5732836> XMLHttpRequest: Inspector should show network activity/XHR in Console (17233)

  • Instrument the InspectorController to cache XHR resrouces since they are not cached by WebCore. The resources will be kept in the same map as all other resources so they will have the exact same lifecycle.
  • ChangeLog:
  • page/InspectorController.cpp: (WebCore::InspectorCachedXMLHttpRequestResource::type): (WebCore::InspectorCachedXMLHttpRequestResource::setType): (WebCore::InspectorCachedXMLHttpRequestResource::data): (WebCore::InspectorCachedXMLHttpRequestResource::setData): (WebCore::InspectorCachedXMLHttpRequestResource::encoding): (WebCore::InspectorCachedXMLHttpRequestResource::setEncoding): (WebCore::InspectorCachedXMLHttpRequestResource::create): (WebCore::InspectorCachedXMLHttpRequestResource::InspectorCachedXMLHttpRequestResource):
  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):
1:40 PM Changeset in webkit [31217] by zecke@webkit.org
  • 1 edit in trunk/ChangeLog

Add missing ChangeLog entry for r31214.

2008-03-21 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Holger.

Remove the JSCore include path options from global_cppflags.
Place JSCore include path options in javascriptcore_cppflags.
Add javascriptcore_cppflags to libWebCore_la_CPPFLAGS.

  • GNUmakefile.am:
12:26 PM Changeset in webkit [31216] by ddkilzer@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-03-21 Arkadiusz Miskiewicz <​arekm@maven.pl>

Webkit does not build on linux powerpc

<​http://bugs.webkit.org/show_bug.cgi?id=17019>

Reviewed by David Kilzer.

  • wtf/TCSpinLock.h: (TCMalloc_SpinLock::Unlock):
11:48 AM Changeset in webkit [31215] by ap@webkit.org
  • 2 edits in trunk/SunSpider

Reviewed by Geoff.

  • sunspider: Pause update daemon on Darwin to make results reliable again (workaround for <rdar://problem/5811127>).
11:21 AM Changeset in webkit [31214] by zecke@webkit.org
  • 7 edits in trunk

JavaScriptCore/ChangeLog:
2008-03-21 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Holger.

​http://bugs.webkit.org/show_bug.cgi?id=17981

Add javascriptcore_cppflags to Programs_minidom_CPPFLAGS.

  • GNUmakefile.am:

WebCore/ChaneLog:
2008-03-21 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Holger.

​http://bugs.webkit.org/show_bug.cgi?id=17981

Remove WebCore/ForwardingHeaders from cppflags as it is not needed,
and causes build problems with GTK+.

  • GNUmakefile.am:

WebKitTools/ChangeLog:
2008-03-21 Rodney Dawes <​dobey@wayofthemonkey.com>

Reviewed by Holger.

​http://bugs.webkit.org/show_bug.cgi?id=17981

Add webcore and javascriptcore cppflags to programs' _CPPFLAGS.

  • GNUmakefile.am:
10:17 AM Changeset in webkit [31213] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Adele Peterson.

Test: fast/block/float/br-with-clear.html

  • rendering/bidi.cpp: (WebCore::RenderBlock::layoutInlineChildren): Fixed the logic for the very special case of an all-lines-clean block that ends with a float- clearing <br> by looking for the <br> at the end of the line rather than at its beginning.

LayoutTests:

Reviewed by Adele Peterson.

  • fast/block/float/br-with-clear.html: Added.
  • platform/mac/fast/block/float/br-with-clear-expected.checksum: Added.
  • platform/mac/fast/block/float/br-with-clear-expected.png: Added.
  • platform/mac/fast/block/float/br-with-clear-expected.txt: Added.
9:36 AM Changeset in webkit [31212] by adachan@apple.com
  • 2 edits in trunk/WebKit/win

<rdar://problem/5810324> visitCount not updated in History.plist
Call WebCore::HistoryItem::mergeAutoCompleteHints() in WebHistoryItem::mergeAutoCompleteHints().

Reviewed by Steve.

  • WebHistoryItem.cpp: (WebHistoryItem::mergeAutoCompleteHints): (WebHistoryItem::QueryInterface):
9:29 AM Changeset in webkit [31211] by Adam Roben
  • 3 edits in trunk/WebKitTools

Remove a non-working mirror from cygwin-downloader and add the ruby package

  • CygwinDownloader/cygwin-downloader.py:
  • CygwinDownloader/cygwin-downloader.zip: Updated.
9:27 AM Changeset in webkit [31210] by Adam Roben
  • 3 edits in trunk/WebCore

Don't allow any newly-scheduled plugin requests to be serviced when JS is paused

This is a followup to r31199.

Reviewed by Tim Hatcher.

  • plugins/PluginView.cpp: (WebCore::PluginView::requestTimerFired): Added an assertion that JS is not paused. (WebCore::PluginView::scheduleRequest): Don't start the request timer if JS is paused. This is the bug fix. (WebCore::PluginView::setJavaScriptPaused): Replaced the use of m_requestTimerWasActive with a check to see if we have any pending requests. m_requestTimerWasActive would not be accurate if a new request had been scheduled while JS was paused. (WebCore::PluginView::PluginView): Removed initialization of m_requestTimerWasActive.
  • plugins/PluginView.h: Removed m_requestTimerWasActive.
9:19 AM UpdatingCygwinDownloader created by Adam Roben
Initial version
9:14 AM WikiStart edited by Adam Roben
Add a link to a page to describe how to update cygwin-downloader (diff)
9:00 AM Changeset in webkit [31209] by timothy@apple.com
  • 6 edits in trunk/WebKit/mac

Bug 17980: Regression: Inspector highlighting of webpage not cleared when going to new URL
​http://bugs.webkit.org/show_bug.cgi?id=17980

Reviewed by Adam.

The new highlight drawing was not honoring the fade value, so it was
always drawing at full opacity. The animation code didn't match Windows
and the new highlight anyway, so it has been removed. The highlight
how just detaches when it is hidden.

  • WebCoreSupport/WebInspectorClient.mm:

(-[WebInspectorWindowController windowShouldClose:]): Call hideHighlight.
(-[WebInspectorWindowController close]): Ditto.
(-[WebInspectorWindowController highlightNode:]): Call attach.
(-[WebInspectorWindowController hideHighlight]): Call detach and release _currentHighlight.

  • WebInspector/WebNodeHighlight.h:
  • WebInspector/WebNodeHighlight.m:

(-[WebNodeHighlight initWithTargetView:inspectorController:]):
(-[WebNodeHighlight dealloc]): Assert we have no _highlightView.
(-[WebNodeHighlight attach]): Renamed from attachHighlight.
(-[WebNodeHighlight detach]): Renamed from detachHighlight.
(-[WebNodeHighlight setNeedsUpdateInTargetViewRect:]): Renamed from setHolesNeedUpdateInTargetViewRect:.

  • WebInspector/WebNodeHighlightView.h:
  • WebInspector/WebNodeHighlightView.m:

(-[WebNodeHighlightView setNeedsDisplayInRect:]): Renamed from setHolesNeedUpdateInRect:.

4:14 AM Changeset in webkit [31208] by ap@webkit.org
  • 10 edits in trunk/JavaScriptCore

Reviewed by Oliver Hunt.

Consolidate static identifier initializers within CommonIdentifiers.

No reliably measurable change on SunSpider; maybe a tiny improvement (within 0.2%).

  • kjs/CommonIdentifiers.h: Added static identifiers that were lazily initialized throughout the code.
  • kjs/date_object.cpp: (KJS::DateObjectImp::DateObjectImp):
  • kjs/function_object.cpp: (KJS::FunctionPrototype::FunctionPrototype):
  • kjs/object_object.cpp: (KJS::ObjectPrototype::ObjectPrototype):
  • kjs/regexp_object.cpp: (KJS::RegExpPrototype::RegExpPrototype): Use the values from CommonIdentifiers.
  • kjs/lookup.h: Caching the identifier in a static wasn't a win on SunSpider, removed it.
  • kjs/value.h: (KJS::jsNaN): We already have a shared NaN value, no need for a duplicate here.
  • wtf/MathExtras.h: (wtf_atan2): Having local variables for numeric_limits constants is good for readability, but there is no reason to keep them static.
12:07 AM Changeset in webkit [31207] by mitz@apple.com
  • 4 edits in trunk/LayoutTests
  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
Note: See TracTimeline for information about the timeline view.