Timeline
May 5, 2008:
- 11:29 PM SquirrelFish edited by
- (diff)
- 10:01 PM Changeset in webkit [32901] by
-
- 2 edits in trunk/WebCore
Fix 60 crashes seen on the buildbots that were misreported as hangs.
Reviewed by Dan Bernstein.
- dom/Document.cpp:
(WebCore::Document::detachNodeIterator): Null-check page() before dereferencing it.
(WebCore::Document::nodeWillBeRemoved): Ditto.
(WebCore::Document::textInserted): Ditto.
(WebCore::Document::textNodesMerged): Ditto.
(WebCore::Document::textRemoved): Ditto.
- 9:09 PM Changeset in webkit [32900] by
-
- 3 edits in trunk/WebCore
2008-05-05 Brady Eidson <beidson@apple.com>
Reviewed by Mitz Pettel RTL
Preparation for upcoming work making LocalStorage persistent.
The other half of the StorageMap::importItem() addition.
- storage/StorageArea.cpp: (WebCore::StorageArea::importItem):
- storage/StorageArea.h:
- 9:03 PM Changeset in webkit [32899] by
-
- 5 edits in trunk/WebCore
2008-05-05 Brady Eidson <beidson@apple.com>
Reviewed by Mitz Pettel RTL
Preparation for upcoming work making LocalStorage persistent.
- Create the LocalStorage object for a PageGroup the moment the first Page is added to it The Settings of the first Page define what persistent path the LocalStorage will use
- Add a Frame argument for the LocalStorageArea request - this will allow a client object to be queried before the LocalStorageArea is established
- page/DOMWindow.cpp: (WebCore::DOMWindow::localStorage):
- page/PageGroup.cpp: (WebCore::PageGroup::addPage): (WebCore::PageGroup::localStorage):
- storage/LocalStorage.cpp: (WebCore::LocalStorage::LocalStorage): Take the path as a constructor argument. Deep copy the path as it will be used from another thread. (WebCore::LocalStorage::storageArea):
- storage/LocalStorage.h: (WebCore::LocalStorage::create):
- 8:16 PM Changeset in webkit [32898] by
-
- 2 edits in branches/squirrelfish/JavaScriptCore
Fix call frame set up for native -> JS function calls.
Review by Geoff
- 8:14 PM Changeset in webkit [32897] by
-
- 3 edits in trunk/WebCore
2008-05-05 Brady Eidson <beidson@apple.com>
Reviewed by Mitz Pettel RTL
Preparation for upcoming work making LocalStorage persistent.
StorageMaps normally have copy-on-write semantics to help support SessionStorage.
For LocalStorage, we never want this behavior. When we forcefully import items into
a StorageMap from the LocalStorage background thread, this new import method will be used.
- storage/StorageMap.cpp: (WebCore::StorageMap::importItem): Add a deep-copy of the item to the map without worrying about copy-on-write.
- storage/StorageMap.h:
- 7:24 PM Changeset in webkit [32896] by
-
- 8 edits2 adds in branches/squirrelfish
2008-05-05 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Fixed ecma_3/Object/8.6.2.6-001.js, and similar bugs.
SunSpider reports a .4% speedup. Not sure what that's about.
- VM/Machine.cpp: (KJS::Machine::privateExecute): Check for exception return from equal, since toPrimitive can throw.
- kjs/operations.cpp: (KJS::strictEqual): In response to an error I made in an earlier version of this patch, I changed strictEqual to make clear the fact that it performs no conversions and can't throw, making it slightly more efficient in the process.
LayoutTests:
2008-05-05 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
Layout test for exceptions thrown from equality comparisons.
- fast/js/exception-thrown-from-equal-expected.txt: Added.
- fast/js/exception-thrown-from-equal.html: Added.
- 5:45 PM Changeset in webkit [32895] by
-
- 3 edits in trunk/WebKitTools
Copy dependencies of ImageDiff, DumpRenderTree in post-build step.
- DumpRenderTree/win/DumpRenderTree.vcproj:
- DumpRenderTree/win/ImageDiff.vcproj:
- 5:23 PM Changeset in webkit [32894] by
-
- 2 edits in tags/Safari-6526.3.4/WebCore
Merged r32711.
- 5:21 PM Changeset in webkit [32893] by
-
- 5 edits in tags/Safari-6526.3.4
Merged r32699, 32701, 32702, 32704.
- 5:15 PM Changeset in webkit [32892] by
-
- 2 edits in tags/Safari-6526.3.4/WebKit/win
Merged r32698.
- 5:08 PM Changeset in webkit [32891] by
-
- 2 edits in tags/Safari-6526.3.4/WebCore
Merged r32659.
- 5:01 PM Changeset in webkit [32890] by
-
- 4 edits6 adds in trunk/WebCore
2008-05-05 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
-<rdar://problem/5770054> JavaScript profiler (10928)
-Begininings of a UI for the Profiler in the WebInspector.
- English.lproj/InspectorLocalizedStrings.js: Add new strings to be localized.
- page/inspector/DatabasesPanel.js: Changed the name of the Databae's results table to be more generic as it is now also used by the profiler.
- page/inspector/Images/glossySelected.png: Added.
- page/inspector/Images/profilesIcon.png: Added.
- page/inspector/Images/treeUpTriangleBlack.png: Added.
- page/inspector/Images/treeUpTriangleWhite.png: Added.
- page/inspector/ProfileView.js: Added. Sets up the header of the table.
- page/inspector/ProfilesPanel.js: Added.
- page/inspector/ProfilesPanel.js: Added. Sets up the containers of the profiler's content.
- page/inspector/inspector.css: Change database-result-table to be more generic as well as add the styles needed by the profiler.
- page/inspector/inspector.html: Add profiler support.
- 4:42 PM Changeset in webkit [32889] by
-
- 2 edits in trunk/WebCore
2008-05-05 Brady Eidson <beidson@apple.com>
Change by Darin, reviewed by Brady
Small efficiency improvement Darin just spotted
- storage/StorageMap.cpp: (WebCore::StorageMap::setItem):
- 4:41 PM Changeset in webkit [32888] by
-
- 3 edits in tags/Safari-6526.3.4/WebCore
- 4:31 PM Changeset in webkit [32887] by
-
- 2 edits in trunk/WebCore
2008-05-05 Antti Koivisto <Antti Koivisto>
Reviewed by Anders.
Fix https://bugs.webkit.org/show_bug.cgi?id=18899
Bug 18899: REGRESSION (r32871): Non-Safari crash in WTF::HashTable on startup
- loader/loader.cpp: (WebCore::Loader::Loader):
- 4:04 PM Changeset in webkit [32886] by
-
- 2 edits in trunk/WebKit/mac
2008-05-05 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Fix for <rdar://problem/5884383>
Escape look-a-like characters from the the entire url.
- Misc/WebNSURLExtras.mm: (escapeUnsafeCharacters): (-[NSURL _web_userVisibleString]):
- 4:00 PM Changeset in webkit [32885] by
-
- 1 copy in tags/Safari-6526.3.4
New tag.
- 3:57 PM Changeset in webkit [32884] by
-
- 2 edits in trunk/WebCore
2008-05-05 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig
Fix a bug in StorageMap iterator tracking where the iterator was not successfully
invalidated at an appropriate time.
- storage/StorageMap.cpp: (WebCore::StorageMap::setItem): ALWAYS invalidate it here
- 3:50 PM Changeset in webkit [32883] by
-
- 7 edits in trunk
WebCore:
2008-05-05 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin.
<rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end
Disable Range mutation on document modifications in Tiger and Leopard Mail,
since they do their own mutation which interferes with ours.
- WebCore.base.exp:
- dom/Document.cpp: (WebCore::Document::nodeChildrenChanged): (WebCore::Document::nodeWillBeRemoved): (WebCore::Document::textInserted): (WebCore::Document::textRemoved): (WebCore::Document::textNodesMerged): (WebCore::Document::textNodeSplit):
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::disableRangeMutationForOldAppleMail):
- page/Settings.h: (WebCore::Settings::rangeMutationDisabledForOldAppleMail):
WebKit/mac:
2008-05-05 Justin Garcia <justin.garcia@apple.com>
Reviewed by Darin.
<rdar://problem/5865171> REGRESSION: Creating a new quote places caret at beginning of quote instead of the end
- WebView/WebView.mm: (-[WebView _updateSettingsFromPreferences:]): Disable Range mutation on changes to the document for Tiger and Leopard Mail. There is code in Mail that does it, and the two interfere.
- 3:47 PM Changeset in webkit [32882] by
-
- 8 edits1 add1 delete in trunk
WebCore:
2008-05-05 Sam Weinig <sam@webkit.org>
Reviewed by Tim Hatcher.
Make the Inspector's localizable strings file match the format used by Dashboard widgets.
- English.lproj/InspectorLocalizedStrings.js: Removed.
- English.lproj/localizedStrings.js: Added.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- page/inspector/inspector.js:
WebKit/mac:
2008-05-05 Sam Weinig <sam@webkit.org>
Reviewed by Tim Hatcher.
Make the Inspector's localizable strings file match the format used by Dashboard widgets.
- WebCoreSupport/WebInspectorClient.mm: (WebInspectorClient::localizedStringsURL):
WebKit/win:
2008-05-05 Sam Weinig <sam@webkit.org>
Reviewed by Tim Hatcher.
Make the Inspector's localizable strings file match the format used by Dashboard widgets.
- WebCoreSupport/WebInspectorClient.cpp: (WebInspectorClient::localizedStringsURL):
- 1:51 PM Changeset in webkit [32881] by
-
- 18 edits in trunk
2008-05-05 Steve Falkenburg <sfalken@apple.com>
Add WebPreference for application chrome mode.
Reviewed by Dave Hyatt.
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): (WebPreferences::inApplicationChromeMode): (WebPreferences::setApplicationChromeMode):
- WebPreferences.h:
- WebView.cpp: (WebView::notifyPreferencesChanged):
2008-05-05 Steve Falkenburg <sfalken@apple.com>
Add support for default button appearance.
Add WebCore setting for app chrome mode.
Reviewed by Dave Hyatt.
- css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSValueKeywords.in: Added default-button value keyword.
- page/Settings.cpp: (WebCore::Settings::Settings): (WebCore::Settings::setApplicationChromeMode):
- page/Settings.h: (WebCore::Settings::inApplicationChromeMode):
- rendering/RenderButton.cpp: (WebCore::RenderButton::RenderButton): (WebCore::RenderButton::setStyle): (WebCore::RenderButton::timerFired):
- rendering/RenderButton.h:
- rendering/RenderStyle.h: (WebCore::):
- rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): (WebCore::RenderTheme::paint): (WebCore::RenderTheme::paintBorderOnly): (WebCore::RenderTheme::paintDecorations): (WebCore::RenderTheme::isControlStyled): (WebCore::RenderTheme::isDefault):
- rendering/RenderTheme.h: (WebCore::):
- rendering/RenderThemeSafari.cpp: (WebCore::RenderThemeSafari::determineState): (WebCore::RenderThemeSafari::adjustRepaintRect): (WebCore::RenderThemeSafari::adjustButtonStyle):
- rendering/RenderThemeWin.cpp: (WebCore::RenderThemeWin::supportsFocus):
- 1:35 PM Changeset in webkit [32880] by
-
- 2 edits in trunk/WebKitTools
2008-05-05 Adele Peterson <adele@apple.com>
Reviewed by Adam.
Look for the right ImageDiff executable for debug builds.
- Scripts/run-webkit-tests:
- 11:29 AM Changeset in webkit [32879] by
-
- 3 edits4 adds in trunk
Reviewed by Darin.
https://bugs.webkit.org/show_bug.cgi?id=11947
nbsps should be converted to entities in innerHTML
https://bugs.webkit.org/show_bug.cgi?id=18769
replacing with spaces using regexp creates inconsistent result
Tests: fast/dom/innerHTML-nbsp.html
fast/dom/innerHTML-escaping-attribute.html
- editing/markup.cpp: (WebCore::appendAttributeValue): (WebCore::escapeContentText): (WebCore::appendEscapedContent): Added U+00a0/nbsp to the list of characters to escape.
- 11:26 AM Changeset in webkit [32878] by
-
- 3 edits3 adds in trunk
WebCore:
2008-05-05 David Hyatt <hyatt@apple.com>
Fix for https://bugs.webkit.org/show_bug.cgi?id=18821. Fix some bugs in both get/PutImageData of <canvas>.
Reviewed by Eric
New tests added in fast/canvas/
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::ImageBuffer::getImageData): (WebCore::ImageBuffer::putImageData):
LayoutTests:
2008-05-05 David Hyatt <hyatt@apple.com>
Fix for https://bugs.webkit.org/show_bug.cgi?id=18821, putImageData incorrect when data has alpha.
Reviewed by Eric
- fast/canvas/canvas-alphaImageData-behavior-expected.txt: Added.
- fast/canvas/canvas-alphaImageData-behavior.html: Added.
- fast/canvas/canvas-alphaImageData-behavior.js: Added.
- 9:59 AM Changeset in webkit [32877] by
-
- 2 edits in trunk/JavaScriptCore
2008-05-05 Darin Adler <Darin Adler>
Reviewed by John Sullivan.
- fix debug-only leak seen on buildbot
- wtf/HashTable.h: (WTF::HashTable::checkKey): After writing an empty value in, but before constructing a deleted value on top of it, call the destructor so the empty value doesn't leak.
- 9:47 AM Changeset in webkit [32876] by
-
- 3 edits in trunk/WebKit/mac
2008-05-05 Anders Carlsson <andersca@apple.com>
Reviewed by Jess.
Apparently preflighting can cause hangs for some reason. Revert this for now.
- Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage _initWithPath:]):
- Plugins/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]):
- 9:44 AM Changeset in webkit [32875] by
-
- 2 edits in trunk/WebKitTools
2008-05-05 Darin Adler <Darin Adler>
- Scripts/run-webkit-tests: Ignore a Java leak showing up in the WebKit leak tests.
- 9:34 AM Changeset in webkit [32874] by
-
- 2 edits in trunk/WebKit/mac
2008-05-05 Darin Adler <Darin Adler>
Reviewed by Mitz.
- https://bugs.webkit.org/show_bug.cgi?id=18789 fix some shouldCloseWithWindow edge cases
- WebView/WebView.mm: (-[WebView viewWillMoveToWindow:]): Fix bug where we would stop observing the NSWindowWillCloseNotification if the view was moved out of the window but still had that window set as the host window. Also make sure this function doesn't do anything if the WebView is already closed. (-[WebView setHostWindow:]): Ditto.
- 9:31 AM Changeset in webkit [32873] by
-
- 1 edit1 copy in trunk/LayoutTests
Rubber-stamped by Adam Roben.
- fix test failure due to Windows' preference for Mac results over generic results
- platform/win/editing/selection/move-left-right-expected.txt: Copied from LayoutTests/editing/selection/move-left-right-expected.txt.
- 9:27 AM Changeset in webkit [32872] by
-
- 9 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix https://bugs.webkit.org/show_bug.cgi?id=18809 Forms with block level generated content and absolutely positioned labels break inline layout (fixed on reflow)
Test: fast/block/basic/adding-near-anonymous-block.html
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::addChildToFlow): When adding a floating or positioned object, if it follows an anonymous block, put it inside the anonymous block. When adding an inline, check if it comes after an anonymous block and put it in the anonymous block.
LayoutTests:
Reviewed by Dave Hyatt.
- test, updated test and updated results for https://bugs.webkit.org/show_bug.cgi?id=18809 Forms with block level generated content and absolutely positioned labels break inline layout (fixed on reflow)
- fast/block/basic/adding-near-anonymous-block.html: Added.
- media/video-controls-rendering.html: Changed to work around https://bugs.webkit.org/show_bug.cgi?id=18857 which now affects this test in its original form.
- platform/mac/css1/box_properties/clear-expected.txt:
- platform/mac/fast/block/basic/adding-near-anonymous-block-expected.checksum: Added.
- platform/mac/fast/block/basic/adding-near-anonymous-block-expected.png: Added.
- platform/mac/fast/block/basic/adding-near-anonymous-block-expected.txt: Added.
- platform/mac/fast/forms/input-align-image-expected.txt:
- platform/mac/media/audio-controls-rendering-expected.txt:
- platform/mac/media/video-controls-rendering-expected.txt:
- platform/mac/tables/mozilla/bugs/bug51140-expected.txt:
- 9:09 AM Changeset in webkit [32871] by
-
- 3 edits in trunk/WebCore
2008-05-05 Antti Koivisto <Antti Koivisto>
Reviewed by Darin.
Speculative fix for <rdar://problem/5906790>
Crash in Loader::servePendingRequests() due to hash table being modified during iteration
I don't know how to reproduce this. It would require the load to fail (or succeed)
synchronously, something that should not usually happen.
- loader/loader.cpp: (WebCore::Loader::Loader): (WebCore::Loader::load): (WebCore::Loader::servePendingRequests): (WebCore::Loader::cancelRequests): (WebCore::Loader::Host::Host):
- loader/loader.h: (WebCore::Loader::Host::name):
- 6:43 AM UsingGitWithWebKit edited by
- fix repository url (diff)
- 3:43 AM Changeset in webkit [32870] by
-
- 3 edits in branches/squirrelfish/JavaScriptCore
2008-05-05 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver.
- fix some dumb mistakes in my last patch
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitPushScope): (KJS::CodeGenerator::emitGetPropertyNames):
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- 3:26 AM Changeset in webkit [32869] by
-
- 2 edits in trunk/WebKitTools
Ariya Hidayat <ariya.hidayat@trolltech.com>
In the Qt's DumpRenderTree, adjust the web view properly (because W3C SVG
tests expect to be 480x360)
- 2:59 AM Changeset in webkit [32868] by
-
- 2 edits in trunk/WebCore
Ariya Hidayat <ariya.hidayat@trolltech.com>
Disable SVG As Image support in the Qt port again, as it
requires more work. Right now the chrome client is
assumed to be a ChromeClientQt, which the SVG Image support
changes.
- 2:34 AM Changeset in webkit [32867] by
-
- 5 edits in branches/squirrelfish/JavaScriptCore
2008-05-05 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver.
- document opcodes relating to jumps, scopes, and property name iteration
Documented jmp, jtrue, false, push_scope, pop_scope, get_pnames,
next_pname and jmp_scopes.
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitJump): (KJS::CodeGenerator::emitJumpIfTrue): (KJS::CodeGenerator::emitJumpIfFalse): (KJS::CodeGenerator::emitPushScope): (KJS::CodeGenerator::emitNextPropertyName): (KJS::CodeGenerator::emitGetPropertyNames):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- kjs/nodes.cpp: (KJS::LogicalAndNode::emitCode): (KJS::LogicalOrNode::emitCode): (KJS::ConditionalNode::emitCode): (KJS::IfNode::emitCode): (KJS::IfElseNode::emitCode): (KJS::DoWhileNode::emitCode): (KJS::WhileNode::emitCode): (KJS::ForNode::emitCode): (KJS::ForInNode::emitCode): (KJS::WithNode::emitCode):
- 1:01 AM Changeset in webkit [32866] by
-
- 4 edits in branches/squirrelfish/JavaScriptCore
Bug 18749: SQUIRRELFISH: const support is broken
<https://bugs.webkit.org/show_bug.cgi?id=18749>
Cameron Zwarich <cwzwarich@uwaterloo.ca>
Reviewed by Oliver.
Adds support for const during code generation.
Fixes 2 layout tests.
May 4, 2008:
- 11:48 PM Changeset in webkit [32865] by
-
- 5 edits in branches/squirrelfish/JavaScriptCore
2008-05-04 Maciej Stachowiak <mjs@apple.com>
Reviewed by Geoff.
- document some more opcodes (and fix argument names)
Added docs for eq, neq, stricteq, nstriceq, less and lesseq.
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitEqual): (KJS::CodeGenerator::emitNotEqual): (KJS::CodeGenerator::emitStrictEqual): (KJS::CodeGenerator::emitNotStrictEqual): (KJS::CodeGenerator::emitLess): (KJS::CodeGenerator::emitLessEq):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- kjs/nodes.cpp: (KJS::LessNode::emitCode): (KJS::GreaterNode::emitCode): (KJS::LessEqNode::emitCode): (KJS::GreaterEqNode::emitCode): (KJS::EqualNode::emitCode): (KJS::NotEqualNode::emitCode): (KJS::StrictEqualNode::emitCode): (KJS::NotStrictEqualNode::emitCode): (KJS::CaseBlockNode::emitCodeForBlock):
- 11:46 PM Changeset in webkit [32864] by
-
- 10 edits in branches/squirrelfish/JavaScriptCore
2008-05-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Maciej Stachowiak.
More scaffolding for f.arguments.
Track the offset of the last call frame in the ExecState, so we can
produce a backtrace at any time.
Also, record numLocals, the sum of numVars + numParameters, in each code
block, to make updates to the ExecState a little cheaper than they
would be otherwise.
We now use numLocals in a bunch of places where we used to calculate
numVars + numParameters or -numVars - numParameters.
Reports are mixed, but all in all, this seems to be a wash on SunSpider.
- 10:30 PM Changeset in webkit [32863] by
-
- 5 edits in trunk/WebKit/wx
Reviewed by Kevin Ollivier.
Allow events to specify the ID of the particular wxWebView they are to be sent to.
https://bugs.webkit.org/show_bug.cgi?id=18659
- 9:46 PM Changeset in webkit [32862] by
-
- 1 edit2 adds in trunk/LayoutTests
2008-05-02 Antti Koivisto <Antti Koivisto>
Reviewed by Mitz.
Test for <rdar://problem/5840475>
CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::RenderBlock::insertPositionedObject
- fast/transforms/container-transform-crash-expected.txt: Added.
- fast/transforms/container-transform-crash.html: Added.
- 9:44 PM Changeset in webkit [32861] by
-
- 2 edits in trunk/WebCore
2008-05-02 Antti Koivisto <Antti Koivisto>
Reviewed by Mitz.
Fix <rdar://problem/5840475>
CrashTracer: [USER] 2 crashes in Safari at com.apple.WebCore: WebCore::RenderBlock::insertPositionedObject
Non-block objects can have transforms so containingBlock() could end up returning null.
RenderObject::container() needs to match.
Test: fast/transforms/container-transform-crash.html
- rendering/RenderObject.cpp: (WebCore::RenderObject::containingBlock): (WebCore::RenderObject::container):
- 9:42 PM Changeset in webkit [32860] by
-
- 2 edits in branches/squirrelfish/JavaScriptCore
Whoops, correctly handle properties that don't exist in the
symbol table.
Reviewed by Geoff
- 7:14 PM Changeset in webkit [32859] by
-
- 8 edits in branches/squirrelfish/JavaScriptCore
Add attribute information to SymbolTable as ground work for
various DontEnum and ReadOnly issues.
Reviewed by Geoff
- 7:05 PM Changeset in webkit [32858] by
-
- 6 edits in branches/squirrelfish/JavaScriptCore
2008-05-04 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
More scaffolding for f.arguments.
Store the register file associated with an ExecState in the ExecState.
SunSpider reports no change.
- kjs/JSGlobalObject.h: (KJS::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): Moved registerFileStack above globalExec, so it gets initialized first. Removed remnants of old activation scheme.
- 6:48 PM Changeset in webkit [32857] by
-
- 2 edits in trunk/WebCore
2008-05-04 Sam Weinig <sam@webkit.org>
Roll out r32851. It broke tiger builds.
- bindings/objc/DOMUtility.mm: (KJS::createDOMWrapper): (WebCore::createDOMWrapper):
- 6:11 PM Changeset in webkit [32856] by
-
- 7 edits in branches/squirrelfish/JavaScriptCore
2008-05-04 Maciej Stachowiak <mjs@apple.com>
Rubber stamped by Oliver.
- renamed a few opcodes and fixed assembly formatting to accomodate the longest opcode
equal --> eq
nequal --> neq
resolve_base_and_property --> resolve_with_base
resolve_base_and_func --> resolve_func
get_prop_id --> get_by_id
put_prop_id --> put_by_id
delete_prop_id --> del_by_id
get_prop_val --> get_by_val
put_prop_val --> put_by_val
delete_prop_val --> del_by_val
put_prop_index --> put_by_index
- VM/CodeBlock.cpp: (KJS::printUnaryOp): (KJS::printBinaryOp): (KJS::printConditionalJump): (KJS::CodeBlock::dump):
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitEqual): (KJS::CodeGenerator::emitNotEqual): (KJS::CodeGenerator::emitResolveWithBase): (KJS::CodeGenerator::emitResolveFunction): (KJS::CodeGenerator::emitGetById): (KJS::CodeGenerator::emitPutById): (KJS::CodeGenerator::emitDeleteById): (KJS::CodeGenerator::emitGetByVal): (KJS::CodeGenerator::emitPutByVal): (KJS::CodeGenerator::emitDeleteByVal): (KJS::CodeGenerator::emitPutByIndex):
- VM/CodeGenerator.h:
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- VM/Opcode.h:
- kjs/nodes.cpp: (KJS::ArrayNode::emitCode): (KJS::PropertyListNode::emitCode): (KJS::BracketAccessorNode::emitCode): (KJS::DotAccessorNode::emitCode): (KJS::EvalFunctionCallNode::emitCode): (KJS::FunctionCallResolveNode::emitCode): (KJS::FunctionCallBracketNode::emitCode): (KJS::FunctionCallDotNode::emitCode): (KJS::PostIncResolveNode::emitCode): (KJS::PostDecResolveNode::emitCode): (KJS::PostIncBracketNode::emitCode): (KJS::PostDecBracketNode::emitCode): (KJS::PostIncDotNode::emitCode): (KJS::PostDecDotNode::emitCode): (KJS::DeleteResolveNode::emitCode): (KJS::DeleteBracketNode::emitCode): (KJS::DeleteDotNode::emitCode): (KJS::TypeOfResolveNode::emitCode): (KJS::PreIncResolveNode::emitCode): (KJS::PreDecResolveNode::emitCode): (KJS::PreIncBracketNode::emitCode): (KJS::PreDecBracketNode::emitCode): (KJS::PreIncDotNode::emitCode): (KJS::PreDecDotNode::emitCode): (KJS::ReadModifyResolveNode::emitCode): (KJS::AssignResolveNode::emitCode): (KJS::AssignDotNode::emitCode): (KJS::ReadModifyDotNode::emitCode): (KJS::AssignBracketNode::emitCode): (KJS::ReadModifyBracketNode::emitCode): (KJS::ConstDeclNode::emitCodeSingle): (KJS::ForInNode::emitCode): (KJS::TryNode::emitCode):
- 4:29 PM Changeset in webkit [32855] by
-
- 3 edits3 adds in branches/squirrelfish
Fix assertion when accessing arguments object with too many arguments provided
Reviewed by Maciej
The arguments constructor was assuming that the register offset given for argv
was an absolute offset into the registerfile, rather than the offset from the
frame. This patches corrects that issue.
- 3:03 PM Changeset in webkit [32854] by
-
- 3 edits2 adds in trunk
WebCore:
Reviewed by Sam Weinig.
- fix https://bugs.webkit.org/show_bug.cgi?id=18879 <rdar://problem/5909481> Reproducible crash when removing a gradient
Test: fast/gradients/crash-on-remove.html
- css/CSSImageGeneratorValue.cpp: (WebCore::CSSImageGeneratorValue::CSSImageGeneratorValue): (WebCore::CSSImageGeneratorValue::addClient): Added a call to ref() the value. (WebCore::CSSImageGeneratorValue::removeClient): Added code to deref() the value.
LayoutTests:
Reviewed by Sam Weinig.
- test for https://bugs.webkit.org/show_bug.cgi?id=18879 <rdar://problem/5909481> Reproducible crash when removing a gradient
- fast/gradients/crash-on-remove-expected.txt: Added.
- fast/gradients/crash-on-remove.html: Added.
- 2:52 PM Changeset in webkit [32853] by
-
- 5 edits in trunk/LayoutTests
2008-05-04 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Don't print out the full url.
- fast/dom/Window/dom-access-from-closure-iframe-expected.txt:
- fast/dom/Window/dom-access-from-closure-window-expected.txt:
- fast/dom/Window/resources/dom-access-from-closure-iframe-child.html:
- fast/dom/Window/resources/dom-access-from-closure-window-child.html:
- 2:52 PM Changeset in webkit [32852] by
-
- 2 edits in trunk/WebKit/mac
Make parameters match for WebChromeClient::addMessageToConsole()
Reviewed by John.
- WebCoreSupport/WebChromeClient.h: (WebChromeClient::addMessageToConsole): Renamed sourceID parameter to sourceURL to match implementation in WebChromeClient.mm.
- 2:29 PM Changeset in webkit [32851] by
-
- 2 edits in trunk/WebCore
2008-05-03 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Move createDOMWrapper(JSObject* object) out of the KJS namespace and into
the WebCore namespace now that the required compilers don't freak out about
this anymore.
- bindings/objc/DOMUtility.mm: (WebCore::createDOMWrapper):
- 11:27 AM Changeset in webkit [32850] by
-
- 2 edits in branches/squirrelfish/JavaScriptCore
2008-05-04 Geoffrey Garen <ggaren@apple.com>
Rubber stamped by Sam Weinig.
Cleaned up Machine.cpp according to our style guidelines: moved static
data to the top of the file; moved stand-alone functions below that;
moved the Machine constructor above other Machine member functions.
May 3, 2008:
- 11:36 PM Changeset in webkit [32849] by
-
- 5 edits in trunk
Reviewed by Sam.
https://bugs.webkit.org/show_bug.cgi?id=18652
onchange events don't seem to fire for input[type=range] controls.
Fire changeEvent when clicking the slider outside the current
thumb position.
- 6:04 PM Changeset in webkit [32848] by
-
- 2 edits in trunk/WebCore
2008-05-03 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Remove unused enums from JSDOMWindowBase.
- bindings/js/JSDOMWindowBase.h: (WebCore::JSDOMWindowBase::):
- 5:59 PM Changeset in webkit [32847] by
-
- 2 edits in trunk/WebCore
2008-05-03 Sam Weinig <sam@webkit.org>
Real build fix.
- WebCore.xcodeproj/project.pbxproj:
- 5:48 PM Changeset in webkit [32846] by
-
- 2 edits in trunk/WebCore
2008-05-03 Sam Weinig <sam@webkit.org>
Build fix.
- bindings/js/kjs_events.cpp: (WebCore::JSAbstractEventListener::handleEvent):
- 5:36 PM Changeset in webkit [32845] by
-
- 1 edit16 adds in trunk/LayoutTests
2008-05-03 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Add tests that show our behavior when using closures from a global object
whose frame has been navigated.
Related to https://bugs.webkit.org/show_bug.cgi?id=17249.
- fast/dom/Window/closure-access-after-navigation-iframe-expected.txt: Added.
- fast/dom/Window/closure-access-after-navigation-iframe.html: Added.
- fast/dom/Window/closure-access-after-navigation-window-expected.txt: Added.
- fast/dom/Window/closure-access-after-navigation-window.html: Added.
- fast/dom/Window/dom-access-from-closure-iframe-expected.txt: Added.
- fast/dom/Window/dom-access-from-closure-iframe.html: Added.
- fast/dom/Window/dom-access-from-closure-window-expected.txt: Added.
- fast/dom/Window/dom-access-from-closure-window.html: Added.
- fast/dom/Window/resources/closure-access-after-navigation-iframe-child-1.html: Added.
- fast/dom/Window/resources/closure-access-after-navigation-iframe-child-2.html: Added.
- fast/dom/Window/resources/closure-access-after-navigation-window-child-1.html: Added.
- fast/dom/Window/resources/closure-access-after-navigation-window-child-2.html: Added.
- fast/dom/Window/resources/dom-access-from-closure-iframe-child.html: Added.
- fast/dom/Window/resources/dom-access-from-closure-window-child.html: Added.
- fast/dom/Window/resources/notify-opener-done.html: Added.
- fast/dom/Window/resources/notify-parent-done.html: Added.
- 5:02 PM Changeset in webkit [32844] by
-
- 23 edits2 moves in trunk/WebCore
2008-05-03 Sam Weinig <sam@webkit.org>
Rubber-stamped by Geoffrey Garen.
Rename JSDOMWindowWrapper to JSDOMWindowShell.
- 2:40 PM Changeset in webkit [32843] by
-
- 2 edits in branches/squirrelfish/JavaScriptCore
2008-05-03 Maciej Stachowiak <mjs@apple.com>
Reviewed by Sam.
- fix accidental breakage from last patch
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- 2:08 PM Changeset in webkit [32842] by
-
- 7 edits in branches/squirrelfish/JavaScriptCore
2008-05-03 Maciej Stachowiak <mjs@apple.com>
Reviewed by Geoff.
- a bunch more opcode documentation and corresponding parameter name fixes
I renamed a few opcodes:
type_of --> typeof (that's what the JS operator is named)
instance_of --> instanceof (ditto)
create_error --> new_error (for consistency with other new_* opcodes)
I documented the following opcodes:
- load
- new_object
- new_array
- new_regexp
- mov
- pre_inc
- pre_dec
- post_inc
- post_dec
- to_jsnumber
- negate
- bitnot
- not
- instanceof
- typeof
- in
- new_func
- new_funcexp
- new_error
I also fixed formatting on some existing opcode docs.
- VM/CodeBlock.cpp: (KJS::CodeBlock::dump):
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitMove): (KJS::CodeGenerator::emitNot): (KJS::CodeGenerator::emitPreInc): (KJS::CodeGenerator::emitPreDec): (KJS::CodeGenerator::emitPostInc): (KJS::CodeGenerator::emitPostDec): (KJS::CodeGenerator::emitToJSNumber): (KJS::CodeGenerator::emitNegate): (KJS::CodeGenerator::emitBitNot): (KJS::CodeGenerator::emitInstanceOf): (KJS::CodeGenerator::emitTypeOf): (KJS::CodeGenerator::emitIn): (KJS::CodeGenerator::emitLoad): (KJS::CodeGenerator::emitNewObject): (KJS::CodeGenerator::emitNewArray): (KJS::CodeGenerator::emitNewRegExp): (KJS::CodeGenerator::emitNewError):
- VM/CodeGenerator.h: (KJS::CodeGenerator::scopeDepth): (KJS::CodeGenerator::addVar):
- VM/Machine.cpp: (KJS::Machine::privateExecute):
- VM/Opcode.h:
- kjs/nodes.cpp: (KJS::Node::emitThrowError): (KJS::RegExpNode::emitCode): (KJS::TypeOfValueNode::emitCode): (KJS::UnaryPlusNode::emitCode): (KJS::NegateNode::emitCode): (KJS::BitwiseNotNode::emitCode): (KJS::LogicalNotNode::emitCode): (KJS::InstanceOfNode::emitCode): (KJS::InNode::emitCode):
- 1:53 PM Changeset in webkit [32841] by
-
- 2 edits2 adds in branches/squirrelfish/JavaScriptCore
2008-05-03 Maciej Stachowiak <mjs@apple.com>
Reviewed by Geoff and Sam.
- generate HTML bytecode docs at build time
- DerivedSources.make:
- docs: Added.
- docs/make-bytecode-docs.pl: Added.
- 1:35 PM Changeset in webkit [32840] by
-
- 7 edits in branches/squirrelfish/JavaScriptCore
2008-05-03 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Update ExecState::m_scopeChain when switching scope chains inside the
machine.
This fixes uses of lexicalGlobalObject, such as, in a subframe
alert(top.makeArray() instanceof Array ? "FAIL" : "PASS");
and a bunch of the security failures listed in
https://bugs.webkit.org/show_bug.cgi?id=18870. (Those tests still fail,
seemingly because of regressions in exception messages).
SunSpider reports no change.
- VM/Machine.cpp: Factored out scope chain updating into a common function that takes care to update ExecState::m_scopeChain, too.
- kjs/ExecState.h: I made Machine a friend of ExecState so that Machine could update ExecState::m_scopeChain, even though that value is read-only for everyone else.
- kjs/JSGlobalObject.h: (KJS::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData): Changed this client to be a little friendlier to ExecState's internal storage type for scope chain data.
- 12:36 PM Changeset in webkit [32839] by
-
- 2 edits in branches/squirrelfish/JavaScriptCore
2008-05-03 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam Weinig.
Fixed https://bugs.webkit.org/show_bug.cgi?id=18876
Squirrelfish: ScopeChainNode leak in op_jmp_scopes.
SunSpider reports no change.
- VM/Machine.cpp: (KJS::Machine::privateExecute): Don't construct a ScopeChain object, since the direct threaded interpreter will goto across its destructor.
- 2:14 AM Changeset in webkit [32838] by
-
- 8 edits in branches/squirrelfish/JavaScriptCore
2008-05-03 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
A bit more efficient fix than r32832: Don't copy globals into function
register files; instead, have the RegisterFileStack track only the base
of the last *global* register file, so the global object's register
references stay good.
SunSpider reports a .3% speedup. Not sure what that's about.
- 12:20 AM Changeset in webkit [32837] by
-
- 6 edits in branches/squirrelfish/JavaScriptCore
Bug 18864: SquirrelFish: Support getter and setter definition in object literals
<https://bugs.webkit.org/show_bug.cgi?id=18864>
Reviewed by Maciej
Add new opcodes to allow us to add getters and setters to an object. These are
only used by the codegen for object literals.
May 2, 2008:
- 11:44 PM Changeset in webkit [32836] by
-
- 6 edits2 adds in trunk
Reviewed by Eric.
https://bugs.webkit.org/show_bug.cgi?id=18568
background: currentColor fails
Implement currentColor from CSS3 color module.
Tests: fast/css/background-currentcolor.html
- 11:43 PM Changeset in webkit [32835] by
-
- 4 edits in tags/Safari-6526.3.3
Versioning.
- 11:40 PM Changeset in webkit [32834] by
-
- 2 edits in tags/Safari-6526.3.3/WebKitLibraries
Merge r32649.
- 11:30 PM Changeset in webkit [32833] by
-
- 1 copy in tags/Safari-6526.3.3
New tag.
- 10:40 PM Changeset in webkit [32832] by
-
- 2 edits in branches/squirrelfish/JavaScriptCore
2008-05-02 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver.
- properly copy globals into and out of implicit call register files, otherwise they will fail at global lookup
Fixes fast/js/array-tostring-and-join.html layout test.
- VM/RegisterFileStack.cpp: (KJS::RegisterFileStack::pushGlobalRegisterFile): (KJS::RegisterFileStack::popGlobalRegisterFile): (KJS::RegisterFileStack::pushFunctionRegisterFile): (KJS::RegisterFileStack::popFunctionRegisterFile):
- 7:25 PM Changeset in webkit [32831] by
-
- 5 edits in branches/squirrelfish/JavaScriptCore
2008-05-02 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Fixed https://bugs.webkit.org/show_bug.cgi?id=18822
SQUIRRELFISH: incorrect eval used in some cases
Changed all code inside the machine to fetch the lexical global object
directly from the scope chain, instead of from the ExecState.
Clients who fetch the lexical global object through the ExecState
still don't work.
SunSpider reports no change.
- VM/Machine.cpp: (KJS::Machine::privateExecute): Fetch the lexical global object from the scope chain.
- kjs/ExecState.h: (KJS::ExecState::ExecState::lexicalGlobalObject): Moved the logic for this function into ScopeChainNode, but kept this function around to support existing clients.
- 5:44 PM Changeset in webkit [32830] by
-
- 5 edits in trunk
WebCore:
2008-05-02 Anders Carlsson <andersca@apple.com>
Reviewed by Mark.
Turns out calling locationInWindow on keyboard events will not throw an exception,
but the point returned is completely bogus, so remove coordinates from the keyboard event struct.
- bridge/npapi.h: (_NPCocoaEvent::):
WebKit/mac:
2008-05-02 Anders Carlsson <andersca@apple.com>
Reviewed by Mark.
Various Cocoa event model and 64-bit plug-in fixes.
- Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::sendMouseEvent): Set click count.
(WebNetscapePluginEventHandlerCocoa::flagsChanged):
(WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
Don't try to get the mouse location for keyboard events.
- Plugins/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): Preflight the bundle so we won't show 32-bit WebKit plug-ins when running as 64-bit.
- 5:21 PM Changeset in webkit [32829] by
-
- 2 edits in trunk
2008-05-02 Anders Carlsson <andersca@apple.com>
Reviewed by Mark.
Add an "x86_64" make rule.
- Makefile.shared:
- 4:10 PM Changeset in webkit [32828] by
-
- 2 edits in trunk/WebCore
2008-05-02 Benjamin Otte <otte@gnome.org>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=18856
[GTK] variable initialization missing
Not initializing the m_needsXEmbed variable could have very funny
results. Most often those results would be crashes.
- plugins/PluginView.cpp: (WebCore::PluginView::PluginView):
- 3:21 PM Changeset in webkit [32827] by
-
- 4 edits in trunk
2008-05-02 Jan Michael Alonzo <jmalonzo@unpluggable.com>
Reviewed by Eric.
https://bugs.webkit.org/show_bug.cgi?id=18811
Enable dashboard and offline web apps in autotools
- 2:07 PM Changeset in webkit [32826] by
-
- 2 edits in tags/Safari-6526.3.2/JavaScriptCore
Merge r32654.
- 2:04 PM Changeset in webkit [32825] by
-
- 4 edits in tags/Safari-6526.3.2
Versioning.
- 2:02 PM Changeset in webkit [32824] by
-
- 1 copy in tags/Safari-6526.3.2
New tag.
- 1:21 PM Changeset in webkit [32823] by
-
- 4 edits in tags/Safari-6526.3.1/WebKit/mac
Merge r32706.
- 1:05 PM Changeset in webkit [32822] by
-
- 4 edits in trunk/JavaScriptCore
Reviewed by Geoffrey Garen.
Get rid of static data in nodes.cpp (well, at least of non-debug one).
No measurable change on SunSpider.
- kjs/InitializeThreading.cpp: (KJS::initializeThreadingOnce):
- kjs/nodes.cpp: (KJS::newTrackedObjects): (KJS::trackedObjectExtraRefCounts): (KJS::initializeNodesThreading): (KJS::ParserRefCounted::ParserRefCounted): (KJS::ParserRefCounted::ref): (KJS::ParserRefCounted::deref): (KJS::ParserRefCounted::refcount): (KJS::ParserRefCounted::deleteNewObjects):
- kjs/nodes.h: Made newTrackedObjects and trackedObjectExtraRefCounts per-thread.
- 12:23 PM Changeset in webkit [32821] by
-
- 4 edits in trunk
WebCore:
2008-05-02 Anders Carlsson <andersca@apple.com>
Reviewed by Sam.
Name the event union so it will work in plain C.
- bridge/npapi.h: (_NPCocoaEvent::):
WebKit/mac:
2008-05-02 Anders Carlsson <andersca@apple.com>
Reviewed by Sam.
The event union is now named.
- Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::drawRect): (WebNetscapePluginEventHandlerCocoa::sendMouseEvent): (WebNetscapePluginEventHandlerCocoa::flagsChanged): (WebNetscapePluginEventHandlerCocoa::sendKeyEvent): (WebNetscapePluginEventHandlerCocoa::windowFocusChanged): (WebNetscapePluginEventHandlerCocoa::focusChanged):
- 11:15 AM Changeset in webkit [32820] by
-
- 2 edits in trunk/WebKit/mac
2008-05-02 Anders Carlsson <andersca@apple.com>
Reviewed by Mark.
Make sure that 32-bit only plug-ins aren't shown when running as 64-bit.
Call preflightAndReturnError on the bundle, which will check if any of the architectures
in the bundle match the current architecture.
- Plugins/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage _initWithPath:]):
- 11:10 AM Changeset in webkit [32819] by
-
- 5 edits in trunk/JavaScriptCore
Reviewed by Darin.
Move call stack depth counter to global object.
- kjs/ExecState.h: (KJS::ExecState::functionCallDepth): Added a recursion depth counter to per-thread data.
- kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init): Initialize PerThreadData.functionCallDepth.
- kjs/JSGlobalObject.h: (KJS::JSGlobalObject::perThreadData): Made the result non-const.
- kjs/object.cpp: (KJS::throwStackSizeExceededError): Moved throwError to a separate function, since it is now the only thing in JSObject::call that needs a PIC branch. (KJS::JSObject::call): Use a per-thread variable instead of local static for recursion depth tracking.
- 10:53 AM Changeset in webkit [32818] by
-
- 2 edits in trunk/WebKitTools
Reviewed by Adam Roben.
- add an option to svn-apply to set the reviewer name in change logs
Scripts/svn-apply: Added a [-rreviewer name] option. - 9:15 AM Changeset in webkit [32817] by
-
- 4 edits4 adds in trunk
WebCore:
Reviewed by John Sullivan.
- render text shadows with zero offset, as the shadow can be seen behind the text if the text is translucent
Test: fast/text/shadow-no-blur.html
- platform/graphics/mac/FontMac.mm: (WebCore::Font::drawComplexText): Removed the isEmpty() condition on the shadow offset. Since isEmpty() is also true for sizes that have one or more non-positive components, this also ensures that subpixel antialiasing of the text is maintained with shadows in all directions. (WebCore::Font::drawGlyphs): Ditto.
- platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs): Ditto.
LayoutTests:
Reviewed by John Sullivan.
- add pixel test for text shadows with zero blur and various offsets, including zero offset
- fast/text/shadow-no-blur.html: Added.
- platform/mac/fast/text/shadow-no-blur-expected.checksum: Added.
- platform/mac/fast/text/shadow-no-blur-expected.png: Added.
- platform/mac/fast/text/shadow-no-blur-expected.txt: Added.
- 7:48 AM Changeset in webkit [32816] by
-
- 102 edits14 adds in trunk/LayoutTests
2008-05-02 Tor Arne Vestbø <tavestbo@trolltech.com>
Updated Qt layout-tests to match changes in font metrics.
- 7:09 AM Changeset in webkit [32815] by
-
- 2 edits in trunk/WebCore
Ariya Hidayat <ariya.hidayat@trolltech.com>
Build the Qt port with SVG Use and As Image support.
- 6:40 AM Changeset in webkit [32814] by
-
- 2 edits in trunk/WebCore
Ariya Hidayat <ariya.hidayat@trolltech.com>
Fixed potential crash on SVG animation (added more checks to the assert).
- 6:21 AM Changeset in webkit [32813] by
-
- 2 edits in trunk/WebKit/qt
Benjamin Meyer <bmeyer@trolltech.com>
Doc: Mention that you have to enable plugins in QWebSettings for them to work.
- 6:07 AM Changeset in webkit [32812] by
-
- 2 edits in trunk/WebCore
Rubber-stamped by John Sullivan.
Fix a debug-only crash in layout tests.
- loader/CachedResource.cpp: (WebCore::CachedResource::~CachedResource): Don't call resourceForURL() for null URLs.
- 5:07 AM Changeset in webkit [32811] by
-
- 2 edits in trunk/WebCore
Fix the Qt build on Windows when Phonon is enabled for Audio/Video support
- 4:04 AM Changeset in webkit [32810] by
-
- 8 edits in trunk
Fix the Qt build, add ExecState where required.
- 3:32 AM Changeset in webkit [32809] by
-
- 4 edits in trunk/WebCore
Fix the Qt/Win build.
- 3:29 AM Changeset in webkit [32808] by
-
- 9 edits in trunk
Reviewed by Darin.
Make JavaScriptGlue and JavaScriptCore API functions implicitly call initializeThreading
for the sake of non-WebKit clients.
- API/JSBase.cpp: (JSGarbageCollect):
- API/JSContextRef.cpp: (JSGlobalContextCreate): These are the JavaScriptCore API bottlenecks. There are a few other JSStringRef and JSClassRef functions that can be called earlier, but they do not do anything that requires initializeThreading.
- kjs/InitializeThreading.cpp: (KJS::doInitializeThreading): (KJS::initializeThreading): On Darwin, make the initialization happen under pthread_once, since there is no guarantee that non-WebKit clients won't try to call this function re-entrantly.
- kjs/InitializeThreading.h:
- wtf/Threading.h: Spell out initializeThreading contract.
- wtf/ThreadingPthreads.cpp: (WTF::isMainThread): Make sure that results are correct on Darwin, even if threading was initialized from a secondary thread.
JavaScriptGlue:
- JavaScriptGlue.cpp: (JSRunCreate): (JSCollect): (JSCreateJSArrayFromCFArray): (JSLockInterpreter): These are all possible JavaScriptGlue entry points.
- 3:07 AM Changeset in webkit [32807] by
-
- 126 edits in trunk
Reviewed by Geoffrey Garen.
https://bugs.webkit.org/show_bug.cgi?id=18826
Make JavaScript heap per-thread
- 2:55 AM Changeset in webkit [32806] by
-
- 2 edits in trunk/WebCore
2008-05-02 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Build the Qt port with SVG Animation support.
- 12:55 AM Changeset in webkit [32805] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Maciej Stachowiak.
- Mac build fix
- wtf/StrHash.h: Added header guards and removed #include "config.h".
- 12:39 AM Changeset in webkit [32804] by
-
- 2 edits in trunk/WebCore
Build fix for Qt/Gtk. Don't declare NP_InitializeFuncPtr twice
with different signatures.
- 12:27 AM Changeset in webkit [32803] by
-
- 3 edits in branches/squirrelfish/JavaScriptCore
2008-05-02 Geoffrey Garen <ggaren@apple.com>
Rubber stamped by Oliver Hunt.
Removed ExecState.cpp from AllInOneFile.cpp, for a .2% speedup.
- JavaScriptCore.xcodeproj/project.pbxproj:
- kjs/AllInOneFile.cpp:
May 1, 2008:
- 11:37 PM Changeset in webkit [32802] by
-
- 3 edits in trunk/WebCore
Reviewed by Kevin Ollivier.
Explicitly set the pen style in wx port to keep pen style changes from affecting URL underline or text field drawing.
https://bugs.webkit.org/show_bug.cgi?id=18775
- 11:37 PM Changeset in webkit [32801] by
-
- 2 edits in branches/squirrelfish/LayoutTests
2008-05-01 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver.
- bump up the numbers in this test to account for our now much higher recursion capability.
- fast/js/deep-recursion-test.html:
- 11:24 PM Changeset in webkit [32800] by
-
- 4 edits1 add in trunk/WebCore
Reviewed by Kevin Ollivier.
Implement popup menu support for wx port.
https://bugs.webkit.org/show_bug.cgi?id=18776
- 10:48 PM Changeset in webkit [32799] by
-
- 2 edits in trunk/JavaScriptCore
#include <wtf/StrHash.h> in identifier.cpp.
Reviewed by Maciej.
- kjs/identifier.cpp:
- 10:16 PM Changeset in webkit [32798] by
-
- 2 edits in trunk/WebCore
Reviewed by Eric Seidel.
Make sure we properly set the button for all mouse events, not just mouse down, set the click count to 0 for non-click events, and finally set the timestamp.
https://bugs.webkit.org/show_bug.cgi?id=18464
- 9:12 PM Changeset in webkit [32797] by
-
- 6 edits in branches/squirrelfish/JavaScriptCore
Bug 18827: SquirrelFish: Prevent getters and setters from destroying the current RegisterFile
<https://bugs.webkit.org/show_bug.cgi?id=18827>
Reviewed by Maciej and Geoff
Remove safe/unsafe RegisterFile concept, and instead just add additional
logic to ensure we always push/pop RegisterFiles when executing getters
and setters, similar to the logic for valueOf and toString.
- 8:00 PM Changeset in webkit [32796] by
-
- 1 edit1 add in trunk/LayoutTests
2008-05-01 Sam Weinig <sam@webkit.org>
Add missing result.
- fast/canvas/canvas-path-with-inf-nan-dimensions-expected.txt: Added.
- 7:34 PM Changeset in webkit [32795] by
-
- 10 edits4 adds2 deletes in trunk/WebCore
2008-05-01 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe (in his infinite wisdom).
Auto-generate the JSXSLTProcessor binding.
- DerivedSources.make:
- GNUmakefile.am:
- WebCore.pro:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- WebCoreSources.bkl:
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::getValueProperty):
- bindings/js/JSDOMWindowBase.h: (WebCore::JSDOMWindowBase::):
- bindings/js/JSXSLTProcessor.cpp: Removed.
- bindings/js/JSXSLTProcessor.h: Removed.
- xml/XSLTProcessor.h:
- 7:27 PM Changeset in webkit [32794] by
-
- 4 edits in tags/Safari-6526.3.1
Versioning.
- 7:26 PM Changeset in webkit [32793] by
-
- 2 edits in tags/Safari-6526.3.1/JavaScriptCore
Merge r32789.
- 7:23 PM Changeset in webkit [32792] by
-
- 1 copy in tags/Safari-6526.3.1
New tag.
- 7:08 PM Changeset in webkit [32791] by
-
- 16 edits in trunk
WebCore:
2008-05-01 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Fixes:
- https://bugs.webkit.org/show_bug.cgi?id=17249 Incorrect lexical scope after navigation leads to UXSS <rdar://problem/5738497>
- https://bugs.webkit.org/show_bug.cgi?id=16824 Script authorization should follow lexical (not dynamic) scope <rdar://problem/5683032>
This patch changes us to perform same-origin checks based on the lexical global object)
rather than dynamic global object, which is now possible we don't re-use the window on
navigations, but rather switch in a new one and re-use the outer shell. This is both
more secure and conforms with the HTML5 specification. Now that all the checks are
done based on the lexical global object, we can remove the SecurityOrigin::Reason
concept, as it was only around to work around an ebay.com bug that required the check to
be done that way.
An important thing to note is that we currently implement a stricter than necessary policy
and perform the same-origin check based on the currently active global object to avoid leaking
the document in cases when the target frame is navigated before access. This will be fixed in
an upcoming patch.
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::allowsAccessFrom): (WebCore::JSDOMWindowBase::allowsAccessFromNoErrorMessage): (WebCore::JSDOMWindowBase::allowsAccessFromPrivate): (WebCore::JSDOMWindowBase::crossDomainAccessErrorMessage): (WebCore::JSDOMWindowBase::printErrorMessage): (WebCore::asJSDOMWindow):
- bindings/js/JSDOMWindowBase.h:
- html/CanvasRenderingContext2D.cpp: (WebCore::CanvasRenderingContext2D::checkOrigin): (WebCore::CanvasRenderingContext2D::createPattern):
- loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): (WebCore::FrameLoader::write): (WebCore::FrameLoader::setOpener): (WebCore::FrameLoader::shouldAllowNavigation):
- page/DOMWindow.h: (WebCore::DOMWindow::setSecurityOrigin): (WebCore::DOMWindow::securityOrigin): (WebCore::DOMWindow::setURL): (WebCore::DOMWindow::url):
- platform/SecurityOrigin.cpp: (WebCore::SecurityOrigin::canAccess): (WebCore::SecurityOrigin::isSecureTransitionTo):
- platform/SecurityOrigin.h:
LayoutTests:
2008-05-01 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
- http/tests/security/listener/xss-JSTargetNode-onclick-addEventListener-expected.txt:
- http/tests/security/listener/xss-JSTargetNode-onclick-shortcut-expected.txt:
- http/tests/security/listener/xss-XMLHttpRequest-addEventListener-expected.txt:
- http/tests/security/listener/xss-XMLHttpRequest-shortcut-expected.txt:
- http/tests/security/listener/xss-window-onclick-addEventListener-expected.txt:
- http/tests/security/listener/xss-window-onclick-shortcut-expected.txt:
- http/tests/security/xss-eval-expected.txt:
- 6:34 PM Changeset in webkit [32790] by
-
- 11 edits in trunk
WebCore:
2008-05-01 Anders Carlsson <andersca@apple.com>
Reviewed by Mark.
Enable 64-bit NPAPI plugins.
- WebCore.xcodeproj/project.pbxproj: Don't remove NPAPI related symbols from the 64-bit .exp file.
- bridge/npruntime.h: Remove now unnecessary #error.
WebKit/mac:
2008-05-01 Anders Carlsson <andersca@apple.com>
Reviewed by Mark.
64-bit NPAPI plugin build fixes.
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): (-[WebBaseNetscapePluginView updateAndSetWindow]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView windowBecameKey:]):
- Plugins/WebNetscapeDeprecatedFunctions.c:
- Plugins/WebNetscapeDeprecatedFunctions.h:
- Plugins/WebNetscapePluginEventHandler.mm: (WebNetscapePluginEventHandler::create):
- Plugins/WebNetscapePluginEventHandlerCarbon.h:
- Plugins/WebNetscapePluginEventHandlerCarbon.mm:
- Plugins/WebPluginDatabase.m: (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]):
- 6:10 PM Changeset in webkit [32789] by
-
- 2 edits in trunk/JavaScriptCore
2008-05-01 Steve Falkenburg <sfalken@apple.com>
Build fix.
- JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
- 6:02 PM Changeset in webkit [32788] by
-
- 3 edits in trunk/WebCore
2008-05-01 Maciej Stachowiak <mjs@apple.com>
Reviewed by Oliver (a while ago)
- just a wee bit more bindings speedup
Store the per-document Node --> JS wrapper cache in the document
instead of an external hashtable.
- bindings/js/kjs_binding.cpp: (WebCore::ScriptInterpreter::getDOMNodeForDocument): (WebCore::ScriptInterpreter::forgetDOMNodeForDocument): (WebCore::ScriptInterpreter::putDOMNodeForDocument): (WebCore::ScriptInterpreter::forgetAllDOMNodesForDocument): (WebCore::ScriptInterpreter::markDOMNodesForDocument):
- dom/Document.h: (WebCore::Document::wrapperCache):
- 5:15 PM Changeset in webkit [32787] by
-
- 7 edits1 delete in trunk
WebCore:
2008-05-01 Anders Carlsson <andersca@apple.com>
Reviewed by Tim.
Remove duplicate npfunctions.h header from WebKit.
- WebCore.xcodeproj/project.pbxproj: Add npfunctions.h and set its role to private.
- plugins/npfunctions.h: Merge Mac specific changes.
WebKit:
2008-05-01 Anders Carlsson <andersca@apple.com>
Reviewed by Tim.
Remove npfunctions.h
- WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
2008-05-01 Anders Carlsson <andersca@apple.com>
Reviewed by Tim.
Remove duplicate npfunctions.h header from WebKit.
- MigrateHeaders.make: Migrate npfunctions.h
- Plugins/npfunctions.h: Removed.
- 4:58 PM Changeset in webkit [32786] by
-
- 13 edits in trunk/WebCore
2008-05-01 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Rename toJSDOMWindow(KJS::JSGlobalObject) to asJSDOMWindow, as all it does is
cast.
- bindings/js/JSCustomVoidCallback.cpp: (WebCore::toVoidCallback):
- bindings/js/JSCustomXPathNSResolver.cpp: (WebCore::JSCustomXPathNSResolver::create):
- bindings/js/JSDOMApplicationCacheCustom.cpp: (WebCore::JSDOMApplicationCache::add): (WebCore::JSDOMApplicationCache::remove):
- bindings/js/JSDOMWindowBase.cpp: (WebCore::allowPopUp): (WebCore::createWindow): (WebCore::windowProtoFuncOpen): (WebCore::asJSDOMWindow):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::setLocation): (WebCore::JSDOMWindow::postMessage):
- bindings/js/JSDatabaseCustom.cpp: (WebCore::JSDatabase::changeVersion): (WebCore::JSDatabase::transaction):
- bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::setLocation):
- bindings/js/JSLocationCustom.cpp: (WebCore::navigateIfAllowed): (WebCore::JSLocation::setHref): (WebCore::JSLocation::replace): (WebCore::JSLocation::reload): (WebCore::JSLocation::assign):
- bindings/js/JSSQLTransactionCustom.cpp: (WebCore::JSSQLTransaction::executeSql):
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::open):
- page/JavaScriptDebugServer.cpp: (WebCore::toPage):
- 4:58 PM Changeset in webkit [32785] by
-
- 1 edit1 move in trunk/LayoutTests
2008-05-01 Anders Carlsson <andersca@apple.com>
Reviewed by Mitz.
Disable an SVG font test that crashes.
http://bugs.webkit.org/show_bug.cgi?id=18830 tracks fixing the crash.
- svg/W3C-SVG-1.1/fonts-glyph-02-t.svg: Removed.
- svg/W3C-SVG-1.1/fonts-glyph-02-t.svg-disabled: Copied from svg/W3C-SVG-1.1/fonts-glyph-02-t.svg.
- 4:54 PM Changeset in webkit [32784] by
-
- 3 edits4 adds in trunk
WebCore:
2008-05-01 Anatoli Papirovski <apapirovski@mac.com>
Reviewed by Dave Hyatt.
- fix https://bugs.webkit.org/show_bug.cgi?id=18347 Absolutely positioned image percentage width does not respect container's padding
Test: fast/replaced/absolute-position-percentage-width.html
- rendering/RenderBox.cpp: (WebCore::RenderBox::calcReplacedWidthUsing):
LayoutTests:
2008-05-01 Anatoli Papirovski <apapirovski@mac.com>
Reviewed by Dave Hyatt.
- added a test case for https://bugs.webkit.org/show_bug.cgi?id=18347 Absolutely positioned image percentage width does not respect container's padding
- fast/replaced/absolute-position-percentage-width.html: Added.
- platform/mac/fast/replaced/absolute-position-percentage-width-expected.checksum: Added.
- platform/mac/fast/replaced/absolute-position-percentage-width-expected.png: Added.
- platform/mac/fast/replaced/absolute-position-percentage-width-expected.txt: Added.
- 4:36 PM Changeset in webkit [32783] by
-
- 2 edits in trunk/WebCore
- Windows build fix
- platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs):
- 4:33 PM Changeset in webkit [32782] by
-
- 2 edits in trunk/WebKit/mac
2008-05-01 Anders Carlsson <andersca@apple.com>
Reviewed by John.
Add null checks for the event handler.
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView stopTimers]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
- 4:10 PM Changeset in webkit [32781] by
-
- 4 edits in trunk/WebCore
Reviewed by Darin Adler.
- make synthetic bold and synthetic italics work in GDI text
- account for synthetic bold in complex text on Windows
- platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs): Adjusted the text rectangle's x coordinates to fit italics. Added a skew transform for synthetic italics and a second paint pass for synthetic bold.
- platform/graphics/win/SimpleFontDataWin.cpp: (WebCore::SimpleFontData::widthForGDIGlyph): Added the synthetic bold offset.
- platform/graphics/win/UniscribeController.cpp: (WebCore::UniscribeController::shapeAndPlaceItem): Added the synthetic bold offset.
- 3:53 PM Changeset in webkit [32780] by
-
- 2 edits in trunk/WebCore
2008-05-01 Alp Toker <alp@nuanti.com>
Qt/Win build fix attempt following plugin changes. Add missing return
statements.
Also fixes some newly introduced coding style issues in the Qt port.
- platform/qt/FileSystemQt.cpp: (WebCore::openTemporaryFile): (WebCore::closeFile): (WebCore::writeToFile): (WebCore::unloadModule):
- 3:39 PM Changeset in webkit [32779] by
-
- 4 edits in branches/squirrelfish/JavaScriptCore
Rename unsafeForReentry to safeForReentry to avoid double negatives.
RS=Geoff
- 3:21 PM Changeset in webkit [32778] by
-
- 4 edits in trunk/WebKit/mac
2008-05-01 Anders Carlsson <andersca@apple.com>
Fix 64-bit build.
- Plugins/WebNetscapePluginEventHandlerCocoa.h:
- Plugins/WebNetscapePluginEventHandlerCocoa.mm:
- WebCoreSupport/WebFrameLoaderClient.mm:
- 3:01 PM Changeset in webkit [32777] by
-
- 2 edits in trunk/WebKit/mac
2008-05-01 Anders Carlsson <andersca@apple.com>
Fix build.
- Plugins/npfunctions.h:
- 2:38 PM BuildingGtk edited by
- Remove non-working link to Aplix wiki (feel free to re-add if this is … (diff)
- 2:37 PM HackingGtk edited by
- Add plugin-related sources to bundled code list (diff)
- 2:28 PM Changeset in webkit [32776] by
-
- 3 edits in trunk/LayoutTests
Rubber-stamped by Sam Weinig.
Mark a couple UTF16 files as binary so windows-svn doesn't mutilate them on checkout.
- fast/xsl/xslt-enc16.xml: add svn:mime-type application/octet-stream
- fast/xsl/xslt-enc16to16.xml: add svn:mime-type application/octet-stream
- 1:43 PM Changeset in webkit [32775] by
-
- 2 edits in trunk/WebCore
2008-05-01 Anders Carlsson <andersca@apple.com>
Reviewed by Adam.
Export methods needed to subclass Widget. (See r32770.)
- WebCore.base.exp:
- 1:25 PM Changeset in webkit [32774] by
-
- 4 edits in trunk
Versioning.
- 1:06 PM Changeset in webkit [32773] by
-
- 64 edits in tags/Safari-6526.3
Merge r32652
- 12:59 PM Changeset in webkit [32772] by
-
- 4 edits in trunk
Versioning.
- 12:57 PM Changeset in webkit [32771] by
-
- 1 copy in tags/Safari-6526.3
New tag.
- 12:42 PM Changeset in webkit [32770] by
-
- 5 edits in trunk/WebKit/mac
2008-05-01 Anders Carlsson <andersca@apple.com>
Reviewed by Adam.
Forward mouse move events to the Netscape plug-in view.
- Plugins/WebBaseNetscapePluginView.h:
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView handleMouseMoved:]): New method that just calls the current event handler.
- Plugins/WebNetscapePluginEventHandlerCocoa.mm: (WebNetscapePluginEventHandlerCocoa::flagsChanged): NSFlagsChanged is not a regular keyboard event and some of the NSEvent accessors don't work on it so don't call them.
- WebCoreSupport/WebFrameLoaderClient.mm: (NetscapePluginWidget::NetscapePluginWidget): New Widget subclass to be used for Netscape plug-ins.
(NetscapePluginWidget::handleEvent):
Forward NSMouseMoved events to the plug-in.
(WebFrameLoaderClient::createPlugin):
Wrap the plug-in view in a NetscapePluginWidget.
- 12:15 PM Changeset in webkit [32769] by
-
- 2 edits in trunk/LayoutTests
2008-05-01 Alice Liu <alice.liu@apple.com>
Rubber-stamped by Sam Weinig.
fast/events/tabindex-focus-blur-all.html was timing out on some machines
Make this test faster by not doing += on innerHTML.
- fast/events/resources/tabindex-focus-blur-all.js:
- 11:52 AM Changeset in webkit [32768] by
-
- 1 edit in trunk/WebKitTools/Scripts/run-webkit-tests
Cleaned up ugly if/else statement.
- 11:34 AM Changeset in webkit [32767] by
-
- 2 edits in trunk/WebKitTools
Clean up configuration usage in run-webkit-tests
Reviewed by Adam.
- Scripts/run-webkit-tests: Parse configuration switches using passedConfiguration() from webkitdirs.pm like every other script. Note that we must still call setConfiguration() afterwards in case the --configuration switch was used. Use $configurationOption when running build-dumprendertree instead of recreating the switch.
- 11:15 AM Changeset in webkit [32766] by
-
- 30 edits7 adds in trunk
2008-05-01 Marc Ordinas i Llopis <marc.ordinasillopis@collabora.co.uk>
Reviewed by Alp Toker.
Qt parts OK'ed by Simon Hausmann.
Based on work by several authors.
https://bugs.webkit.org/show_bug.cgi?id=14750
Added support for NPAPI plugins on Gtk and Qt-x11 ports.
- 11:14 AM Changeset in webkit [32765] by
-
- 2 edits in trunk/WebKit
2008-05-01 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Turn off deprecated warnings for WebNetscapePluginEventHandlerCarbon.mm.
- WebKit.xcodeproj/project.pbxproj:
- 11:09 AM Changeset in webkit [32764] by
-
- 4 edits in trunk/LayoutTests
2008-05-01 Sam Weinig <sam@webkit.org>
Update results with -webkit-box-reflect values.
- fast/css/computed-style-expected.txt:
- fast/css/computed-style-without-renderer-expected.txt:
- svg/css/getComputedStyle-basic-expected.txt:
- 10:48 AM Changeset in webkit [32763] by
-
- 3 edits1 add in trunk
2008-05-01 Sam Weinig <sam@webkit.org>
Fix build.
- JavaScriptCore.xcodeproj/project.pbxproj:
WebCore:
2008-05-01 Sam Weinig <sam@webkit.org>
Fix build.
- ForwardingHeaders/wtf/StrHash.h: Added.
- 10:15 AM Changeset in webkit [32762] by
-
- 7 edits in trunk/WebCore
2008-05-01 Anders Carlsson <andersca@apple.com>
Reviewed by Darin.
Move management of cache groups to ApplicationCacheStorage. Also,
application caches now start out with a null group and will have their group set
when the cache has finished loading.
- loader/appcache/ApplicationCache.cpp: (WebCore::ApplicationCache::ApplicationCache): Initialize m_group to 0.
(WebCore::ApplicationCache::~ApplicationCache):
Null check the group.
(WebCore::ApplicationCache::setGroup):
New method for setting the group.
- loader/appcache/ApplicationCache.h: (WebCore::ApplicationCache::create): Remove the group argument.
- loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::~ApplicationCacheGroup): Let the storage know that the cache group has been destroyed.
(WebCore::ApplicationCacheGroup::cacheForMainRequest):
Call into the storage.
(WebCore::ApplicationCacheGroup::selectCache):
Call into the storage.
(WebCore::ApplicationCacheGroup::documentLoaderDestroyed):
When there are no document loaders associated with the cache group,
set the newest cache to 0.
(WebCore::ApplicationCacheGroup::cacheDestroyed):
Delete the group if there are no associated caches.
(WebCore::ApplicationCacheGroup::setNewestCache):
New method that will set the newest cache and associate the group with the cache.
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
Call setNewestCache instead.
- loader/appcache/ApplicationCacheStorage.cpp: (WebCore::urlHostHash): Move host hash method here.
(WebCore::ApplicationCacheStorage::findOrCreateCacheGroup):
New method that finds a cache group with a given manifest URL or creates a new one.
(WebCore::ApplicationCacheStorage::cacheGroupForURL):
New method that returns a cache group for a given URL.
(WebCore::ApplicationCacheStorage::cacheGroupDestroyed):
When the cache group has been destroyed, remove it from the hash map.
- loader/appcache/ApplicationCacheStorage.h: Add new methods.I b
- 9:50 AM Changeset in webkit [32761] by
-
- 4 edits in trunk/WebCore
2008-05-01 Dan Winship <danw@gnome.org>
Reviewed by Alp Toker.
http://bugs.webkit.org/show_bug.cgi?id=18490
Add mostly-working file: support and mostly-broken ftp: support to
the soup backend.
- platform/network/soup/ResourceHandleSoup.cpp (start): after doing basic checks, delegate to one of three submethods (startData): handles data: URLs (startHttp): handles http: and https: URLs, via libsoup (startGio, etc): handles file: and ftp: URLs, via gio. Lots of FIXMEs detailing the parts that don't fully work yet.
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h: add new member variables for gio-based loading
- 9:32 AM Changeset in webkit [32760] by
-
- 7 edits1 add in trunk/JavaScriptCore
2008-05-01 Kevin McCullough <kmccullough@apple.com>
Reviewed by Darin.
<rdar://problem/5770054> JavaScript profiler (10928)
- Fix "sample" output so that it can be imported into Instruments
- Also keep track of number of times a function is profiled.
- JavaScriptCore.xcodeproj/project.pbxproj: Add StrHash.h which needed to be pulled out of identifier.cpp so that it could be used by the profiler and identifiers.
- kjs/identifier.cpp: Ditto.
- profiler/FunctionCallProfile.cpp: (KJS::FunctionCallProfile::printDataInspectorStyle): Inspector style printing should show microseconds. (KJS::FunctionCallProfile::printDataSampleStyle): Sample style printing now counts the number of times a function is in the stack tree and does not print microseconds since that does not make sense for a sampler.
- profiler/FunctionCallProfile.h: Keep track of number of times a function is profiled. (KJS::FunctionCallProfile::numberOfCalls):
- profiler/Profiler.cpp: (KJS::functionNameCountPairComparator): Comparator for sort function in printDataSampleStyle. (KJS::Profiler::printDataSampleStyle): Print the number of times that a function is listed in the stack tree in order of most times listed.
- wtf/HashCountedSet.h: Added copyToVector since it didn't exist and is a more standard way to copy a HashSet to a Vector. I added on variant that takes a pair as the Vector's type and so the HashCountedSet simply fills in that pair with its internal pair, and another variant that takes a Vector of the type of the HashCountedSet and only fills in the Vector with the first element of the pair. (WTF::copyToVector):
- wtf/StrHash.h: Added. (WTF::):
- 8:56 AM Changeset in webkit [32759] by
-
- 8 edits in trunk
2008-05-01 Alp Toker <alp@nuanti.com>
Rubber-stamped by Anders.
GTK+ build fix for changes in r32752. Use int32, not int32_t types in
npapi.h.
Additional fix to use same signedness in npapi.h and Mac for the
interval parameter.
- 4:26 AM Changeset in webkit [32758] by
-
- 4 edits in branches/squirrelfish/JavaScriptCore
Bug 18827: SquirrelFish: Prevent getters and setters from destroying the current RegisterFile
<https://bugs.webkit.org/show_bug.cgi?id=18827>
Reviewed by Maciej
This patch makes getters and setters work. It does this by
tracking whether the RegisterFile is "safe", that is whether
the interpreter is in a state that in which it can handle
the RegisterFile being reallocated.
