Timeline



Jul 14, 2008:

11:16 PM Changeset in webkit [35178] by mitz@apple.com
  • 2 edits in trunk/WebCore
  • Tiger build fix
  • platform/mac/WidgetMac.mm: (WebCore::Widget::paint):
7:17 PM Changeset in webkit [35177] by mrowe@apple.com
  • 4 edits in trunk/JavaScriptCore

Fix ​https://bugs.webkit.org/show_bug.cgi?id=20037
Bug 20037: GCC 4.2 build broken due to strict aliasing violation.

Reviewed by Sam Weinig.

  • kjs/ustring.cpp:

(KJS::UString::Rep::computeHash): Add a version of computeHash that takes a char* and explicit length.

  • kjs/ustring.h:
  • profiler/CallIdentifier.h:

(WTF::): Use new version of computeHash that takes a char* and explicit length to avoid unsafe aliasing.

5:16 PM Changeset in webkit [35176] by mitz@apple.com
  • 5 edits in trunk

WebCore:

Reviewed by John Sullivan.

  • WebCore part of fixing <rdar://problem/6071850> Subviews not drawn correctly when using -cacheDisplayInRect:toBitmapImageRep:
  • platform/mac/WidgetMac.mm: (WebCore::Widget::paint): Changed to account for the case of drawing into a bitmap context that is not a window's backing store. In that case, -displayRectIgnoringOpacity:inContext: is used to redirect the drawing to the correct context, after setting up the right transform on it. For subframes, additional code ensures that the scroll view will not paint the background behind a transparent frame.

WebKit/mac:

Reviewed by John Sullivan.

  • WebKit part of fixing <rdar://problem/6071850> Subviews not drawn correctly when using -cacheDisplayInRect:toBitmapImageRep:
  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Changed to account for the case of being drawn into a bitmap context that is not a window's backing store. In that case, there are no valid "rects being drawn" to clip to.
  • WebView/WebHTMLView.mm: (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): Added an override of this NSView method which is used in for -cacheDisplayInRect:toBitmapImageRep:. Like two existing NSView drawing machinery overrides, it sets subviews aside before invoking the superclass implementation. On Tiger, it also updates the layout.
4:15 PM Changeset in webkit [35175] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Don't include autoversion.h in WebKitDLL.cpp.
autoversion.h changes for every build, so we don't want to include it unless necessary.

Rubber stamped by Ada Chan.

  • WebKitDLL.cpp:
3:43 PM Changeset in webkit [35174] by Chris Fleizach
  • 14 edits
    6 adds in trunk

<rdar://problem/6038106> AXChildren returned for this web area is null

The accessibility of image maps needed to be brought inline with the new AX architecture

3:31 PM Changeset in webkit [35173] by weinig@apple.com
  • 5 edits in trunk/WebCore

2008-07-14 Sam Weinig <​sam@webkit.org>

Rubber-stamped by David Hyatt.

Remove unused ExceptionCode parameter from compareDocumentPosition.

  • dom/Document.cpp: (WebCore::Document::addStyleSheetCandidateNode):
  • dom/Node.cpp: (WebCore::Node::compareDocumentPosition):
  • dom/Node.h:
  • dom/Node.idl:
3:10 PM Changeset in webkit [35172] by hyatt@apple.com
  • 13 edits
    9 adds in trunk

2008-07-14 David Hyatt <​hyatt@apple.com>

Fix for bugzilla bug 5476, link and style elements should be allowed outside the <head>.

Reviewed by Sam

Added fast/css/style-outside-head.html
Added fast/css/link-outside-head.html

  • dom/Document.cpp: (WebCore::Document::addStyleSheetCandidateNode): (WebCore::Document::removeStyleSheetCandidateNode): (WebCore::Document::recalcStyleSelector):
  • dom/Document.h:
  • dom/Node.cpp: (WebCore::Node::compareDocumentPosition):
  • dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::insertedIntoDocument): (WebCore::ProcessingInstruction::removedFromDocument): (WebCore::ProcessingInstruction::finishParsingChildren):
  • dom/ProcessingInstruction.h: (WebCore::ProcessingInstruction::setCreatedByParser):
  • dom/StyleElement.cpp: (WebCore::StyleElement::removedFromDocument):
  • dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs): (WebCore::XMLTokenizer::processingInstruction): (WebCore::):
  • html/HTMLElementFactory.cpp: (WebCore::linkConstructor):
  • html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::HTMLLinkElement): (WebCore::HTMLLinkElement::insertedIntoDocument): (WebCore::HTMLLinkElement::removedFromDocument): (WebCore::HTMLLinkElement::finishParsingChildren):
  • html/HTMLLinkElement.h: (WebCore::HTMLLinkElement::setCreatedByParser):
  • html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::insertedIntoDocument): (WebCore::HTMLStyleElement::removedFromDocument):
  • svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::insertedIntoDocument): (WebCore::SVGStyleElement::removedFromDocument):
3:08 PM Changeset in webkit [35171] by sfalken@apple.com
  • 2 edits in trunk/WebKitTools

2008-07-14 Steve Falkenburg <​sfalken@apple.com>

Build fix.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
2:48 PM Changeset in webkit [35170] by Adam Roben
  • 2 edits in trunk/WebKitTools

Attempted Windows build fix

  • DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Add CoreFoundation/OSXCompatibilityHeadersGNUCompatibility to the include path.
2:21 PM Changeset in webkit [35169] by weinig@apple.com
  • 2 edits in trunk/WebCore

2008-07-14 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Sort interface extended attributes to appease *the* Mark Rowe.

  • page/DOMWindow.idl:
2:16 PM Changeset in webkit [35168] by andersca@apple.com
  • 4 edits
    2 adds in trunk

WebCore:

2008-07-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/6073974>
​https://bugs.webkit.org/show_bug.cgi?id=18106
The "onscroll" event bubbles, which is inconsistent with Firefox and IE

Don't bubble the scroll event.


  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset):
  • rendering/RenderListBox.cpp: (WebCore::RenderListBox::valueChanged):

LayoutTests:

2008-07-14 Anders Carlsson <​andersca@apple.com>

Reviewed by Geoff.

<rdar://problem/6073974>
​https://bugs.webkit.org/show_bug.cgi?id=18106
The "onscroll" event bubbles, which is inconsistent with Firefox and IE


Add test.


  • fast/events/scroll-event-does-not-bubble-expected.txt: Added.
  • fast/events/scroll-event-does-not-bubble.html: Added.
1:58 PM Changeset in webkit [35167] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-07-14 Adele Peterson <​adele@apple.com>

Reviewed by Geoff.

Fix for <rdar://problem/5784890> REGRESSION (Safari 3): Can't edit SpeedStream 4100 DSL modem settings

The web server on this particular piece of hardware doesn't handle "text/xml" in the
Accept header if the headers are sent in a certain order. Safari 2 used to send "*/*" in
the Accept header. Firefox 2 sent "text/xml" but in an acceptable order for the web
server. And Firefox 3 doesn't send "text/xml" at all in the Accept header since it
is being deprecated in favor of "application/xml". We decided that the best solution is
to match Firefox 3 and stop sending "text/xml" in the Accept header.

No test. There appears to be no way to get the raw headers in the original order in perl/php.

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):
1:56 PM Changeset in webkit [35166] by weinig@apple.com
  • 5 edits
    3 adds in trunk

WebCore:

2008-07-14 Sam Weinig <​sam@webkit.org>

Reviewed by Adele Peterson.

Fix for <rdar://problem/5769819>

Test: http/tests/security/cross-frame-access-object-prototype.html

  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getPropertyAttributes): Perform security check. (WebCore::JSDOMWindow::defineGetter): Ditto. (WebCore::JSDOMWindow::defineSetter): Ditto. (WebCore::JSDOMWindow::lookupGetter): Ditto. (WebCore::JSDOMWindow::lookupSetter): Ditto.
  • bindings/scripts/CodeGeneratorJS.pm: Add support for custom versions of all the core JSObject functionality.
  • page/DOMWindow.idl: Override remaining core JSObject functionality, to inject security checks.

LayoutTests:

2008-07-14 Sam Weinig <​sam@webkit.org>

Reviewed by Adele Peterson.

Test for <rdar://problem/5769819>

  • http/tests/security/cross-frame-access-object-prototype-expected.txt: Added.
  • http/tests/security/cross-frame-access-object-prototype.html: Added.
  • http/tests/security/resources/cross-frame-iframe-for-object-prototype-test.html: Added.
1:37 PM Changeset in webkit [35165] by hyatt@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-14 David Hyatt <​hyatt@apple.com>

Fix a crashing bug in ListHashSet's -- operator. Make sure that end() can be -- by special-casing the null
position.

Reviewed by Maciej

  • wtf/ListHashSet.h: (WTF::ListHashSetConstIterator::operator--):
1:04 PM Changeset in webkit [35164] by hyatt@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-14 David Hyatt <​hyatt@apple.com>

Buidl fix. Make sure the second insertBefore method returns a value.

  • wtf/ListHashSet.h: (WTF::::insertBefore):
12:21 PM Changeset in webkit [35163] by Adam Roben
  • 9 edits in trunk

Windows build fixes

JavaScriptCore:

Windows build fix

  • JavaScriptCore.vcproj/jsc/jsc.vcproj: Added include/pthreads to the include path.

WebCore:

Windows build fixes

  • WebCore.vcproj/WebCore.vcproj: Add include/pthreads to the include path.
  • bindings/scripts/CodeGeneratorCOM.pm: Touched this to force COM bindings to regenerate.
  • loader/FTPDirectoryDocument.cpp:
  • loader/FTPDirectoryParser.cpp: Fixed some duplicate macro definitions now that we're including pthread.h again.

WebKit/win:

Windows build fix

  • WebJavaScriptCollector.cpp: (WebJavaScriptCollector::objectCount): Updated to match -[WebCoreStatistics javaScriptsObjectCount].
11:23 AM Changeset in webkit [35162] by ap@webkit.org
  • 8 edits in trunk

Reviewed by Kevin McCullough.

Make JSGlobalData refcounted in preparation to adding a way to create contexts that share
global data.

  • JavaScriptCore.exp:
  • kjs/JSGlobalData.cpp: (KJS::JSGlobalData::create):
  • kjs/JSGlobalData.h: Made contructor private, and added a static create() method. Made the class inherit from RefCounted.
  • kjs/JSGlobalObject.h: (KJS::JSGlobalObject::globalData): JSGlobalData is now owned by JSGlobalObject (except for the shared one, and the common WebCore one, which are never deleted).
  • kjs/Shell.cpp: (main): Create JSGlobalData with create() method.

WebCore:

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::commonJSGlobalData): Create JSGlobalData with create() method.
7:13 AM Changeset in webkit [35161] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-07-14 Simon Hausmann <Simon Hausmann>

Reviewed by Holger.

Make listDirectory() in the Qt port work with empty namefilters.
Don't include . and .. to avoid scanning the parent directory.

5:12 AM Changeset in webkit [35160] by Simon Hausmann
  • 3 edits in trunk/JavaScriptCore

2008-07-14 Simon Hausmann <Simon Hausmann>

Fix the single-threaded build.

4:28 AM Changeset in webkit [35159] by ap@webkit.org
  • 40 edits
    2 adds in trunk

Reviewed by Geoff Garen.

Eliminate per-thread JavaScript global data instance support and make arbitrary
global data/global object combinations possible.

3:20 AM Changeset in webkit [35158] by Simon Hausmann
  • 4 edits in trunk/WebCore

2008-07-14 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

MinGW build fixes

  • plugins/win/PluginDatabaseWin.cpp:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent):
  • svg/SynchronizableTypeWrapper.h: (WebCore::::SynchronizableTypeWrapper):

Jul 13, 2008:

10:23 PM Changeset in webkit [35157] by weinig@apple.com
  • 2 edits
    1 add in trunk/WebCore

2008-07-13 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt and Dan Bernstein.

Fix for <rdar://problem/5888127>
​https://bugs.webkit.org/show_bug.cgi?id=18699

  • Match Firefox in restricting the size of custom cursor to images to 128x128 px.
  • Restrict custom cursor hotspots to values within the bounds of the cursor image.
  • manual-tests/cursor-max-size.html: Added.
  • page/EventHandler.cpp: (WebCore::EventHandler::selectCursor):
7:46 PM Changeset in webkit [35156] by adachan@apple.com
  • 2 edits in trunk/JavaScriptCore

Windows build fix: Add wtf/RefCountedLeakCounter to the project.

3:50 PM Changeset in webkit [35155] by kevino@webkit.org
  • 2 edits in trunk/WebCore

wx build fix.

Jul 12, 2008:

6:18 PM Changeset in webkit [35154] by mitz@apple.com
  • 2 edits in trunk

Remove conflict markers.

4:42 PM Changeset in webkit [35153] by weinig@apple.com
  • 1 edit
    2 moves in trunk/LayoutTests

2008-07-12 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Oliver Hunt.

Update version of Selectors API test from ​http://ejohn.org/apps/selectortest/
and fix the spelling of the authors name.

  • fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt: Copied from fast/dom/SelectorAPI/ressig-SelectorsAPI-test-expected.txt.
  • fast/dom/SelectorAPI/resig-SelectorsAPI-test.xhtml: Copied from fast/dom/SelectorAPI/ressig-SelectorsAPI-test.xhtml.
  • fast/dom/SelectorAPI/ressig-SelectorsAPI-test-expected.txt: Removed.
  • fast/dom/SelectorAPI/ressig-SelectorsAPI-test.xhtml: Removed.
4:32 PM Changeset in webkit [35152] by mitz@apple.com
  • 3 edits
    4 adds in trunk

WebCore:

Reviewed by Oliver Hunt.

Test: fast/block/basic/min-pref-width-nowrap-floats.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::calcInlinePrefWidths): Fixed a case where a float's width was added to the minimum preferred widths instead of just acting as a lower bound on the minimum preferred width (since the float can always be pushed down to be the only thing on the line).

LayoutTests:

Reviewed by Oliver Hunt.

  • fast/block/basic/min-pref-width-nowrap-floats.html: Added.
  • platform/mac/fast/block/basic/min-pref-width-nowrap-floats-expected.checksum: Added.
  • platform/mac/fast/block/basic/min-pref-width-nowrap-floats-expected.png: Added.
  • platform/mac/fast/block/basic/min-pref-width-nowrap-floats-expected.txt: Added.
2:33 PM Changeset in webkit [35151] by ddkilzer@apple.com
  • 3 edits
    2 adds in trunk/WebCore

Bug 13067: Manually adding #hash to URL reloads entire page instead of jumping to #hash location in cached page

<​https://bugs.webkit.org/show_bug.cgi?id=13067>

Reviewed by Darin.

Test: WebCore/manual-tests/hash-ref.html

  • loader/FrameLoader.cpp: (WebCore::FrameLoader::load(const KURL& newURL, const String& referrer,

FrameLoadType newLoadType, const String& frameName, Event* event,
PassRefPtr<FormState> formState)): Extracted logic into

shouldScrollToAnchor() for determining when to scroll to an anchor.

(WebCore::FrameLoader::load(DocumentLoader* loader, FrameLoadType type,

PassRefPtr<FormState> formState)): Added check for

shouldScrollToAnchor() to catch cases when the user manually added a
hash ref to the URL in the address bar. This is the bug fix.

(WebCore::FrameLoader::shouldReload): Simplified early return logic.
We only need to check if the destinationURL has a hash ref, not the
currentURL, per the comment in the method.

(WebCore::FrameLoader::shouldScrollToAnchor): Added. Logic extracted
from the FrameLoader::load(const KURL& newURL, ...) method. Fixed order
of arguments to shouldReload() since they were backwards, although the
previous logic in the method made this irrelevant.

(WebCore::FrameLoader::loadItem): Removed call to shouldReload(). Since
we're navigating to a HistoryItem, it doesn't make sense to ask whether
we need to reload the page or not. Additionally, the logic at the end
of shouldReload() is also checked in urlsMatchItem(), so there's no need
to call the method. This fixed the fast/css/target-fragment-match.html
test from continuously reloading after the other changes.

  • loader/FrameLoader.h: (WebCore::FrameLoader::shouldScrollToAnchor): Added.
  • manual-tests/hash-ref.html: Added.
  • manual-tests/resources/hash-ref-test.html: Added.
1:09 AM Changeset in webkit [35150] by jmalonzo@webkit.org
  • 4 edits in trunk/JavaScriptCore

2008-07-12 Jan Michael Alonzo <​jmalonzo@webkit.org>

Gtk, Qt and Wx build fix: Add wtf/RefCountedLeakCounter in the
build scripts

12:49 AM Changeset in webkit [35149] by hyatt@apple.com
  • 1 edit in trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt

Update layout test results for new compareDocumentPosition method

Jul 11, 2008:

10:51 PM Changeset in webkit [35148] by Stephanie Lewis
  • 22 edits
    1 move
    4 adds in trunk

2008-07-11 Stephanie Lewis <Stephanie Lewis>

Reviewed by Darin Adler and Oliver Hunt.

JavaScriptCore:

Refactor RefCounting Leak counting code into a common class.

In order to export the symbols I needed to put the debug defines inside the function names


Before we had a separate channel for each Logging each Leak type. Since the leak channels were only used in one location, and only at quit for simplicity I combined them all into one leak channel.

  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj: add new class
  • kjs/nodes.cpp: remove old leak counting code
  • wtf/RefCountedLeakCounter.cpp: Added. create a common leak counting class
  • wtf/RefCountedLeakCounter.h: Added.

WebCore:

No Functionality Changed. Change all the leak counting code to use the new WTF leak counter class.

  • bindings/js/JSCustomSQLTransactionCallback.cpp: (WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback): (WebCore::JSCustomSQLTransactionCallback::~JSCustomSQLTransactionCallback):
  • bindings/js/JSEventListener.cpp: (WebCore::JSEventListener::JSEventListener): (WebCore::JSEventListener::~JSEventListener):
  • dom/Node.cpp: (WebCore::Node::Node): (WebCore::Node::~Node):
  • dom/Range.cpp: (WebCore::Range::Range): (WebCore::Range::~Range):
  • history/CachedPage.cpp: (WebCore::CachedPage::CachedPage): (WebCore::CachedPage::~CachedPage):
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::SubresourceLoader): (WebCore::SubresourceLoader::~SubresourceLoader):
  • page/Frame.cpp: (WebCore::Frame::Frame): (WebCore::Frame::~Frame):
  • page/Page.cpp: (WebCore::Page::Page): (WebCore::Page::~Page):
  • rendering/RenderObject.cpp: (WebCore::RenderObject::RenderObject): (WebCore::RenderObject::~RenderObject):
  • rendering/bidi.cpp: (WebCore::throw): (WebCore::BidiRun::operator delete):

WebKit

Move WebPreferences.m to objc++ so it can include the new WTF leak counting class.

  • WebKit.xcodeproj/project.pbxproj:

Disable WTF leak messages when using fast teardown. Use full document teardown while running in debug.

  • WebView/WebPreferences.m: Removed.
  • WebView/WebPreferences.mm: Copied from http:/svn.webkit.org/repository/webkit/trunk/WebKit/mac/WebView/WebPreferences.m. (+[WebPreferences initialize]): if running in Default enable full document teardown (-[WebPreferences editableLinkBehavior]): (-[WebPreferences setFullDocumentTeardownEnabled:]):
  • WebView/WebView.mm: (-[WebView _close]): disable leak messages if using fast teardown

WebKitTools:

Make sure we read WebCore Leak messages. Force full document teardown for DumpRenderTree.

Up timeout limit, some slower machines were timing out before crashtracer finished writing out to disk and quitting DRT.

  • DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting): (resetWebViewToConsistentStateBeforeTesting):
  • Scripts/run-webkit-tests:
7:52 PM Changeset in webkit [35147] by hyatt@apple.com
  • 1 edit in trunk/WebCore/dom/Node.h

Clean up some funny whitespace from my previous Node.h checkin

7:50 PM Changeset in webkit [35146] by weinig@apple.com
  • 7 edits
    3 adds in trunk

WebCore:

2008-07-11 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Update getSubStringLength and selectSubString methods exception throwing conditions
based on SVG working group errata.

Test: svg/custom/selectSubString.html

  • svg/SVGTextContentElement.cpp: (WebCore::SVGTextContentElement::getSubStringLength): (WebCore::SVGTextContentElement::selectSubString):

LayoutTests:

2008-07-11 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Update getSubStringLength and selectSubString methods exception throwing conditions
based on SVG working group errata.

  • svg/custom/acid3-test-77-expected.txt:
  • svg/custom/acid3-test-77.html:
  • svg/custom/getSubStringLength-expected.txt:
  • svg/custom/resources/getSubStringLength.js:
  • svg/custom/resources/selectSubString.js: Added.
  • svg/custom/selectSubString-expected.txt: Added.
  • svg/custom/selectSubString.html: Added.
7:28 PM Changeset in webkit [35145] by weinig@apple.com
  • 5 edits
    3 adds in trunk

WebCore:

2008-07-11 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

We can only use the Id fast path for querySelector and querySelectorAll
if the selector is purely an Id selector.

Test: fast/dom/SelectorAPI/id-fastpath.html

  • dom/Node.cpp: (WebCore::Node::querySelector):
  • dom/SelectorNodeList.cpp: (WebCore::createSelectorNodeList):

LayoutTests:

2008-07-11 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

We can only use the Id fast path for querySelector and querySelectorAll
if the selector is purely an Id selector.

  • fast/dom/SelectorAPI/id-fastpath-expected.txt: Added.
  • fast/dom/SelectorAPI/id-fastpath.html: Added.
  • fast/dom/SelectorAPI/resources/id-fastpath.js: Added.
  • fast/dom/SelectorAPI/ressig-SelectorsAPI-test-expected.txt:
7:24 PM Changeset in webkit [35144] by hyatt@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-11 David Hyatt <​hyatt@apple.com>

Add an insertBefore method to ListHashSet to allow for insertions in the middle of the list (rather than just
at the end).

Reviewed by Anders

  • wtf/ListHashSet.h: (WTF::::insertBefore): (WTF::::insertNodeBefore):
7:13 PM Changeset in webkit [35143] by hyatt@apple.com
  • 35 edits in trunk

2008-07-11 David Hyatt <​hyatt@apple.com>

Implement the DOM level 3 compareDocumentPosition method on Node.

Reviewed by Darin

  • dom/Node.cpp: (WebCore::Node::compareDocumentPosition):
  • dom/Node.h:
  • dom/Node.idl:
5:29 PM Changeset in webkit [35142] by weinig@apple.com
  • 8 edits
    2 copies in trunk/JavaScriptCore

2008-07-11 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Darin Adler.

Move call function to CallData.cpp and construct to ConstructData.cpp.

  • GNUmakefile.am:
  • JavaScriptCore.pri:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • JavaScriptCoreSources.bkl:
  • kjs/AllInOneFile.cpp:
  • kjs/CallData.cpp: Copied from kjs/JSValue.cpp.
  • kjs/ConstructData.cpp: Copied from kjs/JSValue.cpp.
  • kjs/JSValue.cpp:
3:51 PM Changeset in webkit [35141] by beidson@apple.com
  • 2 edits in trunk/WebCore

2008-07-11 Brady Eidson <​beidson@apple.com>

Rubberstamped by Sam

Removed unneeded export

  • WebCore.base.exp:
3:42 PM Changeset in webkit [35140] by kmccullough@apple.com
  • 2 edits in trunk/WebCore

2008-07-11 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Geoff.

<rdar://problem/6067178> REGRESSION: Start profile button in profiler
now profiles inspector rather than actual page (19833)

  • The JSQuarantinedObjectWrapper should use the wrapped exec state so that calls to it execute in its quarantined world.
  • bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::construct): (WebCore::JSQuarantinedObjectWrapper::call):
3:40 PM Changeset in webkit [35139] by dino@apple.com
  • 2 edits in trunk/WebCore

2008-07-11 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

StyleRareNonInheritedData needs to initialize and compare
m_maskBoxImage.
<​https://bugs.webkit.org/show_bug.cgi?id=20005>

  • rendering/style/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==):
3:34 PM Changeset in webkit [35138] by dino@apple.com
  • 3 edits
    2 adds in trunk

2008-07-11 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt

Bug 18885: RenderLayer::enclosingPositionedAncestor() should
look for transforms, since transforms create containing
blocks.
<​https://bugs.webkit.org/show_bug.cgi?id=18885>

Test: fast/transforms/transform-positioned-ancestor.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::stackingContext): (WebCore::RenderLayer::enclosingPositionedAncestor): (WebCore::RenderLayer::enclosingTransformedAncestor):
3:30 PM Changeset in webkit [35137] by jmalonzo@webkit.org
  • 3 edits in trunk/WebCore

2008-07-11 Jacob Refstrup <​jacob.refstrup@hp.com>

Reviewed by Darin Adler

​http://bugs.webkit.org/show_bug.cgi?id=19978
GTK port always ends up with # at the end of resource URLs (and hence can't load files)

  • Optimized KURL::removeRef() and used it rather than setRef("") which after r35040 does the wrong thing.
  • platform/KURL.cpp: (WebCore::KURL::removeRef):
  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::initializeHandle):
3:07 PM Changeset in webkit [35136] by jmalonzo@webkit.org
  • 7 edits in trunk/WebKit/gtk

2008-07-08 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Christian Dywan.

Replace 'const' with G_CONST_RETURN macro to make it flexible to
disable constness

  • webkit/webkitnetworkrequest.cpp:
  • webkit/webkitnetworkrequest.h:
  • webkit/webkitwebframe.cpp:
  • webkit/webkitwebframe.h:
  • webkit/webkitwebhistoryitem.cpp:
  • webkit/webkitwebhistoryitem.h:
2:46 PM Changeset in webkit [35135] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

Reviewed by Anders.

Skip the printing tests since they fail between machines.
​https://bugs.webkit.org/show_bug.cgi?id=20011

  • platform/mac/Skipped:
2:19 PM Changeset in webkit [35134] by weinig@apple.com
  • 1 edit
    2 adds in trunk/LayoutTests

2008-07-11 Sam Weinig <​sam@webkit.org>

Rubber-stamped by Oliver Hunt.

Import Selectors API test from ​http://ejohn.org/apps/selectortest/.

  • fast/dom/SelectorAPI/ressig-SelectorsAPI-test-expected.txt: Added.
  • fast/dom/SelectorAPI/ressig-SelectorsAPI-test.xhtml: Added.
2:17 PM Changeset in webkit [35133] by eric@webkit.org
  • 2 edits in trunk/LayoutTests

Reviewed by cpst.

Update results to match the buildbot (even though this now fails on my machine)
I think the failure for me is possibly leopard vs. tiger or git vs. svn.

  • webarchive/test-xml-stylesheet-expected.webarchive:
11:51 AM Changeset in webkit [35132] by sfalken@apple.com
  • 2 edits in tags/Safari-6527.1.2/WebKit/win

Merged r35130.

11:37 AM Changeset in webkit [35131] by sfalken@apple.com
  • 1 copy in tags/Safari-6527.1.2

New tag.

11:35 AM Changeset in webkit [35130] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Build fix.

10:02 AM Changeset in webkit [35129] by Simon Hausmann
  • 2 edits in trunk/WebCore

008-07-11 Simon Hausmann <Simon Hausmann>

Fix the Qt/Windows build, include windows.h for HWND directly
instead of implicit inclusion through Timer.h.

9:54 AM Changeset in webkit [35128] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Darin Adler.

  • fix popularity tracking for cached resources, which regressed in r23923
  • loader/Cache.cpp: (WebCore::Cache::requestResource): Changed to increase the access count whenever this function returns a CachedResource and the cache is enabled, instead of only when creating a new CachedResources. The incorrect behavior resulted in all resources in the cache having an access count of exactly 1 at all times. (WebCore::Cache::requestUserCSSStyleSheet): Ditto.
8:43 AM Changeset in webkit [35127] by Simon Hausmann
  • 11 edits in trunk/WebCore

2008-07-11 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

Enable Netscape plugins for the Qt/Windows build.

This required various smaller fixes across a wider set of
files described below.

5:08 AM Changeset in webkit [35126] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-07-11 Simon Hausmann <Simon Hausmann>

Rubber-stamped by Holger.

Enable Database and Icondatabase functionality for the Qt/Windows
build when building inside Qt, as we can use the builtin copy of
sqlite then.

4:51 AM Changeset in webkit [35125] by dino@apple.com
  • 5 edits in trunk/LayoutTests

Updated test results for
​https://bugs.webkit.org/show_bug.cgi?id=19864

  • css3/transform-computed-style-001-expected.txt:
  • fast/css/computed-style-expected.txt:
  • fast/css/computed-style-without-renderer-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
4:28 AM Changeset in webkit [35124] by Simon Hausmann
  • 3 edits in trunk/WebCore

2008-07-11 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Adam Roben.

Fix compile with MinGW since it does not like friend static function.

  • plugins/PluginView.h:
  • plugins/win/PluginViewWin.cpp:
3:33 AM Changeset in webkit [35123] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-07-11 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

Fix Qt/Win32 build.

  • platform/graphics/qt/GraphicsContextQt.cpp:
12:34 AM Changeset in webkit [35122] by weinig@apple.com
  • 21 edits
    9 adds
    2 deletes in trunk

WebCore:

2008-07-10 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Add support for NSResolver to resolve namespaces for querySelector
and querySelectorAll.

  • Namespace resolution is done after parsing by iterating over all the parts of the CSSSelector.

Tests: fast/dom/SelectorAPI/NSResolver-basic.xhtml

fast/dom/SelectorAPI/NSResolver-exceptions.xhtml

  • GNUmakefile.am: Updated with new files.
  • WebCore.pro: Ditto.
  • WebCore.vcproj/WebCore.vcproj: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • WebCoreSources.bkl: Ditto.
  • bindings/js/JSDOMBinding.cpp: (WebCore::execStateFromNode):
  • bindings/js/JSDOMBinding.h: Move execStateFromNode here from NodeFilter.
  • bindings/js/JSDocumentCustom.cpp: (WebCore::JSDocument::querySelector): Don't throw a NOT_SUPPORTED_ERR for NSResolver and instead create one if the argument is not undefined or null. (WebCore::JSDocument::querySelectorAll): Ditto.
  • bindings/js/JSDocumentFragmentCustom.cpp: (WebCore::JSDocumentFragment::querySelector): Ditto. (WebCore::JSDocumentFragment::querySelectorAll): Ditto.
  • bindings/js/JSElementCustom.cpp: (WebCore::JSElement::querySelector): Ditto. (WebCore::JSElement::querySelectorAll): Ditto.
  • bindings/js/JSNSResolver.cpp: Added. (WebCore::JSNSResolver::JSNSResolver): (WebCore::JSNSResolver::mark): (WebCore::JSNSResolver::lookupNamespaceURI): Try and get the function from the passed in argument, either the value itself, or the result of getting the lookupNamespaceURI property, and call it. (WebCore::toNSResolver):
  • bindings/js/JSNSResolver.h: Added. (WebCore::JSNSResolver::create):
  • dom/Document.idl: Update with NSResolver parameter.
  • dom/DocumentFragment.idl: Ditto.
  • dom/Element.idl: Ditto.
  • dom/NSResolver.h: Added. (WebCore::NSResolver::~NSResolver): (WebCore::NSResolver::mark): Abstract base class.
  • dom/NSResolver.idl: Added.
  • dom/Node.cpp: (WebCore::forEachTagSelector): (WebCore::forEachSelector): Functions to iterate over all parts of the selector.

(WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
Functor to be passed to forEachSelector to determine if a selector
needs namespace resolution, for the case when no NSResolver is passed
and we need to determine whether to throw a NAMESPACE_ERR.

(WebCore::ResolveNamespaceFunctor::ResolveNamespaceFunctor):
(WebCore::ResolveNamespaceFunctor::operator()):
Functor to resolve namespaces for the selector.

(WebCore::selectorNeedsNamespaceResolution):
(WebCore::resolveNamespacesForSelector):
(WebCore::Node::querySelector): Resolve namepspaces, including the defaultNamespace
if a NSResolver is passed in.
(WebCore::Node::querySelectorAll): Ditto.

  • dom/Node.h:
  • dom/NodeFilter.cpp:
  • dom/NodeFilter.h:
  • dom/NodeIterator.h: (WebCore::NodeIterator::nextNode): (WebCore::NodeIterator::previousNode):
  • dom/TreeWalker.h: (WebCore::TreeWalker::parentNode): (WebCore::TreeWalker::firstChild): (WebCore::TreeWalker::lastChild): (WebCore::TreeWalker::previousSibling): (WebCore::TreeWalker::nextSibling): (WebCore::TreeWalker::previousNode): (WebCore::TreeWalker::nextNode): Use the version of execStateFromNode in JSDOMBinding.

LayoutTests:

2008-07-10 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Add support for NSResolver to resolve namespaces for querySelector
and querySelectorAll.

  • fast/dom/SelectorAPI/NSResolver-basic-expected.txt: Added.
  • fast/dom/SelectorAPI/NSResolver-basic.xhtml: Added.
  • fast/dom/SelectorAPI/NSResolver-exceptions-expected.txt: Added.
  • fast/dom/SelectorAPI/NSResolver-exceptions.xhtml: Added.
  • fast/dom/SelectorAPI/not-supported-NSResolver-expected.txt: Removed.
  • fast/dom/SelectorAPI/not-supported-NSResolver.html: Removed.
  • fast/dom/SelectorAPI/resources/NSResolver-exceptions.js: Added.

Jul 10, 2008:

11:10 PM Changeset in webkit [35121] by mrowe@apple.com
  • 8 edits in trunk

Define WEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST when building WebKit to ensure that no symbols end up with the weak_import attribute.

Reviewed by Sam Weinig.

11:10 PM Changeset in webkit [35120] by mrowe@apple.com
  • 6 edits in trunk

Fix the Tiger build by omitting annotations from methods declared in categories when using old versions of GCC.

Reviewed by Sam Weinig.

10:15 PM Changeset in webkit [35119] by mrowe@apple.com
  • 2 edits in tags/Safari-6527.1.1/WebKit/win

Build fix.

10:02 PM Changeset in webkit [35118] by sfalken@apple.com
  • 2 edits in trunk/WebKit/win

Build fix.

9:54 PM Changeset in webkit [35117] by dino@apple.com
  • 3 edits
    3 adds in trunk

Reviewed by hyatt.

Calculate computed style for -webkit-transform property
​https://bugs.webkit.org/show_bug.cgi?id=19864

Test: css3/transform-computed-style-001.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::computedTransform):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

handles -webkit-transform property now

  • manual-tests/computed-transform-value.html: Added.
6:05 PM Changeset in webkit [35116] by mrowe@apple.com
  • 4 edits in tags/Safari-6527.1.1

Versioning.

6:05 PM Changeset in webkit [35115] by mrowe@apple.com
  • 2 edits in tags/Safari-6527.1.1/WebCore

Merge r35112.

6:03 PM Changeset in webkit [35114] by mrowe@apple.com
  • 1 copy in tags/Safari-6527.1.1

New tag.

5:46 PM Changeset in webkit [35113] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Adam Roben.

  • fix a parse error in inspector.js
  • page/inspector/inspector.js: Added missing brace.
5:43 PM Changeset in webkit [35112] by Adam Roben
  • 2 edits in trunk/WebCore

Build fix

  • WebCore.vcproj/QTMovieWin.vcproj: Add OSXCompatibilityHeadersGNUCompatibility to the include path.
5:28 PM Changeset in webkit [35111] by Chris Fleizach
  • 4 edits in trunk/WebCore

<rdar://problem/6067408> AX: internal anchors broken

Fixes a broken accessibility test

5:01 PM Changeset in webkit [35110] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Build fix.

4:47 PM Changeset in webkit [35109] by weinig@apple.com
  • 3 edits in trunk/WebCore

2008-07-10 Sam Weinig <​sam@webkit.org>

Reviewed by Mark Rowe.

Remove no-op debug method.

  • css/CSSSelector.cpp:
  • css/CSSSelector.h:
4:21 PM Changeset in webkit [35108] by weinig@apple.com
  • 15 edits
    4 adds in trunk

WebCore:

2008-07-10 Sam Weinig <​sam@webkit.org>

Reviewed by Dave Hyatt and Darin Adler.

Add support for calling querySelector and querySelectorAll on DocumentFragments

  • Fixes bug where nodes not in the document tree would not match based on ID due to over optimization.

Test: fast/dom/SelectorAPI/detached-element.html

  • GNUmakefile.am:
  • WebCore.pro:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • WebCoreSources.bkl:
  • bindings/js/JSDocumentFragmentCustom.cpp: Added. (WebCore::JSDocumentFragment::querySelector): Add custom code matching JSElement and JSDocument that checks for a 2nd arguments and throws an exception indicating we do not currently support the optional NSResolver part of the Selectors API spec. (WebCore::JSDocumentFragment::querySelectorAll): Ditto.
  • dom/DocumentFragment.idl: Add querySelector and querySelectorAll declarations.
  • dom/Node.cpp: (WebCore::Node::querySelector): Make the CSS parser parse the selector according to the strictness of the document so that mixed case ID selectors match in quirks mode. Also, don't use the fast ID path if the root is not in the DOM tree, as it won't work. (WebCore::Node::querySelectorAll): Ditto.
  • dom/SelectorNodeList.cpp: (WebCore::createSelectorNodeList): Don't use the fast ID path if the root is not in the DOM tree, as it won't work.

LayoutTests:

2008-07-10 Sam Weinig <​sam@webkit.org>

Reviewed by Dave Hyatt and Darin Adler,

Add support for calling querySelector and querySelectorAll on DocumentFragments

  • Add test for nodes not in the document tree.
  • fast/dom/SelectorAPI/detached-element-expected.txt: Added.
  • fast/dom/SelectorAPI/detached-element.html: Added.
  • fast/dom/SelectorAPI/dumpNodeList-expected.txt:
  • fast/dom/SelectorAPI/dumpNodeList.html:
  • fast/dom/SelectorAPI/not-supported-NSResolver-expected.txt:
  • fast/dom/SelectorAPI/not-supported-NSResolver.html:
  • fast/dom/SelectorAPI/resources/detached-element.js: Added.
  • fast/dom/Window/window-properties-expected.txt:
4:06 PM Changeset in webkit [35107] by pewtermoose@webkit.org
  • 2 edits in trunk/WebCore

2008-07-10 Anthony Ricaud <​rik24d@gmail.com>

Bug 19389: querySelectorAll exception while searching invalid CSS selector
<​https://bugs.webkit.org/show_bug.cgi?id=19389>

Reviewed by Tim Hatcher.

  • page/inspector/inspector.js: Added a try/catch block.
4:02 PM Changeset in webkit [35106] by pewtermoose@webkit.org
  • 2 edits in trunk/WebCore

2008-07-10 Brent Fulgham <​bfulgham@gmail.com>

Correct a build regression due to an uninitialized variable.

<​https://bugs.webkit.org/show_bug.cgi?id=19976>

Reviewed by Darin.

  • platform/graphics/cairo/FontCairo.cpp: (WebCore::Font::drawGlyphs):
3:59 PM Changeset in webkit [35105] by Adam Roben
  • 3 edits in trunk/WebCore

Fix Bug 19580: REGRESSION (r34432): PGO-only crash in HTMLCollection::resetCollectionInfo (codegen issue?)

<​https://bugs.webkit.org/show_bug.cgi?id=19580>
<rdar://6029794>

Reviewed by Cameron Zwarich.

  • WebCore.vcproj/WebCore.vcproj: Disable LTCG for HTMLFormElement.cpp, which was causing some bad codegen in HTMLFormElement::elements.
  • html/HTMLFormElement.cpp: Touched this file to force it to rebuild.
3:53 PM Changeset in webkit [35104] by andersca@apple.com
  • 3 edits in trunk/WebCore

2008-07-10 Anders Carlsson <​andersca@apple.com>

Reviewed by Jon.

<rdar://problem/6067135>
WebKit should respond true to a query for NPNVSupportsWindowless.


Handle NPNVSupportsWindowless and return true.


  • bridge/npapi.h:
  • plugins/win/PluginViewWin.cpp: (WebCore::PluginView::getValue):
3:38 PM Changeset in webkit [35103] by sfalken@apple.com
  • 2 edits in trunk/WebKitTools

Build fix.

  • DumpRenderTree/win/DumpRenderTree.vcproj:
2:56 PM Memory Use edited by ggaren@apple.com
(diff)
1:50 PM Changeset in webkit [35102] by kmccullough@apple.com
  • 6 edits in trunk

JavaScriptCore:

2008-07-10 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Darin.

-Minor cleanup. Renamed callTree() to head() and no longer use m_head
directly but instead keep it private and access via a method().

  • profiler/HeavyProfile.cpp: (KJS::HeavyProfile::HeavyProfile): (KJS::HeavyProfile::generateHeavyStructure): (KJS::HeavyProfile::addNode):
  • profiler/Profile.h: (KJS::Profile::head):
  • profiler/ProfileGenerator.cpp: (KJS::ProfileGenerator::ProfileGenerator):

WebCore:

2008-07-10 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Darin.

-Minor cleanup. Renamed callTree() to head() and no longer use m_head
directly but instead keep it private and access via a method().

  • page/JavaScriptProfile.cpp: (WebCore::getHeadCallback):
1:38 PM Memory Use edited by ggaren@apple.com
(diff)
1:35 PM Memory Use edited by ggaren@apple.com
(diff)
12:31 PM Changeset in webkit [35101] by dino@apple.com
  • 5 edits
    1 add in trunk/WebCore

When a mask image changes, ensure that elements
that use that mask image are repainted correctly.

<​https://bugs.webkit.org/show_bug.cgi?id=19954>

Reviewed by Dave Hyatt

  • manual-tests/canvas-mask-redraw.html Manual testcase
  • rendering/RenderBox.cpp: (WebCore::RenderBox::imageChanged): (WebCore::RenderBox::repaintLayerRectsForImage):
  • rendering/RenderBox.h: Loop through background layers and mask layers, and if this image is used in a layer, compute a repaint rect and repaint.
  • rendering/RenderImage.cpp: (WebCore::RenderImage::imageChanged): If this image has a mask, call the base class method.
  • rendering/RenderObject.cpp: Remove a bogus 'return'.
12:05 PM Changeset in webkit [35100] by dino@apple.com
  • 3 edits
    2 adds in trunk

Transforms create a containing block, so
RenderLayer::shouldBeOverflowOnly() needs to look for transforms.
<​https://bugs.webkit.org/show_bug.cgi?id=18886>

Reviewed by Dave Hyatt

Test: fast/transforms/transform-overflow.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::shouldBeOverflowOnly):

11:08 AM Changeset in webkit [35099] by Adam Roben
  • 2 edits in trunk/WebKit/win

Windows build fix

  • WebKit.vcproj/resource.h: Revert some changes that VS made to this file in r35083.
10:59 AM Changeset in webkit [35098] by andersca@apple.com
  • 3 edits in trunk/WebKit/mac

2008-07-10 Anders Carlsson <​andersca@apple.com>

Reviewed by Mark.


Add availability macros for the new WebPlugin methods.

  • Plugins/WebPlugin.h:
  • Plugins/WebPluginViewFactory.h:
10:55 AM Changeset in webkit [35097] by ap@webkit.org
  • 7 edits
    2 deletes in trunk/JavaScriptCore

Reviewed by Mark Rowe.

Eliminate CollectorHeapIntrospector.

CollectorHeapIntrospector was added primarily in the hopes to improve leaks tool output,
a result that it didn't deliver. Also, it helped by labeling JSC heap regions as reported by
vmmap tool, but at the same time, it made them mislabeled as malloc'd ones - the correct
way to label mapped regions is to use a VM tag.

So, it makes more sense to remove it completely than to make it work with multiple heaps.

  • JavaScriptCore.exp:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • kjs/AllInOneFile.cpp:
  • kjs/InitializeThreading.cpp: (KJS::initializeThreading):
  • kjs/collector.cpp:
  • kjs/collector.h:
  • kjs/CollectorHeapIntrospector.cpp: Removed.
  • kjs/CollectorHeapIntrospector.h: Removed.
10:33 AM Changeset in webkit [35096] by kmccullough@apple.com
  • 4 edits in trunk/JavaScriptCore

2008-07-09 Kevin McCullough <​kmccullough@apple.com>

Reviewed by Darin.

<rdar://problem/5951532> JSProfiler: Implement heavy (or bottom-up)
view (19228)

  • Implemented the time and call count portionof heavy. Now all that we need is some UI.
  • profiler/CallIdentifier.h: Removed an unused constructor.
  • profiler/HeavyProfile.cpp: (KJS::HeavyProfile::HeavyProfile): Set the initial time of the head node so that percentages work correctly. (KJS::HeavyProfile::mergeProfiles): Sum the times and call count of nodes being merged.
  • profiler/ProfileNode.cpp: Set the intital values of time and call count when copying ProfileNodes. (KJS::ProfileNode::ProfileNode):
3:01 AM Changeset in webkit [35095] by jmalonzo@webkit.org
  • 2 edits in trunk/JavaScriptCore

2008-07-10 Jan Michael Alonzo <​jmalonzo@webkit.org>

Gtk build fix.

  • GNUmakefile.am: Add HeavyProfile.cpp
12:12 AM Changeset in webkit [35094] by oliver@apple.com
  • 60 edits
    9 deletes in trunk/WebCore

2008-07-09 Alex Mathews <​possessedpenguinbob@gmail.com>

Reviewed by Oliver Hunt.

bug 19835: WebKit needs cross-platform filter system
<​https://bugs.webkit.org/show_bug.cgi?id=19835>

More class refactoring in preparation for cross-platform filter
implementation.

Note: See TracTimeline for information about the timeline view.