Timeline
Jul 17, 2008:
- 9:00 PM Changeset in webkit [35231] by
-
- 7 edits in trunk/JavaScriptCore
2008-07-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Next step toward putting doubles in registers: Store constant pool
entries as registers, not JSValue*s.
SunSpider reports no change.
- 4:53 PM Changeset in webkit [35230] by
-
- 3 edits in trunk/JavaScriptCore
2008-07-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by John Sullivan and Oliver Hunt.
A tiny bit of tidying in function call register allocation.
This patch saves one register when invoking a function expression and/or
a new expression that is stored in a temporary.
Since it's just one register, I can't make a testcase for it.
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitCall): No need to ref the function we're calling or its base. We'd like the call frame to overlap with them, if possible. op_call will read the function and its base before writing the call frame, so this is safe.
- kjs/nodes.cpp: (KJS::NewExprNode::emitCode): No need to ref the function we're new-ing, for the same reasons stated above.
(KJS::FunctionCallValueNode::emitCode): ditto
- 3:28 PM Changeset in webkit [35229] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-17 Steve Falkenburg <sfalken@apple.com>
Build fix.
- kjs/InternalFunction.cpp:
- 2:42 PM Changeset in webkit [35228] by
-
- 5 edits3 adds in trunk
2008-07-17 Sam Weinig <sam@webkit.org>
Roll out r35199 as it is causing failures on the PPC build.
LayoutTests:
2008-07-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by David Kilzer.
Test for https://bugs.webkit.org/show_bug.cgi?id=20067
Support function.name (Firefox extension)
- fast/js/function-name-expected.txt: Added.
- fast/js/function-name.html: Added.
- fast/js/resources/function-name.js: Added.
- 2:11 PM Changeset in webkit [35227] by
-
- 6 edits in trunk/JavaScriptCore
2008-07-17 Sam Weinig <sam@webkit.org>
Roll out r35199 as it is causing failures on the PPC build.
- 1:39 PM Changeset in webkit [35226] by
-
- 3 edits3 adds in trunk
2008-07-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Fixed <rdar://problem/6081636> Functions calls use more temporary
registers than necessary
Holding a reference to the last statement result register caused each
successive statement to output its result to an even higher register.
Happily, statements don't actually need to return a result register
at all. I hope to make this clearer in a future cleanup patch,
but this change will fix the major bug for now.
- kjs/nodes.cpp: (KJS::statementListEmitCode):
LayoutTests:
2008-07-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Test for <rdar://problem/6081636> Functions calls use more temporary
registers than necessary
- fast/js/function-call-register-allocation.html: Added.
- fast/js/function-call-register-allocation-expected.txt: Added.
- fast/js/resources/function-call-register-allocation.js: Added.
- 12:49 PM Changeset in webkit [35225] by
-
- 4 edits2 adds in trunk
Reviewed by rwlbuis@gmail.com
- Added "@"{ident} rule (below other @-rules) to use flex for longest match (if an earlier rule - e.g. @media - also matches then flex chooses that one
however, if a longer match - e.g. @mediaall matches flex will choose that)
- Updated grammar to defined ATKEYWORD token and to use that instead of '@' in the error recovery grammar.
Test: css2.1/atrule_longest_match.html
- 12:24 PM Changeset in webkit [35224] by
-
- 5 edits in trunk/JavaScriptCore
2008-07-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Merge pre&post dot nodes to simplify the parse tree.
Sunspider results show 0.6% progression (no performance change expected).
- kjs/grammar.y:
- kjs/nodes.cpp:
- kjs/nodes.h:
- kjs/nodes2string.cpp:
- 11:24 AM Changeset in webkit [35223] by
-
- 2 edits in trunk/WebCore
2008-07-17 David Hyatt <hyatt@apple.com>
Make sure the check to see if a frame/iframe is being rendered inside a transparency layer is
recursive (and checks for transparency layers all the way up the ancestor document chain back to
the top-level frame).
Reviewed by Dan
- rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
- 6:25 AM Changeset in webkit [35222] by
-
- 5 edits in trunk/JavaScriptCore
2008-07-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Cameron Zwarich.
Merge pre&post resolve nodes to simplify the parse tree.
Sunspider results show no performance change.
- kjs/grammar.y:
- kjs/nodes.cpp:
- kjs/nodes.h:
- kjs/nodes2string.cpp:
- 5:06 AM Changeset in webkit [35221] by
-
- 5 edits in trunk/JavaScriptCore
2008-07-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Cameron Zwarich.
Merge logical nodes to simplify the parse tree.
Sunspider results show 0.6% progression (no performance change expected).
- kjs/grammar.y:
- kjs/nodes.cpp:
- kjs/nodes.h:
- kjs/nodes2string.cpp:
- 5:01 AM Changeset in webkit [35220] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-17 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Fix MinGW build (broken in r35198) and simplify getLocalTime().
- kjs/DateMath.cpp: (KJS::getLocalTime):
- 4:51 AM Changeset in webkit [35219] by
-
- 2 edits in trunk/WebKit/gtk
[GTK] WebKit crashes on invalid settings notify callback
https://bugs.webkit.org/show_bug.cgi?id=19813
Disconnect in webkit_web_view_finalize
Reviewed by Holger Freyther.
- 4:44 AM Changeset in webkit [35218] by
-
- 5 edits in trunk/JavaScriptCore
2008-07-17 Gavin Barraclough <barraclough@apple.com>
Merge pre&post bracket nodes to simplify the parse tree.
Sunspider results show no performance change.
Reviewed by Sam Weinig.
- kjs/grammar.y:
- kjs/nodes.cpp:
- kjs/nodes.h:
- kjs/nodes2string.cpp:
- 4:34 AM Changeset in webkit [35217] by
-
- 3 edits in trunk/JavaScriptCore
2008-07-17 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Fix the 32-bit gcc builds, conversion from "long int" to Register is
ambiguous. Explicitly choose the intptr_t constructor.
- 12:18 AM Changeset in webkit [35216] by
-
- 2 edits in trunk/WebCore
Reviewed by mitz.
Attempt to make initializeATSUStyle human-readable by
splitting it out into better-named static inline functions.
No functional changes, thus no tests.
- platform/graphics/mac/FontMac.mm: (WebCore::fontHasMirroringInfo): (WebCore::disableLigatures): (WebCore::initializeATSUStyle):
- 12:17 AM Changeset in webkit [35215] by
-
- 2 edits in trunk/WebCore
No review, build fix only.
Attempt to fix Mac build
- WebCore.xcodeproj/project.pbxproj: Make TextRun.h a private header.
Jul 16, 2008:
- 11:51 PM Changeset in webkit [35214] by
-
- 2 edits in trunk/WebKitTools
2008-07-16 Jon Honeycutt <jhoneycutt@apple.com>
CygwinDownloader fails to install necessary packages
https://bugs.webkit.org/show_bug.cgi?id=20075
Reviewed by Mark Rowe.
- CygwinDownloader/cygwin-downloader.zip: Rebuilt after two broken mirrors removed in r34116. Set MIME type to application/octet-stream.
- 11:20 PM Changeset in webkit [35213] by
-
- 2 edits in trunk/WebKitTools
2008-07-16 Jon Honeycutt <jhoneycutt@apple.com>
CygwinDownloader's make-zip.sh script fails
https://bugs.webkit.org/show_bug.cgi?id=20074
Reviewed by Mark Rowe.
- CygwinDownloader/cygwin-downloader.py:
- 11:17 PM Changeset in webkit [35212] by
-
- 2 edits in trunk/WebCore
2008-07-16 Jon Honeycutt <jhoneycutt@apple.com>
REGRESSION: Can't create windowless plug-in with Flash 9
https://bugs.webkit.org/show_bug.cgi?id=20070
Reviewed by Mark Rowe.
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::determineQuirks): Reverse argument order; PlatformModuleVersion constructor takes leastSig, mostSig.
- 11:13 PM Changeset in webkit [35211] by
-
- 2 edits in trunk/WebCore
Reviewed by mitz.
Make ATSULayoutParameters a real C++ class
(Give it a destructor to clean up after itself)
(Also use OwnArrayPtr instead of manual member cleanup)
- platform/graphics/mac/FontMac.mm: (WebCore::ATSULayoutParameters::ATSULayoutParameters): (WebCore::ATSULayoutParameters::~ATSULayoutParameters): (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
- 11:12 PM Changeset in webkit [35210] by
-
- 2 edits in trunk/WebCore
Reviewed by mitz.
Make ownership of copied UChar buffer clearer
(and more leak-proof) by using a OwnArrayPtr.
No functional changes, thus no tests.
- platform/graphics/mac/FontMac.mm: (WebCore::copyRunForDirectionalOverrideIfNecessary): (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::offsetForPositionForComplexText):
- 10:27 PM Changeset in webkit [35209] by
-
- 3 edits in trunk/JavaScriptCore
Fix JavaScript in 64-bit by using a pointer-sized integer
type in the Register union. Also includes a rename of
the intType constant to IntType.
Rubber-stamped by Geoff Garen.
- VM/Machine.cpp:
(KJS::Machine::initializeCallFrame):
- VM/Register.h:
(KJS::Register::):
(KJS::Register::Register):
- 9:04 PM Changeset in webkit [35208] by
-
- 4 edits1 add in trunk/WebCore
Reviewed by Sam.
Split out TextRun into its own header file.
Re-order members to place all bools together
(to allow compilers to better pack the struct)
No functional changes, thus no tests.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/Font.h: Moved TextRun into its own file.
- platform/graphics/TextRun.h: Split out from Font.h
- 6:16 PM Changeset in webkit [35207] by
-
- 3 edits3 adds in trunk
2008-07-16 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
AnimationController needs to adjust z-index in the blended
style in case opacity or transform were changed by blending.
Test: transitions/opacity-transition-zindex.html
- page/AnimationController.cpp: (WebCore::AnimationController::updateImplicitAnimations):
- 5:41 PM Changeset in webkit [35206] by
-
- 6 edits in trunk/WebCore
Reviewed by Sam.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=20052
Export the tag & attribute names as string literals for SVGNames/XLinkNames and one property in HTMLNames.
- 5:22 PM Changeset in webkit [35205] by
-
- 5 edits in trunk/LayoutTests
Rubber stamped by Eric.
Update pixel test results for two tests that have been changed.
- 4:34 PM Changeset in webkit [35204] by
-
- 46 edits1 add in trunk/WebCore
Reviewed by Eric.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=10745 (SVGLength object needs some weight loss)
Don't store a context pointer in SVGLength, saving memory.
- 3:47 PM Changeset in webkit [35203] by
-
- 22 edits in trunk
2008-07-16 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
First step toward putting doubles in registers: Turned Register into a
proper abstraction layer. It is no longer possible to cast a Register
to a JSValue*, or a Register& to a JSValue*&, or to access the union
inside a Register directly.
SunSpider reports no change.
In support of this change, I had to make the following mechanical changes
in a lot of places:
- Clients now use explicit accessors to read data out of Registers, and implicit copy constructors to write data into registers.
So, assignment that used to look like
x.u.jsValue = y;
now looks like
x = y;
And access that used to look like
x = y.u.jsValue;
now looks like
x = y.jsValue();
- I made generic flow control specific in opcodes that made their flow control generic by treating a Register& as a JSValue*&. This had the added benefit of removing some exception checking branches from immediate number code.
- I beefed up PropertySlot to support storing a Register* in a property slot. For now, only JSVariableObject's symbolTableGet and symbolTablePut use this functionality, but I expect more clients to use it in the future.
- I changed ArgList to be a buffer of Registers, not JSValue*'s, and I changed ArgList iterator clients to iterate Registers, not JSValue*'s.
WebCore:
2008-07-16 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Support for JavaScriptCore's first step toward putting doubles in
registers: Treat ArgList iterators as Register*'s, not JSValue*'s.
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction):
- 2:41 PM Changeset in webkit [35202] by
-
- 2 edits in trunk/JavaScriptCore
Fixed build.
- kjs/JSGlobalObject.cpp:
- 2:24 PM Changeset in webkit [35201] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Anders Carlsson.
Add missing layout test results.
- 1:37 PM Changeset in webkit [35200] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-16 Kevin McCullough <kmccullough@apple.com>
Reviewed by Sam and Geoff.
<rdar://problem/5958840> Navigating to another page while profiler is
attached results in slow JavaScript for all time.
- The UNLIKELY keeps this from being a sunspider performance regression.
- kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::~JSGlobalObject): Stop the profiler associated with this exec state.
- 1:19 PM Changeset in webkit [35199] by
-
- 6 edits in trunk/JavaScriptCore
2008-07-16 Sam Weinig <sam@webkit.org>
Reviewed by Steve Falkenburg.
Replace adopting UString constructor in favor of explicit
static adopt method.
- API/JSStringRefCF.cpp: (JSStringCreateWithCFString):
- kjs/StringConstructor.cpp: (KJS::stringFromCharCode):
- kjs/StringPrototype.cpp: (KJS::stringProtoFuncToLowerCase): (KJS::stringProtoFuncToUpperCase): (KJS::stringProtoFuncToLocaleLowerCase): (KJS::stringProtoFuncToLocaleUpperCase):
- kjs/ustring.cpp: (KJS::UString::adopt):
- kjs/ustring.h: (KJS::UString::UString): (KJS::UString::~UString):
- 3:14 AM Changeset in webkit [35198] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
http://trolltech.com/developer/task-tracker/index_html?method=entry&id=216179
Fix potential crash (on Qt for Windows port) when performing JavaScript date
conversion.
- kjs/DateMath.cpp: (KJS::getLocalTime): For the Qt port, prefer to use Windows code, i.e. localtime_s() instead of localtime() since the latter might crash (on Windows) given a non-sensible, e.g. NaN, argument.
- 1:24 AM Changeset in webkit [35197] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Fix a typo in ChangeLog.
- 1:20 AM Changeset in webkit [35196] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Anders and Geoff.
https://bugs.webkit.org/show_bug.cgi?id=20023
Failed assertion in PropertyNameArray.cpp
This is already tested by testapi.
- API/JSObjectRef.cpp: (JSPropertyNameAccumulatorAddName): Add the string to identifier table to appeaase PropertyNameArray.
- 1:07 AM Changeset in webkit [35195] by
-
- 5 edits in trunk/JavaScriptCore
Reviewed by Geoff.
Dereference identifiers when deleting a hash table (fixes leaks with private JSGlobalData
objects).
- kjs/JSGlobalData.cpp: (KJS::JSGlobalData::~JSGlobalData):
- kjs/lookup.cpp: (KJS::HashTable::deleteTable):
- kjs/lookup.h:
- kjs/lexer.cpp: (KJS::Lexer::~Lexer) HashTable cannot have a destructor, because check-for-global-initializers complains about having a global constructor then.
- 12:58 AM Changeset in webkit [35194] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Geoff.
Check pthread_key_create return value.
This check was helpful when debugging a crash in run-webkit-tests --threaded that happened
because JSGlobalData objects were not deleted, and we were running out of pthread keys soon.
It also looks useful for production builds.
- wtf/ThreadSpecific.h: (WTF::::ThreadSpecific):
Jul 15, 2008:
- 9:53 PM Changeset in webkit [35193] by
-
- 19 edits3 adds in trunk
WebKitTools:
2008-07-15 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Refactor accessibility testing code.
We now have:
- AccessibilityController Controller which has access to the WebView and can provide the focused element, root element and in the future, elementAtPoint.
- AccessibilityUIElement Object which provides access to the data provided by the Accessibility APIs.
- DumpRenderTree/AccessibilityController.cpp: (getFocusedElementCallback): (getRootElementCallback): (AccessibilityController::getJSClass):
- DumpRenderTree/AccessibilityController.h:
- DumpRenderTree/AccessibilityUIElement.cpp: Added. (allAttributesCallback): (attributesOfLinkedUIElementsCallback): (attributesOfChildrenCallback): (getRoleCallback): (getTitleCallback): (getDescriptionCallback): (getWidthCallback): (getHeightCallback): (getIntValueCallback): (getMinValueCallback): (getMaxValueCallback): (finalize): (AccessibilityUIElement::makeJSAccessibilityUIElement): (AccessibilityUIElement::getJSClass):
- DumpRenderTree/AccessibilityUIElement.h: Added. (AccessibilityUIElement::platformUIElement):
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/mac/AccessibilityControllerMac.mm: (AccessibilityController::AccessibilityController): (AccessibilityController::~AccessibilityController): (AccessibilityController::focusedElement): (AccessibilityController::rootElement):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added. (AccessibilityUIElement::AccessibilityUIElement): (descriptionOfValue): (attributesOfElement): (nsStringToJSStringRef): (concatenateAttributeAndValue): (AccessibilityUIElement::getLinkedUIElements): (AccessibilityUIElement::getChildren): (AccessibilityUIElement::attributesOfLinkedUIElements): (AccessibilityUIElement::attributesOfChildren): (AccessibilityUIElement::allAttributes): (AccessibilityUIElement::role): (AccessibilityUIElement::title): (AccessibilityUIElement::description): (AccessibilityUIElement::width): (AccessibilityUIElement::height): (AccessibilityUIElement::intValue): (AccessibilityUIElement::minValue): (AccessibilityUIElement::maxValue):
LayoutTests:
2008-07-15 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Update for refactored accessibility testing code.
- accessibility/aria-describedby-on-input.html:
- accessibility/aria-labelledby-on-input.html:
- accessibility/aria-range-value.html:
- accessibility/aria-range.html:
- accessibility/aria-roles.html:
- accessibility/aria-slider.html:
- accessibility/aria-spinbutton.html:
- accessibility/document-attributes.html:
- accessibility/image-map1.html:
- accessibility/image-map2.html:
- accessibility/internal-link-anchors.html:
- accessibility/radio-button-checkbox-size.html:
- accessibility/radio-button-group-members.html:
- 9:11 PM Changeset in webkit [35192] by
-
- 4 edits in trunk
Versioning.
- 9:10 PM Changeset in webkit [35191] by
-
- 1 copy in tags/Safari-6527.2
New tag.
- 8:17 PM Changeset in webkit [35190] by
-
- 9 edits in trunk/WebCore
2008-07-15 Maxime Britto <britto@apple.com>
Reviewed by Eric.
https://bugs.webkit.org/show_bug.cgi?id=17589
<rdar://problem/5770893>
Retrieve the wheel sensitivity setting from windows system settings for the horizontal and the vertical scrolling.
Allows the page scrolling with the wheel (if activated in windows settings) on both horizontal and vertical ways
For the other platforms, nothing is changed but if someone want to activate this feature
he/she has to retrieve the settings and fill out the m_lineScrollSensitivity and/or m_charScrollSensitivity in his/her PlatformWheelEvent constructor.
- ChangeLog:
- page/EventHandler.cpp: (WebCore::scrollAndAcceptEvent): static inline function to avoid copy/paste in the member functions (WebCore::EventHandler::handleWheelEvent): Call to the above mentionned static inline function with the right parameters
- platform/PlatformWheelEvent.h: (WebCore::PlatformWheelEvent::deltaX): Now returns the delta multiplied by the user settings for the number of lines to scroll (WebCore::PlatformWheelEvent::deltaY): Now returns the delta multiplied by the user settings for the number of chars to scroll (WebCore::PlatformWheelEvent::isPageXScrollModeEnabled): (WebCore::PlatformWheelEvent::isPageYScrollModeEnabled):
- platform/gtk/WheelEventGtk.cpp: Add the values to avoid build break but the factors are initialized to 1 not to change the previous behavior (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- platform/mac/WheelEventMac.mm: Add the values to avoid build break but the factors are initialized to 1 not to change the previous behavior (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- platform/qt/WheelEventQt.cpp: Add the values to avoid build break but the factors are initialized to 1 not to change the previous behavior (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- platform/win/ScrollViewWin.cpp: Added the page scroll (horiz/vertical) and reduced the number of pixels to scroll per line to keep the standard behavior with the factor (WebCore::adjustDeltaForPageScrollMode): static inline function to avoid copy/paste in the member functions (WebCore::ScrollView::updateScrollbars): (WebCore::ScrollView::wheelEvent):
- platform/win/WheelEventWin.cpp: Retrieves the new values by using the win32 API. (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- platform/wx/MouseWheelEventWx.cpp: Add the values to avoid build break but the factors are initialized to 1 not to change the previous behavior (WebCore::PlatformWheelEvent::PlatformWheelEvent):
- 8:09 PM Changeset in webkit [35189] by
-
- 2 edits in trunk/WebCore
wx build fix - adding AccessibilityImageMapLink.cpp to the wx build.
- 4:46 PM Changeset in webkit [35188] by
-
- 3 edits4 adds in trunk
WebCore:
2008-07-15 Kevin McCullough <kmccullough@apple.com>
Reviewed by Dan.
<rdar://problem/5620273> REGRESSION: Apparent caching between form
submits twice (on Maconomy) (18401)
Frames did not set the createdByParser flag even when they were.
- html/HTMLElementFactory.cpp: (WebCore::frameConstructor): (WebCore::iframeConstructor):
LayoutTests:
2008-07-15 Kevin McCullough <kmccullough@apple.com>
Reviewed by Dan.
<rdar://problem/5620273> REGRESSION: Apparent caching between form
submits twice (on Maconomy) (18401)
- fast/forms/form-and-frame-interaction-retains-values-expected.txt: Added.
- fast/forms/form-and-frame-interaction-retains-values.html: Added.
- fast/forms/resources/form-and-frame-interaction-retains-values-main.html: Added.
- fast/forms/resources/form-and-frame-interaction-retains-values-submit.html: Added.
- 4:20 PM Changeset in webkit [35187] by
-
- 2 edits in trunk/LayoutTests
Rubber-stamped by Sam Weinig.
- update results for the addition of the compareDocumentPosition-related constants
- fast/dom/domListEnumeration-expected.txt:
- 3:53 PM Changeset in webkit [35186] by
-
- 3 edits4 adds in trunk
WebCore:
Reviewed by Dave Hyatt.
- fix https://bugs.webkit.org/show_bug.cgi?id=19525 <rdar://problem/5961768> -webkit-box-reflect in hyperlink causes webkit to crash
Test: fast/reflections/inline-crash.html
- rendering/RenderInline.cpp: (WebCore::RenderInline::setStyle): Added setHasReflection(false). Inline flows never have reflections.
LayoutTests:
Reviewed by Dave Hyatt.
- test for https://bugs.webkit.org/show_bug.cgi?id=19525 <rdar://problem/5961768> -webkit-box-reflect in hyperlink causes webkit to crash
- fast/reflections/inline-crash.html: Added.
- platform/mac/fast/reflections/inline-crash-expected.checksum: Added.
- platform/mac/fast/reflections/inline-crash-expected.png: Added.
- platform/mac/fast/reflections/inline-crash-expected.txt: Added.
- 2:24 PM Changeset in webkit [35185] by
-
- 3 edits4 adds in trunk
2008-07-14 David Hyatt <hyatt@apple.com>
Allow <style> and <link> pretty much anywhere. They will still be moved to the <head> if
no <body> exists yet though.
Reviewed by Sam
Added fast/css/style-parsed-outside-of-head.html
- html/HTMLElement.cpp: (WebCore::inlineTagList):
- 10:48 AM Changeset in webkit [35184] by
-
- 10 edits in trunk
2008-07-15 Kevin McCullough <kmccullough@apple.com>
Reviewed by Geoff.
Rename pageGroupIdentifier to profileGroup to keep mention of a
pageGroup out of JavaScriptCore.
- kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::init):
- kjs/JSGlobalObject.h: (KJS::JSGlobalObject::setProfileGroup): (KJS::JSGlobalObject::profileGroup):
- profiler/ProfileGenerator.cpp: (KJS::ProfileGenerator::create): (KJS::ProfileGenerator::ProfileGenerator):
- profiler/ProfileGenerator.h: (KJS::ProfileGenerator::profileGroup):
- profiler/Profiler.cpp: (KJS::Profiler::startProfiling): (KJS::dispatchFunctionToProfiles): (KJS::Profiler::willExecute): (KJS::Profiler::didExecute):
WebCore:
2008-07-15 Kevin McCullough <kmccullough@apple.com>
Reviewed by Geoff.
Rename pageGroupIdentifier to profileGroup to keep mention of a
pageGroup out of JavaScriptCore.
- bindings/js/JSQuarantinedObjectWrapper.cpp: (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom):
- bindings/js/ScriptController.cpp: (WebCore::ScriptController::clear): (WebCore::ScriptController::initScript):
- history/CachedPage.cpp: (WebCore::CachedPage::restore):
- 10:06 AM Changeset in webkit [35183] by
-
- 2 edits in trunk/LayoutTests
2008-07-15 Adele Peterson <adele@apple.com>
Updating results for my fix to <rdar://problem/5784890>.
- http/tests/misc/xhtml-expected.txt:
- 9:49 AM Changeset in webkit [35182] by
-
- 9 edits in trunk
Add WebKit[Set]ShouldUseFontSmoothing functions
WebCore:
WebCore part of adding WebKit[Set]ShouldUseFontSmoothing functions
<rdar://6059127>
Reviewed by John Sullivan.
- platform/graphics/win/FontCGWin.cpp: (WebCore::Font::drawGlyphs): Pass the result of WebCoreShouldUseFontSmoothing() into wkSetFontSmoothingStyle.
- platform/win/WebCoreTextRenderer.cpp: (WebCore::WebCoreSetShouldUseFontSmoothing): (WebCore::WebCoreShouldUseFontSmoothing): Added.
- platform/win/WebCoreTextRenderer.h:
WebKit/win:
Add WebKit[Set]ShouldUseFontSmoothing functions
<rdar://6059127>
Reviewed by John Sullivan.
- WebKit.vcproj/WebKit.def:
- WebKit.vcproj/WebKit_debug.def: Export the new functions.
- WebKitGraphics.cpp: (WebKitSetShouldUseFontSmoothing): (WebKitShouldUseFontSmoothing): Call through to the relevant WebCore functions.
- WebKitGraphics.h:
- 9:32 AM Changeset in webkit [35181] by
-
- 7 edits in trunk/LayoutTests
Rubber-stamped by Anders Carlsson.
- updated results for https://bugs.webkit.org/show_bug.cgi?id=18088 <rdar://problem/6036232> white-space:nowrap; float:left; causing the misalignment issue
- platform/mac/tables/mozilla/bugs/bug26553-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug26553-expected.png:
- platform/mac/tables/mozilla/bugs/bug26553-expected.txt:
- platform/mac/tables/mozilla/bugs/bug57828-2-expected.checksum:
- platform/mac/tables/mozilla/bugs/bug57828-2-expected.png:
- platform/mac/tables/mozilla/bugs/bug57828-2-expected.txt:
- 8:34 AM Changeset in webkit [35180] by
-
- 2 edits in trunk/WebCore
Windows build fix
- WebCore.vcproj/WebCore.vcproj: Add AccessibilityImageMapLink.{cpp,h} to the project.
- 1:14 AM Changeset in webkit [35179] by
-
- 3 edits in trunk/WebCore
2008-07-15 Holger Hans Peter Freyther <zecke@selfish.org>
Build fix for the Gtk+ and Qt platform.
- GNUmakefile.am: Add AccessibilityImageMapLink.cpp to the build
- WebCore.pro: Add AccessibilityImageMapLink.cpp to the build
Jul 14, 2008:
- 11:16 PM Changeset in webkit [35178] by
-
- 2 edits in trunk/WebCore
- Tiger build fix
- platform/mac/WidgetMac.mm: (WebCore::Widget::paint):
- 7:17 PM Changeset in webkit [35177] by
-
- 4 edits in trunk/JavaScriptCore
Fix https://bugs.webkit.org/show_bug.cgi?id=20037
Bug 20037: GCC 4.2 build broken due to strict aliasing violation.
Reviewed by Sam Weinig.
- kjs/ustring.cpp:
(KJS::UString::Rep::computeHash): Add a version of computeHash that takes a char* and explicit length.
- kjs/ustring.h:
- profiler/CallIdentifier.h:
(WTF::): Use new version of computeHash that takes a char* and explicit length to avoid unsafe aliasing.
- 5:16 PM Changeset in webkit [35176] by
-
- 5 edits in trunk
WebCore:
Reviewed by John Sullivan.
- WebCore part of fixing <rdar://problem/6071850> Subviews not drawn correctly when using -cacheDisplayInRect:toBitmapImageRep:
- platform/mac/WidgetMac.mm: (WebCore::Widget::paint): Changed to account for the case of drawing into a bitmap context that is not a window's backing store. In that case, -displayRectIgnoringOpacity:inContext: is used to redirect the drawing to the correct context, after setting up the right transform on it. For subframes, additional code ensures that the scroll view will not paint the background behind a transparent frame.
WebKit/mac:
Reviewed by John Sullivan.
- WebKit part of fixing <rdar://problem/6071850> Subviews not drawn correctly when using -cacheDisplayInRect:toBitmapImageRep:
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Changed to account for the case of being drawn into a bitmap context that is not a window's backing store. In that case, there are no valid "rects being drawn" to clip to.
- WebView/WebHTMLView.mm: (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]): Added an override of this NSView method which is used in for -cacheDisplayInRect:toBitmapImageRep:. Like two existing NSView drawing machinery overrides, it sets subviews aside before invoking the superclass implementation. On Tiger, it also updates the layout.
- 4:15 PM Changeset in webkit [35175] by
-
- 2 edits in trunk/WebKit/win
Don't include autoversion.h in WebKitDLL.cpp.
autoversion.h changes for every build, so we don't want to include it unless necessary.
Rubber stamped by Ada Chan.
- WebKitDLL.cpp:
- 3:43 PM Changeset in webkit [35174] by
-
- 14 edits6 adds in trunk
<rdar://problem/6038106> AXChildren returned for this web area is null
The accessibility of image maps needed to be brought inline with the new AX architecture
- 3:31 PM Changeset in webkit [35173] by
-
- 5 edits in trunk/WebCore
2008-07-14 Sam Weinig <sam@webkit.org>
Rubber-stamped by David Hyatt.
Remove unused ExceptionCode parameter from compareDocumentPosition.
- dom/Document.cpp: (WebCore::Document::addStyleSheetCandidateNode):
- dom/Node.cpp: (WebCore::Node::compareDocumentPosition):
- dom/Node.h:
- dom/Node.idl:
- 3:10 PM Changeset in webkit [35172] by
-
- 13 edits9 adds in trunk
2008-07-14 David Hyatt <hyatt@apple.com>
Fix for bugzilla bug 5476, link and style elements should be allowed outside the <head>.
Reviewed by Sam
Added fast/css/style-outside-head.html
Added fast/css/link-outside-head.html
- dom/Document.cpp: (WebCore::Document::addStyleSheetCandidateNode): (WebCore::Document::removeStyleSheetCandidateNode): (WebCore::Document::recalcStyleSelector):
- dom/Document.h:
- dom/Node.cpp: (WebCore::Node::compareDocumentPosition):
- dom/ProcessingInstruction.cpp: (WebCore::ProcessingInstruction::checkStyleSheet): (WebCore::ProcessingInstruction::insertedIntoDocument): (WebCore::ProcessingInstruction::removedFromDocument): (WebCore::ProcessingInstruction::finishParsingChildren):
- dom/ProcessingInstruction.h: (WebCore::ProcessingInstruction::setCreatedByParser):
- dom/StyleElement.cpp: (WebCore::StyleElement::removedFromDocument):
- dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::startElementNs): (WebCore::XMLTokenizer::processingInstruction): (WebCore::):
- html/HTMLElementFactory.cpp: (WebCore::linkConstructor):
- html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::HTMLLinkElement): (WebCore::HTMLLinkElement::insertedIntoDocument): (WebCore::HTMLLinkElement::removedFromDocument): (WebCore::HTMLLinkElement::finishParsingChildren):
- html/HTMLLinkElement.h: (WebCore::HTMLLinkElement::setCreatedByParser):
- html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::insertedIntoDocument): (WebCore::HTMLStyleElement::removedFromDocument):
- svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::insertedIntoDocument): (WebCore::SVGStyleElement::removedFromDocument):
- 3:08 PM Changeset in webkit [35171] by
-
- 2 edits in trunk/WebKitTools
2008-07-14 Steve Falkenburg <sfalken@apple.com>
Build fix.
- DumpRenderTree/win/DumpRenderTree.vcproj:
- 2:48 PM Changeset in webkit [35170] by
-
- 2 edits in trunk/WebKitTools
Attempted Windows build fix
- DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Add CoreFoundation/OSXCompatibilityHeadersGNUCompatibility to the include path.
- 2:21 PM Changeset in webkit [35169] by
-
- 2 edits in trunk/WebCore
2008-07-14 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
Sort interface extended attributes to appease *the* Mark Rowe.
- page/DOMWindow.idl:
- 2:16 PM Changeset in webkit [35168] by
-
- 4 edits2 adds in trunk
WebCore:
2008-07-14 Anders Carlsson <andersca@apple.com>
Reviewed by Geoff.
<rdar://problem/6073974>
https://bugs.webkit.org/show_bug.cgi?id=18106
The "onscroll" event bubbles, which is inconsistent with Firefox and IE
Don't bubble the scroll event.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollToOffset):
- rendering/RenderListBox.cpp: (WebCore::RenderListBox::valueChanged):
LayoutTests:
2008-07-14 Anders Carlsson <andersca@apple.com>
Reviewed by Geoff.
<rdar://problem/6073974>
https://bugs.webkit.org/show_bug.cgi?id=18106
The "onscroll" event bubbles, which is inconsistent with Firefox and IE
Add test.
- fast/events/scroll-event-does-not-bubble-expected.txt: Added.
- fast/events/scroll-event-does-not-bubble.html: Added.
- 1:58 PM Changeset in webkit [35167] by
-
- 2 edits in trunk/WebCore
2008-07-14 Adele Peterson <adele@apple.com>
Reviewed by Geoff.
Fix for <rdar://problem/5784890> REGRESSION (Safari 3): Can't edit SpeedStream 4100 DSL modem settings
The web server on this particular piece of hardware doesn't handle "text/xml" in the
Accept header if the headers are sent in a certain order. Safari 2 used to send "*/*" in
the Accept header. Firefox 2 sent "text/xml" but in an acceptable order for the web
server. And Firefox 3 doesn't send "text/xml" at all in the Accept header since it
is being deprecated in favor of "application/xml". We decided that the best solution is
to match Firefox 3 and stop sending "text/xml" in the Accept header.
No test. There appears to be no way to get the raw headers in the original order in perl/php.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):
- 1:56 PM Changeset in webkit [35166] by
-
- 5 edits3 adds in trunk
WebCore:
2008-07-14 Sam Weinig <sam@webkit.org>
Reviewed by Adele Peterson.
Fix for <rdar://problem/5769819>
Test: http/tests/security/cross-frame-access-object-prototype.html
- bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::getPropertyAttributes): Perform security check. (WebCore::JSDOMWindow::defineGetter): Ditto. (WebCore::JSDOMWindow::defineSetter): Ditto. (WebCore::JSDOMWindow::lookupGetter): Ditto. (WebCore::JSDOMWindow::lookupSetter): Ditto.
- bindings/scripts/CodeGeneratorJS.pm: Add support for custom versions of all the core JSObject functionality.
- page/DOMWindow.idl: Override remaining core JSObject functionality, to inject security checks.
LayoutTests:
2008-07-14 Sam Weinig <sam@webkit.org>
Reviewed by Adele Peterson.
Test for <rdar://problem/5769819>
- http/tests/security/cross-frame-access-object-prototype-expected.txt: Added.
- http/tests/security/cross-frame-access-object-prototype.html: Added.
- http/tests/security/resources/cross-frame-iframe-for-object-prototype-test.html: Added.
- 1:37 PM Changeset in webkit [35165] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-14 David Hyatt <hyatt@apple.com>
Fix a crashing bug in ListHashSet's -- operator. Make sure that end() can be -- by special-casing the null
position.
Reviewed by Maciej
- wtf/ListHashSet.h: (WTF::ListHashSetConstIterator::operator--):
- 1:04 PM Changeset in webkit [35164] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-14 David Hyatt <hyatt@apple.com>
Buidl fix. Make sure the second insertBefore method returns a value.
- wtf/ListHashSet.h: (WTF::::insertBefore):
- 12:21 PM Changeset in webkit [35163] by
-
- 9 edits in trunk
Windows build fixes
Windows build fix
- JavaScriptCore.vcproj/jsc/jsc.vcproj: Added include/pthreads to the include path.
WebCore:
Windows build fixes
- WebCore.vcproj/WebCore.vcproj: Add include/pthreads to the include path.
- bindings/scripts/CodeGeneratorCOM.pm: Touched this to force COM bindings to regenerate.
- loader/FTPDirectoryDocument.cpp:
- loader/FTPDirectoryParser.cpp: Fixed some duplicate macro definitions now that we're including pthread.h again.
WebKit/win:
Windows build fix
- WebJavaScriptCollector.cpp: (WebJavaScriptCollector::objectCount): Updated to match -[WebCoreStatistics javaScriptsObjectCount].
- 11:23 AM Changeset in webkit [35162] by
-
- 8 edits in trunk
Reviewed by Kevin McCullough.
Make JSGlobalData refcounted in preparation to adding a way to create contexts that share
global data.
- JavaScriptCore.exp:
- kjs/JSGlobalData.cpp: (KJS::JSGlobalData::create):
- kjs/JSGlobalData.h: Made contructor private, and added a static create() method. Made the class inherit from RefCounted.
- kjs/JSGlobalObject.h: (KJS::JSGlobalObject::globalData): JSGlobalData is now owned by JSGlobalObject (except for the shared one, and the common WebCore one, which are never deleted).
- kjs/Shell.cpp: (main): Create JSGlobalData with create() method.
WebCore:
- bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::commonJSGlobalData): Create JSGlobalData with create() method.
- 7:13 AM Changeset in webkit [35161] by
-
- 2 edits in trunk/WebCore
2008-07-14 Simon Hausmann <Simon Hausmann>
Reviewed by Holger.
Make listDirectory() in the Qt port work with empty namefilters.
Don't include . and .. to avoid scanning the parent directory.
- 5:12 AM Changeset in webkit [35160] by
-
- 3 edits in trunk/JavaScriptCore
2008-07-14 Simon Hausmann <Simon Hausmann>
Fix the single-threaded build.
- 4:28 AM Changeset in webkit [35159] by
-
- 40 edits2 adds in trunk
Reviewed by Geoff Garen.
Eliminate per-thread JavaScript global data instance support and make arbitrary
global data/global object combinations possible.
- 3:20 AM Changeset in webkit [35158] by
-
- 4 edits in trunk/WebCore
2008-07-14 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
MinGW build fixes
- plugins/win/PluginDatabaseWin.cpp:
- plugins/win/PluginViewWin.cpp: (WebCore::PluginView::handleKeyboardEvent): (WebCore::PluginView::handleMouseEvent):
- svg/SynchronizableTypeWrapper.h: (WebCore::::SynchronizableTypeWrapper):
Jul 13, 2008:
- 10:23 PM Changeset in webkit [35157] by
-
- 2 edits1 add in trunk/WebCore
2008-07-13 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt and Dan Bernstein.
Fix for <rdar://problem/5888127>
https://bugs.webkit.org/show_bug.cgi?id=18699
- Match Firefox in restricting the size of custom cursor to images to 128x128 px.
- Restrict custom cursor hotspots to values within the bounds of the cursor image.
- manual-tests/cursor-max-size.html: Added.
- page/EventHandler.cpp: (WebCore::EventHandler::selectCursor):
- 7:46 PM Changeset in webkit [35156] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix: Add wtf/RefCountedLeakCounter to the project.
- JavaScriptCore.vcproj/WTF/WTF.vcproj:
- 3:50 PM Changeset in webkit [35155] by
-
- 2 edits in trunk/WebCore
wx build fix.
