Timeline
Jul 20, 2008:
- 8:39 PM Changeset in webkit [35260] by
-
- 2 edits in trunk/WebCore
Touch file to force rebuild for vsprops change.
- WebCorePrefix.h:
- 8:38 PM Changeset in webkit [35259] by
-
- 2 edits in trunk/WebKitLibraries
Build fix.
- win/tools/vsprops/common.vsprops:
- 6:37 PM Changeset in webkit [35258] by
-
- 1 edit1 add in trunk/LayoutTests
Whoops, forgot to commit expected output for this test.
RS=Dan Bernstein
- 4:39 PM Changeset in webkit [35257] by
-
- 2 edits in trunk/WebCore
2008-07-20 Sam Weinig <sam@webkit.org>
Remove extra space Oliver Hunt left in.
- page/Console.cpp: (WebCore::Console::reportException): (WebCore::Console::reportCurrentException):
- 2:31 PM Changeset in webkit [35256] by
-
- 2 edits in trunk/WebCore
Bug 19757: Crash when an ondragstart handler hides the element
<https://bugs.webkit.org/show_bug.cgi?id=19757>
Reviewed by Dan Bernstein.
The solution to this is problem is just to null check the renderer
immediately before launching the system drag, and terminate the
drag if the renderer is gone.
- 1:48 PM Changeset in webkit [35255] by
-
- 6 edits4 adds in trunk
Reviewed by Oliver.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=12171
Remove manual SVG property <-> XML attribute synchronization in SVGPolyElement.
Added svg/custom/poly-points-attribute-changes.svg (testcase from Rob)
- 1:40 PM Changeset in webkit [35254] by
-
- 6 edits in trunk/WebCore
Reviewed by Oliver.
Cleanup JSSVGPODTypeWrapper code.
- 5:43 AM Changeset in webkit [35253] by
-
- 28 edits2 adds in trunk
Bug 15979: Console logs in a database callback lose line number information
<https://bugs.webkit.org/show_bug.cgi?id=15979>
Reviewed by Mark Rowe
The problem was that there were multiple versions of the logic to
log an exception to the console, many of which were incorrect. We
resolve this by making one single shared reportException method,
which handles the exceptions correctly.
This improves fidelity of callback errors, and ensures that
exceptions thrown in timer callbacks correctly report line numbers,
etc.
Test: fast/js/exceptions-thrown-in-callbacks.html
- 4:46 AM Changeset in webkit [35252] by
-
- 2 edits in trunk/WebCore
Rubber stamped by Oliver.
Another attempt to fix the win build.
- 2:24 AM Changeset in webkit [35251] by
-
- 2 edits in trunk/WebCore
Reviewed by David Kilzer.
Fix high CPU usage on testmyiphone.com.
- Made the logic for determining when to stop looking for meta charset more strainghtforward. Previously, this happened if a tag that's disallowed in HEAD was seen past the first 512 bytes. Now, the algorithm bails out at the boundary if we are lo longer in HEAD (i.e, an offending tag was seen at any point before).
- The above change made one of our regression tests fail, because it had its <meta> declaration past the 512 byte boundary. Fixed it by raising the boundary to 1024 bytes.
- Made the algorithm bail out quickly if a comment that's not in HEAD crosses the boundary.
- Moved a check for XML content type out of the loop.
- loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset):
- 12:05 AM FAQ edited by
- (diff)
Jul 19, 2008:
- 10:29 PM Changeset in webkit [35250] by
-
- 8 edits in trunk
Bug 20104: Exception in tables/mozilla_expected_failures/bugs/bug92868_1.html includes the equals operator in the quoted expression
<https://bugs.webkit.org/show_bug.cgi?id=20104>
Reviewed by Cameron Zwarich
To make this correct we make the dot and bracket assign nodes emit the information to indicate
the failure range is the dot/bracket accessor.
- 3:05 PM Changeset in webkit [35249] by
-
- 2 edits in trunk/WebCore
Attempt to fix windows build.
- 8:46 AM Changeset in webkit [35248] by
-
- 116 edits1 add in trunk/WebCore
Reviewed by Oliver & parts by Eric.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=20051
Rewrite animated property concept without heavy macro usage, replace by a templatified solution.
Fewer virtual function calls, no more usage of the tear-off's within internal code (synchronization needed it before.)
Jul 18, 2008:
- 9:40 PM Changeset in webkit [35247] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- kjs/JSGlobalObjectFunctions.cpp: (KJS::isStrWhiteSpace):
- 9:11 PM Changeset in webkit [35246] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- kjs/nodes.h: (KJS::ThrowableExpressionData::ThrowableExpressionData):
- 6:44 PM Changeset in webkit [35245] by
-
- 37 edits2 adds in trunk
Bug 18774: SQUIRRELFISH: print meaningful error messages <https://bugs.webkit.org/show_bug.cgi?id=18774>
<rdar://problem/5769353> SQUIRRELFISH: JavaScript error messages are missing informative text
Reviewed by Cameron Zwarich
Add support for decent error messages in JavaScript. This patch achieves this by providing
ensuring the common errors and exceptions have messages that provide the text of expression
that trigger the exception. In addition it attaches a number of properties to the exception
object detailing where in the source the expression came from.
- 6:36 PM Changeset in webkit [35244] by
-
- 8 edits3 adds in trunk
2008-07-18 Maxime Britto <britto@apple.com>
Reviewed by Adele.
Fixed <rdar://problem/6049803>
Prevent the autoscroll to trigger in WebClips when starting or hovering on an editable field.
Test: fast/events/autoscroll-with-non-scrollable-parent.html
- ChangeLog:
- page/EventHandler.cpp: Edited (WebCore::EventHandler::handleMousePressEvent): changed the name of the funtion called to canBeProgramaticallyScrolled() (WebCore::EventHandler::handleMouseDraggedEvent): prevent the autoscroll to keep looking for a renderer when it's already triggered
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): verifies that the top layer can be programmatically scrolled before asking him to make the rect visible
- rendering/RenderListBox.h: (WebCore::RenderListBox::canBeProgramaticallyScrolled):
- rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled): Edited : For the 3rd case we want document's renderer to have scrollbar as it's the top layer (WebCore::RenderObject::hasScrollableView): Verifies that the Object has a view with scrollBars
- rendering/RenderObject.h: Renamed shouldAutosroll() for canBeProgramaticallyScrolled()
- rendering/RenderTextControl.h: (WebCore::RenderTextControl::canBeProgramaticallyScrolled):
2008-07-18 Adele Peterson & Maxime Britto <britto@apple.com>
Reviewed by Adele.
Test for <rdar://problem/6049803> Autoscroll triggered on no scrolling iframes
- ChangeLog:
- fast/events/autoscroll-with-non-scrollable-parent-expected.txt: Added.
- fast/events/autoscroll-with-non-scrollable-parent.html: Added.
- fast/events/resources/big-page-with-input.html: Added.
- 5:22 PM Changeset in webkit [35243] by
-
- 4 edits in trunk/WebCore
2008-07-18 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
<rdar://problem/6087283> Add support for uploading files via XMLHttpRequest
- Overload XMLHttpRequests send() method to accept File tokens.
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):
- xml/XMLHttpRequest.h:
- 3:18 PM Changeset in webkit [35242] by
-
- 34 edits in trunk
2008-07-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Three renames:
"CallTypeNative" => "CallTypeHost"
"code" => "byteCode"
"generatedCode" => "generatedByteCode"
JavaScriptGlue:
2008-07-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Three renames:
"CallTypeNative" => "CallTypeHost"
"code" => "byteCode"
"generatedCode" => "generatedByteCode"
- ChangeLog:
- JSObject.cpp: (JSUserObject::getCallData):
WebCore:
2008-07-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Three renames:
"CallTypeNative" => "CallTypeHost"
"code" => "byteCode"
"generatedCode" => "generatedByteCode"
- 3:15 PM Changeset in webkit [35241] by
-
- 2 edits in trunk/WebCore
2008-07-18 Adele Peterson <adele@apple.com>
Reviewed by Dan Bernstein.
I recently made a change to avoid fading media controls in and out if a video element actually only contains audio,
which broke the code that did the same thing for audio elements that contain video (but don't actually display that video).
This change will now check both the media element and the player to decide whether or not to make the controls persistent.
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControlVisibility):
- 3:04 PM Changeset in webkit [35240] by
-
- 2 edits in trunk/WebCore
2008-07-18 Simon Fraser <Simon Fraser>
Reviewed by mitz
Remove braces around single-line conditional.
- css/CSSComputedStyleDeclaration.cpp: (WebCore::computedTransform):
- 2:59 PM Changeset in webkit [35239] by
-
- 5 edits in trunk
2008-07-18 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
getComputedStyle() for -webkit-transform should return
'none' for elements with no renderer, or those with no
transform.
Testcase: LayoutTests/fast/css/computed-style-without-renderer
LayoutTests/fast/css/computed-style-expected.txt
- 2:44 PM Changeset in webkit [35238] by
-
- 2 edits in trunk/WebCore
2008-07-18 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Fix assertion about creating Length values with percentage types
when blending transforms.
https://bugs.webkit.org/show_bug.cgi?id=20086
- 2:25 PM Changeset in webkit [35237] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Optimized <= for immediate number cases.
SunSpider reports no overall change, but a 10% speedup on access-nsieve.
- 2:03 PM Changeset in webkit [35236] by
-
- 3 edits in trunk/JavaScriptCore
Fix some casts added in a previous build fix to match the style used
throughout WebKit.
Rubber-stamped by Sam Weinig.
- VM/Machine.cpp:
(KJS::Machine::initializeCallFrame):
- VM/Register.h:
(KJS::Register::Register):
- 11:31 AM Changeset in webkit [35235] by
-
- 2 edits in trunk/LayoutTests
Update expected results for a recently added test to what is seen when running the
full test suite.
- fast/forms/form-and-frame-interaction-retains-values-expected.txt:
- 8:31 AM Changeset in webkit [35234] by
-
- 7 edits in trunk
Bug 19975: [OpenBSD] Patches to enable build of WebKit
2008-07-18 Landry Breuil <landry@openbsd.org>
Bug 19975: [OpenBSD] Patches to enable build of WebKit
Reviewed by David Kilzer.
Support for OpenBSD, mostly threading and libm tweaks.
- kjs/collector.cpp: #include <pthread.h> (KJS::currentThreadStackBase): use pthread_stackseg_np() to get stack base
- kjs/config.h: OpenBSD also provides <pthread_np.h>
- wtf/MathExtras.h: #include <sys/types.h> and <machine/ieee.h> (isfinite), (signbit): as long as we don't have those functions provide fallback implementations
- wtf/Platform.h: Add support for PLATFORM(OPENBSD) and PLATFORM(SPARC64) macro
WebKitTools:
2008-07-18 Landry Breuil <landry@openbsd.org>
Bug 19975: [OpenBSD] Patches to enable build of WebKit
Reviewed by David Kilzer.
- DumpRenderTree/DumpRenderTree.h: OpenBSD doesn't support wide characters.
- 8:21 AM Changeset in webkit [35233] by
-
- 2 edits in trunk/WebKitSite
Fixed indentation of example code for C++ pointers/references!
- coding/coding-style.html:
- 8:15 AM Changeset in webkit [35232] by
-
- 2 edits in trunk/WebKitSite
2008-07-18 Robert Blaut <webkit@blaut.biz>
Reviewed by David Kilzer.
Fix for <https://bugs.webkit.org/show_bug.cgi?id=12313>
Added code style guidelines for multi-line boolean expressions
- coding/coding-style.html:
Jul 17, 2008:
- 9:00 PM Changeset in webkit [35231] by
-
- 7 edits in trunk/JavaScriptCore
2008-07-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Next step toward putting doubles in registers: Store constant pool
entries as registers, not JSValue*s.
SunSpider reports no change.
- 4:53 PM Changeset in webkit [35230] by
-
- 3 edits in trunk/JavaScriptCore
2008-07-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by John Sullivan and Oliver Hunt.
A tiny bit of tidying in function call register allocation.
This patch saves one register when invoking a function expression and/or
a new expression that is stored in a temporary.
Since it's just one register, I can't make a testcase for it.
- VM/CodeGenerator.cpp: (KJS::CodeGenerator::emitCall): No need to ref the function we're calling or its base. We'd like the call frame to overlap with them, if possible. op_call will read the function and its base before writing the call frame, so this is safe.
- kjs/nodes.cpp: (KJS::NewExprNode::emitCode): No need to ref the function we're new-ing, for the same reasons stated above.
(KJS::FunctionCallValueNode::emitCode): ditto
- 3:28 PM Changeset in webkit [35229] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-17 Steve Falkenburg <sfalken@apple.com>
Build fix.
- kjs/InternalFunction.cpp:
- 2:42 PM Changeset in webkit [35228] by
-
- 5 edits3 adds in trunk
2008-07-17 Sam Weinig <sam@webkit.org>
Roll out r35199 as it is causing failures on the PPC build.
LayoutTests:
2008-07-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by David Kilzer.
Test for https://bugs.webkit.org/show_bug.cgi?id=20067
Support function.name (Firefox extension)
- fast/js/function-name-expected.txt: Added.
- fast/js/function-name.html: Added.
- fast/js/resources/function-name.js: Added.
- 2:11 PM Changeset in webkit [35227] by
-
- 6 edits in trunk/JavaScriptCore
2008-07-17 Sam Weinig <sam@webkit.org>
Roll out r35199 as it is causing failures on the PPC build.
- 1:39 PM Changeset in webkit [35226] by
-
- 3 edits3 adds in trunk
2008-07-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Fixed <rdar://problem/6081636> Functions calls use more temporary
registers than necessary
Holding a reference to the last statement result register caused each
successive statement to output its result to an even higher register.
Happily, statements don't actually need to return a result register
at all. I hope to make this clearer in a future cleanup patch,
but this change will fix the major bug for now.
- kjs/nodes.cpp: (KJS::statementListEmitCode):
LayoutTests:
2008-07-17 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Test for <rdar://problem/6081636> Functions calls use more temporary
registers than necessary
- fast/js/function-call-register-allocation.html: Added.
- fast/js/function-call-register-allocation-expected.txt: Added.
- fast/js/resources/function-call-register-allocation.js: Added.
- 12:49 PM Changeset in webkit [35225] by
-
- 4 edits2 adds in trunk
Reviewed by rwlbuis@gmail.com
- Added "@"{ident} rule (below other @-rules) to use flex for longest match (if an earlier rule - e.g. @media - also matches then flex chooses that one
however, if a longer match - e.g. @mediaall matches flex will choose that)
- Updated grammar to defined ATKEYWORD token and to use that instead of '@' in the error recovery grammar.
Test: css2.1/atrule_longest_match.html
- 12:24 PM Changeset in webkit [35224] by
-
- 5 edits in trunk/JavaScriptCore
2008-07-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig.
Merge pre&post dot nodes to simplify the parse tree.
Sunspider results show 0.6% progression (no performance change expected).
- kjs/grammar.y:
- kjs/nodes.cpp:
- kjs/nodes.h:
- kjs/nodes2string.cpp:
- 11:24 AM Changeset in webkit [35223] by
-
- 2 edits in trunk/WebCore
2008-07-17 David Hyatt <hyatt@apple.com>
Make sure the check to see if a frame/iframe is being rendered inside a transparency layer is
recursive (and checks for transparency layers all the way up the ancestor document chain back to
the top-level frame).
Reviewed by Dan
- rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):
- 6:25 AM Changeset in webkit [35222] by
-
- 5 edits in trunk/JavaScriptCore
2008-07-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Cameron Zwarich.
Merge pre&post resolve nodes to simplify the parse tree.
Sunspider results show no performance change.
- kjs/grammar.y:
- kjs/nodes.cpp:
- kjs/nodes.h:
- kjs/nodes2string.cpp:
- 5:06 AM Changeset in webkit [35221] by
-
- 5 edits in trunk/JavaScriptCore
2008-07-17 Gavin Barraclough <barraclough@apple.com>
Reviewed by Cameron Zwarich.
Merge logical nodes to simplify the parse tree.
Sunspider results show 0.6% progression (no performance change expected).
- kjs/grammar.y:
- kjs/nodes.cpp:
- kjs/nodes.h:
- kjs/nodes2string.cpp:
- 5:01 AM Changeset in webkit [35220] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-17 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Fix MinGW build (broken in r35198) and simplify getLocalTime().
- kjs/DateMath.cpp: (KJS::getLocalTime):
- 4:51 AM Changeset in webkit [35219] by
-
- 2 edits in trunk/WebKit/gtk
[GTK] WebKit crashes on invalid settings notify callback
https://bugs.webkit.org/show_bug.cgi?id=19813
Disconnect in webkit_web_view_finalize
Reviewed by Holger Freyther.
- 4:44 AM Changeset in webkit [35218] by
-
- 5 edits in trunk/JavaScriptCore
2008-07-17 Gavin Barraclough <barraclough@apple.com>
Merge pre&post bracket nodes to simplify the parse tree.
Sunspider results show no performance change.
Reviewed by Sam Weinig.
- kjs/grammar.y:
- kjs/nodes.cpp:
- kjs/nodes.h:
- kjs/nodes2string.cpp:
- 4:34 AM Changeset in webkit [35217] by
-
- 3 edits in trunk/JavaScriptCore
2008-07-17 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
Fix the 32-bit gcc builds, conversion from "long int" to Register is
ambiguous. Explicitly choose the intptr_t constructor.
- 12:18 AM Changeset in webkit [35216] by
-
- 2 edits in trunk/WebCore
Reviewed by mitz.
Attempt to make initializeATSUStyle human-readable by
splitting it out into better-named static inline functions.
No functional changes, thus no tests.
- platform/graphics/mac/FontMac.mm: (WebCore::fontHasMirroringInfo): (WebCore::disableLigatures): (WebCore::initializeATSUStyle):
- 12:17 AM Changeset in webkit [35215] by
-
- 2 edits in trunk/WebCore
No review, build fix only.
Attempt to fix Mac build
- WebCore.xcodeproj/project.pbxproj: Make TextRun.h a private header.
Jul 16, 2008:
- 11:51 PM Changeset in webkit [35214] by
-
- 2 edits in trunk/WebKitTools
2008-07-16 Jon Honeycutt <jhoneycutt@apple.com>
CygwinDownloader fails to install necessary packages
https://bugs.webkit.org/show_bug.cgi?id=20075
Reviewed by Mark Rowe.
- CygwinDownloader/cygwin-downloader.zip: Rebuilt after two broken mirrors removed in r34116. Set MIME type to application/octet-stream.
- 11:20 PM Changeset in webkit [35213] by
-
- 2 edits in trunk/WebKitTools
2008-07-16 Jon Honeycutt <jhoneycutt@apple.com>
CygwinDownloader's make-zip.sh script fails
https://bugs.webkit.org/show_bug.cgi?id=20074
Reviewed by Mark Rowe.
- CygwinDownloader/cygwin-downloader.py:
- 11:17 PM Changeset in webkit [35212] by
-
- 2 edits in trunk/WebCore
2008-07-16 Jon Honeycutt <jhoneycutt@apple.com>
REGRESSION: Can't create windowless plug-in with Flash 9
https://bugs.webkit.org/show_bug.cgi?id=20070
Reviewed by Mark Rowe.
- plugins/win/PluginPackageWin.cpp: (WebCore::PluginPackage::determineQuirks): Reverse argument order; PlatformModuleVersion constructor takes leastSig, mostSig.
- 11:13 PM Changeset in webkit [35211] by
-
- 2 edits in trunk/WebCore
Reviewed by mitz.
Make ATSULayoutParameters a real C++ class
(Give it a destructor to clean up after itself)
(Also use OwnArrayPtr instead of manual member cleanup)
- platform/graphics/mac/FontMac.mm: (WebCore::ATSULayoutParameters::ATSULayoutParameters): (WebCore::ATSULayoutParameters::~ATSULayoutParameters): (WebCore::overrideLayoutOperation): (WebCore::ATSULayoutParameters::initialize): (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::floatWidthForComplexText): (WebCore::Font::offsetForPositionForComplexText):
- 11:12 PM Changeset in webkit [35210] by
-
- 2 edits in trunk/WebCore
Reviewed by mitz.
Make ownership of copied UChar buffer clearer
(and more leak-proof) by using a OwnArrayPtr.
No functional changes, thus no tests.
- platform/graphics/mac/FontMac.mm: (WebCore::copyRunForDirectionalOverrideIfNecessary): (WebCore::Font::selectionRectForComplexText): (WebCore::Font::drawComplexText): (WebCore::Font::offsetForPositionForComplexText):
- 10:27 PM Changeset in webkit [35209] by
-
- 3 edits in trunk/JavaScriptCore
Fix JavaScript in 64-bit by using a pointer-sized integer
type in the Register union. Also includes a rename of
the intType constant to IntType.
Rubber-stamped by Geoff Garen.
- VM/Machine.cpp:
(KJS::Machine::initializeCallFrame):
- VM/Register.h:
(KJS::Register::):
(KJS::Register::Register):
- 9:04 PM Changeset in webkit [35208] by
-
- 4 edits1 add in trunk/WebCore
Reviewed by Sam.
Split out TextRun into its own header file.
Re-order members to place all bools together
(to allow compilers to better pack the struct)
No functional changes, thus no tests.
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/Font.h: Moved TextRun into its own file.
- platform/graphics/TextRun.h: Split out from Font.h
- 6:16 PM Changeset in webkit [35207] by
-
- 3 edits3 adds in trunk
2008-07-16 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
AnimationController needs to adjust z-index in the blended
style in case opacity or transform were changed by blending.
Test: transitions/opacity-transition-zindex.html
- page/AnimationController.cpp: (WebCore::AnimationController::updateImplicitAnimations):
- 5:41 PM Changeset in webkit [35206] by
-
- 6 edits in trunk/WebCore
Reviewed by Sam.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=20052
Export the tag & attribute names as string literals for SVGNames/XLinkNames and one property in HTMLNames.
- 5:22 PM Changeset in webkit [35205] by
-
- 5 edits in trunk/LayoutTests
Rubber stamped by Eric.
Update pixel test results for two tests that have been changed.
- 4:34 PM Changeset in webkit [35204] by
-
- 46 edits1 add in trunk/WebCore
Reviewed by Eric.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=10745 (SVGLength object needs some weight loss)
Don't store a context pointer in SVGLength, saving memory.
- 3:47 PM Changeset in webkit [35203] by
-
- 22 edits in trunk
2008-07-16 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
First step toward putting doubles in registers: Turned Register into a
proper abstraction layer. It is no longer possible to cast a Register
to a JSValue*, or a Register& to a JSValue*&, or to access the union
inside a Register directly.
SunSpider reports no change.
In support of this change, I had to make the following mechanical changes
in a lot of places:
- Clients now use explicit accessors to read data out of Registers, and implicit copy constructors to write data into registers.
So, assignment that used to look like
x.u.jsValue = y;
now looks like
x = y;
And access that used to look like
x = y.u.jsValue;
now looks like
x = y.jsValue();
- I made generic flow control specific in opcodes that made their flow control generic by treating a Register& as a JSValue*&. This had the added benefit of removing some exception checking branches from immediate number code.
- I beefed up PropertySlot to support storing a Register* in a property slot. For now, only JSVariableObject's symbolTableGet and symbolTablePut use this functionality, but I expect more clients to use it in the future.
- I changed ArgList to be a buffer of Registers, not JSValue*'s, and I changed ArgList iterator clients to iterate Registers, not JSValue*'s.
WebCore:
2008-07-16 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Support for JavaScriptCore's first step toward putting doubles in
registers: Treat ArgList iterators as Register*'s, not JSValue*'s.
- bindings/js/ScheduledAction.cpp: (WebCore::ScheduledAction::ScheduledAction):
- 2:41 PM Changeset in webkit [35202] by
-
- 2 edits in trunk/JavaScriptCore
Fixed build.
- kjs/JSGlobalObject.cpp:
- 2:24 PM Changeset in webkit [35201] by
-
- 1 edit2 adds in trunk/LayoutTests
Reviewed by Anders Carlsson.
Add missing layout test results.
- 1:37 PM Changeset in webkit [35200] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-16 Kevin McCullough <kmccullough@apple.com>
Reviewed by Sam and Geoff.
<rdar://problem/5958840> Navigating to another page while profiler is
attached results in slow JavaScript for all time.
- The UNLIKELY keeps this from being a sunspider performance regression.
- kjs/JSGlobalObject.cpp: (KJS::JSGlobalObject::~JSGlobalObject): Stop the profiler associated with this exec state.
- 1:19 PM Changeset in webkit [35199] by
-
- 6 edits in trunk/JavaScriptCore
2008-07-16 Sam Weinig <sam@webkit.org>
Reviewed by Steve Falkenburg.
Replace adopting UString constructor in favor of explicit
static adopt method.
- API/JSStringRefCF.cpp: (JSStringCreateWithCFString):
- kjs/StringConstructor.cpp: (KJS::stringFromCharCode):
- kjs/StringPrototype.cpp: (KJS::stringProtoFuncToLowerCase): (KJS::stringProtoFuncToUpperCase): (KJS::stringProtoFuncToLocaleLowerCase): (KJS::stringProtoFuncToLocaleUpperCase):
- kjs/ustring.cpp: (KJS::UString::adopt):
- kjs/ustring.h: (KJS::UString::UString): (KJS::UString::~UString):
- 3:14 AM Changeset in webkit [35198] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon.
http://trolltech.com/developer/task-tracker/index_html?method=entry&id=216179
Fix potential crash (on Qt for Windows port) when performing JavaScript date
conversion.
- kjs/DateMath.cpp: (KJS::getLocalTime): For the Qt port, prefer to use Windows code, i.e. localtime_s() instead of localtime() since the latter might crash (on Windows) given a non-sensible, e.g. NaN, argument.
- 1:24 AM Changeset in webkit [35197] by
-
- 1 edit in trunk/JavaScriptCore/ChangeLog
Fix a typo in ChangeLog.
- 1:20 AM Changeset in webkit [35196] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Anders and Geoff.
https://bugs.webkit.org/show_bug.cgi?id=20023
Failed assertion in PropertyNameArray.cpp
This is already tested by testapi.
- API/JSObjectRef.cpp: (JSPropertyNameAccumulatorAddName): Add the string to identifier table to appeaase PropertyNameArray.
- 1:07 AM Changeset in webkit [35195] by
-
- 5 edits in trunk/JavaScriptCore
Reviewed by Geoff.
Dereference identifiers when deleting a hash table (fixes leaks with private JSGlobalData
objects).
- kjs/JSGlobalData.cpp: (KJS::JSGlobalData::~JSGlobalData):
- kjs/lookup.cpp: (KJS::HashTable::deleteTable):
- kjs/lookup.h:
- kjs/lexer.cpp: (KJS::Lexer::~Lexer) HashTable cannot have a destructor, because check-for-global-initializers complains about having a global constructor then.
- 12:58 AM Changeset in webkit [35194] by
-
- 2 edits in trunk/JavaScriptCore
Reviewed by Geoff.
Check pthread_key_create return value.
This check was helpful when debugging a crash in run-webkit-tests --threaded that happened
because JSGlobalData objects were not deleted, and we were running out of pthread keys soon.
It also looks useful for production builds.
- wtf/ThreadSpecific.h: (WTF::::ThreadSpecific):
