Timeline
Jul 22, 2008:
- 10:10 PM Changeset in webkit [35291] by
-
- 84 edits in trunk
2008-07-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt and Sam Weinig.
Next step toward putting doubles in registers: Prepare the Register class
and its clients for registers that don't contain JSValue*s.
This means a few things:
- Register::jsValue() clients, including ArgList clients, must now supply an ExecState* when accessing an entry in an ArgList, in case the entry will need to create a JSValue* on the fly.
- Register clients that definitely don't want to create a JSValue* on the fly now use different APIs: getJSValue() for clients that know the register contains a JSValue*, and v() for clients who just want a void*.
- I had to change some headers around in order to resolve dependency problems created by using a Register in the ArgList header.
SunSpider reports no change.
JavaScriptGlue:
2008-07-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt and Sam Weinig.
Next step toward putting doubles in registers: Prepare the Register class
and its clients for registers that don't contain JSValue*s.
WebCore:
2008-07-22 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt and Sam Weinig.
Next step toward putting doubles in registers: Prepare the Register class
and its clients for registers that don't contain JSValue*s.
- 8:11 PM Changeset in webkit [35290] by
-
- 5 edits1 move in trunk
WebCore:
2008-07-22 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
<rdar://problem/5788451> toDataURL not implemented for Windows (need mapping of MIME type to UTI)
Add additional support for JPEG and GIF for toDataURL encoding canvases.
- platform/MIMETypeRegistry.cpp: (WebCore::initializeSupportedImageMIMETypesForEncoding):
- platform/graphics/cg/ImageBufferCG.cpp: (WebCore::utiFromMIMEType):
LayoutTests:
2008-07-22 Sam Weinig <sam@webkit.org>
Reviewed by Mark Rowe.
<rdar://problem/5788451> toDataURL not implemented for Windows (need mapping of MIME type to UTI)
Add additional support for JPEG and GIF for toDataURL encoding canvases.
- Turn on and simplify toDataURL-supportedTypes.html to only test for support of mimeTypes and not fail due to differences in image encoders.
- fast/canvas/toDataURL-supportedTypes-expected.txt:
- fast/canvas/toDataURL-supportedTypes.html: Copied from fast/canvas/toDataURL-supportedTypes.html-disabled.
- fast/canvas/toDataURL-supportedTypes.html-disabled: Removed.
- 2:45 PM Changeset in webkit [35289] by
-
- 3 edits2 adds in trunk
<rdar://problem/6004877> internal anchors on this page are not showing up in the AXLinkedUIElements
- 2:28 PM BuildingGtk edited by
- (diff)
- 1:23 PM Changeset in webkit [35288] by
-
- 2 edits in trunk/WebCore
2008-07-22 Anders Carlsson <andersca@apple.com>
Reviewed by Adam.
Allocate the empty StringImpl from the heap.
- platform/text/StringImpl.cpp: (WebCore::StringImpl::empty):
- 10:25 AM Changeset in webkit [35287] by
-
- 4 edits in trunk/WebCore
2008-07-21 Kevin McCullough <kmccullough@apple.com>
Reviewed by Tim.
<rdar://problem/5951532> JSProfiler: Implement heavy (or bottom-up)
view (19228)
- Implement UI for Heavy (Bottom Up) view.
- English.lproj/localizedStrings.js:
- page/JavaScriptProfile.cpp: Expose the ability to get a heavy/tree profile from a profile to the Web Inspector's JavaScript. (WebCore::getHeavyProfileCallback): (WebCore::getTreeProfileCallback): (WebCore::ProfileClass):
- page/inspector/ProfileView.js: Implement the dropdown for changing profile views.
- page/inspector/inspector.css:
- 8:51 AM Changeset in webkit [35286] by
-
- 5 edits in trunk
Reviewed by Adam Roben.
<rdar://problem/5955602> WebKit should support charset name x-windows-949
Test: fast/encoding/char-decoding.html
- platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::registerExtendedEncodingNames): Added support for this name for Firefox compatibility.
- 7:26 AM Changeset in webkit [35285] by
-
- 3 edits1 add in trunk
2008-07-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Alexey Proskuryakov.
Prevent integer overflow when reallocating storage vector for arrays.
Sunspider reports 1.005x as fast (no change expected).
- kjs/JSArray.cpp:
WebCore:
2008-07-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Alexey Proskuryakov.
New test to check that arrays fail gracefully (throw an out of memory exception)
when the vector grows to large.
- manual-tests/array-out-of-memory.html: Added.
Jul 21, 2008:
- 10:52 PM Changeset in webkit [35284] by
-
- 3 edits2 adds in trunk
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=20117
setBaseAndExtent fails to reverse the current selection
Test: editing/selection/setBaseAndExtent-revert-selection.html
- editing/Selection.h: (WebCore::operator==): Compare direction, too.
- 9:35 PM Changeset in webkit [35283] by
-
- 2 edits in trunk/WebKit/wx
wx build fix. Fix pthread linkage under Linux.
- 6:43 PM Changeset in webkit [35282] by
-
- 6 edits in trunk/WebCore
WebCore:
2008-07-21 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Sam Weinig.
Bug 19919: Add selectors' string parsing in CSSParser
https://bugs.webkit.org/show_bug.cgi?id=19919
No functional change.
- css/CSSGrammar.y: Added entry for parsing only a selector.
- css/CSSParser.cpp: (WebCore::CSSParser::CSSParser): (WebCore::CSSParser::parseSelector):
- css/CSSParser.h: Added m_floatingSelector to hold the Selector parsed in parseSelector.
- css/tokenizer.flex: Added "@-webkit-selector" token.
- dom/Node.cpp: (WebCore::Node::querySelector): (WebCore::Node::querySelectorAll): Switched to parseSelector method.
- 6:19 PM Changeset in webkit [35281] by
-
- 2 edits in trunk/WebCore
2008-07-21 Kevin Calhoun <kcalhoun@apple.com>
Reviewed by Adele.
Fix for <rdar://problem/6081160> REGRESSION: Hang loading many pages if QuickTime isn't installed
- platform/graphics/win/QTMovieWin.cpp: (initializeSupportedTypes): Do a Quicktime version minimum version check. (QTMovieWin::initializeQuickTime): Store the Quicktime version globally so in can be used in initializeSupportedTypes as well.
- 6:09 PM Changeset in webkit [35280] by
-
- 2 edits in trunk/WebCore
2008-07-21 Kevin Calhoun <kcalhoun@apple.com>
Reviewed by Adele.
Fix for <rdar://problem/5713336> <video> and <audio> elements that use a autoplay attribute fail to start playing when returning back to page
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::willSaveToCache): Reset the ready state to DATA_UNAVAILABLE when saving to the cache so that everything starts back up normally when the page is retrieved from the cache.
- 6:06 PM Changeset in webkit [35279] by
-
- 2 edits in trunk/WebCore
Reviewed by Mark Rowe.
Remove unused interface declaration.
- platform/network/mac/ResourceHandleMac.mm:
- 6:05 PM Changeset in webkit [35278] by
-
- 12 edits in trunk
<rdar://problem/6091287> Revamp the handling of CFBundleShortVersionString to be fixed at the major component of the version number.
Reviewed by Sam Weinig.
- 6:02 PM Changeset in webkit [35277] by
-
- 5 edits in trunk/WebCore
2008-07-21 Kevin Calhoun <kcalhoun@apple.com>
Reviewed by Adele.
Fix for <rdar://problem/6031039> don't disable track-types when media is in a standalone document
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::inMediaDocument): Added.
- platform/graphics/MediaPlayer.h:
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm: (WebCore::MediaPlayerPrivate::updateStates):
- platform/graphics/win/MediaPlayerPrivateQuickTimeWin.cpp: (WebCore::MediaPlayerPrivate::updateStates):
- 5:41 PM Changeset in webkit [35276] by
-
- 2 edits in trunk/WebCore
2008-07-21 Anders Carlsson <andersca@apple.com>
Reviewed by Jon.
Don't allow requests to be made when the document loader is stopping all loaders.
- plugins/PluginView.cpp: (WebCore::PluginView::load):
- 4:07 PM Changeset in webkit [35275] by
-
- 3 edits2 adds in trunk
WebKit/mac:
2008-07-21 Anders Carlsson <andersca@apple.com>
Reviewed by Geoff.
<rdar://problem/5820667>
CrashTracer: [USER] 3759 crashes in Safari at FrameLoader::activeDocumentLoader const + 6 while canceling plug-in load
Don't allow URLs to be loaded in response to an NPP_DestroyStream that happens when tearing down the plug-in.
- Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):
LayoutTests:
2008-07-21 Anders Carlsson <andersca@apple.com>
Reviewed by Geoff.
<rdar://problem/5820667>
CrashTracer: [USER] 3759 crashes in Safari at FrameLoader::activeDocumentLoader const + 6 while canceling plug-in load
- http/tests/plugins/geturlnotify-from-npp-destroystream-expected.txt: Added.
- http/tests/plugins/geturlnotify-from-npp-destroystream.html: Added.
- 1:23 PM Changeset in webkit [35274] by
-
- 3 edits in trunk/WebCore
2008-07-20 Maxime Britto <britto@apple.com>
Reviewed by John Sullivan.
[PFR] <rdar://problem/6080639> New middle click scrolling speed seems much slower than in FF
Accelerate and enhance the smoothness of the pan scrollling.
- page/EventHandler.cpp: Changed the TimerInterval from 0.1 to 0.05. The scrolling is way more fluid like this.
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::panScrollFromPoint): Differentiate the speed within a 200 pixel side square, around the original click location to the speed for farther distances. This way we allow easyier handle when we are close to the center and very fast scrolling when we go far from the original point.
- 1:16 PM Changeset in webkit [35273] by
-
- 2 edits4 adds in trunk
2008-07-18 David Hyatt <hyatt@apple.com>
Change the cached clip rects to not assume they should be infinite when the root layer has been
shifted as the result of a transformation.
Reviewed by Maciej
Added fast/transforms/overflow-with-transform.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::calculateClipRects):
- 1:15 PM Changeset in webkit [35272] by
-
- 5 edits2 adds in trunk
Reviewed by Mitz.
https://bugs.webkit.org/show_bug.cgi?id=19966
CSS variables crash when using hex notation for colors
Support hex colors as values for the css variables.
Test: fast/css/variables/color-hex-test.html
- 11:29 AM Changeset in webkit [35271] by
-
- 2 edits in trunk/WebKitSite
Update Akismet plugin to 2.1.6.
- 11:16 AM Changeset in webkit [35270] by
-
- 225 edits43 adds in trunk/WebKitSite
Update to WordPress 2.6.
- 10:43 AM Changeset in webkit [35269] by
-
- 2 edits in trunk/JavaScriptCore
Add Vector::find
This is a convenience wrapper around std::find.
Reviewed by Anders Carlsson.
- wtf/Vector.h:
- 8:13 AM Changeset in webkit [35268] by
-
- 2 edits in trunk/WebKit/mac
<rdar://problem/5624143> WebView printing doesn't work correctly in x86_64
Fix the return type of an NSView method that we override so that the correct data type is used in 64-bit.
This prevents a garbage value being used for the scale factor that the NSView print machinery applies.
Reviewed by Adam Roben.
- WebView/WebHTMLView.mm:
- 8:13 AM Changeset in webkit [35267] by
-
- 2 edits in trunk/WebKit/mac
Fix CallDelegateReturningFloat for x86_64.
The x86_64 Objective-C runtime only uses objc_msgSend_fpret for
long double return values. For float return values the standard
objc_msgSend is used, as on ppc and ppc64.
Reviewed by Adam Roben.
- WebView/WebView.mm: Use objc_msgSend_float_return as the name of our version of
objc_msgSend with the correct return type. We can no longer call it objc_msgSend_fpret
as that method is defined by the Objective-C runtime for x86_64.
(CallDelegateReturningFloat):
- 7:45 AM Changeset in webkit [35266] by
-
- 9 edits3 deletes in trunk
Roll out r35261
- 6:47 AM Changeset in webkit [35265] by
-
- 2 edits in trunk/WebCore
2008-07-21 Simon Hausmann <Simon Hausmann>
Reviewed by Holger.
Fix drawing of windowless plugins on Windows with the Qt port by
avoiding the reset of the translation of the HDC to 0, 0.
- 6:46 AM Changeset in webkit [35264] by
-
- 2 edits in trunk/WebCore
2008-07-21 Simon Hausmann <Simon Hausmann>
Reviewed by Holger.
Fix rendering of transparent windowless netscape plugins by passing
the right conversion parameter to QPixmap::fromWinHBITMAP when
converting from HBITMAP to QPixmap.
- 6:46 AM Changeset in webkit [35263] by
-
- 2 edits in trunk/WebCore
2008-07-21 Simon Hausmann <Simon Hausmann>
Reviewed by Holger.
In the implementation of getValue for NPNVnetscapeWindow treat
windowHandleForPlatformWidget on the return value of
containingWindow() to receive the correct HWND for the Qt port.
- 6:46 AM Changeset in webkit [35262] by
-
- 2 edits in trunk/WebCore
2008-07-21 Simon Hausmann <Simon Hausmann>
Reviewed by Holger.
Fix windowHandleForPlatformWidget to return 0 as HWND if we don't have
a QWidget. This can happen on page/view destruction for example.
- 2:34 AM Changeset in webkit [35261] by
-
- 12 edits in trunk
WebCore:
2008-07-21 Anatoli Papirovski <apapirovski@mac.com>
Reviewed by Dave Hyatt.
Fix for https://bugs.webkit.org/show_bug.cgi?id=14346
Modified the css parser:
- not to fail when closing braces are not found for a declaration at the end of the file
- not to accept "!important fail" as valid
- to keep accepting @import when it comes after invalid @ rules
- not to drop the whole @media block when there's an error before the closing brace + some other minor css parsing revisions.
- css/CSSGrammar.y:
LayoutTests:
2008-07-21 Anatoli Papirovski <apapirovski@mac.com>
Reviewed by Dave Hyatt.
Updated layout CSS2.1 test suite tests related to css parsing:
https://bugs.webkit.org/show_bug.cgi?id=14346
- platform/mac/css2.1/t040105-import-01-b-expected.checksum:
- platform/mac/css2.1/t040105-import-01-b-expected.png:
- platform/mac/css2.1/t040105-import-01-b-expected.txt:
- platform/mac/css2.1/t0402-syntax-05-f-expected.checksum:
- platform/mac/css2.1/t0402-syntax-05-f-expected.png:
- platform/mac/css2.1/t0402-syntax-05-f-expected.txt:
- platform/mac/css2.1/t0402-syntax-06-f-expected.checksum:
- platform/mac/css2.1/t0402-syntax-06-f-expected.png:
- platform/mac/css2.1/t0402-syntax-06-f-expected.txt:
Jul 20, 2008:
- 8:39 PM Changeset in webkit [35260] by
-
- 2 edits in trunk/WebCore
Touch file to force rebuild for vsprops change.
- WebCorePrefix.h:
- 8:38 PM Changeset in webkit [35259] by
-
- 2 edits in trunk/WebKitLibraries
Build fix.
- win/tools/vsprops/common.vsprops:
- 6:37 PM Changeset in webkit [35258] by
-
- 1 edit1 add in trunk/LayoutTests
Whoops, forgot to commit expected output for this test.
RS=Dan Bernstein
- 4:39 PM Changeset in webkit [35257] by
-
- 2 edits in trunk/WebCore
2008-07-20 Sam Weinig <sam@webkit.org>
Remove extra space Oliver Hunt left in.
- page/Console.cpp: (WebCore::Console::reportException): (WebCore::Console::reportCurrentException):
- 2:31 PM Changeset in webkit [35256] by
-
- 2 edits in trunk/WebCore
Bug 19757: Crash when an ondragstart handler hides the element
<https://bugs.webkit.org/show_bug.cgi?id=19757>
Reviewed by Dan Bernstein.
The solution to this is problem is just to null check the renderer
immediately before launching the system drag, and terminate the
drag if the renderer is gone.
- 1:48 PM Changeset in webkit [35255] by
-
- 6 edits4 adds in trunk
Reviewed by Oliver.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=12171
Remove manual SVG property <-> XML attribute synchronization in SVGPolyElement.
Added svg/custom/poly-points-attribute-changes.svg (testcase from Rob)
- 1:40 PM Changeset in webkit [35254] by
-
- 6 edits in trunk/WebCore
Reviewed by Oliver.
Cleanup JSSVGPODTypeWrapper code.
- 5:43 AM Changeset in webkit [35253] by
-
- 28 edits2 adds in trunk
Bug 15979: Console logs in a database callback lose line number information
<https://bugs.webkit.org/show_bug.cgi?id=15979>
Reviewed by Mark Rowe
The problem was that there were multiple versions of the logic to
log an exception to the console, many of which were incorrect. We
resolve this by making one single shared reportException method,
which handles the exceptions correctly.
This improves fidelity of callback errors, and ensures that
exceptions thrown in timer callbacks correctly report line numbers,
etc.
Test: fast/js/exceptions-thrown-in-callbacks.html
- 4:46 AM Changeset in webkit [35252] by
-
- 2 edits in trunk/WebCore
Rubber stamped by Oliver.
Another attempt to fix the win build.
- 2:24 AM Changeset in webkit [35251] by
-
- 2 edits in trunk/WebCore
Reviewed by David Kilzer.
Fix high CPU usage on testmyiphone.com.
- Made the logic for determining when to stop looking for meta charset more strainghtforward. Previously, this happened if a tag that's disallowed in HEAD was seen past the first 512 bytes. Now, the algorithm bails out at the boundary if we are lo longer in HEAD (i.e, an offending tag was seen at any point before).
- The above change made one of our regression tests fail, because it had its <meta> declaration past the 512 byte boundary. Fixed it by raising the boundary to 1024 bytes.
- Made the algorithm bail out quickly if a comment that's not in HEAD crosses the boundary.
- Moved a check for XML content type out of the loop.
- loader/TextResourceDecoder.cpp: (WebCore::TextResourceDecoder::checkForHeadCharset):
- 12:05 AM FAQ edited by
- (diff)
Jul 19, 2008:
- 10:29 PM Changeset in webkit [35250] by
-
- 8 edits in trunk
Bug 20104: Exception in tables/mozilla_expected_failures/bugs/bug92868_1.html includes the equals operator in the quoted expression
<https://bugs.webkit.org/show_bug.cgi?id=20104>
Reviewed by Cameron Zwarich
To make this correct we make the dot and bracket assign nodes emit the information to indicate
the failure range is the dot/bracket accessor.
- 3:05 PM Changeset in webkit [35249] by
-
- 2 edits in trunk/WebCore
Attempt to fix windows build.
- 8:46 AM Changeset in webkit [35248] by
-
- 116 edits1 add in trunk/WebCore
Reviewed by Oliver & parts by Eric.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=20051
Rewrite animated property concept without heavy macro usage, replace by a templatified solution.
Fewer virtual function calls, no more usage of the tear-off's within internal code (synchronization needed it before.)
Jul 18, 2008:
- 9:40 PM Changeset in webkit [35247] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- kjs/JSGlobalObjectFunctions.cpp: (KJS::isStrWhiteSpace):
- 9:11 PM Changeset in webkit [35246] by
-
- 2 edits in trunk/JavaScriptCore
Windows build fix.
- kjs/nodes.h: (KJS::ThrowableExpressionData::ThrowableExpressionData):
- 6:44 PM Changeset in webkit [35245] by
-
- 37 edits2 adds in trunk
Bug 18774: SQUIRRELFISH: print meaningful error messages <https://bugs.webkit.org/show_bug.cgi?id=18774>
<rdar://problem/5769353> SQUIRRELFISH: JavaScript error messages are missing informative text
Reviewed by Cameron Zwarich
Add support for decent error messages in JavaScript. This patch achieves this by providing
ensuring the common errors and exceptions have messages that provide the text of expression
that trigger the exception. In addition it attaches a number of properties to the exception
object detailing where in the source the expression came from.
- 6:36 PM Changeset in webkit [35244] by
-
- 8 edits3 adds in trunk
2008-07-18 Maxime Britto <britto@apple.com>
Reviewed by Adele.
Fixed <rdar://problem/6049803>
Prevent the autoscroll to trigger in WebClips when starting or hovering on an editable field.
Test: fast/events/autoscroll-with-non-scrollable-parent.html
- ChangeLog:
- page/EventHandler.cpp: Edited (WebCore::EventHandler::handleMousePressEvent): changed the name of the funtion called to canBeProgramaticallyScrolled() (WebCore::EventHandler::handleMouseDraggedEvent): prevent the autoscroll to keep looking for a renderer when it's already triggered
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::scrollRectToVisible): verifies that the top layer can be programmatically scrolled before asking him to make the rect visible
- rendering/RenderListBox.h: (WebCore::RenderListBox::canBeProgramaticallyScrolled):
- rendering/RenderObject.cpp: (WebCore::RenderObject::canBeProgramaticallyScrolled): Edited : For the 3rd case we want document's renderer to have scrollbar as it's the top layer (WebCore::RenderObject::hasScrollableView): Verifies that the Object has a view with scrollBars
- rendering/RenderObject.h: Renamed shouldAutosroll() for canBeProgramaticallyScrolled()
- rendering/RenderTextControl.h: (WebCore::RenderTextControl::canBeProgramaticallyScrolled):
2008-07-18 Adele Peterson & Maxime Britto <britto@apple.com>
Reviewed by Adele.
Test for <rdar://problem/6049803> Autoscroll triggered on no scrolling iframes
- ChangeLog:
- fast/events/autoscroll-with-non-scrollable-parent-expected.txt: Added.
- fast/events/autoscroll-with-non-scrollable-parent.html: Added.
- fast/events/resources/big-page-with-input.html: Added.
- 5:22 PM Changeset in webkit [35243] by
-
- 4 edits in trunk/WebCore
2008-07-18 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
<rdar://problem/6087283> Add support for uploading files via XMLHttpRequest
- Overload XMLHttpRequests send() method to accept File tokens.
- bindings/js/JSXMLHttpRequestCustom.cpp: (WebCore::JSXMLHttpRequest::send):
- xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::send):
- xml/XMLHttpRequest.h:
- 3:18 PM Changeset in webkit [35242] by
-
- 34 edits in trunk
2008-07-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Three renames:
"CallTypeNative" => "CallTypeHost"
"code" => "byteCode"
"generatedCode" => "generatedByteCode"
JavaScriptGlue:
2008-07-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Three renames:
"CallTypeNative" => "CallTypeHost"
"code" => "byteCode"
"generatedCode" => "generatedByteCode"
- ChangeLog:
- JSObject.cpp: (JSUserObject::getCallData):
WebCore:
2008-07-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Three renames:
"CallTypeNative" => "CallTypeHost"
"code" => "byteCode"
"generatedCode" => "generatedByteCode"
- 3:15 PM Changeset in webkit [35241] by
-
- 2 edits in trunk/WebCore
2008-07-18 Adele Peterson <adele@apple.com>
Reviewed by Dan Bernstein.
I recently made a change to avoid fading media controls in and out if a video element actually only contains audio,
which broke the code that did the same thing for audio elements that contain video (but don't actually display that video).
This change will now check both the media element and the player to decide whether or not to make the controls persistent.
- rendering/RenderMedia.cpp: (WebCore::RenderMedia::updateControlVisibility):
- 3:04 PM Changeset in webkit [35240] by
-
- 2 edits in trunk/WebCore
2008-07-18 Simon Fraser <Simon Fraser>
Reviewed by mitz
Remove braces around single-line conditional.
- css/CSSComputedStyleDeclaration.cpp: (WebCore::computedTransform):
- 2:59 PM Changeset in webkit [35239] by
-
- 5 edits in trunk
2008-07-18 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
getComputedStyle() for -webkit-transform should return
'none' for elements with no renderer, or those with no
transform.
Testcase: LayoutTests/fast/css/computed-style-without-renderer
LayoutTests/fast/css/computed-style-expected.txt
- 2:44 PM Changeset in webkit [35238] by
-
- 2 edits in trunk/WebCore
2008-07-18 Simon Fraser <Simon Fraser>
Reviewed by Dave Hyatt
Fix assertion about creating Length values with percentage types
when blending transforms.
https://bugs.webkit.org/show_bug.cgi?id=20086
- 2:25 PM Changeset in webkit [35237] by
-
- 2 edits in trunk/JavaScriptCore
2008-07-18 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Optimized <= for immediate number cases.
SunSpider reports no overall change, but a 10% speedup on access-nsieve.
- 2:03 PM Changeset in webkit [35236] by
-
- 3 edits in trunk/JavaScriptCore
Fix some casts added in a previous build fix to match the style used
throughout WebKit.
Rubber-stamped by Sam Weinig.
- VM/Machine.cpp:
(KJS::Machine::initializeCallFrame):
- VM/Register.h:
(KJS::Register::Register):
- 11:31 AM Changeset in webkit [35235] by
-
- 2 edits in trunk/LayoutTests
Update expected results for a recently added test to what is seen when running the
full test suite.
- fast/forms/form-and-frame-interaction-retains-values-expected.txt:
- 8:31 AM Changeset in webkit [35234] by
-
- 7 edits in trunk
Bug 19975: [OpenBSD] Patches to enable build of WebKit
2008-07-18 Landry Breuil <landry@openbsd.org>
Bug 19975: [OpenBSD] Patches to enable build of WebKit
Reviewed by David Kilzer.
Support for OpenBSD, mostly threading and libm tweaks.
- kjs/collector.cpp: #include <pthread.h> (KJS::currentThreadStackBase): use pthread_stackseg_np() to get stack base
- kjs/config.h: OpenBSD also provides <pthread_np.h>
- wtf/MathExtras.h: #include <sys/types.h> and <machine/ieee.h> (isfinite), (signbit): as long as we don't have those functions provide fallback implementations
- wtf/Platform.h: Add support for PLATFORM(OPENBSD) and PLATFORM(SPARC64) macro
WebKitTools:
2008-07-18 Landry Breuil <landry@openbsd.org>
Bug 19975: [OpenBSD] Patches to enable build of WebKit
Reviewed by David Kilzer.
- DumpRenderTree/DumpRenderTree.h: OpenBSD doesn't support wide characters.
- 8:21 AM Changeset in webkit [35233] by
-
- 2 edits in trunk/WebKitSite
Fixed indentation of example code for C++ pointers/references!
- coding/coding-style.html:
- 8:15 AM Changeset in webkit [35232] by
-
- 2 edits in trunk/WebKitSite
2008-07-18 Robert Blaut <webkit@blaut.biz>
Reviewed by David Kilzer.
Fix for <https://bugs.webkit.org/show_bug.cgi?id=12313>
Added code style guidelines for multi-line boolean expressions
- coding/coding-style.html:
