Timeline



Jul 28, 2008:

5:37 PM Changeset in webkit [35417] by andersca@apple.com
  • 3 edits in trunk/WebCore

2008-07-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Based on a patch from Dimcho Balev.


Windows part of


​https://bugs.webkit.org/show_bug.cgi?id=18676
<rdar://problem/6106578>
Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs

  • plugins/PluginStream.cpp: (WebCore::PluginStream::wantsAllStreams):
  • plugins/PluginStream.h:
4:38 PM Changeset in webkit [35416] by jchaffraix@webkit.org
  • 11 edits
    2 adds in branches/XBL2

WebCore:

2008-07-28 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Bug 20196: [XBL] Re-enable CSS binding attachment

  • Re-enable legacy CSS attachment code.
  • Add XBLBindingManager bits so that it also creates / removes the required bindings.
  • Renamed '-webkit-binding' property to 'binding' (the name in the specification)

Test: fast/xbl/xbl-css-attachment.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
  • css/CSSParser.cpp: (WebCore::CSSParser::parseValue):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): (WebCore::CSSStyleSelector::removeBindings): Added remove bindings and the style information associated.
  • css/CSSStyleSelector.h:
  • dom/Element.cpp: (WebCore::Element::hasBinding): Update the style as it will cause binding updates.
  • rendering/style/RenderStyle.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator==): (WebCore::BindingURI::BindingURI):
  • rendering/style/RenderStyle.h:
  • xbl/XBLBindingManager.cpp: (WebCore::XBLBindingManager::addBinding): Limit to one binding per element with the same uri as the CSS attachment code can be hit twice.

LayoutTests:

2008-07-28 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Test case for bug 20196: [XBL] Re-enable CSS binding attachment

  • fast/xbl/xbl-css-attachment-expected.txt: Added.
  • fast/xbl/xbl-css-attachment.html: Added.
4:34 PM Changeset in webkit [35415] by beidson@apple.com
  • 6 edits
    4 adds in trunk

WebCore:

2008-07-28 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

Test: security/autocomplete-cleared-on-back.html

<rdar://problem/6093281> - autocomplete="off" should work when going back

Taken care of in two ways:
1 - Listening for the page cache notification to clear the form, in cases where the page

is being restored from the page cache

2 - Not saving such form elements when doing the normal "save state" to a history item,

for cases with no page cache

  • html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::~HTMLFormElement): (WebCore::HTMLFormElement::parseMappedAttribute): (WebCore::HTMLFormElement::didRestoreFromCache): (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): (WebCore::HTMLFormElement::didMoveToNewOwnerDocument):
  • html/HTMLFormElement.h:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::~HTMLInputElement): (WebCore::HTMLInputElement::setInputType): (WebCore::HTMLInputElement::saveState): (WebCore::HTMLInputElement::parseMappedAttribute): (WebCore::HTMLInputElement::needsCacheCallback): (WebCore::HTMLInputElement::registerForCacheCallbackIfNeeded): Only register if the type or attribute indicate we should. (WebCore::HTMLInputElement::unregisterForCacheCallbackIfNeeded): Only unregister if both the type and attribute are clear of needing registration. (WebCore::HTMLInputElement::didRestoreFromCache): (WebCore::HTMLInputElement::willMoveToNewOwnerDocument): (WebCore::HTMLInputElement::didMoveToNewOwnerDocument):
  • html/HTMLInputElement.h:

LayoutTests:

2008-07-28 Brady Eidson <​beidson@apple.com>

Reviewed by Sam Weinig

<rdar://problem/6093281> - autocomplete="off" should work when going back

  • security/autocomplete-cleared-on-back-expected.txt: Added.
  • security/autocomplete-cleared-on-back.html: Added.
  • security/resources: Added.
  • security/resources/autocomplete-cleared-on-back2.html: Added.
3:50 PM Changeset in webkit [35414] by hyatt@apple.com
  • 14 edits
    16 adds in trunk

2008-07-28 David Hyatt <​hyatt@apple.com>

Add support for CSS variable declaration blocks.

Reviewed by Sam

Added tests in fast/css/variables.

  • css/CSSGrammar.y:
  • css/CSSMutableStyleDeclaration.h: (WebCore::CSSMutableStyleDeclaration::isMutableStyleDeclaration):
  • css/CSSParser.cpp: (WebCore::CSSParser::addVariableDeclarationBlock):
  • css/CSSParser.h:
  • css/CSSProperty.cpp: (WebCore::CSSProperty::cssText):
  • css/CSSPropertyNames.in:
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::addMatchedDeclaration): (WebCore::CSSStyleSelector::resolveVariablesForDeclaration):
  • css/CSSStyleSelector.h:
  • css/CSSValueList.h: (WebCore::CSSValueList::isValueList):
  • css/CSSVariablesDeclaration.cpp: (WebCore::CSSVariablesDeclaration::CSSVariablesDeclaration): (WebCore::CSSVariablesDeclaration::getVariableValue): (WebCore::CSSVariablesDeclaration::removeVariable): (WebCore::CSSVariablesDeclaration::addParsedVariable): (WebCore::CSSVariablesDeclaration::getParsedSimpleVariable): (WebCore::CSSVariablesDeclaration::getParsedComplexVariable):
  • css/CSSVariablesDeclaration.h: (WebCore::CSSVariablesDeclaration::create):
  • css/StyleBase.cpp: (WebCore::StyleBase::cssText):
  • css/StyleBase.h: (WebCore::StyleBase::isValueList): (WebCore::StyleBase::isMutableStyleDeclaration):
3:46 PM Changeset in webkit [35413] by andersca@apple.com
  • 4 edits
    4 adds in trunk

../../../../../../LayoutTests:

2008-07-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam.

<rdar://problem/6098335>
​https://bugs.webkit.org/show_bug.cgi?id=20150


Add tests.


  • http/tests/xmlhttprequest/resources/forbidden.txt: Added.
  • http/tests/xmlhttprequest/resources/redirect.php: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-unsafe-redirect.html: Added.

../../../../../../WebCore:

2008-07-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam.

<rdar://problem/6098335>
​https://bugs.webkit.org/show_bug.cgi?id=20150


Handle willSendRequest correctly.

  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::willSendRequest): Make sure to keep the previous URL around so we know when to call willSendRequest.


  • xml/XMLHttpRequest.cpp: (WebCore::XMLHttpRequest::processSyncLoadResults): Abort if we don't have access to the response URL.


(WebCore::XMLHttpRequest::willSendRequest):
Dispatch a network error if we can't access the new URL.

2:15 PM Changeset in webkit [35412] by jchaffraix@webkit.org
  • 4 edits
    1 add in branches/XBL2/WebCore

2008-07-28 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Bug 20171: [XBL] Add <binding> 'element' attribute

  • DerivedSources.make: Add attrs file.
  • GNUmakefile.am: Ditto.
  • WebCore.pro: Ditto.
  • xbl/xblattrs.in: Added.
1:04 PM Changeset in webkit [35411] by ggaren@apple.com
  • 25 edits in trunk

JavaScriptCore:

2008-07-28 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Renamed "ConstructTypeNative" => "ConstructTypeHost".

WebCore:

2008-07-28 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Sam Weinig.

Renamed "ConstructTypeNative" => "ConstructTypeHost".

12:23 PM Changeset in webkit [35410] by andersca@apple.com
  • 2 edits in trunk

Add radar number

12:20 PM Changeset in webkit [35409] by andersca@apple.com
  • 10 edits in trunk

../../../../../../WebCore:

2008-07-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Based on a patch by Dimcho Balev.

​https://bugs.webkit.org/show_bug.cgi?id=18676
Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs


  • bridge/npapi.h: Add new enum values.


  • loader/NetscapePlugInStreamLoader.cpp: (WebCore::NetscapePlugInStreamLoader::didReceiveResponse): When the plug-in indicates that it wants all streams to be delivered, don't cancel the stream if an error occurs.


  • loader/NetscapePlugInStreamLoader.h: (WebCore::NetscapePlugInStreamLoaderClient::wantsAllStreams): Add new client method.

../../../../../../WebKit/mac:

2008-07-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Kevin Decker.

Based on a patch by Dimcho Balev.


​https://bugs.webkit.org/show_bug.cgi?id=18676
Plug-In API Proposal: Enable plugins to receive response body when an HTTP error occurs

  • Plugins/WebBaseNetscapePluginStream.h: Add NPP_GetValue pointer.


  • Plugins/WebBaseNetscapePluginStream.mm: (-[WebBaseNetscapePluginStream setPlugin:]): Initialize NPP_GetValue.


(-[WebBaseNetscapePluginStream wantsAllStreams]):
Call NPP_GetValue.


  • Plugins/WebPlugInStreamLoaderDelegate.h:
  • WebCoreSupport/WebNetscapePlugInStreamLoaderClient.h:
  • WebCoreSupport/WebNetscapePlugInStreamLoaderClient.mm: (WebNetscapePlugInStreamLoaderClient::wantsAllStreams): Implement this and call down to the stream.
9:59 AM Changeset in webkit [35408] by andersca@apple.com
  • 2 edits in trunk/WebKit/mac

2008-07-28 Anders Carlsson <​andersca@apple.com>

Reviewed by Adam.

<rdar://problem/6105529>
​https://bugs.webkit.org/show_bug.cgi?id=19659
Turning off plugins causes crash


When an active page has plug-ins, and plug-ins are disabled, they will be stopped and will
end up in a state where they don't have an event handler. Because of this, we need to
check that the plug-in has been started before calling the event handler.


  • Plugins/WebBaseNetscapePluginView.mm: (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendDrawRectEvent:]): (-[WebBaseNetscapePluginView setHasFocus:]): (-[WebBaseNetscapePluginView mouseDown:]): (-[WebBaseNetscapePluginView mouseUp:]): (-[WebBaseNetscapePluginView mouseEntered:]): (-[WebBaseNetscapePluginView mouseExited:]): (-[WebBaseNetscapePluginView handleMouseMoved:]): (-[WebBaseNetscapePluginView mouseDragged:]): (-[WebBaseNetscapePluginView scrollWheel:]): (-[WebBaseNetscapePluginView keyUp:]): (-[WebBaseNetscapePluginView keyDown:]): (-[WebBaseNetscapePluginView flagsChanged:]): (-[WebBaseNetscapePluginView cut:]): (-[WebBaseNetscapePluginView copy:]): (-[WebBaseNetscapePluginView paste:]): (-[WebBaseNetscapePluginView selectAll:]): (-[WebBaseNetscapePluginView drawRect:]): (-[WebBaseNetscapePluginView inputContext]):
12:37 AM Changeset in webkit [35407] by mrowe@apple.com
  • 2 edits in trunk/WebKitSite

2008-07-28 Robert Blaut <​webkit@blaut.biz>

Reviewed by Mark Rowe.

Fix for bug: Website provides no guidance on debugging
<​https://bugs.webkit.org/show_bug.cgi?id=3643>

  • building/debug.html: added info about Xcode Debugging Guide.

Jul 27, 2008:

3:03 PM Changeset in webkit [35406] by weinig@apple.com
  • 5 edits
    6 adds in trunk

WebCore:

2008-07-27 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=20176
querySelectorAll id optimization no longer working

Turn the querySelector/querySelectorAll id optimization back on
for only strict and almost strict mode. In quirks mode, the optimiztion
won't work as the id match is not case sensitive.

Tests: fast/dom/SelectorAPI/caseID-almost-strict.html

fast/dom/SelectorAPI/caseID-strict.html
fast/dom/SelectorAPI/caseID.html

  • dom/Node.cpp: (WebCore::Node::querySelector): (WebCore::Node::querySelectorAll):
  • dom/SelectorNodeList.cpp: (WebCore::createSelectorNodeList):
  • dom/SelectorNodeList.h:

LayoutTests:

2008-07-27 Sam Weinig <​sam@webkit.org>

Reviewed by Oliver Hunt.

Tests for ​https://bugs.webkit.org/show_bug.cgi?id=20176
querySelectorAll id optimization no longer working

  • fast/dom/SelectorAPI/caseID-almost-strict-expected.txt: Added.
  • fast/dom/SelectorAPI/caseID-almost-strict.html: Added.
  • fast/dom/SelectorAPI/caseID-expected.txt: Added.
  • fast/dom/SelectorAPI/caseID-strict-expected.txt: Added.
  • fast/dom/SelectorAPI/caseID-strict.html: Added.
  • fast/dom/SelectorAPI/caseID.html: Added.
2:34 PM Changeset in webkit [35405] by ddkilzer@apple.com
  • 2 edits in trunk/WebKit/qt

Fix Qt build failure.

  • Api/qwebframe.h: (QWebFrame::setScrollOffset): Make argument const.
2:27 PM Changeset in webkit [35404] by ddkilzer@apple.com
  • 3558 edits in trunk/LayoutTests

Set svn:mime-type to image/png.

2:08 PM Changeset in webkit [35403] by ddkilzer@apple.com
  • 9 edits
    3 adds in trunk

WebCore:

2008-07-21 Anatoli Papirovski <​apapirovski@mac.com>

Reviewed by Dave Hyatt.

Fix for ​https://bugs.webkit.org/show_bug.cgi?id=14346
Modified the css parser:

  • not to fail when closing braces are not found for a declaration at the end of the file
  • not to accept "!important fail" as valid
  • to keep accepting @import when it comes after invalid @ rules
  • not to drop the whole @media block when there's an error before the closing brace + some other minor css parsing revisions.

CSSGrammar.y tweaked by David Kilzer to fix Tiger builds.

  • css/CSSGrammar.y:

LayoutTests:

2008-07-21 Anatoli Papirovski <​apapirovski@mac.com>

Reviewed by Dave Hyatt.

Updated layout CSS2.1 test suite tests related to css parsing:
​https://bugs.webkit.org/show_bug.cgi?id=14346

  • platform/mac/css2.1/t040105-import-01-b-expected.checksum:
  • platform/mac/css2.1/t040105-import-01-b-expected.png:
  • platform/mac/css2.1/t040105-import-01-b-expected.txt:
  • platform/mac/css2.1/t0402-syntax-05-f-expected.checksum:
  • platform/mac/css2.1/t0402-syntax-05-f-expected.png:
  • platform/mac/css2.1/t0402-syntax-05-f-expected.txt:
  • platform/mac/css2.1/t0402-syntax-06-f-expected.checksum:
  • platform/mac/css2.1/t0402-syntax-06-f-expected.png:
  • platform/mac/css2.1/t0402-syntax-06-f-expected.txt:
3:43 AM Changeset in webkit [35402] by jmalonzo@webkit.org
  • 5 edits in trunk/WebCore

2008-07-27 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Eric Seidel.

Use --outputDir instead of --output when invoking make_names.pl
There's no option named "output" in make_names.pl

  • GNUmakefile.am:
  • WebCore.pro:
  • DerivedSources.make: Remove --output. Not necessary here.
  • bindings/scripts/generate-bindings.pl: Rename --outputdir to --outputDir for consistency with make_names.pl
3:28 AM HackingGtk edited by jserv.tw@gmail.com
(diff)

Jul 26, 2008:

11:56 PM Changeset in webkit [35401] by mrowe@apple.com
  • 3 edits in trunk/LayoutTests

2008-07-26 Mark Rowe <​mrowe@apple.com>

Update some layout test results.

  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/domListEnumeration-expected.txt:
11:08 PM Changeset in webkit [35400] by mrowe@apple.com
  • 2 edits in trunk/WebKitSite

2008-07-26 Mark Rowe <​mrowe@apple.com>

Rubber-stamped by Oliver Hunt.

Update the Squirrelfish bytecode documentation.

  • specs/squirrelfish-bytecode.html:
11:02 PM Changeset in webkit [35399] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-07-26 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Eric Seidel.

​http://bugs.webkit.org/show_bug.cgi?id=18694
[CAIRO] Problem with rotation in a given matrix in SVG

Changed values given to AffineTransform.

  • platform/graphics/cairo/AffineTransformCairo.cpp: (WebCore::AffineTransform::AffineTransform): (WebCore::AffineTransform::setMatrix):
11:00 PM Changeset in webkit [35398] by jmalonzo@webkit.org
  • 3 edits in trunk

2008-07-25 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Mark Rowe.

Copy the way Gtk detects jpeglib. Hinted by Wouter Bolsterlee.

[Gtk] Improve detection jpeglib
​https://bugs.webkit.org/show_bug.cgi?id=17865

  • GNUmakefile.am:
  • configure.ac:
10:59 PM Changeset in webkit [35397] by mrowe@apple.com
  • 3 edits in trunk/WebKit/qt

2008-07-26 Marc Ordinas i Llopis <​marc.ordinasillopis@collabora.co.uk>

Reviewed by Simon Hausmann.

​https://bugs.webkit.org/show_bug.cgi?id=20010
[Qt] Add API access to scrolling

  • Api/qwebframe.cpp: Added access to a frame scroll offset. (QWebFrame::scroll): (QWebFrame::scrollOffset): (QWebFrame::setScrollOffset):
  • Api/qwebframe.h:
10:58 PM Changeset in webkit [35396] by mitz@apple.com
  • 3 edits in trunk/LayoutTests

Rubber-stamped by Sam Weinig.

  • update test and expected results for attributes added to HTMLFormElement and HTMLSelectElement.
  • fast/dom/domListEnumeration-expected.txt:
  • fast/dom/resources/domListEnumeration.js:
10:53 PM Changeset in webkit [35395] by mrowe@apple.com
  • 2 edits in trunk/WebKitSite

2008-07-26 Robert Blaut <​webkit@blaut.biz>

Reviewed by Eric Seidel.

Fix for <​https://bugs.webkit.org/show_bug.cgi?id=19712>
Corrected validation errors in main.css file.

  • css/main.css:
10:52 PM Changeset in webkit [35394] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-07-26 Jan Michael Alonzo <​jmalonzo@webkit.org>

Reviewed by Mark Rowe.

Call curl_global_cleanup() to release resources acquired by curl_global_init()

  • platform/network/curl/ResourceHandleManager.cpp: (WebCore::ResourceHandleManager::~ResourceHandleManager):
10:49 PM Changeset in webkit [35393] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-07-26 Marc Ordinas i Llopis <​marc.ordinasillopis@collabora.co.uk>

Reviewed by Simon Hausmann.

Bug 18938: [GTK] Plugins not resized
​https://bugs.webkit.org/show_bug.cgi?id=18938

  • plugins/PluginView.cpp: (WebCore::PluginView::setFrameGeometry): When viewing a full-page plugin in unix, geometry changes have to be passed to the plugin.
10:44 PM Changeset in webkit [35392] by mrowe@apple.com
  • 6 edits
    1 add in trunk/WebCore

2008-07-26 Keishi Hattori <​casey.hattori@gmail.com>

Reviewed by Adam Roben.

Add console.time/timeEnd.
​https://bugs.webkit.org/show_bug.cgi?id=19159

  • manual-tests/inspector/console-time.html: Added. Test cases for console.time/timeEnd.
  • page/Console.cpp: (WebCore::Console::time): Added. (WebCore::Console::timeEnd): Added.
  • page/Console.h:
  • page/Console.idl: Added console.time/timeEnd.
  • page/InspectorController.cpp: (WebCore::InspectorController::startTiming): Added. (WebCore::InspectorController::stopTiming): Added.
  • page/InspectorController.h:
10:40 PM Changeset in webkit [35391] by mrowe@apple.com
  • 3 edits in trunk/WebCore

2008-07-26 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Nikolas Zimmermann.

Fixes rendering issues with gradients in SVG/Cairo.

  • platform/graphics/cairo/PathCairo.cpp: (WebCore::Path::boundingRect):
  • svg/graphics/cairo/SVGPaintServerGradientCairo.cpp: (WebCore::applyStrokeStyleToContext): (WebCore::SVGPaintServerGradient::setup):
10:38 PM Changeset in webkit [35390] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-07-26 Dirk Schulze <​vbs85@gmx.de>

Reviewed by Nikolas Zimmermann.

Added pattern-support for SVG in Cairo.

  • svg/graphics/cairo/SVGPaintServerPatternCairo.cpp: (WebCore::applyStrokeStyleToContext): (WebCore::SVGPaintServerPattern::setup):
10:32 PM Changeset in webkit [35389] by mrowe@apple.com
  • 2 edits in trunk/WebKitSite

2008-07-26 Robert Blaut <​webkit@blaut.biz>

Reviewed by Alexey Proskuryakov.

Fix for bug: <​https://bugs.webkit.org/show_bug.cgi?id=18186>
Added notes about unsupported Visual Studio versions.

  • building/tools.html:
10:29 PM Changeset in webkit [35388] by mrowe@apple.com
  • 2 edits in trunk/JavaScriptCore

2008-07-26 Mark Rowe <​mrowe@apple.com>

Speculative fix for the wx build.

  • JavaScriptCoreSources.bkl: Add JSStaticScopeObject.cpp to the list of source files.
10:27 PM Changeset in webkit [35387] by mrowe@apple.com
  • 2 edits in trunk/WebKit/gtk

2008-07-26 Mark Rowe <​mrowe@apple.com>

Build fix. Changes to accommodate newly named/signatured loading methods in WebCore.

  • WebCoreSupport/FrameLoaderClientGtk.cpp: (WebKit::FrameLoaderClient::createFrame):
10:23 PM Changeset in webkit [35386] by mrowe@apple.com
  • 3 edits in trunk/WebKit/qt

2008-07-26 Daniel Jalkut <​jalkut@red-sweater.com>

Build fix. Adjust to updated WebCore FrameLoader method names & signatures.

  • Api/qwebpage.cpp: (QWebPage::triggerAction):
  • WebCoreSupport/FrameLoaderClientQt.cpp: (WebCore::FrameLoaderClientQt::createFrame):
10:20 PM Changeset in webkit [35385] by mrowe@apple.com
  • 2 edits in trunk/WebKitSite

2008-07-26 Robert Blaut <​webkit@blaut.biz>

Reviewed by Eric Seidel.

Fix for <​https://bugs.webkit.org/show_bug.cgi?id=16719>
Removed basic requirements for undetected version of WebKit.

  • quality/reporting.html:
10:18 PM Changeset in webkit [35384] by mrowe@apple.com
  • 2 edits in trunk/WebKitSite

2008-07-26 Robert Blaut <​webkit@blaut.biz>

Reviewed by Adele Petersen.

Fix for bug 7436: Truncated title on webkit DOM page.
<​https://bugs.webkit.org/show_bug.cgi?id=7436>

  • projects/dom/index.html: Added basic project informations.
10:14 PM Changeset in webkit [35383] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-07-26 Keishi Hattori <​casey.hattori@gmail.com>

Reviewed by Adam Roben.

Fixed bug 18540: console.log('multiple', 'strings') quotes all strings after the first
<​https://bugs.webkit.org/show_bug.cgi?id=18540>

  • page/inspector/Console.js: (WebInspector.ConsoleMessage.prototype._format): String arguments are appended without formatting.
10:10 PM Changeset in webkit [35382] by mrowe@apple.com
  • 2 edits in trunk/WebCore

2008-07-26 Anthony Ricaud <​rik24d@gmail.com>

Reviewed by Tim Hatcher.

<​https://bugs.webkit.org/show_bug.cgi?id=17589> Line highlighting should last longer

Restore the fade out effect after highlighting.

  • page/inspector/SourceFrame.js: Add a class for fade-out effects and sets it at the end of highlighting time.
10:08 PM Changeset in webkit [35381] by mrowe@apple.com
  • 13 edits
    20 adds in trunk

2008-07-26 Michelangelo De Simone <​michelangelo@me.com>

Reviewed by Adele Petersen.

Added the simple willValidate attribute to form controls according to
WebForms 2 spec.

URL: ​http://www.w3.org/TR/web-forms-2/#willvalidate

Tests: fast/forms/willvalidate-000.html

fast/forms/willvalidate-001.html
fast/forms/willvalidate-002.html
fast/forms/willvalidate-003.html
fast/forms/willvalidate-004.html
fast/forms/willvalidate-005.html
fast/forms/willvalidate-006.html
fast/forms/willvalidate-007.html
fast/forms/willvalidate-008.html
fast/forms/willvalidate-009.html

  • html/HTMLButtonElement.h: Added willValidate(), always false.
  • html/HTMLButtonElement.idl: willValidate attribute exposed.
  • html/HTMLFieldSetElement.h: Added willValidate(), always false.
  • html/HTMLFieldSetElement.idl: willValidate attribute exposed.
  • html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::willValidate): Added base willValidate() implementation.
  • html/HTMLFormControlElement.h: Added willValidate().
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::willValidate): Added willValidate(), checks for input type.
  • html/HTMLInputElement.h: Added willValidate()
  • html/HTMLInputElement.idl: willValidate attribute exposed.
  • html/HTMLSelectElement.idl: willValidate attribute exposed.
  • html/HTMLTextAreaElement.idl: willValidate attribute exposed.

2008-07-26 Michelangelo De Simone <​m.des@mac.com>

Reviewed by Adele Petersen.

Test suite for the willValidate form controls attribute.

  • fast/forms/willvalidate-000-expected.txt: Added.
  • fast/forms/willvalidate-000.html: Added.
  • fast/forms/willvalidate-001-expected.txt: Added.
  • fast/forms/willvalidate-001.html: Added.
  • fast/forms/willvalidate-002-expected.txt: Added.
  • fast/forms/willvalidate-002.html: Added.
  • fast/forms/willvalidate-003-expected.txt: Added.
  • fast/forms/willvalidate-003.html: Added.
  • fast/forms/willvalidate-004-expected.txt: Added.
  • fast/forms/willvalidate-004.html: Added.
  • fast/forms/willvalidate-005-expected.txt: Added.
  • fast/forms/willvalidate-005.html: Added.
  • fast/forms/willvalidate-006-expected.txt: Added.
  • fast/forms/willvalidate-006.html: Added.
  • fast/forms/willvalidate-007-expected.txt: Added.
  • fast/forms/willvalidate-007.html: Added.
  • fast/forms/willvalidate-008-expected.txt: Added.
  • fast/forms/willvalidate-008.html: Added.
  • fast/forms/willvalidate-009-expected.txt: Added.
  • fast/forms/willvalidate-009.html: Added.
9:21 PM Changeset in webkit [35380] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Build fix.

9:10 PM Changeset in webkit [35379] by mitz@apple.com
  • 3 edits in trunk/LayoutTests

Rubber-stamped by Mark Rowe.

  • platform/win/Skipped: Added fast/text/international/bidi-AN-after-empty-run.html (<rdar://problem/5075790>) and svg/custom/stroke-width-click.svg (<rdar://problem/5539822>).
  • platform/win/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Updated results for the new way path data is dumped after <​http://trac.webkit.org/changeset/34117>.
9:07 PM Changeset in webkit [35378] by mrowe@apple.com
  • 2 edits in trunk/WebCore

Build fix.

8:49 PM Changeset in webkit [35377] by mrowe@apple.com
  • 16 edits in trunk

2008-07-26 Daniel Jalkut <​jalkut@red-sweater.com>

Reviewed by Geoff Garen.

Revised the FrameLoader class to clean up a variety of load methods, and hopefully
move things closer to integrating into a smaller set of load methods. To this
end, I renamed many of the overloaded load() methods to have more meaningful and
easier to search names. I added comments to the header file to provide clues as
to how many of the load methods are being used, and how they fit into the loading
process. I suspect that the renamed methods and comments indicating their present
usage will facilitate easier cleanup by myself and others as inspiration strikes.

Updated clients of FrameLoader where necessary to adapt to the new method names and signatures.

Combined the 3 canLoad() methods into a single canLoad which expresses the
intended logic of the 3 with a single method interface.

Removed unnecessary "treatAsLocal" attribute of CachedResource. It was only called from
one place in FrameLoader.cpp, and it derived at initialization time by calling back to FrameLoader.

Removed unused userGesture parameter to one variant of the urlSelected method, and
moved one of the urlSelected methods so that it lives nearer to its overloaded
sibling.

  • WebCore.base.exp:
  • loader/Cache.cpp: (WebCore::Cache::requestResource):
  • loader/CachedResource.cpp: (WebCore::CachedResource::CachedResource):
  • loader/CachedResource.h: (WebCore::CachedResource::errorOccurred):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::createWindow): (WebCore::FrameLoader::urlSelected): (WebCore::FrameLoader::loadURLIntoChildFrame): (WebCore::FrameLoader::loadPlugin): (WebCore::FrameLoader::loadFrameRequestWithFormState): (WebCore::FrameLoader::loadFrameRequestWithFormAndValues): (WebCore::FrameLoader::loadURL): (WebCore::FrameLoader::loadWithNavigationAction): (WebCore::FrameLoader::load): (WebCore::FrameLoader::loadWithDocumentLoader): (WebCore::FrameLoader::canLoad): (WebCore::FrameLoader::reloadAllowingStaleData): (WebCore::FrameLoader::reload): (WebCore::FrameLoader::continueLoadAfterWillSubmitForm): (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::loadPostRequest): (WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): (WebCore::FrameLoader::loadItem):
  • loader/FrameLoader.h:
  • loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::create):
  • page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):

2008-07-26 Daniel Jalkut <​jalkut@red-sweater.com>

Reviewed by Geoff Garen.

Changes to accommodate newly named/signatured loading methods in WebCore.

  • Plugins/WebNetscapePluginStream.mm: (-[WebNetscapePluginStream initWithRequest:plugin:notifyData:sendNotification:]):
  • Plugins/WebPluginContainerCheck.mm: (-[WebPluginContainerCheck _isForbiddenFileLoad]):
  • WebView/WebPDFView.mm: (-[WebPDFView PDFViewWillClickOnLink:withURL:]):

2008-07-26 Matt Lilek <​webkit@mattlilek.com>

Reviewed by Geoff Garen.

Changes to accommodate newly named/signatured loading methods in WebCore.

  • WebCoreSupport/WebContextMenuClient.cpp: (WebContextMenuClient::searchWithGoogle):
  • WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::loadURLIntoChild):
7:47 PM Changeset in webkit [35376] by weinig@apple.com
  • 2 edits in trunk

Add radar number to ChangeLog

7:45 PM Changeset in webkit [35375] by weinig@apple.com
  • 6 edits
    8 adds in trunk

WebCore:

2008-07-26 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=20122
REGRESSION (r35075-r35110): Cannot enlarge images at Apple Store product page

Use strict parsing when in AlmostStrict mode.

Tests: fast/dom/SelectorAPI/dumpNodeList-almost-strict.html

fast/dom/SelectorAPI/id-fastpath-almost-strict.html
fast/dom/SelectorAPI/id-fastpath-strict.html

  • dom/Node.cpp: (WebCore::Node::querySelector): (WebCore::Node::querySelectorAll):

LayoutTests:

2008-07-26 Sam Weinig <​sam@webkit.org>

Reviewed by Dan Bernstein.

Fix ​https://bugs.webkit.org/show_bug.cgi?id=20122
REGRESSION (r35075-r35110): Cannot enlarge images at Apple Store product page

  • Additionally, fix some errors introduced in old tests.
  • fast/dom/SelectorAPI/dumpNodeList-almost-strict-expected.txt: Added.
  • fast/dom/SelectorAPI/dumpNodeList-almost-strict.html: Added.
  • fast/dom/SelectorAPI/dumpNodeList-expected.txt:
  • fast/dom/SelectorAPI/dumpNodeList.html:
  • fast/dom/SelectorAPI/id-fastpath-almost-strict-expected.txt: Added.
  • fast/dom/SelectorAPI/id-fastpath-almost-strict.html: Added.
  • fast/dom/SelectorAPI/id-fastpath-strict-expected.txt: Added.
  • fast/dom/SelectorAPI/id-fastpath-strict.html: Added.
  • fast/dom/SelectorAPI/resources/id-fastpath-almost-strict.js: Added.
  • fast/dom/SelectorAPI/resources/id-fastpath-strict.js: Added.
  • fast/dom/SelectorAPI/resources/id-fastpath.js:
4:59 PM Changeset in webkit [35374] by mitz@apple.com
  • 1 edit
    2 moves
    2 adds in trunk/LayoutTests
  • move Leopard-only expected failure results back to mac-leopard; these are covered by <rdar://problem/5539818> and <rdar://problem/5539820>.
  • platform/mac-leopard/http: Added.
  • platform/mac-leopard/http/tests: Added.
  • platform/mac-leopard/http/tests/security: Copied from platform/mac/http/tests/security.
  • platform/mac-leopard/security: Copied from platform/mac/security.
  • platform/mac/http/tests/security: Removed.
  • platform/mac/http/tests/security/dataURL: Removed.
  • platform/mac/http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt: Removed.
  • platform/mac/security: Removed.
  • platform/mac/security/block-test-expected.txt: Removed.
4:37 PM Changeset in webkit [35373] by mitz@apple.com
  • 2 edits
    1 copy
    1 move
    1 add
    3 deletes in trunk/LayoutTests

Reviewed by Oliver Hunt.

  • clean up expected layout test results
  • fast/encoding/idn-security-expected.txt: Replaced with LayoutTests/platform/mac/fast/encoding/idn-security-expected.txt, which is the version of the results for platforms that have "newer ICU".
  • platform/mac-leopard/Skipped: Added svg/custom/stroke-width-click.svg.
  • platform/mac-tiger/fast/encoding: Added.
  • platform/mac-tiger/fast/encoding/idn-security-expected.txt: Copied from LayoutTests/fast/encoding/idn-security-expected.txt, as Tiger still needs the "older ICU" version of the results.
  • platform/mac/fast/encoding/idn-security-expected.txt: Removed.
  • platform/mac/svg/custom/stroke-width-click-expected.checksum: Removed pixel results for a text-only test.
  • platform/mac/svg/custom/stroke-width-click-expected.png: Ditto.
  • platform/mac/svg/custom/stroke-width-click-expected.txt: Removed platform-specific results for a text-only test.
1:04 PM Changeset in webkit [35372] by jchaffraix@webkit.org
  • 5 edits
    2 adds in branches/XBL2

WebCore:

2008-07-26 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by David Hyatt.

Bug 20172: [XBL] XBL elements should not be rendered

  • Roll out renderer disabling bits as they were bogus.
  • Add XBL CSS default rules to html4.css.

Test: fast/xbl/xbl-default-rules.xhtml

  • css/html4.css:
  • xbl/XBLDocument.h: (WebCore::XBLDocument::XBLDocument):
  • xbl/XBLElement.h: (WebCore::XBLElement::isXBLElement):

LayoutTest:

2008-07-26 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by David Hyatt.

Test case for bug 20172: [XBL] XBL elements should not be rendered

  • fast/xbl/xbl-default-rules-expected.txt: Added.
  • fast/xbl/xbl-default-rules.xhtml: Added.
11:59 AM Changeset in webkit [35371] by mitz@apple.com
  • 1 edit
    1 move in trunk/LayoutTests

Rubber-stamped by Nikolas Zimmermann.

  • move platform-independent results back to the generic location
  • platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.txt: Removed.
  • svg/dom/SVGRectElement/rect-modify-rx-expected.txt: Copied from LayoutTests/platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.txt.
6:03 AM Changeset in webkit [35370] by Simon Hausmann
  • 3 edits in trunk/WebCore

2008-07-25 Ariya Hidayat <​ariya.hidayat@trolltech.com>

Reviewed by Simon.

Switch off QPainter's anti aliasing when painting the widgets using QStyle
because otherwise the widgets will look blurry and not crisp.

  • platform/qt/RenderThemeQt.cpp: (WebCore::StylePainter::StylePainter): (WebCore::StylePainter::~StylePainter):
  • platform/qt/RenderThemeQt.h:

Jul 25, 2008:

10:18 PM Changeset in webkit [35369] by oliver@apple.com
  • 2 edits in trunk/JavaScriptCore

Whoops, forgot to save style correction.

RS=Cameron Zwarich

8:52 PM Changeset in webkit [35368] by oliver@apple.com
  • 12 edits
    2 adds in trunk

Bug 19718: Named anonymous functions are slow accessing global variables
<​https://bugs.webkit.org/show_bug.cgi?id=19718>

Reviewed by Cameron Zwarich.

To fix this we switch over to an activation-like scope object for
on which we attach the function name property, and add logic to
prevent cross scope assignment to read only properties.

7:28 PM Changeset in webkit [35367] by kevino@webkit.org
  • 2 edits in trunk/JavaScriptCore

On wx/Win, including windows.h in Threading.h causes multiply-defined symbol errors for libjpeg and wx, and also wx needs to include windows.h itself first for wx includes to work right. So until we can find a better solution to this problem on wx, we work around the need to include windows.h here.

5:35 PM Changeset in webkit [35366] by mitz@apple.com
  • 1 edit
    1541 copies
    1 move
    9 adds
    7 deletes in trunk/LayoutTests

Rubber-stamped by Sam Weinig.

  • moved expected results from platform/mac-leopard to platform/mac. Where the mac baseline differed from the Leopard results, moved the results from mac to mac-tiger.
5:34 PM Changeset in webkit [35365] by jmalonzo@webkit.org
  • 2 edits in trunk/WebKitTools

2008-07-25 Jan Michael Alonzo <​jmalonzo@webkit.org>

DRT/Gtk build fix for r35362

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: (LayoutTestController::elementDoesAutoCompleteForElementWithId):
5:00 PM Changeset in webkit [35364] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Anders Carlsson.

  • fix crash due to re-entering purgeInactiveFontData() now that it is called by releaseFontData()

Not testable in DumpRenderTree

  • platform/graphics/FontCache.cpp: (WebCore::FontCache::purgeInactiveFontData): Added a reentry guard.
4:22 PM Changeset in webkit [35363] by beidson@apple.com
  • 1 edit in trunk/WebCore/WebCore.base.exp

Need to check this in, too *sigh*

4:20 PM Changeset in webkit [35362] by beidson@apple.com
  • 10 edits
    2 adds in trunk

WebCore:

2008-07-25 Brady Eidson <​beidson@apple.com>

Reviewed by Sam

Test: security/set-form-autocomplete-attribute.html

Part of the fix for <rdar://problem/6093281> - Improper handling of autocomplete

The autocomplete attribute works on both <form> and <input> elements, but was not
inherited properly when someone asked an <input> if it should autocomplete.

I fixed this up based on the rules in the current WF2 spec so if the <input> element
has its own autocomplete attribute set, it will follow that but otherwise it will
inherit from its parent <form>

  • WebCore.base.exp:
  • html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::init): (WebCore::HTMLInputElement::autoComplete): (WebCore::HTMLInputElement::parseMappedAttribute):
  • html/HTMLInputElement.h: (WebCore::HTMLInputElement::):

WebKitTools:

2008-07-25 Brady Eidson <​beidson@apple.com>

Reviewed by Sam

Add the ability to dump whether-or-not an element should have autocomplete enabled,
from the perspective of the WebKit API

  • DumpRenderTree/LayoutTestController.cpp: (elementDoesAutoCompleteForElementWithIdCallback): (LayoutTestController::staticFunctions):
  • DumpRenderTree/LayoutTestController.h:
  • DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::elementDoesAutoCompleteForElementWithId):
  • DumpRenderTree/win/LayoutTestControllerWin.cpp: (LayoutTestController::elementDoesAutoCompleteForElementWithId): Stub for now until I can get on Windows

LayoutTests:

2008-07-25 Brady Eidson <​beidson@apple.com>

Reviewed by Sam

Test for autocomplete attribute cleanup

  • platform/win/Skipped:
  • security/set-form-autocomplete-attribute-expected.txt: Added.
  • security/set-form-autocomplete-attribute.html: Added.
4:16 PM Changeset in webkit [35361] by jmalonzo@webkit.org
  • 2 edits in trunk/WebCore

2008-07-25 Wouter Bolsterlee <​uws+webkit@xs4all.nl>

Reviewed by Holger Freyther.

​https://bugs.webkit.org/show_bug.cgi?id=20078
[GTK] Use G_* macros instead of deprecated GTK_* macros in gtk2xtbin.h

  • plugins/gtk/gtk2xtbin.h:
4:12 PM Changeset in webkit [35360] by andersca@apple.com
  • 2 edits in trunk/WebCore

2008-07-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Sam.

Add workaround for a Leopard bug which causes webarchive/test-xml-stylesheet.xml to fail.

  • platform/network/mac/WebCoreURLResponse.mm: (-[NSURLResponse _webcore_MIMEType]):
3:43 PM Changeset in webkit [35359] by andersca@apple.com
  • 3 edits
    1 add in trunk/LayoutTests

2008-07-25 Anders Carlsson <​andersca@apple.com>

Reviewed by Mitz.

Make the willCacheResponse test more robust.


  • http/tests/misc/resources/willCacheResponse-success.html: Added.
  • http/tests/misc/willCacheResponse-delegate-callback-expected.txt:
  • http/tests/misc/willCacheResponse-delegate-callback.html:
3:13 PM Changeset in webkit [35358] by hyatt@apple.com
  • 1 add in trunk/LayoutTests/fast/css/variables/alternate-syntax/color-hex-test-expected.txt

Add result for hex color test

2:42 PM Changeset in webkit [35357] by mitz@apple.com
  • 2 edits in trunk/LayoutTests

Reviewed by Anders Carlsson.

  • http/tests/misc/acid3.html: Updated test 77 from acidtests.org. Added alert()ing the log when the score is less than 100.
1:59 PM Changeset in webkit [35356] by mitz@apple.com
  • 1 edit
    9 adds
    2 deletes in trunk/LayoutTests

Rubber-stamped by Brady Eidson.

  • add missing pixel results and move the render tree results under the platform directory
  • platform/mac/svg/dom/SVGRectElement: Added.
  • platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.checksum: Added.
  • platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.png: Added.
  • platform/mac/svg/dom/SVGRectElement/rect-modify-rx-expected.txt: Added.
  • platform/mac/webarchive: Added.
  • platform/mac/webarchive/loading: Added.
  • platform/mac/webarchive/loading/cache-expired-subresource-expected.checksum: Added.
  • platform/mac/webarchive/loading/cache-expired-subresource-expected.png: Added.
  • platform/mac/webarchive/loading/cache-expired-subresource-expected.txt: Added.
  • svg/dom/SVGRectElement/rect-modify-rx-expected.txt: Removed.
  • webarchive/loading/cache-expired-subresource-expected.txt: Removed.
1:35 PM Changeset in webkit [35355] by Chris Fleizach
  • 9 edits
    4 adds in trunk

<rdar://problem/6084806> AX: REGRESSION: returned line number from TextArea is incorrect

1:21 PM Changeset in webkit [35354] by mitz@apple.com
  • 4 edits
    5 adds in trunk

WebCore:

2008-07-25 Jacob Refstrup <​jacob.refstrup@hp.com>

Reviewed by mitz.


Test: fast/block/float/editable-text-overlapping-float.html

  • rendering/RenderBlock.h:
  • rendering/bidi.cpp: (WebCore::RenderBlock::skipTrailingWhitespace):
  • renamed to reflect usage and removed call to position floats; they only get added (WebCore::RenderBlock::skipLeadingWhitespace):
  • renamed to reflect usage (WebCore::RenderBlock::findNextLineBreak):
  • use skipTrailingWhitespace at end of line (as before but with new name)

LayoutTests:

2008-07-25 Jacob Refstrup <​jacob.refstrup@hp.com>

Reviewed by mitz.


  • fast/block/float/editable-text-overlapping-float.html: Added.
  • platform/mac/fast/block/float/editable-text-overlapping-float-expected.checksum: Added.
  • platform/mac/fast/block/float/editable-text-overlapping-float-expected.png: Added.
  • platform/mac/fast/block/float/editable-text-overlapping-float-expected.txt: Added.
  • platform/qt/fast/block/float/editable-text-overlapping-float-expected.txt: Added.
12:27 PM Changeset in webkit [35353] by Adam Roben
  • 2 edits in trunk/WebKitTools

Try to fix the Windows build bot

  • DumpRenderTree/win/DumpRenderTree.vcproj: Don't try to copy files that don't exist for people outside of Apple.
12:10 PM Changeset in webkit [35352] by mitz@apple.com
  • 2 edits in trunk/WebCore

2008-07-25 Dan Bernstein <​mitz@apple.com>

Reviewed by Sam Weinig.

  • platform/graphics/FontCache.cpp: (WebCore::FontDataCacheKeyTraits): Changed needsDestruction to true because FontPlatformData instances hold references to the platform resources and release them in the destructor. (WebCore::cTargetInactiveFontData): Added, replacing cInactiveFontDataPurgeRatio with the number of inactive FontData instances to leave in the cache when automatically purging. (WebCore::FontCache::getCachedFontData): Moved the code that checks if there are too many inactive FontData instances and if so calls purgeInactiveFontData() from here... (WebCore::FontCache::releaseFontData): ... to here. (WebCore::FontCache::purgeInactiveFontData): Added code to also purge the platform font data cache. All FontPlatformData instances that do not have entries in the font data cache are removed, thus releasing the platform resources (such as HFONTs and NSFonts).
11:33 AM Changeset in webkit [35351] by hyatt@apple.com
  • 14 edits
    71 adds in trunk

WebCore:

2008-07-24 David Hyatt <​hyatt@apple.com>

Add support for an alternate syntax for CSS variables. Testers on www-style will be able to try out
both versions of the syntax in WebKit to help us make a decision regarding which one to go with.

Reviewed by Dan

Added fast/css/variables/alternate-syntax/ (duplicated all existing CSS variables tests)

  • css/CSSGrammar.y:
  • css/CSSParser.cpp: (WebCore::CSSParser::createVariablesRule): (WebCore::CSSParser::checkForVariables):
  • css/CSSParser.h:
  • css/CSSParserValues.cpp: (WebCore::CSSParserValue::isVariable): (WebCore::CSSParserValueList::addValue): (WebCore::CSSParserValueList::deleteValueAt): (WebCore::CSSParserValue::createCSSValue):
  • css/CSSParserValues.h:
  • css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::cleanup): (WebCore::CSSPrimitiveValue::getStringValue): (WebCore::CSSPrimitiveValue::cssText): (WebCore::CSSPrimitiveValue::parserValue):
  • css/CSSPrimitiveValue.h: (WebCore::CSSPrimitiveValue::): (WebCore::CSSPrimitiveValue::isVariable):
  • css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::addMatchedDeclaration):
  • css/CSSVariablesRule.cpp: (WebCore::CSSVariablesRule::CSSVariablesRule): (WebCore::CSSVariablesRule::cssText):
  • css/CSSVariablesRule.h: (WebCore::CSSVariablesRule::create):
  • css/maketokenizer:
  • css/tokenizer.flex:

LayoutTests:

2008-07-24 David Hyatt <​hyatt@apple.com>

Add support for an alternate proposed syntax for CSS variables. This alternate syntax will allow
testers on www-style to try out both versions of the syntax (to help make a decision regarding
which one should be used).

Reviewed by Dan

  • fast/css/variables/alternate-syntax: Added.
  • fast/css/variables/alternate-syntax/color-hex-test.html: Added.
  • fast/css/variables/alternate-syntax/colors-test.html: Added.
  • fast/css/variables/alternate-syntax/font-test.html: Added.
  • fast/css/variables/alternate-syntax/image-test.html: Added.
  • fast/css/variables/alternate-syntax/import-test.html: Added.
  • fast/css/variables/alternate-syntax/inline-style-test.html: Added.
  • fast/css/variables/alternate-syntax/invalid-variable-test.html: Added.
  • fast/css/variables/alternate-syntax/margin-test.html: Added.
  • fast/css/variables/alternate-syntax/misplaced-import-test.html: Added.
  • fast/css/variables/alternate-syntax/misplaced-variables-test.html: Added.
  • fast/css/variables/alternate-syntax/multiple-term-test.html: Added.
  • fast/css/variables/alternate-syntax/override-test.html: Added.
  • fast/css/variables/alternate-syntax/print-test.html: Added.
  • fast/css/variables/alternate-syntax/remove-variable-test.html: Added.
  • fast/css/variables/alternate-syntax/resources: Added.
  • fast/css/variables/alternate-syntax/resources/bad.css: Added.
  • fast/css/variables/alternate-syntax/resources/good.css: Added.
  • fast/css/variables/alternate-syntax/resources/listmark.gif: Added.
  • fast/css/variables/alternate-syntax/set-variable-test.html: Added.
  • fast/css/variables/alternate-syntax/shorthand-test.html: Added.
  • fast/css/variables/alternate-syntax/variable-iteration-test.html: Added.
11:30 AM Changeset in webkit [35350] by britto@apple.com
  • 2 edits in trunk/WebCore

2008-07-25 Maxime Britto <​britto@apple.com>

Reviewed by Anders Carlsson.

<rdar://6102387> "REGRESSION: horizontal scroll with the mouse wheel is inverted on some subframes"

  • page/EventHandler.cpp: (WebCore::EventHandler::handleWheelEvent): Inverted the scroll direction relative to the delta value (positive scrolls left,negative scrolls right)
10:46 AM Changeset in webkit [35349] by Adam Roben
  • 2 edits in trunk/WebKit/win

Try to fix the Windows build bot

  • WebKit.vcproj/WebKit.sln: Linearize the project dependencies. Each project now depends only on the project that should immediately precede it in the build. For the frameworks, this order makes sense. For the applications built on top of the frameworks, the order is arbitrary (but roughly follows the applications' complexity).
10:11 AM Changeset in webkit [35348] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-07-25 Adele Peterson <​adele@apple.com>

Another build fix.

  • platform/win/PlatformScrollBarSafari.cpp: (WebCore::PlatformScrollbar::paint):
9:54 AM Changeset in webkit [35347] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-07-25 Adele Peterson <​adele@apple.com>

More build fixes.

  • platform/win/PlatformScrollBarSafari.cpp: (WebCore::PlatformScrollbar::paint):
9:30 AM Changeset in webkit [35346] by adele@apple.com
  • 2 edits in trunk/WebCore

2008-07-25 Adele Peterson <​adele@apple.com>

Build fix.

  • platform/win/PlatformScrollBarSafari.cpp:
8:58 AM Changeset in webkit [35345] by Adam Roben
  • 2 edits in trunk/JavaScriptCore

Windows build fix

  • JavaScriptCore.vcproj/testapi/testapi.vcproj: Add API/ to the include path.
6:11 AM Changeset in webkit [35344] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-07-25 Simon Hausmann <Simon Hausmann>

Fix the build of jsc on Qt/Windows, make sure os-win32 is in the
include search path (added by WebKit.pri).

6:05 AM Changeset in webkit [35343] by Simon Hausmann
  • 2 edits in trunk/WebKit/qt

2008-07-25 Joerg Bornemann <​joerg.bornemann@trolltech.com>

Reviewed by Simon.

Compile with QT_NO_PRINTER.

5:05 AM Changeset in webkit [35342] by ap@webkit.org
  • 4 edits
    13 moves
    1 add in trunk/JavaScriptCore

Reviewed by Simon Hausmann.

Move JavaScriptCore API tests into a subdirectory of their own to avoid header name
conflicts and developer confusion.

  • API/JSNode.c: Removed.
  • API/JSNode.h: Removed.
  • API/JSNodeList.c: Removed.
  • API/JSNodeList.h: Removed.
  • API/Node.c: Removed.
  • API/Node.h: Removed.
  • API/NodeList.c: Removed.
  • API/NodeList.h: Removed.
  • API/minidom.c: Removed.
  • API/minidom.html: Removed.
  • API/minidom.js: Removed.
  • API/testapi.c: Removed.
  • API/testapi.js: Removed.
  • API/tests: Added.
  • API/tests/JSNode.c: Copied from JavaScriptCore/API/JSNode.c.
  • API/tests/JSNode.h: Copied from JavaScriptCore/API/JSNode.h.
  • API/tests/JSNodeList.c: Copied from JavaScriptCore/API/JSNodeList.c.
  • API/tests/JSNodeList.h: Copied from JavaScriptCore/API/JSNodeList.h.
  • API/tests/Node.c: Copied from JavaScriptCore/API/Node.c.
  • API/tests/Node.h: Copied from JavaScriptCore/API/Node.h.
  • API/tests/NodeList.c: Copied from JavaScriptCore/API/NodeList.c.
  • API/tests/NodeList.h: Copied from JavaScriptCore/API/NodeList.h.
  • API/tests/minidom.c: Copied from JavaScriptCore/API/minidom.c.
  • API/tests/minidom.html: Copied from JavaScriptCore/API/minidom.html.
  • API/tests/minidom.js: Copied from JavaScriptCore/API/minidom.js.
  • API/tests/testapi.c: Copied from JavaScriptCore/API/testapi.c.
  • API/tests/testapi.js: Copied from JavaScriptCore/API/testapi.js.
  • GNUmakefile.am:
  • JavaScriptCore.vcproj/testapi/testapi.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
5:05 AM Changeset in webkit [35341] by vestbo@webkit.org
  • 3 edits in trunk/WebCore

2008-07-24 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon

Provide access to the underlying QKeyEvent in PlatformKeyboardEvent.

5:04 AM Changeset in webkit [35340] by vestbo@webkit.org
  • 2 edits in trunk/WebKit/qt

2008-07-24 Tor Arne Vestbø <​tavestbo@trolltech.com>

Reviewed by Simon

Don't insert text on keyDown event in EditorClientQt.

4:43 AM Changeset in webkit [35339] by Simon Hausmann
  • 2 edits in trunk/WebCore

2008-07-25 Simon Hausmann <Simon Hausmann>

Fix linking of QtWebKit against the statically built JavaScriptCore
library, under Windows/Mac we may need _d/_debug suffixes.

4:02 AM Changeset in webkit [35338] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-07-25 Simon Hausmann <Simon Hausmann>

Prospective WX build fix, add JavaScriptCore/API to the include search
path.

3:56 AM Changeset in webkit [35337] by Simon Hausmann
  • 2 edits in trunk/JavaScriptCore

2008-07-25 Simon Hausmann <Simon Hausmann>

Rubber-stamped by Lars.

Fix the build on Windows. operator new for ArgList is implemented using fastMalloc()
but operator delete was not implemented. Unfortunately MSVC decides to call/reference
the function, so a simple implementation using fastFree() fixes the build.

3:55 AM Changeset in webkit [35336] by Simon Hausmann
  • 3 edits in trunk/WebCore

2008-07-25 Simon Hausmann <Simon Hausmann>

Rubber-stamped by Lars.

Fix the Qt build by adapting to the latest ArgList API changes and
replacing the inclusion of npapi.h in MainThreadScheduler with a forward
declaration of NPP to avoid an include conflict. npapi.h on X11 includes
X headers, which include wonderful defines such as "#define Status" that
cause conflicts.

3:55 AM Changeset in webkit [35335] by Simon Hausmann
  • 8 edits
    1 add in trunk

2008-07-25 Simon Hausmann <Simon Hausmann>

Discussed with and rubber-stamped by Lars.

Fix the build system for the Qt port.

Recent JavaScriptCore changes require the addition of JavaScriptCore/API to the
include search path. With a build process that combines JavaScriptCore and
WebCore in one build process/Makefile the existance of
JavaScriptCore/API/Node.h and WebCore/dom/Node.h causes include conflicts.

This commit solves this by introducing a separate build of JavaScriptCore into
a static library.

As a result of the split-up a race-condition due to broken dependencies of
regular source files to header files of generated sources showed up very
frequently when doing parallel builds (which the buildbot does). This commit at
the same time tries to address the dependency problem by making the
addExtraCompiler() function also generate a pseudo extra compiler that
represents the header file output, so that qmake is aware of the creation of
the header file for dependency calculation.

At the same time I removed a lot of cruft from the pro files to ease maintenance.

Jul 24, 2008:

11:40 PM Changeset in webkit [35334] by ggaren@apple.com
  • 3 edits in trunk/JavaScriptCore

2008-07-24 Geoffrey Garen <​ggaren@apple.com>

Reviewed by Maciej Stachowiak.


Fixed a strict aliasing violation, which caused hash tables with floating
point keys not to find items that were indeed in the tables
(intermittently, and only in release builds, of course).


SunSpider reports no change.


This bug doesn't seem to affect any existing code, but it causes obvious
crashes in some new code I'm working on.

  • wtf/HashFunctions.h: (WTF::FloatHash::hash): Use a union when punning between a float / double and an unsigned (bucket of bits). With strict aliasing enabled, unions are the only safe way to do this kind of type punning.
  • wtf/HashTable.h: When rehashing, ASSERT that the item we just added to the table is indeed in the table. In the buggy case described above, this ASSERT fires.
3:57 PM Changeset in webkit [35333] by kevino@webkit.org
  • 4 edits in trunk/WebCore

wx build fix on Win for plugins coode.

2:55 PM Changeset in webkit [35332] by weinig@apple.com
  • 11 edits in trunk/WebCore

2008-07-24 Sam Weinig <​sam@webkit.org>

Reviewed by Anders Carlsson.

Make isElementNode() non-virtual for a speedup on many benchmarks
including 20% on ​http://ejohn.org/apps/fragment/.

  • Replace Node::m_attrWasSpecifiedOrElementHasRareData with bits in Element and Attr where space was available. Use the new free bit to represent if an node is an element or not.
  • dom/Attr.cpp: (WebCore::Attr::Attr):
  • dom/Attr.h: (WebCore::Attr::specified): (WebCore::Attr::setSpecified):
  • dom/ContainerNode.cpp: (WebCore::ContainerNode::ContainerNode):
  • dom/ContainerNode.h:
  • dom/Element.cpp: (WebCore::Element::Element):
  • dom/Element.h: (WebCore::Element::hasRareData): (WebCore::Element::setHasRareData):
  • dom/EventTargetNode.cpp: (WebCore::EventTargetNode::EventTargetNode):
  • dom/EventTargetNode.h:
  • dom/Node.cpp: (WebCore::Node::Node):
  • dom/Node.h: (WebCore::Node::isElementNode):
2:38 PM Changeset in webkit [35331] by mitz@apple.com
  • 2 edits in trunk/WebCore

Reviewed by Dave Hyatt.

  • fix <rdar://problem/6082111> REGRESSION (r31876): Root element with percent height does not resize when resizing the window vertically

Not testable in DumpRenderTree

  • rendering/RenderView.cpp: (WebCore::RenderView::layout): Ensured that all children with percentage heights get laid out again if the height changes.
2:27 PM Changeset in webkit [35330] by kevino@webkit.org
  • 2 edits in trunk/WebCore

Windows build fix for wx. wx doesn't implement pan scrolling yet.

1:38 PM Changeset in webkit [35329] by Adam Roben
  • 2 edits in trunk/WebKitSite

Remove some redundant text accidentally checked in

  • building/tools.html:
1:36 PM Changeset in webkit [35328] by Adam Roben
  • 2 edits in trunk/WebKitSite

Fix a dead link to the Windows Platform SDK and related instructions

Rubberstamped by Alexey Proskuryakov.

  • building/tools.html: Fixed a dead link.
1:24 PM Changeset in webkit [35327] by hyatt@apple.com
  • 2 edits in trunk/WebCore

2008-07-24 David Hyatt <​hyatt@apple.com>

Fix for bug 18673, crash when using full page zoom on generated content. Don't call
intrinsicSizeChanged when we are first setting our style.

Reviewed by olliej

  • ChangeLog:
  • rendering/RenderReplaced.cpp: (WebCore::RenderReplaced::setStyle):
10:34 AM Changeset in webkit [35326] by jchaffraix@webkit.org
  • 9 edits
    5 adds in branches/XBL2

WebKitTools:

2008-07-24 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Ap.

Add XBL detection to run-webkit-test.

  • Scripts/build-drawtest:
  • Scripts/run-drawtest:
  • Scripts/run-webkit-tests: Detect if WebKit was compiled with XBL support and enable or disable XBL test.


  • Scripts/webkitdirs.pm: Renamed checkWebKitSVGSupport to checkWebKitSupportFor taking a string parameter for the standard to test to share the code between SVG and XBL.

LayoutTest:

2008-07-24 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Ap.

  • Add test for bug 19917: [XBL] We need the ability to manage bindings
  • Updated some tests' results.

Note: the 2 updated test in fast/dom will fail when XBL is disabled

because they depend on Element's number of properties. It is
fine for now but it will need to be properly fixed.

  • fast/dom/Window/window-properties-expected.txt: Updated as we have added the 3 new methods to Element.
  • fast/dom/domListEnumeration-expected.txt: Ditto.
  • fast/dom/resources/domListEnumeration.js: Ditto.
  • fast/xbl: Added.
  • fast/xbl/resources: Added.
  • fast/xbl/resources/xbl-empty-binding.xbl: Added.
  • fast/xbl/xbl-ElementXBL-Interface-expected.txt: Added.
  • fast/xbl/xbl-ElementXBL-Interface.html: Added.
7:19 AM Changeset in webkit [35325] by jchaffraix@webkit.org
  • 5 edits
    2 adds in branches/XBL2/WebCore

2008-07-24 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Bug 20029: [XBL] Add more tags

Add <binding> and <template> classes.
Add <div> tag.

The two classes are stubs for the moment.

These tags are required to have a simple XBL example
running.


XBLElement now inherits from StyledElement as <div>
is a placeholder for CSS style information.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/make_names.pl: Add 'generateNameOnly' attribute used for <div> as we do not want to add a specialized class.


  • xbl/XBLBindingElement.h: Added. (WebCore::XBLBindingElement::XBLBindingElement):
  • xbl/XBLElement.h: (WebCore::XBLElement::XBLElement): Now XBLElement inherits from styledElement.
  • xbl/XBLTemplateElement.h: Added. (WebCore::XBLTemplateElement::XBLTemplateElement):
  • xbl/xbltags.in: Add tags.
3:58 AM Changeset in webkit [35324] by jchaffraix@webkit.org
  • 9 edits
    3 adds in branches/XBL2/WebCore

2008-07-24 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Bug 19917: [XBL] We need the ability to manage bindings

  • Move XBLBindingManager from per-document to global.
  • Implement part of ElementXBL interface (to add bindings, remove bindings and check if an element has a binding).
  • GNUmakefile.am: Add compilation information.
  • WebCore.pro: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/Document.cpp: (WebCore::Document::Document): Remove per-document XBLBindingManager instance. (WebCore::Document::~Document): Ditto.
  • dom/Document.h: Ditto.
  • dom/Element.cpp: (WebCore::Element::~Element): Remove associated bindings to avoid leaks. (WebCore::Element::addBinding): Part of ElementXBL interface to manage bindings. (WebCore::Element::removeBinding): Ditto. (WebCore::Element::hasBinding): Ditto.
  • dom/Element.h: Add ElementXBL interface.
  • dom/Element.idl: Ditto.
  • xbl/XBLBinding.h: Added. (WebCore::XBLBinding::XBLBinding): (WebCore::XBLBinding::uri):
  • xbl/XBLBindingManager.cpp: Added. (WebCore::XBLBindingManager::sharedInstance): (WebCore::XBLBindingManager::XBLBindingManager): (WebCore::XBLBindingManager::addBinding): (WebCore::XBLBindingManager::removeBinding): (WebCore::XBLBindingManager::hasBinding): (WebCore::XBLBindingManager::removeAllBindings): Used in Element destructor to remove all the bindings associated with the Element.
  • xbl/XBLBindingManager.h: Added.
3:16 AM Changeset in webkit [35323] by oliver@apple.com
  • 3 edits
    3 adds in trunk

Bug 20142: REGRESSION(r35245): /=/ weirdness
<​https://bugs.webkit.org/show_bug.cgi?id=20142>

Reviewed by Alexey Proskuryakov.

When adding all the meta data needed for exception error messages
I accidentally clobbered the handling of regex beginning with /=.

1:44 AM Changeset in webkit [35322] by jchaffraix@webkit.org
  • 8 edits
    1 add
    1 delete in trunk/WebCore

2008-07-24 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Bug 20053: .in files should use a custom format instead of XML

  • Remove our XML parser perl module (XML::Tiny)
  • Add a custom perl parser
  • Move XML files to the new format
  • bindings/scripts/InFilesParser.pm: Added.
  • bindings/scripts/XMLTiny.pm: Removed.
  • dom/make_names.pl: Switched to our new parser.


  • html/HTMLAttributeNames.in: Switched to our custom format.
  • html/HTMLTagNames.in: Ditto.
  • svg/svgattrs.in: Ditto.
  • svg/svgtags.in: Ditto.
  • svg/xlinkattrs.in: Ditto.
  • xml/xmlattrs.in: Ditto.
12:45 AM Changeset in webkit [35321] by jchaffraix@webkit.org
  • 4 edits
    2 adds in trunk

WebCore:

2008-07-23 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Bug 19588: CRASH doing open() on destroyed window
​https://bugs.webkit.org/show_bug.cgi?id=19588

Add frame's page null check as it could have been
detached from the page.

Test: fast/frames/crash-removed-iframe.html

  • bindings/js/JSDOMWindowBase.cpp: (WebCore::windowProtoFuncOpen):
  • page/FrameTree.cpp: (WebCore::FrameTree::find):

LayoutTest:

2008-07-23 Julien Chaffraix <​jchaffraix@webkit.org>

Reviewed by Eric.

Test for bug 19588: CRASH doing open() on destroyed window
​https://bugs.webkit.org/show_bug.cgi?id=19588

Test case from Eric Roman.

  • fast/frames/crash-removed-iframe-expected.txt: Added.
  • fast/frames/crash-removed-iframe.html: Added.
Note: See TracTimeline for information about the timeline view.